1 2012-06-20 Murray Cumming <murrayc@murrayc.com>
3 Make OnlineGlomProperties be a normal class.
5 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
6 Move OnlineGlomProperties into its own file to be a regular class:
7 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
8 This makes testing simpler.
10 2012-06-15 Murray Cumming <murrayc@murrayc.com>
12 OnlineGlomServiceImpl.init(): Move some code into a new method.
14 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
17 2012-06-15 Murray Cumming <murrayc@murrayc.com>
19 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
21 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
22 OnlineGlomProperties.getKey(): Make this more robust by moving the
23 check for *.*.filename to here.
25 2012-06-15 Murray Cumming <murrayc@murrayc.com>
27 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
29 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
30 init(): Move knowledge of the config file format into the
31 OnlineGlomProperties inner class.
33 2012-06-15 Murray Cumming <murrayc@murrayc.com>
35 SelfHostExampleTest: Make sure we cleanup on failure.
37 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
38 the use of cleanup() to a tearDown() JUnit method.
40 2012-06-12 Murray Cumming <murrayc@murrayc.com>
42 ConfiguredDocument: Add a primary key to portals at least once.
44 * src/main/java/org/glom/web/server/ConfiguredDocument.java
45 updatePortalsExtras): Fix a typo so that we add the primary key
47 This is a fix for the previous commit:
48 ConfiguredDocument: Do not add a primary key to portals each time.
50 2012-06-08 Murray Cumming <murrayc@murrayc.com>
52 SelfHoster: Avoid some compiler warnings.
54 * src/test/java/org/glom/web/server/SelfHoster.java
55 executeCommandLineAndWait():
56 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
57 the now-unused streams for stdout and stderr from the command Processes.
58 These are not used because readln() hangs while waiting for a new line,
59 where there may be no next line. The commented out code is still there
60 to help us figure out how to do this properly.
62 2012-06-08 Murray Cumming <murrayc@murrayc.com>
64 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
66 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
67 Make this actually test the cloning again, though it is not very useful
68 now that we do not use the part that had a problem with cloning before.
70 2012-06-08 Murray Cumming <murrayc@murrayc.com>
72 SelfHoster: Keep trying pg_ctl after starting postgres.
74 * src/test/java/org/glom/web/server/SelfHoster.java
75 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
76 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
77 regular Glom. This seems mad but it seems to work because the first
78 command would fail if pg_ctl would eventually fail.
80 2012-06-08 Murray Cumming <murrayc@murrayc.com>
82 SelfHoster: Wait until the server is really ready.
84 * src/test/java/org/glom/web/server/SelfHoster.java
85 selfHost(): Attempt the connection after starting the server, retrying
86 a few times if necessary, so that the server is really ready already when
87 we return from this method.
88 The regular Glom code does this too because pg_ctl reports success too soon.
90 2012-06-08 Murray Cumming <murrayc@murrayc.com>
92 ConfiguredDocument: Do not add a primary key to portals each time.
94 * src/main/java/org/glom/web/server/ConfiguredDocument.java
95 updatePortalsExtras(): Only add an extra primary key field if there is
96 none, to avoid adding one each time we retrieve the details layout from the
98 This should fix bug #676986 (Ben Konrath)
100 2012-05-25 Murray Cumming <murrayc@murrayc.com>
102 Document.load(): Support version 7 documents.
104 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
105 database_title attribute if the title attribute is not there.
108 2012-05-24 Ben Konrath <ben@bagu.org>
110 Add configuration for auto-generating mvn:i18n from with Eclipse.
112 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
114 2012-05-24 Murray Cumming <murrayc@murrayc.com>
116 Update translations, adding French.
118 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
119 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
120 Add a French translation, using the translation from Glom.
122 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
123 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
124 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
125 Update these based on the translations from Glom.
127 2012-05-24 Murray Cumming <murrayc@murrayc.com>
129 SelfHoster: Add some debug println messages to help when things fail.
131 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
132 System.out.println() lines.
134 2012-05-23 Murray Cumming <murrayc@murrayc.com>
136 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
138 * src/test/java/org/glom/web/server/SelfHoster.java:
139 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
140 instance) instead of just /usr/bin (as on Fedora). Check the result when
143 2012-05-23 Murray Cumming <murrayc@murrayc.com>
145 Remove LayoutItemPortal.get/setNavigationTable().
147 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
148 Remove get/setNavigationTable(), which is only a cache, because it is not
149 used, and does not need to be used, because that decision should be made on
151 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
152 updatePortalsExtras():
153 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
154 getNavigationRecord():
155 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
158 2012-05-21 Murray Cumming <murrayc@murrayc.com>
160 Initial self-hosting for tests.
162 * pom.xml: Change the scope for log4j, to hopefully make it
163 available to the test code which uses it indirectly via jOOQ.
164 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
165 self-hosting, though we only use it for testing.
167 * src/main/java/org/glom/web/server/libglom/Document.java:
168 example rows: Use a map instead of a list for each row of values,
169 so we know what field they are for, instead of relying on the sequence
170 being correct. This is not very efficient, but it does not really need
172 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
173 testReadTableExampleRows(): Adapted.
175 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
176 that returns an Object, for generic use. Note that Object seems to be
177 the implicit base even of double.
178 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
179 for use in CREATE TABLE SQL queries.
180 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
181 to do self-hosting of PostgreSQL databases via its command-line
182 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
183 backends/postgres_self.cc. This is incomplete - it needs more
184 warnings about failures and it needs to clean up properly when things
186 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
187 test of this new class.
189 2012-05-21 Murray Cumming <murrayc@murrayc.com>
191 Document: loading example data: Handle exceptions.
193 * src/main/java/org/glom/web/server/libglom/Document.java:
194 DateFormat.parse() and Double.valueOf() can throw exceptions, though
195 Eclipse did not warn about that.
197 2012-05-20 Murray Cumming <murrayc@murrayc.com>
199 Document: load(), save(): Handle the example rows.
201 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
203 * src/main/java/org/glom/web/server/libglom/Document.java:
204 load(), save(): Load and save the example rows, though the date, time
205 and image types are not handled properly yet.
206 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
207 Add testReadTableExampleRows() just to check that something is read.
209 2012-05-20 Murray Cumming <murrayc@murrayc.com>
211 Document: Add save().
213 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
214 Added getTranslationsMap() for use while saving.
215 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
216 Adedd getUseDefaultFormatting() for use while saving.
217 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
218 and several private methods that it uses.
220 This will be useful while testing via self-hosting.
221 It is not complete, but should be complete enough for testing.
223 2012-05-17 Murray Cumming <murrayc@murrayc.com>
225 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
227 * src/main/java/org/glom/web/client/OnlineGlomService.java
228 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
229 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
230 Remove getSortedListViewData() and getSortedRelatedListData(), adding
231 the sort column index and ascending bool to the regular method.
232 Instead, a sort column index of -1 now means no sort.
233 This is less explicit, but it's fairly simple, reduces the amount of
234 code, and makes the OnlineGlomService API slightly smaller.
235 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
236 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
238 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
239 getListViewData(), getRelatedListData():
240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
241 getListViewData(), getRelatedListData():
242 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
244 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
246 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
251 2012-05-16 Murray Cumming <murrayc@murrayc.com>
253 Use translations for top-level groups too.
255 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
256 updateTitlesForLocale(): Use the translation for the group
257 as well as for child items.
261 Just recompiled to fix a problem in the released .tar.gz file.
265 2012-05-15 Murray Cumming <murrayc@murrayc.com>
267 Corrections to navigation to related records.
269 * src/main/java/org/glom/web/client/OnlineGlomService.java:
270 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
271 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
272 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
273 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
274 relationship name, because the relationship name is not necessarily unique
276 TOOD: This is inefficient, because it passes the whole list of
277 child field items back to the server, but it is more correct, and happens
278 to fix a bug with the primary key being lost after a few navigations.
279 There is probably a chance to make this more efficient anyway in some
282 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
283 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
284 * src/main/java/org/glom/web/server/ConfiguredDocument.java
285 * src/main/java/org/glom/web/server/database/DBAccess.java
286 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
287 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
290 2012-05-15 Murray Cumming <murrayc@murrayc.com>
292 Fix the use of translations.
294 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
295 Add updateTitlesForLocale().
296 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
297 Call it to discard unwanted translations and to make getTitle() return
298 the wanted translation wihout the need for the client code to specify a locale.
299 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
300 getTitle(): Fallback to the original title, as libglom does.
302 2012-05-15 Murray Cumming <murrayc@murrayc.com>
304 Document: Correctly report the number of available translation locales.
306 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
307 the available locale IDs list.
308 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
309 testLocales: Test this.
311 2012-05-15 Murray Cumming <murrayc@murrayc.com>
313 SqlUtils: Use camelCase.
315 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
316 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
317 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
318 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
319 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
320 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
322 2012-05-15 Murray Cumming <murrayc@murrayc.com>
324 Use jOOQ's tableByName() and fieldByName.
326 * pom.xml: Use jOOQ 2.3.1 to get the new API.
327 * src/main/java/org/glom/web/server/SqlUtils.java:
328 build_sql_select_step_with_where_clause(), .createField(),
329 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
330 so we can get correct quoting and escaping. Thanks to Lukas Eder for
331 adding this, and other things, to jOOQ.
333 2012-05-15 Murray Cumming <murrayc@murrayc.com>
335 SqlUtils: Remove the Connection parameters.
337 * src/main/java/org/glom/web/server/SqlUtils.java:
338 build_sql_select_with_key(), build_sql_select_with_where_clause(),
339 createSelect(), build_sql_select_step_with_where_clause(),
340 build_sql_count_select_with_where_clause(),
341 build_sql_select_count_rows(): Remove the Connection parameter because
342 jOOQ does not actually need a connectionwhen it is just used to build
344 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
346 * src/main/java/org/glom/web/server/ReportGenerator.java:
348 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
350 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
351 Constructor, getListData(), getResultSizeOfSQLQuery():
352 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
353 getSelectQuery(), getCountQuery():
354 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
355 getSelectQuery(), getCountQuery():
356 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
357 getNavigationRecord(): Adapted.
359 2012-05-14 Murray Cumming <murrayc@murrayc.com>
363 * src/main/java/org/glom/web/server/SqlUtils.java:
364 get_find_where_clause_quick(): Use a comparison of
365 lowercase values, instead of a simple equals. Regular Glom
366 uses the PostgreSQL ILIKE operator but jOOQ does not
367 support that just yet, though it will soon.
369 2012-05-14 Murray Cumming <murrayc@murrayc.com>
371 TableToViewDetails: Use a real serialization ID.
373 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
374 Though this does not fix the serialization problem.
376 2012-05-12 Murray Cumming <murrayc@murrayc.com>
378 Added LayoutItemPortalDeepCloneTest.
380 2012-05-11 Murray Cumming <murrayc@murrayc.com>
382 Make navigation work again.
384 * src/main/java/org/glom/web/server/libglom/Document.java:
385 Add getLayoutItemFieldShouldHaveNavigation().
386 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
387 Replace get/setAddNavigation() with the partly-existing
388 get/setNavigationTableName(), with an empty string being no navigation,
389 because this is simpler. Use the new
390 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
392 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
393 Add updateFieldsExtras() and call setNavigationTableName in it.
394 getDetailsLayoutGroup(),
395 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
396 createLayout(): Adapted.
397 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
398 Constructor: Adapted.
400 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
401 Replace get/setAddNavigation() with get/setNavigation(), returning a
402 TableToViewDetails class with both the table name and UsesRelationship,
403 because both are need. The previous code used java-libglom's output
404 variable (strangely, via sharedptr) to return both, but we cannot really
406 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
407 getNavigationRecord(): Adapt. However, we cannot actually use the cache
408 here because it somehow gets set to null during deepCopy(). I must test this.
409 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
410 testGetSuitableTableToViewDetails(): Adapted.
412 TODO: Find out why deepClone() is not quite working.
414 2012-05-11 Murray Cumming <murrayc@murrayc.com>
416 DBAccess: Simplify the retrievel of full field details.
418 * src/main/java/org/glom/web/server/database/DBAccess.java
419 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
420 because the Document loading should have done this.
422 2012-05-11 Murray Cumming <murrayc@murrayc.com>
424 Document: Correct loading of doubly-related layout fields.
426 * src/main/java/org/glom/web/server/libglom/Document.java:
427 loadUsesRelationship(): Actually set the related relationship, instead
428 of only setting it if it's not found.
430 2012-05-09 Murray Cumming <murrayc@murrayc.com>
432 Replace all appearances of Colour with color.
434 Because US English is dominant.
436 2012-05-09 Murray Cumming <murrayc@murrayc.com>
438 Use colors in HTML format, solving a warning about an unused function.
440 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
441 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
442 Add *asHTMLColor() versions of methods.
443 TODO: However, we should create and cache the results on the server.
444 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
445 * src/main/java/org/glom/web/client/ui/list/ListTable.java
446 * src/main/java/org/glom/web/server/ConfiguredDocument.java
447 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
448 Use the asHTMLcolor() versions.
450 2012-05-09 Murray Cumming <murrayc@murrayc.com>
452 ListViewTable: Constructor: Take the table name as a parameter.
454 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
455 Constructor: Take the tableName, and set the member variable, because
457 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
458 setCellTable(): Pass the table name.
459 This makes navigation to non-default tables work again. I don't know
460 why it worked before in the master branch.
462 2012-05-07 Murray Cumming <murrayc@murrayc.com>
464 ConfiguredDocument: Restore correct addition of hidden primary key items.
466 * src/main/java/org/glom/web/client/ui/list/ListTable.java
467 (ListTable.createCellTable): Uncomment out the check for the hidden
469 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
470 add primary key items for top-level lists and portals, as before,
471 instead of adding them to each group.
472 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
473 Actually implement the extra methods such as setHiddenPrimaryKey() and
474 comment that these are used only for top-level list groups and in portals.
475 This strangeness suggests even more that this should not be squeezed
476 into the LayoutGroup class.
478 2012-05-07 Murray Cumming <murrayc@murrayc.com>
480 Fix Formatting loading.
482 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
483 getFormattingUsed(): Remove the duplicate Formatting member variable
484 in favour of the one from the base class.
485 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
486 Initialize a new Formatting instead of using null by default, so we
487 have some defaults, instead of having to initialize one later just to
488 get the same defaults. This also makes loading of formatting from the
489 document work, because that expected a non-null.
491 2012-05-07 Murray Cumming <murrayc@murrayc.com>
493 RelatedListTable: Make sure that the tableName is set.
495 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
496 Constructor: Take the tableName so it is available later. Otherwise,
497 the server assumes that we mean the default table and cannot find the
499 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
500 setData(): Pass the tableName to the RelatedListTable constructor.
502 2012-05-07 Murray Cumming <murrayc@murrayc.com>
506 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
507 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
508 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
510 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
512 * src/main/java/org/glom/web/server/database/DBAccess.java:
513 convertResultSetToDTO(), getPortal():
514 * src/main/java/org/glom/web/server/database/ListDBAccess.java
516 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
517 Add checks for null objects and out of range access, with log messages to
518 give hints so we can fix these properly.
520 2012-05-07 Murray Cumming <murrayc@murrayc.com>
522 Portals: some corrections.
524 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
526 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
527 constructor: Use getRelationshipNameUsed() instead of getName(), because
528 that is what is meant.
529 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
530 getFromField(): Fix a typo, to get the field name, not the table name.
531 * src/main/java/org/glom/web/server/database/DBAccess.java:
532 getPortal(): Fix a typo that stopped this from working.
534 2012-05-07 Murray Cumming <murrayc@murrayc.com>
536 LayoutItemPortal: Also override getTitleOriginal().
538 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
539 This lets the base getTitle() with no parameters work.
540 TODO: Test this properly.
542 2012-05-06 Murray Cumming <murrayc@murrayc.com>
544 LayoutItemPortal: getTitle*(): Use the relationship title.
546 2012-05-06 Murray Cumming <murrayc@murrayc.com>
548 LayoutItemField: Fix loading of custom titles.
550 * src/main/java/org/glom/web/server/libglom/Document.java
551 loadDataLayoutItemField(): The title, if any, instead of the field
552 title, is stored in a title_custom node. Load it from there.
553 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
555 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
556 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
557 getTitle*() overrides.
558 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
561 2012-05-06 Murray Cumming <murrayc@murrayc.com>
563 LayoutItemField: Fall back to field titles, so some are really shown.
565 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
566 Override getTitleOriginal() and getTitle(), as in java-libglom.
567 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
570 2012-05-06 Murray Cumming <murrayc@murrayc.com>
572 Correct use of setExpectedResultSize().
574 * src/main/java/org/glom/web/server/ConfiguredDocument.java
575 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
576 Use setExpectedResultSize only on top-level groups (for instance, the
577 list layout) or on child portals (in details views).
578 Use the correct table name for portals to avoid SQL errors.
579 Update the expected counts when returning cached layouts.
581 2012-05-06 Murray Cumming <murrayc@murrayc.com>
583 Document: Interpret no group column count as 1.
585 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
586 default, though we now check for this in the UI code anyway.
588 2012-05-06 Murray Cumming <murrayc@murrayc.com>
592 2012-05-06 Murray Cumming <murrayc@murrayc.com>
594 Translatable: Use Hashmap instead of Treemap because GWT supports it.
596 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
597 The use of Treemap lead to this error from async methods, with no
599 "The response could not be deserialized"
601 2012-05-06 Murray Cumming <murrayc@murrayc.com>
603 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
605 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
606 when using the Google -> GWT Compile, or
607 g toolbar button -> GWT Compile Project... feature in Eclipse.
609 2012-05-06 Murray Cumming <murrayc@murrayc.com>
611 ListTable.addColumn(): Protect against a null Formatting.
613 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
614 Create a default Formatting if it is null, because that is the simplest
617 2012-05-06 Murray Cumming <murrayc@murrayc.com>
619 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
621 * src/main/java/org/glom/web/server/ConfiguredDocument.java
622 updateLayoutGroup(): Check that the field is not null.
624 2012-05-06 Murray Cumming <murrayc@murrayc.com>
626 ListViewImpl: Protected against a bad cast error.
628 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
629 onEnterKeyDown(): Do not cast without an instanceof check.
631 2012-05-06 Murray Cumming <murrayc@murrayc.com>
633 ListTable: Protect against an out of range error.
635 * src/main/java/org/glom/web/client/ui/list/ListTable.java
636 createCellTable(): This is unlikely, but can happen while debugging.
638 2012-05-06 Murray Cumming <murrayc@murrayc.com>
640 AsyncMessage onFailure() callbacks: Log the exception message.
642 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
643 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
644 * src/main/java/org/glom/web/client/activity/ListActivity.java:
645 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
646 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
647 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
648 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
649 These are useful clues when something is wrong.
651 2012-05-06 Murray Cumming <murrayc@murrayc.com>
653 ConfiguredDocument: Avoid a null dereference.
655 * src/main/java/org/glom/web/server/ConfiguredDocument.java
656 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
657 details maps are created.
659 2012-05-06 Murray Cumming <murrayc@murrayc.com>
661 Document: Correct the port number parsing.
663 * src/main/java/org/glom/web/server/libglom/Document.java:
664 This lets us actually connect to the database and show the document.
666 2012-05-05 Murray Cumming <murrayc@murrayc.com>
670 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
671 user-interaction, asking us to load a temporary URL in a browser.s
672 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
673 which is apparently necessary for testing the service. See the comment.
674 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
675 Show the exception, if any. This is how I saw the 404 in the HTML in
678 2012-05-05 Murray Cumming <murrayc@murrayc.com>
680 DocumentTest: Move the .glom files into the resources directory.
682 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
683 URI via getResource().
685 2012-05-05 Murray Cumming <murrayc@murrayc.com>
687 Document: Remove the FieldIdentifies inner class.
689 * src/main/java/org/glom/web/server/libglom/Document.java: We only
690 use the Relationship (though the same function in libglom is maybe
691 used in other ways) and so this removes a compiler warning.
693 2012-05-05 Murray Cumming <murrayc@murrayc.com>
695 Document.load() Remove the error code parameter.
697 * src/main/java/org/glom/web/server/libglom/Document.java: load():
698 Remove the parameter. We do not set it yet and it could never have
699 worked as an output parameter (though maybe it did in java-libglom).
700 We could use an exception if we really want the failure reason.
701 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
703 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
704 setUp(), testGetSuitableTableToViewDetails(): Adapt.
706 2012-05-05 Murray Cumming <murrayc@murrayc.com>
708 Make some inner classes static.
710 * src/main/java/org/glom/web/server/ConfiguredDocument.java
711 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
712 * src/main/java/org/glom/web/server/ReportGenerator.java
713 * src/main/java/org/glom/web/server/libglom/Document.java
714 Make all inner classes static that can be static.
716 2012-05-05 Murray Cumming <murrayc@murrayc.com>
718 OnlineGlomServiceImpl: Do not load and check for java-libglom.
720 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
721 init(): We do not use java-libglom any more.
723 2012-05-05 Murray Cumming <murrayc@murrayc.com>
725 Remove mentions of java-libglom.
727 * README: Remove mention of java-libglom, because it no longer needed.
728 * utils/build-onlineglom-war.sh:
729 * utils/check-and-recover-tomcat.py:
730 * utils/install-onlineglom-war.sh: Remove these as they are no longer
731 useful. Building is now far easier, with no need for jhbuild.
733 2012-05-05 Murray Cumming <murrayc@murrayc.com>
735 Fix the build (mvn package)
737 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
738 (LayoutGroup): Make the LayoutItemList inner class static and protected.
739 Otherwise the GWT Java->Javascript compilation fails with just this
740 error, during mvn package or when attempting to view in a browser,
741 in the GWT developer mode in Eclipse.
743 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
744 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
745 [INFO] Compiling module org.glom.web.OnlineGlom
746 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
747 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
748 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
749 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
750 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
751 [INFO] [ERROR] Cannot proceed due to previous errors
753 It has taken me 2 days to find out what was causing that. After reducing
754 the code, the compiler eventually showed me the full error message.
756 2012-05-04 Murray Cumming <murrayc@murrayc.com>
758 ConfiguredDocument: Cache the cloned and stripped layouts.
760 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
761 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
762 layout in a map, so we can retrieve it again without rebuilding it.
764 2012-05-04 Murray Cumming <murrayc@murrayc.com>
766 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
768 2012-05-04 Murray Cumming <murrayc@murrayc.com>
770 libglom classes: Implement some auto-generated emthods.
772 2012-05-04 Murray Cumming <murrayc@murrayc.com>
774 Add GwtTestOnlineGlomService.
776 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
777 However, this (and the other GwtTest*) does not seem to run during
780 2012-05-04 Murray Cumming <murrayc@murrayc.com>
782 Remove use of unsupported features from client code.
784 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
785 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
786 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
787 Use our client version of StringUtils instead of the apache commons one.
789 However, the GWT Javascript compliation still fails.
791 2012-04-25 Murray Cumming <murrayc@murrayc.com>
793 Add a Field class and implement some loading of it in Document.
795 2012-04-25 Murray Cumming <murrayc@murrayc.com>
797 Initial Document loading implementation, instead of libglom.
799 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
800 and Translatable classes, and adapt the rest of the code to use them.
801 However, this is still missing Layout and Field classes and loading.
803 2012-04-24 Murray Cumming <murrayc@murrayc.com>
805 Use of jOOQ: Move Field creation into a utility method.
807 * src/main/java/org/glom/web/server/SqlUtils.java:
808 This lets us improve it more easily.
810 2012-04-24 Murray Cumming <murrayc@murrayc.com>
812 Use of jOOQ: Improve the code to COUNT a sub-select.
814 * src/main/java/org/glom/web/server/SqlUtils.java:
815 Move initial query creation into
816 build_sql_select_step_with_where_clause().
817 build_sql_select_count_rows(): Use the jOOQ API instead of
818 concatentating text, because a jOOQ Select*Step is a TableLike,
819 which is what from() takes.
821 2012-04-23 Murray Cumming <murrayc@murrayc.com>
823 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
825 * pom.xml: Depend on jooq.
826 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
827 methods with jOOQ, based on the C++ implementations in libglom,
828 with some changes to the logic required by jooQ.
829 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
831 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
832 * src/main/java/org/glom/web/server/ReportGenerator.java:
833 * src/main/java/org/glom/web/server/SqlUtils.java:
834 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
835 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
836 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
837 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
838 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
839 Adapt. In particular, the SqlUtils methods now need to take a Connection,
840 because jOOQ needs that, though it seems unnecessary.
842 This is not quite finished. Ideally jOOQ would help us to build
843 table_name.field_name names, quoting and escaping them properly.
844 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
846 2012-04-21 Murray Cumming <murrayc@murrayc.com>
848 Move use of Glom.build_sql*() into a new SqlUtils class.
850 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
851 to wrap Glom.build_sql*(). The parameter types are still Glom one,
852 but this will make it easier to start using something other than
853 libglom or SqlBuilder.
855 2012-04-21 Murray Cumming <murrayc@murrayc.com>
857 Update the project URL.
859 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
861 2012-04-21 Murray Cumming <murrayc@murrayc.com>
863 Main layout: Use a FlowTable instead of absolute positioning.
865 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
866 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
867 child panels/widgets must have an absolute position. But that is annoying, so
868 this adds a FlowTable and puts the child panels in there.
870 2012-04-21 Murray Cumming <murrayc@murrayc.com>
872 GwtTestOnlineGlom: Comment out unused code.
874 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
875 Eclipse has started to say that some code is unused.
877 2012-04-21 Murray Cumming <murrayc@murrayc.com>
879 Update to the latest versions of dependencies.
881 * pom.xml: Update version numbers of dependencies to the latest
883 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
885 * src/main/java/org/glom/web/server/ReportGenerator.java:
886 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
887 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
888 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
890 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
891 Modify the imports where necessary.
893 2012-04-17 Murray Cumming <murrayc@murrayc.com>
895 Style: Remove overflow:hidden from searchbox
897 * src/main/webapp/style.css: Because this pushes the Back To Link
898 label/link on to the next row, which is then hidden due to the
899 hard-coded (in ems) height.
901 2012-04-20 Murray Cumming <murrayc@murrayc.com>
903 Remove some duplicate code.
905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
906 getDocumentInfo(): This must have been duplicated during the merge from the
911 2012-04-19 Murray Cumming <murrayc@murrayc.com>
913 Reports: Localize the waiting for report message.
915 * src/main/java/org/glom/web/client/activity/ReportActivity.java
916 start(): Get the message from the contants.
917 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
919 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
920 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
921 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
922 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
923 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
924 Update these files with the English text for newer strings for now.
926 2012-04-19 Murray Cumming <murrayc@murrayc.com>
928 Reports: Show a message while waiting for the report.
930 * src/main/java/org/glom/web/client/ui/ReportView.java
931 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
932 Add setWaitingText(), to show a message saying that we are
933 waiting for the report to be ready.
934 * src/main/java/org/glom/web/client/activity/ReportActivity.java
935 start(): Call setWaitingText() before calling the async
938 2012-04-19 Murray Cumming <murrayc@murrayc.com>
940 ReportGenerator: Specify date and time formats.
942 * src/main/java/org/glom/web/server/ReportGenerator.java:
943 createFieldValueElement(): Use the default (and localized)
944 short formats, though we still need a way to show 4-digit
945 years without providing the format for every locale.
946 * src/main/java/org/glom/web/server/database/DBAccess.java:
947 convertResultSetToDTO(): Use the short formats here too.
949 2012-04-18 Murray Cumming <murrayc@murrayc.com>
951 ReportGenerator: Use the correct numeric formatting.
953 * src/main/java/org/glom/web/server/ReportGenerator.java
954 createFieldExpression(), createFieldValueElement(): Take the
955 whole LayoutItem_Field instead of just the field name, so
956 we have access to the formatting.
957 createFieldValueElement(): Use JRTextField.setPattern() to
958 specify the numeric formatting, with the help of a
959 regular DecimalFormat.
961 2012-04-18 Murray Cumming <murrayc@murrayc.com>
963 ReportGenerator: Avoid showing null for group by titles.
965 * src/main/java/org/glom/web/server/ReportGenerator.java
966 generateReport(): Use setBlankWhenNull() on the field title
967 style too, because this is used for values in group by
970 2012-04-18 Murray Cumming <murrayc@murrayc.com>
972 ReportGenerator: Add a colon to titles in vertical groups.
974 * src/main/java/org/glom/web/server/ReportGenerator.java
975 addFieldToDetailBandVertical(): Pass true for the withColon
978 2012-04-18 Murray Cumming <murrayc@murrayc.com>
980 ReportGenerator: Simplify the code by using Position more.
982 2012-04-18 Murray Cumming <murrayc@murrayc.com>
984 Reports: Support vertical groups, roughly.
986 * src/main/java/org/glom/web/server/ReportGenerator.java:
987 addToReport(): Rename to addGroupToReport() and, if necessary,
988 call the new addVerticalGroupToReport() method.
989 createFieldValueElement(): Let the caller specify the Y position
992 2012-04-17 Murray Cumming <murrayc@murrayc.com>
994 Reports: Allow a second report to be shown.
996 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
997 clear(): Do not remove the HTML widget, which broke the whole layout.
999 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1001 Locales drop-down: Show that we use English by default.
1003 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1004 fillView(): When we use English, just because that is the default, when
1005 no locale is specified, show that in the Locales drop-down instead of
1006 just showing the first item.
1008 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1010 Unselect the Report/Locale/Table combo item when appropriate.
1012 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1013 setPlace(): clear reportName if this is not a ReportPlace.
1014 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1015 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1016 When the provided name is empty, unselect all items, so that none are
1017 indicated. This uses a for loop because I cannot find a single method
1020 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1022 Report: Give the user a way to get back to the list.
1024 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1025 start(), setPlace(): Show the Back To List link on reports, and also
1026 interpret selecting the empty report item as back to list.
1028 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1030 Really show the selected Report name.
1032 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1033 setPlace(): Store the reportName here, if it is that kind of Place.
1034 fillView(): Set the selected Report after filling the list of reports.
1035 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1036 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1037 null Strings, though we need some way to unselect all ListBox items
1040 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1042 ReportGenerator: Try to avoid some problems.
1044 * src/main/java/org/glom/web/server/ReportGenerator.java
1045 addField(): Try to avoid duplicates, and avoid using a null
1048 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1050 Reports: Use quickFind.
1052 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1053 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1054 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1055 getReportHTML(): Add a quickFind parameter.
1056 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1057 start(): Pass the quickFind parameter.
1058 * src/main/java/org/glom/web/server/ReportGenerator.java
1059 generateReport(): Take a quickFind parameter.
1061 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1063 ReportPlace: Actually use the report name.
1065 * src/main/java/org/glom/web/client/place/ReportPlace.java
1066 getPlace(): Do not assign the report name to the quickfind.
1068 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1070 Show java.library.path when complaining.
1072 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1073 init(): When telling us to check java.library.path, show the
1076 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1078 ReportGenerator: Do not show nulls.
1080 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1082 ReportGenerator: Make the title font larger.
1084 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1086 ReportGenerator: Put field titles inside groups, if there are groups.
1088 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1090 ReportGenerator: Take the Report itself instead of the name and group.
1092 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1093 Remove getReportLayoutGroup().
1094 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1095 getReportHTML(): Pass the report instead
1096 of its name and layout group.
1097 * src/main/java/org/glom/web/server/ReportGenerator.java
1098 generateReport(): Use the report object to use the title
1099 instead of the name.
1101 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1103 ReportGenerator: Remove designBand parameters.
1105 * src/main/java/org/glom/web/server/ReportGenerator.java:
1106 Make designBand a class member instead of passing it to all
1109 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1111 ReportGenerator: Add lines, a bit like in the desktop version.
1113 * src/main/java/org/glom/web/server/ReportGenerator.java
1114 addToReport(): Use JRDesignLine.
1116 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1118 ReportGenerator: Correct the title positions and use some bold style.
1120 * src/main/java/org/glom/web/server/ReportGenerator.java:
1121 Break the code up into reusable functions, correct the placement of
1122 titles, and use normal/bold styles as in the reports in the desktop
1125 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1127 ReportGenerator: Add a header band to show the field titles.
1129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1130 getReportHTML(): Pass the localeId to the ReportGenerator
1132 * src/main/java/org/glom/web/server/ReportGenerator.java
1133 constructor: Take the localeID so we can get translated field
1135 generateReport(), addToReport(), addFieldToBand(): Add field
1136 titles in a column header band.
1138 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1140 Reports drop-down list: Some improvement.
1142 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1143 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1144 Adedd setSelectedReport(),
1145 setReportList(): Add a blank line so that the user can select the
1147 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1148 start(): Show the current report by calling setSelectedReport().
1149 This does not seem to work yet.
1151 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1153 DetailsActivity, ListActivity: Move some variables into a base class.
1155 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1156 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1157 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1158 the clientFactory, documentID, tableName and authenticationPopup into
1159 a base class, to avoid duplication.
1161 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1163 Translate the Reports label.
1165 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1166 Get the "Reports" label string from the constants.
1167 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1168 perties: Add Reports to the constants.
1170 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1172 Reports: Implement grouping.
1174 * src/main/java/org/glom/web/server/ReportGenerator.java:
1175 Handle LayoutItem_GroupBy items and try to do the right thing
1176 with JRDesignGroup. It seems to work.
1178 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1180 Actually show some data with JasperReports.
1182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1183 getReportHTML(): Move most code into a ReportGenerator class.
1184 * src/main/java/org/glom/web/server/ReportGenerator.java:
1185 Recurse into sub-groups, adding fields to the JasperDesign's details
1186 band. Note that we must set an arbitrary width and height, or it just
1187 will not show any data.
1189 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1191 Reports Chooser: Show the titles, not the names.
1193 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1194 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1195 and the names as the values.
1196 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1197 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1198 group now that we provide the report name, so it should always
1201 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1203 Depend on jasperreports.
1205 * pom.xml: Add the dependency. My plan is to use this on the
1208 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1210 Implement navigation to report places.
1212 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1213 start(): Do not bother to handle all events here.
1214 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1215 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1216 Added getSelectedReport().
1217 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1218 .java: start(): When handling a change to the reports chooser,
1219 call getSelectedReport() and goTo() its ReportPlace.
1220 * src/main/java/org/glom/web/client/ui/ReportView.java
1221 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1222 Added setReportHTML() which puts the html in a gwt HTML widget.
1223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1224 getReportHTML(): Return "TODO" just to show that this works.
1226 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1228 Make ReportPlace usable.
1230 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1231 Mention ReportPlace.
1232 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1233 Correct the @prefix annotation.
1235 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1237 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1239 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1240 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1241 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1242 Change getReportLayout() to getReportHMTL() because we will not need to
1243 parse or render the report layout on the client side.
1244 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1245 getReportLayout(): Return the libglom LayoutGroup type because we will
1246 not need to convert to a shared type, because this will not be used on
1248 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1251 Note that there is still no implementation for this.
1254 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1256 Add a (empty) Report Place, View, and Activity.
1258 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1260 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1261 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1262 this into a superclass:
1263 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1264 and also use it as the base of this new ReportPlace:
1265 * src/main/java/org/glom/web/client/place/ReportPlace.java
1267 * src/main/java/org/glom/web/client/ui/ReportView.java
1268 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1269 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1270 Add these, containing mostly boiler-plate for now.
1272 * src/main/java/org/glom/web/client/OnlineGlomService.java
1273 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1274 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1275 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1276 Add API to get the LayoutGroup for the report.
1278 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1280 Add and fill a Reports drop-down list box.
1282 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1284 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1285 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1286 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1287 Added getReports(document, table, localeID), calling
1288 ConfiguredDocument.getReports().
1289 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1290 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1291 Added setReportsList() and a list widget.
1292 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1293 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1298 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1300 Translations: Add Esperanto.
1302 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1303 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1304 properties: Add this translation because someone took the time to make it.
1306 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1308 Adapt to the java-libglom 1.21.7 API.
1310 * src/main/java/org/glom/web/server/ReportGenerator.java:
1311 addToReport(): get_group_secondary_fields() is now
1312 get_secondary_fields().
1315 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1317 Use the latest java-libglom version.
1319 * pom.xml: Use java-libglom 1.21.7.
1321 2012-03-03 Ben Konrath <ben@bagu.org>
1323 Display date and time in details view.
1325 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1327 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1329 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1331 Require the latest java-libglom.
1333 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1335 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1337 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1339 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1340 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1341 an empty quickfind string. I also corrected libglom to create only
1342 empty where clauses for empty quickfind strings, but this avoids the
1345 2012-02-24 Ben Konrath <ben@bagu.org>
1347 Improve the tabs in the Notebook widget.
1351 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1353 Translations: Try to translate the strings.
1355 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1356 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1357 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1358 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1359 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1360 Take the Open translation from GTK+'s .po files.
1361 Take the Details translation from Glom's po files.
1362 I have added the other strings to Glom so we can get translations that way:
1363 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1365 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1367 TableSelectionViewImpl: Put the search label and entry in a div.
1369 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1370 Put the search widgets in a FlowTable so that the CSS can be used to
1371 style them while keeping them together.
1372 * src/main/webapp/style.css: Mention the new div.
1374 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1376 Translate more strings in more locales.
1378 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1379 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1380 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1381 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1382 Translate the "Details" and "Open" string too.
1384 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1385 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1386 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1387 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1388 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1389 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1390 Add these new locales as placeholders though they currently contain English.
1392 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1394 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1396 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1397 Check the ConfiguredDocument* for null before using it.
1399 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1401 Tell Eclipse about the generated java files.
1403 * .classpath: This lets it find OnlineGlomConstants.java.
1404 It would be nice if Eclipse just used the maven build files.
1406 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1408 Prevent a crash when no locale is specified in the URL.
1410 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1411 Avoid returning a null string, obtained from
1412 Window.Location.getParameter(). This caused a crash when it was
1413 later passed to libglom's API.
1414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1415 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1416 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1417 guard against future null strings.
1419 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1421 Use the ?locale= query param instead of the &lang= token param.
1423 * src/main/java/org/glom/web/client/place/ListPlace.java
1424 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1425 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1426 Remove the lang token key and value.
1428 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1429 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1430 When the user selects a different locale from the chooser, use
1431 Window.Location.assign() to change the URL, which then causes a reload.
1433 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1434 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1435 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1436 * src/main/java/org/glom/web/client/activity/ListActivity.java
1437 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1438 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1439 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1440 * src/main/java/org/glom/web/client/ui/ListView.java:
1441 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1443 Remove localeID member variables and method/constructor parameters, instead
1444 using Utils.getCurrentLocaleID() when we need a localID to pass to
1447 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1449 Internationalize the UI strings.
1451 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1452 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1453 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1454 because it is unused. Messages are apparently strings that can have
1455 parameters, but we do not need that yet, so Contants will be enough for now.
1456 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1457 to say that we support the en and de locales.
1458 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1459 The original English strings.
1460 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1461 Some German translations of the English strings.
1462 The i18n goal then uses the .properties file to generate an
1463 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1464 returns an implementation that returns the translated strings.
1465 The documentation suggests putting these in src/java/*/client/, but it seems
1466 best to put it in src/resources/*/client/.
1467 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1468 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1469 instead of hard-coding them.
1470 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1471 but that does not seem to stop the build, though it confuses Eclipse.
1473 You can see the translated string by adding ?locale=de to the URL, like so:
1474 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1476 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1478 Improve null/empty String checks.
1480 * pom.xml: Add a dependency on commons-lang, to use
1481 org.apache.commons.lang.StringUtils.
1482 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1483 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1484 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1485 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1486 Use StringUtils.isEmpty().
1488 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1489 StringUtils class with a static isEmpty() function because we
1490 cannot use org.apache.commons.lang.StringUtils in client-side
1491 GWT code because it (apparently) cannot be compiled to javascript.
1492 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1493 * src/main/java/org/glom/web/client/activity/ListActivity.java
1494 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1495 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1496 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1497 * src/main/java/org/glom/web/client/place/ListPlace.java
1498 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1499 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1500 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1501 * src/main/java/org/glom/web/client/ui/details/Group.java
1502 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1503 our StringUtils.isEmpty() function.
1505 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1507 Update to the latest java-libglom API.
1509 * pom.xml: Require java-libglom 1.21.4.
1510 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1511 getDocumentInfo(), getListViewLayoutGroup():
1512 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1514 * src/main/java/org/glom/web/server/database/DBAccess.java
1515 getFieldsToShowForSQLQueryAddGroup(),
1516 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1517 with either get_database_title_original() or
1518 get_database_title(localeID).
1520 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1522 ConfiguredDocument: Avoid a null pointer exception.
1524 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1525 Initialize localeID to "" to avoid returning a null String which
1526 causes a crash in java-libglom's swing-generated code.
1528 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1530 Some simple renaming.
1532 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1533 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1534 for localeChooser. This seems more appropriate and is less ambiguous
1535 particularly in the .css file.
1537 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1539 ConfiguredDocument: Rename the localedID private member variable.
1541 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1543 Adapt to the latest java-libglom API from git master.
1545 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1546 libglom now uses only Vector instead of List, which uses add() instead of
1549 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1551 ConfiguredDocument: Rename the localedID private member variable.
1553 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1555 Build a source tarball with mvn assembly:single
1557 * assembly.xml: Add this file.
1558 * pom.xml: Use the maven-assembly-plugin and tell it to use
1559 our assembly.xml file.
1561 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1563 OnlineGlomServiceImpl: Get .glom files recursively.
1565 * pom.xml: Depend on commons-io from org.apache.commons.
1566 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1567 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1568 files recursively, and with the easier filter for the extension.
1569 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1570 simplify that code too.
1572 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1574 README: Mention that you must install java-libglom packages separately.
1576 But then it works, because java-libglom is now in the central maven
1579 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1581 locales drop-down: Show the correct selected locale when the URL changes.
1583 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1584 .java: setPlace(): Move some code into fillView().
1586 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1588 locales drop-down: Do not lose the primary key.
1590 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1591 start(): onLocaleChange(): Pass the current primary key value,
1592 instead of an empty value.
1594 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1596 locales drop-down: Do not lose the drop-down selection.
1598 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1599 .java (TableSelectionActivity.fillView): Set the selected locale
1600 after changing the drop-down items (though we do not really need
1601 to change them just because the locale changes.)
1603 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1605 locales drop-down: Change the tables list when this changes.
1607 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1608 .java: TableSelectionActivity.start(): Move the async table titles
1609 retrieval into a private fillView() method and also call this when
1610 the chosen locale changes.
1611 Note that the document title is not actually translatable yet, but
1612 that is a problem that I should fix soon in libglom.
1614 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1616 Improve the placement of the locales drop-down.
1618 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1619 Put the title and locales drop-down in a div (gwt.FlowTable).
1620 * src/main/webapp/style.css: Add magic css properties to make this work.
1621 Also remove the left margin from the title so that it lines up with the
1624 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1626 locales selector: Show human-readable locale titles.
1628 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1629 getDocumentInfo(): Use java.util.Locale to show a real title of
1630 each locale, in the locale's own language.
1632 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1634 Add a language/locale selector drop-down.
1636 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1637 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1638 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1639 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1640 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1641 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1642 Add a ListBox to show the available locales. Add getLocaleSelector(),
1643 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1644 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1645 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1646 java: Add these classes.
1647 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1648 start(): Fill the locales ListBox. Handle its change event, firing a
1650 setPlace(): Show the selected locale as specified by the URL token.
1651 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1652 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1653 Handle LocaleChangeEvent, going to a new *Place with that locale.
1655 The placement of the ListBox is not pretty, and it currently uses the ID
1656 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1660 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1662 Search box: Show the search text from the URL token.
1664 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1665 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1666 Add setQuickFindText().
1667 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1668 .java: setPlace(): Store the queryText if the place is a ListPlace,
1669 and call TableSelectionView.setQuickFindText().
1671 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1673 Allow use of translations via, for instance, &lang=de in the URL.
1675 * pom.xml: Use the unstable java-libglom 1.21 version.
1677 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1678 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1680 init(): Instead of calling TranslatableItem.set_current_locale()
1681 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1682 However, this is only for default locales, which are not needed to
1683 change the locale in the URL.
1684 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1685 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1686 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1687 layout for a particular locale.
1688 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1689 Add get/setDefaultLocaleID().
1690 getDocumentInfo(), getListViewData(), getRelatedListData(),
1691 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1692 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1693 localeID parameter, so we can get the layout for a particular locale.
1695 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1696 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1697 * src/main/java/org/glom/web/client/place/ListPlace.java:
1698 Parse and construct a lang parameter too.
1700 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1701 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1702 passed to subsequent methods and constructors.
1703 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1704 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1705 Store the localeID from the *Place and pass it to other constructors
1706 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1708 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1709 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1710 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1711 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1712 * src/main/java/org/glom/web/client/ui/ListView.java:
1713 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1714 Take localeID parameters and pass them to subsequent constructors and
1715 methods, so that the layout is always retrieved for that locale.
1717 This is rather repetitive.
1719 Note that "" means the original (default) locale of the Glom document,
1720 which is usually English.
1722 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1724 Documents: Remove final keyword to fix startup configuration.
1726 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1727 final keywords on the private member variables because that breaks
1728 the startup, apparently (there are warnings) because it stops them
1729 from being serialized. I added these in the previous commit.
1731 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1733 Documents: Add some final keywords.
1735 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1738 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1740 OnlineGlomServiceImpl: Add to overview comments.
1742 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1743 Note that this is where all the document are loaded. They are not
1744 loaded freshly for each page.
1746 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1750 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1751 Add a TextBox for the text of a quick find.
1752 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1754 setBackLink(): Add a String quickFind parameter.
1755 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1756 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1757 to the base interface, because that is how TableSelectionViewImpl is used.
1758 * src/main/webapp/style.css: Add style for the search box and its label.
1760 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1761 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1762 Add these files, based on the existing TableChangeEvent and
1763 TableChangeEventHandlers.
1764 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1765 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1766 a ListPlace() that the user should be taken to.
1767 * src/main/java/org/glom/web/client/activity/ListActivity.java
1768 start(): Handle it here too and adapt the TableChangeEvent handler to
1769 pass the extra "" quickFind parameter to ListPlace.
1770 * src/main/java/org/glom/web/client/place/ListPlace.java:
1771 Constructor: Take an extra String quickFind parameter and store it,
1772 returning it from a new getQuickFind() method.
1773 getToken(): Put the quickFind text in the URL token.
1774 getPlace(): Parse the quickFind text from the URL token.
1775 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1776 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1777 ListPlace constructor.
1778 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1779 .java: start(): Add a Change handler for the TableSelectionView's
1780 TextBox (via its base HasChangeHandlers interface), firing the new
1781 QuickFindChangeEvent.
1782 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1783 pass the extra "" quickFind parameter.
1785 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1786 setCellTable(): Add a String quickFind parameter and pass it to
1787 the ListViewTable() constructor.
1788 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1789 setCellTable() in the base interface, because that is how ListViewImpl
1792 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1793 Add a String quickFind member variable.
1794 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1795 Constructor: Add a String quickFind parameter, storing it in the
1796 base ListTable's member variable.
1797 onRangeChanged(): Pass quickFind to the
1798 OnlineGlomServiceAsync.getSortedListViewData() and
1799 OnlineGlomServiceAsync.getListViewData() methods.
1801 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1802 getListViewData(), getSortedListViewData(): Add a String quickFind
1803 parameter, passing it to ConfiguredDocument.getListViewData().
1804 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1805 Change getListViewData(), getSortedListViewData() in the base interface,
1806 because that is how OnlineGlomServiceImpl is used, via this:
1807 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1808 Change getListViewData(), getSortedListViewData() here too.
1809 This class can apparently be used to asynchronously call methods on
1810 OnlineGlomService, and GWT seems to implement that after recognizing
1811 just the *Async name convention and the extra AsyncCallback parameters.
1813 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1814 getListViewData(): Add a String quickFind parameter, and pass it to
1815 ListViewDBAccess.getData().
1816 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1817 getListData(): Add a String quickFind parameter and pass it to
1819 getSelectQuery(): Add a String quickFind parameter.
1820 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1821 getSelectQuery(): Add a String quickFind parameter and use it with
1822 Glom.get_find_where_clause_quick() to pass a where_clause to
1823 Glom.build_sql_select_with_where_clause(), to actually filter the
1825 getData(): Add a String quickFind parameter, passing it to getListData().
1826 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1827 va: getData(): Pass an empty string to getListData() for the
1828 quickFind parameter.
1830 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1832 ListTable: Minor change.
1834 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1835 createCellTable(): Make this protected instead of public.
1837 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1839 Many files: Use final for the parameters and use the @override attribute.
1841 2012-01-22 Ben Konrath <ben@bagu.org>
1843 Add anchor links for single line text that starts with http, ftp and www.
1847 2012-01-22 Ben Konrath <ben@bagu.org>
1849 Add ellipsis to single line text in details view.
1853 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1855 Remove all javadoc author tags.
1857 Because they are awkward and meaningless when many people touch
1859 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1861 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1863 Revert the COPYING.LESSER to COPYING rename.
1865 Apparently both should be there if it is LGPL.
1867 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1869 *View: Remove unused imports.
1871 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1872 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1873 * src/main/java/org/glom/web/client/ui/ListView.java:
1874 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1875 Remove unused imports, as suggested by Eclipse.
1877 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1879 Move the *View::Presenter types, and some API into one base View.
1881 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1882 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1883 * src/main/java/org/glom/web/client/ui/ListView.java:
1884 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1885 Presenter, setPresenter() and clear() into a shared base interface,
1886 to avoid the unnecessary duplicate Presenter types and to more clearly
1887 show how the *Views share the same structure, even if they are not
1888 used polymorphically.
1890 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1891 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1893 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1894 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1895 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1897 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1900 Feel free to revert this if there is a good reason for the duplicate
1903 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1905 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1907 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1908 a class member instead of a local variable in the method.
1909 This lets us use it to get the view instances, for use in tests.
1910 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1911 beforeOnlineGlom(): Test some more details of the initial view.
1912 Again, this is not very useful.
1914 To really test gwt-glom we will need to start a local postgresql
1915 instance with local data, like the Glom tests in C++.
1917 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1919 pom.xml: Mention the LGPL license.
1921 * pom.xml: Add a licenses section.
1922 * COPYING.LESSER: Move this to COPYING, which
1923 previously contained the GPL. But gwt-glom is all LGPL.
1925 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1927 Add project information to README and pom.xml.
1929 * README: Add a brief description and mention some mvn
1931 * pom.xml: This extra information shows up in mvn site
1934 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1936 Use the latest java-libglom version.
1938 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1940 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1942 GwtTestOnlineGlom: Test a little more.
1944 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1945 protected rather than private, as suggested by the gwt-test-utils
1947 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1948 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1949 Test the initial visibility of the panels.
1951 However, this is not a very useful test.
1952 And I wonder how we should generally test using this idea for an
1953 activity/places app like ours where the real changes happen implicitly
1954 based on the history token/URL.
1956 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1958 Slight modification to *Mapper comments.
1960 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1961 (DataActivityMapper)
1962 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1964 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1966 Remove comments mentioning GIN because they are just copied from
1967 the example code and are apparently not helpful:
1968 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1969 Also change the mention of a class that is only in the example code.
1971 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1973 GwtTestOnlineGlom test: Minor changes.
1975 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1976 Avoid the long qualified class name and modify the comment
1977 because it is now obvious to me that the mocked class is the only
1978 custom one created via GWT.create().
1980 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1982 Tests: Added the beginnings of a test using gwt-test-utils.
1984 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1985 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1986 which tells gwt-test-utils what class will be tested.
1987 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1988 Add a simple (but empty) test case. One class, used by the OnlineGlom
1989 class, is mocked so that it can be created. However, I am not sure
1990 why only this class needs to be mocked.
1992 Note that mockito seems more popular, and clearer, than easymock,
1993 but I have not got that working yet. It might be a matter of the
1996 This test is run during mvn integration-test.
1998 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2000 Tests: Use junit4-style syntax instead of junit3-style.
2002 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2003 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2004 * src/test/java/org/glom/web/shared/DataItemTest.java:
2005 Use the @Test annotation rather than relying on the test*() prefix.
2006 Also no longer implement TestCase, to avoid triggering support for
2007 the junit3-way, which stops the annotations from working.
2008 Change the imports from import junit.framework.* to
2009 import org.junit.*, which is apparently the new way.
2011 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2013 Added a test for ListPlace token parsing and creation.
2015 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2016 This is much the same as DetailsPlaceTest.
2018 I wonder how we could test the other parts of the *Place API.
2020 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2022 DetailsPlace test: Also test getToken() and recreation via getPlace().
2024 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2025 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2026 recreate it, testing the recreated DetailsPlace for the same parameter
2029 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2031 Use the surefire-report plugin.
2033 * pom.xml: This generates a HTML report about the tests in
2034 target/site/surefire-report.html
2035 when you do mvn surefire-report:report. It seems to be popular/normal.
2037 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2039 Added a test for DetailsPlace.
2041 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2042 Test the getPlace() token parsing.
2044 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2046 Added a first unit test.
2048 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2049 * src/test/java/org/glom/web/shared/DataItemTest.java:
2050 This is a silly test but it is just to get things started. Note that
2051 maven/junit finds the test because it looks in src/test by default.
2053 2011-12-22 Ben Konrath <ben@bagu.org>
2055 Change charsetName to "UTF-8" when replacing line breaks.
2057 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2058 that work in Java (such as "UTF8") will not work when compiled to
2061 This fixes a problem with multi-line details view fields that have hard
2062 line breaks. The "License Text" field on this page demonstrates the
2065 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2067 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2069 2011-12-22 Ben Konrath <ben@bagu.org>
2071 Fix another bug with related list navigation.
2073 I've tested all the navigation buttons in all of the related lists
2074 so things should be good now.
2076 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2078 2011-12-22 Ben Konrath <ben@bagu.org>
2080 Fix a crasher when refreshing the list view with the default table.
2082 This crash will also happen when loading the list view with the default
2083 table from a link or bookmark.
2085 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2086 to the main document selection page when the document id hasn't been
2088 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2089 the main document selection page when the document id hasn't been
2091 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2092 values for the details place when the document id hasn't been set.
2093 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2094 values for the list place when the document id hasn't been set.
2096 2011-12-21 Ben Konrath <ben@bagu.org>
2098 Protect against NPE when glom.document.locale is not in config.
2100 This patch protects against an NPE when glom.document.locale is not in
2101 the config file. This NPE will also happen if glom.document.locale is
2104 The patch also updates the error message to display the class name when
2105 the getMessage() returns null. This was happening when the NPE was
2106 thrown and I had "Configuration Error: null". If an NPE is encountered
2107 with this patch, "Configuration Error: NullPointerException " will be
2110 This commit closes this bug:
2112 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2114 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2116 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2118 Rename onlineglom.properties to onlineglom.properties.sample.
2120 * src/main/resources/onlineglom.properties: Rename to:
2121 * src/main/resources/onlineglom.properties.sample:
2122 * src/main/resources/README: And add this file explaining that people
2123 should rename it back when deploying.
2125 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2127 Allow choosing the translation in the .properties file.
2129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2130 init(): Read a glom.document.locale value from the configuration file
2131 and call Glom's TransatableItem::set_current_locale() method.
2132 * src/main/resources/onlineglom.properties: Add a commented-out
2133 example of this new setting.
2135 It would be better to add &lang=de_DE to the URL, but the current
2136 libglom API does not allow us to do this easily. I am working on that.
2138 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2140 Avoid a crash in parsing of token parameters.
2142 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2143 ava: getTokenParams(): Do not crash if a parameter has a key but no
2144 value, and ignore parameters with neither.
2146 2011-12-17 Murray Cumming <murrayc@murayc.com>
2148 History token building/handling: Improve use of token parameters.
2150 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2151 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2152 and buildParamsToken(HashMap), for use by derived classes.
2153 Make the separator private because it is no longer be needed.
2154 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2155 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2156 instead of manual string concatenation.
2157 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2158 of hardcoded indices and awkward splitting code.
2159 * src/main/java/org/glom/web/client/place/ListPlace.java
2160 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2161 instead of manual string concatenation.
2162 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2163 of hardcoded indices and awkward splitting code.
2164 This should fix bug #666420
2166 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2168 Fix a Navgiation->Navigation typo in the code.
2170 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2171 Rename processNavgiation() to processNavigation().
2173 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2175 Fix a seperator->separator typo in the code.
2177 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2178 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2179 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2182 2011-12-15 Ben Konrath <ben@bagu.org>
2184 Cleanup some comments.
2186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2188 2011-12-14 Ben Konrath <ben@bagu.org>
2190 Replace \n with <br/> for multiline text in the details view.
2192 Vertical scrollbars are added when needed as well.
2194 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2196 2011-12-14 Ben Konrath <ben@bagu.org>
2198 Specify the font for document selection links.
2200 * src/main/webapp/style.css:
2202 2011-12-14 Ben Konrath <ben@bagu.org>
2204 Fix bouncy CellTable while paging.
2206 This doesn't currently work with related list tables in unselected
2209 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2211 2011-12-14 Ben Konrath <ben@bagu.org>
2213 Revamp the appearance of the document selection page.
2215 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2216 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2217 * src/main/webapp/style.css:
2219 2011-12-13 Ben Konrath <ben@bagu.org>
2221 Set navigation button column to the smallest size possible.
2223 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2225 2011-12-13 Ben Konrath <ben@bagu.org>
2227 Change OpenButton nomenclature to NavigationButton.
2229 Using NavigtionButton makes things more generic. Classes, methods and
2230 variables have been changed.
2232 This is a rename-only refactor.
2234 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2235 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2236 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2237 Renamed from OpenButtonCell.
2238 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2239 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2240 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2242 2011-12-12 Ben Konrath <ben@bagu.org>
2244 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2246 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2247 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2248 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2249 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2251 2011-12-12 Ben Konrath <ben@bagu.org>
2253 Update variable names and comments.
2255 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2256 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2258 2011-12-12 Ben Konrath <ben@bagu.org>
2260 Properly initialize numNonEmptyRows variable to zero.
2262 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2263 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2265 2011-12-05 Ben Konrath <ben@bagu.org>
2267 Add latest mockup with HTML tables.
2269 Features of this mockup:
2271 -> HTML table for flowtable
2272 -> HTML table for flowtable column
2273 -> Example of how related lists would look
2274 -> Not using text entries for data items
2276 The current version of Online Glom doesn't use HTML tables for the
2279 This mockup has been sent to the glom-devel mailing list but it's good
2280 to have it here as well.
2282 * mockups/details-view-html-tables.html:
2284 2011-12-05 Ben Konrath <ben@bagu.org>
2286 Remove unnecessary getPrimaryKeyField() method.
2288 getPrimaryKeyFieldForTable(String) has been renamed to
2289 getPrimaryKeyField(String).
2291 * src/main/java/org/glom/web/server/database/DBAccess.java:
2292 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2293 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2295 2011-12-05 Ben Konrath <ben@bagu.org>
2297 Add string representation of TypedDataItem value to conversion error message.
2299 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2300 message was extracted into its own method to avoid duplication.
2302 2011-12-05 Ben Konrath <ben@bagu.org>
2304 Add type checking to navigation primary key value creation.
2306 Create navigation primary key only if the expected type from the Glom
2307 document matches the type returned by the SQL query.
2309 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2311 2011-12-05 Ben Konrath <ben@bagu.org>
2313 Rename a couple of variables in RelatedListNavigation.
2315 This is a rename-only refactor.
2317 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2319 2011-12-05 Ben Konrath <ben@bagu.org>
2321 Move getListLayoutGroup() into getListViewLayoutGroup().
2323 This removes getListLayoutGroup(). It was only being called by
2324 getListViewLayoutGroup().
2326 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2328 2011-12-05 Ben Konrath <ben@bagu.org>
2330 Remove check for LayoutItem_Portal in list table method.
2332 This check is no longer necessary because the method isn't being used
2333 to create the LayoutItemPortal DTO.
2335 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2337 2011-12-05 Ben Konrath <ben@bagu.org>
2339 Properly support related list navigation.
2341 Navigation from the "Repository Analyzer -> Package Scans ->
2342 Dependencies" related table wasn't working because the primary key for
2343 related tables wasn't being set properly. This commit fixes the
2346 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2347 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2348 doesn't set the primary key properly for related list tables.
2349 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2350 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2351 useful for getting the primary key for list view tables and for related
2353 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2354 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2355 Move code to set the primary key for the table from the abstract
2356 ListDBAccess class to ListViewDBAccess as it's only correct for list
2358 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2359 Properly add primary key to related list tables.
2361 2011-12-02 Ben Konrath <ben@bagu.org>
2363 Properly set the horizontal alignment of fields.
2365 This fix is for both the list tables and the details view.
2367 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2368 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2369 to set the horizontal alignment of fields.
2371 2011-12-02 Ben Konrath <ben@bagu.org>
2373 Display currency codes in the details view.
2375 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2377 2011-12-02 Ben Konrath <ben@bagu.org>
2379 Avoid duplicate JNI call.
2381 JNI is not as efficient as pure Java and this is an easy (and small)
2384 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2385 Use previously retrieved value for whereClauseToTableName instead of
2388 2011-12-02 Ben Konrath <ben@bagu.org>
2390 Rename a couple of variables in RelatedListNavigation.
2392 This is a rename-only refactor.
2394 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2396 2011-12-02 Ben Konrath <ben@bagu.org>
2398 Indicate clearly that a mismatched primary key type is a bug.
2400 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2401 warning to error. Add 'This is a bug.' to message.
2403 2011-12-02 Ben Konrath <ben@bagu.org>
2405 Update / fix some comments.
2407 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2409 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2411 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2412 Fix comments. Add some TODOs.
2414 2011-12-02 Ben Konrath <ben@bagu.org>
2416 Enable navigation to details view with string primary key from related list.
2418 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2419 Create a text primary key value when return type of result is
2420 java.sql.Types.VARCHAR.
2422 2011-12-02 Ben Konrath <ben@bagu.org>
2424 Use checkboxes for booleans in the details view.
2426 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2428 2011-12-01 Ben Konrath <ben@bagu.org>
2430 Improve performance of related list height calculation.
2432 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2433 Put code to calculate the expected height in a static initializer so
2434 that that it's only called once.
2436 2011-12-01 Ben Konrath <ben@bagu.org>
2438 Show related list tables in notebooks (again).
2440 Calculate the height of the related list tables so the Notebook can be
2441 set the correct height. The height of the related list table is also needed by
2442 FlowTable to be able decide how to create the layout.
2444 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2445 and set the Portal height based on the height of the related list
2446 table and the Portal container.
2447 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2448 Add method to calculate the height of the related list tables.
2449 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2450 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2451 calculate the height of the Pager widget.
2453 2011-12-01 Ben Konrath <ben@bagu.org>
2455 Use CellTable API for table property instead of setting style on Element.
2457 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2459 2011-12-01 Ben Konrath <ben@bagu.org>
2461 Make ListViewTable and RelatedListTable a consistent height.
2463 The tables are now a consistent height regardless of the contents of
2464 the table. A hidden button is added to empty rows to ensure that the
2465 height of these rows will match the height of rows with data.
2467 A navigation button column is now added to every table. The width of
2468 the navigation column is set to 0px when a RelatedListTable shouldn't
2469 have navigation buttons. This maintains the a consistent row height in
2470 tables that don't show the navigation buttons.
2472 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2473 navigation column when not needed.
2474 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2475 arguments for navigation button to constructor of ListViewTable.
2476 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2477 hidden button for empty data rows.
2478 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2479 arguments for navigation button to constructor.
2480 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2481 create navigation buttons. Add hideNavigationButtons() method.
2482 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2483 arguments for navigation button to constructor.
2485 2011-12-01 Ben Konrath <ben@bagu.org>
2487 Use 'visibility: hidden' in Utils.getWidgetHeight().
2489 This is better choice because hidden elements are invisible, don't
2490 respond to events and are not part of the tab order. They will,