1 2012-01-26 Murray Cumming <murrayc@murrayc.com>
3 Use the ?locale= query param instead of the &lang= token param.
5 * src/main/java/org/glom/web/client/place/ListPlace.java
6 * src/main/java/org/glom/web/client/place/DetailsPlace.java
7 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
8 Remove the lang token key and value.
10 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
11 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
12 When the user selects a different locale from the chooser, use
13 Window.Location.assign() to change the URL, which then causes a reload.
15 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
16 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
17 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
18 * src/main/java/org/glom/web/client/activity/ListActivity.java
19 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
20 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
21 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
22 * src/main/java/org/glom/web/client/ui/ListView.java:
23 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
25 Remove localeID member variables and method/constructor parameters, instead
26 using Utils.getCurrentLocaleID() when we need a localID to pass to
29 2012-01-26 Murray Cumming <murrayc@murrayc.com>
31 Internationalize the UI strings.
33 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
34 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
35 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
36 because it is unused. Messages are apparently strings that can have
37 parameters, but we do not need that yet, so Contants will be enough for now.
38 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
39 to say that we support the en and de locales.
40 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
41 The original English strings.
42 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
43 Some German translations of the English strings.
44 The i18n goal then uses the .properties file to generate an
45 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
46 returns an implementation that returns the translated strings.
47 The documentation suggests putting these in src/java/*/client/, but it seems
48 best to put it in src/resources/*/client/.
49 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
50 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
51 instead of hard-coding them.
52 Note that we cannot import OnlineGlomConstants because it does not exist yet,
53 but that does not seem to stop the build, though it confuses Eclipse.
55 You can see the translated string by adding ?locale=de to the URL, like so:
56 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
58 2012-01-24 Murray Cumming <murrayc@murrayc.com>
60 Improve null/empty String checks.
62 * pom.xml: Add a dependency on commons-lang, to use
63 org.apache.commons.lang.StringUtils.
64 * src/main/java/org/glom/web/server/ConfiguredDocument.java
65 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
66 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
67 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
68 Use StringUtils.isEmpty().
70 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
71 StringUtils class with a static isEmpty() function because we
72 cannot use org.apache.commons.lang.StringUtils in client-side
73 GWT code because it (apparently) cannot be compiled to javascript.
74 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
75 * src/main/java/org/glom/web/client/activity/ListActivity.java
76 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
77 * src/main/java/org/glom/web/client/place/DetailsPlace.java
78 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
79 * src/main/java/org/glom/web/client/place/ListPlace.java
80 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
81 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
82 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
83 * src/main/java/org/glom/web/client/ui/details/Group.java
84 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
85 our StringUtils.isEmpty() function.
87 2012-01-24 Murray Cumming <murrayc@murrayc.com>
89 Update to the latest java-libglom API.
91 * pom.xml: Require java-libglom 1.21.4.
92 * src/main/java/org/glom/web/server/ConfiguredDocument.java
93 getDocumentInfo(), getListViewLayoutGroup():
94 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
96 * src/main/java/org/glom/web/server/database/DBAccess.java
97 getFieldsToShowForSQLQueryAddGroup(),
98 getPrimaryKeyLayoutItemField(): Replace get_database_title()
99 with either get_database_title_original() or
100 get_database_title(localeID).
102 2012-01-24 Murray Cumming <murrayc@murrayc.com>
104 ConfiguredDocument: Avoid a null pointer exception.
106 * src/main/java/org/glom/web/server/ConfiguredDocument.java
107 Initialize localeID to "" to avoid returning a null String which
108 causes a crash in java-libglom's swing-generated code.
110 2012-01-23 Murray Cumming <murrayc@murrayc.com>
112 Some simple renaming.
114 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
115 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
116 for localeChooser. This seems more appropriate and is less ambiguous
117 particularly in the .css file.
119 2012-01-23 Murray Cumming <murrayc@murrayc.com>
121 ConfiguredDocument: Rename the localedID private member variable.
123 2012-01-23 Murray Cumming <murrayc@murrayc.com>
125 Adapt to the latest java-libglom API from git master.
127 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
128 libglom now uses only Vector instead of List, which uses add() instead of
131 2012-01-23 Murray Cumming <murrayc@murrayc.com>
133 Add and fill a Reports drop-down list box.
135 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
137 * src/main/java/org/glom/web/client/OnlineGlomService.java:
138 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
139 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
140 Added getReports(document, table, localeID), calling
141 ConfiguredDocument.getReports().
142 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
143 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
144 Added setReportsList() and a list widget.
145 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
146 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
148 2012-01-22 Murray Cumming <murrayc@murrayc.com>
150 ConfiguredDocument: Rename the localedID private member variable.
152 2012-01-20 Murray Cumming <murrayc@murrayc.com>
154 Build a source tarball with mvn assembly:single
156 * assembly.xml: Add this file.
157 * pom.xml: Use the maven-assembly-plugin and tell it to use
158 our assembly.xml file.
160 2012-01-19 Murray Cumming <murrayc@murrayc.com>
162 OnlineGlomServiceImpl: Get .glom files recursively.
164 * pom.xml: Depend on commons-io from org.apache.commons.
165 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
166 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
167 files recursively, and with the easier filter for the extension.
168 Use org.apache.commons.io.FilenameUtils.removeExtension() to
169 simplify that code too.
171 2012-01-19 Murray Cumming <murrayc@murrayc.com>
173 README: Mention that you must install java-libglom packages separately.
175 But then it works, because java-libglom is now in the central maven
178 2012-01-18 Murray Cumming <murrayc@murrayc.com>
180 locales drop-down: Show the correct selected locale when the URL changes.
182 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
183 .java: setPlace(): Move some code into fillView().
185 2012-01-18 Murray Cumming <murrayc@murrayc.com>
187 locales drop-down: Do not lose the primary key.
189 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
190 start(): onLocaleChange(): Pass the current primary key value,
191 instead of an empty value.
193 2012-01-18 Murray Cumming <murrayc@murrayc.com>
195 locales drop-down: Do not lose the drop-down selection.
197 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
198 .java (TableSelectionActivity.fillView): Set the selected locale
199 after changing the drop-down items (though we do not really need
200 to change them just because the locale changes.)
202 2012-01-18 Murray Cumming <murrayc@murrayc.com>
204 locales drop-down: Change the tables list when this changes.
206 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
207 .java: TableSelectionActivity.start(): Move the async table titles
208 retrieval into a private fillView() method and also call this when
209 the chosen locale changes.
210 Note that the document title is not actually translatable yet, but
211 that is a problem that I should fix soon in libglom.
213 2012-01-18 Murray Cumming <murrayc@murrayc.com>
215 Improve the placement of the locales drop-down.
217 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
218 Put the title and locales drop-down in a div (gwt.FlowTable).
219 * src/main/webapp/style.css: Add magic css properties to make this work.
220 Also remove the left margin from the title so that it lines up with the
223 2012-01-18 Murray Cumming <murrayc@murrayc.com>
225 locales selector: Show human-readable locale titles.
227 * src/main/java/org/glom/web/server/ConfiguredDocument.java
228 getDocumentInfo(): Use java.util.Locale to show a real title of
229 each locale, in the locale's own language.
231 2012-01-17 Murray Cumming <murrayc@murrayc.com>
233 Add a language/locale selector drop-down.
235 * src/main/java/org/glom/web/shared/DocumentInfo.java:
236 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
237 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
238 getDocumentInfo(): Store the available Locales in the DocumentInfo.
239 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
240 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
241 Add a ListBox to show the available locales. Add getLocaleSelector(),
242 setLocaleList(), getSelectedLocale(), setSelectedLocale().
243 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
244 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
245 java: Add these classes.
246 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
247 start(): Fill the locales ListBox. Handle its change event, firing a
249 setPlace(): Show the selected locale as specified by the URL token.
250 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
251 * src/main/java/org/glom/web/client/activity/ListActivity.java:
252 Handle LocaleChangeEvent, going to a new *Place with that locale.
254 The placement of the ListBox is not pretty, and it currently uses the ID
255 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
259 2012-01-17 Murray Cumming <murrayc@murrayc.com>
261 Search box: Show the search text from the URL token.
263 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
264 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
265 Add setQuickFindText().
266 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
267 .java: setPlace(): Store the queryText if the place is a ListPlace,
268 and call TableSelectionView.setQuickFindText().
270 2012-01-17 Murray Cumming <murrayc@murrayc.com>
272 Allow use of translations via, for instance, &lang=de in the URL.
274 * pom.xml: Use the unstable java-libglom 1.21 version.
276 * src/main/java/org/glom/web/client/OnlineGlomService.java:
277 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
278 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
279 init(): Instead of calling TranslatableItem.set_current_locale()
280 (now removed), call ConfiguredDocument.setDefaultLocaleID().
281 However, this is only for default locales, which are not needed to
282 change the locale in the URL.
283 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
284 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
285 getSortedRelatedListData(): Add a localeID parameter, so we can get the
286 layout for a particular locale.
287 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
288 Add get/setDefaultLocaleID().
289 getDocumentInfo(), getListViewData(), getRelatedListData(),
290 getDetailsLayoutGroup(), getListViewLayoutGroup(),
291 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
292 localeID parameter, so we can get the layout for a particular locale.
294 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
295 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
296 * src/main/java/org/glom/web/client/place/ListPlace.java:
297 Parse and construct a lang parameter too.
299 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
300 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
301 passed to subsequent methods and constructors.
302 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
303 * src/main/java/org/glom/web/client/activity/ListActivity.java:
304 Store the localeID from the *Place and pass it to other constructors
305 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
307 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
308 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
309 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
310 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
311 * src/main/java/org/glom/web/client/ui/ListView.java:
312 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
313 Take localeID parameters and pass them to subsequent constructors and
314 methods, so that the layout is always retrieved for that locale.
316 This is rather repetitive.
318 Note that "" means the original (default) locale of the Glom document,
319 which is usually English.
321 2012-01-17 Murray Cumming <murrayc@murrayc.com>
323 Documents: Remove final keyword to fix startup configuration.
325 * src/main/java/org/glom/web/shared/Documents.java: Remove the
326 final keywords on the private member variables because that breaks
327 the startup, apparently (there are warnings) because it stops them
328 from being serialized. I added these in the previous commit.
330 2012-01-13 Murray Cumming <murrayc@murrayc.com>
332 Documents: Add some final keywords.
334 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
337 2012-01-13 Murray Cumming <murrayc@murrayc.com>
339 OnlineGlomServiceImpl: Add to overview comments.
341 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
342 Note that this is where all the document are loaded. They are not
343 loaded freshly for each page.
345 2012-01-12 Murray Cumming <murrayc@murrayc.com>
349 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
350 Add a TextBox for the text of a quick find.
351 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
353 setBackLink(): Add a String quickFind parameter.
354 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
355 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
356 to the base interface, because that is how TableSelectionViewImpl is used.
357 * src/main/webapp/style.css: Add style for the search box and its label.
359 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
360 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
361 Add these files, based on the existing TableChangeEvent and
362 TableChangeEventHandlers.
363 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
364 start(): Handle QuickFindChangeEvent, passing its quickFind text to
365 a ListPlace() that the user should be taken to.
366 * src/main/java/org/glom/web/client/activity/ListActivity.java
367 start(): Handle it here too and adapt the TableChangeEvent handler to
368 pass the extra "" quickFind parameter to ListPlace.
369 * src/main/java/org/glom/web/client/place/ListPlace.java:
370 Constructor: Take an extra String quickFind parameter and store it,
371 returning it from a new getQuickFind() method.
372 getToken(): Put the quickFind text in the URL token.
373 getPlace(): Parse the quickFind text from the URL token.
374 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
375 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
376 ListPlace constructor.
377 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
378 .java: start(): Add a Change handler for the TableSelectionView's
379 TextBox (via its base HasChangeHandlers interface), firing the new
380 QuickFindChangeEvent.
381 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
382 pass the extra "" quickFind parameter.
384 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
385 setCellTable(): Add a String quickFind parameter and pass it to
386 the ListViewTable() constructor.
387 * src/main/java/org/glom/web/client/ui/ListView.java: Change
388 setCellTable() in the base interface, because that is how ListViewImpl
391 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
392 Add a String quickFind member variable.
393 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
394 Constructor: Add a String quickFind parameter, storing it in the
395 base ListTable's member variable.
396 onRangeChanged(): Pass quickFind to the
397 OnlineGlomServiceAsync.getSortedListViewData() and
398 OnlineGlomServiceAsync.getListViewData() methods.
400 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
401 getListViewData(), getSortedListViewData(): Add a String quickFind
402 parameter, passing it to ConfiguredDocument.getListViewData().
403 * src/main/java/org/glom/web/client/OnlineGlomService.java:
404 Change getListViewData(), getSortedListViewData() in the base interface,
405 because that is how OnlineGlomServiceImpl is used, via this:
406 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
407 Change getListViewData(), getSortedListViewData() here too.
408 This class can apparently be used to asynchronously call methods on
409 OnlineGlomService, and GWT seems to implement that after recognizing
410 just the *Async name convention and the extra AsyncCallback parameters.
412 * src/main/java/org/glom/web/server/ConfiguredDocument.java
413 getListViewData(): Add a String quickFind parameter, and pass it to
414 ListViewDBAccess.getData().
415 * src/main/java/org/glom/web/server/database/ListDBAccess.java
416 getListData(): Add a String quickFind parameter and pass it to
418 getSelectQuery(): Add a String quickFind parameter.
419 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
420 getSelectQuery(): Add a String quickFind parameter and use it with
421 Glom.get_find_where_clause_quick() to pass a where_clause to
422 Glom.build_sql_select_with_where_clause(), to actually filter the
424 getData(): Add a String quickFind parameter, passing it to getListData().
425 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
426 va: getData(): Pass an empty string to getListData() for the
429 2012-01-12 Murray Cumming <murrayc@murrayc.com>
431 ListTable: Minor change.
433 * src/main/java/org/glom/web/client/ui/list/ListTable.java
434 createCellTable(): Make this protected instead of public.
436 2012-01-12 Murray Cumming <murrayc@murrayc.com>
438 Many files: Use final for the parameters and use the @override attribute.
440 2012-01-22 Ben Konrath <ben@bagu.org>
442 Add anchor links for single line text that starts with http, ftp and www.
446 2012-01-22 Ben Konrath <ben@bagu.org>
448 Add ellipsis to single line text in details view.
452 2012-01-04 Murray Cumming <murrayc@murrayc.com>
454 Remove all javadoc author tags.
456 Because they are awkward and meaningless when many people touch
458 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
460 2012-01-04 Murray Cumming <murrayc@murrayc.com>
462 Revert the COPYING.LESSER to COPYING rename.
464 Apparently both should be there if it is LGPL.
466 2012-01-03 Murray Cumming <murrayc@murrayc.com>
468 *View: Remove unused imports.
470 * src/main/java/org/glom/web/client/ui/DetailsView.java:
471 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
472 * src/main/java/org/glom/web/client/ui/ListView.java:
473 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
474 Remove unused imports, as suggested by Eclipse.
476 2012-01-02 Murray Cumming <murrayc@murrayc.com>
478 Move the *View::Presenter types, and some API into one base View.
480 * src/main/java/org/glom/web/client/ui/DetailsView.java:
481 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
482 * src/main/java/org/glom/web/client/ui/ListView.java:
483 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
484 Presenter, setPresenter() and clear() into a shared base interface,
485 to avoid the unnecessary duplicate Presenter types and to more clearly
486 show how the *Views share the same structure, even if they are not
487 used polymorphically.
489 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
490 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
492 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
493 * src/main/java/org/glom/web/client/activity/ListActivity.java:
494 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
496 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
499 Feel free to revert this if there is a good reason for the duplicate
502 2012-01-02 Murray Cumming <murrayc@murrayc.com>
504 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
506 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
507 a class member instead of a local variable in the method.
508 This lets us use it to get the view instances, for use in tests.
509 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
510 beforeOnlineGlom(): Test some more details of the initial view.
511 Again, this is not very useful.
513 To really test gwt-glom we will need to start a local postgresql
514 instance with local data, like the Glom tests in C++.
516 2012-01-02 Murray Cumming <murrayc@murrayc.com>
518 pom.xml: Mention the LGPL license.
520 * pom.xml: Add a licenses section.
521 * COPYING.LESSER: Move this to COPYING, which
522 previously contained the GPL. But gwt-glom is all LGPL.
524 2012-01-02 Murray Cumming <murrayc@murrayc.com>
526 Add project information to README and pom.xml.
528 * README: Add a brief description and mention some mvn
530 * pom.xml: This extra information shows up in mvn site
533 2011-01-02 Murray Cumming <murrayc@murrayc.com>
535 Use the latest java-libglom version.
537 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
539 2012-01-01 Murray Cumming <murrayc@murrayc.com>
541 GwtTestOnlineGlom: Test a little more.
543 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
544 protected rather than private, as suggested by the gwt-test-utils
546 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
547 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
548 Test the initial visibility of the panels.
550 However, this is not a very useful test.
551 And I wonder how we should generally test using this idea for an
552 activity/places app like ours where the real changes happen implicitly
553 based on the history token/URL.
555 2012-01-01 Murray Cumming <murrayc@murrayc.com>
557 Slight modification to *Mapper comments.
559 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
561 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
563 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
565 Remove comments mentioning GIN because they are just copied from
566 the example code and are apparently not helpful:
567 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
568 Also change the mention of a class that is only in the example code.
570 2012-01-01 Murray Cumming <murrayc@murrayc.com>
572 GwtTestOnlineGlom test: Minor changes.
574 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
575 Avoid the long qualified class name and modify the comment
576 because it is now obvious to me that the mocked class is the only
577 custom one created via GWT.create().
579 2012-01-01 Murray Cumming <murrayc@murrayc.com>
581 Tests: Added the beginnings of a test using gwt-test-utils.
583 * pom.xml: Add dependencies on gwt-test-utils and easymock.
584 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
585 which tells gwt-test-utils what class will be tested.
586 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
587 Add a simple (but empty) test case. One class, used by the OnlineGlom
588 class, is mocked so that it can be created. However, I am not sure
589 why only this class needs to be mocked.
591 Note that mockito seems more popular, and clearer, than easymock,
592 but I have not got that working yet. It might be a matter of the
595 This test is run during mvn integration-test.
597 2011-12-31 Murray Cumming <murrayc@murrayc.com>
599 Tests: Use junit4-style syntax instead of junit3-style.
601 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
602 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
603 * src/test/java/org/glom/web/shared/DataItemTest.java:
604 Use the @Test annotation rather than relying on the test*() prefix.
605 Also no longer implement TestCase, to avoid triggering support for
606 the junit3-way, which stops the annotations from working.
607 Change the imports from import junit.framework.* to
608 import org.junit.*, which is apparently the new way.
610 2011-12-31 Murray Cumming <murrayc@murrayc.com>
612 Added a test for ListPlace token parsing and creation.
614 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
615 This is much the same as DetailsPlaceTest.
617 I wonder how we could test the other parts of the *Place API.
619 2011-12-30 Murray Cumming <murrayc@murrayc.com>
621 DetailsPlace test: Also test getToken() and recreation via getPlace().
623 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
624 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
625 recreate it, testing the recreated DetailsPlace for the same parameter
628 2011-12-30 Murray Cumming <murrayc@murrayc.com>
630 Use the surefire-report plugin.
632 * pom.xml: This generates a HTML report about the tests in
633 target/site/surefire-report.html
634 when you do mvn surefire-report:report. It seems to be popular/normal.
636 2011-12-30 Murray Cumming <murrayc@murrayc.com>
638 Added a test for DetailsPlace.
640 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
641 Test the getPlace() token parsing.
643 2011-12-30 Murray Cumming <murrayc@murrayc.com>
645 Added a first unit test.
647 * pom.xml: Add a test goal, and a dependency on junit in that scope.
648 * src/test/java/org/glom/web/shared/DataItemTest.java:
649 This is a silly test but it is just to get things started. Note that
650 maven/junit finds the test because it looks in src/test by default.
652 2011-12-22 Ben Konrath <ben@bagu.org>
654 Change charsetName to "UTF-8" when replacing line breaks.
656 JavaScript requires the charsetName to be "UTF-8". CharsetName values
657 that work in Java (such as "UTF8") will not work when compiled to
660 This fixes a problem with multi-line details view fields that have hard
661 line breaks. The "License Text" field on this page demonstrates the
664 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
666 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
668 2011-12-22 Ben Konrath <ben@bagu.org>
670 Fix another bug with related list navigation.
672 I've tested all the navigation buttons in all of the related lists
673 so things should be good now.
675 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
677 2011-12-22 Ben Konrath <ben@bagu.org>
679 Fix a crasher when refreshing the list view with the default table.
681 This crash will also happen when loading the list view with the default
682 table from a link or bookmark.
684 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
685 to the main document selection page when the document id hasn't been
687 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
688 the main document selection page when the document id hasn't been
690 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
691 values for the details place when the document id hasn't been set.
692 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
693 values for the list place when the document id hasn't been set.
695 2011-12-21 Ben Konrath <ben@bagu.org>
697 Protect against NPE when glom.document.locale is not in config.
699 This patch protects against an NPE when glom.document.locale is not in
700 the config file. This NPE will also happen if glom.document.locale is
703 The patch also updates the error message to display the class name when
704 the getMessage() returns null. This was happening when the NPE was
705 thrown and I had "Configuration Error: null". If an NPE is encountered
706 with this patch, "Configuration Error: NullPointerException " will be
709 This commit closes this bug:
711 https://bugzilla.gnome.org/show_bug.cgi?id=666669
713 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
715 2011-12-20 Murray Cumming <murrayc@murrayc.com>
717 Rename onlineglom.properties to onlineglom.properties.sample.
719 * src/main/resources/onlineglom.properties: Rename to:
720 * src/main/resources/onlineglom.properties.sample:
721 * src/main/resources/README: And add this file explaining that people
722 should rename it back when deploying.
724 2011-12-20 Murray Cumming <murrayc@murrayc.com>
726 Allow choosing the translation in the .properties file.
728 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
729 init(): Read a glom.document.locale value from the configuration file
730 and call Glom's TransatableItem::set_current_locale() method.
731 * src/main/resources/onlineglom.properties: Add a commented-out
732 example of this new setting.
734 It would be better to add &lang=de_DE to the URL, but the current
735 libglom API does not allow us to do this easily. I am working on that.
737 2011-12-19 Murray Cumming <murrayc@murrayc.com>
739 Avoid a crash in parsing of token parameters.
741 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
742 ava: getTokenParams(): Do not crash if a parameter has a key but no
743 value, and ignore parameters with neither.
745 2011-12-17 Murray Cumming <murrayc@murayc.com>
747 History token building/handling: Improve use of token parameters.
749 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
750 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
751 and buildParamsToken(HashMap), for use by derived classes.
752 Make the separator private because it is no longer be needed.
753 * src/main/java/org/glom/web/client/place/DetailsPlace.java
754 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
755 instead of manual string concatenation.
756 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
757 of hardcoded indices and awkward splitting code.
758 * src/main/java/org/glom/web/client/place/ListPlace.java
759 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
760 instead of manual string concatenation.
761 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
762 of hardcoded indices and awkward splitting code.
763 This should fix bug #666420
765 2011-12-16 Murray Cumming <murrayc@murrayc.com>
767 Fix a Navgiation->Navigation typo in the code.
769 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
770 Rename processNavgiation() to processNavigation().
772 2011-12-16 Murray Cumming <murrayc@murrayc.com>
774 Fix a seperator->separator typo in the code.
776 * src/main/java/org/glom/web/client/place/DetailsPlace.java
777 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
778 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
781 2011-12-15 Ben Konrath <ben@bagu.org>
783 Cleanup some comments.
785 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
787 2011-12-14 Ben Konrath <ben@bagu.org>
789 Replace \n with <br/> for multiline text in the details view.
791 Vertical scrollbars are added when needed as well.
793 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
795 2011-12-14 Ben Konrath <ben@bagu.org>
797 Specify the font for document selection links.
799 * src/main/webapp/style.css:
801 2011-12-14 Ben Konrath <ben@bagu.org>
803 Fix bouncy CellTable while paging.
805 This doesn't currently work with related list tables in unselected
808 * src/main/java/org/glom/web/client/ui/list/ListTable.java
810 2011-12-14 Ben Konrath <ben@bagu.org>
812 Revamp the appearance of the document selection page.
814 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
815 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
816 * src/main/webapp/style.css:
818 2011-12-13 Ben Konrath <ben@bagu.org>
820 Set navigation button column to the smallest size possible.
822 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
824 2011-12-13 Ben Konrath <ben@bagu.org>
826 Change OpenButton nomenclature to NavigationButton.
828 Using NavigtionButton makes things more generic. Classes, methods and
829 variables have been changed.
831 This is a rename-only refactor.
833 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
834 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
835 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
836 Renamed from OpenButtonCell.
837 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
838 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
839 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
841 2011-12-12 Ben Konrath <ben@bagu.org>
843 Remove unnecessary String argument in RelatedListTable and ListViewTable.
845 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
846 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
847 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
848 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
850 2011-12-12 Ben Konrath <ben@bagu.org>
852 Update variable names and comments.
854 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
855 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
857 2011-12-12 Ben Konrath <ben@bagu.org>
859 Properly initialize numNonEmptyRows variable to zero.
861 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
862 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
864 2011-12-05 Ben Konrath <ben@bagu.org>
866 Add latest mockup with HTML tables.
868 Features of this mockup:
870 -> HTML table for flowtable
871 -> HTML table for flowtable column
872 -> Example of how related lists would look
873 -> Not using text entries for data items
875 The current version of Online Glom doesn't use HTML tables for the
878 This mockup has been sent to the glom-devel mailing list but it's good
879 to have it here as well.
881 * mockups/details-view-html-tables.html:
883 2011-12-05 Ben Konrath <ben@bagu.org>
885 Remove unnecessary getPrimaryKeyField() method.
887 getPrimaryKeyFieldForTable(String) has been renamed to
888 getPrimaryKeyField(String).
890 * src/main/java/org/glom/web/server/database/DBAccess.java:
891 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
892 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
894 2011-12-05 Ben Konrath <ben@bagu.org>
896 Add string representation of TypedDataItem value to conversion error message.
898 * src/main/java/org/glom/web/server/Utils.java: Logging the error
899 message was extracted into its own method to avoid duplication.
901 2011-12-05 Ben Konrath <ben@bagu.org>
903 Add type checking to navigation primary key value creation.
905 Create navigation primary key only if the expected type from the Glom
906 document matches the type returned by the SQL query.
908 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
910 2011-12-05 Ben Konrath <ben@bagu.org>
912 Rename a couple of variables in RelatedListNavigation.
914 This is a rename-only refactor.
916 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
918 2011-12-05 Ben Konrath <ben@bagu.org>
920 Move getListLayoutGroup() into getListViewLayoutGroup().
922 This removes getListLayoutGroup(). It was only being called by
923 getListViewLayoutGroup().
925 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
927 2011-12-05 Ben Konrath <ben@bagu.org>
929 Remove check for LayoutItem_Portal in list table method.
931 This check is no longer necessary because the method isn't being used
932 to create the LayoutItemPortal DTO.
934 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
936 2011-12-05 Ben Konrath <ben@bagu.org>
938 Properly support related list navigation.
940 Navigation from the "Repository Analyzer -> Package Scans ->
941 Dependencies" related table wasn't working because the primary key for
942 related tables wasn't being set properly. This commit fixes the
945 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
946 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
947 doesn't set the primary key properly for related list tables.
948 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
949 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
950 useful for getting the primary key for list view tables and for related
952 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
953 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
954 Move code to set the primary key for the table from the abstract
955 ListDBAccess class to ListViewDBAccess as it's only correct for list
957 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
958 Properly add primary key to related list tables.
960 2011-12-02 Ben Konrath <ben@bagu.org>
962 Properly set the horizontal alignment of fields.
964 This fix is for both the list tables and the details view.
966 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
967 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
968 to set the horizontal alignment of fields.
970 2011-12-02 Ben Konrath <ben@bagu.org>
972 Display currency codes in the details view.
974 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
976 2011-12-02 Ben Konrath <ben@bagu.org>
978 Avoid duplicate JNI call.
980 JNI is not as efficient as pure Java and this is an easy (and small)
983 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
984 Use previously retrieved value for whereClauseToTableName instead of
987 2011-12-02 Ben Konrath <ben@bagu.org>
989 Rename a couple of variables in RelatedListNavigation.
991 This is a rename-only refactor.
993 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
995 2011-12-02 Ben Konrath <ben@bagu.org>
997 Indicate clearly that a mismatched primary key type is a bug.
999 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1000 warning to error. Add 'This is a bug.' to message.
1002 2011-12-02 Ben Konrath <ben@bagu.org>
1004 Update / fix some comments.
1006 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1008 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1010 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1011 Fix comments. Add some TODOs.
1013 2011-12-02 Ben Konrath <ben@bagu.org>
1015 Enable navigation to details view with string primary key from related list.
1017 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1018 Create a text primary key value when return type of result is
1019 java.sql.Types.VARCHAR.
1021 2011-12-02 Ben Konrath <ben@bagu.org>
1023 Use checkboxes for booleans in the details view.
1025 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1027 2011-12-01 Ben Konrath <ben@bagu.org>
1029 Improve performance of related list height calculation.
1031 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1032 Put code to calculate the expected height in a static initializer so
1033 that that it's only called once.
1035 2011-12-01 Ben Konrath <ben@bagu.org>
1037 Show related list tables in notebooks (again).
1039 Calculate the height of the related list tables so the Notebook can be
1040 set the correct height. The height of the related list table is also needed by
1041 FlowTable to be able decide how to create the layout.
1043 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1044 and set the Portal height based on the height of the related list
1045 table and the Portal container.
1046 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1047 Add method to calculate the height of the related list tables.
1048 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1049 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1050 calculate the height of the Pager widget.
1052 2011-12-01 Ben Konrath <ben@bagu.org>
1054 Use CellTable API for table property instead of setting style on Element.
1056 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1058 2011-12-01 Ben Konrath <ben@bagu.org>
1060 Make ListViewTable and RelatedListTable a consistent height.
1062 The tables are now a consistent height regardless of the contents of
1063 the table. A hidden button is added to empty rows to ensure that the
1064 height of these rows will match the height of rows with data.
1066 A navigation button column is now added to every table. The width of
1067 the navigation column is set to 0px when a RelatedListTable shouldn't
1068 have navigation buttons. This maintains the a consistent row height in
1069 tables that don't show the navigation buttons.
1071 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1072 navigation column when not needed.
1073 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1074 arguments for navigation button to constructor of ListViewTable.
1075 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1076 hidden button for empty data rows.
1077 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1078 arguments for navigation button to constructor.
1079 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1080 create navigation buttons. Add hideNavigationButtons() method.
1081 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1082 arguments for navigation button to constructor.
1084 2011-12-01 Ben Konrath <ben@bagu.org>
1086 Use 'visibility: hidden' in Utils.getWidgetHeight().
1088 This is better choice because hidden elements are invisible, don't
1089 respond to events and are not part of the tab order. They will,
1090 however, take up space which is required to be able to calculate the
1091 height of the widget.
1093 * src/main/java/org/glom/web/client/Utils.java:
1095 2011-12-01 Ben Konrath <ben@bagu.org>
1097 Use Utils.getWidgetHeight() in FlowTable.
1099 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1101 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1103 2011-12-01 Ben Konrath <ben@bagu.org>
1105 Put the details css class name on the correct table column.
1107 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1109 2011-11-30 Ben Konrath <ben@bagu.org>
1111 Update for java-libglom API change.
1113 The getters and setters on FieldFormatting and NumericFormat were
1114 changed to remove the 'M'.
1116 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1118 2011-11-29 Ben Konrath <ben@bagu.org>
1120 Only allow RelatedListTables in Portals.
1122 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1124 2011-11-29 Ben Konrath <ben@bagu.org>
1126 Only create a contents panel for Portals when title is being set.
1128 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1130 2011-11-29 Ben Konrath <ben@bagu.org>
1132 Set TabLayoutPanel height based on calculated height its widgets.
1134 This is a potential fix for this bug:
1136 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1138 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1140 2011-11-29 Ben Konrath <ben@bagu.org>
1142 Align details field labels and data with the Open buttons.
1144 * src/main/webapp/style.css:
1146 2011-11-29 Ben Konrath <ben@bagu.org>
1148 Remove unnecessary <div> in the Notebook widget.
1150 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1151 method to get container FlowPanel (<div>).
1152 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1153 initWidget() method directly on the TabLayoutPanel widget instead of
1154 Group's container widget.
1156 2011-11-29 Ben Konrath <ben@bagu.org>
1158 Don't add group titles for Portals in Notebooks.
1160 This reverts the previous patch and fixes a bug I introduced with
1161 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1163 * src/main/java/org/glom/web/client/ui/details/Group.java:
1164 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1166 2011-11-28 Ben Konrath <ben@bagu.org>
1168 Remove unused boolean argument in Portal constructor.
1170 Just a code cleanup.
1172 * src/main/java/org/glom/web/client/ui/details/Group.java:
1173 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1175 2011-11-28 Ben Konrath <ben@bagu.org>
1177 Remove hack for glom 1.18 style glom files.
1179 * src/main/java/org/glom/web/client/ui/details/Group.java:
1180 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1181 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1183 2011-11-28 Ben Konrath <ben@bagu.org>
1185 Use Gda Value version of primary key to log result too large error.
1187 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1189 2011-11-28 Ben Konrath <ben@bagu.org>
1191 Don't use TypedDataItem.getText() for Unknown types from the URL.
1193 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1194 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1195 instead of getText().
1196 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1197 String field and getUnknown() method.
1199 2011-11-28 Ben Konrath <ben@bagu.org>
1201 Log an error message when the java-libglom .so is not present.
1203 The error message was being set in the exception but not logged.
1205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1207 2011-11-28 Ben Konrath <ben@bagu.org>
1209 Ignore LayoutItem_CalendarPortals.
1211 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1212 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1214 2011-11-28 Ben Konrath <ben@bagu.org>
1216 Extract method for creating the LayoutItemPortal DTO.
1218 Just breaking the code up into smaller chunks.
1220 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1222 2011-11-28 Ben Konrath <ben@bagu.org>
1226 This should have been added with the refactor. Oops!
1228 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1230 2011-11-28 Ben Konrath <ben@bagu.org>
1232 Create primary key value from URL string using type from Glom document.
1234 See this bug, comments 19 - 25:
1236 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1238 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1239 create a TypeDataItem for the primary key here when loading from a
1240 URL. Show the same string for the primary key value as was received
1241 from the URL string (when loading from a URL).
1242 * src/main/java/org/glom/web/server/Utils.java: Update method for
1243 creating the Gda Value from the TypeDataItem to properly deal with
1244 creating a Gda Value based on the Glom document type for the primary
1245 key value string when loading from a URL.
1246 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1247 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1248 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1249 Update for changed method name.
1251 2011-11-27 Ben Konrath <ben@bagu.org>
1253 Rename PrimaryKeyItem to TypedDataItem.
1255 The name PrimaryKeyItem suggests what the class should be used for.
1256 TypedDataItem is a neutral name that describes the class better.
1258 This is a rename-only refactor.
1260 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1261 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1262 * src/main/java/org/glom/web/client/Utils.java:
1263 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1264 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1265 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1266 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1267 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1268 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1269 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1270 * src/main/java/org/glom/web/server/Utils.java:
1271 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1272 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1273 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1274 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1276 2011-11-25 Ben Konrath <ben@bagu.org>
1278 Improve Gda Value conversion from PrimaryKeyItem.
1280 The value from the PrimaryKeyItem is only used if its type match the
1281 type from the glom document.
1283 * src/main/java/org/glom/web/server/Utils.java:
1285 2011-11-25 Ben Konrath <ben@bagu.org>
1287 Manually check if the java-liblgom .so is visible to the JVM.
1289 It seems that Tomcat has problems when a static initializer throws an
1290 exception. This check is done before the first method call into
1291 java-libglom so that execution doesn't continue if the .so is not
1294 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1296 2011-11-25 Ben Konrath <ben@bagu.org>
1298 Improve browser configuration error messages.
1302 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1304 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1305 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1306 getConfigurationErrorMessage() method.
1307 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1308 Get and display a specific configuration error message when no Glom
1309 documents are found.
1310 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1311 Implement getConfigurationErrorMessage() method. Surround configuration
1312 code in the init() method with a try/catch block. This allows the
1313 errors to be caught while keeping the servlet available to retrieve the
1314 configuration error message.
1316 2011-11-25 Ben Konrath <ben@bagu.org>
1318 Don't use Strings to hold primary key values.
1320 The primary key values are now held in a new data object
1321 (PrimaryKeyItem) that holds type information and the primary key value
1322 using the correct type.
1324 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1325 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1327 PrimaryKeyItem instead of String to hold the primary key value.
1328 * src/main/java/org/glom/web/client/Utils.java: Remove
1329 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1330 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1331 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1332 PrimaryKeyItem instead of String to hold the primary key value. Load
1333 document selection page when the documentID has not been set correctly.
1334 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1335 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1337 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1338 Return empty string for URL instead of "null".
1339 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1340 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1341 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1342 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1343 PrimaryKeyItem instead of String to hold primary key values.
1344 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1345 PrimaryKeyValue to a Gda Value.
1346 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1347 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1348 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1349 Replace temporary database access code that uses the PrimaryKeyValue to
1350 Gda Value conversion.
1351 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1352 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1353 PrimaryKeyItem instead of String.
1354 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1355 hold primary key values.
1357 2011-11-24 Ben Konrath <ben@bagu.org>
1359 Use newly added java-libglom API to create queries.
1361 This isn't finished. I still need to stop using Strings for primary key
1362 values in the client code.
1364 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1365 libglom to use fake connections so that retrieving the query string will
1367 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1368 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1369 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1370 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1371 Use the newly added libglom sql methods and classes to create the
1372 query. Add temporary hack to convert primary value strings to Gda
1375 2011-11-23 Ben Konrath <ben@bagu.org>
1377 Don't explicitly set the height of Portals.
1379 See comments 6 - 10 of this bug for details:
1381 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1383 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1385 2011-11-23 Ben Konrath <ben@bagu.org>
1387 Use an HTML table instead of CSS for the FlowTable layout.
1389 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1390 GWT's FlexTable to implement the FlowTable.
1391 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1393 2011-11-18 Ben Konrath <ben@bagu.org>
1395 Add boolean example to HTML table mockup.
1397 * mockups/details-view-html-tables-text-entries.html:
1399 2011-11-17 Ben Konrath <ben@bagu.org>
1401 Ensure the pager buttons are always visible for related lists.
1403 To accomplish this, I've turned off text wrapping in the list view and
1404 related list tables for both the header and data text. The related list
1405 table now has a fixed layout so the it doesn't overflow its container.
1406 This is required to ensure that the cell text is clipped when it
1407 overflows the cell and an ellipsis is added to the right side of the
1408 cell when text is clipped.
1410 A fixed table layout for the related list table in the details view
1411 seems what we want for the details view anyway, so the side-effect is
1414 The ellipsis will only be displayed in Firefox >= 7.
1418 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1420 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1421 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1422 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1424 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1425 Set the 'table-layout: fixed' CSS property to the related list table.
1426 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1427 'white-space: nowrap;' CSS property on both the list view and the
1428 related list tables.
1430 2011-11-16 Ben Konrath <ben@bagu.org>
1432 Rework the fix for empty notebook tab labels.
1434 Setting the empty group titles with its name caused problems for the
1435 details layout. Instead of using libglom's
1436 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1437 to the client when the title is empty. This allows the Notebook to use
1438 the name when the title is empty without affecting anything else.
1440 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1441 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1443 2011-11-16 Ben Konrath <ben@bagu.org>
1445 Set group titles with name when title is empty.
1447 This fixes a problem with an empty notebook tab label in the Lesson
1448 Planner document. The forth tab in the notebook should be "Internet":
1450 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1452 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1453 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1456 2011-11-16 Ben Konrath <ben@bagu.org>
1458 Remove whitespace from the configured username properties.
1460 This assumes that usernames won't have whitespace at the beginning
1461 or end. But I think this is a reasonable assumption.
1463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1464 String.trim() to remove the whitespace from the username properties.
1466 2011-11-15 Ben Konrath <ben@bagu.org>
1468 Add details view mockup with HTML tables and text entries.
1470 This is from the attachment on this bug:
1472 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1474 * mockups/details-view-html-tables-text-entries.html:
1476 2011-11-15 Ben Konrath <ben@bagu.org>
1478 Add space between the columns of the flow table.
1482 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1484 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1485 space between columns in the flow table.
1487 2011-11-15 Ben Konrath <ben@bagu.org>
1489 Add backup files to the .gitignore.
1491 * .gitignore: Ignore files that end with ~.
1493 2011-11-09 Ben Konrath <ben@bagu.org>
1495 Use latest release of gwt-log.
1497 Gwt-log releases are now being submitted to the maven central
1498 repository so manual installation of the jar is no longer required.
1500 * pom.xml: Update version and groupId of gwt-log dependency.
1502 2011-10-31 Ben Konrath <ben@bagu.org>
1504 Don't use GWT numeric formatting to override the glom currency formatting.
1506 Currencies are now displayed like they are in Glom. See this bug:
1508 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1510 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1512 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1513 currency code to constructor and set it when the cell is rendered.
1514 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1515 currency code to the constructor of the NumericCell.
1517 2011-10-27 Ben Konrath <ben@bagu.org>
1519 Require the latest release of java-libglom (1.17.4).
1523 2011-10-26 Ben Konrath <ben@bagu.org>
1525 Add style to Notebook that matches current theme.
1527 It's not the best style in the world but it's better than the default.
1529 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1530 padding at the bottom of the child widgets.
1531 * src/main/webapp/style.css: Add style for the Notebook.
1533 2011-10-26 Ben Konrath <ben@bagu.org>
1535 Move servlet initialization code to overridden init method.
1537 This is half of the solution to getting proper error messages
1538 displayed when configuration errors occur. Here's the relevant bug:
1540 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1542 The rest of the solution involves surrounding the init method with a
1543 try/catch block and setting a global variable with the error /
1544 exception. A new async method should be created to retrieve and display
1545 the error message / exception.
1547 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1548 code from constructor to init method adding exceptions as needed.
1550 2011-10-26 Ben Konrath <ben@bagu.org>
1552 Add script to monitor and restart tomcat if required.
1554 * utils/check-and-recover-tomcat.py: New file.
1556 2011-10-26 Ben Konrath <ben@bagu.org>
1558 Display the correct number of data items in the pager.
1562 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1564 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1565 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1566 The implementation is the same for both tables: Keep track of the
1567 number of non-empty rows and fire and RowCountChangeEvent after the data has
1569 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1570 custom Pager class that subclasses SimplePager to handle displaying
1571 the correct number when empty rows have been added.
1573 2011-10-26 Ben Konrath <ben@bagu.org>
1575 Correct error in previous commit.
1577 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1578 eventBus parameter from listView.setCellTable().
1580 2011-10-26 Ben Konrath <ben@bagu.org>
1582 Fix error in TODO comment.
1584 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1586 2011-10-24 Ben Konrath <ben@bagu.org>
1588 Create Notebook widgets to the details view.
1590 This isn't finished just yet - I still need to create a reasonable
1591 style to match the current theme.
1593 * src/main/java/org/glom/web/client/Utils.java: Add method for
1594 calculating the height of a widget. This is used in the Notebook class.
1595 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1596 new constructor method in Group.
1597 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1598 method for creating child widget that can be used by subclasses
1599 like Notebook. New constructor that allows disabling the group
1600 titles - Notebooks don't set a group title for their child groups.
1601 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1602 to make Notebooks using GWT's TabLayoutPanel.
1603 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1604 constructor that allows disabling the group titles.
1605 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1606 LayoutItemNotebook DTO.
1607 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1608 DTO for Notebooks. It's just an empty class for now but we might need
1609 it to transfer some specific information in the future.
1611 2011-10-21 Ben Konrath <ben@bagu.org>
1613 Add navigation buttons to related list tables.
1615 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1616 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1617 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1618 method getSuitableRecordToViewDetails() for getting the table name
1619 and primary key value for related list navigation buttons.
1620 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1621 private cell renderer class to get the navigation information for
1622 related list tables from the server. Extract the navigation
1623 processing code from the details cell navigation and use it for the
1624 related list navigation as well.
1625 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1626 cell renderer class for the details open buttons. This was needed
1627 because the related list navigation buttons and the list view
1628 navigation buttons need to react differently when clicked.
1629 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1630 the onEnterKeyDown() method because it's now overriden in the
1631 subclasses that are specific to the related list tables and the list
1633 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1634 the vertical size a little because the buttons add a bit of vertical
1635 space to table. This is not a perfect solution because the vertical
1636 size of with table fewer than 5 rows will be a little smaller.
1637 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1638 changes in how navigation buttons are handled.
1639 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1640 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1641 database access object.
1642 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1643 to find the portal for a given relationship name from
1644 RelatedListDBAccess. Add method to find a primary key field for a
1646 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1647 Move code to find the portal for a given relationship name to
1649 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1650 New file: database access object for getting the related list
1651 navigation information (the table name and the primary key value).
1652 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1653 DTO for transferring a table name to navigate to and a primary key
1655 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1656 boolean and getter/setter to specifies if the related list should add
1659 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1661 Use the master branch of java-libglom
1663 * pom.xml: Depend on java-libglom 1.19 instead.
1665 This is the master branch. See also the libglom-1-18 branch.
1667 2011-10-11 Ben Konrath <ben@bagu.org>
1669 Enable the open navigation button when the data has been set.
1671 This avoids having active buttons that don't do anything when the data
1674 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1676 2011-10-11 Ben Konrath <ben@bagu.org>
1678 Use IsWidget interface for FlowTableItem.
1680 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1681 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1683 2011-10-11 Ben Konrath <ben@bagu.org>
1685 Remove GWT styling from open button in details view.
1687 There are still some issues with how the details cell is arranged but
1688 this should be made to match Glom 1.20. I'm going to leave fixing this
1689 until I have Glom 1.20 up and running.
1691 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1692 style name on open button.
1693 * src/main/webapp/style.css: Move and edit details-navigation class.
1694 Re-arrange some classes to make them appear in the same order as the
1697 2011-10-07 Ben Konrath <ben@bagu.org>
1699 Update to GWT 2.4.0.
1701 * .gitignore: Ignore new cache directory.
1702 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1703 * pom.xml: Change GWT and maven plugin to 2.4.0.
1704 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1706 * src/main/java/org/glom/web/client/ClientFactory.java:
1707 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1708 * src/main/java/org/glom/web/client/OnlineGlom.java:
1709 Update source for API changes.
1710 * utils/build-onlineglom-war.sh: Remove cache directory before the
1713 2011-10-07 Ben Konrath <ben@bagu.org>
1715 Add navigation buttons in the details view.
1717 This isn't finished but I thought I'd commit what I have as it's a
1718 pretty good start. I still need to:
1720 1. Change the style so that it fits better into the current theme
1721 2. Adjust the details cell to expand as much as possible.
1723 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1724 click handlers to navigation buttons in the DetailsCells. Create a
1725 refreshData() method to get just the data from the server without the
1727 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1728 Update the tableSelector and browser title when the table name
1729 changes without using the tableSelector.
1730 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1731 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1732 getDetailsCells() to getCells(). Update variable names.
1733 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1734 method to set click handler on navigation button. Rename a few
1735 variables. Add navigation buttons where needed.
1736 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1737 variables and methods.
1738 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1739 navigation boolean and navigation table as required in the
1740 LayoutItemField DTO.
1741 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1742 variables for navigation along with getter/setter methods.
1744 2011-10-07 Ben Konrath <ben@bagu.org>
1746 Rename Field to DetailsCell.
1748 This is a refactor-only commit. No functionality has been added or
1751 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1752 Update variable and method names.
1753 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1754 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1755 variable and method names.
1756 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1758 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1759 variable and method names.
1761 2011-10-07 Ben Konrath <ben@bagu.org>
1763 Create separate methods for layout and data the details view.
1765 This is a refactor-only commit. No functionality has been added or
1768 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1769 private methods: setData(), createLayout().
1771 2011-10-07 Ben Konrath <ben@bagu.org>
1773 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1775 This is part of a change to get navigation buttons in the details view
1776 but it should have been done this way from the start.
1778 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1779 for method name change in TableSelectionView.
1780 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1781 Create TableChangeEvent and set the browser title using the
1782 TableSelectionView API.
1783 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1784 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1785 Change getSelectedTable() to getSelectedTableName(). Add
1786 getSelectedTableTitle().
1788 2011-10-07 Ben Konrath <ben@bagu.org>
1790 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1792 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1794 2011-10-07 Ben Konrath <ben@bagu.org>
1796 Update TableChangeEvent to use newTableName naming convention.
1798 This makes the class more consistent with GWT naming conventions.
1800 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1801 Update for method name change in TableChangeEvent.
1802 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1803 for method name change in TableChangeEvent.
1804 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1805 newTableName variable and getter method. Make toDebugString()
1808 2011-09-30 Ben Konrath <ben@bagu.org>
1810 Disable the pager in the list tables when the data row count is less than the minimum.
1812 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1813 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1815 2011-09-30 Ben Konrath <ben@bagu.org>
1817 Add empty rows to the end of related list and list view tables.
1819 I also extracted the cell rendering classes from the ListTable because
1820 the code was becoming a little crazy with all the anonymous inner
1821 classes. My plan is to use these cell rendering classes in the details
1822 view as well so this refactor will be needed for that change.
1824 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1825 set the row count in related list tables if the data has more rows
1826 than the minimum number of rows visible.
1827 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1828 row count in list view tables if the data has more rows than the
1829 minimum number of rows visible.
1830 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1831 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1833 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1834 for rendering TYPE_NUMERIC cells. The code was extracted from the
1836 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1837 class for rendering cells with buttons in list views. The code was
1838 extracted from the ListTable class.
1839 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1840 for rendering TYPE_TEXT cells. The code was extracted from the
1842 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1843 Add empty rows to the end of the data if required. Implement
1844 ListTable.getMinNumVisibleRows().
1845 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1846 cell renderer code to public classes. Return null in
1847 Column.getValue() for empty rows. Add new abstract method:
1848 getMinNumVisibleRows(). Move code to set the row count of the list view
1849 table to ListViewImpl.
1850 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1851 empty rows to the end of the data if required. Implement
1852 ListTable.getMinNumVisibleRows().
1855 2011-09-27 Ben Konrath <ben@bagu.org>
1857 Use GWT.log for client-side debugging statements.
1859 These are optimized out when deployed so I should have used this method
1860 in the first place. These statements will eventually be replaced with some sort
1861 of notification in the browser.
1863 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1864 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1865 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1866 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1867 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1869 2011-09-27 Ben Konrath <ben@bagu.org>
1871 Put tableselector on the right, back to list link on right.
1873 The idea is that the table selector is acting like a label for the
1874 currently displayed table so it should be placed below the document title. This
1875 puts the table title in a similar position to where it is in Glom.
1877 * mockups/details-contacts.html:
1878 * mockups/details-projects.html:
1879 * mockups/listview-contacts.html:
1880 * mockups/listview-projects.html:
1881 * mockups/style.css:
1882 Update mockups to match how the interfaces currently look.
1883 * src/main/webapp/style.css: Swap positions of backlink with the table
1884 selector. Add some space on the left side of the table selector to
1885 line things up with the document title.
1887 2011-09-27 Ben Konrath <ben@bagu.org>
1889 Add field colouring to details view.
1891 This change re-works how field colouring works. The colour formatting
1892 information is now set to the client with the layout information instead of
1893 with the data. This eliminates the need to send the same colour strings for
1894 data in list view column when colour information is set.
1896 In order to set an alternate colour for negative numeric values, the
1897 number is now sent to client and formatted with the GWT NumberFormat class.
1899 This change also fixes:
1901 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1903 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1904 internationalization framework which is needed for client side numeric
1906 * src/main/java/org/glom/web/client/Utils.java: New file for some
1907 client static utility methods.
1908 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1909 the DataItem object to the Field class. Use a utility method to
1910 create the foreignKeyValue string.
1911 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1912 alignment and text colours in the constructor. Add setData(DataItem)
1913 method. Remove setText(String) method.
1914 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1915 colour information to GlomTextCell. Create and use GlomNumberCell for
1916 rendering numbers. Use utility method to get the string for the
1917 primary key of the key provider. Re-work how the horizontal alignment
1919 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1920 formatting to layout information. Methods for converting the libglom
1921 formatting information were moved from DBAccess.
1922 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1923 numeric formatting (it's now done on the client side). Don't set text
1924 colours in DataItem. Move libglom formatting conversion methods to
1926 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1927 getters/setters for text colour information.
1928 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1929 for transferring the libglom NumericFormat information to the client.
1930 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1931 and getters/setters for: GlomNumericFormat, background colour and
1932 foreground colour strings.
1934 2011-09-26 Ben Konrath <ben@bagu.org>
1936 Simplify code that iterates through the LayoutGroup.
1938 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1940 2011-09-26 Ben Konrath <ben@bagu.org>
1942 Accept Eclipse formatting for OnlineGlomServiceAsync.
1944 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1946 2011-09-26 Ben Konrath <ben@bagu.org>
1948 Don't use the ListDBAccess classes to get the primary key layout information.
1950 This was causing a bug where the wrong index for the hidden primary key
1951 was being sent to the client.
1953 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1954 primary key while creating the LayoutGroup DTO. Create a
1955 LayoutItemField DTO for hidden primary keys. Don't use the
1956 RelatedListDBAccess because it was only used for getting the primary
1958 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1959 access modifier from public to protected for getPrimaryKeyField() and
1960 getPrimaryKeyLayoutItemField().
1961 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1962 abstract method getExpectedResultSize() because RelatedListDBAccess
1963 doesn't have enough info to implement it.
1964 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1965 Remove @Override for getExpectedResultSize().
1966 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1967 Remove method getExpectedResultSize().
1969 2011-09-23 Ben Konrath <ben@bagu.org>
1971 Log which layout (list or details) the ignored item is from.
1973 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1975 2011-09-23 Ben Konrath <ben@bagu.org>
1977 Remove annotations that turn off code formatting in DataItem.
1979 * src/main/java/org/glom/web/shared/DataItem.java:
1981 2011-09-23 Ben Konrath <ben@bagu.org>
1983 Rename GlomField to DataItem and update associated methods.
1985 This is a rename-only refactor. No functionality has been added or
1988 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1989 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1990 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1991 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1992 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1993 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1994 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1995 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1996 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1997 * src/main/java/org/glom/web/server/database/DBAccess.java:
1998 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1999 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2000 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2001 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2002 * src/main/java/org/glom/web/shared/DataItem.java:
2003 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2004 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2006 2011-09-23 Ben Konrath <ben@bagu.org>
2008 Rename GlomDocument to DocumentInfo and update associated methods.
2010 This is a rename-only refactor. No functionality has been added or
2013 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2014 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2015 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2016 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2017 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2018 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2019 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2021 2011-09-20 Ben Konrath <ben@bagu.org>
2023 Require java-libglom 1.17.3.
2025 This picks up the fix for the seg fault problem with the Scenes table
2026 in the Openismus Film Manager example.
2030 2011-09-20 Ben Konrath <ben@bagu.org>
2032 Change the way sort clause is added for primary key when no sort clause is requested.
2034 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2035 before the sort clause is created. When a sort clause is not requested, the
2036 sort clause is created by finding the primary key in the LayoutFieldVector
2039 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2041 2011-09-20 Ben Konrath <ben@bagu.org>
2043 Log error message if no documents are found in the configured directory.
2045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2046 Extract the glom file extension string to a private static final class
2047 variable (mostly as syntactic sugar). Accept a minor formatting change.
2048 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2049 the example glom.document.directory configuration property to make it
2050 more clear that it can any directory, not just the home directory.
2052 2011-09-18 Ben Konrath <ben@bagu.org>
2054 Add related lists to details view.
2056 The related list table has support for paging and sorting just like the
2057 table in the list view.
2059 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2060 SQL queries for the related list tables.
2061 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2062 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2063 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2064 Rename getList methods to getListView and add comments. Remove
2065 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2066 it being unused. Add methods: getDetailsLayoutAndData(),
2067 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2068 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2069 Create the layout and set the data for the fields in one async call
2070 instead of two. Create related lists where appropriate.
2071 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2072 for method name changes in OnlineGlomService.
2073 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2074 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2075 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2077 * src/main/java/org/glom/web/client/ui/ListView.java:
2078 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2079 tableName from setCellTable(). Create a ListViewTable instead of
2081 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2082 represent a data field in the details view.
2083 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2084 from addDetailsCell() to Field class. Keep track of the Fields and
2085 Portals in the details view.
2086 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2087 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2088 and add a method to get it. Add method to set the contents of the
2090 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2091 New class for related list tables. This class has the data provider
2092 for the related list table.
2093 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2094 abstract class which is the base class for the ListViewTable and the
2096 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2097 New class for list view tables. This class has the data provider for
2098 the list view table.
2099 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2100 methods for related list tables. Add more information to the
2101 LayoutItemField and LayoutItemPortal DTOs.
2102 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2103 Remove debugging print statement.
2104 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2105 Remove debugging print statements. Add primary key field to SQL count
2107 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2108 Remove unnecessary LayoutFieldVector parameter from
2109 getResultSizeOfSQLQuery() method.
2110 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2111 New class for related list table database access.
2112 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2113 class that is a wrapper DTO for details view layout and data.
2114 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2115 new 'fromField' string to this DTO.
2116 * src/main/webapp/style.css: Remove bottom margin and override top
2119 2011-09-15 Ben Konrath <ben@bagu.org>
2121 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2123 This sets things up to make it easier to add the data retrieval for
2124 related lists (portals). No user noticeable changes were made with
2127 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2128 class has the code to retrieve the layouts and access the
2129 database using the new database helper classes.
2130 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2131 Most of the functionality has been removed from this class. This
2132 class now represents the public interface for the client side
2133 code. It also deals with configuring the servlet and cleaning
2134 things up when the servlet is stopped.
2135 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2136 of static methods into this utility class.
2137 * src/main/java/org/glom/web/server/database/DBAccess.java:
2138 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2139 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2140 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2141 These classes have the database retrieval code. The class hierarchy
2142 has been setup to make it easy to reuse code for similar
2145 2011-09-06 Ben Konrath <ben@bagu.org>
2147 Create separate classes for list table code and the data provider.
2149 As part of this refactor, I also split up the code a bit to make it
2152 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2153 table code to two new classes (below).
2154 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2155 with code from ListViewImpl.
2156 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2157 New file with code from ListViewImpl.
2159 2011-09-06 Ben Konrath <ben@bagu.org>
2161 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2163 This fixes the LayoutItemPortal DTO to match the libglom layout object
2166 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2168 2011-09-01 Ben Konrath <ben@bagu.org>
2170 Set title of Portals in the Details View.
2172 * pom.xml: Bump required version of java-libglom to 1.17.1.
2173 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2174 widget creation to its own class. Add comments to constructor.
2175 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2176 The code is mostly from the Group class with the title now set.
2177 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2178 title of Portal. Update some comments. Fix some code formatting.
2180 2011-09-01 Ben Konrath <ben@bagu.org>
2182 Remove TODO comment for the flow table column width.
2184 The flow table column width is working correctly and doesn't need to be
2185 changed. See this mailing list post for more info:
2187 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2189 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2191 2011-08-27 Ben Konrath <ben@bagu.org>
2193 Add document title (database name) to top of the browser page.
2195 I added the document title to the TableSelecitonView but that will
2196 change if / when we add a view that doesn't require table selection.
2198 * mockups/details-contacts.html:
2199 * mockups/details-projects.html:
2200 * mockups/listview-contacts.html:
2201 * mockups/listview-projects.html:
2202 * mockups/style.css: Add document title to mockups to keep things
2204 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2205 sizes to account for the document title.
2206 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2207 Set the document title when it has been retrieved from the server.
2208 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2209 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2210 and implement setDocumentTitle(String) method.
2211 * src/main/webapp/style.css: Add ID for document title style.
2213 2011-08-25 Ben Konrath <ben@bagu.org>
2215 Add NavigationType enum to LayoutItemPortal DTO.
2217 This is the start of adding support for Portals to the Details View.
2219 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2220 LayoutItem_Portal.navigation_type enum from libglom to
2221 LayoutItemPortal.NavigationType enum.
2222 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2223 NavigationType enum, field for storing the NavigationType and getter
2226 2011-08-25 Ben Konrath <ben@bagu.org>
2228 Implement the flow table layout in the Details View.
2230 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2231 FlowTable to Group to account for the renamed class.
2232 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2233 File. This is a container widget that implements the Glom details view
2234 flow table behaviour.
2235 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2236 org/glom/web/client/ui/FlowTable.java.
2237 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2238 so that the size of the subgroups are a closer match to the size of
2239 the Glom subgroups. This makes the flowtable layout match the layout
2240 in Glom for the Music Collection example file.
2242 2011-08-16 Ben Konrath <ben@bagu.org>
2244 Create container element for LayoutItemPortal in Details View.
2246 This will help me develop the layout for the FlowTable.
2248 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2249 fieldPanel variable to detailsCell.
2251 2011-08-15 Ben Konrath <ben@bagu.org>
2253 Set the height of the data element in the Details View.
2255 I changed the InlineLabels (text in a span element) to Labels (text in
2256 a div element) so that I could set the height of the details-data
2257 elements instead of the details-cell parent elements. This allows the
2258 the details-data element to display the correct height if style is
2259 applied that shows the height.
2261 This change has the added benefit of allowing the order of the labels
2262 and data elements to be changed for right-to-left languages.
2264 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2265 InlineLabels to Labels.
2266 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2267 InlineLabels to Labels. Set the height of the data element.
2268 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2269 multiline text height in the Formatting DTO.
2270 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2271 for multiline height along with getter and setter methods.
2272 * src/main/webapp/style.css: Adjust style to account for the change
2273 from span elements to div elements in the details cell.
2275 2011-08-15 Ben Konrath <ben@bagu.org>
2277 Make the List View appearance match the mockups.
2279 It doesn't match exactly but it's much better than it was.
2281 * mockups/listview-contacts.html: Remove unused css classes.
2282 * mockups/listview-projects.html: Remove unused css classes.
2283 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2284 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2285 for mainPanel instead of VerticalPanel (table). Set style name on
2286 CellTable. Set style name on Details column. Right-align Details
2288 * src/main/webapp/style.css: Adjust properties to match the mockups.
2290 2011-08-12 Ben Konrath <ben@bagu.org>
2292 Add better support for subgroups in the details view.
2294 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2295 changed FlowTable constructor.
2296 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2297 support for subgroups and subgroup-titles.
2298 * src/main/webapp/style.css: Add CSS class for subgroups and
2301 2011-08-12 Ben Konrath <ben@bagu.org>
2303 Return the top level LayoutGroup title.
2305 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2307 2011-08-11 Ben Konrath <ben@bagu.org>
2309 Make the TableSelector header match the mockup.
2311 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2312 the layout panel. Properly lineup the table selection header with
2313 the list and details view.
2314 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2315 margin around the details view.
2316 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2317 Rename listBox variable to tableSelector. Set id for the style sheet.
2318 Use a FlowPanel instead of a HorizontalPanel.
2319 * src/main/webapp/style.css: Add properties to make the TableSelector
2320 box match the mockups.
2322 2011-07-13 Ben Konrath <ben@bagu.org>
2324 Update install script for java-libglom version change.
2326 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2329 2011-07-13 Ben Konrath <ben@bagu.org>
2331 Add support sub-group in the details view.
2333 I also removed the code that special-cased the default details view
2336 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2338 I still have to make a proper flowtable.
2340 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2341 Don't special-case default details view layout.
2342 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2343 addLayoutField() as I'm going to use it.
2344 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2345 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2347 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2348 extracted from DetailsViewImpl.GroupPanel. Add support for
2350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2351 column count when getting the details layout.
2353 2011-07-12 Ben Konrath <ben@bagu.org>
2355 Set browser title with database and table titles.
2357 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2358 Set the browser title when the table changes and when the activity
2360 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2361 title when retrieving document info (the GlomDocument object).
2362 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2363 with getter and setter methods. Remove unused convenience constructor.
2364 Use default code formatting.
2366 2011-07-12 Ben Konrath <ben@bagu.org>
2368 Ignore LayoutItemPortals in the details view.
2370 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2373 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2374 LayoutItemPortal layout objects.
2375 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2376 LayoutItemPortal objects when retrieving the details layout.
2377 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2378 file. This is an empty class and just used to get type information for
2381 2011-07-12 Ben Konrath <ben@bagu.org>
2383 Use java-libglom 1.17.0.
2387 2011-07-11 Ben Konrath <ben@bagu.org>
2389 Remove "Table:" label from table selector.
2391 This matches a recent change in the Glom UI.
2393 * mockups/details-contacts.html:
2394 * mockups/details-projects.html:
2395 * mockups/listview-contacts.html:
2396 * mockups/listview-projects.html: Remove the "Table:" label from the
2398 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2400 2011-07-11 Ben Konrath <ben@bagu.org>
2402 Add main groups to the details view.
2404 This makes things look a little nicer in the details view. The next step
2405 is to implement the flowtable.
2407 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2408 resources from the standard gwt css theme. Standard.css is now
2409 included in OnlineGlom.html so that the online glom css rules have
2410 precedence over the gwt theme.
2411 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2412 the whole LayoutGroup to the DetailsView instead of just the titles.
2413 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2414 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2415 details layout with a helper class (GroupPanel). I might extract this
2416 class when I make the full flowtable.
2417 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2418 string as default so I don't have to worry about NPEs when processing
2420 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2421 note beside OnlineGlom.gwt.xml above).
2422 * src/main/webapp/style.css: Add default font-size to body to override
2423 the font-size set by the standard theme. Don't use h2 tags for
2424 group-title. Create new details-cell class.
2426 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2428 ConfiguredDocument: Set the port number too.
2430 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2431 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2432 Glom document. Presumably this worked sometimes so far because there is a
2433 default port number.
2435 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2437 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2439 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2440 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2441 correct, though we should throw an exception too.
2443 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2445 Fix a addDocuemnt typo.
2447 * src/main/java/org/glom/web/shared/Documents.java
2448 (Documents.addDocuemnt): Rename to addDocument().
2449 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2450 (OnlineGlomServiceImpl.getDocuments): Adapt.
2452 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2454 Slightly improved log output when connection fails.
2456 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2457 (ConfiguredDocument.setUsernameAndPassword):
2458 We don't know for sure if it' the username/password that's wrong, so
2459 rephrase the message.
2460 Also ouput the exception message, though it's generic in this case.
2462 2011-07-08 Ben Konrath <ben@bagu.org>
2466 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2467 added braces to a one line if statement because the Eclipse formatter
2468 was getting confused.
2470 2011-07-07 Ben Konrath <ben@bagu.org>
2472 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2474 These should really be two separate tasks but I counldn't get things to
2475 work with GWT 2.2.0 and Eclipse 3.7.
2479 * .settings/org.eclipse.jdt.core.prefs:
2480 * .settings/org.eclipse.jdt.ui.prefs:
2481 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2482 * .settings/org.eclipse.m2e.core.prefs:
2483 Add new config files. Update current files. Remove references to the
2484 webtools plugins as we're not using any of the webtools features.
2485 * .gitignore: Add logs directory which is created when running with
2487 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2488 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2489 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2491 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2493 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2495 onlineglom.properties: Add explanatory comments.
2497 * src/main/resources/onlineglom.properties: Also change the default user
2498 from ben to someuser, to avoid the risk of people thinking we just
2499 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2501 2011-06-28 Ben Konrath <ben@bagu.org>
2503 Use filename in Log for incorrect passwords.
2505 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2506 getFileName(String) method to get the filename from the URI.
2508 2011-06-28 Ben Konrath <ben@bagu.org>
2510 Add the table name to the URL token for the ListPlace.
2512 This makes things consistent between the DetailsPlace and the
2513 ListPlace. It also allows the the ListPlace to be bookmarked.
2515 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2516 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2518 Remove getDefaultListLayout(). The default layout is now returned
2519 by the getListLayout() method when the table name is an empty string.
2520 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2521 Add table name field. Change to a new ListPlace when the table
2522 has been changed. Use getListLayout() for getting the default
2524 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2525 Add table name field. Set the correct table name in the list box
2526 when loading from bookmark. This corrects a problem for the
2528 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2529 Move table name to super-class (HasSelectableTable). Move document
2530 and table URL keys to super-class in HasSelectableTable.
2531 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2532 Add table name field. Add Tokenizer class with URL key common to
2533 the subclasses (DetailsPlace and ListPlace).
2534 * src/main/java/org/glom/web/client/place/ListPlace.java:
2535 Add table name. Add code to parse the URL token.
2536 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2537 Update ListPlace construction with empty table name string.
2538 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2539 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2540 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2541 Update ListPlace construction with table name string.
2542 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2543 Change defaultTableName field to tableName to reflect how it's now
2544 used. Update the getter and setter methods.
2546 2011-06-28 Ben Konrath <ben@bagu.org>
2548 Enable the table selector in the DetailsView.
2550 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2551 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2552 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2553 Remove getDefaultDetailsLayout(). The default layout is now returned
2554 by the getDetailsLayout() method when the table name is an empty
2556 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2557 event handler for table change event. Change to using
2558 getDetailsLayout() for the default details layout.
2559 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2561 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2562 when navigating to the details place.
2564 2011-06-27 Ben Konrath <ben@bagu.org>
2566 Use filename based unique document ID in URL and for RPC.
2568 The document ID is the glom document name with spaces (' ') replaced
2569 with pluses ('+') and without the .glom extension.
2571 This change is mostly a string substitution of 'documentTitle' for
2572 'documentID'. The only code change is the addition of a Documents DTO to get the
2573 filename to document title mappings as indicated below.
2575 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2576 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2577 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2578 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2579 Use Documents DTO to create the document links in the document
2581 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2582 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2583 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2584 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2585 * src/main/java/org/glom/web/client/place/ListPlace.java:
2586 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2587 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2588 * src/main/java/org/glom/web/client/ui/ListView.java:
2589 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2590 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2591 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2592 * src/main/java/org/glom/web/server/Log.java:
2593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2594 getDocumentTitles() to getDocuments() and return the Documents DTO.
2595 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2596 transferring the filename to document title mappings.
2598 2011-06-25 Ben Konrath <ben@bagu.org>
2600 Make the authentication popup work again.
2602 This bug was introduced when I extracted ConfiguredDocument to its own class.
2604 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2605 correct success / fail status in setUsernameAndPassword().
2607 2011-06-25 Ben Konrath <ben@bagu.org>
2609 Use filename as unique key for configuring database usernames and passwords.
2611 This replaces the use of the Glom document title which could change
2612 depending on the locale. Thanks to Murray Cumming for pointing out this
2615 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2616 * src/main/resources/onlineglom.properties:
2618 2011-06-24 Ben Konrath <ben@bagu.org>
2620 Pass primary key value to DetailsView.
2622 This enables the DetailsView to load the correct data.
2624 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2625 primary key value field and set in constructor. Pass primary key
2626 value to getDetailsData().
2627 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2628 variables for document title and primary key value.
2629 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2630 key value to the DetailsPlace.
2632 2011-06-24 Ben Konrath <ben@bagu.org>
2634 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2636 This allows the primary key to be retrieved by the Details button. This
2637 functionality has not been implemented yet but it's in the works.
2639 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2640 the LayoutGroup result to ListView.setCellTable instead of all of its
2641 fields individually.
2642 * src/main/java/org/glom/web/client/ui/ListView.java:
2643 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2644 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2645 get the primary key for the table.
2646 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2647 index of the primary key in the LayoutGroup accounting for hidden
2648 primary keys. Rename getJavaNumberFormat() to
2649 convertToJavaNumberFormat() for consistency. Cleanup / add some
2651 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2652 field for primary key index and a field to indicate whether the
2653 primary key is hidden or not.
2655 2011-06-23 Ben Konrath <ben@bagu.org>
2657 Rename getTableData methods to getListData.
2659 This is a rename refactor for consistency with other methods.
2661 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2662 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2663 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2664 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2666 2011-06-23 Ben Konrath <ben@bagu.org>
2668 Extract the ConfiguredDocument innerclass into its own class.
2670 This makes the servlet code more object oriented.
2672 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2673 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2674 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2675 new ConfiguredDocument class.
2677 2011-06-21 Ben Konrath <ben@bagu.org>
2679 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2681 This makes things more inline with how libglom works and reduces code
2682 duplication. This refactor lays the groundwork for adding the primary key to
2683 the LayoutGroup object.
2685 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2686 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2687 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2688 Change method names to getListLayout and getDefaultListLayout for
2689 consistency. Use LayoutGroup as the DTO for the list layout instead of
2690 ColumnInfo and LayoutListTable.
2691 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2692 new method names along with the LayoutGroup object for transferring the
2694 * src/main/java/org/glom/web/client/ui/ListView.java:
2695 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2696 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2697 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2699 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2700 Replaced with LayoutGroup.
2701 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2702 expectedResultSize and defaultTableName fields which are needed for
2704 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2705 type field which is needed for the list layout but will also be
2706 useful for the details layout as things progress.
2707 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2708 Make class abstract. Remove the unnecessary
2709 getFormattingHorizontalAlignment method. Add setFormatting method.
2711 2011-06-16 Ben Konrath <ben@bagu.org>
2713 Add scripts for building and installing war.
2715 These will help when updating OnlineGlom but they're also good
2716 supplemental documentation of the build and deployment proceeding.
2718 * utils/build-onlineglom-war.sh: New file.
2719 * utils/install-onlineglom-war.sh: New file.
2721 2011-06-16 Ben Konrath <ben@bagu.org>
2723 Create wrapper class to create consistent log messages.
2725 I wrapped methods in the Log class of gwt-log to add the method names
2726 from the servlet and create consistent formatting of the document title
2727 and table names in the log messages.
2729 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2731 log methods to use methods from wrapped Log class.
2733 2011-06-16 Ben Konrath <ben@bagu.org>
2735 Remove superfluous conditional return.
2737 Thanks to Murray Cumming for pointing this out!
2739 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2741 2011-06-15 Ben Konrath <ben@bagu.org>
2743 Return an ArrayList of LayoutGroups for the Details layout.
2745 This corrects a problem with the details layout as it can have more
2746 than one top level LayoutGroup.
2748 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2749 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2750 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2751 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2752 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2753 with ArrayList of LayoutGroups for the details view layout.
2754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2755 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2756 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2757 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2758 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2759 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2761 2011-06-14 Ben Konrath <ben@bagu.org>
2763 Use cast_dynamic method to determine the libglom LayoutItem type.
2765 This is better than finding the LayoutItem type by using the string
2766 returned from the get_part_type_name() method.
2768 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2770 2011-06-14 Ben Konrath <ben@bagu.org>
2772 Add method names to log entries in the servlet.
2774 This helps when tracking down deployment problems.
2776 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2778 2011-06-14 Ben Konrath <ben@bagu.org>
2780 Add data to the DetailsView using a hard-coded primary key value.
2782 The layout and functionality of the DetailsView is not complete. This
2783 is just a checkpoint so the patch doesn't get too big.
2785 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2786 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2787 Add getDetailsData() servlet method.
2788 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2789 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2790 LayoutFields are added to the DetailsView.
2791 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2792 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2793 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2794 take the string for the title instead of the object.
2795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2796 Add implementation getDetailsData() along with some private helper
2798 * src/main/webapp/style.css: Add padding to details-data class. Add a
2799 details-label class with the same padding as the details-data class.
2801 2011-06-03 Ben Konrath <ben@bagu.org>
2803 Use presenter.goTo() to change to the DetailsPlace.
2805 This will make things easier when we need to open the DetailsView with
2806 data specific to the row that was clicked.
2808 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2810 2011-06-02 Ben Konrath <ben@bagu.org>
2812 Add CSS file from mockups.
2814 I'm adding this now because it's going to be useful to have when
2815 developing the DetailsView. The TableSelectionView and ListView aren't
2818 * src/main/webapp/OnlineGlom.html:
2819 * src/main/webapp/style.css:
2821 2011-06-02 Ben Konrath <ben@bagu.org>
2823 Use String.isEmpty() to check for empty string.
2825 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2827 2011-06-02 Ben Konrath <ben@bagu.org>
2829 Display main layout group titles in the DetailsView.
2831 This is the start of the DetailsActivity/DetailsView implementation.
2833 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2834 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2835 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2836 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2837 Get the layout information for the details view from the server and set
2838 the main layout group titles.
2839 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2840 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2841 Add addLayoutGroup() and addLayoutField() methods. This are just
2842 temporary methods for creating the the details view that will change
2844 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2845 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2847 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2848 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2849 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2850 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2851 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2852 Data Transfer Objects that mimic the libglom object structure. These are
2853 used for transferring the details layout but could also be used for
2854 transferring the list layout.
2856 2011-05-27 Ben Konrath <ben@bagu.org>
2858 Reset the AuthenticationPopup when clearing the ListView.
2860 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2862 2011-05-27 Ben Konrath <ben@bagu.org>
2864 Fix problem with onlineglom.properties file loading.
2866 The old way worked in Eclipse but not on the server. Loading the
2867 onlineglom.properties file now works in Eclipse and on the server.
2869 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2871 2011-05-24 Ben Konrath <ben@bagu.org>
2873 Update gwt-log from 3.1.0 to 3.1.2.
2875 Gwt-log 3.1.0 has been marked as depreciated.
2879 2011-05-24 Ben Konrath <ben@bagu.org>
2881 Add comment to ListActivity.goTo() method.
2883 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2885 2011-05-24 Ben Konrath <ben@bagu.org>
2887 Remove FIXME in convertGdkColorToHtmlColour()
2889 The Gdk::Color value returned by libglom is 16-bits per channel on both
2890 64 and 32-bit platforms.
2892 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2894 2011-05-19 Ben Konrath <ben@bagu.org>
2896 Improve performance of initial ListView load.
2898 I removed a round trip to the server for getting the default table name
2899 and then requesting information about that table. This also removes a potential
2900 problem with the table change handler not being setup in time to receive the
2901 table change event from the ListActivity.
2903 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2904 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2905 getDefaultLayoutListTable() method. Improve comments.
2906 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2907 getDefaultLayoutListTable() method instead of firing a table change
2908 event to get the table to load.
2909 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2910 implementation of getDefaultLayoutListTable() method.
2911 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2914 2011-05-19 Ben Konrath <ben@bagu.org>
2916 Override toDebugString() in TableChangeEvent.
2918 This is useful to have for debugging.
2920 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2922 2011-05-19 Ben Konrath <ben@bagu.org>
2924 Add a "Back to List" link when at the DetailsPlace.
2926 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2927 Populate the CellTable based on the selected table of the ListBox if
2928 it's set otherwise use the default table. This allows the "Back to
2930 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2931 Remove Place from constructors. Add a setPlace() method. Add
2932 goToPlace() method. Set class as presenter for TableSelectionView.
2933 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2934 Use the same TableSelectionActivity when switching between the List and
2936 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2937 Subclass the new HasSelectableTablePlace. This removes some duplicate
2939 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2940 New class to represent Places that display the TableSelectionView.
2941 * src/main/java/org/glom/web/client/place/ListPlace.java:
2942 Subclass the new HasSelectableTablePlace. This removes some duplicate
2944 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2945 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2946 Add Presenter interface. Add setBackLinkVisible() method. Add
2947 setBackLink() method.
2949 2011-05-18 Ben Konrath <ben@bagu.org>
2951 Enable the "Details" buttons.
2953 Right now only an empty details view is displayed.
2955 * src/main/java/org/glom/web/client/ClientFactory.java:
2956 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2957 Add DetailsView to ClientFactory.
2958 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2959 A basic activity for the details view.
2960 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2961 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2963 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2964 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2966 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2967 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2968 unnecessary super() in constructor.
2969 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2970 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2971 really shouldn't create a new TableSelectionActivity for both the ListPlace
2972 and the DetailsPlace so this should be considered a temporary solution.
2973 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2974 New file. Represents a URL for the details view.
2975 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2976 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2977 A basic details view interface and implementation.
2978 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2979 Enable the "Details" buttons.
2981 2011-05-12 Ben Konrath <ben@bagu.org>
2983 Use a LayoutPanel with multiple display areas for main layout.
2985 This is mostly a refactor in that there are no changes from the user
2986 point of view. These changes are required so that we can swap out the list view
2987 with the details view when the user clicks the "Details" button.
2989 * src/main/java/org/glom/web/client/ClientFactory.java:
2990 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2991 OnlineGlomView. Add TableSelectionView, ListView and
2992 AuthenticationPopup.
2993 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2994 for main layout. Add display regions for main activities. Add
2995 activity manager for for main activities.
2996 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2997 file from parts of the deleted OnlineGlomActivity.
2998 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2999 New file from parts of the deleted OnlineGlomActivity.
3000 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3001 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3002 New files for app wide table change event.
3003 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3004 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3005 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3006 Activity mappers for the main activities replace the deleted app-wide
3008 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3009 Fix a spelling error in he comment.
3010 * src/main/java/org/glom/web/client/ui/ListView.java:
3011 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3012 Renamed from LayoutListView and modified for MVP. This still not a
3013 proper dumb view as prescribed by the MVP pattern but it works for now.
3014 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3015 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3016 New widget stripped out of the deleted OnlineGlomView.
3017 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3018 Remove hack that is fixed by this patch.
3020 2011-05-06 Ben Konrath <ben@bagu.org>
3022 Rename OnlineGlomPlace to ListPlace.
3024 The only change besides the rename is that url will now display #list
3025 instead of #Document.
3027 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3028 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3029 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3030 * src/main/java/org/glom/web/client/place/ListPlace.java:
3031 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3033 2011-05-06 Ben Konrath <ben@bagu.org>
3035 Use Presenter for app navigation.
3037 This is the proper way to deal with Place (URL) changes with the MVP
3040 * src/main/java/org/glom/web/client/ClientFactory.java:
3041 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3042 PlaceHistoryMapper and PlaceHistoryHandler.
3043 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3044 PlaceHistoryMapper and PlaceHistoryHandler.
3045 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3046 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3047 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3048 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3049 Add Presenter interface and setPresenter methods. Rename addHyperLink
3050 to addDocumentLink taking only the document title as a parameter.
3052 2011-04-14 Ben Konrath <ben@bagu.org>
3054 Prompt for db username/password if they haven't been set.
3056 This is implemented with a popup widget that is contained within the
3057 OnlineGlomView and managed by the OnlineGlomActivity.
3059 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3060 methods for checking and setting the database username and password.
3061 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3062 new methods for checking and setting the database username and
3064 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3065 Display authentication popup if the JDBC connection to the database
3066 has not been authenticated.
3067 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3069 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3070 for dealing with the authentication popup.
3071 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3072 Implement the methods for dealing with the authentication popup.
3073 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3074 try to executed queries if the database connection hasn't been
3075 authenticated. Implement methods for checking and setting the
3076 database username and password.
3078 2011-04-12 Ben Konrath <ben@bagu.org>
3080 Make log messages a little clearer.
3082 Add a dash betweeen the document title and the table name.
3084 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3086 2011-04-12 Ben Konrath <ben@bagu.org>
3088 Protect against NPEs when cleaning up database resources.
3090 While this isn't strictly necessary because the exception is caught,
3091 not protecting against the NPEs makes it harder to find the real error
3094 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3096 2011-04-12 Ben Konrath <ben@bagu.org>
3098 Move configuration of the servlet to the constructor.
3100 The servlet will be initialized even if the database authentication
3101 information is not set or correct. I still need to add the UI for prompting
3102 the user for the authentication information when it's required.
3104 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3105 javadocs for getDocumentTitles() method.
3106 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3107 Set error message when RPC fails.
3108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3109 glom files directory from the configuration file. Try to set the
3110 database authentication information for the specific document if it's
3111 set and works otherwise try to use the global authentication
3112 information set for the directory.
3113 * src/main/resources/onlineglom.properties: Moved from
3114 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3115 Added detailed comments for the new keys.
3117 2011-04-11 Ben Konrath <ben@bagu.org>
3119 Remove unnecessary @Override in DocumentSelectionViewImpl.
3121 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3123 2011-04-11 Ben Konrath <ben@bagu.org>
3125 Remove center alignment in DocumentSelectionView.
3127 The title element is still centred but the document titles and bottom
3128 sentence are both left-aligned.
3130 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3132 2011-04-11 Ben Konrath <ben@bagu.org>
3134 Change 'Demo' naming convention to 'Document'.
3136 This is just a rename refactor with no functional changes to the code.
3138 * src/main/java/org/glom/web/client/ClientFactory.java:
3139 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3140 * src/main/java/org/glom/web/client/OnlineGlom.java:
3141 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3142 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3143 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3144 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3145 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3146 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3147 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3148 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3149 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3152 2011-04-08 Ben Konrath <ben@bagu.org>
3154 Remove FIXME from safeLongToInt() method.
3156 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3161 2011-04-08 Ben Konrath <ben@bagu.org>
3163 Display an error if no glom documents are found in the specified directory.
3165 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3166 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3167 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3170 2011-04-08 Ben Konrath <ben@bagu.org>
3172 Add copyright header to one more file ... oops.
3174 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3176 2011-04-08 Ben Konrath <ben@bagu.org>
3178 Add copyright header to files without it.
3180 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3181 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3182 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3183 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3184 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3185 * src/main/java/org/glom/web/shared/GlomField.java:
3187 2011-04-08 Ben Konrath <ben@bagu.org>
3189 Add support for accessing multiple glom documents in the servlet.
3191 This completes the demo selection functionality.
3193 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3194 document title to methods.
3195 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3196 document title to methods.
3197 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3198 Set browser window title when the activity starts. Correct name of
3199 document title variable.
3200 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3201 Set browser window title when the activity starts. Set the table
3202 selector change handler after table selector has been set. Clear the
3203 OnlineGlomView when the activity has been stopped.
3204 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3205 document title as the place token. Use "#Document:" instead of
3206 "#OnlineGlomPlace:" in the URL.
3207 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3208 Change heading to "Online Glom"
3209 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3210 document title in RPC methods.
3211 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3212 setDocumentTitle() method. Add clear() method.
3213 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3214 setDocumentTitle() method. Implement clear() method which removes the
3215 change handler on the ListBox, clears the ListBox and clears the
3217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3218 Implement methods with document title. Keep track for the configured
3219 glom documents and their corresponding JDBC configurations in a hash
3220 table. This information is retrieved using the document title as the
3221 key in the hash table.
3222 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3223 document title field as it's no longer needed.
3225 2011-04-08 Ben Konrath <ben@bagu.org>
3227 Update the Eclipse JDT configuration.
3229 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
projects / online-glom:gwt-glom.git / blob