1 2012-01-17 Murray Cumming <murrayc@murrayc.com>
3 Allow use of translations via, for instance, &lang=de in the URL.
5 * pom.xml: Use the unstable java-libglom 1.21 version.
7 * src/main/java/org/glom/web/client/OnlineGlomService.java:
8 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
9 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
10 init(): Instead of calling TranslatableItem.set_current_locale()
11 (now removed), call ConfiguredDocument.setDefaultLocaleID().
12 However, this is only for default locales, which are not needed to
13 change the locale in the URL.
14 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
15 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
16 getSortedRelatedListData(): Add a localeID parameter, so we can get the
17 layout for a particular locale.
18 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
19 Add get/setDefaultLocaleID().
20 getDocumentInfo(), getListViewData(), getRelatedListData(),
21 getDetailsLayoutGroup(), getListViewLayoutGroup(),
22 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
23 localeID parameter, so we can get the layout for a particular locale.
25 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
26 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
27 * src/main/java/org/glom/web/client/place/ListPlace.java:
28 Parse and construct a lang parameter too.
30 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
31 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
32 passed to subsequent methods and constructors.
33 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
34 * src/main/java/org/glom/web/client/activity/ListActivity.java:
35 Store the localeID from the *Place and pass it to other constructors
36 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
38 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
39 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
40 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
41 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
42 * src/main/java/org/glom/web/client/ui/ListView.java:
43 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
44 Take localeID parameters and pass them to subsequent constructors and
45 methods, so that the layout is always retrieved for that locale.
47 This is rather repetitive.
49 Note that "" means the original (default) locale of the Glom document,
50 which is usually English.
52 2012-01-17 Murray Cumming <murrayc@murrayc.com>
54 Documents: Remove final keyword to fix startup configuration.
56 * src/main/java/org/glom/web/shared/Documents.java: Remove the
57 final keywords on the private member variables because that breaks
58 the startup, apparently (there are warnings) because it stops them
59 from being serialized. I added these in the previous commit.
61 2012-01-13 Murray Cumming <murrayc@murrayc.com>
63 Documents: Add some final keywords.
65 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
68 2012-01-13 Murray Cumming <murrayc@murrayc.com>
70 OnlineGlomServiceImpl: Add to overview comments.
72 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
73 Note that this is where all the document are loaded. They are not
74 loaded freshly for each page.
76 2012-01-12 Murray Cumming <murrayc@murrayc.com>
80 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
81 Add a TextBox for the text of a quick find.
82 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
84 setBackLink(): Add a String quickFind parameter.
85 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
86 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
87 to the base interface, because that is how TableSelectionViewImpl is used.
88 * src/main/webapp/style.css: Add style for the search box and its label.
90 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
91 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
92 Add these files, based on the existing TableChangeEvent and
93 TableChangeEventHandlers.
94 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
95 start(): Handle QuickFindChangeEvent, passing its quickFind text to
96 a ListPlace() that the user should be taken to.
97 * src/main/java/org/glom/web/client/activity/ListActivity.java
98 start(): Handle it here too and adapt the TableChangeEvent handler to
99 pass the extra "" quickFind parameter to ListPlace.
100 * src/main/java/org/glom/web/client/place/ListPlace.java:
101 Constructor: Take an extra String quickFind parameter and store it,
102 returning it from a new getQuickFind() method.
103 getToken(): Put the quickFind text in the URL token.
104 getPlace(): Parse the quickFind text from the URL token.
105 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
106 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
107 ListPlace constructor.
108 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
109 .java: start(): Add a Change handler for the TableSelectionView's
110 TextBox (via its base HasChangeHandlers interface), firing the new
111 QuickFindChangeEvent.
112 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
113 pass the extra "" quickFind parameter.
115 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
116 setCellTable(): Add a String quickFind parameter and pass it to
117 the ListViewTable() constructor.
118 * src/main/java/org/glom/web/client/ui/ListView.java: Change
119 setCellTable() in the base interface, because that is how ListViewImpl
122 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
123 Add a String quickFind member variable.
124 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
125 Constructor: Add a String quickFind parameter, storing it in the
126 base ListTable's member variable.
127 onRangeChanged(): Pass quickFind to the
128 OnlineGlomServiceAsync.getSortedListViewData() and
129 OnlineGlomServiceAsync.getListViewData() methods.
131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
132 getListViewData(), getSortedListViewData(): Add a String quickFind
133 parameter, passing it to ConfiguredDocument.getListViewData().
134 * src/main/java/org/glom/web/client/OnlineGlomService.java:
135 Change getListViewData(), getSortedListViewData() in the base interface,
136 because that is how OnlineGlomServiceImpl is used, via this:
137 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
138 Change getListViewData(), getSortedListViewData() here too.
139 This class can apparently be used to asynchronously call methods on
140 OnlineGlomService, and GWT seems to implement that after recognizing
141 just the *Async name convention and the extra AsyncCallback parameters.
143 * src/main/java/org/glom/web/server/ConfiguredDocument.java
144 getListViewData(): Add a String quickFind parameter, and pass it to
145 ListViewDBAccess.getData().
146 * src/main/java/org/glom/web/server/database/ListDBAccess.java
147 getListData(): Add a String quickFind parameter and pass it to
149 getSelectQuery(): Add a String quickFind parameter.
150 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
151 getSelectQuery(): Add a String quickFind parameter and use it with
152 Glom.get_find_where_clause_quick() to pass a where_clause to
153 Glom.build_sql_select_with_where_clause(), to actually filter the
155 getData(): Add a String quickFind parameter, passing it to getListData().
156 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
157 va: getData(): Pass an empty string to getListData() for the
160 2012-01-12 Murray Cumming <murrayc@murrayc.com>
162 ListTable: Minor change.
164 * src/main/java/org/glom/web/client/ui/list/ListTable.java
165 createCellTable(): Make this protected instead of public.
167 2012-01-12 Murray Cumming <murrayc@murrayc.com>
169 Many files: Use final for the parameters and use the @override attribute.
171 2012-01-22 Ben Konrath <ben@bagu.org>
173 Add anchor links for single line text that starts with http, ftp and www.
177 2012-01-22 Ben Konrath <ben@bagu.org>
179 Add ellipsis to single line text in details view.
183 2012-01-04 Murray Cumming <murrayc@murrayc.com>
185 Remove all javadoc author tags.
187 Because they are awkward and meaningless when many people touch
189 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
191 2012-01-04 Murray Cumming <murrayc@murrayc.com>
193 Revert the COPYING.LESSER to COPYING rename.
195 Apparently both should be there if it is LGPL.
197 2012-01-03 Murray Cumming <murrayc@murrayc.com>
199 *View: Remove unused imports.
201 * src/main/java/org/glom/web/client/ui/DetailsView.java:
202 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
203 * src/main/java/org/glom/web/client/ui/ListView.java:
204 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
205 Remove unused imports, as suggested by Eclipse.
207 2012-01-02 Murray Cumming <murrayc@murrayc.com>
209 Move the *View::Presenter types, and some API into one base View.
211 * src/main/java/org/glom/web/client/ui/DetailsView.java:
212 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
213 * src/main/java/org/glom/web/client/ui/ListView.java:
214 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
215 Presenter, setPresenter() and clear() into a shared base interface,
216 to avoid the unnecessary duplicate Presenter types and to more clearly
217 show how the *Views share the same structure, even if they are not
218 used polymorphically.
220 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
221 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
223 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
224 * src/main/java/org/glom/web/client/activity/ListActivity.java:
225 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
227 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
230 Feel free to revert this if there is a good reason for the duplicate
233 2012-01-02 Murray Cumming <murrayc@murrayc.com>
235 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
237 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
238 a class member instead of a local variable in the method.
239 This lets us use it to get the view instances, for use in tests.
240 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
241 beforeOnlineGlom(): Test some more details of the initial view.
242 Again, this is not very useful.
244 To really test gwt-glom we will need to start a local postgresql
245 instance with local data, like the Glom tests in C++.
247 2012-01-02 Murray Cumming <murrayc@murrayc.com>
249 pom.xml: Mention the LGPL license.
251 * pom.xml: Add a licenses section.
252 * COPYING.LESSER: Move this to COPYING, which
253 previously contained the GPL. But gwt-glom is all LGPL.
255 2012-01-02 Murray Cumming <murrayc@murrayc.com>
257 Add project information to README and pom.xml.
259 * README: Add a brief description and mention some mvn
261 * pom.xml: This extra information shows up in mvn site
264 2011-01-02 Murray Cumming <murrayc@murrayc.com>
266 Use the latest java-libglom version.
268 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
270 2012-01-01 Murray Cumming <murrayc@murrayc.com>
272 GwtTestOnlineGlom: Test a little more.
274 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
275 protected rather than private, as suggested by the gwt-test-utils
277 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
278 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
279 Test the initial visibility of the panels.
281 However, this is not a very useful test.
282 And I wonder how we should generally test using this idea for an
283 activity/places app like ours where the real changes happen implicitly
284 based on the history token/URL.
286 2012-01-01 Murray Cumming <murrayc@murrayc.com>
288 Slight modification to *Mapper comments.
290 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
292 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
294 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
296 Remove comments mentioning GIN because they are just copied from
297 the example code and are apparently not helpful:
298 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
299 Also change the mention of a class that is only in the example code.
301 2012-01-01 Murray Cumming <murrayc@murrayc.com>
303 GwtTestOnlineGlom test: Minor changes.
305 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
306 Avoid the long qualified class name and modify the comment
307 because it is now obvious to me that the mocked class is the only
308 custom one created via GWT.create().
310 2012-01-01 Murray Cumming <murrayc@murrayc.com>
312 Tests: Added the beginnings of a test using gwt-test-utils.
314 * pom.xml: Add dependencies on gwt-test-utils and easymock.
315 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
316 which tells gwt-test-utils what class will be tested.
317 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
318 Add a simple (but empty) test case. One class, used by the OnlineGlom
319 class, is mocked so that it can be created. However, I am not sure
320 why only this class needs to be mocked.
322 Note that mockito seems more popular, and clearer, than easymock,
323 but I have not got that working yet. It might be a matter of the
326 This test is run during mvn integration-test.
328 2011-12-31 Murray Cumming <murrayc@murrayc.com>
330 Tests: Use junit4-style syntax instead of junit3-style.
332 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
333 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
334 * src/test/java/org/glom/web/shared/DataItemTest.java:
335 Use the @Test annotation rather than relying on the test*() prefix.
336 Also no longer implement TestCase, to avoid triggering support for
337 the junit3-way, which stops the annotations from working.
338 Change the imports from import junit.framework.* to
339 import org.junit.*, which is apparently the new way.
341 2011-12-31 Murray Cumming <murrayc@murrayc.com>
343 Added a test for ListPlace token parsing and creation.
345 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
346 This is much the same as DetailsPlaceTest.
348 I wonder how we could test the other parts of the *Place API.
350 2011-12-30 Murray Cumming <murrayc@murrayc.com>
352 DetailsPlace test: Also test getToken() and recreation via getPlace().
354 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
355 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
356 recreate it, testing the recreated DetailsPlace for the same parameter
359 2011-12-30 Murray Cumming <murrayc@murrayc.com>
361 Use the surefire-report plugin.
363 * pom.xml: This generates a HTML report about the tests in
364 target/site/surefire-report.html
365 when you do mvn surefire-report:report. It seems to be popular/normal.
367 2011-12-30 Murray Cumming <murrayc@murrayc.com>
369 Added a test for DetailsPlace.
371 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
372 Test the getPlace() token parsing.
374 2011-12-30 Murray Cumming <murrayc@murrayc.com>
376 Added a first unit test.
378 * pom.xml: Add a test goal, and a dependency on junit in that scope.
379 * src/test/java/org/glom/web/shared/DataItemTest.java:
380 This is a silly test but it is just to get things started. Note that
381 maven/junit finds the test because it looks in src/test by default.
383 2011-12-22 Ben Konrath <ben@bagu.org>
385 Change charsetName to "UTF-8" when replacing line breaks.
387 JavaScript requires the charsetName to be "UTF-8". CharsetName values
388 that work in Java (such as "UTF8") will not work when compiled to
391 This fixes a problem with multi-line details view fields that have hard
392 line breaks. The "License Text" field on this page demonstrates the
395 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
397 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
399 2011-12-22 Ben Konrath <ben@bagu.org>
401 Fix another bug with related list navigation.
403 I've tested all the navigation buttons in all of the related lists
404 so things should be good now.
406 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
408 2011-12-22 Ben Konrath <ben@bagu.org>
410 Fix a crasher when refreshing the list view with the default table.
412 This crash will also happen when loading the list view with the default
413 table from a link or bookmark.
415 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
416 to the main document selection page when the document id hasn't been
418 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
419 the main document selection page when the document id hasn't been
421 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
422 values for the details place when the document id hasn't been set.
423 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
424 values for the list place when the document id hasn't been set.
426 2011-12-21 Ben Konrath <ben@bagu.org>
428 Protect against NPE when glom.document.locale is not in config.
430 This patch protects against an NPE when glom.document.locale is not in
431 the config file. This NPE will also happen if glom.document.locale is
434 The patch also updates the error message to display the class name when
435 the getMessage() returns null. This was happening when the NPE was
436 thrown and I had "Configuration Error: null". If an NPE is encountered
437 with this patch, "Configuration Error: NullPointerException " will be
440 This commit closes this bug:
442 https://bugzilla.gnome.org/show_bug.cgi?id=666669
444 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
446 2011-12-20 Murray Cumming <murrayc@murrayc.com>
448 Rename onlineglom.properties to onlineglom.properties.sample.
450 * src/main/resources/onlineglom.properties: Rename to:
451 * src/main/resources/onlineglom.properties.sample:
452 * src/main/resources/README: And add this file explaining that people
453 should rename it back when deploying.
455 2011-12-20 Murray Cumming <murrayc@murrayc.com>
457 Allow choosing the translation in the .properties file.
459 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
460 init(): Read a glom.document.locale value from the configuration file
461 and call Glom's TransatableItem::set_current_locale() method.
462 * src/main/resources/onlineglom.properties: Add a commented-out
463 example of this new setting.
465 It would be better to add &lang=de_DE to the URL, but the current
466 libglom API does not allow us to do this easily. I am working on that.
468 2011-12-19 Murray Cumming <murrayc@murrayc.com>
470 Avoid a crash in parsing of token parameters.
472 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
473 ava: getTokenParams(): Do not crash if a parameter has a key but no
474 value, and ignore parameters with neither.
476 2011-12-17 Murray Cumming <murrayc@murayc.com>
478 History token building/handling: Improve use of token parameters.
480 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
481 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
482 and buildParamsToken(HashMap), for use by derived classes.
483 Make the separator private because it is no longer be needed.
484 * src/main/java/org/glom/web/client/place/DetailsPlace.java
485 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
486 instead of manual string concatenation.
487 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
488 of hardcoded indices and awkward splitting code.
489 * src/main/java/org/glom/web/client/place/ListPlace.java
490 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
491 instead of manual string concatenation.
492 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
493 of hardcoded indices and awkward splitting code.
494 This should fix bug #666420
496 2011-12-16 Murray Cumming <murrayc@murrayc.com>
498 Fix a Navgiation->Navigation typo in the code.
500 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
501 Rename processNavgiation() to processNavigation().
503 2011-12-16 Murray Cumming <murrayc@murrayc.com>
505 Fix a seperator->separator typo in the code.
507 * src/main/java/org/glom/web/client/place/DetailsPlace.java
508 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
509 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
512 2011-12-15 Ben Konrath <ben@bagu.org>
514 Cleanup some comments.
516 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
518 2011-12-14 Ben Konrath <ben@bagu.org>
520 Replace \n with <br/> for multiline text in the details view.
522 Vertical scrollbars are added when needed as well.
524 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
526 2011-12-14 Ben Konrath <ben@bagu.org>
528 Specify the font for document selection links.
530 * src/main/webapp/style.css:
532 2011-12-14 Ben Konrath <ben@bagu.org>
534 Fix bouncy CellTable while paging.
536 This doesn't currently work with related list tables in unselected
539 * src/main/java/org/glom/web/client/ui/list/ListTable.java
541 2011-12-14 Ben Konrath <ben@bagu.org>
543 Revamp the appearance of the document selection page.
545 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
546 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
547 * src/main/webapp/style.css:
549 2011-12-13 Ben Konrath <ben@bagu.org>
551 Set navigation button column to the smallest size possible.
553 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
555 2011-12-13 Ben Konrath <ben@bagu.org>
557 Change OpenButton nomenclature to NavigationButton.
559 Using NavigtionButton makes things more generic. Classes, methods and
560 variables have been changed.
562 This is a rename-only refactor.
564 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
565 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
566 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
567 Renamed from OpenButtonCell.
568 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
569 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
570 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
572 2011-12-12 Ben Konrath <ben@bagu.org>
574 Remove unnecessary String argument in RelatedListTable and ListViewTable.
576 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
577 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
578 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
579 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
581 2011-12-12 Ben Konrath <ben@bagu.org>
583 Update variable names and comments.
585 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
586 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
588 2011-12-12 Ben Konrath <ben@bagu.org>
590 Properly initialize numNonEmptyRows variable to zero.
592 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
593 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
595 2011-12-05 Ben Konrath <ben@bagu.org>
597 Add latest mockup with HTML tables.
599 Features of this mockup:
601 -> HTML table for flowtable
602 -> HTML table for flowtable column
603 -> Example of how related lists would look
604 -> Not using text entries for data items
606 The current version of Online Glom doesn't use HTML tables for the
609 This mockup has been sent to the glom-devel mailing list but it's good
610 to have it here as well.
612 * mockups/details-view-html-tables.html:
614 2011-12-05 Ben Konrath <ben@bagu.org>
616 Remove unnecessary getPrimaryKeyField() method.
618 getPrimaryKeyFieldForTable(String) has been renamed to
619 getPrimaryKeyField(String).
621 * src/main/java/org/glom/web/server/database/DBAccess.java:
622 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
623 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
625 2011-12-05 Ben Konrath <ben@bagu.org>
627 Add string representation of TypedDataItem value to conversion error message.
629 * src/main/java/org/glom/web/server/Utils.java: Logging the error
630 message was extracted into its own method to avoid duplication.
632 2011-12-05 Ben Konrath <ben@bagu.org>
634 Add type checking to navigation primary key value creation.
636 Create navigation primary key only if the expected type from the Glom
637 document matches the type returned by the SQL query.
639 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
641 2011-12-05 Ben Konrath <ben@bagu.org>
643 Rename a couple of variables in RelatedListNavigation.
645 This is a rename-only refactor.
647 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
649 2011-12-05 Ben Konrath <ben@bagu.org>
651 Move getListLayoutGroup() into getListViewLayoutGroup().
653 This removes getListLayoutGroup(). It was only being called by
654 getListViewLayoutGroup().
656 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
658 2011-12-05 Ben Konrath <ben@bagu.org>
660 Remove check for LayoutItem_Portal in list table method.
662 This check is no longer necessary because the method isn't being used
663 to create the LayoutItemPortal DTO.
665 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
667 2011-12-05 Ben Konrath <ben@bagu.org>
669 Properly support related list navigation.
671 Navigation from the "Repository Analyzer -> Package Scans ->
672 Dependencies" related table wasn't working because the primary key for
673 related tables wasn't being set properly. This commit fixes the
676 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
677 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
678 doesn't set the primary key properly for related list tables.
679 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
680 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
681 useful for getting the primary key for list view tables and for related
683 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
684 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
685 Move code to set the primary key for the table from the abstract
686 ListDBAccess class to ListViewDBAccess as it's only correct for list
688 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
689 Properly add primary key to related list tables.
691 2011-12-02 Ben Konrath <ben@bagu.org>
693 Properly set the horizontal alignment of fields.
695 This fix is for both the list tables and the details view.
697 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
698 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
699 to set the horizontal alignment of fields.
701 2011-12-02 Ben Konrath <ben@bagu.org>
703 Display currency codes in the details view.
705 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
707 2011-12-02 Ben Konrath <ben@bagu.org>
709 Avoid duplicate JNI call.
711 JNI is not as efficient as pure Java and this is an easy (and small)
714 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
715 Use previously retrieved value for whereClauseToTableName instead of
718 2011-12-02 Ben Konrath <ben@bagu.org>
720 Rename a couple of variables in RelatedListNavigation.
722 This is a rename-only refactor.
724 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
726 2011-12-02 Ben Konrath <ben@bagu.org>
728 Indicate clearly that a mismatched primary key type is a bug.
730 * src/main/java/org/glom/web/server/Utils.java: Change log level from
731 warning to error. Add 'This is a bug.' to message.
733 2011-12-02 Ben Konrath <ben@bagu.org>
735 Update / fix some comments.
737 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
739 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
741 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
742 Fix comments. Add some TODOs.
744 2011-12-02 Ben Konrath <ben@bagu.org>
746 Enable navigation to details view with string primary key from related list.
748 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
749 Create a text primary key value when return type of result is
750 java.sql.Types.VARCHAR.
752 2011-12-02 Ben Konrath <ben@bagu.org>
754 Use checkboxes for booleans in the details view.
756 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
758 2011-12-01 Ben Konrath <ben@bagu.org>
760 Improve performance of related list height calculation.
762 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
763 Put code to calculate the expected height in a static initializer so
764 that that it's only called once.
766 2011-12-01 Ben Konrath <ben@bagu.org>
768 Show related list tables in notebooks (again).
770 Calculate the height of the related list tables so the Notebook can be
771 set the correct height. The height of the related list table is also needed by
772 FlowTable to be able decide how to create the layout.
774 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
775 and set the Portal height based on the height of the related list
776 table and the Portal container.
777 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
778 Add method to calculate the height of the related list tables.
779 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
780 * src/main/webapp/style.css: Add css class for Pager. This is needed to
781 calculate the height of the Pager widget.
783 2011-12-01 Ben Konrath <ben@bagu.org>
785 Use CellTable API for table property instead of setting style on Element.
787 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
789 2011-12-01 Ben Konrath <ben@bagu.org>
791 Make ListViewTable and RelatedListTable a consistent height.
793 The tables are now a consistent height regardless of the contents of
794 the table. A hidden button is added to empty rows to ensure that the
795 height of these rows will match the height of rows with data.
797 A navigation button column is now added to every table. The width of
798 the navigation column is set to 0px when a RelatedListTable shouldn't
799 have navigation buttons. This maintains the a consistent row height in
800 tables that don't show the navigation buttons.
802 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
803 navigation column when not needed.
804 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
805 arguments for navigation button to constructor of ListViewTable.
806 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
807 hidden button for empty data rows.
808 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
809 arguments for navigation button to constructor.
810 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
811 create navigation buttons. Add hideNavigationButtons() method.
812 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
813 arguments for navigation button to constructor.
815 2011-12-01 Ben Konrath <ben@bagu.org>
817 Use 'visibility: hidden' in Utils.getWidgetHeight().
819 This is better choice because hidden elements are invisible, don't
820 respond to events and are not part of the tab order. They will,
821 however, take up space which is required to be able to calculate the
822 height of the widget.
824 * src/main/java/org/glom/web/client/Utils.java:
826 2011-12-01 Ben Konrath <ben@bagu.org>
828 Use Utils.getWidgetHeight() in FlowTable.
830 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
832 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
834 2011-12-01 Ben Konrath <ben@bagu.org>
836 Put the details css class name on the correct table column.
838 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
840 2011-11-30 Ben Konrath <ben@bagu.org>
842 Update for java-libglom API change.
844 The getters and setters on FieldFormatting and NumericFormat were
845 changed to remove the 'M'.
847 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
849 2011-11-29 Ben Konrath <ben@bagu.org>
851 Only allow RelatedListTables in Portals.
853 * src/main/java/org/glom/web/client/ui/details/Portal.java:
855 2011-11-29 Ben Konrath <ben@bagu.org>
857 Only create a contents panel for Portals when title is being set.
859 * src/main/java/org/glom/web/client/ui/details/Portal.java:
861 2011-11-29 Ben Konrath <ben@bagu.org>
863 Set TabLayoutPanel height based on calculated height its widgets.
865 This is a potential fix for this bug:
867 https://bugzilla.gnome.org/show_bug.cgi?id=665133
869 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
871 2011-11-29 Ben Konrath <ben@bagu.org>
873 Align details field labels and data with the Open buttons.
875 * src/main/webapp/style.css:
877 2011-11-29 Ben Konrath <ben@bagu.org>
879 Remove unnecessary <div> in the Notebook widget.
881 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
882 method to get container FlowPanel (<div>).
883 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
884 initWidget() method directly on the TabLayoutPanel widget instead of
885 Group's container widget.
887 2011-11-29 Ben Konrath <ben@bagu.org>
889 Don't add group titles for Portals in Notebooks.
891 This reverts the previous patch and fixes a bug I introduced with
892 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
894 * src/main/java/org/glom/web/client/ui/details/Group.java:
895 * src/main/java/org/glom/web/client/ui/details/Portal.java:
897 2011-11-28 Ben Konrath <ben@bagu.org>
899 Remove unused boolean argument in Portal constructor.
903 * src/main/java/org/glom/web/client/ui/details/Group.java:
904 * src/main/java/org/glom/web/client/ui/details/Portal.java:
906 2011-11-28 Ben Konrath <ben@bagu.org>
908 Remove hack for glom 1.18 style glom files.
910 * src/main/java/org/glom/web/client/ui/details/Group.java:
911 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
912 * src/main/java/org/glom/web/client/ui/details/Portal.java:
914 2011-11-28 Ben Konrath <ben@bagu.org>
916 Use Gda Value version of primary key to log result too large error.
918 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
920 2011-11-28 Ben Konrath <ben@bagu.org>
922 Don't use TypedDataItem.getText() for Unknown types from the URL.
924 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
925 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
926 instead of getText().
927 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
928 String field and getUnknown() method.
930 2011-11-28 Ben Konrath <ben@bagu.org>
932 Log an error message when the java-libglom .so is not present.
934 The error message was being set in the exception but not logged.
936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
938 2011-11-28 Ben Konrath <ben@bagu.org>
940 Ignore LayoutItem_CalendarPortals.
942 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
943 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
945 2011-11-28 Ben Konrath <ben@bagu.org>
947 Extract method for creating the LayoutItemPortal DTO.
949 Just breaking the code up into smaller chunks.
951 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
953 2011-11-28 Ben Konrath <ben@bagu.org>
957 This should have been added with the refactor. Oops!
959 * src/main/java/org/glom/web/shared/TypedDataItem.java:
961 2011-11-28 Ben Konrath <ben@bagu.org>
963 Create primary key value from URL string using type from Glom document.
965 See this bug, comments 19 - 25:
967 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
969 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
970 create a TypeDataItem for the primary key here when loading from a
971 URL. Show the same string for the primary key value as was received
972 from the URL string (when loading from a URL).
973 * src/main/java/org/glom/web/server/Utils.java: Update method for
974 creating the Gda Value from the TypeDataItem to properly deal with
975 creating a Gda Value based on the Glom document type for the primary
976 key value string when loading from a URL.
977 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
978 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
979 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
980 Update for changed method name.
982 2011-11-27 Ben Konrath <ben@bagu.org>
984 Rename PrimaryKeyItem to TypedDataItem.
986 The name PrimaryKeyItem suggests what the class should be used for.
987 TypedDataItem is a neutral name that describes the class better.
989 This is a rename-only refactor.
991 * src/main/java/org/glom/web/client/OnlineGlomService.java:
992 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
993 * src/main/java/org/glom/web/client/Utils.java:
994 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
995 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
996 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
997 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
998 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
999 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1000 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1001 * src/main/java/org/glom/web/server/Utils.java:
1002 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1003 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1004 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1005 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1007 2011-11-25 Ben Konrath <ben@bagu.org>
1009 Improve Gda Value conversion from PrimaryKeyItem.
1011 The value from the PrimaryKeyItem is only used if its type match the
1012 type from the glom document.
1014 * src/main/java/org/glom/web/server/Utils.java:
1016 2011-11-25 Ben Konrath <ben@bagu.org>
1018 Manually check if the java-liblgom .so is visible to the JVM.
1020 It seems that Tomcat has problems when a static initializer throws an
1021 exception. This check is done before the first method call into
1022 java-libglom so that execution doesn't continue if the .so is not
1025 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1027 2011-11-25 Ben Konrath <ben@bagu.org>
1029 Improve browser configuration error messages.
1033 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1035 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1036 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1037 getConfigurationErrorMessage() method.
1038 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1039 Get and display a specific configuration error message when no Glom
1040 documents are found.
1041 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1042 Implement getConfigurationErrorMessage() method. Surround configuration
1043 code in the init() method with a try/catch block. This allows the
1044 errors to be caught while keeping the servlet available to retrieve the
1045 configuration error message.
1047 2011-11-25 Ben Konrath <ben@bagu.org>
1049 Don't use Strings to hold primary key values.
1051 The primary key values are now held in a new data object
1052 (PrimaryKeyItem) that holds type information and the primary key value
1053 using the correct type.
1055 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1056 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1057 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1058 PrimaryKeyItem instead of String to hold the primary key value.
1059 * src/main/java/org/glom/web/client/Utils.java: Remove
1060 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1061 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1062 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1063 PrimaryKeyItem instead of String to hold the primary key value. Load
1064 document selection page when the documentID has not been set correctly.
1065 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1066 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1068 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1069 Return empty string for URL instead of "null".
1070 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1071 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1072 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1073 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1074 PrimaryKeyItem instead of String to hold primary key values.
1075 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1076 PrimaryKeyValue to a Gda Value.
1077 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1078 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1079 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1080 Replace temporary database access code that uses the PrimaryKeyValue to
1081 Gda Value conversion.
1082 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1083 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1084 PrimaryKeyItem instead of String.
1085 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1086 hold primary key values.
1088 2011-11-24 Ben Konrath <ben@bagu.org>
1090 Use newly added java-libglom API to create queries.
1092 This isn't finished. I still need to stop using Strings for primary key
1093 values in the client code.
1095 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1096 libglom to use fake connections so that retrieving the query string will
1098 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1099 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1100 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1101 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1102 Use the newly added libglom sql methods and classes to create the
1103 query. Add temporary hack to convert primary value strings to Gda
1106 2011-11-23 Ben Konrath <ben@bagu.org>
1108 Don't explicitly set the height of Portals.
1110 See comments 6 - 10 of this bug for details:
1112 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1114 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1116 2011-11-23 Ben Konrath <ben@bagu.org>
1118 Use an HTML table instead of CSS for the FlowTable layout.
1120 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1121 GWT's FlexTable to implement the FlowTable.
1122 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1124 2011-11-18 Ben Konrath <ben@bagu.org>
1126 Add boolean example to HTML table mockup.
1128 * mockups/details-view-html-tables-text-entries.html:
1130 2011-11-17 Ben Konrath <ben@bagu.org>
1132 Ensure the pager buttons are always visible for related lists.
1134 To accomplish this, I've turned off text wrapping in the list view and
1135 related list tables for both the header and data text. The related list
1136 table now has a fixed layout so the it doesn't overflow its container.
1137 This is required to ensure that the cell text is clipped when it
1138 overflows the cell and an ellipsis is added to the right side of the
1139 cell when text is clipped.
1141 A fixed table layout for the related list table in the details view
1142 seems what we want for the details view anyway, so the side-effect is
1145 The ellipsis will only be displayed in Firefox >= 7.
1149 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1151 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1152 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1153 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1155 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1156 Set the 'table-layout: fixed' CSS property to the related list table.
1157 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1158 'white-space: nowrap;' CSS property on both the list view and the
1159 related list tables.
1161 2011-11-16 Ben Konrath <ben@bagu.org>
1163 Rework the fix for empty notebook tab labels.
1165 Setting the empty group titles with its name caused problems for the
1166 details layout. Instead of using libglom's
1167 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1168 to the client when the title is empty. This allows the Notebook to use
1169 the name when the title is empty without affecting anything else.
1171 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1172 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1174 2011-11-16 Ben Konrath <ben@bagu.org>
1176 Set group titles with name when title is empty.
1178 This fixes a problem with an empty notebook tab label in the Lesson
1179 Planner document. The forth tab in the notebook should be "Internet":
1181 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1183 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1184 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1187 2011-11-16 Ben Konrath <ben@bagu.org>
1189 Remove whitespace from the configured username properties.
1191 This assumes that usernames won't have whitespace at the beginning
1192 or end. But I think this is a reasonable assumption.
1194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1195 String.trim() to remove the whitespace from the username properties.
1197 2011-11-15 Ben Konrath <ben@bagu.org>
1199 Add details view mockup with HTML tables and text entries.
1201 This is from the attachment on this bug:
1203 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1205 * mockups/details-view-html-tables-text-entries.html:
1207 2011-11-15 Ben Konrath <ben@bagu.org>
1209 Add space between the columns of the flow table.
1213 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1215 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1216 space between columns in the flow table.
1218 2011-11-15 Ben Konrath <ben@bagu.org>
1220 Add backup files to the .gitignore.
1222 * .gitignore: Ignore files that end with ~.
1224 2011-11-09 Ben Konrath <ben@bagu.org>
1226 Use latest release of gwt-log.
1228 Gwt-log releases are now being submitted to the maven central
1229 repository so manual installation of the jar is no longer required.
1231 * pom.xml: Update version and groupId of gwt-log dependency.
1233 2011-10-31 Ben Konrath <ben@bagu.org>
1235 Don't use GWT numeric formatting to override the glom currency formatting.
1237 Currencies are now displayed like they are in Glom. See this bug:
1239 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1241 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1243 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1244 currency code to constructor and set it when the cell is rendered.
1245 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1246 currency code to the constructor of the NumericCell.
1248 2011-10-27 Ben Konrath <ben@bagu.org>
1250 Require the latest release of java-libglom (1.17.4).
1254 2011-10-26 Ben Konrath <ben@bagu.org>
1256 Add style to Notebook that matches current theme.
1258 It's not the best style in the world but it's better than the default.
1260 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1261 padding at the bottom of the child widgets.
1262 * src/main/webapp/style.css: Add style for the Notebook.
1264 2011-10-26 Ben Konrath <ben@bagu.org>
1266 Move servlet initialization code to overridden init method.
1268 This is half of the solution to getting proper error messages
1269 displayed when configuration errors occur. Here's the relevant bug:
1271 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1273 The rest of the solution involves surrounding the init method with a
1274 try/catch block and setting a global variable with the error /
1275 exception. A new async method should be created to retrieve and display
1276 the error message / exception.
1278 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1279 code from constructor to init method adding exceptions as needed.
1281 2011-10-26 Ben Konrath <ben@bagu.org>
1283 Add script to monitor and restart tomcat if required.
1285 * utils/check-and-recover-tomcat.py: New file.
1287 2011-10-26 Ben Konrath <ben@bagu.org>
1289 Display the correct number of data items in the pager.
1293 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1295 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1296 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1297 The implementation is the same for both tables: Keep track of the
1298 number of non-empty rows and fire and RowCountChangeEvent after the data has
1300 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1301 custom Pager class that subclasses SimplePager to handle displaying
1302 the correct number when empty rows have been added.
1304 2011-10-26 Ben Konrath <ben@bagu.org>
1306 Correct error in previous commit.
1308 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1309 eventBus parameter from listView.setCellTable().
1311 2011-10-26 Ben Konrath <ben@bagu.org>
1313 Fix error in TODO comment.
1315 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1317 2011-10-24 Ben Konrath <ben@bagu.org>
1319 Create Notebook widgets to the details view.
1321 This isn't finished just yet - I still need to create a reasonable
1322 style to match the current theme.
1324 * src/main/java/org/glom/web/client/Utils.java: Add method for
1325 calculating the height of a widget. This is used in the Notebook class.
1326 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1327 new constructor method in Group.
1328 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1329 method for creating child widget that can be used by subclasses
1330 like Notebook. New constructor that allows disabling the group
1331 titles - Notebooks don't set a group title for their child groups.
1332 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1333 to make Notebooks using GWT's TabLayoutPanel.
1334 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1335 constructor that allows disabling the group titles.
1336 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1337 LayoutItemNotebook DTO.
1338 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1339 DTO for Notebooks. It's just an empty class for now but we might need
1340 it to transfer some specific information in the future.
1342 2011-10-21 Ben Konrath <ben@bagu.org>
1344 Add navigation buttons to related list tables.
1346 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1347 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1348 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1349 method getSuitableRecordToViewDetails() for getting the table name
1350 and primary key value for related list navigation buttons.
1351 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1352 private cell renderer class to get the navigation information for
1353 related list tables from the server. Extract the navigation
1354 processing code from the details cell navigation and use it for the
1355 related list navigation as well.
1356 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1357 cell renderer class for the details open buttons. This was needed
1358 because the related list navigation buttons and the list view
1359 navigation buttons need to react differently when clicked.
1360 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1361 the onEnterKeyDown() method because it's now overriden in the
1362 subclasses that are specific to the related list tables and the list
1364 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1365 the vertical size a little because the buttons add a bit of vertical
1366 space to table. This is not a perfect solution because the vertical
1367 size of with table fewer than 5 rows will be a little smaller.
1368 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1369 changes in how navigation buttons are handled.
1370 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1371 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1372 database access object.
1373 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1374 to find the portal for a given relationship name from
1375 RelatedListDBAccess. Add method to find a primary key field for a
1377 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1378 Move code to find the portal for a given relationship name to
1380 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1381 New file: database access object for getting the related list
1382 navigation information (the table name and the primary key value).
1383 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1384 DTO for transferring a table name to navigate to and a primary key
1386 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1387 boolean and getter/setter to specifies if the related list should add
1390 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1392 Use the master branch of java-libglom
1394 * pom.xml: Depend on java-libglom 1.19 instead.
1396 This is the master branch. See also the libglom-1-18 branch.
1398 2011-10-11 Ben Konrath <ben@bagu.org>
1400 Enable the open navigation button when the data has been set.
1402 This avoids having active buttons that don't do anything when the data
1405 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1407 2011-10-11 Ben Konrath <ben@bagu.org>
1409 Use IsWidget interface for FlowTableItem.
1411 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1412 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1414 2011-10-11 Ben Konrath <ben@bagu.org>
1416 Remove GWT styling from open button in details view.
1418 There are still some issues with how the details cell is arranged but
1419 this should be made to match Glom 1.20. I'm going to leave fixing this
1420 until I have Glom 1.20 up and running.
1422 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1423 style name on open button.
1424 * src/main/webapp/style.css: Move and edit details-navigation class.
1425 Re-arrange some classes to make them appear in the same order as the
1428 2011-10-07 Ben Konrath <ben@bagu.org>
1430 Update to GWT 2.4.0.
1432 * .gitignore: Ignore new cache directory.
1433 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1434 * pom.xml: Change GWT and maven plugin to 2.4.0.
1435 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1437 * src/main/java/org/glom/web/client/ClientFactory.java:
1438 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1439 * src/main/java/org/glom/web/client/OnlineGlom.java:
1440 Update source for API changes.
1441 * utils/build-onlineglom-war.sh: Remove cache directory before the
1444 2011-10-07 Ben Konrath <ben@bagu.org>
1446 Add navigation buttons in the details view.
1448 This isn't finished but I thought I'd commit what I have as it's a
1449 pretty good start. I still need to:
1451 1. Change the style so that it fits better into the current theme
1452 2. Adjust the details cell to expand as much as possible.
1454 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1455 click handlers to navigation buttons in the DetailsCells. Create a
1456 refreshData() method to get just the data from the server without the
1458 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1459 Update the tableSelector and browser title when the table name
1460 changes without using the tableSelector.
1461 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1462 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1463 getDetailsCells() to getCells(). Update variable names.
1464 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1465 method to set click handler on navigation button. Rename a few
1466 variables. Add navigation buttons where needed.
1467 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1468 variables and methods.
1469 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1470 navigation boolean and navigation table as required in the
1471 LayoutItemField DTO.
1472 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1473 variables for navigation along with getter/setter methods.
1475 2011-10-07 Ben Konrath <ben@bagu.org>
1477 Rename Field to DetailsCell.
1479 This is a refactor-only commit. No functionality has been added or
1482 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1483 Update variable and method names.
1484 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1485 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1486 variable and method names.
1487 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1489 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1490 variable and method names.
1492 2011-10-07 Ben Konrath <ben@bagu.org>
1494 Create separate methods for layout and data the details view.
1496 This is a refactor-only commit. No functionality has been added or
1499 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1500 private methods: setData(), createLayout().
1502 2011-10-07 Ben Konrath <ben@bagu.org>
1504 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1506 This is part of a change to get navigation buttons in the details view
1507 but it should have been done this way from the start.
1509 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1510 for method name change in TableSelectionView.
1511 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1512 Create TableChangeEvent and set the browser title using the
1513 TableSelectionView API.
1514 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1515 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1516 Change getSelectedTable() to getSelectedTableName(). Add
1517 getSelectedTableTitle().
1519 2011-10-07 Ben Konrath <ben@bagu.org>
1521 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1523 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1525 2011-10-07 Ben Konrath <ben@bagu.org>
1527 Update TableChangeEvent to use newTableName naming convention.
1529 This makes the class more consistent with GWT naming conventions.
1531 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1532 Update for method name change in TableChangeEvent.
1533 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1534 for method name change in TableChangeEvent.
1535 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1536 newTableName variable and getter method. Make toDebugString()
1539 2011-09-30 Ben Konrath <ben@bagu.org>
1541 Disable the pager in the list tables when the data row count is less than the minimum.
1543 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1544 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1546 2011-09-30 Ben Konrath <ben@bagu.org>
1548 Add empty rows to the end of related list and list view tables.
1550 I also extracted the cell rendering classes from the ListTable because
1551 the code was becoming a little crazy with all the anonymous inner
1552 classes. My plan is to use these cell rendering classes in the details
1553 view as well so this refactor will be needed for that change.
1555 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1556 set the row count in related list tables if the data has more rows
1557 than the minimum number of rows visible.
1558 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1559 row count in list view tables if the data has more rows than the
1560 minimum number of rows visible.
1561 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1562 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1564 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1565 for rendering TYPE_NUMERIC cells. The code was extracted from the
1567 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1568 class for rendering cells with buttons in list views. The code was
1569 extracted from the ListTable class.
1570 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1571 for rendering TYPE_TEXT cells. The code was extracted from the
1573 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1574 Add empty rows to the end of the data if required. Implement
1575 ListTable.getMinNumVisibleRows().
1576 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1577 cell renderer code to public classes. Return null in
1578 Column.getValue() for empty rows. Add new abstract method:
1579 getMinNumVisibleRows(). Move code to set the row count of the list view
1580 table to ListViewImpl.
1581 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1582 empty rows to the end of the data if required. Implement
1583 ListTable.getMinNumVisibleRows().
1586 2011-09-27 Ben Konrath <ben@bagu.org>
1588 Use GWT.log for client-side debugging statements.
1590 These are optimized out when deployed so I should have used this method
1591 in the first place. These statements will eventually be replaced with some sort
1592 of notification in the browser.
1594 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1595 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1596 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1597 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1598 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1600 2011-09-27 Ben Konrath <ben@bagu.org>
1602 Put tableselector on the right, back to list link on right.
1604 The idea is that the table selector is acting like a label for the
1605 currently displayed table so it should be placed below the document title. This
1606 puts the table title in a similar position to where it is in Glom.
1608 * mockups/details-contacts.html:
1609 * mockups/details-projects.html:
1610 * mockups/listview-contacts.html:
1611 * mockups/listview-projects.html:
1612 * mockups/style.css:
1613 Update mockups to match how the interfaces currently look.
1614 * src/main/webapp/style.css: Swap positions of backlink with the table
1615 selector. Add some space on the left side of the table selector to
1616 line things up with the document title.
1618 2011-09-27 Ben Konrath <ben@bagu.org>
1620 Add field colouring to details view.
1622 This change re-works how field colouring works. The colour formatting
1623 information is now set to the client with the layout information instead of
1624 with the data. This eliminates the need to send the same colour strings for
1625 data in list view column when colour information is set.
1627 In order to set an alternate colour for negative numeric values, the
1628 number is now sent to client and formatted with the GWT NumberFormat class.
1630 This change also fixes:
1632 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1634 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1635 internationalization framework which is needed for client side numeric
1637 * src/main/java/org/glom/web/client/Utils.java: New file for some
1638 client static utility methods.
1639 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1640 the DataItem object to the Field class. Use a utility method to
1641 create the foreignKeyValue string.
1642 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1643 alignment and text colours in the constructor. Add setData(DataItem)
1644 method. Remove setText(String) method.
1645 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1646 colour information to GlomTextCell. Create and use GlomNumberCell for
1647 rendering numbers. Use utility method to get the string for the
1648 primary key of the key provider. Re-work how the horizontal alignment
1650 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1651 formatting to layout information. Methods for converting the libglom
1652 formatting information were moved from DBAccess.
1653 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1654 numeric formatting (it's now done on the client side). Don't set text
1655 colours in DataItem. Move libglom formatting conversion methods to
1657 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1658 getters/setters for text colour information.
1659 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1660 for transferring the libglom NumericFormat information to the client.
1661 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1662 and getters/setters for: GlomNumericFormat, background colour and
1663 foreground colour strings.
1665 2011-09-26 Ben Konrath <ben@bagu.org>
1667 Simplify code that iterates through the LayoutGroup.
1669 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1671 2011-09-26 Ben Konrath <ben@bagu.org>
1673 Accept Eclipse formatting for OnlineGlomServiceAsync.
1675 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1677 2011-09-26 Ben Konrath <ben@bagu.org>
1679 Don't use the ListDBAccess classes to get the primary key layout information.
1681 This was causing a bug where the wrong index for the hidden primary key
1682 was being sent to the client.
1684 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1685 primary key while creating the LayoutGroup DTO. Create a
1686 LayoutItemField DTO for hidden primary keys. Don't use the
1687 RelatedListDBAccess because it was only used for getting the primary
1689 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1690 access modifier from public to protected for getPrimaryKeyField() and
1691 getPrimaryKeyLayoutItemField().
1692 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1693 abstract method getExpectedResultSize() because RelatedListDBAccess
1694 doesn't have enough info to implement it.
1695 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1696 Remove @Override for getExpectedResultSize().
1697 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1698 Remove method getExpectedResultSize().
1700 2011-09-23 Ben Konrath <ben@bagu.org>
1702 Log which layout (list or details) the ignored item is from.
1704 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1706 2011-09-23 Ben Konrath <ben@bagu.org>
1708 Remove annotations that turn off code formatting in DataItem.
1710 * src/main/java/org/glom/web/shared/DataItem.java:
1712 2011-09-23 Ben Konrath <ben@bagu.org>
1714 Rename GlomField to DataItem and update associated methods.
1716 This is a rename-only refactor. No functionality has been added or
1719 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1720 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1721 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1722 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1723 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1724 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1725 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1726 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1727 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1728 * src/main/java/org/glom/web/server/database/DBAccess.java:
1729 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1730 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1731 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1732 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1733 * src/main/java/org/glom/web/shared/DataItem.java:
1734 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1735 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1737 2011-09-23 Ben Konrath <ben@bagu.org>
1739 Rename GlomDocument to DocumentInfo and update associated methods.
1741 This is a rename-only refactor. No functionality has been added or
1744 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1745 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1746 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1747 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1748 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1749 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1750 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1752 2011-09-20 Ben Konrath <ben@bagu.org>
1754 Require java-libglom 1.17.3.
1756 This picks up the fix for the seg fault problem with the Scenes table
1757 in the Openismus Film Manager example.
1761 2011-09-20 Ben Konrath <ben@bagu.org>
1763 Change the way sort clause is added for primary key when no sort clause is requested.
1765 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1766 before the sort clause is created. When a sort clause is not requested, the
1767 sort clause is created by finding the primary key in the LayoutFieldVector
1770 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1772 2011-09-20 Ben Konrath <ben@bagu.org>
1774 Log error message if no documents are found in the configured directory.
1776 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1777 Extract the glom file extension string to a private static final class
1778 variable (mostly as syntactic sugar). Accept a minor formatting change.
1779 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1780 the example glom.document.directory configuration property to make it
1781 more clear that it can any directory, not just the home directory.
1783 2011-09-18 Ben Konrath <ben@bagu.org>
1785 Add related lists to details view.
1787 The related list table has support for paging and sorting just like the
1788 table in the list view.
1790 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1791 SQL queries for the related list tables.
1792 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1793 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1794 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1795 Rename getList methods to getListView and add comments. Remove
1796 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1797 it being unused. Add methods: getDetailsLayoutAndData(),
1798 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1799 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1800 Create the layout and set the data for the fields in one async call
1801 instead of two. Create related lists where appropriate.
1802 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1803 for method name changes in OnlineGlomService.
1804 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1805 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1806 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1808 * src/main/java/org/glom/web/client/ui/ListView.java:
1809 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1810 tableName from setCellTable(). Create a ListViewTable instead of
1812 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1813 represent a data field in the details view.
1814 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1815 from addDetailsCell() to Field class. Keep track of the Fields and
1816 Portals in the details view.
1817 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1818 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1819 and add a method to get it. Add method to set the contents of the
1821 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1822 New class for related list tables. This class has the data provider
1823 for the related list table.
1824 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1825 abstract class which is the base class for the ListViewTable and the
1827 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1828 New class for list view tables. This class has the data provider for
1829 the list view table.
1830 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1831 methods for related list tables. Add more information to the
1832 LayoutItemField and LayoutItemPortal DTOs.
1833 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1834 Remove debugging print statement.
1835 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1836 Remove debugging print statements. Add primary key field to SQL count
1838 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1839 Remove unnecessary LayoutFieldVector parameter from
1840 getResultSizeOfSQLQuery() method.
1841 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1842 New class for related list table database access.
1843 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1844 class that is a wrapper DTO for details view layout and data.
1845 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1846 new 'fromField' string to this DTO.
1847 * src/main/webapp/style.css: Remove bottom margin and override top
1850 2011-09-15 Ben Konrath <ben@bagu.org>
1852 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1854 This sets things up to make it easier to add the data retrieval for
1855 related lists (portals). No user noticeable changes were made with
1858 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1859 class has the code to retrieve the layouts and access the
1860 database using the new database helper classes.
1861 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1862 Most of the functionality has been removed from this class. This
1863 class now represents the public interface for the client side
1864 code. It also deals with configuring the servlet and cleaning
1865 things up when the servlet is stopped.
1866 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1867 of static methods into this utility class.
1868 * src/main/java/org/glom/web/server/database/DBAccess.java:
1869 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1870 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1871 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1872 These classes have the database retrieval code. The class hierarchy
1873 has been setup to make it easy to reuse code for similar
1876 2011-09-06 Ben Konrath <ben@bagu.org>
1878 Create separate classes for list table code and the data provider.
1880 As part of this refactor, I also split up the code a bit to make it
1883 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1884 table code to two new classes (below).
1885 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1886 with code from ListViewImpl.
1887 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1888 New file with code from ListViewImpl.
1890 2011-09-06 Ben Konrath <ben@bagu.org>
1892 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1894 This fixes the LayoutItemPortal DTO to match the libglom layout object
1897 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1899 2011-09-01 Ben Konrath <ben@bagu.org>
1901 Set title of Portals in the Details View.
1903 * pom.xml: Bump required version of java-libglom to 1.17.1.
1904 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1905 widget creation to its own class. Add comments to constructor.
1906 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1907 The code is mostly from the Group class with the title now set.
1908 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1909 title of Portal. Update some comments. Fix some code formatting.
1911 2011-09-01 Ben Konrath <ben@bagu.org>
1913 Remove TODO comment for the flow table column width.
1915 The flow table column width is working correctly and doesn't need to be
1916 changed. See this mailing list post for more info:
1918 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1920 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1922 2011-08-27 Ben Konrath <ben@bagu.org>
1924 Add document title (database name) to top of the browser page.
1926 I added the document title to the TableSelecitonView but that will
1927 change if / when we add a view that doesn't require table selection.
1929 * mockups/details-contacts.html:
1930 * mockups/details-projects.html:
1931 * mockups/listview-contacts.html:
1932 * mockups/listview-projects.html:
1933 * mockups/style.css: Add document title to mockups to keep things
1935 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1936 sizes to account for the document title.
1937 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1938 Set the document title when it has been retrieved from the server.
1939 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1940 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1941 and implement setDocumentTitle(String) method.
1942 * src/main/webapp/style.css: Add ID for document title style.
1944 2011-08-25 Ben Konrath <ben@bagu.org>
1946 Add NavigationType enum to LayoutItemPortal DTO.
1948 This is the start of adding support for Portals to the Details View.
1950 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1951 LayoutItem_Portal.navigation_type enum from libglom to
1952 LayoutItemPortal.NavigationType enum.
1953 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1954 NavigationType enum, field for storing the NavigationType and getter
1957 2011-08-25 Ben Konrath <ben@bagu.org>
1959 Implement the flow table layout in the Details View.
1961 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1962 FlowTable to Group to account for the renamed class.
1963 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1964 File. This is a container widget that implements the Glom details view
1965 flow table behaviour.
1966 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1967 org/glom/web/client/ui/FlowTable.java.
1968 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1969 so that the size of the subgroups are a closer match to the size of
1970 the Glom subgroups. This makes the flowtable layout match the layout
1971 in Glom for the Music Collection example file.
1973 2011-08-16 Ben Konrath <ben@bagu.org>
1975 Create container element for LayoutItemPortal in Details View.
1977 This will help me develop the layout for the FlowTable.
1979 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1980 fieldPanel variable to detailsCell.
1982 2011-08-15 Ben Konrath <ben@bagu.org>
1984 Set the height of the data element in the Details View.
1986 I changed the InlineLabels (text in a span element) to Labels (text in
1987 a div element) so that I could set the height of the details-data
1988 elements instead of the details-cell parent elements. This allows the
1989 the details-data element to display the correct height if style is
1990 applied that shows the height.
1992 This change has the added benefit of allowing the order of the labels
1993 and data elements to be changed for right-to-left languages.
1995 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1996 InlineLabels to Labels.
1997 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1998 InlineLabels to Labels. Set the height of the data element.
1999 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2000 multiline text height in the Formatting DTO.
2001 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2002 for multiline height along with getter and setter methods.
2003 * src/main/webapp/style.css: Adjust style to account for the change
2004 from span elements to div elements in the details cell.
2006 2011-08-15 Ben Konrath <ben@bagu.org>
2008 Make the List View appearance match the mockups.
2010 It doesn't match exactly but it's much better than it was.
2012 * mockups/listview-contacts.html: Remove unused css classes.
2013 * mockups/listview-projects.html: Remove unused css classes.
2014 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2015 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2016 for mainPanel instead of VerticalPanel (table). Set style name on
2017 CellTable. Set style name on Details column. Right-align Details
2019 * src/main/webapp/style.css: Adjust properties to match the mockups.
2021 2011-08-12 Ben Konrath <ben@bagu.org>
2023 Add better support for subgroups in the details view.
2025 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2026 changed FlowTable constructor.
2027 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2028 support for subgroups and subgroup-titles.
2029 * src/main/webapp/style.css: Add CSS class for subgroups and
2032 2011-08-12 Ben Konrath <ben@bagu.org>
2034 Return the top level LayoutGroup title.
2036 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2038 2011-08-11 Ben Konrath <ben@bagu.org>
2040 Make the TableSelector header match the mockup.
2042 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2043 the layout panel. Properly lineup the table selection header with
2044 the list and details view.
2045 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2046 margin around the details view.
2047 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2048 Rename listBox variable to tableSelector. Set id for the style sheet.
2049 Use a FlowPanel instead of a HorizontalPanel.
2050 * src/main/webapp/style.css: Add properties to make the TableSelector
2051 box match the mockups.
2053 2011-07-13 Ben Konrath <ben@bagu.org>
2055 Update install script for java-libglom version change.
2057 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2060 2011-07-13 Ben Konrath <ben@bagu.org>
2062 Add support sub-group in the details view.
2064 I also removed the code that special-cased the default details view
2067 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2069 I still have to make a proper flowtable.
2071 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2072 Don't special-case default details view layout.
2073 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2074 addLayoutField() as I'm going to use it.
2075 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2076 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2078 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2079 extracted from DetailsViewImpl.GroupPanel. Add support for
2081 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2082 column count when getting the details layout.
2084 2011-07-12 Ben Konrath <ben@bagu.org>
2086 Set browser title with database and table titles.
2088 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2089 Set the browser title when the table changes and when the activity
2091 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2092 title when retrieving document info (the GlomDocument object).
2093 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2094 with getter and setter methods. Remove unused convenience constructor.
2095 Use default code formatting.
2097 2011-07-12 Ben Konrath <ben@bagu.org>
2099 Ignore LayoutItemPortals in the details view.
2101 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2104 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2105 LayoutItemPortal layout objects.
2106 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2107 LayoutItemPortal objects when retrieving the details layout.
2108 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2109 file. This is an empty class and just used to get type information for
2112 2011-07-12 Ben Konrath <ben@bagu.org>
2114 Use java-libglom 1.17.0.
2118 2011-07-11 Ben Konrath <ben@bagu.org>
2120 Remove "Table:" label from table selector.
2122 This matches a recent change in the Glom UI.
2124 * mockups/details-contacts.html:
2125 * mockups/details-projects.html:
2126 * mockups/listview-contacts.html:
2127 * mockups/listview-projects.html: Remove the "Table:" label from the
2129 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2131 2011-07-11 Ben Konrath <ben@bagu.org>
2133 Add main groups to the details view.
2135 This makes things look a little nicer in the details view. The next step
2136 is to implement the flowtable.
2138 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2139 resources from the standard gwt css theme. Standard.css is now
2140 included in OnlineGlom.html so that the online glom css rules have
2141 precedence over the gwt theme.
2142 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2143 the whole LayoutGroup to the DetailsView instead of just the titles.
2144 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2145 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2146 details layout with a helper class (GroupPanel). I might extract this
2147 class when I make the full flowtable.
2148 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2149 string as default so I don't have to worry about NPEs when processing
2151 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2152 note beside OnlineGlom.gwt.xml above).
2153 * src/main/webapp/style.css: Add default font-size to body to override
2154 the font-size set by the standard theme. Don't use h2 tags for
2155 group-title. Create new details-cell class.
2157 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2159 ConfiguredDocument: Set the port number too.
2161 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2162 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2163 Glom document. Presumably this worked sometimes so far because there is a
2164 default port number.
2166 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2168 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2170 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2171 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2172 correct, though we should throw an exception too.
2174 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2176 Fix a addDocuemnt typo.
2178 * src/main/java/org/glom/web/shared/Documents.java
2179 (Documents.addDocuemnt): Rename to addDocument().
2180 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2181 (OnlineGlomServiceImpl.getDocuments): Adapt.
2183 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2185 Slightly improved log output when connection fails.
2187 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2188 (ConfiguredDocument.setUsernameAndPassword):
2189 We don't know for sure if it' the username/password that's wrong, so
2190 rephrase the message.
2191 Also ouput the exception message, though it's generic in this case.
2193 2011-07-08 Ben Konrath <ben@bagu.org>
2197 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2198 added braces to a one line if statement because the Eclipse formatter
2199 was getting confused.
2201 2011-07-07 Ben Konrath <ben@bagu.org>
2203 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2205 These should really be two separate tasks but I counldn't get things to
2206 work with GWT 2.2.0 and Eclipse 3.7.
2210 * .settings/org.eclipse.jdt.core.prefs:
2211 * .settings/org.eclipse.jdt.ui.prefs:
2212 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2213 * .settings/org.eclipse.m2e.core.prefs:
2214 Add new config files. Update current files. Remove references to the
2215 webtools plugins as we're not using any of the webtools features.
2216 * .gitignore: Add logs directory which is created when running with
2218 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2219 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2220 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2222 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2224 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2226 onlineglom.properties: Add explanatory comments.
2228 * src/main/resources/onlineglom.properties: Also change the default user
2229 from ben to someuser, to avoid the risk of people thinking we just
2230 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2232 2011-06-28 Ben Konrath <ben@bagu.org>
2234 Use filename in Log for incorrect passwords.
2236 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2237 getFileName(String) method to get the filename from the URI.
2239 2011-06-28 Ben Konrath <ben@bagu.org>
2241 Add the table name to the URL token for the ListPlace.
2243 This makes things consistent between the DetailsPlace and the
2244 ListPlace. It also allows the the ListPlace to be bookmarked.
2246 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2247 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2248 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2249 Remove getDefaultListLayout(). The default layout is now returned
2250 by the getListLayout() method when the table name is an empty string.
2251 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2252 Add table name field. Change to a new ListPlace when the table
2253 has been changed. Use getListLayout() for getting the default
2255 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2256 Add table name field. Set the correct table name in the list box
2257 when loading from bookmark. This corrects a problem for the
2259 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2260 Move table name to super-class (HasSelectableTable). Move document
2261 and table URL keys to super-class in HasSelectableTable.
2262 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2263 Add table name field. Add Tokenizer class with URL key common to
2264 the subclasses (DetailsPlace and ListPlace).
2265 * src/main/java/org/glom/web/client/place/ListPlace.java:
2266 Add table name. Add code to parse the URL token.
2267 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2268 Update ListPlace construction with empty table name string.
2269 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2270 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2271 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2272 Update ListPlace construction with table name string.
2273 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2274 Change defaultTableName field to tableName to reflect how it's now
2275 used. Update the getter and setter methods.
2277 2011-06-28 Ben Konrath <ben@bagu.org>
2279 Enable the table selector in the DetailsView.
2281 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2282 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2283 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2284 Remove getDefaultDetailsLayout(). The default layout is now returned
2285 by the getDetailsLayout() method when the table name is an empty
2287 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2288 event handler for table change event. Change to using
2289 getDetailsLayout() for the default details layout.
2290 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2292 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2293 when navigating to the details place.
2295 2011-06-27 Ben Konrath <ben@bagu.org>
2297 Use filename based unique document ID in URL and for RPC.
2299 The document ID is the glom document name with spaces (' ') replaced
2300 with pluses ('+') and without the .glom extension.
2302 This change is mostly a string substitution of 'documentTitle' for
2303 'documentID'. The only code change is the addition of a Documents DTO to get the
2304 filename to document title mappings as indicated below.
2306 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2307 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2308 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2309 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2310 Use Documents DTO to create the document links in the document
2312 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2313 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2314 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2315 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2316 * src/main/java/org/glom/web/client/place/ListPlace.java:
2317 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2318 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2319 * src/main/java/org/glom/web/client/ui/ListView.java:
2320 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2321 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2322 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2323 * src/main/java/org/glom/web/server/Log.java:
2324 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2325 getDocumentTitles() to getDocuments() and return the Documents DTO.
2326 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2327 transferring the filename to document title mappings.
2329 2011-06-25 Ben Konrath <ben@bagu.org>
2331 Make the authentication popup work again.
2333 This bug was introduced when I extracted ConfiguredDocument to its own class.
2335 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2336 correct success / fail status in setUsernameAndPassword().
2338 2011-06-25 Ben Konrath <ben@bagu.org>
2340 Use filename as unique key for configuring database usernames and passwords.
2342 This replaces the use of the Glom document title which could change
2343 depending on the locale. Thanks to Murray Cumming for pointing out this
2346 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2347 * src/main/resources/onlineglom.properties:
2349 2011-06-24 Ben Konrath <ben@bagu.org>
2351 Pass primary key value to DetailsView.
2353 This enables the DetailsView to load the correct data.
2355 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2356 primary key value field and set in constructor. Pass primary key
2357 value to getDetailsData().
2358 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2359 variables for document title and primary key value.
2360 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2361 key value to the DetailsPlace.
2363 2011-06-24 Ben Konrath <ben@bagu.org>
2365 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2367 This allows the primary key to be retrieved by the Details button. This
2368 functionality has not been implemented yet but it's in the works.
2370 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2371 the LayoutGroup result to ListView.setCellTable instead of all of its
2372 fields individually.
2373 * src/main/java/org/glom/web/client/ui/ListView.java:
2374 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2375 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2376 get the primary key for the table.
2377 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2378 index of the primary key in the LayoutGroup accounting for hidden
2379 primary keys. Rename getJavaNumberFormat() to
2380 convertToJavaNumberFormat() for consistency. Cleanup / add some
2382 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2383 field for primary key index and a field to indicate whether the
2384 primary key is hidden or not.
2386 2011-06-23 Ben Konrath <ben@bagu.org>
2388 Rename getTableData methods to getListData.
2390 This is a rename refactor for consistency with other methods.
2392 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2393 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2394 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2395 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2397 2011-06-23 Ben Konrath <ben@bagu.org>
2399 Extract the ConfiguredDocument innerclass into its own class.
2401 This makes the servlet code more object oriented.
2403 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2404 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2405 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2406 new ConfiguredDocument class.
2408 2011-06-21 Ben Konrath <ben@bagu.org>
2410 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2412 This makes things more inline with how libglom works and reduces code
2413 duplication. This refactor lays the groundwork for adding the primary key to
2414 the LayoutGroup object.
2416 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2417 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2418 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2419 Change method names to getListLayout and getDefaultListLayout for
2420 consistency. Use LayoutGroup as the DTO for the list layout instead of
2421 ColumnInfo and LayoutListTable.
2422 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2423 new method names along with the LayoutGroup object for transferring the
2425 * src/main/java/org/glom/web/client/ui/ListView.java:
2426 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2427 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2428 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2430 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2431 Replaced with LayoutGroup.
2432 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2433 expectedResultSize and defaultTableName fields which are needed for
2435 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2436 type field which is needed for the list layout but will also be
2437 useful for the details layout as things progress.
2438 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2439 Make class abstract. Remove the unnecessary
2440 getFormattingHorizontalAlignment method. Add setFormatting method.
2442 2011-06-16 Ben Konrath <ben@bagu.org>
2444 Add scripts for building and installing war.
2446 These will help when updating OnlineGlom but they're also good
2447 supplemental documentation of the build and deployment proceeding.
2449 * utils/build-onlineglom-war.sh: New file.
2450 * utils/install-onlineglom-war.sh: New file.
2452 2011-06-16 Ben Konrath <ben@bagu.org>
2454 Create wrapper class to create consistent log messages.
2456 I wrapped methods in the Log class of gwt-log to add the method names
2457 from the servlet and create consistent formatting of the document title
2458 and table names in the log messages.
2460 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2461 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2462 log methods to use methods from wrapped Log class.
2464 2011-06-16 Ben Konrath <ben@bagu.org>
2466 Remove superfluous conditional return.
2468 Thanks to Murray Cumming for pointing this out!
2470 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2472 2011-06-15 Ben Konrath <ben@bagu.org>
2474 Return an ArrayList of LayoutGroups for the Details layout.
2476 This corrects a problem with the details layout as it can have more
2477 than one top level LayoutGroup.
2479 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2480 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2481 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2482 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2483 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2484 with ArrayList of LayoutGroups for the details view layout.
2485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2486 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2487 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2488 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2489 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2490 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2492 2011-06-14 Ben Konrath <ben@bagu.org>
2494 Use cast_dynamic method to determine the libglom LayoutItem type.
2496 This is better than finding the LayoutItem type by using the string
2497 returned from the get_part_type_name() method.
2499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2501 2011-06-14 Ben Konrath <ben@bagu.org>
2503 Add method names to log entries in the servlet.
2505 This helps when tracking down deployment problems.
2507 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2509 2011-06-14 Ben Konrath <ben@bagu.org>
2511 Add data to the DetailsView using a hard-coded primary key value.
2513 The layout and functionality of the DetailsView is not complete. This
2514 is just a checkpoint so the patch doesn't get too big.
2516 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2517 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2518 Add getDetailsData() servlet method.
2519 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2520 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2521 LayoutFields are added to the DetailsView.
2522 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2523 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2524 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2525 take the string for the title instead of the object.
2526 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2527 Add implementation getDetailsData() along with some private helper
2529 * src/main/webapp/style.css: Add padding to details-data class. Add a
2530 details-label class with the same padding as the details-data class.
2532 2011-06-03 Ben Konrath <ben@bagu.org>
2534 Use presenter.goTo() to change to the DetailsPlace.
2536 This will make things easier when we need to open the DetailsView with
2537 data specific to the row that was clicked.
2539 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2541 2011-06-02 Ben Konrath <ben@bagu.org>
2543 Add CSS file from mockups.
2545 I'm adding this now because it's going to be useful to have when
2546 developing the DetailsView. The TableSelectionView and ListView aren't
2549 * src/main/webapp/OnlineGlom.html:
2550 * src/main/webapp/style.css:
2552 2011-06-02 Ben Konrath <ben@bagu.org>
2554 Use String.isEmpty() to check for empty string.
2556 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2558 2011-06-02 Ben Konrath <ben@bagu.org>
2560 Display main layout group titles in the DetailsView.
2562 This is the start of the DetailsActivity/DetailsView implementation.
2564 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2565 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2566 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2567 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2568 Get the layout information for the details view from the server and set
2569 the main layout group titles.
2570 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2571 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2572 Add addLayoutGroup() and addLayoutField() methods. This are just
2573 temporary methods for creating the the details view that will change
2575 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2576 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2578 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2579 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2580 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2581 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2582 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2583 Data Transfer Objects that mimic the libglom object structure. These are
2584 used for transferring the details layout but could also be used for
2585 transferring the list layout.
2587 2011-05-27 Ben Konrath <ben@bagu.org>
2589 Reset the AuthenticationPopup when clearing the ListView.
2591 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2593 2011-05-27 Ben Konrath <ben@bagu.org>
2595 Fix problem with onlineglom.properties file loading.
2597 The old way worked in Eclipse but not on the server. Loading the
2598 onlineglom.properties file now works in Eclipse and on the server.
2600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2602 2011-05-24 Ben Konrath <ben@bagu.org>
2604 Update gwt-log from 3.1.0 to 3.1.2.
2606 Gwt-log 3.1.0 has been marked as depreciated.
2610 2011-05-24 Ben Konrath <ben@bagu.org>
2612 Add comment to ListActivity.goTo() method.
2614 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2616 2011-05-24 Ben Konrath <ben@bagu.org>
2618 Remove FIXME in convertGdkColorToHtmlColour()
2620 The Gdk::Color value returned by libglom is 16-bits per channel on both
2621 64 and 32-bit platforms.
2623 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2625 2011-05-19 Ben Konrath <ben@bagu.org>
2627 Improve performance of initial ListView load.
2629 I removed a round trip to the server for getting the default table name
2630 and then requesting information about that table. This also removes a potential
2631 problem with the table change handler not being setup in time to receive the
2632 table change event from the ListActivity.
2634 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2635 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2636 getDefaultLayoutListTable() method. Improve comments.
2637 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2638 getDefaultLayoutListTable() method instead of firing a table change
2639 event to get the table to load.
2640 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2641 implementation of getDefaultLayoutListTable() method.
2642 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2645 2011-05-19 Ben Konrath <ben@bagu.org>
2647 Override toDebugString() in TableChangeEvent.
2649 This is useful to have for debugging.
2651 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2653 2011-05-19 Ben Konrath <ben@bagu.org>
2655 Add a "Back to List" link when at the DetailsPlace.
2657 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2658 Populate the CellTable based on the selected table of the ListBox if
2659 it's set otherwise use the default table. This allows the "Back to
2661 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2662 Remove Place from constructors. Add a setPlace() method. Add
2663 goToPlace() method. Set class as presenter for TableSelectionView.
2664 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2665 Use the same TableSelectionActivity when switching between the List and
2667 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2668 Subclass the new HasSelectableTablePlace. This removes some duplicate
2670 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2671 New class to represent Places that display the TableSelectionView.
2672 * src/main/java/org/glom/web/client/place/ListPlace.java:
2673 Subclass the new HasSelectableTablePlace. This removes some duplicate
2675 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2676 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2677 Add Presenter interface. Add setBackLinkVisible() method. Add
2678 setBackLink() method.
2680 2011-05-18 Ben Konrath <ben@bagu.org>
2682 Enable the "Details" buttons.
2684 Right now only an empty details view is displayed.
2686 * src/main/java/org/glom/web/client/ClientFactory.java:
2687 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2688 Add DetailsView to ClientFactory.
2689 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2690 A basic activity for the details view.
2691 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2692 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2694 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2695 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2697 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2698 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2699 unnecessary super() in constructor.
2700 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2701 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2702 really shouldn't create a new TableSelectionActivity for both the ListPlace
2703 and the DetailsPlace so this should be considered a temporary solution.
2704 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2705 New file. Represents a URL for the details view.
2706 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2707 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2708 A basic details view interface and implementation.
2709 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2710 Enable the "Details" buttons.
2712 2011-05-12 Ben Konrath <ben@bagu.org>
2714 Use a LayoutPanel with multiple display areas for main layout.
2716 This is mostly a refactor in that there are no changes from the user
2717 point of view. These changes are required so that we can swap out the list view
2718 with the details view when the user clicks the "Details" button.
2720 * src/main/java/org/glom/web/client/ClientFactory.java:
2721 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2722 OnlineGlomView. Add TableSelectionView, ListView and
2723 AuthenticationPopup.
2724 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2725 for main layout. Add display regions for main activities. Add
2726 activity manager for for main activities.
2727 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2728 file from parts of the deleted OnlineGlomActivity.
2729 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2730 New file from parts of the deleted OnlineGlomActivity.
2731 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2732 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2733 New files for app wide table change event.
2734 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2735 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2736 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2737 Activity mappers for the main activities replace the deleted app-wide
2739 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2740 Fix a spelling error in he comment.
2741 * src/main/java/org/glom/web/client/ui/ListView.java:
2742 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2743 Renamed from LayoutListView and modified for MVP. This still not a
2744 proper dumb view as prescribed by the MVP pattern but it works for now.
2745 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2746 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2747 New widget stripped out of the deleted OnlineGlomView.
2748 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2749 Remove hack that is fixed by this patch.
2751 2011-05-06 Ben Konrath <ben@bagu.org>
2753 Rename OnlineGlomPlace to ListPlace.
2755 The only change besides the rename is that url will now display #list
2756 instead of #Document.
2758 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2759 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2760 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2761 * src/main/java/org/glom/web/client/place/ListPlace.java:
2762 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2764 2011-05-06 Ben Konrath <ben@bagu.org>
2766 Use Presenter for app navigation.
2768 This is the proper way to deal with Place (URL) changes with the MVP
2771 * src/main/java/org/glom/web/client/ClientFactory.java:
2772 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2773 PlaceHistoryMapper and PlaceHistoryHandler.
2774 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2775 PlaceHistoryMapper and PlaceHistoryHandler.
2776 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2777 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2778 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2779 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2780 Add Presenter interface and setPresenter methods. Rename addHyperLink
2781 to addDocumentLink taking only the document title as a parameter.
2783 2011-04-14 Ben Konrath <ben@bagu.org>
2785 Prompt for db username/password if they haven't been set.
2787 This is implemented with a popup widget that is contained within the
2788 OnlineGlomView and managed by the OnlineGlomActivity.
2790 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2791 methods for checking and setting the database username and password.
2792 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2793 new methods for checking and setting the database username and
2795 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2796 Display authentication popup if the JDBC connection to the database
2797 has not been authenticated.
2798 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2800 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2801 for dealing with the authentication popup.
2802 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2803 Implement the methods for dealing with the authentication popup.
2804 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2805 try to executed queries if the database connection hasn't been
2806 authenticated. Implement methods for checking and setting the
2807 database username and password.
2809 2011-04-12 Ben Konrath <ben@bagu.org>
2811 Make log messages a little clearer.
2813 Add a dash betweeen the document title and the table name.
2815 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2817 2011-04-12 Ben Konrath <ben@bagu.org>
2819 Protect against NPEs when cleaning up database resources.
2821 While this isn't strictly necessary because the exception is caught,
2822 not protecting against the NPEs makes it harder to find the real error
2825 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2827 2011-04-12 Ben Konrath <ben@bagu.org>
2829 Move configuration of the servlet to the constructor.
2831 The servlet will be initialized even if the database authentication
2832 information is not set or correct. I still need to add the UI for prompting
2833 the user for the authentication information when it's required.
2835 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2836 javadocs for getDocumentTitles() method.
2837 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2838 Set error message when RPC fails.
2839 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2840 glom files directory from the configuration file. Try to set the
2841 database authentication information for the specific document if it's
2842 set and works otherwise try to use the global authentication
2843 information set for the directory.
2844 * src/main/resources/onlineglom.properties: Moved from
2845 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2846 Added detailed comments for the new keys.
2848 2011-04-11 Ben Konrath <ben@bagu.org>
2850 Remove unnecessary @Override in DocumentSelectionViewImpl.
2852 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2854 2011-04-11 Ben Konrath <ben@bagu.org>
2856 Remove center alignment in DocumentSelectionView.
2858 The title element is still centred but the document titles and bottom
2859 sentence are both left-aligned.
2861 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2863 2011-04-11 Ben Konrath <ben@bagu.org>
2865 Change 'Demo' naming convention to 'Document'.
2867 This is just a rename refactor with no functional changes to the code.
2869 * src/main/java/org/glom/web/client/ClientFactory.java:
2870 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2871 * src/main/java/org/glom/web/client/OnlineGlom.java:
2872 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2873 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2874 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2875 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2876 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2877 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2878 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2879 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2880 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2881 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2883 2011-04-08 Ben Konrath <ben@bagu.org>
2885 Remove FIXME from safeLongToInt() method.
2887 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2890 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2892 2011-04-08 Ben Konrath <ben@bagu.org>
2894 Display an error if no glom documents are found in the specified directory.
2896 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2897 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2898 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2901 2011-04-08 Ben Konrath <ben@bagu.org>
2903 Add copyright header to one more file ... oops.
2905 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2907 2011-04-08 Ben Konrath <ben@bagu.org>
2909 Add copyright header to files without it.
2911 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2912 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2913 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2914 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2915 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2916 * src/main/java/org/glom/web/shared/GlomField.java:
2918 2011-04-08 Ben Konrath <ben@bagu.org>
2920 Add support for accessing multiple glom documents in the servlet.
2922 This completes the demo selection functionality.
2924 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2925 document title to methods.
2926 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2927 document title to methods.
2928 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2929 Set browser window title when the activity starts. Correct name of
2930 document title variable.
2931 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2932 Set browser window title when the activity starts. Set the table
2933 selector change handler after table selector has been set. Clear the
2934 OnlineGlomView when the activity has been stopped.
2935 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2936 document title as the place token. Use "#Document:" instead of
2937 "#OnlineGlomPlace:" in the URL.
2938 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2939 Change heading to "Online Glom"
2940 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2941 document title in RPC methods.
2942 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2943 setDocumentTitle() method. Add clear() method.
2944 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2945 setDocumentTitle() method. Implement clear() method which removes the
2946 change handler on the ListBox, clears the ListBox and clears the
2948 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2949 Implement methods with document title. Keep track for the configured
2950 glom documents and their corresponding JDBC configurations in a hash
2951 table. This information is retrieved using the document title as the
2952 key in the hash table.
2953 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2954 document title field as it's no longer needed.
2956 2011-04-08 Ben Konrath <ben@bagu.org>
2958 Update the Eclipse JDT configuration.
2960 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2961 methods. Automatically add the copyright header to new files.
2963 2011-04-05 Ben Konrath <ben@bagu.org>
2965 Add new page for demo selection.
2967 This patch adds all the components required to view and start an
2968 OnlineGlom demo by clicking on the desired hyperlink. The user is
2969 able to return to the demo selection page with the browser's back
2970 button. I still need to modify the servlet to work with multiple
2971 documents so all demo links will load the file defined in the
2972 OnlineGlom.properties.
2974 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2975 This is only useful during development so we don't need to save it.
2976 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2977 get a reference to the DemoSelectionView.
2978 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2979 method to get a reference to the DemoSelectionView.
2980 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2981 default view to DemoSelectionView.
2982 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2983 to get glom document titles for glom files in a hard-coded directory.
2984 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2985 method to get glom document titles for glom files in a hard-coded
2987 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2988 Presenter for DemoSelectionView.
2989 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2990 for DemoSelectionView.
2991 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2992 Update for DemoSelectionView.
2993 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2994 Basic 'Place' implementation for the DemoSelectionView.
2995 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2996 The interface for the DemoSelectionView.
2997 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2998 The implementation of the DemoSelectionView.
2999 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3000 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3001 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3002 implementation of method to get glom document titles for glom files
3003 in a hard-coded directory.
3004 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3005 on longer being used.
3006 * src/main/webapp/glom.png: Glom logo.
3008 2011-04-05 Ben Konrath <ben@bagu.org>
3010 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3012 This is the forth and final commit of a refactor that will allow
3013 OnlineGlom to be used with multiple documents.
3015 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3016 Move RPC code from OnlineGlomViewImpl to this class.
3017 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3019 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3020 RPC code to the presenter class (the P in MVP).
3022 2011-04-04 Ben Konrath <ben@bagu.org>
3024 Start moving the existing OnlineGlom code to MVP.
3026 This work is based on the GWT MVP framework that is documented here:
3028 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3030 This is the third commit of a refactor that will allow OnlineGlom to
3031 be used with multiple documents.
3033 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3034 Interface for client factory which is used to get instances of various
3035 classes throughout the app.
3036 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3037 Implementation of client factory.
3038 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3039 initialize the MVP framework.
3040 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3041 New file. Activity manager for the main container widget. This is the
3043 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3044 Maps place (URL) to its corresponding activity.
3045 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3046 New file. This is just a place holder for a generated file.
3047 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
3048 New file. Represents the URL for the main Online Glom app.
3049 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
3050 for changes in LayoutListViewImpl.
3051 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
3052 interface for View. Move code to OnlineGlomViewImpl class.
3053 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
3054 file. Implementation of OnlineGlomView.
3055 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
3056 Place resources. Use ClientFactoryImpl by default.
3058 2011-04-04 Ben Konrath <ben@bagu.org>
3060 Move View classes to their own package.
3062 This is the second commit of a refactor that will allow OnlineGlom to
3063 be used with multiple documents.
3065 * src/main/java/org/glom/web/client/OnlineGlom.java:
3066 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
3067 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
3069 2011-04-02 Ben Konrath <ben@bagu.org>
3071 Move UI code from the main module to its own class.
3073 This is the first commit of a refactor that will allow OnlineGlom to be
3074 used with multiple documents.
3076 * src/main/java/org/glom/web/client/LayoutListView.java: Update
3077 references to OnlineGlom to OnlineGlomView.
3078 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
3079 OnlineGlomView and instantiate it here.
3080 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
3081 represents the main OnlineGlomView with one document.
3083 2011-04-01 Ben Konrath <ben@bagu.org>
3085 Fix formatting of gwt.xml and add DTD.
3087 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
3089 2011-03-30 Ben Konrath <ben@bagu.org>
3091 Propperly convert gdkColor string to html colour string.
3093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3095 2011-03-28 Ben Konrath <ben@bagu.org>
3097 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
3099 This implementation matches
3100 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
3101 readable and is not tied to Swig.
3103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3105 2011-03-28 Ben Konrath <ben@bagu.org>
3107 Use read-only checkboxes for boolean field types.
3109 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
3110 in the CellTable based on the field type. It currently only
3111 distinguishes between boolean and text columns but I'll need to add
3112 support for more types.
3113 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3114 column type in the ColumnInfo object. Add method to convert between the
3115 glom field type enum in ColumnInfo and the glom field type in libglom.
3116 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
3118 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
3119 getting and setting booleans.
3121 2011-03-25 Ben Konrath <ben@bagu.org>
3123 Don't get the Date twice from the ResultSet.
3125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3127 2011-03-25 Ben Konrath <ben@bagu.org>
3129 Cleanup code in the servlet.
3131 * TODO: Remove item about row count. Add item about testing row count
3132 query with large number of rows.
3133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
3134 spelling mistakes, change method parameter to be consistent with
3137 2011-03-25 Ben Konrath <ben@bagu.org>
3139 Add server side logging with the gwt-log library.
3141 * .gitignore: Ignore the log file we're now producing.
3142 * TODO: Add a couple TODO item for logging.
3143 * pom.xml: Add gwt-log and log4j as a dependency.
3144 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3145 logging of errors, warnings and some important info.
3146 * src/main/resources/log4j.properties: New file to configure log4j.
3148 2011-03-24 Ben Konrath <ben@bagu.org>
3150 Add a disable button for the Details view.
3152 * src/main/java/org/glom/web/client/LayoutListView.java:
3154 2011-03-22 Ben Konrath <ben@bagu.org>
3156 Use a count query to get the number of rows for the list view pager.
3158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3160 2011-03-22 Ben Konrath <ben@bagu.org>
3162 Add more TODO information about CellTable pager positioning.
3166 2011-03-19 Ben Konrath <ben@bagu.org>
3168 Add TODO item about CellTable pager positioning.
3172 2011-03-18 Ben Konrath <ben@bagu.org>
3174 Remove unneeded GlomFieldColumn class.
3176 This is just a small code cleanup.
3178 * src/main/java/org/glom/web/client/LayoutListView.java:
3180 2011-03-18 Ben Konrath <ben@bagu.org>
3182 Use cursor mode in the query that gets data for the list view.
3184 I still need to fix the potential memory problem when getting the row
3185 count for the list view.
3187 * TODO: Add note about testing memory usage with large data sets. Add
3188 item about fixing row counting with large data sets.
3189 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
3190 PostgreSQL JDBC driver into cursor mode when getting data for the
3193 2011-03-15 Ben Konrath <ben@bagu.org>
3195 Remove the GWT Container from the Eclipse build classpath.
3197 The GWT dependencies are set by Maven so this isn't needed.
3201 2011-03-15 Murray Cumming <murrayc@murrayc.com>
3203 Added some earlier mockups to git, but not to the tarball dist.
3205 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
3206 Openismus. These hopefully show how we might structure the HTML so that
3207 it can be styled easily with CSS. However, we probably need to adapt them
3208 for the CSS structure that GWT dictates for common widgets.
3210 2011-03-14 Ben Konrath <ben@bagu.org>
3212 Locate OnlineGlom.properties using the ServletContext.
3214 This is required to be able to locate the file in the deployed servlet.
3216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3217 Configure the database and glom document in in a helper method so
3218 that the ServletContext can be used to locate OnlineGlom.properties.
3219 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
3220 src/main/webapp. This is the proper location for .properites files.
3222 2011-03-12 Ben Konrath <ben@bagu.org>
3224 Add note to README about why we're compiling down to obfuscated JavaScript.
3228 2011-03-11 Ben Konrath <ben@bagu.org>
3230 Use properties file to configure servlet.
3232 This allows people to change the glom file path, db username and db
3233 password without recompiling the code.