1 2012-04-12 Murray Cumming <murrayc@murrayc.com>
3 Translations: Add Esperanto.
5 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
6 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
7 properties: Add this translation because someone took the time to make it.
9 2012-03-15 Murray Cumming <murrayc@murrayc.com>
11 Use the latest java-libglom version.
13 * pom.xml: Use java-libglom 1.21.7.
15 2012-03-03 Ben Konrath <ben@bagu.org>
17 Display date and time in details view.
19 https://bugzilla.gnome.org/show_bug.cgi?id=671257
21 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
23 2012-02-24 Ben Konrath <ben@bagu.org>
25 Improve the tabs in the Notebook widget.
29 2012-01-30 Murray Cumming <murrayc@murrayc.com>
31 Translations: Try to translate the strings.
33 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
34 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
35 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
36 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
37 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
38 Take the Open translation from GTK+'s .po files.
39 Take the Details translation from Glom's po files.
40 I have added the other strings to Glom so we can get translations that way:
41 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
43 2012-01-27 Murray Cumming <murrayc@murrayc.com>
45 TableSelectionViewImpl: Put the search label and entry in a div.
47 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
48 Put the search widgets in a FlowTable so that the CSS can be used to
49 style them while keeping them together.
50 * src/main/webapp/style.css: Mention the new div.
52 2012-01-27 Murray Cumming <murrayc@murrayc.com>
54 Translate more strings in more locales.
56 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
57 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
58 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
59 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
60 Translate the "Details" and "Open" string too.
62 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
63 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
64 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
65 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
66 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
67 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
68 Add these new locales as placeholders though they currently contain English.
70 2012-01-27 Murray Cumming <murrayc@murrayc.com>
72 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
74 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
75 Check the ConfiguredDocument* for null before using it.
77 2012-01-26 Murray Cumming <murrayc@murrayc.com>
79 Tell Eclipse about the generated java files.
81 * .classpath: This lets it find OnlineGlomConstants.java.
82 It would be nice if Eclipse just used the maven build files.
84 2012-01-26 Murray Cumming <murrayc@murrayc.com>
86 Prevent a crash when no locale is specified in the URL.
88 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
89 Avoid returning a null string, obtained from
90 Window.Location.getParameter(). This caused a crash when it was
91 later passed to libglom's API.
92 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
93 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
94 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
95 guard against future null strings.
97 2012-01-26 Murray Cumming <murrayc@murrayc.com>
99 Use the ?locale= query param instead of the &lang= token param.
101 * src/main/java/org/glom/web/client/place/ListPlace.java
102 * src/main/java/org/glom/web/client/place/DetailsPlace.java
103 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
104 Remove the lang token key and value.
106 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
107 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
108 When the user selects a different locale from the chooser, use
109 Window.Location.assign() to change the URL, which then causes a reload.
111 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
112 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
113 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
114 * src/main/java/org/glom/web/client/activity/ListActivity.java
115 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
116 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
117 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
118 * src/main/java/org/glom/web/client/ui/ListView.java:
119 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
121 Remove localeID member variables and method/constructor parameters, instead
122 using Utils.getCurrentLocaleID() when we need a localID to pass to
125 2012-01-26 Murray Cumming <murrayc@murrayc.com>
127 Internationalize the UI strings.
129 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
130 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
131 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
132 because it is unused. Messages are apparently strings that can have
133 parameters, but we do not need that yet, so Contants will be enough for now.
134 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
135 to say that we support the en and de locales.
136 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
137 The original English strings.
138 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
139 Some German translations of the English strings.
140 The i18n goal then uses the .properties file to generate an
141 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
142 returns an implementation that returns the translated strings.
143 The documentation suggests putting these in src/java/*/client/, but it seems
144 best to put it in src/resources/*/client/.
145 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
146 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
147 instead of hard-coding them.
148 Note that we cannot import OnlineGlomConstants because it does not exist yet,
149 but that does not seem to stop the build, though it confuses Eclipse.
151 You can see the translated string by adding ?locale=de to the URL, like so:
152 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
154 2012-01-24 Murray Cumming <murrayc@murrayc.com>
156 Improve null/empty String checks.
158 * pom.xml: Add a dependency on commons-lang, to use
159 org.apache.commons.lang.StringUtils.
160 * src/main/java/org/glom/web/server/ConfiguredDocument.java
161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
162 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
163 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
164 Use StringUtils.isEmpty().
166 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
167 StringUtils class with a static isEmpty() function because we
168 cannot use org.apache.commons.lang.StringUtils in client-side
169 GWT code because it (apparently) cannot be compiled to javascript.
170 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
171 * src/main/java/org/glom/web/client/activity/ListActivity.java
172 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
173 * src/main/java/org/glom/web/client/place/DetailsPlace.java
174 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
175 * src/main/java/org/glom/web/client/place/ListPlace.java
176 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
177 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
178 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
179 * src/main/java/org/glom/web/client/ui/details/Group.java
180 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
181 our StringUtils.isEmpty() function.
183 2012-01-24 Murray Cumming <murrayc@murrayc.com>
185 Update to the latest java-libglom API.
187 * pom.xml: Require java-libglom 1.21.4.
188 * src/main/java/org/glom/web/server/ConfiguredDocument.java
189 getDocumentInfo(), getListViewLayoutGroup():
190 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
192 * src/main/java/org/glom/web/server/database/DBAccess.java
193 getFieldsToShowForSQLQueryAddGroup(),
194 getPrimaryKeyLayoutItemField(): Replace get_database_title()
195 with either get_database_title_original() or
196 get_database_title(localeID).
198 2012-01-24 Murray Cumming <murrayc@murrayc.com>
200 ConfiguredDocument: Avoid a null pointer exception.
202 * src/main/java/org/glom/web/server/ConfiguredDocument.java
203 Initialize localeID to "" to avoid returning a null String which
204 causes a crash in java-libglom's swing-generated code.
206 2012-01-23 Murray Cumming <murrayc@murrayc.com>
208 Some simple renaming.
210 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
211 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
212 for localeChooser. This seems more appropriate and is less ambiguous
213 particularly in the .css file.
215 2012-01-23 Murray Cumming <murrayc@murrayc.com>
217 ConfiguredDocument: Rename the localedID private member variable.
219 2012-01-23 Murray Cumming <murrayc@murrayc.com>
221 Adapt to the latest java-libglom API from git master.
223 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
224 libglom now uses only Vector instead of List, which uses add() instead of
227 2012-01-20 Murray Cumming <murrayc@murrayc.com>
229 Build a source tarball with mvn assembly:single
231 * assembly.xml: Add this file.
232 * pom.xml: Use the maven-assembly-plugin and tell it to use
233 our assembly.xml file.
235 2012-01-19 Murray Cumming <murrayc@murrayc.com>
237 OnlineGlomServiceImpl: Get .glom files recursively.
239 * pom.xml: Depend on commons-io from org.apache.commons.
240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
241 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
242 files recursively, and with the easier filter for the extension.
243 Use org.apache.commons.io.FilenameUtils.removeExtension() to
244 simplify that code too.
246 2012-01-19 Murray Cumming <murrayc@murrayc.com>
248 README: Mention that you must install java-libglom packages separately.
250 But then it works, because java-libglom is now in the central maven
253 2012-01-18 Murray Cumming <murrayc@murrayc.com>
255 locales drop-down: Show the correct selected locale when the URL changes.
257 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
258 .java: setPlace(): Move some code into fillView().
260 2012-01-18 Murray Cumming <murrayc@murrayc.com>
262 locales drop-down: Do not lose the primary key.
264 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
265 start(): onLocaleChange(): Pass the current primary key value,
266 instead of an empty value.
268 2012-01-18 Murray Cumming <murrayc@murrayc.com>
270 locales drop-down: Do not lose the drop-down selection.
272 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
273 .java (TableSelectionActivity.fillView): Set the selected locale
274 after changing the drop-down items (though we do not really need
275 to change them just because the locale changes.)
277 2012-01-18 Murray Cumming <murrayc@murrayc.com>
279 locales drop-down: Change the tables list when this changes.
281 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
282 .java: TableSelectionActivity.start(): Move the async table titles
283 retrieval into a private fillView() method and also call this when
284 the chosen locale changes.
285 Note that the document title is not actually translatable yet, but
286 that is a problem that I should fix soon in libglom.
288 2012-01-18 Murray Cumming <murrayc@murrayc.com>
290 Improve the placement of the locales drop-down.
292 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
293 Put the title and locales drop-down in a div (gwt.FlowTable).
294 * src/main/webapp/style.css: Add magic css properties to make this work.
295 Also remove the left margin from the title so that it lines up with the
298 2012-01-18 Murray Cumming <murrayc@murrayc.com>
300 locales selector: Show human-readable locale titles.
302 * src/main/java/org/glom/web/server/ConfiguredDocument.java
303 getDocumentInfo(): Use java.util.Locale to show a real title of
304 each locale, in the locale's own language.
306 2012-01-17 Murray Cumming <murrayc@murrayc.com>
308 Add a language/locale selector drop-down.
310 * src/main/java/org/glom/web/shared/DocumentInfo.java:
311 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
312 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
313 getDocumentInfo(): Store the available Locales in the DocumentInfo.
314 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
315 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
316 Add a ListBox to show the available locales. Add getLocaleSelector(),
317 setLocaleList(), getSelectedLocale(), setSelectedLocale().
318 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
319 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
320 java: Add these classes.
321 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
322 start(): Fill the locales ListBox. Handle its change event, firing a
324 setPlace(): Show the selected locale as specified by the URL token.
325 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
326 * src/main/java/org/glom/web/client/activity/ListActivity.java:
327 Handle LocaleChangeEvent, going to a new *Place with that locale.
329 The placement of the ListBox is not pretty, and it currently uses the ID
330 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
334 2012-01-17 Murray Cumming <murrayc@murrayc.com>
336 Search box: Show the search text from the URL token.
338 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
339 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
340 Add setQuickFindText().
341 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
342 .java: setPlace(): Store the queryText if the place is a ListPlace,
343 and call TableSelectionView.setQuickFindText().
345 2012-01-17 Murray Cumming <murrayc@murrayc.com>
347 Allow use of translations via, for instance, &lang=de in the URL.
349 * pom.xml: Use the unstable java-libglom 1.21 version.
351 * src/main/java/org/glom/web/client/OnlineGlomService.java:
352 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
353 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
354 init(): Instead of calling TranslatableItem.set_current_locale()
355 (now removed), call ConfiguredDocument.setDefaultLocaleID().
356 However, this is only for default locales, which are not needed to
357 change the locale in the URL.
358 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
359 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
360 getSortedRelatedListData(): Add a localeID parameter, so we can get the
361 layout for a particular locale.
362 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
363 Add get/setDefaultLocaleID().
364 getDocumentInfo(), getListViewData(), getRelatedListData(),
365 getDetailsLayoutGroup(), getListViewLayoutGroup(),
366 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
367 localeID parameter, so we can get the layout for a particular locale.
369 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
370 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
371 * src/main/java/org/glom/web/client/place/ListPlace.java:
372 Parse and construct a lang parameter too.
374 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
375 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
376 passed to subsequent methods and constructors.
377 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
378 * src/main/java/org/glom/web/client/activity/ListActivity.java:
379 Store the localeID from the *Place and pass it to other constructors
380 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
382 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
383 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
384 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
385 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
386 * src/main/java/org/glom/web/client/ui/ListView.java:
387 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
388 Take localeID parameters and pass them to subsequent constructors and
389 methods, so that the layout is always retrieved for that locale.
391 This is rather repetitive.
393 Note that "" means the original (default) locale of the Glom document,
394 which is usually English.
396 2012-01-17 Murray Cumming <murrayc@murrayc.com>
398 Documents: Remove final keyword to fix startup configuration.
400 * src/main/java/org/glom/web/shared/Documents.java: Remove the
401 final keywords on the private member variables because that breaks
402 the startup, apparently (there are warnings) because it stops them
403 from being serialized. I added these in the previous commit.
405 2012-01-13 Murray Cumming <murrayc@murrayc.com>
407 Documents: Add some final keywords.
409 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
412 2012-01-13 Murray Cumming <murrayc@murrayc.com>
414 OnlineGlomServiceImpl: Add to overview comments.
416 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
417 Note that this is where all the document are loaded. They are not
418 loaded freshly for each page.
420 2012-01-12 Murray Cumming <murrayc@murrayc.com>
424 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
425 Add a TextBox for the text of a quick find.
426 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
428 setBackLink(): Add a String quickFind parameter.
429 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
430 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
431 to the base interface, because that is how TableSelectionViewImpl is used.
432 * src/main/webapp/style.css: Add style for the search box and its label.
434 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
435 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
436 Add these files, based on the existing TableChangeEvent and
437 TableChangeEventHandlers.
438 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
439 start(): Handle QuickFindChangeEvent, passing its quickFind text to
440 a ListPlace() that the user should be taken to.
441 * src/main/java/org/glom/web/client/activity/ListActivity.java
442 start(): Handle it here too and adapt the TableChangeEvent handler to
443 pass the extra "" quickFind parameter to ListPlace.
444 * src/main/java/org/glom/web/client/place/ListPlace.java:
445 Constructor: Take an extra String quickFind parameter and store it,
446 returning it from a new getQuickFind() method.
447 getToken(): Put the quickFind text in the URL token.
448 getPlace(): Parse the quickFind text from the URL token.
449 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
450 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
451 ListPlace constructor.
452 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
453 .java: start(): Add a Change handler for the TableSelectionView's
454 TextBox (via its base HasChangeHandlers interface), firing the new
455 QuickFindChangeEvent.
456 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
457 pass the extra "" quickFind parameter.
459 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
460 setCellTable(): Add a String quickFind parameter and pass it to
461 the ListViewTable() constructor.
462 * src/main/java/org/glom/web/client/ui/ListView.java: Change
463 setCellTable() in the base interface, because that is how ListViewImpl
466 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
467 Add a String quickFind member variable.
468 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
469 Constructor: Add a String quickFind parameter, storing it in the
470 base ListTable's member variable.
471 onRangeChanged(): Pass quickFind to the
472 OnlineGlomServiceAsync.getSortedListViewData() and
473 OnlineGlomServiceAsync.getListViewData() methods.
475 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
476 getListViewData(), getSortedListViewData(): Add a String quickFind
477 parameter, passing it to ConfiguredDocument.getListViewData().
478 * src/main/java/org/glom/web/client/OnlineGlomService.java:
479 Change getListViewData(), getSortedListViewData() in the base interface,
480 because that is how OnlineGlomServiceImpl is used, via this:
481 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
482 Change getListViewData(), getSortedListViewData() here too.
483 This class can apparently be used to asynchronously call methods on
484 OnlineGlomService, and GWT seems to implement that after recognizing
485 just the *Async name convention and the extra AsyncCallback parameters.
487 * src/main/java/org/glom/web/server/ConfiguredDocument.java
488 getListViewData(): Add a String quickFind parameter, and pass it to
489 ListViewDBAccess.getData().
490 * src/main/java/org/glom/web/server/database/ListDBAccess.java
491 getListData(): Add a String quickFind parameter and pass it to
493 getSelectQuery(): Add a String quickFind parameter.
494 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
495 getSelectQuery(): Add a String quickFind parameter and use it with
496 Glom.get_find_where_clause_quick() to pass a where_clause to
497 Glom.build_sql_select_with_where_clause(), to actually filter the
499 getData(): Add a String quickFind parameter, passing it to getListData().
500 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
501 va: getData(): Pass an empty string to getListData() for the
504 2012-01-12 Murray Cumming <murrayc@murrayc.com>
506 ListTable: Minor change.
508 * src/main/java/org/glom/web/client/ui/list/ListTable.java
509 createCellTable(): Make this protected instead of public.
511 2012-01-12 Murray Cumming <murrayc@murrayc.com>
513 Many files: Use final for the parameters and use the @override attribute.
515 2012-01-22 Ben Konrath <ben@bagu.org>
517 Add anchor links for single line text that starts with http, ftp and www.
521 2012-01-22 Ben Konrath <ben@bagu.org>
523 Add ellipsis to single line text in details view.
527 2012-01-04 Murray Cumming <murrayc@murrayc.com>
529 Remove all javadoc author tags.
531 Because they are awkward and meaningless when many people touch
533 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
535 2012-01-04 Murray Cumming <murrayc@murrayc.com>
537 Revert the COPYING.LESSER to COPYING rename.
539 Apparently both should be there if it is LGPL.
541 2012-01-03 Murray Cumming <murrayc@murrayc.com>
543 *View: Remove unused imports.
545 * src/main/java/org/glom/web/client/ui/DetailsView.java:
546 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
547 * src/main/java/org/glom/web/client/ui/ListView.java:
548 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
549 Remove unused imports, as suggested by Eclipse.
551 2012-01-02 Murray Cumming <murrayc@murrayc.com>
553 Move the *View::Presenter types, and some API into one base View.
555 * src/main/java/org/glom/web/client/ui/DetailsView.java:
556 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
557 * src/main/java/org/glom/web/client/ui/ListView.java:
558 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
559 Presenter, setPresenter() and clear() into a shared base interface,
560 to avoid the unnecessary duplicate Presenter types and to more clearly
561 show how the *Views share the same structure, even if they are not
562 used polymorphically.
564 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
565 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
567 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
568 * src/main/java/org/glom/web/client/activity/ListActivity.java:
569 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
571 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
574 Feel free to revert this if there is a good reason for the duplicate
577 2012-01-02 Murray Cumming <murrayc@murrayc.com>
579 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
581 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
582 a class member instead of a local variable in the method.
583 This lets us use it to get the view instances, for use in tests.
584 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
585 beforeOnlineGlom(): Test some more details of the initial view.
586 Again, this is not very useful.
588 To really test gwt-glom we will need to start a local postgresql
589 instance with local data, like the Glom tests in C++.
591 2012-01-02 Murray Cumming <murrayc@murrayc.com>
593 pom.xml: Mention the LGPL license.
595 * pom.xml: Add a licenses section.
596 * COPYING.LESSER: Move this to COPYING, which
597 previously contained the GPL. But gwt-glom is all LGPL.
599 2012-01-02 Murray Cumming <murrayc@murrayc.com>
601 Add project information to README and pom.xml.
603 * README: Add a brief description and mention some mvn
605 * pom.xml: This extra information shows up in mvn site
608 2011-01-02 Murray Cumming <murrayc@murrayc.com>
610 Use the latest java-libglom version.
612 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
614 2012-01-01 Murray Cumming <murrayc@murrayc.com>
616 GwtTestOnlineGlom: Test a little more.
618 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
619 protected rather than private, as suggested by the gwt-test-utils
621 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
622 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
623 Test the initial visibility of the panels.
625 However, this is not a very useful test.
626 And I wonder how we should generally test using this idea for an
627 activity/places app like ours where the real changes happen implicitly
628 based on the history token/URL.
630 2012-01-01 Murray Cumming <murrayc@murrayc.com>
632 Slight modification to *Mapper comments.
634 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
636 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
638 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
640 Remove comments mentioning GIN because they are just copied from
641 the example code and are apparently not helpful:
642 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
643 Also change the mention of a class that is only in the example code.
645 2012-01-01 Murray Cumming <murrayc@murrayc.com>
647 GwtTestOnlineGlom test: Minor changes.
649 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
650 Avoid the long qualified class name and modify the comment
651 because it is now obvious to me that the mocked class is the only
652 custom one created via GWT.create().
654 2012-01-01 Murray Cumming <murrayc@murrayc.com>
656 Tests: Added the beginnings of a test using gwt-test-utils.
658 * pom.xml: Add dependencies on gwt-test-utils and easymock.
659 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
660 which tells gwt-test-utils what class will be tested.
661 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
662 Add a simple (but empty) test case. One class, used by the OnlineGlom
663 class, is mocked so that it can be created. However, I am not sure
664 why only this class needs to be mocked.
666 Note that mockito seems more popular, and clearer, than easymock,
667 but I have not got that working yet. It might be a matter of the
670 This test is run during mvn integration-test.
672 2011-12-31 Murray Cumming <murrayc@murrayc.com>
674 Tests: Use junit4-style syntax instead of junit3-style.
676 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
677 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
678 * src/test/java/org/glom/web/shared/DataItemTest.java:
679 Use the @Test annotation rather than relying on the test*() prefix.
680 Also no longer implement TestCase, to avoid triggering support for
681 the junit3-way, which stops the annotations from working.
682 Change the imports from import junit.framework.* to
683 import org.junit.*, which is apparently the new way.
685 2011-12-31 Murray Cumming <murrayc@murrayc.com>
687 Added a test for ListPlace token parsing and creation.
689 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
690 This is much the same as DetailsPlaceTest.
692 I wonder how we could test the other parts of the *Place API.
694 2011-12-30 Murray Cumming <murrayc@murrayc.com>
696 DetailsPlace test: Also test getToken() and recreation via getPlace().
698 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
699 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
700 recreate it, testing the recreated DetailsPlace for the same parameter
703 2011-12-30 Murray Cumming <murrayc@murrayc.com>
705 Use the surefire-report plugin.
707 * pom.xml: This generates a HTML report about the tests in
708 target/site/surefire-report.html
709 when you do mvn surefire-report:report. It seems to be popular/normal.
711 2011-12-30 Murray Cumming <murrayc@murrayc.com>
713 Added a test for DetailsPlace.
715 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
716 Test the getPlace() token parsing.
718 2011-12-30 Murray Cumming <murrayc@murrayc.com>
720 Added a first unit test.
722 * pom.xml: Add a test goal, and a dependency on junit in that scope.
723 * src/test/java/org/glom/web/shared/DataItemTest.java:
724 This is a silly test but it is just to get things started. Note that
725 maven/junit finds the test because it looks in src/test by default.
727 2011-12-22 Ben Konrath <ben@bagu.org>
729 Change charsetName to "UTF-8" when replacing line breaks.
731 JavaScript requires the charsetName to be "UTF-8". CharsetName values
732 that work in Java (such as "UTF8") will not work when compiled to
735 This fixes a problem with multi-line details view fields that have hard
736 line breaks. The "License Text" field on this page demonstrates the
739 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
741 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
743 2011-12-22 Ben Konrath <ben@bagu.org>
745 Fix another bug with related list navigation.
747 I've tested all the navigation buttons in all of the related lists
748 so things should be good now.
750 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
752 2011-12-22 Ben Konrath <ben@bagu.org>
754 Fix a crasher when refreshing the list view with the default table.
756 This crash will also happen when loading the list view with the default
757 table from a link or bookmark.
759 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
760 to the main document selection page when the document id hasn't been
762 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
763 the main document selection page when the document id hasn't been
765 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
766 values for the details place when the document id hasn't been set.
767 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
768 values for the list place when the document id hasn't been set.
770 2011-12-21 Ben Konrath <ben@bagu.org>
772 Protect against NPE when glom.document.locale is not in config.
774 This patch protects against an NPE when glom.document.locale is not in
775 the config file. This NPE will also happen if glom.document.locale is
778 The patch also updates the error message to display the class name when
779 the getMessage() returns null. This was happening when the NPE was
780 thrown and I had "Configuration Error: null". If an NPE is encountered
781 with this patch, "Configuration Error: NullPointerException " will be
784 This commit closes this bug:
786 https://bugzilla.gnome.org/show_bug.cgi?id=666669
788 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
790 2011-12-20 Murray Cumming <murrayc@murrayc.com>
792 Rename onlineglom.properties to onlineglom.properties.sample.
794 * src/main/resources/onlineglom.properties: Rename to:
795 * src/main/resources/onlineglom.properties.sample:
796 * src/main/resources/README: And add this file explaining that people
797 should rename it back when deploying.
799 2011-12-20 Murray Cumming <murrayc@murrayc.com>
801 Allow choosing the translation in the .properties file.
803 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
804 init(): Read a glom.document.locale value from the configuration file
805 and call Glom's TransatableItem::set_current_locale() method.
806 * src/main/resources/onlineglom.properties: Add a commented-out
807 example of this new setting.
809 It would be better to add &lang=de_DE to the URL, but the current
810 libglom API does not allow us to do this easily. I am working on that.
812 2011-12-19 Murray Cumming <murrayc@murrayc.com>
814 Avoid a crash in parsing of token parameters.
816 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
817 ava: getTokenParams(): Do not crash if a parameter has a key but no
818 value, and ignore parameters with neither.
820 2011-12-17 Murray Cumming <murrayc@murayc.com>
822 History token building/handling: Improve use of token parameters.
824 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
825 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
826 and buildParamsToken(HashMap), for use by derived classes.
827 Make the separator private because it is no longer be needed.
828 * src/main/java/org/glom/web/client/place/DetailsPlace.java
829 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
830 instead of manual string concatenation.
831 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
832 of hardcoded indices and awkward splitting code.
833 * src/main/java/org/glom/web/client/place/ListPlace.java
834 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
835 instead of manual string concatenation.
836 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
837 of hardcoded indices and awkward splitting code.
838 This should fix bug #666420
840 2011-12-16 Murray Cumming <murrayc@murrayc.com>
842 Fix a Navgiation->Navigation typo in the code.
844 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
845 Rename processNavgiation() to processNavigation().
847 2011-12-16 Murray Cumming <murrayc@murrayc.com>
849 Fix a seperator->separator typo in the code.
851 * src/main/java/org/glom/web/client/place/DetailsPlace.java
852 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
853 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
856 2011-12-15 Ben Konrath <ben@bagu.org>
858 Cleanup some comments.
860 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
862 2011-12-14 Ben Konrath <ben@bagu.org>
864 Replace \n with <br/> for multiline text in the details view.
866 Vertical scrollbars are added when needed as well.
868 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
870 2011-12-14 Ben Konrath <ben@bagu.org>
872 Specify the font for document selection links.
874 * src/main/webapp/style.css:
876 2011-12-14 Ben Konrath <ben@bagu.org>
878 Fix bouncy CellTable while paging.
880 This doesn't currently work with related list tables in unselected
883 * src/main/java/org/glom/web/client/ui/list/ListTable.java
885 2011-12-14 Ben Konrath <ben@bagu.org>
887 Revamp the appearance of the document selection page.
889 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
890 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
891 * src/main/webapp/style.css:
893 2011-12-13 Ben Konrath <ben@bagu.org>
895 Set navigation button column to the smallest size possible.
897 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
899 2011-12-13 Ben Konrath <ben@bagu.org>
901 Change OpenButton nomenclature to NavigationButton.
903 Using NavigtionButton makes things more generic. Classes, methods and
904 variables have been changed.
906 This is a rename-only refactor.
908 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
909 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
910 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
911 Renamed from OpenButtonCell.
912 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
913 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
914 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
916 2011-12-12 Ben Konrath <ben@bagu.org>
918 Remove unnecessary String argument in RelatedListTable and ListViewTable.
920 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
921 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
922 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
923 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
925 2011-12-12 Ben Konrath <ben@bagu.org>
927 Update variable names and comments.
929 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
930 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
932 2011-12-12 Ben Konrath <ben@bagu.org>
934 Properly initialize numNonEmptyRows variable to zero.
936 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
937 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
939 2011-12-05 Ben Konrath <ben@bagu.org>
941 Add latest mockup with HTML tables.
943 Features of this mockup:
945 -> HTML table for flowtable
946 -> HTML table for flowtable column
947 -> Example of how related lists would look
948 -> Not using text entries for data items
950 The current version of Online Glom doesn't use HTML tables for the
953 This mockup has been sent to the glom-devel mailing list but it's good
954 to have it here as well.
956 * mockups/details-view-html-tables.html:
958 2011-12-05 Ben Konrath <ben@bagu.org>
960 Remove unnecessary getPrimaryKeyField() method.
962 getPrimaryKeyFieldForTable(String) has been renamed to
963 getPrimaryKeyField(String).
965 * src/main/java/org/glom/web/server/database/DBAccess.java:
966 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
967 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
969 2011-12-05 Ben Konrath <ben@bagu.org>
971 Add string representation of TypedDataItem value to conversion error message.
973 * src/main/java/org/glom/web/server/Utils.java: Logging the error
974 message was extracted into its own method to avoid duplication.
976 2011-12-05 Ben Konrath <ben@bagu.org>
978 Add type checking to navigation primary key value creation.
980 Create navigation primary key only if the expected type from the Glom
981 document matches the type returned by the SQL query.
983 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
985 2011-12-05 Ben Konrath <ben@bagu.org>
987 Rename a couple of variables in RelatedListNavigation.
989 This is a rename-only refactor.
991 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
993 2011-12-05 Ben Konrath <ben@bagu.org>
995 Move getListLayoutGroup() into getListViewLayoutGroup().
997 This removes getListLayoutGroup(). It was only being called by
998 getListViewLayoutGroup().
1000 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1002 2011-12-05 Ben Konrath <ben@bagu.org>
1004 Remove check for LayoutItem_Portal in list table method.
1006 This check is no longer necessary because the method isn't being used
1007 to create the LayoutItemPortal DTO.
1009 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1011 2011-12-05 Ben Konrath <ben@bagu.org>
1013 Properly support related list navigation.
1015 Navigation from the "Repository Analyzer -> Package Scans ->
1016 Dependencies" related table wasn't working because the primary key for
1017 related tables wasn't being set properly. This commit fixes the
1020 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1021 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1022 doesn't set the primary key properly for related list tables.
1023 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1024 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1025 useful for getting the primary key for list view tables and for related
1027 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1028 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1029 Move code to set the primary key for the table from the abstract
1030 ListDBAccess class to ListViewDBAccess as it's only correct for list
1032 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1033 Properly add primary key to related list tables.
1035 2011-12-02 Ben Konrath <ben@bagu.org>
1037 Properly set the horizontal alignment of fields.
1039 This fix is for both the list tables and the details view.
1041 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1042 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1043 to set the horizontal alignment of fields.
1045 2011-12-02 Ben Konrath <ben@bagu.org>
1047 Display currency codes in the details view.
1049 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1051 2011-12-02 Ben Konrath <ben@bagu.org>
1053 Avoid duplicate JNI call.
1055 JNI is not as efficient as pure Java and this is an easy (and small)
1058 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1059 Use previously retrieved value for whereClauseToTableName instead of
1062 2011-12-02 Ben Konrath <ben@bagu.org>
1064 Rename a couple of variables in RelatedListNavigation.
1066 This is a rename-only refactor.
1068 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1070 2011-12-02 Ben Konrath <ben@bagu.org>
1072 Indicate clearly that a mismatched primary key type is a bug.
1074 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1075 warning to error. Add 'This is a bug.' to message.
1077 2011-12-02 Ben Konrath <ben@bagu.org>
1079 Update / fix some comments.
1081 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1083 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1085 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1086 Fix comments. Add some TODOs.
1088 2011-12-02 Ben Konrath <ben@bagu.org>
1090 Enable navigation to details view with string primary key from related list.
1092 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1093 Create a text primary key value when return type of result is
1094 java.sql.Types.VARCHAR.
1096 2011-12-02 Ben Konrath <ben@bagu.org>
1098 Use checkboxes for booleans in the details view.
1100 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1102 2011-12-01 Ben Konrath <ben@bagu.org>
1104 Improve performance of related list height calculation.
1106 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1107 Put code to calculate the expected height in a static initializer so
1108 that that it's only called once.
1110 2011-12-01 Ben Konrath <ben@bagu.org>
1112 Show related list tables in notebooks (again).
1114 Calculate the height of the related list tables so the Notebook can be
1115 set the correct height. The height of the related list table is also needed by
1116 FlowTable to be able decide how to create the layout.
1118 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1119 and set the Portal height based on the height of the related list
1120 table and the Portal container.
1121 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1122 Add method to calculate the height of the related list tables.
1123 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1124 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1125 calculate the height of the Pager widget.
1127 2011-12-01 Ben Konrath <ben@bagu.org>
1129 Use CellTable API for table property instead of setting style on Element.
1131 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1133 2011-12-01 Ben Konrath <ben@bagu.org>
1135 Make ListViewTable and RelatedListTable a consistent height.
1137 The tables are now a consistent height regardless of the contents of
1138 the table. A hidden button is added to empty rows to ensure that the
1139 height of these rows will match the height of rows with data.
1141 A navigation button column is now added to every table. The width of
1142 the navigation column is set to 0px when a RelatedListTable shouldn't
1143 have navigation buttons. This maintains the a consistent row height in
1144 tables that don't show the navigation buttons.
1146 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1147 navigation column when not needed.
1148 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1149 arguments for navigation button to constructor of ListViewTable.
1150 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1151 hidden button for empty data rows.
1152 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1153 arguments for navigation button to constructor.
1154 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1155 create navigation buttons. Add hideNavigationButtons() method.
1156 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1157 arguments for navigation button to constructor.
1159 2011-12-01 Ben Konrath <ben@bagu.org>
1161 Use 'visibility: hidden' in Utils.getWidgetHeight().
1163 This is better choice because hidden elements are invisible, don't
1164 respond to events and are not part of the tab order. They will,
1165 however, take up space which is required to be able to calculate the
1166 height of the widget.
1168 * src/main/java/org/glom/web/client/Utils.java:
1170 2011-12-01 Ben Konrath <ben@bagu.org>
1172 Use Utils.getWidgetHeight() in FlowTable.
1174 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1176 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1178 2011-12-01 Ben Konrath <ben@bagu.org>
1180 Put the details css class name on the correct table column.
1182 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1184 2011-11-30 Ben Konrath <ben@bagu.org>
1186 Update for java-libglom API change.
1188 The getters and setters on FieldFormatting and NumericFormat were
1189 changed to remove the 'M'.
1191 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1193 2011-11-29 Ben Konrath <ben@bagu.org>
1195 Only allow RelatedListTables in Portals.
1197 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1199 2011-11-29 Ben Konrath <ben@bagu.org>
1201 Only create a contents panel for Portals when title is being set.
1203 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1205 2011-11-29 Ben Konrath <ben@bagu.org>
1207 Set TabLayoutPanel height based on calculated height its widgets.
1209 This is a potential fix for this bug:
1211 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1213 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1215 2011-11-29 Ben Konrath <ben@bagu.org>
1217 Align details field labels and data with the Open buttons.
1219 * src/main/webapp/style.css:
1221 2011-11-29 Ben Konrath <ben@bagu.org>
1223 Remove unnecessary <div> in the Notebook widget.
1225 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1226 method to get container FlowPanel (<div>).
1227 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1228 initWidget() method directly on the TabLayoutPanel widget instead of
1229 Group's container widget.
1231 2011-11-29 Ben Konrath <ben@bagu.org>
1233 Don't add group titles for Portals in Notebooks.
1235 This reverts the previous patch and fixes a bug I introduced with
1236 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1238 * src/main/java/org/glom/web/client/ui/details/Group.java:
1239 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1241 2011-11-28 Ben Konrath <ben@bagu.org>
1243 Remove unused boolean argument in Portal constructor.
1245 Just a code cleanup.
1247 * src/main/java/org/glom/web/client/ui/details/Group.java:
1248 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1250 2011-11-28 Ben Konrath <ben@bagu.org>
1252 Remove hack for glom 1.18 style glom files.
1254 * src/main/java/org/glom/web/client/ui/details/Group.java:
1255 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1256 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1258 2011-11-28 Ben Konrath <ben@bagu.org>
1260 Use Gda Value version of primary key to log result too large error.
1262 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1264 2011-11-28 Ben Konrath <ben@bagu.org>
1266 Don't use TypedDataItem.getText() for Unknown types from the URL.
1268 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1269 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1270 instead of getText().
1271 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1272 String field and getUnknown() method.
1274 2011-11-28 Ben Konrath <ben@bagu.org>
1276 Log an error message when the java-libglom .so is not present.
1278 The error message was being set in the exception but not logged.
1280 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1282 2011-11-28 Ben Konrath <ben@bagu.org>
1284 Ignore LayoutItem_CalendarPortals.
1286 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1287 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1289 2011-11-28 Ben Konrath <ben@bagu.org>
1291 Extract method for creating the LayoutItemPortal DTO.
1293 Just breaking the code up into smaller chunks.
1295 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1297 2011-11-28 Ben Konrath <ben@bagu.org>
1301 This should have been added with the refactor. Oops!
1303 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1305 2011-11-28 Ben Konrath <ben@bagu.org>
1307 Create primary key value from URL string using type from Glom document.
1309 See this bug, comments 19 - 25:
1311 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1313 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1314 create a TypeDataItem for the primary key here when loading from a
1315 URL. Show the same string for the primary key value as was received
1316 from the URL string (when loading from a URL).
1317 * src/main/java/org/glom/web/server/Utils.java: Update method for
1318 creating the Gda Value from the TypeDataItem to properly deal with
1319 creating a Gda Value based on the Glom document type for the primary
1320 key value string when loading from a URL.
1321 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1322 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1323 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1324 Update for changed method name.
1326 2011-11-27 Ben Konrath <ben@bagu.org>
1328 Rename PrimaryKeyItem to TypedDataItem.
1330 The name PrimaryKeyItem suggests what the class should be used for.
1331 TypedDataItem is a neutral name that describes the class better.
1333 This is a rename-only refactor.
1335 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1336 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1337 * src/main/java/org/glom/web/client/Utils.java:
1338 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1339 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1340 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1341 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1342 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1343 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1344 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1345 * src/main/java/org/glom/web/server/Utils.java:
1346 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1347 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1348 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1349 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1351 2011-11-25 Ben Konrath <ben@bagu.org>
1353 Improve Gda Value conversion from PrimaryKeyItem.
1355 The value from the PrimaryKeyItem is only used if its type match the
1356 type from the glom document.
1358 * src/main/java/org/glom/web/server/Utils.java:
1360 2011-11-25 Ben Konrath <ben@bagu.org>
1362 Manually check if the java-liblgom .so is visible to the JVM.
1364 It seems that Tomcat has problems when a static initializer throws an
1365 exception. This check is done before the first method call into
1366 java-libglom so that execution doesn't continue if the .so is not
1369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1371 2011-11-25 Ben Konrath <ben@bagu.org>
1373 Improve browser configuration error messages.
1377 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1379 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1380 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1381 getConfigurationErrorMessage() method.
1382 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1383 Get and display a specific configuration error message when no Glom
1384 documents are found.
1385 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1386 Implement getConfigurationErrorMessage() method. Surround configuration
1387 code in the init() method with a try/catch block. This allows the
1388 errors to be caught while keeping the servlet available to retrieve the
1389 configuration error message.
1391 2011-11-25 Ben Konrath <ben@bagu.org>
1393 Don't use Strings to hold primary key values.
1395 The primary key values are now held in a new data object
1396 (PrimaryKeyItem) that holds type information and the primary key value
1397 using the correct type.
1399 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1400 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1401 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1402 PrimaryKeyItem instead of String to hold the primary key value.
1403 * src/main/java/org/glom/web/client/Utils.java: Remove
1404 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1405 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1406 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1407 PrimaryKeyItem instead of String to hold the primary key value. Load
1408 document selection page when the documentID has not been set correctly.
1409 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1410 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1412 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1413 Return empty string for URL instead of "null".
1414 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1415 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1416 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1417 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1418 PrimaryKeyItem instead of String to hold primary key values.
1419 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1420 PrimaryKeyValue to a Gda Value.
1421 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1422 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1423 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1424 Replace temporary database access code that uses the PrimaryKeyValue to
1425 Gda Value conversion.
1426 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1427 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1428 PrimaryKeyItem instead of String.
1429 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1430 hold primary key values.
1432 2011-11-24 Ben Konrath <ben@bagu.org>
1434 Use newly added java-libglom API to create queries.
1436 This isn't finished. I still need to stop using Strings for primary key
1437 values in the client code.
1439 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1440 libglom to use fake connections so that retrieving the query string will
1442 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1443 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1444 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1445 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1446 Use the newly added libglom sql methods and classes to create the
1447 query. Add temporary hack to convert primary value strings to Gda
1450 2011-11-23 Ben Konrath <ben@bagu.org>
1452 Don't explicitly set the height of Portals.
1454 See comments 6 - 10 of this bug for details:
1456 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1458 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1460 2011-11-23 Ben Konrath <ben@bagu.org>
1462 Use an HTML table instead of CSS for the FlowTable layout.
1464 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1465 GWT's FlexTable to implement the FlowTable.
1466 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1468 2011-11-18 Ben Konrath <ben@bagu.org>
1470 Add boolean example to HTML table mockup.
1472 * mockups/details-view-html-tables-text-entries.html:
1474 2011-11-17 Ben Konrath <ben@bagu.org>
1476 Ensure the pager buttons are always visible for related lists.
1478 To accomplish this, I've turned off text wrapping in the list view and
1479 related list tables for both the header and data text. The related list
1480 table now has a fixed layout so the it doesn't overflow its container.
1481 This is required to ensure that the cell text is clipped when it
1482 overflows the cell and an ellipsis is added to the right side of the
1483 cell when text is clipped.
1485 A fixed table layout for the related list table in the details view
1486 seems what we want for the details view anyway, so the side-effect is
1489 The ellipsis will only be displayed in Firefox >= 7.
1493 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1495 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1496 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1497 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1499 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1500 Set the 'table-layout: fixed' CSS property to the related list table.
1501 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1502 'white-space: nowrap;' CSS property on both the list view and the
1503 related list tables.
1505 2011-11-16 Ben Konrath <ben@bagu.org>
1507 Rework the fix for empty notebook tab labels.
1509 Setting the empty group titles with its name caused problems for the
1510 details layout. Instead of using libglom's
1511 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1512 to the client when the title is empty. This allows the Notebook to use
1513 the name when the title is empty without affecting anything else.
1515 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1516 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1518 2011-11-16 Ben Konrath <ben@bagu.org>
1520 Set group titles with name when title is empty.
1522 This fixes a problem with an empty notebook tab label in the Lesson
1523 Planner document. The forth tab in the notebook should be "Internet":
1525 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1527 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1528 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1531 2011-11-16 Ben Konrath <ben@bagu.org>
1533 Remove whitespace from the configured username properties.
1535 This assumes that usernames won't have whitespace at the beginning
1536 or end. But I think this is a reasonable assumption.
1538 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1539 String.trim() to remove the whitespace from the username properties.
1541 2011-11-15 Ben Konrath <ben@bagu.org>
1543 Add details view mockup with HTML tables and text entries.
1545 This is from the attachment on this bug:
1547 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1549 * mockups/details-view-html-tables-text-entries.html:
1551 2011-11-15 Ben Konrath <ben@bagu.org>
1553 Add space between the columns of the flow table.
1557 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1559 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1560 space between columns in the flow table.
1562 2011-11-15 Ben Konrath <ben@bagu.org>
1564 Add backup files to the .gitignore.
1566 * .gitignore: Ignore files that end with ~.
1568 2011-11-09 Ben Konrath <ben@bagu.org>
1570 Use latest release of gwt-log.
1572 Gwt-log releases are now being submitted to the maven central
1573 repository so manual installation of the jar is no longer required.
1575 * pom.xml: Update version and groupId of gwt-log dependency.
1577 2011-10-31 Ben Konrath <ben@bagu.org>
1579 Don't use GWT numeric formatting to override the glom currency formatting.
1581 Currencies are now displayed like they are in Glom. See this bug:
1583 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1585 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1587 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1588 currency code to constructor and set it when the cell is rendered.
1589 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1590 currency code to the constructor of the NumericCell.
1592 2011-10-27 Ben Konrath <ben@bagu.org>
1594 Require the latest release of java-libglom (1.17.4).
1598 2011-10-26 Ben Konrath <ben@bagu.org>
1600 Add style to Notebook that matches current theme.
1602 It's not the best style in the world but it's better than the default.
1604 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1605 padding at the bottom of the child widgets.
1606 * src/main/webapp/style.css: Add style for the Notebook.
1608 2011-10-26 Ben Konrath <ben@bagu.org>
1610 Move servlet initialization code to overridden init method.
1612 This is half of the solution to getting proper error messages
1613 displayed when configuration errors occur. Here's the relevant bug:
1615 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1617 The rest of the solution involves surrounding the init method with a
1618 try/catch block and setting a global variable with the error /
1619 exception. A new async method should be created to retrieve and display
1620 the error message / exception.
1622 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1623 code from constructor to init method adding exceptions as needed.
1625 2011-10-26 Ben Konrath <ben@bagu.org>
1627 Add script to monitor and restart tomcat if required.
1629 * utils/check-and-recover-tomcat.py: New file.
1631 2011-10-26 Ben Konrath <ben@bagu.org>
1633 Display the correct number of data items in the pager.
1637 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1639 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1640 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1641 The implementation is the same for both tables: Keep track of the
1642 number of non-empty rows and fire and RowCountChangeEvent after the data has
1644 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1645 custom Pager class that subclasses SimplePager to handle displaying
1646 the correct number when empty rows have been added.
1648 2011-10-26 Ben Konrath <ben@bagu.org>
1650 Correct error in previous commit.
1652 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1653 eventBus parameter from listView.setCellTable().
1655 2011-10-26 Ben Konrath <ben@bagu.org>
1657 Fix error in TODO comment.
1659 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1661 2011-10-24 Ben Konrath <ben@bagu.org>
1663 Create Notebook widgets to the details view.
1665 This isn't finished just yet - I still need to create a reasonable
1666 style to match the current theme.
1668 * src/main/java/org/glom/web/client/Utils.java: Add method for
1669 calculating the height of a widget. This is used in the Notebook class.
1670 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1671 new constructor method in Group.
1672 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1673 method for creating child widget that can be used by subclasses
1674 like Notebook. New constructor that allows disabling the group
1675 titles - Notebooks don't set a group title for their child groups.
1676 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1677 to make Notebooks using GWT's TabLayoutPanel.
1678 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1679 constructor that allows disabling the group titles.
1680 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1681 LayoutItemNotebook DTO.
1682 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1683 DTO for Notebooks. It's just an empty class for now but we might need
1684 it to transfer some specific information in the future.
1686 2011-10-21 Ben Konrath <ben@bagu.org>
1688 Add navigation buttons to related list tables.
1690 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1691 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1692 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1693 method getSuitableRecordToViewDetails() for getting the table name
1694 and primary key value for related list navigation buttons.
1695 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1696 private cell renderer class to get the navigation information for
1697 related list tables from the server. Extract the navigation
1698 processing code from the details cell navigation and use it for the
1699 related list navigation as well.
1700 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1701 cell renderer class for the details open buttons. This was needed
1702 because the related list navigation buttons and the list view
1703 navigation buttons need to react differently when clicked.
1704 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1705 the onEnterKeyDown() method because it's now overriden in the
1706 subclasses that are specific to the related list tables and the list
1708 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1709 the vertical size a little because the buttons add a bit of vertical
1710 space to table. This is not a perfect solution because the vertical
1711 size of with table fewer than 5 rows will be a little smaller.
1712 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1713 changes in how navigation buttons are handled.
1714 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1715 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1716 database access object.
1717 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1718 to find the portal for a given relationship name from
1719 RelatedListDBAccess. Add method to find a primary key field for a
1721 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1722 Move code to find the portal for a given relationship name to
1724 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1725 New file: database access object for getting the related list
1726 navigation information (the table name and the primary key value).
1727 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1728 DTO for transferring a table name to navigate to and a primary key
1730 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1731 boolean and getter/setter to specifies if the related list should add
1734 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1736 Use the master branch of java-libglom
1738 * pom.xml: Depend on java-libglom 1.19 instead.
1740 This is the master branch. See also the libglom-1-18 branch.
1742 2011-10-11 Ben Konrath <ben@bagu.org>
1744 Enable the open navigation button when the data has been set.
1746 This avoids having active buttons that don't do anything when the data
1749 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1751 2011-10-11 Ben Konrath <ben@bagu.org>
1753 Use IsWidget interface for FlowTableItem.
1755 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1756 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1758 2011-10-11 Ben Konrath <ben@bagu.org>
1760 Remove GWT styling from open button in details view.
1762 There are still some issues with how the details cell is arranged but
1763 this should be made to match Glom 1.20. I'm going to leave fixing this
1764 until I have Glom 1.20 up and running.
1766 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1767 style name on open button.
1768 * src/main/webapp/style.css: Move and edit details-navigation class.
1769 Re-arrange some classes to make them appear in the same order as the
1772 2011-10-07 Ben Konrath <ben@bagu.org>
1774 Update to GWT 2.4.0.
1776 * .gitignore: Ignore new cache directory.
1777 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1778 * pom.xml: Change GWT and maven plugin to 2.4.0.
1779 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1781 * src/main/java/org/glom/web/client/ClientFactory.java:
1782 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1783 * src/main/java/org/glom/web/client/OnlineGlom.java:
1784 Update source for API changes.
1785 * utils/build-onlineglom-war.sh: Remove cache directory before the
1788 2011-10-07 Ben Konrath <ben@bagu.org>
1790 Add navigation buttons in the details view.
1792 This isn't finished but I thought I'd commit what I have as it's a
1793 pretty good start. I still need to:
1795 1. Change the style so that it fits better into the current theme
1796 2. Adjust the details cell to expand as much as possible.
1798 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1799 click handlers to navigation buttons in the DetailsCells. Create a
1800 refreshData() method to get just the data from the server without the
1802 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1803 Update the tableSelector and browser title when the table name
1804 changes without using the tableSelector.
1805 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1806 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1807 getDetailsCells() to getCells(). Update variable names.
1808 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1809 method to set click handler on navigation button. Rename a few
1810 variables. Add navigation buttons where needed.
1811 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1812 variables and methods.
1813 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1814 navigation boolean and navigation table as required in the
1815 LayoutItemField DTO.
1816 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1817 variables for navigation along with getter/setter methods.
1819 2011-10-07 Ben Konrath <ben@bagu.org>
1821 Rename Field to DetailsCell.
1823 This is a refactor-only commit. No functionality has been added or
1826 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1827 Update variable and method names.
1828 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1829 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1830 variable and method names.
1831 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1833 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1834 variable and method names.
1836 2011-10-07 Ben Konrath <ben@bagu.org>
1838 Create separate methods for layout and data the details view.
1840 This is a refactor-only commit. No functionality has been added or
1843 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1844 private methods: setData(), createLayout().
1846 2011-10-07 Ben Konrath <ben@bagu.org>
1848 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1850 This is part of a change to get navigation buttons in the details view
1851 but it should have been done this way from the start.
1853 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1854 for method name change in TableSelectionView.
1855 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1856 Create TableChangeEvent and set the browser title using the
1857 TableSelectionView API.
1858 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1859 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1860 Change getSelectedTable() to getSelectedTableName(). Add
1861 getSelectedTableTitle().
1863 2011-10-07 Ben Konrath <ben@bagu.org>
1865 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1867 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1869 2011-10-07 Ben Konrath <ben@bagu.org>
1871 Update TableChangeEvent to use newTableName naming convention.
1873 This makes the class more consistent with GWT naming conventions.
1875 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1876 Update for method name change in TableChangeEvent.
1877 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1878 for method name change in TableChangeEvent.
1879 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1880 newTableName variable and getter method. Make toDebugString()
1883 2011-09-30 Ben Konrath <ben@bagu.org>
1885 Disable the pager in the list tables when the data row count is less than the minimum.
1887 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1888 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1890 2011-09-30 Ben Konrath <ben@bagu.org>
1892 Add empty rows to the end of related list and list view tables.
1894 I also extracted the cell rendering classes from the ListTable because
1895 the code was becoming a little crazy with all the anonymous inner
1896 classes. My plan is to use these cell rendering classes in the details
1897 view as well so this refactor will be needed for that change.
1899 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1900 set the row count in related list tables if the data has more rows
1901 than the minimum number of rows visible.
1902 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1903 row count in list view tables if the data has more rows than the
1904 minimum number of rows visible.
1905 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1906 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1908 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1909 for rendering TYPE_NUMERIC cells. The code was extracted from the
1911 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1912 class for rendering cells with buttons in list views. The code was
1913 extracted from the ListTable class.
1914 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1915 for rendering TYPE_TEXT cells. The code was extracted from the
1917 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1918 Add empty rows to the end of the data if required. Implement
1919 ListTable.getMinNumVisibleRows().
1920 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1921 cell renderer code to public classes. Return null in
1922 Column.getValue() for empty rows. Add new abstract method:
1923 getMinNumVisibleRows(). Move code to set the row count of the list view
1924 table to ListViewImpl.
1925 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1926 empty rows to the end of the data if required. Implement
1927 ListTable.getMinNumVisibleRows().
1930 2011-09-27 Ben Konrath <ben@bagu.org>
1932 Use GWT.log for client-side debugging statements.
1934 These are optimized out when deployed so I should have used this method
1935 in the first place. These statements will eventually be replaced with some sort
1936 of notification in the browser.
1938 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1939 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1940 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1941 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1942 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1944 2011-09-27 Ben Konrath <ben@bagu.org>
1946 Put tableselector on the right, back to list link on right.
1948 The idea is that the table selector is acting like a label for the
1949 currently displayed table so it should be placed below the document title. This
1950 puts the table title in a similar position to where it is in Glom.
1952 * mockups/details-contacts.html:
1953 * mockups/details-projects.html:
1954 * mockups/listview-contacts.html:
1955 * mockups/listview-projects.html:
1956 * mockups/style.css:
1957 Update mockups to match how the interfaces currently look.
1958 * src/main/webapp/style.css: Swap positions of backlink with the table
1959 selector. Add some space on the left side of the table selector to
1960 line things up with the document title.
1962 2011-09-27 Ben Konrath <ben@bagu.org>
1964 Add field colouring to details view.
1966 This change re-works how field colouring works. The colour formatting
1967 information is now set to the client with the layout information instead of
1968 with the data. This eliminates the need to send the same colour strings for
1969 data in list view column when colour information is set.
1971 In order to set an alternate colour for negative numeric values, the
1972 number is now sent to client and formatted with the GWT NumberFormat class.
1974 This change also fixes:
1976 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1978 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1979 internationalization framework which is needed for client side numeric
1981 * src/main/java/org/glom/web/client/Utils.java: New file for some
1982 client static utility methods.
1983 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1984 the DataItem object to the Field class. Use a utility method to
1985 create the foreignKeyValue string.
1986 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1987 alignment and text colours in the constructor. Add setData(DataItem)
1988 method. Remove setText(String) method.
1989 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1990 colour information to GlomTextCell. Create and use GlomNumberCell for
1991 rendering numbers. Use utility method to get the string for the
1992 primary key of the key provider. Re-work how the horizontal alignment
1994 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1995 formatting to layout information. Methods for converting the libglom
1996 formatting information were moved from DBAccess.
1997 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1998 numeric formatting (it's now done on the client side). Don't set text
1999 colours in DataItem. Move libglom formatting conversion methods to
2001 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2002 getters/setters for text colour information.
2003 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2004 for transferring the libglom NumericFormat information to the client.
2005 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2006 and getters/setters for: GlomNumericFormat, background colour and
2007 foreground colour strings.
2009 2011-09-26 Ben Konrath <ben@bagu.org>
2011 Simplify code that iterates through the LayoutGroup.
2013 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2015 2011-09-26 Ben Konrath <ben@bagu.org>
2017 Accept Eclipse formatting for OnlineGlomServiceAsync.
2019 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2021 2011-09-26 Ben Konrath <ben@bagu.org>
2023 Don't use the ListDBAccess classes to get the primary key layout information.
2025 This was causing a bug where the wrong index for the hidden primary key
2026 was being sent to the client.
2028 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2029 primary key while creating the LayoutGroup DTO. Create a
2030 LayoutItemField DTO for hidden primary keys. Don't use the
2031 RelatedListDBAccess because it was only used for getting the primary
2033 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2034 access modifier from public to protected for getPrimaryKeyField() and
2035 getPrimaryKeyLayoutItemField().
2036 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2037 abstract method getExpectedResultSize() because RelatedListDBAccess
2038 doesn't have enough info to implement it.
2039 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2040 Remove @Override for getExpectedResultSize().
2041 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2042 Remove method getExpectedResultSize().
2044 2011-09-23 Ben Konrath <ben@bagu.org>
2046 Log which layout (list or details) the ignored item is from.
2048 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2050 2011-09-23 Ben Konrath <ben@bagu.org>
2052 Remove annotations that turn off code formatting in DataItem.
2054 * src/main/java/org/glom/web/shared/DataItem.java:
2056 2011-09-23 Ben Konrath <ben@bagu.org>
2058 Rename GlomField to DataItem and update associated methods.
2060 This is a rename-only refactor. No functionality has been added or
2063 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2064 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2065 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2066 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2067 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2068 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2069 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2070 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2071 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2072 * src/main/java/org/glom/web/server/database/DBAccess.java:
2073 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2074 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2075 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2076 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2077 * src/main/java/org/glom/web/shared/DataItem.java:
2078 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2079 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2081 2011-09-23 Ben Konrath <ben@bagu.org>
2083 Rename GlomDocument to DocumentInfo and update associated methods.
2085 This is a rename-only refactor. No functionality has been added or
2088 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2089 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2090 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2091 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2092 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2094 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2096 2011-09-20 Ben Konrath <ben@bagu.org>
2098 Require java-libglom 1.17.3.
2100 This picks up the fix for the seg fault problem with the Scenes table
2101 in the Openismus Film Manager example.
2105 2011-09-20 Ben Konrath <ben@bagu.org>
2107 Change the way sort clause is added for primary key when no sort clause is requested.
2109 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2110 before the sort clause is created. When a sort clause is not requested, the
2111 sort clause is created by finding the primary key in the LayoutFieldVector
2114 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2116 2011-09-20 Ben Konrath <ben@bagu.org>
2118 Log error message if no documents are found in the configured directory.
2120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2121 Extract the glom file extension string to a private static final class
2122 variable (mostly as syntactic sugar). Accept a minor formatting change.
2123 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2124 the example glom.document.directory configuration property to make it
2125 more clear that it can any directory, not just the home directory.
2127 2011-09-18 Ben Konrath <ben@bagu.org>
2129 Add related lists to details view.
2131 The related list table has support for paging and sorting just like the
2132 table in the list view.
2134 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2135 SQL queries for the related list tables.
2136 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2137 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2138 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2139 Rename getList methods to getListView and add comments. Remove
2140 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2141 it being unused. Add methods: getDetailsLayoutAndData(),
2142 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2143 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2144 Create the layout and set the data for the fields in one async call
2145 instead of two. Create related lists where appropriate.
2146 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2147 for method name changes in OnlineGlomService.
2148 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2149 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2150 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2152 * src/main/java/org/glom/web/client/ui/ListView.java:
2153 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2154 tableName from setCellTable(). Create a ListViewTable instead of
2156 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2157 represent a data field in the details view.
2158 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2159 from addDetailsCell() to Field class. Keep track of the Fields and
2160 Portals in the details view.
2161 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2162 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2163 and add a method to get it. Add method to set the contents of the
2165 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2166 New class for related list tables. This class has the data provider
2167 for the related list table.
2168 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2169 abstract class which is the base class for the ListViewTable and the
2171 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2172 New class for list view tables. This class has the data provider for
2173 the list view table.
2174 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2175 methods for related list tables. Add more information to the
2176 LayoutItemField and LayoutItemPortal DTOs.
2177 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2178 Remove debugging print statement.
2179 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2180 Remove debugging print statements. Add primary key field to SQL count
2182 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2183 Remove unnecessary LayoutFieldVector parameter from
2184 getResultSizeOfSQLQuery() method.
2185 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2186 New class for related list table database access.
2187 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2188 class that is a wrapper DTO for details view layout and data.
2189 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2190 new 'fromField' string to this DTO.
2191 * src/main/webapp/style.css: Remove bottom margin and override top
2194 2011-09-15 Ben Konrath <ben@bagu.org>
2196 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2198 This sets things up to make it easier to add the data retrieval for
2199 related lists (portals). No user noticeable changes were made with
2202 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2203 class has the code to retrieve the layouts and access the
2204 database using the new database helper classes.
2205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2206 Most of the functionality has been removed from this class. This
2207 class now represents the public interface for the client side
2208 code. It also deals with configuring the servlet and cleaning
2209 things up when the servlet is stopped.
2210 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2211 of static methods into this utility class.
2212 * src/main/java/org/glom/web/server/database/DBAccess.java:
2213 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2214 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2215 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2216 These classes have the database retrieval code. The class hierarchy
2217 has been setup to make it easy to reuse code for similar
2220 2011-09-06 Ben Konrath <ben@bagu.org>
2222 Create separate classes for list table code and the data provider.
2224 As part of this refactor, I also split up the code a bit to make it
2227 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2228 table code to two new classes (below).
2229 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2230 with code from ListViewImpl.
2231 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2232 New file with code from ListViewImpl.
2234 2011-09-06 Ben Konrath <ben@bagu.org>
2236 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2238 This fixes the LayoutItemPortal DTO to match the libglom layout object
2241 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2243 2011-09-01 Ben Konrath <ben@bagu.org>
2245 Set title of Portals in the Details View.
2247 * pom.xml: Bump required version of java-libglom to 1.17.1.
2248 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2249 widget creation to its own class. Add comments to constructor.
2250 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2251 The code is mostly from the Group class with the title now set.
2252 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2253 title of Portal. Update some comments. Fix some code formatting.
2255 2011-09-01 Ben Konrath <ben@bagu.org>
2257 Remove TODO comment for the flow table column width.
2259 The flow table column width is working correctly and doesn't need to be
2260 changed. See this mailing list post for more info:
2262 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2264 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2266 2011-08-27 Ben Konrath <ben@bagu.org>
2268 Add document title (database name) to top of the browser page.
2270 I added the document title to the TableSelecitonView but that will
2271 change if / when we add a view that doesn't require table selection.
2273 * mockups/details-contacts.html:
2274 * mockups/details-projects.html:
2275 * mockups/listview-contacts.html:
2276 * mockups/listview-projects.html:
2277 * mockups/style.css: Add document title to mockups to keep things
2279 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2280 sizes to account for the document title.
2281 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2282 Set the document title when it has been retrieved from the server.
2283 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2284 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2285 and implement setDocumentTitle(String) method.
2286 * src/main/webapp/style.css: Add ID for document title style.
2288 2011-08-25 Ben Konrath <ben@bagu.org>
2290 Add NavigationType enum to LayoutItemPortal DTO.
2292 This is the start of adding support for Portals to the Details View.
2294 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2295 LayoutItem_Portal.navigation_type enum from libglom to
2296 LayoutItemPortal.NavigationType enum.
2297 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2298 NavigationType enum, field for storing the NavigationType and getter
2301 2011-08-25 Ben Konrath <ben@bagu.org>
2303 Implement the flow table layout in the Details View.
2305 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2306 FlowTable to Group to account for the renamed class.
2307 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2308 File. This is a container widget that implements the Glom details view
2309 flow table behaviour.
2310 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2311 org/glom/web/client/ui/FlowTable.java.
2312 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2313 so that the size of the subgroups are a closer match to the size of
2314 the Glom subgroups. This makes the flowtable layout match the layout
2315 in Glom for the Music Collection example file.
2317 2011-08-16 Ben Konrath <ben@bagu.org>
2319 Create container element for LayoutItemPortal in Details View.
2321 This will help me develop the layout for the FlowTable.
2323 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2324 fieldPanel variable to detailsCell.
2326 2011-08-15 Ben Konrath <ben@bagu.org>
2328 Set the height of the data element in the Details View.
2330 I changed the InlineLabels (text in a span element) to Labels (text in
2331 a div element) so that I could set the height of the details-data
2332 elements instead of the details-cell parent elements. This allows the
2333 the details-data element to display the correct height if style is
2334 applied that shows the height.
2336 This change has the added benefit of allowing the order of the labels
2337 and data elements to be changed for right-to-left languages.
2339 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2340 InlineLabels to Labels.
2341 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2342 InlineLabels to Labels. Set the height of the data element.
2343 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2344 multiline text height in the Formatting DTO.
2345 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2346 for multiline height along with getter and setter methods.
2347 * src/main/webapp/style.css: Adjust style to account for the change
2348 from span elements to div elements in the details cell.
2350 2011-08-15 Ben Konrath <ben@bagu.org>
2352 Make the List View appearance match the mockups.
2354 It doesn't match exactly but it's much better than it was.
2356 * mockups/listview-contacts.html: Remove unused css classes.
2357 * mockups/listview-projects.html: Remove unused css classes.
2358 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2359 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2360 for mainPanel instead of VerticalPanel (table). Set style name on
2361 CellTable. Set style name on Details column. Right-align Details
2363 * src/main/webapp/style.css: Adjust properties to match the mockups.
2365 2011-08-12 Ben Konrath <ben@bagu.org>
2367 Add better support for subgroups in the details view.
2369 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2370 changed FlowTable constructor.
2371 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2372 support for subgroups and subgroup-titles.
2373 * src/main/webapp/style.css: Add CSS class for subgroups and
2376 2011-08-12 Ben Konrath <ben@bagu.org>
2378 Return the top level LayoutGroup title.
2380 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2382 2011-08-11 Ben Konrath <ben@bagu.org>
2384 Make the TableSelector header match the mockup.
2386 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2387 the layout panel. Properly lineup the table selection header with
2388 the list and details view.
2389 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2390 margin around the details view.
2391 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2392 Rename listBox variable to tableSelector. Set id for the style sheet.
2393 Use a FlowPanel instead of a HorizontalPanel.
2394 * src/main/webapp/style.css: Add properties to make the TableSelector
2395 box match the mockups.
2397 2011-07-13 Ben Konrath <ben@bagu.org>
2399 Update install script for java-libglom version change.
2401 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2404 2011-07-13 Ben Konrath <ben@bagu.org>
2406 Add support sub-group in the details view.
2408 I also removed the code that special-cased the default details view
2411 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2413 I still have to make a proper flowtable.
2415 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2416 Don't special-case default details view layout.
2417 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2418 addLayoutField() as I'm going to use it.
2419 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2420 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2422 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2423 extracted from DetailsViewImpl.GroupPanel. Add support for
2425 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2426 column count when getting the details layout.
2428 2011-07-12 Ben Konrath <ben@bagu.org>
2430 Set browser title with database and table titles.
2432 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2433 Set the browser title when the table changes and when the activity
2435 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2436 title when retrieving document info (the GlomDocument object).
2437 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2438 with getter and setter methods. Remove unused convenience constructor.
2439 Use default code formatting.
2441 2011-07-12 Ben Konrath <ben@bagu.org>
2443 Ignore LayoutItemPortals in the details view.
2445 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2448 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2449 LayoutItemPortal layout objects.
2450 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2451 LayoutItemPortal objects when retrieving the details layout.
2452 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2453 file. This is an empty class and just used to get type information for
2456 2011-07-12 Ben Konrath <ben@bagu.org>
2458 Use java-libglom 1.17.0.
2462 2011-07-11 Ben Konrath <ben@bagu.org>
2464 Remove "Table:" label from table selector.
2466 This matches a recent change in the Glom UI.
2468 * mockups/details-contacts.html:
2469 * mockups/details-projects.html:
2470 * mockups/listview-contacts.html:
2471 * mockups/listview-projects.html: Remove the "Table:" label from the
2473 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2475 2011-07-11 Ben Konrath <ben@bagu.org>
2477 Add main groups to the details view.
2479 This makes things look a little nicer in the details view. The next step
2480 is to implement the flowtable.
2482 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2483 resources from the standard gwt css theme. Standard.css is now
2484 included in OnlineGlom.html so that the online glom css rules have
2485 precedence over the gwt theme.
2486 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2487 the whole LayoutGroup to the DetailsView instead of just the titles.
2488 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2489 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2490 details layout with a helper class (GroupPanel). I might extract this
2491 class when I make the full flowtable.
2492 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2493 string as default so I don't have to worry about NPEs when processing
2495 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2496 note beside OnlineGlom.gwt.xml above).
2497 * src/main/webapp/style.css: Add default font-size to body to override
2498 the font-size set by the standard theme. Don't use h2 tags for
2499 group-title. Create new details-cell class.
2501 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2503 ConfiguredDocument: Set the port number too.
2505 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2506 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2507 Glom document. Presumably this worked sometimes so far because there is a
2508 default port number.
2510 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2512 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2514 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2515 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2516 correct, though we should throw an exception too.
2518 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2520 Fix a addDocuemnt typo.
2522 * src/main/java/org/glom/web/shared/Documents.java
2523 (Documents.addDocuemnt): Rename to addDocument().
2524 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2525 (OnlineGlomServiceImpl.getDocuments): Adapt.
2527 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2529 Slightly improved log output when connection fails.
2531 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2532 (ConfiguredDocument.setUsernameAndPassword):
2533 We don't know for sure if it' the username/password that's wrong, so
2534 rephrase the message.
2535 Also ouput the exception message, though it's generic in this case.
2537 2011-07-08 Ben Konrath <ben@bagu.org>
2541 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2542 added braces to a one line if statement because the Eclipse formatter
2543 was getting confused.
2545 2011-07-07 Ben Konrath <ben@bagu.org>
2547 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2549 These should really be two separate tasks but I counldn't get things to
2550 work with GWT 2.2.0 and Eclipse 3.7.
2554 * .settings/org.eclipse.jdt.core.prefs:
2555 * .settings/org.eclipse.jdt.ui.prefs:
2556 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2557 * .settings/org.eclipse.m2e.core.prefs:
2558 Add new config files. Update current files. Remove references to the
2559 webtools plugins as we're not using any of the webtools features.
2560 * .gitignore: Add logs directory which is created when running with
2562 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2563 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2564 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2566 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2568 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2570 onlineglom.properties: Add explanatory comments.
2572 * src/main/resources/onlineglom.properties: Also change the default user
2573 from ben to someuser, to avoid the risk of people thinking we just
2574 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2576 2011-06-28 Ben Konrath <ben@bagu.org>
2578 Use filename in Log for incorrect passwords.
2580 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2581 getFileName(String) method to get the filename from the URI.
2583 2011-06-28 Ben Konrath <ben@bagu.org>
2585 Add the table name to the URL token for the ListPlace.
2587 This makes things consistent between the DetailsPlace and the
2588 ListPlace. It also allows the the ListPlace to be bookmarked.
2590 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2591 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2593 Remove getDefaultListLayout(). The default layout is now returned
2594 by the getListLayout() method when the table name is an empty string.
2595 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2596 Add table name field. Change to a new ListPlace when the table
2597 has been changed. Use getListLayout() for getting the default
2599 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2600 Add table name field. Set the correct table name in the list box
2601 when loading from bookmark. This corrects a problem for the
2603 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2604 Move table name to super-class (HasSelectableTable). Move document
2605 and table URL keys to super-class in HasSelectableTable.
2606 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2607 Add table name field. Add Tokenizer class with URL key common to
2608 the subclasses (DetailsPlace and ListPlace).
2609 * src/main/java/org/glom/web/client/place/ListPlace.java:
2610 Add table name. Add code to parse the URL token.
2611 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2612 Update ListPlace construction with empty table name string.
2613 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2614 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2615 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2616 Update ListPlace construction with table name string.
2617 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2618 Change defaultTableName field to tableName to reflect how it's now
2619 used. Update the getter and setter methods.
2621 2011-06-28 Ben Konrath <ben@bagu.org>
2623 Enable the table selector in the DetailsView.
2625 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2626 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2627 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2628 Remove getDefaultDetailsLayout(). The default layout is now returned
2629 by the getDetailsLayout() method when the table name is an empty
2631 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2632 event handler for table change event. Change to using
2633 getDetailsLayout() for the default details layout.
2634 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2636 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2637 when navigating to the details place.
2639 2011-06-27 Ben Konrath <ben@bagu.org>
2641 Use filename based unique document ID in URL and for RPC.
2643 The document ID is the glom document name with spaces (' ') replaced
2644 with pluses ('+') and without the .glom extension.
2646 This change is mostly a string substitution of 'documentTitle' for
2647 'documentID'. The only code change is the addition of a Documents DTO to get the
2648 filename to document title mappings as indicated below.
2650 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2651 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2652 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2653 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2654 Use Documents DTO to create the document links in the document
2656 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2657 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2658 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2659 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2660 * src/main/java/org/glom/web/client/place/ListPlace.java:
2661 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2662 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2663 * src/main/java/org/glom/web/client/ui/ListView.java:
2664 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2665 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2666 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2667 * src/main/java/org/glom/web/server/Log.java:
2668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2669 getDocumentTitles() to getDocuments() and return the Documents DTO.
2670 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2671 transferring the filename to document title mappings.
2673 2011-06-25 Ben Konrath <ben@bagu.org>
2675 Make the authentication popup work again.
2677 This bug was introduced when I extracted ConfiguredDocument to its own class.
2679 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2680 correct success / fail status in setUsernameAndPassword().
2682 2011-06-25 Ben Konrath <ben@bagu.org>
2684 Use filename as unique key for configuring database usernames and passwords.
2686 This replaces the use of the Glom document title which could change
2687 depending on the locale. Thanks to Murray Cumming for pointing out this
2690 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2691 * src/main/resources/onlineglom.properties:
2693 2011-06-24 Ben Konrath <ben@bagu.org>
2695 Pass primary key value to DetailsView.
2697 This enables the DetailsView to load the correct data.
2699 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2700 primary key value field and set in constructor. Pass primary key
2701 value to getDetailsData().
2702 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2703 variables for document title and primary key value.
2704 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2705 key value to the DetailsPlace.
2707 2011-06-24 Ben Konrath <ben@bagu.org>
2709 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2711 This allows the primary key to be retrieved by the Details button. This
2712 functionality has not been implemented yet but it's in the works.
2714 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2715 the LayoutGroup result to ListView.setCellTable instead of all of its
2716 fields individually.
2717 * src/main/java/org/glom/web/client/ui/ListView.java:
2718 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2719 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2720 get the primary key for the table.
2721 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2722 index of the primary key in the LayoutGroup accounting for hidden
2723 primary keys. Rename getJavaNumberFormat() to
2724 convertToJavaNumberFormat() for consistency. Cleanup / add some
2726 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2727 field for primary key index and a field to indicate whether the
2728 primary key is hidden or not.
2730 2011-06-23 Ben Konrath <ben@bagu.org>
2732 Rename getTableData methods to getListData.
2734 This is a rename refactor for consistency with other methods.
2736 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2737 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2738 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2739 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2741 2011-06-23 Ben Konrath <ben@bagu.org>
2743 Extract the ConfiguredDocument innerclass into its own class.
2745 This makes the servlet code more object oriented.
2747 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2748 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2749 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2750 new ConfiguredDocument class.
2752 2011-06-21 Ben Konrath <ben@bagu.org>
2754 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2756 This makes things more inline with how libglom works and reduces code
2757 duplication. This refactor lays the groundwork for adding the primary key to
2758 the LayoutGroup object.
2760 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2761 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2763 Change method names to getListLayout and getDefaultListLayout for
2764 consistency. Use LayoutGroup as the DTO for the list layout instead of
2765 ColumnInfo and LayoutListTable.
2766 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2767 new method names along with the LayoutGroup object for transferring the
2769 * src/main/java/org/glom/web/client/ui/ListView.java:
2770 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2771 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2772 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2774 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2775 Replaced with LayoutGroup.
2776 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2777 expectedResultSize and defaultTableName fields which are needed for
2779 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2780 type field which is needed for the list layout but will also be
2781 useful for the details layout as things progress.
2782 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2783 Make class abstract. Remove the unnecessary
2784 getFormattingHorizontalAlignment method. Add setFormatting method.
2786 2011-06-16 Ben Konrath <ben@bagu.org>
2788 Add scripts for building and installing war.
2790 These will help when updating OnlineGlom but they're also good
2791 supplemental documentation of the build and deployment proceeding.
2793 * utils/build-onlineglom-war.sh: New file.
2794 * utils/install-onlineglom-war.sh: New file.
2796 2011-06-16 Ben Konrath <ben@bagu.org>
2798 Create wrapper class to create consistent log messages.
2800 I wrapped methods in the Log class of gwt-log to add the method names
2801 from the servlet and create consistent formatting of the document title
2802 and table names in the log messages.
2804 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2805 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2806 log methods to use methods from wrapped Log class.
2808 2011-06-16 Ben Konrath <ben@bagu.org>
2810 Remove superfluous conditional return.
2812 Thanks to Murray Cumming for pointing this out!
2814 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2816 2011-06-15 Ben Konrath <ben@bagu.org>
2818 Return an ArrayList of LayoutGroups for the Details layout.
2820 This corrects a problem with the details layout as it can have more
2821 than one top level LayoutGroup.
2823 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2824 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2825 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2826 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2827 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2828 with ArrayList of LayoutGroups for the details view layout.
2829 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2830 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2831 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2832 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2833 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2834 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2836 2011-06-14 Ben Konrath <ben@bagu.org>
2838 Use cast_dynamic method to determine the libglom LayoutItem type.
2840 This is better than finding the LayoutItem type by using the string
2841 returned from the get_part_type_name() method.
2843 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2845 2011-06-14 Ben Konrath <ben@bagu.org>
2847 Add method names to log entries in the servlet.
2849 This helps when tracking down deployment problems.
2851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2853 2011-06-14 Ben Konrath <ben@bagu.org>
2855 Add data to the DetailsView using a hard-coded primary key value.
2857 The layout and functionality of the DetailsView is not complete. This
2858 is just a checkpoint so the patch doesn't get too big.
2860 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2861 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2862 Add getDetailsData() servlet method.
2863 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2864 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2865 LayoutFields are added to the DetailsView.
2866 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2867 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2868 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2869 take the string for the title instead of the object.
2870 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2871 Add implementation getDetailsData() along with some private helper
2873 * src/main/webapp/style.css: Add padding to details-data class. Add a
2874 details-label class with the same padding as the details-data class.
2876 2011-06-03 Ben Konrath <ben@bagu.org>
2878 Use presenter.goTo() to change to the DetailsPlace.
2880 This will make things easier when we need to open the DetailsView with
2881 data specific to the row that was clicked.
2883 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2885 2011-06-02 Ben Konrath <ben@bagu.org>
2887 Add CSS file from mockups.
2889 I'm adding this now because it's going to be useful to have when
2890 developing the DetailsView. The TableSelectionView and ListView aren't
2893 * src/main/webapp/OnlineGlom.html:
2894 * src/main/webapp/style.css:
2896 2011-06-02 Ben Konrath <ben@bagu.org>
2898 Use String.isEmpty() to check for empty string.
2900 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2902 2011-06-02 Ben Konrath <ben@bagu.org>
2904 Display main layout group titles in the DetailsView.
2906 This is the start of the DetailsActivity/DetailsView implementation.
2908 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2909 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2910 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2911 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2912 Get the layout information for the details view from the server and set
2913 the main layout group titles.
2914 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2915 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2916 Add addLayoutGroup() and addLayoutField() methods. This are just
2917 temporary methods for creating the the details view that will change
2919 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2920 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2922 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2923 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2924 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2925 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2926 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2927 Data Transfer Objects that mimic the libglom object structure. These are
2928 used for transferring the details layout but could also be used for
2929 transferring the list layout.
2931 2011-05-27 Ben Konrath <ben@bagu.org>
2933 Reset the AuthenticationPopup when clearing the ListView.
2935 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2937 2011-05-27 Ben Konrath <ben@bagu.org>
2939 Fix problem with onlineglom.properties file loading.
2941 The old way worked in Eclipse but not on the server. Loading the
2942 onlineglom.properties file now works in Eclipse and on the server.
2944 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2946 2011-05-24 Ben Konrath <ben@bagu.org>
2948 Update gwt-log from 3.1.0 to 3.1.2.
2950 Gwt-log 3.1.0 has been marked as depreciated.
2954 2011-05-24 Ben Konrath <ben@bagu.org>
2956 Add comment to ListActivity.goTo() method.
2958 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2960 2011-05-24 Ben Konrath <ben@bagu.org>
2962 Remove FIXME in convertGdkColorToHtmlColour()
2964 The Gdk::Color value returned by libglom is 16-bits per channel on both
2965 64 and 32-bit platforms.
2967 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2969 2011-05-19 Ben Konrath <ben@bagu.org>
2971 Improve performance of initial ListView load.
2973 I removed a round trip to the server for getting the default table name
2974 and then requesting information about that table. This also removes a potential
2975 problem with the table change handler not being setup in time to receive the
2976 table change event from the ListActivity.
2978 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2979 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2980 getDefaultLayoutListTable() method. Improve comments.
2981 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2982 getDefaultLayoutListTable() method instead of firing a table change
2983 event to get the table to load.
2984 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2985 implementation of getDefaultLayoutListTable() method.
2986 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2989 2011-05-19 Ben Konrath <ben@bagu.org>
2991 Override toDebugString() in TableChangeEvent.
2993 This is useful to have for debugging.
2995 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2997 2011-05-19 Ben Konrath <ben@bagu.org>
2999 Add a "Back to List" link when at the DetailsPlace.
3001 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3002 Populate the CellTable based on the selected table of the ListBox if
3003 it's set otherwise use the default table. This allows the "Back to
3005 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3006 Remove Place from constructors. Add a setPlace() method. Add
3007 goToPlace() method. Set class as presenter for TableSelectionView.
3008 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3009 Use the same TableSelectionActivity when switching between the List and
3011 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3012 Subclass the new HasSelectableTablePlace. This removes some duplicate
3014 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3015 New class to represent Places that display the TableSelectionView.
3016 * src/main/java/org/glom/web/client/place/ListPlace.java:
3017 Subclass the new HasSelectableTablePlace. This removes some duplicate
3019 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3020 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3021 Add Presenter interface. Add setBackLinkVisible() method. Add
3022 setBackLink() method.
3024 2011-05-18 Ben Konrath <ben@bagu.org>
3026 Enable the "Details" buttons.
3028 Right now only an empty details view is displayed.
3030 * src/main/java/org/glom/web/client/ClientFactory.java:
3031 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3032 Add DetailsView to ClientFactory.
3033 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3034 A basic activity for the details view.
3035 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3036 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3038 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3039 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3041 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3042 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3043 unnecessary super() in constructor.
3044 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3045 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3046 really shouldn't create a new TableSelectionActivity for both the ListPlace
3047 and the DetailsPlace so this should be considered a temporary solution.
3048 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3049 New file. Represents a URL for the details view.
3050 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3051 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3052 A basic details view interface and implementation.
3053 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3054 Enable the "Details" buttons.
3056 2011-05-12 Ben Konrath <ben@bagu.org>
3058 Use a LayoutPanel with multiple display areas for main layout.
3060 This is mostly a refactor in that there are no changes from the user
3061 point of view. These changes are required so that we can swap out the list view
3062 with the details view when the user clicks the "Details" button.
3064 * src/main/java/org/glom/web/client/ClientFactory.java:
3065 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3066 OnlineGlomView. Add TableSelectionView, ListView and
3067 AuthenticationPopup.
3068 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3069 for main layout. Add display regions for main activities. Add
3070 activity manager for for main activities.
3071 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3072 file from parts of the deleted OnlineGlomActivity.
3073 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3074 New file from parts of the deleted OnlineGlomActivity.
3075 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3076 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3077 New files for app wide table change event.
3078 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3079 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3080 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3081 Activity mappers for the main activities replace the deleted app-wide
3083 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3084 Fix a spelling error in he comment.
3085 * src/main/java/org/glom/web/client/ui/ListView.java:
3086 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3087 Renamed from LayoutListView and modified for MVP. This still not a
3088 proper dumb view as prescribed by the MVP pattern but it works for now.
3089 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3090 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3091 New widget stripped out of the deleted OnlineGlomView.
3092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3093 Remove hack that is fixed by this patch.
3095 2011-05-06 Ben Konrath <ben@bagu.org>
3097 Rename OnlineGlomPlace to ListPlace.
3099 The only change besides the rename is that url will now display #list
3100 instead of #Document.
3102 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3103 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3104 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3105 * src/main/java/org/glom/web/client/place/ListPlace.java:
3106 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3108 2011-05-06 Ben Konrath <ben@bagu.org>
3110 Use Presenter for app navigation.
3112 This is the proper way to deal with Place (URL) changes with the MVP
3115 * src/main/java/org/glom/web/client/ClientFactory.java:
3116 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3117 PlaceHistoryMapper and PlaceHistoryHandler.
3118 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3119 PlaceHistoryMapper and PlaceHistoryHandler.
3120 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3121 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3122 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3123 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3124 Add Presenter interface and setPresenter methods. Rename addHyperLink
3125 to addDocumentLink taking only the document title as a parameter.
3127 2011-04-14 Ben Konrath <ben@bagu.org>
3129 Prompt for db username/password if they haven't been set.
3131 This is implemented with a popup widget that is contained within the
3132 OnlineGlomView and managed by the OnlineGlomActivity.
3134 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3135 methods for checking and setting the database username and password.
3136 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3137 new methods for checking and setting the database username and
3139 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3140 Display authentication popup if the JDBC connection to the database
3141 has not been authenticated.
3142 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3144 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3145 for dealing with the authentication popup.
3146 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3147 Implement the methods for dealing with the authentication popup.
3148 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3149 try to executed queries if the database connection hasn't been
3150 authenticated. Implement methods for checking and setting the
3151 database username and password.
3153 2011-04-12 Ben Konrath <ben@bagu.org>
3155 Make log messages a little clearer.
3157 Add a dash betweeen the document title and the table name.
3159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3161 2011-04-12 Ben Konrath <ben@bagu.org>
3163 Protect against NPEs when cleaning up database resources.
3165 While this isn't strictly necessary because the exception is caught,
3166 not protecting against the NPEs makes it harder to find the real error
3169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3171 2011-04-12 Ben Konrath <ben@bagu.org>
3173 Move configuration of the servlet to the constructor.
3175 The servlet will be initialized even if the database authentication
3176 information is not set or correct. I still need to add the UI for prompting
3177 the user for the authentication information when it's required.
3179 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3180 javadocs for getDocumentTitles() method.
3181 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3182 Set error message when RPC fails.
3183 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3184 glom files directory from the configuration file. Try to set the
3185 database authentication information for the specific document if it's
3186 set and works otherwise try to use the global authentication
3187 information set for the directory.
3188 * src/main/resources/onlineglom.properties: Moved from
3189 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3190 Added detailed comments for the new keys.
3192 2011-04-11 Ben Konrath <ben@bagu.org>
3194 Remove unnecessary @Override in DocumentSelectionViewImpl.
3196 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3198 2011-04-11 Ben Konrath <ben@bagu.org>
3200 Remove center alignment in DocumentSelectionView.
3202 The title element is still centred but the document titles and bottom
3203 sentence are both left-aligned.
3205 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3207 2011-04-11 Ben Konrath <ben@bagu.org>
3209 Change 'Demo' naming convention to 'Document'.
3211 This is just a rename refactor with no functional changes to the code.
3213 * src/main/java/org/glom/web/client/ClientFactory.java:
3214 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3215 * src/main/java/org/glom/web/client/OnlineGlom.java:
3216 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3217 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3218 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3219 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3220 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3221 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3222 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3223 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3224 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3225 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3227 2011-04-08 Ben Konrath <ben@bagu.org>
3229 Remove FIXME from safeLongToInt() method.
3231 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
projects / online-glom:gwt-glom.git / blob