1 2012-03-15 Murray Cumming <murrayc@murrayc.com>
3 Use the latest java-libglom version.
5 * pom.xml: Use java-libglom 1.21.7.
7 2012-03-06 Murray Cumming <murrayc@murrayc.com>
9 ReportGenerator: Do not show nulls.
11 2012-03-06 Murray Cumming <murrayc@murrayc.com>
13 ReportGenerator: Make the title font larger.
15 2012-03-06 Murray Cumming <murrayc@murrayc.com>
17 ReportGenerator: Put field titles inside groups, if there are groups.
19 2012-03-06 Murray Cumming <murrayc@murrayc.com>
21 ReportGenerator: Take the Report itself instead of the name and group.
23 * src/main/java/org/glom/web/server/ConfiguredDocument.java
24 Remove getReportLayoutGroup().
25 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
26 getReportHTML(): Pass the report instead
27 of its name and layout group.
28 * src/main/java/org/glom/web/server/ReportGenerator.java
29 generateReport(): Use the report object to use the title
32 2012-03-06 Murray Cumming <murrayc@murrayc.com>
34 ReportGenerator: Remove designBand parameters.
36 * src/main/java/org/glom/web/server/ReportGenerator.java:
37 Make designBand a class member instead of passing it to all
40 2012-03-06 Murray Cumming <murrayc@murrayc.com>
42 ReportGenerator: Add lines, a bit like in the desktop version.
44 * src/main/java/org/glom/web/server/ReportGenerator.java
45 addToReport(): Use JRDesignLine.
47 2012-03-06 Murray Cumming <murrayc@murrayc.com>
49 ReportGenerator: Correct the title positions and use some bold style.
51 * src/main/java/org/glom/web/server/ReportGenerator.java:
52 Break the code up into reusable functions, correct the placement of
53 titles, and use normal/bold styles as in the reports in the desktop
56 2012-03-06 Murray Cumming <murrayc@murrayc.com>
58 ReportGenerator: Add a header band to show the field titles.
60 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
61 getReportHTML(): Pass the localeId to the ReportGenerator
63 * src/main/java/org/glom/web/server/ReportGenerator.java
64 constructor: Take the localeID so we can get translated field
66 generateReport(), addToReport(), addFieldToBand(): Add field
67 titles in a column header band.
69 2012-03-05 Murray Cumming <murrayc@murrayc.com>
71 Reports drop-down list: Some improvement.
73 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
74 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
75 Adedd setSelectedReport(),
76 setReportList(): Add a blank line so that the user can select the
78 * src/main/java/org/glom/web/client/activity/ReportActivity.java
79 start(): Show the current report by calling setSelectedReport().
80 This does not seem to work yet.
82 2012-03-05 Murray Cumming <murrayc@murrayc.com>
84 DetailsActivity, ListActivity: Move some variables into a base class.
86 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
87 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
88 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
89 the clientFactory, documentID, tableName and authenticationPopup into
90 a base class, to avoid duplication.
92 2012-03-05 Murray Cumming <murrayc@murrayc.com>
94 Translate the Reports label.
96 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
97 Get the "Reports" label string from the constants.
98 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
99 perties: Add Reports to the constants.
101 2012-03-03 Ben Konrath <ben@bagu.org>
103 Display date and time in details view.
105 https://bugzilla.gnome.org/show_bug.cgi?id=671257
107 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
109 2012-03-05 Murray Cumming <murrayc@murrayc.com>
111 Require the latest java-libglom.
113 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
115 2012-03-05 Murray Cumming <murrayc@murrayc.com>
117 Reports: Implement grouping.
119 * src/main/java/org/glom/web/server/ReportGenerator.java:
120 Handle LayoutItem_GroupBy items and try to do the right thing
121 with JRDesignGroup. It seems to work.
123 2012-03-04 Murray Cumming <murrayc@murrayc.com>
125 Actually show some data with JasperReports.
127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
128 getReportHTML(): Move most code into a ReportGenerator class.
129 * src/main/java/org/glom/web/server/ReportGenerator.java:
130 Recurse into sub-groups, adding fields to the JasperDesign's details
131 band. Note that we must set an arbitrary width and height, or it just
132 will not show any data.
134 2012-03-04 Murray Cumming <murrayc@murrayc.com>
136 Reports Chooser: Show the titles, not the names.
138 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
139 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
140 and the names as the values.
141 * src/main/java/org/glom/web/server/ConfiguredDocument.java
142 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
143 group now that we provide the report name, so it should always
146 2012-03-04 Murray Cumming <murrayc@murrayc.com>
148 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
150 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
151 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
152 an empty quickfind string. I also corrected libglom to create only
153 empty where clauses for empty quickfind strings, but this avoids the
156 2012-02-24 Ben Konrath <ben@bagu.org>
158 Improve the tabs in the Notebook widget.
162 2012-02-15 Murray Cumming <murrayc@murrayc.com>
164 Depend on jasperreports.
166 * pom.xml: Add the dependency. My plan is to use this on the
169 2012-01-31 Murray Cumming <murrayc@murrayc.com>
171 Implement navigation to report places.
173 * src/main/java/org/glom/web/client/activity/ReportActivity.java
174 start(): Do not bother to handle all events here.
175 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
176 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
177 Added getSelectedReport().
178 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
179 .java: start(): When handling a change to the reports chooser,
180 call getSelectedReport() and goTo() its ReportPlace.
181 * src/main/java/org/glom/web/client/ui/ReportView.java
182 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
183 Added setReportHTML() which puts the html in a gwt HTML widget.
184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
185 getReportHTML(): Return "TODO" just to show that this works.
187 2012-01-31 Murray Cumming <murrayc@murrayc.com>
189 Make ReportPlace usable.
191 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
193 * src/main/java/org/glom/web/client/place/ReportPlace.java:
194 Correct the @prefix annotation.
196 2012-01-31 Murray Cumming <murrayc@murrayc.com>
198 OnlineGlomService: Return report HTML rather than the LayoutGroup.
200 * src/main/java/org/glom/web/client/OnlineGlomService.java:
201 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
203 Change getReportLayout() to getReportHMTL() because we will not need to
204 parse or render the report layout on the client side.
205 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
206 getReportLayout(): Return the libglom LayoutGroup type because we will
207 not need to convert to a shared type, because this will not be used on
209 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
212 Note that there is still no implementation for this.
214 2012-01-30 Murray Cumming <murrayc@murrayc.com>
216 Translations: Try to translate the strings.
218 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
219 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
220 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
221 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
222 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
223 Take the Open translation from GTK+'s .po files.
224 Take the Details translation from Glom's po files.
225 I have added the other strings to Glom so we can get translations that way:
226 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
228 2012-01-27 Murray Cumming <murrayc@murrayc.com>
230 Add a (empty) Report Place, View, and Activity.
232 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
234 * src/main/java/org/glom/web/client/place/HasTablePlace.java
235 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
236 this into a superclass:
237 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
238 and also use it as the base of this new ReportPlace:
239 * src/main/java/org/glom/web/client/place/ReportPlace.java
241 * src/main/java/org/glom/web/client/ui/ReportView.java
242 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
243 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
244 Add these, containing mostly boiler-plate for now.
246 * src/main/java/org/glom/web/client/OnlineGlomService.java
247 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
248 * src/main/java/org/glom/web/server/ConfiguredDocument.java
249 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
250 Add API to get the LayoutGroup for the report.
252 2012-01-27 Murray Cumming <murrayc@murrayc.com>
254 TableSelectionViewImpl: Put the search label and entry in a div.
256 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
257 Put the search widgets in a FlowTable so that the CSS can be used to
258 style them while keeping them together.
259 * src/main/webapp/style.css: Mention the new div.
261 2012-01-27 Murray Cumming <murrayc@murrayc.com>
263 Translate more strings in more locales.
265 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
266 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
267 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
268 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
269 Translate the "Details" and "Open" string too.
271 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
272 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
273 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
274 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
275 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
276 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
277 Add these new locales as placeholders though they currently contain English.
279 2012-01-27 Murray Cumming <murrayc@murrayc.com>
281 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
283 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
284 Check the ConfiguredDocument* for null before using it.
286 2012-01-26 Murray Cumming <murrayc@murrayc.com>
288 Tell Eclipse about the generated java files.
290 * .classpath: This lets it find OnlineGlomConstants.java.
291 It would be nice if Eclipse just used the maven build files.
293 2012-01-26 Murray Cumming <murrayc@murrayc.com>
295 Prevent a crash when no locale is specified in the URL.
297 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
298 Avoid returning a null string, obtained from
299 Window.Location.getParameter(). This caused a crash when it was
300 later passed to libglom's API.
301 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
302 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
303 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
304 guard against future null strings.
306 2012-01-26 Murray Cumming <murrayc@murrayc.com>
308 Use the ?locale= query param instead of the &lang= token param.
310 * src/main/java/org/glom/web/client/place/ListPlace.java
311 * src/main/java/org/glom/web/client/place/DetailsPlace.java
312 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
313 Remove the lang token key and value.
315 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
316 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
317 When the user selects a different locale from the chooser, use
318 Window.Location.assign() to change the URL, which then causes a reload.
320 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
321 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
322 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
323 * src/main/java/org/glom/web/client/activity/ListActivity.java
324 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
325 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
326 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
327 * src/main/java/org/glom/web/client/ui/ListView.java:
328 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
330 Remove localeID member variables and method/constructor parameters, instead
331 using Utils.getCurrentLocaleID() when we need a localID to pass to
334 2012-01-26 Murray Cumming <murrayc@murrayc.com>
336 Internationalize the UI strings.
338 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
339 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
340 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
341 because it is unused. Messages are apparently strings that can have
342 parameters, but we do not need that yet, so Contants will be enough for now.
343 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
344 to say that we support the en and de locales.
345 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
346 The original English strings.
347 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
348 Some German translations of the English strings.
349 The i18n goal then uses the .properties file to generate an
350 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
351 returns an implementation that returns the translated strings.
352 The documentation suggests putting these in src/java/*/client/, but it seems
353 best to put it in src/resources/*/client/.
354 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
355 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
356 instead of hard-coding them.
357 Note that we cannot import OnlineGlomConstants because it does not exist yet,
358 but that does not seem to stop the build, though it confuses Eclipse.
360 You can see the translated string by adding ?locale=de to the URL, like so:
361 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
363 2012-01-24 Murray Cumming <murrayc@murrayc.com>
365 Improve null/empty String checks.
367 * pom.xml: Add a dependency on commons-lang, to use
368 org.apache.commons.lang.StringUtils.
369 * src/main/java/org/glom/web/server/ConfiguredDocument.java
370 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
371 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
372 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
373 Use StringUtils.isEmpty().
375 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
376 StringUtils class with a static isEmpty() function because we
377 cannot use org.apache.commons.lang.StringUtils in client-side
378 GWT code because it (apparently) cannot be compiled to javascript.
379 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
380 * src/main/java/org/glom/web/client/activity/ListActivity.java
381 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
382 * src/main/java/org/glom/web/client/place/DetailsPlace.java
383 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
384 * src/main/java/org/glom/web/client/place/ListPlace.java
385 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
386 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
387 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
388 * src/main/java/org/glom/web/client/ui/details/Group.java
389 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
390 our StringUtils.isEmpty() function.
392 2012-01-24 Murray Cumming <murrayc@murrayc.com>
394 Update to the latest java-libglom API.
396 * pom.xml: Require java-libglom 1.21.4.
397 * src/main/java/org/glom/web/server/ConfiguredDocument.java
398 getDocumentInfo(), getListViewLayoutGroup():
399 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
401 * src/main/java/org/glom/web/server/database/DBAccess.java
402 getFieldsToShowForSQLQueryAddGroup(),
403 getPrimaryKeyLayoutItemField(): Replace get_database_title()
404 with either get_database_title_original() or
405 get_database_title(localeID).
407 2012-01-24 Murray Cumming <murrayc@murrayc.com>
409 ConfiguredDocument: Avoid a null pointer exception.
411 * src/main/java/org/glom/web/server/ConfiguredDocument.java
412 Initialize localeID to "" to avoid returning a null String which
413 causes a crash in java-libglom's swing-generated code.
415 2012-01-23 Murray Cumming <murrayc@murrayc.com>
417 Some simple renaming.
419 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
420 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
421 for localeChooser. This seems more appropriate and is less ambiguous
422 particularly in the .css file.
424 2012-01-23 Murray Cumming <murrayc@murrayc.com>
426 ConfiguredDocument: Rename the localedID private member variable.
428 2012-01-23 Murray Cumming <murrayc@murrayc.com>
430 Adapt to the latest java-libglom API from git master.
432 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
433 libglom now uses only Vector instead of List, which uses add() instead of
436 2012-01-23 Murray Cumming <murrayc@murrayc.com>
438 Add and fill a Reports drop-down list box.
440 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
442 * src/main/java/org/glom/web/client/OnlineGlomService.java:
443 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
444 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
445 Added getReports(document, table, localeID), calling
446 ConfiguredDocument.getReports().
447 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
448 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
449 Added setReportsList() and a list widget.
450 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
451 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
453 2012-01-22 Murray Cumming <murrayc@murrayc.com>
455 ConfiguredDocument: Rename the localedID private member variable.
457 2012-01-20 Murray Cumming <murrayc@murrayc.com>
459 Build a source tarball with mvn assembly:single
461 * assembly.xml: Add this file.
462 * pom.xml: Use the maven-assembly-plugin and tell it to use
463 our assembly.xml file.
465 2012-01-19 Murray Cumming <murrayc@murrayc.com>
467 OnlineGlomServiceImpl: Get .glom files recursively.
469 * pom.xml: Depend on commons-io from org.apache.commons.
470 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
471 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
472 files recursively, and with the easier filter for the extension.
473 Use org.apache.commons.io.FilenameUtils.removeExtension() to
474 simplify that code too.
476 2012-01-19 Murray Cumming <murrayc@murrayc.com>
478 README: Mention that you must install java-libglom packages separately.
480 But then it works, because java-libglom is now in the central maven
483 2012-01-18 Murray Cumming <murrayc@murrayc.com>
485 locales drop-down: Show the correct selected locale when the URL changes.
487 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
488 .java: setPlace(): Move some code into fillView().
490 2012-01-18 Murray Cumming <murrayc@murrayc.com>
492 locales drop-down: Do not lose the primary key.
494 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
495 start(): onLocaleChange(): Pass the current primary key value,
496 instead of an empty value.
498 2012-01-18 Murray Cumming <murrayc@murrayc.com>
500 locales drop-down: Do not lose the drop-down selection.
502 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
503 .java (TableSelectionActivity.fillView): Set the selected locale
504 after changing the drop-down items (though we do not really need
505 to change them just because the locale changes.)
507 2012-01-18 Murray Cumming <murrayc@murrayc.com>
509 locales drop-down: Change the tables list when this changes.
511 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
512 .java: TableSelectionActivity.start(): Move the async table titles
513 retrieval into a private fillView() method and also call this when
514 the chosen locale changes.
515 Note that the document title is not actually translatable yet, but
516 that is a problem that I should fix soon in libglom.
518 2012-01-18 Murray Cumming <murrayc@murrayc.com>
520 Improve the placement of the locales drop-down.
522 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
523 Put the title and locales drop-down in a div (gwt.FlowTable).
524 * src/main/webapp/style.css: Add magic css properties to make this work.
525 Also remove the left margin from the title so that it lines up with the
528 2012-01-18 Murray Cumming <murrayc@murrayc.com>
530 locales selector: Show human-readable locale titles.
532 * src/main/java/org/glom/web/server/ConfiguredDocument.java
533 getDocumentInfo(): Use java.util.Locale to show a real title of
534 each locale, in the locale's own language.
536 2012-01-17 Murray Cumming <murrayc@murrayc.com>
538 Add a language/locale selector drop-down.
540 * src/main/java/org/glom/web/shared/DocumentInfo.java:
541 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
542 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
543 getDocumentInfo(): Store the available Locales in the DocumentInfo.
544 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
545 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
546 Add a ListBox to show the available locales. Add getLocaleSelector(),
547 setLocaleList(), getSelectedLocale(), setSelectedLocale().
548 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
549 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
550 java: Add these classes.
551 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
552 start(): Fill the locales ListBox. Handle its change event, firing a
554 setPlace(): Show the selected locale as specified by the URL token.
555 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
556 * src/main/java/org/glom/web/client/activity/ListActivity.java:
557 Handle LocaleChangeEvent, going to a new *Place with that locale.
559 The placement of the ListBox is not pretty, and it currently uses the ID
560 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
564 2012-01-17 Murray Cumming <murrayc@murrayc.com>
566 Search box: Show the search text from the URL token.
568 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
569 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
570 Add setQuickFindText().
571 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
572 .java: setPlace(): Store the queryText if the place is a ListPlace,
573 and call TableSelectionView.setQuickFindText().
575 2012-01-17 Murray Cumming <murrayc@murrayc.com>
577 Allow use of translations via, for instance, &lang=de in the URL.
579 * pom.xml: Use the unstable java-libglom 1.21 version.
581 * src/main/java/org/glom/web/client/OnlineGlomService.java:
582 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
583 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
584 init(): Instead of calling TranslatableItem.set_current_locale()
585 (now removed), call ConfiguredDocument.setDefaultLocaleID().
586 However, this is only for default locales, which are not needed to
587 change the locale in the URL.
588 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
589 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
590 getSortedRelatedListData(): Add a localeID parameter, so we can get the
591 layout for a particular locale.
592 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
593 Add get/setDefaultLocaleID().
594 getDocumentInfo(), getListViewData(), getRelatedListData(),
595 getDetailsLayoutGroup(), getListViewLayoutGroup(),
596 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
597 localeID parameter, so we can get the layout for a particular locale.
599 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
600 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
601 * src/main/java/org/glom/web/client/place/ListPlace.java:
602 Parse and construct a lang parameter too.
604 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
605 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
606 passed to subsequent methods and constructors.
607 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
608 * src/main/java/org/glom/web/client/activity/ListActivity.java:
609 Store the localeID from the *Place and pass it to other constructors
610 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
612 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
613 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
614 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
615 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
616 * src/main/java/org/glom/web/client/ui/ListView.java:
617 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
618 Take localeID parameters and pass them to subsequent constructors and
619 methods, so that the layout is always retrieved for that locale.
621 This is rather repetitive.
623 Note that "" means the original (default) locale of the Glom document,
624 which is usually English.
626 2012-01-17 Murray Cumming <murrayc@murrayc.com>
628 Documents: Remove final keyword to fix startup configuration.
630 * src/main/java/org/glom/web/shared/Documents.java: Remove the
631 final keywords on the private member variables because that breaks
632 the startup, apparently (there are warnings) because it stops them
633 from being serialized. I added these in the previous commit.
635 2012-01-13 Murray Cumming <murrayc@murrayc.com>
637 Documents: Add some final keywords.
639 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
642 2012-01-13 Murray Cumming <murrayc@murrayc.com>
644 OnlineGlomServiceImpl: Add to overview comments.
646 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
647 Note that this is where all the document are loaded. They are not
648 loaded freshly for each page.
650 2012-01-12 Murray Cumming <murrayc@murrayc.com>
654 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
655 Add a TextBox for the text of a quick find.
656 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
658 setBackLink(): Add a String quickFind parameter.
659 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
660 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
661 to the base interface, because that is how TableSelectionViewImpl is used.
662 * src/main/webapp/style.css: Add style for the search box and its label.
664 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
665 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
666 Add these files, based on the existing TableChangeEvent and
667 TableChangeEventHandlers.
668 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
669 start(): Handle QuickFindChangeEvent, passing its quickFind text to
670 a ListPlace() that the user should be taken to.
671 * src/main/java/org/glom/web/client/activity/ListActivity.java
672 start(): Handle it here too and adapt the TableChangeEvent handler to
673 pass the extra "" quickFind parameter to ListPlace.
674 * src/main/java/org/glom/web/client/place/ListPlace.java:
675 Constructor: Take an extra String quickFind parameter and store it,
676 returning it from a new getQuickFind() method.
677 getToken(): Put the quickFind text in the URL token.
678 getPlace(): Parse the quickFind text from the URL token.
679 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
680 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
681 ListPlace constructor.
682 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
683 .java: start(): Add a Change handler for the TableSelectionView's
684 TextBox (via its base HasChangeHandlers interface), firing the new
685 QuickFindChangeEvent.
686 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
687 pass the extra "" quickFind parameter.
689 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
690 setCellTable(): Add a String quickFind parameter and pass it to
691 the ListViewTable() constructor.
692 * src/main/java/org/glom/web/client/ui/ListView.java: Change
693 setCellTable() in the base interface, because that is how ListViewImpl
696 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
697 Add a String quickFind member variable.
698 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
699 Constructor: Add a String quickFind parameter, storing it in the
700 base ListTable's member variable.
701 onRangeChanged(): Pass quickFind to the
702 OnlineGlomServiceAsync.getSortedListViewData() and
703 OnlineGlomServiceAsync.getListViewData() methods.
705 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
706 getListViewData(), getSortedListViewData(): Add a String quickFind
707 parameter, passing it to ConfiguredDocument.getListViewData().
708 * src/main/java/org/glom/web/client/OnlineGlomService.java:
709 Change getListViewData(), getSortedListViewData() in the base interface,
710 because that is how OnlineGlomServiceImpl is used, via this:
711 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
712 Change getListViewData(), getSortedListViewData() here too.
713 This class can apparently be used to asynchronously call methods on
714 OnlineGlomService, and GWT seems to implement that after recognizing
715 just the *Async name convention and the extra AsyncCallback parameters.
717 * src/main/java/org/glom/web/server/ConfiguredDocument.java
718 getListViewData(): Add a String quickFind parameter, and pass it to
719 ListViewDBAccess.getData().
720 * src/main/java/org/glom/web/server/database/ListDBAccess.java
721 getListData(): Add a String quickFind parameter and pass it to
723 getSelectQuery(): Add a String quickFind parameter.
724 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
725 getSelectQuery(): Add a String quickFind parameter and use it with
726 Glom.get_find_where_clause_quick() to pass a where_clause to
727 Glom.build_sql_select_with_where_clause(), to actually filter the
729 getData(): Add a String quickFind parameter, passing it to getListData().
730 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
731 va: getData(): Pass an empty string to getListData() for the
734 2012-01-12 Murray Cumming <murrayc@murrayc.com>
736 ListTable: Minor change.
738 * src/main/java/org/glom/web/client/ui/list/ListTable.java
739 createCellTable(): Make this protected instead of public.
741 2012-01-12 Murray Cumming <murrayc@murrayc.com>
743 Many files: Use final for the parameters and use the @override attribute.
745 2012-01-22 Ben Konrath <ben@bagu.org>
747 Add anchor links for single line text that starts with http, ftp and www.
751 2012-01-22 Ben Konrath <ben@bagu.org>
753 Add ellipsis to single line text in details view.
757 2012-01-04 Murray Cumming <murrayc@murrayc.com>
759 Remove all javadoc author tags.
761 Because they are awkward and meaningless when many people touch
763 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
765 2012-01-04 Murray Cumming <murrayc@murrayc.com>
767 Revert the COPYING.LESSER to COPYING rename.
769 Apparently both should be there if it is LGPL.
771 2012-01-03 Murray Cumming <murrayc@murrayc.com>
773 *View: Remove unused imports.
775 * src/main/java/org/glom/web/client/ui/DetailsView.java:
776 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
777 * src/main/java/org/glom/web/client/ui/ListView.java:
778 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
779 Remove unused imports, as suggested by Eclipse.
781 2012-01-02 Murray Cumming <murrayc@murrayc.com>
783 Move the *View::Presenter types, and some API into one base View.
785 * src/main/java/org/glom/web/client/ui/DetailsView.java:
786 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
787 * src/main/java/org/glom/web/client/ui/ListView.java:
788 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
789 Presenter, setPresenter() and clear() into a shared base interface,
790 to avoid the unnecessary duplicate Presenter types and to more clearly
791 show how the *Views share the same structure, even if they are not
792 used polymorphically.
794 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
795 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
797 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
798 * src/main/java/org/glom/web/client/activity/ListActivity.java:
799 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
801 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
804 Feel free to revert this if there is a good reason for the duplicate
807 2012-01-02 Murray Cumming <murrayc@murrayc.com>
809 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
811 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
812 a class member instead of a local variable in the method.
813 This lets us use it to get the view instances, for use in tests.
814 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
815 beforeOnlineGlom(): Test some more details of the initial view.
816 Again, this is not very useful.
818 To really test gwt-glom we will need to start a local postgresql
819 instance with local data, like the Glom tests in C++.
821 2012-01-02 Murray Cumming <murrayc@murrayc.com>
823 pom.xml: Mention the LGPL license.
825 * pom.xml: Add a licenses section.
826 * COPYING.LESSER: Move this to COPYING, which
827 previously contained the GPL. But gwt-glom is all LGPL.
829 2012-01-02 Murray Cumming <murrayc@murrayc.com>
831 Add project information to README and pom.xml.
833 * README: Add a brief description and mention some mvn
835 * pom.xml: This extra information shows up in mvn site
838 2011-01-02 Murray Cumming <murrayc@murrayc.com>
840 Use the latest java-libglom version.
842 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
844 2012-01-01 Murray Cumming <murrayc@murrayc.com>
846 GwtTestOnlineGlom: Test a little more.
848 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
849 protected rather than private, as suggested by the gwt-test-utils
851 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
852 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
853 Test the initial visibility of the panels.
855 However, this is not a very useful test.
856 And I wonder how we should generally test using this idea for an
857 activity/places app like ours where the real changes happen implicitly
858 based on the history token/URL.
860 2012-01-01 Murray Cumming <murrayc@murrayc.com>
862 Slight modification to *Mapper comments.
864 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
866 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
868 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
870 Remove comments mentioning GIN because they are just copied from
871 the example code and are apparently not helpful:
872 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
873 Also change the mention of a class that is only in the example code.
875 2012-01-01 Murray Cumming <murrayc@murrayc.com>
877 GwtTestOnlineGlom test: Minor changes.
879 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
880 Avoid the long qualified class name and modify the comment
881 because it is now obvious to me that the mocked class is the only
882 custom one created via GWT.create().
884 2012-01-01 Murray Cumming <murrayc@murrayc.com>
886 Tests: Added the beginnings of a test using gwt-test-utils.
888 * pom.xml: Add dependencies on gwt-test-utils and easymock.
889 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
890 which tells gwt-test-utils what class will be tested.
891 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
892 Add a simple (but empty) test case. One class, used by the OnlineGlom
893 class, is mocked so that it can be created. However, I am not sure
894 why only this class needs to be mocked.
896 Note that mockito seems more popular, and clearer, than easymock,
897 but I have not got that working yet. It might be a matter of the
900 This test is run during mvn integration-test.
902 2011-12-31 Murray Cumming <murrayc@murrayc.com>
904 Tests: Use junit4-style syntax instead of junit3-style.
906 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
907 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
908 * src/test/java/org/glom/web/shared/DataItemTest.java:
909 Use the @Test annotation rather than relying on the test*() prefix.
910 Also no longer implement TestCase, to avoid triggering support for
911 the junit3-way, which stops the annotations from working.
912 Change the imports from import junit.framework.* to
913 import org.junit.*, which is apparently the new way.
915 2011-12-31 Murray Cumming <murrayc@murrayc.com>
917 Added a test for ListPlace token parsing and creation.
919 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
920 This is much the same as DetailsPlaceTest.
922 I wonder how we could test the other parts of the *Place API.
924 2011-12-30 Murray Cumming <murrayc@murrayc.com>
926 DetailsPlace test: Also test getToken() and recreation via getPlace().
928 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
929 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
930 recreate it, testing the recreated DetailsPlace for the same parameter
933 2011-12-30 Murray Cumming <murrayc@murrayc.com>
935 Use the surefire-report plugin.
937 * pom.xml: This generates a HTML report about the tests in
938 target/site/surefire-report.html
939 when you do mvn surefire-report:report. It seems to be popular/normal.
941 2011-12-30 Murray Cumming <murrayc@murrayc.com>
943 Added a test for DetailsPlace.
945 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
946 Test the getPlace() token parsing.
948 2011-12-30 Murray Cumming <murrayc@murrayc.com>
950 Added a first unit test.
952 * pom.xml: Add a test goal, and a dependency on junit in that scope.
953 * src/test/java/org/glom/web/shared/DataItemTest.java:
954 This is a silly test but it is just to get things started. Note that
955 maven/junit finds the test because it looks in src/test by default.
957 2011-12-22 Ben Konrath <ben@bagu.org>
959 Change charsetName to "UTF-8" when replacing line breaks.
961 JavaScript requires the charsetName to be "UTF-8". CharsetName values
962 that work in Java (such as "UTF8") will not work when compiled to
965 This fixes a problem with multi-line details view fields that have hard
966 line breaks. The "License Text" field on this page demonstrates the
969 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
971 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
973 2011-12-22 Ben Konrath <ben@bagu.org>
975 Fix another bug with related list navigation.
977 I've tested all the navigation buttons in all of the related lists
978 so things should be good now.
980 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
982 2011-12-22 Ben Konrath <ben@bagu.org>
984 Fix a crasher when refreshing the list view with the default table.
986 This crash will also happen when loading the list view with the default
987 table from a link or bookmark.
989 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
990 to the main document selection page when the document id hasn't been
992 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
993 the main document selection page when the document id hasn't been
995 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
996 values for the details place when the document id hasn't been set.
997 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
998 values for the list place when the document id hasn't been set.
1000 2011-12-21 Ben Konrath <ben@bagu.org>
1002 Protect against NPE when glom.document.locale is not in config.
1004 This patch protects against an NPE when glom.document.locale is not in
1005 the config file. This NPE will also happen if glom.document.locale is
1008 The patch also updates the error message to display the class name when
1009 the getMessage() returns null. This was happening when the NPE was
1010 thrown and I had "Configuration Error: null". If an NPE is encountered
1011 with this patch, "Configuration Error: NullPointerException " will be
1014 This commit closes this bug:
1016 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1018 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1020 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1022 Rename onlineglom.properties to onlineglom.properties.sample.
1024 * src/main/resources/onlineglom.properties: Rename to:
1025 * src/main/resources/onlineglom.properties.sample:
1026 * src/main/resources/README: And add this file explaining that people
1027 should rename it back when deploying.
1029 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1031 Allow choosing the translation in the .properties file.
1033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1034 init(): Read a glom.document.locale value from the configuration file
1035 and call Glom's TransatableItem::set_current_locale() method.
1036 * src/main/resources/onlineglom.properties: Add a commented-out
1037 example of this new setting.
1039 It would be better to add &lang=de_DE to the URL, but the current
1040 libglom API does not allow us to do this easily. I am working on that.
1042 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1044 Avoid a crash in parsing of token parameters.
1046 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1047 ava: getTokenParams(): Do not crash if a parameter has a key but no
1048 value, and ignore parameters with neither.
1050 2011-12-17 Murray Cumming <murrayc@murayc.com>
1052 History token building/handling: Improve use of token parameters.
1054 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1055 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1056 and buildParamsToken(HashMap), for use by derived classes.
1057 Make the separator private because it is no longer be needed.
1058 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1059 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1060 instead of manual string concatenation.
1061 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1062 of hardcoded indices and awkward splitting code.
1063 * src/main/java/org/glom/web/client/place/ListPlace.java
1064 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1065 instead of manual string concatenation.
1066 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1067 of hardcoded indices and awkward splitting code.
1068 This should fix bug #666420
1070 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1072 Fix a Navgiation->Navigation typo in the code.
1074 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1075 Rename processNavgiation() to processNavigation().
1077 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1079 Fix a seperator->separator typo in the code.
1081 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1082 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1083 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1086 2011-12-15 Ben Konrath <ben@bagu.org>
1088 Cleanup some comments.
1090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1092 2011-12-14 Ben Konrath <ben@bagu.org>
1094 Replace \n with <br/> for multiline text in the details view.
1096 Vertical scrollbars are added when needed as well.
1098 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1100 2011-12-14 Ben Konrath <ben@bagu.org>
1102 Specify the font for document selection links.
1104 * src/main/webapp/style.css:
1106 2011-12-14 Ben Konrath <ben@bagu.org>
1108 Fix bouncy CellTable while paging.
1110 This doesn't currently work with related list tables in unselected
1113 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1115 2011-12-14 Ben Konrath <ben@bagu.org>
1117 Revamp the appearance of the document selection page.
1119 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1120 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1121 * src/main/webapp/style.css:
1123 2011-12-13 Ben Konrath <ben@bagu.org>
1125 Set navigation button column to the smallest size possible.
1127 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1129 2011-12-13 Ben Konrath <ben@bagu.org>
1131 Change OpenButton nomenclature to NavigationButton.
1133 Using NavigtionButton makes things more generic. Classes, methods and
1134 variables have been changed.
1136 This is a rename-only refactor.
1138 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1139 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1140 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1141 Renamed from OpenButtonCell.
1142 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1143 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1144 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1146 2011-12-12 Ben Konrath <ben@bagu.org>
1148 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1150 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1151 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1152 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1153 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1155 2011-12-12 Ben Konrath <ben@bagu.org>
1157 Update variable names and comments.
1159 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1160 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1162 2011-12-12 Ben Konrath <ben@bagu.org>
1164 Properly initialize numNonEmptyRows variable to zero.
1166 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1167 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1169 2011-12-05 Ben Konrath <ben@bagu.org>
1171 Add latest mockup with HTML tables.
1173 Features of this mockup:
1175 -> HTML table for flowtable
1176 -> HTML table for flowtable column
1177 -> Example of how related lists would look
1178 -> Not using text entries for data items
1180 The current version of Online Glom doesn't use HTML tables for the
1183 This mockup has been sent to the glom-devel mailing list but it's good
1184 to have it here as well.
1186 * mockups/details-view-html-tables.html:
1188 2011-12-05 Ben Konrath <ben@bagu.org>
1190 Remove unnecessary getPrimaryKeyField() method.
1192 getPrimaryKeyFieldForTable(String) has been renamed to
1193 getPrimaryKeyField(String).
1195 * src/main/java/org/glom/web/server/database/DBAccess.java:
1196 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1197 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1199 2011-12-05 Ben Konrath <ben@bagu.org>
1201 Add string representation of TypedDataItem value to conversion error message.
1203 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1204 message was extracted into its own method to avoid duplication.
1206 2011-12-05 Ben Konrath <ben@bagu.org>
1208 Add type checking to navigation primary key value creation.
1210 Create navigation primary key only if the expected type from the Glom
1211 document matches the type returned by the SQL query.
1213 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1215 2011-12-05 Ben Konrath <ben@bagu.org>
1217 Rename a couple of variables in RelatedListNavigation.
1219 This is a rename-only refactor.
1221 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1223 2011-12-05 Ben Konrath <ben@bagu.org>
1225 Move getListLayoutGroup() into getListViewLayoutGroup().
1227 This removes getListLayoutGroup(). It was only being called by
1228 getListViewLayoutGroup().
1230 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1232 2011-12-05 Ben Konrath <ben@bagu.org>
1234 Remove check for LayoutItem_Portal in list table method.
1236 This check is no longer necessary because the method isn't being used
1237 to create the LayoutItemPortal DTO.
1239 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1241 2011-12-05 Ben Konrath <ben@bagu.org>
1243 Properly support related list navigation.
1245 Navigation from the "Repository Analyzer -> Package Scans ->
1246 Dependencies" related table wasn't working because the primary key for
1247 related tables wasn't being set properly. This commit fixes the
1250 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1251 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1252 doesn't set the primary key properly for related list tables.
1253 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1254 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1255 useful for getting the primary key for list view tables and for related
1257 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1258 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1259 Move code to set the primary key for the table from the abstract
1260 ListDBAccess class to ListViewDBAccess as it's only correct for list
1262 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1263 Properly add primary key to related list tables.
1265 2011-12-02 Ben Konrath <ben@bagu.org>
1267 Properly set the horizontal alignment of fields.
1269 This fix is for both the list tables and the details view.
1271 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1272 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1273 to set the horizontal alignment of fields.
1275 2011-12-02 Ben Konrath <ben@bagu.org>
1277 Display currency codes in the details view.
1279 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1281 2011-12-02 Ben Konrath <ben@bagu.org>
1283 Avoid duplicate JNI call.
1285 JNI is not as efficient as pure Java and this is an easy (and small)
1288 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1289 Use previously retrieved value for whereClauseToTableName instead of
1292 2011-12-02 Ben Konrath <ben@bagu.org>
1294 Rename a couple of variables in RelatedListNavigation.
1296 This is a rename-only refactor.
1298 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1300 2011-12-02 Ben Konrath <ben@bagu.org>
1302 Indicate clearly that a mismatched primary key type is a bug.
1304 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1305 warning to error. Add 'This is a bug.' to message.
1307 2011-12-02 Ben Konrath <ben@bagu.org>
1309 Update / fix some comments.
1311 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1313 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1315 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1316 Fix comments. Add some TODOs.
1318 2011-12-02 Ben Konrath <ben@bagu.org>
1320 Enable navigation to details view with string primary key from related list.
1322 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1323 Create a text primary key value when return type of result is
1324 java.sql.Types.VARCHAR.
1326 2011-12-02 Ben Konrath <ben@bagu.org>
1328 Use checkboxes for booleans in the details view.
1330 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1332 2011-12-01 Ben Konrath <ben@bagu.org>
1334 Improve performance of related list height calculation.
1336 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1337 Put code to calculate the expected height in a static initializer so
1338 that that it's only called once.
1340 2011-12-01 Ben Konrath <ben@bagu.org>
1342 Show related list tables in notebooks (again).
1344 Calculate the height of the related list tables so the Notebook can be
1345 set the correct height. The height of the related list table is also needed by
1346 FlowTable to be able decide how to create the layout.
1348 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1349 and set the Portal height based on the height of the related list
1350 table and the Portal container.
1351 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1352 Add method to calculate the height of the related list tables.
1353 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1354 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1355 calculate the height of the Pager widget.
1357 2011-12-01 Ben Konrath <ben@bagu.org>
1359 Use CellTable API for table property instead of setting style on Element.
1361 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1363 2011-12-01 Ben Konrath <ben@bagu.org>
1365 Make ListViewTable and RelatedListTable a consistent height.
1367 The tables are now a consistent height regardless of the contents of
1368 the table. A hidden button is added to empty rows to ensure that the
1369 height of these rows will match the height of rows with data.
1371 A navigation button column is now added to every table. The width of
1372 the navigation column is set to 0px when a RelatedListTable shouldn't
1373 have navigation buttons. This maintains the a consistent row height in
1374 tables that don't show the navigation buttons.
1376 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1377 navigation column when not needed.
1378 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1379 arguments for navigation button to constructor of ListViewTable.
1380 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1381 hidden button for empty data rows.
1382 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1383 arguments for navigation button to constructor.
1384 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1385 create navigation buttons. Add hideNavigationButtons() method.
1386 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1387 arguments for navigation button to constructor.
1389 2011-12-01 Ben Konrath <ben@bagu.org>
1391 Use 'visibility: hidden' in Utils.getWidgetHeight().
1393 This is better choice because hidden elements are invisible, don't
1394 respond to events and are not part of the tab order. They will,
1395 however, take up space which is required to be able to calculate the
1396 height of the widget.
1398 * src/main/java/org/glom/web/client/Utils.java:
1400 2011-12-01 Ben Konrath <ben@bagu.org>
1402 Use Utils.getWidgetHeight() in FlowTable.
1404 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1406 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1408 2011-12-01 Ben Konrath <ben@bagu.org>
1410 Put the details css class name on the correct table column.
1412 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1414 2011-11-30 Ben Konrath <ben@bagu.org>
1416 Update for java-libglom API change.
1418 The getters and setters on FieldFormatting and NumericFormat were
1419 changed to remove the 'M'.
1421 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1423 2011-11-29 Ben Konrath <ben@bagu.org>
1425 Only allow RelatedListTables in Portals.
1427 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1429 2011-11-29 Ben Konrath <ben@bagu.org>
1431 Only create a contents panel for Portals when title is being set.
1433 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1435 2011-11-29 Ben Konrath <ben@bagu.org>
1437 Set TabLayoutPanel height based on calculated height its widgets.
1439 This is a potential fix for this bug:
1441 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1443 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1445 2011-11-29 Ben Konrath <ben@bagu.org>
1447 Align details field labels and data with the Open buttons.
1449 * src/main/webapp/style.css:
1451 2011-11-29 Ben Konrath <ben@bagu.org>
1453 Remove unnecessary <div> in the Notebook widget.
1455 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1456 method to get container FlowPanel (<div>).
1457 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1458 initWidget() method directly on the TabLayoutPanel widget instead of
1459 Group's container widget.
1461 2011-11-29 Ben Konrath <ben@bagu.org>
1463 Don't add group titles for Portals in Notebooks.
1465 This reverts the previous patch and fixes a bug I introduced with
1466 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1468 * src/main/java/org/glom/web/client/ui/details/Group.java:
1469 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1471 2011-11-28 Ben Konrath <ben@bagu.org>
1473 Remove unused boolean argument in Portal constructor.
1475 Just a code cleanup.
1477 * src/main/java/org/glom/web/client/ui/details/Group.java:
1478 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1480 2011-11-28 Ben Konrath <ben@bagu.org>
1482 Remove hack for glom 1.18 style glom files.
1484 * src/main/java/org/glom/web/client/ui/details/Group.java:
1485 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1486 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1488 2011-11-28 Ben Konrath <ben@bagu.org>
1490 Use Gda Value version of primary key to log result too large error.
1492 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1494 2011-11-28 Ben Konrath <ben@bagu.org>
1496 Don't use TypedDataItem.getText() for Unknown types from the URL.
1498 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1499 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1500 instead of getText().
1501 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1502 String field and getUnknown() method.
1504 2011-11-28 Ben Konrath <ben@bagu.org>
1506 Log an error message when the java-libglom .so is not present.
1508 The error message was being set in the exception but not logged.
1510 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1512 2011-11-28 Ben Konrath <ben@bagu.org>
1514 Ignore LayoutItem_CalendarPortals.
1516 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1517 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1519 2011-11-28 Ben Konrath <ben@bagu.org>
1521 Extract method for creating the LayoutItemPortal DTO.
1523 Just breaking the code up into smaller chunks.
1525 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1527 2011-11-28 Ben Konrath <ben@bagu.org>
1531 This should have been added with the refactor. Oops!
1533 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1535 2011-11-28 Ben Konrath <ben@bagu.org>
1537 Create primary key value from URL string using type from Glom document.
1539 See this bug, comments 19 - 25:
1541 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1543 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1544 create a TypeDataItem for the primary key here when loading from a
1545 URL. Show the same string for the primary key value as was received
1546 from the URL string (when loading from a URL).
1547 * src/main/java/org/glom/web/server/Utils.java: Update method for
1548 creating the Gda Value from the TypeDataItem to properly deal with
1549 creating a Gda Value based on the Glom document type for the primary
1550 key value string when loading from a URL.
1551 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1552 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1553 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1554 Update for changed method name.
1556 2011-11-27 Ben Konrath <ben@bagu.org>
1558 Rename PrimaryKeyItem to TypedDataItem.
1560 The name PrimaryKeyItem suggests what the class should be used for.
1561 TypedDataItem is a neutral name that describes the class better.
1563 This is a rename-only refactor.
1565 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1566 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1567 * src/main/java/org/glom/web/client/Utils.java:
1568 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1569 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1570 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1571 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1572 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1573 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1574 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1575 * src/main/java/org/glom/web/server/Utils.java:
1576 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1577 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1578 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1579 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1581 2011-11-25 Ben Konrath <ben@bagu.org>
1583 Improve Gda Value conversion from PrimaryKeyItem.
1585 The value from the PrimaryKeyItem is only used if its type match the
1586 type from the glom document.
1588 * src/main/java/org/glom/web/server/Utils.java:
1590 2011-11-25 Ben Konrath <ben@bagu.org>
1592 Manually check if the java-liblgom .so is visible to the JVM.
1594 It seems that Tomcat has problems when a static initializer throws an
1595 exception. This check is done before the first method call into
1596 java-libglom so that execution doesn't continue if the .so is not
1599 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1601 2011-11-25 Ben Konrath <ben@bagu.org>
1603 Improve browser configuration error messages.
1607 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1609 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1610 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1611 getConfigurationErrorMessage() method.
1612 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1613 Get and display a specific configuration error message when no Glom
1614 documents are found.
1615 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1616 Implement getConfigurationErrorMessage() method. Surround configuration
1617 code in the init() method with a try/catch block. This allows the
1618 errors to be caught while keeping the servlet available to retrieve the
1619 configuration error message.
1621 2011-11-25 Ben Konrath <ben@bagu.org>
1623 Don't use Strings to hold primary key values.
1625 The primary key values are now held in a new data object
1626 (PrimaryKeyItem) that holds type information and the primary key value
1627 using the correct type.
1629 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1630 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1631 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1632 PrimaryKeyItem instead of String to hold the primary key value.
1633 * src/main/java/org/glom/web/client/Utils.java: Remove
1634 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1635 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1636 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1637 PrimaryKeyItem instead of String to hold the primary key value. Load
1638 document selection page when the documentID has not been set correctly.
1639 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1640 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1642 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1643 Return empty string for URL instead of "null".
1644 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1645 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1646 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1647 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1648 PrimaryKeyItem instead of String to hold primary key values.
1649 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1650 PrimaryKeyValue to a Gda Value.
1651 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1652 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1653 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1654 Replace temporary database access code that uses the PrimaryKeyValue to
1655 Gda Value conversion.
1656 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1657 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1658 PrimaryKeyItem instead of String.
1659 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1660 hold primary key values.
1662 2011-11-24 Ben Konrath <ben@bagu.org>
1664 Use newly added java-libglom API to create queries.
1666 This isn't finished. I still need to stop using Strings for primary key
1667 values in the client code.
1669 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1670 libglom to use fake connections so that retrieving the query string will
1672 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1673 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1674 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1675 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1676 Use the newly added libglom sql methods and classes to create the
1677 query. Add temporary hack to convert primary value strings to Gda
1680 2011-11-23 Ben Konrath <ben@bagu.org>
1682 Don't explicitly set the height of Portals.
1684 See comments 6 - 10 of this bug for details:
1686 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1688 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1690 2011-11-23 Ben Konrath <ben@bagu.org>
1692 Use an HTML table instead of CSS for the FlowTable layout.
1694 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1695 GWT's FlexTable to implement the FlowTable.
1696 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1698 2011-11-18 Ben Konrath <ben@bagu.org>
1700 Add boolean example to HTML table mockup.
1702 * mockups/details-view-html-tables-text-entries.html:
1704 2011-11-17 Ben Konrath <ben@bagu.org>
1706 Ensure the pager buttons are always visible for related lists.
1708 To accomplish this, I've turned off text wrapping in the list view and
1709 related list tables for both the header and data text. The related list
1710 table now has a fixed layout so the it doesn't overflow its container.
1711 This is required to ensure that the cell text is clipped when it
1712 overflows the cell and an ellipsis is added to the right side of the
1713 cell when text is clipped.
1715 A fixed table layout for the related list table in the details view
1716 seems what we want for the details view anyway, so the side-effect is
1719 The ellipsis will only be displayed in Firefox >= 7.
1723 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1725 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1726 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1727 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1729 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1730 Set the 'table-layout: fixed' CSS property to the related list table.
1731 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1732 'white-space: nowrap;' CSS property on both the list view and the
1733 related list tables.
1735 2011-11-16 Ben Konrath <ben@bagu.org>
1737 Rework the fix for empty notebook tab labels.
1739 Setting the empty group titles with its name caused problems for the
1740 details layout. Instead of using libglom's
1741 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1742 to the client when the title is empty. This allows the Notebook to use
1743 the name when the title is empty without affecting anything else.
1745 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1746 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1748 2011-11-16 Ben Konrath <ben@bagu.org>
1750 Set group titles with name when title is empty.
1752 This fixes a problem with an empty notebook tab label in the Lesson
1753 Planner document. The forth tab in the notebook should be "Internet":
1755 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1757 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1758 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1761 2011-11-16 Ben Konrath <ben@bagu.org>
1763 Remove whitespace from the configured username properties.
1765 This assumes that usernames won't have whitespace at the beginning
1766 or end. But I think this is a reasonable assumption.
1768 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1769 String.trim() to remove the whitespace from the username properties.
1771 2011-11-15 Ben Konrath <ben@bagu.org>
1773 Add details view mockup with HTML tables and text entries.
1775 This is from the attachment on this bug:
1777 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1779 * mockups/details-view-html-tables-text-entries.html:
1781 2011-11-15 Ben Konrath <ben@bagu.org>
1783 Add space between the columns of the flow table.
1787 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1789 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1790 space between columns in the flow table.
1792 2011-11-15 Ben Konrath <ben@bagu.org>
1794 Add backup files to the .gitignore.
1796 * .gitignore: Ignore files that end with ~.
1798 2011-11-09 Ben Konrath <ben@bagu.org>
1800 Use latest release of gwt-log.
1802 Gwt-log releases are now being submitted to the maven central
1803 repository so manual installation of the jar is no longer required.
1805 * pom.xml: Update version and groupId of gwt-log dependency.
1807 2011-10-31 Ben Konrath <ben@bagu.org>
1809 Don't use GWT numeric formatting to override the glom currency formatting.
1811 Currencies are now displayed like they are in Glom. See this bug:
1813 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1815 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1817 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1818 currency code to constructor and set it when the cell is rendered.
1819 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1820 currency code to the constructor of the NumericCell.
1822 2011-10-27 Ben Konrath <ben@bagu.org>
1824 Require the latest release of java-libglom (1.17.4).
1828 2011-10-26 Ben Konrath <ben@bagu.org>
1830 Add style to Notebook that matches current theme.
1832 It's not the best style in the world but it's better than the default.
1834 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1835 padding at the bottom of the child widgets.
1836 * src/main/webapp/style.css: Add style for the Notebook.
1838 2011-10-26 Ben Konrath <ben@bagu.org>
1840 Move servlet initialization code to overridden init method.
1842 This is half of the solution to getting proper error messages
1843 displayed when configuration errors occur. Here's the relevant bug:
1845 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1847 The rest of the solution involves surrounding the init method with a
1848 try/catch block and setting a global variable with the error /
1849 exception. A new async method should be created to retrieve and display
1850 the error message / exception.
1852 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1853 code from constructor to init method adding exceptions as needed.
1855 2011-10-26 Ben Konrath <ben@bagu.org>
1857 Add script to monitor and restart tomcat if required.
1859 * utils/check-and-recover-tomcat.py: New file.
1861 2011-10-26 Ben Konrath <ben@bagu.org>
1863 Display the correct number of data items in the pager.
1867 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1869 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1870 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1871 The implementation is the same for both tables: Keep track of the
1872 number of non-empty rows and fire and RowCountChangeEvent after the data has
1874 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1875 custom Pager class that subclasses SimplePager to handle displaying
1876 the correct number when empty rows have been added.
1878 2011-10-26 Ben Konrath <ben@bagu.org>
1880 Correct error in previous commit.
1882 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1883 eventBus parameter from listView.setCellTable().
1885 2011-10-26 Ben Konrath <ben@bagu.org>
1887 Fix error in TODO comment.
1889 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1891 2011-10-24 Ben Konrath <ben@bagu.org>
1893 Create Notebook widgets to the details view.
1895 This isn't finished just yet - I still need to create a reasonable
1896 style to match the current theme.
1898 * src/main/java/org/glom/web/client/Utils.java: Add method for
1899 calculating the height of a widget. This is used in the Notebook class.
1900 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1901 new constructor method in Group.
1902 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1903 method for creating child widget that can be used by subclasses
1904 like Notebook. New constructor that allows disabling the group
1905 titles - Notebooks don't set a group title for their child groups.
1906 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1907 to make Notebooks using GWT's TabLayoutPanel.
1908 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1909 constructor that allows disabling the group titles.
1910 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1911 LayoutItemNotebook DTO.
1912 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1913 DTO for Notebooks. It's just an empty class for now but we might need
1914 it to transfer some specific information in the future.
1916 2011-10-21 Ben Konrath <ben@bagu.org>
1918 Add navigation buttons to related list tables.
1920 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1921 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1922 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1923 method getSuitableRecordToViewDetails() for getting the table name
1924 and primary key value for related list navigation buttons.
1925 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1926 private cell renderer class to get the navigation information for
1927 related list tables from the server. Extract the navigation
1928 processing code from the details cell navigation and use it for the
1929 related list navigation as well.
1930 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1931 cell renderer class for the details open buttons. This was needed
1932 because the related list navigation buttons and the list view
1933 navigation buttons need to react differently when clicked.
1934 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1935 the onEnterKeyDown() method because it's now overriden in the
1936 subclasses that are specific to the related list tables and the list
1938 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1939 the vertical size a little because the buttons add a bit of vertical
1940 space to table. This is not a perfect solution because the vertical
1941 size of with table fewer than 5 rows will be a little smaller.
1942 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1943 changes in how navigation buttons are handled.
1944 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1945 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1946 database access object.
1947 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1948 to find the portal for a given relationship name from
1949 RelatedListDBAccess. Add method to find a primary key field for a
1951 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1952 Move code to find the portal for a given relationship name to
1954 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1955 New file: database access object for getting the related list
1956 navigation information (the table name and the primary key value).
1957 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1958 DTO for transferring a table name to navigate to and a primary key
1960 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1961 boolean and getter/setter to specifies if the related list should add
1964 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1966 Use the master branch of java-libglom
1968 * pom.xml: Depend on java-libglom 1.19 instead.
1970 This is the master branch. See also the libglom-1-18 branch.
1972 2011-10-11 Ben Konrath <ben@bagu.org>
1974 Enable the open navigation button when the data has been set.
1976 This avoids having active buttons that don't do anything when the data
1979 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1981 2011-10-11 Ben Konrath <ben@bagu.org>
1983 Use IsWidget interface for FlowTableItem.
1985 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1986 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1988 2011-10-11 Ben Konrath <ben@bagu.org>
1990 Remove GWT styling from open button in details view.
1992 There are still some issues with how the details cell is arranged but
1993 this should be made to match Glom 1.20. I'm going to leave fixing this
1994 until I have Glom 1.20 up and running.
1996 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1997 style name on open button.
1998 * src/main/webapp/style.css: Move and edit details-navigation class.
1999 Re-arrange some classes to make them appear in the same order as the
2002 2011-10-07 Ben Konrath <ben@bagu.org>
2004 Update to GWT 2.4.0.
2006 * .gitignore: Ignore new cache directory.
2007 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2008 * pom.xml: Change GWT and maven plugin to 2.4.0.
2009 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2011 * src/main/java/org/glom/web/client/ClientFactory.java:
2012 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2013 * src/main/java/org/glom/web/client/OnlineGlom.java:
2014 Update source for API changes.
2015 * utils/build-onlineglom-war.sh: Remove cache directory before the
2018 2011-10-07 Ben Konrath <ben@bagu.org>
2020 Add navigation buttons in the details view.
2022 This isn't finished but I thought I'd commit what I have as it's a
2023 pretty good start. I still need to:
2025 1. Change the style so that it fits better into the current theme
2026 2. Adjust the details cell to expand as much as possible.
2028 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2029 click handlers to navigation buttons in the DetailsCells. Create a
2030 refreshData() method to get just the data from the server without the
2032 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2033 Update the tableSelector and browser title when the table name
2034 changes without using the tableSelector.
2035 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2036 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2037 getDetailsCells() to getCells(). Update variable names.
2038 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2039 method to set click handler on navigation button. Rename a few
2040 variables. Add navigation buttons where needed.
2041 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2042 variables and methods.
2043 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2044 navigation boolean and navigation table as required in the
2045 LayoutItemField DTO.
2046 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2047 variables for navigation along with getter/setter methods.
2049 2011-10-07 Ben Konrath <ben@bagu.org>
2051 Rename Field to DetailsCell.
2053 This is a refactor-only commit. No functionality has been added or
2056 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2057 Update variable and method names.
2058 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2059 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2060 variable and method names.
2061 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2063 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2064 variable and method names.
2066 2011-10-07 Ben Konrath <ben@bagu.org>
2068 Create separate methods for layout and data the details view.
2070 This is a refactor-only commit. No functionality has been added or
2073 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2074 private methods: setData(), createLayout().
2076 2011-10-07 Ben Konrath <ben@bagu.org>
2078 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2080 This is part of a change to get navigation buttons in the details view
2081 but it should have been done this way from the start.
2083 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2084 for method name change in TableSelectionView.
2085 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2086 Create TableChangeEvent and set the browser title using the
2087 TableSelectionView API.
2088 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2089 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2090 Change getSelectedTable() to getSelectedTableName(). Add
2091 getSelectedTableTitle().
2093 2011-10-07 Ben Konrath <ben@bagu.org>
2095 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2097 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2099 2011-10-07 Ben Konrath <ben@bagu.org>
2101 Update TableChangeEvent to use newTableName naming convention.
2103 This makes the class more consistent with GWT naming conventions.
2105 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2106 Update for method name change in TableChangeEvent.
2107 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2108 for method name change in TableChangeEvent.
2109 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2110 newTableName variable and getter method. Make toDebugString()
2113 2011-09-30 Ben Konrath <ben@bagu.org>
2115 Disable the pager in the list tables when the data row count is less than the minimum.
2117 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2118 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2120 2011-09-30 Ben Konrath <ben@bagu.org>
2122 Add empty rows to the end of related list and list view tables.
2124 I also extracted the cell rendering classes from the ListTable because
2125 the code was becoming a little crazy with all the anonymous inner
2126 classes. My plan is to use these cell rendering classes in the details
2127 view as well so this refactor will be needed for that change.
2129 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2130 set the row count in related list tables if the data has more rows
2131 than the minimum number of rows visible.
2132 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2133 row count in list view tables if the data has more rows than the
2134 minimum number of rows visible.
2135 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2136 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2138 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2139 for rendering TYPE_NUMERIC cells. The code was extracted from the
2141 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2142 class for rendering cells with buttons in list views. The code was
2143 extracted from the ListTable class.
2144 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2145 for rendering TYPE_TEXT cells. The code was extracted from the
2147 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2148 Add empty rows to the end of the data if required. Implement
2149 ListTable.getMinNumVisibleRows().
2150 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2151 cell renderer code to public classes. Return null in
2152 Column.getValue() for empty rows. Add new abstract method:
2153 getMinNumVisibleRows(). Move code to set the row count of the list view
2154 table to ListViewImpl.
2155 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2156 empty rows to the end of the data if required. Implement
2157 ListTable.getMinNumVisibleRows().
2160 2011-09-27 Ben Konrath <ben@bagu.org>
2162 Use GWT.log for client-side debugging statements.
2164 These are optimized out when deployed so I should have used this method
2165 in the first place. These statements will eventually be replaced with some sort
2166 of notification in the browser.
2168 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2169 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2170 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2171 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2172 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2174 2011-09-27 Ben Konrath <ben@bagu.org>
2176 Put tableselector on the right, back to list link on right.
2178 The idea is that the table selector is acting like a label for the
2179 currently displayed table so it should be placed below the document title. This
2180 puts the table title in a similar position to where it is in Glom.
2182 * mockups/details-contacts.html:
2183 * mockups/details-projects.html:
2184 * mockups/listview-contacts.html:
2185 * mockups/listview-projects.html:
2186 * mockups/style.css:
2187 Update mockups to match how the interfaces currently look.
2188 * src/main/webapp/style.css: Swap positions of backlink with the table
2189 selector. Add some space on the left side of the table selector to
2190 line things up with the document title.
2192 2011-09-27 Ben Konrath <ben@bagu.org>
2194 Add field colouring to details view.
2196 This change re-works how field colouring works. The colour formatting
2197 information is now set to the client with the layout information instead of
2198 with the data. This eliminates the need to send the same colour strings for
2199 data in list view column when colour information is set.
2201 In order to set an alternate colour for negative numeric values, the
2202 number is now sent to client and formatted with the GWT NumberFormat class.
2204 This change also fixes:
2206 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2208 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2209 internationalization framework which is needed for client side numeric
2211 * src/main/java/org/glom/web/client/Utils.java: New file for some
2212 client static utility methods.
2213 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2214 the DataItem object to the Field class. Use a utility method to
2215 create the foreignKeyValue string.
2216 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2217 alignment and text colours in the constructor. Add setData(DataItem)
2218 method. Remove setText(String) method.
2219 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2220 colour information to GlomTextCell. Create and use GlomNumberCell for
2221 rendering numbers. Use utility method to get the string for the
2222 primary key of the key provider. Re-work how the horizontal alignment
2224 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2225 formatting to layout information. Methods for converting the libglom
2226 formatting information were moved from DBAccess.
2227 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2228 numeric formatting (it's now done on the client side). Don't set text
2229 colours in DataItem. Move libglom formatting conversion methods to
2231 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2232 getters/setters for text colour information.
2233 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2234 for transferring the libglom NumericFormat information to the client.
2235 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2236 and getters/setters for: GlomNumericFormat, background colour and
2237 foreground colour strings.
2239 2011-09-26 Ben Konrath <ben@bagu.org>
2241 Simplify code that iterates through the LayoutGroup.
2243 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2245 2011-09-26 Ben Konrath <ben@bagu.org>
2247 Accept Eclipse formatting for OnlineGlomServiceAsync.
2249 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2251 2011-09-26 Ben Konrath <ben@bagu.org>
2253 Don't use the ListDBAccess classes to get the primary key layout information.
2255 This was causing a bug where the wrong index for the hidden primary key
2256 was being sent to the client.
2258 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2259 primary key while creating the LayoutGroup DTO. Create a
2260 LayoutItemField DTO for hidden primary keys. Don't use the
2261 RelatedListDBAccess because it was only used for getting the primary
2263 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2264 access modifier from public to protected for getPrimaryKeyField() and
2265 getPrimaryKeyLayoutItemField().
2266 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2267 abstract method getExpectedResultSize() because RelatedListDBAccess
2268 doesn't have enough info to implement it.
2269 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2270 Remove @Override for getExpectedResultSize().
2271 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2272 Remove method getExpectedResultSize().
2274 2011-09-23 Ben Konrath <ben@bagu.org>
2276 Log which layout (list or details) the ignored item is from.
2278 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2280 2011-09-23 Ben Konrath <ben@bagu.org>
2282 Remove annotations that turn off code formatting in DataItem.
2284 * src/main/java/org/glom/web/shared/DataItem.java:
2286 2011-09-23 Ben Konrath <ben@bagu.org>
2288 Rename GlomField to DataItem and update associated methods.
2290 This is a rename-only refactor. No functionality has been added or
2293 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2294 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2295 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2296 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2297 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2298 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2299 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2300 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2301 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2302 * src/main/java/org/glom/web/server/database/DBAccess.java:
2303 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2304 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2305 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2306 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2307 * src/main/java/org/glom/web/shared/DataItem.java:
2308 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2309 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2311 2011-09-23 Ben Konrath <ben@bagu.org>
2313 Rename GlomDocument to DocumentInfo and update associated methods.
2315 This is a rename-only refactor. No functionality has been added or
2318 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2319 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2320 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2321 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2322 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2323 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2324 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2326 2011-09-20 Ben Konrath <ben@bagu.org>
2328 Require java-libglom 1.17.3.
2330 This picks up the fix for the seg fault problem with the Scenes table
2331 in the Openismus Film Manager example.
2335 2011-09-20 Ben Konrath <ben@bagu.org>
2337 Change the way sort clause is added for primary key when no sort clause is requested.
2339 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2340 before the sort clause is created. When a sort clause is not requested, the
2341 sort clause is created by finding the primary key in the LayoutFieldVector
2344 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2346 2011-09-20 Ben Konrath <ben@bagu.org>
2348 Log error message if no documents are found in the configured directory.
2350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2351 Extract the glom file extension string to a private static final class
2352 variable (mostly as syntactic sugar). Accept a minor formatting change.
2353 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2354 the example glom.document.directory configuration property to make it
2355 more clear that it can any directory, not just the home directory.
2357 2011-09-18 Ben Konrath <ben@bagu.org>
2359 Add related lists to details view.
2361 The related list table has support for paging and sorting just like the
2362 table in the list view.
2364 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2365 SQL queries for the related list tables.
2366 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2367 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2368 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2369 Rename getList methods to getListView and add comments. Remove
2370 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2371 it being unused. Add methods: getDetailsLayoutAndData(),
2372 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2373 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2374 Create the layout and set the data for the fields in one async call
2375 instead of two. Create related lists where appropriate.
2376 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2377 for method name changes in OnlineGlomService.
2378 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2379 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2380 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2382 * src/main/java/org/glom/web/client/ui/ListView.java:
2383 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2384 tableName from setCellTable(). Create a ListViewTable instead of
2386 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2387 represent a data field in the details view.
2388 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2389 from addDetailsCell() to Field class. Keep track of the Fields and
2390 Portals in the details view.
2391 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2392 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2393 and add a method to get it. Add method to set the contents of the
2395 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2396 New class for related list tables. This class has the data provider
2397 for the related list table.
2398 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2399 abstract class which is the base class for the ListViewTable and the
2401 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2402 New class for list view tables. This class has the data provider for
2403 the list view table.
2404 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2405 methods for related list tables. Add more information to the
2406 LayoutItemField and LayoutItemPortal DTOs.
2407 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2408 Remove debugging print statement.
2409 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2410 Remove debugging print statements. Add primary key field to SQL count
2412 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2413 Remove unnecessary LayoutFieldVector parameter from
2414 getResultSizeOfSQLQuery() method.
2415 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2416 New class for related list table database access.
2417 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2418 class that is a wrapper DTO for details view layout and data.
2419 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2420 new 'fromField' string to this DTO.
2421 * src/main/webapp/style.css: Remove bottom margin and override top
2424 2011-09-15 Ben Konrath <ben@bagu.org>
2426 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2428 This sets things up to make it easier to add the data retrieval for
2429 related lists (portals). No user noticeable changes were made with
2432 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2433 class has the code to retrieve the layouts and access the
2434 database using the new database helper classes.
2435 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2436 Most of the functionality has been removed from this class. This
2437 class now represents the public interface for the client side
2438 code. It also deals with configuring the servlet and cleaning
2439 things up when the servlet is stopped.
2440 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2441 of static methods into this utility class.
2442 * src/main/java/org/glom/web/server/database/DBAccess.java:
2443 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2444 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2445 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2446 These classes have the database retrieval code. The class hierarchy
2447 has been setup to make it easy to reuse code for similar
2450 2011-09-06 Ben Konrath <ben@bagu.org>
2452 Create separate classes for list table code and the data provider.
2454 As part of this refactor, I also split up the code a bit to make it
2457 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2458 table code to two new classes (below).
2459 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2460 with code from ListViewImpl.
2461 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2462 New file with code from ListViewImpl.
2464 2011-09-06 Ben Konrath <ben@bagu.org>
2466 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2468 This fixes the LayoutItemPortal DTO to match the libglom layout object
2471 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2473 2011-09-01 Ben Konrath <ben@bagu.org>
2475 Set title of Portals in the Details View.
2477 * pom.xml: Bump required version of java-libglom to 1.17.1.
2478 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2479 widget creation to its own class. Add comments to constructor.
2480 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2481 The code is mostly from the Group class with the title now set.
2482 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2483 title of Portal. Update some comments. Fix some code formatting.
2485 2011-09-01 Ben Konrath <ben@bagu.org>
2487 Remove TODO comment for the flow table column width.
2489 The flow table column width is working correctly and doesn't need to be
2490 changed. See this mailing list post for more info:
2492 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2494 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2496 2011-08-27 Ben Konrath <ben@bagu.org>
2498 Add document title (database name) to top of the browser page.
2500 I added the document title to the TableSelecitonView but that will
2501 change if / when we add a view that doesn't require table selection.
2503 * mockups/details-contacts.html:
2504 * mockups/details-projects.html:
2505 * mockups/listview-contacts.html:
2506 * mockups/listview-projects.html:
2507 * mockups/style.css: Add document title to mockups to keep things
2509 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2510 sizes to account for the document title.
2511 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2512 Set the document title when it has been retrieved from the server.
2513 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2514 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2515 and implement setDocumentTitle(String) method.
2516 * src/main/webapp/style.css: Add ID for document title style.
2518 2011-08-25 Ben Konrath <ben@bagu.org>
2520 Add NavigationType enum to LayoutItemPortal DTO.
2522 This is the start of adding support for Portals to the Details View.
2524 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2525 LayoutItem_Portal.navigation_type enum from libglom to
2526 LayoutItemPortal.NavigationType enum.
2527 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2528 NavigationType enum, field for storing the NavigationType and getter
2531 2011-08-25 Ben Konrath <ben@bagu.org>
2533 Implement the flow table layout in the Details View.
2535 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2536 FlowTable to Group to account for the renamed class.
2537 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2538 File. This is a container widget that implements the Glom details view
2539 flow table behaviour.
2540 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2541 org/glom/web/client/ui/FlowTable.java.
2542 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2543 so that the size of the subgroups are a closer match to the size of
2544 the Glom subgroups. This makes the flowtable layout match the layout
2545 in Glom for the Music Collection example file.
2547 2011-08-16 Ben Konrath <ben@bagu.org>
2549 Create container element for LayoutItemPortal in Details View.
2551 This will help me develop the layout for the FlowTable.
2553 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2554 fieldPanel variable to detailsCell.
2556 2011-08-15 Ben Konrath <ben@bagu.org>
2558 Set the height of the data element in the Details View.
2560 I changed the InlineLabels (text in a span element) to Labels (text in
2561 a div element) so that I could set the height of the details-data
2562 elements instead of the details-cell parent elements. This allows the
2563 the details-data element to display the correct height if style is
2564 applied that shows the height.
2566 This change has the added benefit of allowing the order of the labels
2567 and data elements to be changed for right-to-left languages.
2569 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2570 InlineLabels to Labels.
2571 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2572 InlineLabels to Labels. Set the height of the data element.
2573 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2574 multiline text height in the Formatting DTO.
2575 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2576 for multiline height along with getter and setter methods.
2577 * src/main/webapp/style.css: Adjust style to account for the change
2578 from span elements to div elements in the details cell.
2580 2011-08-15 Ben Konrath <ben@bagu.org>
2582 Make the List View appearance match the mockups.
2584 It doesn't match exactly but it's much better than it was.
2586 * mockups/listview-contacts.html: Remove unused css classes.
2587 * mockups/listview-projects.html: Remove unused css classes.
2588 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2589 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2590 for mainPanel instead of VerticalPanel (table). Set style name on
2591 CellTable. Set style name on Details column. Right-align Details
2593 * src/main/webapp/style.css: Adjust properties to match the mockups.
2595 2011-08-12 Ben Konrath <ben@bagu.org>
2597 Add better support for subgroups in the details view.
2599 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2600 changed FlowTable constructor.
2601 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2602 support for subgroups and subgroup-titles.
2603 * src/main/webapp/style.css: Add CSS class for subgroups and
2606 2011-08-12 Ben Konrath <ben@bagu.org>
2608 Return the top level LayoutGroup title.
2610 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2612 2011-08-11 Ben Konrath <ben@bagu.org>
2614 Make the TableSelector header match the mockup.
2616 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2617 the layout panel. Properly lineup the table selection header with
2618 the list and details view.
2619 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2620 margin around the details view.
2621 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2622 Rename listBox variable to tableSelector. Set id for the style sheet.
2623 Use a FlowPanel instead of a HorizontalPanel.
2624 * src/main/webapp/style.css: Add properties to make the TableSelector
2625 box match the mockups.
2627 2011-07-13 Ben Konrath <ben@bagu.org>
2629 Update install script for java-libglom version change.
2631 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2634 2011-07-13 Ben Konrath <ben@bagu.org>
2636 Add support sub-group in the details view.
2638 I also removed the code that special-cased the default details view
2641 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2643 I still have to make a proper flowtable.
2645 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2646 Don't special-case default details view layout.
2647 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2648 addLayoutField() as I'm going to use it.
2649 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2650 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2652 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2653 extracted from DetailsViewImpl.GroupPanel. Add support for
2655 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2656 column count when getting the details layout.
2658 2011-07-12 Ben Konrath <ben@bagu.org>
2660 Set browser title with database and table titles.
2662 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2663 Set the browser title when the table changes and when the activity
2665 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2666 title when retrieving document info (the GlomDocument object).
2667 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2668 with getter and setter methods. Remove unused convenience constructor.
2669 Use default code formatting.
2671 2011-07-12 Ben Konrath <ben@bagu.org>
2673 Ignore LayoutItemPortals in the details view.
2675 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2678 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2679 LayoutItemPortal layout objects.
2680 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2681 LayoutItemPortal objects when retrieving the details layout.
2682 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2683 file. This is an empty class and just used to get type information for
2686 2011-07-12 Ben Konrath <ben@bagu.org>
2688 Use java-libglom 1.17.0.
2692 2011-07-11 Ben Konrath <ben@bagu.org>
2694 Remove "Table:" label from table selector.
2696 This matches a recent change in the Glom UI.
2698 * mockups/details-contacts.html:
2699 * mockups/details-projects.html:
2700 * mockups/listview-contacts.html:
2701 * mockups/listview-projects.html: Remove the "Table:" label from the
2703 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2705 2011-07-11 Ben Konrath <ben@bagu.org>
2707 Add main groups to the details view.
2709 This makes things look a little nicer in the details view. The next step
2710 is to implement the flowtable.
2712 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2713 resources from the standard gwt css theme. Standard.css is now
2714 included in OnlineGlom.html so that the online glom css rules have
2715 precedence over the gwt theme.
2716 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2717 the whole LayoutGroup to the DetailsView instead of just the titles.
2718 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2719 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2720 details layout with a helper class (GroupPanel). I might extract this
2721 class when I make the full flowtable.
2722 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2723 string as default so I don't have to worry about NPEs when processing
2725 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2726 note beside OnlineGlom.gwt.xml above).
2727 * src/main/webapp/style.css: Add default font-size to body to override
2728 the font-size set by the standard theme. Don't use h2 tags for
2729 group-title. Create new details-cell class.
2731 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2733 ConfiguredDocument: Set the port number too.
2735 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2736 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2737 Glom document. Presumably this worked sometimes so far because there is a
2738 default port number.
2740 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2742 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2744 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2745 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2746 correct, though we should throw an exception too.
2748 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2750 Fix a addDocuemnt typo.
2752 * src/main/java/org/glom/web/shared/Documents.java
2753 (Documents.addDocuemnt): Rename to addDocument().
2754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2755 (OnlineGlomServiceImpl.getDocuments): Adapt.
2757 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2759 Slightly improved log output when connection fails.
2761 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2762 (ConfiguredDocument.setUsernameAndPassword):
2763 We don't know for sure if it' the username/password that's wrong, so
2764 rephrase the message.
2765 Also ouput the exception message, though it's generic in this case.
2767 2011-07-08 Ben Konrath <ben@bagu.org>
2771 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2772 added braces to a one line if statement because the Eclipse formatter
2773 was getting confused.
2775 2011-07-07 Ben Konrath <ben@bagu.org>
2777 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2779 These should really be two separate tasks but I counldn't get things to
2780 work with GWT 2.2.0 and Eclipse 3.7.
2784 * .settings/org.eclipse.jdt.core.prefs:
2785 * .settings/org.eclipse.jdt.ui.prefs:
2786 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2787 * .settings/org.eclipse.m2e.core.prefs:
2788 Add new config files. Update current files. Remove references to the
2789 webtools plugins as we're not using any of the webtools features.
2790 * .gitignore: Add logs directory which is created when running with
2792 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2793 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2794 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2796 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2798 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2800 onlineglom.properties: Add explanatory comments.
2802 * src/main/resources/onlineglom.properties: Also change the default user
2803 from ben to someuser, to avoid the risk of people thinking we just
2804 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2806 2011-06-28 Ben Konrath <ben@bagu.org>
2808 Use filename in Log for incorrect passwords.
2810 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2811 getFileName(String) method to get the filename from the URI.
2813 2011-06-28 Ben Konrath <ben@bagu.org>
2815 Add the table name to the URL token for the ListPlace.
2817 This makes things consistent between the DetailsPlace and the
2818 ListPlace. It also allows the the ListPlace to be bookmarked.
2820 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2821 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2823 Remove getDefaultListLayout(). The default layout is now returned
2824 by the getListLayout() method when the table name is an empty string.
2825 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2826 Add table name field. Change to a new ListPlace when the table
2827 has been changed. Use getListLayout() for getting the default
2829 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2830 Add table name field. Set the correct table name in the list box
2831 when loading from bookmark. This corrects a problem for the
2833 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2834 Move table name to super-class (HasSelectableTable). Move document
2835 and table URL keys to super-class in HasSelectableTable.
2836 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2837 Add table name field. Add Tokenizer class with URL key common to
2838 the subclasses (DetailsPlace and ListPlace).
2839 * src/main/java/org/glom/web/client/place/ListPlace.java:
2840 Add table name. Add code to parse the URL token.
2841 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2842 Update ListPlace construction with empty table name string.
2843 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2844 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2845 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2846 Update ListPlace construction with table name string.
2847 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2848 Change defaultTableName field to tableName to reflect how it's now
2849 used. Update the getter and setter methods.
2851 2011-06-28 Ben Konrath <ben@bagu.org>
2853 Enable the table selector in the DetailsView.
2855 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2856 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2857 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2858 Remove getDefaultDetailsLayout(). The default layout is now returned
2859 by the getDetailsLayout() method when the table name is an empty
2861 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2862 event handler for table change event. Change to using
2863 getDetailsLayout() for the default details layout.
2864 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2866 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2867 when navigating to the details place.
2869 2011-06-27 Ben Konrath <ben@bagu.org>
2871 Use filename based unique document ID in URL and for RPC.
2873 The document ID is the glom document name with spaces (' ') replaced
2874 with pluses ('+') and without the .glom extension.
2876 This change is mostly a string substitution of 'documentTitle' for
2877 'documentID'. The only code change is the addition of a Documents DTO to get the
2878 filename to document title mappings as indicated below.
2880 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2881 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2882 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2883 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2884 Use Documents DTO to create the document links in the document
2886 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2887 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2888 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2889 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2890 * src/main/java/org/glom/web/client/place/ListPlace.java:
2891 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2892 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2893 * src/main/java/org/glom/web/client/ui/ListView.java:
2894 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2895 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2896 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2897 * src/main/java/org/glom/web/server/Log.java:
2898 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2899 getDocumentTitles() to getDocuments() and return the Documents DTO.
2900 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2901 transferring the filename to document title mappings.
2903 2011-06-25 Ben Konrath <ben@bagu.org>
2905 Make the authentication popup work again.
2907 This bug was introduced when I extracted ConfiguredDocument to its own class.
2909 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2910 correct success / fail status in setUsernameAndPassword().
2912 2011-06-25 Ben Konrath <ben@bagu.org>
2914 Use filename as unique key for configuring database usernames and passwords.
2916 This replaces the use of the Glom document title which could change
2917 depending on the locale. Thanks to Murray Cumming for pointing out this
2920 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2921 * src/main/resources/onlineglom.properties:
2923 2011-06-24 Ben Konrath <ben@bagu.org>
2925 Pass primary key value to DetailsView.
2927 This enables the DetailsView to load the correct data.
2929 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2930 primary key value field and set in constructor. Pass primary key
2931 value to getDetailsData().
2932 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2933 variables for document title and primary key value.
2934 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2935 key value to the DetailsPlace.
2937 2011-06-24 Ben Konrath <ben@bagu.org>
2939 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2941 This allows the primary key to be retrieved by the Details button. This
2942 functionality has not been implemented yet but it's in the works.
2944 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2945 the LayoutGroup result to ListView.setCellTable instead of all of its
2946 fields individually.
2947 * src/main/java/org/glom/web/client/ui/ListView.java:
2948 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2949 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2950 get the primary key for the table.
2951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2952 index of the primary key in the LayoutGroup accounting for hidden
2953 primary keys. Rename getJavaNumberFormat() to
2954 convertToJavaNumberFormat() for consistency. Cleanup / add some
2956 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2957 field for primary key index and a field to indicate whether the
2958 primary key is hidden or not.
2960 2011-06-23 Ben Konrath <ben@bagu.org>
2962 Rename getTableData methods to getListData.
2964 This is a rename refactor for consistency with other methods.
2966 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2967 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2968 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2969 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2971 2011-06-23 Ben Konrath <ben@bagu.org>
2973 Extract the ConfiguredDocument innerclass into its own class.
2975 This makes the servlet code more object oriented.
2977 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2978 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2979 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2980 new ConfiguredDocument class.
2982 2011-06-21 Ben Konrath <ben@bagu.org>
2984 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2986 This makes things more inline with how libglom works and reduces code
2987 duplication. This refactor lays the groundwork for adding the primary key to
2988 the LayoutGroup object.
2990 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2991 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2992 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2993 Change method names to getListLayout and getDefaultListLayout for
2994 consistency. Use LayoutGroup as the DTO for the list layout instead of
2995 ColumnInfo and LayoutListTable.
2996 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2997 new method names along with the LayoutGroup object for transferring the
2999 * src/main/java/org/glom/web/client/ui/ListView.java:
3000 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3001 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3002 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3004 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3005 Replaced with LayoutGroup.
3006 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3007 expectedResultSize and defaultTableName fields which are needed for
3009 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3010 type field which is needed for the list layout but will also be
3011 useful for the details layout as things progress.
3012 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3013 Make class abstract. Remove the unnecessary
3014 getFormattingHorizontalAlignment method. Add setFormatting method.
3016 2011-06-16 Ben Konrath <ben@bagu.org>
3018 Add scripts for building and installing war.
3020 These will help when updating OnlineGlom but they're also good
3021 supplemental documentation of the build and deployment proceeding.
3023 * utils/build-onlineglom-war.sh: New file.
3024 * utils/install-onlineglom-war.sh: New file.
3026 2011-06-16 Ben Konrath <ben@bagu.org>
3028 Create wrapper class to create consistent log messages.
3030 I wrapped methods in the Log class of gwt-log to add the method names
3031 from the servlet and create consistent formatting of the document title
3032 and table names in the log messages.
3034 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3036 log methods to use methods from wrapped Log class.
3038 2011-06-16 Ben Konrath <ben@bagu.org>
3040 Remove superfluous conditional return.
3042 Thanks to Murray Cumming for pointing this out!
3044 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3046 2011-06-15 Ben Konrath <ben@bagu.org>
3048 Return an ArrayList of LayoutGroups for the Details layout.
3050 This corrects a problem with the details layout as it can have more
3051 than one top level LayoutGroup.
3053 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3054 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
3055 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
3056 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
3057 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
3058 with ArrayList of LayoutGroups for the details view layout.
3059 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3060 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
3061 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
3062 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
3063 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
3064 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
3066 2011-06-14 Ben Konrath <ben@bagu.org>
3068 Use cast_dynamic method to determine the libglom LayoutItem type.
3070 This is better than finding the LayoutItem type by using the string
3071 returned from the get_part_type_name() method.
3073 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3075 2011-06-14 Ben Konrath <ben@bagu.org>
3077 Add method names to log entries in the servlet.
3079 This helps when tracking down deployment problems.
3081 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3083 2011-06-14 Ben Konrath <ben@bagu.org>
3085 Add data to the DetailsView using a hard-coded primary key value.
3087 The layout and functionality of the DetailsView is not complete. This
3088 is just a checkpoint so the patch doesn't get too big.
3090 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3091 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3092 Add getDetailsData() servlet method.
3093 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3094 Add RPC to getDetailsData(). Change the way the LayoutGroups and
3095 LayoutFields are added to the DetailsView.
3096 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3097 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3098 Add setData() method. Change addLayoutGroup() and addLayoutField() to
3099 take the string for the title instead of the object.
3100 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3101 Add implementation getDetailsData() along with some private helper
3103 * src/main/webapp/style.css: Add padding to details-data class. Add a
3104 details-label class with the same padding as the details-data class.
3106 2011-06-03 Ben Konrath <ben@bagu.org>
3108 Use presenter.goTo() to change to the DetailsPlace.
3110 This will make things easier when we need to open the DetailsView with
3111 data specific to the row that was clicked.
3113 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3115 2011-06-02 Ben Konrath <ben@bagu.org>
3117 Add CSS file from mockups.
3119 I'm adding this now because it's going to be useful to have when
3120 developing the DetailsView. The TableSelectionView and ListView aren't
3123 * src/main/webapp/OnlineGlom.html:
3124 * src/main/webapp/style.css:
3126 2011-06-02 Ben Konrath <ben@bagu.org>
3128 Use String.isEmpty() to check for empty string.
3130 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3132 2011-06-02 Ben Konrath <ben@bagu.org>
3134 Display main layout group titles in the DetailsView.
3136 This is the start of the DetailsActivity/DetailsView implementation.
3138 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3139 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3140 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
3141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3142 Get the layout information for the details view from the server and set
3143 the main layout group titles.
3144 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3145 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3146 Add addLayoutGroup() and addLayoutField() methods. This are just
3147 temporary methods for creating the the details view that will change
3149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3150 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
3152 * src/main/java/org/glom/web/shared/layout/Formatting.java:
3153 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3154 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
3155 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
3156 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3157 Data Transfer Objects that mimic the libglom object structure. These are
3158 used for transferring the details layout but could also be used for
3159 transferring the list layout.
3161 2011-05-27 Ben Konrath <ben@bagu.org>
3163 Reset the AuthenticationPopup when clearing the ListView.
3165 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3167 2011-05-27 Ben Konrath <ben@bagu.org>
3169 Fix problem with onlineglom.properties file loading.
3171 The old way worked in Eclipse but not on the server. Loading the
3172 onlineglom.properties file now works in Eclipse and on the server.
3174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3176 2011-05-24 Ben Konrath <ben@bagu.org>
3178 Update gwt-log from 3.1.0 to 3.1.2.
3180 Gwt-log 3.1.0 has been marked as depreciated.
3184 2011-05-24 Ben Konrath <ben@bagu.org>
3186 Add comment to ListActivity.goTo() method.
3188 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3190 2011-05-24 Ben Konrath <ben@bagu.org>
3192 Remove FIXME in convertGdkColorToHtmlColour()
3194 The Gdk::Color value returned by libglom is 16-bits per channel on both
3195 64 and 32-bit platforms.
3197 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3199 2011-05-19 Ben Konrath <ben@bagu.org>
3201 Improve performance of initial ListView load.
3203 I removed a round trip to the server for getting the default table name
3204 and then requesting information about that table. This also removes a potential
3205 problem with the table change handler not being setup in time to receive the
3206 table change event from the ListActivity.
3208 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3209 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3210 getDefaultLayoutListTable() method. Improve comments.
3211 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
3212 getDefaultLayoutListTable() method instead of firing a table change
3213 event to get the table to load.
3214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3215 implementation of getDefaultLayoutListTable() method.
3216 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3219 2011-05-19 Ben Konrath <ben@bagu.org>
3221 Override toDebugString() in TableChangeEvent.
3223 This is useful to have for debugging.
3225 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3227 2011-05-19 Ben Konrath <ben@bagu.org>
3229 Add a "Back to List" link when at the DetailsPlace.
3231 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3232 Populate the CellTable based on the selected table of the ListBox if
3233 it's set otherwise use the default table. This allows the "Back to
3235 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3236 Remove Place from constructors. Add a setPlace() method. Add
3237 goToPlace() method. Set class as presenter for TableSelectionView.
3238 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3239 Use the same TableSelectionActivity when switching between the List and
3241 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3242 Subclass the new HasSelectableTablePlace. This removes some