1 2012-11-20 Murray Cumming <murrayc@murrayc.com>
3 Update the jasperreports version.
5 * pom.xml: This was shown by
6 mvn versions:display-dependency-updates
8 2012-11-20 Murray Cumming <murrayc@murrayc.com>
10 Eclipse: Reorder the Java Build Path to fix the build in Eclipse.
12 * .classpath: This prevents an error saying that getTextContent()
14 See http://mergetag.com/the-method-gettextcontent-is-undefined-for-the-type-node/
16 2012-11-20 Murray Cumming <murrayc@murrayc.com>
18 Explicitly declare some dependencies (and scopes) that we use.
20 * pom.xml: The dependency report showed what we use.
22 2012-11-20 Murray Cumming <murrayc@murrayc.com>
24 Update the gwt-test-utils version.
26 * pom.xml: gwt-test-utils 0.43 uses GWT 2.5.0, not GWT 2.4.0.
27 Using both in the same project was causing gwt-log to fail in GWTBrige,
29 testOutOfBounds(org.glom.web.server.libglom.DocumentLayoutPathTest):
30 (class: com/google/gwt/core/client/GWT, method: setBridge signature: (Lcom/google/gwt/core/client/GWTBridge;)V) Incompatible argument to function
32 2012-11-19 Murray Cumming <murrayc@murrayc.com>
34 DocumentTest: testLocales(): Update for the latest example version.
36 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
37 The .glom file, updated in the previous commit, now has more translations.
39 2012-11-19 Murray Cumming <murrayc@murrayc.com>
41 Update the .glom files used for tests.
43 * src/test/resources/org/glom/web/server/example_film_manager.glom:
44 * src/test/resources/org/glom/web/server/example_music_collection.glom:
45 * src/test/resources/org/glom/web/server/libglom/example_film_manager.glom:
46 * src/test/resources/org/glom/web/server/libglom/example_music_collection.glom:
47 Copy them from git master of Glom.
49 2012-11-18 Murray Cumming <murrayc@murrayc.com>
51 Update versions of dependencies.
53 * pom.xml: Increase some version numbers based on the output of
54 , using mvn versions:display-dependency-updates.
55 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
56 Use the annotation instead of getModuleName().
57 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
58 Do not use deprecated assert() classes/methods.
60 2012-11-18 Murray Cumming <murrayc@murrayc.com>
62 Document: Correct an import to use the correct Log API.
64 * src/main/java/org/glom/web/server/libglom/Document.java:
65 Use our Utils.Log API rather than the jfree one that Eclipse
66 must have suggested at some time.
68 2012-11-15 Murray Cumming <murrayc@murrayc.com>
70 Details: Get static image data from our images services.
72 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
73 Add constructors for LayoutItemText and LayoutItemImage and
74 deal with their common type instead of just LayoutItemField.
76 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
78 * src/main/java/org/glom/web/client/ui/details/Group.java:
79 createChildWidget(): Use the other DetailsCell constructors for
80 these layout items, and do not add them to the list of
81 cells with data from the database.
82 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
83 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
84 Remove the image data when cloning the layout and storing it in the
85 cache. Clients will instead get it via the URL, from
87 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
88 doGet(): Depending on the URI parameters, optionally get
89 image data from a layout_item_image in the document,
91 * src/main/java/org/glom/web/server/database/DBAccess.java:
92 convertResultSetToDTO(): Move some URIBuilder code to:
93 * src/main/java/org/glom/web/server/Utils.java:
94 Add buildImageDataUrl() taking the primary key, etc, to
95 get data from the database.
97 2012-11-15 Murray Cumming <murrayc@murrayc.com>
99 Document: Static image items: Store an image URL, using the layout path.
101 * src/main/java/org/glom/web/server/Utils.java: Add buildImageDataUrl().
102 * src/main/java/org/glom/web/server/libglom/Document.java:
103 Add a constructor that takes the documentID, for use in the
105 loadLayoutNode(): Pass a Path object to the helper methods, so we
106 can use it to create a URL for LayoutItemImage items.
107 This seems as good a way as any to specify a layout item in the document.
108 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
109 Pass the documentID to the constructor, for use in the LayoutItemImage
112 2012-11-15 Murray Cumming <murrayc@murrayc.com>
114 Document: Add getLayoutItemByPath().
116 * src/main/java/org/glom/web/server/Utils.java:
117 Add buildLayoutPath() and parseLayoutPath().
118 * src/test/java/org/glom/web/server/LayoutPathTest.java: Test that these
119 utility methods work.
120 * src/main/java/org/glom/web/server/libglom/Document.java:
121 Add Add getLayoutItemByPath().
122 * src/test/java/org/glom/web/server/libglom/DocumentLayoutPathTest.java: Test
125 This will be useful in subsequent commits.
127 2012-11-15 Murray Cumming <murrayc@murrayc.com>
129 Need a short description (OOPS!).
130 Need the bug URL (OOPS!).
132 Reviewed by NOBODY (OOPS!).
134 Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
137 * .settings/com.google.gdt.eclipse.core.prefs:
138 * .settings/com.google.gwt.eclipse.core.prefs:
139 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
140 (DetailsActivity.createLayout):
141 (DetailsActivity.setData):
142 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
144 (DetailsCell.DetailsCell):
145 (DetailsCell.setupWidgets):
146 (DetailsCell.setData):
147 (DetailsCell.getLayoutItem):
148 * src/main/java/org/glom/web/client/ui/details/Group.java:
149 (Group.createChildWidget):
150 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
151 (ConfiguredDocument.getValidListViewLayoutGroup):
152 (ConfiguredDocument.getDetailsLayoutGroup):
153 (ConfiguredDocument):
154 (ConfiguredDocument.updateLayoutItemImages):
155 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
156 (ConfiguredDocumentSet.getDocumentIdForFilename):
157 (ConfiguredDocumentSet):
158 (ConfiguredDocumentSet.addDocument):
159 (ConfiguredDocumentSet.readConfiguration):
160 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
161 (OnlineGlomImages.OnlineGlomImages):
162 (OnlineGlomImages.doGet):
164 (OnlineGlomImages.getImageFromDocument):
165 (OnlineGlomImages.getImageFromDatabase):
166 * src/main/java/org/glom/web/server/Utils.java:
168 (Utils.buildImageDataUrl):
169 (Utils.buildImageDataUrlStart):
170 (Utils.buildLayoutPath):
171 (Utils.parseLayoutPath):
172 * src/main/java/org/glom/web/server/database/DBAccess.java:
173 (DBAccess.convertResultSetToDTO):
174 * src/main/java/org/glom/web/server/libglom/Document.java:
178 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
179 (DocumentTest.TestThread.run):
181 2012-11-15 Murray Cumming <murrayc@murrayc.com>
183 Document: Use a better base64 decoder to read static image data.
185 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
186 getNodeTextChildAsValue(): Use the apache commons base64 decoder
187 instead of the gwt one, because it correctly decodes the strings
188 from g_base64_encode(). It is probably more correct.
189 The newlines might be confusing the gwt decoder.
191 2012-11-14 Murray Cumming <murrayc@murrayc.com>
193 Document: Do not use == to compare strings. Use equals().
195 * src/main/java/org/glom/web/server/libglom/Document.java:
196 == only checks that they are the same object, so it can
199 2012-11-14 Murray Cumming <murrayc@murrayc.com>
201 Document: Add and use public constants for layout names.
203 * src/main/java/org/glom/web/server/libglom/Document.java:
204 Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
205 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
206 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
207 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
208 * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use
209 them here instead of hard-coded the strings repeatedly.
211 2012-11-13 Murray Cumming <murrayc@murrayc.com>
213 Document: Load static text and image items too.
215 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
216 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
217 New LayoutItem classes to represent these layout items.
218 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
219 main text of a LayoutItemText.
220 * src/main/java/org/glom/web/server/libglom/Document.java:
221 load_after_layout_group(): Handle the node types and instantiate the
223 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
224 Add testLayoutItemText() to check that the text is loaded properly.
226 2012-11-13 Murray Cumming <murrayc@murrayc.com>
228 Do not use client.GWT for shared code.
230 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
231 Import shared.GWT instead of client.GWT, which seems to be appropriate.
233 2012-11-12 Murray Cumming <murrayc@murrayc.com>
235 Use image data when recreating databases for testing.
237 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
238 for use locally (not acrosss the network) when recreating databases
240 getValue(): Use it here instead of getImageDataUrl(), noting that
241 this method is only for use when recreating databases.
242 * src/main/java/org/glom/web/server/libglom/Document.java:
243 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
245 2012-11-09 Murray Cumming <murrayc@murrayc.com>
247 OnlineGlomImages: Detect the mime-type (content type).
249 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
250 doGet(): Instead of hard-coding image/png.
252 2012-11-09 Murray Cumming <murrayc@murrayc.com>
254 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
257 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
258 Java Compiler and Java Build path settings in the UI.
260 2012-11-09 Murray Cumming <murrayc@murrayc.com>
262 Use the latest (now stable) version of GWT.
264 * pom.xml: And the latest version of the gwt-maven-plugin.
266 2012-11-08 Murray Cumming <murrayc@murrayc.com>
268 Added an Indonesian translation.
270 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
271 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
272 This is from the new translation in Glom.
274 2012-07-23 Murray Cumming <murrayc@murrayc.com>
276 Details: Show images.
278 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
280 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
281 so it can be used in:
282 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
283 for serving image data.
284 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
286 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
287 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
288 setData(): For image field types, add a GWT Image widget,
289 with the URL that was set in the DataItem.
291 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
292 * src/main/java/org/glom/web/server/database/DBAccess.java:
293 convertResultSetToDTO(): Set the URL for image data, so the client browser
294 can retrieve the image from our new servlet. This uses UriBuilder.
295 Move getPrimaryKeyField to:
296 * src/main/java/org/glom/web/server/libglom/Document.java:
297 Added getTablePrimaryKeyField().
299 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
300 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
301 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
304 2012-07-22 Murray Cumming <murrayc@murrayc.com>
308 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
309 * src/main/java/org/glom/web/client/OnlineGlomService.java:
310 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
311 to gwtGlom, which is more appropriate.
312 This servlet name does not seem to be visible to the client side anyway.
314 2012-07-22 Murray Cumming <murrayc@murrayc.com>
316 Tests: Make the imports of assert*() consistent.
318 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
319 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
320 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
321 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
322 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
323 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
324 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
325 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
326 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
327 * src/test/java/org/glom/web/shared/DataItemTest.java:
329 import static org.junit.Assert.*;
330 which seems fairly common.
334 2012-07-21 Murray Cumming <murrayc@murrayc.com>
336 tests: Move a test that needs a database connection.
338 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
339 Move testGetListViewLayoutGroup() to
340 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
341 because it needs a database connection.
343 2012-07-21 Murray Cumming <murrayc@murrayc.com>
345 tests: Use @BeforeClass on tearDown().
347 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
348 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
349 This avoids leaking a postgres process in SelfHostExampleTest.
351 2012-07-21 Murray Cumming <murrayc@murrayc.com>
353 tests: Test translations more.
355 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
356 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
357 Test titles in the non-default locale.
359 2012-07-21 Murray Cumming <murrayc@murrayc.com>
361 tests: Add SelfHostConfiguredDocumentTest
363 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
364 username and password, for use by ConfiguredDocument.
365 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
366 This tests some of the ConfiguredDocument API that requires a database connection.
368 2012-07-21 Murray Cumming <murrayc@murrayc.com>
370 Document: Load title translations and test them.
372 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
373 of titles. I am surprised that we do not do this yet.
374 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
375 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
376 Test translations more.
378 2012-07-20 Murray Cumming <murrayc@murrayc.com>
382 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
383 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
384 Set the timeout here too.
386 2012-07-20 Murray Cumming <murrayc@murrayc.com>
388 tests: ConfiguredDocumentTest: Make this pass.
390 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
391 Disable tests that need a database connection.
393 2012-07-20 Murray Cumming <murrayc@murrayc.com>
395 Use Java 1.7 instead of Java 1.6.
397 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
398 to do this twice, at least for Eclipse.
399 This seems OK because it is the current version.
401 2012-07-20 Murray Cumming <murrayc@murrayc.com>
405 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
406 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
407 Avoid using a null Connection.
409 2012-07-20 Murray Cumming <murrayc@murrayc.com>
411 tests: Add a ConfiguredDocument test.
413 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
416 2012-07-20 Murray Cumming <murrayc@murrayc.com>
418 LayoutItemFIeld: getName(): Use the Field if it is set.
420 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
421 getName(): If the full field details have been set, return its name, so that
422 callers do not need to set the name separately.
423 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
424 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
425 so we can count the rows.
427 2012-07-20 Murray Cumming <murrayc@murrayc.com>
429 tests: SelfHoster: Test SqlUtils too.
431 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
432 Retrieve some data and check it too, as in the regular Glom
433 test_selfhosting_new_from_example.cc test.
434 * src/test/java/org/glom/web/server/SelfHoster.java:
435 createConnection(): Make this public.
437 2012-07-20 Murray Cumming <murrayc@murrayc.com>
439 tests: SelfHoster: createConnection(): Do not warn about expected failures.
441 Let the caller say if the connection is expected to fail, to avoid
442 irrelevant error output.
444 2012-07-20 Murray Cumming <murrayc@murrayc.com>
446 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
448 * src/test/java/org/glom/web/server/SelfHoster.java:
449 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
450 due to the inevitable need to retry the connection while the database server
453 2012-07-20 Murray Cumming <murrayc@murray.com>
455 tests: SelfHoster: createConnection(): Set a timeout.
457 * src/test/java/org/glom/web/server/SelfHoster.java:
458 createConnection(): Use setLoginTimeout() because it otherwise seems to take
459 ages to actually return when it fails.
461 2012-07-20 Murray Cumming <murrayc@murrayc.com>
463 tests: SelfHoster: selfHost(): Close the test connection.
465 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
466 When we check that the connection works, close the connection. This seems
467 to not be closed automatically otherwise.
469 2012-07-20 Murray Cumming <murrayc@murrayc.com>
471 Use slf4j-simple to see JDBC errors.
473 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
475 2012-07-19 Murray Cumming <murrayc@murrayc.com>
477 SelfHoster.discoverFirstFreePort(): Close the socket.
479 * src/test/java/org/glom/web/server/SelfHoster.java:
480 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
482 2012-07-19 Murray Cumming <murrayc@murrayc.com>
484 Avoid another code warning in Eclipse Juno.
486 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
487 Do instanceof checks on the FileUtils.listFiles() result and its
490 2012-07-13 Murray Cumming <murrayc@murrayc.com>
492 Avoid some code warnings in Eclipse Juno
494 * src/main/java/org/glom/web/server/libglom/Document.java:
495 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
496 * src/test/java/org/glom/web/server/SelfHoster.java
497 createTextFile(): Make sure that the FileOutputStream is closed.
499 2012-06-22 Murray Cumming <murrayc@murrayc.com>
501 Added OnlineGlomPropertiesTest.
503 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
504 Make sure we never return a null string.
505 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
506 Added tests of the OnlineGlomProperties API, using our sample file.
508 2012-06-20 Murray Cumming <murrayc@murrayc.com>
510 Make OnlineGlomProperties be a normal class.
512 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
513 Move OnlineGlomProperties into its own file to be a regular class:
514 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
515 This makes testing simpler.
517 2012-06-15 Murray Cumming <murrayc@murrayc.com>
519 OnlineGlomServiceImpl.init(): Move some code into a new method.
521 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
522 Create addDocument().
524 2012-06-15 Murray Cumming <murrayc@murrayc.com>
526 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
528 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
529 OnlineGlomProperties.getKey(): Make this more robust by moving the
530 check for *.*.filename to here.
532 2012-06-15 Murray Cumming <murrayc@murrayc.com>
534 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
536 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
537 init(): Move knowledge of the config file format into the
538 OnlineGlomProperties inner class.
540 2012-06-15 Murray Cumming <murrayc@murrayc.com>
542 SelfHostExampleTest: Make sure we cleanup on failure.
544 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
545 the use of cleanup() to a tearDown() JUnit method.
549 2012-06-12 Murray Cumming <murrayc@murrayc.com>
551 ConfiguredDocument: Add a primary key to portals at least once.
553 * src/main/java/org/glom/web/server/ConfiguredDocument.java
554 updatePortalsExtras): Fix a typo so that we add the primary key
555 column at least once.
556 This is a fix for the previous commit:
557 ConfiguredDocument: Do not add a primary key to portals each time.
559 2012-06-08 Murray Cumming <murrayc@murrayc.com>
561 SelfHoster: Avoid some compiler warnings.
563 * src/test/java/org/glom/web/server/SelfHoster.java
564 executeCommandLineAndWait():
565 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
566 the now-unused streams for stdout and stderr from the command Processes.
567 These are not used because readln() hangs while waiting for a new line,
568 where there may be no next line. The commented out code is still there
569 to help us figure out how to do this properly.
571 2012-06-08 Murray Cumming <murrayc@murrayc.com>
573 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
575 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
576 Make this actually test the cloning again, though it is not very useful
577 now that we do not use the part that had a problem with cloning before.
579 2012-06-08 Murray Cumming <murrayc@murrayc.com>
581 SelfHoster: Keep trying pg_ctl after starting postgres.
583 * src/test/java/org/glom/web/server/SelfHoster.java
584 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
585 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
586 regular Glom. This seems mad but it seems to work because the first
587 command would fail if pg_ctl would eventually fail.
589 2012-06-08 Murray Cumming <murrayc@murrayc.com>
591 SelfHoster: Wait until the server is really ready.
593 * src/test/java/org/glom/web/server/SelfHoster.java
594 selfHost(): Attempt the connection after starting the server, retrying
595 a few times if necessary, so that the server is really ready already when
596 we return from this method.
597 The regular Glom code does this too because pg_ctl reports success too soon.
599 2012-06-08 Murray Cumming <murrayc@murrayc.com>
601 ConfiguredDocument: Do not add a primary key to portals each time.
603 * src/main/java/org/glom/web/server/ConfiguredDocument.java
604 updatePortalsExtras(): Only add an extra primary key field if there is
605 none, to avoid adding one each time we retrieve the details layout from the
607 This should fix bug #676986 (Ben Konrath)
609 2012-05-25 Murray Cumming <murrayc@murrayc.com>
611 Document.load(): Support version 7 documents.
613 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
614 database_title attribute if the title attribute is not there.
617 2012-05-24 Ben Konrath <ben@bagu.org>
619 Add configuration for auto-generating mvn:i18n from with Eclipse.
621 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
623 2012-05-24 Murray Cumming <murrayc@murrayc.com>
625 Update translations, adding French.
627 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
628 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
629 Add a French translation, using the translation from Glom.
631 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
632 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
633 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
634 Update these based on the translations from Glom.
636 2012-05-24 Murray Cumming <murrayc@murrayc.com>
638 SelfHoster: Add some debug println messages to help when things fail.
640 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
641 System.out.println() lines.
643 2012-05-23 Murray Cumming <murrayc@murrayc.com>
645 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
647 * src/test/java/org/glom/web/server/SelfHoster.java:
648 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
649 instance) instead of just /usr/bin (as on Fedora). Check the result when
652 2012-05-23 Murray Cumming <murrayc@murrayc.com>
654 Remove LayoutItemPortal.get/setNavigationTable().
656 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
657 Remove get/setNavigationTable(), which is only a cache, because it is not
658 used, and does not need to be used, because that decision should be made on
660 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
661 updatePortalsExtras():
662 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
663 getNavigationRecord():
664 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
667 2012-05-21 Murray Cumming <murrayc@murrayc.com>
669 Initial self-hosting for tests.
671 * pom.xml: Change the scope for log4j, to hopefully make it
672 available to the test code which uses it indirectly via jOOQ.
673 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
674 self-hosting, though we only use it for testing.
676 * src/main/java/org/glom/web/server/libglom/Document.java:
677 example rows: Use a map instead of a list for each row of values,
678 so we know what field they are for, instead of relying on the sequence
679 being correct. This is not very efficient, but it does not really need
681 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
682 testReadTableExampleRows(): Adapted.
684 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
685 that returns an Object, for generic use. Note that Object seems to be
686 the implicit base even of double.
687 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
688 for use in CREATE TABLE SQL queries.
689 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
690 to do self-hosting of PostgreSQL databases via its command-line
691 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
692 backends/postgres_self.cc. This is incomplete - it needs more
693 warnings about failures and it needs to clean up properly when things
695 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
696 test of this new class.
698 2012-05-21 Murray Cumming <murrayc@murrayc.com>
700 Document: loading example data: Handle exceptions.
702 * src/main/java/org/glom/web/server/libglom/Document.java:
703 DateFormat.parse() and Double.valueOf() can throw exceptions, though
704 Eclipse did not warn about that.
706 2012-05-20 Murray Cumming <murrayc@murrayc.com>
708 Document: load(), save(): Handle the example rows.
710 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
712 * src/main/java/org/glom/web/server/libglom/Document.java:
713 load(), save(): Load and save the example rows, though the date, time
714 and image types are not handled properly yet.
715 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
716 Add testReadTableExampleRows() just to check that something is read.
718 2012-05-20 Murray Cumming <murrayc@murrayc.com>
720 Document: Add save().
722 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
723 Added getTranslationsMap() for use while saving.
724 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
725 Adedd getUseDefaultFormatting() for use while saving.
726 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
727 and several private methods that it uses.
729 This will be useful while testing via self-hosting.
730 It is not complete, but should be complete enough for testing.
732 2012-05-17 Murray Cumming <murrayc@murrayc.com>
734 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
736 * src/main/java/org/glom/web/client/OnlineGlomService.java
737 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
738 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
739 Remove getSortedListViewData() and getSortedRelatedListData(), adding
740 the sort column index and ascending bool to the regular method.
741 Instead, a sort column index of -1 now means no sort.
742 This is less explicit, but it's fairly simple, reduces the amount of
743 code, and makes the OnlineGlomService API slightly smaller.
744 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
745 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
747 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
748 getListViewData(), getRelatedListData():
749 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
750 getListViewData(), getRelatedListData():
751 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
753 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
755 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
760 2012-05-16 Murray Cumming <murrayc@murrayc.com>
762 Use translations for top-level groups too.
764 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
765 updateTitlesForLocale(): Use the translation for the group
766 as well as for child items.
770 Just recompiled to fix a problem in the released .tar.gz file.
774 2012-05-15 Murray Cumming <murrayc@murrayc.com>
776 Corrections to navigation to related records.
778 * src/main/java/org/glom/web/client/OnlineGlomService.java:
779 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
780 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
781 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
782 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
783 relationship name, because the relationship name is not necessarily unique
785 TOOD: This is inefficient, because it passes the whole list of
786 child field items back to the server, but it is more correct, and happens
787 to fix a bug with the primary key being lost after a few navigations.
788 There is probably a chance to make this more efficient anyway in some
791 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
792 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
793 * src/main/java/org/glom/web/server/ConfiguredDocument.java
794 * src/main/java/org/glom/web/server/database/DBAccess.java
795 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
796 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
799 2012-05-15 Murray Cumming <murrayc@murrayc.com>
801 Fix the use of translations.
803 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
804 Add updateTitlesForLocale().
805 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
806 Call it to discard unwanted translations and to make getTitle() return
807 the wanted translation wihout the need for the client code to specify a locale.
808 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
809 getTitle(): Fallback to the original title, as libglom does.
811 2012-05-15 Murray Cumming <murrayc@murrayc.com>
813 Document: Correctly report the number of available translation locales.
815 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
816 the available locale IDs list.
817 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
818 testLocales: Test this.
820 2012-05-15 Murray Cumming <murrayc@murrayc.com>
822 SqlUtils: Use camelCase.
824 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
825 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
826 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
827 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
828 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
829 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
831 2012-05-15 Murray Cumming <murrayc@murrayc.com>
833 Use jOOQ's tableByName() and fieldByName.
835 * pom.xml: Use jOOQ 2.3.1 to get the new API.
836 * src/main/java/org/glom/web/server/SqlUtils.java:
837 build_sql_select_step_with_where_clause(), .createField(),
838 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
839 so we can get correct quoting and escaping. Thanks to Lukas Eder for
840 adding this, and other things, to jOOQ.
842 2012-05-15 Murray Cumming <murrayc@murrayc.com>
844 SqlUtils: Remove the Connection parameters.
846 * src/main/java/org/glom/web/server/SqlUtils.java:
847 build_sql_select_with_key(), build_sql_select_with_where_clause(),
848 createSelect(), build_sql_select_step_with_where_clause(),
849 build_sql_count_select_with_where_clause(),
850 build_sql_select_count_rows(): Remove the Connection parameter because
851 jOOQ does not actually need a connectionwhen it is just used to build
853 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
855 * src/main/java/org/glom/web/server/ReportGenerator.java:
857 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
859 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
860 Constructor, getListData(), getResultSizeOfSQLQuery():
861 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
862 getSelectQuery(), getCountQuery():
863 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
864 getSelectQuery(), getCountQuery():
865 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
866 getNavigationRecord(): Adapted.
868 2012-05-14 Murray Cumming <murrayc@murrayc.com>
872 * src/main/java/org/glom/web/server/SqlUtils.java:
873 get_find_where_clause_quick(): Use a comparison of
874 lowercase values, instead of a simple equals. Regular Glom
875 uses the PostgreSQL ILIKE operator but jOOQ does not
876 support that just yet, though it will soon.
878 2012-05-14 Murray Cumming <murrayc@murrayc.com>
880 TableToViewDetails: Use a real serialization ID.
882 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
883 Though this does not fix the serialization problem.
885 2012-05-12 Murray Cumming <murrayc@murrayc.com>
887 Added LayoutItemPortalDeepCloneTest.
889 2012-05-11 Murray Cumming <murrayc@murrayc.com>
891 Make navigation work again.
893 * src/main/java/org/glom/web/server/libglom/Document.java:
894 Add getLayoutItemFieldShouldHaveNavigation().
895 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
896 Replace get/setAddNavigation() with the partly-existing
897 get/setNavigationTableName(), with an empty string being no navigation,
898 because this is simpler. Use the new
899 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
901 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
902 Add updateFieldsExtras() and call setNavigationTableName in it.
903 getDetailsLayoutGroup(),
904 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
905 createLayout(): Adapted.
906 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
907 Constructor: Adapted.
909 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
910 Replace get/setAddNavigation() with get/setNavigation(), returning a
911 TableToViewDetails class with both the table name and UsesRelationship,
912 because both are need. The previous code used java-libglom's output
913 variable (strangely, via sharedptr) to return both, but we cannot really
915 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
916 getNavigationRecord(): Adapt. However, we cannot actually use the cache
917 here because it somehow gets set to null during deepCopy(). I must test this.
918 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
919 testGetSuitableTableToViewDetails(): Adapted.
921 TODO: Find out why deepClone() is not quite working.
923 2012-05-11 Murray Cumming <murrayc@murrayc.com>
925 DBAccess: Simplify the retrievel of full field details.
927 * src/main/java/org/glom/web/server/database/DBAccess.java
928 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
929 because the Document loading should have done this.
931 2012-05-11 Murray Cumming <murrayc@murrayc.com>
933 Document: Correct loading of doubly-related layout fields.
935 * src/main/java/org/glom/web/server/libglom/Document.java:
936 loadUsesRelationship(): Actually set the related relationship, instead
937 of only setting it if it's not found.
939 2012-05-09 Murray Cumming <murrayc@murrayc.com>
941 Replace all appearances of Colour with color.
943 Because US English is dominant.
945 2012-05-09 Murray Cumming <murrayc@murrayc.com>
947 Use colors in HTML format, solving a warning about an unused function.
949 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
950 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
951 Add *asHTMLColor() versions of methods.
952 TODO: However, we should create and cache the results on the server.
953 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
954 * src/main/java/org/glom/web/client/ui/list/ListTable.java
955 * src/main/java/org/glom/web/server/ConfiguredDocument.java
956 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
957 Use the asHTMLcolor() versions.
959 2012-05-09 Murray Cumming <murrayc@murrayc.com>
961 ListViewTable: Constructor: Take the table name as a parameter.
963 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
964 Constructor: Take the tableName, and set the member variable, because
966 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
967 setCellTable(): Pass the table name.
968 This makes navigation to non-default tables work again. I don't know
969 why it worked before in the master branch.
971 2012-05-07 Murray Cumming <murrayc@murrayc.com>
973 ConfiguredDocument: Restore correct addition of hidden primary key items.
975 * src/main/java/org/glom/web/client/ui/list/ListTable.java
976 (ListTable.createCellTable): Uncomment out the check for the hidden
978 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
979 add primary key items for top-level lists and portals, as before,
980 instead of adding them to each group.
981 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
982 Actually implement the extra methods such as setHiddenPrimaryKey() and
983 comment that these are used only for top-level list groups and in portals.
984 This strangeness suggests even more that this should not be squeezed
985 into the LayoutGroup class.
987 2012-05-07 Murray Cumming <murrayc@murrayc.com>
989 Fix Formatting loading.
991 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
992 getFormattingUsed(): Remove the duplicate Formatting member variable
993 in favour of the one from the base class.
994 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
995 Initialize a new Formatting instead of using null by default, so we
996 have some defaults, instead of having to initialize one later just to
997 get the same defaults. This also makes loading of formatting from the
998 document work, because that expected a non-null.
1000 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1002 RelatedListTable: Make sure that the tableName is set.
1004 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1005 Constructor: Take the tableName so it is available later. Otherwise,
1006 the server assumes that we mean the default table and cannot find the
1008 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1009 setData(): Pass the tableName to the RelatedListTable constructor.
1011 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1015 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1016 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
1017 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1019 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1021 * src/main/java/org/glom/web/server/database/DBAccess.java:
1022 convertResultSetToDTO(), getPortal():
1023 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1025 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1026 Add checks for null objects and out of range access, with log messages to
1027 give hints so we can fix these properly.
1029 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1031 Portals: some corrections.
1033 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1035 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1036 constructor: Use getRelationshipNameUsed() instead of getName(), because
1037 that is what is meant.
1038 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1039 getFromField(): Fix a typo, to get the field name, not the table name.
1040 * src/main/java/org/glom/web/server/database/DBAccess.java:
1041 getPortal(): Fix a typo that stopped this from working.
1043 2012-05-07 Murray Cumming <murrayc@murrayc.com>
1045 LayoutItemPortal: Also override getTitleOriginal().
1047 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1048 This lets the base getTitle() with no parameters work.
1049 TODO: Test this properly.
1051 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1053 LayoutItemPortal: getTitle*(): Use the relationship title.
1055 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1057 LayoutItemField: Fix loading of custom titles.
1059 * src/main/java/org/glom/web/server/libglom/Document.java
1060 loadDataLayoutItemField(): The title, if any, instead of the field
1061 title, is stored in a title_custom node. Load it from there.
1062 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
1064 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
1065 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
1066 getTitle*() overrides.
1067 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1070 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1072 LayoutItemField: Fall back to field titles, so some are really shown.
1074 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
1075 Override getTitleOriginal() and getTitle(), as in java-libglom.
1076 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1077 Test this behaviour.
1079 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1081 Correct use of setExpectedResultSize().
1083 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1084 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
1085 Use setExpectedResultSize only on top-level groups (for instance, the
1086 list layout) or on child portals (in details views).
1087 Use the correct table name for portals to avoid SQL errors.
1088 Update the expected counts when returning cached layouts.
1090 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1092 Document: Interpret no group column count as 1.
1094 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
1095 default, though we now check for this in the UI code anyway.
1097 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1101 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1103 Translatable: Use Hashmap instead of Treemap because GWT supports it.
1105 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
1106 The use of Treemap lead to this error from async methods, with no
1108 "The response could not be deserialized"
1110 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1112 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
1114 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
1115 when using the Google -> GWT Compile, or
1116 g toolbar button -> GWT Compile Project... feature in Eclipse.
1118 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1120 ListTable.addColumn(): Protect against a null Formatting.
1122 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
1123 Create a default Formatting if it is null, because that is the simplest
1126 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1128 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
1130 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1131 updateLayoutGroup(): Check that the field is not null.
1133 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1135 ListViewImpl: Protected against a bad cast error.
1137 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1138 onEnterKeyDown(): Do not cast without an instanceof check.
1140 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1142 ListTable: Protect against an out of range error.
1144 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1145 createCellTable(): This is unlikely, but can happen while debugging.
1147 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1149 AsyncMessage onFailure() callbacks: Log the exception message.
1151 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1152 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1153 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1154 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1155 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1156 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1157 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1158 These are useful clues when something is wrong.
1160 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1162 ConfiguredDocument: Avoid a null dereference.
1164 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1165 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
1166 details maps are created.
1168 2012-05-06 Murray Cumming <murrayc@murrayc.com>
1170 Document: Correct the port number parsing.
1172 * src/main/java/org/glom/web/server/libglom/Document.java:
1173 This lets us actually connect to the database and show the document.
1175 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1179 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
1180 user-interaction, asking us to load a temporary URL in a browser.s
1181 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
1182 which is apparently necessary for testing the service. See the comment.
1183 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1184 Show the exception, if any. This is how I saw the 404 in the HTML in
1187 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1189 DocumentTest: Move the .glom files into the resources directory.
1191 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1192 URI via getResource().
1194 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1196 Document: Remove the FieldIdentifies inner class.
1198 * src/main/java/org/glom/web/server/libglom/Document.java: We only
1199 use the Relationship (though the same function in libglom is maybe
1200 used in other ways) and so this removes a compiler warning.
1202 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1204 Document.load() Remove the error code parameter.
1206 * src/main/java/org/glom/web/server/libglom/Document.java: load():
1207 Remove the parameter. We do not set it yet and it could never have
1208 worked as an output parameter (though maybe it did in java-libglom).
1209 We could use an exception if we really want the failure reason.
1210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1212 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1213 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1215 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1217 Make some inner classes static.
1219 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1221 * src/main/java/org/glom/web/server/ReportGenerator.java
1222 * src/main/java/org/glom/web/server/libglom/Document.java
1223 Make all inner classes static that can be static.
1225 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1227 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1229 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1230 init(): We do not use java-libglom any more.
1232 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1234 Remove mentions of java-libglom.
1236 * README: Remove mention of java-libglom, because it no longer needed.
1237 * utils/build-onlineglom-war.sh:
1238 * utils/check-and-recover-tomcat.py:
1239 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1240 useful. Building is now far easier, with no need for jhbuild.
1242 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1244 Fix the build (mvn package)
1246 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1247 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1248 Otherwise the GWT Java->Javascript compilation fails with just this
1249 error, during mvn package or when attempting to view in a browser,
1250 in the GWT developer mode in Eclipse.
1252 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1253 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1254 [INFO] Compiling module org.glom.web.OnlineGlom
1255 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1256 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1257 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1258 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1259 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1260 [INFO] [ERROR] Cannot proceed due to previous errors
1262 It has taken me 2 days to find out what was causing that. After reducing
1263 the code, the compiler eventually showed me the full error message.
1265 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1267 ConfiguredDocument: Cache the cloned and stripped layouts.
1269 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1270 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1271 layout in a map, so we can retrieve it again without rebuilding it.
1273 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1275 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1277 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1279 libglom classes: Implement some auto-generated emthods.
1281 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1283 Add GwtTestOnlineGlomService.
1285 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1286 However, this (and the other GwtTest*) does not seem to run during
1289 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1291 Remove use of unsupported features from client code.
1293 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1294 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1295 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1296 Use our client version of StringUtils instead of the apache commons one.
1298 However, the GWT Javascript compliation still fails.
1300 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1302 Add a Field class and implement some loading of it in Document.
1304 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1306 Initial Document loading implementation, instead of libglom.
1308 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1309 and Translatable classes, and adapt the rest of the code to use them.
1310 However, this is still missing Layout and Field classes and loading.
1312 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1314 Use of jOOQ: Move Field creation into a utility method.
1316 * src/main/java/org/glom/web/server/SqlUtils.java:
1317 This lets us improve it more easily.
1319 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1321 Use of jOOQ: Improve the code to COUNT a sub-select.
1323 * src/main/java/org/glom/web/server/SqlUtils.java:
1324 Move initial query creation into
1325 build_sql_select_step_with_where_clause().
1326 build_sql_select_count_rows(): Use the jOOQ API instead of
1327 concatentating text, because a jOOQ Select*Step is a TableLike,
1328 which is what from() takes.
1330 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1332 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1334 * pom.xml: Depend on jooq.
1335 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1336 methods with jOOQ, based on the C++ implementations in libglom,
1337 with some changes to the logic required by jooQ.
1338 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1340 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1341 * src/main/java/org/glom/web/server/ReportGenerator.java:
1342 * src/main/java/org/glom/web/server/SqlUtils.java:
1343 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1344 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1345 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1346 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1347 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1348 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1349 because jOOQ needs that, though it seems unnecessary.
1351 This is not quite finished. Ideally jOOQ would help us to build
1352 table_name.field_name names, quoting and escaping them properly.
1353 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1355 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1357 Move use of Glom.build_sql*() into a new SqlUtils class.
1359 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1360 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1361 but this will make it easier to start using something other than
1362 libglom or SqlBuilder.
1364 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1366 Update the project URL.
1368 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1370 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1372 Main layout: Use a FlowTable instead of absolute positioning.
1374 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1375 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1376 child panels/widgets must have an absolute position. But that is annoying, so
1377 this adds a FlowTable and puts the child panels in there.
1379 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1381 GwtTestOnlineGlom: Comment out unused code.
1383 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1384 Eclipse has started to say that some code is unused.
1386 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1388 Update to the latest versions of dependencies.
1390 * pom.xml: Update version numbers of dependencies to the latest
1392 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1393 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1394 * src/main/java/org/glom/web/server/ReportGenerator.java:
1395 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1396 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1397 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1399 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1400 Modify the imports where necessary.
1402 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1404 Style: Remove overflow:hidden from searchbox
1406 * src/main/webapp/style.css: Because this pushes the Back To Link
1407 label/link on to the next row, which is then hidden due to the
1408 hard-coded (in ems) height.
1410 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1412 Remove some duplicate code.
1414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1415 getDocumentInfo(): This must have been duplicated during the merge from the
1420 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1422 Reports: Localize the waiting for report message.
1424 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1425 start(): Get the message from the contants.
1426 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1427 Add the string here.
1428 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1429 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1430 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1431 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1432 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1433 Update these files with the English text for newer strings for now.
1435 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1437 Reports: Show a message while waiting for the report.
1439 * src/main/java/org/glom/web/client/ui/ReportView.java
1440 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1441 Add setWaitingText(), to show a message saying that we are
1442 waiting for the report to be ready.
1443 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1444 start(): Call setWaitingText() before calling the async
1447 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1449 ReportGenerator: Specify date and time formats.
1451 * src/main/java/org/glom/web/server/ReportGenerator.java:
1452 createFieldValueElement(): Use the default (and localized)
1453 short formats, though we still need a way to show 4-digit
1454 years without providing the format for every locale.
1455 * src/main/java/org/glom/web/server/database/DBAccess.java:
1456 convertResultSetToDTO(): Use the short formats here too.
1458 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1460 ReportGenerator: Use the correct numeric formatting.
1462 * src/main/java/org/glom/web/server/ReportGenerator.java
1463 createFieldExpression(), createFieldValueElement(): Take the
1464 whole LayoutItem_Field instead of just the field name, so
1465 we have access to the formatting.
1466 createFieldValueElement(): Use JRTextField.setPattern() to
1467 specify the numeric formatting, with the help of a
1468 regular DecimalFormat.
1470 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1472 ReportGenerator: Avoid showing null for group by titles.
1474 * src/main/java/org/glom/web/server/ReportGenerator.java
1475 generateReport(): Use setBlankWhenNull() on the field title
1476 style too, because this is used for values in group by
1479 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1481 ReportGenerator: Add a colon to titles in vertical groups.
1483 * src/main/java/org/glom/web/server/ReportGenerator.java
1484 addFieldToDetailBandVertical(): Pass true for the withColon
1487 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1489 ReportGenerator: Simplify the code by using Position more.
1491 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1493 Reports: Support vertical groups, roughly.
1495 * src/main/java/org/glom/web/server/ReportGenerator.java:
1496 addToReport(): Rename to addGroupToReport() and, if necessary,
1497 call the new addVerticalGroupToReport() method.
1498 createFieldValueElement(): Let the caller specify the Y position
1501 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1503 Reports: Allow a second report to be shown.
1505 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1506 clear(): Do not remove the HTML widget, which broke the whole layout.
1508 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1510 Locales drop-down: Show that we use English by default.
1512 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1513 fillView(): When we use English, just because that is the default, when
1514 no locale is specified, show that in the Locales drop-down instead of
1515 just showing the first item.
1517 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1519 Unselect the Report/Locale/Table combo item when appropriate.
1521 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1522 setPlace(): clear reportName if this is not a ReportPlace.
1523 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1524 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1525 When the provided name is empty, unselect all items, so that none are
1526 indicated. This uses a for loop because I cannot find a single method
1529 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1531 Report: Give the user a way to get back to the list.
1533 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1534 start(), setPlace(): Show the Back To List link on reports, and also
1535 interpret selecting the empty report item as back to list.
1537 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1539 Really show the selected Report name.
1541 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1542 setPlace(): Store the reportName here, if it is that kind of Place.
1543 fillView(): Set the selected Report after filling the list of reports.
1544 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1545 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1546 null Strings, though we need some way to unselect all ListBox items
1549 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1551 ReportGenerator: Try to avoid some problems.
1553 * src/main/java/org/glom/web/server/ReportGenerator.java
1554 addField(): Try to avoid duplicates, and avoid using a null
1557 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1559 Reports: Use quickFind.
1561 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1562 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1563 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1564 getReportHTML(): Add a quickFind parameter.
1565 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1566 start(): Pass the quickFind parameter.
1567 * src/main/java/org/glom/web/server/ReportGenerator.java
1568 generateReport(): Take a quickFind parameter.
1570 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1572 ReportPlace: Actually use the report name.
1574 * src/main/java/org/glom/web/client/place/ReportPlace.java
1575 getPlace(): Do not assign the report name to the quickfind.
1577 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1579 Show java.library.path when complaining.
1581 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1582 init(): When telling us to check java.library.path, show the
1585 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1587 ReportGenerator: Do not show nulls.
1589 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1591 ReportGenerator: Make the title font larger.
1593 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1595 ReportGenerator: Put field titles inside groups, if there are groups.
1597 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1599 ReportGenerator: Take the Report itself instead of the name and group.
1601 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1602 Remove getReportLayoutGroup().
1603 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1604 getReportHTML(): Pass the report instead
1605 of its name and layout group.
1606 * src/main/java/org/glom/web/server/ReportGenerator.java
1607 generateReport(): Use the report object to use the title
1608 instead of the name.
1610 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1612 ReportGenerator: Remove designBand parameters.
1614 * src/main/java/org/glom/web/server/ReportGenerator.java:
1615 Make designBand a class member instead of passing it to all
1618 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1620 ReportGenerator: Add lines, a bit like in the desktop version.
1622 * src/main/java/org/glom/web/server/ReportGenerator.java
1623 addToReport(): Use JRDesignLine.
1625 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1627 ReportGenerator: Correct the title positions and use some bold style.
1629 * src/main/java/org/glom/web/server/ReportGenerator.java:
1630 Break the code up into reusable functions, correct the placement of
1631 titles, and use normal/bold styles as in the reports in the desktop
1634 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1636 ReportGenerator: Add a header band to show the field titles.
1638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1639 getReportHTML(): Pass the localeId to the ReportGenerator
1641 * src/main/java/org/glom/web/server/ReportGenerator.java
1642 constructor: Take the localeID so we can get translated field
1644 generateReport(), addToReport(), addFieldToBand(): Add field
1645 titles in a column header band.
1647 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1649 Reports drop-down list: Some improvement.
1651 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1652 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1653 Adedd setSelectedReport(),
1654 setReportList(): Add a blank line so that the user can select the
1656 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1657 start(): Show the current report by calling setSelectedReport().
1658 This does not seem to work yet.
1660 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1662 DetailsActivity, ListActivity: Move some variables into a base class.
1664 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1665 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1666 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1667 the clientFactory, documentID, tableName and authenticationPopup into
1668 a base class, to avoid duplication.
1670 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1672 Translate the Reports label.
1674 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1675 Get the "Reports" label string from the constants.
1676 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1677 perties: Add Reports to the constants.
1679 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1681 Reports: Implement grouping.
1683 * src/main/java/org/glom/web/server/ReportGenerator.java:
1684 Handle LayoutItem_GroupBy items and try to do the right thing
1685 with JRDesignGroup. It seems to work.
1687 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1689 Actually show some data with JasperReports.
1691 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1692 getReportHTML(): Move most code into a ReportGenerator class.
1693 * src/main/java/org/glom/web/server/ReportGenerator.java:
1694 Recurse into sub-groups, adding fields to the JasperDesign's details
1695 band. Note that we must set an arbitrary width and height, or it just
1696 will not show any data.
1698 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1700 Reports Chooser: Show the titles, not the names.
1702 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1703 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1704 and the names as the values.
1705 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1706 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1707 group now that we provide the report name, so it should always
1710 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1712 Depend on jasperreports.
1714 * pom.xml: Add the dependency. My plan is to use this on the
1717 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1719 Implement navigation to report places.
1721 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1722 start(): Do not bother to handle all events here.
1723 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1724 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1725 Added getSelectedReport().
1726 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1727 .java: start(): When handling a change to the reports chooser,
1728 call getSelectedReport() and goTo() its ReportPlace.
1729 * src/main/java/org/glom/web/client/ui/ReportView.java
1730 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1731 Added setReportHTML() which puts the html in a gwt HTML widget.
1732 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1733 getReportHTML(): Return "TODO" just to show that this works.
1735 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1737 Make ReportPlace usable.
1739 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1740 Mention ReportPlace.
1741 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1742 Correct the @prefix annotation.
1744 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1746 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1748 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1749 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1750 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1751 Change getReportLayout() to getReportHMTL() because we will not need to
1752 parse or render the report layout on the client side.
1753 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1754 getReportLayout(): Return the libglom LayoutGroup type because we will
1755 not need to convert to a shared type, because this will not be used on
1757 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1760 Note that there is still no implementation for this.
1763 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1765 Add a (empty) Report Place, View, and Activity.
1767 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1769 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1770 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1771 this into a superclass:
1772 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1773 and also use it as the base of this new ReportPlace:
1774 * src/main/java/org/glom/web/client/place/ReportPlace.java
1776 * src/main/java/org/glom/web/client/ui/ReportView.java
1777 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1778 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1779 Add these, containing mostly boiler-plate for now.
1781 * src/main/java/org/glom/web/client/OnlineGlomService.java
1782 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1783 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1785 Add API to get the LayoutGroup for the report.
1787 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1789 Add and fill a Reports drop-down list box.
1791 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1793 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1794 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1796 Added getReports(document, table, localeID), calling
1797 ConfiguredDocument.getReports().
1798 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1799 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1800 Added setReportsList() and a list widget.
1801 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1802 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1807 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1809 Translations: Add Esperanto.
1811 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1812 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1813 properties: Add this translation because someone took the time to make it.
1815 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1817 Adapt to the java-libglom 1.21.7 API.
1819 * src/main/java/org/glom/web/server/ReportGenerator.java:
1820 addToReport(): get_group_secondary_fields() is now
1821 get_secondary_fields().
1824 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1826 Use the latest java-libglom version.
1828 * pom.xml: Use java-libglom 1.21.7.
1830 2012-03-03 Ben Konrath <ben@bagu.org>
1832 Display date and time in details view.
1834 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1836 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1838 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1840 Require the latest java-libglom.
1842 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1844 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1846 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1848 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1849 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1850 an empty quickfind string. I also corrected libglom to create only
1851 empty where clauses for empty quickfind strings, but this avoids the
1854 2012-02-24 Ben Konrath <ben@bagu.org>
1856 Improve the tabs in the Notebook widget.
1860 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1862 Translations: Try to translate the strings.
1864 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1865 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1866 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1867 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1868 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1869 Take the Open translation from GTK+'s .po files.
1870 Take the Details translation from Glom's po files.
1871 I have added the other strings to Glom so we can get translations that way:
1872 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1874 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1876 TableSelectionViewImpl: Put the search label and entry in a div.
1878 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1879 Put the search widgets in a FlowTable so that the CSS can be used to
1880 style them while keeping them together.
1881 * src/main/webapp/style.css: Mention the new div.
1883 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1885 Translate more strings in more locales.
1887 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1888 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1889 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1890 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1891 Translate the "Details" and "Open" string too.
1893 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1894 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1895 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1896 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1897 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1898 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1899 Add these new locales as placeholders though they currently contain English.
1901 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1903 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1906 Check the ConfiguredDocument* for null before using it.
1908 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1910 Tell Eclipse about the generated java files.
1912 * .classpath: This lets it find OnlineGlomConstants.java.
1913 It would be nice if Eclipse just used the maven build files.
1915 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1917 Prevent a crash when no locale is specified in the URL.
1919 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1920 Avoid returning a null string, obtained from
1921 Window.Location.getParameter(). This caused a crash when it was
1922 later passed to libglom's API.
1923 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1924 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1925 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1926 guard against future null strings.
1928 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1930 Use the ?locale= query param instead of the &lang= token param.
1932 * src/main/java/org/glom/web/client/place/ListPlace.java
1933 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1934 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1935 Remove the lang token key and value.
1937 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1938 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1939 When the user selects a different locale from the chooser, use
1940 Window.Location.assign() to change the URL, which then causes a reload.
1942 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1943 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1944 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1945 * src/main/java/org/glom/web/client/activity/ListActivity.java
1946 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1947 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1948 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1949 * src/main/java/org/glom/web/client/ui/ListView.java:
1950 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1952 Remove localeID member variables and method/constructor parameters, instead
1953 using Utils.getCurrentLocaleID() when we need a localID to pass to
1956 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1958 Internationalize the UI strings.
1960 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1961 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1962 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1963 because it is unused. Messages are apparently strings that can have
1964 parameters, but we do not need that yet, so Contants will be enough for now.
1965 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1966 to say that we support the en and de locales.
1967 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1968 The original English strings.
1969 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1970 Some German translations of the English strings.
1971 The i18n goal then uses the .properties file to generate an
1972 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1973 returns an implementation that returns the translated strings.
1974 The documentation suggests putting these in src/java/*/client/, but it seems
1975 best to put it in src/resources/*/client/.
1976 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1977 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1978 instead of hard-coding them.
1979 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1980 but that does not seem to stop the build, though it confuses Eclipse.
1982 You can see the translated string by adding ?locale=de to the URL, like so:
1983 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1985 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1987 Improve null/empty String checks.
1989 * pom.xml: Add a dependency on commons-lang, to use
1990 org.apache.commons.lang.StringUtils.
1991 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1992 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1993 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1994 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1995 Use StringUtils.isEmpty().
1997 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1998 StringUtils class with a static isEmpty() function because we
1999 cannot use org.apache.commons.lang.StringUtils in client-side
2000 GWT code because it (apparently) cannot be compiled to javascript.
2001 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2002 * src/main/java/org/glom/web/client/activity/ListActivity.java
2003 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
2004 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2005 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2006 * src/main/java/org/glom/web/client/place/ListPlace.java
2007 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
2008 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
2009 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
2010 * src/main/java/org/glom/web/client/ui/details/Group.java
2011 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
2012 our StringUtils.isEmpty() function.
2014 2012-01-24 Murray Cumming <murrayc@murrayc.com>
2016 Update to the latest java-libglom API.
2018 * pom.xml: Require java-libglom 1.21.4.
2019 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2020 getDocumentInfo(), getListViewLayoutGroup():
2021 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2023 * src/main/java/org/glom/web/server/database/DBAccess.java
2024 getFieldsToShowForSQLQueryAddGroup(),
2025 getPrimaryKeyLayoutItemField(): Replace get_database_title()
2026 with either get_database_title_original() or
2027 get_database_title(localeID).
2029 2012-01-24 Murray Cumming <murrayc@murrayc.com>
2031 ConfiguredDocument: Avoid a null pointer exception.
2033 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2034 Initialize localeID to "" to avoid returning a null String which
2035 causes a crash in java-libglom's swing-generated code.
2037 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2039 Some simple renaming.
2041 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2042 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
2043 for localeChooser. This seems more appropriate and is less ambiguous
2044 particularly in the .css file.
2046 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2048 ConfiguredDocument: Rename the localedID private member variable.
2050 2012-01-23 Murray Cumming <murrayc@murrayc.com>
2052 Adapt to the latest java-libglom API from git master.
2054 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2055 libglom now uses only Vector instead of List, which uses add() instead of
2058 2012-01-22 Murray Cumming <murrayc@murrayc.com>
2060 ConfiguredDocument: Rename the localedID private member variable.
2062 2012-01-20 Murray Cumming <murrayc@murrayc.com>
2064 Build a source tarball with mvn assembly:single
2066 * assembly.xml: Add this file.
2067 * pom.xml: Use the maven-assembly-plugin and tell it to use
2068 our assembly.xml file.
2070 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2072 OnlineGlomServiceImpl: Get .glom files recursively.
2074 * pom.xml: Depend on commons-io from org.apache.commons.
2075 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2076 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
2077 files recursively, and with the easier filter for the extension.
2078 Use org.apache.commons.io.FilenameUtils.removeExtension() to
2079 simplify that code too.
2081 2012-01-19 Murray Cumming <murrayc@murrayc.com>
2083 README: Mention that you must install java-libglom packages separately.
2085 But then it works, because java-libglom is now in the central maven
2088 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2090 locales drop-down: Show the correct selected locale when the URL changes.
2092 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2093 .java: setPlace(): Move some code into fillView().
2095 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2097 locales drop-down: Do not lose the primary key.
2099 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2100 start(): onLocaleChange(): Pass the current primary key value,
2101 instead of an empty value.
2103 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2105 locales drop-down: Do not lose the drop-down selection.
2107 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2108 .java (TableSelectionActivity.fillView): Set the selected locale
2109 after changing the drop-down items (though we do not really need
2110 to change them just because the locale changes.)
2112 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2114 locales drop-down: Change the tables list when this changes.
2116 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2117 .java: TableSelectionActivity.start(): Move the async table titles
2118 retrieval into a private fillView() method and also call this when
2119 the chosen locale changes.
2120 Note that the document title is not actually translatable yet, but
2121 that is a problem that I should fix soon in libglom.
2123 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2125 Improve the placement of the locales drop-down.
2127 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2128 Put the title and locales drop-down in a div (gwt.FlowTable).
2129 * src/main/webapp/style.css: Add magic css properties to make this work.
2130 Also remove the left margin from the title so that it lines up with the
2133 2012-01-18 Murray Cumming <murrayc@murrayc.com>
2135 locales selector: Show human-readable locale titles.
2137 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2138 getDocumentInfo(): Use java.util.Locale to show a real title of
2139 each locale, in the locale's own language.
2141 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2143 Add a language/locale selector drop-down.
2145 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2146 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
2147 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
2148 getDocumentInfo(): Store the available Locales in the DocumentInfo.
2149 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2150 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2151 Add a ListBox to show the available locales. Add getLocaleSelector(),
2152 setLocaleList(), getSelectedLocale(), setSelectedLocale().
2153 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
2154 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
2155 java: Add these classes.
2156 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2157 start(): Fill the locales ListBox. Handle its change event, firing a
2159 setPlace(): Show the selected locale as specified by the URL token.
2160 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2161 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2162 Handle LocaleChangeEvent, going to a new *Place with that locale.
2164 The placement of the ListBox is not pretty, and it currently uses the ID
2165 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
2169 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2171 Search box: Show the search text from the URL token.
2173 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2174 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2175 Add setQuickFindText().
2176 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2177 .java: setPlace(): Store the queryText if the place is a ListPlace,
2178 and call TableSelectionView.setQuickFindText().
2180 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2182 Allow use of translations via, for instance, &lang=de in the URL.
2184 * pom.xml: Use the unstable java-libglom 1.21 version.
2186 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2187 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
2188 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2189 init(): Instead of calling TranslatableItem.set_current_locale()
2190 (now removed), call ConfiguredDocument.setDefaultLocaleID().
2191 However, this is only for default locales, which are not needed to
2192 change the locale in the URL.
2193 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2194 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2195 getSortedRelatedListData(): Add a localeID parameter, so we can get the
2196 layout for a particular locale.
2197 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2198 Add get/setDefaultLocaleID().
2199 getDocumentInfo(), getListViewData(), getRelatedListData(),
2200 getDetailsLayoutGroup(), getListViewLayoutGroup(),
2201 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
2202 localeID parameter, so we can get the layout for a particular locale.
2204 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2205 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2206 * src/main/java/org/glom/web/client/place/ListPlace.java:
2207 Parse and construct a lang parameter too.
2209 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2210 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2211 passed to subsequent methods and constructors.
2212 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2213 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2214 Store the localeID from the *Place and pass it to other constructors
2215 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2217 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2218 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2219 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2220 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2221 * src/main/java/org/glom/web/client/ui/ListView.java:
2222 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2223 Take localeID parameters and pass them to subsequent constructors and
2224 methods, so that the layout is always retrieved for that locale.
2226 This is rather repetitive.
2228 Note that "" means the original (default) locale of the Glom document,
2229 which is usually English.
2231 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2233 Documents: Remove final keyword to fix startup configuration.
2235 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2236 final keywords on the private member variables because that breaks
2237 the startup, apparently (there are warnings) because it stops them
2238 from being serialized. I added these in the previous commit.
2240 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2242 Documents: Add some final keywords.
2244 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2247 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2249 OnlineGlomServiceImpl: Add to overview comments.
2251 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2252 Note that this is where all the document are loaded. They are not
2253 loaded freshly for each page.
2255 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2259 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2260 Add a TextBox for the text of a quick find.
2261 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2263 setBackLink(): Add a String quickFind parameter.
2264 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2265 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2266 to the base interface, because that is how TableSelectionViewImpl is used.
2267 * src/main/webapp/style.css: Add style for the search box and its label.
2269 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2270 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2271 Add these files, based on the existing TableChangeEvent and
2272 TableChangeEventHandlers.
2273 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2274 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2275 a ListPlace() that the user should be taken to.
2276 * src/main/java/org/glom/web/client/activity/ListActivity.java
2277 start(): Handle it here too and adapt the TableChangeEvent handler to
2278 pass the extra "" quickFind parameter to ListPlace.
2279 * src/main/java/org/glom/web/client/place/ListPlace.java:
2280 Constructor: Take an extra String quickFind parameter and store it,
2281 returning it from a new getQuickFind() method.
2282 getToken(): Put the quickFind text in the URL token.
2283 getPlace(): Parse the quickFind text from the URL token.
2284 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2285 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2286 ListPlace constructor.
2287 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2288 .java: start(): Add a Change handler for the TableSelectionView's
2289 TextBox (via its base HasChangeHandlers interface), firing the new
2290 QuickFindChangeEvent.
2291 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2292 pass the extra "" quickFind parameter.
2294 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2295 setCellTable(): Add a String quickFind parameter and pass it to
2296 the ListViewTable() constructor.
2297 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2298 setCellTable() in the base interface, because that is how ListViewImpl
2301 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2302 Add a String quickFind member variable.
2303 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2304 Constructor: Add a String quickFind parameter, storing it in the
2305 base ListTable's member variable.
2306 onRangeChanged(): Pass quickFind to the
2307 OnlineGlomServiceAsync.getSortedListViewData() and
2308 OnlineGlomServiceAsync.getListViewData() methods.
2310 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2311 getListViewData(), getSortedListViewData(): Add a String quickFind
2312 parameter, passing it to ConfiguredDocument.getListViewData().
2313 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2314 Change getListViewData(), getSortedListViewData() in the base interface,
2315 because that is how OnlineGlomServiceImpl is used, via this:
2316 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2317 Change getListViewData(), getSortedListViewData() here too.
2318 This class can apparently be used to asynchronously call methods on
2319 OnlineGlomService, and GWT seems to implement that after recognizing
2320 just the *Async name convention and the extra AsyncCallback parameters.
2322 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2323 getListViewData(): Add a String quickFind parameter, and pass it to
2324 ListViewDBAccess.getData().
2325 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2326 getListData(): Add a String quickFind parameter and pass it to
2328 getSelectQuery(): Add a String quickFind parameter.
2329 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2330 getSelectQuery(): Add a String quickFind parameter and use it with
2331 Glom.get_find_where_clause_quick() to pass a where_clause to
2332 Glom.build_sql_select_with_where_clause(), to actually filter the
2334 getData(): Add a String quickFind parameter, passing it to getListData().
2335 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2336 va: getData(): Pass an empty string to getListData() for the
2337 quickFind parameter.
2339 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2341 ListTable: Minor change.
2343 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2344 createCellTable(): Make this protected instead of public.
2346 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2348 Many files: Use final for the parameters and use the @override attribute.
2350 2012-01-22 Ben Konrath <ben@bagu.org>
2352 Add anchor links for single line text that starts with http, ftp and www.
2356 2012-01-22 Ben Konrath <ben@bagu.org>
2358 Add ellipsis to single line text in details view.
2362 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2364 Remove all javadoc author tags.
2366 Because they are awkward and meaningless when many people touch
2368 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2370 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2372 Revert the COPYING.LESSER to COPYING rename.
2374 Apparently both should be there if it is LGPL.
2376 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2378 *View: Remove unused imports.
2380 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2381 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2382 * src/main/java/org/glom/web/client/ui/ListView.java:
2383 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2384 Remove unused imports, as suggested by Eclipse.
2386 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2388 Move the *View::Presenter types, and some API into one base View.
2390 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2391 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2392 * src/main/java/org/glom/web/client/ui/ListView.java:
2393 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2394 Presenter, setPresenter() and clear() into a shared base interface,
2395 to avoid the unnecessary duplicate Presenter types and to more clearly
2396 show how the *Views share the same structure, even if they are not
2397 used polymorphically.
2399 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2400 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2402 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2403 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2404 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2406 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2409 Feel free to revert this if there is a good reason for the duplicate
2412 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2414 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2416 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2417 a class member instead of a local variable in the method.
2418 This lets us use it to get the view instances, for use in tests.
2419 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2420 beforeOnlineGlom(): Test some more details of the initial view.
2421 Again, this is not very useful.
2423 To really test gwt-glom we will need to start a local postgresql
2424 instance with local data, like the Glom tests in C++.
2426 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2428 pom.xml: Mention the LGPL license.
2430 * pom.xml: Add a licenses section.
2431 * COPYING.LESSER: Move this to COPYING, which
2432 previously contained the GPL. But gwt-glom is all LGPL.
2434 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2436 Add project information to README and pom.xml.
2438 * README: Add a brief description and mention some mvn
2440 * pom.xml: This extra information shows up in mvn site
2443 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2445 Use the latest java-libglom version.
2447 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2449 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2451 GwtTestOnlineGlom: Test a little more.
2453 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2454 protected rather than private, as suggested by the gwt-test-utils
2456 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2457 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2458 Test the initial visibility of the panels.
2460 However, this is not a very useful test.
2461 And I wonder how we should generally test using this idea for an
2462 activity/places app like ours where the real changes happen implicitly
2463 based on the history token/URL.
2465 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2467 Slight modification to *Mapper comments.
2469 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2470 (DataActivityMapper)
2471 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2473 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2475 Remove comments mentioning GIN because they are just copied from
2476 the example code and are apparently not helpful:
2477 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2478 Also change the mention of a class that is only in the example code.
2480 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2482 GwtTestOnlineGlom test: Minor changes.
2484 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2485 Avoid the long qualified class name and modify the comment
2486 because it is now obvious to me that the mocked class is the only
2487 custom one created via GWT.create().
2489 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2491 Tests: Added the beginnings of a test using gwt-test-utils.
2493 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2494 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2495 which tells gwt-test-utils what class will be tested.
2496 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2497 Add a simple (but empty) test case. One class, used by the OnlineGlom
2498 class, is mocked so that it can be created. However, I am not sure
2499 why only this class needs to be mocked.
2501 Note that mockito seems more popular, and clearer, than easymock,
2502 but I have not got that working yet. It might be a matter of the
2505 This test is run during mvn integration-test.
2507 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2509 Tests: Use junit4-style syntax instead of junit3-style.
2511 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2512 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2513 * src/test/java/org/glom/web/shared/DataItemTest.java:
2514 Use the @Test annotation rather than relying on the test*() prefix.
2515 Also no longer implement TestCase, to avoid triggering support for
2516 the junit3-way, which stops the annotations from working.
2517 Change the imports from import junit.framework.* to
2518 import org.junit.*, which is apparently the new way.
2520 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2522 Added a test for ListPlace token parsing and creation.
2524 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2525 This is much the same as DetailsPlaceTest.
2527 I wonder how we could test the other parts of the *Place API.
2529 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2531 DetailsPlace test: Also test getToken() and recreation via getPlace().
2533 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2534 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2535 recreate it, testing the recreated DetailsPlace for the same parameter
2538 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2540 Use the surefire-report plugin.
2542 * pom.xml: This generates a HTML report about the tests in
2543 target/site/surefire-report.html
2544 when you do mvn surefire-report:report. It seems to be popular/normal.
2546 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2548 Added a test for DetailsPlace.
2550 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2551 Test the getPlace() token parsing.
2553 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2555 Added a first unit test.
2557 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2558 * src/test/java/org/glom/web/shared/DataItemTest.java:
2559 This is a silly test but it is just to get things started. Note that
2560 maven/junit finds the test because it looks in src/test by default.
2562 2011-12-22 Ben Konrath <ben@bagu.org>
2564 Change charsetName to "UTF-8" when replacing line breaks.
2566 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2567 that work in Java (such as "UTF8") will not work when compiled to
2570 This fixes a problem with multi-line details view fields that have hard
2571 line breaks. The "License Text" field on this page demonstrates the
2574 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2576 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2578 2011-12-22 Ben Konrath <ben@bagu.org>
2580 Fix another bug with related list navigation.
2582 I've tested all the navigation buttons in all of the related lists
2583 so things should be good now.
2585 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2587 2011-12-22 Ben Konrath <ben@bagu.org>
2589 Fix a crasher when refreshing the list view with the default table.
2591 This crash will also happen when loading the list view with the default
2592 table from a link or bookmark.
2594 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2595 to the main document selection page when the document id hasn't been
2597 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2598 the main document selection page when the document id hasn't been
2600 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2601 values for the details place when the document id hasn't been set.
2602 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2603 values for the list place when the document id hasn't been set.
2605 2011-12-21 Ben Konrath <ben@bagu.org>
2607 Protect against NPE when glom.document.locale is not in config.
2609 This patch protects against an NPE when glom.document.locale is not in
2610 the config file. This NPE will also happen if glom.document.locale is
2613 The patch also updates the error message to display the class name when
2614 the getMessage() returns null. This was happening when the NPE was
2615 thrown and I had "Configuration Error: null". If an NPE is encountered
2616 with this patch, "Configuration Error: NullPointerException " will be
2619 This commit closes this bug:
2621 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2623 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2625 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2627 Rename onlineglom.properties to onlineglom.properties.sample.
2629 * src/main/resources/onlineglom.properties: Rename to:
2630 * src/main/resources/onlineglom.properties.sample:
2631 * src/main/resources/README: And add this file explaining that people
2632 should rename it back when deploying.
2634 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2636 Allow choosing the translation in the .properties file.
2638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2639 init(): Read a glom.document.locale value from the configuration file
2640 and call Glom's TransatableItem::set_current_locale() method.
2641 * src/main/resources/onlineglom.properties: Add a commented-out
2642 example of this new setting.
2644 It would be better to add &lang=de_DE to the URL, but the current
2645 libglom API does not allow us to do this easily. I am working on that.
2647 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2649 Avoid a crash in parsing of token parameters.
2651 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2652 ava: getTokenParams(): Do not crash if a parameter has a key but no
2653 value, and ignore parameters with neither.
2655 2011-12-17 Murray Cumming <murrayc@murayc.com>
2657 History token building/handling: Improve use of token parameters.
2659 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2660 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2661 and buildParamsToken(HashMap), for use by derived classes.
2662 Make the separator private because it is no longer be needed.
2663 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2664 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2665 instead of manual string concatenation.
2666 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2667 of hardcoded indices and awkward splitting code.
2668 * src/main/java/org/glom/web/client/place/ListPlace.java
2669 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2670 instead of manual string concatenation.
2671 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2672 of hardcoded indices and awkward splitting code.
2673 This should fix bug #666420
2675 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2677 Fix a Navgiation->Navigation typo in the code.
2679 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2680 Rename processNavgiation() to processNavigation().
2682 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2684 Fix a seperator->separator typo in the code.
2686 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2687 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2688 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2691 2011-12-15 Ben Konrath <ben@bagu.org>
2693 Cleanup some comments.
2695 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2697 2011-12-14 Ben Konrath <ben@bagu.org>
2699 Replace \n with <br/> for multiline text in the details view.
2701 Vertical scrollbars are added when needed as well.
2703 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2705 2011-12-14 Ben Konrath <ben@bagu.org>
2707 Specify the font for document selection links.
2709 * src/main/webapp/style.css:
2711 2011-12-14 Ben Konrath <ben@bagu.org>
2713 Fix bouncy CellTable while paging.
2715 This doesn't currently work with related list tables in unselected
2718 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2720 2011-12-14 Ben Konrath <ben@bagu.org>
2722 Revamp the appearance of the document selection page.
2724 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2725 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2726 * src/main/webapp/style.css:
2728 2011-12-13 Ben Konrath <ben@bagu.org>
2730 Set navigation button column to the smallest size possible.
2732 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2734 2011-12-13 Ben Konrath <ben@bagu.org>
2736 Change OpenButton nomenclature to NavigationButton.
2738 Using NavigtionButton makes things more generic. Classes, methods and
2739 variables have been changed.
2741 This is a rename-only refactor.
2743 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2744 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2745 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2746 Renamed from OpenButtonCell.
2747 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2748 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2749 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2751 2011-12-12 Ben Konrath <ben@bagu.org>
2753 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2755 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2756 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2757 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2758 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2760 2011-12-12 Ben Konrath <ben@bagu.org>
2762 Update variable names and comments.
2764 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2765 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2767 2011-12-12 Ben Konrath <ben@bagu.org>
2769 Properly initialize numNonEmptyRows variable to zero.
2771 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2772 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2774 2011-12-05 Ben Konrath <ben@bagu.org>
2776 Add latest mockup with HTML tables.
2778 Features of this mockup:
2780 -> HTML table for flowtable
2781 -> HTML table for flowtable column
2782 -> Example of how related lists would look
2783 -> Not using text entries for data items
2785 The current version of Online Glom doesn't use HTML tables for the
2788 This mockup has been sent to the glom-devel mailing list but it's good
2789 to have it here as well.
2791 * mockups/details-view-html-tables.html:
2793 2011-12-05 Ben Konrath <ben@bagu.org>
2795 Remove unnecessary getPrimaryKeyField() method.
2797 getPrimaryKeyFieldForTable(String) has been renamed to
2798 getPrimaryKeyField(String).
2800 * src/main/java/org/glom/web/server/database/DBAccess.java:
2801 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2802 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2804 2011-12-05 Ben Konrath <ben@bagu.org>
2806 Add string representation of TypedDataItem value to conversion error message.
2808 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2809 message was extracted into its own method to avoid duplication.
2811 2011-12-05 Ben Konrath <ben@bagu.org>
2813 Add type checking to navigation primary key value creation.
2815 Create navigation primary key only if the expected type from the Glom
2816 document matches the type returned by the SQL query.
2818 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2820 2011-12-05 Ben Konrath <ben@bagu.org>
2822 Rename a couple of variables in RelatedListNavigation.
2824 This is a rename-only refactor.
2826 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2828 2011-12-05 Ben Konrath <ben@bagu.org>
2830 Move getListLayoutGroup() into getListViewLayoutGroup().
2832 This removes getListLayoutGroup(). It was only being called by
2833 getListViewLayoutGroup().
2835 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2837 2011-12-05 Ben Konrath <ben@bagu.org>
2839 Remove check for LayoutItem_Portal in list table method.
2841 This check is no longer necessary because the method isn't being used
2842 to create the LayoutItemPortal DTO.
2844 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2846 2011-12-05 Ben Konrath <ben@bagu.org>
2848 Properly support related list navigation.
2850 Navigation from the "Repository Analyzer -> Package Scans ->
2851 Dependencies" related table wasn't working because the primary key for
2852 related tables wasn't being set properly. This commit fixes the
2855 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2856 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2857 doesn't set the primary key properly for related list tables.
2858 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2859 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2860 useful for getting the primary key for list view tables and for related
2862 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2863 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2864 Move code to set the primary key for the table from the abstract
2865 ListDBAccess class to ListViewDBAccess as it's only correct for list
2867 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2868 Properly add primary key to related list tables.
2870 2011-12-02 Ben Konrath <ben@bagu.org>
2872 Properly set the horizontal alignment of fields.
2874 This fix is for both the list tables and the details view.
2876 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2877 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2878 to set the horizontal alignment of fields.
2880 2011-12-02 Ben Konrath <ben@bagu.org>
2882 Display currency codes in the details view.
2884 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2886 2011-12-02 Ben Konrath <ben@bagu.org>
2888 Avoid duplicate JNI call.
2890 JNI is not as efficient as pure Java and this is an easy (and small)
2893 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2894 Use previously retrieved value for whereClauseToTableName instead of
2897 2011-12-02 Ben Konrath <ben@bagu.org>
2899 Rename a couple of variables in RelatedListNavigation.
2901 This is a rename-only refactor.
2903 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2905 2011-12-02 Ben Konrath <ben@bagu.org>
2907 Indicate clearly that a mismatched primary key type is a bug.
2909 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2910 warning to error. Add 'This is a bug.' to message.
2912 2011-12-02 Ben Konrath <ben@bagu.org>
2914 Update / fix some comments.
2916 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2918 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2920 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2921 Fix comments. Add some TODOs.
2923 2011-12-02 Ben Konrath <ben@bagu.org>
2925 Enable navigation to details view with string primary key from related list.
2927 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2928 Create a text primary key value when return type of result is
2929 java.sql.Types.VARCHAR.
2931 2011-12-02 Ben Konrath <ben@bagu.org>
2933 Use checkboxes for booleans in the details view.
2935 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2937 2011-12-01 Ben Konrath <ben@bagu.org>
2939 Improve performance of related list height calculation.
2941 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2942 Put code to calculate the expected height in a static initializer so
2943 that that it's only called once.
2945 2011-12-01 Ben Konrath <ben@bagu.org>
2947 Show related list tables in notebooks (again).
2949 Calculate the height of the related list tables so the Notebook can be
2950 set the correct height. The height of the related list table is also needed by
2951 FlowTable to be able decide how to create the layout.
2953 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2954 and set the Portal height based on the height of the related list
2955 table and the Portal container.
2956 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2957 Add method to calculate the height of the related list tables.
2958 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2959 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2960 calculate the height of the Pager widget.
2962 2011-12-01 Ben Konrath <ben@bagu.org>
2964 Use CellTable API for table property instead of setting style on Element.
2966 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2968 2011-12-01 Ben Konrath <ben@bagu.org>
2970 Make ListViewTable and RelatedListTable a consistent height.
2972 The tables are now a consistent height regardless of the contents of
2973 the table. A hidden button is added to empty rows to ensure that the
2974 height of these rows will match the height of rows with data.
2976 A navigation button column is now added to every table. The width of
2977 the navigation column is set to 0px when a RelatedListTable shouldn't
2978 have navigation buttons. This maintains the a consistent row height in
2979 tables that don't show the navigation buttons.
2981 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2982 navigation column when not needed.
2983 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2984 arguments for navigation button to constructor of ListViewTable.
2985 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2986 hidden button for empty data rows.
2987 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2988 arguments for navigation button to constructor.
2989 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2990 create navigation buttons. Add hideNavigationButtons() method.
2991 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2992 arguments for navigation button to constructor.
2994 2011-12-01 Ben Konrath <ben@bagu.org>
2996 Use 'visibility: hidden' in Utils.getWidgetHeight().
2998 This is better choice because hidden elements are invisible, don't
2999 respond to events and are not part of the tab order. They will,