1 2012-01-19 Murray Cumming <murrayc@murrayc.com>
3 README: Mention that you must install java-libglom packages separately.
5 But then it works, because java-libglom is now in the central maven
8 2012-01-18 Murray Cumming <murrayc@murrayc.com>
10 locales drop-down: Show the correct selected locale when the URL changes.
12 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
13 .java: setPlace(): Move some code into fillView().
15 2012-01-18 Murray Cumming <murrayc@murrayc.com>
17 locales drop-down: Do not lose the primary key.
19 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
20 start(): onLocaleChange(): Pass the current primary key value,
21 instead of an empty value.
23 2012-01-18 Murray Cumming <murrayc@murrayc.com>
25 locales drop-down: Do not lose the drop-down selection.
27 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
28 .java (TableSelectionActivity.fillView): Set the selected locale
29 after changing the drop-down items (though we do not really need
30 to change them just because the locale changes.)
32 2012-01-18 Murray Cumming <murrayc@murrayc.com>
34 locales drop-down: Change the tables list when this changes.
36 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
37 .java: TableSelectionActivity.start(): Move the async table titles
38 retrieval into a private fillView() method and also call this when
39 the chosen locale changes.
40 Note that the document title is not actually translatable yet, but
41 that is a problem that I should fix soon in libglom.
43 2012-01-18 Murray Cumming <murrayc@murrayc.com>
45 Improve the placement of the locales drop-down.
47 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
48 Put the title and locales drop-down in a div (gwt.FlowTable).
49 * src/main/webapp/style.css: Add magic css properties to make this work.
50 Also remove the left margin from the title so that it lines up with the
53 2012-01-18 Murray Cumming <murrayc@murrayc.com>
55 locales selector: Show human-readable locale titles.
57 * src/main/java/org/glom/web/server/ConfiguredDocument.java
58 getDocumentInfo(): Use java.util.Locale to show a real title of
59 each locale, in the locale's own language.
61 2012-01-17 Murray Cumming <murrayc@murrayc.com>
63 Add a language/locale selector drop-down.
65 * src/main/java/org/glom/web/shared/DocumentInfo.java:
66 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
67 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
68 getDocumentInfo(): Store the available Locales in the DocumentInfo.
69 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
70 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
71 Add a ListBox to show the available locales. Add getLocaleSelector(),
72 setLocaleList(), getSelectedLocale(), setSelectedLocale().
73 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
74 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
75 java: Add these classes.
76 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
77 start(): Fill the locales ListBox. Handle its change event, firing a
79 setPlace(): Show the selected locale as specified by the URL token.
80 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
81 * src/main/java/org/glom/web/client/activity/ListActivity.java:
82 Handle LocaleChangeEvent, going to a new *Place with that locale.
84 The placement of the ListBox is not pretty, and it currently uses the ID
85 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
89 2012-01-17 Murray Cumming <murrayc@murrayc.com>
91 Search box: Show the search text from the URL token.
93 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
94 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
95 Add setQuickFindText().
96 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
97 .java: setPlace(): Store the queryText if the place is a ListPlace,
98 and call TableSelectionView.setQuickFindText().
100 2012-01-17 Murray Cumming <murrayc@murrayc.com>
102 Allow use of translations via, for instance, &lang=de in the URL.
104 * pom.xml: Use the unstable java-libglom 1.21 version.
106 * src/main/java/org/glom/web/client/OnlineGlomService.java:
107 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
109 init(): Instead of calling TranslatableItem.set_current_locale()
110 (now removed), call ConfiguredDocument.setDefaultLocaleID().
111 However, this is only for default locales, which are not needed to
112 change the locale in the URL.
113 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
114 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
115 getSortedRelatedListData(): Add a localeID parameter, so we can get the
116 layout for a particular locale.
117 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
118 Add get/setDefaultLocaleID().
119 getDocumentInfo(), getListViewData(), getRelatedListData(),
120 getDetailsLayoutGroup(), getListViewLayoutGroup(),
121 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
122 localeID parameter, so we can get the layout for a particular locale.
124 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
125 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
126 * src/main/java/org/glom/web/client/place/ListPlace.java:
127 Parse and construct a lang parameter too.
129 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
130 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
131 passed to subsequent methods and constructors.
132 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
133 * src/main/java/org/glom/web/client/activity/ListActivity.java:
134 Store the localeID from the *Place and pass it to other constructors
135 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
137 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
138 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
139 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
140 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
141 * src/main/java/org/glom/web/client/ui/ListView.java:
142 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
143 Take localeID parameters and pass them to subsequent constructors and
144 methods, so that the layout is always retrieved for that locale.
146 This is rather repetitive.
148 Note that "" means the original (default) locale of the Glom document,
149 which is usually English.
151 2012-01-17 Murray Cumming <murrayc@murrayc.com>
153 Documents: Remove final keyword to fix startup configuration.
155 * src/main/java/org/glom/web/shared/Documents.java: Remove the
156 final keywords on the private member variables because that breaks
157 the startup, apparently (there are warnings) because it stops them
158 from being serialized. I added these in the previous commit.
160 2012-01-13 Murray Cumming <murrayc@murrayc.com>
162 Documents: Add some final keywords.
164 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
167 2012-01-13 Murray Cumming <murrayc@murrayc.com>
169 OnlineGlomServiceImpl: Add to overview comments.
171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
172 Note that this is where all the document are loaded. They are not
173 loaded freshly for each page.
175 2012-01-12 Murray Cumming <murrayc@murrayc.com>
179 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
180 Add a TextBox for the text of a quick find.
181 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
183 setBackLink(): Add a String quickFind parameter.
184 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
185 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
186 to the base interface, because that is how TableSelectionViewImpl is used.
187 * src/main/webapp/style.css: Add style for the search box and its label.
189 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
190 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
191 Add these files, based on the existing TableChangeEvent and
192 TableChangeEventHandlers.
193 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
194 start(): Handle QuickFindChangeEvent, passing its quickFind text to
195 a ListPlace() that the user should be taken to.
196 * src/main/java/org/glom/web/client/activity/ListActivity.java
197 start(): Handle it here too and adapt the TableChangeEvent handler to
198 pass the extra "" quickFind parameter to ListPlace.
199 * src/main/java/org/glom/web/client/place/ListPlace.java:
200 Constructor: Take an extra String quickFind parameter and store it,
201 returning it from a new getQuickFind() method.
202 getToken(): Put the quickFind text in the URL token.
203 getPlace(): Parse the quickFind text from the URL token.
204 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
205 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
206 ListPlace constructor.
207 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
208 .java: start(): Add a Change handler for the TableSelectionView's
209 TextBox (via its base HasChangeHandlers interface), firing the new
210 QuickFindChangeEvent.
211 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
212 pass the extra "" quickFind parameter.
214 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
215 setCellTable(): Add a String quickFind parameter and pass it to
216 the ListViewTable() constructor.
217 * src/main/java/org/glom/web/client/ui/ListView.java: Change
218 setCellTable() in the base interface, because that is how ListViewImpl
221 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
222 Add a String quickFind member variable.
223 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
224 Constructor: Add a String quickFind parameter, storing it in the
225 base ListTable's member variable.
226 onRangeChanged(): Pass quickFind to the
227 OnlineGlomServiceAsync.getSortedListViewData() and
228 OnlineGlomServiceAsync.getListViewData() methods.
230 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
231 getListViewData(), getSortedListViewData(): Add a String quickFind
232 parameter, passing it to ConfiguredDocument.getListViewData().
233 * src/main/java/org/glom/web/client/OnlineGlomService.java:
234 Change getListViewData(), getSortedListViewData() in the base interface,
235 because that is how OnlineGlomServiceImpl is used, via this:
236 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
237 Change getListViewData(), getSortedListViewData() here too.
238 This class can apparently be used to asynchronously call methods on
239 OnlineGlomService, and GWT seems to implement that after recognizing
240 just the *Async name convention and the extra AsyncCallback parameters.
242 * src/main/java/org/glom/web/server/ConfiguredDocument.java
243 getListViewData(): Add a String quickFind parameter, and pass it to
244 ListViewDBAccess.getData().
245 * src/main/java/org/glom/web/server/database/ListDBAccess.java
246 getListData(): Add a String quickFind parameter and pass it to
248 getSelectQuery(): Add a String quickFind parameter.
249 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
250 getSelectQuery(): Add a String quickFind parameter and use it with
251 Glom.get_find_where_clause_quick() to pass a where_clause to
252 Glom.build_sql_select_with_where_clause(), to actually filter the
254 getData(): Add a String quickFind parameter, passing it to getListData().
255 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
256 va: getData(): Pass an empty string to getListData() for the
259 2012-01-12 Murray Cumming <murrayc@murrayc.com>
261 ListTable: Minor change.
263 * src/main/java/org/glom/web/client/ui/list/ListTable.java
264 createCellTable(): Make this protected instead of public.
266 2012-01-12 Murray Cumming <murrayc@murrayc.com>
268 Many files: Use final for the parameters and use the @override attribute.
270 2012-01-22 Ben Konrath <ben@bagu.org>
272 Add anchor links for single line text that starts with http, ftp and www.
276 2012-01-22 Ben Konrath <ben@bagu.org>
278 Add ellipsis to single line text in details view.
282 2012-01-04 Murray Cumming <murrayc@murrayc.com>
284 Remove all javadoc author tags.
286 Because they are awkward and meaningless when many people touch
288 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
290 2012-01-04 Murray Cumming <murrayc@murrayc.com>
292 Revert the COPYING.LESSER to COPYING rename.
294 Apparently both should be there if it is LGPL.
296 2012-01-03 Murray Cumming <murrayc@murrayc.com>
298 *View: Remove unused imports.
300 * src/main/java/org/glom/web/client/ui/DetailsView.java:
301 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
302 * src/main/java/org/glom/web/client/ui/ListView.java:
303 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
304 Remove unused imports, as suggested by Eclipse.
306 2012-01-02 Murray Cumming <murrayc@murrayc.com>
308 Move the *View::Presenter types, and some API into one base View.
310 * src/main/java/org/glom/web/client/ui/DetailsView.java:
311 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
312 * src/main/java/org/glom/web/client/ui/ListView.java:
313 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
314 Presenter, setPresenter() and clear() into a shared base interface,
315 to avoid the unnecessary duplicate Presenter types and to more clearly
316 show how the *Views share the same structure, even if they are not
317 used polymorphically.
319 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
320 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
322 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
323 * src/main/java/org/glom/web/client/activity/ListActivity.java:
324 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
326 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
329 Feel free to revert this if there is a good reason for the duplicate
332 2012-01-02 Murray Cumming <murrayc@murrayc.com>
334 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
336 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
337 a class member instead of a local variable in the method.
338 This lets us use it to get the view instances, for use in tests.
339 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
340 beforeOnlineGlom(): Test some more details of the initial view.
341 Again, this is not very useful.
343 To really test gwt-glom we will need to start a local postgresql
344 instance with local data, like the Glom tests in C++.
346 2012-01-02 Murray Cumming <murrayc@murrayc.com>
348 pom.xml: Mention the LGPL license.
350 * pom.xml: Add a licenses section.
351 * COPYING.LESSER: Move this to COPYING, which
352 previously contained the GPL. But gwt-glom is all LGPL.
354 2012-01-02 Murray Cumming <murrayc@murrayc.com>
356 Add project information to README and pom.xml.
358 * README: Add a brief description and mention some mvn
360 * pom.xml: This extra information shows up in mvn site
363 2011-01-02 Murray Cumming <murrayc@murrayc.com>
365 Use the latest java-libglom version.
367 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
369 2012-01-01 Murray Cumming <murrayc@murrayc.com>
371 GwtTestOnlineGlom: Test a little more.
373 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
374 protected rather than private, as suggested by the gwt-test-utils
376 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
377 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
378 Test the initial visibility of the panels.
380 However, this is not a very useful test.
381 And I wonder how we should generally test using this idea for an
382 activity/places app like ours where the real changes happen implicitly
383 based on the history token/URL.
385 2012-01-01 Murray Cumming <murrayc@murrayc.com>
387 Slight modification to *Mapper comments.
389 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
391 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
393 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
395 Remove comments mentioning GIN because they are just copied from
396 the example code and are apparently not helpful:
397 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
398 Also change the mention of a class that is only in the example code.
400 2012-01-01 Murray Cumming <murrayc@murrayc.com>
402 GwtTestOnlineGlom test: Minor changes.
404 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
405 Avoid the long qualified class name and modify the comment
406 because it is now obvious to me that the mocked class is the only
407 custom one created via GWT.create().
409 2012-01-01 Murray Cumming <murrayc@murrayc.com>
411 Tests: Added the beginnings of a test using gwt-test-utils.
413 * pom.xml: Add dependencies on gwt-test-utils and easymock.
414 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
415 which tells gwt-test-utils what class will be tested.
416 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
417 Add a simple (but empty) test case. One class, used by the OnlineGlom
418 class, is mocked so that it can be created. However, I am not sure
419 why only this class needs to be mocked.
421 Note that mockito seems more popular, and clearer, than easymock,
422 but I have not got that working yet. It might be a matter of the
425 This test is run during mvn integration-test.
427 2011-12-31 Murray Cumming <murrayc@murrayc.com>
429 Tests: Use junit4-style syntax instead of junit3-style.
431 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
432 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
433 * src/test/java/org/glom/web/shared/DataItemTest.java:
434 Use the @Test annotation rather than relying on the test*() prefix.
435 Also no longer implement TestCase, to avoid triggering support for
436 the junit3-way, which stops the annotations from working.
437 Change the imports from import junit.framework.* to
438 import org.junit.*, which is apparently the new way.
440 2011-12-31 Murray Cumming <murrayc@murrayc.com>
442 Added a test for ListPlace token parsing and creation.
444 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
445 This is much the same as DetailsPlaceTest.
447 I wonder how we could test the other parts of the *Place API.
449 2011-12-30 Murray Cumming <murrayc@murrayc.com>
451 DetailsPlace test: Also test getToken() and recreation via getPlace().
453 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
454 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
455 recreate it, testing the recreated DetailsPlace for the same parameter
458 2011-12-30 Murray Cumming <murrayc@murrayc.com>
460 Use the surefire-report plugin.
462 * pom.xml: This generates a HTML report about the tests in
463 target/site/surefire-report.html
464 when you do mvn surefire-report:report. It seems to be popular/normal.
466 2011-12-30 Murray Cumming <murrayc@murrayc.com>
468 Added a test for DetailsPlace.
470 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
471 Test the getPlace() token parsing.
473 2011-12-30 Murray Cumming <murrayc@murrayc.com>
475 Added a first unit test.
477 * pom.xml: Add a test goal, and a dependency on junit in that scope.
478 * src/test/java/org/glom/web/shared/DataItemTest.java:
479 This is a silly test but it is just to get things started. Note that
480 maven/junit finds the test because it looks in src/test by default.
482 2011-12-22 Ben Konrath <ben@bagu.org>
484 Change charsetName to "UTF-8" when replacing line breaks.
486 JavaScript requires the charsetName to be "UTF-8". CharsetName values
487 that work in Java (such as "UTF8") will not work when compiled to
490 This fixes a problem with multi-line details view fields that have hard
491 line breaks. The "License Text" field on this page demonstrates the
494 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
496 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
498 2011-12-22 Ben Konrath <ben@bagu.org>
500 Fix another bug with related list navigation.
502 I've tested all the navigation buttons in all of the related lists
503 so things should be good now.
505 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
507 2011-12-22 Ben Konrath <ben@bagu.org>
509 Fix a crasher when refreshing the list view with the default table.
511 This crash will also happen when loading the list view with the default
512 table from a link or bookmark.
514 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
515 to the main document selection page when the document id hasn't been
517 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
518 the main document selection page when the document id hasn't been
520 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
521 values for the details place when the document id hasn't been set.
522 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
523 values for the list place when the document id hasn't been set.
525 2011-12-21 Ben Konrath <ben@bagu.org>
527 Protect against NPE when glom.document.locale is not in config.
529 This patch protects against an NPE when glom.document.locale is not in
530 the config file. This NPE will also happen if glom.document.locale is
533 The patch also updates the error message to display the class name when
534 the getMessage() returns null. This was happening when the NPE was
535 thrown and I had "Configuration Error: null". If an NPE is encountered
536 with this patch, "Configuration Error: NullPointerException " will be
539 This commit closes this bug:
541 https://bugzilla.gnome.org/show_bug.cgi?id=666669
543 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
545 2011-12-20 Murray Cumming <murrayc@murrayc.com>
547 Rename onlineglom.properties to onlineglom.properties.sample.
549 * src/main/resources/onlineglom.properties: Rename to:
550 * src/main/resources/onlineglom.properties.sample:
551 * src/main/resources/README: And add this file explaining that people
552 should rename it back when deploying.
554 2011-12-20 Murray Cumming <murrayc@murrayc.com>
556 Allow choosing the translation in the .properties file.
558 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
559 init(): Read a glom.document.locale value from the configuration file
560 and call Glom's TransatableItem::set_current_locale() method.
561 * src/main/resources/onlineglom.properties: Add a commented-out
562 example of this new setting.
564 It would be better to add &lang=de_DE to the URL, but the current
565 libglom API does not allow us to do this easily. I am working on that.
567 2011-12-19 Murray Cumming <murrayc@murrayc.com>
569 Avoid a crash in parsing of token parameters.
571 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
572 ava: getTokenParams(): Do not crash if a parameter has a key but no
573 value, and ignore parameters with neither.
575 2011-12-17 Murray Cumming <murrayc@murayc.com>
577 History token building/handling: Improve use of token parameters.
579 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
580 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
581 and buildParamsToken(HashMap), for use by derived classes.
582 Make the separator private because it is no longer be needed.
583 * src/main/java/org/glom/web/client/place/DetailsPlace.java
584 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
585 instead of manual string concatenation.
586 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
587 of hardcoded indices and awkward splitting code.
588 * src/main/java/org/glom/web/client/place/ListPlace.java
589 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
590 instead of manual string concatenation.
591 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
592 of hardcoded indices and awkward splitting code.
593 This should fix bug #666420
595 2011-12-16 Murray Cumming <murrayc@murrayc.com>
597 Fix a Navgiation->Navigation typo in the code.
599 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
600 Rename processNavgiation() to processNavigation().
602 2011-12-16 Murray Cumming <murrayc@murrayc.com>
604 Fix a seperator->separator typo in the code.
606 * src/main/java/org/glom/web/client/place/DetailsPlace.java
607 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
608 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
611 2011-12-15 Ben Konrath <ben@bagu.org>
613 Cleanup some comments.
615 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
617 2011-12-14 Ben Konrath <ben@bagu.org>
619 Replace \n with <br/> for multiline text in the details view.
621 Vertical scrollbars are added when needed as well.
623 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
625 2011-12-14 Ben Konrath <ben@bagu.org>
627 Specify the font for document selection links.
629 * src/main/webapp/style.css:
631 2011-12-14 Ben Konrath <ben@bagu.org>
633 Fix bouncy CellTable while paging.
635 This doesn't currently work with related list tables in unselected
638 * src/main/java/org/glom/web/client/ui/list/ListTable.java
640 2011-12-14 Ben Konrath <ben@bagu.org>
642 Revamp the appearance of the document selection page.
644 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
645 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
646 * src/main/webapp/style.css:
648 2011-12-13 Ben Konrath <ben@bagu.org>
650 Set navigation button column to the smallest size possible.
652 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
654 2011-12-13 Ben Konrath <ben@bagu.org>
656 Change OpenButton nomenclature to NavigationButton.
658 Using NavigtionButton makes things more generic. Classes, methods and
659 variables have been changed.
661 This is a rename-only refactor.
663 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
664 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
665 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
666 Renamed from OpenButtonCell.
667 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
668 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
669 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
671 2011-12-12 Ben Konrath <ben@bagu.org>
673 Remove unnecessary String argument in RelatedListTable and ListViewTable.
675 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
676 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
677 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
678 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
680 2011-12-12 Ben Konrath <ben@bagu.org>
682 Update variable names and comments.
684 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
685 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
687 2011-12-12 Ben Konrath <ben@bagu.org>
689 Properly initialize numNonEmptyRows variable to zero.
691 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
692 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
694 2011-12-05 Ben Konrath <ben@bagu.org>
696 Add latest mockup with HTML tables.
698 Features of this mockup:
700 -> HTML table for flowtable
701 -> HTML table for flowtable column
702 -> Example of how related lists would look
703 -> Not using text entries for data items
705 The current version of Online Glom doesn't use HTML tables for the
708 This mockup has been sent to the glom-devel mailing list but it's good
709 to have it here as well.
711 * mockups/details-view-html-tables.html:
713 2011-12-05 Ben Konrath <ben@bagu.org>
715 Remove unnecessary getPrimaryKeyField() method.
717 getPrimaryKeyFieldForTable(String) has been renamed to
718 getPrimaryKeyField(String).
720 * src/main/java/org/glom/web/server/database/DBAccess.java:
721 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
722 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
724 2011-12-05 Ben Konrath <ben@bagu.org>
726 Add string representation of TypedDataItem value to conversion error message.
728 * src/main/java/org/glom/web/server/Utils.java: Logging the error
729 message was extracted into its own method to avoid duplication.
731 2011-12-05 Ben Konrath <ben@bagu.org>
733 Add type checking to navigation primary key value creation.
735 Create navigation primary key only if the expected type from the Glom
736 document matches the type returned by the SQL query.
738 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
740 2011-12-05 Ben Konrath <ben@bagu.org>
742 Rename a couple of variables in RelatedListNavigation.
744 This is a rename-only refactor.
746 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
748 2011-12-05 Ben Konrath <ben@bagu.org>
750 Move getListLayoutGroup() into getListViewLayoutGroup().
752 This removes getListLayoutGroup(). It was only being called by
753 getListViewLayoutGroup().
755 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
757 2011-12-05 Ben Konrath <ben@bagu.org>
759 Remove check for LayoutItem_Portal in list table method.
761 This check is no longer necessary because the method isn't being used
762 to create the LayoutItemPortal DTO.
764 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
766 2011-12-05 Ben Konrath <ben@bagu.org>
768 Properly support related list navigation.
770 Navigation from the "Repository Analyzer -> Package Scans ->
771 Dependencies" related table wasn't working because the primary key for
772 related tables wasn't being set properly. This commit fixes the
775 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
776 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
777 doesn't set the primary key properly for related list tables.
778 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
779 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
780 useful for getting the primary key for list view tables and for related
782 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
783 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
784 Move code to set the primary key for the table from the abstract
785 ListDBAccess class to ListViewDBAccess as it's only correct for list
787 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
788 Properly add primary key to related list tables.
790 2011-12-02 Ben Konrath <ben@bagu.org>
792 Properly set the horizontal alignment of fields.
794 This fix is for both the list tables and the details view.
796 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
797 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
798 to set the horizontal alignment of fields.
800 2011-12-02 Ben Konrath <ben@bagu.org>
802 Display currency codes in the details view.
804 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
806 2011-12-02 Ben Konrath <ben@bagu.org>
808 Avoid duplicate JNI call.
810 JNI is not as efficient as pure Java and this is an easy (and small)
813 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
814 Use previously retrieved value for whereClauseToTableName instead of
817 2011-12-02 Ben Konrath <ben@bagu.org>
819 Rename a couple of variables in RelatedListNavigation.
821 This is a rename-only refactor.
823 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
825 2011-12-02 Ben Konrath <ben@bagu.org>
827 Indicate clearly that a mismatched primary key type is a bug.
829 * src/main/java/org/glom/web/server/Utils.java: Change log level from
830 warning to error. Add 'This is a bug.' to message.
832 2011-12-02 Ben Konrath <ben@bagu.org>
834 Update / fix some comments.
836 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
838 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
840 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
841 Fix comments. Add some TODOs.
843 2011-12-02 Ben Konrath <ben@bagu.org>
845 Enable navigation to details view with string primary key from related list.
847 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
848 Create a text primary key value when return type of result is
849 java.sql.Types.VARCHAR.
851 2011-12-02 Ben Konrath <ben@bagu.org>
853 Use checkboxes for booleans in the details view.
855 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
857 2011-12-01 Ben Konrath <ben@bagu.org>
859 Improve performance of related list height calculation.
861 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
862 Put code to calculate the expected height in a static initializer so
863 that that it's only called once.
865 2011-12-01 Ben Konrath <ben@bagu.org>
867 Show related list tables in notebooks (again).
869 Calculate the height of the related list tables so the Notebook can be
870 set the correct height. The height of the related list table is also needed by
871 FlowTable to be able decide how to create the layout.
873 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
874 and set the Portal height based on the height of the related list
875 table and the Portal container.
876 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
877 Add method to calculate the height of the related list tables.
878 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
879 * src/main/webapp/style.css: Add css class for Pager. This is needed to
880 calculate the height of the Pager widget.
882 2011-12-01 Ben Konrath <ben@bagu.org>
884 Use CellTable API for table property instead of setting style on Element.
886 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
888 2011-12-01 Ben Konrath <ben@bagu.org>
890 Make ListViewTable and RelatedListTable a consistent height.
892 The tables are now a consistent height regardless of the contents of
893 the table. A hidden button is added to empty rows to ensure that the
894 height of these rows will match the height of rows with data.
896 A navigation button column is now added to every table. The width of
897 the navigation column is set to 0px when a RelatedListTable shouldn't
898 have navigation buttons. This maintains the a consistent row height in
899 tables that don't show the navigation buttons.
901 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
902 navigation column when not needed.
903 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
904 arguments for navigation button to constructor of ListViewTable.
905 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
906 hidden button for empty data rows.
907 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
908 arguments for navigation button to constructor.
909 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
910 create navigation buttons. Add hideNavigationButtons() method.
911 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
912 arguments for navigation button to constructor.
914 2011-12-01 Ben Konrath <ben@bagu.org>
916 Use 'visibility: hidden' in Utils.getWidgetHeight().
918 This is better choice because hidden elements are invisible, don't
919 respond to events and are not part of the tab order. They will,
920 however, take up space which is required to be able to calculate the
921 height of the widget.
923 * src/main/java/org/glom/web/client/Utils.java:
925 2011-12-01 Ben Konrath <ben@bagu.org>
927 Use Utils.getWidgetHeight() in FlowTable.
929 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
931 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
933 2011-12-01 Ben Konrath <ben@bagu.org>
935 Put the details css class name on the correct table column.
937 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
939 2011-11-30 Ben Konrath <ben@bagu.org>
941 Update for java-libglom API change.
943 The getters and setters on FieldFormatting and NumericFormat were
944 changed to remove the 'M'.
946 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
948 2011-11-29 Ben Konrath <ben@bagu.org>
950 Only allow RelatedListTables in Portals.
952 * src/main/java/org/glom/web/client/ui/details/Portal.java:
954 2011-11-29 Ben Konrath <ben@bagu.org>
956 Only create a contents panel for Portals when title is being set.
958 * src/main/java/org/glom/web/client/ui/details/Portal.java:
960 2011-11-29 Ben Konrath <ben@bagu.org>
962 Set TabLayoutPanel height based on calculated height its widgets.
964 This is a potential fix for this bug:
966 https://bugzilla.gnome.org/show_bug.cgi?id=665133
968 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
970 2011-11-29 Ben Konrath <ben@bagu.org>
972 Align details field labels and data with the Open buttons.
974 * src/main/webapp/style.css:
976 2011-11-29 Ben Konrath <ben@bagu.org>
978 Remove unnecessary <div> in the Notebook widget.
980 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
981 method to get container FlowPanel (<div>).
982 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
983 initWidget() method directly on the TabLayoutPanel widget instead of
984 Group's container widget.
986 2011-11-29 Ben Konrath <ben@bagu.org>
988 Don't add group titles for Portals in Notebooks.
990 This reverts the previous patch and fixes a bug I introduced with
991 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
993 * src/main/java/org/glom/web/client/ui/details/Group.java:
994 * src/main/java/org/glom/web/client/ui/details/Portal.java:
996 2011-11-28 Ben Konrath <ben@bagu.org>
998 Remove unused boolean argument in Portal constructor.
1000 Just a code cleanup.
1002 * src/main/java/org/glom/web/client/ui/details/Group.java:
1003 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1005 2011-11-28 Ben Konrath <ben@bagu.org>
1007 Remove hack for glom 1.18 style glom files.
1009 * src/main/java/org/glom/web/client/ui/details/Group.java:
1010 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1011 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1013 2011-11-28 Ben Konrath <ben@bagu.org>
1015 Use Gda Value version of primary key to log result too large error.
1017 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1019 2011-11-28 Ben Konrath <ben@bagu.org>
1021 Don't use TypedDataItem.getText() for Unknown types from the URL.
1023 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1024 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1025 instead of getText().
1026 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1027 String field and getUnknown() method.
1029 2011-11-28 Ben Konrath <ben@bagu.org>
1031 Log an error message when the java-libglom .so is not present.
1033 The error message was being set in the exception but not logged.
1035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1037 2011-11-28 Ben Konrath <ben@bagu.org>
1039 Ignore LayoutItem_CalendarPortals.
1041 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1042 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1044 2011-11-28 Ben Konrath <ben@bagu.org>
1046 Extract method for creating the LayoutItemPortal DTO.
1048 Just breaking the code up into smaller chunks.
1050 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1052 2011-11-28 Ben Konrath <ben@bagu.org>
1056 This should have been added with the refactor. Oops!
1058 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1060 2011-11-28 Ben Konrath <ben@bagu.org>
1062 Create primary key value from URL string using type from Glom document.
1064 See this bug, comments 19 - 25:
1066 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1068 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1069 create a TypeDataItem for the primary key here when loading from a
1070 URL. Show the same string for the primary key value as was received
1071 from the URL string (when loading from a URL).
1072 * src/main/java/org/glom/web/server/Utils.java: Update method for
1073 creating the Gda Value from the TypeDataItem to properly deal with
1074 creating a Gda Value based on the Glom document type for the primary
1075 key value string when loading from a URL.
1076 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1077 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1078 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1079 Update for changed method name.
1081 2011-11-27 Ben Konrath <ben@bagu.org>
1083 Rename PrimaryKeyItem to TypedDataItem.
1085 The name PrimaryKeyItem suggests what the class should be used for.
1086 TypedDataItem is a neutral name that describes the class better.
1088 This is a rename-only refactor.
1090 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1091 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1092 * src/main/java/org/glom/web/client/Utils.java:
1093 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1094 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1095 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1096 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1097 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1098 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1099 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1100 * src/main/java/org/glom/web/server/Utils.java:
1101 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1102 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1103 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1104 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1106 2011-11-25 Ben Konrath <ben@bagu.org>
1108 Improve Gda Value conversion from PrimaryKeyItem.
1110 The value from the PrimaryKeyItem is only used if its type match the
1111 type from the glom document.
1113 * src/main/java/org/glom/web/server/Utils.java:
1115 2011-11-25 Ben Konrath <ben@bagu.org>
1117 Manually check if the java-liblgom .so is visible to the JVM.
1119 It seems that Tomcat has problems when a static initializer throws an
1120 exception. This check is done before the first method call into
1121 java-libglom so that execution doesn't continue if the .so is not
1124 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1126 2011-11-25 Ben Konrath <ben@bagu.org>
1128 Improve browser configuration error messages.
1132 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1134 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1135 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1136 getConfigurationErrorMessage() method.
1137 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1138 Get and display a specific configuration error message when no Glom
1139 documents are found.
1140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1141 Implement getConfigurationErrorMessage() method. Surround configuration
1142 code in the init() method with a try/catch block. This allows the
1143 errors to be caught while keeping the servlet available to retrieve the
1144 configuration error message.
1146 2011-11-25 Ben Konrath <ben@bagu.org>
1148 Don't use Strings to hold primary key values.
1150 The primary key values are now held in a new data object
1151 (PrimaryKeyItem) that holds type information and the primary key value
1152 using the correct type.
1154 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1155 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1156 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1157 PrimaryKeyItem instead of String to hold the primary key value.
1158 * src/main/java/org/glom/web/client/Utils.java: Remove
1159 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1160 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1162 PrimaryKeyItem instead of String to hold the primary key value. Load
1163 document selection page when the documentID has not been set correctly.
1164 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1165 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1167 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1168 Return empty string for URL instead of "null".
1169 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1170 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1171 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1172 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1173 PrimaryKeyItem instead of String to hold primary key values.
1174 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1175 PrimaryKeyValue to a Gda Value.
1176 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1177 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1178 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1179 Replace temporary database access code that uses the PrimaryKeyValue to
1180 Gda Value conversion.
1181 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1182 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1183 PrimaryKeyItem instead of String.
1184 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1185 hold primary key values.
1187 2011-11-24 Ben Konrath <ben@bagu.org>
1189 Use newly added java-libglom API to create queries.
1191 This isn't finished. I still need to stop using Strings for primary key
1192 values in the client code.
1194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1195 libglom to use fake connections so that retrieving the query string will
1197 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1198 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1199 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1200 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1201 Use the newly added libglom sql methods and classes to create the
1202 query. Add temporary hack to convert primary value strings to Gda
1205 2011-11-23 Ben Konrath <ben@bagu.org>
1207 Don't explicitly set the height of Portals.
1209 See comments 6 - 10 of this bug for details:
1211 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1213 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1215 2011-11-23 Ben Konrath <ben@bagu.org>
1217 Use an HTML table instead of CSS for the FlowTable layout.
1219 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1220 GWT's FlexTable to implement the FlowTable.
1221 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1223 2011-11-18 Ben Konrath <ben@bagu.org>
1225 Add boolean example to HTML table mockup.
1227 * mockups/details-view-html-tables-text-entries.html:
1229 2011-11-17 Ben Konrath <ben@bagu.org>
1231 Ensure the pager buttons are always visible for related lists.
1233 To accomplish this, I've turned off text wrapping in the list view and
1234 related list tables for both the header and data text. The related list
1235 table now has a fixed layout so the it doesn't overflow its container.
1236 This is required to ensure that the cell text is clipped when it
1237 overflows the cell and an ellipsis is added to the right side of the
1238 cell when text is clipped.
1240 A fixed table layout for the related list table in the details view
1241 seems what we want for the details view anyway, so the side-effect is
1244 The ellipsis will only be displayed in Firefox >= 7.
1248 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1250 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1251 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1252 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1254 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1255 Set the 'table-layout: fixed' CSS property to the related list table.
1256 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1257 'white-space: nowrap;' CSS property on both the list view and the
1258 related list tables.
1260 2011-11-16 Ben Konrath <ben@bagu.org>
1262 Rework the fix for empty notebook tab labels.
1264 Setting the empty group titles with its name caused problems for the
1265 details layout. Instead of using libglom's
1266 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1267 to the client when the title is empty. This allows the Notebook to use
1268 the name when the title is empty without affecting anything else.
1270 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1271 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1273 2011-11-16 Ben Konrath <ben@bagu.org>
1275 Set group titles with name when title is empty.
1277 This fixes a problem with an empty notebook tab label in the Lesson
1278 Planner document. The forth tab in the notebook should be "Internet":
1280 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1282 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1283 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1286 2011-11-16 Ben Konrath <ben@bagu.org>
1288 Remove whitespace from the configured username properties.
1290 This assumes that usernames won't have whitespace at the beginning
1291 or end. But I think this is a reasonable assumption.
1293 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1294 String.trim() to remove the whitespace from the username properties.
1296 2011-11-15 Ben Konrath <ben@bagu.org>
1298 Add details view mockup with HTML tables and text entries.
1300 This is from the attachment on this bug:
1302 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1304 * mockups/details-view-html-tables-text-entries.html:
1306 2011-11-15 Ben Konrath <ben@bagu.org>
1308 Add space between the columns of the flow table.
1312 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1314 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1315 space between columns in the flow table.
1317 2011-11-15 Ben Konrath <ben@bagu.org>
1319 Add backup files to the .gitignore.
1321 * .gitignore: Ignore files that end with ~.
1323 2011-11-09 Ben Konrath <ben@bagu.org>
1325 Use latest release of gwt-log.
1327 Gwt-log releases are now being submitted to the maven central
1328 repository so manual installation of the jar is no longer required.
1330 * pom.xml: Update version and groupId of gwt-log dependency.
1332 2011-10-31 Ben Konrath <ben@bagu.org>
1334 Don't use GWT numeric formatting to override the glom currency formatting.
1336 Currencies are now displayed like they are in Glom. See this bug:
1338 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1340 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1342 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1343 currency code to constructor and set it when the cell is rendered.
1344 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1345 currency code to the constructor of the NumericCell.
1347 2011-10-27 Ben Konrath <ben@bagu.org>
1349 Require the latest release of java-libglom (1.17.4).
1353 2011-10-26 Ben Konrath <ben@bagu.org>
1355 Add style to Notebook that matches current theme.
1357 It's not the best style in the world but it's better than the default.
1359 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1360 padding at the bottom of the child widgets.
1361 * src/main/webapp/style.css: Add style for the Notebook.
1363 2011-10-26 Ben Konrath <ben@bagu.org>
1365 Move servlet initialization code to overridden init method.
1367 This is half of the solution to getting proper error messages
1368 displayed when configuration errors occur. Here's the relevant bug:
1370 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1372 The rest of the solution involves surrounding the init method with a
1373 try/catch block and setting a global variable with the error /
1374 exception. A new async method should be created to retrieve and display
1375 the error message / exception.
1377 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1378 code from constructor to init method adding exceptions as needed.
1380 2011-10-26 Ben Konrath <ben@bagu.org>
1382 Add script to monitor and restart tomcat if required.
1384 * utils/check-and-recover-tomcat.py: New file.
1386 2011-10-26 Ben Konrath <ben@bagu.org>
1388 Display the correct number of data items in the pager.
1392 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1394 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1395 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1396 The implementation is the same for both tables: Keep track of the
1397 number of non-empty rows and fire and RowCountChangeEvent after the data has
1399 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1400 custom Pager class that subclasses SimplePager to handle displaying
1401 the correct number when empty rows have been added.
1403 2011-10-26 Ben Konrath <ben@bagu.org>
1405 Correct error in previous commit.
1407 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1408 eventBus parameter from listView.setCellTable().
1410 2011-10-26 Ben Konrath <ben@bagu.org>
1412 Fix error in TODO comment.
1414 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1416 2011-10-24 Ben Konrath <ben@bagu.org>
1418 Create Notebook widgets to the details view.
1420 This isn't finished just yet - I still need to create a reasonable
1421 style to match the current theme.
1423 * src/main/java/org/glom/web/client/Utils.java: Add method for
1424 calculating the height of a widget. This is used in the Notebook class.
1425 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1426 new constructor method in Group.
1427 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1428 method for creating child widget that can be used by subclasses
1429 like Notebook. New constructor that allows disabling the group
1430 titles - Notebooks don't set a group title for their child groups.
1431 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1432 to make Notebooks using GWT's TabLayoutPanel.
1433 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1434 constructor that allows disabling the group titles.
1435 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1436 LayoutItemNotebook DTO.
1437 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1438 DTO for Notebooks. It's just an empty class for now but we might need
1439 it to transfer some specific information in the future.
1441 2011-10-21 Ben Konrath <ben@bagu.org>
1443 Add navigation buttons to related list tables.
1445 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1446 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1447 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1448 method getSuitableRecordToViewDetails() for getting the table name
1449 and primary key value for related list navigation buttons.
1450 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1451 private cell renderer class to get the navigation information for
1452 related list tables from the server. Extract the navigation
1453 processing code from the details cell navigation and use it for the
1454 related list navigation as well.
1455 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1456 cell renderer class for the details open buttons. This was needed
1457 because the related list navigation buttons and the list view
1458 navigation buttons need to react differently when clicked.
1459 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1460 the onEnterKeyDown() method because it's now overriden in the
1461 subclasses that are specific to the related list tables and the list
1463 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1464 the vertical size a little because the buttons add a bit of vertical
1465 space to table. This is not a perfect solution because the vertical
1466 size of with table fewer than 5 rows will be a little smaller.
1467 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1468 changes in how navigation buttons are handled.
1469 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1470 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1471 database access object.
1472 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1473 to find the portal for a given relationship name from
1474 RelatedListDBAccess. Add method to find a primary key field for a
1476 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1477 Move code to find the portal for a given relationship name to
1479 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1480 New file: database access object for getting the related list
1481 navigation information (the table name and the primary key value).
1482 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1483 DTO for transferring a table name to navigate to and a primary key
1485 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1486 boolean and getter/setter to specifies if the related list should add
1489 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1491 Use the master branch of java-libglom
1493 * pom.xml: Depend on java-libglom 1.19 instead.
1495 This is the master branch. See also the libglom-1-18 branch.
1497 2011-10-11 Ben Konrath <ben@bagu.org>
1499 Enable the open navigation button when the data has been set.
1501 This avoids having active buttons that don't do anything when the data
1504 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1506 2011-10-11 Ben Konrath <ben@bagu.org>
1508 Use IsWidget interface for FlowTableItem.
1510 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1511 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1513 2011-10-11 Ben Konrath <ben@bagu.org>
1515 Remove GWT styling from open button in details view.
1517 There are still some issues with how the details cell is arranged but
1518 this should be made to match Glom 1.20. I'm going to leave fixing this
1519 until I have Glom 1.20 up and running.
1521 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1522 style name on open button.
1523 * src/main/webapp/style.css: Move and edit details-navigation class.
1524 Re-arrange some classes to make them appear in the same order as the
1527 2011-10-07 Ben Konrath <ben@bagu.org>
1529 Update to GWT 2.4.0.
1531 * .gitignore: Ignore new cache directory.
1532 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1533 * pom.xml: Change GWT and maven plugin to 2.4.0.
1534 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1536 * src/main/java/org/glom/web/client/ClientFactory.java:
1537 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1538 * src/main/java/org/glom/web/client/OnlineGlom.java:
1539 Update source for API changes.
1540 * utils/build-onlineglom-war.sh: Remove cache directory before the
1543 2011-10-07 Ben Konrath <ben@bagu.org>
1545 Add navigation buttons in the details view.
1547 This isn't finished but I thought I'd commit what I have as it's a
1548 pretty good start. I still need to:
1550 1. Change the style so that it fits better into the current theme
1551 2. Adjust the details cell to expand as much as possible.
1553 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1554 click handlers to navigation buttons in the DetailsCells. Create a
1555 refreshData() method to get just the data from the server without the
1557 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1558 Update the tableSelector and browser title when the table name
1559 changes without using the tableSelector.
1560 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1561 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1562 getDetailsCells() to getCells(). Update variable names.
1563 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1564 method to set click handler on navigation button. Rename a few
1565 variables. Add navigation buttons where needed.
1566 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1567 variables and methods.
1568 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1569 navigation boolean and navigation table as required in the
1570 LayoutItemField DTO.
1571 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1572 variables for navigation along with getter/setter methods.
1574 2011-10-07 Ben Konrath <ben@bagu.org>
1576 Rename Field to DetailsCell.
1578 This is a refactor-only commit. No functionality has been added or
1581 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1582 Update variable and method names.
1583 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1584 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1585 variable and method names.
1586 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1588 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1589 variable and method names.
1591 2011-10-07 Ben Konrath <ben@bagu.org>
1593 Create separate methods for layout and data the details view.
1595 This is a refactor-only commit. No functionality has been added or
1598 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1599 private methods: setData(), createLayout().
1601 2011-10-07 Ben Konrath <ben@bagu.org>
1603 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1605 This is part of a change to get navigation buttons in the details view
1606 but it should have been done this way from the start.
1608 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1609 for method name change in TableSelectionView.
1610 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1611 Create TableChangeEvent and set the browser title using the
1612 TableSelectionView API.
1613 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1614 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1615 Change getSelectedTable() to getSelectedTableName(). Add
1616 getSelectedTableTitle().
1618 2011-10-07 Ben Konrath <ben@bagu.org>
1620 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1622 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1624 2011-10-07 Ben Konrath <ben@bagu.org>
1626 Update TableChangeEvent to use newTableName naming convention.
1628 This makes the class more consistent with GWT naming conventions.
1630 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1631 Update for method name change in TableChangeEvent.
1632 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1633 for method name change in TableChangeEvent.
1634 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1635 newTableName variable and getter method. Make toDebugString()
1638 2011-09-30 Ben Konrath <ben@bagu.org>
1640 Disable the pager in the list tables when the data row count is less than the minimum.
1642 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1643 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1645 2011-09-30 Ben Konrath <ben@bagu.org>
1647 Add empty rows to the end of related list and list view tables.
1649 I also extracted the cell rendering classes from the ListTable because
1650 the code was becoming a little crazy with all the anonymous inner
1651 classes. My plan is to use these cell rendering classes in the details
1652 view as well so this refactor will be needed for that change.
1654 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1655 set the row count in related list tables if the data has more rows
1656 than the minimum number of rows visible.
1657 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1658 row count in list view tables if the data has more rows than the
1659 minimum number of rows visible.
1660 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1661 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1663 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1664 for rendering TYPE_NUMERIC cells. The code was extracted from the
1666 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1667 class for rendering cells with buttons in list views. The code was
1668 extracted from the ListTable class.
1669 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1670 for rendering TYPE_TEXT cells. The code was extracted from the
1672 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1673 Add empty rows to the end of the data if required. Implement
1674 ListTable.getMinNumVisibleRows().
1675 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1676 cell renderer code to public classes. Return null in
1677 Column.getValue() for empty rows. Add new abstract method:
1678 getMinNumVisibleRows(). Move code to set the row count of the list view
1679 table to ListViewImpl.
1680 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1681 empty rows to the end of the data if required. Implement
1682 ListTable.getMinNumVisibleRows().
1685 2011-09-27 Ben Konrath <ben@bagu.org>
1687 Use GWT.log for client-side debugging statements.
1689 These are optimized out when deployed so I should have used this method
1690 in the first place. These statements will eventually be replaced with some sort
1691 of notification in the browser.
1693 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1694 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1695 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1696 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1697 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1699 2011-09-27 Ben Konrath <ben@bagu.org>
1701 Put tableselector on the right, back to list link on right.
1703 The idea is that the table selector is acting like a label for the
1704 currently displayed table so it should be placed below the document title. This
1705 puts the table title in a similar position to where it is in Glom.
1707 * mockups/details-contacts.html:
1708 * mockups/details-projects.html:
1709 * mockups/listview-contacts.html:
1710 * mockups/listview-projects.html:
1711 * mockups/style.css:
1712 Update mockups to match how the interfaces currently look.
1713 * src/main/webapp/style.css: Swap positions of backlink with the table
1714 selector. Add some space on the left side of the table selector to
1715 line things up with the document title.
1717 2011-09-27 Ben Konrath <ben@bagu.org>
1719 Add field colouring to details view.
1721 This change re-works how field colouring works. The colour formatting
1722 information is now set to the client with the layout information instead of
1723 with the data. This eliminates the need to send the same colour strings for
1724 data in list view column when colour information is set.
1726 In order to set an alternate colour for negative numeric values, the
1727 number is now sent to client and formatted with the GWT NumberFormat class.
1729 This change also fixes:
1731 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1733 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1734 internationalization framework which is needed for client side numeric
1736 * src/main/java/org/glom/web/client/Utils.java: New file for some
1737 client static utility methods.
1738 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1739 the DataItem object to the Field class. Use a utility method to
1740 create the foreignKeyValue string.
1741 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1742 alignment and text colours in the constructor. Add setData(DataItem)
1743 method. Remove setText(String) method.
1744 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1745 colour information to GlomTextCell. Create and use GlomNumberCell for
1746 rendering numbers. Use utility method to get the string for the
1747 primary key of the key provider. Re-work how the horizontal alignment
1749 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1750 formatting to layout information. Methods for converting the libglom
1751 formatting information were moved from DBAccess.
1752 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1753 numeric formatting (it's now done on the client side). Don't set text
1754 colours in DataItem. Move libglom formatting conversion methods to
1756 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1757 getters/setters for text colour information.
1758 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1759 for transferring the libglom NumericFormat information to the client.
1760 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1761 and getters/setters for: GlomNumericFormat, background colour and
1762 foreground colour strings.
1764 2011-09-26 Ben Konrath <ben@bagu.org>
1766 Simplify code that iterates through the LayoutGroup.
1768 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1770 2011-09-26 Ben Konrath <ben@bagu.org>
1772 Accept Eclipse formatting for OnlineGlomServiceAsync.
1774 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1776 2011-09-26 Ben Konrath <ben@bagu.org>
1778 Don't use the ListDBAccess classes to get the primary key layout information.
1780 This was causing a bug where the wrong index for the hidden primary key
1781 was being sent to the client.
1783 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1784 primary key while creating the LayoutGroup DTO. Create a
1785 LayoutItemField DTO for hidden primary keys. Don't use the
1786 RelatedListDBAccess because it was only used for getting the primary
1788 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1789 access modifier from public to protected for getPrimaryKeyField() and
1790 getPrimaryKeyLayoutItemField().
1791 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1792 abstract method getExpectedResultSize() because RelatedListDBAccess
1793 doesn't have enough info to implement it.
1794 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1795 Remove @Override for getExpectedResultSize().
1796 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1797 Remove method getExpectedResultSize().
1799 2011-09-23 Ben Konrath <ben@bagu.org>
1801 Log which layout (list or details) the ignored item is from.
1803 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1805 2011-09-23 Ben Konrath <ben@bagu.org>
1807 Remove annotations that turn off code formatting in DataItem.
1809 * src/main/java/org/glom/web/shared/DataItem.java:
1811 2011-09-23 Ben Konrath <ben@bagu.org>
1813 Rename GlomField to DataItem and update associated methods.
1815 This is a rename-only refactor. No functionality has been added or
1818 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1819 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1820 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1821 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1822 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1823 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1824 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1825 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1826 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1827 * src/main/java/org/glom/web/server/database/DBAccess.java:
1828 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1829 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1830 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1831 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1832 * src/main/java/org/glom/web/shared/DataItem.java:
1833 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1834 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1836 2011-09-23 Ben Konrath <ben@bagu.org>
1838 Rename GlomDocument to DocumentInfo and update associated methods.
1840 This is a rename-only refactor. No functionality has been added or
1843 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1844 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1845 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1846 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1847 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1848 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1849 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1851 2011-09-20 Ben Konrath <ben@bagu.org>
1853 Require java-libglom 1.17.3.
1855 This picks up the fix for the seg fault problem with the Scenes table
1856 in the Openismus Film Manager example.
1860 2011-09-20 Ben Konrath <ben@bagu.org>
1862 Change the way sort clause is added for primary key when no sort clause is requested.
1864 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1865 before the sort clause is created. When a sort clause is not requested, the
1866 sort clause is created by finding the primary key in the LayoutFieldVector
1869 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1871 2011-09-20 Ben Konrath <ben@bagu.org>
1873 Log error message if no documents are found in the configured directory.
1875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1876 Extract the glom file extension string to a private static final class
1877 variable (mostly as syntactic sugar). Accept a minor formatting change.
1878 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1879 the example glom.document.directory configuration property to make it
1880 more clear that it can any directory, not just the home directory.
1882 2011-09-18 Ben Konrath <ben@bagu.org>
1884 Add related lists to details view.
1886 The related list table has support for paging and sorting just like the
1887 table in the list view.
1889 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1890 SQL queries for the related list tables.
1891 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1892 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1893 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1894 Rename getList methods to getListView and add comments. Remove
1895 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1896 it being unused. Add methods: getDetailsLayoutAndData(),
1897 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1898 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1899 Create the layout and set the data for the fields in one async call
1900 instead of two. Create related lists where appropriate.
1901 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1902 for method name changes in OnlineGlomService.
1903 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1904 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1905 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1907 * src/main/java/org/glom/web/client/ui/ListView.java:
1908 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1909 tableName from setCellTable(). Create a ListViewTable instead of
1911 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1912 represent a data field in the details view.
1913 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1914 from addDetailsCell() to Field class. Keep track of the Fields and
1915 Portals in the details view.
1916 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1917 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1918 and add a method to get it. Add method to set the contents of the
1920 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1921 New class for related list tables. This class has the data provider
1922 for the related list table.
1923 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1924 abstract class which is the base class for the ListViewTable and the
1926 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1927 New class for list view tables. This class has the data provider for
1928 the list view table.
1929 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1930 methods for related list tables. Add more information to the
1931 LayoutItemField and LayoutItemPortal DTOs.
1932 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1933 Remove debugging print statement.
1934 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1935 Remove debugging print statements. Add primary key field to SQL count
1937 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1938 Remove unnecessary LayoutFieldVector parameter from
1939 getResultSizeOfSQLQuery() method.
1940 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1941 New class for related list table database access.
1942 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1943 class that is a wrapper DTO for details view layout and data.
1944 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1945 new 'fromField' string to this DTO.
1946 * src/main/webapp/style.css: Remove bottom margin and override top
1949 2011-09-15 Ben Konrath <ben@bagu.org>
1951 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1953 This sets things up to make it easier to add the data retrieval for
1954 related lists (portals). No user noticeable changes were made with
1957 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1958 class has the code to retrieve the layouts and access the
1959 database using the new database helper classes.
1960 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1961 Most of the functionality has been removed from this class. This
1962 class now represents the public interface for the client side
1963 code. It also deals with configuring the servlet and cleaning
1964 things up when the servlet is stopped.
1965 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1966 of static methods into this utility class.
1967 * src/main/java/org/glom/web/server/database/DBAccess.java:
1968 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1969 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1970 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1971 These classes have the database retrieval code. The class hierarchy
1972 has been setup to make it easy to reuse code for similar
1975 2011-09-06 Ben Konrath <ben@bagu.org>
1977 Create separate classes for list table code and the data provider.
1979 As part of this refactor, I also split up the code a bit to make it
1982 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1983 table code to two new classes (below).
1984 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1985 with code from ListViewImpl.
1986 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1987 New file with code from ListViewImpl.
1989 2011-09-06 Ben Konrath <ben@bagu.org>
1991 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1993 This fixes the LayoutItemPortal DTO to match the libglom layout object
1996 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1998 2011-09-01 Ben Konrath <ben@bagu.org>
2000 Set title of Portals in the Details View.
2002 * pom.xml: Bump required version of java-libglom to 1.17.1.
2003 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2004 widget creation to its own class. Add comments to constructor.
2005 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2006 The code is mostly from the Group class with the title now set.
2007 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2008 title of Portal. Update some comments. Fix some code formatting.
2010 2011-09-01 Ben Konrath <ben@bagu.org>
2012 Remove TODO comment for the flow table column width.
2014 The flow table column width is working correctly and doesn't need to be
2015 changed. See this mailing list post for more info:
2017 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2019 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2021 2011-08-27 Ben Konrath <ben@bagu.org>
2023 Add document title (database name) to top of the browser page.
2025 I added the document title to the TableSelecitonView but that will
2026 change if / when we add a view that doesn't require table selection.
2028 * mockups/details-contacts.html:
2029 * mockups/details-projects.html:
2030 * mockups/listview-contacts.html:
2031 * mockups/listview-projects.html:
2032 * mockups/style.css: Add document title to mockups to keep things
2034 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2035 sizes to account for the document title.
2036 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2037 Set the document title when it has been retrieved from the server.
2038 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2039 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2040 and implement setDocumentTitle(String) method.
2041 * src/main/webapp/style.css: Add ID for document title style.
2043 2011-08-25 Ben Konrath <ben@bagu.org>
2045 Add NavigationType enum to LayoutItemPortal DTO.
2047 This is the start of adding support for Portals to the Details View.
2049 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2050 LayoutItem_Portal.navigation_type enum from libglom to
2051 LayoutItemPortal.NavigationType enum.
2052 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2053 NavigationType enum, field for storing the NavigationType and getter
2056 2011-08-25 Ben Konrath <ben@bagu.org>
2058 Implement the flow table layout in the Details View.
2060 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2061 FlowTable to Group to account for the renamed class.
2062 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2063 File. This is a container widget that implements the Glom details view
2064 flow table behaviour.
2065 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2066 org/glom/web/client/ui/FlowTable.java.
2067 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2068 so that the size of the subgroups are a closer match to the size of
2069 the Glom subgroups. This makes the flowtable layout match the layout
2070 in Glom for the Music Collection example file.
2072 2011-08-16 Ben Konrath <ben@bagu.org>
2074 Create container element for LayoutItemPortal in Details View.
2076 This will help me develop the layout for the FlowTable.
2078 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2079 fieldPanel variable to detailsCell.
2081 2011-08-15 Ben Konrath <ben@bagu.org>
2083 Set the height of the data element in the Details View.
2085 I changed the InlineLabels (text in a span element) to Labels (text in
2086 a div element) so that I could set the height of the details-data
2087 elements instead of the details-cell parent elements. This allows the
2088 the details-data element to display the correct height if style is
2089 applied that shows the height.
2091 This change has the added benefit of allowing the order of the labels
2092 and data elements to be changed for right-to-left languages.
2094 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2095 InlineLabels to Labels.
2096 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2097 InlineLabels to Labels. Set the height of the data element.
2098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2099 multiline text height in the Formatting DTO.
2100 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2101 for multiline height along with getter and setter methods.
2102 * src/main/webapp/style.css: Adjust style to account for the change
2103 from span elements to div elements in the details cell.
2105 2011-08-15 Ben Konrath <ben@bagu.org>
2107 Make the List View appearance match the mockups.
2109 It doesn't match exactly but it's much better than it was.
2111 * mockups/listview-contacts.html: Remove unused css classes.
2112 * mockups/listview-projects.html: Remove unused css classes.
2113 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2114 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2115 for mainPanel instead of VerticalPanel (table). Set style name on
2116 CellTable. Set style name on Details column. Right-align Details
2118 * src/main/webapp/style.css: Adjust properties to match the mockups.
2120 2011-08-12 Ben Konrath <ben@bagu.org>
2122 Add better support for subgroups in the details view.
2124 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2125 changed FlowTable constructor.
2126 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2127 support for subgroups and subgroup-titles.
2128 * src/main/webapp/style.css: Add CSS class for subgroups and
2131 2011-08-12 Ben Konrath <ben@bagu.org>
2133 Return the top level LayoutGroup title.
2135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2137 2011-08-11 Ben Konrath <ben@bagu.org>
2139 Make the TableSelector header match the mockup.
2141 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2142 the layout panel. Properly lineup the table selection header with
2143 the list and details view.
2144 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2145 margin around the details view.
2146 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2147 Rename listBox variable to tableSelector. Set id for the style sheet.
2148 Use a FlowPanel instead of a HorizontalPanel.
2149 * src/main/webapp/style.css: Add properties to make the TableSelector
2150 box match the mockups.
2152 2011-07-13 Ben Konrath <ben@bagu.org>
2154 Update install script for java-libglom version change.
2156 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2159 2011-07-13 Ben Konrath <ben@bagu.org>
2161 Add support sub-group in the details view.
2163 I also removed the code that special-cased the default details view
2166 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2168 I still have to make a proper flowtable.
2170 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2171 Don't special-case default details view layout.
2172 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2173 addLayoutField() as I'm going to use it.
2174 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2175 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2177 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2178 extracted from DetailsViewImpl.GroupPanel. Add support for
2180 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2181 column count when getting the details layout.
2183 2011-07-12 Ben Konrath <ben@bagu.org>
2185 Set browser title with database and table titles.
2187 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2188 Set the browser title when the table changes and when the activity
2190 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2191 title when retrieving document info (the GlomDocument object).
2192 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2193 with getter and setter methods. Remove unused convenience constructor.
2194 Use default code formatting.
2196 2011-07-12 Ben Konrath <ben@bagu.org>
2198 Ignore LayoutItemPortals in the details view.
2200 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2203 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2204 LayoutItemPortal layout objects.
2205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2206 LayoutItemPortal objects when retrieving the details layout.
2207 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2208 file. This is an empty class and just used to get type information for
2211 2011-07-12 Ben Konrath <ben@bagu.org>
2213 Use java-libglom 1.17.0.
2217 2011-07-11 Ben Konrath <ben@bagu.org>
2219 Remove "Table:" label from table selector.
2221 This matches a recent change in the Glom UI.
2223 * mockups/details-contacts.html:
2224 * mockups/details-projects.html:
2225 * mockups/listview-contacts.html:
2226 * mockups/listview-projects.html: Remove the "Table:" label from the
2228 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2230 2011-07-11 Ben Konrath <ben@bagu.org>
2232 Add main groups to the details view.
2234 This makes things look a little nicer in the details view. The next step
2235 is to implement the flowtable.
2237 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2238 resources from the standard gwt css theme. Standard.css is now
2239 included in OnlineGlom.html so that the online glom css rules have
2240 precedence over the gwt theme.
2241 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2242 the whole LayoutGroup to the DetailsView instead of just the titles.
2243 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2244 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2245 details layout with a helper class (GroupPanel). I might extract this
2246 class when I make the full flowtable.
2247 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2248 string as default so I don't have to worry about NPEs when processing
2250 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2251 note beside OnlineGlom.gwt.xml above).
2252 * src/main/webapp/style.css: Add default font-size to body to override
2253 the font-size set by the standard theme. Don't use h2 tags for
2254 group-title. Create new details-cell class.
2256 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2258 ConfiguredDocument: Set the port number too.
2260 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2261 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2262 Glom document. Presumably this worked sometimes so far because there is a
2263 default port number.
2265 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2267 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2269 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2270 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2271 correct, though we should throw an exception too.
2273 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2275 Fix a addDocuemnt typo.
2277 * src/main/java/org/glom/web/shared/Documents.java
2278 (Documents.addDocuemnt): Rename to addDocument().
2279 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2280 (OnlineGlomServiceImpl.getDocuments): Adapt.
2282 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2284 Slightly improved log output when connection fails.
2286 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2287 (ConfiguredDocument.setUsernameAndPassword):
2288 We don't know for sure if it' the username/password that's wrong, so
2289 rephrase the message.
2290 Also ouput the exception message, though it's generic in this case.
2292 2011-07-08 Ben Konrath <ben@bagu.org>
2296 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2297 added braces to a one line if statement because the Eclipse formatter
2298 was getting confused.
2300 2011-07-07 Ben Konrath <ben@bagu.org>
2302 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2304 These should really be two separate tasks but I counldn't get things to
2305 work with GWT 2.2.0 and Eclipse 3.7.
2309 * .settings/org.eclipse.jdt.core.prefs:
2310 * .settings/org.eclipse.jdt.ui.prefs:
2311 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2312 * .settings/org.eclipse.m2e.core.prefs:
2313 Add new config files. Update current files. Remove references to the
2314 webtools plugins as we're not using any of the webtools features.
2315 * .gitignore: Add logs directory which is created when running with
2317 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2318 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2319 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2321 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2323 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2325 onlineglom.properties: Add explanatory comments.
2327 * src/main/resources/onlineglom.properties: Also change the default user
2328 from ben to someuser, to avoid the risk of people thinking we just
2329 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2331 2011-06-28 Ben Konrath <ben@bagu.org>
2333 Use filename in Log for incorrect passwords.
2335 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2336 getFileName(String) method to get the filename from the URI.
2338 2011-06-28 Ben Konrath <ben@bagu.org>
2340 Add the table name to the URL token for the ListPlace.
2342 This makes things consistent between the DetailsPlace and the
2343 ListPlace. It also allows the the ListPlace to be bookmarked.
2345 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2346 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2347 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2348 Remove getDefaultListLayout(). The default layout is now returned
2349 by the getListLayout() method when the table name is an empty string.
2350 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2351 Add table name field. Change to a new ListPlace when the table
2352 has been changed. Use getListLayout() for getting the default
2354 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2355 Add table name field. Set the correct table name in the list box
2356 when loading from bookmark. This corrects a problem for the
2358 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2359 Move table name to super-class (HasSelectableTable). Move document
2360 and table URL keys to super-class in HasSelectableTable.
2361 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2362 Add table name field. Add Tokenizer class with URL key common to
2363 the subclasses (DetailsPlace and ListPlace).
2364 * src/main/java/org/glom/web/client/place/ListPlace.java:
2365 Add table name. Add code to parse the URL token.
2366 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2367 Update ListPlace construction with empty table name string.
2368 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2369 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2370 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2371 Update ListPlace construction with table name string.
2372 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2373 Change defaultTableName field to tableName to reflect how it's now
2374 used. Update the getter and setter methods.
2376 2011-06-28 Ben Konrath <ben@bagu.org>
2378 Enable the table selector in the DetailsView.
2380 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2381 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2382 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2383 Remove getDefaultDetailsLayout(). The default layout is now returned
2384 by the getDetailsLayout() method when the table name is an empty
2386 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2387 event handler for table change event. Change to using
2388 getDetailsLayout() for the default details layout.
2389 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2391 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2392 when navigating to the details place.
2394 2011-06-27 Ben Konrath <ben@bagu.org>
2396 Use filename based unique document ID in URL and for RPC.
2398 The document ID is the glom document name with spaces (' ') replaced
2399 with pluses ('+') and without the .glom extension.
2401 This change is mostly a string substitution of 'documentTitle' for
2402 'documentID'. The only code change is the addition of a Documents DTO to get the
2403 filename to document title mappings as indicated below.
2405 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2406 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2407 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2408 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2409 Use Documents DTO to create the document links in the document
2411 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2412 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2413 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2414 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2415 * src/main/java/org/glom/web/client/place/ListPlace.java:
2416 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2417 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2418 * src/main/java/org/glom/web/client/ui/ListView.java:
2419 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2420 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2421 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2422 * src/main/java/org/glom/web/server/Log.java:
2423 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2424 getDocumentTitles() to getDocuments() and return the Documents DTO.
2425 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2426 transferring the filename to document title mappings.
2428 2011-06-25 Ben Konrath <ben@bagu.org>
2430 Make the authentication popup work again.
2432 This bug was introduced when I extracted ConfiguredDocument to its own class.
2434 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2435 correct success / fail status in setUsernameAndPassword().
2437 2011-06-25 Ben Konrath <ben@bagu.org>
2439 Use filename as unique key for configuring database usernames and passwords.
2441 This replaces the use of the Glom document title which could change
2442 depending on the locale. Thanks to Murray Cumming for pointing out this
2445 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2446 * src/main/resources/onlineglom.properties:
2448 2011-06-24 Ben Konrath <ben@bagu.org>
2450 Pass primary key value to DetailsView.
2452 This enables the DetailsView to load the correct data.
2454 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2455 primary key value field and set in constructor. Pass primary key
2456 value to getDetailsData().
2457 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2458 variables for document title and primary key value.
2459 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2460 key value to the DetailsPlace.
2462 2011-06-24 Ben Konrath <ben@bagu.org>
2464 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2466 This allows the primary key to be retrieved by the Details button. This
2467 functionality has not been implemented yet but it's in the works.
2469 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2470 the LayoutGroup result to ListView.setCellTable instead of all of its
2471 fields individually.
2472 * src/main/java/org/glom/web/client/ui/ListView.java:
2473 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2474 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2475 get the primary key for the table.
2476 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2477 index of the primary key in the LayoutGroup accounting for hidden
2478 primary keys. Rename getJavaNumberFormat() to
2479 convertToJavaNumberFormat() for consistency. Cleanup / add some
2481 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2482 field for primary key index and a field to indicate whether the
2483 primary key is hidden or not.
2485 2011-06-23 Ben Konrath <ben@bagu.org>
2487 Rename getTableData methods to getListData.
2489 This is a rename refactor for consistency with other methods.
2491 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2492 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2493 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2494 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2496 2011-06-23 Ben Konrath <ben@bagu.org>
2498 Extract the ConfiguredDocument innerclass into its own class.
2500 This makes the servlet code more object oriented.
2502 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2503 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2504 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2505 new ConfiguredDocument class.
2507 2011-06-21 Ben Konrath <ben@bagu.org>
2509 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2511 This makes things more inline with how libglom works and reduces code
2512 duplication. This refactor lays the groundwork for adding the primary key to
2513 the LayoutGroup object.
2515 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2516 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2518 Change method names to getListLayout and getDefaultListLayout for
2519 consistency. Use LayoutGroup as the DTO for the list layout instead of
2520 ColumnInfo and LayoutListTable.
2521 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2522 new method names along with the LayoutGroup object for transferring the
2524 * src/main/java/org/glom/web/client/ui/ListView.java:
2525 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2526 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2527 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2529 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2530 Replaced with LayoutGroup.
2531 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2532 expectedResultSize and defaultTableName fields which are needed for
2534 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2535 type field which is needed for the list layout but will also be
2536 useful for the details layout as things progress.
2537 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2538 Make class abstract. Remove the unnecessary
2539 getFormattingHorizontalAlignment method. Add setFormatting method.
2541 2011-06-16 Ben Konrath <ben@bagu.org>
2543 Add scripts for building and installing war.
2545 These will help when updating OnlineGlom but they're also good
2546 supplemental documentation of the build and deployment proceeding.
2548 * utils/build-onlineglom-war.sh: New file.
2549 * utils/install-onlineglom-war.sh: New file.
2551 2011-06-16 Ben Konrath <ben@bagu.org>
2553 Create wrapper class to create consistent log messages.
2555 I wrapped methods in the Log class of gwt-log to add the method names
2556 from the servlet and create consistent formatting of the document title
2557 and table names in the log messages.
2559 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2561 log methods to use methods from wrapped Log class.
2563 2011-06-16 Ben Konrath <ben@bagu.org>
2565 Remove superfluous conditional return.
2567 Thanks to Murray Cumming for pointing this out!
2569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2571 2011-06-15 Ben Konrath <ben@bagu.org>
2573 Return an ArrayList of LayoutGroups for the Details layout.
2575 This corrects a problem with the details layout as it can have more
2576 than one top level LayoutGroup.
2578 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2579 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2580 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2581 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2582 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2583 with ArrayList of LayoutGroups for the details view layout.
2584 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2585 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2586 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2587 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2588 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2589 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2591 2011-06-14 Ben Konrath <ben@bagu.org>
2593 Use cast_dynamic method to determine the libglom LayoutItem type.
2595 This is better than finding the LayoutItem type by using the string
2596 returned from the get_part_type_name() method.
2598 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2600 2011-06-14 Ben Konrath <ben@bagu.org>
2602 Add method names to log entries in the servlet.
2604 This helps when tracking down deployment problems.
2606 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2608 2011-06-14 Ben Konrath <ben@bagu.org>
2610 Add data to the DetailsView using a hard-coded primary key value.
2612 The layout and functionality of the DetailsView is not complete. This
2613 is just a checkpoint so the patch doesn't get too big.
2615 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2616 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2617 Add getDetailsData() servlet method.
2618 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2619 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2620 LayoutFields are added to the DetailsView.
2621 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2622 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2623 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2624 take the string for the title instead of the object.
2625 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2626 Add implementation getDetailsData() along with some private helper
2628 * src/main/webapp/style.css: Add padding to details-data class. Add a
2629 details-label class with the same padding as the details-data class.
2631 2011-06-03 Ben Konrath <ben@bagu.org>
2633 Use presenter.goTo() to change to the DetailsPlace.
2635 This will make things easier when we need to open the DetailsView with
2636 data specific to the row that was clicked.
2638 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2640 2011-06-02 Ben Konrath <ben@bagu.org>
2642 Add CSS file from mockups.
2644 I'm adding this now because it's going to be useful to have when
2645 developing the DetailsView. The TableSelectionView and ListView aren't
2648 * src/main/webapp/OnlineGlom.html:
2649 * src/main/webapp/style.css:
2651 2011-06-02 Ben Konrath <ben@bagu.org>
2653 Use String.isEmpty() to check for empty string.
2655 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2657 2011-06-02 Ben Konrath <ben@bagu.org>
2659 Display main layout group titles in the DetailsView.
2661 This is the start of the DetailsActivity/DetailsView implementation.
2663 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2664 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2665 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2666 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2667 Get the layout information for the details view from the server and set
2668 the main layout group titles.
2669 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2670 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2671 Add addLayoutGroup() and addLayoutField() methods. This are just
2672 temporary methods for creating the the details view that will change
2674 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2675 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2677 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2678 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2679 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2680 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2681 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2682 Data Transfer Objects that mimic the libglom object structure. These are
2683 used for transferring the details layout but could also be used for
2684 transferring the list layout.
2686 2011-05-27 Ben Konrath <ben@bagu.org>
2688 Reset the AuthenticationPopup when clearing the ListView.
2690 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2692 2011-05-27 Ben Konrath <ben@bagu.org>
2694 Fix problem with onlineglom.properties file loading.
2696 The old way worked in Eclipse but not on the server. Loading the
2697 onlineglom.properties file now works in Eclipse and on the server.
2699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2701 2011-05-24 Ben Konrath <ben@bagu.org>
2703 Update gwt-log from 3.1.0 to 3.1.2.
2705 Gwt-log 3.1.0 has been marked as depreciated.
2709 2011-05-24 Ben Konrath <ben@bagu.org>
2711 Add comment to ListActivity.goTo() method.
2713 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2715 2011-05-24 Ben Konrath <ben@bagu.org>
2717 Remove FIXME in convertGdkColorToHtmlColour()
2719 The Gdk::Color value returned by libglom is 16-bits per channel on both
2720 64 and 32-bit platforms.
2722 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2724 2011-05-19 Ben Konrath <ben@bagu.org>
2726 Improve performance of initial ListView load.
2728 I removed a round trip to the server for getting the default table name
2729 and then requesting information about that table. This also removes a potential
2730 problem with the table change handler not being setup in time to receive the
2731 table change event from the ListActivity.
2733 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2734 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2735 getDefaultLayoutListTable() method. Improve comments.
2736 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2737 getDefaultLayoutListTable() method instead of firing a table change
2738 event to get the table to load.
2739 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2740 implementation of getDefaultLayoutListTable() method.
2741 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2744 2011-05-19 Ben Konrath <ben@bagu.org>
2746 Override toDebugString() in TableChangeEvent.
2748 This is useful to have for debugging.
2750 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2752 2011-05-19 Ben Konrath <ben@bagu.org>
2754 Add a "Back to List" link when at the DetailsPlace.
2756 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2757 Populate the CellTable based on the selected table of the ListBox if
2758 it's set otherwise use the default table. This allows the "Back to
2760 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2761 Remove Place from constructors. Add a setPlace() method. Add
2762 goToPlace() method. Set class as presenter for TableSelectionView.
2763 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2764 Use the same TableSelectionActivity when switching between the List and
2766 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2767 Subclass the new HasSelectableTablePlace. This removes some duplicate
2769 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2770 New class to represent Places that display the TableSelectionView.
2771 * src/main/java/org/glom/web/client/place/ListPlace.java:
2772 Subclass the new HasSelectableTablePlace. This removes some duplicate
2774 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2775 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2776 Add Presenter interface. Add setBackLinkVisible() method. Add
2777 setBackLink() method.
2779 2011-05-18 Ben Konrath <ben@bagu.org>
2781 Enable the "Details" buttons.
2783 Right now only an empty details view is displayed.
2785 * src/main/java/org/glom/web/client/ClientFactory.java:
2786 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2787 Add DetailsView to ClientFactory.
2788 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2789 A basic activity for the details view.
2790 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2791 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2793 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2794 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2796 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2797 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2798 unnecessary super() in constructor.
2799 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2800 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2801 really shouldn't create a new TableSelectionActivity for both the ListPlace
2802 and the DetailsPlace so this should be considered a temporary solution.
2803 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2804 New file. Represents a URL for the details view.
2805 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2806 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2807 A basic details view interface and implementation.
2808 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2809 Enable the "Details" buttons.
2811 2011-05-12 Ben Konrath <ben@bagu.org>
2813 Use a LayoutPanel with multiple display areas for main layout.
2815 This is mostly a refactor in that there are no changes from the user
2816 point of view. These changes are required so that we can swap out the list view
2817 with the details view when the user clicks the "Details" button.
2819 * src/main/java/org/glom/web/client/ClientFactory.java:
2820 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2821 OnlineGlomView. Add TableSelectionView, ListView and
2822 AuthenticationPopup.
2823 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2824 for main layout. Add display regions for main activities. Add
2825 activity manager for for main activities.
2826 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2827 file from parts of the deleted OnlineGlomActivity.
2828 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2829 New file from parts of the deleted OnlineGlomActivity.
2830 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2831 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2832 New files for app wide table change event.
2833 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2834 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2835 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2836 Activity mappers for the main activities replace the deleted app-wide
2838 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2839 Fix a spelling error in he comment.
2840 * src/main/java/org/glom/web/client/ui/ListView.java:
2841 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2842 Renamed from LayoutListView and modified for MVP. This still not a
2843 proper dumb view as prescribed by the MVP pattern but it works for now.
2844 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2845 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2846 New widget stripped out of the deleted OnlineGlomView.
2847 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2848 Remove hack that is fixed by this patch.
2850 2011-05-06 Ben Konrath <ben@bagu.org>
2852 Rename OnlineGlomPlace to ListPlace.
2854 The only change besides the rename is that url will now display #list
2855 instead of #Document.
2857 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2858 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2859 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2860 * src/main/java/org/glom/web/client/place/ListPlace.java:
2861 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2863 2011-05-06 Ben Konrath <ben@bagu.org>
2865 Use Presenter for app navigation.
2867 This is the proper way to deal with Place (URL) changes with the MVP
2870 * src/main/java/org/glom/web/client/ClientFactory.java:
2871 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2872 PlaceHistoryMapper and PlaceHistoryHandler.
2873 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2874 PlaceHistoryMapper and PlaceHistoryHandler.
2875 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2876 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2877 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2878 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2879 Add Presenter interface and setPresenter methods. Rename addHyperLink
2880 to addDocumentLink taking only the document title as a parameter.
2882 2011-04-14 Ben Konrath <ben@bagu.org>
2884 Prompt for db username/password if they haven't been set.
2886 This is implemented with a popup widget that is contained within the
2887 OnlineGlomView and managed by the OnlineGlomActivity.
2889 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2890 methods for checking and setting the database username and password.
2891 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2892 new methods for checking and setting the database username and
2894 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2895 Display authentication popup if the JDBC connection to the database
2896 has not been authenticated.
2897 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2899 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2900 for dealing with the authentication popup.
2901 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2902 Implement the methods for dealing with the authentication popup.
2903 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2904 try to executed queries if the database connection hasn't been
2905 authenticated. Implement methods for checking and setting the
2906 database username and password.
2908 2011-04-12 Ben Konrath <ben@bagu.org>
2910 Make log messages a little clearer.
2912 Add a dash betweeen the document title and the table name.
2914 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2916 2011-04-12 Ben Konrath <ben@bagu.org>
2918 Protect against NPEs when cleaning up database resources.
2920 While this isn't strictly necessary because the exception is caught,
2921 not protecting against the NPEs makes it harder to find the real error
2924 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2926 2011-04-12 Ben Konrath <ben@bagu.org>
2928 Move configuration of the servlet to the constructor.
2930 The servlet will be initialized even if the database authentication
2931 information is not set or correct. I still need to add the UI for prompting
2932 the user for the authentication information when it's required.
2934 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2935 javadocs for getDocumentTitles() method.
2936 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2937 Set error message when RPC fails.
2938 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2939 glom files directory from the configuration file. Try to set the
2940 database authentication information for the specific document if it's
2941 set and works otherwise try to use the global authentication
2942 information set for the directory.
2943 * src/main/resources/onlineglom.properties: Moved from
2944 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2945 Added detailed comments for the new keys.
2947 2011-04-11 Ben Konrath <ben@bagu.org>
2949 Remove unnecessary @Override in DocumentSelectionViewImpl.
2951 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2953 2011-04-11 Ben Konrath <ben@bagu.org>
2955 Remove center alignment in DocumentSelectionView.
2957 The title element is still centred but the document titles and bottom
2958 sentence are both left-aligned.
2960 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2962 2011-04-11 Ben Konrath <ben@bagu.org>
2964 Change 'Demo' naming convention to 'Document'.
2966 This is just a rename refactor with no functional changes to the code.
2968 * src/main/java/org/glom/web/client/ClientFactory.java:
2969 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2970 * src/main/java/org/glom/web/client/OnlineGlom.java:
2971 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2972 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2973 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2974 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2975 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2976 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2977 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2978 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2979 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2980 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2982 2011-04-08 Ben Konrath <ben@bagu.org>
2984 Remove FIXME from safeLongToInt() method.
2986 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2989 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2991 2011-04-08 Ben Konrath <ben@bagu.org>
2993 Display an error if no glom documents are found in the specified directory.
2995 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2996 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2997 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3000 2011-04-08 Ben Konrath <ben@bagu.org>
3002 Add copyright header to one more file ... oops.
3004 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3006 2011-04-08 Ben Konrath <ben@bagu.org>
3008 Add copyright header to files without it.
3010 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3011 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3012 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3013 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3014 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3015 * src/main/java/org/glom/web/shared/GlomField.java:
3017 2011-04-08 Ben Konrath <ben@bagu.org>
3019 Add support for accessing multiple glom documents in the servlet.
3021 This completes the demo selection functionality.
3023 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3024 document title to methods.
3025 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3026 document title to methods.
3027 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3028 Set browser window title when the activity starts. Correct name of
3029 document title variable.
3030 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3031 Set browser window title when the activity starts. Set the table
3032 selector change handler after table selector has been set. Clear the
3033 OnlineGlomView when the activity has been stopped.
3034 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3035 document title as the place token. Use "#Document:" instead of
3036 "#OnlineGlomPlace:" in the URL.
3037 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3038 Change heading to "Online Glom"
3039 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3040 document title in RPC methods.
3041 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3042 setDocumentTitle() method. Add clear() method.
3043 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3044 setDocumentTitle() method. Implement clear() method which removes the
3045 change handler on the ListBox, clears the ListBox and clears the
3047 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3048 Implement methods with document title. Keep track for the configured
3049 glom documents and their corresponding JDBC configurations in a hash
3050 table. This information is retrieved using the document title as the
3051 key in the hash table.
3052 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3053 document title field as it's no longer needed.
3055 2011-04-08 Ben Konrath <ben@bagu.org>
3057 Update the Eclipse JDT configuration.
3059 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3060 methods. Automatically add the copyright header to new files.
3062 2011-04-05 Ben Konrath <ben@bagu.org>
3064 Add new page for demo selection.
3066 This patch adds all the components required to view and start an
3067 OnlineGlom demo by clicking on the desired hyperlink. The user is
3068 able to return to the demo selection page with the browser's back
3069 button. I still need to modify the servlet to work with multiple
3070 documents so all demo links will load the file defined in the
3071 OnlineGlom.properties.
3073 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3074 This is only useful during development so we don't need to save it.
3075 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3076 get a reference to the DemoSelectionView.
3077 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3078 method to get a reference to the DemoSelectionView.
3079 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3080 default view to DemoSelectionView.
3081 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3082 to get glom document titles for glom files in a hard-coded directory.
3083 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3084 method to get glom document titles for glom files in a hard-coded
3086 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3087 Presenter for DemoSelectionView.
3088 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3089 for DemoSelectionView.
3090 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3091 Update for DemoSelectionView.
3092 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3093 Basic 'Place' implementation for the DemoSelectionView.
3094 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3095 The interface for the DemoSelectionView.
3096 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3097 The implementation of the DemoSelectionView.
3098 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3099 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3100 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3101 implementation of method to get glom document titles for glom files
3102 in a hard-coded directory.
3103 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3104 on longer being used.
3105 * src/main/webapp/glom.png: Glom logo.
3107 2011-04-05 Ben Konrath <ben@bagu.org>
3109 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3111 This is the forth and final commit of a refactor that will allow
3112 OnlineGlom to be used with multiple documents.
3114 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3115 Move RPC code from OnlineGlomViewImpl to this class.
3116 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3118 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3119 RPC code to the presenter class (the P in MVP).
3121 2011-04-04 Ben Konrath <ben@bagu.org>
3123 Start moving the existing OnlineGlom code to MVP.
3125 This work is based on the GWT MVP framework that is documented here:
3127 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3129 This is the third commit of a refactor that will allow OnlineGlom to
3130 be used with multiple documents.
3132 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3133 Interface for client factory which is used to get instances of various
3134 classes throughout the app.
3135 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3136 Implementation of client factory.
3137 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3138 initialize the MVP framework.
3139 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3140 New file. Activity manager for the main container widget. This is the
3142 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3143 Maps place (URL) to its corresponding activity.
3144 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3145 New file. This is just a place holder for a generated file.
3146 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
3147 New file. Represents the URL for the main Online Glom app.
3148 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
3149 for changes in LayoutListViewImpl.
3150 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
3151 interface for View. Move code to OnlineGlomViewImpl class.
3152 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
3153 file. Implementation of OnlineGlomView.
3154 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
3155 Place resources. Use ClientFactoryImpl by default.
3157 2011-04-04 Ben Konrath <ben@bagu.org>
3159 Move View classes to their own package.
3161 This is the second commit of a refactor that will allow OnlineGlom to
3162 be used with multiple documents.
3164 * src/main/java/org/glom/web/client/OnlineGlom.java:
3165 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
3166 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
3168 2011-04-02 Ben Konrath <ben@bagu.org>
3170 Move UI code from the main module to its own class.
3172 This is the first commit of a refactor that will allow OnlineGlom to be
3173 used with multiple documents.
3175 * src/main/java/org/glom/web/client/LayoutListView.java: Update
3176 references to OnlineGlom to OnlineGlomView.
3177 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
3178 OnlineGlomView and instantiate it here.
3179 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
3180 represents the main OnlineGlomView with one document.
3182 2011-04-01 Ben Konrath <ben@bagu.org>
3184 Fix formatting of gwt.xml and add DTD.
3186 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
3188 2011-03-30 Ben Konrath <ben@bagu.org>
3190 Propperly convert gdkColor string to html colour string.
3192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3194 2011-03-28 Ben Konrath <ben@bagu.org>
3196 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
3198 This implementation matches
3199 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
3200 readable and is not tied to Swig.
3202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3204 2011-03-28 Ben Konrath <ben@bagu.org>
3206 Use read-only checkboxes for boolean field types.
3208 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
3209 in the CellTable based on the field type. It currently only
3210 distinguishes between boolean and text columns but I'll need to add
3211 support for more types.
3212 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3213 column type in the ColumnInfo object. Add method to convert between the
3214 glom field type enum in ColumnInfo and the glom field type in libglom.
3215 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
3217 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
3218 getting and setting booleans.
3220 2011-03-25 Ben Konrath <ben@bagu.org>
3222 Don't get the Date twice from the ResultSet.
3224 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3226 2011-03-25 Ben Konrath <ben@bagu.org>
3228 Cleanup code in the servlet.