1 2012-01-23 Murray Cumming <murrayc@murrayc.com>
5 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
6 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
7 for localeChooser. This seems more appropriate and is less ambiguous
8 particularly in the .css file.
10 2012-01-23 Murray Cumming <murrayc@murrayc.com>
12 ConfiguredDocument: Rename the localedID private member variable.
14 2012-01-23 Murray Cumming <murrayc@murrayc.com>
16 Adapt to the latest java-libglom API from git master.
18 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
19 libglom now uses only Vector instead of List, which uses add() instead of
22 2012-01-23 Murray Cumming <murrayc@murrayc.com>
24 Add and fill a Reports drop-down list box.
26 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
28 * src/main/java/org/glom/web/client/OnlineGlomService.java:
29 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
30 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
31 Added getReports(document, table, localeID), calling
32 ConfiguredDocument.getReports().
33 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
34 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
35 Added setReportsList() and a list widget.
36 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
37 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
39 2012-01-22 Murray Cumming <murrayc@murrayc.com>
41 ConfiguredDocument: Rename the localedID private member variable.
43 2012-01-20 Murray Cumming <murrayc@murrayc.com>
45 Build a source tarball with mvn assembly:single
47 * assembly.xml: Add this file.
48 * pom.xml: Use the maven-assembly-plugin and tell it to use
49 our assembly.xml file.
51 2012-01-19 Murray Cumming <murrayc@murrayc.com>
53 OnlineGlomServiceImpl: Get .glom files recursively.
55 * pom.xml: Depend on commons-io from org.apache.commons.
56 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
57 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
58 files recursively, and with the easier filter for the extension.
59 Use org.apache.commons.io.FilenameUtils.removeExtension() to
60 simplify that code too.
62 2012-01-19 Murray Cumming <murrayc@murrayc.com>
64 README: Mention that you must install java-libglom packages separately.
66 But then it works, because java-libglom is now in the central maven
69 2012-01-18 Murray Cumming <murrayc@murrayc.com>
71 locales drop-down: Show the correct selected locale when the URL changes.
73 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
74 .java: setPlace(): Move some code into fillView().
76 2012-01-18 Murray Cumming <murrayc@murrayc.com>
78 locales drop-down: Do not lose the primary key.
80 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
81 start(): onLocaleChange(): Pass the current primary key value,
82 instead of an empty value.
84 2012-01-18 Murray Cumming <murrayc@murrayc.com>
86 locales drop-down: Do not lose the drop-down selection.
88 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
89 .java (TableSelectionActivity.fillView): Set the selected locale
90 after changing the drop-down items (though we do not really need
91 to change them just because the locale changes.)
93 2012-01-18 Murray Cumming <murrayc@murrayc.com>
95 locales drop-down: Change the tables list when this changes.
97 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
98 .java: TableSelectionActivity.start(): Move the async table titles
99 retrieval into a private fillView() method and also call this when
100 the chosen locale changes.
101 Note that the document title is not actually translatable yet, but
102 that is a problem that I should fix soon in libglom.
104 2012-01-18 Murray Cumming <murrayc@murrayc.com>
106 Improve the placement of the locales drop-down.
108 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
109 Put the title and locales drop-down in a div (gwt.FlowTable).
110 * src/main/webapp/style.css: Add magic css properties to make this work.
111 Also remove the left margin from the title so that it lines up with the
114 2012-01-18 Murray Cumming <murrayc@murrayc.com>
116 locales selector: Show human-readable locale titles.
118 * src/main/java/org/glom/web/server/ConfiguredDocument.java
119 getDocumentInfo(): Use java.util.Locale to show a real title of
120 each locale, in the locale's own language.
122 2012-01-17 Murray Cumming <murrayc@murrayc.com>
124 Add a language/locale selector drop-down.
126 * src/main/java/org/glom/web/shared/DocumentInfo.java:
127 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
128 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
129 getDocumentInfo(): Store the available Locales in the DocumentInfo.
130 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
131 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
132 Add a ListBox to show the available locales. Add getLocaleSelector(),
133 setLocaleList(), getSelectedLocale(), setSelectedLocale().
134 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
135 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
136 java: Add these classes.
137 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
138 start(): Fill the locales ListBox. Handle its change event, firing a
140 setPlace(): Show the selected locale as specified by the URL token.
141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
142 * src/main/java/org/glom/web/client/activity/ListActivity.java:
143 Handle LocaleChangeEvent, going to a new *Place with that locale.
145 The placement of the ListBox is not pretty, and it currently uses the ID
146 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
150 2012-01-17 Murray Cumming <murrayc@murrayc.com>
152 Search box: Show the search text from the URL token.
154 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
155 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
156 Add setQuickFindText().
157 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
158 .java: setPlace(): Store the queryText if the place is a ListPlace,
159 and call TableSelectionView.setQuickFindText().
161 2012-01-17 Murray Cumming <murrayc@murrayc.com>
163 Allow use of translations via, for instance, &lang=de in the URL.
165 * pom.xml: Use the unstable java-libglom 1.21 version.
167 * src/main/java/org/glom/web/client/OnlineGlomService.java:
168 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
170 init(): Instead of calling TranslatableItem.set_current_locale()
171 (now removed), call ConfiguredDocument.setDefaultLocaleID().
172 However, this is only for default locales, which are not needed to
173 change the locale in the URL.
174 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
175 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
176 getSortedRelatedListData(): Add a localeID parameter, so we can get the
177 layout for a particular locale.
178 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
179 Add get/setDefaultLocaleID().
180 getDocumentInfo(), getListViewData(), getRelatedListData(),
181 getDetailsLayoutGroup(), getListViewLayoutGroup(),
182 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
183 localeID parameter, so we can get the layout for a particular locale.
185 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
186 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
187 * src/main/java/org/glom/web/client/place/ListPlace.java:
188 Parse and construct a lang parameter too.
190 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
191 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
192 passed to subsequent methods and constructors.
193 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
194 * src/main/java/org/glom/web/client/activity/ListActivity.java:
195 Store the localeID from the *Place and pass it to other constructors
196 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
198 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
199 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
200 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
201 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
202 * src/main/java/org/glom/web/client/ui/ListView.java:
203 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
204 Take localeID parameters and pass them to subsequent constructors and
205 methods, so that the layout is always retrieved for that locale.
207 This is rather repetitive.
209 Note that "" means the original (default) locale of the Glom document,
210 which is usually English.
212 2012-01-17 Murray Cumming <murrayc@murrayc.com>
214 Documents: Remove final keyword to fix startup configuration.
216 * src/main/java/org/glom/web/shared/Documents.java: Remove the
217 final keywords on the private member variables because that breaks
218 the startup, apparently (there are warnings) because it stops them
219 from being serialized. I added these in the previous commit.
221 2012-01-13 Murray Cumming <murrayc@murrayc.com>
223 Documents: Add some final keywords.
225 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
228 2012-01-13 Murray Cumming <murrayc@murrayc.com>
230 OnlineGlomServiceImpl: Add to overview comments.
232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
233 Note that this is where all the document are loaded. They are not
234 loaded freshly for each page.
236 2012-01-12 Murray Cumming <murrayc@murrayc.com>
240 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
241 Add a TextBox for the text of a quick find.
242 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
244 setBackLink(): Add a String quickFind parameter.
245 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
246 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
247 to the base interface, because that is how TableSelectionViewImpl is used.
248 * src/main/webapp/style.css: Add style for the search box and its label.
250 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
251 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
252 Add these files, based on the existing TableChangeEvent and
253 TableChangeEventHandlers.
254 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
255 start(): Handle QuickFindChangeEvent, passing its quickFind text to
256 a ListPlace() that the user should be taken to.
257 * src/main/java/org/glom/web/client/activity/ListActivity.java
258 start(): Handle it here too and adapt the TableChangeEvent handler to
259 pass the extra "" quickFind parameter to ListPlace.
260 * src/main/java/org/glom/web/client/place/ListPlace.java:
261 Constructor: Take an extra String quickFind parameter and store it,
262 returning it from a new getQuickFind() method.
263 getToken(): Put the quickFind text in the URL token.
264 getPlace(): Parse the quickFind text from the URL token.
265 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
266 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
267 ListPlace constructor.
268 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
269 .java: start(): Add a Change handler for the TableSelectionView's
270 TextBox (via its base HasChangeHandlers interface), firing the new
271 QuickFindChangeEvent.
272 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
273 pass the extra "" quickFind parameter.
275 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
276 setCellTable(): Add a String quickFind parameter and pass it to
277 the ListViewTable() constructor.
278 * src/main/java/org/glom/web/client/ui/ListView.java: Change
279 setCellTable() in the base interface, because that is how ListViewImpl
282 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
283 Add a String quickFind member variable.
284 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
285 Constructor: Add a String quickFind parameter, storing it in the
286 base ListTable's member variable.
287 onRangeChanged(): Pass quickFind to the
288 OnlineGlomServiceAsync.getSortedListViewData() and
289 OnlineGlomServiceAsync.getListViewData() methods.
291 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
292 getListViewData(), getSortedListViewData(): Add a String quickFind
293 parameter, passing it to ConfiguredDocument.getListViewData().
294 * src/main/java/org/glom/web/client/OnlineGlomService.java:
295 Change getListViewData(), getSortedListViewData() in the base interface,
296 because that is how OnlineGlomServiceImpl is used, via this:
297 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
298 Change getListViewData(), getSortedListViewData() here too.
299 This class can apparently be used to asynchronously call methods on
300 OnlineGlomService, and GWT seems to implement that after recognizing
301 just the *Async name convention and the extra AsyncCallback parameters.
303 * src/main/java/org/glom/web/server/ConfiguredDocument.java
304 getListViewData(): Add a String quickFind parameter, and pass it to
305 ListViewDBAccess.getData().
306 * src/main/java/org/glom/web/server/database/ListDBAccess.java
307 getListData(): Add a String quickFind parameter and pass it to
309 getSelectQuery(): Add a String quickFind parameter.
310 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
311 getSelectQuery(): Add a String quickFind parameter and use it with
312 Glom.get_find_where_clause_quick() to pass a where_clause to
313 Glom.build_sql_select_with_where_clause(), to actually filter the
315 getData(): Add a String quickFind parameter, passing it to getListData().
316 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
317 va: getData(): Pass an empty string to getListData() for the
320 2012-01-12 Murray Cumming <murrayc@murrayc.com>
322 ListTable: Minor change.
324 * src/main/java/org/glom/web/client/ui/list/ListTable.java
325 createCellTable(): Make this protected instead of public.
327 2012-01-12 Murray Cumming <murrayc@murrayc.com>
329 Many files: Use final for the parameters and use the @override attribute.
331 2012-01-22 Ben Konrath <ben@bagu.org>
333 Add anchor links for single line text that starts with http, ftp and www.
337 2012-01-22 Ben Konrath <ben@bagu.org>
339 Add ellipsis to single line text in details view.
343 2012-01-04 Murray Cumming <murrayc@murrayc.com>
345 Remove all javadoc author tags.
347 Because they are awkward and meaningless when many people touch
349 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
351 2012-01-04 Murray Cumming <murrayc@murrayc.com>
353 Revert the COPYING.LESSER to COPYING rename.
355 Apparently both should be there if it is LGPL.
357 2012-01-03 Murray Cumming <murrayc@murrayc.com>
359 *View: Remove unused imports.
361 * src/main/java/org/glom/web/client/ui/DetailsView.java:
362 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
363 * src/main/java/org/glom/web/client/ui/ListView.java:
364 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
365 Remove unused imports, as suggested by Eclipse.
367 2012-01-02 Murray Cumming <murrayc@murrayc.com>
369 Move the *View::Presenter types, and some API into one base View.
371 * src/main/java/org/glom/web/client/ui/DetailsView.java:
372 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
373 * src/main/java/org/glom/web/client/ui/ListView.java:
374 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
375 Presenter, setPresenter() and clear() into a shared base interface,
376 to avoid the unnecessary duplicate Presenter types and to more clearly
377 show how the *Views share the same structure, even if they are not
378 used polymorphically.
380 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
381 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
383 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
384 * src/main/java/org/glom/web/client/activity/ListActivity.java:
385 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
387 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
390 Feel free to revert this if there is a good reason for the duplicate
393 2012-01-02 Murray Cumming <murrayc@murrayc.com>
395 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
397 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
398 a class member instead of a local variable in the method.
399 This lets us use it to get the view instances, for use in tests.
400 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
401 beforeOnlineGlom(): Test some more details of the initial view.
402 Again, this is not very useful.
404 To really test gwt-glom we will need to start a local postgresql
405 instance with local data, like the Glom tests in C++.
407 2012-01-02 Murray Cumming <murrayc@murrayc.com>
409 pom.xml: Mention the LGPL license.
411 * pom.xml: Add a licenses section.
412 * COPYING.LESSER: Move this to COPYING, which
413 previously contained the GPL. But gwt-glom is all LGPL.
415 2012-01-02 Murray Cumming <murrayc@murrayc.com>
417 Add project information to README and pom.xml.
419 * README: Add a brief description and mention some mvn
421 * pom.xml: This extra information shows up in mvn site
424 2011-01-02 Murray Cumming <murrayc@murrayc.com>
426 Use the latest java-libglom version.
428 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
430 2012-01-01 Murray Cumming <murrayc@murrayc.com>
432 GwtTestOnlineGlom: Test a little more.
434 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
435 protected rather than private, as suggested by the gwt-test-utils
437 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
438 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
439 Test the initial visibility of the panels.
441 However, this is not a very useful test.
442 And I wonder how we should generally test using this idea for an
443 activity/places app like ours where the real changes happen implicitly
444 based on the history token/URL.
446 2012-01-01 Murray Cumming <murrayc@murrayc.com>
448 Slight modification to *Mapper comments.
450 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
452 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
454 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
456 Remove comments mentioning GIN because they are just copied from
457 the example code and are apparently not helpful:
458 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
459 Also change the mention of a class that is only in the example code.
461 2012-01-01 Murray Cumming <murrayc@murrayc.com>
463 GwtTestOnlineGlom test: Minor changes.
465 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
466 Avoid the long qualified class name and modify the comment
467 because it is now obvious to me that the mocked class is the only
468 custom one created via GWT.create().
470 2012-01-01 Murray Cumming <murrayc@murrayc.com>
472 Tests: Added the beginnings of a test using gwt-test-utils.
474 * pom.xml: Add dependencies on gwt-test-utils and easymock.
475 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
476 which tells gwt-test-utils what class will be tested.
477 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
478 Add a simple (but empty) test case. One class, used by the OnlineGlom
479 class, is mocked so that it can be created. However, I am not sure
480 why only this class needs to be mocked.
482 Note that mockito seems more popular, and clearer, than easymock,
483 but I have not got that working yet. It might be a matter of the
486 This test is run during mvn integration-test.
488 2011-12-31 Murray Cumming <murrayc@murrayc.com>
490 Tests: Use junit4-style syntax instead of junit3-style.
492 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
493 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
494 * src/test/java/org/glom/web/shared/DataItemTest.java:
495 Use the @Test annotation rather than relying on the test*() prefix.
496 Also no longer implement TestCase, to avoid triggering support for
497 the junit3-way, which stops the annotations from working.
498 Change the imports from import junit.framework.* to
499 import org.junit.*, which is apparently the new way.
501 2011-12-31 Murray Cumming <murrayc@murrayc.com>
503 Added a test for ListPlace token parsing and creation.
505 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
506 This is much the same as DetailsPlaceTest.
508 I wonder how we could test the other parts of the *Place API.
510 2011-12-30 Murray Cumming <murrayc@murrayc.com>
512 DetailsPlace test: Also test getToken() and recreation via getPlace().
514 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
515 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
516 recreate it, testing the recreated DetailsPlace for the same parameter
519 2011-12-30 Murray Cumming <murrayc@murrayc.com>
521 Use the surefire-report plugin.
523 * pom.xml: This generates a HTML report about the tests in
524 target/site/surefire-report.html
525 when you do mvn surefire-report:report. It seems to be popular/normal.
527 2011-12-30 Murray Cumming <murrayc@murrayc.com>
529 Added a test for DetailsPlace.
531 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
532 Test the getPlace() token parsing.
534 2011-12-30 Murray Cumming <murrayc@murrayc.com>
536 Added a first unit test.
538 * pom.xml: Add a test goal, and a dependency on junit in that scope.
539 * src/test/java/org/glom/web/shared/DataItemTest.java:
540 This is a silly test but it is just to get things started. Note that
541 maven/junit finds the test because it looks in src/test by default.
543 2011-12-22 Ben Konrath <ben@bagu.org>
545 Change charsetName to "UTF-8" when replacing line breaks.
547 JavaScript requires the charsetName to be "UTF-8". CharsetName values
548 that work in Java (such as "UTF8") will not work when compiled to
551 This fixes a problem with multi-line details view fields that have hard
552 line breaks. The "License Text" field on this page demonstrates the
555 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
557 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
559 2011-12-22 Ben Konrath <ben@bagu.org>
561 Fix another bug with related list navigation.
563 I've tested all the navigation buttons in all of the related lists
564 so things should be good now.
566 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
568 2011-12-22 Ben Konrath <ben@bagu.org>
570 Fix a crasher when refreshing the list view with the default table.
572 This crash will also happen when loading the list view with the default
573 table from a link or bookmark.
575 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
576 to the main document selection page when the document id hasn't been
578 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
579 the main document selection page when the document id hasn't been
581 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
582 values for the details place when the document id hasn't been set.
583 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
584 values for the list place when the document id hasn't been set.
586 2011-12-21 Ben Konrath <ben@bagu.org>
588 Protect against NPE when glom.document.locale is not in config.
590 This patch protects against an NPE when glom.document.locale is not in
591 the config file. This NPE will also happen if glom.document.locale is
594 The patch also updates the error message to display the class name when
595 the getMessage() returns null. This was happening when the NPE was
596 thrown and I had "Configuration Error: null". If an NPE is encountered
597 with this patch, "Configuration Error: NullPointerException " will be
600 This commit closes this bug:
602 https://bugzilla.gnome.org/show_bug.cgi?id=666669
604 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
606 2011-12-20 Murray Cumming <murrayc@murrayc.com>
608 Rename onlineglom.properties to onlineglom.properties.sample.
610 * src/main/resources/onlineglom.properties: Rename to:
611 * src/main/resources/onlineglom.properties.sample:
612 * src/main/resources/README: And add this file explaining that people
613 should rename it back when deploying.
615 2011-12-20 Murray Cumming <murrayc@murrayc.com>
617 Allow choosing the translation in the .properties file.
619 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
620 init(): Read a glom.document.locale value from the configuration file
621 and call Glom's TransatableItem::set_current_locale() method.
622 * src/main/resources/onlineglom.properties: Add a commented-out
623 example of this new setting.
625 It would be better to add &lang=de_DE to the URL, but the current
626 libglom API does not allow us to do this easily. I am working on that.
628 2011-12-19 Murray Cumming <murrayc@murrayc.com>
630 Avoid a crash in parsing of token parameters.
632 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
633 ava: getTokenParams(): Do not crash if a parameter has a key but no
634 value, and ignore parameters with neither.
636 2011-12-17 Murray Cumming <murrayc@murayc.com>
638 History token building/handling: Improve use of token parameters.
640 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
641 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
642 and buildParamsToken(HashMap), for use by derived classes.
643 Make the separator private because it is no longer be needed.
644 * src/main/java/org/glom/web/client/place/DetailsPlace.java
645 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
646 instead of manual string concatenation.
647 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
648 of hardcoded indices and awkward splitting code.
649 * src/main/java/org/glom/web/client/place/ListPlace.java
650 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
651 instead of manual string concatenation.
652 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
653 of hardcoded indices and awkward splitting code.
654 This should fix bug #666420
656 2011-12-16 Murray Cumming <murrayc@murrayc.com>
658 Fix a Navgiation->Navigation typo in the code.
660 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
661 Rename processNavgiation() to processNavigation().
663 2011-12-16 Murray Cumming <murrayc@murrayc.com>
665 Fix a seperator->separator typo in the code.
667 * src/main/java/org/glom/web/client/place/DetailsPlace.java
668 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
669 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
672 2011-12-15 Ben Konrath <ben@bagu.org>
674 Cleanup some comments.
676 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
678 2011-12-14 Ben Konrath <ben@bagu.org>
680 Replace \n with <br/> for multiline text in the details view.
682 Vertical scrollbars are added when needed as well.
684 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
686 2011-12-14 Ben Konrath <ben@bagu.org>
688 Specify the font for document selection links.
690 * src/main/webapp/style.css:
692 2011-12-14 Ben Konrath <ben@bagu.org>
694 Fix bouncy CellTable while paging.
696 This doesn't currently work with related list tables in unselected
699 * src/main/java/org/glom/web/client/ui/list/ListTable.java
701 2011-12-14 Ben Konrath <ben@bagu.org>
703 Revamp the appearance of the document selection page.
705 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
706 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
707 * src/main/webapp/style.css:
709 2011-12-13 Ben Konrath <ben@bagu.org>
711 Set navigation button column to the smallest size possible.
713 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
715 2011-12-13 Ben Konrath <ben@bagu.org>
717 Change OpenButton nomenclature to NavigationButton.
719 Using NavigtionButton makes things more generic. Classes, methods and
720 variables have been changed.
722 This is a rename-only refactor.
724 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
725 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
726 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
727 Renamed from OpenButtonCell.
728 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
729 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
730 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
732 2011-12-12 Ben Konrath <ben@bagu.org>
734 Remove unnecessary String argument in RelatedListTable and ListViewTable.
736 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
737 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
738 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
739 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
741 2011-12-12 Ben Konrath <ben@bagu.org>
743 Update variable names and comments.
745 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
746 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
748 2011-12-12 Ben Konrath <ben@bagu.org>
750 Properly initialize numNonEmptyRows variable to zero.
752 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
753 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
755 2011-12-05 Ben Konrath <ben@bagu.org>
757 Add latest mockup with HTML tables.
759 Features of this mockup:
761 -> HTML table for flowtable
762 -> HTML table for flowtable column
763 -> Example of how related lists would look
764 -> Not using text entries for data items
766 The current version of Online Glom doesn't use HTML tables for the
769 This mockup has been sent to the glom-devel mailing list but it's good
770 to have it here as well.
772 * mockups/details-view-html-tables.html:
774 2011-12-05 Ben Konrath <ben@bagu.org>
776 Remove unnecessary getPrimaryKeyField() method.
778 getPrimaryKeyFieldForTable(String) has been renamed to
779 getPrimaryKeyField(String).
781 * src/main/java/org/glom/web/server/database/DBAccess.java:
782 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
783 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
785 2011-12-05 Ben Konrath <ben@bagu.org>
787 Add string representation of TypedDataItem value to conversion error message.
789 * src/main/java/org/glom/web/server/Utils.java: Logging the error
790 message was extracted into its own method to avoid duplication.
792 2011-12-05 Ben Konrath <ben@bagu.org>
794 Add type checking to navigation primary key value creation.
796 Create navigation primary key only if the expected type from the Glom
797 document matches the type returned by the SQL query.
799 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
801 2011-12-05 Ben Konrath <ben@bagu.org>
803 Rename a couple of variables in RelatedListNavigation.
805 This is a rename-only refactor.
807 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
809 2011-12-05 Ben Konrath <ben@bagu.org>
811 Move getListLayoutGroup() into getListViewLayoutGroup().
813 This removes getListLayoutGroup(). It was only being called by
814 getListViewLayoutGroup().
816 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
818 2011-12-05 Ben Konrath <ben@bagu.org>
820 Remove check for LayoutItem_Portal in list table method.
822 This check is no longer necessary because the method isn't being used
823 to create the LayoutItemPortal DTO.
825 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
827 2011-12-05 Ben Konrath <ben@bagu.org>
829 Properly support related list navigation.
831 Navigation from the "Repository Analyzer -> Package Scans ->
832 Dependencies" related table wasn't working because the primary key for
833 related tables wasn't being set properly. This commit fixes the
836 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
837 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
838 doesn't set the primary key properly for related list tables.
839 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
840 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
841 useful for getting the primary key for list view tables and for related
843 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
844 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
845 Move code to set the primary key for the table from the abstract
846 ListDBAccess class to ListViewDBAccess as it's only correct for list
848 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
849 Properly add primary key to related list tables.
851 2011-12-02 Ben Konrath <ben@bagu.org>
853 Properly set the horizontal alignment of fields.
855 This fix is for both the list tables and the details view.
857 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
858 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
859 to set the horizontal alignment of fields.
861 2011-12-02 Ben Konrath <ben@bagu.org>
863 Display currency codes in the details view.
865 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
867 2011-12-02 Ben Konrath <ben@bagu.org>
869 Avoid duplicate JNI call.
871 JNI is not as efficient as pure Java and this is an easy (and small)
874 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
875 Use previously retrieved value for whereClauseToTableName instead of
878 2011-12-02 Ben Konrath <ben@bagu.org>
880 Rename a couple of variables in RelatedListNavigation.
882 This is a rename-only refactor.
884 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
886 2011-12-02 Ben Konrath <ben@bagu.org>
888 Indicate clearly that a mismatched primary key type is a bug.
890 * src/main/java/org/glom/web/server/Utils.java: Change log level from
891 warning to error. Add 'This is a bug.' to message.
893 2011-12-02 Ben Konrath <ben@bagu.org>
895 Update / fix some comments.
897 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
899 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
901 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
902 Fix comments. Add some TODOs.
904 2011-12-02 Ben Konrath <ben@bagu.org>
906 Enable navigation to details view with string primary key from related list.
908 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
909 Create a text primary key value when return type of result is
910 java.sql.Types.VARCHAR.
912 2011-12-02 Ben Konrath <ben@bagu.org>
914 Use checkboxes for booleans in the details view.
916 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
918 2011-12-01 Ben Konrath <ben@bagu.org>
920 Improve performance of related list height calculation.
922 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
923 Put code to calculate the expected height in a static initializer so
924 that that it's only called once.
926 2011-12-01 Ben Konrath <ben@bagu.org>
928 Show related list tables in notebooks (again).
930 Calculate the height of the related list tables so the Notebook can be
931 set the correct height. The height of the related list table is also needed by
932 FlowTable to be able decide how to create the layout.
934 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
935 and set the Portal height based on the height of the related list
936 table and the Portal container.
937 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
938 Add method to calculate the height of the related list tables.
939 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
940 * src/main/webapp/style.css: Add css class for Pager. This is needed to
941 calculate the height of the Pager widget.
943 2011-12-01 Ben Konrath <ben@bagu.org>
945 Use CellTable API for table property instead of setting style on Element.
947 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
949 2011-12-01 Ben Konrath <ben@bagu.org>
951 Make ListViewTable and RelatedListTable a consistent height.
953 The tables are now a consistent height regardless of the contents of
954 the table. A hidden button is added to empty rows to ensure that the
955 height of these rows will match the height of rows with data.
957 A navigation button column is now added to every table. The width of
958 the navigation column is set to 0px when a RelatedListTable shouldn't
959 have navigation buttons. This maintains the a consistent row height in
960 tables that don't show the navigation buttons.
962 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
963 navigation column when not needed.
964 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
965 arguments for navigation button to constructor of ListViewTable.
966 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
967 hidden button for empty data rows.
968 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
969 arguments for navigation button to constructor.
970 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
971 create navigation buttons. Add hideNavigationButtons() method.
972 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
973 arguments for navigation button to constructor.
975 2011-12-01 Ben Konrath <ben@bagu.org>
977 Use 'visibility: hidden' in Utils.getWidgetHeight().
979 This is better choice because hidden elements are invisible, don't
980 respond to events and are not part of the tab order. They will,
981 however, take up space which is required to be able to calculate the
982 height of the widget.
984 * src/main/java/org/glom/web/client/Utils.java:
986 2011-12-01 Ben Konrath <ben@bagu.org>
988 Use Utils.getWidgetHeight() in FlowTable.
990 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
992 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
994 2011-12-01 Ben Konrath <ben@bagu.org>
996 Put the details css class name on the correct table column.
998 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1000 2011-11-30 Ben Konrath <ben@bagu.org>
1002 Update for java-libglom API change.
1004 The getters and setters on FieldFormatting and NumericFormat were
1005 changed to remove the 'M'.
1007 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1009 2011-11-29 Ben Konrath <ben@bagu.org>
1011 Only allow RelatedListTables in Portals.
1013 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1015 2011-11-29 Ben Konrath <ben@bagu.org>
1017 Only create a contents panel for Portals when title is being set.
1019 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1021 2011-11-29 Ben Konrath <ben@bagu.org>
1023 Set TabLayoutPanel height based on calculated height its widgets.
1025 This is a potential fix for this bug:
1027 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1029 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1031 2011-11-29 Ben Konrath <ben@bagu.org>
1033 Align details field labels and data with the Open buttons.
1035 * src/main/webapp/style.css:
1037 2011-11-29 Ben Konrath <ben@bagu.org>
1039 Remove unnecessary <div> in the Notebook widget.
1041 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1042 method to get container FlowPanel (<div>).
1043 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1044 initWidget() method directly on the TabLayoutPanel widget instead of
1045 Group's container widget.
1047 2011-11-29 Ben Konrath <ben@bagu.org>
1049 Don't add group titles for Portals in Notebooks.
1051 This reverts the previous patch and fixes a bug I introduced with
1052 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1054 * src/main/java/org/glom/web/client/ui/details/Group.java:
1055 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1057 2011-11-28 Ben Konrath <ben@bagu.org>
1059 Remove unused boolean argument in Portal constructor.
1061 Just a code cleanup.
1063 * src/main/java/org/glom/web/client/ui/details/Group.java:
1064 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1066 2011-11-28 Ben Konrath <ben@bagu.org>
1068 Remove hack for glom 1.18 style glom files.
1070 * src/main/java/org/glom/web/client/ui/details/Group.java:
1071 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1072 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1074 2011-11-28 Ben Konrath <ben@bagu.org>
1076 Use Gda Value version of primary key to log result too large error.
1078 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1080 2011-11-28 Ben Konrath <ben@bagu.org>
1082 Don't use TypedDataItem.getText() for Unknown types from the URL.
1084 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1085 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1086 instead of getText().
1087 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1088 String field and getUnknown() method.
1090 2011-11-28 Ben Konrath <ben@bagu.org>
1092 Log an error message when the java-libglom .so is not present.
1094 The error message was being set in the exception but not logged.
1096 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1098 2011-11-28 Ben Konrath <ben@bagu.org>
1100 Ignore LayoutItem_CalendarPortals.
1102 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1103 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1105 2011-11-28 Ben Konrath <ben@bagu.org>
1107 Extract method for creating the LayoutItemPortal DTO.
1109 Just breaking the code up into smaller chunks.
1111 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1113 2011-11-28 Ben Konrath <ben@bagu.org>
1117 This should have been added with the refactor. Oops!
1119 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1121 2011-11-28 Ben Konrath <ben@bagu.org>
1123 Create primary key value from URL string using type from Glom document.
1125 See this bug, comments 19 - 25:
1127 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1129 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1130 create a TypeDataItem for the primary key here when loading from a
1131 URL. Show the same string for the primary key value as was received
1132 from the URL string (when loading from a URL).
1133 * src/main/java/org/glom/web/server/Utils.java: Update method for
1134 creating the Gda Value from the TypeDataItem to properly deal with
1135 creating a Gda Value based on the Glom document type for the primary
1136 key value string when loading from a URL.
1137 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1138 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1139 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1140 Update for changed method name.
1142 2011-11-27 Ben Konrath <ben@bagu.org>
1144 Rename PrimaryKeyItem to TypedDataItem.
1146 The name PrimaryKeyItem suggests what the class should be used for.
1147 TypedDataItem is a neutral name that describes the class better.
1149 This is a rename-only refactor.
1151 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1152 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1153 * src/main/java/org/glom/web/client/Utils.java:
1154 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1155 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1156 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1157 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1158 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1159 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1161 * src/main/java/org/glom/web/server/Utils.java:
1162 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1163 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1164 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1165 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1167 2011-11-25 Ben Konrath <ben@bagu.org>
1169 Improve Gda Value conversion from PrimaryKeyItem.
1171 The value from the PrimaryKeyItem is only used if its type match the
1172 type from the glom document.
1174 * src/main/java/org/glom/web/server/Utils.java:
1176 2011-11-25 Ben Konrath <ben@bagu.org>
1178 Manually check if the java-liblgom .so is visible to the JVM.
1180 It seems that Tomcat has problems when a static initializer throws an
1181 exception. This check is done before the first method call into
1182 java-libglom so that execution doesn't continue if the .so is not
1185 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1187 2011-11-25 Ben Konrath <ben@bagu.org>
1189 Improve browser configuration error messages.
1193 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1195 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1196 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1197 getConfigurationErrorMessage() method.
1198 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1199 Get and display a specific configuration error message when no Glom
1200 documents are found.
1201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1202 Implement getConfigurationErrorMessage() method. Surround configuration
1203 code in the init() method with a try/catch block. This allows the
1204 errors to be caught while keeping the servlet available to retrieve the
1205 configuration error message.
1207 2011-11-25 Ben Konrath <ben@bagu.org>
1209 Don't use Strings to hold primary key values.
1211 The primary key values are now held in a new data object
1212 (PrimaryKeyItem) that holds type information and the primary key value
1213 using the correct type.
1215 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1216 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1218 PrimaryKeyItem instead of String to hold the primary key value.
1219 * src/main/java/org/glom/web/client/Utils.java: Remove
1220 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1221 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1222 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1223 PrimaryKeyItem instead of String to hold the primary key value. Load
1224 document selection page when the documentID has not been set correctly.
1225 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1226 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1228 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1229 Return empty string for URL instead of "null".
1230 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1231 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1232 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1233 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1234 PrimaryKeyItem instead of String to hold primary key values.
1235 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1236 PrimaryKeyValue to a Gda Value.
1237 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1238 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1239 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1240 Replace temporary database access code that uses the PrimaryKeyValue to
1241 Gda Value conversion.
1242 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1243 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1244 PrimaryKeyItem instead of String.
1245 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1246 hold primary key values.
1248 2011-11-24 Ben Konrath <ben@bagu.org>
1250 Use newly added java-libglom API to create queries.
1252 This isn't finished. I still need to stop using Strings for primary key
1253 values in the client code.
1255 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1256 libglom to use fake connections so that retrieving the query string will
1258 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1259 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1260 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1261 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1262 Use the newly added libglom sql methods and classes to create the
1263 query. Add temporary hack to convert primary value strings to Gda
1266 2011-11-23 Ben Konrath <ben@bagu.org>
1268 Don't explicitly set the height of Portals.
1270 See comments 6 - 10 of this bug for details:
1272 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1274 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1276 2011-11-23 Ben Konrath <ben@bagu.org>
1278 Use an HTML table instead of CSS for the FlowTable layout.
1280 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1281 GWT's FlexTable to implement the FlowTable.
1282 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1284 2011-11-18 Ben Konrath <ben@bagu.org>
1286 Add boolean example to HTML table mockup.
1288 * mockups/details-view-html-tables-text-entries.html:
1290 2011-11-17 Ben Konrath <ben@bagu.org>
1292 Ensure the pager buttons are always visible for related lists.
1294 To accomplish this, I've turned off text wrapping in the list view and
1295 related list tables for both the header and data text. The related list
1296 table now has a fixed layout so the it doesn't overflow its container.
1297 This is required to ensure that the cell text is clipped when it
1298 overflows the cell and an ellipsis is added to the right side of the
1299 cell when text is clipped.
1301 A fixed table layout for the related list table in the details view
1302 seems what we want for the details view anyway, so the side-effect is
1305 The ellipsis will only be displayed in Firefox >= 7.
1309 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1311 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1312 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1313 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1315 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1316 Set the 'table-layout: fixed' CSS property to the related list table.
1317 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1318 'white-space: nowrap;' CSS property on both the list view and the
1319 related list tables.
1321 2011-11-16 Ben Konrath <ben@bagu.org>
1323 Rework the fix for empty notebook tab labels.
1325 Setting the empty group titles with its name caused problems for the
1326 details layout. Instead of using libglom's
1327 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1328 to the client when the title is empty. This allows the Notebook to use
1329 the name when the title is empty without affecting anything else.
1331 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1332 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1334 2011-11-16 Ben Konrath <ben@bagu.org>
1336 Set group titles with name when title is empty.
1338 This fixes a problem with an empty notebook tab label in the Lesson
1339 Planner document. The forth tab in the notebook should be "Internet":
1341 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1343 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1344 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1347 2011-11-16 Ben Konrath <ben@bagu.org>
1349 Remove whitespace from the configured username properties.
1351 This assumes that usernames won't have whitespace at the beginning
1352 or end. But I think this is a reasonable assumption.
1354 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1355 String.trim() to remove the whitespace from the username properties.
1357 2011-11-15 Ben Konrath <ben@bagu.org>
1359 Add details view mockup with HTML tables and text entries.
1361 This is from the attachment on this bug:
1363 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1365 * mockups/details-view-html-tables-text-entries.html:
1367 2011-11-15 Ben Konrath <ben@bagu.org>
1369 Add space between the columns of the flow table.
1373 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1375 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1376 space between columns in the flow table.
1378 2011-11-15 Ben Konrath <ben@bagu.org>
1380 Add backup files to the .gitignore.
1382 * .gitignore: Ignore files that end with ~.
1384 2011-11-09 Ben Konrath <ben@bagu.org>
1386 Use latest release of gwt-log.
1388 Gwt-log releases are now being submitted to the maven central
1389 repository so manual installation of the jar is no longer required.
1391 * pom.xml: Update version and groupId of gwt-log dependency.
1393 2011-10-31 Ben Konrath <ben@bagu.org>
1395 Don't use GWT numeric formatting to override the glom currency formatting.
1397 Currencies are now displayed like they are in Glom. See this bug:
1399 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1401 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1403 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1404 currency code to constructor and set it when the cell is rendered.
1405 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1406 currency code to the constructor of the NumericCell.
1408 2011-10-27 Ben Konrath <ben@bagu.org>
1410 Require the latest release of java-libglom (1.17.4).
1414 2011-10-26 Ben Konrath <ben@bagu.org>
1416 Add style to Notebook that matches current theme.
1418 It's not the best style in the world but it's better than the default.
1420 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1421 padding at the bottom of the child widgets.
1422 * src/main/webapp/style.css: Add style for the Notebook.
1424 2011-10-26 Ben Konrath <ben@bagu.org>
1426 Move servlet initialization code to overridden init method.
1428 This is half of the solution to getting proper error messages
1429 displayed when configuration errors occur. Here's the relevant bug:
1431 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1433 The rest of the solution involves surrounding the init method with a
1434 try/catch block and setting a global variable with the error /
1435 exception. A new async method should be created to retrieve and display
1436 the error message / exception.
1438 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1439 code from constructor to init method adding exceptions as needed.
1441 2011-10-26 Ben Konrath <ben@bagu.org>
1443 Add script to monitor and restart tomcat if required.
1445 * utils/check-and-recover-tomcat.py: New file.
1447 2011-10-26 Ben Konrath <ben@bagu.org>
1449 Display the correct number of data items in the pager.
1453 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1455 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1456 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1457 The implementation is the same for both tables: Keep track of the
1458 number of non-empty rows and fire and RowCountChangeEvent after the data has
1460 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1461 custom Pager class that subclasses SimplePager to handle displaying
1462 the correct number when empty rows have been added.
1464 2011-10-26 Ben Konrath <ben@bagu.org>
1466 Correct error in previous commit.
1468 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1469 eventBus parameter from listView.setCellTable().
1471 2011-10-26 Ben Konrath <ben@bagu.org>
1473 Fix error in TODO comment.
1475 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1477 2011-10-24 Ben Konrath <ben@bagu.org>
1479 Create Notebook widgets to the details view.
1481 This isn't finished just yet - I still need to create a reasonable
1482 style to match the current theme.
1484 * src/main/java/org/glom/web/client/Utils.java: Add method for
1485 calculating the height of a widget. This is used in the Notebook class.
1486 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1487 new constructor method in Group.
1488 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1489 method for creating child widget that can be used by subclasses
1490 like Notebook. New constructor that allows disabling the group
1491 titles - Notebooks don't set a group title for their child groups.
1492 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1493 to make Notebooks using GWT's TabLayoutPanel.
1494 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1495 constructor that allows disabling the group titles.
1496 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1497 LayoutItemNotebook DTO.
1498 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1499 DTO for Notebooks. It's just an empty class for now but we might need
1500 it to transfer some specific information in the future.
1502 2011-10-21 Ben Konrath <ben@bagu.org>
1504 Add navigation buttons to related list tables.
1506 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1507 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1508 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1509 method getSuitableRecordToViewDetails() for getting the table name
1510 and primary key value for related list navigation buttons.
1511 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1512 private cell renderer class to get the navigation information for
1513 related list tables from the server. Extract the navigation
1514 processing code from the details cell navigation and use it for the
1515 related list navigation as well.
1516 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1517 cell renderer class for the details open buttons. This was needed
1518 because the related list navigation buttons and the list view
1519 navigation buttons need to react differently when clicked.
1520 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1521 the onEnterKeyDown() method because it's now overriden in the
1522 subclasses that are specific to the related list tables and the list
1524 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1525 the vertical size a little because the buttons add a bit of vertical
1526 space to table. This is not a perfect solution because the vertical
1527 size of with table fewer than 5 rows will be a little smaller.
1528 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1529 changes in how navigation buttons are handled.
1530 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1531 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1532 database access object.
1533 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1534 to find the portal for a given relationship name from
1535 RelatedListDBAccess. Add method to find a primary key field for a
1537 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1538 Move code to find the portal for a given relationship name to
1540 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1541 New file: database access object for getting the related list
1542 navigation information (the table name and the primary key value).
1543 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1544 DTO for transferring a table name to navigate to and a primary key
1546 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1547 boolean and getter/setter to specifies if the related list should add
1550 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1552 Use the master branch of java-libglom
1554 * pom.xml: Depend on java-libglom 1.19 instead.
1556 This is the master branch. See also the libglom-1-18 branch.
1558 2011-10-11 Ben Konrath <ben@bagu.org>
1560 Enable the open navigation button when the data has been set.
1562 This avoids having active buttons that don't do anything when the data
1565 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1567 2011-10-11 Ben Konrath <ben@bagu.org>
1569 Use IsWidget interface for FlowTableItem.
1571 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1572 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1574 2011-10-11 Ben Konrath <ben@bagu.org>
1576 Remove GWT styling from open button in details view.
1578 There are still some issues with how the details cell is arranged but
1579 this should be made to match Glom 1.20. I'm going to leave fixing this
1580 until I have Glom 1.20 up and running.
1582 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1583 style name on open button.
1584 * src/main/webapp/style.css: Move and edit details-navigation class.
1585 Re-arrange some classes to make them appear in the same order as the
1588 2011-10-07 Ben Konrath <ben@bagu.org>
1590 Update to GWT 2.4.0.
1592 * .gitignore: Ignore new cache directory.
1593 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1594 * pom.xml: Change GWT and maven plugin to 2.4.0.
1595 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1597 * src/main/java/org/glom/web/client/ClientFactory.java:
1598 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1599 * src/main/java/org/glom/web/client/OnlineGlom.java:
1600 Update source for API changes.
1601 * utils/build-onlineglom-war.sh: Remove cache directory before the
1604 2011-10-07 Ben Konrath <ben@bagu.org>
1606 Add navigation buttons in the details view.
1608 This isn't finished but I thought I'd commit what I have as it's a
1609 pretty good start. I still need to:
1611 1. Change the style so that it fits better into the current theme
1612 2. Adjust the details cell to expand as much as possible.
1614 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1615 click handlers to navigation buttons in the DetailsCells. Create a
1616 refreshData() method to get just the data from the server without the
1618 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1619 Update the tableSelector and browser title when the table name
1620 changes without using the tableSelector.
1621 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1622 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1623 getDetailsCells() to getCells(). Update variable names.
1624 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1625 method to set click handler on navigation button. Rename a few
1626 variables. Add navigation buttons where needed.
1627 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1628 variables and methods.
1629 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1630 navigation boolean and navigation table as required in the
1631 LayoutItemField DTO.
1632 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1633 variables for navigation along with getter/setter methods.
1635 2011-10-07 Ben Konrath <ben@bagu.org>
1637 Rename Field to DetailsCell.
1639 This is a refactor-only commit. No functionality has been added or
1642 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1643 Update variable and method names.
1644 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1645 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1646 variable and method names.
1647 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1649 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1650 variable and method names.
1652 2011-10-07 Ben Konrath <ben@bagu.org>
1654 Create separate methods for layout and data the details view.
1656 This is a refactor-only commit. No functionality has been added or
1659 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1660 private methods: setData(), createLayout().
1662 2011-10-07 Ben Konrath <ben@bagu.org>
1664 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1666 This is part of a change to get navigation buttons in the details view
1667 but it should have been done this way from the start.
1669 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1670 for method name change in TableSelectionView.
1671 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1672 Create TableChangeEvent and set the browser title using the
1673 TableSelectionView API.
1674 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1675 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1676 Change getSelectedTable() to getSelectedTableName(). Add
1677 getSelectedTableTitle().
1679 2011-10-07 Ben Konrath <ben@bagu.org>
1681 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1683 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1685 2011-10-07 Ben Konrath <ben@bagu.org>
1687 Update TableChangeEvent to use newTableName naming convention.
1689 This makes the class more consistent with GWT naming conventions.
1691 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1692 Update for method name change in TableChangeEvent.
1693 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1694 for method name change in TableChangeEvent.
1695 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1696 newTableName variable and getter method. Make toDebugString()
1699 2011-09-30 Ben Konrath <ben@bagu.org>
1701 Disable the pager in the list tables when the data row count is less than the minimum.
1703 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1704 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1706 2011-09-30 Ben Konrath <ben@bagu.org>
1708 Add empty rows to the end of related list and list view tables.
1710 I also extracted the cell rendering classes from the ListTable because
1711 the code was becoming a little crazy with all the anonymous inner
1712 classes. My plan is to use these cell rendering classes in the details
1713 view as well so this refactor will be needed for that change.
1715 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1716 set the row count in related list tables if the data has more rows
1717 than the minimum number of rows visible.
1718 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1719 row count in list view tables if the data has more rows than the
1720 minimum number of rows visible.
1721 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1722 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1724 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1725 for rendering TYPE_NUMERIC cells. The code was extracted from the
1727 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1728 class for rendering cells with buttons in list views. The code was
1729 extracted from the ListTable class.
1730 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1731 for rendering TYPE_TEXT cells. The code was extracted from the
1733 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1734 Add empty rows to the end of the data if required. Implement
1735 ListTable.getMinNumVisibleRows().
1736 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1737 cell renderer code to public classes. Return null in
1738 Column.getValue() for empty rows. Add new abstract method:
1739 getMinNumVisibleRows(). Move code to set the row count of the list view
1740 table to ListViewImpl.
1741 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1742 empty rows to the end of the data if required. Implement
1743 ListTable.getMinNumVisibleRows().
1746 2011-09-27 Ben Konrath <ben@bagu.org>
1748 Use GWT.log for client-side debugging statements.
1750 These are optimized out when deployed so I should have used this method
1751 in the first place. These statements will eventually be replaced with some sort
1752 of notification in the browser.
1754 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1755 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1756 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1757 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1758 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1760 2011-09-27 Ben Konrath <ben@bagu.org>
1762 Put tableselector on the right, back to list link on right.
1764 The idea is that the table selector is acting like a label for the
1765 currently displayed table so it should be placed below the document title. This
1766 puts the table title in a similar position to where it is in Glom.
1768 * mockups/details-contacts.html:
1769 * mockups/details-projects.html:
1770 * mockups/listview-contacts.html:
1771 * mockups/listview-projects.html:
1772 * mockups/style.css:
1773 Update mockups to match how the interfaces currently look.
1774 * src/main/webapp/style.css: Swap positions of backlink with the table
1775 selector. Add some space on the left side of the table selector to
1776 line things up with the document title.
1778 2011-09-27 Ben Konrath <ben@bagu.org>
1780 Add field colouring to details view.
1782 This change re-works how field colouring works. The colour formatting
1783 information is now set to the client with the layout information instead of
1784 with the data. This eliminates the need to send the same colour strings for
1785 data in list view column when colour information is set.
1787 In order to set an alternate colour for negative numeric values, the
1788 number is now sent to client and formatted with the GWT NumberFormat class.
1790 This change also fixes:
1792 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1794 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1795 internationalization framework which is needed for client side numeric
1797 * src/main/java/org/glom/web/client/Utils.java: New file for some
1798 client static utility methods.
1799 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1800 the DataItem object to the Field class. Use a utility method to
1801 create the foreignKeyValue string.
1802 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1803 alignment and text colours in the constructor. Add setData(DataItem)
1804 method. Remove setText(String) method.
1805 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1806 colour information to GlomTextCell. Create and use GlomNumberCell for
1807 rendering numbers. Use utility method to get the string for the
1808 primary key of the key provider. Re-work how the horizontal alignment
1810 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1811 formatting to layout information. Methods for converting the libglom
1812 formatting information were moved from DBAccess.
1813 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1814 numeric formatting (it's now done on the client side). Don't set text
1815 colours in DataItem. Move libglom formatting conversion methods to
1817 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1818 getters/setters for text colour information.
1819 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1820 for transferring the libglom NumericFormat information to the client.
1821 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1822 and getters/setters for: GlomNumericFormat, background colour and
1823 foreground colour strings.
1825 2011-09-26 Ben Konrath <ben@bagu.org>
1827 Simplify code that iterates through the LayoutGroup.
1829 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1831 2011-09-26 Ben Konrath <ben@bagu.org>
1833 Accept Eclipse formatting for OnlineGlomServiceAsync.
1835 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1837 2011-09-26 Ben Konrath <ben@bagu.org>
1839 Don't use the ListDBAccess classes to get the primary key layout information.
1841 This was causing a bug where the wrong index for the hidden primary key
1842 was being sent to the client.
1844 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1845 primary key while creating the LayoutGroup DTO. Create a
1846 LayoutItemField DTO for hidden primary keys. Don't use the
1847 RelatedListDBAccess because it was only used for getting the primary
1849 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1850 access modifier from public to protected for getPrimaryKeyField() and
1851 getPrimaryKeyLayoutItemField().
1852 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1853 abstract method getExpectedResultSize() because RelatedListDBAccess
1854 doesn't have enough info to implement it.
1855 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1856 Remove @Override for getExpectedResultSize().
1857 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1858 Remove method getExpectedResultSize().
1860 2011-09-23 Ben Konrath <ben@bagu.org>
1862 Log which layout (list or details) the ignored item is from.
1864 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1866 2011-09-23 Ben Konrath <ben@bagu.org>
1868 Remove annotations that turn off code formatting in DataItem.
1870 * src/main/java/org/glom/web/shared/DataItem.java:
1872 2011-09-23 Ben Konrath <ben@bagu.org>
1874 Rename GlomField to DataItem and update associated methods.
1876 This is a rename-only refactor. No functionality has been added or
1879 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1880 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1881 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1882 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1883 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1884 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1885 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1886 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1887 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1888 * src/main/java/org/glom/web/server/database/DBAccess.java:
1889 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1890 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1891 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1892 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1893 * src/main/java/org/glom/web/shared/DataItem.java:
1894 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1895 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1897 2011-09-23 Ben Konrath <ben@bagu.org>
1899 Rename GlomDocument to DocumentInfo and update associated methods.
1901 This is a rename-only refactor. No functionality has been added or
1904 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1905 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1906 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1907 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1908 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1909 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1910 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1912 2011-09-20 Ben Konrath <ben@bagu.org>
1914 Require java-libglom 1.17.3.
1916 This picks up the fix for the seg fault problem with the Scenes table
1917 in the Openismus Film Manager example.
1921 2011-09-20 Ben Konrath <ben@bagu.org>
1923 Change the way sort clause is added for primary key when no sort clause is requested.
1925 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1926 before the sort clause is created. When a sort clause is not requested, the
1927 sort clause is created by finding the primary key in the LayoutFieldVector
1930 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1932 2011-09-20 Ben Konrath <ben@bagu.org>
1934 Log error message if no documents are found in the configured directory.
1936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1937 Extract the glom file extension string to a private static final class
1938 variable (mostly as syntactic sugar). Accept a minor formatting change.
1939 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1940 the example glom.document.directory configuration property to make it
1941 more clear that it can any directory, not just the home directory.
1943 2011-09-18 Ben Konrath <ben@bagu.org>
1945 Add related lists to details view.
1947 The related list table has support for paging and sorting just like the
1948 table in the list view.
1950 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1951 SQL queries for the related list tables.
1952 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1953 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1955 Rename getList methods to getListView and add comments. Remove
1956 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1957 it being unused. Add methods: getDetailsLayoutAndData(),
1958 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1959 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1960 Create the layout and set the data for the fields in one async call
1961 instead of two. Create related lists where appropriate.
1962 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1963 for method name changes in OnlineGlomService.
1964 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1965 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1966 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1968 * src/main/java/org/glom/web/client/ui/ListView.java:
1969 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1970 tableName from setCellTable(). Create a ListViewTable instead of
1972 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1973 represent a data field in the details view.
1974 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1975 from addDetailsCell() to Field class. Keep track of the Fields and
1976 Portals in the details view.
1977 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1978 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1979 and add a method to get it. Add method to set the contents of the
1981 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1982 New class for related list tables. This class has the data provider
1983 for the related list table.
1984 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1985 abstract class which is the base class for the ListViewTable and the
1987 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1988 New class for list view tables. This class has the data provider for
1989 the list view table.
1990 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1991 methods for related list tables. Add more information to the
1992 LayoutItemField and LayoutItemPortal DTOs.
1993 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1994 Remove debugging print statement.
1995 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1996 Remove debugging print statements. Add primary key field to SQL count
1998 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1999 Remove unnecessary LayoutFieldVector parameter from
2000 getResultSizeOfSQLQuery() method.
2001 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2002 New class for related list table database access.
2003 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2004 class that is a wrapper DTO for details view layout and data.
2005 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2006 new 'fromField' string to this DTO.
2007 * src/main/webapp/style.css: Remove bottom margin and override top
2010 2011-09-15 Ben Konrath <ben@bagu.org>
2012 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2014 This sets things up to make it easier to add the data retrieval for
2015 related lists (portals). No user noticeable changes were made with
2018 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2019 class has the code to retrieve the layouts and access the
2020 database using the new database helper classes.
2021 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2022 Most of the functionality has been removed from this class. This
2023 class now represents the public interface for the client side
2024 code. It also deals with configuring the servlet and cleaning
2025 things up when the servlet is stopped.
2026 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2027 of static methods into this utility class.
2028 * src/main/java/org/glom/web/server/database/DBAccess.java:
2029 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2030 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2031 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2032 These classes have the database retrieval code. The class hierarchy
2033 has been setup to make it easy to reuse code for similar
2036 2011-09-06 Ben Konrath <ben@bagu.org>
2038 Create separate classes for list table code and the data provider.
2040 As part of this refactor, I also split up the code a bit to make it
2043 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2044 table code to two new classes (below).
2045 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2046 with code from ListViewImpl.
2047 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2048 New file with code from ListViewImpl.
2050 2011-09-06 Ben Konrath <ben@bagu.org>
2052 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2054 This fixes the LayoutItemPortal DTO to match the libglom layout object
2057 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2059 2011-09-01 Ben Konrath <ben@bagu.org>
2061 Set title of Portals in the Details View.
2063 * pom.xml: Bump required version of java-libglom to 1.17.1.
2064 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2065 widget creation to its own class. Add comments to constructor.
2066 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2067 The code is mostly from the Group class with the title now set.
2068 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2069 title of Portal. Update some comments. Fix some code formatting.
2071 2011-09-01 Ben Konrath <ben@bagu.org>
2073 Remove TODO comment for the flow table column width.
2075 The flow table column width is working correctly and doesn't need to be
2076 changed. See this mailing list post for more info:
2078 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2080 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2082 2011-08-27 Ben Konrath <ben@bagu.org>
2084 Add document title (database name) to top of the browser page.
2086 I added the document title to the TableSelecitonView but that will
2087 change if / when we add a view that doesn't require table selection.
2089 * mockups/details-contacts.html:
2090 * mockups/details-projects.html:
2091 * mockups/listview-contacts.html:
2092 * mockups/listview-projects.html:
2093 * mockups/style.css: Add document title to mockups to keep things
2095 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2096 sizes to account for the document title.
2097 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2098 Set the document title when it has been retrieved from the server.
2099 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2100 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2101 and implement setDocumentTitle(String) method.
2102 * src/main/webapp/style.css: Add ID for document title style.
2104 2011-08-25 Ben Konrath <ben@bagu.org>
2106 Add NavigationType enum to LayoutItemPortal DTO.
2108 This is the start of adding support for Portals to the Details View.
2110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2111 LayoutItem_Portal.navigation_type enum from libglom to
2112 LayoutItemPortal.NavigationType enum.
2113 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2114 NavigationType enum, field for storing the NavigationType and getter
2117 2011-08-25 Ben Konrath <ben@bagu.org>
2119 Implement the flow table layout in the Details View.
2121 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2122 FlowTable to Group to account for the renamed class.
2123 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2124 File. This is a container widget that implements the Glom details view
2125 flow table behaviour.
2126 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2127 org/glom/web/client/ui/FlowTable.java.
2128 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2129 so that the size of the subgroups are a closer match to the size of
2130 the Glom subgroups. This makes the flowtable layout match the layout
2131 in Glom for the Music Collection example file.
2133 2011-08-16 Ben Konrath <ben@bagu.org>
2135 Create container element for LayoutItemPortal in Details View.
2137 This will help me develop the layout for the FlowTable.
2139 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2140 fieldPanel variable to detailsCell.
2142 2011-08-15 Ben Konrath <ben@bagu.org>
2144 Set the height of the data element in the Details View.
2146 I changed the InlineLabels (text in a span element) to Labels (text in
2147 a div element) so that I could set the height of the details-data
2148 elements instead of the details-cell parent elements. This allows the
2149 the details-data element to display the correct height if style is
2150 applied that shows the height.
2152 This change has the added benefit of allowing the order of the labels
2153 and data elements to be changed for right-to-left languages.
2155 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2156 InlineLabels to Labels.
2157 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2158 InlineLabels to Labels. Set the height of the data element.
2159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2160 multiline text height in the Formatting DTO.
2161 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2162 for multiline height along with getter and setter methods.
2163 * src/main/webapp/style.css: Adjust style to account for the change
2164 from span elements to div elements in the details cell.
2166 2011-08-15 Ben Konrath <ben@bagu.org>
2168 Make the List View appearance match the mockups.
2170 It doesn't match exactly but it's much better than it was.
2172 * mockups/listview-contacts.html: Remove unused css classes.
2173 * mockups/listview-projects.html: Remove unused css classes.
2174 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2175 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2176 for mainPanel instead of VerticalPanel (table). Set style name on
2177 CellTable. Set style name on Details column. Right-align Details
2179 * src/main/webapp/style.css: Adjust properties to match the mockups.
2181 2011-08-12 Ben Konrath <ben@bagu.org>
2183 Add better support for subgroups in the details view.
2185 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2186 changed FlowTable constructor.
2187 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2188 support for subgroups and subgroup-titles.
2189 * src/main/webapp/style.css: Add CSS class for subgroups and
2192 2011-08-12 Ben Konrath <ben@bagu.org>
2194 Return the top level LayoutGroup title.
2196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2198 2011-08-11 Ben Konrath <ben@bagu.org>
2200 Make the TableSelector header match the mockup.
2202 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2203 the layout panel. Properly lineup the table selection header with
2204 the list and details view.
2205 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2206 margin around the details view.
2207 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2208 Rename listBox variable to tableSelector. Set id for the style sheet.
2209 Use a FlowPanel instead of a HorizontalPanel.
2210 * src/main/webapp/style.css: Add properties to make the TableSelector
2211 box match the mockups.
2213 2011-07-13 Ben Konrath <ben@bagu.org>
2215 Update install script for java-libglom version change.
2217 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2220 2011-07-13 Ben Konrath <ben@bagu.org>
2222 Add support sub-group in the details view.
2224 I also removed the code that special-cased the default details view
2227 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2229 I still have to make a proper flowtable.
2231 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2232 Don't special-case default details view layout.
2233 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2234 addLayoutField() as I'm going to use it.
2235 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2236 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2238 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2239 extracted from DetailsViewImpl.GroupPanel. Add support for
2241 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2242 column count when getting the details layout.
2244 2011-07-12 Ben Konrath <ben@bagu.org>
2246 Set browser title with database and table titles.
2248 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2249 Set the browser title when the table changes and when the activity
2251 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2252 title when retrieving document info (the GlomDocument object).
2253 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2254 with getter and setter methods. Remove unused convenience constructor.
2255 Use default code formatting.
2257 2011-07-12 Ben Konrath <ben@bagu.org>
2259 Ignore LayoutItemPortals in the details view.
2261 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2264 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2265 LayoutItemPortal layout objects.
2266 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2267 LayoutItemPortal objects when retrieving the details layout.
2268 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2269 file. This is an empty class and just used to get type information for
2272 2011-07-12 Ben Konrath <ben@bagu.org>
2274 Use java-libglom 1.17.0.
2278 2011-07-11 Ben Konrath <ben@bagu.org>
2280 Remove "Table:" label from table selector.
2282 This matches a recent change in the Glom UI.
2284 * mockups/details-contacts.html:
2285 * mockups/details-projects.html:
2286 * mockups/listview-contacts.html:
2287 * mockups/listview-projects.html: Remove the "Table:" label from the
2289 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2291 2011-07-11 Ben Konrath <ben@bagu.org>
2293 Add main groups to the details view.
2295 This makes things look a little nicer in the details view. The next step
2296 is to implement the flowtable.
2298 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2299 resources from the standard gwt css theme. Standard.css is now
2300 included in OnlineGlom.html so that the online glom css rules have
2301 precedence over the gwt theme.
2302 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2303 the whole LayoutGroup to the DetailsView instead of just the titles.
2304 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2305 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2306 details layout with a helper class (GroupPanel). I might extract this
2307 class when I make the full flowtable.
2308 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2309 string as default so I don't have to worry about NPEs when processing
2311 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2312 note beside OnlineGlom.gwt.xml above).
2313 * src/main/webapp/style.css: Add default font-size to body to override
2314 the font-size set by the standard theme. Don't use h2 tags for
2315 group-title. Create new details-cell class.
2317 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2319 ConfiguredDocument: Set the port number too.
2321 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2322 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2323 Glom document. Presumably this worked sometimes so far because there is a
2324 default port number.
2326 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2328 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2330 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2331 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2332 correct, though we should throw an exception too.
2334 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2336 Fix a addDocuemnt typo.
2338 * src/main/java/org/glom/web/shared/Documents.java
2339 (Documents.addDocuemnt): Rename to addDocument().
2340 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2341 (OnlineGlomServiceImpl.getDocuments): Adapt.
2343 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2345 Slightly improved log output when connection fails.
2347 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2348 (ConfiguredDocument.setUsernameAndPassword):
2349 We don't know for sure if it' the username/password that's wrong, so
2350 rephrase the message.
2351 Also ouput the exception message, though it's generic in this case.
2353 2011-07-08 Ben Konrath <ben@bagu.org>
2357 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2358 added braces to a one line if statement because the Eclipse formatter
2359 was getting confused.
2361 2011-07-07 Ben Konrath <ben@bagu.org>
2363 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2365 These should really be two separate tasks but I counldn't get things to
2366 work with GWT 2.2.0 and Eclipse 3.7.
2370 * .settings/org.eclipse.jdt.core.prefs:
2371 * .settings/org.eclipse.jdt.ui.prefs:
2372 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2373 * .settings/org.eclipse.m2e.core.prefs:
2374 Add new config files. Update current files. Remove references to the
2375 webtools plugins as we're not using any of the webtools features.
2376 * .gitignore: Add logs directory which is created when running with
2378 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2379 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2380 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2382 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2384 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2386 onlineglom.properties: Add explanatory comments.
2388 * src/main/resources/onlineglom.properties: Also change the default user
2389 from ben to someuser, to avoid the risk of people thinking we just
2390 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2392 2011-06-28 Ben Konrath <ben@bagu.org>
2394 Use filename in Log for incorrect passwords.
2396 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2397 getFileName(String) method to get the filename from the URI.
2399 2011-06-28 Ben Konrath <ben@bagu.org>
2401 Add the table name to the URL token for the ListPlace.
2403 This makes things consistent between the DetailsPlace and the
2404 ListPlace. It also allows the the ListPlace to be bookmarked.
2406 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2407 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2408 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2409 Remove getDefaultListLayout(). The default layout is now returned
2410 by the getListLayout() method when the table name is an empty string.
2411 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2412 Add table name field. Change to a new ListPlace when the table
2413 has been changed. Use getListLayout() for getting the default
2415 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2416 Add table name field. Set the correct table name in the list box
2417 when loading from bookmark. This corrects a problem for the
2419 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2420 Move table name to super-class (HasSelectableTable). Move document
2421 and table URL keys to super-class in HasSelectableTable.
2422 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2423 Add table name field. Add Tokenizer class with URL key common to
2424 the subclasses (DetailsPlace and ListPlace).
2425 * src/main/java/org/glom/web/client/place/ListPlace.java:
2426 Add table name. Add code to parse the URL token.
2427 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2428 Update ListPlace construction with empty table name string.
2429 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2430 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2431 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2432 Update ListPlace construction with table name string.
2433 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2434 Change defaultTableName field to tableName to reflect how it's now
2435 used. Update the getter and setter methods.
2437 2011-06-28 Ben Konrath <ben@bagu.org>
2439 Enable the table selector in the DetailsView.
2441 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2442 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2443 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2444 Remove getDefaultDetailsLayout(). The default layout is now returned
2445 by the getDetailsLayout() method when the table name is an empty
2447 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2448 event handler for table change event. Change to using
2449 getDetailsLayout() for the default details layout.
2450 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2452 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2453 when navigating to the details place.
2455 2011-06-27 Ben Konrath <ben@bagu.org>
2457 Use filename based unique document ID in URL and for RPC.
2459 The document ID is the glom document name with spaces (' ') replaced
2460 with pluses ('+') and without the .glom extension.
2462 This change is mostly a string substitution of 'documentTitle' for
2463 'documentID'. The only code change is the addition of a Documents DTO to get the
2464 filename to document title mappings as indicated below.
2466 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2467 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2468 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2469 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2470 Use Documents DTO to create the document links in the document
2472 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2473 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2474 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2475 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2476 * src/main/java/org/glom/web/client/place/ListPlace.java:
2477 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2478 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2479 * src/main/java/org/glom/web/client/ui/ListView.java:
2480 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2481 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2482 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2483 * src/main/java/org/glom/web/server/Log.java:
2484 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2485 getDocumentTitles() to getDocuments() and return the Documents DTO.
2486 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2487 transferring the filename to document title mappings.
2489 2011-06-25 Ben Konrath <ben@bagu.org>
2491 Make the authentication popup work again.
2493 This bug was introduced when I extracted ConfiguredDocument to its own class.
2495 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2496 correct success / fail status in setUsernameAndPassword().
2498 2011-06-25 Ben Konrath <ben@bagu.org>
2500 Use filename as unique key for configuring database usernames and passwords.
2502 This replaces the use of the Glom document title which could change
2503 depending on the locale. Thanks to Murray Cumming for pointing out this
2506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2507 * src/main/resources/onlineglom.properties:
2509 2011-06-24 Ben Konrath <ben@bagu.org>
2511 Pass primary key value to DetailsView.
2513 This enables the DetailsView to load the correct data.
2515 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2516 primary key value field and set in constructor. Pass primary key
2517 value to getDetailsData().
2518 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2519 variables for document title and primary key value.
2520 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2521 key value to the DetailsPlace.
2523 2011-06-24 Ben Konrath <ben@bagu.org>
2525 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2527 This allows the primary key to be retrieved by the Details button. This
2528 functionality has not been implemented yet but it's in the works.
2530 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2531 the LayoutGroup result to ListView.setCellTable instead of all of its
2532 fields individually.
2533 * src/main/java/org/glom/web/client/ui/ListView.java:
2534 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2535 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2536 get the primary key for the table.
2537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2538 index of the primary key in the LayoutGroup accounting for hidden
2539 primary keys. Rename getJavaNumberFormat() to
2540 convertToJavaNumberFormat() for consistency. Cleanup / add some
2542 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2543 field for primary key index and a field to indicate whether the
2544 primary key is hidden or not.
2546 2011-06-23 Ben Konrath <ben@bagu.org>
2548 Rename getTableData methods to getListData.
2550 This is a rename refactor for consistency with other methods.
2552 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2553 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2554 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2555 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2557 2011-06-23 Ben Konrath <ben@bagu.org>
2559 Extract the ConfiguredDocument innerclass into its own class.
2561 This makes the servlet code more object oriented.
2563 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2564 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2565 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2566 new ConfiguredDocument class.
2568 2011-06-21 Ben Konrath <ben@bagu.org>
2570 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2572 This makes things more inline with how libglom works and reduces code
2573 duplication. This refactor lays the groundwork for adding the primary key to
2574 the LayoutGroup object.
2576 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2577 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2578 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2579 Change method names to getListLayout and getDefaultListLayout for
2580 consistency. Use LayoutGroup as the DTO for the list layout instead of
2581 ColumnInfo and LayoutListTable.
2582 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2583 new method names along with the LayoutGroup object for transferring the
2585 * src/main/java/org/glom/web/client/ui/ListView.java:
2586 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2587 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2588 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2590 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2591 Replaced with LayoutGroup.
2592 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2593 expectedResultSize and defaultTableName fields which are needed for
2595 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2596 type field which is needed for the list layout but will also be
2597 useful for the details layout as things progress.
2598 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2599 Make class abstract. Remove the unnecessary
2600 getFormattingHorizontalAlignment method. Add setFormatting method.
2602 2011-06-16 Ben Konrath <ben@bagu.org>
2604 Add scripts for building and installing war.
2606 These will help when updating OnlineGlom but they're also good
2607 supplemental documentation of the build and deployment proceeding.
2609 * utils/build-onlineglom-war.sh: New file.
2610 * utils/install-onlineglom-war.sh: New file.
2612 2011-06-16 Ben Konrath <ben@bagu.org>
2614 Create wrapper class to create consistent log messages.
2616 I wrapped methods in the Log class of gwt-log to add the method names
2617 from the servlet and create consistent formatting of the document title
2618 and table names in the log messages.
2620 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2622 log methods to use methods from wrapped Log class.
2624 2011-06-16 Ben Konrath <ben@bagu.org>
2626 Remove superfluous conditional return.
2628 Thanks to Murray Cumming for pointing this out!
2630 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2632 2011-06-15 Ben Konrath <ben@bagu.org>
2634 Return an ArrayList of LayoutGroups for the Details layout.
2636 This corrects a problem with the details layout as it can have more
2637 than one top level LayoutGroup.
2639 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2640 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2641 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2642 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2643 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2644 with ArrayList of LayoutGroups for the details view layout.
2645 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2646 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2647 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2648 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2649 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2650 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2652 2011-06-14 Ben Konrath <ben@bagu.org>
2654 Use cast_dynamic method to determine the libglom LayoutItem type.
2656 This is better than finding the LayoutItem type by using the string
2657 returned from the get_part_type_name() method.
2659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2661 2011-06-14 Ben Konrath <ben@bagu.org>
2663 Add method names to log entries in the servlet.
2665 This helps when tracking down deployment problems.
2667 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2669 2011-06-14 Ben Konrath <ben@bagu.org>
2671 Add data to the DetailsView using a hard-coded primary key value.
2673 The layout and functionality of the DetailsView is not complete. This
2674 is just a checkpoint so the patch doesn't get too big.
2676 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2677 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2678 Add getDetailsData() servlet method.
2679 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2680 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2681 LayoutFields are added to the DetailsView.
2682 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2683 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2684 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2685 take the string for the title instead of the object.
2686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2687 Add implementation getDetailsData() along with some private helper
2689 * src/main/webapp/style.css: Add padding to details-data class. Add a
2690 details-label class with the same padding as the details-data class.
2692 2011-06-03 Ben Konrath <ben@bagu.org>
2694 Use presenter.goTo() to change to the DetailsPlace.
2696 This will make things easier when we need to open the DetailsView with
2697 data specific to the row that was clicked.
2699 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2701 2011-06-02 Ben Konrath <ben@bagu.org>
2703 Add CSS file from mockups.
2705 I'm adding this now because it's going to be useful to have when
2706 developing the DetailsView. The TableSelectionView and ListView aren't
2709 * src/main/webapp/OnlineGlom.html:
2710 * src/main/webapp/style.css:
2712 2011-06-02 Ben Konrath <ben@bagu.org>
2714 Use String.isEmpty() to check for empty string.
2716 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2718 2011-06-02 Ben Konrath <ben@bagu.org>
2720 Display main layout group titles in the DetailsView.
2722 This is the start of the DetailsActivity/DetailsView implementation.
2724 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2725 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2726 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2727 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2728 Get the layout information for the details view from the server and set
2729 the main layout group titles.
2730 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2731 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2732 Add addLayoutGroup() and addLayoutField() methods. This are just
2733 temporary methods for creating the the details view that will change
2735 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2736 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2738 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2739 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2740 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2741 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2742 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2743 Data Transfer Objects that mimic the libglom object structure. These are
2744 used for transferring the details layout but could also be used for
2745 transferring the list layout.
2747 2011-05-27 Ben Konrath <ben@bagu.org>
2749 Reset the AuthenticationPopup when clearing the ListView.
2751 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2753 2011-05-27 Ben Konrath <ben@bagu.org>
2755 Fix problem with onlineglom.properties file loading.
2757 The old way worked in Eclipse but not on the server. Loading the
2758 onlineglom.properties file now works in Eclipse and on the server.
2760 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2762 2011-05-24 Ben Konrath <ben@bagu.org>
2764 Update gwt-log from 3.1.0 to 3.1.2.
2766 Gwt-log 3.1.0 has been marked as depreciated.
2770 2011-05-24 Ben Konrath <ben@bagu.org>
2772 Add comment to ListActivity.goTo() method.
2774 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2776 2011-05-24 Ben Konrath <ben@bagu.org>
2778 Remove FIXME in convertGdkColorToHtmlColour()
2780 The Gdk::Color value returned by libglom is 16-bits per channel on both
2781 64 and 32-bit platforms.
2783 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2785 2011-05-19 Ben Konrath <ben@bagu.org>
2787 Improve performance of initial ListView load.
2789 I removed a round trip to the server for getting the default table name
2790 and then requesting information about that table. This also removes a potential
2791 problem with the table change handler not being setup in time to receive the
2792 table change event from the ListActivity.
2794 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2795 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2796 getDefaultLayoutListTable() method. Improve comments.
2797 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2798 getDefaultLayoutListTable() method instead of firing a table change
2799 event to get the table to load.
2800 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2801 implementation of getDefaultLayoutListTable() method.
2802 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2805 2011-05-19 Ben Konrath <ben@bagu.org>
2807 Override toDebugString() in TableChangeEvent.
2809 This is useful to have for debugging.
2811 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2813 2011-05-19 Ben Konrath <ben@bagu.org>
2815 Add a "Back to List" link when at the DetailsPlace.
2817 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2818 Populate the CellTable based on the selected table of the ListBox if
2819 it's set otherwise use the default table. This allows the "Back to
2821 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2822 Remove Place from constructors. Add a setPlace() method. Add
2823 goToPlace() method. Set class as presenter for TableSelectionView.
2824 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2825 Use the same TableSelectionActivity when switching between the List and
2827 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2828 Subclass the new HasSelectableTablePlace. This removes some duplicate
2830 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2831 New class to represent Places that display the TableSelectionView.
2832 * src/main/java/org/glom/web/client/place/ListPlace.java:
2833 Subclass the new HasSelectableTablePlace. This removes some duplicate
2835 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2836 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2837 Add Presenter interface. Add setBackLinkVisible() method. Add
2838 setBackLink() method.
2840 2011-05-18 Ben Konrath <ben@bagu.org>
2842 Enable the "Details" buttons.
2844 Right now only an empty details view is displayed.
2846 * src/main/java/org/glom/web/client/ClientFactory.java:
2847 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2848 Add DetailsView to ClientFactory.
2849 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2850 A basic activity for the details view.
2851 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2852 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2854 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2855 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2857 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2858 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2859 unnecessary super() in constructor.
2860 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2861 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2862 really shouldn't create a new TableSelectionActivity for both the ListPlace
2863 and the DetailsPlace so this should be considered a temporary solution.
2864 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2865 New file. Represents a URL for the details view.
2866 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2867 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2868 A basic details view interface and implementation.
2869 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2870 Enable the "Details" buttons.
2872 2011-05-12 Ben Konrath <ben@bagu.org>
2874 Use a LayoutPanel with multiple display areas for main layout.
2876 This is mostly a refactor in that there are no changes from the user
2877 point of view. These changes are required so that we can swap out the list view
2878 with the details view when the user clicks the "Details" button.
2880 * src/main/java/org/glom/web/client/ClientFactory.java:
2881 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2882 OnlineGlomView. Add TableSelectionView, ListView and
2883 AuthenticationPopup.
2884 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2885 for main layout. Add display regions for main activities. Add
2886 activity manager for for main activities.
2887 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2888 file from parts of the deleted OnlineGlomActivity.
2889 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2890 New file from parts of the deleted OnlineGlomActivity.
2891 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2892 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2893 New files for app wide table change event.
2894 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2895 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2896 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2897 Activity mappers for the main activities replace the deleted app-wide
2899 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2900 Fix a spelling error in he comment.
2901 * src/main/java/org/glom/web/client/ui/ListView.java:
2902 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2903 Renamed from LayoutListView and modified for MVP. This still not a
2904 proper dumb view as prescribed by the MVP pattern but it works for now.
2905 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2906 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2907 New widget stripped out of the deleted OnlineGlomView.
2908 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2909 Remove hack that is fixed by this patch.
2911 2011-05-06 Ben Konrath <ben@bagu.org>
2913 Rename OnlineGlomPlace to ListPlace.
2915 The only change besides the rename is that url will now display #list
2916 instead of #Document.
2918 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2919 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2920 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2921 * src/main/java/org/glom/web/client/place/ListPlace.java:
2922 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2924 2011-05-06 Ben Konrath <ben@bagu.org>
2926 Use Presenter for app navigation.
2928 This is the proper way to deal with Place (URL) changes with the MVP
2931 * src/main/java/org/glom/web/client/ClientFactory.java:
2932 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2933 PlaceHistoryMapper and PlaceHistoryHandler.
2934 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2935 PlaceHistoryMapper and PlaceHistoryHandler.
2936 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2937 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2938 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2939 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2940 Add Presenter interface and setPresenter methods. Rename addHyperLink
2941 to addDocumentLink taking only the document title as a parameter.
2943 2011-04-14 Ben Konrath <ben@bagu.org>
2945 Prompt for db username/password if they haven't been set.
2947 This is implemented with a popup widget that is contained within the
2948 OnlineGlomView and managed by the OnlineGlomActivity.
2950 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2951 methods for checking and setting the database username and password.
2952 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2953 new methods for checking and setting the database username and
2955 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2956 Display authentication popup if the JDBC connection to the database
2957 has not been authenticated.
2958 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2960 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2961 for dealing with the authentication popup.
2962 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2963 Implement the methods for dealing with the authentication popup.
2964 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2965 try to executed queries if the database connection hasn't been
2966 authenticated. Implement methods for checking and setting the
2967 database username and password.
2969 2011-04-12 Ben Konrath <ben@bagu.org>
2971 Make log messages a little clearer.
2973 Add a dash betweeen the document title and the table name.
2975 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2977 2011-04-12 Ben Konrath <ben@bagu.org>
2979 Protect against NPEs when cleaning up database resources.
2981 While this isn't strictly necessary because the exception is caught,
2982 not protecting against the NPEs makes it harder to find the real error
2985 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2987 2011-04-12 Ben Konrath <ben@bagu.org>
2989 Move configuration of the servlet to the constructor.
2991 The servlet will be initialized even if the database authentication
2992 information is not set or correct. I still need to add the UI for prompting
2993 the user for the authentication information when it's required.
2995 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2996 javadocs for getDocumentTitles() method.
2997 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2998 Set error message when RPC fails.
2999 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3000 glom files directory from the configuration file. Try to set the
3001 database authentication information for the specific document if it's
3002 set and works otherwise try to use the global authentication
3003 information set for the directory.
3004 * src/main/resources/onlineglom.properties: Moved from
3005 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3006 Added detailed comments for the new keys.
3008 2011-04-11 Ben Konrath <ben@bagu.org>
3010 Remove unnecessary @Override in DocumentSelectionViewImpl.
3012 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3014 2011-04-11 Ben Konrath <ben@bagu.org>
3016 Remove center alignment in DocumentSelectionView.
3018 The title element is still centred but the document titles and bottom
3019 sentence are both left-aligned.
3021 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3023 2011-04-11 Ben Konrath <ben@bagu.org>
3025 Change 'Demo' naming convention to 'Document'.
3027 This is just a rename refactor with no functional changes to the code.
3029 * src/main/java/org/glom/web/client/ClientFactory.java:
3030 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3031 * src/main/java/org/glom/web/client/OnlineGlom.java:
3032 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3033 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3034 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3035 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3036 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3037 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3038 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3039 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3040 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3041 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3043 2011-04-08 Ben Konrath <ben@bagu.org>
3045 Remove FIXME from safeLongToInt() method.
3047 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3050 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3052 2011-04-08 Ben Konrath <ben@bagu.org>
3054 Display an error if no glom documents are found in the specified directory.
3056 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3057 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3058 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3059 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3061 2011-04-08 Ben Konrath <ben@bagu.org>
3063 Add copyright header to one more file ... oops.
3065 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3067 2011-04-08 Ben Konrath <ben@bagu.org>
3069 Add copyright header to files without it.
3071 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3072 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3073 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3074 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3075 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3076 * src/main/java/org/glom/web/shared/GlomField.java:
3078 2011-04-08 Ben Konrath <ben@bagu.org>
3080 Add support for accessing multiple glom documents in the servlet.
3082 This completes the demo selection functionality.
3084 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3085 document title to methods.
3086 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3087 document title to methods.
3088 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3089 Set browser window title when the activity starts. Correct name of
3090 document title variable.
3091 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3092 Set browser window title when the activity starts. Set the table
3093 selector change handler after table selector has been set. Clear the
3094 OnlineGlomView when the activity has been stopped.
3095 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3096 document title as the place token. Use "#Document:" instead of
3097 "#OnlineGlomPlace:" in the URL.
3098 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3099 Change heading to "Online Glom"
3100 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3101 document title in RPC methods.
3102 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3103 setDocumentTitle() method. Add clear() method.
3104 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3105 setDocumentTitle() method. Implement clear() method which removes the
3106 change handler on the ListBox, clears the ListBox and clears the
3108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3109 Implement methods with document title. Keep track for the configured
3110 glom documents and their corresponding JDBC configurations in a hash
3111 table. This information is retrieved using the document title as the
3112 key in the hash table.
3113 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3114 document title field as it's no longer needed.
3116 2011-04-08 Ben Konrath <ben@bagu.org>
3118 Update the Eclipse JDT configuration.
3120 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3121 methods. Automatically add the copyright header to new files.
3123 2011-04-05 Ben Konrath <ben@bagu.org>
3125 Add new page for demo selection.
3127 This patch adds all the components required to view and start an
3128 OnlineGlom demo by clicking on the desired hyperlink. The user is
3129 able to return to the demo selection page with the browser's back
3130 button. I still need to modify the servlet to work with multiple
3131 documents so all demo links will load the file defined in the
3132 OnlineGlom.properties.
3134 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3135 This is only useful during development so we don't need to save it.
3136 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3137 get a reference to the DemoSelectionView.
3138 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3139 method to get a reference to the DemoSelectionView.
3140 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3141 default view to DemoSelectionView.
3142 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3143 to get glom document titles for glom files in a hard-coded directory.
3144 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3145 method to get glom document titles for glom files in a hard-coded
3147 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3148 Presenter for DemoSelectionView.
3149 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3150 for DemoSelectionView.
3151 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3152 Update for DemoSelectionView.
3153 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3154 Basic 'Place' implementation for the DemoSelectionView.
3155 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3156 The interface for the DemoSelectionView.
3157 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3158 The implementation of the DemoSelectionView.
3159 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3160 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3162 implementation of method to get glom document titles for glom files
3163 in a hard-coded directory.
3164 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3165 on longer being used.
3166 * src/main/webapp/glom.png: Glom logo.
3168 2011-04-05 Ben Konrath <ben@bagu.org>
3170 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3172 This is the forth and final commit of a refactor that will allow
3173 OnlineGlom to be used with multiple documents.
3175 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3176 Move RPC code from OnlineGlomViewImpl to this class.
3177 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3179 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3180 RPC code to the presenter class (the P in MVP).
3182 2011-04-04 Ben Konrath <ben@bagu.org>
3184 Start moving the existing OnlineGlom code to MVP.
3186 This work is based on the GWT MVP framework that is documented here:
3188 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3190 This is the third commit of a refactor that will allow OnlineGlom to
3191 be used with multiple documents.
3193 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3194 Interface for client factory which is used to get instances of various
3195 classes throughout the app.
3196 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3197 Implementation of client factory.
3198 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3199 initialize the MVP framework.
3200 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3201 New file. Activity manager for the main container widget. This is the
3203 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3204 Maps place (URL) to its corresponding activity.
3205 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3206 New file. This is just a place holder for a generated file.
3207 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
3208 New file. Represents the URL for the main Online Glom app.
3209 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
3210 for changes in LayoutListViewImpl.
3211 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
3212 interface for View. Move code to OnlineGlomViewImpl class.
3213 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
3214 file. Implementation of OnlineGlomView.
3215 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
3216 Place resources. Use ClientFactoryImpl by default.
3218 2011-04-04 Ben Konrath <ben@bagu.org>
3220 Move View classes to their own package.
3222 This is the second commit of a refactor that will allow OnlineGlom to
3223 be used with multiple documents.
3225 * src/main/java/org/glom/web/client/OnlineGlom.java:
3226 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
3227 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
3229 2011-04-02 Ben Konrath <ben@bagu.org>