1 2012-05-11 Murray Cumming <murrayc@murrayc.com>
3 Make navigation work again.
5 * src/main/java/org/glom/web/server/libglom/Document.java:
6 Add getLayoutItemFieldShouldHaveNavigation().
7 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
8 Replace get/setAddNavigation() with the partly-existing
9 get/setNavigationTableName(), with an empty string being no navigation,
10 because this is simpler. Use the new
11 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
13 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
14 Add updateFieldsExtras() and call setNavigationTableName in it.
15 getDetailsLayoutGroup(),
16 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
17 createLayout(): Adapted.
18 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
21 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
22 Replace get/setAddNavigation() with get/setNavigation(), returning a
23 TableToViewDetails class with both the table name and UsesRelationship,
24 because both are need. The previous code used java-libglom's output
25 variable (strangely, via sharedptr) to return both, but we cannot really
27 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
28 getNavigationRecord(): Adapt. However, we cannot actually use the cache
29 here because it somehow gets set to null during deepCopy(). I must test this.
30 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
31 testGetSuitableTableToViewDetails(): Adapted.
33 TODO: Find out why deepClone() is not quite working.
35 2012-05-11 Murray Cumming <murrayc@murrayc.com>
37 DBAccess: Simplify the retrievel of full field details.
39 * src/main/java/org/glom/web/server/database/DBAccess.java
40 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
41 because the Document loading should have done this.
43 2012-05-11 Murray Cumming <murrayc@murrayc.com>
45 Document: Correct loading of doubly-related layout fields.
47 * src/main/java/org/glom/web/server/libglom/Document.java:
48 loadUsesRelationship(): Actually set the related relationship, instead
49 of only setting it if it's not found.
51 2012-05-09 Murray Cumming <murrayc@murrayc.com>
53 ListViewTable: Constructor: Take the table name as a parameter.
55 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
56 Constructor: Take the tableName, and set the member variable, because
58 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
59 setCellTable(): Pass the table name.
60 This makes navigation to non-default tables work again. I don't know
61 why it worked before in the master branch.
63 2012-05-07 Murray Cumming <murrayc@murrayc.com>
65 ConfiguredDocument: Restore correct addition of hidden primary key items.
67 * src/main/java/org/glom/web/client/ui/list/ListTable.java
68 (ListTable.createCellTable): Uncomment out the check for the hidden
70 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
71 add primary key items for top-level lists and portals, as before,
72 instead of adding them to each group.
73 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
74 Actually implement the extra methods such as setHiddenPrimaryKey() and
75 comment that these are used only for top-level list groups and in portals.
76 This strangeness suggests even more that this should not be squeezed
77 into the LayoutGroup class.
79 2012-05-07 Murray Cumming <murrayc@murrayc.com>
81 Fix Formatting loading.
83 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
84 getFormattingUsed(): Remove the duplicate Formatting member variable
85 in favour of the one from the base class.
86 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
87 Initialize a new Formatting instead of using null by default, so we
88 have some defaults, instead of having to initialize one later just to
89 get the same defaults. This also makes loading of formatting from the
90 document work, because that expected a non-null.
92 2012-05-07 Murray Cumming <murrayc@murrayc.com>
94 RelatedListTable: Make sure that the tableName is set.
96 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
97 Constructor: Take the tableName so it is available later. Otherwise,
98 the server assumes that we mean the default table and cannot find the
100 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
101 setData(): Pass the tableName to the RelatedListTable constructor.
103 2012-05-07 Murray Cumming <murrayc@murrayc.com>
107 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
108 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
109 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
111 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
113 * src/main/java/org/glom/web/server/database/DBAccess.java:
114 convertResultSetToDTO(), getPortal():
115 * src/main/java/org/glom/web/server/database/ListDBAccess.java
117 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
118 Add checks for null objects and out of range access, with log messages to
119 give hints so we can fix these properly.
121 2012-05-07 Murray Cumming <murrayc@murrayc.com>
123 Portals: some corrections.
125 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
127 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
128 constructor: Use getRelationshipNameUsed() instead of getName(), because
129 that is what is meant.
130 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
131 getFromField(): Fix a typo, to get the field name, not the table name.
132 * src/main/java/org/glom/web/server/database/DBAccess.java:
133 getPortal(): Fix a typo that stopped this from working.
135 2012-05-07 Murray Cumming <murrayc@murrayc.com>
137 LayoutItemPortal: Also override getTitleOriginal().
139 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
140 This lets the base getTitle() with no parameters work.
141 TODO: Test this properly.
143 2012-05-06 Murray Cumming <murrayc@murrayc.com>
145 LayoutItemPortal: getTitle*(): Use the relationship title.
147 2012-05-06 Murray Cumming <murrayc@murrayc.com>
149 LayoutItemField: Fix loading of custom titles.
151 * src/main/java/org/glom/web/server/libglom/Document.java
152 loadDataLayoutItemField(): The title, if any, instead of the field
153 title, is stored in a title_custom node. Load it from there.
154 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
156 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
157 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
158 getTitle*() overrides.
159 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
162 2012-05-06 Murray Cumming <murrayc@murrayc.com>
164 LayoutItemField: Fall back to field titles, so some are really shown.
166 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
167 Override getTitleOriginal() and getTitle(), as in java-libglom.
168 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
171 2012-05-06 Murray Cumming <murrayc@murrayc.com>
173 Correct use of setExpectedResultSize().
175 * src/main/java/org/glom/web/server/ConfiguredDocument.java
176 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
177 Use setExpectedResultSize only on top-level groups (for instance, the
178 list layout) or on child portals (in details views).
179 Use the correct table name for portals to avoid SQL errors.
180 Update the expected counts when returning cached layouts.
182 2012-05-06 Murray Cumming <murrayc@murrayc.com>
184 Document: Interpret no group column count as 1.
186 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
187 default, though we now check for this in the UI code anyway.
189 2012-05-06 Murray Cumming <murrayc@murrayc.com>
193 2012-05-06 Murray Cumming <murrayc@murrayc.com>
195 Translatable: Use Hashmap instead of Treemap because GWT supports it.
197 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
198 The use of Treemap lead to this error from async methods, with no
200 "The response could not be deserialized"
202 2012-05-06 Murray Cumming <murrayc@murrayc.com>
204 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
206 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
207 when using the Google -> GWT Compile, or
208 g toolbar button -> GWT Compile Project... feature in Eclipse.
210 2012-05-06 Murray Cumming <murrayc@murrayc.com>
212 ListTable.addColumn(): Protect against a null Formatting.
214 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
215 Create a default Formatting if it is null, because that is the simplest
218 2012-05-06 Murray Cumming <murrayc@murrayc.com>
220 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
222 * src/main/java/org/glom/web/server/ConfiguredDocument.java
223 updateLayoutGroup(): Check that the field is not null.
225 2012-05-06 Murray Cumming <murrayc@murrayc.com>
227 ListViewImpl: Protected against a bad cast error.
229 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
230 onEnterKeyDown(): Do not cast without an instanceof check.
232 2012-05-06 Murray Cumming <murrayc@murrayc.com>
234 ListTable: Protect against an out of range error.
236 * src/main/java/org/glom/web/client/ui/list/ListTable.java
237 createCellTable(): This is unlikely, but can happen while debugging.
239 2012-05-06 Murray Cumming <murrayc@murrayc.com>
241 AsyncMessage onFailure() callbacks: Log the exception message.
243 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
244 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
245 * src/main/java/org/glom/web/client/activity/ListActivity.java:
246 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
247 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
248 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
249 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
250 These are useful clues when something is wrong.
252 2012-05-06 Murray Cumming <murrayc@murrayc.com>
254 ConfiguredDocument: Avoid a null dereference.
256 * src/main/java/org/glom/web/server/ConfiguredDocument.java
257 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
258 details maps are created.
260 2012-05-06 Murray Cumming <murrayc@murrayc.com>
262 Document: Correct the port number parsing.
264 * src/main/java/org/glom/web/server/libglom/Document.java:
265 This lets us actually connect to the database and show the document.
267 2012-05-05 Murray Cumming <murrayc@murrayc.com>
271 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
272 user-interaction, asking us to load a temporary URL in a browser.s
273 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
274 which is apparently necessary for testing the service. See the comment.
275 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
276 Show the exception, if any. This is how I saw the 404 in the HTML in
279 2012-05-05 Murray Cumming <murrayc@murrayc.com>
281 DocumentTest: Move the .glom files into the resources directory.
283 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
284 URI via getResource().
286 2012-05-05 Murray Cumming <murrayc@murrayc.com>
288 Document: Remove the FieldIdentifies inner class.
290 * src/main/java/org/glom/web/server/libglom/Document.java: We only
291 use the Relationship (though the same function in libglom is maybe
292 used in other ways) and so this removes a compiler warning.
294 2012-05-05 Murray Cumming <murrayc@murrayc.com>
296 Document.load() Remove the error code parameter.
298 * src/main/java/org/glom/web/server/libglom/Document.java: load():
299 Remove the parameter. We do not set it yet and it could never have
300 worked as an output parameter (though maybe it did in java-libglom).
301 We could use an exception if we really want the failure reason.
302 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
304 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
305 setUp(), testGetSuitableTableToViewDetails(): Adapt.
307 2012-05-05 Murray Cumming <murrayc@murrayc.com>
309 Make some inner classes static.
311 * src/main/java/org/glom/web/server/ConfiguredDocument.java
312 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
313 * src/main/java/org/glom/web/server/ReportGenerator.java
314 * src/main/java/org/glom/web/server/libglom/Document.java
315 Make all inner classes static that can be static.
317 2012-05-05 Murray Cumming <murrayc@murrayc.com>
319 OnlineGlomServiceImpl: Do not load and check for java-libglom.
321 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
322 init(): We do not use java-libglom any more.
324 2012-05-05 Murray Cumming <murrayc@murrayc.com>
326 Remove mentions of java-libglom.
328 * README: Remove mention of java-libglom, because it no longer needed.
329 * utils/build-onlineglom-war.sh:
330 * utils/check-and-recover-tomcat.py:
331 * utils/install-onlineglom-war.sh: Remove these as they are no longer
332 useful. Building is now far easier, with no need for jhbuild.
334 2012-05-05 Murray Cumming <murrayc@murrayc.com>
336 Fix the build (mvn package)
338 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
339 (LayoutGroup): Make the LayoutItemList inner class static and protected.
340 Otherwise the GWT Java->Javascript compilation fails with just this
341 error, during mvn package or when attempting to view in a browser,
342 in the GWT developer mode in Eclipse.
344 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
345 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
346 [INFO] Compiling module org.glom.web.OnlineGlom
347 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
348 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
349 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
350 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
351 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
352 [INFO] [ERROR] Cannot proceed due to previous errors
354 It has taken me 2 days to find out what was causing that. After reducing
355 the code, the compiler eventually showed me the full error message.
357 2012-05-04 Murray Cumming <murrayc@murrayc.com>
359 ConfiguredDocument: Cache the cloned and stripped layouts.
361 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
362 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
363 layout in a map, so we can retrieve it again without rebuilding it.
365 2012-05-04 Murray Cumming <murrayc@murrayc.com>
367 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
369 2012-05-04 Murray Cumming <murrayc@murrayc.com>
371 libglom classes: Implement some auto-generated emthods.
373 2012-05-04 Murray Cumming <murrayc@murrayc.com>
375 Add GwtTestOnlineGlomService.
377 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
378 However, this (and the other GwtTest*) does not seem to run during
381 2012-05-04 Murray Cumming <murrayc@murrayc.com>
383 Remove use of unsupported features from client code.
385 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
386 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
387 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
388 Use our client version of StringUtils instead of the apache commons one.
390 However, the GWT Javascript compliation still fails.
392 2012-04-25 Murray Cumming <murrayc@murrayc.com>
394 Add a Field class and implement some loading of it in Document.
396 2012-04-25 Murray Cumming <murrayc@murrayc.com>
398 Initial Document loading implementation, instead of libglom.
400 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
401 and Translatable classes, and adapt the rest of the code to use them.
402 However, this is still missing Layout and Field classes and loading.
404 2012-04-24 Murray Cumming <murrayc@murrayc.com>
406 Use of jOOQ: Move Field creation into a utility method.
408 * src/main/java/org/glom/web/server/SqlUtils.java:
409 This lets us improve it more easily.
411 2012-04-24 Murray Cumming <murrayc@murrayc.com>
413 Use of jOOQ: Improve the code to COUNT a sub-select.
415 * src/main/java/org/glom/web/server/SqlUtils.java:
416 Move initial query creation into
417 build_sql_select_step_with_where_clause().
418 build_sql_select_count_rows(): Use the jOOQ API instead of
419 concatentating text, because a jOOQ Select*Step is a TableLike,
420 which is what from() takes.
422 2012-04-23 Murray Cumming <murrayc@murrayc.com>
424 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
426 * pom.xml: Depend on jooq.
427 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
428 methods with jOOQ, based on the C++ implementations in libglom,
429 with some changes to the logic required by jooQ.
430 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
432 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
433 * src/main/java/org/glom/web/server/ReportGenerator.java:
434 * src/main/java/org/glom/web/server/SqlUtils.java:
435 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
436 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
437 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
438 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
439 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
440 Adapt. In particular, the SqlUtils methods now need to take a Connection,
441 because jOOQ needs that, though it seems unnecessary.
443 This is not quite finished. Ideally jOOQ would help us to build
444 table_name.field_name names, quoting and escaping them properly.
445 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
447 2012-04-21 Murray Cumming <murrayc@murrayc.com>
449 Move use of Glom.build_sql*() into a new SqlUtils class.
451 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
452 to wrap Glom.build_sql*(). The parameter types are still Glom one,
453 but this will make it easier to start using something other than
454 libglom or SqlBuilder.
456 2012-04-21 Murray Cumming <murrayc@murrayc.com>
458 Update the project URL.
460 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
462 2012-04-21 Murray Cumming <murrayc@murrayc.com>
464 Main layout: Use a FlowTable instead of absolute positioning.
466 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
467 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
468 child panels/widgets must have an absolute position. But that is annoying, so
469 this adds a FlowTable and puts the child panels in there.
471 2012-04-21 Murray Cumming <murrayc@murrayc.com>
473 GwtTestOnlineGlom: Comment out unused code.
475 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
476 Eclipse has started to say that some code is unused.
478 2012-04-21 Murray Cumming <murrayc@murrayc.com>
480 Update to the latest versions of dependencies.
482 * pom.xml: Update version numbers of dependencies to the latest
484 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
486 * src/main/java/org/glom/web/server/ReportGenerator.java:
487 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
488 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
489 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
491 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
492 Modify the imports where necessary.
494 2012-04-17 Murray Cumming <murrayc@murrayc.com>
496 Style: Remove overflow:hidden from searchbox
498 * src/main/webapp/style.css: Because this pushes the Back To Link
499 label/link on to the next row, which is then hidden due to the
500 hard-coded (in ems) height.
502 2012-04-20 Murray Cumming <murrayc@murrayc.com>
504 Remove some duplicate code.
506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
507 getDocumentInfo(): This must have been duplicated during the merge from the
512 2012-04-19 Murray Cumming <murrayc@murrayc.com>
514 Reports: Localize the waiting for report message.
516 * src/main/java/org/glom/web/client/activity/ReportActivity.java
517 start(): Get the message from the contants.
518 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
520 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
521 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
522 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
523 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
524 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
525 Update these files with the English text for newer strings for now.
527 2012-04-19 Murray Cumming <murrayc@murrayc.com>
529 Reports: Show a message while waiting for the report.
531 * src/main/java/org/glom/web/client/ui/ReportView.java
532 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
533 Add setWaitingText(), to show a message saying that we are
534 waiting for the report to be ready.
535 * src/main/java/org/glom/web/client/activity/ReportActivity.java
536 start(): Call setWaitingText() before calling the async
539 2012-04-19 Murray Cumming <murrayc@murrayc.com>
541 ReportGenerator: Specify date and time formats.
543 * src/main/java/org/glom/web/server/ReportGenerator.java:
544 createFieldValueElement(): Use the default (and localized)
545 short formats, though we still need a way to show 4-digit
546 years without providing the format for every locale.
547 * src/main/java/org/glom/web/server/database/DBAccess.java:
548 convertResultSetToDTO(): Use the short formats here too.
550 2012-04-18 Murray Cumming <murrayc@murrayc.com>
552 ReportGenerator: Use the correct numeric formatting.
554 * src/main/java/org/glom/web/server/ReportGenerator.java
555 createFieldExpression(), createFieldValueElement(): Take the
556 whole LayoutItem_Field instead of just the field name, so
557 we have access to the formatting.
558 createFieldValueElement(): Use JRTextField.setPattern() to
559 specify the numeric formatting, with the help of a
560 regular DecimalFormat.
562 2012-04-18 Murray Cumming <murrayc@murrayc.com>
564 ReportGenerator: Avoid showing null for group by titles.
566 * src/main/java/org/glom/web/server/ReportGenerator.java
567 generateReport(): Use setBlankWhenNull() on the field title
568 style too, because this is used for values in group by
571 2012-04-18 Murray Cumming <murrayc@murrayc.com>
573 ReportGenerator: Add a colon to titles in vertical groups.
575 * src/main/java/org/glom/web/server/ReportGenerator.java
576 addFieldToDetailBandVertical(): Pass true for the withColon
579 2012-04-18 Murray Cumming <murrayc@murrayc.com>
581 ReportGenerator: Simplify the code by using Position more.
583 2012-04-18 Murray Cumming <murrayc@murrayc.com>
585 Reports: Support vertical groups, roughly.
587 * src/main/java/org/glom/web/server/ReportGenerator.java:
588 addToReport(): Rename to addGroupToReport() and, if necessary,
589 call the new addVerticalGroupToReport() method.
590 createFieldValueElement(): Let the caller specify the Y position
593 2012-04-17 Murray Cumming <murrayc@murrayc.com>
595 Reports: Allow a second report to be shown.
597 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
598 clear(): Do not remove the HTML widget, which broke the whole layout.
600 2012-04-17 Murray Cumming <murrayc@murrayc.com>
602 Locales drop-down: Show that we use English by default.
604 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
605 fillView(): When we use English, just because that is the default, when
606 no locale is specified, show that in the Locales drop-down instead of
607 just showing the first item.
609 2012-04-17 Murray Cumming <murrayc@murrayc.com>
611 Unselect the Report/Locale/Table combo item when appropriate.
613 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
614 setPlace(): clear reportName if this is not a ReportPlace.
615 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
616 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
617 When the provided name is empty, unselect all items, so that none are
618 indicated. This uses a for loop because I cannot find a single method
621 2012-04-17 Murray Cumming <murrayc@murrayc.com>
623 Report: Give the user a way to get back to the list.
625 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
626 start(), setPlace(): Show the Back To List link on reports, and also
627 interpret selecting the empty report item as back to list.
629 2012-04-13 Murray Cumming <murrayc@murrayc.com>
631 Really show the selected Report name.
633 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
634 setPlace(): Store the reportName here, if it is that kind of Place.
635 fillView(): Set the selected Report after filling the list of reports.
636 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
637 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
638 null Strings, though we need some way to unselect all ListBox items
641 2012-04-13 Murray Cumming <murrayc@murrayc.com>
643 ReportGenerator: Try to avoid some problems.
645 * src/main/java/org/glom/web/server/ReportGenerator.java
646 addField(): Try to avoid duplicates, and avoid using a null
649 2012-04-13 Murray Cumming <murrayc@murrayc.com>
651 Reports: Use quickFind.
653 * src/main/java/org/glom/web/client/OnlineGlomService.java;
654 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
655 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
656 getReportHTML(): Add a quickFind parameter.
657 * src/main/java/org/glom/web/client/activity/ReportActivity.java
658 start(): Pass the quickFind parameter.
659 * src/main/java/org/glom/web/server/ReportGenerator.java
660 generateReport(): Take a quickFind parameter.
662 2012-04-13 Murray Cumming <murrayc@murrayc.com>
664 ReportPlace: Actually use the report name.
666 * src/main/java/org/glom/web/client/place/ReportPlace.java
667 getPlace(): Do not assign the report name to the quickfind.
669 2012-04-13 Murray Cumming <murrayc@murrayc.com>
671 Show java.library.path when complaining.
673 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
674 init(): When telling us to check java.library.path, show the
677 2012-03-06 Murray Cumming <murrayc@murrayc.com>
679 ReportGenerator: Do not show nulls.
681 2012-03-06 Murray Cumming <murrayc@murrayc.com>
683 ReportGenerator: Make the title font larger.
685 2012-03-06 Murray Cumming <murrayc@murrayc.com>
687 ReportGenerator: Put field titles inside groups, if there are groups.
689 2012-03-06 Murray Cumming <murrayc@murrayc.com>
691 ReportGenerator: Take the Report itself instead of the name and group.
693 * src/main/java/org/glom/web/server/ConfiguredDocument.java
694 Remove getReportLayoutGroup().
695 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
696 getReportHTML(): Pass the report instead
697 of its name and layout group.
698 * src/main/java/org/glom/web/server/ReportGenerator.java
699 generateReport(): Use the report object to use the title
702 2012-03-06 Murray Cumming <murrayc@murrayc.com>
704 ReportGenerator: Remove designBand parameters.
706 * src/main/java/org/glom/web/server/ReportGenerator.java:
707 Make designBand a class member instead of passing it to all
710 2012-03-06 Murray Cumming <murrayc@murrayc.com>
712 ReportGenerator: Add lines, a bit like in the desktop version.
714 * src/main/java/org/glom/web/server/ReportGenerator.java
715 addToReport(): Use JRDesignLine.
717 2012-03-06 Murray Cumming <murrayc@murrayc.com>
719 ReportGenerator: Correct the title positions and use some bold style.
721 * src/main/java/org/glom/web/server/ReportGenerator.java:
722 Break the code up into reusable functions, correct the placement of
723 titles, and use normal/bold styles as in the reports in the desktop
726 2012-03-06 Murray Cumming <murrayc@murrayc.com>
728 ReportGenerator: Add a header band to show the field titles.
730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
731 getReportHTML(): Pass the localeId to the ReportGenerator
733 * src/main/java/org/glom/web/server/ReportGenerator.java
734 constructor: Take the localeID so we can get translated field
736 generateReport(), addToReport(), addFieldToBand(): Add field
737 titles in a column header band.
739 2012-03-05 Murray Cumming <murrayc@murrayc.com>
741 Reports drop-down list: Some improvement.
743 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
744 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
745 Adedd setSelectedReport(),
746 setReportList(): Add a blank line so that the user can select the
748 * src/main/java/org/glom/web/client/activity/ReportActivity.java
749 start(): Show the current report by calling setSelectedReport().
750 This does not seem to work yet.
752 2012-03-05 Murray Cumming <murrayc@murrayc.com>
754 DetailsActivity, ListActivity: Move some variables into a base class.
756 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
757 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
758 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
759 the clientFactory, documentID, tableName and authenticationPopup into
760 a base class, to avoid duplication.
762 2012-03-05 Murray Cumming <murrayc@murrayc.com>
764 Translate the Reports label.
766 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
767 Get the "Reports" label string from the constants.
768 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
769 perties: Add Reports to the constants.
771 2012-03-05 Murray Cumming <murrayc@murrayc.com>
773 Reports: Implement grouping.
775 * src/main/java/org/glom/web/server/ReportGenerator.java:
776 Handle LayoutItem_GroupBy items and try to do the right thing
777 with JRDesignGroup. It seems to work.
779 2012-03-04 Murray Cumming <murrayc@murrayc.com>
781 Actually show some data with JasperReports.
783 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
784 getReportHTML(): Move most code into a ReportGenerator class.
785 * src/main/java/org/glom/web/server/ReportGenerator.java:
786 Recurse into sub-groups, adding fields to the JasperDesign's details
787 band. Note that we must set an arbitrary width and height, or it just
788 will not show any data.
790 2012-03-04 Murray Cumming <murrayc@murrayc.com>
792 Reports Chooser: Show the titles, not the names.
794 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
795 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
796 and the names as the values.
797 * src/main/java/org/glom/web/server/ConfiguredDocument.java
798 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
799 group now that we provide the report name, so it should always
802 2012-02-15 Murray Cumming <murrayc@murrayc.com>
804 Depend on jasperreports.
806 * pom.xml: Add the dependency. My plan is to use this on the
809 2012-01-31 Murray Cumming <murrayc@murrayc.com>
811 Implement navigation to report places.
813 * src/main/java/org/glom/web/client/activity/ReportActivity.java
814 start(): Do not bother to handle all events here.
815 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
816 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
817 Added getSelectedReport().
818 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
819 .java: start(): When handling a change to the reports chooser,
820 call getSelectedReport() and goTo() its ReportPlace.
821 * src/main/java/org/glom/web/client/ui/ReportView.java
822 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
823 Added setReportHTML() which puts the html in a gwt HTML widget.
824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
825 getReportHTML(): Return "TODO" just to show that this works.
827 2012-01-31 Murray Cumming <murrayc@murrayc.com>
829 Make ReportPlace usable.
831 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
833 * src/main/java/org/glom/web/client/place/ReportPlace.java:
834 Correct the @prefix annotation.
836 2012-01-31 Murray Cumming <murrayc@murrayc.com>
838 OnlineGlomService: Return report HTML rather than the LayoutGroup.
840 * src/main/java/org/glom/web/client/OnlineGlomService.java:
841 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
842 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
843 Change getReportLayout() to getReportHMTL() because we will not need to
844 parse or render the report layout on the client side.
845 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
846 getReportLayout(): Return the libglom LayoutGroup type because we will
847 not need to convert to a shared type, because this will not be used on
849 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
852 Note that there is still no implementation for this.
855 2012-01-27 Murray Cumming <murrayc@murrayc.com>
857 Add a (empty) Report Place, View, and Activity.
859 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
861 * src/main/java/org/glom/web/client/place/HasTablePlace.java
862 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
863 this into a superclass:
864 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
865 and also use it as the base of this new ReportPlace:
866 * src/main/java/org/glom/web/client/place/ReportPlace.java
868 * src/main/java/org/glom/web/client/ui/ReportView.java
869 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
870 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
871 Add these, containing mostly boiler-plate for now.
873 * src/main/java/org/glom/web/client/OnlineGlomService.java
874 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
875 * src/main/java/org/glom/web/server/ConfiguredDocument.java
876 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
877 Add API to get the LayoutGroup for the report.
879 2012-01-23 Murray Cumming <murrayc@murrayc.com>
881 Add and fill a Reports drop-down list box.
883 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
885 * src/main/java/org/glom/web/client/OnlineGlomService.java:
886 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
887 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
888 Added getReports(document, table, localeID), calling
889 ConfiguredDocument.getReports().
890 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
891 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
892 Added setReportsList() and a list widget.
893 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
894 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
899 2012-04-12 Murray Cumming <murrayc@murrayc.com>
901 Translations: Add Esperanto.
903 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
904 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
905 properties: Add this translation because someone took the time to make it.
907 2012-03-15 Murray Cumming <murrayc@murrayc.com>
909 Adapt to the java-libglom 1.21.7 API.
911 * src/main/java/org/glom/web/server/ReportGenerator.java:
912 addToReport(): get_group_secondary_fields() is now
913 get_secondary_fields().
916 2012-03-15 Murray Cumming <murrayc@murrayc.com>
918 Use the latest java-libglom version.
920 * pom.xml: Use java-libglom 1.21.7.
922 2012-03-03 Ben Konrath <ben@bagu.org>
924 Display date and time in details view.
926 https://bugzilla.gnome.org/show_bug.cgi?id=671257
928 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
930 2012-03-05 Murray Cumming <murrayc@murrayc.com>
932 Require the latest java-libglom.
934 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
936 2012-03-04 Murray Cumming <murrayc@murrayc.com>
938 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
940 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
941 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
942 an empty quickfind string. I also corrected libglom to create only
943 empty where clauses for empty quickfind strings, but this avoids the
946 2012-02-24 Ben Konrath <ben@bagu.org>
948 Improve the tabs in the Notebook widget.
952 2012-01-30 Murray Cumming <murrayc@murrayc.com>
954 Translations: Try to translate the strings.
956 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
957 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
958 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
959 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
960 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
961 Take the Open translation from GTK+'s .po files.
962 Take the Details translation from Glom's po files.
963 I have added the other strings to Glom so we can get translations that way:
964 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
966 2012-01-27 Murray Cumming <murrayc@murrayc.com>
968 TableSelectionViewImpl: Put the search label and entry in a div.
970 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
971 Put the search widgets in a FlowTable so that the CSS can be used to
972 style them while keeping them together.
973 * src/main/webapp/style.css: Mention the new div.
975 2012-01-27 Murray Cumming <murrayc@murrayc.com>
977 Translate more strings in more locales.
979 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
980 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
981 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
982 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
983 Translate the "Details" and "Open" string too.
985 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
986 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
987 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
988 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
989 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
990 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
991 Add these new locales as placeholders though they currently contain English.
993 2012-01-27 Murray Cumming <murrayc@murrayc.com>
995 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
997 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
998 Check the ConfiguredDocument* for null before using it.
1000 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1002 Tell Eclipse about the generated java files.
1004 * .classpath: This lets it find OnlineGlomConstants.java.
1005 It would be nice if Eclipse just used the maven build files.
1007 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1009 Prevent a crash when no locale is specified in the URL.
1011 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1012 Avoid returning a null string, obtained from
1013 Window.Location.getParameter(). This caused a crash when it was
1014 later passed to libglom's API.
1015 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1016 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1017 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1018 guard against future null strings.
1020 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1022 Use the ?locale= query param instead of the &lang= token param.
1024 * src/main/java/org/glom/web/client/place/ListPlace.java
1025 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1026 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1027 Remove the lang token key and value.
1029 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1030 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1031 When the user selects a different locale from the chooser, use
1032 Window.Location.assign() to change the URL, which then causes a reload.
1034 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1035 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1036 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1037 * src/main/java/org/glom/web/client/activity/ListActivity.java
1038 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1039 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1040 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1041 * src/main/java/org/glom/web/client/ui/ListView.java:
1042 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1044 Remove localeID member variables and method/constructor parameters, instead
1045 using Utils.getCurrentLocaleID() when we need a localID to pass to
1048 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1050 Internationalize the UI strings.
1052 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1053 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1054 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1055 because it is unused. Messages are apparently strings that can have
1056 parameters, but we do not need that yet, so Contants will be enough for now.
1057 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1058 to say that we support the en and de locales.
1059 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1060 The original English strings.
1061 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1062 Some German translations of the English strings.
1063 The i18n goal then uses the .properties file to generate an
1064 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1065 returns an implementation that returns the translated strings.
1066 The documentation suggests putting these in src/java/*/client/, but it seems
1067 best to put it in src/resources/*/client/.
1068 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1069 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1070 instead of hard-coding them.
1071 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1072 but that does not seem to stop the build, though it confuses Eclipse.
1074 You can see the translated string by adding ?locale=de to the URL, like so:
1075 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1077 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1079 Improve null/empty String checks.
1081 * pom.xml: Add a dependency on commons-lang, to use
1082 org.apache.commons.lang.StringUtils.
1083 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1084 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1085 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1086 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1087 Use StringUtils.isEmpty().
1089 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1090 StringUtils class with a static isEmpty() function because we
1091 cannot use org.apache.commons.lang.StringUtils in client-side
1092 GWT code because it (apparently) cannot be compiled to javascript.
1093 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1094 * src/main/java/org/glom/web/client/activity/ListActivity.java
1095 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1096 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1097 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1098 * src/main/java/org/glom/web/client/place/ListPlace.java
1099 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1100 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1101 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1102 * src/main/java/org/glom/web/client/ui/details/Group.java
1103 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1104 our StringUtils.isEmpty() function.
1106 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1108 Update to the latest java-libglom API.
1110 * pom.xml: Require java-libglom 1.21.4.
1111 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1112 getDocumentInfo(), getListViewLayoutGroup():
1113 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1115 * src/main/java/org/glom/web/server/database/DBAccess.java
1116 getFieldsToShowForSQLQueryAddGroup(),
1117 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1118 with either get_database_title_original() or
1119 get_database_title(localeID).
1121 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1123 ConfiguredDocument: Avoid a null pointer exception.
1125 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1126 Initialize localeID to "" to avoid returning a null String which
1127 causes a crash in java-libglom's swing-generated code.
1129 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1131 Some simple renaming.
1133 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1134 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1135 for localeChooser. This seems more appropriate and is less ambiguous
1136 particularly in the .css file.
1138 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1140 ConfiguredDocument: Rename the localedID private member variable.
1142 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1144 Adapt to the latest java-libglom API from git master.
1146 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1147 libglom now uses only Vector instead of List, which uses add() instead of
1150 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1152 ConfiguredDocument: Rename the localedID private member variable.
1154 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1156 Build a source tarball with mvn assembly:single
1158 * assembly.xml: Add this file.
1159 * pom.xml: Use the maven-assembly-plugin and tell it to use
1160 our assembly.xml file.
1162 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1164 OnlineGlomServiceImpl: Get .glom files recursively.
1166 * pom.xml: Depend on commons-io from org.apache.commons.
1167 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1168 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1169 files recursively, and with the easier filter for the extension.
1170 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1171 simplify that code too.
1173 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1175 README: Mention that you must install java-libglom packages separately.
1177 But then it works, because java-libglom is now in the central maven
1180 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1182 locales drop-down: Show the correct selected locale when the URL changes.
1184 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1185 .java: setPlace(): Move some code into fillView().
1187 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1189 locales drop-down: Do not lose the primary key.
1191 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1192 start(): onLocaleChange(): Pass the current primary key value,
1193 instead of an empty value.
1195 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1197 locales drop-down: Do not lose the drop-down selection.
1199 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1200 .java (TableSelectionActivity.fillView): Set the selected locale
1201 after changing the drop-down items (though we do not really need
1202 to change them just because the locale changes.)
1204 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1206 locales drop-down: Change the tables list when this changes.
1208 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1209 .java: TableSelectionActivity.start(): Move the async table titles
1210 retrieval into a private fillView() method and also call this when
1211 the chosen locale changes.
1212 Note that the document title is not actually translatable yet, but
1213 that is a problem that I should fix soon in libglom.
1215 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1217 Improve the placement of the locales drop-down.
1219 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1220 Put the title and locales drop-down in a div (gwt.FlowTable).
1221 * src/main/webapp/style.css: Add magic css properties to make this work.
1222 Also remove the left margin from the title so that it lines up with the
1225 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1227 locales selector: Show human-readable locale titles.
1229 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1230 getDocumentInfo(): Use java.util.Locale to show a real title of
1231 each locale, in the locale's own language.
1233 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1235 Add a language/locale selector drop-down.
1237 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1238 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1239 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1240 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1241 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1242 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1243 Add a ListBox to show the available locales. Add getLocaleSelector(),
1244 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1245 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1246 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1247 java: Add these classes.
1248 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1249 start(): Fill the locales ListBox. Handle its change event, firing a
1251 setPlace(): Show the selected locale as specified by the URL token.
1252 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1253 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1254 Handle LocaleChangeEvent, going to a new *Place with that locale.
1256 The placement of the ListBox is not pretty, and it currently uses the ID
1257 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1261 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1263 Search box: Show the search text from the URL token.
1265 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1266 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1267 Add setQuickFindText().
1268 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1269 .java: setPlace(): Store the queryText if the place is a ListPlace,
1270 and call TableSelectionView.setQuickFindText().
1272 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1274 Allow use of translations via, for instance, &lang=de in the URL.
1276 * pom.xml: Use the unstable java-libglom 1.21 version.
1278 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1279 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1280 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1281 init(): Instead of calling TranslatableItem.set_current_locale()
1282 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1283 However, this is only for default locales, which are not needed to
1284 change the locale in the URL.
1285 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1286 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1287 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1288 layout for a particular locale.
1289 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1290 Add get/setDefaultLocaleID().
1291 getDocumentInfo(), getListViewData(), getRelatedListData(),
1292 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1293 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1294 localeID parameter, so we can get the layout for a particular locale.
1296 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1297 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1298 * src/main/java/org/glom/web/client/place/ListPlace.java:
1299 Parse and construct a lang parameter too.
1301 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1302 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1303 passed to subsequent methods and constructors.
1304 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1305 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1306 Store the localeID from the *Place and pass it to other constructors
1307 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1309 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1310 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1311 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1312 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1313 * src/main/java/org/glom/web/client/ui/ListView.java:
1314 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1315 Take localeID parameters and pass them to subsequent constructors and
1316 methods, so that the layout is always retrieved for that locale.
1318 This is rather repetitive.
1320 Note that "" means the original (default) locale of the Glom document,
1321 which is usually English.
1323 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1325 Documents: Remove final keyword to fix startup configuration.
1327 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1328 final keywords on the private member variables because that breaks
1329 the startup, apparently (there are warnings) because it stops them
1330 from being serialized. I added these in the previous commit.
1332 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1334 Documents: Add some final keywords.
1336 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1339 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1341 OnlineGlomServiceImpl: Add to overview comments.
1343 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1344 Note that this is where all the document are loaded. They are not
1345 loaded freshly for each page.
1347 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1351 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1352 Add a TextBox for the text of a quick find.
1353 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1355 setBackLink(): Add a String quickFind parameter.
1356 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1357 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1358 to the base interface, because that is how TableSelectionViewImpl is used.
1359 * src/main/webapp/style.css: Add style for the search box and its label.
1361 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1362 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1363 Add these files, based on the existing TableChangeEvent and
1364 TableChangeEventHandlers.
1365 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1366 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1367 a ListPlace() that the user should be taken to.
1368 * src/main/java/org/glom/web/client/activity/ListActivity.java
1369 start(): Handle it here too and adapt the TableChangeEvent handler to
1370 pass the extra "" quickFind parameter to ListPlace.
1371 * src/main/java/org/glom/web/client/place/ListPlace.java:
1372 Constructor: Take an extra String quickFind parameter and store it,
1373 returning it from a new getQuickFind() method.
1374 getToken(): Put the quickFind text in the URL token.
1375 getPlace(): Parse the quickFind text from the URL token.
1376 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1377 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1378 ListPlace constructor.
1379 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1380 .java: start(): Add a Change handler for the TableSelectionView's
1381 TextBox (via its base HasChangeHandlers interface), firing the new
1382 QuickFindChangeEvent.
1383 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1384 pass the extra "" quickFind parameter.
1386 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1387 setCellTable(): Add a String quickFind parameter and pass it to
1388 the ListViewTable() constructor.
1389 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1390 setCellTable() in the base interface, because that is how ListViewImpl
1393 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1394 Add a String quickFind member variable.
1395 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1396 Constructor: Add a String quickFind parameter, storing it in the
1397 base ListTable's member variable.
1398 onRangeChanged(): Pass quickFind to the
1399 OnlineGlomServiceAsync.getSortedListViewData() and
1400 OnlineGlomServiceAsync.getListViewData() methods.
1402 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1403 getListViewData(), getSortedListViewData(): Add a String quickFind
1404 parameter, passing it to ConfiguredDocument.getListViewData().
1405 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1406 Change getListViewData(), getSortedListViewData() in the base interface,
1407 because that is how OnlineGlomServiceImpl is used, via this:
1408 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1409 Change getListViewData(), getSortedListViewData() here too.
1410 This class can apparently be used to asynchronously call methods on
1411 OnlineGlomService, and GWT seems to implement that after recognizing
1412 just the *Async name convention and the extra AsyncCallback parameters.
1414 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1415 getListViewData(): Add a String quickFind parameter, and pass it to
1416 ListViewDBAccess.getData().
1417 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1418 getListData(): Add a String quickFind parameter and pass it to
1420 getSelectQuery(): Add a String quickFind parameter.
1421 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1422 getSelectQuery(): Add a String quickFind parameter and use it with
1423 Glom.get_find_where_clause_quick() to pass a where_clause to
1424 Glom.build_sql_select_with_where_clause(), to actually filter the
1426 getData(): Add a String quickFind parameter, passing it to getListData().
1427 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1428 va: getData(): Pass an empty string to getListData() for the
1429 quickFind parameter.
1431 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1433 ListTable: Minor change.
1435 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1436 createCellTable(): Make this protected instead of public.
1438 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1440 Many files: Use final for the parameters and use the @override attribute.
1442 2012-01-22 Ben Konrath <ben@bagu.org>
1444 Add anchor links for single line text that starts with http, ftp and www.
1448 2012-01-22 Ben Konrath <ben@bagu.org>
1450 Add ellipsis to single line text in details view.
1454 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1456 Remove all javadoc author tags.
1458 Because they are awkward and meaningless when many people touch
1460 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1462 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1464 Revert the COPYING.LESSER to COPYING rename.
1466 Apparently both should be there if it is LGPL.
1468 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1470 *View: Remove unused imports.
1472 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1473 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1474 * src/main/java/org/glom/web/client/ui/ListView.java:
1475 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1476 Remove unused imports, as suggested by Eclipse.
1478 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1480 Move the *View::Presenter types, and some API into one base View.
1482 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1483 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1484 * src/main/java/org/glom/web/client/ui/ListView.java:
1485 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1486 Presenter, setPresenter() and clear() into a shared base interface,
1487 to avoid the unnecessary duplicate Presenter types and to more clearly
1488 show how the *Views share the same structure, even if they are not
1489 used polymorphically.
1491 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1492 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1494 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1495 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1496 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1498 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1501 Feel free to revert this if there is a good reason for the duplicate
1504 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1506 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1508 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1509 a class member instead of a local variable in the method.
1510 This lets us use it to get the view instances, for use in tests.
1511 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1512 beforeOnlineGlom(): Test some more details of the initial view.
1513 Again, this is not very useful.
1515 To really test gwt-glom we will need to start a local postgresql
1516 instance with local data, like the Glom tests in C++.
1518 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1520 pom.xml: Mention the LGPL license.
1522 * pom.xml: Add a licenses section.
1523 * COPYING.LESSER: Move this to COPYING, which
1524 previously contained the GPL. But gwt-glom is all LGPL.
1526 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1528 Add project information to README and pom.xml.
1530 * README: Add a brief description and mention some mvn
1532 * pom.xml: This extra information shows up in mvn site
1535 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1537 Use the latest java-libglom version.
1539 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1541 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1543 GwtTestOnlineGlom: Test a little more.
1545 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1546 protected rather than private, as suggested by the gwt-test-utils
1548 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1549 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1550 Test the initial visibility of the panels.
1552 However, this is not a very useful test.
1553 And I wonder how we should generally test using this idea for an
1554 activity/places app like ours where the real changes happen implicitly
1555 based on the history token/URL.
1557 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1559 Slight modification to *Mapper comments.
1561 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1562 (DataActivityMapper)
1563 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1565 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1567 Remove comments mentioning GIN because they are just copied from
1568 the example code and are apparently not helpful:
1569 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1570 Also change the mention of a class that is only in the example code.
1572 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1574 GwtTestOnlineGlom test: Minor changes.
1576 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1577 Avoid the long qualified class name and modify the comment
1578 because it is now obvious to me that the mocked class is the only
1579 custom one created via GWT.create().
1581 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1583 Tests: Added the beginnings of a test using gwt-test-utils.
1585 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1586 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1587 which tells gwt-test-utils what class will be tested.
1588 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1589 Add a simple (but empty) test case. One class, used by the OnlineGlom
1590 class, is mocked so that it can be created. However, I am not sure
1591 why only this class needs to be mocked.
1593 Note that mockito seems more popular, and clearer, than easymock,
1594 but I have not got that working yet. It might be a matter of the
1597 This test is run during mvn integration-test.
1599 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1601 Tests: Use junit4-style syntax instead of junit3-style.
1603 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1604 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1605 * src/test/java/org/glom/web/shared/DataItemTest.java:
1606 Use the @Test annotation rather than relying on the test*() prefix.
1607 Also no longer implement TestCase, to avoid triggering support for
1608 the junit3-way, which stops the annotations from working.
1609 Change the imports from import junit.framework.* to
1610 import org.junit.*, which is apparently the new way.
1612 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1614 Added a test for ListPlace token parsing and creation.
1616 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1617 This is much the same as DetailsPlaceTest.
1619 I wonder how we could test the other parts of the *Place API.
1621 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1623 DetailsPlace test: Also test getToken() and recreation via getPlace().
1625 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1626 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1627 recreate it, testing the recreated DetailsPlace for the same parameter
1630 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1632 Use the surefire-report plugin.
1634 * pom.xml: This generates a HTML report about the tests in
1635 target/site/surefire-report.html
1636 when you do mvn surefire-report:report. It seems to be popular/normal.
1638 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1640 Added a test for DetailsPlace.
1642 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1643 Test the getPlace() token parsing.
1645 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1647 Added a first unit test.
1649 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1650 * src/test/java/org/glom/web/shared/DataItemTest.java:
1651 This is a silly test but it is just to get things started. Note that
1652 maven/junit finds the test because it looks in src/test by default.
1654 2011-12-22 Ben Konrath <ben@bagu.org>
1656 Change charsetName to "UTF-8" when replacing line breaks.
1658 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1659 that work in Java (such as "UTF8") will not work when compiled to
1662 This fixes a problem with multi-line details view fields that have hard
1663 line breaks. The "License Text" field on this page demonstrates the
1666 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1668 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1670 2011-12-22 Ben Konrath <ben@bagu.org>
1672 Fix another bug with related list navigation.
1674 I've tested all the navigation buttons in all of the related lists
1675 so things should be good now.
1677 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1679 2011-12-22 Ben Konrath <ben@bagu.org>
1681 Fix a crasher when refreshing the list view with the default table.
1683 This crash will also happen when loading the list view with the default
1684 table from a link or bookmark.
1686 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1687 to the main document selection page when the document id hasn't been
1689 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1690 the main document selection page when the document id hasn't been
1692 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1693 values for the details place when the document id hasn't been set.
1694 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1695 values for the list place when the document id hasn't been set.
1697 2011-12-21 Ben Konrath <ben@bagu.org>
1699 Protect against NPE when glom.document.locale is not in config.
1701 This patch protects against an NPE when glom.document.locale is not in
1702 the config file. This NPE will also happen if glom.document.locale is
1705 The patch also updates the error message to display the class name when
1706 the getMessage() returns null. This was happening when the NPE was
1707 thrown and I had "Configuration Error: null". If an NPE is encountered
1708 with this patch, "Configuration Error: NullPointerException " will be
1711 This commit closes this bug:
1713 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1715 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1717 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1719 Rename onlineglom.properties to onlineglom.properties.sample.
1721 * src/main/resources/onlineglom.properties: Rename to:
1722 * src/main/resources/onlineglom.properties.sample:
1723 * src/main/resources/README: And add this file explaining that people
1724 should rename it back when deploying.
1726 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1728 Allow choosing the translation in the .properties file.
1730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1731 init(): Read a glom.document.locale value from the configuration file
1732 and call Glom's TransatableItem::set_current_locale() method.
1733 * src/main/resources/onlineglom.properties: Add a commented-out
1734 example of this new setting.
1736 It would be better to add &lang=de_DE to the URL, but the current
1737 libglom API does not allow us to do this easily. I am working on that.
1739 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1741 Avoid a crash in parsing of token parameters.
1743 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1744 ava: getTokenParams(): Do not crash if a parameter has a key but no
1745 value, and ignore parameters with neither.
1747 2011-12-17 Murray Cumming <murrayc@murayc.com>
1749 History token building/handling: Improve use of token parameters.
1751 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1752 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1753 and buildParamsToken(HashMap), for use by derived classes.
1754 Make the separator private because it is no longer be needed.
1755 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1756 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1757 instead of manual string concatenation.
1758 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1759 of hardcoded indices and awkward splitting code.
1760 * src/main/java/org/glom/web/client/place/ListPlace.java
1761 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1762 instead of manual string concatenation.
1763 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1764 of hardcoded indices and awkward splitting code.
1765 This should fix bug #666420
1767 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1769 Fix a Navgiation->Navigation typo in the code.
1771 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1772 Rename processNavgiation() to processNavigation().
1774 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1776 Fix a seperator->separator typo in the code.
1778 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1779 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1780 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1783 2011-12-15 Ben Konrath <ben@bagu.org>
1785 Cleanup some comments.
1787 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1789 2011-12-14 Ben Konrath <ben@bagu.org>
1791 Replace \n with <br/> for multiline text in the details view.
1793 Vertical scrollbars are added when needed as well.
1795 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1797 2011-12-14 Ben Konrath <ben@bagu.org>
1799 Specify the font for document selection links.
1801 * src/main/webapp/style.css:
1803 2011-12-14 Ben Konrath <ben@bagu.org>
1805 Fix bouncy CellTable while paging.
1807 This doesn't currently work with related list tables in unselected
1810 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1812 2011-12-14 Ben Konrath <ben@bagu.org>
1814 Revamp the appearance of the document selection page.
1816 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1817 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1818 * src/main/webapp/style.css:
1820 2011-12-13 Ben Konrath <ben@bagu.org>
1822 Set navigation button column to the smallest size possible.
1824 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1826 2011-12-13 Ben Konrath <ben@bagu.org>
1828 Change OpenButton nomenclature to NavigationButton.
1830 Using NavigtionButton makes things more generic. Classes, methods and
1831 variables have been changed.
1833 This is a rename-only refactor.
1835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1836 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1837 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1838 Renamed from OpenButtonCell.
1839 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1840 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1841 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1843 2011-12-12 Ben Konrath <ben@bagu.org>
1845 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1847 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1848 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1849 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1850 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1852 2011-12-12 Ben Konrath <ben@bagu.org>
1854 Update variable names and comments.
1856 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1857 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1859 2011-12-12 Ben Konrath <ben@bagu.org>
1861 Properly initialize numNonEmptyRows variable to zero.
1863 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1864 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1866 2011-12-05 Ben Konrath <ben@bagu.org>
1868 Add latest mockup with HTML tables.
1870 Features of this mockup:
1872 -> HTML table for flowtable
1873 -> HTML table for flowtable column
1874 -> Example of how related lists would look
1875 -> Not using text entries for data items
1877 The current version of Online Glom doesn't use HTML tables for the
1880 This mockup has been sent to the glom-devel mailing list but it's good
1881 to have it here as well.
1883 * mockups/details-view-html-tables.html:
1885 2011-12-05 Ben Konrath <ben@bagu.org>
1887 Remove unnecessary getPrimaryKeyField() method.
1889 getPrimaryKeyFieldForTable(String) has been renamed to
1890 getPrimaryKeyField(String).
1892 * src/main/java/org/glom/web/server/database/DBAccess.java:
1893 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1894 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1896 2011-12-05 Ben Konrath <ben@bagu.org>
1898 Add string representation of TypedDataItem value to conversion error message.
1900 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1901 message was extracted into its own method to avoid duplication.
1903 2011-12-05 Ben Konrath <ben@bagu.org>
1905 Add type checking to navigation primary key value creation.
1907 Create navigation primary key only if the expected type from the Glom
1908 document matches the type returned by the SQL query.
1910 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1912 2011-12-05 Ben Konrath <ben@bagu.org>
1914 Rename a couple of variables in RelatedListNavigation.
1916 This is a rename-only refactor.
1918 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1920 2011-12-05 Ben Konrath <ben@bagu.org>
1922 Move getListLayoutGroup() into getListViewLayoutGroup().
1924 This removes getListLayoutGroup(). It was only being called by
1925 getListViewLayoutGroup().
1927 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1929 2011-12-05 Ben Konrath <ben@bagu.org>
1931 Remove check for LayoutItem_Portal in list table method.
1933 This check is no longer necessary because the method isn't being used
1934 to create the LayoutItemPortal DTO.
1936 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1938 2011-12-05 Ben Konrath <ben@bagu.org>
1940 Properly support related list navigation.
1942 Navigation from the "Repository Analyzer -> Package Scans ->
1943 Dependencies" related table wasn't working because the primary key for
1944 related tables wasn't being set properly. This commit fixes the
1947 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1948 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1949 doesn't set the primary key properly for related list tables.
1950 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1951 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1952 useful for getting the primary key for list view tables and for related
1954 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1955 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1956 Move code to set the primary key for the table from the abstract
1957 ListDBAccess class to ListViewDBAccess as it's only correct for list
1959 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1960 Properly add primary key to related list tables.
1962 2011-12-02 Ben Konrath <ben@bagu.org>
1964 Properly set the horizontal alignment of fields.
1966 This fix is for both the list tables and the details view.
1968 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1969 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1970 to set the horizontal alignment of fields.
1972 2011-12-02 Ben Konrath <ben@bagu.org>
1974 Display currency codes in the details view.
1976 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1978 2011-12-02 Ben Konrath <ben@bagu.org>
1980 Avoid duplicate JNI call.
1982 JNI is not as efficient as pure Java and this is an easy (and small)
1985 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1986 Use previously retrieved value for whereClauseToTableName instead of
1989 2011-12-02 Ben Konrath <ben@bagu.org>
1991 Rename a couple of variables in RelatedListNavigation.
1993 This is a rename-only refactor.
1995 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1997 2011-12-02 Ben Konrath <ben@bagu.org>
1999 Indicate clearly that a mismatched primary key type is a bug.
2001 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2002 warning to error. Add 'This is a bug.' to message.
2004 2011-12-02 Ben Konrath <ben@bagu.org>
2006 Update / fix some comments.
2008 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2010 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2012 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2013 Fix comments. Add some TODOs.
2015 2011-12-02 Ben Konrath <ben@bagu.org>
2017 Enable navigation to details view with string primary key from related list.
2019 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2020 Create a text primary key value when return type of result is
2021 java.sql.Types.VARCHAR.
2023 2011-12-02 Ben Konrath <ben@bagu.org>
2025 Use checkboxes for booleans in the details view.
2027 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2029 2011-12-01 Ben Konrath <ben@bagu.org>
2031 Improve performance of related list height calculation.
2033 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2034 Put code to calculate the expected height in a static initializer so
2035 that that it's only called once.
2037 2011-12-01 Ben Konrath <ben@bagu.org>
2039 Show related list tables in notebooks (again).
2041 Calculate the height of the related list tables so the Notebook can be
2042 set the correct height. The height of the related list table is also needed by
2043 FlowTable to be able decide how to create the layout.
2045 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2046 and set the Portal height based on the height of the related list
2047 table and the Portal container.
2048 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2049 Add method to calculate the height of the related list tables.
2050 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2051 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2052 calculate the height of the Pager widget.
2054 2011-12-01 Ben Konrath <ben@bagu.org>
2056 Use CellTable API for table property instead of setting style on Element.
2058 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2060 2011-12-01 Ben Konrath <ben@bagu.org>
2062 Make ListViewTable and RelatedListTable a consistent height.
2064 The tables are now a consistent height regardless of the contents of
2065 the table. A hidden button is added to empty rows to ensure that the
2066 height of these rows will match the height of rows with data.
2068 A navigation button column is now added to every table. The width of
2069 the navigation column is set to 0px when a RelatedListTable shouldn't
2070 have navigation buttons. This maintains the a consistent row height in
2071 tables that don't show the navigation buttons.
2073 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2074 navigation column when not needed.
2075 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2076 arguments for navigation button to constructor of ListViewTable.
2077 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2078 hidden button for empty data rows.
2079 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2080 arguments for navigation button to constructor.
2081 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2082 create navigation buttons. Add hideNavigationButtons() method.
2083 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2084 arguments for navigation button to constructor.
2086 2011-12-01 Ben Konrath <ben@bagu.org>
2088 Use 'visibility: hidden' in Utils.getWidgetHeight().
2090 This is better choice because hidden elements are invisible, don't
2091 respond to events and are not part of the tab order. They will,
2092 however, take up space which is required to be able to calculate the
2093 height of the widget.
2095 * src/main/java/org/glom/web/client/Utils.java:
2097 2011-12-01 Ben Konrath <ben@bagu.org>
2099 Use Utils.getWidgetHeight() in FlowTable.
2101 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2103 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2105 2011-12-01 Ben Konrath <ben@bagu.org>
2107 Put the details css class name on the correct table column.
2109 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2111 2011-11-30 Ben Konrath <ben@bagu.org>
2113 Update for java-libglom API change.
2115 The getters and setters on FieldFormatting and NumericFormat were
2116 changed to remove the 'M'.
2118 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2120 2011-11-29 Ben Konrath <ben@bagu.org>
2122 Only allow RelatedListTables in Portals.
2124 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2126 2011-11-29 Ben Konrath <ben@bagu.org>
2128 Only create a contents panel for Portals when title is being set.
2130 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2132 2011-11-29 Ben Konrath <ben@bagu.org>
2134 Set TabLayoutPanel height based on calculated height its widgets.
2136 This is a potential fix for this bug:
2138 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2140 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2142 2011-11-29 Ben Konrath <ben@bagu.org>
2144 Align details field labels and data with the Open buttons.
2146 * src/main/webapp/style.css:
2148 2011-11-29 Ben Konrath <ben@bagu.org>
2150 Remove unnecessary <div> in the Notebook widget.
2152 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2153 method to get container FlowPanel (<div>).
2154 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2155 initWidget() method directly on the TabLayoutPanel widget instead of
2156 Group's container widget.
2158 2011-11-29 Ben Konrath <ben@bagu.org>
2160 Don't add group titles for Portals in Notebooks.
2162 This reverts the previous patch and fixes a bug I introduced with
2163 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2165 * src/main/java/org/glom/web/client/ui/details/Group.java:
2166 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2168 2011-11-28 Ben Konrath <ben@bagu.org>
2170 Remove unused boolean argument in Portal constructor.
2172 Just a code cleanup.
2174 * src/main/java/org/glom/web/client/ui/details/Group.java:
2175 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2177 2011-11-28 Ben Konrath <ben@bagu.org>
2179 Remove hack for glom 1.18 style glom files.
2181 * src/main/java/org/glom/web/client/ui/details/Group.java:
2182 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2183 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2185 2011-11-28 Ben Konrath <ben@bagu.org>
2187 Use Gda Value version of primary key to log result too large error.
2189 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2191 2011-11-28 Ben Konrath <ben@bagu.org>
2193 Don't use TypedDataItem.getText() for Unknown types from the URL.
2195 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2196 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2197 instead of getText().
2198 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2199 String field and getUnknown() method.
2201 2011-11-28 Ben Konrath <ben@bagu.org>
2203 Log an error message when the java-libglom .so is not present.
2205 The error message was being set in the exception but not logged.
2207 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2209 2011-11-28 Ben Konrath <ben@bagu.org>
2211 Ignore LayoutItem_CalendarPortals.
2213 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2214 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2216 2011-11-28 Ben Konrath <ben@bagu.org>
2218 Extract method for creating the LayoutItemPortal DTO.
2220 Just breaking the code up into smaller chunks.
2222 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2224 2011-11-28 Ben Konrath <ben@bagu.org>
2228 This should have been added with the refactor. Oops!
2230 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2232 2011-11-28 Ben Konrath <ben@bagu.org>
2234 Create primary key value from URL string using type from Glom document.
2236 See this bug, comments 19 - 25:
2238 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2240 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2241 create a TypeDataItem for the primary key here when loading from a
2242 URL. Show the same string for the primary key value as was received
2243 from the URL string (when loading from a URL).
2244 * src/main/java/org/glom/web/server/Utils.java: Update method for
2245 creating the Gda Value from the TypeDataItem to properly deal with
2246 creating a Gda Value based on the Glom document type for the primary
2247 key value string when loading from a URL.
2248 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2249 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2250 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2251 Update for changed method name.
2253 2011-11-27 Ben Konrath <ben@bagu.org>
2255 Rename PrimaryKeyItem to TypedDataItem.
2257 The name PrimaryKeyItem suggests what the class should be used for.
2258 TypedDataItem is a neutral name that describes the class better.
2260 This is a rename-only refactor.
2262 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2263 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2264 * src/main/java/org/glom/web/client/Utils.java:
2265 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2266 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2267 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2268 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2269 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2270 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2271 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2272 * src/main/java/org/glom/web/server/Utils.java:
2273 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2274 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2275 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2276 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2278 2011-11-25 Ben Konrath <ben@bagu.org>
2280 Improve Gda Value conversion from PrimaryKeyItem.
2282 The value from the PrimaryKeyItem is only used if its type match the
2283 type from the glom document.
2285 * src/main/java/org/glom/web/server/Utils.java:
2287 2011-11-25 Ben Konrath <ben@bagu.org>
2289 Manually check if the java-liblgom .so is visible to the JVM.
2291 It seems that Tomcat has problems when a static initializer throws an
2292 exception. This check is done before the first method call into
2293 java-libglom so that execution doesn't continue if the .so is not
2296 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2298 2011-11-25 Ben Konrath <ben@bagu.org>
2300 Improve browser configuration error messages.
2304 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2306 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2307 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2308 getConfigurationErrorMessage() method.
2309 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2310 Get and display a specific configuration error message when no Glom
2311 documents are found.
2312 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2313 Implement getConfigurationErrorMessage() method. Surround configuration
2314 code in the init() method with a try/catch block. This allows the
2315 errors to be caught while keeping the servlet available to retrieve the
2316 configuration error message.
2318 2011-11-25 Ben Konrath <ben@bagu.org>
2320 Don't use Strings to hold primary key values.
2322 The primary key values are now held in a new data object
2323 (PrimaryKeyItem) that holds type information and the primary key value
2324 using the correct type.
2326 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2327 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2328 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2329 PrimaryKeyItem instead of String to hold the primary key value.
2330 * src/main/java/org/glom/web/client/Utils.java: Remove
2331 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2332 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2333 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2334 PrimaryKeyItem instead of String to hold the primary key value. Load
2335 document selection page when the documentID has not been set correctly.
2336 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2337 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2339 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2340 Return empty string for URL instead of "null".
2341 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2342 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2343 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2344 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2345 PrimaryKeyItem instead of String to hold primary key values.
2346 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2347 PrimaryKeyValue to a Gda Value.
2348 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2349 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2350 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2351 Replace temporary database access code that uses the PrimaryKeyValue to
2352 Gda Value conversion.
2353 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2354 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2355 PrimaryKeyItem instead of String.
2356 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2357 hold primary key values.
2359 2011-11-24 Ben Konrath <ben@bagu.org>
2361 Use newly added java-libglom API to create queries.
2363 This isn't finished. I still need to stop using Strings for primary key
2364 values in the client code.
2366 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2367 libglom to use fake connections so that retrieving the query string will
2369 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2370 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2371 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2372 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2373 Use the newly added libglom sql methods and classes to create the
2374 query. Add temporary hack to convert primary value strings to Gda
2377 2011-11-23 Ben Konrath <ben@bagu.org>
2379 Don't explicitly set the height of Portals.
2381 See comments 6 - 10 of this bug for details:
2383 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2385 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2387 2011-11-23 Ben Konrath <ben@bagu.org>
2389 Use an HTML table instead of CSS for the FlowTable layout.
2391 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2392 GWT's FlexTable to implement the FlowTable.
2393 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2395 2011-11-18 Ben Konrath <ben@bagu.org>
2397 Add boolean example to HTML table mockup.
2399 * mockups/details-view-html-tables-text-entries.html:
2401 2011-11-17 Ben Konrath <ben@bagu.org>
2403 Ensure the pager buttons are always visible for related lists.
2405 To accomplish this, I've turned off text wrapping in the list view and
2406 related list tables for both the header and data text. The related list
2407 table now has a fixed layout so the it doesn't overflow its container.
2408 This is required to ensure that the cell text is clipped when it
2409 overflows the cell and an ellipsis is added to the right side of the
2410 cell when text is clipped.
2412 A fixed table layout for the related list table in the details view
2413 seems what we want for the details view anyway, so the side-effect is
2416 The ellipsis will only be displayed in Firefox >= 7.
2420 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2422 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2423 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2424 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2426 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2427 Set the 'table-layout: fixed' CSS property to the related list table.
2428 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2429 'white-space: nowrap;' CSS property on both the list view and the
2430 related list tables.
2432 2011-11-16 Ben Konrath <ben@bagu.org>
2434 Rework the fix for empty notebook tab labels.
2436 Setting the empty group titles with its name caused problems for the
2437 details layout. Instead of using libglom's
2438 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2439 to the client when the title is empty. This allows the Notebook to use
2440 the name when the title is empty without affecting anything else.
2442 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2443 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2445 2011-11-16 Ben Konrath <ben@bagu.org>
2447 Set group titles with name when title is empty.
2449 This fixes a problem with an empty notebook tab label in the Lesson
2450 Planner document. The forth tab in the notebook should be "Internet":
2452 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2454 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2455 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2458 2011-11-16 Ben Konrath <ben@bagu.org>
2460 Remove whitespace from the configured username properties.
2462 This assumes that usernames won't have whitespace at the beginning
2463 or end. But I think this is a reasonable assumption.
2465 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2466 String.trim() to remove the whitespace from the username properties.
2468 2011-11-15 Ben Konrath <ben@bagu.org>
2470 Add details view mockup with HTML tables and text entries.
2472 This is from the attachment on this bug:
2474 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2476 * mockups/details-view-html-tables-text-entries.html:
2478 2011-11-15 Ben Konrath <ben@bagu.org>
2480 Add space between the columns of the flow table.
2484 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2486 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2487 space between columns in the flow table.
2489 2011-11-15 Ben Konrath <ben@bagu.org>
2491 Add backup files to the .gitignore.
2493 * .gitignore: Ignore files that end with ~.
2495 2011-11-09 Ben Konrath <ben@bagu.org>
2497 Use latest release of gwt-log.
2499 Gwt-log releases are now being submitted to the maven central
2500 repository so manual installation of the jar is no longer required.
2502 * pom.xml: Update version and groupId of gwt-log dependency.
2504 2011-10-31 Ben Konrath <ben@bagu.org>
2506 Don't use GWT numeric formatting to override the glom currency formatting.
2508 Currencies are now displayed like they are in Glom. See this bug:
2510 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2512 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2514 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2515 currency code to constructor and set it when the cell is rendered.
2516 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2517 currency code to the constructor of the NumericCell.
2519 2011-10-27 Ben Konrath <ben@bagu.org>
2521 Require the latest release of java-libglom (1.17.4).
2525 2011-10-26 Ben Konrath <ben@bagu.org>
2527 Add style to Notebook that matches current theme.
2529 It's not the best style in the world but it's better than the default.
2531 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2532 padding at the bottom of the child widgets.
2533 * src/main/webapp/style.css: Add style for the Notebook.
2535 2011-10-26 Ben Konrath <ben@bagu.org>
2537 Move servlet initialization code to overridden init method.
2539 This is half of the solution to getting proper error messages
2540 displayed when configuration errors occur. Here's the relevant bug:
2542 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2544 The rest of the solution involves surrounding the init method with a
2545 try/catch block and setting a global variable with the error /
2546 exception. A new async method should be created to retrieve and display
2547 the error message / exception.
2549 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2550 code from constructor to init method adding exceptions as needed.
2552 2011-10-26 Ben Konrath <ben@bagu.org>
2554 Add script to monitor and restart tomcat if required.
2556 * utils/check-and-recover-tomcat.py: New file.
2558 2011-10-26 Ben Konrath <ben@bagu.org>
2560 Display the correct number of data items in the pager.
2564 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2566 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2567 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2568 The implementation is the same for both tables: Keep track of the
2569 number of non-empty rows and fire and RowCountChangeEvent after the data has
2571 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2572 custom Pager class that subclasses SimplePager to handle displaying
2573 the correct number when empty rows have been added.
2575 2011-10-26 Ben Konrath <ben@bagu.org>
2577 Correct error in previous commit.
2579 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2580 eventBus parameter from listView.setCellTable().
2582 2011-10-26 Ben Konrath <ben@bagu.org>
2584 Fix error in TODO comment.
2586 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2588 2011-10-24 Ben Konrath <ben@bagu.org>
2590 Create Notebook widgets to the details view.
2592 This isn't finished just yet - I still need to create a reasonable
2593 style to match the current theme.
2595 * src/main/java/org/glom/web/client/Utils.java: Add method for
2596 calculating the height of a widget. This is used in the Notebook class.
2597 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2598 new constructor method in Group.
2599 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2600 method for creating child widget that can be used by subclasses
2601 like Notebook. New constructor that allows disabling the group
2602 titles - Notebooks don't set a group title for their child groups.
2603 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2604 to make Notebooks using GWT's TabLayoutPanel.
2605 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2606 constructor that allows disabling the group titles.
2607 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2608 LayoutItemNotebook DTO.
2609 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2610 DTO for Notebooks. It's just an empty class for now but we might need
2611 it to transfer some specific information in the future.
2613 2011-10-21 Ben Konrath <ben@bagu.org>
2615 Add navigation buttons to related list tables.
2617 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2618 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2619 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2620 method getSuitableRecordToViewDetails() for getting the table name
2621 and primary key value for related list navigation buttons.
2622 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2623 private cell renderer class to get the navigation information for
2624 related list tables from the server. Extract the navigation
2625 processing code from the details cell navigation and use it for the
2626 related list navigation as well.
2627 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2628 cell renderer class for the details open buttons. This was needed
2629 because the related list navigation buttons and the list view
2630 navigation buttons need to react differently when clicked.
2631 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2632 the onEnterKeyDown() method because it's now overriden in the
2633 subclasses that are specific to the related list tables and the list
2635 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2636 the vertical size a little because the buttons add a bit of vertical
2637 space to table. This is not a perfect solution because the vertical
2638 size of with table fewer than 5 rows will be a little smaller.
2639 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2640 changes in how navigation buttons are handled.
2641 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2642 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2643 database access object.
2644 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2645 to find the portal for a given relationship name from
2646 RelatedListDBAccess. Add method to find a primary key field for a
2648 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2649 Move code to find the portal for a given relationship name to
2651 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2652 New file: database access object for getting the related list
2653 navigation information (the table name and the primary key value).
2654 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2655 DTO for transferring a table name to navigate to and a primary key
2657 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2658 boolean and getter/setter to specifies if the related list should add
2661 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2663 Use the master branch of java-libglom
2665 * pom.xml: Depend on java-libglom 1.19 instead.
2667 This is the master branch. See also the libglom-1-18 branch.
2669 2011-10-11 Ben Konrath <ben@bagu.org>
2671 Enable the open navigation button when the data has been set.
2673 This avoids having active buttons that don't do anything when the data
2676 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2678 2011-10-11 Ben Konrath <ben@bagu.org>
2680 Use IsWidget interface for FlowTableItem.
2682 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2683 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2685 2011-10-11 Ben Konrath <ben@bagu.org>
2687 Remove GWT styling from open button in details view.
2689 There are still some issues with how the details cell is arranged but
2690 this should be made to match Glom 1.20. I'm going to leave fixing this
2691 until I have Glom 1.20 up and running.
2693 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2694 style name on open button.
2695 * src/main/webapp/style.css: Move and edit details-navigation class.
2696 Re-arrange some classes to make them appear in the same order as the
2699 2011-10-07 Ben Konrath <ben@bagu.org>
2701 Update to GWT 2.4.0.
2703 * .gitignore: Ignore new cache directory.
2704 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2705 * pom.xml: Change GWT and maven plugin to 2.4.0.
2706 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2708 * src/main/java/org/glom/web/client/ClientFactory.java:
2709 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2710 * src/main/java/org/glom/web/client/OnlineGlom.java:
2711 Update source for API changes.
2712 * utils/build-onlineglom-war.sh: Remove cache directory before the
2715 2011-10-07 Ben Konrath <ben@bagu.org>
2717 Add navigation buttons in the details view.
2719 This isn't finished but I thought I'd commit what I have as it's a
2720 pretty good start. I still need to:
2722 1. Change the style so that it fits better into the current theme
2723 2. Adjust the details cell to expand as much as possible.
2725 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2726 click handlers to navigation buttons in the DetailsCells. Create a
2727 refreshData() method to get just the data from the server without the
2729 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2730 Update the tableSelector and browser title when the table name
2731 changes without using the tableSelector.
2732 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2733 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2734 getDetailsCells() to getCells(). Update variable names.
2735 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2736 method to set click handler on navigation button. Rename a few
2737 variables. Add navigation buttons where needed.
2738 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2739 variables and methods.
2740 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2741 navigation boolean and navigation table as required in the
2742 LayoutItemField DTO.
2743 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2744 variables for navigation along with getter/setter methods.
2746 2011-10-07 Ben Konrath <ben@bagu.org>
2748 Rename Field to DetailsCell.
2750 This is a refactor-only commit. No functionality has been added or
2753 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2754 Update variable and method names.
2755 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2756 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2757 variable and method names.
2758 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2760 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2761 variable and method names.
2763 2011-10-07 Ben Konrath <ben@bagu.org>
2765 Create separate methods for layout and data the details view.
2767 This is a refactor-only commit. No functionality has been added or
2770 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2771 private methods: setData(), createLayout().
2773 2011-10-07 Ben Konrath <ben@bagu.org>
2775 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2777 This is part of a change to get navigation buttons in the details view
2778 but it should have been done this way from the start.
2780 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2781 for method name change in TableSelectionView.
2782 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2783 Create TableChangeEvent and set the browser title using the
2784 TableSelectionView API.
2785 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2786 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2787 Change getSelectedTable() to getSelectedTableName(). Add
2788 getSelectedTableTitle().
2790 2011-10-07 Ben Konrath <ben@bagu.org>
2792 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2794 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2796 2011-10-07 Ben Konrath <ben@bagu.org>
2798 Update TableChangeEvent to use newTableName naming convention.
2800 This makes the class more consistent with GWT naming conventions.
2802 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2803 Update for method name change in TableChangeEvent.
2804 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2805 for method name change in TableChangeEvent.
2806 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2807 newTableName variable and getter method. Make toDebugString()
2810 2011-09-30 Ben Konrath <ben@bagu.org>
2812 Disable the pager in the list tables when the data row count is less than the minimum.
2814 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2815 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2817 2011-09-30 Ben Konrath <ben@bagu.org>
2819 Add empty rows to the end of related list and list view tables.
2821 I also extracted the cell rendering classes from the ListTable because
2822 the code was becoming a little crazy with all the anonymous inner
2823 classes. My plan is to use these cell rendering classes in the details
2824 view as well so this refactor will be needed for that change.
2826 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2827 set the row count in related list tables if the data has more rows
2828 than the minimum number of rows visible.
2829 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2830 row count in list view tables if the data has more rows than the
2831 minimum number of rows visible.
2832 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2833 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2835 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2836 for rendering TYPE_NUMERIC cells. The code was extracted from the
2838 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2839 class for rendering cells with buttons in list views. The code was
2840 extracted from the ListTable class.
2841 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2842 for rendering TYPE_TEXT cells. The code was extracted from the
2844 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2845 Add empty rows to the end of the data if required. Implement
2846 ListTable.getMinNumVisibleRows().
2847 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2848 cell renderer code to public classes. Return null in
2849 Column.getValue() for empty rows. Add new abstract method:
2850 getMinNumVisibleRows(). Move code to set the row count of the list view
2851 table to ListViewImpl.
2852 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2853 empty rows to the end of the data if required. Implement
2854 ListTable.getMinNumVisibleRows().
2857 2011-09-27 Ben Konrath <ben@bagu.org>
2859 Use GWT.log for client-side debugging statements.
2861 These are optimized out when deployed so I should have used this method
2862 in the first place. These statements will eventually be replaced with some sort
2863 of notification in the browser.
2865 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2866 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2867 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2868 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2869 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2871 2011-09-27 Ben Konrath <ben@bagu.org>
2873 Put tableselector on the right, back to list link on right.
2875 The idea is that the table selector is acting like a label for the
2876 currently displayed table so it should be placed below the document title. This
2877 puts the table title in a similar position to where it is in Glom.
2879 * mockups/details-contacts.html:
2880 * mockups/details-projects.html:
2881 * mockups/listview-contacts.html:
2882 * mockups/listview-projects.html:
2883 * mockups/style.css:
2884 Update mockups to match how the interfaces currently look.
2885 * src/main/webapp/style.css: Swap positions of backlink with the table
2886 selector. Add some space on the left side of the table selector to
2887 line things up with the document title.
2889 2011-09-27 Ben Konrath <ben@bagu.org>
2891 Add field colouring to details view.
2893 This change re-works how field colouring works. The colour formatting
2894 information is now set to the client with the layout information instead of
2895 with the data. This eliminates the need to send the same colour strings for
2896 data in list view column when colour information is set.
2898 In order to set an alternate colour for negative numeric values, the
2899 number is now sent to client and formatted with the GWT NumberFormat class.
2901 This change also fixes:
2903 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2905 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2906 internationalization framework which is needed for client side numeric
2908 * src/main/java/org/glom/web/client/Utils.java: New file for some
2909 client static utility methods.
2910 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2911 the DataItem object to the Field class. Use a utility method to
2912 create the foreignKeyValue string.
2913 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2914 alignment and text colours in the constructor. Add setData(DataItem)
2915 method. Remove setText(String) method.
2916 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2917 colour information to GlomTextCell. Create and use GlomNumberCell for
2918 rendering numbers. Use utility method to get the string for the
2919 primary key of the key provider. Re-work how the horizontal alignment
2921 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2922 formatting to layout information. Methods for converting the libglom
2923 formatting information were moved from DBAccess.
2924 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2925 numeric formatting (it's now done on the client side). Don't set text
2926 colours in DataItem. Move libglom formatting conversion methods to
2928 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2929 getters/setters for text colour information.
2930 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2931 for transferring the libglom NumericFormat information to the client.
2932 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2933 and getters/setters for: GlomNumericFormat, background colour and
2934 foreground colour strings.
2936 2011-09-26 Ben Konrath <ben@bagu.org>
2938 Simplify code that iterates through the LayoutGroup.
2940 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2942 2011-09-26 Ben Konrath <ben@bagu.org>
2944 Accept Eclipse formatting for OnlineGlomServiceAsync.
2946 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2948 2011-09-26 Ben Konrath <ben@bagu.org>
2950 Don't use the ListDBAccess classes to get the primary key layout information.
2952 This was causing a bug where the wrong index for the hidden primary key
2953 was being sent to the client.
2955 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2956 primary key while creating the LayoutGroup DTO. Create a
2957 LayoutItemField DTO for hidden primary keys. Don't use the
2958 RelatedListDBAccess because it was only used for getting the primary
2960 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2961 access modifier from public to protected for getPrimaryKeyField() and
2962 getPrimaryKeyLayoutItemField().
2963 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2964 abstract method getExpectedResultSize() because RelatedListDBAccess
2965 doesn't have enough info to implement it.
2966 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2967 Remove @Override for getExpectedResultSize().
2968 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2969 Remove method getExpectedResultSize().
2971 2011-09-23 Ben Konrath <ben@bagu.org>
2973 Log which layout (list or details) the ignored item is from.
2975 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2977 2011-09-23 Ben Konrath <ben@bagu.org>
2979 Remove annotations that turn off code formatting in DataItem.
2981 * src/main/java/org/glom/web/shared/DataItem.java:
2983 2011-09-23 Ben Konrath <ben@bagu.org>
2985 Rename GlomField to DataItem and update associated methods.
2987 This is a rename-only refactor. No functionality has been added or
2990 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2991 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2992 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2993 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2994 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2995 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2996 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2997 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2999 * src/main/java/org/glom/web/server/database/DBAccess.java:
3000 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3001 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3002 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3003 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3004 * src/main/java/org/glom/web/shared/DataItem.java:
3005 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3006 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3008 2011-09-23 Ben Konrath <ben@bagu.org>
3010 Rename GlomDocument to DocumentInfo and update associated methods.
3012 This is a rename-only refactor. No functionality has been added or
3015 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3016 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3017 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3018 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3019 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3020 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3021 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3023 2011-09-20 Ben Konrath <ben@bagu.org>
3025 Require java-libglom 1.17.3.
3027 This picks up the fix for the seg fault problem with the Scenes table
3028 in the Openismus Film Manager example.
3032 2011-09-20 Ben Konrath <ben@bagu.org>
3034 Change the way sort clause is added for primary key when no sort clause is requested.
3036 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3037 before the sort clause is created. When a sort clause is not requested, the
3038 sort clause is created by finding the primary key in the LayoutFieldVector
3041 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3043 2011-09-20 Ben Konrath <ben@bagu.org>
3045 Log error message if no documents are found in the configured directory.
3047 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3048 Extract the glom file extension string to a private static final class
3049 variable (mostly as syntactic sugar). Accept a minor formatting change.
3050 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3051 the example glom.document.directory configuration property to make it
3052 more clear that it can any directory, not just the home directory.
3054 2011-09-18 Ben Konrath <ben@bagu.org>
3056 Add related lists to details view.
3058 The related list table has support for paging and sorting just like the
3059 table in the list view.
3061 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3062 SQL queries for the related list tables.
3063 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3064 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3065 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3066 Rename getList methods to getListView and add comments. Remove
3067 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3068 it being unused. Add methods: getDetailsLayoutAndData(),
3069 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3070 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3071 Create the layout and set the data for the fields in one async call
3072 instead of two. Create related lists where appropriate.
3073 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3074 for method name changes in OnlineGlomService.
3075 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3076 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3077 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3079 * src/main/java/org/glom/web/client/ui/ListView.java:
3080 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3081 tableName from setCellTable(). Create a ListViewTable instead of
3083 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3084 represent a data field in the details view.
3085 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3086 from addDetailsCell() to Field class. Keep track of the Fields and
3087 Portals in the details view.
3088 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3089 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3090 and add a method to get it. Add method to set the contents of the
3092 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3093 New class for related list tables. This class has the data provider
3094 for the related list table.
3095 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3096 abstract class which is the base class for the ListViewTable and the
3098 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3099 New class for list view tables. This class has the data provider for
3100 the list view table.
3101 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3102 methods for related list tables. Add more information to the
3103 LayoutItemField and LayoutItemPortal DTOs.
3104 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3105 Remove debugging print statement.
3106 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3107 Remove debugging print statements. Add primary key field to SQL count
3109 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3110 Remove unnecessary LayoutFieldVector parameter from
3111 getResultSizeOfSQLQuery() method.
3112 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3113 New class for related list table database access.
3114 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3115 class that is a wrapper DTO for details view layout and data.
3116 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3117 new 'fromField' string to this DTO.
3118 * src/main/webapp/style.css: Remove bottom margin and override top
3121 2011-09-15 Ben Konrath <ben@bagu.org>
3123 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3125 This sets things up to make it easier to add the data retrieval for
3126 related lists (portals). No user noticeable changes were made with
3129 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3130 class has the code to retrieve the layouts and access the
3131 database using the new database helper classes.
3132 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3133 Most of the functionality has been removed from this class. This
3134 class now represents the public interface for the client side
3135 code. It also deals with configuring the servlet and cleaning
3136 things up when the servlet is stopped.
3137 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3138 of static methods into this utility class.
3139 * src/main/java/org/glom/web/server/database/DBAccess.java:
3140 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3141 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3142 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3143 These classes have the database retrieval code. The class hierarchy
3144 has been setup to make it easy to reuse code for similar
3147 2011-09-06 Ben Konrath <ben@bagu.org>
3149 Create separate classes for list table code and the data provider.
3151 As part of this refactor, I also split up the code a bit to make it
3154 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3155 table code to two new classes (below).
3156 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3157 with code from ListViewImpl.
3158 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3159 New file with code from ListViewImpl.
3161 2011-09-06 Ben Konrath <ben@bagu.org>
3163 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3165 This fixes the LayoutItemPortal DTO to match the libglom layout object
3168 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3170 2011-09-01 Ben Konrath <ben@bagu.org>
3172 Set title of Portals in the Details View.
3174 * pom.xml: Bump required version of java-libglom to 1.17.1.
3175 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3176 widget creation to its own class. Add comments to constructor.
3177 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3178 The code is mostly from the Group class with the title now set.
3179 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3180 title of Portal. Update some comments. Fix some code formatting.
3182 2011-09-01 Ben Konrath <ben@bagu.org>
3184 Remove TODO comment for the flow table column width.
3186 The flow table column width is working correctly and doesn't need to be
3187 changed. See this mailing list post for more info:
3189 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3191 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3193 2011-08-27 Ben Konrath <ben@bagu.org>
3195 Add document title (database name) to top of the browser page.
3197 I added the document title to the TableSelecitonView but that will
3198 change if / when we add a view that doesn't require table selection.
3200 * mockups/details-contacts.html:
3201 * mockups/details-projects.html:
3202 * mockups/listview-contacts.html:
3203 * mockups/listview-projects.html:
3204 * mockups/style.css: Add document title to mockups to keep things
3206 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3207 sizes to account for the document title.
3208 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3209 Set the document title when it has been retrieved from the server.
3210 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3211 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3212 and implement setDocumentTitle(String) method.
3213 * src/main/webapp/style.css: Add ID for document title style.
3215 2011-08-25 Ben Konrath <ben@bagu.org>
3217 Add NavigationType enum to LayoutItemPortal DTO.
3219 This is the start of adding support for Portals to the Details View.
3221 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3222 LayoutItem_Portal.navigation_type enum from libglom to
3223 LayoutItemPortal.NavigationType enum.
3224 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3225 NavigationType enum, field for storing the NavigationType and getter
3228 2011-08-25 Ben Konrath <ben@bagu.org>
3230 Implement the flow table layout in the Details View.
3232 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3233 FlowTable to Group to account for the renamed class.
3234 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3235 File. This is a container widget that implements the Glom details view
3236 flow table behaviour.
3237 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3238 org/glom/web/client/ui/FlowTable.java.
3239 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3240 so that the size of the subgroups are a closer match to the size of
3241 the Glom subgroups. This makes the flowtable layout match the layout
3242 in Glom for the Music Collection example file.
3244 2011-08-16 Ben Konrath <ben@bagu.org>
3246 Create container element for LayoutItemPortal in Details View.
3248 This will help me develop the layout for the FlowTable.
3250 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3251 fieldPanel variable to detailsCell.
3253 2011-08-15 Ben Konrath <ben@bagu.org>
3255 Set the height of the data element in the Details View.