1 2012-01-01 Murray Cumming <murrayc@murrayc.com>
3 Tests: Added the beginnings of a test using gwt-test-utils.
5 * pom.xml: Add dependencies on gwt-test-utils and easymock.
6 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
7 which tells gwt-test-utils what class will be tested.
8 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
9 Add a simple (but empty) test case. One class, used by the OnlineGlom
10 class, is mocked so that it can be created. However, I am not sure
11 why only this class needs to be mocked.
13 Note that mockito seems more popular, and clearer, than easymock,
14 but I have not got that working yet. It might be a matter of the
17 This test is run during mvn integration-test.
19 2011-12-31 Murray Cumming <murrayc@murrayc.com>
21 Tests: Use junit4-style syntax instead of junit3-style.
23 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
24 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
25 * src/test/java/org/glom/web/shared/DataItemTest.java:
26 Use the @Test annotation rather than relying on the test*() prefix.
27 Also no longer implement TestCase, to avoid triggering support for
28 the junit3-way, which stops the annotations from working.
29 Change the imports from import junit.framework.* to
30 import org.junit.*, which is apparently the new way.
32 2011-12-31 Murray Cumming <murrayc@murrayc.com>
34 Added a test for ListPlace token parsing and creation.
36 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
37 This is much the same as DetailsPlaceTest.
39 I wonder how we could test the other parts of the *Place API.
41 2011-12-30 Murray Cumming <murrayc@murrayc.com>
43 DetailsPlace test: Also test getToken() and recreation via getPlace().
45 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
46 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
47 recreate it, testing the recreated DetailsPlace for the same parameter
50 2011-12-30 Murray Cumming <murrayc@murrayc.com>
52 Use the surefire-report plugin.
54 * pom.xml: This generates a HTML report about the tests in
55 target/site/surefire-report.html
56 when you do mvn surefire-report:report. It seems to be popular/normal.
58 2011-12-30 Murray Cumming <murrayc@murrayc.com>
60 Added a test for DetailsPlace.
62 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
63 Test the getPlace() token parsing.
65 2011-12-30 Murray Cumming <murrayc@murrayc.com>
67 Added a first unit test.
69 * pom.xml: Add a test goal, and a dependency on junit in that scope.
70 * src/test/java/org/glom/web/shared/DataItemTest.java:
71 This is a silly test but it is just to get things started. Note that
72 maven/junit finds the test because it looks in src/test by default.
74 2011-12-22 Ben Konrath <ben@bagu.org>
76 Change charsetName to "UTF-8" when replacing line breaks.
78 JavaScript requires the charsetName to be "UTF-8". CharsetName values
79 that work in Java (such as "UTF8") will not work when compiled to
82 This fixes a problem with multi-line details view fields that have hard
83 line breaks. The "License Text" field on this page demonstrates the
86 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
88 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
90 2011-12-22 Ben Konrath <ben@bagu.org>
92 Fix another bug with related list navigation.
94 I've tested all the navigation buttons in all of the related lists
95 so things should be good now.
97 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
99 2011-12-22 Ben Konrath <ben@bagu.org>
101 Fix a crasher when refreshing the list view with the default table.
103 This crash will also happen when loading the list view with the default
104 table from a link or bookmark.
106 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
107 to the main document selection page when the document id hasn't been
109 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
110 the main document selection page when the document id hasn't been
112 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
113 values for the details place when the document id hasn't been set.
114 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
115 values for the list place when the document id hasn't been set.
117 2011-12-21 Ben Konrath <ben@bagu.org>
119 Protect against NPE when glom.document.locale is not in config.
121 This patch protects against an NPE when glom.document.locale is not in
122 the config file. This NPE will also happen if glom.document.locale is
125 The patch also updates the error message to display the class name when
126 the getMessage() returns null. This was happening when the NPE was
127 thrown and I had "Configuration Error: null". If an NPE is encountered
128 with this patch, "Configuration Error: NullPointerException " will be
131 This commit closes this bug:
133 https://bugzilla.gnome.org/show_bug.cgi?id=666669
135 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
137 2011-12-20 Murray Cumming <murrayc@murrayc.com>
139 Rename onlineglom.properties to onlineglom.properties.sample.
141 * src/main/resources/onlineglom.properties: Rename to:
142 * src/main/resources/onlineglom.properties.sample:
143 * src/main/resources/README: And add this file explaining that people
144 should rename it back when deploying.
146 2011-12-20 Murray Cumming <murrayc@murrayc.com>
148 Allow choosing the translation in the .properties file.
150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
151 init(): Read a glom.document.locale value from the configuration file
152 and call Glom's TransatableItem::set_current_locale() method.
153 * src/main/resources/onlineglom.properties: Add a commented-out
154 example of this new setting.
156 It would be better to add &lang=de_DE to the URL, but the current
157 libglom API does not allow us to do this easily. I am working on that.
159 2011-12-19 Murray Cumming <murrayc@murrayc.com>
161 Avoid a crash in parsing of token parameters.
163 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
164 ava: getTokenParams(): Do not crash if a parameter has a key but no
165 value, and ignore parameters with neither.
167 2011-12-17 Murray Cumming <murrayc@murayc.com>
169 History token building/handling: Improve use of token parameters.
171 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
172 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
173 and buildParamsToken(HashMap), for use by derived classes.
174 Make the separator private because it is no longer be needed.
175 * src/main/java/org/glom/web/client/place/DetailsPlace.java
176 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
177 instead of manual string concatenation.
178 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
179 of hardcoded indices and awkward splitting code.
180 * src/main/java/org/glom/web/client/place/ListPlace.java
181 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
182 instead of manual string concatenation.
183 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
184 of hardcoded indices and awkward splitting code.
185 This should fix bug #666420
187 2011-12-16 Murray Cumming <murrayc@murrayc.com>
189 Fix a Navgiation->Navigation typo in the code.
191 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
192 Rename processNavgiation() to processNavigation().
194 2011-12-16 Murray Cumming <murrayc@murrayc.com>
196 Fix a seperator->separator typo in the code.
198 * src/main/java/org/glom/web/client/place/DetailsPlace.java
199 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
200 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
203 2011-12-15 Ben Konrath <ben@bagu.org>
205 Cleanup some comments.
207 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
209 2011-12-14 Ben Konrath <ben@bagu.org>
211 Replace \n with <br/> for multiline text in the details view.
213 Vertical scrollbars are added when needed as well.
215 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
217 2011-12-14 Ben Konrath <ben@bagu.org>
219 Specify the font for document selection links.
221 * src/main/webapp/style.css:
223 2011-12-14 Ben Konrath <ben@bagu.org>
225 Fix bouncy CellTable while paging.
227 This doesn't currently work with related list tables in unselected
230 * src/main/java/org/glom/web/client/ui/list/ListTable.java
232 2011-12-14 Ben Konrath <ben@bagu.org>
234 Revamp the appearance of the document selection page.
236 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
237 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
238 * src/main/webapp/style.css:
240 2011-12-13 Ben Konrath <ben@bagu.org>
242 Set navigation button column to the smallest size possible.
244 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
246 2011-12-13 Ben Konrath <ben@bagu.org>
248 Change OpenButton nomenclature to NavigationButton.
250 Using NavigtionButton makes things more generic. Classes, methods and
251 variables have been changed.
253 This is a rename-only refactor.
255 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
256 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
257 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
258 Renamed from OpenButtonCell.
259 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
260 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
261 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
263 2011-12-12 Ben Konrath <ben@bagu.org>
265 Remove unnecessary String argument in RelatedListTable and ListViewTable.
267 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
268 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
269 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
270 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
272 2011-12-12 Ben Konrath <ben@bagu.org>
274 Update variable names and comments.
276 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
277 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
279 2011-12-12 Ben Konrath <ben@bagu.org>
281 Properly initialize numNonEmptyRows variable to zero.
283 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
284 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
286 2011-12-05 Ben Konrath <ben@bagu.org>
288 Add latest mockup with HTML tables.
290 Features of this mockup:
292 -> HTML table for flowtable
293 -> HTML table for flowtable column
294 -> Example of how related lists would look
295 -> Not using text entries for data items
297 The current version of Online Glom doesn't use HTML tables for the
300 This mockup has been sent to the glom-devel mailing list but it's good
301 to have it here as well.
303 * mockups/details-view-html-tables.html:
305 2011-12-05 Ben Konrath <ben@bagu.org>
307 Remove unnecessary getPrimaryKeyField() method.
309 getPrimaryKeyFieldForTable(String) has been renamed to
310 getPrimaryKeyField(String).
312 * src/main/java/org/glom/web/server/database/DBAccess.java:
313 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
314 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
316 2011-12-05 Ben Konrath <ben@bagu.org>
318 Add string representation of TypedDataItem value to conversion error message.
320 * src/main/java/org/glom/web/server/Utils.java: Logging the error
321 message was extracted into its own method to avoid duplication.
323 2011-12-05 Ben Konrath <ben@bagu.org>
325 Add type checking to navigation primary key value creation.
327 Create navigation primary key only if the expected type from the Glom
328 document matches the type returned by the SQL query.
330 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
332 2011-12-05 Ben Konrath <ben@bagu.org>
334 Rename a couple of variables in RelatedListNavigation.
336 This is a rename-only refactor.
338 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
340 2011-12-05 Ben Konrath <ben@bagu.org>
342 Move getListLayoutGroup() into getListViewLayoutGroup().
344 This removes getListLayoutGroup(). It was only being called by
345 getListViewLayoutGroup().
347 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
349 2011-12-05 Ben Konrath <ben@bagu.org>
351 Remove check for LayoutItem_Portal in list table method.
353 This check is no longer necessary because the method isn't being used
354 to create the LayoutItemPortal DTO.
356 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
358 2011-12-05 Ben Konrath <ben@bagu.org>
360 Properly support related list navigation.
362 Navigation from the "Repository Analyzer -> Package Scans ->
363 Dependencies" related table wasn't working because the primary key for
364 related tables wasn't being set properly. This commit fixes the
367 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
368 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
369 doesn't set the primary key properly for related list tables.
370 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
371 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
372 useful for getting the primary key for list view tables and for related
374 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
375 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
376 Move code to set the primary key for the table from the abstract
377 ListDBAccess class to ListViewDBAccess as it's only correct for list
379 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
380 Properly add primary key to related list tables.
382 2011-12-02 Ben Konrath <ben@bagu.org>
384 Properly set the horizontal alignment of fields.
386 This fix is for both the list tables and the details view.
388 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
389 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
390 to set the horizontal alignment of fields.
392 2011-12-02 Ben Konrath <ben@bagu.org>
394 Display currency codes in the details view.
396 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
398 2011-12-02 Ben Konrath <ben@bagu.org>
400 Avoid duplicate JNI call.
402 JNI is not as efficient as pure Java and this is an easy (and small)
405 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
406 Use previously retrieved value for whereClauseToTableName instead of
409 2011-12-02 Ben Konrath <ben@bagu.org>
411 Rename a couple of variables in RelatedListNavigation.
413 This is a rename-only refactor.
415 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
417 2011-12-02 Ben Konrath <ben@bagu.org>
419 Indicate clearly that a mismatched primary key type is a bug.
421 * src/main/java/org/glom/web/server/Utils.java: Change log level from
422 warning to error. Add 'This is a bug.' to message.
424 2011-12-02 Ben Konrath <ben@bagu.org>
426 Update / fix some comments.
428 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
430 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
432 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
433 Fix comments. Add some TODOs.
435 2011-12-02 Ben Konrath <ben@bagu.org>
437 Enable navigation to details view with string primary key from related list.
439 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
440 Create a text primary key value when return type of result is
441 java.sql.Types.VARCHAR.
443 2011-12-02 Ben Konrath <ben@bagu.org>
445 Use checkboxes for booleans in the details view.
447 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
449 2011-12-01 Ben Konrath <ben@bagu.org>
451 Improve performance of related list height calculation.
453 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
454 Put code to calculate the expected height in a static initializer so
455 that that it's only called once.
457 2011-12-01 Ben Konrath <ben@bagu.org>
459 Show related list tables in notebooks (again).
461 Calculate the height of the related list tables so the Notebook can be
462 set the correct height. The height of the related list table is also needed by
463 FlowTable to be able decide how to create the layout.
465 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
466 and set the Portal height based on the height of the related list
467 table and the Portal container.
468 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
469 Add method to calculate the height of the related list tables.
470 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
471 * src/main/webapp/style.css: Add css class for Pager. This is needed to
472 calculate the height of the Pager widget.
474 2011-12-01 Ben Konrath <ben@bagu.org>
476 Use CellTable API for table property instead of setting style on Element.
478 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
480 2011-12-01 Ben Konrath <ben@bagu.org>
482 Make ListViewTable and RelatedListTable a consistent height.
484 The tables are now a consistent height regardless of the contents of
485 the table. A hidden button is added to empty rows to ensure that the
486 height of these rows will match the height of rows with data.
488 A navigation button column is now added to every table. The width of
489 the navigation column is set to 0px when a RelatedListTable shouldn't
490 have navigation buttons. This maintains the a consistent row height in
491 tables that don't show the navigation buttons.
493 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
494 navigation column when not needed.
495 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
496 arguments for navigation button to constructor of ListViewTable.
497 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
498 hidden button for empty data rows.
499 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
500 arguments for navigation button to constructor.
501 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
502 create navigation buttons. Add hideNavigationButtons() method.
503 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
504 arguments for navigation button to constructor.
506 2011-12-01 Ben Konrath <ben@bagu.org>
508 Use 'visibility: hidden' in Utils.getWidgetHeight().
510 This is better choice because hidden elements are invisible, don't
511 respond to events and are not part of the tab order. They will,
512 however, take up space which is required to be able to calculate the
513 height of the widget.
515 * src/main/java/org/glom/web/client/Utils.java:
517 2011-12-01 Ben Konrath <ben@bagu.org>
519 Use Utils.getWidgetHeight() in FlowTable.
521 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
523 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
525 2011-12-01 Ben Konrath <ben@bagu.org>
527 Put the details css class name on the correct table column.
529 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
531 2011-11-30 Ben Konrath <ben@bagu.org>
533 Update for java-libglom API change.
535 The getters and setters on FieldFormatting and NumericFormat were
536 changed to remove the 'M'.
538 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
540 2011-11-29 Ben Konrath <ben@bagu.org>
542 Only allow RelatedListTables in Portals.
544 * src/main/java/org/glom/web/client/ui/details/Portal.java:
546 2011-11-29 Ben Konrath <ben@bagu.org>
548 Only create a contents panel for Portals when title is being set.
550 * src/main/java/org/glom/web/client/ui/details/Portal.java:
552 2011-11-29 Ben Konrath <ben@bagu.org>
554 Set TabLayoutPanel height based on calculated height its widgets.
556 This is a potential fix for this bug:
558 https://bugzilla.gnome.org/show_bug.cgi?id=665133
560 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
562 2011-11-29 Ben Konrath <ben@bagu.org>
564 Align details field labels and data with the Open buttons.
566 * src/main/webapp/style.css:
568 2011-11-29 Ben Konrath <ben@bagu.org>
570 Remove unnecessary <div> in the Notebook widget.
572 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
573 method to get container FlowPanel (<div>).
574 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
575 initWidget() method directly on the TabLayoutPanel widget instead of
576 Group's container widget.
578 2011-11-29 Ben Konrath <ben@bagu.org>
580 Don't add group titles for Portals in Notebooks.
582 This reverts the previous patch and fixes a bug I introduced with
583 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
585 * src/main/java/org/glom/web/client/ui/details/Group.java:
586 * src/main/java/org/glom/web/client/ui/details/Portal.java:
588 2011-11-28 Ben Konrath <ben@bagu.org>
590 Remove unused boolean argument in Portal constructor.
594 * src/main/java/org/glom/web/client/ui/details/Group.java:
595 * src/main/java/org/glom/web/client/ui/details/Portal.java:
597 2011-11-28 Ben Konrath <ben@bagu.org>
599 Remove hack for glom 1.18 style glom files.
601 * src/main/java/org/glom/web/client/ui/details/Group.java:
602 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
603 * src/main/java/org/glom/web/client/ui/details/Portal.java:
605 2011-11-28 Ben Konrath <ben@bagu.org>
607 Use Gda Value version of primary key to log result too large error.
609 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
611 2011-11-28 Ben Konrath <ben@bagu.org>
613 Don't use TypedDataItem.getText() for Unknown types from the URL.
615 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
616 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
617 instead of getText().
618 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
619 String field and getUnknown() method.
621 2011-11-28 Ben Konrath <ben@bagu.org>
623 Log an error message when the java-libglom .so is not present.
625 The error message was being set in the exception but not logged.
627 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
629 2011-11-28 Ben Konrath <ben@bagu.org>
631 Ignore LayoutItem_CalendarPortals.
633 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
634 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
636 2011-11-28 Ben Konrath <ben@bagu.org>
638 Extract method for creating the LayoutItemPortal DTO.
640 Just breaking the code up into smaller chunks.
642 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
644 2011-11-28 Ben Konrath <ben@bagu.org>
648 This should have been added with the refactor. Oops!
650 * src/main/java/org/glom/web/shared/TypedDataItem.java:
652 2011-11-28 Ben Konrath <ben@bagu.org>
654 Create primary key value from URL string using type from Glom document.
656 See this bug, comments 19 - 25:
658 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
660 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
661 create a TypeDataItem for the primary key here when loading from a
662 URL. Show the same string for the primary key value as was received
663 from the URL string (when loading from a URL).
664 * src/main/java/org/glom/web/server/Utils.java: Update method for
665 creating the Gda Value from the TypeDataItem to properly deal with
666 creating a Gda Value based on the Glom document type for the primary
667 key value string when loading from a URL.
668 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
669 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
670 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
671 Update for changed method name.
673 2011-11-27 Ben Konrath <ben@bagu.org>
675 Rename PrimaryKeyItem to TypedDataItem.
677 The name PrimaryKeyItem suggests what the class should be used for.
678 TypedDataItem is a neutral name that describes the class better.
680 This is a rename-only refactor.
682 * src/main/java/org/glom/web/client/OnlineGlomService.java:
683 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
684 * src/main/java/org/glom/web/client/Utils.java:
685 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
686 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
687 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
688 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
689 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
690 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
691 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
692 * src/main/java/org/glom/web/server/Utils.java:
693 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
694 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
695 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
696 * src/main/java/org/glom/web/shared/NavigationRecord.java:
698 2011-11-25 Ben Konrath <ben@bagu.org>
700 Improve Gda Value conversion from PrimaryKeyItem.
702 The value from the PrimaryKeyItem is only used if its type match the
703 type from the glom document.
705 * src/main/java/org/glom/web/server/Utils.java:
707 2011-11-25 Ben Konrath <ben@bagu.org>
709 Manually check if the java-liblgom .so is visible to the JVM.
711 It seems that Tomcat has problems when a static initializer throws an
712 exception. This check is done before the first method call into
713 java-libglom so that execution doesn't continue if the .so is not
716 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
718 2011-11-25 Ben Konrath <ben@bagu.org>
720 Improve browser configuration error messages.
724 https://bugzilla.gnome.org/show_bug.cgi?id=662792
726 * src/main/java/org/glom/web/client/OnlineGlomService.java:
727 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
728 getConfigurationErrorMessage() method.
729 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
730 Get and display a specific configuration error message when no Glom
732 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
733 Implement getConfigurationErrorMessage() method. Surround configuration
734 code in the init() method with a try/catch block. This allows the
735 errors to be caught while keeping the servlet available to retrieve the
736 configuration error message.
738 2011-11-25 Ben Konrath <ben@bagu.org>
740 Don't use Strings to hold primary key values.
742 The primary key values are now held in a new data object
743 (PrimaryKeyItem) that holds type information and the primary key value
744 using the correct type.
746 * src/main/java/org/glom/web/client/OnlineGlomService.java:
747 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
748 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
749 PrimaryKeyItem instead of String to hold the primary key value.
750 * src/main/java/org/glom/web/client/Utils.java: Remove
751 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
752 PrimaryKeyItem based on the GlomFieldType and the DataItem.
753 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
754 PrimaryKeyItem instead of String to hold the primary key value. Load
755 document selection page when the documentID has not been set correctly.
756 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
757 DetailsPlace -> URL and URL -> DetailsPlace conversion with
759 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
760 Return empty string for URL instead of "null".
761 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
762 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
763 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
764 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
765 PrimaryKeyItem instead of String to hold primary key values.
766 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
767 PrimaryKeyValue to a Gda Value.
768 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
769 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
770 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
771 Replace temporary database access code that uses the PrimaryKeyValue to
772 Gda Value conversion.
773 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
774 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
775 PrimaryKeyItem instead of String.
776 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
777 hold primary key values.
779 2011-11-24 Ben Konrath <ben@bagu.org>
781 Use newly added java-libglom API to create queries.
783 This isn't finished. I still need to stop using Strings for primary key
784 values in the client code.
786 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
787 libglom to use fake connections so that retrieving the query string will
789 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
790 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
791 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
792 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
793 Use the newly added libglom sql methods and classes to create the
794 query. Add temporary hack to convert primary value strings to Gda
797 2011-11-23 Ben Konrath <ben@bagu.org>
799 Don't explicitly set the height of Portals.
801 See comments 6 - 10 of this bug for details:
803 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
805 * src/main/java/org/glom/web/client/ui/details/Portal.java:
807 2011-11-23 Ben Konrath <ben@bagu.org>
809 Use an HTML table instead of CSS for the FlowTable layout.
811 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
812 GWT's FlexTable to implement the FlowTable.
813 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
815 2011-11-18 Ben Konrath <ben@bagu.org>
817 Add boolean example to HTML table mockup.
819 * mockups/details-view-html-tables-text-entries.html:
821 2011-11-17 Ben Konrath <ben@bagu.org>
823 Ensure the pager buttons are always visible for related lists.
825 To accomplish this, I've turned off text wrapping in the list view and
826 related list tables for both the header and data text. The related list
827 table now has a fixed layout so the it doesn't overflow its container.
828 This is required to ensure that the cell text is clipped when it
829 overflows the cell and an ellipsis is added to the right side of the
830 cell when text is clipped.
832 A fixed table layout for the related list table in the details view
833 seems what we want for the details view anyway, so the side-effect is
836 The ellipsis will only be displayed in Firefox >= 7.
840 https://bugzilla.gnome.org/show_bug.cgi?id=662930
842 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
843 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
844 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
846 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
847 Set the 'table-layout: fixed' CSS property to the related list table.
848 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
849 'white-space: nowrap;' CSS property on both the list view and the
852 2011-11-16 Ben Konrath <ben@bagu.org>
854 Rework the fix for empty notebook tab labels.
856 Setting the empty group titles with its name caused problems for the
857 details layout. Instead of using libglom's
858 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
859 to the client when the title is empty. This allows the Notebook to use
860 the name when the title is empty without affecting anything else.
862 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
863 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
865 2011-11-16 Ben Konrath <ben@bagu.org>
867 Set group titles with name when title is empty.
869 This fixes a problem with an empty notebook tab label in the Lesson
870 Planner document. The forth tab in the notebook should be "Internet":
872 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
874 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
875 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
878 2011-11-16 Ben Konrath <ben@bagu.org>
880 Remove whitespace from the configured username properties.
882 This assumes that usernames won't have whitespace at the beginning
883 or end. But I think this is a reasonable assumption.
885 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
886 String.trim() to remove the whitespace from the username properties.
888 2011-11-15 Ben Konrath <ben@bagu.org>
890 Add details view mockup with HTML tables and text entries.
892 This is from the attachment on this bug:
894 https://bugzilla.gnome.org/show_bug.cgi?id=663109
896 * mockups/details-view-html-tables-text-entries.html:
898 2011-11-15 Ben Konrath <ben@bagu.org>
900 Add space between the columns of the flow table.
904 https://bugzilla.gnome.org/show_bug.cgi?id=662918
906 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
907 space between columns in the flow table.
909 2011-11-15 Ben Konrath <ben@bagu.org>
911 Add backup files to the .gitignore.
913 * .gitignore: Ignore files that end with ~.
915 2011-11-09 Ben Konrath <ben@bagu.org>
917 Use latest release of gwt-log.
919 Gwt-log releases are now being submitted to the maven central
920 repository so manual installation of the jar is no longer required.
922 * pom.xml: Update version and groupId of gwt-log dependency.
924 2011-10-31 Ben Konrath <ben@bagu.org>
926 Don't use GWT numeric formatting to override the glom currency formatting.
928 Currencies are now displayed like they are in Glom. See this bug:
930 https://bugzilla.gnome.org/show_bug.cgi?id=646216
932 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
934 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
935 currency code to constructor and set it when the cell is rendered.
936 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
937 currency code to the constructor of the NumericCell.
939 2011-10-27 Ben Konrath <ben@bagu.org>
941 Require the latest release of java-libglom (1.17.4).
945 2011-10-26 Ben Konrath <ben@bagu.org>
947 Add style to Notebook that matches current theme.
949 It's not the best style in the world but it's better than the default.
951 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
952 padding at the bottom of the child widgets.
953 * src/main/webapp/style.css: Add style for the Notebook.
955 2011-10-26 Ben Konrath <ben@bagu.org>
957 Move servlet initialization code to overridden init method.
959 This is half of the solution to getting proper error messages
960 displayed when configuration errors occur. Here's the relevant bug:
962 https://bugzilla.gnome.org/show_bug.cgi?id=662792
964 The rest of the solution involves surrounding the init method with a
965 try/catch block and setting a global variable with the error /
966 exception. A new async method should be created to retrieve and display
967 the error message / exception.
969 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
970 code from constructor to init method adding exceptions as needed.
972 2011-10-26 Ben Konrath <ben@bagu.org>
974 Add script to monitor and restart tomcat if required.
976 * utils/check-and-recover-tomcat.py: New file.
978 2011-10-26 Ben Konrath <ben@bagu.org>
980 Display the correct number of data items in the pager.
984 https://bugzilla.gnome.org/show_bug.cgi?id=661441
986 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
987 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
988 The implementation is the same for both tables: Keep track of the
989 number of non-empty rows and fire and RowCountChangeEvent after the data has
991 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
992 custom Pager class that subclasses SimplePager to handle displaying
993 the correct number when empty rows have been added.
995 2011-10-26 Ben Konrath <ben@bagu.org>
997 Correct error in previous commit.
999 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1000 eventBus parameter from listView.setCellTable().
1002 2011-10-26 Ben Konrath <ben@bagu.org>
1004 Fix error in TODO comment.
1006 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1008 2011-10-24 Ben Konrath <ben@bagu.org>
1010 Create Notebook widgets to the details view.
1012 This isn't finished just yet - I still need to create a reasonable
1013 style to match the current theme.
1015 * src/main/java/org/glom/web/client/Utils.java: Add method for
1016 calculating the height of a widget. This is used in the Notebook class.
1017 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1018 new constructor method in Group.
1019 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1020 method for creating child widget that can be used by subclasses
1021 like Notebook. New constructor that allows disabling the group
1022 titles - Notebooks don't set a group title for their child groups.
1023 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1024 to make Notebooks using GWT's TabLayoutPanel.
1025 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1026 constructor that allows disabling the group titles.
1027 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1028 LayoutItemNotebook DTO.
1029 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1030 DTO for Notebooks. It's just an empty class for now but we might need
1031 it to transfer some specific information in the future.
1033 2011-10-21 Ben Konrath <ben@bagu.org>
1035 Add navigation buttons to related list tables.
1037 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1038 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1039 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1040 method getSuitableRecordToViewDetails() for getting the table name
1041 and primary key value for related list navigation buttons.
1042 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1043 private cell renderer class to get the navigation information for
1044 related list tables from the server. Extract the navigation
1045 processing code from the details cell navigation and use it for the
1046 related list navigation as well.
1047 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1048 cell renderer class for the details open buttons. This was needed
1049 because the related list navigation buttons and the list view
1050 navigation buttons need to react differently when clicked.
1051 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1052 the onEnterKeyDown() method because it's now overriden in the
1053 subclasses that are specific to the related list tables and the list
1055 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1056 the vertical size a little because the buttons add a bit of vertical
1057 space to table. This is not a perfect solution because the vertical
1058 size of with table fewer than 5 rows will be a little smaller.
1059 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1060 changes in how navigation buttons are handled.
1061 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1062 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1063 database access object.
1064 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1065 to find the portal for a given relationship name from
1066 RelatedListDBAccess. Add method to find a primary key field for a
1068 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1069 Move code to find the portal for a given relationship name to
1071 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1072 New file: database access object for getting the related list
1073 navigation information (the table name and the primary key value).
1074 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1075 DTO for transferring a table name to navigate to and a primary key
1077 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1078 boolean and getter/setter to specifies if the related list should add
1081 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1083 Use the master branch of java-libglom
1085 * pom.xml: Depend on java-libglom 1.19 instead.
1087 This is the master branch. See also the libglom-1-18 branch.
1089 2011-10-11 Ben Konrath <ben@bagu.org>
1091 Enable the open navigation button when the data has been set.
1093 This avoids having active buttons that don't do anything when the data
1096 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1098 2011-10-11 Ben Konrath <ben@bagu.org>
1100 Use IsWidget interface for FlowTableItem.
1102 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1103 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1105 2011-10-11 Ben Konrath <ben@bagu.org>
1107 Remove GWT styling from open button in details view.
1109 There are still some issues with how the details cell is arranged but
1110 this should be made to match Glom 1.20. I'm going to leave fixing this
1111 until I have Glom 1.20 up and running.
1113 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1114 style name on open button.
1115 * src/main/webapp/style.css: Move and edit details-navigation class.
1116 Re-arrange some classes to make them appear in the same order as the
1119 2011-10-07 Ben Konrath <ben@bagu.org>
1121 Update to GWT 2.4.0.
1123 * .gitignore: Ignore new cache directory.
1124 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1125 * pom.xml: Change GWT and maven plugin to 2.4.0.
1126 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1128 * src/main/java/org/glom/web/client/ClientFactory.java:
1129 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1130 * src/main/java/org/glom/web/client/OnlineGlom.java:
1131 Update source for API changes.
1132 * utils/build-onlineglom-war.sh: Remove cache directory before the
1135 2011-10-07 Ben Konrath <ben@bagu.org>
1137 Add navigation buttons in the details view.
1139 This isn't finished but I thought I'd commit what I have as it's a
1140 pretty good start. I still need to:
1142 1. Change the style so that it fits better into the current theme
1143 2. Adjust the details cell to expand as much as possible.
1145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1146 click handlers to navigation buttons in the DetailsCells. Create a
1147 refreshData() method to get just the data from the server without the
1149 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1150 Update the tableSelector and browser title when the table name
1151 changes without using the tableSelector.
1152 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1153 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1154 getDetailsCells() to getCells(). Update variable names.
1155 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1156 method to set click handler on navigation button. Rename a few
1157 variables. Add navigation buttons where needed.
1158 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1159 variables and methods.
1160 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1161 navigation boolean and navigation table as required in the
1162 LayoutItemField DTO.
1163 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1164 variables for navigation along with getter/setter methods.
1166 2011-10-07 Ben Konrath <ben@bagu.org>
1168 Rename Field to DetailsCell.
1170 This is a refactor-only commit. No functionality has been added or
1173 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1174 Update variable and method names.
1175 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1176 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1177 variable and method names.
1178 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1180 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1181 variable and method names.
1183 2011-10-07 Ben Konrath <ben@bagu.org>
1185 Create separate methods for layout and data the details view.
1187 This is a refactor-only commit. No functionality has been added or
1190 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1191 private methods: setData(), createLayout().
1193 2011-10-07 Ben Konrath <ben@bagu.org>
1195 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1197 This is part of a change to get navigation buttons in the details view
1198 but it should have been done this way from the start.
1200 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1201 for method name change in TableSelectionView.
1202 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1203 Create TableChangeEvent and set the browser title using the
1204 TableSelectionView API.
1205 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1206 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1207 Change getSelectedTable() to getSelectedTableName(). Add
1208 getSelectedTableTitle().
1210 2011-10-07 Ben Konrath <ben@bagu.org>
1212 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1214 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1216 2011-10-07 Ben Konrath <ben@bagu.org>
1218 Update TableChangeEvent to use newTableName naming convention.
1220 This makes the class more consistent with GWT naming conventions.
1222 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1223 Update for method name change in TableChangeEvent.
1224 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1225 for method name change in TableChangeEvent.
1226 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1227 newTableName variable and getter method. Make toDebugString()
1230 2011-09-30 Ben Konrath <ben@bagu.org>
1232 Disable the pager in the list tables when the data row count is less than the minimum.
1234 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1235 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1237 2011-09-30 Ben Konrath <ben@bagu.org>
1239 Add empty rows to the end of related list and list view tables.
1241 I also extracted the cell rendering classes from the ListTable because
1242 the code was becoming a little crazy with all the anonymous inner
1243 classes. My plan is to use these cell rendering classes in the details
1244 view as well so this refactor will be needed for that change.
1246 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1247 set the row count in related list tables if the data has more rows
1248 than the minimum number of rows visible.
1249 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1250 row count in list view tables if the data has more rows than the
1251 minimum number of rows visible.
1252 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1253 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1255 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1256 for rendering TYPE_NUMERIC cells. The code was extracted from the
1258 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1259 class for rendering cells with buttons in list views. The code was
1260 extracted from the ListTable class.
1261 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1262 for rendering TYPE_TEXT cells. The code was extracted from the
1264 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1265 Add empty rows to the end of the data if required. Implement
1266 ListTable.getMinNumVisibleRows().
1267 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1268 cell renderer code to public classes. Return null in
1269 Column.getValue() for empty rows. Add new abstract method:
1270 getMinNumVisibleRows(). Move code to set the row count of the list view
1271 table to ListViewImpl.
1272 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1273 empty rows to the end of the data if required. Implement
1274 ListTable.getMinNumVisibleRows().
1277 2011-09-27 Ben Konrath <ben@bagu.org>
1279 Use GWT.log for client-side debugging statements.
1281 These are optimized out when deployed so I should have used this method
1282 in the first place. These statements will eventually be replaced with some sort
1283 of notification in the browser.
1285 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1286 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1287 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1288 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1289 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1291 2011-09-27 Ben Konrath <ben@bagu.org>
1293 Put tableselector on the right, back to list link on right.
1295 The idea is that the table selector is acting like a label for the
1296 currently displayed table so it should be placed below the document title. This
1297 puts the table title in a similar position to where it is in Glom.
1299 * mockups/details-contacts.html:
1300 * mockups/details-projects.html:
1301 * mockups/listview-contacts.html:
1302 * mockups/listview-projects.html:
1303 * mockups/style.css:
1304 Update mockups to match how the interfaces currently look.
1305 * src/main/webapp/style.css: Swap positions of backlink with the table
1306 selector. Add some space on the left side of the table selector to
1307 line things up with the document title.
1309 2011-09-27 Ben Konrath <ben@bagu.org>
1311 Add field colouring to details view.
1313 This change re-works how field colouring works. The colour formatting
1314 information is now set to the client with the layout information instead of
1315 with the data. This eliminates the need to send the same colour strings for
1316 data in list view column when colour information is set.
1318 In order to set an alternate colour for negative numeric values, the
1319 number is now sent to client and formatted with the GWT NumberFormat class.
1321 This change also fixes:
1323 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1325 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1326 internationalization framework which is needed for client side numeric
1328 * src/main/java/org/glom/web/client/Utils.java: New file for some
1329 client static utility methods.
1330 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1331 the DataItem object to the Field class. Use a utility method to
1332 create the foreignKeyValue string.
1333 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1334 alignment and text colours in the constructor. Add setData(DataItem)
1335 method. Remove setText(String) method.
1336 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1337 colour information to GlomTextCell. Create and use GlomNumberCell for
1338 rendering numbers. Use utility method to get the string for the
1339 primary key of the key provider. Re-work how the horizontal alignment
1341 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1342 formatting to layout information. Methods for converting the libglom
1343 formatting information were moved from DBAccess.
1344 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1345 numeric formatting (it's now done on the client side). Don't set text
1346 colours in DataItem. Move libglom formatting conversion methods to
1348 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1349 getters/setters for text colour information.
1350 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1351 for transferring the libglom NumericFormat information to the client.
1352 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1353 and getters/setters for: GlomNumericFormat, background colour and
1354 foreground colour strings.
1356 2011-09-26 Ben Konrath <ben@bagu.org>
1358 Simplify code that iterates through the LayoutGroup.
1360 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1362 2011-09-26 Ben Konrath <ben@bagu.org>
1364 Accept Eclipse formatting for OnlineGlomServiceAsync.
1366 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1368 2011-09-26 Ben Konrath <ben@bagu.org>
1370 Don't use the ListDBAccess classes to get the primary key layout information.
1372 This was causing a bug where the wrong index for the hidden primary key
1373 was being sent to the client.
1375 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1376 primary key while creating the LayoutGroup DTO. Create a
1377 LayoutItemField DTO for hidden primary keys. Don't use the
1378 RelatedListDBAccess because it was only used for getting the primary
1380 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1381 access modifier from public to protected for getPrimaryKeyField() and
1382 getPrimaryKeyLayoutItemField().
1383 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1384 abstract method getExpectedResultSize() because RelatedListDBAccess
1385 doesn't have enough info to implement it.
1386 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1387 Remove @Override for getExpectedResultSize().
1388 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1389 Remove method getExpectedResultSize().
1391 2011-09-23 Ben Konrath <ben@bagu.org>
1393 Log which layout (list or details) the ignored item is from.
1395 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1397 2011-09-23 Ben Konrath <ben@bagu.org>
1399 Remove annotations that turn off code formatting in DataItem.
1401 * src/main/java/org/glom/web/shared/DataItem.java:
1403 2011-09-23 Ben Konrath <ben@bagu.org>
1405 Rename GlomField to DataItem and update associated methods.
1407 This is a rename-only refactor. No functionality has been added or
1410 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1411 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1412 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1413 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1414 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1415 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1416 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1417 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1418 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1419 * src/main/java/org/glom/web/server/database/DBAccess.java:
1420 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1421 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1422 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1423 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1424 * src/main/java/org/glom/web/shared/DataItem.java:
1425 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1426 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1428 2011-09-23 Ben Konrath <ben@bagu.org>
1430 Rename GlomDocument to DocumentInfo and update associated methods.
1432 This is a rename-only refactor. No functionality has been added or
1435 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1436 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1437 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1438 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1439 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1440 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1441 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1443 2011-09-20 Ben Konrath <ben@bagu.org>
1445 Require java-libglom 1.17.3.
1447 This picks up the fix for the seg fault problem with the Scenes table
1448 in the Openismus Film Manager example.
1452 2011-09-20 Ben Konrath <ben@bagu.org>
1454 Change the way sort clause is added for primary key when no sort clause is requested.
1456 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1457 before the sort clause is created. When a sort clause is not requested, the
1458 sort clause is created by finding the primary key in the LayoutFieldVector
1461 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1463 2011-09-20 Ben Konrath <ben@bagu.org>
1465 Log error message if no documents are found in the configured directory.
1467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1468 Extract the glom file extension string to a private static final class
1469 variable (mostly as syntactic sugar). Accept a minor formatting change.
1470 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1471 the example glom.document.directory configuration property to make it
1472 more clear that it can any directory, not just the home directory.
1474 2011-09-18 Ben Konrath <ben@bagu.org>
1476 Add related lists to details view.
1478 The related list table has support for paging and sorting just like the
1479 table in the list view.
1481 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1482 SQL queries for the related list tables.
1483 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1484 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1486 Rename getList methods to getListView and add comments. Remove
1487 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1488 it being unused. Add methods: getDetailsLayoutAndData(),
1489 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1490 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1491 Create the layout and set the data for the fields in one async call
1492 instead of two. Create related lists where appropriate.
1493 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1494 for method name changes in OnlineGlomService.
1495 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1496 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1497 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1499 * src/main/java/org/glom/web/client/ui/ListView.java:
1500 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1501 tableName from setCellTable(). Create a ListViewTable instead of
1503 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1504 represent a data field in the details view.
1505 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1506 from addDetailsCell() to Field class. Keep track of the Fields and
1507 Portals in the details view.
1508 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1509 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1510 and add a method to get it. Add method to set the contents of the
1512 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1513 New class for related list tables. This class has the data provider
1514 for the related list table.
1515 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1516 abstract class which is the base class for the ListViewTable and the
1518 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1519 New class for list view tables. This class has the data provider for
1520 the list view table.
1521 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1522 methods for related list tables. Add more information to the
1523 LayoutItemField and LayoutItemPortal DTOs.
1524 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1525 Remove debugging print statement.
1526 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1527 Remove debugging print statements. Add primary key field to SQL count
1529 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1530 Remove unnecessary LayoutFieldVector parameter from
1531 getResultSizeOfSQLQuery() method.
1532 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1533 New class for related list table database access.
1534 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1535 class that is a wrapper DTO for details view layout and data.
1536 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1537 new 'fromField' string to this DTO.
1538 * src/main/webapp/style.css: Remove bottom margin and override top
1541 2011-09-15 Ben Konrath <ben@bagu.org>
1543 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1545 This sets things up to make it easier to add the data retrieval for
1546 related lists (portals). No user noticeable changes were made with
1549 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1550 class has the code to retrieve the layouts and access the
1551 database using the new database helper classes.
1552 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1553 Most of the functionality has been removed from this class. This
1554 class now represents the public interface for the client side
1555 code. It also deals with configuring the servlet and cleaning
1556 things up when the servlet is stopped.
1557 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1558 of static methods into this utility class.
1559 * src/main/java/org/glom/web/server/database/DBAccess.java:
1560 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1561 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1562 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1563 These classes have the database retrieval code. The class hierarchy
1564 has been setup to make it easy to reuse code for similar
1567 2011-09-06 Ben Konrath <ben@bagu.org>
1569 Create separate classes for list table code and the data provider.
1571 As part of this refactor, I also split up the code a bit to make it
1574 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1575 table code to two new classes (below).
1576 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1577 with code from ListViewImpl.
1578 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1579 New file with code from ListViewImpl.
1581 2011-09-06 Ben Konrath <ben@bagu.org>
1583 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1585 This fixes the LayoutItemPortal DTO to match the libglom layout object
1588 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1590 2011-09-01 Ben Konrath <ben@bagu.org>
1592 Set title of Portals in the Details View.
1594 * pom.xml: Bump required version of java-libglom to 1.17.1.
1595 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1596 widget creation to its own class. Add comments to constructor.
1597 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1598 The code is mostly from the Group class with the title now set.
1599 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1600 title of Portal. Update some comments. Fix some code formatting.
1602 2011-09-01 Ben Konrath <ben@bagu.org>
1604 Remove TODO comment for the flow table column width.
1606 The flow table column width is working correctly and doesn't need to be
1607 changed. See this mailing list post for more info:
1609 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1611 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1613 2011-08-27 Ben Konrath <ben@bagu.org>
1615 Add document title (database name) to top of the browser page.
1617 I added the document title to the TableSelecitonView but that will
1618 change if / when we add a view that doesn't require table selection.
1620 * mockups/details-contacts.html:
1621 * mockups/details-projects.html:
1622 * mockups/listview-contacts.html:
1623 * mockups/listview-projects.html:
1624 * mockups/style.css: Add document title to mockups to keep things
1626 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1627 sizes to account for the document title.
1628 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1629 Set the document title when it has been retrieved from the server.
1630 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1631 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1632 and implement setDocumentTitle(String) method.
1633 * src/main/webapp/style.css: Add ID for document title style.
1635 2011-08-25 Ben Konrath <ben@bagu.org>
1637 Add NavigationType enum to LayoutItemPortal DTO.
1639 This is the start of adding support for Portals to the Details View.
1641 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1642 LayoutItem_Portal.navigation_type enum from libglom to
1643 LayoutItemPortal.NavigationType enum.
1644 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1645 NavigationType enum, field for storing the NavigationType and getter
1648 2011-08-25 Ben Konrath <ben@bagu.org>
1650 Implement the flow table layout in the Details View.
1652 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1653 FlowTable to Group to account for the renamed class.
1654 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1655 File. This is a container widget that implements the Glom details view
1656 flow table behaviour.
1657 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1658 org/glom/web/client/ui/FlowTable.java.
1659 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1660 so that the size of the subgroups are a closer match to the size of
1661 the Glom subgroups. This makes the flowtable layout match the layout
1662 in Glom for the Music Collection example file.
1664 2011-08-16 Ben Konrath <ben@bagu.org>
1666 Create container element for LayoutItemPortal in Details View.
1668 This will help me develop the layout for the FlowTable.
1670 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1671 fieldPanel variable to detailsCell.
1673 2011-08-15 Ben Konrath <ben@bagu.org>
1675 Set the height of the data element in the Details View.
1677 I changed the InlineLabels (text in a span element) to Labels (text in
1678 a div element) so that I could set the height of the details-data
1679 elements instead of the details-cell parent elements. This allows the
1680 the details-data element to display the correct height if style is
1681 applied that shows the height.
1683 This change has the added benefit of allowing the order of the labels
1684 and data elements to be changed for right-to-left languages.
1686 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1687 InlineLabels to Labels.
1688 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1689 InlineLabels to Labels. Set the height of the data element.
1690 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1691 multiline text height in the Formatting DTO.
1692 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1693 for multiline height along with getter and setter methods.
1694 * src/main/webapp/style.css: Adjust style to account for the change
1695 from span elements to div elements in the details cell.
1697 2011-08-15 Ben Konrath <ben@bagu.org>
1699 Make the List View appearance match the mockups.
1701 It doesn't match exactly but it's much better than it was.
1703 * mockups/listview-contacts.html: Remove unused css classes.
1704 * mockups/listview-projects.html: Remove unused css classes.
1705 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1706 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1707 for mainPanel instead of VerticalPanel (table). Set style name on
1708 CellTable. Set style name on Details column. Right-align Details
1710 * src/main/webapp/style.css: Adjust properties to match the mockups.
1712 2011-08-12 Ben Konrath <ben@bagu.org>
1714 Add better support for subgroups in the details view.
1716 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1717 changed FlowTable constructor.
1718 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1719 support for subgroups and subgroup-titles.
1720 * src/main/webapp/style.css: Add CSS class for subgroups and
1723 2011-08-12 Ben Konrath <ben@bagu.org>
1725 Return the top level LayoutGroup title.
1727 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1729 2011-08-11 Ben Konrath <ben@bagu.org>
1731 Make the TableSelector header match the mockup.
1733 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1734 the layout panel. Properly lineup the table selection header with
1735 the list and details view.
1736 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1737 margin around the details view.
1738 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1739 Rename listBox variable to tableSelector. Set id for the style sheet.
1740 Use a FlowPanel instead of a HorizontalPanel.
1741 * src/main/webapp/style.css: Add properties to make the TableSelector
1742 box match the mockups.
1744 2011-07-13 Ben Konrath <ben@bagu.org>
1746 Update install script for java-libglom version change.
1748 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1751 2011-07-13 Ben Konrath <ben@bagu.org>
1753 Add support sub-group in the details view.
1755 I also removed the code that special-cased the default details view
1758 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1760 I still have to make a proper flowtable.
1762 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1763 Don't special-case default details view layout.
1764 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1765 addLayoutField() as I'm going to use it.
1766 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1767 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1769 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1770 extracted from DetailsViewImpl.GroupPanel. Add support for
1772 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1773 column count when getting the details layout.
1775 2011-07-12 Ben Konrath <ben@bagu.org>
1777 Set browser title with database and table titles.
1779 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1780 Set the browser title when the table changes and when the activity
1782 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1783 title when retrieving document info (the GlomDocument object).
1784 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1785 with getter and setter methods. Remove unused convenience constructor.
1786 Use default code formatting.
1788 2011-07-12 Ben Konrath <ben@bagu.org>
1790 Ignore LayoutItemPortals in the details view.
1792 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1795 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1796 LayoutItemPortal layout objects.
1797 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1798 LayoutItemPortal objects when retrieving the details layout.
1799 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1800 file. This is an empty class and just used to get type information for
1803 2011-07-12 Ben Konrath <ben@bagu.org>
1805 Use java-libglom 1.17.0.
1809 2011-07-11 Ben Konrath <ben@bagu.org>
1811 Remove "Table:" label from table selector.
1813 This matches a recent change in the Glom UI.
1815 * mockups/details-contacts.html:
1816 * mockups/details-projects.html:
1817 * mockups/listview-contacts.html:
1818 * mockups/listview-projects.html: Remove the "Table:" label from the
1820 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1822 2011-07-11 Ben Konrath <ben@bagu.org>
1824 Add main groups to the details view.
1826 This makes things look a little nicer in the details view. The next step
1827 is to implement the flowtable.
1829 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1830 resources from the standard gwt css theme. Standard.css is now
1831 included in OnlineGlom.html so that the online glom css rules have
1832 precedence over the gwt theme.
1833 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1834 the whole LayoutGroup to the DetailsView instead of just the titles.
1835 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1836 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1837 details layout with a helper class (GroupPanel). I might extract this
1838 class when I make the full flowtable.
1839 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1840 string as default so I don't have to worry about NPEs when processing
1842 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1843 note beside OnlineGlom.gwt.xml above).
1844 * src/main/webapp/style.css: Add default font-size to body to override
1845 the font-size set by the standard theme. Don't use h2 tags for
1846 group-title. Create new details-cell class.
1848 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1850 ConfiguredDocument: Set the port number too.
1852 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1853 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1854 Glom document. Presumably this worked sometimes so far because there is a
1855 default port number.
1857 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1859 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1861 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1862 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1863 correct, though we should throw an exception too.
1865 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1867 Fix a addDocuemnt typo.
1869 * src/main/java/org/glom/web/shared/Documents.java
1870 (Documents.addDocuemnt): Rename to addDocument().
1871 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1872 (OnlineGlomServiceImpl.getDocuments): Adapt.
1874 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1876 Slightly improved log output when connection fails.
1878 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1879 (ConfiguredDocument.setUsernameAndPassword):
1880 We don't know for sure if it' the username/password that's wrong, so
1881 rephrase the message.
1882 Also ouput the exception message, though it's generic in this case.
1884 2011-07-08 Ben Konrath <ben@bagu.org>
1888 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1889 added braces to a one line if statement because the Eclipse formatter
1890 was getting confused.
1892 2011-07-07 Ben Konrath <ben@bagu.org>
1894 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1896 These should really be two separate tasks but I counldn't get things to
1897 work with GWT 2.2.0 and Eclipse 3.7.
1901 * .settings/org.eclipse.jdt.core.prefs:
1902 * .settings/org.eclipse.jdt.ui.prefs:
1903 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1904 * .settings/org.eclipse.m2e.core.prefs:
1905 Add new config files. Update current files. Remove references to the
1906 webtools plugins as we're not using any of the webtools features.
1907 * .gitignore: Add logs directory which is created when running with
1909 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1910 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1911 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1913 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1915 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1917 onlineglom.properties: Add explanatory comments.
1919 * src/main/resources/onlineglom.properties: Also change the default user
1920 from ben to someuser, to avoid the risk of people thinking we just
1921 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1923 2011-06-28 Ben Konrath <ben@bagu.org>
1925 Use filename in Log for incorrect passwords.
1927 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1928 getFileName(String) method to get the filename from the URI.
1930 2011-06-28 Ben Konrath <ben@bagu.org>
1932 Add the table name to the URL token for the ListPlace.
1934 This makes things consistent between the DetailsPlace and the
1935 ListPlace. It also allows the the ListPlace to be bookmarked.
1937 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1938 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1939 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1940 Remove getDefaultListLayout(). The default layout is now returned
1941 by the getListLayout() method when the table name is an empty string.
1942 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1943 Add table name field. Change to a new ListPlace when the table
1944 has been changed. Use getListLayout() for getting the default
1946 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1947 Add table name field. Set the correct table name in the list box
1948 when loading from bookmark. This corrects a problem for the
1950 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1951 Move table name to super-class (HasSelectableTable). Move document
1952 and table URL keys to super-class in HasSelectableTable.
1953 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1954 Add table name field. Add Tokenizer class with URL key common to
1955 the subclasses (DetailsPlace and ListPlace).
1956 * src/main/java/org/glom/web/client/place/ListPlace.java:
1957 Add table name. Add code to parse the URL token.
1958 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1959 Update ListPlace construction with empty table name string.
1960 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1961 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1962 Change setTableSelectedIndex(int) to setSelectedTableName(String).
1963 Update ListPlace construction with table name string.
1964 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1965 Change defaultTableName field to tableName to reflect how it's now
1966 used. Update the getter and setter methods.
1968 2011-06-28 Ben Konrath <ben@bagu.org>
1970 Enable the table selector in the DetailsView.
1972 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1973 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1974 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1975 Remove getDefaultDetailsLayout(). The default layout is now returned
1976 by the getDetailsLayout() method when the table name is an empty
1978 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1979 event handler for table change event. Change to using
1980 getDetailsLayout() for the default details layout.
1981 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
1983 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
1984 when navigating to the details place.
1986 2011-06-27 Ben Konrath <ben@bagu.org>
1988 Use filename based unique document ID in URL and for RPC.
1990 The document ID is the glom document name with spaces (' ') replaced
1991 with pluses ('+') and without the .glom extension.
1993 This change is mostly a string substitution of 'documentTitle' for
1994 'documentID'. The only code change is the addition of a Documents DTO to get the
1995 filename to document title mappings as indicated below.
1997 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1998 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1999 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2000 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2001 Use Documents DTO to create the document links in the document
2003 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2004 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2005 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2006 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2007 * src/main/java/org/glom/web/client/place/ListPlace.java:
2008 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2009 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2010 * src/main/java/org/glom/web/client/ui/ListView.java:
2011 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2012 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2013 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2014 * src/main/java/org/glom/web/server/Log.java:
2015 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2016 getDocumentTitles() to getDocuments() and return the Documents DTO.
2017 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2018 transferring the filename to document title mappings.
2020 2011-06-25 Ben Konrath <ben@bagu.org>
2022 Make the authentication popup work again.
2024 This bug was introduced when I extracted ConfiguredDocument to its own class.
2026 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2027 correct success / fail status in setUsernameAndPassword().
2029 2011-06-25 Ben Konrath <ben@bagu.org>
2031 Use filename as unique key for configuring database usernames and passwords.
2033 This replaces the use of the Glom document title which could change
2034 depending on the locale. Thanks to Murray Cumming for pointing out this
2037 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2038 * src/main/resources/onlineglom.properties:
2040 2011-06-24 Ben Konrath <ben@bagu.org>
2042 Pass primary key value to DetailsView.
2044 This enables the DetailsView to load the correct data.
2046 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2047 primary key value field and set in constructor. Pass primary key
2048 value to getDetailsData().
2049 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2050 variables for document title and primary key value.
2051 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2052 key value to the DetailsPlace.
2054 2011-06-24 Ben Konrath <ben@bagu.org>
2056 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2058 This allows the primary key to be retrieved by the Details button. This
2059 functionality has not been implemented yet but it's in the works.
2061 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2062 the LayoutGroup result to ListView.setCellTable instead of all of its
2063 fields individually.
2064 * src/main/java/org/glom/web/client/ui/ListView.java:
2065 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2066 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2067 get the primary key for the table.
2068 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2069 index of the primary key in the LayoutGroup accounting for hidden
2070 primary keys. Rename getJavaNumberFormat() to
2071 convertToJavaNumberFormat() for consistency. Cleanup / add some
2073 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2074 field for primary key index and a field to indicate whether the
2075 primary key is hidden or not.
2077 2011-06-23 Ben Konrath <ben@bagu.org>
2079 Rename getTableData methods to getListData.
2081 This is a rename refactor for consistency with other methods.
2083 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2084 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2085 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2086 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2088 2011-06-23 Ben Konrath <ben@bagu.org>
2090 Extract the ConfiguredDocument innerclass into its own class.
2092 This makes the servlet code more object oriented.
2094 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2095 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2096 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2097 new ConfiguredDocument class.
2099 2011-06-21 Ben Konrath <ben@bagu.org>
2101 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2103 This makes things more inline with how libglom works and reduces code
2104 duplication. This refactor lays the groundwork for adding the primary key to
2105 the LayoutGroup object.
2107 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2108 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2109 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2110 Change method names to getListLayout and getDefaultListLayout for
2111 consistency. Use LayoutGroup as the DTO for the list layout instead of
2112 ColumnInfo and LayoutListTable.
2113 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2114 new method names along with the LayoutGroup object for transferring the
2116 * src/main/java/org/glom/web/client/ui/ListView.java:
2117 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2118 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2119 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2121 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2122 Replaced with LayoutGroup.
2123 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2124 expectedResultSize and defaultTableName fields which are needed for
2126 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2127 type field which is needed for the list layout but will also be
2128 useful for the details layout as things progress.
2129 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2130 Make class abstract. Remove the unnecessary
2131 getFormattingHorizontalAlignment method. Add setFormatting method.
2133 2011-06-16 Ben Konrath <ben@bagu.org>
2135 Add scripts for building and installing war.
2137 These will help when updating OnlineGlom but they're also good
2138 supplemental documentation of the build and deployment proceeding.
2140 * utils/build-onlineglom-war.sh: New file.
2141 * utils/install-onlineglom-war.sh: New file.
2143 2011-06-16 Ben Konrath <ben@bagu.org>
2145 Create wrapper class to create consistent log messages.
2147 I wrapped methods in the Log class of gwt-log to add the method names
2148 from the servlet and create consistent formatting of the document title
2149 and table names in the log messages.
2151 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2153 log methods to use methods from wrapped Log class.
2155 2011-06-16 Ben Konrath <ben@bagu.org>
2157 Remove superfluous conditional return.
2159 Thanks to Murray Cumming for pointing this out!
2161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2163 2011-06-15 Ben Konrath <ben@bagu.org>
2165 Return an ArrayList of LayoutGroups for the Details layout.
2167 This corrects a problem with the details layout as it can have more
2168 than one top level LayoutGroup.
2170 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2171 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2172 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2173 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2174 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2175 with ArrayList of LayoutGroups for the details view layout.
2176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2177 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2178 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2179 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2180 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2181 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2183 2011-06-14 Ben Konrath <ben@bagu.org>
2185 Use cast_dynamic method to determine the libglom LayoutItem type.
2187 This is better than finding the LayoutItem type by using the string
2188 returned from the get_part_type_name() method.
2190 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2192 2011-06-14 Ben Konrath <ben@bagu.org>
2194 Add method names to log entries in the servlet.
2196 This helps when tracking down deployment problems.
2198 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2200 2011-06-14 Ben Konrath <ben@bagu.org>
2202 Add data to the DetailsView using a hard-coded primary key value.
2204 The layout and functionality of the DetailsView is not complete. This
2205 is just a checkpoint so the patch doesn't get too big.
2207 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2208 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2209 Add getDetailsData() servlet method.
2210 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2211 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2212 LayoutFields are added to the DetailsView.
2213 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2214 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2215 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2216 take the string for the title instead of the object.
2217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2218 Add implementation getDetailsData() along with some private helper
2220 * src/main/webapp/style.css: Add padding to details-data class. Add a
2221 details-label class with the same padding as the details-data class.
2223 2011-06-03 Ben Konrath <ben@bagu.org>
2225 Use presenter.goTo() to change to the DetailsPlace.
2227 This will make things easier when we need to open the DetailsView with
2228 data specific to the row that was clicked.
2230 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2232 2011-06-02 Ben Konrath <ben@bagu.org>
2234 Add CSS file from mockups.
2236 I'm adding this now because it's going to be useful to have when
2237 developing the DetailsView. The TableSelectionView and ListView aren't
2240 * src/main/webapp/OnlineGlom.html:
2241 * src/main/webapp/style.css:
2243 2011-06-02 Ben Konrath <ben@bagu.org>
2245 Use String.isEmpty() to check for empty string.
2247 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2249 2011-06-02 Ben Konrath <ben@bagu.org>
2251 Display main layout group titles in the DetailsView.
2253 This is the start of the DetailsActivity/DetailsView implementation.
2255 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2256 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2257 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2258 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2259 Get the layout information for the details view from the server and set
2260 the main layout group titles.
2261 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2262 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2263 Add addLayoutGroup() and addLayoutField() methods. This are just
2264 temporary methods for creating the the details view that will change
2266 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2267 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2269 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2270 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2271 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2272 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2273 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2274 Data Transfer Objects that mimic the libglom object structure. These are
2275 used for transferring the details layout but could also be used for
2276 transferring the list layout.
2278 2011-05-27 Ben Konrath <ben@bagu.org>
2280 Reset the AuthenticationPopup when clearing the ListView.
2282 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2284 2011-05-27 Ben Konrath <ben@bagu.org>
2286 Fix problem with onlineglom.properties file loading.
2288 The old way worked in Eclipse but not on the server. Loading the
2289 onlineglom.properties file now works in Eclipse and on the server.
2291 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2293 2011-05-24 Ben Konrath <ben@bagu.org>
2295 Update gwt-log from 3.1.0 to 3.1.2.
2297 Gwt-log 3.1.0 has been marked as depreciated.
2301 2011-05-24 Ben Konrath <ben@bagu.org>
2303 Add comment to ListActivity.goTo() method.
2305 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2307 2011-05-24 Ben Konrath <ben@bagu.org>
2309 Remove FIXME in convertGdkColorToHtmlColour()
2311 The Gdk::Color value returned by libglom is 16-bits per channel on both
2312 64 and 32-bit platforms.
2314 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2316 2011-05-19 Ben Konrath <ben@bagu.org>
2318 Improve performance of initial ListView load.
2320 I removed a round trip to the server for getting the default table name
2321 and then requesting information about that table. This also removes a potential
2322 problem with the table change handler not being setup in time to receive the
2323 table change event from the ListActivity.
2325 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2326 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2327 getDefaultLayoutListTable() method. Improve comments.
2328 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2329 getDefaultLayoutListTable() method instead of firing a table change
2330 event to get the table to load.
2331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2332 implementation of getDefaultLayoutListTable() method.
2333 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2336 2011-05-19 Ben Konrath <ben@bagu.org>
2338 Override toDebugString() in TableChangeEvent.
2340 This is useful to have for debugging.
2342 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2344 2011-05-19 Ben Konrath <ben@bagu.org>
2346 Add a "Back to List" link when at the DetailsPlace.
2348 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2349 Populate the CellTable based on the selected table of the ListBox if
2350 it's set otherwise use the default table. This allows the "Back to
2352 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2353 Remove Place from constructors. Add a setPlace() method. Add
2354 goToPlace() method. Set class as presenter for TableSelectionView.
2355 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2356 Use the same TableSelectionActivity when switching between the List and
2358 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2359 Subclass the new HasSelectableTablePlace. This removes some duplicate
2361 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2362 New class to represent Places that display the TableSelectionView.
2363 * src/main/java/org/glom/web/client/place/ListPlace.java:
2364 Subclass the new HasSelectableTablePlace. This removes some duplicate
2366 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2367 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2368 Add Presenter interface. Add setBackLinkVisible() method. Add
2369 setBackLink() method.
2371 2011-05-18 Ben Konrath <ben@bagu.org>
2373 Enable the "Details" buttons.
2375 Right now only an empty details view is displayed.
2377 * src/main/java/org/glom/web/client/ClientFactory.java:
2378 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2379 Add DetailsView to ClientFactory.
2380 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2381 A basic activity for the details view.
2382 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2383 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2385 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2386 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2388 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2389 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2390 unnecessary super() in constructor.
2391 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2392 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2393 really shouldn't create a new TableSelectionActivity for both the ListPlace
2394 and the DetailsPlace so this should be considered a temporary solution.
2395 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2396 New file. Represents a URL for the details view.
2397 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2398 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2399 A basic details view interface and implementation.
2400 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2401 Enable the "Details" buttons.
2403 2011-05-12 Ben Konrath <ben@bagu.org>
2405 Use a LayoutPanel with multiple display areas for main layout.
2407 This is mostly a refactor in that there are no changes from the user
2408 point of view. These changes are required so that we can swap out the list view
2409 with the details view when the user clicks the "Details" button.
2411 * src/main/java/org/glom/web/client/ClientFactory.java:
2412 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2413 OnlineGlomView. Add TableSelectionView, ListView and
2414 AuthenticationPopup.
2415 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2416 for main layout. Add display regions for main activities. Add
2417 activity manager for for main activities.
2418 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2419 file from parts of the deleted OnlineGlomActivity.
2420 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2421 New file from parts of the deleted OnlineGlomActivity.
2422 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2423 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2424 New files for app wide table change event.
2425 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2426 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2427 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2428 Activity mappers for the main activities replace the deleted app-wide
2430 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2431 Fix a spelling error in he comment.
2432 * src/main/java/org/glom/web/client/ui/ListView.java:
2433 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2434 Renamed from LayoutListView and modified for MVP. This still not a
2435 proper dumb view as prescribed by the MVP pattern but it works for now.
2436 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2437 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2438 New widget stripped out of the deleted OnlineGlomView.
2439 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2440 Remove hack that is fixed by this patch.
2442 2011-05-06 Ben Konrath <ben@bagu.org>
2444 Rename OnlineGlomPlace to ListPlace.
2446 The only change besides the rename is that url will now display #list
2447 instead of #Document.
2449 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2450 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2451 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2452 * src/main/java/org/glom/web/client/place/ListPlace.java:
2453 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2455 2011-05-06 Ben Konrath <ben@bagu.org>
2457 Use Presenter for app navigation.
2459 This is the proper way to deal with Place (URL) changes with the MVP
2462 * src/main/java/org/glom/web/client/ClientFactory.java:
2463 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2464 PlaceHistoryMapper and PlaceHistoryHandler.
2465 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2466 PlaceHistoryMapper and PlaceHistoryHandler.
2467 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2468 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2469 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2470 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2471 Add Presenter interface and setPresenter methods. Rename addHyperLink
2472 to addDocumentLink taking only the document title as a parameter.
2474 2011-04-14 Ben Konrath <ben@bagu.org>
2476 Prompt for db username/password if they haven't been set.
2478 This is implemented with a popup widget that is contained within the
2479 OnlineGlomView and managed by the OnlineGlomActivity.
2481 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2482 methods for checking and setting the database username and password.
2483 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2484 new methods for checking and setting the database username and
2486 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2487 Display authentication popup if the JDBC connection to the database
2488 has not been authenticated.
2489 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2491 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2492 for dealing with the authentication popup.
2493 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2494 Implement the methods for dealing with the authentication popup.
2495 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2496 try to executed queries if the database connection hasn't been
2497 authenticated. Implement methods for checking and setting the
2498 database username and password.
2500 2011-04-12 Ben Konrath <ben@bagu.org>
2502 Make log messages a little clearer.
2504 Add a dash betweeen the document title and the table name.
2506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2508 2011-04-12 Ben Konrath <ben@bagu.org>
2510 Protect against NPEs when cleaning up database resources.
2512 While this isn't strictly necessary because the exception is caught,
2513 not protecting against the NPEs makes it harder to find the real error
2516 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2518 2011-04-12 Ben Konrath <ben@bagu.org>
2520 Move configuration of the servlet to the constructor.
2522 The servlet will be initialized even if the database authentication
2523 information is not set or correct. I still need to add the UI for prompting
2524 the user for the authentication information when it's required.
2526 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2527 javadocs for getDocumentTitles() method.
2528 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2529 Set error message when RPC fails.
2530 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2531 glom files directory from the configuration file. Try to set the
2532 database authentication information for the specific document if it's
2533 set and works otherwise try to use the global authentication
2534 information set for the directory.
2535 * src/main/resources/onlineglom.properties: Moved from
2536 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2537 Added detailed comments for the new keys.
2539 2011-04-11 Ben Konrath <ben@bagu.org>
2541 Remove unnecessary @Override in DocumentSelectionViewImpl.
2543 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2545 2011-04-11 Ben Konrath <ben@bagu.org>
2547 Remove center alignment in DocumentSelectionView.
2549 The title element is still centred but the document titles and bottom
2550 sentence are both left-aligned.
2552 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2554 2011-04-11 Ben Konrath <ben@bagu.org>
2556 Change 'Demo' naming convention to 'Document'.
2558 This is just a rename refactor with no functional changes to the code.
2560 * src/main/java/org/glom/web/client/ClientFactory.java:
2561 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2562 * src/main/java/org/glom/web/client/OnlineGlom.java:
2563 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2564 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2565 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2566 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2567 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2568 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2569 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2570 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2571 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2572 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2574 2011-04-08 Ben Konrath <ben@bagu.org>
2576 Remove FIXME from safeLongToInt() method.
2578 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2581 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2583 2011-04-08 Ben Konrath <ben@bagu.org>
2585 Display an error if no glom documents are found in the specified directory.
2587 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2588 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2589 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2590 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2592 2011-04-08 Ben Konrath <ben@bagu.org>
2594 Add copyright header to one more file ... oops.
2596 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2598 2011-04-08 Ben Konrath <ben@bagu.org>
2600 Add copyright header to files without it.
2602 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2603 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2604 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2605 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2606 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2607 * src/main/java/org/glom/web/shared/GlomField.java:
2609 2011-04-08 Ben Konrath <ben@bagu.org>
2611 Add support for accessing multiple glom documents in the servlet.
2613 This completes the demo selection functionality.
2615 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2616 document title to methods.
2617 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2618 document title to methods.
2619 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2620 Set browser window title when the activity starts. Correct name of
2621 document title variable.
2622 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2623 Set browser window title when the activity starts. Set the table
2624 selector change handler after table selector has been set. Clear the
2625 OnlineGlomView when the activity has been stopped.
2626 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2627 document title as the place token. Use "#Document:" instead of
2628 "#OnlineGlomPlace:" in the URL.
2629 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2630 Change heading to "Online Glom"
2631 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2632 document title in RPC methods.
2633 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2634 setDocumentTitle() method. Add clear() method.
2635 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2636 setDocumentTitle() method. Implement clear() method which removes the
2637 change handler on the ListBox, clears the ListBox and clears the
2639 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2640 Implement methods with document title. Keep track for the configured
2641 glom documents and their corresponding JDBC configurations in a hash
2642 table. This information is retrieved using the document title as the
2643 key in the hash table.
2644 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2645 document title field as it's no longer needed.
2647 2011-04-08 Ben Konrath <ben@bagu.org>
2649 Update the Eclipse JDT configuration.
2651 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2652 methods. Automatically add the copyright header to new files.
2654 2011-04-05 Ben Konrath <ben@bagu.org>
2656 Add new page for demo selection.
2658 This patch adds all the components required to view and start an
2659 OnlineGlom demo by clicking on the desired hyperlink. The user is
2660 able to return to the demo selection page with the browser's back
2661 button. I still need to modify the servlet to work with multiple
2662 documents so all demo links will load the file defined in the
2663 OnlineGlom.properties.
2665 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2666 This is only useful during development so we don't need to save it.
2667 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2668 get a reference to the DemoSelectionView.
2669 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2670 method to get a reference to the DemoSelectionView.
2671 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2672 default view to DemoSelectionView.
2673 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2674 to get glom document titles for glom files in a hard-coded directory.
2675 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2676 method to get glom document titles for glom files in a hard-coded
2678 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2679 Presenter for DemoSelectionView.
2680 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2681 for DemoSelectionView.
2682 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2683 Update for DemoSelectionView.
2684 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2685 Basic 'Place' implementation for the DemoSelectionView.
2686 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2687 The interface for the DemoSelectionView.
2688 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2689 The implementation of the DemoSelectionView.
2690 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2691 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2692 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2693 implementation of method to get glom document titles for glom files
2694 in a hard-coded directory.
2695 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2696 on longer being used.
2697 * src/main/webapp/glom.png: Glom logo.
2699 2011-04-05 Ben Konrath <ben@bagu.org>
2701 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2703 This is the forth and final commit of a refactor that will allow
2704 OnlineGlom to be used with multiple documents.
2706 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2707 Move RPC code from OnlineGlomViewImpl to this class.
2708 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2710 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2711 RPC code to the presenter class (the P in MVP).
2713 2011-04-04 Ben Konrath <ben@bagu.org>
2715 Start moving the existing OnlineGlom code to MVP.
2717 This work is based on the GWT MVP framework that is documented here:
2719 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2721 This is the third commit of a refactor that will allow OnlineGlom to
2722 be used with multiple documents.
2724 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2725 Interface for client factory which is used to get instances of various
2726 classes throughout the app.
2727 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2728 Implementation of client factory.
2729 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2730 initialize the MVP framework.
2731 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2732 New file. Activity manager for the main container widget. This is the
2734 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2735 Maps place (URL) to its corresponding activity.
2736 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2737 New file. This is just a place holder for a generated file.
2738 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2739 New file. Represents the URL for the main Online Glom app.
2740 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2741 for changes in LayoutListViewImpl.
2742 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2743 interface for View. Move code to OnlineGlomViewImpl class.
2744 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2745 file. Implementation of OnlineGlomView.
2746 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2747 Place resources. Use ClientFactoryImpl by default.
2749 2011-04-04 Ben Konrath <ben@bagu.org>
2751 Move View classes to their own package.
2753 This is the second commit of a refactor that will allow OnlineGlom to
2754 be used with multiple documents.
2756 * src/main/java/org/glom/web/client/OnlineGlom.java:
2757 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2758 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2760 2011-04-02 Ben Konrath <ben@bagu.org>
2762 Move UI code from the main module to its own class.
2764 This is the first commit of a refactor that will allow OnlineGlom to be
2765 used with multiple documents.
2767 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2768 references to OnlineGlom to OnlineGlomView.
2769 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2770 OnlineGlomView and instantiate it here.
2771 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2772 represents the main OnlineGlomView with one document.
2774 2011-04-01 Ben Konrath <ben@bagu.org>
2776 Fix formatting of gwt.xml and add DTD.
2778 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2780 2011-03-30 Ben Konrath <ben@bagu.org>
2782 Propperly convert gdkColor string to html colour string.
2784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2786 2011-03-28 Ben Konrath <ben@bagu.org>
2788 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2790 This implementation matches
2791 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2792 readable and is not tied to Swig.
2794 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2796 2011-03-28 Ben Konrath <ben@bagu.org>
2798 Use read-only checkboxes for boolean field types.
2800 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2801 in the CellTable based on the field type. It currently only
2802 distinguishes between boolean and text columns but I'll need to add
2803 support for more types.
2804 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2805 column type in the ColumnInfo object. Add method to convert between the
2806 glom field type enum in ColumnInfo and the glom field type in libglom.
2807 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2809 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2810 getting and setting booleans.
2812 2011-03-25 Ben Konrath <ben@bagu.org>
2814 Don't get the Date twice from the ResultSet.
2816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2818 2011-03-25 Ben Konrath <ben@bagu.org>
2820 Cleanup code in the servlet.
2822 * TODO: Remove item about row count. Add item about testing row count
2823 query with large number of rows.
2824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2825 spelling mistakes, change method parameter to be consistent with
2828 2011-03-25 Ben Konrath <ben@bagu.org>
2830 Add server side logging with the gwt-log library.
2832 * .gitignore: Ignore the log file we're now producing.
2833 * TODO: Add a couple TODO item for logging.
2834 * pom.xml: Add gwt-log and log4j as a dependency.
2835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2836 logging of errors, warnings and some important info.
2837 * src/main/resources/log4j.properties: New file to configure log4j.
2839 2011-03-24 Ben Konrath <ben@bagu.org>
2841 Add a disable button for the Details view.
2843 * src/main/java/org/glom/web/client/LayoutListView.java:
2845 2011-03-22 Ben Konrath <ben@bagu.org>
2847 Use a count query to get the number of rows for the list view pager.
2849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2851 2011-03-22 Ben Konrath <ben@bagu.org>
2853 Add more TODO information about CellTable pager positioning.
2857 2011-03-19 Ben Konrath <ben@bagu.org>
2859 Add TODO item about CellTable pager positioning.
2863 2011-03-18 Ben Konrath <ben@bagu.org>
2865 Remove unneeded GlomFieldColumn class.
2867 This is just a small code cleanup.
2869 * src/main/java/org/glom/web/client/LayoutListView.java:
2871 2011-03-18 Ben Konrath <ben@bagu.org>
2873 Use cursor mode in the query that gets data for the list view.
2875 I still need to fix the potential memory problem when getting the row
2876 count for the list view.
2878 * TODO: Add note about testing memory usage with large data sets. Add
2879 item about fixing row counting with large data sets.
2880 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2881 PostgreSQL JDBC driver into cursor mode when getting data for the
2884 2011-03-15 Ben Konrath <ben@bagu.org>
2886 Remove the GWT Container from the Eclipse build classpath.
2888 The GWT dependencies are set by Maven so this isn't needed.
2892 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2894 Added some earlier mockups to git, but not to the tarball dist.
2896 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2897 Openismus. These hopefully show how we might structure the HTML so that
2898 it can be styled easily with CSS. However, we probably need to adapt them
2899 for the CSS structure that GWT dictates for common widgets.
2901 2011-03-14 Ben Konrath <ben@bagu.org>
2903 Locate OnlineGlom.properties using the ServletContext.
2905 This is required to be able to locate the file in the deployed servlet.
2907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2908 Configure the database and glom document in in a helper method so
2909 that the ServletContext can be used to locate OnlineGlom.properties.
2910 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2911 src/main/webapp. This is the proper location for .properites files.
2913 2011-03-12 Ben Konrath <ben@bagu.org>
2915 Add note to README about why we're compiling down to obfuscated JavaScript.
2919 2011-03-11 Ben Konrath <ben@bagu.org>
2921 Use properties file to configure servlet.
2923 This allows people to change the glom file path, db username and db
2924 password without recompiling the code.
2926 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2927 * src/main/webapp/OnlineGlom.properties:
2929 2011-03-11 Ben Konrath <ben@bagu.org>
2931 Use table fields in layout list view if the layout list is not defined.
2933 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2934 Manually create a LayoutFieldVector for the query builder using the
2935 table fields when a layout list is not defined in the glom file.
2937 2011-03-11 Ben Konrath <ben@bagu.org>
2939 Only show FIXME string for images when there's an image.
2941 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
2942 in this change are some small code cleanups.
2944 2011-03-11 Ben Konrath <ben@bagu.org>
2946 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
2948 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2950 2011-03-11 Ben Konrath <ben@bagu.org>
2952 Correctly set the index of the default table.
2954 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2955 Correctly set the index of the default table. Add commented out example
2958 2011-03-10 Ben Konrath <ben@bagu.org>
2960 Add comment to pom.xml about the previous change.
2962 * pom.xml: Add comment about the deployment issue so that it's obvious
2963 why java-libglom is set to the provided scope.
2965 2011-03-10 Ben Konrath <ben@bagu.org>
2967 Change java-libglom dependency from compile to provided in pom.xml.
2969 Since java-libglom uses jni it can only be loaded once and therefore
2970 must be placed in $CATALINA_HOME/lib and not included in each war.
2971 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
2972 More information about this issue can be found in the Tomcat 6 release
2973 notes in the "JNI Based Applications" section:
2975 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
2977 * README: Remove note about this issue. Deployment info should really
2978 be on the wiki anyway so I'll add it right now.
2979 * pom.xml: Change java-libglom dependency from compile to provided so
2980 that it's copied in to the packaged war.
2982 2011-03-09 Ben Konrath <ben@bagu.org>
2984 Change to using a neutral locale for currency, date and time formatting.
2986 This solves the problem of currency values being represented without a
2987 space between the currency code and the number (e.g. "EUR5.89" is now
2988 represented as "EUR 5.89"). More work is required when we implement
2989 a locale preference setting.
2991 * TODO: Add note about currency formatting issues with different
2993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2994 to using the neutral ROOT locale.
2996 2011-03-09 Ben Konrath <ben@bagu.org>
2998 Add support for currency codes that are not ISO 4217 codes.
3000 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3001 the currency code defined in the glom file when it's not 3 characters
3002 long or when Java doesn't recognize the string as an ISO 4217 code.
3004 2011-03-08 Ben Konrath <ben@bagu.org>
3006 Remove test classes, launch configurations and configuration.
3008 The test stuff was getting in the way when creating the war. To make
3009 the war file you can now do 'mvn clean package'. The packaged war file
3010 will be in the target directory.
3012 * .classpath: Remove unused classpathentry for tests and i18n.
3013 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
3014 property. Don't run test or i18n goals when packaging the war.
3015 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
3020 * OnlineGlomTest-dev.launch:
3021 * OnlineGlomTest-prod.launch:
3022 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
3023 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
3025 2011-03-07 Ben Konrath <ben@bagu.org>
3027 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
3029 These fixes allow me to use 'mvn deploy' to create the war file.
3031 * .classpath: This generated config has been updated by Eclipse. This
3032 change was probably triggered by me updating from Eclipse 3.6.1 to
3034 * .gitignore: Add entry to ignore the directory
3035 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
3036 * .project: The generated config has been updated by Eclipse. This
3037 change was probably triggered by me updating from Eclipse 3.6.1 to
3039 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3040 so that Eclipse doesn't complain
3041 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3042 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3043 'tests' directory to 'client' directory. This is the new
3044 gwt-maven-plugin convension.
3045 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3046 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3048 2011-03-07 Ben Konrath <ben@bagu.org>
3050 Add support for horizontal alignment in the LayoutList columns.
3052 * TODO: Remove item about horizontal alignment. Add item about
3053 improvements to ColumnInfo.
3054 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3055 alignment on the columns. Use ColumnInfo RPC object get the column
3056 title and horizontal alignment.
3057 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3058 LayoutListView creation with ColumnInfo RPC object.
3059 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3060 a ColumnInfo object for every LayoutList columnn. Convert the
3061 FieldFormatting.HorizontalAlignment to the correct
3062 ColumnnInfo.HorizontatlAlignment with the new
3063 getColumnInfoHorizontalAlignment helper method.
3064 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3065 to encapsulate column information like alignment and title. This
3066 could be used to set the colour instead of on a per cell field basis.
3067 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3068 column title storage and retrieval with ColumnInfo.
3070 2011-03-04 Ben Konrath <ben@bagu.org>
3072 Add support for column sorting.
3074 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3075 AsynDataProvider to be an anonymous inner class. Use new
3076 getSortedTableData RPC method when column sort is requested. Set all
3077 columns sortable and add an AsyncHandler to activate sorting in the
3079 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3080 method getSortedTableData(). Cleanup other method signatures.
3081 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3082 new method getSortedTableData(). Cleanup other method signatures.
3083 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3084 Implement getSortedTableData() and getTableData() methods by using a
3085 private helper method with the appropriate parameters filled in. Use
3086 user supplied sort clause when supplied, otherwise fall back to
3087 sorting by the primary key. Move destroy() method to be underneath
3088 constructor for readability. Cleanup comments.
3090 2011-03-03 Ben Konrath <ben@bagu.org>
3092 Add support for colour text and colour backgrounds to the layout list cells.
3094 Only the cell backgrounds are coloured which leaves a gap between the
3095 cells that isn't coloured. I need to figure out a way to set
3096 'style=background-colour:' on the whole column rather than just the
3099 * TODO: Add a note about colouring the background of the whole column.
3100 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3101 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3102 render the coloured text and backgrounds. Use GlomField[] for the row type.
3103 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3105 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3106 GlomField[] for the row type.
3107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3108 GlomField[] for the row type. Set the text, text colour and background
3109 colour in the GlomField objects as specified in the glom document. Add
3110 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3111 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3112 the glom field text, foreground colour and background colour.
3114 2011-03-02 Ben Konrath <ben@bagu.org>
3116 Don't display hidden tables in the combo box.
3118 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3121 code to ignore hidden tables using ArrayLists for the table names and
3123 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3124 tableNames to use ArrayLists instead of String[]. Update getter and setter
3127 2011-03-01 Ben Konrath <ben@bagu.org>
3129 Add support for Date and Time number types.
3131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3132 Implement formatting for Date and Time values. Change the default glom
3133 file to small business example.
3135 2011-03-01 Ben Konrath <ben@bagu.org>
3137 Add support for formatting glom types as specified in the glom file.
3139 Formatting isn't finished yet - I still need to add support for Date
3142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3143 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3144 checks for null values in JDBC cleanup code and catch all exceptions
3145 instead of just SQLExceptions.
3146 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3149 2011-03-01 Ben Konrath <ben@bagu.org>
3151 Use GWT 2.2.0 instead of 2.1.1.
3153 * pom.xml: Change GWT version numbers.
3155 2011-03-01 Ben Konrath <ben@bagu.org>
3157 A few small code cleanups.
3159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3161 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3162 unnecessary object creation in constructor.
3163 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3164 unnecessary object creation in constructor.
3166 2011-02-28 Ben Konrath <ben@bagu.org>
3168 Add file for TODO list.
3172 2011-02-18 Ben Konrath <ben@bagu.org>
3174 Enable the CellTable Pager when more than 20 rows need to be viewed.
3176 The Pager will automatically become active when the results are larger
3177 than the CellTable size which is currently set to 20 lines.
3179 * src/main/java/org/glom/web/client/LayoutListView.java: Correct class
3180 name on debug statment in RPC call in LayoutListDataProvider, add
3181 numRows parameter to LayoutListView constructor, propperly set rowCount
3183 * src/main/java/org/glom/web/client/OnlineGlom.java: Correct class
3184 name on debug statment in RPC call, use LayoutListTable object in RPC
3185 calls, pass rowCount to LayoutListView.
3186 * src/main/java/org/glom/web/client/OnlineGlomService.java: Change
3187 getLayoutListHeaders to getLayoutListTable and return LayoutListTable
3189 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Update
3190 interface for changes in OnlineGlomService.
3191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3192 getLayoutListHeaders() to getLayoutListTable() and return
3193 LayoutListTable. Using this object allows me to pass other information
3194 about the LayoutList like the expected number of rows in the result set.
3195 The Connection object from the connection pool is now propperly closed.
3196 Only the requested number of lines are returned to the client in
3198 * src/main/java/org/glom/web/shared/LayoutListTable.java: Move from
3199 GlomTable and add columnTitles and numRows.
3201 2011-02-18 Ben Konrath <ben@bagu.org>
3203 Use String arrays instead of GlomTable objects in GlomDocument GWT-RPC object.
3205 This is a small performance boost. I'll use GlomTable to get the required
3206 layoutlist information.
3208 * src/main/java/org/glom/web/client/OnlineGlom.java:
3209 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3210 * src/main/java/org/glom/web/shared/GlomDocument.java:
3212 2011-02-18 Ben Konrath <ben@bagu.org>
3214 Add option to turn off formatting in JDT formatter preferences.
3216 * .settings/org.eclipse.jdt.core.prefs:
3218 2011-02-18 Ben Konrath <ben@bagu.org>
3220 Rename LayoutList to LayoutListView.
3222 I'm working towards setting things up to easily use MVP when the time
3225 * src/main/java/org/glom/web/client/LayoutListView.java: Rename from
3227 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3230 2011-02-17 Ben Konrath <ben@bagu.org>
3232 Move LayoutListDataProvider class into LayoutList.java.
3234 * src/main/java/org/glom/web/client/LayoutList.java:
3236 2011-02-17 Ben Konrath <ben@bagu.org>