1 2012-05-06 Murray Cumming <murrayc@murrayc.com>
3 Correct use of setExpectedResultSize().
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java
6 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
7 Use setExpectedResultSize only on top-level groups (for instance, the
8 list layout) or on child portals (in details views).
9 Use the correct table name for portals to avoid SQL errors.
10 Update the expected counts when returning cached layouts.
12 2012-05-06 Murray Cumming <murrayc@murrayc.com>
14 Document: Interpret no group column count as 1.
16 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
17 default, though we now check for this in the UI code anyway.
19 2012-05-06 Murray Cumming <murrayc@murrayc.com>
23 2012-05-06 Murray Cumming <murrayc@murrayc.com>
25 Translatable: Use Hashmap instead of Treemap because GWT supports it.
27 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
28 The use of Treemap lead to this error from async methods, with no
30 "The response could not be deserialized"
32 2012-05-06 Murray Cumming <murrayc@murrayc.com>
34 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
36 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
37 when using the Google -> GWT Compile, or
38 g toolbar button -> GWT Compile Project... feature in Eclipse.
40 2012-05-06 Murray Cumming <murrayc@murrayc.com>
42 ListTable.addColumn(): Protect against a null Formatting.
44 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
45 Create a default Formatting if it is null, because that is the simplest
48 2012-05-06 Murray Cumming <murrayc@murrayc.com>
50 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
52 * src/main/java/org/glom/web/server/ConfiguredDocument.java
53 updateLayoutGroup(): Check that the field is not null.
55 2012-05-06 Murray Cumming <murrayc@murrayc.com>
57 ListViewImpl: Protected against a bad cast error.
59 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
60 onEnterKeyDown(): Do not cast without an instanceof check.
62 2012-05-06 Murray Cumming <murrayc@murrayc.com>
64 ListTable: Protect against an out of range error.
66 * src/main/java/org/glom/web/client/ui/list/ListTable.java
67 createCellTable(): This is unlikely, but can happen while debugging.
69 2012-05-06 Murray Cumming <murrayc@murrayc.com>
71 AsyncMessage onFailure() callbacks: Log the exception message.
73 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
74 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
75 * src/main/java/org/glom/web/client/activity/ListActivity.java:
76 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
77 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
78 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
79 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
80 These are useful clues when something is wrong.
82 2012-05-06 Murray Cumming <murrayc@murrayc.com>
84 ConfiguredDocument: Avoid a null dereference.
86 * src/main/java/org/glom/web/server/ConfiguredDocument.java
87 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
88 details maps are created.
90 2012-05-06 Murray Cumming <murrayc@murrayc.com>
92 Document: Correct the port number parsing.
94 * src/main/java/org/glom/web/server/libglom/Document.java:
95 This lets us actually connect to the database and show the document.
97 2012-05-05 Murray Cumming <murrayc@murrayc.com>
101 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
102 user-interaction, asking us to load a temporary URL in a browser.s
103 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
104 which is apparently necessary for testing the service. See the comment.
105 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
106 Show the exception, if any. This is how I saw the 404 in the HTML in
109 2012-05-05 Murray Cumming <murrayc@murrayc.com>
111 DocumentTest: Move the .glom files into the resources directory.
113 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
114 URI via getResource().
116 2012-05-05 Murray Cumming <murrayc@murrayc.com>
118 Document: Remove the FieldIdentifies inner class.
120 * src/main/java/org/glom/web/server/libglom/Document.java: We only
121 use the Relationship (though the same function in libglom is maybe
122 used in other ways) and so this removes a compiler warning.
124 2012-05-05 Murray Cumming <murrayc@murrayc.com>
126 Document.load() Remove the error code parameter.
128 * src/main/java/org/glom/web/server/libglom/Document.java: load():
129 Remove the parameter. We do not set it yet and it could never have
130 worked as an output parameter (though maybe it did in java-libglom).
131 We could use an exception if we really want the failure reason.
132 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
134 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
135 setUp(), testGetSuitableTableToViewDetails(): Adapt.
137 2012-05-05 Murray Cumming <murrayc@murrayc.com>
139 Make some inner classes static.
141 * src/main/java/org/glom/web/server/ConfiguredDocument.java
142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
143 * src/main/java/org/glom/web/server/ReportGenerator.java
144 * src/main/java/org/glom/web/server/libglom/Document.java
145 Make all inner classes static that can be static.
147 2012-05-05 Murray Cumming <murrayc@murrayc.com>
149 OnlineGlomServiceImpl: Do not load and check for java-libglom.
151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
152 init(): We do not use java-libglom any more.
154 2012-05-05 Murray Cumming <murrayc@murrayc.com>
156 Remove mentions of java-libglom.
158 * README: Remove mention of java-libglom, because it no longer needed.
159 * utils/build-onlineglom-war.sh:
160 * utils/check-and-recover-tomcat.py:
161 * utils/install-onlineglom-war.sh: Remove these as they are no longer
162 useful. Building is now far easier, with no need for jhbuild.
164 2012-05-05 Murray Cumming <murrayc@murrayc.com>
166 Fix the build (mvn package)
168 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
169 (LayoutGroup): Make the LayoutItemList inner class static and protected.
170 Otherwise the GWT Java->Javascript compilation fails with just this
171 error, during mvn package or when attempting to view in a browser,
172 in the GWT developer mode in Eclipse.
174 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
175 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
176 [INFO] Compiling module org.glom.web.OnlineGlom
177 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
178 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
179 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
180 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
181 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
182 [INFO] [ERROR] Cannot proceed due to previous errors
184 It has taken me 2 days to find out what was causing that. After reducing
185 the code, the compiler eventually showed me the full error message.
187 2012-05-04 Murray Cumming <murrayc@murrayc.com>
189 ConfiguredDocument: Cache the cloned and stripped layouts.
191 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
192 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
193 layout in a map, so we can retrieve it again without rebuilding it.
195 2012-05-04 Murray Cumming <murrayc@murrayc.com>
197 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
199 2012-05-04 Murray Cumming <murrayc@murrayc.com>
201 libglom classes: Implement some auto-generated emthods.
203 2012-05-04 Murray Cumming <murrayc@murrayc.com>
205 Add GwtTestOnlineGlomService.
207 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
208 However, this (and the other GwtTest*) does not seem to run during
211 2012-05-04 Murray Cumming <murrayc@murrayc.com>
213 Remove use of unsupported features from client code.
215 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
216 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
217 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
218 Use our client version of StringUtils instead of the apache commons one.
220 However, the GWT Javascript compliation still fails.
222 2012-04-25 Murray Cumming <murrayc@murrayc.com>
224 Add a Field class and implement some loading of it in Document.
226 2012-04-25 Murray Cumming <murrayc@murrayc.com>
228 Initial Document loading implementation, instead of libglom.
230 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
231 and Translatable classes, and adapt the rest of the code to use them.
232 However, this is still missing Layout and Field classes and loading.
234 2012-04-24 Murray Cumming <murrayc@murrayc.com>
236 Use of jOOQ: Move Field creation into a utility method.
238 * src/main/java/org/glom/web/server/SqlUtils.java:
239 This lets us improve it more easily.
241 2012-04-24 Murray Cumming <murrayc@murrayc.com>
243 Use of jOOQ: Improve the code to COUNT a sub-select.
245 * src/main/java/org/glom/web/server/SqlUtils.java:
246 Move initial query creation into
247 build_sql_select_step_with_where_clause().
248 build_sql_select_count_rows(): Use the jOOQ API instead of
249 concatentating text, because a jOOQ Select*Step is a TableLike,
250 which is what from() takes.
252 2012-04-23 Murray Cumming <murrayc@murrayc.com>
254 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
256 * pom.xml: Depend on jooq.
257 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
258 methods with jOOQ, based on the C++ implementations in libglom,
259 with some changes to the logic required by jooQ.
260 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
262 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
263 * src/main/java/org/glom/web/server/ReportGenerator.java:
264 * src/main/java/org/glom/web/server/SqlUtils.java:
265 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
266 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
267 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
268 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
269 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
270 Adapt. In particular, the SqlUtils methods now need to take a Connection,
271 because jOOQ needs that, though it seems unnecessary.
273 This is not quite finished. Ideally jOOQ would help us to build
274 table_name.field_name names, quoting and escaping them properly.
275 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
277 2012-04-21 Murray Cumming <murrayc@murrayc.com>
279 Move use of Glom.build_sql*() into a new SqlUtils class.
281 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
282 to wrap Glom.build_sql*(). The parameter types are still Glom one,
283 but this will make it easier to start using something other than
284 libglom or SqlBuilder.
286 2012-04-21 Murray Cumming <murrayc@murrayc.com>
288 Update the project URL.
290 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
292 2012-04-21 Murray Cumming <murrayc@murrayc.com>
294 Main layout: Use a FlowTable instead of absolute positioning.
296 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
297 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
298 child panels/widgets must have an absolute position. But that is annoying, so
299 this adds a FlowTable and puts the child panels in there.
301 2012-04-21 Murray Cumming <murrayc@murrayc.com>
303 GwtTestOnlineGlom: Comment out unused code.
305 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
306 Eclipse has started to say that some code is unused.
308 2012-04-21 Murray Cumming <murrayc@murrayc.com>
310 Update to the latest versions of dependencies.
312 * pom.xml: Update version numbers of dependencies to the latest
314 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
315 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
316 * src/main/java/org/glom/web/server/ReportGenerator.java:
317 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
318 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
319 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
321 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
322 Modify the imports where necessary.
324 2012-04-17 Murray Cumming <murrayc@murrayc.com>
326 Style: Remove overflow:hidden from searchbox
328 * src/main/webapp/style.css: Because this pushes the Back To Link
329 label/link on to the next row, which is then hidden due to the
330 hard-coded (in ems) height.
332 2012-04-20 Murray Cumming <murrayc@murrayc.com>
334 Remove some duplicate code.
336 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
337 getDocumentInfo(): This must have been duplicated during the merge from the
342 2012-04-19 Murray Cumming <murrayc@murrayc.com>
344 Reports: Localize the waiting for report message.
346 * src/main/java/org/glom/web/client/activity/ReportActivity.java
347 start(): Get the message from the contants.
348 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
350 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
351 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
352 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
353 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
354 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
355 Update these files with the English text for newer strings for now.
357 2012-04-19 Murray Cumming <murrayc@murrayc.com>
359 Reports: Show a message while waiting for the report.
361 * src/main/java/org/glom/web/client/ui/ReportView.java
362 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
363 Add setWaitingText(), to show a message saying that we are
364 waiting for the report to be ready.
365 * src/main/java/org/glom/web/client/activity/ReportActivity.java
366 start(): Call setWaitingText() before calling the async
369 2012-04-19 Murray Cumming <murrayc@murrayc.com>
371 ReportGenerator: Specify date and time formats.
373 * src/main/java/org/glom/web/server/ReportGenerator.java:
374 createFieldValueElement(): Use the default (and localized)
375 short formats, though we still need a way to show 4-digit
376 years without providing the format for every locale.
377 * src/main/java/org/glom/web/server/database/DBAccess.java:
378 convertResultSetToDTO(): Use the short formats here too.
380 2012-04-18 Murray Cumming <murrayc@murrayc.com>
382 ReportGenerator: Use the correct numeric formatting.
384 * src/main/java/org/glom/web/server/ReportGenerator.java
385 createFieldExpression(), createFieldValueElement(): Take the
386 whole LayoutItem_Field instead of just the field name, so
387 we have access to the formatting.
388 createFieldValueElement(): Use JRTextField.setPattern() to
389 specify the numeric formatting, with the help of a
390 regular DecimalFormat.
392 2012-04-18 Murray Cumming <murrayc@murrayc.com>
394 ReportGenerator: Avoid showing null for group by titles.
396 * src/main/java/org/glom/web/server/ReportGenerator.java
397 generateReport(): Use setBlankWhenNull() on the field title
398 style too, because this is used for values in group by
401 2012-04-18 Murray Cumming <murrayc@murrayc.com>
403 ReportGenerator: Add a colon to titles in vertical groups.
405 * src/main/java/org/glom/web/server/ReportGenerator.java
406 addFieldToDetailBandVertical(): Pass true for the withColon
409 2012-04-18 Murray Cumming <murrayc@murrayc.com>
411 ReportGenerator: Simplify the code by using Position more.
413 2012-04-18 Murray Cumming <murrayc@murrayc.com>
415 Reports: Support vertical groups, roughly.
417 * src/main/java/org/glom/web/server/ReportGenerator.java:
418 addToReport(): Rename to addGroupToReport() and, if necessary,
419 call the new addVerticalGroupToReport() method.
420 createFieldValueElement(): Let the caller specify the Y position
423 2012-04-17 Murray Cumming <murrayc@murrayc.com>
425 Reports: Allow a second report to be shown.
427 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
428 clear(): Do not remove the HTML widget, which broke the whole layout.
430 2012-04-17 Murray Cumming <murrayc@murrayc.com>
432 Locales drop-down: Show that we use English by default.
434 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
435 fillView(): When we use English, just because that is the default, when
436 no locale is specified, show that in the Locales drop-down instead of
437 just showing the first item.
439 2012-04-17 Murray Cumming <murrayc@murrayc.com>
441 Unselect the Report/Locale/Table combo item when appropriate.
443 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
444 setPlace(): clear reportName if this is not a ReportPlace.
445 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
446 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
447 When the provided name is empty, unselect all items, so that none are
448 indicated. This uses a for loop because I cannot find a single method
451 2012-04-17 Murray Cumming <murrayc@murrayc.com>
453 Report: Give the user a way to get back to the list.
455 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
456 start(), setPlace(): Show the Back To List link on reports, and also
457 interpret selecting the empty report item as back to list.
459 2012-04-13 Murray Cumming <murrayc@murrayc.com>
461 Really show the selected Report name.
463 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
464 setPlace(): Store the reportName here, if it is that kind of Place.
465 fillView(): Set the selected Report after filling the list of reports.
466 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
467 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
468 null Strings, though we need some way to unselect all ListBox items
471 2012-04-13 Murray Cumming <murrayc@murrayc.com>
473 ReportGenerator: Try to avoid some problems.
475 * src/main/java/org/glom/web/server/ReportGenerator.java
476 addField(): Try to avoid duplicates, and avoid using a null
479 2012-04-13 Murray Cumming <murrayc@murrayc.com>
481 Reports: Use quickFind.
483 * src/main/java/org/glom/web/client/OnlineGlomService.java;
484 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
486 getReportHTML(): Add a quickFind parameter.
487 * src/main/java/org/glom/web/client/activity/ReportActivity.java
488 start(): Pass the quickFind parameter.
489 * src/main/java/org/glom/web/server/ReportGenerator.java
490 generateReport(): Take a quickFind parameter.
492 2012-04-13 Murray Cumming <murrayc@murrayc.com>
494 ReportPlace: Actually use the report name.
496 * src/main/java/org/glom/web/client/place/ReportPlace.java
497 getPlace(): Do not assign the report name to the quickfind.
499 2012-04-13 Murray Cumming <murrayc@murrayc.com>
501 Show java.library.path when complaining.
503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
504 init(): When telling us to check java.library.path, show the
507 2012-03-06 Murray Cumming <murrayc@murrayc.com>
509 ReportGenerator: Do not show nulls.
511 2012-03-06 Murray Cumming <murrayc@murrayc.com>
513 ReportGenerator: Make the title font larger.
515 2012-03-06 Murray Cumming <murrayc@murrayc.com>
517 ReportGenerator: Put field titles inside groups, if there are groups.
519 2012-03-06 Murray Cumming <murrayc@murrayc.com>
521 ReportGenerator: Take the Report itself instead of the name and group.
523 * src/main/java/org/glom/web/server/ConfiguredDocument.java
524 Remove getReportLayoutGroup().
525 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
526 getReportHTML(): Pass the report instead
527 of its name and layout group.
528 * src/main/java/org/glom/web/server/ReportGenerator.java
529 generateReport(): Use the report object to use the title
532 2012-03-06 Murray Cumming <murrayc@murrayc.com>
534 ReportGenerator: Remove designBand parameters.
536 * src/main/java/org/glom/web/server/ReportGenerator.java:
537 Make designBand a class member instead of passing it to all
540 2012-03-06 Murray Cumming <murrayc@murrayc.com>
542 ReportGenerator: Add lines, a bit like in the desktop version.
544 * src/main/java/org/glom/web/server/ReportGenerator.java
545 addToReport(): Use JRDesignLine.
547 2012-03-06 Murray Cumming <murrayc@murrayc.com>
549 ReportGenerator: Correct the title positions and use some bold style.
551 * src/main/java/org/glom/web/server/ReportGenerator.java:
552 Break the code up into reusable functions, correct the placement of
553 titles, and use normal/bold styles as in the reports in the desktop
556 2012-03-06 Murray Cumming <murrayc@murrayc.com>
558 ReportGenerator: Add a header band to show the field titles.
560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
561 getReportHTML(): Pass the localeId to the ReportGenerator
563 * src/main/java/org/glom/web/server/ReportGenerator.java
564 constructor: Take the localeID so we can get translated field
566 generateReport(), addToReport(), addFieldToBand(): Add field
567 titles in a column header band.
569 2012-03-05 Murray Cumming <murrayc@murrayc.com>
571 Reports drop-down list: Some improvement.
573 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
574 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
575 Adedd setSelectedReport(),
576 setReportList(): Add a blank line so that the user can select the
578 * src/main/java/org/glom/web/client/activity/ReportActivity.java
579 start(): Show the current report by calling setSelectedReport().
580 This does not seem to work yet.
582 2012-03-05 Murray Cumming <murrayc@murrayc.com>
584 DetailsActivity, ListActivity: Move some variables into a base class.
586 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
587 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
588 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
589 the clientFactory, documentID, tableName and authenticationPopup into
590 a base class, to avoid duplication.
592 2012-03-05 Murray Cumming <murrayc@murrayc.com>
594 Translate the Reports label.
596 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
597 Get the "Reports" label string from the constants.
598 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
599 perties: Add Reports to the constants.
601 2012-03-05 Murray Cumming <murrayc@murrayc.com>
603 Reports: Implement grouping.
605 * src/main/java/org/glom/web/server/ReportGenerator.java:
606 Handle LayoutItem_GroupBy items and try to do the right thing
607 with JRDesignGroup. It seems to work.
609 2012-03-04 Murray Cumming <murrayc@murrayc.com>
611 Actually show some data with JasperReports.
613 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
614 getReportHTML(): Move most code into a ReportGenerator class.
615 * src/main/java/org/glom/web/server/ReportGenerator.java:
616 Recurse into sub-groups, adding fields to the JasperDesign's details
617 band. Note that we must set an arbitrary width and height, or it just
618 will not show any data.
620 2012-03-04 Murray Cumming <murrayc@murrayc.com>
622 Reports Chooser: Show the titles, not the names.
624 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
625 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
626 and the names as the values.
627 * src/main/java/org/glom/web/server/ConfiguredDocument.java
628 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
629 group now that we provide the report name, so it should always
632 2012-02-15 Murray Cumming <murrayc@murrayc.com>
634 Depend on jasperreports.
636 * pom.xml: Add the dependency. My plan is to use this on the
639 2012-01-31 Murray Cumming <murrayc@murrayc.com>
641 Implement navigation to report places.
643 * src/main/java/org/glom/web/client/activity/ReportActivity.java
644 start(): Do not bother to handle all events here.
645 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
646 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
647 Added getSelectedReport().
648 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
649 .java: start(): When handling a change to the reports chooser,
650 call getSelectedReport() and goTo() its ReportPlace.
651 * src/main/java/org/glom/web/client/ui/ReportView.java
652 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
653 Added setReportHTML() which puts the html in a gwt HTML widget.
654 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
655 getReportHTML(): Return "TODO" just to show that this works.
657 2012-01-31 Murray Cumming <murrayc@murrayc.com>
659 Make ReportPlace usable.
661 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
663 * src/main/java/org/glom/web/client/place/ReportPlace.java:
664 Correct the @prefix annotation.
666 2012-01-31 Murray Cumming <murrayc@murrayc.com>
668 OnlineGlomService: Return report HTML rather than the LayoutGroup.
670 * src/main/java/org/glom/web/client/OnlineGlomService.java:
671 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
672 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
673 Change getReportLayout() to getReportHMTL() because we will not need to
674 parse or render the report layout on the client side.
675 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
676 getReportLayout(): Return the libglom LayoutGroup type because we will
677 not need to convert to a shared type, because this will not be used on
679 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
682 Note that there is still no implementation for this.
685 2012-01-27 Murray Cumming <murrayc@murrayc.com>
687 Add a (empty) Report Place, View, and Activity.
689 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
691 * src/main/java/org/glom/web/client/place/HasTablePlace.java
692 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
693 this into a superclass:
694 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
695 and also use it as the base of this new ReportPlace:
696 * src/main/java/org/glom/web/client/place/ReportPlace.java
698 * src/main/java/org/glom/web/client/ui/ReportView.java
699 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
700 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
701 Add these, containing mostly boiler-plate for now.
703 * src/main/java/org/glom/web/client/OnlineGlomService.java
704 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
705 * src/main/java/org/glom/web/server/ConfiguredDocument.java
706 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
707 Add API to get the LayoutGroup for the report.
709 2012-01-23 Murray Cumming <murrayc@murrayc.com>
711 Add and fill a Reports drop-down list box.
713 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
715 * src/main/java/org/glom/web/client/OnlineGlomService.java:
716 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
717 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
718 Added getReports(document, table, localeID), calling
719 ConfiguredDocument.getReports().
720 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
721 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
722 Added setReportsList() and a list widget.
723 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
724 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
729 2012-04-12 Murray Cumming <murrayc@murrayc.com>
731 Translations: Add Esperanto.
733 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
734 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
735 properties: Add this translation because someone took the time to make it.
737 2012-03-15 Murray Cumming <murrayc@murrayc.com>
739 Adapt to the java-libglom 1.21.7 API.
741 * src/main/java/org/glom/web/server/ReportGenerator.java:
742 addToReport(): get_group_secondary_fields() is now
743 get_secondary_fields().
746 2012-03-15 Murray Cumming <murrayc@murrayc.com>
748 Use the latest java-libglom version.
750 * pom.xml: Use java-libglom 1.21.7.
752 2012-03-03 Ben Konrath <ben@bagu.org>
754 Display date and time in details view.
756 https://bugzilla.gnome.org/show_bug.cgi?id=671257
758 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
760 2012-03-05 Murray Cumming <murrayc@murrayc.com>
762 Require the latest java-libglom.
764 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
766 2012-03-04 Murray Cumming <murrayc@murrayc.com>
768 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
770 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
771 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
772 an empty quickfind string. I also corrected libglom to create only
773 empty where clauses for empty quickfind strings, but this avoids the
776 2012-02-24 Ben Konrath <ben@bagu.org>
778 Improve the tabs in the Notebook widget.
782 2012-01-30 Murray Cumming <murrayc@murrayc.com>
784 Translations: Try to translate the strings.
786 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
787 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
788 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
789 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
790 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
791 Take the Open translation from GTK+'s .po files.
792 Take the Details translation from Glom's po files.
793 I have added the other strings to Glom so we can get translations that way:
794 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
796 2012-01-27 Murray Cumming <murrayc@murrayc.com>
798 TableSelectionViewImpl: Put the search label and entry in a div.
800 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
801 Put the search widgets in a FlowTable so that the CSS can be used to
802 style them while keeping them together.
803 * src/main/webapp/style.css: Mention the new div.
805 2012-01-27 Murray Cumming <murrayc@murrayc.com>
807 Translate more strings in more locales.
809 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
810 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
811 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
812 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
813 Translate the "Details" and "Open" string too.
815 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
816 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
817 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
818 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
819 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
820 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
821 Add these new locales as placeholders though they currently contain English.
823 2012-01-27 Murray Cumming <murrayc@murrayc.com>
825 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
827 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
828 Check the ConfiguredDocument* for null before using it.
830 2012-01-26 Murray Cumming <murrayc@murrayc.com>
832 Tell Eclipse about the generated java files.
834 * .classpath: This lets it find OnlineGlomConstants.java.
835 It would be nice if Eclipse just used the maven build files.
837 2012-01-26 Murray Cumming <murrayc@murrayc.com>
839 Prevent a crash when no locale is specified in the URL.
841 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
842 Avoid returning a null string, obtained from
843 Window.Location.getParameter(). This caused a crash when it was
844 later passed to libglom's API.
845 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
846 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
847 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
848 guard against future null strings.
850 2012-01-26 Murray Cumming <murrayc@murrayc.com>
852 Use the ?locale= query param instead of the &lang= token param.
854 * src/main/java/org/glom/web/client/place/ListPlace.java
855 * src/main/java/org/glom/web/client/place/DetailsPlace.java
856 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
857 Remove the lang token key and value.
859 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
860 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
861 When the user selects a different locale from the chooser, use
862 Window.Location.assign() to change the URL, which then causes a reload.
864 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
865 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
866 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
867 * src/main/java/org/glom/web/client/activity/ListActivity.java
868 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
869 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
870 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
871 * src/main/java/org/glom/web/client/ui/ListView.java:
872 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
874 Remove localeID member variables and method/constructor parameters, instead
875 using Utils.getCurrentLocaleID() when we need a localID to pass to
878 2012-01-26 Murray Cumming <murrayc@murrayc.com>
880 Internationalize the UI strings.
882 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
883 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
884 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
885 because it is unused. Messages are apparently strings that can have
886 parameters, but we do not need that yet, so Contants will be enough for now.
887 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
888 to say that we support the en and de locales.
889 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
890 The original English strings.
891 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
892 Some German translations of the English strings.
893 The i18n goal then uses the .properties file to generate an
894 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
895 returns an implementation that returns the translated strings.
896 The documentation suggests putting these in src/java/*/client/, but it seems
897 best to put it in src/resources/*/client/.
898 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
899 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
900 instead of hard-coding them.
901 Note that we cannot import OnlineGlomConstants because it does not exist yet,
902 but that does not seem to stop the build, though it confuses Eclipse.
904 You can see the translated string by adding ?locale=de to the URL, like so:
905 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
907 2012-01-24 Murray Cumming <murrayc@murrayc.com>
909 Improve null/empty String checks.
911 * pom.xml: Add a dependency on commons-lang, to use
912 org.apache.commons.lang.StringUtils.
913 * src/main/java/org/glom/web/server/ConfiguredDocument.java
914 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
915 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
916 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
917 Use StringUtils.isEmpty().
919 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
920 StringUtils class with a static isEmpty() function because we
921 cannot use org.apache.commons.lang.StringUtils in client-side
922 GWT code because it (apparently) cannot be compiled to javascript.
923 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
924 * src/main/java/org/glom/web/client/activity/ListActivity.java
925 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
926 * src/main/java/org/glom/web/client/place/DetailsPlace.java
927 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
928 * src/main/java/org/glom/web/client/place/ListPlace.java
929 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
930 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
931 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
932 * src/main/java/org/glom/web/client/ui/details/Group.java
933 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
934 our StringUtils.isEmpty() function.
936 2012-01-24 Murray Cumming <murrayc@murrayc.com>
938 Update to the latest java-libglom API.
940 * pom.xml: Require java-libglom 1.21.4.
941 * src/main/java/org/glom/web/server/ConfiguredDocument.java
942 getDocumentInfo(), getListViewLayoutGroup():
943 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
945 * src/main/java/org/glom/web/server/database/DBAccess.java
946 getFieldsToShowForSQLQueryAddGroup(),
947 getPrimaryKeyLayoutItemField(): Replace get_database_title()
948 with either get_database_title_original() or
949 get_database_title(localeID).
951 2012-01-24 Murray Cumming <murrayc@murrayc.com>
953 ConfiguredDocument: Avoid a null pointer exception.
955 * src/main/java/org/glom/web/server/ConfiguredDocument.java
956 Initialize localeID to "" to avoid returning a null String which
957 causes a crash in java-libglom's swing-generated code.
959 2012-01-23 Murray Cumming <murrayc@murrayc.com>
961 Some simple renaming.
963 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
964 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
965 for localeChooser. This seems more appropriate and is less ambiguous
966 particularly in the .css file.
968 2012-01-23 Murray Cumming <murrayc@murrayc.com>
970 ConfiguredDocument: Rename the localedID private member variable.
972 2012-01-23 Murray Cumming <murrayc@murrayc.com>
974 Adapt to the latest java-libglom API from git master.
976 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
977 libglom now uses only Vector instead of List, which uses add() instead of
980 2012-01-22 Murray Cumming <murrayc@murrayc.com>
982 ConfiguredDocument: Rename the localedID private member variable.
984 2012-01-20 Murray Cumming <murrayc@murrayc.com>
986 Build a source tarball with mvn assembly:single
988 * assembly.xml: Add this file.
989 * pom.xml: Use the maven-assembly-plugin and tell it to use
990 our assembly.xml file.
992 2012-01-19 Murray Cumming <murrayc@murrayc.com>
994 OnlineGlomServiceImpl: Get .glom files recursively.
996 * pom.xml: Depend on commons-io from org.apache.commons.
997 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
998 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
999 files recursively, and with the easier filter for the extension.
1000 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1001 simplify that code too.
1003 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1005 README: Mention that you must install java-libglom packages separately.
1007 But then it works, because java-libglom is now in the central maven
1010 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1012 locales drop-down: Show the correct selected locale when the URL changes.
1014 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1015 .java: setPlace(): Move some code into fillView().
1017 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1019 locales drop-down: Do not lose the primary key.
1021 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1022 start(): onLocaleChange(): Pass the current primary key value,
1023 instead of an empty value.
1025 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1027 locales drop-down: Do not lose the drop-down selection.
1029 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1030 .java (TableSelectionActivity.fillView): Set the selected locale
1031 after changing the drop-down items (though we do not really need
1032 to change them just because the locale changes.)
1034 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1036 locales drop-down: Change the tables list when this changes.
1038 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1039 .java: TableSelectionActivity.start(): Move the async table titles
1040 retrieval into a private fillView() method and also call this when
1041 the chosen locale changes.
1042 Note that the document title is not actually translatable yet, but
1043 that is a problem that I should fix soon in libglom.
1045 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1047 Improve the placement of the locales drop-down.
1049 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1050 Put the title and locales drop-down in a div (gwt.FlowTable).
1051 * src/main/webapp/style.css: Add magic css properties to make this work.
1052 Also remove the left margin from the title so that it lines up with the
1055 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1057 locales selector: Show human-readable locale titles.
1059 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1060 getDocumentInfo(): Use java.util.Locale to show a real title of
1061 each locale, in the locale's own language.
1063 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1065 Add a language/locale selector drop-down.
1067 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1068 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1069 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1070 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1071 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1072 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1073 Add a ListBox to show the available locales. Add getLocaleSelector(),
1074 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1075 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1076 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1077 java: Add these classes.
1078 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1079 start(): Fill the locales ListBox. Handle its change event, firing a
1081 setPlace(): Show the selected locale as specified by the URL token.
1082 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1083 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1084 Handle LocaleChangeEvent, going to a new *Place with that locale.
1086 The placement of the ListBox is not pretty, and it currently uses the ID
1087 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1091 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1093 Search box: Show the search text from the URL token.
1095 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1096 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1097 Add setQuickFindText().
1098 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1099 .java: setPlace(): Store the queryText if the place is a ListPlace,
1100 and call TableSelectionView.setQuickFindText().
1102 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1104 Allow use of translations via, for instance, &lang=de in the URL.
1106 * pom.xml: Use the unstable java-libglom 1.21 version.
1108 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1109 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1111 init(): Instead of calling TranslatableItem.set_current_locale()
1112 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1113 However, this is only for default locales, which are not needed to
1114 change the locale in the URL.
1115 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1116 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1117 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1118 layout for a particular locale.
1119 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1120 Add get/setDefaultLocaleID().
1121 getDocumentInfo(), getListViewData(), getRelatedListData(),
1122 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1123 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1124 localeID parameter, so we can get the layout for a particular locale.
1126 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1127 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1128 * src/main/java/org/glom/web/client/place/ListPlace.java:
1129 Parse and construct a lang parameter too.
1131 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1132 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1133 passed to subsequent methods and constructors.
1134 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1135 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1136 Store the localeID from the *Place and pass it to other constructors
1137 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1139 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1140 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1141 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1142 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1143 * src/main/java/org/glom/web/client/ui/ListView.java:
1144 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1145 Take localeID parameters and pass them to subsequent constructors and
1146 methods, so that the layout is always retrieved for that locale.
1148 This is rather repetitive.
1150 Note that "" means the original (default) locale of the Glom document,
1151 which is usually English.
1153 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1155 Documents: Remove final keyword to fix startup configuration.
1157 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1158 final keywords on the private member variables because that breaks
1159 the startup, apparently (there are warnings) because it stops them
1160 from being serialized. I added these in the previous commit.
1162 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1164 Documents: Add some final keywords.
1166 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1169 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1171 OnlineGlomServiceImpl: Add to overview comments.
1173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1174 Note that this is where all the document are loaded. They are not
1175 loaded freshly for each page.
1177 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1181 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1182 Add a TextBox for the text of a quick find.
1183 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1185 setBackLink(): Add a String quickFind parameter.
1186 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1187 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1188 to the base interface, because that is how TableSelectionViewImpl is used.
1189 * src/main/webapp/style.css: Add style for the search box and its label.
1191 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1192 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1193 Add these files, based on the existing TableChangeEvent and
1194 TableChangeEventHandlers.
1195 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1196 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1197 a ListPlace() that the user should be taken to.
1198 * src/main/java/org/glom/web/client/activity/ListActivity.java
1199 start(): Handle it here too and adapt the TableChangeEvent handler to
1200 pass the extra "" quickFind parameter to ListPlace.
1201 * src/main/java/org/glom/web/client/place/ListPlace.java:
1202 Constructor: Take an extra String quickFind parameter and store it,
1203 returning it from a new getQuickFind() method.
1204 getToken(): Put the quickFind text in the URL token.
1205 getPlace(): Parse the quickFind text from the URL token.
1206 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1207 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1208 ListPlace constructor.
1209 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1210 .java: start(): Add a Change handler for the TableSelectionView's
1211 TextBox (via its base HasChangeHandlers interface), firing the new
1212 QuickFindChangeEvent.
1213 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1214 pass the extra "" quickFind parameter.
1216 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1217 setCellTable(): Add a String quickFind parameter and pass it to
1218 the ListViewTable() constructor.
1219 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1220 setCellTable() in the base interface, because that is how ListViewImpl
1223 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1224 Add a String quickFind member variable.
1225 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1226 Constructor: Add a String quickFind parameter, storing it in the
1227 base ListTable's member variable.
1228 onRangeChanged(): Pass quickFind to the
1229 OnlineGlomServiceAsync.getSortedListViewData() and
1230 OnlineGlomServiceAsync.getListViewData() methods.
1232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1233 getListViewData(), getSortedListViewData(): Add a String quickFind
1234 parameter, passing it to ConfiguredDocument.getListViewData().
1235 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1236 Change getListViewData(), getSortedListViewData() in the base interface,
1237 because that is how OnlineGlomServiceImpl is used, via this:
1238 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1239 Change getListViewData(), getSortedListViewData() here too.
1240 This class can apparently be used to asynchronously call methods on
1241 OnlineGlomService, and GWT seems to implement that after recognizing
1242 just the *Async name convention and the extra AsyncCallback parameters.
1244 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1245 getListViewData(): Add a String quickFind parameter, and pass it to
1246 ListViewDBAccess.getData().
1247 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1248 getListData(): Add a String quickFind parameter and pass it to
1250 getSelectQuery(): Add a String quickFind parameter.
1251 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1252 getSelectQuery(): Add a String quickFind parameter and use it with
1253 Glom.get_find_where_clause_quick() to pass a where_clause to
1254 Glom.build_sql_select_with_where_clause(), to actually filter the
1256 getData(): Add a String quickFind parameter, passing it to getListData().
1257 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1258 va: getData(): Pass an empty string to getListData() for the
1259 quickFind parameter.
1261 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1263 ListTable: Minor change.
1265 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1266 createCellTable(): Make this protected instead of public.
1268 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1270 Many files: Use final for the parameters and use the @override attribute.
1272 2012-01-22 Ben Konrath <ben@bagu.org>
1274 Add anchor links for single line text that starts with http, ftp and www.
1278 2012-01-22 Ben Konrath <ben@bagu.org>
1280 Add ellipsis to single line text in details view.
1284 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1286 Remove all javadoc author tags.
1288 Because they are awkward and meaningless when many people touch
1290 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1292 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1294 Revert the COPYING.LESSER to COPYING rename.
1296 Apparently both should be there if it is LGPL.
1298 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1300 *View: Remove unused imports.
1302 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1303 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1304 * src/main/java/org/glom/web/client/ui/ListView.java:
1305 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1306 Remove unused imports, as suggested by Eclipse.
1308 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1310 Move the *View::Presenter types, and some API into one base View.
1312 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1313 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1314 * src/main/java/org/glom/web/client/ui/ListView.java:
1315 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1316 Presenter, setPresenter() and clear() into a shared base interface,
1317 to avoid the unnecessary duplicate Presenter types and to more clearly
1318 show how the *Views share the same structure, even if they are not
1319 used polymorphically.
1321 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1322 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1324 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1325 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1326 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1328 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1331 Feel free to revert this if there is a good reason for the duplicate
1334 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1336 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1338 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1339 a class member instead of a local variable in the method.
1340 This lets us use it to get the view instances, for use in tests.
1341 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1342 beforeOnlineGlom(): Test some more details of the initial view.
1343 Again, this is not very useful.
1345 To really test gwt-glom we will need to start a local postgresql
1346 instance with local data, like the Glom tests in C++.
1348 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1350 pom.xml: Mention the LGPL license.
1352 * pom.xml: Add a licenses section.
1353 * COPYING.LESSER: Move this to COPYING, which
1354 previously contained the GPL. But gwt-glom is all LGPL.
1356 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1358 Add project information to README and pom.xml.
1360 * README: Add a brief description and mention some mvn
1362 * pom.xml: This extra information shows up in mvn site
1365 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1367 Use the latest java-libglom version.
1369 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1371 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1373 GwtTestOnlineGlom: Test a little more.
1375 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1376 protected rather than private, as suggested by the gwt-test-utils
1378 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1379 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1380 Test the initial visibility of the panels.
1382 However, this is not a very useful test.
1383 And I wonder how we should generally test using this idea for an
1384 activity/places app like ours where the real changes happen implicitly
1385 based on the history token/URL.
1387 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1389 Slight modification to *Mapper comments.
1391 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1392 (DataActivityMapper)
1393 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1395 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1397 Remove comments mentioning GIN because they are just copied from
1398 the example code and are apparently not helpful:
1399 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1400 Also change the mention of a class that is only in the example code.
1402 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1404 GwtTestOnlineGlom test: Minor changes.
1406 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1407 Avoid the long qualified class name and modify the comment
1408 because it is now obvious to me that the mocked class is the only
1409 custom one created via GWT.create().
1411 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1413 Tests: Added the beginnings of a test using gwt-test-utils.
1415 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1416 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1417 which tells gwt-test-utils what class will be tested.
1418 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1419 Add a simple (but empty) test case. One class, used by the OnlineGlom
1420 class, is mocked so that it can be created. However, I am not sure
1421 why only this class needs to be mocked.
1423 Note that mockito seems more popular, and clearer, than easymock,
1424 but I have not got that working yet. It might be a matter of the
1427 This test is run during mvn integration-test.
1429 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1431 Tests: Use junit4-style syntax instead of junit3-style.
1433 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1434 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1435 * src/test/java/org/glom/web/shared/DataItemTest.java:
1436 Use the @Test annotation rather than relying on the test*() prefix.
1437 Also no longer implement TestCase, to avoid triggering support for
1438 the junit3-way, which stops the annotations from working.
1439 Change the imports from import junit.framework.* to
1440 import org.junit.*, which is apparently the new way.
1442 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1444 Added a test for ListPlace token parsing and creation.
1446 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1447 This is much the same as DetailsPlaceTest.
1449 I wonder how we could test the other parts of the *Place API.
1451 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1453 DetailsPlace test: Also test getToken() and recreation via getPlace().
1455 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1456 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1457 recreate it, testing the recreated DetailsPlace for the same parameter
1460 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1462 Use the surefire-report plugin.
1464 * pom.xml: This generates a HTML report about the tests in
1465 target/site/surefire-report.html
1466 when you do mvn surefire-report:report. It seems to be popular/normal.
1468 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1470 Added a test for DetailsPlace.
1472 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1473 Test the getPlace() token parsing.
1475 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1477 Added a first unit test.
1479 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1480 * src/test/java/org/glom/web/shared/DataItemTest.java:
1481 This is a silly test but it is just to get things started. Note that
1482 maven/junit finds the test because it looks in src/test by default.
1484 2011-12-22 Ben Konrath <ben@bagu.org>
1486 Change charsetName to "UTF-8" when replacing line breaks.
1488 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1489 that work in Java (such as "UTF8") will not work when compiled to
1492 This fixes a problem with multi-line details view fields that have hard
1493 line breaks. The "License Text" field on this page demonstrates the
1496 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1498 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1500 2011-12-22 Ben Konrath <ben@bagu.org>
1502 Fix another bug with related list navigation.
1504 I've tested all the navigation buttons in all of the related lists
1505 so things should be good now.
1507 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1509 2011-12-22 Ben Konrath <ben@bagu.org>
1511 Fix a crasher when refreshing the list view with the default table.
1513 This crash will also happen when loading the list view with the default
1514 table from a link or bookmark.
1516 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1517 to the main document selection page when the document id hasn't been
1519 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1520 the main document selection page when the document id hasn't been
1522 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1523 values for the details place when the document id hasn't been set.
1524 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1525 values for the list place when the document id hasn't been set.
1527 2011-12-21 Ben Konrath <ben@bagu.org>
1529 Protect against NPE when glom.document.locale is not in config.
1531 This patch protects against an NPE when glom.document.locale is not in
1532 the config file. This NPE will also happen if glom.document.locale is
1535 The patch also updates the error message to display the class name when
1536 the getMessage() returns null. This was happening when the NPE was
1537 thrown and I had "Configuration Error: null". If an NPE is encountered
1538 with this patch, "Configuration Error: NullPointerException " will be
1541 This commit closes this bug:
1543 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1545 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1547 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1549 Rename onlineglom.properties to onlineglom.properties.sample.
1551 * src/main/resources/onlineglom.properties: Rename to:
1552 * src/main/resources/onlineglom.properties.sample:
1553 * src/main/resources/README: And add this file explaining that people
1554 should rename it back when deploying.
1556 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1558 Allow choosing the translation in the .properties file.
1560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1561 init(): Read a glom.document.locale value from the configuration file
1562 and call Glom's TransatableItem::set_current_locale() method.
1563 * src/main/resources/onlineglom.properties: Add a commented-out
1564 example of this new setting.
1566 It would be better to add &lang=de_DE to the URL, but the current
1567 libglom API does not allow us to do this easily. I am working on that.
1569 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1571 Avoid a crash in parsing of token parameters.
1573 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1574 ava: getTokenParams(): Do not crash if a parameter has a key but no
1575 value, and ignore parameters with neither.
1577 2011-12-17 Murray Cumming <murrayc@murayc.com>
1579 History token building/handling: Improve use of token parameters.
1581 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1582 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1583 and buildParamsToken(HashMap), for use by derived classes.
1584 Make the separator private because it is no longer be needed.
1585 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1586 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1587 instead of manual string concatenation.
1588 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1589 of hardcoded indices and awkward splitting code.
1590 * src/main/java/org/glom/web/client/place/ListPlace.java
1591 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1592 instead of manual string concatenation.
1593 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1594 of hardcoded indices and awkward splitting code.
1595 This should fix bug #666420
1597 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1599 Fix a Navgiation->Navigation typo in the code.
1601 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1602 Rename processNavgiation() to processNavigation().
1604 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1606 Fix a seperator->separator typo in the code.
1608 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1609 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1610 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1613 2011-12-15 Ben Konrath <ben@bagu.org>
1615 Cleanup some comments.
1617 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1619 2011-12-14 Ben Konrath <ben@bagu.org>
1621 Replace \n with <br/> for multiline text in the details view.
1623 Vertical scrollbars are added when needed as well.
1625 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1627 2011-12-14 Ben Konrath <ben@bagu.org>
1629 Specify the font for document selection links.
1631 * src/main/webapp/style.css:
1633 2011-12-14 Ben Konrath <ben@bagu.org>
1635 Fix bouncy CellTable while paging.
1637 This doesn't currently work with related list tables in unselected
1640 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1642 2011-12-14 Ben Konrath <ben@bagu.org>
1644 Revamp the appearance of the document selection page.
1646 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1647 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1648 * src/main/webapp/style.css:
1650 2011-12-13 Ben Konrath <ben@bagu.org>
1652 Set navigation button column to the smallest size possible.
1654 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1656 2011-12-13 Ben Konrath <ben@bagu.org>
1658 Change OpenButton nomenclature to NavigationButton.
1660 Using NavigtionButton makes things more generic. Classes, methods and
1661 variables have been changed.
1663 This is a rename-only refactor.
1665 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1666 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1667 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1668 Renamed from OpenButtonCell.
1669 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1670 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1671 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1673 2011-12-12 Ben Konrath <ben@bagu.org>
1675 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1677 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1678 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1679 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1680 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1682 2011-12-12 Ben Konrath <ben@bagu.org>
1684 Update variable names and comments.
1686 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1687 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1689 2011-12-12 Ben Konrath <ben@bagu.org>
1691 Properly initialize numNonEmptyRows variable to zero.
1693 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1694 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1696 2011-12-05 Ben Konrath <ben@bagu.org>
1698 Add latest mockup with HTML tables.
1700 Features of this mockup:
1702 -> HTML table for flowtable
1703 -> HTML table for flowtable column
1704 -> Example of how related lists would look
1705 -> Not using text entries for data items
1707 The current version of Online Glom doesn't use HTML tables for the
1710 This mockup has been sent to the glom-devel mailing list but it's good
1711 to have it here as well.
1713 * mockups/details-view-html-tables.html:
1715 2011-12-05 Ben Konrath <ben@bagu.org>
1717 Remove unnecessary getPrimaryKeyField() method.
1719 getPrimaryKeyFieldForTable(String) has been renamed to
1720 getPrimaryKeyField(String).
1722 * src/main/java/org/glom/web/server/database/DBAccess.java:
1723 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1724 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1726 2011-12-05 Ben Konrath <ben@bagu.org>
1728 Add string representation of TypedDataItem value to conversion error message.
1730 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1731 message was extracted into its own method to avoid duplication.
1733 2011-12-05 Ben Konrath <ben@bagu.org>
1735 Add type checking to navigation primary key value creation.
1737 Create navigation primary key only if the expected type from the Glom
1738 document matches the type returned by the SQL query.
1740 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1742 2011-12-05 Ben Konrath <ben@bagu.org>
1744 Rename a couple of variables in RelatedListNavigation.
1746 This is a rename-only refactor.
1748 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1750 2011-12-05 Ben Konrath <ben@bagu.org>
1752 Move getListLayoutGroup() into getListViewLayoutGroup().
1754 This removes getListLayoutGroup(). It was only being called by
1755 getListViewLayoutGroup().
1757 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1759 2011-12-05 Ben Konrath <ben@bagu.org>
1761 Remove check for LayoutItem_Portal in list table method.
1763 This check is no longer necessary because the method isn't being used
1764 to create the LayoutItemPortal DTO.
1766 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1768 2011-12-05 Ben Konrath <ben@bagu.org>
1770 Properly support related list navigation.
1772 Navigation from the "Repository Analyzer -> Package Scans ->
1773 Dependencies" related table wasn't working because the primary key for
1774 related tables wasn't being set properly. This commit fixes the
1777 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1778 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1779 doesn't set the primary key properly for related list tables.
1780 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1781 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1782 useful for getting the primary key for list view tables and for related
1784 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1785 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1786 Move code to set the primary key for the table from the abstract
1787 ListDBAccess class to ListViewDBAccess as it's only correct for list
1789 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1790 Properly add primary key to related list tables.
1792 2011-12-02 Ben Konrath <ben@bagu.org>
1794 Properly set the horizontal alignment of fields.
1796 This fix is for both the list tables and the details view.
1798 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1799 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1800 to set the horizontal alignment of fields.
1802 2011-12-02 Ben Konrath <ben@bagu.org>
1804 Display currency codes in the details view.
1806 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1808 2011-12-02 Ben Konrath <ben@bagu.org>
1810 Avoid duplicate JNI call.
1812 JNI is not as efficient as pure Java and this is an easy (and small)
1815 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1816 Use previously retrieved value for whereClauseToTableName instead of
1819 2011-12-02 Ben Konrath <ben@bagu.org>
1821 Rename a couple of variables in RelatedListNavigation.
1823 This is a rename-only refactor.
1825 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1827 2011-12-02 Ben Konrath <ben@bagu.org>
1829 Indicate clearly that a mismatched primary key type is a bug.
1831 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1832 warning to error. Add 'This is a bug.' to message.
1834 2011-12-02 Ben Konrath <ben@bagu.org>
1836 Update / fix some comments.
1838 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1840 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1842 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1843 Fix comments. Add some TODOs.
1845 2011-12-02 Ben Konrath <ben@bagu.org>
1847 Enable navigation to details view with string primary key from related list.
1849 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1850 Create a text primary key value when return type of result is
1851 java.sql.Types.VARCHAR.
1853 2011-12-02 Ben Konrath <ben@bagu.org>
1855 Use checkboxes for booleans in the details view.
1857 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1859 2011-12-01 Ben Konrath <ben@bagu.org>
1861 Improve performance of related list height calculation.
1863 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1864 Put code to calculate the expected height in a static initializer so
1865 that that it's only called once.
1867 2011-12-01 Ben Konrath <ben@bagu.org>
1869 Show related list tables in notebooks (again).
1871 Calculate the height of the related list tables so the Notebook can be
1872 set the correct height. The height of the related list table is also needed by
1873 FlowTable to be able decide how to create the layout.
1875 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1876 and set the Portal height based on the height of the related list
1877 table and the Portal container.
1878 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1879 Add method to calculate the height of the related list tables.
1880 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1881 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1882 calculate the height of the Pager widget.
1884 2011-12-01 Ben Konrath <ben@bagu.org>
1886 Use CellTable API for table property instead of setting style on Element.
1888 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1890 2011-12-01 Ben Konrath <ben@bagu.org>
1892 Make ListViewTable and RelatedListTable a consistent height.
1894 The tables are now a consistent height regardless of the contents of
1895 the table. A hidden button is added to empty rows to ensure that the
1896 height of these rows will match the height of rows with data.
1898 A navigation button column is now added to every table. The width of
1899 the navigation column is set to 0px when a RelatedListTable shouldn't
1900 have navigation buttons. This maintains the a consistent row height in
1901 tables that don't show the navigation buttons.
1903 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1904 navigation column when not needed.
1905 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1906 arguments for navigation button to constructor of ListViewTable.
1907 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1908 hidden button for empty data rows.
1909 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1910 arguments for navigation button to constructor.
1911 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1912 create navigation buttons. Add hideNavigationButtons() method.
1913 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1914 arguments for navigation button to constructor.
1916 2011-12-01 Ben Konrath <ben@bagu.org>
1918 Use 'visibility: hidden' in Utils.getWidgetHeight().
1920 This is better choice because hidden elements are invisible, don't
1921 respond to events and are not part of the tab order. They will,
1922 however, take up space which is required to be able to calculate the
1923 height of the widget.
1925 * src/main/java/org/glom/web/client/Utils.java:
1927 2011-12-01 Ben Konrath <ben@bagu.org>
1929 Use Utils.getWidgetHeight() in FlowTable.
1931 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1933 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1935 2011-12-01 Ben Konrath <ben@bagu.org>
1937 Put the details css class name on the correct table column.
1939 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1941 2011-11-30 Ben Konrath <ben@bagu.org>
1943 Update for java-libglom API change.
1945 The getters and setters on FieldFormatting and NumericFormat were
1946 changed to remove the 'M'.
1948 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1950 2011-11-29 Ben Konrath <ben@bagu.org>
1952 Only allow RelatedListTables in Portals.
1954 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1956 2011-11-29 Ben Konrath <ben@bagu.org>
1958 Only create a contents panel for Portals when title is being set.
1960 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1962 2011-11-29 Ben Konrath <ben@bagu.org>
1964 Set TabLayoutPanel height based on calculated height its widgets.
1966 This is a potential fix for this bug:
1968 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1970 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1972 2011-11-29 Ben Konrath <ben@bagu.org>
1974 Align details field labels and data with the Open buttons.
1976 * src/main/webapp/style.css:
1978 2011-11-29 Ben Konrath <ben@bagu.org>
1980 Remove unnecessary <div> in the Notebook widget.
1982 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1983 method to get container FlowPanel (<div>).
1984 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1985 initWidget() method directly on the TabLayoutPanel widget instead of
1986 Group's container widget.
1988 2011-11-29 Ben Konrath <ben@bagu.org>
1990 Don't add group titles for Portals in Notebooks.
1992 This reverts the previous patch and fixes a bug I introduced with
1993 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1995 * src/main/java/org/glom/web/client/ui/details/Group.java:
1996 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1998 2011-11-28 Ben Konrath <ben@bagu.org>
2000 Remove unused boolean argument in Portal constructor.
2002 Just a code cleanup.
2004 * src/main/java/org/glom/web/client/ui/details/Group.java:
2005 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2007 2011-11-28 Ben Konrath <ben@bagu.org>
2009 Remove hack for glom 1.18 style glom files.
2011 * src/main/java/org/glom/web/client/ui/details/Group.java:
2012 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2013 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2015 2011-11-28 Ben Konrath <ben@bagu.org>
2017 Use Gda Value version of primary key to log result too large error.
2019 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2021 2011-11-28 Ben Konrath <ben@bagu.org>
2023 Don't use TypedDataItem.getText() for Unknown types from the URL.
2025 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2026 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2027 instead of getText().
2028 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2029 String field and getUnknown() method.
2031 2011-11-28 Ben Konrath <ben@bagu.org>
2033 Log an error message when the java-libglom .so is not present.
2035 The error message was being set in the exception but not logged.
2037 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2039 2011-11-28 Ben Konrath <ben@bagu.org>
2041 Ignore LayoutItem_CalendarPortals.
2043 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2044 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2046 2011-11-28 Ben Konrath <ben@bagu.org>
2048 Extract method for creating the LayoutItemPortal DTO.
2050 Just breaking the code up into smaller chunks.
2052 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2054 2011-11-28 Ben Konrath <ben@bagu.org>
2058 This should have been added with the refactor. Oops!
2060 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2062 2011-11-28 Ben Konrath <ben@bagu.org>
2064 Create primary key value from URL string using type from Glom document.
2066 See this bug, comments 19 - 25:
2068 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2070 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2071 create a TypeDataItem for the primary key here when loading from a
2072 URL. Show the same string for the primary key value as was received
2073 from the URL string (when loading from a URL).
2074 * src/main/java/org/glom/web/server/Utils.java: Update method for
2075 creating the Gda Value from the TypeDataItem to properly deal with
2076 creating a Gda Value based on the Glom document type for the primary
2077 key value string when loading from a URL.
2078 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2079 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2080 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2081 Update for changed method name.
2083 2011-11-27 Ben Konrath <ben@bagu.org>
2085 Rename PrimaryKeyItem to TypedDataItem.
2087 The name PrimaryKeyItem suggests what the class should be used for.
2088 TypedDataItem is a neutral name that describes the class better.
2090 This is a rename-only refactor.
2092 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2093 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2094 * src/main/java/org/glom/web/client/Utils.java:
2095 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2096 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2097 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2098 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2099 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2100 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2102 * src/main/java/org/glom/web/server/Utils.java:
2103 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2104 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2105 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2106 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2108 2011-11-25 Ben Konrath <ben@bagu.org>
2110 Improve Gda Value conversion from PrimaryKeyItem.
2112 The value from the PrimaryKeyItem is only used if its type match the
2113 type from the glom document.
2115 * src/main/java/org/glom/web/server/Utils.java:
2117 2011-11-25 Ben Konrath <ben@bagu.org>
2119 Manually check if the java-liblgom .so is visible to the JVM.
2121 It seems that Tomcat has problems when a static initializer throws an
2122 exception. This check is done before the first method call into
2123 java-libglom so that execution doesn't continue if the .so is not
2126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2128 2011-11-25 Ben Konrath <ben@bagu.org>
2130 Improve browser configuration error messages.
2134 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2136 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2137 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2138 getConfigurationErrorMessage() method.
2139 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2140 Get and display a specific configuration error message when no Glom
2141 documents are found.
2142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2143 Implement getConfigurationErrorMessage() method. Surround configuration
2144 code in the init() method with a try/catch block. This allows the
2145 errors to be caught while keeping the servlet available to retrieve the
2146 configuration error message.
2148 2011-11-25 Ben Konrath <ben@bagu.org>
2150 Don't use Strings to hold primary key values.
2152 The primary key values are now held in a new data object
2153 (PrimaryKeyItem) that holds type information and the primary key value
2154 using the correct type.
2156 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2157 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2159 PrimaryKeyItem instead of String to hold the primary key value.
2160 * src/main/java/org/glom/web/client/Utils.java: Remove
2161 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2162 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2163 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2164 PrimaryKeyItem instead of String to hold the primary key value. Load
2165 document selection page when the documentID has not been set correctly.
2166 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2167 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2169 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2170 Return empty string for URL instead of "null".
2171 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2172 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2173 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2174 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2175 PrimaryKeyItem instead of String to hold primary key values.
2176 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2177 PrimaryKeyValue to a Gda Value.
2178 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2179 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2180 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2181 Replace temporary database access code that uses the PrimaryKeyValue to
2182 Gda Value conversion.
2183 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2184 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2185 PrimaryKeyItem instead of String.
2186 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2187 hold primary key values.
2189 2011-11-24 Ben Konrath <ben@bagu.org>
2191 Use newly added java-libglom API to create queries.
2193 This isn't finished. I still need to stop using Strings for primary key
2194 values in the client code.
2196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2197 libglom to use fake connections so that retrieving the query string will
2199 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2200 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2201 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2202 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2203 Use the newly added libglom sql methods and classes to create the
2204 query. Add temporary hack to convert primary value strings to Gda
2207 2011-11-23 Ben Konrath <ben@bagu.org>
2209 Don't explicitly set the height of Portals.
2211 See comments 6 - 10 of this bug for details:
2213 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2215 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2217 2011-11-23 Ben Konrath <ben@bagu.org>
2219 Use an HTML table instead of CSS for the FlowTable layout.
2221 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2222 GWT's FlexTable to implement the FlowTable.
2223 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2225 2011-11-18 Ben Konrath <ben@bagu.org>
2227 Add boolean example to HTML table mockup.
2229 * mockups/details-view-html-tables-text-entries.html:
2231 2011-11-17 Ben Konrath <ben@bagu.org>
2233 Ensure the pager buttons are always visible for related lists.
2235 To accomplish this, I've turned off text wrapping in the list view and
2236 related list tables for both the header and data text. The related list
2237 table now has a fixed layout so the it doesn't overflow its container.
2238 This is required to ensure that the cell text is clipped when it
2239 overflows the cell and an ellipsis is added to the right side of the
2240 cell when text is clipped.
2242 A fixed table layout for the related list table in the details view
2243 seems what we want for the details view anyway, so the side-effect is
2246 The ellipsis will only be displayed in Firefox >= 7.
2250 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2252 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2253 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2254 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2256 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2257 Set the 'table-layout: fixed' CSS property to the related list table.
2258 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2259 'white-space: nowrap;' CSS property on both the list view and the
2260 related list tables.
2262 2011-11-16 Ben Konrath <ben@bagu.org>
2264 Rework the fix for empty notebook tab labels.
2266 Setting the empty group titles with its name caused problems for the
2267 details layout. Instead of using libglom's
2268 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2269 to the client when the title is empty. This allows the Notebook to use
2270 the name when the title is empty without affecting anything else.
2272 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2273 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2275 2011-11-16 Ben Konrath <ben@bagu.org>
2277 Set group titles with name when title is empty.
2279 This fixes a problem with an empty notebook tab label in the Lesson
2280 Planner document. The forth tab in the notebook should be "Internet":
2282 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2284 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2285 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2288 2011-11-16 Ben Konrath <ben@bagu.org>
2290 Remove whitespace from the configured username properties.
2292 This assumes that usernames won't have whitespace at the beginning
2293 or end. But I think this is a reasonable assumption.
2295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2296 String.trim() to remove the whitespace from the username properties.
2298 2011-11-15 Ben Konrath <ben@bagu.org>
2300 Add details view mockup with HTML tables and text entries.
2302 This is from the attachment on this bug:
2304 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2306 * mockups/details-view-html-tables-text-entries.html:
2308 2011-11-15 Ben Konrath <ben@bagu.org>
2310 Add space between the columns of the flow table.
2314 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2316 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2317 space between columns in the flow table.
2319 2011-11-15 Ben Konrath <ben@bagu.org>
2321 Add backup files to the .gitignore.
2323 * .gitignore: Ignore files that end with ~.
2325 2011-11-09 Ben Konrath <ben@bagu.org>
2327 Use latest release of gwt-log.
2329 Gwt-log releases are now being submitted to the maven central
2330 repository so manual installation of the jar is no longer required.
2332 * pom.xml: Update version and groupId of gwt-log dependency.
2334 2011-10-31 Ben Konrath <ben@bagu.org>
2336 Don't use GWT numeric formatting to override the glom currency formatting.
2338 Currencies are now displayed like they are in Glom. See this bug:
2340 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2342 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2344 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2345 currency code to constructor and set it when the cell is rendered.
2346 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2347 currency code to the constructor of the NumericCell.
2349 2011-10-27 Ben Konrath <ben@bagu.org>
2351 Require the latest release of java-libglom (1.17.4).
2355 2011-10-26 Ben Konrath <ben@bagu.org>
2357 Add style to Notebook that matches current theme.
2359 It's not the best style in the world but it's better than the default.
2361 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2362 padding at the bottom of the child widgets.
2363 * src/main/webapp/style.css: Add style for the Notebook.
2365 2011-10-26 Ben Konrath <ben@bagu.org>
2367 Move servlet initialization code to overridden init method.
2369 This is half of the solution to getting proper error messages
2370 displayed when configuration errors occur. Here's the relevant bug:
2372 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2374 The rest of the solution involves surrounding the init method with a
2375 try/catch block and setting a global variable with the error /
2376 exception. A new async method should be created to retrieve and display
2377 the error message / exception.
2379 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2380 code from constructor to init method adding exceptions as needed.
2382 2011-10-26 Ben Konrath <ben@bagu.org>
2384 Add script to monitor and restart tomcat if required.
2386 * utils/check-and-recover-tomcat.py: New file.
2388 2011-10-26 Ben Konrath <ben@bagu.org>
2390 Display the correct number of data items in the pager.
2394 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2396 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2397 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2398 The implementation is the same for both tables: Keep track of the
2399 number of non-empty rows and fire and RowCountChangeEvent after the data has
2401 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2402 custom Pager class that subclasses SimplePager to handle displaying
2403 the correct number when empty rows have been added.
2405 2011-10-26 Ben Konrath <ben@bagu.org>
2407 Correct error in previous commit.
2409 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2410 eventBus parameter from listView.setCellTable().
2412 2011-10-26 Ben Konrath <ben@bagu.org>
2414 Fix error in TODO comment.
2416 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2418 2011-10-24 Ben Konrath <ben@bagu.org>
2420 Create Notebook widgets to the details view.
2422 This isn't finished just yet - I still need to create a reasonable
2423 style to match the current theme.
2425 * src/main/java/org/glom/web/client/Utils.java: Add method for
2426 calculating the height of a widget. This is used in the Notebook class.
2427 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2428 new constructor method in Group.
2429 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2430 method for creating child widget that can be used by subclasses
2431 like Notebook. New constructor that allows disabling the group
2432 titles - Notebooks don't set a group title for their child groups.
2433 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2434 to make Notebooks using GWT's TabLayoutPanel.
2435 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2436 constructor that allows disabling the group titles.
2437 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2438 LayoutItemNotebook DTO.
2439 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2440 DTO for Notebooks. It's just an empty class for now but we might need
2441 it to transfer some specific information in the future.
2443 2011-10-21 Ben Konrath <ben@bagu.org>
2445 Add navigation buttons to related list tables.
2447 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2448 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2449 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2450 method getSuitableRecordToViewDetails() for getting the table name
2451 and primary key value for related list navigation buttons.
2452 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2453 private cell renderer class to get the navigation information for
2454 related list tables from the server. Extract the navigation
2455 processing code from the details cell navigation and use it for the
2456 related list navigation as well.
2457 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2458 cell renderer class for the details open buttons. This was needed
2459 because the related list navigation buttons and the list view
2460 navigation buttons need to react differently when clicked.
2461 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2462 the onEnterKeyDown() method because it's now overriden in the
2463 subclasses that are specific to the related list tables and the list
2465 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2466 the vertical size a little because the buttons add a bit of vertical
2467 space to table. This is not a perfect solution because the vertical
2468 size of with table fewer than 5 rows will be a little smaller.
2469 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2470 changes in how navigation buttons are handled.
2471 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2472 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2473 database access object.
2474 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2475 to find the portal for a given relationship name from
2476 RelatedListDBAccess. Add method to find a primary key field for a
2478 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2479 Move code to find the portal for a given relationship name to
2481 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2482 New file: database access object for getting the related list
2483 navigation information (the table name and the primary key value).
2484 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2485 DTO for transferring a table name to navigate to and a primary key
2487 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2488 boolean and getter/setter to specifies if the related list should add
2491 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2493 Use the master branch of java-libglom
2495 * pom.xml: Depend on java-libglom 1.19 instead.
2497 This is the master branch. See also the libglom-1-18 branch.
2499 2011-10-11 Ben Konrath <ben@bagu.org>
2501 Enable the open navigation button when the data has been set.
2503 This avoids having active buttons that don't do anything when the data
2506 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2508 2011-10-11 Ben Konrath <ben@bagu.org>
2510 Use IsWidget interface for FlowTableItem.
2512 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2513 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2515 2011-10-11 Ben Konrath <ben@bagu.org>
2517 Remove GWT styling from open button in details view.
2519 There are still some issues with how the details cell is arranged but
2520 this should be made to match Glom 1.20. I'm going to leave fixing this
2521 until I have Glom 1.20 up and running.
2523 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2524 style name on open button.
2525 * src/main/webapp/style.css: Move and edit details-navigation class.
2526 Re-arrange some classes to make them appear in the same order as the
2529 2011-10-07 Ben Konrath <ben@bagu.org>
2531 Update to GWT 2.4.0.
2533 * .gitignore: Ignore new cache directory.
2534 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2535 * pom.xml: Change GWT and maven plugin to 2.4.0.
2536 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2538 * src/main/java/org/glom/web/client/ClientFactory.java:
2539 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2540 * src/main/java/org/glom/web/client/OnlineGlom.java:
2541 Update source for API changes.
2542 * utils/build-onlineglom-war.sh: Remove cache directory before the
2545 2011-10-07 Ben Konrath <ben@bagu.org>
2547 Add navigation buttons in the details view.
2549 This isn't finished but I thought I'd commit what I have as it's a
2550 pretty good start. I still need to:
2552 1. Change the style so that it fits better into the current theme
2553 2. Adjust the details cell to expand as much as possible.
2555 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2556 click handlers to navigation buttons in the DetailsCells. Create a
2557 refreshData() method to get just the data from the server without the
2559 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2560 Update the tableSelector and browser title when the table name
2561 changes without using the tableSelector.
2562 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2563 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2564 getDetailsCells() to getCells(). Update variable names.
2565 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2566 method to set click handler on navigation button. Rename a few
2567 variables. Add navigation buttons where needed.
2568 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2569 variables and methods.
2570 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2571 navigation boolean and navigation table as required in the
2572 LayoutItemField DTO.
2573 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2574 variables for navigation along with getter/setter methods.
2576 2011-10-07 Ben Konrath <ben@bagu.org>
2578 Rename Field to DetailsCell.
2580 This is a refactor-only commit. No functionality has been added or
2583 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2584 Update variable and method names.
2585 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2586 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2587 variable and method names.
2588 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2590 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2591 variable and method names.
2593 2011-10-07 Ben Konrath <ben@bagu.org>
2595 Create separate methods for layout and data the details view.
2597 This is a refactor-only commit. No functionality has been added or
2600 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2601 private methods: setData(), createLayout().
2603 2011-10-07 Ben Konrath <ben@bagu.org>
2605 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2607 This is part of a change to get navigation buttons in the details view
2608 but it should have been done this way from the start.
2610 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2611 for method name change in TableSelectionView.
2612 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2613 Create TableChangeEvent and set the browser title using the
2614 TableSelectionView API.
2615 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2616 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2617 Change getSelectedTable() to getSelectedTableName(). Add
2618 getSelectedTableTitle().
2620 2011-10-07 Ben Konrath <ben@bagu.org>
2622 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2624 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2626 2011-10-07 Ben Konrath <ben@bagu.org>
2628 Update TableChangeEvent to use newTableName naming convention.
2630 This makes the class more consistent with GWT naming conventions.
2632 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2633 Update for method name change in TableChangeEvent.
2634 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2635 for method name change in TableChangeEvent.
2636 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2637 newTableName variable and getter method. Make toDebugString()
2640 2011-09-30 Ben Konrath <ben@bagu.org>
2642 Disable the pager in the list tables when the data row count is less than the minimum.
2644 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2645 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2647 2011-09-30 Ben Konrath <ben@bagu.org>
2649 Add empty rows to the end of related list and list view tables.
2651 I also extracted the cell rendering classes from the ListTable because
2652 the code was becoming a little crazy with all the anonymous inner
2653 classes. My plan is to use these cell rendering classes in the details
2654 view as well so this refactor will be needed for that change.
2656 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2657 set the row count in related list tables if the data has more rows
2658 than the minimum number of rows visible.
2659 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2660 row count in list view tables if the data has more rows than the
2661 minimum number of rows visible.
2662 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2663 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2665 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2666 for rendering TYPE_NUMERIC cells. The code was extracted from the
2668 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2669 class for rendering cells with buttons in list views. The code was
2670 extracted from the ListTable class.
2671 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2672 for rendering TYPE_TEXT cells. The code was extracted from the
2674 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2675 Add empty rows to the end of the data if required. Implement
2676 ListTable.getMinNumVisibleRows().
2677 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2678 cell renderer code to public classes. Return null in
2679 Column.getValue() for empty rows. Add new abstract method:
2680 getMinNumVisibleRows(). Move code to set the row count of the list view
2681 table to ListViewImpl.
2682 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2683 empty rows to the end of the data if required. Implement
2684 ListTable.getMinNumVisibleRows().
2687 2011-09-27 Ben Konrath <ben@bagu.org>
2689 Use GWT.log for client-side debugging statements.
2691 These are optimized out when deployed so I should have used this method
2692 in the first place. These statements will eventually be replaced with some sort
2693 of notification in the browser.
2695 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2696 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2697 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2698 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2699 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2701 2011-09-27 Ben Konrath <ben@bagu.org>
2703 Put tableselector on the right, back to list link on right.
2705 The idea is that the table selector is acting like a label for the
2706 currently displayed table so it should be placed below the document title. This
2707 puts the table title in a similar position to where it is in Glom.
2709 * mockups/details-contacts.html:
2710 * mockups/details-projects.html:
2711 * mockups/listview-contacts.html:
2712 * mockups/listview-projects.html:
2713 * mockups/style.css:
2714 Update mockups to match how the interfaces currently look.
2715 * src/main/webapp/style.css: Swap positions of backlink with the table
2716 selector. Add some space on the left side of the table selector to
2717 line things up with the document title.
2719 2011-09-27 Ben Konrath <ben@bagu.org>
2721 Add field colouring to details view.
2723 This change re-works how field colouring works. The colour formatting
2724 information is now set to the client with the layout information instead of
2725 with the data. This eliminates the need to send the same colour strings for
2726 data in list view column when colour information is set.
2728 In order to set an alternate colour for negative numeric values, the
2729 number is now sent to client and formatted with the GWT NumberFormat class.
2731 This change also fixes:
2733 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2735 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2736 internationalization framework which is needed for client side numeric
2738 * src/main/java/org/glom/web/client/Utils.java: New file for some
2739 client static utility methods.
2740 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2741 the DataItem object to the Field class. Use a utility method to
2742 create the foreignKeyValue string.
2743 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2744 alignment and text colours in the constructor. Add setData(DataItem)
2745 method. Remove setText(String) method.
2746 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2747 colour information to GlomTextCell. Create and use GlomNumberCell for
2748 rendering numbers. Use utility method to get the string for the
2749 primary key of the key provider. Re-work how the horizontal alignment
2751 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2752 formatting to layout information. Methods for converting the libglom
2753 formatting information were moved from DBAccess.
2754 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2755 numeric formatting (it's now done on the client side). Don't set text
2756 colours in DataItem. Move libglom formatting conversion methods to
2758 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2759 getters/setters for text colour information.
2760 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2761 for transferring the libglom NumericFormat information to the client.
2762 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2763 and getters/setters for: GlomNumericFormat, background colour and
2764 foreground colour strings.
2766 2011-09-26 Ben Konrath <ben@bagu.org>
2768 Simplify code that iterates through the LayoutGroup.
2770 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2772 2011-09-26 Ben Konrath <ben@bagu.org>
2774 Accept Eclipse formatting for OnlineGlomServiceAsync.
2776 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2778 2011-09-26 Ben Konrath <ben@bagu.org>
2780 Don't use the ListDBAccess classes to get the primary key layout information.
2782 This was causing a bug where the wrong index for the hidden primary key
2783 was being sent to the client.
2785 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2786 primary key while creating the LayoutGroup DTO. Create a
2787 LayoutItemField DTO for hidden primary keys. Don't use the
2788 RelatedListDBAccess because it was only used for getting the primary
2790 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2791 access modifier from public to protected for getPrimaryKeyField() and
2792 getPrimaryKeyLayoutItemField().
2793 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2794 abstract method getExpectedResultSize() because RelatedListDBAccess
2795 doesn't have enough info to implement it.
2796 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2797 Remove @Override for getExpectedResultSize().
2798 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2799 Remove method getExpectedResultSize().
2801 2011-09-23 Ben Konrath <ben@bagu.org>
2803 Log which layout (list or details) the ignored item is from.
2805 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2807 2011-09-23 Ben Konrath <ben@bagu.org>
2809 Remove annotations that turn off code formatting in DataItem.
2811 * src/main/java/org/glom/web/shared/DataItem.java:
2813 2011-09-23 Ben Konrath <ben@bagu.org>
2815 Rename GlomField to DataItem and update associated methods.
2817 This is a rename-only refactor. No functionality has been added or
2820 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2821 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2822 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2823 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2824 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2825 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2826 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2827 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2828 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2829 * src/main/java/org/glom/web/server/database/DBAccess.java:
2830 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2831 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2832 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2833 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2834 * src/main/java/org/glom/web/shared/DataItem.java:
2835 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2836 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2838 2011-09-23 Ben Konrath <ben@bagu.org>
2840 Rename GlomDocument to DocumentInfo and update associated methods.
2842 This is a rename-only refactor. No functionality has been added or
2845 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2846 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2847 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2848 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2849 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2850 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2851 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2853 2011-09-20 Ben Konrath <ben@bagu.org>
2855 Require java-libglom 1.17.3.
2857 This picks up the fix for the seg fault problem with the Scenes table
2858 in the Openismus Film Manager example.
2862 2011-09-20 Ben Konrath <ben@bagu.org>
2864 Change the way sort clause is added for primary key when no sort clause is requested.
2866 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2867 before the sort clause is created. When a sort clause is not requested, the
2868 sort clause is created by finding the primary key in the LayoutFieldVector
2871 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2873 2011-09-20 Ben Konrath <ben@bagu.org>
2875 Log error message if no documents are found in the configured directory.
2877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2878 Extract the glom file extension string to a private static final class
2879 variable (mostly as syntactic sugar). Accept a minor formatting change.
2880 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2881 the example glom.document.directory configuration property to make it
2882 more clear that it can any directory, not just the home directory.
2884 2011-09-18 Ben Konrath <ben@bagu.org>
2886 Add related lists to details view.
2888 The related list table has support for paging and sorting just like the
2889 table in the list view.
2891 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2892 SQL queries for the related list tables.
2893 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2894 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2895 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2896 Rename getList methods to getListView and add comments. Remove
2897 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2898 it being unused. Add methods: getDetailsLayoutAndData(),
2899 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2900 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2901 Create the layout and set the data for the fields in one async call
2902 instead of two. Create related lists where appropriate.
2903 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2904 for method name changes in OnlineGlomService.
2905 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2906 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2907 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2909 * src/main/java/org/glom/web/client/ui/ListView.java:
2910 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2911 tableName from setCellTable(). Create a ListViewTable instead of
2913 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2914 represent a data field in the details view.
2915 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2916 from addDetailsCell() to Field class. Keep track of the Fields and
2917 Portals in the details view.
2918 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2919 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2920 and add a method to get it. Add method to set the contents of the
2922 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2923 New class for related list tables. This class has the data provider
2924 for the related list table.
2925 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2926 abstract class which is the base class for the ListViewTable and the
2928 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2929 New class for list view tables. This class has the data provider for
2930 the list view table.
2931 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2932 methods for related list tables. Add more information to the
2933 LayoutItemField and LayoutItemPortal DTOs.
2934 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2935 Remove debugging print statement.
2936 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2937 Remove debugging print statements. Add primary key field to SQL count
2939 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2940 Remove unnecessary LayoutFieldVector parameter from
2941 getResultSizeOfSQLQuery() method.
2942 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2943 New class for related list table database access.
2944 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2945 class that is a wrapper DTO for details view layout and data.
2946 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2947 new 'fromField' string to this DTO.
2948 * src/main/webapp/style.css: Remove bottom margin and override top
2951 2011-09-15 Ben Konrath <ben@bagu.org>
2953 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2955 This sets things up to make it easier to add the data retrieval for
2956 related lists (portals). No user noticeable changes were made with
2959 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2960 class has the code to retrieve the layouts and access the
2961 database using the new database helper classes.
2962 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2963 Most of the functionality has been removed from this class. This
2964 class now represents the public interface for the client side
2965 code. It also deals with configuring the servlet and cleaning
2966 things up when the servlet is stopped.
2967 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2968 of static methods into this utility class.
2969 * src/main/java/org/glom/web/server/database/DBAccess.java:
2970 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2971 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2972 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2973 These classes have the database retrieval code. The class hierarchy
2974 has been setup to make it easy to reuse code for similar
2977 2011-09-06 Ben Konrath <ben@bagu.org>
2979 Create separate classes for list table code and the data provider.
2981 As part of this refactor, I also split up the code a bit to make it
2984 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2985 table code to two new classes (below).
2986 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2987 with code from ListViewImpl.
2988 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2989 New file with code from ListViewImpl.
2991 2011-09-06 Ben Konrath <ben@bagu.org>
2993 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2995 This fixes the LayoutItemPortal DTO to match the libglom layout object
2998 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3000 2011-09-01 Ben Konrath <ben@bagu.org>
3002 Set title of Portals in the Details View.
3004 * pom.xml: Bump required version of java-libglom to 1.17.1.
3005 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3006 widget creation to its own class. Add comments to constructor.
3007 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3008 The code is mostly from the Group class with the title now set.
3009 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3010 title of Portal. Update some comments. Fix some code formatting.
3012 2011-09-01 Ben Konrath <ben@bagu.org>
3014 Remove TODO comment for the flow table column width.
3016 The flow table column width is working correctly and doesn't need to be
3017 changed. See this mailing list post for more info:
3019 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3021 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3023 2011-08-27 Ben Konrath <ben@bagu.org>
3025 Add document title (database name) to top of the browser page.
3027 I added the document title to the TableSelecitonView but that will
3028 change if / when we add a view that doesn't require table selection.
3030 * mockups/details-contacts.html:
3031 * mockups/details-projects.html:
3032 * mockups/listview-contacts.html:
3033 * mockups/listview-projects.html:
3034 * mockups/style.css: Add document title to mockups to keep things
3036 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3037 sizes to account for the document title.
3038 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3039 Set the document title when it has been retrieved from the server.
3040 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3041 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3042 and implement setDocumentTitle(String) method.
3043 * src/main/webapp/style.css: Add ID for document title style.
3045 2011-08-25 Ben Konrath <ben@bagu.org>
3047 Add NavigationType enum to LayoutItemPortal DTO.
3049 This is the start of adding support for Portals to the Details View.
3051 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3052 LayoutItem_Portal.navigation_type enum from libglom to
3053 LayoutItemPortal.NavigationType enum.
3054 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3055 NavigationType enum, field for storing the NavigationType and getter
3058 2011-08-25 Ben Konrath <ben@bagu.org>
3060 Implement the flow table layout in the Details View.
3062 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3063 FlowTable to Group to account for the renamed class.
3064 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3065 File. This is a container widget that implements the Glom details view
3066 flow table behaviour.
3067 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3068 org/glom/web/client/ui/FlowTable.java.
3069 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3070 so that the size of the subgroups are a closer match to the size of
3071 the Glom subgroups. This makes the flowtable layout match the layout
3072 in Glom for the Music Collection example file.
3074 2011-08-16 Ben Konrath <ben@bagu.org>
3076 Create container element for LayoutItemPortal in Details View.
3078 This will help me develop the layout for the FlowTable.
3080 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3081 fieldPanel variable to detailsCell.
3083 2011-08-15 Ben Konrath <ben@bagu.org>
3085 Set the height of the data element in the Details View.
3087 I changed the InlineLabels (text in a span element) to Labels (text in
3088 a div element) so that I could set the height of the details-data
3089 elements instead of the details-cell parent elements. This allows the
3090 the details-data element to display the correct height if style is
3091 applied that shows the height.
3093 This change has the added benefit of allowing the order of the labels
3094 and data elements to be changed for right-to-left languages.
3096 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3097 InlineLabels to Labels.
3098 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3099 InlineLabels to Labels. Set the height of the data element.
3100 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3101 multiline text height in the Formatting DTO.
3102 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3103 for multiline height along with getter and setter methods.
3104 * src/main/webapp/style.css: Adjust style to account for the change
3105 from span elements to div elements in the details cell.
3107 2011-08-15 Ben Konrath <ben@bagu.org>
3109 Make the List View appearance match the mockups.
3111 It doesn't match exactly but it's much better than it was.
3113 * mockups/listview-contacts.html: Remove unused css classes.
3114 * mockups/listview-projects.html: Remove unused css classes.
3115 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3116 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3117 for mainPanel instead of VerticalPanel (table). Set style name on
3118 CellTable. Set style name on Details column. Right-align Details
3120 * src/main/webapp/style.css: Adjust properties to match the mockups.
3122 2011-08-12 Ben Konrath <ben@bagu.org>
3124 Add better support for subgroups in the details view.
3126 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3127 changed FlowTable constructor.
3128 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3129 support for subgroups and subgroup-titles.
3130 * src/main/webapp/style.css: Add CSS class for subgroups and
3133 2011-08-12 Ben Konrath <ben@bagu.org>
3135 Return the top level LayoutGroup title.
3137 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3139 2011-08-11 Ben Konrath <ben@bagu.org>
3141 Make the TableSelector header match the mockup.
3143 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3144 the layout panel. Properly lineup the table selection header with
3145 the list and details view.
3146 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3147 margin around the details view.
3148 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3149 Rename listBox variable to tableSelector. Set id for the style sheet.
3150 Use a FlowPanel instead of a HorizontalPanel.
3151 * src/main/webapp/style.css: Add properties to make the TableSelector
3152 box match the mockups.
3154 2011-07-13 Ben Konrath <ben@bagu.org>
3156 Update install script for java-libglom version change.
3158 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3161 2011-07-13 Ben Konrath <ben@bagu.org>
3163 Add support sub-group in the details view.
3165 I also removed the code that special-cased the default details view
3168 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3170 I still have to make a proper flowtable.
3172 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3173 Don't special-case default details view layout.
3174 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3175 addLayoutField() as I'm going to use it.
3176 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3177 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3179 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3180 extracted from DetailsViewImpl.GroupPanel. Add support for
3182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3183 column count when getting the details layout.
3185 2011-07-12 Ben Konrath <ben@bagu.org>
3187 Set browser title with database and table titles.
3189 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3190 Set the browser title when the table changes and when the activity
3192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3193 title when retrieving document info (the GlomDocument object).
3194 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3195 with getter and setter methods. Remove unused convenience constructor.
3196 Use default code formatting.
3198 2011-07-12 Ben Konrath <ben@bagu.org>
3200 Ignore LayoutItemPortals in the details view.
3202 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3205 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3206 LayoutItemPortal layout objects.
3207 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3208 LayoutItemPortal objects when retrieving the details layout.
3209 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3210 file. This is an empty class and just used to get type information for
3213 2011-07-12 Ben Konrath <ben@bagu.org>
3215 Use java-libglom 1.17.0.
3219 2011-07-11 Ben Konrath <ben@bagu.org>
3221 Remove "Table:" label from table selector.
3223 This matches a recent change in the Glom UI.
3225 * mockups/details-contacts.html:
3226 * mockups/details-projects.html:
3227 * mockups/listview-contacts.html:
3228 * mockups/listview-projects.html: Remove the "Table:" label from the
3230 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3232 2011-07-11 Ben Konrath <ben@bagu.org>
3234 Add main groups to the details view.
3236 This makes things look a little nicer in the details view. The next step
3237 is to implement the flowtable.
3239 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3240 resources from the standard gwt css theme. Standard.css is now
3241 included in OnlineGlom.html so that the online glom css rules have
3242 precedence over the gwt theme.
3243 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3244 the whole LayoutGroup to the DetailsView instead of just the titles.
3245 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3246 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3247 details layout with a helper class (GroupPanel). I might extract this
3248 class when I make the full flowtable.
3249 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3250 string as default so I don't have to worry about NPEs when processing
3252 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3253 note beside OnlineGlom.gwt.xml above).
3254 * src/main/webapp/style.css: Add default font-size to body to override
3255 the font-size set by the standard theme. Don't use h2 tags for
3256 group-title. Create new details-cell class.