In the UI, allow primary keys to be any type, and test it.
[online-glom:gwt-glom.git] / ChangeLog
1 2012-12-02  Murray Cumming  <murrayc@murrayc.com>
2
3         In the UI, allow primary keys to be any type, and test it.
4
5         * src/main/java/org/glom/web/shared/TypedDataItem.java:
6         Added isUnknownType() for convenience.
7         * src/main/java/org/glom/web/client/place/DetailsPlace.java:
8         getToken(): Move some code into getStringForData() and handle
9         other data types.
10         * src/main/java/org/glom/web/server/Utils.java:
11         Added transformUnknownToActualType(), to parse the unknown string
12         as a particular type of data. This should correspond with 
13         getStringForData() above.
14         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
15         Add setDataItemType() to set the type of data for primary
16         keys.
17         getDetailsData(), getSuitableRecordToViewDetails():
18         Call it, to have the correctly-typed primary key value.
19         We do it here, on the server, instead of before, because it 
20         is only here that we can know the field type that is in the 
21         document.
22         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
23         Added testGetPlaceParametersNumericPrimaryKey(),
24         testGetPlaceParametersBooleanPrimaryKey() and 
25         testGetPlaceParametersDatePrimaryKey).
26
27 2012-11-30  Murray Cumming  <murrayc@murrayc.com>
28
29         Allow primary keys to be any type, and test it.
30
31         * src/main/java/org/glom/web/shared/TypedDataItem.java:
32         Add overrides for the other set*() methods, to set the type.
33         Added getValue() which returns a generic Object.
34         * src/main/java/org/glom/web/server/SqlUtils.java:
35         buildSimpleWhereExpression(): Use TypedDataItem.getValue() instead of 
36         getNumber().
37         * src/test/java/org/glom/web/server/SelfHostExampleNonNumericPrimaryKeysTest.java:
38         Added this test, which is much like SelfHostExampleTest, but which uses this
39         test file, take from Glom:
40         * src/test/resources/org/glom/web/server/test_example_music_collection_text_pk_fields.glom:
41         which has all the primary keys changes to text instead of numbers.
42
43         However, parts of the UI code still assume that primary keys are numbers.
44
45 2012-11-28  Murray Cumming  <murrayc@murrayc.com>
46
47         SelfHostExampleTest: Move some checks into a utility function.
48
49         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
50         Move the data checks into a new file:
51         * src/test/java/org/glom/web/server/SelfHostTestUtils.java:
52         SelfHostTestUtils.java: so we can use it in some other 
53         tests, with different documents.
54
55 2012-11-28  Murray Cumming  <murrayc@murrayc.com>
56
57         SelfHosting test: Also try using a relationship.
58
59         * src/main/java/org/glom/web/server/database/DBAccess.java:
60         convertResultSetToDTO(): Move some code into a public 
61         method as:
62         * src/main/java/org/glom/web/server/SqlUtils.java:
63         fillDataItemFromResultSet(): This takes a DataItem and 
64         sets it from a value from a datbase recordset.
65         * src/main/java/org/glom/web/server/libglom/Document.java:
66         Make getDocument() public, so we can use it in a test.
67         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
68         Add testExampleMusiccollectionDataRelated() and call it from 
69         testExampleMusiccollectionData(), to do a basic test of using
70         a relationship.
71
72 2012-11-22  Murray Cumming  <murrayc@murrayc.com>
73
74         Build: Specify the source encoding.
75
76         * pom.xml: Set project.build.sourceEncoding
77         This should fix this build problem on some systems:
78         [ERROR] /var/lib/jenkins/workspace/OnlineGlom/src/test/java/org/glom/web/server/libglom/DocumentTest.java:[139,72] error: unmappable character for encoding ASCII
79
80 1.23.1:
81
82 2012-11-20  Murray Cumming  <murrayc@murrayc.com>
83
84         Update the jasperreports version.
85
86         * pom.xml: This was shown by
87         mvn versions:display-dependency-updates
88
89 2012-11-20  Murray Cumming  <murrayc@murrayc.com>
90
91         Eclipse: Reorder the Java Build Path to fix the build in Eclipse.
92
93         * .classpath: This prevents an error saying that getTextContent()
94         is undefined.
95         See http://mergetag.com/the-method-gettextcontent-is-undefined-for-the-type-node/
96
97 2012-11-20  Murray Cumming  <murrayc@murrayc.com>
98
99         Explicitly declare some dependencies (and scopes) that we use.
100
101         * pom.xml: The dependency report showed what we use.
102
103 2012-11-20  Murray Cumming  <murrayc@murrayc.com>
104
105         Update the gwt-test-utils version.
106
107         * pom.xml: gwt-test-utils 0.43 uses GWT 2.5.0, not GWT 2.4.0.
108         Using both in the same project was causing gwt-log to fail in GWTBrige,
109         with this error:
110         testOutOfBounds(org.glom.web.server.libglom.DocumentLayoutPathTest):
111         (class: com/google/gwt/core/client/GWT, method: setBridge signature: (Lcom/google/gwt/core/client/GWTBridge;)V) Incompatible argument to function
112
113 2012-11-19  Murray Cumming  <murrayc@murrayc.com>
114
115         DocumentTest: testLocales(): Update for the latest example version.
116
117         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
118         The .glom file, updated in the previous commit, now has more translations.
119
120 2012-11-19  Murray Cumming  <murrayc@murrayc.com>
121
122         Update the .glom files used for tests.
123
124         * src/test/resources/org/glom/web/server/example_film_manager.glom:
125         * src/test/resources/org/glom/web/server/example_music_collection.glom:
126         * src/test/resources/org/glom/web/server/libglom/example_film_manager.glom:
127         * src/test/resources/org/glom/web/server/libglom/example_music_collection.glom:
128         Copy them from git master of Glom.
129
130 2012-11-18  Murray Cumming  <murrayc@murrayc.com>
131
132         Update versions of dependencies.
133
134         * pom.xml: Increase some version numbers based on the output of
135         , using mvn versions:display-dependency-updates.
136         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
137         Use the annotation instead of getModuleName().
138         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
139         Do not use deprecated assert() classes/methods.
140
141 2012-11-18  Murray Cumming  <murrayc@murrayc.com>
142
143         Document: Correct an import to use the correct Log API.
144
145         * src/main/java/org/glom/web/server/libglom/Document.java:
146         Use our Utils.Log API rather than the jfree one that Eclipse
147         must have suggested at some time.
148
149 2012-11-15  Murray Cumming  <murrayc@murrayc.com>
150
151         Details: Get static image data from our images services.
152
153         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
154         Add constructors for LayoutItemText and LayoutItemImage and
155         deal with their common type instead of just LayoutItemField.
156         setData():
157         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
158         Adapted.
159         * src/main/java/org/glom/web/client/ui/details/Group.java:
160         createChildWidget(): Use the other DetailsCell constructors for
161         these layout items, and do not add them to the list of
162         cells with data from the database.
163         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
164         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
165         Remove the image data when cloning the layout and storing it in the
166         cache. Clients will instead get it via the URL, from
167         our images service.
168         * src/main/java/org/glom/web/server/OnlineGlomImages.java:
169         doGet(): Depending on the URI parameters, optionally get 
170         image data from a layout_item_image in the document,
171         via its layout path.
172         * src/main/java/org/glom/web/server/database/DBAccess.java:
173         convertResultSetToDTO(): Move some URIBuilder code to:
174         * src/main/java/org/glom/web/server/Utils.java:
175         Add buildImageDataUrl() taking the primary key, etc, to
176         get data from the database.
177
178 2012-11-15  Murray Cumming  <murrayc@murrayc.com>
179
180         Document: Static image items: Store an image URL, using the layout path. 
181
182         * src/main/java/org/glom/web/server/Utils.java: Add buildImageDataUrl().
183         * src/main/java/org/glom/web/server/libglom/Document.java:
184         Add a constructor that takes the documentID, for use in the 
185         LayoutItemImage URL.
186         loadLayoutNode(): Pass a Path object to the helper methods, so we 
187         can use it to create a URL for LayoutItemImage items.
188         This seems as good a way as any to specify a layout item in the document.
189         * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
190         Pass the documentID to the constructor, for use in the LayoutItemImage
191         URL.
192
193 2012-11-15  Murray Cumming  <murrayc@murrayc.com>
194
195         Document: Add getLayoutItemByPath().
196
197         * src/main/java/org/glom/web/server/Utils.java:
198         Add buildLayoutPath() and parseLayoutPath().
199         * src/test/java/org/glom/web/server/LayoutPathTest.java: Test that these 
200         utility methods work.
201         * src/main/java/org/glom/web/server/libglom/Document.java:
202         Add Add getLayoutItemByPath().
203         * src/test/java/org/glom/web/server/libglom/DocumentLayoutPathTest.java: Test 
204         that it works.
205
206         This will be useful in subsequent commits.
207
208 2012-11-15  Murray Cumming  <murrayc@murrayc.com>
209
210         Document: Use a better base64 decoder to read static image data.
211
212         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
213         getNodeTextChildAsValue(): Use the apache commons base64 decoder
214         instead of the gwt one, because it correctly decodes the strings
215         from g_base64_encode(). It is probably more correct.
216         The newlines might be confusing the gwt decoder.
217
218 2012-11-14  Murray Cumming  <murrayc@murrayc.com>
219
220         Document: Do not use == to compare strings. Use equals().
221
222         * src/main/java/org/glom/web/server/libglom/Document.java:
223         == only checks that they are the same object, so it can 
224         seem to fail.
225
226 2012-11-14  Murray Cumming  <murrayc@murrayc.com>
227
228         Document: Add and use public constants for layout names.
229
230         * src/main/java/org/glom/web/server/libglom/Document.java:
231         Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
232         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
233         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
234         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
235         * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use 
236         them here instead of hard-coded the strings repeatedly.
237
238 2012-11-13  Murray Cumming  <murrayc@murrayc.com>
239
240         Document: Load static text and image items too.
241
242         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
243         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
244         New LayoutItem classes to represent these layout items.
245         * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The 
246         main text of a LayoutItemText.
247         * src/main/java/org/glom/web/server/libglom/Document.java:
248         load_after_layout_group(): Handle the node types and instantiate the 
249         new classes.
250         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
251         Add testLayoutItemText() to check that the text is loaded properly.
252
253 2012-11-13  Murray Cumming  <murrayc@murrayc.com>
254
255         Do not use client.GWT for shared code.
256
257         * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
258         Import shared.GWT instead of client.GWT, which seems to be appropriate.
259
260 2012-11-12  Murray Cumming  <murrayc@murrayc.com>
261
262         Use image data when recreating databases for testing.
263
264         * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
265         for use locally (not acrosss the network) when recreating databases
266         for testing.
267         getValue(): Use it here instead of getImageDataUrl(), noting that 
268         this method is only for use when recreating databases.
269         * src/main/java/org/glom/web/server/libglom/Document.java:
270         getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
271
272 2012-11-09  Murray Cumming  <murrayc@murrayc.com>
273
274         OnlineGlomImages: Detect the mime-type (content type).
275
276         * src/main/java/org/glom/web/server/OnlineGlomImages.java:
277         doGet(): Instead of hard-coding image/png.
278
279 2012-11-09  Murray Cumming  <murrayc@murrayc.com>
280
281         Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
282
283         * .classpath:
284         * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
285         Java Compiler and Java Build path settings in the UI.
286
287 2012-11-09  Murray Cumming  <murrayc@murrayc.com>
288
289         Use the latest (now stable) version of GWT.
290
291         * pom.xml: And the latest version of the gwt-maven-plugin.
292
293 2012-11-08  Murray Cumming  <murrayc@murrayc.com>
294
295         Added an Indonesian translation.
296
297         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
298         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
299         This is from the new translation in Glom.
300
301 2012-07-23  Murray Cumming  <murrayc@murrayc.com>
302
303         Details: Show images.
304
305         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
306         Move some code into
307         * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
308         so it can be used in:
309         * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
310         for serving image data.
311         * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
312
313         * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
314         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
315         setData(): For image field types, add a GWT Image widget, 
316         with the URL that was set in the DataItem.
317
318         * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
319         * src/main/java/org/glom/web/server/database/DBAccess.java:
320         convertResultSetToDTO(): Set the URL for image data, so the client browser
321         can retrieve the image from our new servlet. This uses UriBuilder.
322         Move getPrimaryKeyField to:
323         * src/main/java/org/glom/web/server/libglom/Document.java:
324         Added getTablePrimaryKeyField().
325
326         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
327         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
328         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
329         Adapted.
330
331 2012-07-22  Murray Cumming  <murrayc@murrayc.com>
332
333         Rename the servlet.
334
335         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
336         * src/main/java/org/glom/web/client/OnlineGlomService.java:
337         * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
338         to gwtGlom, which is more appropriate.
339         This servlet name does not seem to be visible to the client side anyway.
340
341 2012-07-22  Murray Cumming  <murrayc@murrayc.com>
342
343         Tests: Make the imports of assert*() consistent.
344
345         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
346         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
347         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
348         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
349         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
350         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
351         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
352         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
353         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
354         * src/test/java/org/glom/web/shared/DataItemTest.java:
355         Just do
356         import static org.junit.Assert.*;
357         which seems fairly common.
358
359 1.21.10 (unstable):
360
361 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
362
363         tests: Move a test that needs a database connection.
364
365         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
366         Move testGetListViewLayoutGroup() to
367         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
368         because it needs a database connection.
369
370 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
371
372         tests: Use @BeforeClass on tearDown().
373
374         * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
375         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
376         This avoids leaking a postgres process in SelfHostExampleTest.
377
378 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
379
380         tests: Test translations more.
381
382         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
383         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
384         Test titles in the non-default locale.
385
386 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
387
388         tests: Add SelfHostConfiguredDocumentTest
389  
390         * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the 
391         username and password, for use by ConfiguredDocument.
392         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java: 
393         This tests some of the ConfiguredDocument API that requires a database connection.
394
395 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
396
397         Document: Load title translations and test them.
398
399         * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
400         of titles. I am surprised that we do not do this yet.
401         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
402         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
403         Test translations more.
404
405 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
406
407         Set JDBC timeouts.
408
409         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
410         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
411         Set the timeout here too.
412
413 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
414
415         tests: ConfiguredDocumentTest: Make this pass.
416
417         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
418         Disable tests that need a database connection.
419
420 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
421
422         Use Java 1.7 instead of Java 1.6.
423
424         * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
425         to do this twice, at least for Eclipse.
426         This seems OK because it is the current version.
427
428 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
429
430         Some error checking.
431
432         * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
433         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
434         Avoid using a null Connection.
435
436 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
437
438         tests: Add a ConfiguredDocument test.
439
440         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
441         Add this test.
442
443 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
444
445         LayoutItemFIeld: getName(): Use the Field if it is set.
446
447         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
448         getName(): If the full field details have been set, return its name, so that
449         callers do not need to set the name separately.
450         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
451         testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
452         so we can count the rows.
453
454 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
455
456         tests: SelfHoster: Test SqlUtils too.
457
458         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
459         Retrieve some data and check it too, as in the regular Glom
460         test_selfhosting_new_from_example.cc test.
461         * src/test/java/org/glom/web/server/SelfHoster.java:
462         createConnection(): Make this public.
463
464 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
465
466         tests: SelfHoster: createConnection(): Do not warn about expected failures.
467         
468         Let the caller say if the connection is expected to fail, to avoid 
469         irrelevant error output.
470
471 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
472
473         tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
474         
475         * src/test/java/org/glom/web/server/SelfHoster.java:
476         createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
477         due to the inevitable need to retry the connection while the database server
478         starts.
479
480 2012-07-20  Murray Cumming  <murrayc@murray.com>
481
482         tests: SelfHoster: createConnection(): Set a timeout.
483
484         * src/test/java/org/glom/web/server/SelfHoster.java:
485         createConnection(): Use setLoginTimeout() because it otherwise seems to take
486         ages to actually return when it fails.
487
488 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
489
490         tests: SelfHoster: selfHost(): Close the test connection.
491
492         * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
493         When we check that the connection works, close the connection. This seems
494         to not be closed automatically otherwise.
495
496 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
497
498         Use slf4j-simple to see JDBC errors.
499
500         * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
501
502 2012-07-19  Murray Cumming  <murrayc@murrayc.com>
503
504         SelfHoster.discoverFirstFreePort(): Close the socket.
505
506         * src/test/java/org/glom/web/server/SelfHoster.java:
507         discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
508
509 2012-07-19  Murray Cumming  <murrayc@murrayc.com>
510
511         Avoid another code warning in Eclipse Juno.
512
513         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
514         Do instanceof checks on the FileUtils.listFiles() result and its 
515         items.
516
517 2012-07-13  Murray Cumming  <murrayc@murrayc.com>
518
519         Avoid some code warnings in Eclipse Juno
520
521         * src/main/java/org/glom/web/server/libglom/Document.java:
522         getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
523         * src/test/java/org/glom/web/server/SelfHoster.java
524         createTextFile(): Make sure that the FileOutputStream is closed.
525
526 2012-06-22  Murray Cumming  <murrayc@murrayc.com>
527
528         Added OnlineGlomPropertiesTest.
529
530         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
531         Make sure we never return a null string.
532         * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
533         Added tests of the OnlineGlomProperties API, using our sample file.
534
535 2012-06-20  Murray Cumming  <murrayc@murrayc.com>
536
537         Make OnlineGlomProperties be a normal class.
538
539         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
540         Move OnlineGlomProperties into its own file to be a regular class:
541         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
542         This makes testing simpler.
543
544 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
545
546         OnlineGlomServiceImpl.init(): Move some code into a new method.
547
548         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
549         Create addDocument().
550
551 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
552
553         OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
554
555         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
556         OnlineGlomProperties.getKey(): Make this more robust by moving the
557         check for *.*.filename to here.
558
559 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
560
561         OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
562
563         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
564         init(): Move knowledge of the config file format into the 
565         OnlineGlomProperties inner class.
566
567 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
568
569         SelfHostExampleTest: Make sure we cleanup on failure.
570
571         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
572         the use of cleanup() to a tearDown() JUnit method.
573
574 1.21.9.3:
575
576 2012-06-12  Murray Cumming  <murrayc@murrayc.com>
577
578         ConfiguredDocument: Add a primary key to portals at least once.
579
580         * src/main/java/org/glom/web/server/ConfiguredDocument.java
581         updatePortalsExtras): Fix a typo so that we add the primary key
582         column at least once.
583         This is a fix for the previous commit:
584         ConfiguredDocument: Do not add a primary key to portals each time.
585
586 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
587
588         SelfHoster: Avoid some compiler warnings.
589
590         * src/test/java/org/glom/web/server/SelfHoster.java
591         executeCommandLineAndWait():
592         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
593         the now-unused streams for stdout and stderr from the command Processes.
594         These are not used because readln() hangs while waiting for a new line,
595         where there may be no next line. The commented out code is still there
596         to help us figure out how to do this properly.
597
598 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
599
600         LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
601
602         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
603         Make this actually test the cloning again, though it is not very useful
604         now that we do not use the part that had a problem with cloning before.
605
606 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
607
608         SelfHoster: Keep trying pg_ctl after starting postgres.
609
610         * src/test/java/org/glom/web/server/SelfHoster.java
611         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
612         Try pg_ctl repeatedly (for ever) until it succeeds, as we do in 
613         regular Glom. This seems mad but it seems to work because the first
614         command would fail if pg_ctl would eventually fail.
615
616 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
617
618         SelfHoster: Wait until the server is really ready.
619
620         * src/test/java/org/glom/web/server/SelfHoster.java
621         selfHost(): Attempt the connection after starting the server, retrying 
622         a few times if necessary, so that the server is really ready already when
623         we return from this method.
624         The regular Glom code does this too because pg_ctl reports success too soon.
625
626 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
627
628         ConfiguredDocument: Do not add a primary key to portals each time.
629
630         * src/main/java/org/glom/web/server/ConfiguredDocument.java
631         updatePortalsExtras(): Only add an extra primary key field if there is 
632         none, to avoid adding one each time we retrieve the details layout from the
633         layouts cache.
634         This should fix bug #676986 (Ben Konrath) 
635
636 2012-05-25  Murray Cumming  <murrayc@murrayc.com>
637
638         Document.load(): Support version 7 documents. 
639
640         * src/main/java/org/glom/web/server/libglom/Document.java: Load the 
641         database_title attribute if the title attribute is not there.
642         Bug #676737
643
644 2012-05-24  Ben Konrath  <ben@bagu.org>
645
646         Add configuration for auto-generating mvn:i18n from with Eclipse.
647
648         * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
649
650 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
651
652         Update translations, adding French.
653
654         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
655         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
656         Add a French translation, using the translation from Glom.
657
658         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
659         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
660         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
661         Update these based on the translations from Glom.
662
663 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
664
665         SelfHoster: Add some debug println messages to help when things fail.
666
667         * src/test/java/org/glom/web/server/SelfHoster.java: Add several
668         System.out.println() lines.
669
670 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
671
672         Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
673
674         * src/test/java/org/glom/web/server/SelfHoster.java:
675         getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for 
676         instance) instead of just /usr/bin (as on Fedora). Check the result when 
677         using this method.
678
679 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
680
681         Remove LayoutItemPortal.get/setNavigationTable().
682         
683         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
684         Remove get/setNavigationTable(), which is only a cache, because it is not
685         used, and does not need to be used, because that decision should be made on
686         the server.
687         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
688         updatePortalsExtras():
689         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
690         getNavigationRecord():
691         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
692         Adapted.
693
694 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
695
696         Initial self-hosting for tests.
697
698         * pom.xml: Change the scope for log4j, to hopefully make it 
699         available to the test code which uses it indirectly via jOOQ.
700         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
701         self-hosting, though we only use it for testing.
702
703         * src/main/java/org/glom/web/server/libglom/Document.java:
704         example rows: Use a map instead of a list for each row of values,
705         so we know what field they are for, instead of relying on the sequence
706         being correct. This is not very efficient, but it does not really need 
707         to be.
708         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
709         testReadTableExampleRows(): Adapted.
710
711         * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
712         that returns an Object, for generic use. Note that Object seems to be 
713         the implicit base even of double.
714         * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
715         for use in CREATE TABLE SQL queries.
716         * src/test/java/org/glom/web/server/SelfHoster.java: Add this class 
717         to do self-hosting of PostgreSQL databases via its command-line 
718         utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
719         backends/postgres_self.cc. This is incomplete - it needs more 
720         warnings about failures and it needs to clean up properly when things
721         fail.
722         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple 
723         test of this new class.
724
725 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
726
727         Document: loading example data: Handle exceptions.
728
729         * src/main/java/org/glom/web/server/libglom/Document.java:
730         DateFormat.parse() and Double.valueOf() can throw exceptions, though
731         Eclipse did not warn about that.
732
733 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
734
735         Document: load(), save(): Handle the example rows.
736
737         * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate() 
738         and get/setImage().
739         * src/main/java/org/glom/web/server/libglom/Document.java:
740         load(), save(): Load and save the example rows, though the date, time
741         and image types are not handled properly yet.
742         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
743         Add testReadTableExampleRows() just to check that something is read.
744
745 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
746
747         Document: Add save().
748
749         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
750         Added getTranslationsMap() for use while saving.
751         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
752         Adedd getUseDefaultFormatting() for use while saving.
753         * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
754         and several private methods that it uses.
755
756         This will be useful while testing via self-hosting.
757         It is not complete, but should be complete enough for testing.
758
759 2012-05-17  Murray Cumming  <murrayc@murrayc.com>
760
761         OnlineGlomService: Simplify the getList/RelatedViewData() methods.
762
763         * src/main/java/org/glom/web/client/OnlineGlomService.java
764         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
765         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
766         Remove getSortedListViewData() and getSortedRelatedListData(), adding
767         the sort column index and ascending bool to the regular method.
768         Instead, a sort column index of -1 now means no sort.
769         This is less explicit, but it's fairly simple, reduces the amount of 
770         code, and makes the OnlineGlomService API slightly smaller.
771         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
772         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
773         getDataProvider():
774         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
775         getListViewData(), getRelatedListData():
776         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
777         getListViewData(), getRelatedListData():
778         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
779         getListData():
780         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
781         getData():
782         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
783         getData(): Adapted.
784
785 1.21.9.2:
786
787 2012-05-16  Murray Cumming  <murrayc@murrayc.com>
788
789         Use translations for top-level groups too.
790
791         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
792         updateTitlesForLocale(): Use the translation for the group 
793         as well as for child items.
794
795 1.21.9.1:
796
797 Just recompiled to fix a problem in the released .tar.gz file.
798
799 1.21.9:
800
801 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
802
803         Corrections to navigation to related records.
804         
805         * src/main/java/org/glom/web/client/OnlineGlomService.java:
806         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
807         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
808         getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
809         getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a 
810         relationship name, because the relationship name is not necessarily unique 
811         on the layout.
812         TOOD: This is inefficient, because it passes the whole list of 
813         child field items back to the server, but it is more correct, and happens
814         to fix a bug with the primary key being lost after a few navigations.
815         There is probably a chance to make this more efficient anyway in some 
816         more basic way.
817         
818         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
819         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
820         * src/main/java/org/glom/web/server/ConfiguredDocument.java
821         * src/main/java/org/glom/web/server/database/DBAccess.java
822         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
823         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
824         Adapted.
825
826 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
827
828         Fix the use of translations.
829
830         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
831         Add updateTitlesForLocale().
832         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
833         Call it to discard unwanted translations and to make getTitle() return
834         the wanted translation wihout the need for the client code to specify a locale.
835         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
836         getTitle(): Fallback to the original title, as libglom does.
837
838 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
839
840         Document: Correctly report the number of available translation locales.
841
842         * src/main/java/org/glom/web/server/libglom/Document.java: Fill
843         the available locale IDs list.
844         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
845         testLocales: Test this.
846
847 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
848
849         SqlUtils: Use camelCase.
850
851         * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
852         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
853         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
854         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
855         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
856         * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
857
858 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
859
860         Use jOOQ's tableByName() and fieldByName.
861
862         * pom.xml: Use jOOQ 2.3.1 to get the new API.
863         * src/main/java/org/glom/web/server/SqlUtils.java:
864         build_sql_select_step_with_where_clause(), .createField(),
865         builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
866         so we can get correct quoting and escaping. Thanks to Lukas Eder for 
867         adding this, and other things, to jOOQ.
868
869 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
870
871         SqlUtils: Remove the Connection parameters.
872
873         * src/main/java/org/glom/web/server/SqlUtils.java:
874         build_sql_select_with_key(), build_sql_select_with_where_clause(),
875         createSelect(), build_sql_select_step_with_where_clause(),
876         build_sql_count_select_with_where_clause(),
877         build_sql_select_count_rows(): Remove the Connection parameter because
878         jOOQ does not actually need a connectionwhen it is just used to build 
879         a SQL string:
880         https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
881
882         * src/main/java/org/glom/web/server/ReportGenerator.java:
883         generateReport():
884         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
885         getData():
886         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
887         Constructor, getListData(), getResultSizeOfSQLQuery():
888         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
889         getSelectQuery(), getCountQuery():
890         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
891         getSelectQuery(), getCountQuery():
892         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
893         getNavigationRecord(): Adapted.
894
895 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
896
897         Fix quick find.
898
899         * src/main/java/org/glom/web/server/SqlUtils.java:
900         get_find_where_clause_quick(): Use a comparison of 
901         lowercase values, instead of a simple equals. Regular Glom
902         uses the PostgreSQL ILIKE operator but jOOQ does not 
903         support that just yet, though it will soon.
904
905 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
906
907         TableToViewDetails: Use a real serialization ID.
908
909         * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
910         Though this does not fix the serialization problem.
911
912 2012-05-12  Murray Cumming  <murrayc@murrayc.com>
913
914         Added LayoutItemPortalDeepCloneTest.
915
916 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
917
918         Make navigation work again.
919
920         * src/main/java/org/glom/web/server/libglom/Document.java:
921         Add getLayoutItemFieldShouldHaveNavigation().
922         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
923         Replace get/setAddNavigation() with the partly-existing 
924         get/setNavigationTableName(), with an empty string being no navigation,
925         because this is simpler. Use the new 
926         Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
927         
928         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
929         Add updateFieldsExtras() and call setNavigationTableName in it.
930         getDetailsLayoutGroup(), 
931         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
932         createLayout(): Adapted.
933         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
934         Constructor: Adapted.
935
936         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
937         Replace get/setAddNavigation() with get/setNavigation(), returning a
938         TableToViewDetails class with both the table name and UsesRelationship,
939         because both are need. The previous code used java-libglom's output 
940         variable (strangely, via sharedptr) to return both, but we cannot really
941         do that in Java.
942         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
943         getNavigationRecord(): Adapt. However, we cannot actually use the cache
944         here because it somehow gets set to null during deepCopy(). I must test this.
945         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
946         testGetSuitableTableToViewDetails(): Adapted.
947         
948         TODO: Find out why deepClone() is not quite working.
949         
950 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
951
952         DBAccess: Simplify the retrievel of full field details.
953
954         * src/main/java/org/glom/web/server/database/DBAccess.java
955         getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
956         because the Document loading should have done this.
957
958 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
959
960         Document: Correct loading of doubly-related layout fields.
961
962         * src/main/java/org/glom/web/server/libglom/Document.java:
963         loadUsesRelationship(): Actually set the related relationship, instead
964         of only setting it if it's not found.
965
966 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
967
968         Replace all appearances of Colour with color.
969
970         Because US English is dominant.
971
972 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
973
974         Use colors in HTML format, solving a warning about an unused function.
975
976         * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
977         * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
978         Add *asHTMLColor() versions of methods.
979         TODO: However, we should create and cache the results on the server.
980         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
981         * src/main/java/org/glom/web/client/ui/list/ListTable.java
982         * src/main/java/org/glom/web/server/ConfiguredDocument.java
983         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
984         Use the asHTMLcolor() versions.
985
986 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
987
988         ListViewTable: Constructor: Take the table name as a parameter.
989
990         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
991         Constructor: Take the tableName, and set the member variable, because
992         we use it here.
993         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
994         setCellTable(): Pass the table name.
995         This makes navigation to non-default tables work again. I don't know 
996         why it worked before in the master branch.
997
998 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
999
1000         ConfiguredDocument: Restore correct addition of hidden primary key items.
1001
1002         * src/main/java/org/glom/web/client/ui/list/ListTable.java
1003         (ListTable.createCellTable): Uncomment out the check for the hidden
1004         primary key.
1005         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
1006         add primary key items for top-level lists and portals, as before, 
1007         instead of adding them to each group.
1008         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
1009         Actually implement the extra methods such as setHiddenPrimaryKey() and
1010         comment that these are used only for top-level list groups and in portals.
1011         This strangeness suggests even more that this should not be squeezed
1012         into the LayoutGroup class.
1013
1014 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
1015
1016         Fix Formatting loading.
1017
1018         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
1019         getFormattingUsed(): Remove the duplicate Formatting member variable
1020         in favour of the one from the base class.
1021         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
1022         Initialize a new Formatting instead of using null by default, so we 
1023         have some defaults, instead of having to initialize one later just to 
1024         get the same defaults. This also makes loading of formatting from the
1025         document work, because that expected a non-null.
1026
1027 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
1028
1029         RelatedListTable: Make sure that the tableName is set.
1030
1031         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1032         Constructor: Take the tableName so it is available later. Otherwise, 
1033         the server assumes that we mean the default table and cannot find the
1034         relationship in it.
1035         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1036         setData(): Pass the tableName to the RelatedListTable constructor.
1037
1038 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
1039
1040         Add some checks.
1041
1042         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1043         RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
1044         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1045         getDataProvider():
1046         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1047         addColumn():
1048         * src/main/java/org/glom/web/server/database/DBAccess.java:
1049         convertResultSetToDTO(), getPortal():
1050         * src/main/java/org/glom/web/server/database/ListDBAccess.java
1051         getListData():
1052         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1053         Add checks for null objects and out of range access, with log messages to
1054         give hints so we can fix these properly.
1055
1056 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
1057
1058         Portals: some corrections.
1059
1060         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1061         setData():
1062         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1063         constructor: Use getRelationshipNameUsed() instead of getName(), because
1064         that is what is meant.
1065         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1066         getFromField(): Fix a typo, to get the field name, not the table name.
1067         * src/main/java/org/glom/web/server/database/DBAccess.java:
1068         getPortal(): Fix a typo that stopped this from working.
1069
1070 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
1071
1072         LayoutItemPortal: Also override getTitleOriginal().
1073
1074         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1075         This lets the base getTitle() with no parameters work.
1076         TODO: Test this properly.
1077
1078 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1079
1080         LayoutItemPortal: getTitle*(): Use the relationship title.
1081
1082 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1083
1084         LayoutItemField: Fix loading of custom titles.
1085
1086         * src/main/java/org/glom/web/server/libglom/Document.java
1087         loadDataLayoutItemField(): The title, if any, instead of the field 
1088         title, is stored in a title_custom node. Load it from there.
1089         * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
1090         class.
1091         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
1092         Add getCustomTitle() and use it, instead of super.getTitle*(), in the
1093         getTitle*() overrides.
1094         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1095         Adapt.
1096
1097 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1098
1099         LayoutItemField: Fall back to field titles, so some are really shown.
1100
1101         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
1102         Override getTitleOriginal() and getTitle(), as in java-libglom.
1103         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1104         Test this behaviour.
1105
1106 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1107
1108         Correct use of setExpectedResultSize().
1109
1110         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1111         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
1112         Use setExpectedResultSize only on top-level groups (for instance, the
1113         list layout) or on child portals (in details views).
1114         Use the correct table name for portals to avoid SQL errors.
1115         Update the expected counts when returning cached layouts.
1116
1117 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1118
1119         Document: Interpret no group column count as 1.
1120
1121         * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
1122         default, though we now check for this in the UI code anyway.
1123
1124 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1125
1126         More null checks.
1127
1128 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1129
1130         Translatable: Use Hashmap instead of Treemap because GWT supports it.
1131
1132         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
1133         The use of Treemap lead to this error from async methods, with no 
1134         further clue:
1135         "The response could not be deserialized"
1136
1137 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1138
1139         OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
1140
1141         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary 
1142         when using the Google -> GWT Compile, or 
1143         g toolbar button -> GWT Compile Project... feature in Eclipse.
1144
1145 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1146
1147         ListTable.addColumn(): Protect against a null Formatting.
1148
1149         * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
1150         Create a default Formatting if it is null, because that is the simplest
1151         way to do this.
1152
1153 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1154
1155         ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
1156
1157         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1158         updateLayoutGroup(): Check that the field is not null.
1159
1160 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1161
1162         ListViewImpl: Protected against a bad cast error.
1163
1164         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1165         onEnterKeyDown(): Do not cast without an instanceof check.
1166
1167 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1168
1169         ListTable: Protect against an out of range error.
1170
1171         * src/main/java/org/glom/web/client/ui/list/ListTable.java
1172         createCellTable(): This is unlikely, but can happen while debugging.
1173
1174 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1175
1176         AsyncMessage onFailure() callbacks: Log the exception message.
1177
1178         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1179         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1180         * src/main/java/org/glom/web/client/activity/ListActivity.java:
1181         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1182         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1183         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1184         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1185         These are useful clues when something is wrong.
1186
1187 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1188
1189         ConfiguredDocument: Avoid a null dereference.
1190
1191         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1192         TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and 
1193         details maps are created.
1194
1195 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1196
1197         Document: Correct the port number parsing.
1198
1199         * src/main/java/org/glom/web/server/libglom/Document.java:
1200         This lets us actually connect to the database and show the document.
1201
1202 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1203
1204         Fix mvn gwt:test
1205
1206         * pom.xml: Use htmlunit mode for gwt:test, because the default demands
1207         user-interaction, asking us to load a temporary URL in a browser.s
1208         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
1209         which is apparently necessary for testing the service. See the comment.
1210         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java: 
1211         Show the exception, if any. This is how I saw the 404 in the HTML in 
1212         the exception.
1213
1214 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1215
1216         DocumentTest: Move the .glom files into the resources directory.
1217
1218         * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1219         URI via getResource().
1220
1221 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1222
1223         Document: Remove the FieldIdentifies inner class.
1224
1225         * src/main/java/org/glom/web/server/libglom/Document.java: We only
1226         use the Relationship (though the same function in libglom is maybe
1227         used in other ways) and so this removes a compiler warning.
1228
1229 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1230
1231         Document.load() Remove the error code parameter.
1232
1233         * src/main/java/org/glom/web/server/libglom/Document.java: load():
1234         Remove the parameter. We do not set it yet and it could never have
1235         worked as an output parameter (though maybe it did in java-libglom).
1236         We could use an exception if we really want the failure reason.
1237         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1238         init():
1239         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1240         setUp(), testGetSuitableTableToViewDetails(): Adapt.
1241
1242 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1243
1244         Make some inner classes static.
1245
1246         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1247         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1248         * src/main/java/org/glom/web/server/ReportGenerator.java
1249         * src/main/java/org/glom/web/server/libglom/Document.java
1250         Make all inner classes static that can be static.
1251
1252 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1253
1254         OnlineGlomServiceImpl: Do not load and check for java-libglom.
1255
1256         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1257         init(): We do not use java-libglom any more.
1258
1259 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1260
1261         Remove mentions of java-libglom.
1262
1263         * README: Remove mention of java-libglom, because it no longer needed.
1264         * utils/build-onlineglom-war.sh:
1265         * utils/check-and-recover-tomcat.py:
1266         * utils/install-onlineglom-war.sh: Remove these as they are no longer
1267         useful. Building is now far easier, with no need for jhbuild.
1268
1269 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1270
1271         Fix the build (mvn package)
1272
1273         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1274         (LayoutGroup): Make the LayoutItemList inner class static and protected.
1275         Otherwise the GWT Java->Javascript compilation fails with just this
1276         error, during mvn package or when attempting to view in a browser, 
1277         in the GWT developer mode in Eclipse.
1278
1279         [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1280         [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1281         [INFO] Compiling module org.glom.web.OnlineGlom
1282         [INFO]    [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1283         [INFO]       [ERROR] Line 46:  Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1284         [INFO]    Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1285         [INFO]       [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1286         [INFO]          [WARN] org.glom.web.client.OnlineGlomService_Proxy
1287         [INFO]    [ERROR] Cannot proceed due to previous errors
1288
1289         It has taken me 2 days to find out what was causing that. After reducing
1290         the code, the compiler eventually showed me the full error message.
1291
1292 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1293
1294         ConfiguredDocument: Cache the cloned and stripped layouts.
1295
1296         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1297         getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1298         layout in a map, so we can retrieve it again without rebuilding it.
1299
1300 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1301
1302         UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1303
1304 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1305
1306         libglom classes: Implement some auto-generated emthods.
1307
1308 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1309
1310         Add GwtTestOnlineGlomService.
1311
1312         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1313         However, this (and the other GwtTest*) does not seem to run during 
1314         mvn test. 
1315
1316 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1317
1318         Remove use of unsupported features from client code.
1319
1320         * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1321         * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1322         * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1323         Use our client version of StringUtils instead of the apache commons one.
1324         
1325         However, the GWT Javascript compliation still fails.
1326
1327 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
1328
1329         Add a Field class and implement some loading of it in Document.
1330
1331 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
1332
1333         Initial Document loading implementation, instead of libglom.
1334
1335         * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1336         and Translatable classes, and adapt the rest of the code to use them.
1337         However, this is still missing Layout and Field classes and loading.
1338
1339 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
1340
1341         Use of jOOQ: Move Field creation into a utility method.
1342
1343         * src/main/java/org/glom/web/server/SqlUtils.java:
1344         This lets us improve it more easily.
1345
1346 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
1347
1348         Use of jOOQ: Improve the code to COUNT a sub-select.
1349
1350         * src/main/java/org/glom/web/server/SqlUtils.java:
1351         Move initial query creation into 
1352         build_sql_select_step_with_where_clause().
1353         build_sql_select_count_rows(): Use the jOOQ API instead of
1354         concatentating text, because a jOOQ Select*Step is a TableLike,
1355         which is what from() takes.
1356
1357 2012-04-23  Murray Cumming  <murrayc@murrayc.com>
1358
1359         Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1360
1361         * pom.xml: Depend on jooq.
1362         * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1363         methods with jOOQ, based on the C++ implementations in libglom,
1364         with some changes to the logic required by jooQ.
1365         Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1366         where clause.
1367         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1368         * src/main/java/org/glom/web/server/ReportGenerator.java:
1369         * src/main/java/org/glom/web/server/SqlUtils.java:
1370         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1371         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1372         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1373         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1374         * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1375         Adapt. In particular, the SqlUtils methods now need to take a Connection,
1376         because jOOQ needs that, though it seems unnecessary.
1377
1378         This is not quite finished. Ideally jOOQ would help us to build 
1379         table_name.field_name names, quoting and escaping them properly.
1380         See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1381
1382 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1383
1384         Move use of Glom.build_sql*() into a new SqlUtils class.
1385
1386         * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1387         to wrap Glom.build_sql*(). The parameter types are still Glom one,
1388         but this will make it easier to start using something other than 
1389         libglom or SqlBuilder.
1390
1391 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1392
1393         Update the project URL.
1394
1395         * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1396
1397 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1398
1399         Main layout: Use a FlowTable instead of absolute positioning.
1400
1401         * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1402         The RootLayoutPanel is a (extends) AbsolutePanel, so each of its 
1403         child panels/widgets must have an absolute position. But that is annoying, so
1404         this adds a FlowTable and puts the child panels in there.
1405
1406 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1407
1408         GwtTestOnlineGlom: Comment out unused code.
1409
1410         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1411         Eclipse has started to say that some code is unused.
1412
1413 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1414
1415         Update to the latest versions of dependencies.
1416
1417         * pom.xml: Update version numbers of dependencies to the latest
1418         versions.
1419         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1420         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1421         * src/main/java/org/glom/web/server/ReportGenerator.java:
1422         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1423         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1424         * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1425         java:
1426         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1427         Modify the imports where necessary.
1428
1429 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1430
1431         Style: Remove overflow:hidden from searchbox
1432
1433         * src/main/webapp/style.css: Because this pushes the Back To Link
1434         label/link on to the next row, which is then hidden due to the 
1435         hard-coded (in ems) height.
1436
1437 2012-04-20  Murray Cumming  <murrayc@murrayc.com>
1438
1439         Remove some duplicate code.
1440
1441         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1442         getDocumentInfo(): This must have been duplicated during the merge from the
1443         reports branch.
1444
1445 1.21.8.1:
1446
1447 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1448
1449         Reports: Localize the waiting for report message.
1450
1451         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1452         start(): Get the message from the contants.
1453         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1454         Add the string here.
1455         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1456         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1457         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1458         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1459         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1460         Update these files with the English text for newer strings for now.
1461
1462 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1463
1464         Reports: Show a message while waiting for the report.
1465
1466         * src/main/java/org/glom/web/client/ui/ReportView.java
1467         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1468         Add setWaitingText(), to show a message saying that we are 
1469         waiting for the report to be ready.
1470         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1471         start(): Call setWaitingText() before calling the async
1472         report generation.
1473
1474 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1475
1476         ReportGenerator: Specify date and time formats.
1477
1478         * src/main/java/org/glom/web/server/ReportGenerator.java:
1479         createFieldValueElement(): Use the default (and localized)
1480         short formats, though we still need a way to show 4-digit
1481         years without providing the format for every locale.
1482         * src/main/java/org/glom/web/server/database/DBAccess.java:
1483         convertResultSetToDTO(): Use the short formats here too.
1484
1485 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1486
1487         ReportGenerator: Use the correct numeric formatting.
1488
1489         * src/main/java/org/glom/web/server/ReportGenerator.java
1490         createFieldExpression(), createFieldValueElement(): Take the
1491         whole LayoutItem_Field instead of just the field name, so
1492         we have access to the formatting.
1493         createFieldValueElement(): Use JRTextField.setPattern() to
1494         specify the numeric formatting, with the help of a 
1495         regular DecimalFormat.
1496
1497 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1498
1499         ReportGenerator: Avoid showing null for group by titles.
1500
1501         * src/main/java/org/glom/web/server/ReportGenerator.java
1502         generateReport(): Use setBlankWhenNull() on the field title
1503         style too, because this is used for values in group by
1504         sections.
1505
1506 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1507
1508         ReportGenerator: Add a colon to titles in vertical groups.
1509
1510         * src/main/java/org/glom/web/server/ReportGenerator.java
1511         addFieldToDetailBandVertical(): Pass true for the withColon
1512         parameter.
1513
1514 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1515
1516         ReportGenerator: Simplify the code by using Position more.
1517
1518 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1519
1520         Reports: Support vertical groups, roughly.
1521
1522         * src/main/java/org/glom/web/server/ReportGenerator.java:
1523         addToReport(): Rename to addGroupToReport() and, if necessary,
1524         call the new addVerticalGroupToReport() method.
1525         createFieldValueElement(): Let the caller specify the Y position
1526         too.
1527
1528 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1529
1530         Reports: Allow a second report to be shown.
1531
1532         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1533         clear(): Do not remove the HTML widget, which broke the whole layout.
1534
1535 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1536
1537         Locales drop-down: Show that we use English by default.
1538
1539         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1540         fillView(): When we use English, just because that is the default, when
1541         no locale is specified, show that in the Locales drop-down instead of 
1542         just showing the first item.
1543
1544 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1545
1546         Unselect the Report/Locale/Table combo item when appropriate.
1547
1548         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1549         setPlace(): clear reportName if this is not a ReportPlace.
1550         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1551         setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1552         When the provided name is empty, unselect all items, so that none are
1553         indicated. This uses a for loop because I cannot find a single method
1554         to do this.
1555
1556 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1557
1558         Report: Give the user a way to get back to the list.
1559
1560         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1561         start(), setPlace(): Show the Back To List link on reports, and also 
1562         interpret selecting the empty report item as back to list.
1563
1564 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1565
1566         Really show the selected Report name.
1567
1568         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1569         setPlace(): Store the reportName here, if it is that kind of Place.
1570         fillView(): Set the selected Report after filling the list of reports.
1571         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1572         setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1573         null Strings, though we need some way to unselect all ListBox items
1574         in that case.
1575
1576 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1577
1578         ReportGenerator: Try to avoid some problems.
1579
1580         * src/main/java/org/glom/web/server/ReportGenerator.java
1581         addField(): Try to avoid duplicates, and avoid using a null
1582         class type.
1583
1584 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1585
1586         Reports: Use quickFind.
1587
1588         * src/main/java/org/glom/web/client/OnlineGlomService.java;
1589         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1590         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1591         getReportHTML(): Add a quickFind parameter.
1592         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1593         start(): Pass the quickFind parameter.
1594         * src/main/java/org/glom/web/server/ReportGenerator.java
1595         generateReport(): Take a quickFind parameter.
1596
1597 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1598
1599         ReportPlace: Actually use the report name.
1600
1601         * src/main/java/org/glom/web/client/place/ReportPlace.java
1602         getPlace(): Do not assign the report name to the quickfind.
1603
1604 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1605
1606         Show java.library.path when complaining.
1607
1608         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1609         init(): When telling us to check java.library.path, show the
1610         current value.
1611
1612 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1613
1614         ReportGenerator: Do not show nulls.
1615
1616 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1617
1618         ReportGenerator: Make the title font larger.
1619
1620 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1621
1622         ReportGenerator: Put field titles inside groups, if there are groups.
1623
1624 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1625
1626         ReportGenerator: Take the Report itself instead of the name and group.
1627
1628         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1629         Remove getReportLayoutGroup().
1630         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1631         getReportHTML(): Pass the report instead
1632         of its name and layout group.
1633         * src/main/java/org/glom/web/server/ReportGenerator.java
1634         generateReport(): Use the report object to use the title 
1635         instead of the name.
1636
1637 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1638
1639         ReportGenerator: Remove designBand parameters.
1640
1641         * src/main/java/org/glom/web/server/ReportGenerator.java:
1642         Make designBand a class member instead of passing it to all
1643         methods.
1644
1645 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1646
1647         ReportGenerator: Add lines, a bit like in the desktop version.
1648
1649         * src/main/java/org/glom/web/server/ReportGenerator.java
1650         addToReport(): Use JRDesignLine.
1651
1652 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1653
1654         ReportGenerator: Correct the title positions and use some bold style.
1655
1656         * src/main/java/org/glom/web/server/ReportGenerator.java:
1657         Break the code up into reusable functions, correct the placement of 
1658         titles, and use normal/bold styles as in the reports in the desktop 
1659         version.
1660
1661 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1662
1663         ReportGenerator: Add a header band to show the field titles.
1664
1665         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1666         getReportHTML(): Pass the localeId to the ReportGenerator 
1667         constructor.
1668         * src/main/java/org/glom/web/server/ReportGenerator.java
1669         constructor: Take the localeID so we can get translated field
1670         titles.
1671         generateReport(), addToReport(), addFieldToBand(): Add field 
1672         titles in a column header band.
1673
1674 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1675
1676         Reports drop-down list: Some improvement.
1677
1678         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1679         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1680         Adedd setSelectedReport(),
1681         setReportList(): Add a blank line so that the user can select the 
1682         first one.
1683         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1684         start(): Show the current report by calling setSelectedReport().
1685         This does not seem to work yet.
1686
1687 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1688
1689         DetailsActivity, ListActivity: Move some variables into a base class.
1690
1691         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1692         * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1693         * src/main/java/org/glom/web/client/activity/ListActivity.java: Move 
1694         the clientFactory, documentID, tableName and authenticationPopup into
1695         a base class, to avoid duplication.
1696
1697 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1698
1699         Translate the Reports label.
1700
1701         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1702         Get the "Reports" label string from the constants.
1703         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1704         perties: Add Reports to the constants.
1705
1706 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1707
1708         Reports: Implement grouping.
1709
1710         * src/main/java/org/glom/web/server/ReportGenerator.java:
1711         Handle LayoutItem_GroupBy items and try to do the right thing
1712         with JRDesignGroup. It seems to work.
1713
1714 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1715
1716         Actually show some data with JasperReports.
1717
1718         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: 
1719         getReportHTML(): Move most code into a ReportGenerator class.
1720         * src/main/java/org/glom/web/server/ReportGenerator.java:
1721         Recurse into sub-groups, adding fields to the JasperDesign's details
1722         band. Note that we must set an arbitrary width and height, or it just
1723         will not show any data.
1724
1725 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1726
1727         Reports Chooser: Show the titles, not the names.
1728
1729         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1730         (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1731         and the names as the values.
1732         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1733         (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1734         group now that we provide the report name, so it should always 
1735         succeed.
1736
1737 2012-02-15  Murray Cumming  <murrayc@murrayc.com>
1738
1739         Depend on jasperreports.
1740
1741         * pom.xml: Add the dependency. My plan is to use this on the 
1742         server side.
1743
1744 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1745
1746         Implement navigation to report places.
1747
1748         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1749         start(): Do not bother to handle all events here.
1750         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1751         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1752         Added getSelectedReport().
1753         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1754         .java: start(): When handling a change to the reports chooser,
1755         call getSelectedReport() and goTo() its ReportPlace.
1756         * src/main/java/org/glom/web/client/ui/ReportView.java
1757         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1758         Added setReportHTML() which puts the html in a gwt HTML widget.
1759         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1760         getReportHTML(): Return "TODO" just to show that this works.
1761
1762 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1763
1764         Make ReportPlace usable.
1765
1766         * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1767         Mention ReportPlace.
1768         * src/main/java/org/glom/web/client/place/ReportPlace.java:
1769         Correct the @prefix annotation.
1770
1771 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1772
1773         OnlineGlomService: Return report HTML rather than the LayoutGroup.
1774
1775         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1776         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1777         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1778         Change getReportLayout() to getReportHMTL() because we will not need to 
1779         parse or render the report layout on the client side.
1780         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1781         getReportLayout(): Return the libglom LayoutGroup type because we will
1782         not need to convert to a shared type, because this will not be used on
1783         the client side.
1784         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1785         Adapted.
1786
1787         Note that there is still no implementation for this.
1788
1789
1790 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1791
1792         Add a (empty) Report Place, View, and Activity.
1793
1794         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1795         Rename to:
1796         * src/main/java/org/glom/web/client/place/HasTablePlace.java
1797         * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1798         this into a superclass:
1799         * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1800         and also use it as the base of this new ReportPlace:
1801         * src/main/java/org/glom/web/client/place/ReportPlace.java
1802
1803         * src/main/java/org/glom/web/client/ui/ReportView.java
1804         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1805         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1806         Add these, containing mostly boiler-plate for now.
1807
1808         * src/main/java/org/glom/web/client/OnlineGlomService.java
1809         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1810         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1811         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1812         Add API to get the LayoutGroup for the report.
1813
1814 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1815
1816         Add and fill a Reports drop-down list box.
1817
1818         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1819         Aded getReports():
1820         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1821         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1822         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1823         Added getReports(document, table, localeID), calling 
1824         ConfiguredDocument.getReports().
1825         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1826         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1827         Added setReportsList() and a list widget.
1828         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1829         .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1830
1831
1832 1.21.8:
1833
1834 2012-04-12  Murray Cumming  <murrayc@murrayc.com>
1835
1836         Translations: Add Esperanto.
1837
1838         * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1839         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1840         properties: Add this translation because someone took the time to make it.
1841
1842 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1843
1844         Adapt to the java-libglom 1.21.7 API. 
1845
1846         * src/main/java/org/glom/web/server/ReportGenerator.java:
1847         addToReport(): get_group_secondary_fields() is now
1848         get_secondary_fields().
1849
1850
1851 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1852
1853         Use the latest java-libglom version.
1854
1855         * pom.xml: Use java-libglom 1.21.7.
1856
1857 2012-03-03  Ben Konrath  <ben@bagu.org>
1858
1859         Display date and time in details view.
1860
1861         https://bugzilla.gnome.org/show_bug.cgi?id=671257
1862
1863         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1864
1865 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1866
1867         Require the latest java-libglom.
1868
1869         * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1870
1871 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1872
1873         ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1874
1875         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1876         ListViewDBAccess.getSelectQuery(): Do not create a where clause for 
1877         an empty quickfind string. I also corrected libglom to create only 
1878         empty where clauses for empty quickfind strings, but this avoids the
1879         need for that fix.
1880
1881 2012-02-24  Ben Konrath  <ben@bagu.org>
1882
1883         Improve the tabs in the Notebook widget.
1884
1885         Bug #670728
1886
1887 2012-01-30  Murray Cumming  <murrayc@murrayc.com>
1888
1889         Translations: Try to translate the strings.
1890
1891         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1892         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1893         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1894         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1895         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1896         Take the Open translation from GTK+'s .po files.
1897         Take the Details translation from Glom's po files.
1898         I have added the other strings to Glom so we can get translations that way:
1899         http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1900
1901 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1902
1903         TableSelectionViewImpl: Put the search label and entry in a div.
1904
1905         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1906         Put the search widgets in a FlowTable so that the CSS can be used to
1907         style them while keeping them together.
1908         * src/main/webapp/style.css: Mention the new div.
1909
1910 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1911
1912         Translate more strings in more locales.
1913
1914         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1915         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1916         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1917         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1918         Translate the "Details" and "Open" string too.
1919
1920         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1921         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1922         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1923         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1924         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1925         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1926         Add these new locales as placeholders though they currently contain English.
1927
1928 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1929
1930         OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1931
1932         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1933         Check the ConfiguredDocument* for null before using it.
1934
1935 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1936
1937         Tell Eclipse about the generated java files.
1938
1939         * .classpath: This lets it find OnlineGlomConstants.java.
1940         It would be nice if Eclipse just used the maven build files.
1941
1942 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1943
1944         Prevent a crash when no locale is specified in the URL.
1945
1946         * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1947         Avoid returning a null string, obtained from 
1948         Window.Location.getParameter(). This caused a crash when it was
1949         later passed to libglom's API.
1950         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1951         init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1952         getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1953         guard against future null strings.
1954
1955 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1956
1957         Use the ?locale= query param instead of the &lang= token param. 
1958
1959         * src/main/java/org/glom/web/client/place/ListPlace.java
1960         * src/main/java/org/glom/web/client/place/DetailsPlace.java
1961         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1962         Remove the lang token key and value.
1963         
1964         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1965         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1966         When the user selects a different locale from the chooser, use 
1967         Window.Location.assign() to change the URL, which then causes a reload.
1968         
1969         * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1970         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1971         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1972         * src/main/java/org/glom/web/client/activity/ListActivity.java
1973         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1974         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1975         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1976         * src/main/java/org/glom/web/client/ui/ListView.java:
1977         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1978
1979         Remove localeID member variables and method/constructor parameters, instead
1980         using Utils.getCurrentLocaleID() when we need a localID to pass to 
1981         OnlineGlomService.
1982
1983 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1984
1985         Internationalize the UI strings.
1986
1987         * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a 
1988         <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1989         * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1990         because it is unused. Messages are apparently strings that can have 
1991         parameters, but we do not need that yet, so Contants will be enough for now.
1992         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1993         to say that we support the en and de locales.
1994         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1995         The original English strings.
1996         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1997         Some German translations of the English strings.
1998         The i18n goal then uses the .properties file to generate an 
1999         OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
2000         returns an implementation that returns the translated strings.
2001         The documentation suggests putting these in src/java/*/client/, but it seems
2002         best to put it in src/resources/*/client/.
2003         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2004         Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
2005         instead of hard-coding them.
2006         Note that we cannot import OnlineGlomConstants because it does not exist yet,
2007         but that does not seem to stop the build, though it confuses Eclipse.
2008         
2009         You can see the translated string by adding ?locale=de to the URL, like so:
2010         http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
2011
2012 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
2013
2014         Improve null/empty String checks. 
2015
2016         * pom.xml: Add a dependency on commons-lang, to use
2017         org.apache.commons.lang.StringUtils.
2018         * src/main/java/org/glom/web/server/ConfiguredDocument.java
2019         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2020         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
2021         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2022         Use StringUtils.isEmpty().
2023
2024         * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
2025         StringUtils class with a static isEmpty() function because we 
2026         cannot use org.apache.commons.lang.StringUtils in client-side
2027         GWT code because it (apparently) cannot be compiled to javascript.
2028         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2029         * src/main/java/org/glom/web/client/activity/ListActivity.java
2030         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
2031         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2032         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2033         * src/main/java/org/glom/web/client/place/ListPlace.java
2034         * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
2035         * src/main/java/org/glom/web/client/ui/cell/TextCell.java
2036         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
2037         * src/main/java/org/glom/web/client/ui/details/Group.java
2038         * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use 
2039         our StringUtils.isEmpty() function.
2040
2041 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
2042
2043         Update to the latest java-libglom API.
2044
2045         * pom.xml: Require java-libglom 1.21.4.
2046         * src/main/java/org/glom/web/server/ConfiguredDocument.java
2047         getDocumentInfo(), getListViewLayoutGroup():
2048         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2049         getDocuments():
2050         * src/main/java/org/glom/web/server/database/DBAccess.java
2051         getFieldsToShowForSQLQueryAddGroup(),
2052         getPrimaryKeyLayoutItemField(): Replace get_database_title()
2053         with either get_database_title_original() or 
2054         get_database_title(localeID).
2055
2056 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
2057
2058         ConfiguredDocument: Avoid a null pointer exception.
2059
2060         * src/main/java/org/glom/web/server/ConfiguredDocument.java
2061         Initialize localeID to "" to avoid returning a null String which 
2062         causes a crash in java-libglom's swing-generated code.
2063
2064 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
2065
2066         Some simple renaming.
2067
2068         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2069         * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
2070         for localeChooser. This seems more appropriate and is less ambiguous 
2071         particularly in the .css file.
2072
2073 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
2074
2075         ConfiguredDocument: Rename the localedID private member variable.
2076
2077 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
2078
2079         Adapt to the latest java-libglom API from git master.
2080
2081         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2082         libglom now uses only Vector instead of List, which uses add() instead of
2083         addLast(). 
2084
2085 2012-01-22  Murray Cumming  <murrayc@murrayc.com>
2086
2087         ConfiguredDocument: Rename the localedID private member variable.
2088
2089 2012-01-20  Murray Cumming  <murrayc@murrayc.com>
2090
2091         Build a source tarball with mvn assembly:single
2092
2093         * assembly.xml: Add this file.
2094         * pom.xml: Use the maven-assembly-plugin and tell it to use 
2095         our assembly.xml file.
2096
2097 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
2098
2099         OnlineGlomServiceImpl: Get .glom files recursively.
2100
2101         * pom.xml: Depend on commons-io from org.apache.commons.
2102         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2103         init(): Use org.apache.commons.io.FileUtils.listFiles() to get the 
2104         files recursively, and with the easier filter for the extension.
2105         Use org.apache.commons.io.FilenameUtils.removeExtension() to 
2106         simplify that code too.
2107
2108 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
2109
2110         README: Mention that you must install java-libglom packages separately.
2111
2112         But then it works, because java-libglom is now in the central maven 
2113         repository.
2114
2115 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2116
2117         locales drop-down: Show the correct selected locale when the URL changes.
2118
2119         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2120         .java: setPlace(): Move some code into fillView().
2121
2122 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2123
2124         locales drop-down: Do not lose the primary key.
2125
2126         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2127         start(): onLocaleChange(): Pass the current primary key value, 
2128         instead of an empty value.
2129
2130 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2131
2132         locales drop-down: Do not lose the drop-down selection.
2133
2134         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2135         .java (TableSelectionActivity.fillView): Set the selected locale
2136         after changing the drop-down items (though we do not really need
2137         to change them just because the locale changes.)
2138
2139 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2140
2141         locales drop-down: Change the tables list when this changes.
2142
2143         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2144         .java: TableSelectionActivity.start(): Move the async table titles
2145         retrieval into a private fillView() method and also call this when 
2146         the chosen locale changes.
2147         Note that the document title is not actually translatable yet, but
2148         that is a problem that I should fix soon in libglom.
2149
2150 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2151
2152         Improve the placement of the locales drop-down.
2153
2154         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2155         Put the title and locales drop-down in a div (gwt.FlowTable).
2156         * src/main/webapp/style.css: Add magic css properties to make this work.
2157         Also remove the left margin from the title so that it lines up with the 
2158         headerbox below it.
2159
2160 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2161
2162         locales selector: Show human-readable locale titles.
2163
2164         * src/main/java/org/glom/web/server/ConfiguredDocument.java
2165         getDocumentInfo(): Use java.util.Locale to show a real title of 
2166         each locale, in the locale's own language.
2167
2168 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
2169
2170         Add a language/locale selector drop-down.
2171
2172         * src/main/java/org/glom/web/shared/DocumentInfo.java:
2173         Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
2174         * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
2175         getDocumentInfo(): Store the available Locales in the DocumentInfo.
2176         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2177         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2178         Add a ListBox to show the available locales. Add getLocaleSelector(),
2179         setLocaleList(), getSelectedLocale(), setSelectedLocale().
2180         * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
2181         * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
2182         java: Add these classes.
2183         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2184         start(): Fill the locales ListBox. Handle its change event, firing a 
2185         LocaleChangeEvent.
2186         setPlace(): Show the selected locale as specified by the URL token.
2187         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2188         * src/main/java/org/glom/web/client/activity/ListActivity.java:
2189         Handle LocaleChangeEvent, going to a new *Place with that locale.
2190
2191         The placement of the ListBox is not pretty, and it currently uses the ID
2192         as a title, instead of "English", "Deutsch", "Espanola", etc, but it 
2193         is a start.
2194
2195
2196 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
2197
2198         Search box: Show the search text from the URL token.
2199
2200         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2201         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2202         Add setQuickFindText().
2203         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2204         .java: setPlace(): Store the queryText if the place is a ListPlace, 
2205         and call TableSelectionView.setQuickFindText().
2206
2207 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
2208
2209         Allow use of translations via, for instance, &lang=de in the URL.
2210
2211         * pom.xml: Use the unstable java-libglom 1.21 version.
2212
2213         * src/main/java/org/glom/web/client/OnlineGlomService.java:
2214         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
2215         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2216         init(): Instead of calling TranslatableItem.set_current_locale() 
2217         (now removed), call ConfiguredDocument.setDefaultLocaleID().
2218         However, this is only for default locales, which are not needed to 
2219         change the locale in the URL.
2220         getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2221         getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2222         getSortedRelatedListData(): Add a localeID parameter, so we can get the 
2223         layout for a particular locale.
2224         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2225         Add get/setDefaultLocaleID().
2226         getDocumentInfo(), getListViewData(), getRelatedListData(),
2227         getDetailsLayoutGroup(), getListViewLayoutGroup(),
2228         createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a 
2229         localeID parameter, so we can get the layout for a particular locale.
2230
2231         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2232         * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2233         * src/main/java/org/glom/web/client/place/ListPlace.java:
2234         Parse and construct a lang parameter too.
2235
2236         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2237         start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2238         passed to subsequent methods and constructors.
2239         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2240         * src/main/java/org/glom/web/client/activity/ListActivity.java:
2241         Store the localeID from the *Place and pass it to other constructors
2242         and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2243
2244         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2245         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2246         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2247         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2248         * src/main/java/org/glom/web/client/ui/ListView.java:
2249         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2250         Take localeID parameters and pass them to subsequent constructors and 
2251         methods, so that the layout is always retrieved for that locale.
2252
2253         This is rather repetitive.
2254
2255         Note that "" means the original (default) locale of the Glom document,
2256         which is usually English.       
2257
2258 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
2259
2260         Documents: Remove final keyword to fix startup configuration.
2261
2262         * src/main/java/org/glom/web/shared/Documents.java: Remove the
2263         final keywords on the private member variables because that breaks
2264         the startup, apparently (there are warnings) because it stops them
2265         from being serialized. I added these in the previous commit.
2266
2267 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
2268
2269         Documents: Add some final keywords.
2270
2271         * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2272         this.
2273
2274 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
2275
2276         OnlineGlomServiceImpl: Add to overview comments.
2277
2278         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2279         Note that this is where all the document are loaded. They are not 
2280         loaded freshly for each page.
2281
2282 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
2283
2284         Add a search box.
2285
2286         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2287         Add a TextBox for the text of a quick find.
2288         Add getQuickFindBox(), to get the widget, and getQuickFindText() to 
2289         get the text.
2290         setBackLink(): Add a String quickFind parameter.
2291         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2292         (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2293         to the base interface, because that is how TableSelectionViewImpl is used.
2294         * src/main/webapp/style.css: Add style for the search box and its label.
2295
2296         * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2297         * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2298         Add these files, based on the existing TableChangeEvent and 
2299         TableChangeEventHandlers.
2300         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2301         start(): Handle QuickFindChangeEvent, passing its quickFind text to
2302         a ListPlace() that the user should be taken to.
2303         * src/main/java/org/glom/web/client/activity/ListActivity.java
2304         start(): Handle it here too and adapt the TableChangeEvent handler to 
2305         pass the extra "" quickFind parameter to ListPlace.
2306         * src/main/java/org/glom/web/client/place/ListPlace.java: 
2307         Constructor: Take an extra String quickFind parameter and store it, 
2308         returning it from a new  getQuickFind() method.
2309         getToken(): Put the quickFind text in the URL token.
2310         getPlace(): Parse the quickFind text from the URL token.
2311         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2312         va: addDocumentLink(): Pass an extra "" quickFind parameter to the 
2313         ListPlace constructor.
2314         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2315         .java: start(): Add a Change handler for the TableSelectionView's
2316         TextBox (via its base HasChangeHandlers interface), firing the new 
2317         QuickFindChangeEvent.
2318         setPlace(): Adapt the call to TableSelectionView.setbackLink(), to 
2319         pass the extra "" quickFind parameter.
2320
2321         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2322         setCellTable(): Add a String quickFind parameter and pass it to 
2323         the ListViewTable() constructor.
2324         * src/main/java/org/glom/web/client/ui/ListView.java: Change 
2325         setCellTable() in the base interface, because that is how ListViewImpl
2326         is used.
2327
2328         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2329         Add a String quickFind member variable.
2330         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2331         Constructor: Add a String quickFind parameter, storing it in the
2332         base ListTable's member variable.
2333         onRangeChanged(): Pass quickFind to the 
2334         OnlineGlomServiceAsync.getSortedListViewData() and 
2335         OnlineGlomServiceAsync.getListViewData() methods.
2336
2337         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2338         getListViewData(), getSortedListViewData(): Add a String quickFind 
2339         parameter, passing it to ConfiguredDocument.getListViewData().
2340         * src/main/java/org/glom/web/client/OnlineGlomService.java:
2341         Change getListViewData(), getSortedListViewData() in the base interface,
2342         because that is how OnlineGlomServiceImpl is used, via this:
2343         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2344         Change getListViewData(), getSortedListViewData() here too.
2345         This class can apparently be used to asynchronously call methods on 
2346         OnlineGlomService, and GWT seems to implement that after recognizing 
2347         just the *Async name convention and the extra AsyncCallback parameters.
2348
2349         * src/main/java/org/glom/web/server/ConfiguredDocument.java
2350         getListViewData(): Add a String quickFind parameter, and pass it to 
2351         ListViewDBAccess.getData().
2352         * src/main/java/org/glom/web/server/database/ListDBAccess.java
2353         getListData(): Add a String quickFind parameter and pass it to 
2354         getSelectQuery().
2355         getSelectQuery(): Add a String quickFind parameter.
2356         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2357         getSelectQuery(): Add a String quickFind parameter and use it with 
2358         Glom.get_find_where_clause_quick() to pass a where_clause to 
2359         Glom.build_sql_select_with_where_clause(), to actually filter the 
2360         list view results.
2361         getData(): Add a String quickFind parameter, passing it to getListData().
2362         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2363         va: getData(): Pass an empty string to getListData() for the 
2364         quickFind parameter.
2365
2366 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
2367
2368         ListTable: Minor change.
2369
2370         * src/main/java/org/glom/web/client/ui/list/ListTable.java
2371         createCellTable(): Make this protected instead of public.
2372
2373 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
2374
2375         Many files: Use final for the parameters and use the @override attribute.
2376
2377 2012-01-22  Ben Konrath <ben@bagu.org>
2378
2379         Add anchor links for single line text that starts with http, ftp and www.
2380
2381         Bug #667269
2382
2383 2012-01-22  Ben Konrath <ben@bagu.org>
2384
2385         Add ellipsis to single line text in details view.
2386
2387         Bug #667269
2388
2389 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
2390
2391         Remove all javadoc author tags.
2392
2393         Because they are awkward and meaningless when many people touch
2394         many files.
2395         See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2396  
2397 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
2398
2399         Revert the COPYING.LESSER to COPYING rename.
2400
2401         Apparently both should be there if it is LGPL.
2402
2403 2012-01-03  Murray Cumming  <murrayc@murrayc.com>
2404
2405         *View: Remove unused imports.
2406
2407         * src/main/java/org/glom/web/client/ui/DetailsView.java:
2408         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2409         * src/main/java/org/glom/web/client/ui/ListView.java:
2410         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2411         Remove unused imports, as suggested by Eclipse.
2412
2413 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2414
2415         Move the *View::Presenter types, and some API into one base View.
2416
2417         * src/main/java/org/glom/web/client/ui/DetailsView.java:
2418         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2419         * src/main/java/org/glom/web/client/ui/ListView.java:
2420         * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2421         Presenter, setPresenter() and clear() into a shared base interface,
2422         to avoid the unnecessary duplicate Presenter types and to more clearly
2423         show how the *Views share the same structure, even if they are not 
2424         used polymorphically.
2425
2426         * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2427         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2428         va:
2429         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2430         * src/main/java/org/glom/web/client/activity/ListActivity.java:
2431         * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2432         ity.java:
2433         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2434         .java: Adapt.
2435
2436         Feel free to revert this if there is a good reason for the duplicate
2437         types.
2438
2439 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2440
2441         OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2442
2443         * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2444         a class member instead of a local variable in the method.
2445         This lets us use it to get the view instances, for use in tests.
2446         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2447         beforeOnlineGlom(): Test some more details of the initial view.
2448         Again, this is not very useful.
2449
2450         To really test gwt-glom we will need to start a local postgresql 
2451         instance with local data, like the Glom tests in C++.
2452
2453 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2454
2455         pom.xml: Mention the LGPL license.
2456
2457         * pom.xml: Add a licenses section.
2458         * COPYING.LESSER: Move this to COPYING, which
2459         previously contained the GPL. But gwt-glom is all LGPL.
2460
2461 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2462
2463         Add project information to README and pom.xml.
2464
2465         * README: Add a brief description and mention some mvn
2466         commands.
2467         * pom.xml: This extra information shows up in mvn site
2468         generated pages.
2469
2470 2011-01-02  Murray Cumming  <murrayc@murrayc.com>
2471
2472         Use the latest java-libglom version.
2473
2474         * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2475
2476 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2477
2478         GwtTestOnlineGlom: Test a little more.
2479
2480         * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2481         protected rather than private, as suggested by the gwt-test-utils
2482         maintianer here:
2483         http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2484         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2485         Test the initial visibility of the panels.
2486
2487         However, this is not a very useful test.
2488         And I wonder how we should generally test using this idea for an
2489         activity/places app like ours where the real changes happen implicitly
2490         based on the history token/URL.
2491
2492 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2493
2494         Slight modification to *Mapper comments.
2495
2496         * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2497         (DataActivityMapper)
2498         * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2499         pper.java
2500         * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2501         r.java
2502         Remove comments mentioning GIN because they are just copied from 
2503         the example code and are apparently not helpful:
2504         http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2505         Also change the mention of a class that is only in the example code.
2506
2507 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2508
2509         GwtTestOnlineGlom test: Minor changes.
2510
2511         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2512         Avoid the long qualified class name and modify the comment 
2513         because it is now obvious to me that the mocked class is the only
2514         custom one created via GWT.create().
2515
2516 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2517
2518         Tests: Added the beginnings of a test using gwt-test-utils.
2519
2520         * pom.xml: Add dependencies on gwt-test-utils and easymock.
2521         * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2522         which tells gwt-test-utils what class will be tested.
2523         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2524         Add a simple (but empty) test case. One class, used by the OnlineGlom
2525         class, is mocked so that it can be created. However, I am not sure 
2526         why only this class needs to be mocked.
2527
2528         Note that mockito seems more popular, and clearer, than easymock,
2529         but I have not got that working yet. It might be a matter of the 
2530         mockito version.
2531
2532         This test is run during mvn integration-test.
2533
2534 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2535
2536         Tests: Use junit4-style syntax instead of junit3-style.
2537
2538         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2539         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2540         * src/test/java/org/glom/web/shared/DataItemTest.java:
2541         Use the @Test annotation rather than relying on the test*() prefix.
2542         Also no longer implement TestCase, to avoid triggering support for 
2543         the junit3-way, which stops the annotations from working.
2544         Change the imports from import junit.framework.* to 
2545         import org.junit.*, which is apparently the new way.
2546
2547 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2548
2549         Added a test for ListPlace token parsing and creation.
2550
2551         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2552         This is much the same as DetailsPlaceTest.
2553
2554         I wonder how we could test the other parts of the *Place API.
2555
2556 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2557
2558         DetailsPlace test: Also test getToken() and recreation via getPlace().
2559
2560         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2561         testGetPlaceParameters(): Get the tokens from the DetailsPlace and 
2562         recreate it, testing the recreated DetailsPlace for the same parameter
2563         values.
2564
2565 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2566
2567         Use the surefire-report plugin.
2568
2569         * pom.xml: This generates a HTML report about the tests in 
2570         target/site/surefire-report.html
2571         when you do mvn surefire-report:report. It seems to be popular/normal.
2572
2573 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2574
2575         Added a test for DetailsPlace.
2576
2577         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2578         Test the getPlace() token parsing.
2579
2580 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2581
2582         Added a first unit test.
2583
2584         * pom.xml: Add a test goal, and a dependency on junit in that scope.
2585         * src/test/java/org/glom/web/shared/DataItemTest.java:
2586         This is a silly test but it is just to get things started. Note that
2587         maven/junit finds the test because it looks in src/test by default.
2588
2589 2011-12-22  Ben Konrath  <ben@bagu.org>
2590
2591         Change charsetName to "UTF-8" when replacing line breaks.
2592
2593         JavaScript requires the charsetName to be "UTF-8". CharsetName values
2594         that work in Java (such as "UTF8") will not work when compiled to
2595         JavaScript.
2596
2597         This fixes a problem with multi-line details view fields that have hard
2598         line breaks. The "License Text" field on this page demonstrates the
2599         problem:
2600
2601         http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2602
2603         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2604
2605 2011-12-22  Ben Konrath  <ben@bagu.org>
2606
2607         Fix another bug with related list navigation.
2608
2609         I've tested all the navigation buttons in all of the related lists
2610         so things should be good now.
2611
2612         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2613
2614 2011-12-22  Ben Konrath  <ben@bagu.org>
2615
2616         Fix a crasher when refreshing the list view with the default table.
2617
2618         This crash will also happen when loading the list view with the default
2619         table from a link or bookmark.
2620
2621         * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2622         to the main document selection page when the document id hasn't been
2623         set.
2624         * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2625         the main document selection page when the document id hasn't been
2626         set.
2627         * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2628         values for the details place when the document id hasn't been set.
2629         * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2630         values for the list place when the document id hasn't been set.
2631
2632 2011-12-21  Ben Konrath  <ben@bagu.org>
2633
2634         Protect against NPE when glom.document.locale is not in config.
2635
2636         This patch protects against an NPE when glom.document.locale is not in
2637         the config file. This NPE will also happen if glom.document.locale is
2638         commented out.
2639
2640         The patch also updates the error message to display the class name when
2641         the getMessage() returns null. This was happening when the NPE was
2642         thrown and I had "Configuration Error: null". If an NPE is encountered
2643         with this patch, "Configuration Error: NullPointerException " will be
2644         displayed.
2645
2646         This commit closes this bug:
2647
2648         https://bugzilla.gnome.org/show_bug.cgi?id=666669
2649
2650         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2651
2652 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2653
2654         Rename onlineglom.properties to onlineglom.properties.sample.
2655
2656         * src/main/resources/onlineglom.properties: Rename to:
2657         * src/main/resources/onlineglom.properties.sample:
2658         * src/main/resources/README: And add this file explaining that people
2659         should rename it back when deploying.
2660
2661 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2662
2663         Allow choosing the translation in the .properties file.
2664
2665         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2666         init(): Read a glom.document.locale value from the configuration file 
2667         and call Glom's TransatableItem::set_current_locale() method.
2668         * src/main/resources/onlineglom.properties: Add a commented-out 
2669         example of this new setting.
2670
2671         It would be better to add &lang=de_DE to the URL, but the current 
2672         libglom API does not allow us to do this easily. I am working on that.
2673
2674 2011-12-19  Murray Cumming  <murrayc@murrayc.com>
2675
2676         Avoid a crash in parsing of token parameters.
2677
2678         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2679         ava: getTokenParams(): Do not crash if a parameter has a key but no 
2680         value, and ignore parameters with neither.
2681
2682 2011-12-17  Murray Cumming  <murrayc@murayc.com>
2683
2684         History token building/handling: Improve use of token parameters.
2685
2686         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java 
2687         (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2688         and buildParamsToken(HashMap), for use by derived classes.
2689         Make the separator private because it is no longer be needed.
2690         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2691         (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2692         instead of manual string concatenation.
2693         (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2694         of hardcoded indices and awkward splitting code.
2695         * src/main/java/org/glom/web/client/place/ListPlace.java
2696         (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2697         instead of manual string concatenation.
2698         (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2699         of hardcoded indices and awkward splitting code.
2700         This should fix bug #666420
2701
2702 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2703
2704         Fix a Navgiation->Navigation typo in the code.
2705
2706         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2707         Rename processNavgiation() to processNavigation().
2708
2709 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2710
2711         Fix a seperator->separator typo in the code.
2712
2713         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2714         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2715         * src/main/java/org/glom/web/client/place/ListPlace.java: Just a 
2716         misspelling.
2717
2718 2011-12-15  Ben Konrath <ben@bagu.org>
2719
2720         Cleanup some comments.
2721
2722         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2723
2724 2011-12-14  Ben Konrath <ben@bagu.org>
2725
2726         Replace \n with <br/> for multiline text in the details view.
2727
2728         Vertical scrollbars are added when needed as well.
2729
2730         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2731
2732 2011-12-14  Ben Konrath <ben@bagu.org>
2733
2734         Specify the font for document selection links.
2735
2736         * src/main/webapp/style.css:
2737
2738 2011-12-14  Ben Konrath <ben@bagu.org>
2739
2740         Fix bouncy CellTable while paging.
2741
2742         This doesn't currently work with related list tables in unselected
2743         Notebook tabs.
2744
2745         * src/main/java/org/glom/web/client/ui/list/ListTable.java
2746
2747 2011-12-14  Ben Konrath <ben@bagu.org>
2748
2749         Revamp the appearance of the document selection page.
2750
2751         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2752         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2753         * src/main/webapp/style.css:
2754
2755 2011-12-13  Ben Konrath <ben@bagu.org>
2756
2757         Set navigation button column to the smallest size possible.
2758
2759         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2760
2761 2011-12-13  Ben Konrath <ben@bagu.org>
2762
2763         Change OpenButton nomenclature to NavigationButton.
2764
2765         Using NavigtionButton makes things more generic. Classes, methods and
2766         variables have been changed.
2767
2768         This is a rename-only refactor.
2769
2770         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2771         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2772         * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2773         Renamed from OpenButtonCell.
2774         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2775         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2776         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2777
2778 2011-12-12  Ben Konrath <ben@bagu.org>
2779
2780         Remove unnecessary String argument in RelatedListTable and ListViewTable.
2781
2782         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2783         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2784         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2785         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2786
2787 2011-12-12  Ben Konrath <ben@bagu.org>
2788
2789         Update variable names and comments.
2790
2791         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2792         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2793
2794 2011-12-12  Ben Konrath <ben@bagu.org>
2795
2796         Properly initialize numNonEmptyRows variable to zero.
2797
2798         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2799         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2800
2801 2011-12-05  Ben Konrath  <ben@bagu.org>
2802
2803         Add latest mockup with HTML tables.
2804
2805         Features of this mockup:
2806
2807         -> HTML table for flowtable
2808         -> HTML table for flowtable column
2809         -> Example of how related lists would look
2810         -> Not using text entries for data items
2811
2812         The current version of Online Glom doesn't use HTML tables for the
2813         flowtable columns.
2814
2815         This mockup has been sent to the glom-devel mailing list but it's good
2816         to have it here as well.
2817
2818         * mockups/details-view-html-tables.html:
2819
2820 2011-12-05  Ben Konrath  <ben@bagu.org>
2821
2822         Remove unnecessary getPrimaryKeyField() method.
2823
2824         getPrimaryKeyFieldForTable(String) has been renamed to
2825         getPrimaryKeyField(String).
2826
2827         * src/main/java/org/glom/web/server/database/DBAccess.java:
2828         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2829         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2830
2831 2011-12-05  Ben Konrath  <ben@bagu.org>
2832
2833         Add string representation of TypedDataItem value to conversion error message.
2834
2835         * src/main/java/org/glom/web/server/Utils.java: Logging the error
2836         message was extracted into its own method to avoid duplication.
2837
2838 2011-12-05  Ben Konrath  <ben@bagu.org>
2839
2840         Add type checking to navigation primary key value creation.
2841
2842         Create navigation primary key only if the expected type from the Glom
2843         document matches the type returned by the SQL query.
2844
2845         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2846
2847 2011-12-05  Ben Konrath  <ben@bagu.org>
2848
2849         Rename a couple of variables in RelatedListNavigation.
2850
2851         This is a rename-only refactor.
2852
2853         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2854
2855 2011-12-05  Ben Konrath  <ben@bagu.org>
2856
2857         Move getListLayoutGroup() into getListViewLayoutGroup().
2858
2859         This removes getListLayoutGroup(). It was only being called by
2860         getListViewLayoutGroup().
2861
2862         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2863
2864 2011-12-05  Ben Konrath  <ben@bagu.org>
2865
2866         Remove check for LayoutItem_Portal in list table method.
2867
2868         This check is no longer necessary because the method isn't being used
2869         to create the LayoutItemPortal DTO.
2870
2871         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2872
2873 2011-12-05  Ben Konrath  <ben@bagu.org>
2874
2875         Properly support related list navigation.
2876
2877         Navigation from the "Repository Analyzer -> Package Scans ->
2878         Dependencies" related table wasn't working because the primary key for
2879         related tables wasn't being set properly. This commit fixes the
2880         problem.
2881
2882         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2883         getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2884         doesn't set the primary key properly for related list tables.
2885         * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2886         name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2887         useful for getting the primary key for list view tables and for related
2888         list tables.
2889         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2890         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2891         Move code to set the primary key for the table from the abstract
2892         ListDBAccess class to ListViewDBAccess as it's only correct for list
2893         view tables.
2894         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2895         Properly add primary key to related list tables.
2896
2897 2011-12-02  Ben Konrath  <ben@bagu.org>
2898
2899         Properly set the horizontal alignment of fields.
2900
2901         This fix is for both the list tables and the details view.
2902
2903         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2904         LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2905         to set the horizontal alignment of fields.
2906
2907 2011-12-02  Ben Konrath  <ben@bagu.org>
2908
2909         Display currency codes in the details view.
2910
2911         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2912
2913 2011-12-02  Ben Konrath  <ben@bagu.org>
2914
2915         Avoid duplicate JNI call.
2916
2917         JNI is not as efficient as pure Java and this is an easy (and small)
2918         optimization.
2919
2920         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2921         Use previously retrieved value for whereClauseToTableName instead of
2922         getting it again.
2923
2924 2011-12-02  Ben Konrath  <ben@bagu.org>
2925
2926         Rename a couple of variables in RelatedListNavigation.
2927
2928         This is a rename-only refactor.
2929
2930         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2931
2932 2011-12-02  Ben Konrath  <ben@bagu.org>
2933
2934         Indicate clearly that a mismatched primary key type is a bug.
2935
2936         * src/main/java/org/glom/web/server/Utils.java: Change log level from
2937         warning to error. Add 'This is a bug.' to message.
2938
2939 2011-12-02  Ben Konrath  <ben@bagu.org>
2940
2941         Update / fix some comments.
2942
2943         * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2944         comments.
2945         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2946         comment.
2947         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2948         Fix comments. Add some TODOs.
2949
2950 2011-12-02  Ben Konrath  <ben@bagu.org>
2951
2952         Enable navigation to details view with string primary key from related list.
2953
2954         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2955         Create a text primary key value when return type of result is
2956         java.sql.Types.VARCHAR.
2957
2958 2011-12-02  Ben Konrath  <ben@bagu.org>
2959
2960         Use checkboxes for booleans in the details view.
2961
2962         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2963
2964 2011-12-01  Ben Konrath  <ben@bagu.org>
2965
2966         Improve performance of related list height calculation.
2967
2968         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2969         Put code to calculate the expected height in a static initializer so
2970         that that it's only called once.
2971
2972 2011-12-01  Ben Konrath  <ben@bagu.org>
2973
2974         Show related list tables in notebooks (again).
2975
2976         Calculate the height of the related list tables so the Notebook can be
2977         set the correct height. The height of the related list table is also needed by
2978         FlowTable to be able decide how to create the layout.
2979
2980         * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2981         and set the Portal height based on the height of the related list
2982         table and the Portal container.
2983         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2984         Add method to calculate the height of the related list tables.
2985         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2986         * src/main/webapp/style.css: Add css class for Pager. This is needed to
2987         calculate the height of the Pager widget.
2988
2989 2011-12-01  Ben Konrath  <ben@bagu.org>
2990
2991         Use CellTable API for table property instead of setting style on Element.
2992
2993         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2994
2995 2011-12-01  Ben Konrath  <ben@bagu.org>
2996
2997         Make ListViewTable and RelatedListTable a consistent height.
2998
2999         The tables are now a consistent height regardless of the contents of
3000         the table. A hidden button is added to empty rows to ensure that the
3001         height of these rows will match the height of rows with data.
3002
3003         A navigation button column is now added to every table. The width of
3004         the navigation column is set to 0px when a RelatedListTable shouldn't
3005         have navigation buttons. This maintains the a consistent row height in
3006         tables that don't show the navigation buttons.
3007
3008         * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
3009         navigation column when not needed.
3010         * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
3011         arguments for navigation button to constructor of ListViewTable.
3012         * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
3013         hidden button for empty data rows.
3014         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
3015         arguments for navigation button to constructor.
3016         * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
3017         create navigation buttons. Add hideNavigationButtons() method.
3018         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
3019         arguments for navigation button to constructor.
3020
3021 2011-12-01  Ben Konrath  <ben@bagu.org>
3022
3023         Use 'visibility: hidden' in Utils.getWidgetHeight().
3024
3025         This is better choice because hidden elements are invisible, don't
3026         respond to events and are not part of the tab order. They will,
3027         however, 
3028