1 2012-04-19 Murray Cumming <murrayc@murrayc.com>
3 Reports: Localize the waiting for report message.
5 * src/main/java/org/glom/web/client/activity/ReportActivity.java
6 start(): Get the message from the contants.
7 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
9 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
10 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
11 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
12 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
13 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
14 Update these files with the English text for newer strings for now.
16 2012-04-19 Murray Cumming <murrayc@murrayc.com>
18 Reports: Show a message while waiting for the report.
20 * src/main/java/org/glom/web/client/ui/ReportView.java
21 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
22 Add setWaitingText(), to show a message saying that we are
23 waiting for the report to be ready.
24 * src/main/java/org/glom/web/client/activity/ReportActivity.java
25 start(): Call setWaitingText() before calling the async
28 2012-04-19 Murray Cumming <murrayc@murrayc.com>
30 ReportGenerator: Specify date and time formats.
32 * src/main/java/org/glom/web/server/ReportGenerator.java:
33 createFieldValueElement(): Use the default (and localized)
34 short formats, though we still need a way to show 4-digit
35 years without providing the format for every locale.
36 * src/main/java/org/glom/web/server/database/DBAccess.java:
37 convertResultSetToDTO(): Use the short formats here too.
39 2012-04-18 Murray Cumming <murrayc@murrayc.com>
41 ReportGenerator: Use the correct numeric formatting.
43 * src/main/java/org/glom/web/server/ReportGenerator.java
44 createFieldExpression(), createFieldValueElement(): Take the
45 whole LayoutItem_Field instead of just the field name, so
46 we have access to the formatting.
47 createFieldValueElement(): Use JRTextField.setPattern() to
48 specify the numeric formatting, with the help of a
49 regular DecimalFormat.
51 2012-04-18 Murray Cumming <murrayc@murrayc.com>
53 ReportGenerator: Avoid showing null for group by titles.
55 * src/main/java/org/glom/web/server/ReportGenerator.java
56 generateReport(): Use setBlankWhenNull() on the field title
57 style too, because this is used for values in group by
60 2012-04-18 Murray Cumming <murrayc@murrayc.com>
62 ReportGenerator: Add a colon to titles in vertical groups.
64 * src/main/java/org/glom/web/server/ReportGenerator.java
65 addFieldToDetailBandVertical(): Pass true for the withColon
68 2012-04-18 Murray Cumming <murrayc@murrayc.com>
70 ReportGenerator: Simplify the code by using Position more.
72 2012-04-18 Murray Cumming <murrayc@murrayc.com>
74 Reports: Support vertical groups, roughly.
76 * src/main/java/org/glom/web/server/ReportGenerator.java:
77 addToReport(): Rename to addGroupToReport() and, if necessary,
78 call the new addVerticalGroupToReport() method.
79 createFieldValueElement(): Let the caller specify the Y position
82 2012-04-17 Murray Cumming <murrayc@murrayc.com>
84 Reports: Allow a second report to be shown.
86 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
87 clear(): Do not remove the HTML widget, which broke the whole layout.
89 2012-04-17 Murray Cumming <murrayc@murrayc.com>
91 Locales drop-down: Show that we use English by default.
93 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
94 fillView(): When we use English, just because that is the default, when
95 no locale is specified, show that in the Locales drop-down instead of
96 just showing the first item.
98 2012-04-17 Murray Cumming <murrayc@murrayc.com>
100 Unselect the Report/Locale/Table combo item when appropriate.
102 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
103 setPlace(): clear reportName if this is not a ReportPlace.
104 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
105 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
106 When the provided name is empty, unselect all items, so that none are
107 indicated. This uses a for loop because I cannot find a single method
110 2012-04-17 Murray Cumming <murrayc@murrayc.com>
112 Report: Give the user a way to get back to the list.
114 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
115 start(), setPlace(): Show the Back To List link on reports, and also
116 interpret selecting the empty report item as back to list.
118 2012-04-17 Murray Cumming <murrayc@murrayc.com>
120 Style: Remove overflow:hidden from searchbox
122 * src/main/webapp/style.css: Because this pushes the Back To Link
123 label/link on to the next row, which is then hidden due to the
124 hard-coded (in ems) height.
126 2012-04-13 Murray Cumming <murrayc@murrayc.com>
128 Really show the selected Report name.
130 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
131 setPlace(): Store the reportName here, if it is that kind of Place.
132 fillView(): Set the selected Report after filling the list of reports.
133 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
134 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
135 null Strings, though we need some way to unselect all ListBox items
138 2012-04-13 Murray Cumming <murrayc@murrayc.com>
140 ReportGenerator: Try to avoid some problems.
142 * src/main/java/org/glom/web/server/ReportGenerator.java
143 addField(): Try to avoid duplicates, and avoid using a null
146 2012-04-13 Murray Cumming <murrayc@murrayc.com>
148 Reports: Use quickFind.
150 * src/main/java/org/glom/web/client/OnlineGlomService.java;
151 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
153 getReportHTML(): Add a quickFind parameter.
154 * src/main/java/org/glom/web/client/activity/ReportActivity.java
155 start(): Pass the quickFind parameter.
156 * src/main/java/org/glom/web/server/ReportGenerator.java
157 generateReport(): Take a quickFind parameter.
159 2012-04-13 Murray Cumming <murrayc@murrayc.com>
161 ReportPlace: Actually use the report name.
163 * src/main/java/org/glom/web/client/place/ReportPlace.java
164 getPlace(): Do not assign the report name to the quickfind.
166 2012-04-13 Murray Cumming <murrayc@murrayc.com>
168 Show java.library.path when complaining.
170 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
171 init(): When telling us to check java.library.path, show the
174 2012-04-12 Murray Cumming <murrayc@murrayc.com>
176 Adapt to the java-libglom 1.21.8 API.
178 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
179 java-libglom's FieldFormatting is now Formatting.
181 2012-04-12 Murray Cumming <murrayc@murrayc.com>
183 Use the latest java-libglom version.
185 * pom.xml: Use java-libglom 1.21.8.
187 2012-03-15 Murray Cumming <murrayc@murrayc.com>
189 Adapt to the java-libglom 1.21.7 API.
191 * src/main/java/org/glom/web/server/ReportGenerator.java:
192 addToReport(): get_group_secondary_fields() is now
193 get_secondary_fields().
195 2012-03-15 Murray Cumming <murrayc@murrayc.com>
197 Use the latest java-libglom version.
199 * pom.xml: Use java-libglom 1.21.7.
201 2012-03-06 Murray Cumming <murrayc@murrayc.com>
203 ReportGenerator: Do not show nulls.
205 2012-03-06 Murray Cumming <murrayc@murrayc.com>
207 ReportGenerator: Make the title font larger.
209 2012-03-06 Murray Cumming <murrayc@murrayc.com>
211 ReportGenerator: Put field titles inside groups, if there are groups.
213 2012-03-06 Murray Cumming <murrayc@murrayc.com>
215 ReportGenerator: Take the Report itself instead of the name and group.
217 * src/main/java/org/glom/web/server/ConfiguredDocument.java
218 Remove getReportLayoutGroup().
219 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
220 getReportHTML(): Pass the report instead
221 of its name and layout group.
222 * src/main/java/org/glom/web/server/ReportGenerator.java
223 generateReport(): Use the report object to use the title
226 2012-03-06 Murray Cumming <murrayc@murrayc.com>
228 ReportGenerator: Remove designBand parameters.
230 * src/main/java/org/glom/web/server/ReportGenerator.java:
231 Make designBand a class member instead of passing it to all
234 2012-03-06 Murray Cumming <murrayc@murrayc.com>
236 ReportGenerator: Add lines, a bit like in the desktop version.
238 * src/main/java/org/glom/web/server/ReportGenerator.java
239 addToReport(): Use JRDesignLine.
241 2012-03-06 Murray Cumming <murrayc@murrayc.com>
243 ReportGenerator: Correct the title positions and use some bold style.
245 * src/main/java/org/glom/web/server/ReportGenerator.java:
246 Break the code up into reusable functions, correct the placement of
247 titles, and use normal/bold styles as in the reports in the desktop
250 2012-03-06 Murray Cumming <murrayc@murrayc.com>
252 ReportGenerator: Add a header band to show the field titles.
254 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
255 getReportHTML(): Pass the localeId to the ReportGenerator
257 * src/main/java/org/glom/web/server/ReportGenerator.java
258 constructor: Take the localeID so we can get translated field
260 generateReport(), addToReport(), addFieldToBand(): Add field
261 titles in a column header band.
263 2012-03-05 Murray Cumming <murrayc@murrayc.com>
265 Reports drop-down list: Some improvement.
267 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
268 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
269 Adedd setSelectedReport(),
270 setReportList(): Add a blank line so that the user can select the
272 * src/main/java/org/glom/web/client/activity/ReportActivity.java
273 start(): Show the current report by calling setSelectedReport().
274 This does not seem to work yet.
276 2012-03-05 Murray Cumming <murrayc@murrayc.com>
278 DetailsActivity, ListActivity: Move some variables into a base class.
280 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
281 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
282 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
283 the clientFactory, documentID, tableName and authenticationPopup into
284 a base class, to avoid duplication.
286 2012-03-05 Murray Cumming <murrayc@murrayc.com>
288 Translate the Reports label.
290 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
291 Get the "Reports" label string from the constants.
292 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
293 perties: Add Reports to the constants.
295 2012-03-03 Ben Konrath <ben@bagu.org>
297 Display date and time in details view.
299 https://bugzilla.gnome.org/show_bug.cgi?id=671257
301 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
303 2012-03-05 Murray Cumming <murrayc@murrayc.com>
305 Require the latest java-libglom.
307 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
309 2012-03-05 Murray Cumming <murrayc@murrayc.com>
311 Reports: Implement grouping.
313 * src/main/java/org/glom/web/server/ReportGenerator.java:
314 Handle LayoutItem_GroupBy items and try to do the right thing
315 with JRDesignGroup. It seems to work.
317 2012-03-04 Murray Cumming <murrayc@murrayc.com>
319 Actually show some data with JasperReports.
321 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
322 getReportHTML(): Move most code into a ReportGenerator class.
323 * src/main/java/org/glom/web/server/ReportGenerator.java:
324 Recurse into sub-groups, adding fields to the JasperDesign's details
325 band. Note that we must set an arbitrary width and height, or it just
326 will not show any data.
328 2012-03-04 Murray Cumming <murrayc@murrayc.com>
330 Reports Chooser: Show the titles, not the names.
332 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
333 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
334 and the names as the values.
335 * src/main/java/org/glom/web/server/ConfiguredDocument.java
336 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
337 group now that we provide the report name, so it should always
340 2012-03-04 Murray Cumming <murrayc@murrayc.com>
342 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
344 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
345 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
346 an empty quickfind string. I also corrected libglom to create only
347 empty where clauses for empty quickfind strings, but this avoids the
350 2012-02-24 Ben Konrath <ben@bagu.org>
352 Improve the tabs in the Notebook widget.
356 2012-02-15 Murray Cumming <murrayc@murrayc.com>
358 Depend on jasperreports.
360 * pom.xml: Add the dependency. My plan is to use this on the
363 2012-01-31 Murray Cumming <murrayc@murrayc.com>
365 Implement navigation to report places.
367 * src/main/java/org/glom/web/client/activity/ReportActivity.java
368 start(): Do not bother to handle all events here.
369 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
370 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
371 Added getSelectedReport().
372 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
373 .java: start(): When handling a change to the reports chooser,
374 call getSelectedReport() and goTo() its ReportPlace.
375 * src/main/java/org/glom/web/client/ui/ReportView.java
376 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
377 Added setReportHTML() which puts the html in a gwt HTML widget.
378 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
379 getReportHTML(): Return "TODO" just to show that this works.
381 2012-01-31 Murray Cumming <murrayc@murrayc.com>
383 Make ReportPlace usable.
385 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
387 * src/main/java/org/glom/web/client/place/ReportPlace.java:
388 Correct the @prefix annotation.
390 2012-01-31 Murray Cumming <murrayc@murrayc.com>
392 OnlineGlomService: Return report HTML rather than the LayoutGroup.
394 * src/main/java/org/glom/web/client/OnlineGlomService.java:
395 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
396 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
397 Change getReportLayout() to getReportHMTL() because we will not need to
398 parse or render the report layout on the client side.
399 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
400 getReportLayout(): Return the libglom LayoutGroup type because we will
401 not need to convert to a shared type, because this will not be used on
403 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
406 Note that there is still no implementation for this.
408 2012-01-30 Murray Cumming <murrayc@murrayc.com>
410 Translations: Try to translate the strings.
412 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
413 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
414 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
415 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
416 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
417 Take the Open translation from GTK+'s .po files.
418 Take the Details translation from Glom's po files.
419 I have added the other strings to Glom so we can get translations that way:
420 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
422 2012-01-27 Murray Cumming <murrayc@murrayc.com>
424 Add a (empty) Report Place, View, and Activity.
426 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
428 * src/main/java/org/glom/web/client/place/HasTablePlace.java
429 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
430 this into a superclass:
431 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
432 and also use it as the base of this new ReportPlace:
433 * src/main/java/org/glom/web/client/place/ReportPlace.java
435 * src/main/java/org/glom/web/client/ui/ReportView.java
436 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
437 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
438 Add these, containing mostly boiler-plate for now.
440 * src/main/java/org/glom/web/client/OnlineGlomService.java
441 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
442 * src/main/java/org/glom/web/server/ConfiguredDocument.java
443 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
444 Add API to get the LayoutGroup for the report.
446 2012-01-27 Murray Cumming <murrayc@murrayc.com>
448 TableSelectionViewImpl: Put the search label and entry in a div.
450 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
451 Put the search widgets in a FlowTable so that the CSS can be used to
452 style them while keeping them together.
453 * src/main/webapp/style.css: Mention the new div.
455 2012-01-27 Murray Cumming <murrayc@murrayc.com>
457 Translate more strings in more locales.
459 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
460 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
461 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
462 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
463 Translate the "Details" and "Open" string too.
465 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
466 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
467 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
468 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
469 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
470 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
471 Add these new locales as placeholders though they currently contain English.
473 2012-01-27 Murray Cumming <murrayc@murrayc.com>
475 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
477 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
478 Check the ConfiguredDocument* for null before using it.
480 2012-01-26 Murray Cumming <murrayc@murrayc.com>
482 Tell Eclipse about the generated java files.
484 * .classpath: This lets it find OnlineGlomConstants.java.
485 It would be nice if Eclipse just used the maven build files.
487 2012-01-26 Murray Cumming <murrayc@murrayc.com>
489 Prevent a crash when no locale is specified in the URL.
491 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
492 Avoid returning a null string, obtained from
493 Window.Location.getParameter(). This caused a crash when it was
494 later passed to libglom's API.
495 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
496 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
497 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
498 guard against future null strings.
500 2012-01-26 Murray Cumming <murrayc@murrayc.com>
502 Use the ?locale= query param instead of the &lang= token param.
504 * src/main/java/org/glom/web/client/place/ListPlace.java
505 * src/main/java/org/glom/web/client/place/DetailsPlace.java
506 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
507 Remove the lang token key and value.
509 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
510 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
511 When the user selects a different locale from the chooser, use
512 Window.Location.assign() to change the URL, which then causes a reload.
514 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
515 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
516 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
517 * src/main/java/org/glom/web/client/activity/ListActivity.java
518 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
519 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
520 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
521 * src/main/java/org/glom/web/client/ui/ListView.java:
522 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
524 Remove localeID member variables and method/constructor parameters, instead
525 using Utils.getCurrentLocaleID() when we need a localID to pass to
528 2012-01-26 Murray Cumming <murrayc@murrayc.com>
530 Internationalize the UI strings.
532 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
533 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
534 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
535 because it is unused. Messages are apparently strings that can have
536 parameters, but we do not need that yet, so Contants will be enough for now.
537 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
538 to say that we support the en and de locales.
539 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
540 The original English strings.
541 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
542 Some German translations of the English strings.
543 The i18n goal then uses the .properties file to generate an
544 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
545 returns an implementation that returns the translated strings.
546 The documentation suggests putting these in src/java/*/client/, but it seems
547 best to put it in src/resources/*/client/.
548 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
549 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
550 instead of hard-coding them.
551 Note that we cannot import OnlineGlomConstants because it does not exist yet,
552 but that does not seem to stop the build, though it confuses Eclipse.
554 You can see the translated string by adding ?locale=de to the URL, like so:
555 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
557 2012-01-24 Murray Cumming <murrayc@murrayc.com>
559 Improve null/empty String checks.
561 * pom.xml: Add a dependency on commons-lang, to use
562 org.apache.commons.lang.StringUtils.
563 * src/main/java/org/glom/web/server/ConfiguredDocument.java
564 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
565 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
566 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
567 Use StringUtils.isEmpty().
569 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
570 StringUtils class with a static isEmpty() function because we
571 cannot use org.apache.commons.lang.StringUtils in client-side
572 GWT code because it (apparently) cannot be compiled to javascript.
573 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
574 * src/main/java/org/glom/web/client/activity/ListActivity.java
575 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
576 * src/main/java/org/glom/web/client/place/DetailsPlace.java
577 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
578 * src/main/java/org/glom/web/client/place/ListPlace.java
579 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
580 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
581 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
582 * src/main/java/org/glom/web/client/ui/details/Group.java
583 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
584 our StringUtils.isEmpty() function.
586 2012-01-24 Murray Cumming <murrayc@murrayc.com>
588 Update to the latest java-libglom API.
590 * pom.xml: Require java-libglom 1.21.4.
591 * src/main/java/org/glom/web/server/ConfiguredDocument.java
592 getDocumentInfo(), getListViewLayoutGroup():
593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
595 * src/main/java/org/glom/web/server/database/DBAccess.java
596 getFieldsToShowForSQLQueryAddGroup(),
597 getPrimaryKeyLayoutItemField(): Replace get_database_title()
598 with either get_database_title_original() or
599 get_database_title(localeID).
601 2012-01-24 Murray Cumming <murrayc@murrayc.com>
603 ConfiguredDocument: Avoid a null pointer exception.
605 * src/main/java/org/glom/web/server/ConfiguredDocument.java
606 Initialize localeID to "" to avoid returning a null String which
607 causes a crash in java-libglom's swing-generated code.
609 2012-01-23 Murray Cumming <murrayc@murrayc.com>
611 Some simple renaming.
613 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
614 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
615 for localeChooser. This seems more appropriate and is less ambiguous
616 particularly in the .css file.
618 2012-01-23 Murray Cumming <murrayc@murrayc.com>
620 ConfiguredDocument: Rename the localedID private member variable.
622 2012-01-23 Murray Cumming <murrayc@murrayc.com>
624 Adapt to the latest java-libglom API from git master.
626 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
627 libglom now uses only Vector instead of List, which uses add() instead of
630 2012-01-23 Murray Cumming <murrayc@murrayc.com>
632 Add and fill a Reports drop-down list box.
634 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
636 * src/main/java/org/glom/web/client/OnlineGlomService.java:
637 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
639 Added getReports(document, table, localeID), calling
640 ConfiguredDocument.getReports().
641 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
642 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
643 Added setReportsList() and a list widget.
644 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
645 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
647 2012-01-22 Murray Cumming <murrayc@murrayc.com>
649 ConfiguredDocument: Rename the localedID private member variable.
651 2012-01-20 Murray Cumming <murrayc@murrayc.com>
653 Build a source tarball with mvn assembly:single
655 * assembly.xml: Add this file.
656 * pom.xml: Use the maven-assembly-plugin and tell it to use
657 our assembly.xml file.
659 2012-01-19 Murray Cumming <murrayc@murrayc.com>
661 OnlineGlomServiceImpl: Get .glom files recursively.
663 * pom.xml: Depend on commons-io from org.apache.commons.
664 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
665 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
666 files recursively, and with the easier filter for the extension.
667 Use org.apache.commons.io.FilenameUtils.removeExtension() to
668 simplify that code too.
670 2012-01-19 Murray Cumming <murrayc@murrayc.com>
672 README: Mention that you must install java-libglom packages separately.
674 But then it works, because java-libglom is now in the central maven
677 2012-01-18 Murray Cumming <murrayc@murrayc.com>
679 locales drop-down: Show the correct selected locale when the URL changes.
681 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
682 .java: setPlace(): Move some code into fillView().
684 2012-01-18 Murray Cumming <murrayc@murrayc.com>
686 locales drop-down: Do not lose the primary key.
688 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
689 start(): onLocaleChange(): Pass the current primary key value,
690 instead of an empty value.
692 2012-01-18 Murray Cumming <murrayc@murrayc.com>
694 locales drop-down: Do not lose the drop-down selection.
696 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
697 .java (TableSelectionActivity.fillView): Set the selected locale
698 after changing the drop-down items (though we do not really need
699 to change them just because the locale changes.)
701 2012-01-18 Murray Cumming <murrayc@murrayc.com>
703 locales drop-down: Change the tables list when this changes.
705 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
706 .java: TableSelectionActivity.start(): Move the async table titles
707 retrieval into a private fillView() method and also call this when
708 the chosen locale changes.
709 Note that the document title is not actually translatable yet, but
710 that is a problem that I should fix soon in libglom.
712 2012-01-18 Murray Cumming <murrayc@murrayc.com>
714 Improve the placement of the locales drop-down.
716 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
717 Put the title and locales drop-down in a div (gwt.FlowTable).
718 * src/main/webapp/style.css: Add magic css properties to make this work.
719 Also remove the left margin from the title so that it lines up with the
722 2012-01-18 Murray Cumming <murrayc@murrayc.com>
724 locales selector: Show human-readable locale titles.
726 * src/main/java/org/glom/web/server/ConfiguredDocument.java
727 getDocumentInfo(): Use java.util.Locale to show a real title of
728 each locale, in the locale's own language.
730 2012-01-17 Murray Cumming <murrayc@murrayc.com>
732 Add a language/locale selector drop-down.
734 * src/main/java/org/glom/web/shared/DocumentInfo.java:
735 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
736 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
737 getDocumentInfo(): Store the available Locales in the DocumentInfo.
738 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
739 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
740 Add a ListBox to show the available locales. Add getLocaleSelector(),
741 setLocaleList(), getSelectedLocale(), setSelectedLocale().
742 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
743 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
744 java: Add these classes.
745 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
746 start(): Fill the locales ListBox. Handle its change event, firing a
748 setPlace(): Show the selected locale as specified by the URL token.
749 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
750 * src/main/java/org/glom/web/client/activity/ListActivity.java:
751 Handle LocaleChangeEvent, going to a new *Place with that locale.
753 The placement of the ListBox is not pretty, and it currently uses the ID
754 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
758 2012-01-17 Murray Cumming <murrayc@murrayc.com>
760 Search box: Show the search text from the URL token.
762 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
763 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
764 Add setQuickFindText().
765 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
766 .java: setPlace(): Store the queryText if the place is a ListPlace,
767 and call TableSelectionView.setQuickFindText().
769 2012-01-17 Murray Cumming <murrayc@murrayc.com>
771 Allow use of translations via, for instance, &lang=de in the URL.
773 * pom.xml: Use the unstable java-libglom 1.21 version.
775 * src/main/java/org/glom/web/client/OnlineGlomService.java:
776 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
777 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
778 init(): Instead of calling TranslatableItem.set_current_locale()
779 (now removed), call ConfiguredDocument.setDefaultLocaleID().
780 However, this is only for default locales, which are not needed to
781 change the locale in the URL.
782 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
783 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
784 getSortedRelatedListData(): Add a localeID parameter, so we can get the
785 layout for a particular locale.
786 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
787 Add get/setDefaultLocaleID().
788 getDocumentInfo(), getListViewData(), getRelatedListData(),
789 getDetailsLayoutGroup(), getListViewLayoutGroup(),
790 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
791 localeID parameter, so we can get the layout for a particular locale.
793 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
794 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
795 * src/main/java/org/glom/web/client/place/ListPlace.java:
796 Parse and construct a lang parameter too.
798 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
799 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
800 passed to subsequent methods and constructors.
801 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
802 * src/main/java/org/glom/web/client/activity/ListActivity.java:
803 Store the localeID from the *Place and pass it to other constructors
804 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
806 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
807 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
808 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
809 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
810 * src/main/java/org/glom/web/client/ui/ListView.java:
811 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
812 Take localeID parameters and pass them to subsequent constructors and
813 methods, so that the layout is always retrieved for that locale.
815 This is rather repetitive.
817 Note that "" means the original (default) locale of the Glom document,
818 which is usually English.
820 2012-01-17 Murray Cumming <murrayc@murrayc.com>
822 Documents: Remove final keyword to fix startup configuration.
824 * src/main/java/org/glom/web/shared/Documents.java: Remove the
825 final keywords on the private member variables because that breaks
826 the startup, apparently (there are warnings) because it stops them
827 from being serialized. I added these in the previous commit.
829 2012-01-13 Murray Cumming <murrayc@murrayc.com>
831 Documents: Add some final keywords.
833 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
836 2012-01-13 Murray Cumming <murrayc@murrayc.com>
838 OnlineGlomServiceImpl: Add to overview comments.
840 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
841 Note that this is where all the document are loaded. They are not
842 loaded freshly for each page.
844 2012-01-12 Murray Cumming <murrayc@murrayc.com>
848 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
849 Add a TextBox for the text of a quick find.
850 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
852 setBackLink(): Add a String quickFind parameter.
853 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
854 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
855 to the base interface, because that is how TableSelectionViewImpl is used.
856 * src/main/webapp/style.css: Add style for the search box and its label.
858 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
859 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
860 Add these files, based on the existing TableChangeEvent and
861 TableChangeEventHandlers.
862 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
863 start(): Handle QuickFindChangeEvent, passing its quickFind text to
864 a ListPlace() that the user should be taken to.
865 * src/main/java/org/glom/web/client/activity/ListActivity.java
866 start(): Handle it here too and adapt the TableChangeEvent handler to
867 pass the extra "" quickFind parameter to ListPlace.
868 * src/main/java/org/glom/web/client/place/ListPlace.java:
869 Constructor: Take an extra String quickFind parameter and store it,
870 returning it from a new getQuickFind() method.
871 getToken(): Put the quickFind text in the URL token.
872 getPlace(): Parse the quickFind text from the URL token.
873 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
874 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
875 ListPlace constructor.
876 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
877 .java: start(): Add a Change handler for the TableSelectionView's
878 TextBox (via its base HasChangeHandlers interface), firing the new
879 QuickFindChangeEvent.
880 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
881 pass the extra "" quickFind parameter.
883 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
884 setCellTable(): Add a String quickFind parameter and pass it to
885 the ListViewTable() constructor.
886 * src/main/java/org/glom/web/client/ui/ListView.java: Change
887 setCellTable() in the base interface, because that is how ListViewImpl
890 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
891 Add a String quickFind member variable.
892 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
893 Constructor: Add a String quickFind parameter, storing it in the
894 base ListTable's member variable.
895 onRangeChanged(): Pass quickFind to the
896 OnlineGlomServiceAsync.getSortedListViewData() and
897 OnlineGlomServiceAsync.getListViewData() methods.
899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
900 getListViewData(), getSortedListViewData(): Add a String quickFind
901 parameter, passing it to ConfiguredDocument.getListViewData().
902 * src/main/java/org/glom/web/client/OnlineGlomService.java:
903 Change getListViewData(), getSortedListViewData() in the base interface,
904 because that is how OnlineGlomServiceImpl is used, via this:
905 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
906 Change getListViewData(), getSortedListViewData() here too.
907 This class can apparently be used to asynchronously call methods on
908 OnlineGlomService, and GWT seems to implement that after recognizing
909 just the *Async name convention and the extra AsyncCallback parameters.
911 * src/main/java/org/glom/web/server/ConfiguredDocument.java
912 getListViewData(): Add a String quickFind parameter, and pass it to
913 ListViewDBAccess.getData().
914 * src/main/java/org/glom/web/server/database/ListDBAccess.java
915 getListData(): Add a String quickFind parameter and pass it to
917 getSelectQuery(): Add a String quickFind parameter.
918 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
919 getSelectQuery(): Add a String quickFind parameter and use it with
920 Glom.get_find_where_clause_quick() to pass a where_clause to
921 Glom.build_sql_select_with_where_clause(), to actually filter the
923 getData(): Add a String quickFind parameter, passing it to getListData().
924 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
925 va: getData(): Pass an empty string to getListData() for the
928 2012-01-12 Murray Cumming <murrayc@murrayc.com>
930 ListTable: Minor change.
932 * src/main/java/org/glom/web/client/ui/list/ListTable.java
933 createCellTable(): Make this protected instead of public.
935 2012-01-12 Murray Cumming <murrayc@murrayc.com>
937 Many files: Use final for the parameters and use the @override attribute.
939 2012-01-22 Ben Konrath <ben@bagu.org>
941 Add anchor links for single line text that starts with http, ftp and www.
945 2012-01-22 Ben Konrath <ben@bagu.org>
947 Add ellipsis to single line text in details view.
951 2012-01-04 Murray Cumming <murrayc@murrayc.com>
953 Remove all javadoc author tags.
955 Because they are awkward and meaningless when many people touch
957 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
959 2012-01-04 Murray Cumming <murrayc@murrayc.com>
961 Revert the COPYING.LESSER to COPYING rename.
963 Apparently both should be there if it is LGPL.
965 2012-01-03 Murray Cumming <murrayc@murrayc.com>
967 *View: Remove unused imports.
969 * src/main/java/org/glom/web/client/ui/DetailsView.java:
970 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
971 * src/main/java/org/glom/web/client/ui/ListView.java:
972 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
973 Remove unused imports, as suggested by Eclipse.
975 2012-01-02 Murray Cumming <murrayc@murrayc.com>
977 Move the *View::Presenter types, and some API into one base View.
979 * src/main/java/org/glom/web/client/ui/DetailsView.java:
980 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
981 * src/main/java/org/glom/web/client/ui/ListView.java:
982 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
983 Presenter, setPresenter() and clear() into a shared base interface,
984 to avoid the unnecessary duplicate Presenter types and to more clearly
985 show how the *Views share the same structure, even if they are not
986 used polymorphically.
988 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
989 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
991 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
992 * src/main/java/org/glom/web/client/activity/ListActivity.java:
993 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
995 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
998 Feel free to revert this if there is a good reason for the duplicate
1001 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1003 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1005 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1006 a class member instead of a local variable in the method.
1007 This lets us use it to get the view instances, for use in tests.
1008 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1009 beforeOnlineGlom(): Test some more details of the initial view.
1010 Again, this is not very useful.
1012 To really test gwt-glom we will need to start a local postgresql
1013 instance with local data, like the Glom tests in C++.
1015 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1017 pom.xml: Mention the LGPL license.
1019 * pom.xml: Add a licenses section.
1020 * COPYING.LESSER: Move this to COPYING, which
1021 previously contained the GPL. But gwt-glom is all LGPL.
1023 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1025 Add project information to README and pom.xml.
1027 * README: Add a brief description and mention some mvn
1029 * pom.xml: This extra information shows up in mvn site
1032 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1034 Use the latest java-libglom version.
1036 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1038 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1040 GwtTestOnlineGlom: Test a little more.
1042 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1043 protected rather than private, as suggested by the gwt-test-utils
1045 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1046 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1047 Test the initial visibility of the panels.
1049 However, this is not a very useful test.
1050 And I wonder how we should generally test using this idea for an
1051 activity/places app like ours where the real changes happen implicitly
1052 based on the history token/URL.
1054 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1056 Slight modification to *Mapper comments.
1058 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1059 (DataActivityMapper)
1060 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1062 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1064 Remove comments mentioning GIN because they are just copied from
1065 the example code and are apparently not helpful:
1066 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1067 Also change the mention of a class that is only in the example code.
1069 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1071 GwtTestOnlineGlom test: Minor changes.
1073 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1074 Avoid the long qualified class name and modify the comment
1075 because it is now obvious to me that the mocked class is the only
1076 custom one created via GWT.create().
1078 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1080 Tests: Added the beginnings of a test using gwt-test-utils.
1082 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1083 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1084 which tells gwt-test-utils what class will be tested.
1085 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1086 Add a simple (but empty) test case. One class, used by the OnlineGlom
1087 class, is mocked so that it can be created. However, I am not sure
1088 why only this class needs to be mocked.
1090 Note that mockito seems more popular, and clearer, than easymock,
1091 but I have not got that working yet. It might be a matter of the
1094 This test is run during mvn integration-test.
1096 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1098 Tests: Use junit4-style syntax instead of junit3-style.
1100 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1101 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1102 * src/test/java/org/glom/web/shared/DataItemTest.java:
1103 Use the @Test annotation rather than relying on the test*() prefix.
1104 Also no longer implement TestCase, to avoid triggering support for
1105 the junit3-way, which stops the annotations from working.
1106 Change the imports from import junit.framework.* to
1107 import org.junit.*, which is apparently the new way.
1109 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1111 Added a test for ListPlace token parsing and creation.
1113 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1114 This is much the same as DetailsPlaceTest.
1116 I wonder how we could test the other parts of the *Place API.
1118 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1120 DetailsPlace test: Also test getToken() and recreation via getPlace().
1122 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1123 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1124 recreate it, testing the recreated DetailsPlace for the same parameter
1127 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1129 Use the surefire-report plugin.
1131 * pom.xml: This generates a HTML report about the tests in
1132 target/site/surefire-report.html
1133 when you do mvn surefire-report:report. It seems to be popular/normal.
1135 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1137 Added a test for DetailsPlace.
1139 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1140 Test the getPlace() token parsing.
1142 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1144 Added a first unit test.
1146 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1147 * src/test/java/org/glom/web/shared/DataItemTest.java:
1148 This is a silly test but it is just to get things started. Note that
1149 maven/junit finds the test because it looks in src/test by default.
1151 2011-12-22 Ben Konrath <ben@bagu.org>
1153 Change charsetName to "UTF-8" when replacing line breaks.
1155 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1156 that work in Java (such as "UTF8") will not work when compiled to
1159 This fixes a problem with multi-line details view fields that have hard
1160 line breaks. The "License Text" field on this page demonstrates the
1163 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1165 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1167 2011-12-22 Ben Konrath <ben@bagu.org>
1169 Fix another bug with related list navigation.
1171 I've tested all the navigation buttons in all of the related lists
1172 so things should be good now.
1174 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1176 2011-12-22 Ben Konrath <ben@bagu.org>
1178 Fix a crasher when refreshing the list view with the default table.
1180 This crash will also happen when loading the list view with the default
1181 table from a link or bookmark.
1183 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1184 to the main document selection page when the document id hasn't been
1186 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1187 the main document selection page when the document id hasn't been
1189 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1190 values for the details place when the document id hasn't been set.
1191 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1192 values for the list place when the document id hasn't been set.
1194 2011-12-21 Ben Konrath <ben@bagu.org>
1196 Protect against NPE when glom.document.locale is not in config.
1198 This patch protects against an NPE when glom.document.locale is not in
1199 the config file. This NPE will also happen if glom.document.locale is
1202 The patch also updates the error message to display the class name when
1203 the getMessage() returns null. This was happening when the NPE was
1204 thrown and I had "Configuration Error: null". If an NPE is encountered
1205 with this patch, "Configuration Error: NullPointerException " will be
1208 This commit closes this bug:
1210 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1212 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1214 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1216 Rename onlineglom.properties to onlineglom.properties.sample.
1218 * src/main/resources/onlineglom.properties: Rename to:
1219 * src/main/resources/onlineglom.properties.sample:
1220 * src/main/resources/README: And add this file explaining that people
1221 should rename it back when deploying.
1223 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1225 Allow choosing the translation in the .properties file.
1227 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1228 init(): Read a glom.document.locale value from the configuration file
1229 and call Glom's TransatableItem::set_current_locale() method.
1230 * src/main/resources/onlineglom.properties: Add a commented-out
1231 example of this new setting.
1233 It would be better to add &lang=de_DE to the URL, but the current
1234 libglom API does not allow us to do this easily. I am working on that.
1236 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1238 Avoid a crash in parsing of token parameters.
1240 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1241 ava: getTokenParams(): Do not crash if a parameter has a key but no
1242 value, and ignore parameters with neither.
1244 2011-12-17 Murray Cumming <murrayc@murayc.com>
1246 History token building/handling: Improve use of token parameters.
1248 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1249 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1250 and buildParamsToken(HashMap), for use by derived classes.
1251 Make the separator private because it is no longer be needed.
1252 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1253 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1254 instead of manual string concatenation.
1255 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1256 of hardcoded indices and awkward splitting code.
1257 * src/main/java/org/glom/web/client/place/ListPlace.java
1258 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1259 instead of manual string concatenation.
1260 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1261 of hardcoded indices and awkward splitting code.
1262 This should fix bug #666420
1264 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1266 Fix a Navgiation->Navigation typo in the code.
1268 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1269 Rename processNavgiation() to processNavigation().
1271 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1273 Fix a seperator->separator typo in the code.
1275 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1276 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1277 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1280 2011-12-15 Ben Konrath <ben@bagu.org>
1282 Cleanup some comments.
1284 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1286 2011-12-14 Ben Konrath <ben@bagu.org>
1288 Replace \n with <br/> for multiline text in the details view.
1290 Vertical scrollbars are added when needed as well.
1292 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1294 2011-12-14 Ben Konrath <ben@bagu.org>
1296 Specify the font for document selection links.
1298 * src/main/webapp/style.css:
1300 2011-12-14 Ben Konrath <ben@bagu.org>
1302 Fix bouncy CellTable while paging.
1304 This doesn't currently work with related list tables in unselected
1307 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1309 2011-12-14 Ben Konrath <ben@bagu.org>
1311 Revamp the appearance of the document selection page.
1313 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1314 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1315 * src/main/webapp/style.css:
1317 2011-12-13 Ben Konrath <ben@bagu.org>
1319 Set navigation button column to the smallest size possible.
1321 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1323 2011-12-13 Ben Konrath <ben@bagu.org>
1325 Change OpenButton nomenclature to NavigationButton.
1327 Using NavigtionButton makes things more generic. Classes, methods and
1328 variables have been changed.
1330 This is a rename-only refactor.
1332 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1333 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1334 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1335 Renamed from OpenButtonCell.
1336 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1337 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1338 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1340 2011-12-12 Ben Konrath <ben@bagu.org>
1342 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1344 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1345 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1346 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1347 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1349 2011-12-12 Ben Konrath <ben@bagu.org>
1351 Update variable names and comments.
1353 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1354 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1356 2011-12-12 Ben Konrath <ben@bagu.org>
1358 Properly initialize numNonEmptyRows variable to zero.
1360 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1361 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1363 2011-12-05 Ben Konrath <ben@bagu.org>
1365 Add latest mockup with HTML tables.
1367 Features of this mockup:
1369 -> HTML table for flowtable
1370 -> HTML table for flowtable column
1371 -> Example of how related lists would look
1372 -> Not using text entries for data items
1374 The current version of Online Glom doesn't use HTML tables for the
1377 This mockup has been sent to the glom-devel mailing list but it's good
1378 to have it here as well.
1380 * mockups/details-view-html-tables.html:
1382 2011-12-05 Ben Konrath <ben@bagu.org>
1384 Remove unnecessary getPrimaryKeyField() method.
1386 getPrimaryKeyFieldForTable(String) has been renamed to
1387 getPrimaryKeyField(String).
1389 * src/main/java/org/glom/web/server/database/DBAccess.java:
1390 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1391 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1393 2011-12-05 Ben Konrath <ben@bagu.org>
1395 Add string representation of TypedDataItem value to conversion error message.
1397 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1398 message was extracted into its own method to avoid duplication.
1400 2011-12-05 Ben Konrath <ben@bagu.org>
1402 Add type checking to navigation primary key value creation.
1404 Create navigation primary key only if the expected type from the Glom
1405 document matches the type returned by the SQL query.
1407 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1409 2011-12-05 Ben Konrath <ben@bagu.org>
1411 Rename a couple of variables in RelatedListNavigation.
1413 This is a rename-only refactor.
1415 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1417 2011-12-05 Ben Konrath <ben@bagu.org>
1419 Move getListLayoutGroup() into getListViewLayoutGroup().
1421 This removes getListLayoutGroup(). It was only being called by
1422 getListViewLayoutGroup().
1424 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1426 2011-12-05 Ben Konrath <ben@bagu.org>
1428 Remove check for LayoutItem_Portal in list table method.
1430 This check is no longer necessary because the method isn't being used
1431 to create the LayoutItemPortal DTO.
1433 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1435 2011-12-05 Ben Konrath <ben@bagu.org>
1437 Properly support related list navigation.
1439 Navigation from the "Repository Analyzer -> Package Scans ->
1440 Dependencies" related table wasn't working because the primary key for
1441 related tables wasn't being set properly. This commit fixes the
1444 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1445 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1446 doesn't set the primary key properly for related list tables.
1447 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1448 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1449 useful for getting the primary key for list view tables and for related
1451 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1452 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1453 Move code to set the primary key for the table from the abstract
1454 ListDBAccess class to ListViewDBAccess as it's only correct for list
1456 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1457 Properly add primary key to related list tables.
1459 2011-12-02 Ben Konrath <ben@bagu.org>
1461 Properly set the horizontal alignment of fields.
1463 This fix is for both the list tables and the details view.
1465 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1466 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1467 to set the horizontal alignment of fields.
1469 2011-12-02 Ben Konrath <ben@bagu.org>
1471 Display currency codes in the details view.
1473 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1475 2011-12-02 Ben Konrath <ben@bagu.org>
1477 Avoid duplicate JNI call.
1479 JNI is not as efficient as pure Java and this is an easy (and small)
1482 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1483 Use previously retrieved value for whereClauseToTableName instead of
1486 2011-12-02 Ben Konrath <ben@bagu.org>
1488 Rename a couple of variables in RelatedListNavigation.
1490 This is a rename-only refactor.
1492 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1494 2011-12-02 Ben Konrath <ben@bagu.org>
1496 Indicate clearly that a mismatched primary key type is a bug.
1498 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1499 warning to error. Add 'This is a bug.' to message.
1501 2011-12-02 Ben Konrath <ben@bagu.org>
1503 Update / fix some comments.
1505 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1507 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1509 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1510 Fix comments. Add some TODOs.
1512 2011-12-02 Ben Konrath <ben@bagu.org>
1514 Enable navigation to details view with string primary key from related list.
1516 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1517 Create a text primary key value when return type of result is
1518 java.sql.Types.VARCHAR.
1520 2011-12-02 Ben Konrath <ben@bagu.org>
1522 Use checkboxes for booleans in the details view.
1524 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1526 2011-12-01 Ben Konrath <ben@bagu.org>
1528 Improve performance of related list height calculation.
1530 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1531 Put code to calculate the expected height in a static initializer so
1532 that that it's only called once.
1534 2011-12-01 Ben Konrath <ben@bagu.org>
1536 Show related list tables in notebooks (again).
1538 Calculate the height of the related list tables so the Notebook can be
1539 set the correct height. The height of the related list table is also needed by
1540 FlowTable to be able decide how to create the layout.
1542 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1543 and set the Portal height based on the height of the related list
1544 table and the Portal container.
1545 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1546 Add method to calculate the height of the related list tables.
1547 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1548 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1549 calculate the height of the Pager widget.
1551 2011-12-01 Ben Konrath <ben@bagu.org>
1553 Use CellTable API for table property instead of setting style on Element.
1555 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1557 2011-12-01 Ben Konrath <ben@bagu.org>
1559 Make ListViewTable and RelatedListTable a consistent height.
1561 The tables are now a consistent height regardless of the contents of
1562 the table. A hidden button is added to empty rows to ensure that the
1563 height of these rows will match the height of rows with data.
1565 A navigation button column is now added to every table. The width of
1566 the navigation column is set to 0px when a RelatedListTable shouldn't
1567 have navigation buttons. This maintains the a consistent row height in
1568 tables that don't show the navigation buttons.
1570 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1571 navigation column when not needed.
1572 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1573 arguments for navigation button to constructor of ListViewTable.
1574 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1575 hidden button for empty data rows.
1576 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1577 arguments for navigation button to constructor.
1578 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1579 create navigation buttons. Add hideNavigationButtons() method.
1580 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1581 arguments for navigation button to constructor.
1583 2011-12-01 Ben Konrath <ben@bagu.org>
1585 Use 'visibility: hidden' in Utils.getWidgetHeight().
1587 This is better choice because hidden elements are invisible, don't
1588 respond to events and are not part of the tab order. They will,
1589 however, take up space which is required to be able to calculate the
1590 height of the widget.
1592 * src/main/java/org/glom/web/client/Utils.java:
1594 2011-12-01 Ben Konrath <ben@bagu.org>
1596 Use Utils.getWidgetHeight() in FlowTable.
1598 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1600 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1602 2011-12-01 Ben Konrath <ben@bagu.org>
1604 Put the details css class name on the correct table column.
1606 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1608 2011-11-30 Ben Konrath <ben@bagu.org>
1610 Update for java-libglom API change.
1612 The getters and setters on FieldFormatting and NumericFormat were
1613 changed to remove the 'M'.
1615 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1617 2011-11-29 Ben Konrath <ben@bagu.org>
1619 Only allow RelatedListTables in Portals.
1621 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1623 2011-11-29 Ben Konrath <ben@bagu.org>
1625 Only create a contents panel for Portals when title is being set.
1627 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1629 2011-11-29 Ben Konrath <ben@bagu.org>
1631 Set TabLayoutPanel height based on calculated height its widgets.
1633 This is a potential fix for this bug:
1635 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1637 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1639 2011-11-29 Ben Konrath <ben@bagu.org>
1641 Align details field labels and data with the Open buttons.
1643 * src/main/webapp/style.css:
1645 2011-11-29 Ben Konrath <ben@bagu.org>
1647 Remove unnecessary <div> in the Notebook widget.
1649 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1650 method to get container FlowPanel (<div>).
1651 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1652 initWidget() method directly on the TabLayoutPanel widget instead of
1653 Group's container widget.
1655 2011-11-29 Ben Konrath <ben@bagu.org>
1657 Don't add group titles for Portals in Notebooks.
1659 This reverts the previous patch and fixes a bug I introduced with
1660 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1662 * src/main/java/org/glom/web/client/ui/details/Group.java:
1663 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1665 2011-11-28 Ben Konrath <ben@bagu.org>
1667 Remove unused boolean argument in Portal constructor.
1669 Just a code cleanup.
1671 * src/main/java/org/glom/web/client/ui/details/Group.java:
1672 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1674 2011-11-28 Ben Konrath <ben@bagu.org>
1676 Remove hack for glom 1.18 style glom files.
1678 * src/main/java/org/glom/web/client/ui/details/Group.java:
1679 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1680 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1682 2011-11-28 Ben Konrath <ben@bagu.org>
1684 Use Gda Value version of primary key to log result too large error.
1686 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1688 2011-11-28 Ben Konrath <ben@bagu.org>
1690 Don't use TypedDataItem.getText() for Unknown types from the URL.
1692 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1693 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1694 instead of getText().
1695 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1696 String field and getUnknown() method.
1698 2011-11-28 Ben Konrath <ben@bagu.org>
1700 Log an error message when the java-libglom .so is not present.
1702 The error message was being set in the exception but not logged.
1704 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1706 2011-11-28 Ben Konrath <ben@bagu.org>
1708 Ignore LayoutItem_CalendarPortals.
1710 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1711 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1713 2011-11-28 Ben Konrath <ben@bagu.org>
1715 Extract method for creating the LayoutItemPortal DTO.
1717 Just breaking the code up into smaller chunks.
1719 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1721 2011-11-28 Ben Konrath <ben@bagu.org>
1725 This should have been added with the refactor. Oops!
1727 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1729 2011-11-28 Ben Konrath <ben@bagu.org>
1731 Create primary key value from URL string using type from Glom document.
1733 See this bug, comments 19 - 25:
1735 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1737 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1738 create a TypeDataItem for the primary key here when loading from a
1739 URL. Show the same string for the primary key value as was received
1740 from the URL string (when loading from a URL).
1741 * src/main/java/org/glom/web/server/Utils.java: Update method for
1742 creating the Gda Value from the TypeDataItem to properly deal with
1743 creating a Gda Value based on the Glom document type for the primary
1744 key value string when loading from a URL.
1745 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1746 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1747 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1748 Update for changed method name.
1750 2011-11-27 Ben Konrath <ben@bagu.org>
1752 Rename PrimaryKeyItem to TypedDataItem.
1754 The name PrimaryKeyItem suggests what the class should be used for.
1755 TypedDataItem is a neutral name that describes the class better.
1757 This is a rename-only refactor.
1759 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1760 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1761 * src/main/java/org/glom/web/client/Utils.java:
1762 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1763 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1764 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1765 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1766 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1767 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1768 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1769 * src/main/java/org/glom/web/server/Utils.java:
1770 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1771 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1772 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1773 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1775 2011-11-25 Ben Konrath <ben@bagu.org>
1777 Improve Gda Value conversion from PrimaryKeyItem.
1779 The value from the PrimaryKeyItem is only used if its type match the
1780 type from the glom document.
1782 * src/main/java/org/glom/web/server/Utils.java:
1784 2011-11-25 Ben Konrath <ben@bagu.org>
1786 Manually check if the java-liblgom .so is visible to the JVM.
1788 It seems that Tomcat has problems when a static initializer throws an
1789 exception. This check is done before the first method call into
1790 java-libglom so that execution doesn't continue if the .so is not
1793 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1795 2011-11-25 Ben Konrath <ben@bagu.org>
1797 Improve browser configuration error messages.
1801 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1803 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1804 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1805 getConfigurationErrorMessage() method.
1806 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1807 Get and display a specific configuration error message when no Glom
1808 documents are found.
1809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1810 Implement getConfigurationErrorMessage() method. Surround configuration
1811 code in the init() method with a try/catch block. This allows the
1812 errors to be caught while keeping the servlet available to retrieve the
1813 configuration error message.
1815 2011-11-25 Ben Konrath <ben@bagu.org>
1817 Don't use Strings to hold primary key values.
1819 The primary key values are now held in a new data object
1820 (PrimaryKeyItem) that holds type information and the primary key value
1821 using the correct type.
1823 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1824 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1825 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1826 PrimaryKeyItem instead of String to hold the primary key value.
1827 * src/main/java/org/glom/web/client/Utils.java: Remove
1828 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1829 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1830 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1831 PrimaryKeyItem instead of String to hold the primary key value. Load
1832 document selection page when the documentID has not been set correctly.
1833 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1834 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1836 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1837 Return empty string for URL instead of "null".
1838 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1839 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1840 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1841 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1842 PrimaryKeyItem instead of String to hold primary key values.
1843 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1844 PrimaryKeyValue to a Gda Value.
1845 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1846 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1847 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1848 Replace temporary database access code that uses the PrimaryKeyValue to
1849 Gda Value conversion.
1850 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1851 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1852 PrimaryKeyItem instead of String.
1853 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1854 hold primary key values.
1856 2011-11-24 Ben Konrath <ben@bagu.org>
1858 Use newly added java-libglom API to create queries.
1860 This isn't finished. I still need to stop using Strings for primary key
1861 values in the client code.
1863 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1864 libglom to use fake connections so that retrieving the query string will
1866 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1867 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1868 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1869 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1870 Use the newly added libglom sql methods and classes to create the
1871 query. Add temporary hack to convert primary value strings to Gda
1874 2011-11-23 Ben Konrath <ben@bagu.org>
1876 Don't explicitly set the height of Portals.
1878 See comments 6 - 10 of this bug for details:
1880 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1882 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1884 2011-11-23 Ben Konrath <ben@bagu.org>
1886 Use an HTML table instead of CSS for the FlowTable layout.
1888 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1889 GWT's FlexTable to implement the FlowTable.
1890 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1892 2011-11-18 Ben Konrath <ben@bagu.org>
1894 Add boolean example to HTML table mockup.
1896 * mockups/details-view-html-tables-text-entries.html:
1898 2011-11-17 Ben Konrath <ben@bagu.org>
1900 Ensure the pager buttons are always visible for related lists.
1902 To accomplish this, I've turned off text wrapping in the list view and
1903 related list tables for both the header and data text. The related list
1904 table now has a fixed layout so the it doesn't overflow its container.
1905 This is required to ensure that the cell text is clipped when it
1906 overflows the cell and an ellipsis is added to the right side of the
1907 cell when text is clipped.
1909 A fixed table layout for the related list table in the details view
1910 seems what we want for the details view anyway, so the side-effect is
1913 The ellipsis will only be displayed in Firefox >= 7.
1917 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1919 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1920 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1921 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1923 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1924 Set the 'table-layout: fixed' CSS property to the related list table.
1925 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1926 'white-space: nowrap;' CSS property on both the list view and the
1927 related list tables.
1929 2011-11-16 Ben Konrath <ben@bagu.org>
1931 Rework the fix for empty notebook tab labels.
1933 Setting the empty group titles with its name caused problems for the
1934 details layout. Instead of using libglom's
1935 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1936 to the client when the title is empty. This allows the Notebook to use
1937 the name when the title is empty without affecting anything else.
1939 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1940 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1942 2011-11-16 Ben Konrath <ben@bagu.org>
1944 Set group titles with name when title is empty.
1946 This fixes a problem with an empty notebook tab label in the Lesson
1947 Planner document. The forth tab in the notebook should be "Internet":
1949 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1951 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1952 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1955 2011-11-16 Ben Konrath <ben@bagu.org>
1957 Remove whitespace from the configured username properties.
1959 This assumes that usernames won't have whitespace at the beginning
1960 or end. But I think this is a reasonable assumption.
1962 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1963 String.trim() to remove the whitespace from the username properties.
1965 2011-11-15 Ben Konrath <ben@bagu.org>
1967 Add details view mockup with HTML tables and text entries.
1969 This is from the attachment on this bug:
1971 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1973 * mockups/details-view-html-tables-text-entries.html:
1975 2011-11-15 Ben Konrath <ben@bagu.org>
1977 Add space between the columns of the flow table.
1981 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1983 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1984 space between columns in the flow table.
1986 2011-11-15 Ben Konrath <ben@bagu.org>
1988 Add backup files to the .gitignore.
1990 * .gitignore: Ignore files that end with ~.
1992 2011-11-09 Ben Konrath <ben@bagu.org>
1994 Use latest release of gwt-log.
1996 Gwt-log releases are now being submitted to the maven central
1997 repository so manual installation of the jar is no longer required.
1999 * pom.xml: Update version and groupId of gwt-log dependency.
2001 2011-10-31 Ben Konrath <ben@bagu.org>
2003 Don't use GWT numeric formatting to override the glom currency formatting.
2005 Currencies are now displayed like they are in Glom. See this bug:
2007 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2009 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2011 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2012 currency code to constructor and set it when the cell is rendered.
2013 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2014 currency code to the constructor of the NumericCell.
2016 2011-10-27 Ben Konrath <ben@bagu.org>
2018 Require the latest release of java-libglom (1.17.4).
2022 2011-10-26 Ben Konrath <ben@bagu.org>
2024 Add style to Notebook that matches current theme.
2026 It's not the best style in the world but it's better than the default.
2028 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2029 padding at the bottom of the child widgets.
2030 * src/main/webapp/style.css: Add style for the Notebook.
2032 2011-10-26 Ben Konrath <ben@bagu.org>
2034 Move servlet initialization code to overridden init method.
2036 This is half of the solution to getting proper error messages
2037 displayed when configuration errors occur. Here's the relevant bug:
2039 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2041 The rest of the solution involves surrounding the init method with a
2042 try/catch block and setting a global variable with the error /
2043 exception. A new async method should be created to retrieve and display
2044 the error message / exception.
2046 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2047 code from constructor to init method adding exceptions as needed.
2049 2011-10-26 Ben Konrath <ben@bagu.org>
2051 Add script to monitor and restart tomcat if required.
2053 * utils/check-and-recover-tomcat.py: New file.
2055 2011-10-26 Ben Konrath <ben@bagu.org>
2057 Display the correct number of data items in the pager.
2061 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2063 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2064 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2065 The implementation is the same for both tables: Keep track of the
2066 number of non-empty rows and fire and RowCountChangeEvent after the data has
2068 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2069 custom Pager class that subclasses SimplePager to handle displaying
2070 the correct number when empty rows have been added.
2072 2011-10-26 Ben Konrath <ben@bagu.org>
2074 Correct error in previous commit.
2076 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2077 eventBus parameter from listView.setCellTable().
2079 2011-10-26 Ben Konrath <ben@bagu.org>
2081 Fix error in TODO comment.
2083 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2085 2011-10-24 Ben Konrath <ben@bagu.org>
2087 Create Notebook widgets to the details view.
2089 This isn't finished just yet - I still need to create a reasonable
2090 style to match the current theme.
2092 * src/main/java/org/glom/web/client/Utils.java: Add method for
2093 calculating the height of a widget. This is used in the Notebook class.
2094 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2095 new constructor method in Group.
2096 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2097 method for creating child widget that can be used by subclasses
2098 like Notebook. New constructor that allows disabling the group
2099 titles - Notebooks don't set a group title for their child groups.
2100 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2101 to make Notebooks using GWT's TabLayoutPanel.
2102 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2103 constructor that allows disabling the group titles.
2104 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2105 LayoutItemNotebook DTO.
2106 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2107 DTO for Notebooks. It's just an empty class for now but we might need
2108 it to transfer some specific information in the future.
2110 2011-10-21 Ben Konrath <ben@bagu.org>
2112 Add navigation buttons to related list tables.
2114 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2115 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2116 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2117 method getSuitableRecordToViewDetails() for getting the table name
2118 and primary key value for related list navigation buttons.
2119 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2120 private cell renderer class to get the navigation information for
2121 related list tables from the server. Extract the navigation
2122 processing code from the details cell navigation and use it for the
2123 related list navigation as well.
2124 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2125 cell renderer class for the details open buttons. This was needed
2126 because the related list navigation buttons and the list view
2127 navigation buttons need to react differently when clicked.
2128 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2129 the onEnterKeyDown() method because it's now overriden in the
2130 subclasses that are specific to the related list tables and the list
2132 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2133 the vertical size a little because the buttons add a bit of vertical
2134 space to table. This is not a perfect solution because the vertical
2135 size of with table fewer than 5 rows will be a little smaller.
2136 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2137 changes in how navigation buttons are handled.
2138 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2139 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2140 database access object.
2141 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2142 to find the portal for a given relationship name from
2143 RelatedListDBAccess. Add method to find a primary key field for a
2145 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2146 Move code to find the portal for a given relationship name to
2148 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2149 New file: database access object for getting the related list
2150 navigation information (the table name and the primary key value).
2151 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2152 DTO for transferring a table name to navigate to and a primary key
2154 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2155 boolean and getter/setter to specifies if the related list should add
2158 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2160 Use the master branch of java-libglom
2162 * pom.xml: Depend on java-libglom 1.19 instead.
2164 This is the master branch. See also the libglom-1-18 branch.
2166 2011-10-11 Ben Konrath <ben@bagu.org>
2168 Enable the open navigation button when the data has been set.
2170 This avoids having active buttons that don't do anything when the data
2173 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2175 2011-10-11 Ben Konrath <ben@bagu.org>
2177 Use IsWidget interface for FlowTableItem.
2179 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2180 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2182 2011-10-11 Ben Konrath <ben@bagu.org>
2184 Remove GWT styling from open button in details view.
2186 There are still some issues with how the details cell is arranged but
2187 this should be made to match Glom 1.20. I'm going to leave fixing this
2188 until I have Glom 1.20 up and running.
2190 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2191 style name on open button.
2192 * src/main/webapp/style.css: Move and edit details-navigation class.
2193 Re-arrange some classes to make them appear in the same order as the
2196 2011-10-07 Ben Konrath <ben@bagu.org>
2198 Update to GWT 2.4.0.
2200 * .gitignore: Ignore new cache directory.
2201 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2202 * pom.xml: Change GWT and maven plugin to 2.4.0.
2203 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2205 * src/main/java/org/glom/web/client/ClientFactory.java:
2206 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2207 * src/main/java/org/glom/web/client/OnlineGlom.java:
2208 Update source for API changes.
2209 * utils/build-onlineglom-war.sh: Remove cache directory before the
2212 2011-10-07 Ben Konrath <ben@bagu.org>
2214 Add navigation buttons in the details view.
2216 This isn't finished but I thought I'd commit what I have as it's a
2217 pretty good start. I still need to:
2219 1. Change the style so that it fits better into the current theme
2220 2. Adjust the details cell to expand as much as possible.
2222 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2223 click handlers to navigation buttons in the DetailsCells. Create a
2224 refreshData() method to get just the data from the server without the
2226 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2227 Update the tableSelector and browser title when the table name
2228 changes without using the tableSelector.
2229 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2230 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2231 getDetailsCells() to getCells(). Update variable names.
2232 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2233 method to set click handler on navigation button. Rename a few
2234 variables. Add navigation buttons where needed.
2235 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2236 variables and methods.
2237 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2238 navigation boolean and navigation table as required in the
2239 LayoutItemField DTO.
2240 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2241 variables for navigation along with getter/setter methods.
2243 2011-10-07 Ben Konrath <ben@bagu.org>
2245 Rename Field to DetailsCell.
2247 This is a refactor-only commit. No functionality has been added or
2250 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2251 Update variable and method names.
2252 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2253 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2254 variable and method names.
2255 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2257 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2258 variable and method names.
2260 2011-10-07 Ben Konrath <ben@bagu.org>
2262 Create separate methods for layout and data the details view.
2264 This is a refactor-only commit. No functionality has been added or
2267 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2268 private methods: setData(), createLayout().
2270 2011-10-07 Ben Konrath <ben@bagu.org>
2272 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2274 This is part of a change to get navigation buttons in the details view
2275 but it should have been done this way from the start.
2277 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2278 for method name change in TableSelectionView.
2279 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2280 Create TableChangeEvent and set the browser title using the
2281 TableSelectionView API.
2282 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2283 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2284 Change getSelectedTable() to getSelectedTableName(). Add
2285 getSelectedTableTitle().
2287 2011-10-07 Ben Konrath <ben@bagu.org>
2289 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2291 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2293 2011-10-07 Ben Konrath <ben@bagu.org>
2295 Update TableChangeEvent to use newTableName naming convention.
2297 This makes the class more consistent with GWT naming conventions.
2299 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2300 Update for method name change in TableChangeEvent.
2301 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2302 for method name change in TableChangeEvent.
2303 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2304 newTableName variable and getter method. Make toDebugString()
2307 2011-09-30 Ben Konrath <ben@bagu.org>
2309 Disable the pager in the list tables when the data row count is less than the minimum.
2311 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2312 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2314 2011-09-30 Ben Konrath <ben@bagu.org>
2316 Add empty rows to the end of related list and list view tables.
2318 I also extracted the cell rendering classes from the ListTable because
2319 the code was becoming a little crazy with all the anonymous inner
2320 classes. My plan is to use these cell rendering classes in the details
2321 view as well so this refactor will be needed for that change.
2323 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2324 set the row count in related list tables if the data has more rows
2325 than the minimum number of rows visible.
2326 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2327 row count in list view tables if the data has more rows than the
2328 minimum number of rows visible.
2329 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2330 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2332 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2333 for rendering TYPE_NUMERIC cells. The code was extracted from the
2335 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2336 class for rendering cells with buttons in list views. The code was
2337 extracted from the ListTable class.
2338 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2339 for rendering TYPE_TEXT cells. The code was extracted from the
2341 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2342 Add empty rows to the end of the data if required. Implement
2343 ListTable.getMinNumVisibleRows().
2344 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2345 cell renderer code to public classes. Return null in
2346 Column.getValue() for empty rows. Add new abstract method:
2347 getMinNumVisibleRows(). Move code to set the row count of the list view
2348 table to ListViewImpl.
2349 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2350 empty rows to the end of the data if required. Implement
2351 ListTable.getMinNumVisibleRows().
2354 2011-09-27 Ben Konrath <ben@bagu.org>
2356 Use GWT.log for client-side debugging statements.
2358 These are optimized out when deployed so I should have used this method
2359 in the first place. These statements will eventually be replaced with some sort
2360 of notification in the browser.
2362 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2363 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2364 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2365 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2366 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2368 2011-09-27 Ben Konrath <ben@bagu.org>
2370 Put tableselector on the right, back to list link on right.
2372 The idea is that the table selector is acting like a label for the
2373 currently displayed table so it should be placed below the document title. This
2374 puts the table title in a similar position to where it is in Glom.
2376 * mockups/details-contacts.html:
2377 * mockups/details-projects.html:
2378 * mockups/listview-contacts.html:
2379 * mockups/listview-projects.html:
2380 * mockups/style.css:
2381 Update mockups to match how the interfaces currently look.
2382 * src/main/webapp/style.css: Swap positions of backlink with the table
2383 selector. Add some space on the left side of the table selector to
2384 line things up with the document title.
2386 2011-09-27 Ben Konrath <ben@bagu.org>
2388 Add field colouring to details view.
2390 This change re-works how field colouring works. The colour formatting
2391 information is now set to the client with the layout information instead of
2392 with the data. This eliminates the need to send the same colour strings for
2393 data in list view column when colour information is set.
2395 In order to set an alternate colour for negative numeric values, the
2396 number is now sent to client and formatted with the GWT NumberFormat class.
2398 This change also fixes:
2400 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2402 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2403 internationalization framework which is needed for client side numeric
2405 * src/main/java/org/glom/web/client/Utils.java: New file for some
2406 client static utility methods.
2407 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2408 the DataItem object to the Field class. Use a utility method to
2409 create the foreignKeyValue string.
2410 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2411 alignment and text colours in the constructor. Add setData(DataItem)
2412 method. Remove setText(String) method.
2413 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2414 colour information to GlomTextCell. Create and use GlomNumberCell for
2415 rendering numbers. Use utility method to get the string for the
2416 primary key of the key provider. Re-work how the horizontal alignment
2418 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2419 formatting to layout information. Methods for converting the libglom
2420 formatting information were moved from DBAccess.
2421 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2422 numeric formatting (it's now done on the client side). Don't set text
2423 colours in DataItem. Move libglom formatting conversion methods to
2425 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2426 getters/setters for text colour information.
2427 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2428 for transferring the libglom NumericFormat information to the client.
2429 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2430 and getters/setters for: GlomNumericFormat, background colour and
2431 foreground colour strings.
2433 2011-09-26 Ben Konrath <ben@bagu.org>
2435 Simplify code that iterates through the LayoutGroup.
2437 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2439 2011-09-26 Ben Konrath <ben@bagu.org>
2441 Accept Eclipse formatting for OnlineGlomServiceAsync.
2443 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2445 2011-09-26 Ben Konrath <ben@bagu.org>
2447 Don't use the ListDBAccess classes to get the primary key layout information.
2449 This was causing a bug where the wrong index for the hidden primary key
2450 was being sent to the client.
2452 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2453 primary key while creating the LayoutGroup DTO. Create a
2454 LayoutItemField DTO for hidden primary keys. Don't use the
2455 RelatedListDBAccess because it was only used for getting the primary
2457 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2458 access modifier from public to protected for getPrimaryKeyField() and
2459 getPrimaryKeyLayoutItemField().
2460 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2461 abstract method getExpectedResultSize() because RelatedListDBAccess
2462 doesn't have enough info to implement it.
2463 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2464 Remove @Override for getExpectedResultSize().
2465 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2466 Remove method getExpectedResultSize().
2468 2011-09-23 Ben Konrath <ben@bagu.org>
2470 Log which layout (list or details) the ignored item is from.
2472 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2474 2011-09-23 Ben Konrath <ben@bagu.org>
2476 Remove annotations that turn off code formatting in DataItem.
2478 * src/main/java/org/glom/web/shared/DataItem.java:
2480 2011-09-23 Ben Konrath <ben@bagu.org>
2482 Rename GlomField to DataItem and update associated methods.
2484 This is a rename-only refactor. No functionality has been added or
2487 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2488 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2489 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2490 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2491 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2492 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2493 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2494 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2495 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2496 * src/main/java/org/glom/web/server/database/DBAccess.java:
2497 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2498 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2499 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2500 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2501 * src/main/java/org/glom/web/shared/DataItem.java:
2502 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2503 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2505 2011-09-23 Ben Konrath <ben@bagu.org>
2507 Rename GlomDocument to DocumentInfo and update associated methods.
2509 This is a rename-only refactor. No functionality has been added or
2512 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2513 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2514 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2515 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2516 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2518 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2520 2011-09-20 Ben Konrath <ben@bagu.org>
2522 Require java-libglom 1.17.3.
2524 This picks up the fix for the seg fault problem with the Scenes table
2525 in the Openismus Film Manager example.
2529 2011-09-20 Ben Konrath <ben@bagu.org>
2531 Change the way sort clause is added for primary key when no sort clause is requested.
2533 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2534 before the sort clause is created. When a sort clause is not requested, the
2535 sort clause is created by finding the primary key in the LayoutFieldVector
2538 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2540 2011-09-20 Ben Konrath <ben@bagu.org>
2542 Log error message if no documents are found in the configured directory.
2544 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2545 Extract the glom file extension string to a private static final class
2546 variable (mostly as syntactic sugar). Accept a minor formatting change.
2547 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2548 the example glom.document.directory configuration property to make it
2549 more clear that it can any directory, not just the home directory.
2551 2011-09-18 Ben Konrath <ben@bagu.org>
2553 Add related lists to details view.
2555 The related list table has support for paging and sorting just like the
2556 table in the list view.
2558 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2559 SQL queries for the related list tables.
2560 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2561 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2562 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2563 Rename getList methods to getListView and add comments. Remove
2564 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2565 it being unused. Add methods: getDetailsLayoutAndData(),
2566 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2567 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2568 Create the layout and set the data for the fields in one async call
2569 instead of two. Create related lists where appropriate.
2570 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2571 for method name changes in OnlineGlomService.
2572 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2573 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2574 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2576 * src/main/java/org/glom/web/client/ui/ListView.java:
2577 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2578 tableName from setCellTable(). Create a ListViewTable instead of
2580 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2581 represent a data field in the details view.
2582 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2583 from addDetailsCell() to Field class. Keep track of the Fields and
2584 Portals in the details view.
2585 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2586 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2587 and add a method to get it. Add method to set the contents of the
2589 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2590 New class for related list tables. This class has the data provider
2591 for the related list table.
2592 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2593 abstract class which is the base class for the ListViewTable and the
2595 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2596 New class for list view tables. This class has the data provider for
2597 the list view table.
2598 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2599 methods for related list tables. Add more information to the
2600 LayoutItemField and LayoutItemPortal DTOs.
2601 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2602 Remove debugging print statement.
2603 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2604 Remove debugging print statements. Add primary key field to SQL count
2606 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2607 Remove unnecessary LayoutFieldVector parameter from
2608 getResultSizeOfSQLQuery() method.
2609 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2610 New class for related list table database access.
2611 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2612 class that is a wrapper DTO for details view layout and data.
2613 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2614 new 'fromField' string to this DTO.
2615 * src/main/webapp/style.css: Remove bottom margin and override top
2618 2011-09-15 Ben Konrath <ben@bagu.org>
2620 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2622 This sets things up to make it easier to add the data retrieval for
2623 related lists (portals). No user noticeable changes were made with
2626 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2627 class has the code to retrieve the layouts and access the
2628 database using the new database helper classes.
2629 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2630 Most of the functionality has been removed from this class. This
2631 class now represents the public interface for the client side
2632 code. It also deals with configuring the servlet and cleaning
2633 things up when the servlet is stopped.
2634 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2635 of static methods into this utility class.
2636 * src/main/java/org/glom/web/server/database/DBAccess.java:
2637 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2638 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2639 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2640 These classes have the database retrieval code. The class hierarchy
2641 has been setup to make it easy to reuse code for similar
2644 2011-09-06 Ben Konrath <ben@bagu.org>
2646 Create separate classes for list table code and the data provider.
2648 As part of this refactor, I also split up the code a bit to make it
2651 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2652 table code to two new classes (below).
2653 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2654 with code from ListViewImpl.
2655 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2656 New file with code from ListViewImpl.
2658 2011-09-06 Ben Konrath <ben@bagu.org>
2660 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2662 This fixes the LayoutItemPortal DTO to match the libglom layout object
2665 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2667 2011-09-01 Ben Konrath <ben@bagu.org>
2669 Set title of Portals in the Details View.
2671 * pom.xml: Bump required version of java-libglom to 1.17.1.
2672 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2673 widget creation to its own class. Add comments to constructor.
2674 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2675 The code is mostly from the Group class with the title now set.
2676 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2677 title of Portal. Update some comments. Fix some code formatting.
2679 2011-09-01 Ben Konrath <ben@bagu.org>
2681 Remove TODO comment for the flow table column width.
2683 The flow table column width is working correctly and doesn't need to be
2684 changed. See this mailing list post for more info:
2686 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2688 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2690 2011-08-27 Ben Konrath <ben@bagu.org>
2692 Add document title (database name) to top of the browser page.
2694 I added the document title to the TableSelecitonView but that will
2695 change if / when we add a view that doesn't require table selection.
2697 * mockups/details-contacts.html:
2698 * mockups/details-projects.html:
2699 * mockups/listview-contacts.html:
2700 * mockups/listview-projects.html:
2701 * mockups/style.css: Add document title to mockups to keep things
2703 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2704 sizes to account for the document title.
2705 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2706 Set the document title when it has been retrieved from the server.
2707 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2708 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2709 and implement setDocumentTitle(String) method.
2710 * src/main/webapp/style.css: Add ID for document title style.
2712 2011-08-25 Ben Konrath <ben@bagu.org>
2714 Add NavigationType enum to LayoutItemPortal DTO.
2716 This is the start of adding support for Portals to the Details View.
2718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2719 LayoutItem_Portal.navigation_type enum from libglom to
2720 LayoutItemPortal.NavigationType enum.
2721 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2722 NavigationType enum, field for storing the NavigationType and getter
2725 2011-08-25 Ben Konrath <ben@bagu.org>
2727 Implement the flow table layout in the Details View.
2729 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2730 FlowTable to Group to account for the renamed class.
2731 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2732 File. This is a container widget that implements the Glom details view
2733 flow table behaviour.
2734 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2735 org/glom/web/client/ui/FlowTable.java.
2736 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2737 so that the size of the subgroups are a closer match to the size of
2738 the Glom subgroups. This makes the flowtable layout match the layout
2739 in Glom for the Music Collection example file.
2741 2011-08-16 Ben Konrath <ben@bagu.org>
2743 Create container element for LayoutItemPortal in Details View.
2745 This will help me develop the layout for the FlowTable.
2747 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2748 fieldPanel variable to detailsCell.
2750 2011-08-15 Ben Konrath <ben@bagu.org>
2752 Set the height of the data element in the Details View.
2754 I changed the InlineLabels (text in a span element) to Labels (text in
2755 a div element) so that I could set the height of the details-data
2756 elements instead of the details-cell parent elements. This allows the
2757 the details-data element to display the correct height if style is
2758 applied that shows the height.
2760 This change has the added benefit of allowing the order of the labels
2761 and data elements to be changed for right-to-left languages.
2763 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2764 InlineLabels to Labels.
2765 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2766 InlineLabels to Labels. Set the height of the data element.
2767 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2768 multiline text height in the Formatting DTO.
2769 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2770 for multiline height along with getter and setter methods.
2771 * src/main/webapp/style.css: Adjust style to account for the change
2772 from span elements to div elements in the details cell.
2774 2011-08-15 Ben Konrath <ben@bagu.org>
2776 Make the List View appearance match the mockups.
2778 It doesn't match exactly but it's much better than it was.
2780 * mockups/listview-contacts.html: Remove unused css classes.
2781 * mockups/listview-projects.html: Remove unused css classes.
2782 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2783 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2784 for mainPanel instead of VerticalPanel (table). Set style name on
2785 CellTable. Set style name on Details column. Right-align Details
2787 * src/main/webapp/style.css: Adjust properties to match the mockups.
2789 2011-08-12 Ben Konrath <ben@bagu.org>
2791 Add better support for subgroups in the details view.
2793 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2794 changed FlowTable constructor.
2795 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2796 support for subgroups and subgroup-titles.
2797 * src/main/webapp/style.css: Add CSS class for subgroups and
2800 2011-08-12 Ben Konrath <ben@bagu.org>
2802 Return the top level LayoutGroup title.
2804 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2806 2011-08-11 Ben Konrath <ben@bagu.org>
2808 Make the TableSelector header match the mockup.
2810 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2811 the layout panel. Properly lineup the table selection header with
2812 the list and details view.
2813 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2814 margin around the details view.
2815 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2816 Rename listBox variable to tableSelector. Set id for the style sheet.
2817 Use a FlowPanel instead of a HorizontalPanel.
2818 * src/main/webapp/style.css: Add properties to make the TableSelector
2819 box match the mockups.
2821 2011-07-13 Ben Konrath <ben@bagu.org>
2823 Update install script for java-libglom version change.
2825 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2828 2011-07-13 Ben Konrath <ben@bagu.org>
2830 Add support sub-group in the details view.
2832 I also removed the code that special-cased the default details view
2835 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2837 I still have to make a proper flowtable.
2839 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2840 Don't special-case default details view layout.
2841 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2842 addLayoutField() as I'm going to use it.
2843 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2844 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2846 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2847 extracted from DetailsViewImpl.GroupPanel. Add support for
2849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2850 column count when getting the details layout.
2852 2011-07-12 Ben Konrath <ben@bagu.org>
2854 Set browser title with database and table titles.
2856 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2857 Set the browser title when the table changes and when the activity
2859 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2860 title when retrieving document info (the GlomDocument object).
2861 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2862 with getter and setter methods. Remove unused convenience constructor.
2863 Use default code formatting.
2865 2011-07-12 Ben Konrath <ben@bagu.org>
2867 Ignore LayoutItemPortals in the details view.
2869 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2872 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2873 LayoutItemPortal layout objects.
2874 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2875 LayoutItemPortal objects when retrieving the details layout.
2876 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2877 file. This is an empty class and just used to get type information for
2880 2011-07-12 Ben Konrath <ben@bagu.org>
2882 Use java-libglom 1.17.0.
2886 2011-07-11 Ben Konrath <ben@bagu.org>
2888 Remove "Table:" label from table selector.
2890 This matches a recent change in the Glom UI.
2892 * mockups/details-contacts.html:
2893 * mockups/details-projects.html:
2894 * mockups/listview-contacts.html:
2895 * mockups/listview-projects.html: Remove the "Table:" label from the
2897 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2899 2011-07-11 Ben Konrath <ben@bagu.org>
2901 Add main groups to the details view.
2903 This makes things look a little nicer in the details view. The next step
2904 is to implement the flowtable.
2906 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2907 resources from the standard gwt css theme. Standard.css is now
2908 included in OnlineGlom.html so that the online glom css rules have
2909 precedence over the gwt theme.
2910 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2911 the whole LayoutGroup to the DetailsView instead of just the titles.
2912 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2913 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2914 details layout with a helper class (GroupPanel). I might extract this
2915 class when I make the full flowtable.
2916 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2917 string as default so I don't have to worry about NPEs when processing
2919 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2920 note beside OnlineGlom.gwt.xml above).
2921 * src/main/webapp/style.css: Add default font-size to body to override
2922 the font-size set by the standard theme. Don't use h2 tags for
2923 group-title. Create new details-cell class.
2925 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2927 ConfiguredDocument: Set the port number too.
2929 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2930 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2931 Glom document. Presumably this worked sometimes so far because there is a
2932 default port number.
2934 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2936 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2938 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2939 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2940 correct, though we should throw an exception too.
2942 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2944 Fix a addDocuemnt typo.
2946 * src/main/java/org/glom/web/shared/Documents.java
2947 (Documents.addDocuemnt): Rename to addDocument().
2948 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2949 (OnlineGlomServiceImpl.getDocuments): Adapt.
2951 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2953 Slightly improved log output when connection fails.
2955 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2956 (ConfiguredDocument.setUsernameAndPassword):
2957 We don't know for sure if it' the username/password that's wrong, so
2958 rephrase the message.
2959 Also ouput the exception message, though it's generic in this case.
2961 2011-07-08 Ben Konrath <ben@bagu.org>
2965 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2966 added braces to a one line if statement because the Eclipse formatter
2967 was getting confused.
2969 2011-07-07 Ben Konrath <ben@bagu.org>
2971 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2973 These should really be two separate tasks but I counldn't get things to
2974 work with GWT 2.2.0 and Eclipse 3.7.
2978 * .settings/org.eclipse.jdt.core.prefs:
2979 * .settings/org.eclipse.jdt.ui.prefs:
2980 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2981 * .settings/org.eclipse.m2e.core.prefs:
2982 Add new config files. Update current files. Remove references to the
2983 webtools plugins as we're not using any of the webtools features.
2984 * .gitignore: Add logs directory which is created when running with
2986 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2987 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2988 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2990 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2992 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2994 onlineglom.properties: Add explanatory comments.
2996 * src/main/resources/onlineglom.properties: Also change the default user
2997 from ben to someuser, to avoid the risk of people thinking we just
2998 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3000 2011-06-28 Ben Konrath <ben@bagu.org>
3002 Use filename in Log for incorrect passwords.
3004 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3005 getFileName(String) method to get the filename from the URI.
3007 2011-06-28 Ben Konrath <ben@bagu.org>
3009 Add the table name to the URL token for the ListPlace.
3011 This makes things consistent between the DetailsPlace and the
3012 ListPlace. It also allows the the ListPlace to be bookmarked.
3014 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3015 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3016 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3017 Remove getDefaultListLayout(). The default layout is now returned
3018 by the getListLayout() method when the table name is an empty string.
3019 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3020 Add table name field. Change to a new ListPlace when the table
3021 has been changed. Use getListLayout() for getting the default
3023 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3024 Add table name field. Set the correct table name in the list box
3025 when loading from bookmark. This corrects a problem for the
3027 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3028 Move table name to super-class (HasSelectableTable). Move document
3029 and table URL keys to super-class in HasSelectableTable.
3030 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3031 Add table name field. Add Tokenizer class with URL key common to
3032 the subclasses (DetailsPlace and ListPlace).
3033 * src/main/java/org/glom/web/client/place/ListPlace.java:
3034 Add table name. Add code to parse the URL token.
3035 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3036 Update ListPlace construction with empty table name string.
3037 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3038 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3039 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3040 Update ListPlace construction with table name string.
3041 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3042 Change defaultTableName field to tableName to reflect how it's now
3043 used. Update the getter and setter methods.
3045 2011-06-28 Ben Konrath <ben@bagu.org>
3047 Enable the table selector in the DetailsView.
3049 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3050 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3051 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3052 Remove getDefaultDetailsLayout(). The default layout is now returned
3053 by the getDetailsLayout() method when the table name is an empty
3055 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3056 event handler for table change event. Change to using
3057 getDetailsLayout() for the default details layout.
3058 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3060 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3061 when navigating to the details place.
3063 2011-06-27 Ben Konrath <ben@bagu.org>
3065 Use filename based unique document ID in URL and for RPC.
3067 The document ID is the glom document name with spaces (' ') replaced
3068 with pluses ('+') and without the .glom extension.
3070 This change is mostly a string substitution of 'documentTitle' for
3071 'documentID'. The only code change is the addition of a Documents DTO to get the
3072 filename to document title mappings as indicated below.
3074 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3075 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3076 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3077 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3078 Use Documents DTO to create the document links in the document
3080 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3081 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3082 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3083 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3084 * src/main/java/org/glom/web/client/place/ListPlace.java:
3085 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3086 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3087 * src/main/java/org/glom/web/client/ui/ListView.java:
3088 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3089 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3090 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3091 * src/main/java/org/glom/web/server/Log.java:
3092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3093 getDocumentTitles() to getDocuments() and return the Documents DTO.
3094 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3095 transferring the filename to document title mappings.
3097 2011-06-25 Ben Konrath <ben@bagu.org>
3099 Make the authentication popup work again.
3101 This bug was introduced when I extracted ConfiguredDocument to its own class.
3103 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3104 correct success / fail status in setUsernameAndPassword().
3106 2011-06-25 Ben Konrath <ben@bagu.org>
3108 Use filename as unique key for configuring database usernames and passwords.
3110 This replaces the use of the Glom document title which could change
3111 depending on the locale. Thanks to Murray Cumming for pointing out this
3114 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3115 * src/main/resources/onlineglom.properties:
3117 2011-06-24 Ben Konrath <ben@bagu.org>
3119 Pass primary key value to DetailsView.
3121 This enables the DetailsView to load the correct data.
3123 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3124 primary key value field and set in constructor. Pass primary key
3125 value to getDetailsData().
3126 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3127 variables for document title and primary key value.
3128 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3129 key value to the DetailsPlace.
3131 2011-06-24 Ben Konrath <ben@bagu.org>
3133 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3135 This allows the primary key to be retrieved by the Details button. This
3136 functionality has not been implemented yet but it's in the works.
3138 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3139 the LayoutGroup result to ListView.setCellTable instead of all of its
3140 fields individually.
3141 * src/main/java/org/glom/web/client/ui/ListView.java:
3142 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3143 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3144 get the primary key for the table.
3145 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3146 index of the primary key in the LayoutGroup accounting for hidden
3147 primary keys. Rename getJavaNumberFormat() to
3148 convertToJavaNumberFormat() for consistency. Cleanup / add some
3150 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3151 field for primary key index and a field to indicate whether the
3152 primary key is hidden or not.
3154 2011-06-23 Ben Konrath <ben@bagu.org>
3156 Rename getTableData methods to getListData.
3158 This is a rename refactor for consistency with other methods.
3160 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3161 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3162 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3165 2011-06-23 Ben Konrath <ben@bagu.org>
3167 Extract the ConfiguredDocument innerclass into its own class.
3169 This makes the servlet code more object oriented.
3171 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3172 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3174 new ConfiguredDocument class.
3176 2011-06-21 Ben Konrath <ben@bagu.org>
3178 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3180 This makes things more inline with how libglom works and reduces code
3181 duplication. This refactor lays the groundwork for adding the primary key to
3182 the LayoutGroup object.
3184 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3185 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3187 Change method names to getListLayout and getDefaultListLayout for
3188 consistency. Use LayoutGroup as the DTO for the list layout instead of
3189 ColumnInfo and LayoutListTable.
3190 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3191 new method names along with the LayoutGroup object for transferring the
3193 * src/main/java/org/glom/web/client/ui/ListView.java:
3194 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3195 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3196 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3198 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3199 Replaced with LayoutGroup.
3200 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3201 expectedResultSize and defaultTableName fields which are needed for
3203 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3204 type field which is needed for the list layout but will also be
3205 useful for the details layout as things progress.
3206 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3207 Make class abstract. Remove the unnecessary
3208 getFormattingHorizontalAlignment method. Add setFormatting method.
3210 2011-06-16 Ben Konrath <ben@bagu.org>
3212 Add scripts for building and installing war.
3214 These will help when updating OnlineGlom but they're also good
3215 supplemental documentation of the build and deployment proceeding.
3217 * utils/build-onlineglom-war.sh: New file.
3218 * utils/install-onlineglom-war.sh: New file.
3220 2011-06-16 Ben Konrath <ben@bagu.org>
3222 Create wrapper class to create consistent log messages.
3224 I wrapped methods in the Log class of gwt-log to add the method names
3225 from the servlet and create consistent formatting of the document title
3226 and table names in the log messages.
3228 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3229 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3230 log methods to use methods from wrapped Log class.
3232 2011-06-16 Ben Konrath <ben@bagu.org>
3234 Remove superfluous conditional return.
3236 Thanks to Murray Cumming for pointing this out!
3238 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3240 2011-06-15 Ben Konrath <ben@bagu.org>
3242 Return an ArrayList of LayoutGroups for the Details layout.
3244 This corrects a problem with the details layout as it can have more
3245 than one top level LayoutGroup.