1 2012-03-06 Murray Cumming <murrayc@murrayc.com>
3 ReportGenerator: Do not show nulls.
5 2012-03-06 Murray Cumming <murrayc@murrayc.com>
7 ReportGenerator: Make the title font larger.
9 2012-03-06 Murray Cumming <murrayc@murrayc.com>
11 ReportGenerator: Put field titles inside groups, if there are groups.
13 2012-03-06 Murray Cumming <murrayc@murrayc.com>
15 ReportGenerator: Take the Report itself instead of the name and group.
17 * src/main/java/org/glom/web/server/ConfiguredDocument.java
18 Remove getReportLayoutGroup().
19 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
20 getReportHTML(): Pass the report instead
21 of its name and layout group.
22 * src/main/java/org/glom/web/server/ReportGenerator.java
23 generateReport(): Use the report object to use the title
26 2012-03-06 Murray Cumming <murrayc@murrayc.com>
28 ReportGenerator: Remove designBand parameters.
30 * src/main/java/org/glom/web/server/ReportGenerator.java:
31 Make designBand a class member instead of passing it to all
34 2012-03-06 Murray Cumming <murrayc@murrayc.com>
36 ReportGenerator: Add lines, a bit like in the desktop version.
38 * src/main/java/org/glom/web/server/ReportGenerator.java
39 addToReport(): Use JRDesignLine.
41 2012-03-06 Murray Cumming <murrayc@murrayc.com>
43 ReportGenerator: Correct the title positions and use some bold style.
45 * src/main/java/org/glom/web/server/ReportGenerator.java:
46 Break the code up into reusable functions, correct the placement of
47 titles, and use normal/bold styles as in the reports in the desktop
50 2012-03-06 Murray Cumming <murrayc@murrayc.com>
52 ReportGenerator: Add a header band to show the field titles.
54 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
55 getReportHTML(): Pass the localeId to the ReportGenerator
57 * src/main/java/org/glom/web/server/ReportGenerator.java
58 constructor: Take the localeID so we can get translated field
60 generateReport(), addToReport(), addFieldToBand(): Add field
61 titles in a column header band.
63 2012-03-05 Murray Cumming <murrayc@murrayc.com>
65 Reports drop-down list: Some improvement.
67 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
68 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
69 Adedd setSelectedReport(),
70 setReportList(): Add a blank line so that the user can select the
72 * src/main/java/org/glom/web/client/activity/ReportActivity.java
73 start(): Show the current report by calling setSelectedReport().
74 This does not seem to work yet.
76 2012-03-05 Murray Cumming <murrayc@murrayc.com>
78 DetailsActivity, ListActivity: Move some variables into a base class.
80 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
81 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
82 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
83 the clientFactory, documentID, tableName and authenticationPopup into
84 a base class, to avoid duplication.
86 2012-03-05 Murray Cumming <murrayc@murrayc.com>
88 Translate the Reports label.
90 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
91 Get the "Reports" label string from the constants.
92 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
93 perties: Add Reports to the constants.
95 2012-03-03 Ben Konrath <ben@bagu.org>
97 Display date and time in details view.
99 https://bugzilla.gnome.org/show_bug.cgi?id=671257
101 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
103 2012-03-05 Murray Cumming <murrayc@murrayc.com>
105 Require the latest java-libglom.
107 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
109 2012-03-05 Murray Cumming <murrayc@murrayc.com>
111 Reports: Implement grouping.
113 * src/main/java/org/glom/web/server/ReportGenerator.java:
114 Handle LayoutItem_GroupBy items and try to do the right thing
115 with JRDesignGroup. It seems to work.
117 2012-03-04 Murray Cumming <murrayc@murrayc.com>
119 Actually show some data with JasperReports.
121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
122 getReportHTML(): Move most code into a ReportGenerator class.
123 * src/main/java/org/glom/web/server/ReportGenerator.java:
124 Recurse into sub-groups, adding fields to the JasperDesign's details
125 band. Note that we must set an arbitrary width and height, or it just
126 will not show any data.
128 2012-03-04 Murray Cumming <murrayc@murrayc.com>
130 Reports Chooser: Show the titles, not the names.
132 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
133 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
134 and the names as the values.
135 * src/main/java/org/glom/web/server/ConfiguredDocument.java
136 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
137 group now that we provide the report name, so it should always
140 2012-03-04 Murray Cumming <murrayc@murrayc.com>
142 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
144 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
145 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
146 an empty quickfind string. I also corrected libglom to create only
147 empty where clauses for empty quickfind strings, but this avoids the
150 2012-02-24 Ben Konrath <ben@bagu.org>
152 Improve the tabs in the Notebook widget.
156 2012-02-15 Murray Cumming <murrayc@murrayc.com>
158 Depend on jasperreports.
160 * pom.xml: Add the dependency. My plan is to use this on the
163 2012-01-31 Murray Cumming <murrayc@murrayc.com>
165 Implement navigation to report places.
167 * src/main/java/org/glom/web/client/activity/ReportActivity.java
168 start(): Do not bother to handle all events here.
169 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
170 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
171 Added getSelectedReport().
172 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
173 .java: start(): When handling a change to the reports chooser,
174 call getSelectedReport() and goTo() its ReportPlace.
175 * src/main/java/org/glom/web/client/ui/ReportView.java
176 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
177 Added setReportHTML() which puts the html in a gwt HTML widget.
178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
179 getReportHTML(): Return "TODO" just to show that this works.
181 2012-01-31 Murray Cumming <murrayc@murrayc.com>
183 Make ReportPlace usable.
185 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
187 * src/main/java/org/glom/web/client/place/ReportPlace.java:
188 Correct the @prefix annotation.
190 2012-01-31 Murray Cumming <murrayc@murrayc.com>
192 OnlineGlomService: Return report HTML rather than the LayoutGroup.
194 * src/main/java/org/glom/web/client/OnlineGlomService.java:
195 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
197 Change getReportLayout() to getReportHMTL() because we will not need to
198 parse or render the report layout on the client side.
199 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
200 getReportLayout(): Return the libglom LayoutGroup type because we will
201 not need to convert to a shared type, because this will not be used on
203 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
206 Note that there is still no implementation for this.
208 2012-01-30 Murray Cumming <murrayc@murrayc.com>
210 Translations: Try to translate the strings.
212 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
213 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
214 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
215 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
216 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
217 Take the Open translation from GTK+'s .po files.
218 Take the Details translation from Glom's po files.
219 I have added the other strings to Glom so we can get translations that way:
220 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
222 2012-01-27 Murray Cumming <murrayc@murrayc.com>
224 Add a (empty) Report Place, View, and Activity.
226 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
228 * src/main/java/org/glom/web/client/place/HasTablePlace.java
229 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
230 this into a superclass:
231 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
232 and also use it as the base of this new ReportPlace:
233 * src/main/java/org/glom/web/client/place/ReportPlace.java
235 * src/main/java/org/glom/web/client/ui/ReportView.java
236 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
237 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
238 Add these, containing mostly boiler-plate for now.
240 * src/main/java/org/glom/web/client/OnlineGlomService.java
241 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
242 * src/main/java/org/glom/web/server/ConfiguredDocument.java
243 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
244 Add API to get the LayoutGroup for the report.
246 2012-01-27 Murray Cumming <murrayc@murrayc.com>
248 TableSelectionViewImpl: Put the search label and entry in a div.
250 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
251 Put the search widgets in a FlowTable so that the CSS can be used to
252 style them while keeping them together.
253 * src/main/webapp/style.css: Mention the new div.
255 2012-01-27 Murray Cumming <murrayc@murrayc.com>
257 Translate more strings in more locales.
259 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
260 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
261 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
262 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
263 Translate the "Details" and "Open" string too.
265 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
266 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
267 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
268 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
269 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
270 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
271 Add these new locales as placeholders though they currently contain English.
273 2012-01-27 Murray Cumming <murrayc@murrayc.com>
275 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
278 Check the ConfiguredDocument* for null before using it.
280 2012-01-26 Murray Cumming <murrayc@murrayc.com>
282 Tell Eclipse about the generated java files.
284 * .classpath: This lets it find OnlineGlomConstants.java.
285 It would be nice if Eclipse just used the maven build files.
287 2012-01-26 Murray Cumming <murrayc@murrayc.com>
289 Prevent a crash when no locale is specified in the URL.
291 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
292 Avoid returning a null string, obtained from
293 Window.Location.getParameter(). This caused a crash when it was
294 later passed to libglom's API.
295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
296 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
297 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
298 guard against future null strings.
300 2012-01-26 Murray Cumming <murrayc@murrayc.com>
302 Use the ?locale= query param instead of the &lang= token param.
304 * src/main/java/org/glom/web/client/place/ListPlace.java
305 * src/main/java/org/glom/web/client/place/DetailsPlace.java
306 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
307 Remove the lang token key and value.
309 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
310 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
311 When the user selects a different locale from the chooser, use
312 Window.Location.assign() to change the URL, which then causes a reload.
314 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
315 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
316 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
317 * src/main/java/org/glom/web/client/activity/ListActivity.java
318 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
319 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
320 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
321 * src/main/java/org/glom/web/client/ui/ListView.java:
322 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
324 Remove localeID member variables and method/constructor parameters, instead
325 using Utils.getCurrentLocaleID() when we need a localID to pass to
328 2012-01-26 Murray Cumming <murrayc@murrayc.com>
330 Internationalize the UI strings.
332 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
333 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
334 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
335 because it is unused. Messages are apparently strings that can have
336 parameters, but we do not need that yet, so Contants will be enough for now.
337 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
338 to say that we support the en and de locales.
339 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
340 The original English strings.
341 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
342 Some German translations of the English strings.
343 The i18n goal then uses the .properties file to generate an
344 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
345 returns an implementation that returns the translated strings.
346 The documentation suggests putting these in src/java/*/client/, but it seems
347 best to put it in src/resources/*/client/.
348 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
349 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
350 instead of hard-coding them.
351 Note that we cannot import OnlineGlomConstants because it does not exist yet,
352 but that does not seem to stop the build, though it confuses Eclipse.
354 You can see the translated string by adding ?locale=de to the URL, like so:
355 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
357 2012-01-24 Murray Cumming <murrayc@murrayc.com>
359 Improve null/empty String checks.
361 * pom.xml: Add a dependency on commons-lang, to use
362 org.apache.commons.lang.StringUtils.
363 * src/main/java/org/glom/web/server/ConfiguredDocument.java
364 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
365 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
366 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
367 Use StringUtils.isEmpty().
369 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
370 StringUtils class with a static isEmpty() function because we
371 cannot use org.apache.commons.lang.StringUtils in client-side
372 GWT code because it (apparently) cannot be compiled to javascript.
373 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
374 * src/main/java/org/glom/web/client/activity/ListActivity.java
375 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
376 * src/main/java/org/glom/web/client/place/DetailsPlace.java
377 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
378 * src/main/java/org/glom/web/client/place/ListPlace.java
379 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
380 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
381 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
382 * src/main/java/org/glom/web/client/ui/details/Group.java
383 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
384 our StringUtils.isEmpty() function.
386 2012-01-24 Murray Cumming <murrayc@murrayc.com>
388 Update to the latest java-libglom API.
390 * pom.xml: Require java-libglom 1.21.4.
391 * src/main/java/org/glom/web/server/ConfiguredDocument.java
392 getDocumentInfo(), getListViewLayoutGroup():
393 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
395 * src/main/java/org/glom/web/server/database/DBAccess.java
396 getFieldsToShowForSQLQueryAddGroup(),
397 getPrimaryKeyLayoutItemField(): Replace get_database_title()
398 with either get_database_title_original() or
399 get_database_title(localeID).
401 2012-01-24 Murray Cumming <murrayc@murrayc.com>
403 ConfiguredDocument: Avoid a null pointer exception.
405 * src/main/java/org/glom/web/server/ConfiguredDocument.java
406 Initialize localeID to "" to avoid returning a null String which
407 causes a crash in java-libglom's swing-generated code.
409 2012-01-23 Murray Cumming <murrayc@murrayc.com>
411 Some simple renaming.
413 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
414 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
415 for localeChooser. This seems more appropriate and is less ambiguous
416 particularly in the .css file.
418 2012-01-23 Murray Cumming <murrayc@murrayc.com>
420 ConfiguredDocument: Rename the localedID private member variable.
422 2012-01-23 Murray Cumming <murrayc@murrayc.com>
424 Adapt to the latest java-libglom API from git master.
426 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
427 libglom now uses only Vector instead of List, which uses add() instead of
430 2012-01-23 Murray Cumming <murrayc@murrayc.com>
432 Add and fill a Reports drop-down list box.
434 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
436 * src/main/java/org/glom/web/client/OnlineGlomService.java:
437 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
438 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
439 Added getReports(document, table, localeID), calling
440 ConfiguredDocument.getReports().
441 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
442 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
443 Added setReportsList() and a list widget.
444 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
445 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
447 2012-01-22 Murray Cumming <murrayc@murrayc.com>
449 ConfiguredDocument: Rename the localedID private member variable.
451 2012-01-20 Murray Cumming <murrayc@murrayc.com>
453 Build a source tarball with mvn assembly:single
455 * assembly.xml: Add this file.
456 * pom.xml: Use the maven-assembly-plugin and tell it to use
457 our assembly.xml file.
459 2012-01-19 Murray Cumming <murrayc@murrayc.com>
461 OnlineGlomServiceImpl: Get .glom files recursively.
463 * pom.xml: Depend on commons-io from org.apache.commons.
464 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
465 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
466 files recursively, and with the easier filter for the extension.
467 Use org.apache.commons.io.FilenameUtils.removeExtension() to
468 simplify that code too.
470 2012-01-19 Murray Cumming <murrayc@murrayc.com>
472 README: Mention that you must install java-libglom packages separately.
474 But then it works, because java-libglom is now in the central maven
477 2012-01-18 Murray Cumming <murrayc@murrayc.com>
479 locales drop-down: Show the correct selected locale when the URL changes.
481 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
482 .java: setPlace(): Move some code into fillView().
484 2012-01-18 Murray Cumming <murrayc@murrayc.com>
486 locales drop-down: Do not lose the primary key.
488 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
489 start(): onLocaleChange(): Pass the current primary key value,
490 instead of an empty value.
492 2012-01-18 Murray Cumming <murrayc@murrayc.com>
494 locales drop-down: Do not lose the drop-down selection.
496 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
497 .java (TableSelectionActivity.fillView): Set the selected locale
498 after changing the drop-down items (though we do not really need
499 to change them just because the locale changes.)
501 2012-01-18 Murray Cumming <murrayc@murrayc.com>
503 locales drop-down: Change the tables list when this changes.
505 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
506 .java: TableSelectionActivity.start(): Move the async table titles
507 retrieval into a private fillView() method and also call this when
508 the chosen locale changes.
509 Note that the document title is not actually translatable yet, but
510 that is a problem that I should fix soon in libglom.
512 2012-01-18 Murray Cumming <murrayc@murrayc.com>
514 Improve the placement of the locales drop-down.
516 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
517 Put the title and locales drop-down in a div (gwt.FlowTable).
518 * src/main/webapp/style.css: Add magic css properties to make this work.
519 Also remove the left margin from the title so that it lines up with the
522 2012-01-18 Murray Cumming <murrayc@murrayc.com>
524 locales selector: Show human-readable locale titles.
526 * src/main/java/org/glom/web/server/ConfiguredDocument.java
527 getDocumentInfo(): Use java.util.Locale to show a real title of
528 each locale, in the locale's own language.
530 2012-01-17 Murray Cumming <murrayc@murrayc.com>
532 Add a language/locale selector drop-down.
534 * src/main/java/org/glom/web/shared/DocumentInfo.java:
535 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
536 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
537 getDocumentInfo(): Store the available Locales in the DocumentInfo.
538 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
539 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
540 Add a ListBox to show the available locales. Add getLocaleSelector(),
541 setLocaleList(), getSelectedLocale(), setSelectedLocale().
542 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
543 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
544 java: Add these classes.
545 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
546 start(): Fill the locales ListBox. Handle its change event, firing a
548 setPlace(): Show the selected locale as specified by the URL token.
549 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
550 * src/main/java/org/glom/web/client/activity/ListActivity.java:
551 Handle LocaleChangeEvent, going to a new *Place with that locale.
553 The placement of the ListBox is not pretty, and it currently uses the ID
554 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
558 2012-01-17 Murray Cumming <murrayc@murrayc.com>
560 Search box: Show the search text from the URL token.
562 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
563 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
564 Add setQuickFindText().
565 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
566 .java: setPlace(): Store the queryText if the place is a ListPlace,
567 and call TableSelectionView.setQuickFindText().
569 2012-01-17 Murray Cumming <murrayc@murrayc.com>
571 Allow use of translations via, for instance, &lang=de in the URL.
573 * pom.xml: Use the unstable java-libglom 1.21 version.
575 * src/main/java/org/glom/web/client/OnlineGlomService.java:
576 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
577 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
578 init(): Instead of calling TranslatableItem.set_current_locale()
579 (now removed), call ConfiguredDocument.setDefaultLocaleID().
580 However, this is only for default locales, which are not needed to
581 change the locale in the URL.
582 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
583 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
584 getSortedRelatedListData(): Add a localeID parameter, so we can get the
585 layout for a particular locale.
586 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
587 Add get/setDefaultLocaleID().
588 getDocumentInfo(), getListViewData(), getRelatedListData(),
589 getDetailsLayoutGroup(), getListViewLayoutGroup(),
590 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
591 localeID parameter, so we can get the layout for a particular locale.
593 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
594 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
595 * src/main/java/org/glom/web/client/place/ListPlace.java:
596 Parse and construct a lang parameter too.
598 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
599 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
600 passed to subsequent methods and constructors.
601 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
602 * src/main/java/org/glom/web/client/activity/ListActivity.java:
603 Store the localeID from the *Place and pass it to other constructors
604 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
606 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
607 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
608 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
609 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
610 * src/main/java/org/glom/web/client/ui/ListView.java:
611 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
612 Take localeID parameters and pass them to subsequent constructors and
613 methods, so that the layout is always retrieved for that locale.
615 This is rather repetitive.
617 Note that "" means the original (default) locale of the Glom document,
618 which is usually English.
620 2012-01-17 Murray Cumming <murrayc@murrayc.com>
622 Documents: Remove final keyword to fix startup configuration.
624 * src/main/java/org/glom/web/shared/Documents.java: Remove the
625 final keywords on the private member variables because that breaks
626 the startup, apparently (there are warnings) because it stops them
627 from being serialized. I added these in the previous commit.
629 2012-01-13 Murray Cumming <murrayc@murrayc.com>
631 Documents: Add some final keywords.
633 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
636 2012-01-13 Murray Cumming <murrayc@murrayc.com>
638 OnlineGlomServiceImpl: Add to overview comments.
640 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
641 Note that this is where all the document are loaded. They are not
642 loaded freshly for each page.
644 2012-01-12 Murray Cumming <murrayc@murrayc.com>
648 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
649 Add a TextBox for the text of a quick find.
650 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
652 setBackLink(): Add a String quickFind parameter.
653 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
654 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
655 to the base interface, because that is how TableSelectionViewImpl is used.
656 * src/main/webapp/style.css: Add style for the search box and its label.
658 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
659 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
660 Add these files, based on the existing TableChangeEvent and
661 TableChangeEventHandlers.
662 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
663 start(): Handle QuickFindChangeEvent, passing its quickFind text to
664 a ListPlace() that the user should be taken to.
665 * src/main/java/org/glom/web/client/activity/ListActivity.java
666 start(): Handle it here too and adapt the TableChangeEvent handler to
667 pass the extra "" quickFind parameter to ListPlace.
668 * src/main/java/org/glom/web/client/place/ListPlace.java:
669 Constructor: Take an extra String quickFind parameter and store it,
670 returning it from a new getQuickFind() method.
671 getToken(): Put the quickFind text in the URL token.
672 getPlace(): Parse the quickFind text from the URL token.
673 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
674 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
675 ListPlace constructor.
676 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
677 .java: start(): Add a Change handler for the TableSelectionView's
678 TextBox (via its base HasChangeHandlers interface), firing the new
679 QuickFindChangeEvent.
680 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
681 pass the extra "" quickFind parameter.
683 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
684 setCellTable(): Add a String quickFind parameter and pass it to
685 the ListViewTable() constructor.
686 * src/main/java/org/glom/web/client/ui/ListView.java: Change
687 setCellTable() in the base interface, because that is how ListViewImpl
690 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
691 Add a String quickFind member variable.
692 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
693 Constructor: Add a String quickFind parameter, storing it in the
694 base ListTable's member variable.
695 onRangeChanged(): Pass quickFind to the
696 OnlineGlomServiceAsync.getSortedListViewData() and
697 OnlineGlomServiceAsync.getListViewData() methods.
699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
700 getListViewData(), getSortedListViewData(): Add a String quickFind
701 parameter, passing it to ConfiguredDocument.getListViewData().
702 * src/main/java/org/glom/web/client/OnlineGlomService.java:
703 Change getListViewData(), getSortedListViewData() in the base interface,
704 because that is how OnlineGlomServiceImpl is used, via this:
705 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
706 Change getListViewData(), getSortedListViewData() here too.
707 This class can apparently be used to asynchronously call methods on
708 OnlineGlomService, and GWT seems to implement that after recognizing
709 just the *Async name convention and the extra AsyncCallback parameters.
711 * src/main/java/org/glom/web/server/ConfiguredDocument.java
712 getListViewData(): Add a String quickFind parameter, and pass it to
713 ListViewDBAccess.getData().
714 * src/main/java/org/glom/web/server/database/ListDBAccess.java
715 getListData(): Add a String quickFind parameter and pass it to
717 getSelectQuery(): Add a String quickFind parameter.
718 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
719 getSelectQuery(): Add a String quickFind parameter and use it with
720 Glom.get_find_where_clause_quick() to pass a where_clause to
721 Glom.build_sql_select_with_where_clause(), to actually filter the
723 getData(): Add a String quickFind parameter, passing it to getListData().
724 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
725 va: getData(): Pass an empty string to getListData() for the
728 2012-01-12 Murray Cumming <murrayc@murrayc.com>
730 ListTable: Minor change.
732 * src/main/java/org/glom/web/client/ui/list/ListTable.java
733 createCellTable(): Make this protected instead of public.
735 2012-01-12 Murray Cumming <murrayc@murrayc.com>
737 Many files: Use final for the parameters and use the @override attribute.
739 2012-01-22 Ben Konrath <ben@bagu.org>
741 Add anchor links for single line text that starts with http, ftp and www.
745 2012-01-22 Ben Konrath <ben@bagu.org>
747 Add ellipsis to single line text in details view.
751 2012-01-04 Murray Cumming <murrayc@murrayc.com>
753 Remove all javadoc author tags.
755 Because they are awkward and meaningless when many people touch
757 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
759 2012-01-04 Murray Cumming <murrayc@murrayc.com>
761 Revert the COPYING.LESSER to COPYING rename.
763 Apparently both should be there if it is LGPL.
765 2012-01-03 Murray Cumming <murrayc@murrayc.com>
767 *View: Remove unused imports.
769 * src/main/java/org/glom/web/client/ui/DetailsView.java:
770 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
771 * src/main/java/org/glom/web/client/ui/ListView.java:
772 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
773 Remove unused imports, as suggested by Eclipse.
775 2012-01-02 Murray Cumming <murrayc@murrayc.com>
777 Move the *View::Presenter types, and some API into one base View.
779 * src/main/java/org/glom/web/client/ui/DetailsView.java:
780 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
781 * src/main/java/org/glom/web/client/ui/ListView.java:
782 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
783 Presenter, setPresenter() and clear() into a shared base interface,
784 to avoid the unnecessary duplicate Presenter types and to more clearly
785 show how the *Views share the same structure, even if they are not
786 used polymorphically.
788 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
789 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
791 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
792 * src/main/java/org/glom/web/client/activity/ListActivity.java:
793 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
795 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
798 Feel free to revert this if there is a good reason for the duplicate
801 2012-01-02 Murray Cumming <murrayc@murrayc.com>
803 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
805 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
806 a class member instead of a local variable in the method.
807 This lets us use it to get the view instances, for use in tests.
808 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
809 beforeOnlineGlom(): Test some more details of the initial view.
810 Again, this is not very useful.
812 To really test gwt-glom we will need to start a local postgresql
813 instance with local data, like the Glom tests in C++.
815 2012-01-02 Murray Cumming <murrayc@murrayc.com>
817 pom.xml: Mention the LGPL license.
819 * pom.xml: Add a licenses section.
820 * COPYING.LESSER: Move this to COPYING, which
821 previously contained the GPL. But gwt-glom is all LGPL.
823 2012-01-02 Murray Cumming <murrayc@murrayc.com>
825 Add project information to README and pom.xml.
827 * README: Add a brief description and mention some mvn
829 * pom.xml: This extra information shows up in mvn site
832 2011-01-02 Murray Cumming <murrayc@murrayc.com>
834 Use the latest java-libglom version.
836 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
838 2012-01-01 Murray Cumming <murrayc@murrayc.com>
840 GwtTestOnlineGlom: Test a little more.
842 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
843 protected rather than private, as suggested by the gwt-test-utils
845 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
846 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
847 Test the initial visibility of the panels.
849 However, this is not a very useful test.
850 And I wonder how we should generally test using this idea for an
851 activity/places app like ours where the real changes happen implicitly
852 based on the history token/URL.
854 2012-01-01 Murray Cumming <murrayc@murrayc.com>
856 Slight modification to *Mapper comments.
858 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
860 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
862 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
864 Remove comments mentioning GIN because they are just copied from
865 the example code and are apparently not helpful:
866 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
867 Also change the mention of a class that is only in the example code.
869 2012-01-01 Murray Cumming <murrayc@murrayc.com>
871 GwtTestOnlineGlom test: Minor changes.
873 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
874 Avoid the long qualified class name and modify the comment
875 because it is now obvious to me that the mocked class is the only
876 custom one created via GWT.create().
878 2012-01-01 Murray Cumming <murrayc@murrayc.com>
880 Tests: Added the beginnings of a test using gwt-test-utils.
882 * pom.xml: Add dependencies on gwt-test-utils and easymock.
883 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
884 which tells gwt-test-utils what class will be tested.
885 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
886 Add a simple (but empty) test case. One class, used by the OnlineGlom
887 class, is mocked so that it can be created. However, I am not sure
888 why only this class needs to be mocked.
890 Note that mockito seems more popular, and clearer, than easymock,
891 but I have not got that working yet. It might be a matter of the
894 This test is run during mvn integration-test.
896 2011-12-31 Murray Cumming <murrayc@murrayc.com>
898 Tests: Use junit4-style syntax instead of junit3-style.
900 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
901 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
902 * src/test/java/org/glom/web/shared/DataItemTest.java:
903 Use the @Test annotation rather than relying on the test*() prefix.
904 Also no longer implement TestCase, to avoid triggering support for
905 the junit3-way, which stops the annotations from working.
906 Change the imports from import junit.framework.* to
907 import org.junit.*, which is apparently the new way.
909 2011-12-31 Murray Cumming <murrayc@murrayc.com>
911 Added a test for ListPlace token parsing and creation.
913 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
914 This is much the same as DetailsPlaceTest.
916 I wonder how we could test the other parts of the *Place API.
918 2011-12-30 Murray Cumming <murrayc@murrayc.com>
920 DetailsPlace test: Also test getToken() and recreation via getPlace().
922 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
923 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
924 recreate it, testing the recreated DetailsPlace for the same parameter
927 2011-12-30 Murray Cumming <murrayc@murrayc.com>
929 Use the surefire-report plugin.
931 * pom.xml: This generates a HTML report about the tests in
932 target/site/surefire-report.html
933 when you do mvn surefire-report:report. It seems to be popular/normal.
935 2011-12-30 Murray Cumming <murrayc@murrayc.com>
937 Added a test for DetailsPlace.
939 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
940 Test the getPlace() token parsing.
942 2011-12-30 Murray Cumming <murrayc@murrayc.com>
944 Added a first unit test.
946 * pom.xml: Add a test goal, and a dependency on junit in that scope.
947 * src/test/java/org/glom/web/shared/DataItemTest.java:
948 This is a silly test but it is just to get things started. Note that
949 maven/junit finds the test because it looks in src/test by default.
951 2011-12-22 Ben Konrath <ben@bagu.org>
953 Change charsetName to "UTF-8" when replacing line breaks.
955 JavaScript requires the charsetName to be "UTF-8". CharsetName values
956 that work in Java (such as "UTF8") will not work when compiled to
959 This fixes a problem with multi-line details view fields that have hard
960 line breaks. The "License Text" field on this page demonstrates the
963 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
965 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
967 2011-12-22 Ben Konrath <ben@bagu.org>
969 Fix another bug with related list navigation.
971 I've tested all the navigation buttons in all of the related lists
972 so things should be good now.
974 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
976 2011-12-22 Ben Konrath <ben@bagu.org>
978 Fix a crasher when refreshing the list view with the default table.
980 This crash will also happen when loading the list view with the default
981 table from a link or bookmark.
983 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
984 to the main document selection page when the document id hasn't been
986 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
987 the main document selection page when the document id hasn't been
989 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
990 values for the details place when the document id hasn't been set.
991 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
992 values for the list place when the document id hasn't been set.
994 2011-12-21 Ben Konrath <ben@bagu.org>
996 Protect against NPE when glom.document.locale is not in config.
998 This patch protects against an NPE when glom.document.locale is not in
999 the config file. This NPE will also happen if glom.document.locale is
1002 The patch also updates the error message to display the class name when
1003 the getMessage() returns null. This was happening when the NPE was
1004 thrown and I had "Configuration Error: null". If an NPE is encountered
1005 with this patch, "Configuration Error: NullPointerException " will be
1008 This commit closes this bug:
1010 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1014 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1016 Rename onlineglom.properties to onlineglom.properties.sample.
1018 * src/main/resources/onlineglom.properties: Rename to:
1019 * src/main/resources/onlineglom.properties.sample:
1020 * src/main/resources/README: And add this file explaining that people
1021 should rename it back when deploying.
1023 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1025 Allow choosing the translation in the .properties file.
1027 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1028 init(): Read a glom.document.locale value from the configuration file
1029 and call Glom's TransatableItem::set_current_locale() method.
1030 * src/main/resources/onlineglom.properties: Add a commented-out
1031 example of this new setting.
1033 It would be better to add &lang=de_DE to the URL, but the current
1034 libglom API does not allow us to do this easily. I am working on that.
1036 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1038 Avoid a crash in parsing of token parameters.
1040 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1041 ava: getTokenParams(): Do not crash if a parameter has a key but no
1042 value, and ignore parameters with neither.
1044 2011-12-17 Murray Cumming <murrayc@murayc.com>
1046 History token building/handling: Improve use of token parameters.
1048 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1049 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1050 and buildParamsToken(HashMap), for use by derived classes.
1051 Make the separator private because it is no longer be needed.
1052 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1053 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1054 instead of manual string concatenation.
1055 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1056 of hardcoded indices and awkward splitting code.
1057 * src/main/java/org/glom/web/client/place/ListPlace.java
1058 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1059 instead of manual string concatenation.
1060 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1061 of hardcoded indices and awkward splitting code.
1062 This should fix bug #666420
1064 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1066 Fix a Navgiation->Navigation typo in the code.
1068 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1069 Rename processNavgiation() to processNavigation().
1071 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1073 Fix a seperator->separator typo in the code.
1075 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1076 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1077 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1080 2011-12-15 Ben Konrath <ben@bagu.org>
1082 Cleanup some comments.
1084 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1086 2011-12-14 Ben Konrath <ben@bagu.org>
1088 Replace \n with <br/> for multiline text in the details view.
1090 Vertical scrollbars are added when needed as well.
1092 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1094 2011-12-14 Ben Konrath <ben@bagu.org>
1096 Specify the font for document selection links.
1098 * src/main/webapp/style.css:
1100 2011-12-14 Ben Konrath <ben@bagu.org>
1102 Fix bouncy CellTable while paging.
1104 This doesn't currently work with related list tables in unselected
1107 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1109 2011-12-14 Ben Konrath <ben@bagu.org>
1111 Revamp the appearance of the document selection page.
1113 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1114 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1115 * src/main/webapp/style.css:
1117 2011-12-13 Ben Konrath <ben@bagu.org>
1119 Set navigation button column to the smallest size possible.
1121 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1123 2011-12-13 Ben Konrath <ben@bagu.org>
1125 Change OpenButton nomenclature to NavigationButton.
1127 Using NavigtionButton makes things more generic. Classes, methods and
1128 variables have been changed.
1130 This is a rename-only refactor.
1132 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1133 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1134 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1135 Renamed from OpenButtonCell.
1136 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1137 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1138 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1140 2011-12-12 Ben Konrath <ben@bagu.org>
1142 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1144 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1145 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1146 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1147 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1149 2011-12-12 Ben Konrath <ben@bagu.org>
1151 Update variable names and comments.
1153 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1154 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1156 2011-12-12 Ben Konrath <ben@bagu.org>
1158 Properly initialize numNonEmptyRows variable to zero.
1160 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1161 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1163 2011-12-05 Ben Konrath <ben@bagu.org>
1165 Add latest mockup with HTML tables.
1167 Features of this mockup:
1169 -> HTML table for flowtable
1170 -> HTML table for flowtable column
1171 -> Example of how related lists would look
1172 -> Not using text entries for data items
1174 The current version of Online Glom doesn't use HTML tables for the
1177 This mockup has been sent to the glom-devel mailing list but it's good
1178 to have it here as well.
1180 * mockups/details-view-html-tables.html:
1182 2011-12-05 Ben Konrath <ben@bagu.org>
1184 Remove unnecessary getPrimaryKeyField() method.
1186 getPrimaryKeyFieldForTable(String) has been renamed to
1187 getPrimaryKeyField(String).
1189 * src/main/java/org/glom/web/server/database/DBAccess.java:
1190 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1191 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1193 2011-12-05 Ben Konrath <ben@bagu.org>
1195 Add string representation of TypedDataItem value to conversion error message.
1197 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1198 message was extracted into its own method to avoid duplication.
1200 2011-12-05 Ben Konrath <ben@bagu.org>
1202 Add type checking to navigation primary key value creation.
1204 Create navigation primary key only if the expected type from the Glom
1205 document matches the type returned by the SQL query.
1207 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1209 2011-12-05 Ben Konrath <ben@bagu.org>
1211 Rename a couple of variables in RelatedListNavigation.
1213 This is a rename-only refactor.
1215 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1217 2011-12-05 Ben Konrath <ben@bagu.org>
1219 Move getListLayoutGroup() into getListViewLayoutGroup().
1221 This removes getListLayoutGroup(). It was only being called by
1222 getListViewLayoutGroup().
1224 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1226 2011-12-05 Ben Konrath <ben@bagu.org>
1228 Remove check for LayoutItem_Portal in list table method.
1230 This check is no longer necessary because the method isn't being used
1231 to create the LayoutItemPortal DTO.
1233 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1235 2011-12-05 Ben Konrath <ben@bagu.org>
1237 Properly support related list navigation.
1239 Navigation from the "Repository Analyzer -> Package Scans ->
1240 Dependencies" related table wasn't working because the primary key for
1241 related tables wasn't being set properly. This commit fixes the
1244 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1245 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1246 doesn't set the primary key properly for related list tables.
1247 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1248 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1249 useful for getting the primary key for list view tables and for related
1251 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1252 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1253 Move code to set the primary key for the table from the abstract
1254 ListDBAccess class to ListViewDBAccess as it's only correct for list
1256 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1257 Properly add primary key to related list tables.
1259 2011-12-02 Ben Konrath <ben@bagu.org>
1261 Properly set the horizontal alignment of fields.
1263 This fix is for both the list tables and the details view.
1265 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1266 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1267 to set the horizontal alignment of fields.
1269 2011-12-02 Ben Konrath <ben@bagu.org>
1271 Display currency codes in the details view.
1273 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1275 2011-12-02 Ben Konrath <ben@bagu.org>
1277 Avoid duplicate JNI call.
1279 JNI is not as efficient as pure Java and this is an easy (and small)
1282 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1283 Use previously retrieved value for whereClauseToTableName instead of
1286 2011-12-02 Ben Konrath <ben@bagu.org>
1288 Rename a couple of variables in RelatedListNavigation.
1290 This is a rename-only refactor.
1292 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1294 2011-12-02 Ben Konrath <ben@bagu.org>
1296 Indicate clearly that a mismatched primary key type is a bug.
1298 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1299 warning to error. Add 'This is a bug.' to message.
1301 2011-12-02 Ben Konrath <ben@bagu.org>
1303 Update / fix some comments.
1305 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1307 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1309 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1310 Fix comments. Add some TODOs.
1312 2011-12-02 Ben Konrath <ben@bagu.org>
1314 Enable navigation to details view with string primary key from related list.
1316 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1317 Create a text primary key value when return type of result is
1318 java.sql.Types.VARCHAR.
1320 2011-12-02 Ben Konrath <ben@bagu.org>
1322 Use checkboxes for booleans in the details view.
1324 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1326 2011-12-01 Ben Konrath <ben@bagu.org>
1328 Improve performance of related list height calculation.
1330 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1331 Put code to calculate the expected height in a static initializer so
1332 that that it's only called once.
1334 2011-12-01 Ben Konrath <ben@bagu.org>
1336 Show related list tables in notebooks (again).
1338 Calculate the height of the related list tables so the Notebook can be
1339 set the correct height. The height of the related list table is also needed by
1340 FlowTable to be able decide how to create the layout.
1342 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1343 and set the Portal height based on the height of the related list
1344 table and the Portal container.
1345 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1346 Add method to calculate the height of the related list tables.
1347 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1348 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1349 calculate the height of the Pager widget.
1351 2011-12-01 Ben Konrath <ben@bagu.org>
1353 Use CellTable API for table property instead of setting style on Element.
1355 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1357 2011-12-01 Ben Konrath <ben@bagu.org>
1359 Make ListViewTable and RelatedListTable a consistent height.
1361 The tables are now a consistent height regardless of the contents of
1362 the table. A hidden button is added to empty rows to ensure that the
1363 height of these rows will match the height of rows with data.
1365 A navigation button column is now added to every table. The width of
1366 the navigation column is set to 0px when a RelatedListTable shouldn't
1367 have navigation buttons. This maintains the a consistent row height in
1368 tables that don't show the navigation buttons.
1370 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1371 navigation column when not needed.
1372 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1373 arguments for navigation button to constructor of ListViewTable.
1374 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1375 hidden button for empty data rows.
1376 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1377 arguments for navigation button to constructor.
1378 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1379 create navigation buttons. Add hideNavigationButtons() method.
1380 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1381 arguments for navigation button to constructor.
1383 2011-12-01 Ben Konrath <ben@bagu.org>
1385 Use 'visibility: hidden' in Utils.getWidgetHeight().
1387 This is better choice because hidden elements are invisible, don't
1388 respond to events and are not part of the tab order. They will,
1389 however, take up space which is required to be able to calculate the
1390 height of the widget.
1392 * src/main/java/org/glom/web/client/Utils.java:
1394 2011-12-01 Ben Konrath <ben@bagu.org>
1396 Use Utils.getWidgetHeight() in FlowTable.
1398 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1400 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1402 2011-12-01 Ben Konrath <ben@bagu.org>
1404 Put the details css class name on the correct table column.
1406 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1408 2011-11-30 Ben Konrath <ben@bagu.org>
1410 Update for java-libglom API change.
1412 The getters and setters on FieldFormatting and NumericFormat were
1413 changed to remove the 'M'.
1415 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1417 2011-11-29 Ben Konrath <ben@bagu.org>
1419 Only allow RelatedListTables in Portals.
1421 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1423 2011-11-29 Ben Konrath <ben@bagu.org>
1425 Only create a contents panel for Portals when title is being set.
1427 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1429 2011-11-29 Ben Konrath <ben@bagu.org>
1431 Set TabLayoutPanel height based on calculated height its widgets.
1433 This is a potential fix for this bug:
1435 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1437 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1439 2011-11-29 Ben Konrath <ben@bagu.org>
1441 Align details field labels and data with the Open buttons.
1443 * src/main/webapp/style.css:
1445 2011-11-29 Ben Konrath <ben@bagu.org>
1447 Remove unnecessary <div> in the Notebook widget.
1449 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1450 method to get container FlowPanel (<div>).
1451 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1452 initWidget() method directly on the TabLayoutPanel widget instead of
1453 Group's container widget.
1455 2011-11-29 Ben Konrath <ben@bagu.org>
1457 Don't add group titles for Portals in Notebooks.
1459 This reverts the previous patch and fixes a bug I introduced with
1460 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1462 * src/main/java/org/glom/web/client/ui/details/Group.java:
1463 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1465 2011-11-28 Ben Konrath <ben@bagu.org>
1467 Remove unused boolean argument in Portal constructor.
1469 Just a code cleanup.
1471 * src/main/java/org/glom/web/client/ui/details/Group.java:
1472 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1474 2011-11-28 Ben Konrath <ben@bagu.org>
1476 Remove hack for glom 1.18 style glom files.
1478 * src/main/java/org/glom/web/client/ui/details/Group.java:
1479 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1480 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1482 2011-11-28 Ben Konrath <ben@bagu.org>
1484 Use Gda Value version of primary key to log result too large error.
1486 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1488 2011-11-28 Ben Konrath <ben@bagu.org>
1490 Don't use TypedDataItem.getText() for Unknown types from the URL.
1492 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1493 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1494 instead of getText().
1495 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1496 String field and getUnknown() method.
1498 2011-11-28 Ben Konrath <ben@bagu.org>
1500 Log an error message when the java-libglom .so is not present.
1502 The error message was being set in the exception but not logged.
1504 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1506 2011-11-28 Ben Konrath <ben@bagu.org>
1508 Ignore LayoutItem_CalendarPortals.
1510 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1511 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1513 2011-11-28 Ben Konrath <ben@bagu.org>
1515 Extract method for creating the LayoutItemPortal DTO.
1517 Just breaking the code up into smaller chunks.
1519 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1521 2011-11-28 Ben Konrath <ben@bagu.org>
1525 This should have been added with the refactor. Oops!
1527 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1529 2011-11-28 Ben Konrath <ben@bagu.org>
1531 Create primary key value from URL string using type from Glom document.
1533 See this bug, comments 19 - 25:
1535 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1537 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1538 create a TypeDataItem for the primary key here when loading from a
1539 URL. Show the same string for the primary key value as was received
1540 from the URL string (when loading from a URL).
1541 * src/main/java/org/glom/web/server/Utils.java: Update method for
1542 creating the Gda Value from the TypeDataItem to properly deal with
1543 creating a Gda Value based on the Glom document type for the primary
1544 key value string when loading from a URL.
1545 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1546 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1547 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1548 Update for changed method name.
1550 2011-11-27 Ben Konrath <ben@bagu.org>
1552 Rename PrimaryKeyItem to TypedDataItem.
1554 The name PrimaryKeyItem suggests what the class should be used for.
1555 TypedDataItem is a neutral name that describes the class better.
1557 This is a rename-only refactor.
1559 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1560 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1561 * src/main/java/org/glom/web/client/Utils.java:
1562 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1563 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1564 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1565 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1566 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1567 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1568 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1569 * src/main/java/org/glom/web/server/Utils.java:
1570 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1571 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1572 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1573 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1575 2011-11-25 Ben Konrath <ben@bagu.org>
1577 Improve Gda Value conversion from PrimaryKeyItem.
1579 The value from the PrimaryKeyItem is only used if its type match the
1580 type from the glom document.
1582 * src/main/java/org/glom/web/server/Utils.java:
1584 2011-11-25 Ben Konrath <ben@bagu.org>
1586 Manually check if the java-liblgom .so is visible to the JVM.
1588 It seems that Tomcat has problems when a static initializer throws an
1589 exception. This check is done before the first method call into
1590 java-libglom so that execution doesn't continue if the .so is not
1593 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1595 2011-11-25 Ben Konrath <ben@bagu.org>
1597 Improve browser configuration error messages.
1601 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1603 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1604 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1605 getConfigurationErrorMessage() method.
1606 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1607 Get and display a specific configuration error message when no Glom
1608 documents are found.
1609 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1610 Implement getConfigurationErrorMessage() method. Surround configuration
1611 code in the init() method with a try/catch block. This allows the
1612 errors to be caught while keeping the servlet available to retrieve the
1613 configuration error message.
1615 2011-11-25 Ben Konrath <ben@bagu.org>
1617 Don't use Strings to hold primary key values.
1619 The primary key values are now held in a new data object
1620 (PrimaryKeyItem) that holds type information and the primary key value
1621 using the correct type.
1623 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1624 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1625 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1626 PrimaryKeyItem instead of String to hold the primary key value.
1627 * src/main/java/org/glom/web/client/Utils.java: Remove
1628 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1629 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1630 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1631 PrimaryKeyItem instead of String to hold the primary key value. Load
1632 document selection page when the documentID has not been set correctly.
1633 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1634 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1636 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1637 Return empty string for URL instead of "null".
1638 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1639 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1640 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1641 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1642 PrimaryKeyItem instead of String to hold primary key values.
1643 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1644 PrimaryKeyValue to a Gda Value.
1645 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1646 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1647 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1648 Replace temporary database access code that uses the PrimaryKeyValue to
1649 Gda Value conversion.
1650 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1651 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1652 PrimaryKeyItem instead of String.
1653 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1654 hold primary key values.
1656 2011-11-24 Ben Konrath <ben@bagu.org>
1658 Use newly added java-libglom API to create queries.
1660 This isn't finished. I still need to stop using Strings for primary key
1661 values in the client code.
1663 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1664 libglom to use fake connections so that retrieving the query string will
1666 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1667 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1668 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1669 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1670 Use the newly added libglom sql methods and classes to create the
1671 query. Add temporary hack to convert primary value strings to Gda
1674 2011-11-23 Ben Konrath <ben@bagu.org>
1676 Don't explicitly set the height of Portals.
1678 See comments 6 - 10 of this bug for details:
1680 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1682 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1684 2011-11-23 Ben Konrath <ben@bagu.org>
1686 Use an HTML table instead of CSS for the FlowTable layout.
1688 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1689 GWT's FlexTable to implement the FlowTable.
1690 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1692 2011-11-18 Ben Konrath <ben@bagu.org>
1694 Add boolean example to HTML table mockup.
1696 * mockups/details-view-html-tables-text-entries.html:
1698 2011-11-17 Ben Konrath <ben@bagu.org>
1700 Ensure the pager buttons are always visible for related lists.
1702 To accomplish this, I've turned off text wrapping in the list view and
1703 related list tables for both the header and data text. The related list
1704 table now has a fixed layout so the it doesn't overflow its container.
1705 This is required to ensure that the cell text is clipped when it
1706 overflows the cell and an ellipsis is added to the right side of the
1707 cell when text is clipped.
1709 A fixed table layout for the related list table in the details view
1710 seems what we want for the details view anyway, so the side-effect is
1713 The ellipsis will only be displayed in Firefox >= 7.
1717 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1719 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1720 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1721 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1723 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1724 Set the 'table-layout: fixed' CSS property to the related list table.
1725 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1726 'white-space: nowrap;' CSS property on both the list view and the
1727 related list tables.
1729 2011-11-16 Ben Konrath <ben@bagu.org>
1731 Rework the fix for empty notebook tab labels.
1733 Setting the empty group titles with its name caused problems for the
1734 details layout. Instead of using libglom's
1735 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1736 to the client when the title is empty. This allows the Notebook to use
1737 the name when the title is empty without affecting anything else.
1739 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1740 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1742 2011-11-16 Ben Konrath <ben@bagu.org>
1744 Set group titles with name when title is empty.
1746 This fixes a problem with an empty notebook tab label in the Lesson
1747 Planner document. The forth tab in the notebook should be "Internet":
1749 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1751 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1752 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1755 2011-11-16 Ben Konrath <ben@bagu.org>
1757 Remove whitespace from the configured username properties.
1759 This assumes that usernames won't have whitespace at the beginning
1760 or end. But I think this is a reasonable assumption.
1762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1763 String.trim() to remove the whitespace from the username properties.
1765 2011-11-15 Ben Konrath <ben@bagu.org>
1767 Add details view mockup with HTML tables and text entries.
1769 This is from the attachment on this bug:
1771 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1773 * mockups/details-view-html-tables-text-entries.html:
1775 2011-11-15 Ben Konrath <ben@bagu.org>
1777 Add space between the columns of the flow table.
1781 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1783 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1784 space between columns in the flow table.
1786 2011-11-15 Ben Konrath <ben@bagu.org>
1788 Add backup files to the .gitignore.
1790 * .gitignore: Ignore files that end with ~.
1792 2011-11-09 Ben Konrath <ben@bagu.org>
1794 Use latest release of gwt-log.
1796 Gwt-log releases are now being submitted to the maven central
1797 repository so manual installation of the jar is no longer required.
1799 * pom.xml: Update version and groupId of gwt-log dependency.
1801 2011-10-31 Ben Konrath <ben@bagu.org>
1803 Don't use GWT numeric formatting to override the glom currency formatting.
1805 Currencies are now displayed like they are in Glom. See this bug:
1807 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1809 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1811 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1812 currency code to constructor and set it when the cell is rendered.
1813 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1814 currency code to the constructor of the NumericCell.
1816 2011-10-27 Ben Konrath <ben@bagu.org>
1818 Require the latest release of java-libglom (1.17.4).
1822 2011-10-26 Ben Konrath <ben@bagu.org>
1824 Add style to Notebook that matches current theme.
1826 It's not the best style in the world but it's better than the default.
1828 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1829 padding at the bottom of the child widgets.
1830 * src/main/webapp/style.css: Add style for the Notebook.
1832 2011-10-26 Ben Konrath <ben@bagu.org>
1834 Move servlet initialization code to overridden init method.
1836 This is half of the solution to getting proper error messages
1837 displayed when configuration errors occur. Here's the relevant bug:
1839 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1841 The rest of the solution involves surrounding the init method with a
1842 try/catch block and setting a global variable with the error /
1843 exception. A new async method should be created to retrieve and display
1844 the error message / exception.
1846 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1847 code from constructor to init method adding exceptions as needed.
1849 2011-10-26 Ben Konrath <ben@bagu.org>
1851 Add script to monitor and restart tomcat if required.
1853 * utils/check-and-recover-tomcat.py: New file.
1855 2011-10-26 Ben Konrath <ben@bagu.org>
1857 Display the correct number of data items in the pager.
1861 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1863 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1864 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1865 The implementation is the same for both tables: Keep track of the
1866 number of non-empty rows and fire and RowCountChangeEvent after the data has
1868 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1869 custom Pager class that subclasses SimplePager to handle displaying
1870 the correct number when empty rows have been added.
1872 2011-10-26 Ben Konrath <ben@bagu.org>
1874 Correct error in previous commit.
1876 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1877 eventBus parameter from listView.setCellTable().
1879 2011-10-26 Ben Konrath <ben@bagu.org>
1881 Fix error in TODO comment.
1883 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1885 2011-10-24 Ben Konrath <ben@bagu.org>
1887 Create Notebook widgets to the details view.
1889 This isn't finished just yet - I still need to create a reasonable
1890 style to match the current theme.
1892 * src/main/java/org/glom/web/client/Utils.java: Add method for
1893 calculating the height of a widget. This is used in the Notebook class.
1894 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1895 new constructor method in Group.
1896 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1897 method for creating child widget that can be used by subclasses
1898 like Notebook. New constructor that allows disabling the group
1899 titles - Notebooks don't set a group title for their child groups.
1900 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1901 to make Notebooks using GWT's TabLayoutPanel.
1902 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1903 constructor that allows disabling the group titles.
1904 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1905 LayoutItemNotebook DTO.
1906 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1907 DTO for Notebooks. It's just an empty class for now but we might need
1908 it to transfer some specific information in the future.
1910 2011-10-21 Ben Konrath <ben@bagu.org>
1912 Add navigation buttons to related list tables.
1914 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1915 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1916 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1917 method getSuitableRecordToViewDetails() for getting the table name
1918 and primary key value for related list navigation buttons.
1919 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1920 private cell renderer class to get the navigation information for
1921 related list tables from the server. Extract the navigation
1922 processing code from the details cell navigation and use it for the
1923 related list navigation as well.
1924 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1925 cell renderer class for the details open buttons. This was needed
1926 because the related list navigation buttons and the list view
1927 navigation buttons need to react differently when clicked.
1928 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1929 the onEnterKeyDown() method because it's now overriden in the
1930 subclasses that are specific to the related list tables and the list
1932 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1933 the vertical size a little because the buttons add a bit of vertical
1934 space to table. This is not a perfect solution because the vertical
1935 size of with table fewer than 5 rows will be a little smaller.
1936 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1937 changes in how navigation buttons are handled.
1938 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1939 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1940 database access object.
1941 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1942 to find the portal for a given relationship name from
1943 RelatedListDBAccess. Add method to find a primary key field for a
1945 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1946 Move code to find the portal for a given relationship name to
1948 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1949 New file: database access object for getting the related list
1950 navigation information (the table name and the primary key value).
1951 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1952 DTO for transferring a table name to navigate to and a primary key
1954 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1955 boolean and getter/setter to specifies if the related list should add
1958 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1960 Use the master branch of java-libglom
1962 * pom.xml: Depend on java-libglom 1.19 instead.
1964 This is the master branch. See also the libglom-1-18 branch.
1966 2011-10-11 Ben Konrath <ben@bagu.org>
1968 Enable the open navigation button when the data has been set.
1970 This avoids having active buttons that don't do anything when the data
1973 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1975 2011-10-11 Ben Konrath <ben@bagu.org>
1977 Use IsWidget interface for FlowTableItem.
1979 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1980 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1982 2011-10-11 Ben Konrath <ben@bagu.org>
1984 Remove GWT styling from open button in details view.
1986 There are still some issues with how the details cell is arranged but
1987 this should be made to match Glom 1.20. I'm going to leave fixing this
1988 until I have Glom 1.20 up and running.
1990 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1991 style name on open button.
1992 * src/main/webapp/style.css: Move and edit details-navigation class.
1993 Re-arrange some classes to make them appear in the same order as the
1996 2011-10-07 Ben Konrath <ben@bagu.org>
1998 Update to GWT 2.4.0.
2000 * .gitignore: Ignore new cache directory.
2001 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2002 * pom.xml: Change GWT and maven plugin to 2.4.0.
2003 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2005 * src/main/java/org/glom/web/client/ClientFactory.java:
2006 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2007 * src/main/java/org/glom/web/client/OnlineGlom.java:
2008 Update source for API changes.
2009 * utils/build-onlineglom-war.sh: Remove cache directory before the
2012 2011-10-07 Ben Konrath <ben@bagu.org>
2014 Add navigation buttons in the details view.
2016 This isn't finished but I thought I'd commit what I have as it's a
2017 pretty good start. I still need to:
2019 1. Change the style so that it fits better into the current theme
2020 2. Adjust the details cell to expand as much as possible.
2022 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2023 click handlers to navigation buttons in the DetailsCells. Create a
2024 refreshData() method to get just the data from the server without the
2026 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2027 Update the tableSelector and browser title when the table name
2028 changes without using the tableSelector.
2029 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2030 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2031 getDetailsCells() to getCells(). Update variable names.
2032 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2033 method to set click handler on navigation button. Rename a few
2034 variables. Add navigation buttons where needed.
2035 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2036 variables and methods.
2037 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2038 navigation boolean and navigation table as required in the
2039 LayoutItemField DTO.
2040 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2041 variables for navigation along with getter/setter methods.
2043 2011-10-07 Ben Konrath <ben@bagu.org>
2045 Rename Field to DetailsCell.
2047 This is a refactor-only commit. No functionality has been added or
2050 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2051 Update variable and method names.
2052 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2053 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2054 variable and method names.
2055 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2057 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2058 variable and method names.
2060 2011-10-07 Ben Konrath <ben@bagu.org>
2062 Create separate methods for layout and data the details view.
2064 This is a refactor-only commit. No functionality has been added or
2067 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2068 private methods: setData(), createLayout().
2070 2011-10-07 Ben Konrath <ben@bagu.org>
2072 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2074 This is part of a change to get navigation buttons in the details view
2075 but it should have been done this way from the start.
2077 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2078 for method name change in TableSelectionView.
2079 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2080 Create TableChangeEvent and set the browser title using the
2081 TableSelectionView API.
2082 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2083 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2084 Change getSelectedTable() to getSelectedTableName(). Add
2085 getSelectedTableTitle().
2087 2011-10-07 Ben Konrath <ben@bagu.org>
2089 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2091 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2093 2011-10-07 Ben Konrath <ben@bagu.org>
2095 Update TableChangeEvent to use newTableName naming convention.
2097 This makes the class more consistent with GWT naming conventions.
2099 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2100 Update for method name change in TableChangeEvent.
2101 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2102 for method name change in TableChangeEvent.
2103 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2104 newTableName variable and getter method. Make toDebugString()
2107 2011-09-30 Ben Konrath <ben@bagu.org>
2109 Disable the pager in the list tables when the data row count is less than the minimum.
2111 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2112 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2114 2011-09-30 Ben Konrath <ben@bagu.org>
2116 Add empty rows to the end of related list and list view tables.
2118 I also extracted the cell rendering classes from the ListTable because
2119 the code was becoming a little crazy with all the anonymous inner
2120 classes. My plan is to use these cell rendering classes in the details
2121 view as well so this refactor will be needed for that change.
2123 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2124 set the row count in related list tables if the data has more rows
2125 than the minimum number of rows visible.
2126 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2127 row count in list view tables if the data has more rows than the
2128 minimum number of rows visible.
2129 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2130 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2132 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2133 for rendering TYPE_NUMERIC cells. The code was extracted from the
2135 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2136 class for rendering cells with buttons in list views. The code was
2137 extracted from the ListTable class.
2138 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2139 for rendering TYPE_TEXT cells. The code was extracted from the
2141 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2142 Add empty rows to the end of the data if required. Implement
2143 ListTable.getMinNumVisibleRows().
2144 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2145 cell renderer code to public classes. Return null in
2146 Column.getValue() for empty rows. Add new abstract method:
2147 getMinNumVisibleRows(). Move code to set the row count of the list view
2148 table to ListViewImpl.
2149 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2150 empty rows to the end of the data if required. Implement
2151 ListTable.getMinNumVisibleRows().
2154 2011-09-27 Ben Konrath <ben@bagu.org>
2156 Use GWT.log for client-side debugging statements.
2158 These are optimized out when deployed so I should have used this method
2159 in the first place. These statements will eventually be replaced with some sort
2160 of notification in the browser.
2162 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2163 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2164 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2165 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2166 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2168 2011-09-27 Ben Konrath <ben@bagu.org>
2170 Put tableselector on the right, back to list link on right.
2172 The idea is that the table selector is acting like a label for the
2173 currently displayed table so it should be placed below the document title. This
2174 puts the table title in a similar position to where it is in Glom.
2176 * mockups/details-contacts.html:
2177 * mockups/details-projects.html:
2178 * mockups/listview-contacts.html:
2179 * mockups/listview-projects.html:
2180 * mockups/style.css:
2181 Update mockups to match how the interfaces currently look.
2182 * src/main/webapp/style.css: Swap positions of backlink with the table
2183 selector. Add some space on the left side of the table selector to
2184 line things up with the document title.
2186 2011-09-27 Ben Konrath <ben@bagu.org>
2188 Add field colouring to details view.
2190 This change re-works how field colouring works. The colour formatting
2191 information is now set to the client with the layout information instead of
2192 with the data. This eliminates the need to send the same colour strings for
2193 data in list view column when colour information is set.
2195 In order to set an alternate colour for negative numeric values, the
2196 number is now sent to client and formatted with the GWT NumberFormat class.
2198 This change also fixes:
2200 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2202 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2203 internationalization framework which is needed for client side numeric
2205 * src/main/java/org/glom/web/client/Utils.java: New file for some
2206 client static utility methods.
2207 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2208 the DataItem object to the Field class. Use a utility method to
2209 create the foreignKeyValue string.
2210 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2211 alignment and text colours in the constructor. Add setData(DataItem)
2212 method. Remove setText(String) method.
2213 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2214 colour information to GlomTextCell. Create and use GlomNumberCell for
2215 rendering numbers. Use utility method to get the string for the
2216 primary key of the key provider. Re-work how the horizontal alignment
2218 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2219 formatting to layout information. Methods for converting the libglom
2220 formatting information were moved from DBAccess.
2221 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2222 numeric formatting (it's now done on the client side). Don't set text
2223 colours in DataItem. Move libglom formatting conversion methods to
2225 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2226 getters/setters for text colour information.
2227 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2228 for transferring the libglom NumericFormat information to the client.
2229 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2230 and getters/setters for: GlomNumericFormat, background colour and
2231 foreground colour strings.
2233 2011-09-26 Ben Konrath <ben@bagu.org>
2235 Simplify code that iterates through the LayoutGroup.
2237 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2239 2011-09-26 Ben Konrath <ben@bagu.org>
2241 Accept Eclipse formatting for OnlineGlomServiceAsync.
2243 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2245 2011-09-26 Ben Konrath <ben@bagu.org>
2247 Don't use the ListDBAccess classes to get the primary key layout information.
2249 This was causing a bug where the wrong index for the hidden primary key
2250 was being sent to the client.
2252 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2253 primary key while creating the LayoutGroup DTO. Create a
2254 LayoutItemField DTO for hidden primary keys. Don't use the
2255 RelatedListDBAccess because it was only used for getting the primary
2257 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2258 access modifier from public to protected for getPrimaryKeyField() and
2259 getPrimaryKeyLayoutItemField().
2260 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2261 abstract method getExpectedResultSize() because RelatedListDBAccess
2262 doesn't have enough info to implement it.
2263 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2264 Remove @Override for getExpectedResultSize().
2265 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2266 Remove method getExpectedResultSize().
2268 2011-09-23 Ben Konrath <ben@bagu.org>
2270 Log which layout (list or details) the ignored item is from.
2272 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2274 2011-09-23 Ben Konrath <ben@bagu.org>
2276 Remove annotations that turn off code formatting in DataItem.
2278 * src/main/java/org/glom/web/shared/DataItem.java:
2280 2011-09-23 Ben Konrath <ben@bagu.org>
2282 Rename GlomField to DataItem and update associated methods.
2284 This is a rename-only refactor. No functionality has been added or
2287 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2288 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2289 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2290 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2291 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2292 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2293 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2294 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2296 * src/main/java/org/glom/web/server/database/DBAccess.java:
2297 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2298 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2299 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2300 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2301 * src/main/java/org/glom/web/shared/DataItem.java:
2302 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2303 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2305 2011-09-23 Ben Konrath <ben@bagu.org>
2307 Rename GlomDocument to DocumentInfo and update associated methods.
2309 This is a rename-only refactor. No functionality has been added or
2312 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2313 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2314 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2315 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2316 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2317 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2318 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2320 2011-09-20 Ben Konrath <ben@bagu.org>
2322 Require java-libglom 1.17.3.
2324 This picks up the fix for the seg fault problem with the Scenes table
2325 in the Openismus Film Manager example.
2329 2011-09-20 Ben Konrath <ben@bagu.org>
2331 Change the way sort clause is added for primary key when no sort clause is requested.
2333 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2334 before the sort clause is created. When a sort clause is not requested, the
2335 sort clause is created by finding the primary key in the LayoutFieldVector
2338 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2340 2011-09-20 Ben Konrath <ben@bagu.org>
2342 Log error message if no documents are found in the configured directory.
2344 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2345 Extract the glom file extension string to a private static final class
2346 variable (mostly as syntactic sugar). Accept a minor formatting change.
2347 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2348 the example glom.document.directory configuration property to make it
2349 more clear that it can any directory, not just the home directory.
2351 2011-09-18 Ben Konrath <ben@bagu.org>
2353 Add related lists to details view.
2355 The related list table has support for paging and sorting just like the
2356 table in the list view.
2358 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2359 SQL queries for the related list tables.
2360 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2361 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2362 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2363 Rename getList methods to getListView and add comments. Remove
2364 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2365 it being unused. Add methods: getDetailsLayoutAndData(),
2366 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2367 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2368 Create the layout and set the data for the fields in one async call
2369 instead of two. Create related lists where appropriate.
2370 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2371 for method name changes in OnlineGlomService.
2372 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2373 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2374 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2376 * src/main/java/org/glom/web/client/ui/ListView.java:
2377 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2378 tableName from setCellTable(). Create a ListViewTable instead of
2380 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2381 represent a data field in the details view.
2382 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2383 from addDetailsCell() to Field class. Keep track of the Fields and
2384 Portals in the details view.
2385 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2386 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2387 and add a method to get it. Add method to set the contents of the
2389 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2390 New class for related list tables. This class has the data provider
2391 for the related list table.
2392 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2393 abstract class which is the base class for the ListViewTable and the
2395 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2396 New class for list view tables. This class has the data provider for
2397 the list view table.
2398 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2399 methods for related list tables. Add more information to the
2400 LayoutItemField and LayoutItemPortal DTOs.
2401 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2402 Remove debugging print statement.
2403 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2404 Remove debugging print statements. Add primary key field to SQL count
2406 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2407 Remove unnecessary LayoutFieldVector parameter from
2408 getResultSizeOfSQLQuery() method.
2409 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2410 New class for related list table database access.
2411 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2412 class that is a wrapper DTO for details view layout and data.
2413 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2414 new 'fromField' string to this DTO.
2415 * src/main/webapp/style.css: Remove bottom margin and override top
2418 2011-09-15 Ben Konrath <ben@bagu.org>
2420 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2422 This sets things up to make it easier to add the data retrieval for
2423 related lists (portals). No user noticeable changes were made with
2426 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2427 class has the code to retrieve the layouts and access the
2428 database using the new database helper classes.
2429 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2430 Most of the functionality has been removed from this class. This
2431 class now represents the public interface for the client side
2432 code. It also deals with configuring the servlet and cleaning
2433 things up when the servlet is stopped.
2434 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2435 of static methods into this utility class.
2436 * src/main/java/org/glom/web/server/database/DBAccess.java:
2437 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2438 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2439 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2440 These classes have the database retrieval code. The class hierarchy
2441 has been setup to make it easy to reuse code for similar
2444 2011-09-06 Ben Konrath <ben@bagu.org>
2446 Create separate classes for list table code and the data provider.
2448 As part of this refactor, I also split up the code a bit to make it
2451 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2452 table code to two new classes (below).
2453 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2454 with code from ListViewImpl.
2455 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2456 New file with code from ListViewImpl.
2458 2011-09-06 Ben Konrath <ben@bagu.org>
2460 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2462 This fixes the LayoutItemPortal DTO to match the libglom layout object
2465 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2467 2011-09-01 Ben Konrath <ben@bagu.org>
2469 Set title of Portals in the Details View.
2471 * pom.xml: Bump required version of java-libglom to 1.17.1.
2472 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2473 widget creation to its own class. Add comments to constructor.
2474 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2475 The code is mostly from the Group class with the title now set.
2476 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2477 title of Portal. Update some comments. Fix some code formatting.
2479 2011-09-01 Ben Konrath <ben@bagu.org>
2481 Remove TODO comment for the flow table column width.
2483 The flow table column width is working correctly and doesn't need to be
2484 changed. See this mailing list post for more info:
2486 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2488 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2490 2011-08-27 Ben Konrath <ben@bagu.org>
2492 Add document title (database name) to top of the browser page.
2494 I added the document title to the TableSelecitonView but that will
2495 change if / when we add a view that doesn't require table selection.
2497 * mockups/details-contacts.html:
2498 * mockups/details-projects.html:
2499 * mockups/listview-contacts.html:
2500 * mockups/listview-projects.html:
2501 * mockups/style.css: Add document title to mockups to keep things
2503 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2504 sizes to account for the document title.
2505 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2506 Set the document title when it has been retrieved from the server.
2507 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2508 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2509 and implement setDocumentTitle(String) method.
2510 * src/main/webapp/style.css: Add ID for document title style.
2512 2011-08-25 Ben Konrath <ben@bagu.org>
2514 Add NavigationType enum to LayoutItemPortal DTO.
2516 This is the start of adding support for Portals to the Details View.
2518 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2519 LayoutItem_Portal.navigation_type enum from libglom to
2520 LayoutItemPortal.NavigationType enum.
2521 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2522 NavigationType enum, field for storing the NavigationType and getter
2525 2011-08-25 Ben Konrath <ben@bagu.org>
2527 Implement the flow table layout in the Details View.
2529 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2530 FlowTable to Group to account for the renamed class.
2531 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2532 File. This is a container widget that implements the Glom details view
2533 flow table behaviour.
2534 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2535 org/glom/web/client/ui/FlowTable.java.
2536 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2537 so that the size of the subgroups are a closer match to the size of
2538 the Glom subgroups. This makes the flowtable layout match the layout
2539 in Glom for the Music Collection example file.
2541 2011-08-16 Ben Konrath <ben@bagu.org>
2543 Create container element for LayoutItemPortal in Details View.
2545 This will help me develop the layout for the FlowTable.
2547 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2548 fieldPanel variable to detailsCell.
2550 2011-08-15 Ben Konrath <ben@bagu.org>
2552 Set the height of the data element in the Details View.
2554 I changed the InlineLabels (text in a span element) to Labels (text in
2555 a div element) so that I could set the height of the details-data
2556 elements instead of the details-cell parent elements. This allows the
2557 the details-data element to display the correct height if style is
2558 applied that shows the height.
2560 This change has the added benefit of allowing the order of the labels
2561 and data elements to be changed for right-to-left languages.
2563 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2564 InlineLabels to Labels.
2565 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2566 InlineLabels to Labels. Set the height of the data element.
2567 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2568 multiline text height in the Formatting DTO.
2569 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2570 for multiline height along with getter and setter methods.
2571 * src/main/webapp/style.css: Adjust style to account for the change
2572 from span elements to div elements in the details cell.
2574 2011-08-15 Ben Konrath <ben@bagu.org>
2576 Make the List View appearance match the mockups.
2578 It doesn't match exactly but it's much better than it was.
2580 * mockups/listview-contacts.html: Remove unused css classes.
2581 * mockups/listview-projects.html: Remove unused css classes.
2582 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2583 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2584 for mainPanel instead of VerticalPanel (table). Set style name on
2585 CellTable. Set style name on Details column. Right-align Details
2587 * src/main/webapp/style.css: Adjust properties to match the mockups.
2589 2011-08-12 Ben Konrath <ben@bagu.org>
2591 Add better support for subgroups in the details view.
2593 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2594 changed FlowTable constructor.
2595 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2596 support for subgroups and subgroup-titles.
2597 * src/main/webapp/style.css: Add CSS class for subgroups and
2600 2011-08-12 Ben Konrath <ben@bagu.org>
2602 Return the top level LayoutGroup title.
2604 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2606 2011-08-11 Ben Konrath <ben@bagu.org>
2608 Make the TableSelector header match the mockup.
2610 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2611 the layout panel. Properly lineup the table selection header with
2612 the list and details view.
2613 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2614 margin around the details view.
2615 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2616 Rename listBox variable to tableSelector. Set id for the style sheet.
2617 Use a FlowPanel instead of a HorizontalPanel.
2618 * src/main/webapp/style.css: Add properties to make the TableSelector
2619 box match the mockups.
2621 2011-07-13 Ben Konrath <ben@bagu.org>
2623 Update install script for java-libglom version change.
2625 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2628 2011-07-13 Ben Konrath <ben@bagu.org>
2630 Add support sub-group in the details view.
2632 I also removed the code that special-cased the default details view
2635 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2637 I still have to make a proper flowtable.
2639 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2640 Don't special-case default details view layout.
2641 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2642 addLayoutField() as I'm going to use it.
2643 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2644 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2646 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2647 extracted from DetailsViewImpl.GroupPanel. Add support for
2649 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2650 column count when getting the details layout.
2652 2011-07-12 Ben Konrath <ben@bagu.org>
2654 Set browser title with database and table titles.
2656 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2657 Set the browser title when the table changes and when the activity
2659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2660 title when retrieving document info (the GlomDocument object).
2661 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2662 with getter and setter methods. Remove unused convenience constructor.
2663 Use default code formatting.
2665 2011-07-12 Ben Konrath <ben@bagu.org>
2667 Ignore LayoutItemPortals in the details view.
2669 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2672 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2673 LayoutItemPortal layout objects.
2674 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2675 LayoutItemPortal objects when retrieving the details layout.
2676 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2677 file. This is an empty class and just used to get type information for
2680 2011-07-12 Ben Konrath <ben@bagu.org>
2682 Use java-libglom 1.17.0.
2686 2011-07-11 Ben Konrath <ben@bagu.org>
2688 Remove "Table:" label from table selector.
2690 This matches a recent change in the Glom UI.
2692 * mockups/details-contacts.html:
2693 * mockups/details-projects.html:
2694 * mockups/listview-contacts.html:
2695 * mockups/listview-projects.html: Remove the "Table:" label from the
2697 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2699 2011-07-11 Ben Konrath <ben@bagu.org>
2701 Add main groups to the details view.
2703 This makes things look a little nicer in the details view. The next step
2704 is to implement the flowtable.
2706 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2707 resources from the standard gwt css theme. Standard.css is now
2708 included in OnlineGlom.html so that the online glom css rules have
2709 precedence over the gwt theme.
2710 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2711 the whole LayoutGroup to the DetailsView instead of just the titles.
2712 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2713 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2714 details layout with a helper class (GroupPanel). I might extract this
2715 class when I make the full flowtable.
2716 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2717 string as default so I don't have to worry about NPEs when processing
2719 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2720 note beside OnlineGlom.gwt.xml above).
2721 * src/main/webapp/style.css: Add default font-size to body to override
2722 the font-size set by the standard theme. Don't use h2 tags for
2723 group-title. Create new details-cell class.
2725 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2727 ConfiguredDocument: Set the port number too.
2729 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2730 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2731 Glom document. Presumably this worked sometimes so far because there is a
2732 default port number.
2734 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2736 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2738 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2739 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2740 correct, though we should throw an exception too.
2742 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2744 Fix a addDocuemnt typo.
2746 * src/main/java/org/glom/web/shared/Documents.java
2747 (Documents.addDocuemnt): Rename to addDocument().
2748 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2749 (OnlineGlomServiceImpl.getDocuments): Adapt.
2751 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2753 Slightly improved log output when connection fails.
2755 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2756 (ConfiguredDocument.setUsernameAndPassword):
2757 We don't know for sure if it' the username/password that's wrong, so
2758 rephrase the message.
2759 Also ouput the exception message, though it's generic in this case.
2761 2011-07-08 Ben Konrath <ben@bagu.org>
2765 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2766 added braces to a one line if statement because the Eclipse formatter
2767 was getting confused.
2769 2011-07-07 Ben Konrath <ben@bagu.org>
2771 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2773 These should really be two separate tasks but I counldn't get things to
2774 work with GWT 2.2.0 and Eclipse 3.7.
2778 * .settings/org.eclipse.jdt.core.prefs:
2779 * .settings/org.eclipse.jdt.ui.prefs:
2780 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2781 * .settings/org.eclipse.m2e.core.prefs:
2782 Add new config files. Update current files. Remove references to the
2783 webtools plugins as we're not using any of the webtools features.
2784 * .gitignore: Add logs directory which is created when running with
2786 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2787 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2788 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2790 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2792 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2794 onlineglom.properties: Add explanatory comments.
2796 * src/main/resources/onlineglom.properties: Also change the default user
2797 from ben to someuser, to avoid the risk of people thinking we just
2798 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2800 2011-06-28 Ben Konrath <ben@bagu.org>
2802 Use filename in Log for incorrect passwords.
2804 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2805 getFileName(String) method to get the filename from the URI.
2807 2011-06-28 Ben Konrath <ben@bagu.org>
2809 Add the table name to the URL token for the ListPlace.
2811 This makes things consistent between the DetailsPlace and the
2812 ListPlace. It also allows the the ListPlace to be bookmarked.
2814 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2815 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2817 Remove getDefaultListLayout(). The default layout is now returned
2818 by the getListLayout() method when the table name is an empty string.
2819 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2820 Add table name field. Change to a new ListPlace when the table
2821 has been changed. Use getListLayout() for getting the default
2823 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2824 Add table name field. Set the correct table name in the list box
2825 when loading from bookmark. This corrects a problem for the
2827 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2828 Move table name to super-class (HasSelectableTable). Move document
2829 and table URL keys to super-class in HasSelectableTable.
2830 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2831 Add table name field. Add Tokenizer class with URL key common to
2832 the subclasses (DetailsPlace and ListPlace).
2833 * src/main/java/org/glom/web/client/place/ListPlace.java:
2834 Add table name. Add code to parse the URL token.
2835 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2836 Update ListPlace construction with empty table name string.
2837 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2838 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2839 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2840 Update ListPlace construction with table name string.
2841 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2842 Change defaultTableName field to tableName to reflect how it's now
2843 used. Update the getter and setter methods.
2845 2011-06-28 Ben Konrath <ben@bagu.org>
2847 Enable the table selector in the DetailsView.
2849 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2850 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2852 Remove getDefaultDetailsLayout(). The default layout is now returned
2853 by the getDetailsLayout() method when the table name is an empty
2855 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2856 event handler for table change event. Change to using
2857 getDetailsLayout() for the default details layout.
2858 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2860 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2861 when navigating to the details place.
2863 2011-06-27 Ben Konrath <ben@bagu.org>
2865 Use filename based unique document ID in URL and for RPC.
2867 The document ID is the glom document name with spaces (' ') replaced
2868 with pluses ('+') and without the .glom extension.
2870 This change is mostly a string substitution of 'documentTitle' for
2871 'documentID'. The only code change is the addition of a Documents DTO to get the
2872 filename to document title mappings as indicated below.
2874 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2875 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2876 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2877 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2878 Use Documents DTO to create the document links in the document
2880 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2881 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2882 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2883 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2884 * src/main/java/org/glom/web/client/place/ListPlace.java:
2885 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2886 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2887 * src/main/java/org/glom/web/client/ui/ListView.java:
2888 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2889 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2890 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2891 * src/main/java/org/glom/web/server/Log.java:
2892 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2893 getDocumentTitles() to getDocuments() and return the Documents DTO.
2894 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2895 transferring the filename to document title mappings.
2897 2011-06-25 Ben Konrath <ben@bagu.org>
2899 Make the authentication popup work again.
2901 This bug was introduced when I extracted ConfiguredDocument to its own class.
2903 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2904 correct success / fail status in setUsernameAndPassword().
2906 2011-06-25 Ben Konrath <ben@bagu.org>
2908 Use filename as unique key for configuring database usernames and passwords.
2910 This replaces the use of the Glom document title which could change
2911 depending on the locale. Thanks to Murray Cumming for pointing out this
2914 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2915 * src/main/resources/onlineglom.properties:
2917 2011-06-24 Ben Konrath <ben@bagu.org>
2919 Pass primary key value to DetailsView.
2921 This enables the DetailsView to load the correct data.
2923 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2924 primary key value field and set in constructor. Pass primary key
2925 value to getDetailsData().
2926 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2927 variables for document title and primary key value.
2928 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2929 key value to the DetailsPlace.
2931 2011-06-24 Ben Konrath <ben@bagu.org>
2933 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2935 This allows the primary key to be retrieved by the Details button. This
2936 functionality has not been implemented yet but it's in the works.
2938 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2939 the LayoutGroup result to ListView.setCellTable instead of all of its
2940 fields individually.
2941 * src/main/java/org/glom/web/client/ui/ListView.java:
2942 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2943 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2944 get the primary key for the table.
2945 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2946 index of the primary key in the LayoutGroup accounting for hidden
2947 primary keys. Rename getJavaNumberFormat() to
2948 convertToJavaNumberFormat() for consistency. Cleanup / add some
2950 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2951 field for primary key index and a field to indicate whether the
2952 primary key is hidden or not.
2954 2011-06-23 Ben Konrath <ben@bagu.org>
2956 Rename getTableData methods to getListData.
2958 This is a rename refactor for consistency with other methods.
2960 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2961 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2962 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2963 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2965 2011-06-23 Ben Konrath <ben@bagu.org>
2967 Extract the ConfiguredDocument innerclass into its own class.
2969 This makes the servlet code more object oriented.
2971 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2972 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2973 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2974 new ConfiguredDocument class.
2976 2011-06-21 Ben Konrath <ben@bagu.org>
2978 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2980 This makes things more inline with how libglom works and reduces code
2981 duplication. This refactor lays the groundwork for adding the primary key to
2982 the LayoutGroup object.
2984 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2985 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2987 Change method names to getListLayout and getDefaultListLayout for
2988 consistency. Use LayoutGroup as the DTO for the list layout instead of
2989 ColumnInfo and LayoutListTable.
2990 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2991 new method names along with the LayoutGroup object for transferring the
2993 * src/main/java/org/glom/web/client/ui/ListView.java:
2994 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2995 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2996 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2998 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2999 Replaced with LayoutGroup.
3000 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3001 expectedResultSize and defaultTableName fields which are needed for
3003 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3004 type field which is needed for the list layout but will also be
3005 useful for the details layout as things progress.
3006 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3007 Make class abstract. Remove the unnecessary
3008 getFormattingHorizontalAlignment method. Add setFormatting method.
3010 2011-06-16 Ben Konrath <ben@bagu.org>
3012 Add scripts for building and installing war.
3014 These will help when updating OnlineGlom but they're also good
3015 supplemental documentation of the build and deployment proceeding.
3017 * utils/build-onlineglom-war.sh: New file.
3018 * utils/install-onlineglom-war.sh: New file.
3020 2011-06-16 Ben Konrath <ben@bagu.org>
3022 Create wrapper class to create consistent log messages.
3024 I wrapped methods in the Log class of gwt-log to add the method names
3025 from the servlet and create consistent formatting of the document title
3026 and table names in the log messages.
3028 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3030 log methods to use methods from wrapped Log class.
3032 2011-06-16 Ben Konrath <ben@bagu.org>
3034 Remove superfluous conditional return.
3036 Thanks to Murray Cumming for pointing this out!
3038 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3040 2011-06-15 Ben Konrath <ben@bagu.org>
3042 Return an ArrayList of LayoutGroups for the Details layout.
3044 This corrects a problem with the details layout as it can have more
3045 than one top level LayoutGroup.
3047 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3048 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
3049 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
3050 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
3051 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
3052 with ArrayList of LayoutGroups for the details view layout.
3053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3054 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
3055 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
3056 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
3057 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
3058 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
3060 2011-06-14 Ben Konrath <ben@bagu.org>
3062 Use cast_dynamic method to determine the libglom LayoutItem type.
3064 This is better than finding the LayoutItem type by using the string
3065 returned from the get_part_type_name() method.
3067 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3069 2011-06-14 Ben Konrath <ben@bagu.org>
3071 Add method names to log entries in the servlet.
3073 This helps when tracking down deployment problems.
3075 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3077 2011-06-14 Ben Konrath <ben@bagu.org>
3079 Add data to the DetailsView using a hard-coded primary key value.
3081 The layout and functionality of the DetailsView is not complete. This
3082 is just a checkpoint so the patch doesn't get too big.
3084 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3085 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3086 Add getDetailsData() servlet method.
3087 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3088 Add RPC to getDetailsData(). Change the way the LayoutGroups and
3089 LayoutFields are added to the DetailsView.
3090 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3091 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3092 Add setData() method. Change addLayoutGroup() and addLayoutField() to
3093 take the string for the title instead of the object.
3094 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3095 Add implementation getDetailsData() along with some private helper
3097 * src/main/webapp/style.css: Add padding to details-data class. Add a
3098 details-label class with the same padding as the details-data class.
3100 2011-06-03 Ben Konrath <ben@bagu.org>
3102 Use presenter.goTo() to change to the DetailsPlace.
3104 This will make things easier when we need to open the DetailsView with
3105 data specific to the row that was clicked.
3107 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3109 2011-06-02 Ben Konrath <ben@bagu.org>
3111 Add CSS file from mockups.
3113 I'm adding this now because it's going to be useful to have when
3114 developing the DetailsView. The TableSelectionView and ListView aren't
3117 * src/main/webapp/OnlineGlom.html:
3118 * src/main/webapp/style.css:
3120 2011-06-02 Ben Konrath <ben@bagu.org>
3122 Use String.isEmpty() to check for empty string.
3124 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3126 2011-06-02 Ben Konrath <ben@bagu.org>
3128 Display main layout group titles in the DetailsView.
3130 This is the start of the DetailsActivity/DetailsView implementation.
3132 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3133 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3134 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
3135 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3136 Get the layout information for the details view from the server and set
3137 the main layout group titles.
3138 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3139 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3140 Add addLayoutGroup() and addLayoutField() methods. This are just
3141 temporary methods for creating the the details view that will change
3143 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3144 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
3146 * src/main/java/org/glom/web/shared/layout/Formatting.java:
3147 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3148 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
3149 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
3150 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3151 Data Transfer Objects that mimic the libglom object structure. These are
3152 used for transferring the details layout but could also be used for
3153 transferring the list layout.
3155 2011-05-27 Ben Konrath <ben@bagu.org>
3157 Reset the AuthenticationPopup when clearing the ListView.
3159 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3161 2011-05-27 Ben Konrath <ben@bagu.org>
3163 Fix problem with onlineglom.properties file loading.
3165 The old way worked in Eclipse but not on the server. Loading the
3166 onlineglom.properties file now works in Eclipse and on the server.
3168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3170 2011-05-24 Ben Konrath <ben@bagu.org>
3172 Update gwt-log from 3.1.0 to 3.1.2.
3174 Gwt-log 3.1.0 has been marked as depreciated.
3178 2011-05-24 Ben Konrath <ben@bagu.org>
3180 Add comment to ListActivity.goTo() method.
3182 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3184 2011-05-24 Ben Konrath <ben@bagu.org>
3186 Remove FIXME in convertGdkColorToHtmlColour()
3188 The Gdk::Color value returned by libglom is 16-bits per channel on both
3189 64 and 32-bit platforms.
3191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3193 2011-05-19 Ben Konrath <ben@bagu.org>
3195 Improve performance of initial ListView load.
3197 I removed a round trip to the server for getting the default table name
3198 and then requesting information about that table. This also removes a potential
3199 problem with the table change handler not being setup in time to receive the
3200 table change event from the ListActivity.
3202 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3203 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3204 getDefaultLayoutListTable() method. Improve comments.
3205 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
3206 getDefaultLayoutListTable() method instead of firing a table change
3207 event to get the table to load.
3208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3209 implementation of getDefaultLayoutListTable() method.
3210 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3213 2011-05-19 Ben Konrath <ben@bagu.org>
3215 Override toDebugString() in TableChangeEvent.
3217 This is useful to have for debugging.
3219 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3221 2011-05-19 Ben Konrath <ben@bagu.org>
3223 Add a "Back to List" link when at the DetailsPlace.
3225 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3226 Populate the CellTable based on the selected table of the ListBox if
3227 it's set otherwise use the default table. This allows the "Back to
3229 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3230 Remove Place from constructors. Add a setPlace() method. Add
3231 goToPlace() method. Set class as presenter for TableSelectionView.
3232 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3233 Use the same TableSelectionActivity when switching between the List and
3235 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3236 Subclass the new HasSelectableTablePlace. This removes some duplicate
3238 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3239 New class to represent Places that display the TableSelectionView.
3240 * src/main/java/org/glom/web/client/place/ListPlace.java: