1 2012-01-24 Murray Cumming <murrayc@murrayc.com>
3 Update to the latest java-libglom API.
5 * pom.xml: Require java-libglom 1.21.4.
6 * src/main/java/org/glom/web/server/ConfiguredDocument.java
7 getDocumentInfo(), getListViewLayoutGroup():
8 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
10 * src/main/java/org/glom/web/server/database/DBAccess.java
11 getFieldsToShowForSQLQueryAddGroup(),
12 getPrimaryKeyLayoutItemField(): Replace get_database_title()
13 with either get_database_title_original() or
14 get_database_title(localeID).
16 2012-01-24 Murray Cumming <murrayc@murrayc.com>
18 ConfiguredDocument: Avoid a null pointer exception.
20 * src/main/java/org/glom/web/server/ConfiguredDocument.java
21 Initialize localeID to "" to avoid returning a null String which
22 causes a crash in java-libglom's swing-generated code.
24 2012-01-23 Murray Cumming <murrayc@murrayc.com>
28 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
29 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
30 for localeChooser. This seems more appropriate and is less ambiguous
31 particularly in the .css file.
33 2012-01-23 Murray Cumming <murrayc@murrayc.com>
35 ConfiguredDocument: Rename the localedID private member variable.
37 2012-01-23 Murray Cumming <murrayc@murrayc.com>
39 Adapt to the latest java-libglom API from git master.
41 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
42 libglom now uses only Vector instead of List, which uses add() instead of
45 2012-01-23 Murray Cumming <murrayc@murrayc.com>
47 Add and fill a Reports drop-down list box.
49 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
51 * src/main/java/org/glom/web/client/OnlineGlomService.java:
52 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
53 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
54 Added getReports(document, table, localeID), calling
55 ConfiguredDocument.getReports().
56 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
57 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
58 Added setReportsList() and a list widget.
59 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
60 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
62 2012-01-22 Murray Cumming <murrayc@murrayc.com>
64 ConfiguredDocument: Rename the localedID private member variable.
66 2012-01-20 Murray Cumming <murrayc@murrayc.com>
68 Build a source tarball with mvn assembly:single
70 * assembly.xml: Add this file.
71 * pom.xml: Use the maven-assembly-plugin and tell it to use
72 our assembly.xml file.
74 2012-01-19 Murray Cumming <murrayc@murrayc.com>
76 OnlineGlomServiceImpl: Get .glom files recursively.
78 * pom.xml: Depend on commons-io from org.apache.commons.
79 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
80 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
81 files recursively, and with the easier filter for the extension.
82 Use org.apache.commons.io.FilenameUtils.removeExtension() to
83 simplify that code too.
85 2012-01-19 Murray Cumming <murrayc@murrayc.com>
87 README: Mention that you must install java-libglom packages separately.
89 But then it works, because java-libglom is now in the central maven
92 2012-01-18 Murray Cumming <murrayc@murrayc.com>
94 locales drop-down: Show the correct selected locale when the URL changes.
96 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
97 .java: setPlace(): Move some code into fillView().
99 2012-01-18 Murray Cumming <murrayc@murrayc.com>
101 locales drop-down: Do not lose the primary key.
103 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
104 start(): onLocaleChange(): Pass the current primary key value,
105 instead of an empty value.
107 2012-01-18 Murray Cumming <murrayc@murrayc.com>
109 locales drop-down: Do not lose the drop-down selection.
111 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
112 .java (TableSelectionActivity.fillView): Set the selected locale
113 after changing the drop-down items (though we do not really need
114 to change them just because the locale changes.)
116 2012-01-18 Murray Cumming <murrayc@murrayc.com>
118 locales drop-down: Change the tables list when this changes.
120 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
121 .java: TableSelectionActivity.start(): Move the async table titles
122 retrieval into a private fillView() method and also call this when
123 the chosen locale changes.
124 Note that the document title is not actually translatable yet, but
125 that is a problem that I should fix soon in libglom.
127 2012-01-18 Murray Cumming <murrayc@murrayc.com>
129 Improve the placement of the locales drop-down.
131 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
132 Put the title and locales drop-down in a div (gwt.FlowTable).
133 * src/main/webapp/style.css: Add magic css properties to make this work.
134 Also remove the left margin from the title so that it lines up with the
137 2012-01-18 Murray Cumming <murrayc@murrayc.com>
139 locales selector: Show human-readable locale titles.
141 * src/main/java/org/glom/web/server/ConfiguredDocument.java
142 getDocumentInfo(): Use java.util.Locale to show a real title of
143 each locale, in the locale's own language.
145 2012-01-17 Murray Cumming <murrayc@murrayc.com>
147 Add a language/locale selector drop-down.
149 * src/main/java/org/glom/web/shared/DocumentInfo.java:
150 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
151 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
152 getDocumentInfo(): Store the available Locales in the DocumentInfo.
153 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
154 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
155 Add a ListBox to show the available locales. Add getLocaleSelector(),
156 setLocaleList(), getSelectedLocale(), setSelectedLocale().
157 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
158 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
159 java: Add these classes.
160 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
161 start(): Fill the locales ListBox. Handle its change event, firing a
163 setPlace(): Show the selected locale as specified by the URL token.
164 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
165 * src/main/java/org/glom/web/client/activity/ListActivity.java:
166 Handle LocaleChangeEvent, going to a new *Place with that locale.
168 The placement of the ListBox is not pretty, and it currently uses the ID
169 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
173 2012-01-17 Murray Cumming <murrayc@murrayc.com>
175 Search box: Show the search text from the URL token.
177 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
178 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
179 Add setQuickFindText().
180 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
181 .java: setPlace(): Store the queryText if the place is a ListPlace,
182 and call TableSelectionView.setQuickFindText().
184 2012-01-17 Murray Cumming <murrayc@murrayc.com>
186 Allow use of translations via, for instance, &lang=de in the URL.
188 * pom.xml: Use the unstable java-libglom 1.21 version.
190 * src/main/java/org/glom/web/client/OnlineGlomService.java:
191 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
193 init(): Instead of calling TranslatableItem.set_current_locale()
194 (now removed), call ConfiguredDocument.setDefaultLocaleID().
195 However, this is only for default locales, which are not needed to
196 change the locale in the URL.
197 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
198 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
199 getSortedRelatedListData(): Add a localeID parameter, so we can get the
200 layout for a particular locale.
201 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
202 Add get/setDefaultLocaleID().
203 getDocumentInfo(), getListViewData(), getRelatedListData(),
204 getDetailsLayoutGroup(), getListViewLayoutGroup(),
205 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
206 localeID parameter, so we can get the layout for a particular locale.
208 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
209 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
210 * src/main/java/org/glom/web/client/place/ListPlace.java:
211 Parse and construct a lang parameter too.
213 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
214 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
215 passed to subsequent methods and constructors.
216 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
217 * src/main/java/org/glom/web/client/activity/ListActivity.java:
218 Store the localeID from the *Place and pass it to other constructors
219 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
221 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
222 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
223 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
224 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
225 * src/main/java/org/glom/web/client/ui/ListView.java:
226 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
227 Take localeID parameters and pass them to subsequent constructors and
228 methods, so that the layout is always retrieved for that locale.
230 This is rather repetitive.
232 Note that "" means the original (default) locale of the Glom document,
233 which is usually English.
235 2012-01-17 Murray Cumming <murrayc@murrayc.com>
237 Documents: Remove final keyword to fix startup configuration.
239 * src/main/java/org/glom/web/shared/Documents.java: Remove the
240 final keywords on the private member variables because that breaks
241 the startup, apparently (there are warnings) because it stops them
242 from being serialized. I added these in the previous commit.
244 2012-01-13 Murray Cumming <murrayc@murrayc.com>
246 Documents: Add some final keywords.
248 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
251 2012-01-13 Murray Cumming <murrayc@murrayc.com>
253 OnlineGlomServiceImpl: Add to overview comments.
255 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
256 Note that this is where all the document are loaded. They are not
257 loaded freshly for each page.
259 2012-01-12 Murray Cumming <murrayc@murrayc.com>
263 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
264 Add a TextBox for the text of a quick find.
265 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
267 setBackLink(): Add a String quickFind parameter.
268 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
269 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
270 to the base interface, because that is how TableSelectionViewImpl is used.
271 * src/main/webapp/style.css: Add style for the search box and its label.
273 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
274 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
275 Add these files, based on the existing TableChangeEvent and
276 TableChangeEventHandlers.
277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
278 start(): Handle QuickFindChangeEvent, passing its quickFind text to
279 a ListPlace() that the user should be taken to.
280 * src/main/java/org/glom/web/client/activity/ListActivity.java
281 start(): Handle it here too and adapt the TableChangeEvent handler to
282 pass the extra "" quickFind parameter to ListPlace.
283 * src/main/java/org/glom/web/client/place/ListPlace.java:
284 Constructor: Take an extra String quickFind parameter and store it,
285 returning it from a new getQuickFind() method.
286 getToken(): Put the quickFind text in the URL token.
287 getPlace(): Parse the quickFind text from the URL token.
288 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
289 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
290 ListPlace constructor.
291 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
292 .java: start(): Add a Change handler for the TableSelectionView's
293 TextBox (via its base HasChangeHandlers interface), firing the new
294 QuickFindChangeEvent.
295 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
296 pass the extra "" quickFind parameter.
298 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
299 setCellTable(): Add a String quickFind parameter and pass it to
300 the ListViewTable() constructor.
301 * src/main/java/org/glom/web/client/ui/ListView.java: Change
302 setCellTable() in the base interface, because that is how ListViewImpl
305 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
306 Add a String quickFind member variable.
307 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
308 Constructor: Add a String quickFind parameter, storing it in the
309 base ListTable's member variable.
310 onRangeChanged(): Pass quickFind to the
311 OnlineGlomServiceAsync.getSortedListViewData() and
312 OnlineGlomServiceAsync.getListViewData() methods.
314 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
315 getListViewData(), getSortedListViewData(): Add a String quickFind
316 parameter, passing it to ConfiguredDocument.getListViewData().
317 * src/main/java/org/glom/web/client/OnlineGlomService.java:
318 Change getListViewData(), getSortedListViewData() in the base interface,
319 because that is how OnlineGlomServiceImpl is used, via this:
320 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
321 Change getListViewData(), getSortedListViewData() here too.
322 This class can apparently be used to asynchronously call methods on
323 OnlineGlomService, and GWT seems to implement that after recognizing
324 just the *Async name convention and the extra AsyncCallback parameters.
326 * src/main/java/org/glom/web/server/ConfiguredDocument.java
327 getListViewData(): Add a String quickFind parameter, and pass it to
328 ListViewDBAccess.getData().
329 * src/main/java/org/glom/web/server/database/ListDBAccess.java
330 getListData(): Add a String quickFind parameter and pass it to
332 getSelectQuery(): Add a String quickFind parameter.
333 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
334 getSelectQuery(): Add a String quickFind parameter and use it with
335 Glom.get_find_where_clause_quick() to pass a where_clause to
336 Glom.build_sql_select_with_where_clause(), to actually filter the
338 getData(): Add a String quickFind parameter, passing it to getListData().
339 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
340 va: getData(): Pass an empty string to getListData() for the
343 2012-01-12 Murray Cumming <murrayc@murrayc.com>
345 ListTable: Minor change.
347 * src/main/java/org/glom/web/client/ui/list/ListTable.java
348 createCellTable(): Make this protected instead of public.
350 2012-01-12 Murray Cumming <murrayc@murrayc.com>
352 Many files: Use final for the parameters and use the @override attribute.
354 2012-01-22 Ben Konrath <ben@bagu.org>
356 Add anchor links for single line text that starts with http, ftp and www.
360 2012-01-22 Ben Konrath <ben@bagu.org>
362 Add ellipsis to single line text in details view.
366 2012-01-04 Murray Cumming <murrayc@murrayc.com>
368 Remove all javadoc author tags.
370 Because they are awkward and meaningless when many people touch
372 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
374 2012-01-04 Murray Cumming <murrayc@murrayc.com>
376 Revert the COPYING.LESSER to COPYING rename.
378 Apparently both should be there if it is LGPL.
380 2012-01-03 Murray Cumming <murrayc@murrayc.com>
382 *View: Remove unused imports.
384 * src/main/java/org/glom/web/client/ui/DetailsView.java:
385 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
386 * src/main/java/org/glom/web/client/ui/ListView.java:
387 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
388 Remove unused imports, as suggested by Eclipse.
390 2012-01-02 Murray Cumming <murrayc@murrayc.com>
392 Move the *View::Presenter types, and some API into one base View.
394 * src/main/java/org/glom/web/client/ui/DetailsView.java:
395 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
396 * src/main/java/org/glom/web/client/ui/ListView.java:
397 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
398 Presenter, setPresenter() and clear() into a shared base interface,
399 to avoid the unnecessary duplicate Presenter types and to more clearly
400 show how the *Views share the same structure, even if they are not
401 used polymorphically.
403 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
404 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
406 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
407 * src/main/java/org/glom/web/client/activity/ListActivity.java:
408 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
410 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
413 Feel free to revert this if there is a good reason for the duplicate
416 2012-01-02 Murray Cumming <murrayc@murrayc.com>
418 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
420 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
421 a class member instead of a local variable in the method.
422 This lets us use it to get the view instances, for use in tests.
423 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
424 beforeOnlineGlom(): Test some more details of the initial view.
425 Again, this is not very useful.
427 To really test gwt-glom we will need to start a local postgresql
428 instance with local data, like the Glom tests in C++.
430 2012-01-02 Murray Cumming <murrayc@murrayc.com>
432 pom.xml: Mention the LGPL license.
434 * pom.xml: Add a licenses section.
435 * COPYING.LESSER: Move this to COPYING, which
436 previously contained the GPL. But gwt-glom is all LGPL.
438 2012-01-02 Murray Cumming <murrayc@murrayc.com>
440 Add project information to README and pom.xml.
442 * README: Add a brief description and mention some mvn
444 * pom.xml: This extra information shows up in mvn site
447 2011-01-02 Murray Cumming <murrayc@murrayc.com>
449 Use the latest java-libglom version.
451 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
453 2012-01-01 Murray Cumming <murrayc@murrayc.com>
455 GwtTestOnlineGlom: Test a little more.
457 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
458 protected rather than private, as suggested by the gwt-test-utils
460 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
461 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
462 Test the initial visibility of the panels.
464 However, this is not a very useful test.
465 And I wonder how we should generally test using this idea for an
466 activity/places app like ours where the real changes happen implicitly
467 based on the history token/URL.
469 2012-01-01 Murray Cumming <murrayc@murrayc.com>
471 Slight modification to *Mapper comments.
473 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
475 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
477 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
479 Remove comments mentioning GIN because they are just copied from
480 the example code and are apparently not helpful:
481 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
482 Also change the mention of a class that is only in the example code.
484 2012-01-01 Murray Cumming <murrayc@murrayc.com>
486 GwtTestOnlineGlom test: Minor changes.
488 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
489 Avoid the long qualified class name and modify the comment
490 because it is now obvious to me that the mocked class is the only
491 custom one created via GWT.create().
493 2012-01-01 Murray Cumming <murrayc@murrayc.com>
495 Tests: Added the beginnings of a test using gwt-test-utils.
497 * pom.xml: Add dependencies on gwt-test-utils and easymock.
498 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
499 which tells gwt-test-utils what class will be tested.
500 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
501 Add a simple (but empty) test case. One class, used by the OnlineGlom
502 class, is mocked so that it can be created. However, I am not sure
503 why only this class needs to be mocked.
505 Note that mockito seems more popular, and clearer, than easymock,
506 but I have not got that working yet. It might be a matter of the
509 This test is run during mvn integration-test.
511 2011-12-31 Murray Cumming <murrayc@murrayc.com>
513 Tests: Use junit4-style syntax instead of junit3-style.
515 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
516 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
517 * src/test/java/org/glom/web/shared/DataItemTest.java:
518 Use the @Test annotation rather than relying on the test*() prefix.
519 Also no longer implement TestCase, to avoid triggering support for
520 the junit3-way, which stops the annotations from working.
521 Change the imports from import junit.framework.* to
522 import org.junit.*, which is apparently the new way.
524 2011-12-31 Murray Cumming <murrayc@murrayc.com>
526 Added a test for ListPlace token parsing and creation.
528 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
529 This is much the same as DetailsPlaceTest.
531 I wonder how we could test the other parts of the *Place API.
533 2011-12-30 Murray Cumming <murrayc@murrayc.com>
535 DetailsPlace test: Also test getToken() and recreation via getPlace().
537 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
538 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
539 recreate it, testing the recreated DetailsPlace for the same parameter
542 2011-12-30 Murray Cumming <murrayc@murrayc.com>
544 Use the surefire-report plugin.
546 * pom.xml: This generates a HTML report about the tests in
547 target/site/surefire-report.html
548 when you do mvn surefire-report:report. It seems to be popular/normal.
550 2011-12-30 Murray Cumming <murrayc@murrayc.com>
552 Added a test for DetailsPlace.
554 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
555 Test the getPlace() token parsing.
557 2011-12-30 Murray Cumming <murrayc@murrayc.com>
559 Added a first unit test.
561 * pom.xml: Add a test goal, and a dependency on junit in that scope.
562 * src/test/java/org/glom/web/shared/DataItemTest.java:
563 This is a silly test but it is just to get things started. Note that
564 maven/junit finds the test because it looks in src/test by default.
566 2011-12-22 Ben Konrath <ben@bagu.org>
568 Change charsetName to "UTF-8" when replacing line breaks.
570 JavaScript requires the charsetName to be "UTF-8". CharsetName values
571 that work in Java (such as "UTF8") will not work when compiled to
574 This fixes a problem with multi-line details view fields that have hard
575 line breaks. The "License Text" field on this page demonstrates the
578 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
580 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
582 2011-12-22 Ben Konrath <ben@bagu.org>
584 Fix another bug with related list navigation.
586 I've tested all the navigation buttons in all of the related lists
587 so things should be good now.
589 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
591 2011-12-22 Ben Konrath <ben@bagu.org>
593 Fix a crasher when refreshing the list view with the default table.
595 This crash will also happen when loading the list view with the default
596 table from a link or bookmark.
598 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
599 to the main document selection page when the document id hasn't been
601 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
602 the main document selection page when the document id hasn't been
604 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
605 values for the details place when the document id hasn't been set.
606 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
607 values for the list place when the document id hasn't been set.
609 2011-12-21 Ben Konrath <ben@bagu.org>
611 Protect against NPE when glom.document.locale is not in config.
613 This patch protects against an NPE when glom.document.locale is not in
614 the config file. This NPE will also happen if glom.document.locale is
617 The patch also updates the error message to display the class name when
618 the getMessage() returns null. This was happening when the NPE was
619 thrown and I had "Configuration Error: null". If an NPE is encountered
620 with this patch, "Configuration Error: NullPointerException " will be
623 This commit closes this bug:
625 https://bugzilla.gnome.org/show_bug.cgi?id=666669
627 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
629 2011-12-20 Murray Cumming <murrayc@murrayc.com>
631 Rename onlineglom.properties to onlineglom.properties.sample.
633 * src/main/resources/onlineglom.properties: Rename to:
634 * src/main/resources/onlineglom.properties.sample:
635 * src/main/resources/README: And add this file explaining that people
636 should rename it back when deploying.
638 2011-12-20 Murray Cumming <murrayc@murrayc.com>
640 Allow choosing the translation in the .properties file.
642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
643 init(): Read a glom.document.locale value from the configuration file
644 and call Glom's TransatableItem::set_current_locale() method.
645 * src/main/resources/onlineglom.properties: Add a commented-out
646 example of this new setting.
648 It would be better to add &lang=de_DE to the URL, but the current
649 libglom API does not allow us to do this easily. I am working on that.
651 2011-12-19 Murray Cumming <murrayc@murrayc.com>
653 Avoid a crash in parsing of token parameters.
655 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
656 ava: getTokenParams(): Do not crash if a parameter has a key but no
657 value, and ignore parameters with neither.
659 2011-12-17 Murray Cumming <murrayc@murayc.com>
661 History token building/handling: Improve use of token parameters.
663 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
664 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
665 and buildParamsToken(HashMap), for use by derived classes.
666 Make the separator private because it is no longer be needed.
667 * src/main/java/org/glom/web/client/place/DetailsPlace.java
668 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
669 instead of manual string concatenation.
670 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
671 of hardcoded indices and awkward splitting code.
672 * src/main/java/org/glom/web/client/place/ListPlace.java
673 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
674 instead of manual string concatenation.
675 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
676 of hardcoded indices and awkward splitting code.
677 This should fix bug #666420
679 2011-12-16 Murray Cumming <murrayc@murrayc.com>
681 Fix a Navgiation->Navigation typo in the code.
683 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
684 Rename processNavgiation() to processNavigation().
686 2011-12-16 Murray Cumming <murrayc@murrayc.com>
688 Fix a seperator->separator typo in the code.
690 * src/main/java/org/glom/web/client/place/DetailsPlace.java
691 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
692 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
695 2011-12-15 Ben Konrath <ben@bagu.org>
697 Cleanup some comments.
699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
701 2011-12-14 Ben Konrath <ben@bagu.org>
703 Replace \n with <br/> for multiline text in the details view.
705 Vertical scrollbars are added when needed as well.
707 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
709 2011-12-14 Ben Konrath <ben@bagu.org>
711 Specify the font for document selection links.
713 * src/main/webapp/style.css:
715 2011-12-14 Ben Konrath <ben@bagu.org>
717 Fix bouncy CellTable while paging.
719 This doesn't currently work with related list tables in unselected
722 * src/main/java/org/glom/web/client/ui/list/ListTable.java
724 2011-12-14 Ben Konrath <ben@bagu.org>
726 Revamp the appearance of the document selection page.
728 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
729 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
730 * src/main/webapp/style.css:
732 2011-12-13 Ben Konrath <ben@bagu.org>
734 Set navigation button column to the smallest size possible.
736 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
738 2011-12-13 Ben Konrath <ben@bagu.org>
740 Change OpenButton nomenclature to NavigationButton.
742 Using NavigtionButton makes things more generic. Classes, methods and
743 variables have been changed.
745 This is a rename-only refactor.
747 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
748 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
749 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
750 Renamed from OpenButtonCell.
751 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
752 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
753 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
755 2011-12-12 Ben Konrath <ben@bagu.org>
757 Remove unnecessary String argument in RelatedListTable and ListViewTable.
759 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
760 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
761 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
762 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
764 2011-12-12 Ben Konrath <ben@bagu.org>
766 Update variable names and comments.
768 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
769 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
771 2011-12-12 Ben Konrath <ben@bagu.org>
773 Properly initialize numNonEmptyRows variable to zero.
775 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
776 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
778 2011-12-05 Ben Konrath <ben@bagu.org>
780 Add latest mockup with HTML tables.
782 Features of this mockup:
784 -> HTML table for flowtable
785 -> HTML table for flowtable column
786 -> Example of how related lists would look
787 -> Not using text entries for data items
789 The current version of Online Glom doesn't use HTML tables for the
792 This mockup has been sent to the glom-devel mailing list but it's good
793 to have it here as well.
795 * mockups/details-view-html-tables.html:
797 2011-12-05 Ben Konrath <ben@bagu.org>
799 Remove unnecessary getPrimaryKeyField() method.
801 getPrimaryKeyFieldForTable(String) has been renamed to
802 getPrimaryKeyField(String).
804 * src/main/java/org/glom/web/server/database/DBAccess.java:
805 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
806 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
808 2011-12-05 Ben Konrath <ben@bagu.org>
810 Add string representation of TypedDataItem value to conversion error message.
812 * src/main/java/org/glom/web/server/Utils.java: Logging the error
813 message was extracted into its own method to avoid duplication.
815 2011-12-05 Ben Konrath <ben@bagu.org>
817 Add type checking to navigation primary key value creation.
819 Create navigation primary key only if the expected type from the Glom
820 document matches the type returned by the SQL query.
822 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
824 2011-12-05 Ben Konrath <ben@bagu.org>
826 Rename a couple of variables in RelatedListNavigation.
828 This is a rename-only refactor.
830 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
832 2011-12-05 Ben Konrath <ben@bagu.org>
834 Move getListLayoutGroup() into getListViewLayoutGroup().
836 This removes getListLayoutGroup(). It was only being called by
837 getListViewLayoutGroup().
839 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
841 2011-12-05 Ben Konrath <ben@bagu.org>
843 Remove check for LayoutItem_Portal in list table method.
845 This check is no longer necessary because the method isn't being used
846 to create the LayoutItemPortal DTO.
848 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
850 2011-12-05 Ben Konrath <ben@bagu.org>
852 Properly support related list navigation.
854 Navigation from the "Repository Analyzer -> Package Scans ->
855 Dependencies" related table wasn't working because the primary key for
856 related tables wasn't being set properly. This commit fixes the
859 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
860 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
861 doesn't set the primary key properly for related list tables.
862 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
863 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
864 useful for getting the primary key for list view tables and for related
866 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
867 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
868 Move code to set the primary key for the table from the abstract
869 ListDBAccess class to ListViewDBAccess as it's only correct for list
871 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
872 Properly add primary key to related list tables.
874 2011-12-02 Ben Konrath <ben@bagu.org>
876 Properly set the horizontal alignment of fields.
878 This fix is for both the list tables and the details view.
880 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
881 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
882 to set the horizontal alignment of fields.
884 2011-12-02 Ben Konrath <ben@bagu.org>
886 Display currency codes in the details view.
888 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
890 2011-12-02 Ben Konrath <ben@bagu.org>
892 Avoid duplicate JNI call.
894 JNI is not as efficient as pure Java and this is an easy (and small)
897 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
898 Use previously retrieved value for whereClauseToTableName instead of
901 2011-12-02 Ben Konrath <ben@bagu.org>
903 Rename a couple of variables in RelatedListNavigation.
905 This is a rename-only refactor.
907 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
909 2011-12-02 Ben Konrath <ben@bagu.org>
911 Indicate clearly that a mismatched primary key type is a bug.
913 * src/main/java/org/glom/web/server/Utils.java: Change log level from
914 warning to error. Add 'This is a bug.' to message.
916 2011-12-02 Ben Konrath <ben@bagu.org>
918 Update / fix some comments.
920 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
922 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
924 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
925 Fix comments. Add some TODOs.
927 2011-12-02 Ben Konrath <ben@bagu.org>
929 Enable navigation to details view with string primary key from related list.
931 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
932 Create a text primary key value when return type of result is
933 java.sql.Types.VARCHAR.
935 2011-12-02 Ben Konrath <ben@bagu.org>
937 Use checkboxes for booleans in the details view.
939 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
941 2011-12-01 Ben Konrath <ben@bagu.org>
943 Improve performance of related list height calculation.
945 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
946 Put code to calculate the expected height in a static initializer so
947 that that it's only called once.
949 2011-12-01 Ben Konrath <ben@bagu.org>
951 Show related list tables in notebooks (again).
953 Calculate the height of the related list tables so the Notebook can be
954 set the correct height. The height of the related list table is also needed by
955 FlowTable to be able decide how to create the layout.
957 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
958 and set the Portal height based on the height of the related list
959 table and the Portal container.
960 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
961 Add method to calculate the height of the related list tables.
962 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
963 * src/main/webapp/style.css: Add css class for Pager. This is needed to
964 calculate the height of the Pager widget.
966 2011-12-01 Ben Konrath <ben@bagu.org>
968 Use CellTable API for table property instead of setting style on Element.
970 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
972 2011-12-01 Ben Konrath <ben@bagu.org>
974 Make ListViewTable and RelatedListTable a consistent height.
976 The tables are now a consistent height regardless of the contents of
977 the table. A hidden button is added to empty rows to ensure that the
978 height of these rows will match the height of rows with data.
980 A navigation button column is now added to every table. The width of
981 the navigation column is set to 0px when a RelatedListTable shouldn't
982 have navigation buttons. This maintains the a consistent row height in
983 tables that don't show the navigation buttons.
985 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
986 navigation column when not needed.
987 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
988 arguments for navigation button to constructor of ListViewTable.
989 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
990 hidden button for empty data rows.
991 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
992 arguments for navigation button to constructor.
993 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
994 create navigation buttons. Add hideNavigationButtons() method.
995 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
996 arguments for navigation button to constructor.
998 2011-12-01 Ben Konrath <ben@bagu.org>
1000 Use 'visibility: hidden' in Utils.getWidgetHeight().
1002 This is better choice because hidden elements are invisible, don't
1003 respond to events and are not part of the tab order. They will,
1004 however, take up space which is required to be able to calculate the
1005 height of the widget.
1007 * src/main/java/org/glom/web/client/Utils.java:
1009 2011-12-01 Ben Konrath <ben@bagu.org>
1011 Use Utils.getWidgetHeight() in FlowTable.
1013 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1015 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1017 2011-12-01 Ben Konrath <ben@bagu.org>
1019 Put the details css class name on the correct table column.
1021 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1023 2011-11-30 Ben Konrath <ben@bagu.org>
1025 Update for java-libglom API change.
1027 The getters and setters on FieldFormatting and NumericFormat were
1028 changed to remove the 'M'.
1030 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1032 2011-11-29 Ben Konrath <ben@bagu.org>
1034 Only allow RelatedListTables in Portals.
1036 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1038 2011-11-29 Ben Konrath <ben@bagu.org>
1040 Only create a contents panel for Portals when title is being set.
1042 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1044 2011-11-29 Ben Konrath <ben@bagu.org>
1046 Set TabLayoutPanel height based on calculated height its widgets.
1048 This is a potential fix for this bug:
1050 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1052 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1054 2011-11-29 Ben Konrath <ben@bagu.org>
1056 Align details field labels and data with the Open buttons.
1058 * src/main/webapp/style.css:
1060 2011-11-29 Ben Konrath <ben@bagu.org>
1062 Remove unnecessary <div> in the Notebook widget.
1064 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1065 method to get container FlowPanel (<div>).
1066 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1067 initWidget() method directly on the TabLayoutPanel widget instead of
1068 Group's container widget.
1070 2011-11-29 Ben Konrath <ben@bagu.org>
1072 Don't add group titles for Portals in Notebooks.
1074 This reverts the previous patch and fixes a bug I introduced with
1075 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1077 * src/main/java/org/glom/web/client/ui/details/Group.java:
1078 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1080 2011-11-28 Ben Konrath <ben@bagu.org>
1082 Remove unused boolean argument in Portal constructor.
1084 Just a code cleanup.
1086 * src/main/java/org/glom/web/client/ui/details/Group.java:
1087 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1089 2011-11-28 Ben Konrath <ben@bagu.org>
1091 Remove hack for glom 1.18 style glom files.
1093 * src/main/java/org/glom/web/client/ui/details/Group.java:
1094 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1095 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1097 2011-11-28 Ben Konrath <ben@bagu.org>
1099 Use Gda Value version of primary key to log result too large error.
1101 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1103 2011-11-28 Ben Konrath <ben@bagu.org>
1105 Don't use TypedDataItem.getText() for Unknown types from the URL.
1107 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1108 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1109 instead of getText().
1110 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1111 String field and getUnknown() method.
1113 2011-11-28 Ben Konrath <ben@bagu.org>
1115 Log an error message when the java-libglom .so is not present.
1117 The error message was being set in the exception but not logged.
1119 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1121 2011-11-28 Ben Konrath <ben@bagu.org>
1123 Ignore LayoutItem_CalendarPortals.
1125 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1126 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1128 2011-11-28 Ben Konrath <ben@bagu.org>
1130 Extract method for creating the LayoutItemPortal DTO.
1132 Just breaking the code up into smaller chunks.
1134 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1136 2011-11-28 Ben Konrath <ben@bagu.org>
1140 This should have been added with the refactor. Oops!
1142 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1144 2011-11-28 Ben Konrath <ben@bagu.org>
1146 Create primary key value from URL string using type from Glom document.
1148 See this bug, comments 19 - 25:
1150 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1152 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1153 create a TypeDataItem for the primary key here when loading from a
1154 URL. Show the same string for the primary key value as was received
1155 from the URL string (when loading from a URL).
1156 * src/main/java/org/glom/web/server/Utils.java: Update method for
1157 creating the Gda Value from the TypeDataItem to properly deal with
1158 creating a Gda Value based on the Glom document type for the primary
1159 key value string when loading from a URL.
1160 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1161 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1162 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1163 Update for changed method name.
1165 2011-11-27 Ben Konrath <ben@bagu.org>
1167 Rename PrimaryKeyItem to TypedDataItem.
1169 The name PrimaryKeyItem suggests what the class should be used for.
1170 TypedDataItem is a neutral name that describes the class better.
1172 This is a rename-only refactor.
1174 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1175 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1176 * src/main/java/org/glom/web/client/Utils.java:
1177 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1178 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1179 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1180 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1181 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1182 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1183 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1184 * src/main/java/org/glom/web/server/Utils.java:
1185 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1186 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1187 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1188 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1190 2011-11-25 Ben Konrath <ben@bagu.org>
1192 Improve Gda Value conversion from PrimaryKeyItem.
1194 The value from the PrimaryKeyItem is only used if its type match the
1195 type from the glom document.
1197 * src/main/java/org/glom/web/server/Utils.java:
1199 2011-11-25 Ben Konrath <ben@bagu.org>
1201 Manually check if the java-liblgom .so is visible to the JVM.
1203 It seems that Tomcat has problems when a static initializer throws an
1204 exception. This check is done before the first method call into
1205 java-libglom so that execution doesn't continue if the .so is not
1208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1210 2011-11-25 Ben Konrath <ben@bagu.org>
1212 Improve browser configuration error messages.
1216 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1218 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1219 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1220 getConfigurationErrorMessage() method.
1221 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1222 Get and display a specific configuration error message when no Glom
1223 documents are found.
1224 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1225 Implement getConfigurationErrorMessage() method. Surround configuration
1226 code in the init() method with a try/catch block. This allows the
1227 errors to be caught while keeping the servlet available to retrieve the
1228 configuration error message.
1230 2011-11-25 Ben Konrath <ben@bagu.org>
1232 Don't use Strings to hold primary key values.
1234 The primary key values are now held in a new data object
1235 (PrimaryKeyItem) that holds type information and the primary key value
1236 using the correct type.
1238 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1239 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1241 PrimaryKeyItem instead of String to hold the primary key value.
1242 * src/main/java/org/glom/web/client/Utils.java: Remove
1243 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1244 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1245 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1246 PrimaryKeyItem instead of String to hold the primary key value. Load
1247 document selection page when the documentID has not been set correctly.
1248 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1249 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1251 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1252 Return empty string for URL instead of "null".
1253 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1254 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1255 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1256 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1257 PrimaryKeyItem instead of String to hold primary key values.
1258 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1259 PrimaryKeyValue to a Gda Value.
1260 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1261 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1262 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1263 Replace temporary database access code that uses the PrimaryKeyValue to
1264 Gda Value conversion.
1265 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1266 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1267 PrimaryKeyItem instead of String.
1268 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1269 hold primary key values.
1271 2011-11-24 Ben Konrath <ben@bagu.org>
1273 Use newly added java-libglom API to create queries.
1275 This isn't finished. I still need to stop using Strings for primary key
1276 values in the client code.
1278 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1279 libglom to use fake connections so that retrieving the query string will
1281 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1282 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1283 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1284 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1285 Use the newly added libglom sql methods and classes to create the
1286 query. Add temporary hack to convert primary value strings to Gda
1289 2011-11-23 Ben Konrath <ben@bagu.org>
1291 Don't explicitly set the height of Portals.
1293 See comments 6 - 10 of this bug for details:
1295 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1297 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1299 2011-11-23 Ben Konrath <ben@bagu.org>
1301 Use an HTML table instead of CSS for the FlowTable layout.
1303 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1304 GWT's FlexTable to implement the FlowTable.
1305 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1307 2011-11-18 Ben Konrath <ben@bagu.org>
1309 Add boolean example to HTML table mockup.
1311 * mockups/details-view-html-tables-text-entries.html:
1313 2011-11-17 Ben Konrath <ben@bagu.org>
1315 Ensure the pager buttons are always visible for related lists.
1317 To accomplish this, I've turned off text wrapping in the list view and
1318 related list tables for both the header and data text. The related list
1319 table now has a fixed layout so the it doesn't overflow its container.
1320 This is required to ensure that the cell text is clipped when it
1321 overflows the cell and an ellipsis is added to the right side of the
1322 cell when text is clipped.
1324 A fixed table layout for the related list table in the details view
1325 seems what we want for the details view anyway, so the side-effect is
1328 The ellipsis will only be displayed in Firefox >= 7.
1332 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1334 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1335 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1336 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1338 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1339 Set the 'table-layout: fixed' CSS property to the related list table.
1340 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1341 'white-space: nowrap;' CSS property on both the list view and the
1342 related list tables.
1344 2011-11-16 Ben Konrath <ben@bagu.org>
1346 Rework the fix for empty notebook tab labels.
1348 Setting the empty group titles with its name caused problems for the
1349 details layout. Instead of using libglom's
1350 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1351 to the client when the title is empty. This allows the Notebook to use
1352 the name when the title is empty without affecting anything else.
1354 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1355 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1357 2011-11-16 Ben Konrath <ben@bagu.org>
1359 Set group titles with name when title is empty.
1361 This fixes a problem with an empty notebook tab label in the Lesson
1362 Planner document. The forth tab in the notebook should be "Internet":
1364 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1366 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1367 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1370 2011-11-16 Ben Konrath <ben@bagu.org>
1372 Remove whitespace from the configured username properties.
1374 This assumes that usernames won't have whitespace at the beginning
1375 or end. But I think this is a reasonable assumption.
1377 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1378 String.trim() to remove the whitespace from the username properties.
1380 2011-11-15 Ben Konrath <ben@bagu.org>
1382 Add details view mockup with HTML tables and text entries.
1384 This is from the attachment on this bug:
1386 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1388 * mockups/details-view-html-tables-text-entries.html:
1390 2011-11-15 Ben Konrath <ben@bagu.org>
1392 Add space between the columns of the flow table.
1396 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1398 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1399 space between columns in the flow table.
1401 2011-11-15 Ben Konrath <ben@bagu.org>
1403 Add backup files to the .gitignore.
1405 * .gitignore: Ignore files that end with ~.
1407 2011-11-09 Ben Konrath <ben@bagu.org>
1409 Use latest release of gwt-log.
1411 Gwt-log releases are now being submitted to the maven central
1412 repository so manual installation of the jar is no longer required.
1414 * pom.xml: Update version and groupId of gwt-log dependency.
1416 2011-10-31 Ben Konrath <ben@bagu.org>
1418 Don't use GWT numeric formatting to override the glom currency formatting.
1420 Currencies are now displayed like they are in Glom. See this bug:
1422 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1424 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1426 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1427 currency code to constructor and set it when the cell is rendered.
1428 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1429 currency code to the constructor of the NumericCell.
1431 2011-10-27 Ben Konrath <ben@bagu.org>
1433 Require the latest release of java-libglom (1.17.4).
1437 2011-10-26 Ben Konrath <ben@bagu.org>
1439 Add style to Notebook that matches current theme.
1441 It's not the best style in the world but it's better than the default.
1443 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1444 padding at the bottom of the child widgets.
1445 * src/main/webapp/style.css: Add style for the Notebook.
1447 2011-10-26 Ben Konrath <ben@bagu.org>
1449 Move servlet initialization code to overridden init method.
1451 This is half of the solution to getting proper error messages
1452 displayed when configuration errors occur. Here's the relevant bug:
1454 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1456 The rest of the solution involves surrounding the init method with a
1457 try/catch block and setting a global variable with the error /
1458 exception. A new async method should be created to retrieve and display
1459 the error message / exception.
1461 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1462 code from constructor to init method adding exceptions as needed.
1464 2011-10-26 Ben Konrath <ben@bagu.org>
1466 Add script to monitor and restart tomcat if required.
1468 * utils/check-and-recover-tomcat.py: New file.
1470 2011-10-26 Ben Konrath <ben@bagu.org>
1472 Display the correct number of data items in the pager.
1476 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1478 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1479 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1480 The implementation is the same for both tables: Keep track of the
1481 number of non-empty rows and fire and RowCountChangeEvent after the data has
1483 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1484 custom Pager class that subclasses SimplePager to handle displaying
1485 the correct number when empty rows have been added.
1487 2011-10-26 Ben Konrath <ben@bagu.org>
1489 Correct error in previous commit.
1491 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1492 eventBus parameter from listView.setCellTable().
1494 2011-10-26 Ben Konrath <ben@bagu.org>
1496 Fix error in TODO comment.
1498 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1500 2011-10-24 Ben Konrath <ben@bagu.org>
1502 Create Notebook widgets to the details view.
1504 This isn't finished just yet - I still need to create a reasonable
1505 style to match the current theme.
1507 * src/main/java/org/glom/web/client/Utils.java: Add method for
1508 calculating the height of a widget. This is used in the Notebook class.
1509 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1510 new constructor method in Group.
1511 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1512 method for creating child widget that can be used by subclasses
1513 like Notebook. New constructor that allows disabling the group
1514 titles - Notebooks don't set a group title for their child groups.
1515 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1516 to make Notebooks using GWT's TabLayoutPanel.
1517 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1518 constructor that allows disabling the group titles.
1519 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1520 LayoutItemNotebook DTO.
1521 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1522 DTO for Notebooks. It's just an empty class for now but we might need
1523 it to transfer some specific information in the future.
1525 2011-10-21 Ben Konrath <ben@bagu.org>
1527 Add navigation buttons to related list tables.
1529 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1530 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1531 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1532 method getSuitableRecordToViewDetails() for getting the table name
1533 and primary key value for related list navigation buttons.
1534 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1535 private cell renderer class to get the navigation information for
1536 related list tables from the server. Extract the navigation
1537 processing code from the details cell navigation and use it for the
1538 related list navigation as well.
1539 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1540 cell renderer class for the details open buttons. This was needed
1541 because the related list navigation buttons and the list view
1542 navigation buttons need to react differently when clicked.
1543 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1544 the onEnterKeyDown() method because it's now overriden in the
1545 subclasses that are specific to the related list tables and the list
1547 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1548 the vertical size a little because the buttons add a bit of vertical
1549 space to table. This is not a perfect solution because the vertical
1550 size of with table fewer than 5 rows will be a little smaller.
1551 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1552 changes in how navigation buttons are handled.
1553 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1554 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1555 database access object.
1556 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1557 to find the portal for a given relationship name from
1558 RelatedListDBAccess. Add method to find a primary key field for a
1560 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1561 Move code to find the portal for a given relationship name to
1563 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1564 New file: database access object for getting the related list
1565 navigation information (the table name and the primary key value).
1566 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1567 DTO for transferring a table name to navigate to and a primary key
1569 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1570 boolean and getter/setter to specifies if the related list should add
1573 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1575 Use the master branch of java-libglom
1577 * pom.xml: Depend on java-libglom 1.19 instead.
1579 This is the master branch. See also the libglom-1-18 branch.
1581 2011-10-11 Ben Konrath <ben@bagu.org>
1583 Enable the open navigation button when the data has been set.
1585 This avoids having active buttons that don't do anything when the data
1588 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1590 2011-10-11 Ben Konrath <ben@bagu.org>
1592 Use IsWidget interface for FlowTableItem.
1594 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1595 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1597 2011-10-11 Ben Konrath <ben@bagu.org>
1599 Remove GWT styling from open button in details view.
1601 There are still some issues with how the details cell is arranged but
1602 this should be made to match Glom 1.20. I'm going to leave fixing this
1603 until I have Glom 1.20 up and running.
1605 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1606 style name on open button.
1607 * src/main/webapp/style.css: Move and edit details-navigation class.
1608 Re-arrange some classes to make them appear in the same order as the
1611 2011-10-07 Ben Konrath <ben@bagu.org>
1613 Update to GWT 2.4.0.
1615 * .gitignore: Ignore new cache directory.
1616 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1617 * pom.xml: Change GWT and maven plugin to 2.4.0.
1618 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1620 * src/main/java/org/glom/web/client/ClientFactory.java:
1621 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1622 * src/main/java/org/glom/web/client/OnlineGlom.java:
1623 Update source for API changes.
1624 * utils/build-onlineglom-war.sh: Remove cache directory before the
1627 2011-10-07 Ben Konrath <ben@bagu.org>
1629 Add navigation buttons in the details view.
1631 This isn't finished but I thought I'd commit what I have as it's a
1632 pretty good start. I still need to:
1634 1. Change the style so that it fits better into the current theme
1635 2. Adjust the details cell to expand as much as possible.
1637 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1638 click handlers to navigation buttons in the DetailsCells. Create a
1639 refreshData() method to get just the data from the server without the
1641 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1642 Update the tableSelector and browser title when the table name
1643 changes without using the tableSelector.
1644 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1645 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1646 getDetailsCells() to getCells(). Update variable names.
1647 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1648 method to set click handler on navigation button. Rename a few
1649 variables. Add navigation buttons where needed.
1650 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1651 variables and methods.
1652 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1653 navigation boolean and navigation table as required in the
1654 LayoutItemField DTO.
1655 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1656 variables for navigation along with getter/setter methods.
1658 2011-10-07 Ben Konrath <ben@bagu.org>
1660 Rename Field to DetailsCell.
1662 This is a refactor-only commit. No functionality has been added or
1665 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1666 Update variable and method names.
1667 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1668 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1669 variable and method names.
1670 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1672 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1673 variable and method names.
1675 2011-10-07 Ben Konrath <ben@bagu.org>
1677 Create separate methods for layout and data the details view.
1679 This is a refactor-only commit. No functionality has been added or
1682 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1683 private methods: setData(), createLayout().
1685 2011-10-07 Ben Konrath <ben@bagu.org>
1687 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1689 This is part of a change to get navigation buttons in the details view
1690 but it should have been done this way from the start.
1692 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1693 for method name change in TableSelectionView.
1694 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1695 Create TableChangeEvent and set the browser title using the
1696 TableSelectionView API.
1697 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1698 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1699 Change getSelectedTable() to getSelectedTableName(). Add
1700 getSelectedTableTitle().
1702 2011-10-07 Ben Konrath <ben@bagu.org>
1704 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1706 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1708 2011-10-07 Ben Konrath <ben@bagu.org>
1710 Update TableChangeEvent to use newTableName naming convention.
1712 This makes the class more consistent with GWT naming conventions.
1714 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1715 Update for method name change in TableChangeEvent.
1716 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1717 for method name change in TableChangeEvent.
1718 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1719 newTableName variable and getter method. Make toDebugString()
1722 2011-09-30 Ben Konrath <ben@bagu.org>
1724 Disable the pager in the list tables when the data row count is less than the minimum.
1726 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1727 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1729 2011-09-30 Ben Konrath <ben@bagu.org>
1731 Add empty rows to the end of related list and list view tables.
1733 I also extracted the cell rendering classes from the ListTable because
1734 the code was becoming a little crazy with all the anonymous inner
1735 classes. My plan is to use these cell rendering classes in the details
1736 view as well so this refactor will be needed for that change.
1738 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1739 set the row count in related list tables if the data has more rows
1740 than the minimum number of rows visible.
1741 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1742 row count in list view tables if the data has more rows than the
1743 minimum number of rows visible.
1744 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1745 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1747 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1748 for rendering TYPE_NUMERIC cells. The code was extracted from the
1750 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1751 class for rendering cells with buttons in list views. The code was
1752 extracted from the ListTable class.
1753 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1754 for rendering TYPE_TEXT cells. The code was extracted from the
1756 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1757 Add empty rows to the end of the data if required. Implement
1758 ListTable.getMinNumVisibleRows().
1759 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1760 cell renderer code to public classes. Return null in
1761 Column.getValue() for empty rows. Add new abstract method:
1762 getMinNumVisibleRows(). Move code to set the row count of the list view
1763 table to ListViewImpl.
1764 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1765 empty rows to the end of the data if required. Implement
1766 ListTable.getMinNumVisibleRows().
1769 2011-09-27 Ben Konrath <ben@bagu.org>
1771 Use GWT.log for client-side debugging statements.
1773 These are optimized out when deployed so I should have used this method
1774 in the first place. These statements will eventually be replaced with some sort
1775 of notification in the browser.
1777 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1778 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1779 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1780 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1781 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1783 2011-09-27 Ben Konrath <ben@bagu.org>
1785 Put tableselector on the right, back to list link on right.
1787 The idea is that the table selector is acting like a label for the
1788 currently displayed table so it should be placed below the document title. This
1789 puts the table title in a similar position to where it is in Glom.
1791 * mockups/details-contacts.html:
1792 * mockups/details-projects.html:
1793 * mockups/listview-contacts.html:
1794 * mockups/listview-projects.html:
1795 * mockups/style.css:
1796 Update mockups to match how the interfaces currently look.
1797 * src/main/webapp/style.css: Swap positions of backlink with the table
1798 selector. Add some space on the left side of the table selector to
1799 line things up with the document title.
1801 2011-09-27 Ben Konrath <ben@bagu.org>
1803 Add field colouring to details view.
1805 This change re-works how field colouring works. The colour formatting
1806 information is now set to the client with the layout information instead of
1807 with the data. This eliminates the need to send the same colour strings for
1808 data in list view column when colour information is set.
1810 In order to set an alternate colour for negative numeric values, the
1811 number is now sent to client and formatted with the GWT NumberFormat class.
1813 This change also fixes:
1815 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1817 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1818 internationalization framework which is needed for client side numeric
1820 * src/main/java/org/glom/web/client/Utils.java: New file for some
1821 client static utility methods.
1822 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1823 the DataItem object to the Field class. Use a utility method to
1824 create the foreignKeyValue string.
1825 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1826 alignment and text colours in the constructor. Add setData(DataItem)
1827 method. Remove setText(String) method.
1828 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1829 colour information to GlomTextCell. Create and use GlomNumberCell for
1830 rendering numbers. Use utility method to get the string for the
1831 primary key of the key provider. Re-work how the horizontal alignment
1833 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1834 formatting to layout information. Methods for converting the libglom
1835 formatting information were moved from DBAccess.
1836 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1837 numeric formatting (it's now done on the client side). Don't set text
1838 colours in DataItem. Move libglom formatting conversion methods to
1840 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1841 getters/setters for text colour information.
1842 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1843 for transferring the libglom NumericFormat information to the client.
1844 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1845 and getters/setters for: GlomNumericFormat, background colour and
1846 foreground colour strings.
1848 2011-09-26 Ben Konrath <ben@bagu.org>
1850 Simplify code that iterates through the LayoutGroup.
1852 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1854 2011-09-26 Ben Konrath <ben@bagu.org>
1856 Accept Eclipse formatting for OnlineGlomServiceAsync.
1858 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1860 2011-09-26 Ben Konrath <ben@bagu.org>
1862 Don't use the ListDBAccess classes to get the primary key layout information.
1864 This was causing a bug where the wrong index for the hidden primary key
1865 was being sent to the client.
1867 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1868 primary key while creating the LayoutGroup DTO. Create a
1869 LayoutItemField DTO for hidden primary keys. Don't use the
1870 RelatedListDBAccess because it was only used for getting the primary
1872 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1873 access modifier from public to protected for getPrimaryKeyField() and
1874 getPrimaryKeyLayoutItemField().
1875 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1876 abstract method getExpectedResultSize() because RelatedListDBAccess
1877 doesn't have enough info to implement it.
1878 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1879 Remove @Override for getExpectedResultSize().
1880 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1881 Remove method getExpectedResultSize().
1883 2011-09-23 Ben Konrath <ben@bagu.org>
1885 Log which layout (list or details) the ignored item is from.
1887 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1889 2011-09-23 Ben Konrath <ben@bagu.org>
1891 Remove annotations that turn off code formatting in DataItem.
1893 * src/main/java/org/glom/web/shared/DataItem.java:
1895 2011-09-23 Ben Konrath <ben@bagu.org>
1897 Rename GlomField to DataItem and update associated methods.
1899 This is a rename-only refactor. No functionality has been added or
1902 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1903 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1904 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1905 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1906 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1907 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1908 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1909 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1910 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1911 * src/main/java/org/glom/web/server/database/DBAccess.java:
1912 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1913 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1914 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1915 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1916 * src/main/java/org/glom/web/shared/DataItem.java:
1917 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1918 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1920 2011-09-23 Ben Konrath <ben@bagu.org>
1922 Rename GlomDocument to DocumentInfo and update associated methods.
1924 This is a rename-only refactor. No functionality has been added or
1927 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1928 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1929 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1930 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1931 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1932 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1933 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1935 2011-09-20 Ben Konrath <ben@bagu.org>
1937 Require java-libglom 1.17.3.
1939 This picks up the fix for the seg fault problem with the Scenes table
1940 in the Openismus Film Manager example.
1944 2011-09-20 Ben Konrath <ben@bagu.org>
1946 Change the way sort clause is added for primary key when no sort clause is requested.
1948 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1949 before the sort clause is created. When a sort clause is not requested, the
1950 sort clause is created by finding the primary key in the LayoutFieldVector
1953 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1955 2011-09-20 Ben Konrath <ben@bagu.org>
1957 Log error message if no documents are found in the configured directory.
1959 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1960 Extract the glom file extension string to a private static final class
1961 variable (mostly as syntactic sugar). Accept a minor formatting change.
1962 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1963 the example glom.document.directory configuration property to make it
1964 more clear that it can any directory, not just the home directory.
1966 2011-09-18 Ben Konrath <ben@bagu.org>
1968 Add related lists to details view.
1970 The related list table has support for paging and sorting just like the
1971 table in the list view.
1973 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1974 SQL queries for the related list tables.
1975 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1976 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1977 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1978 Rename getList methods to getListView and add comments. Remove
1979 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1980 it being unused. Add methods: getDetailsLayoutAndData(),
1981 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1982 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1983 Create the layout and set the data for the fields in one async call
1984 instead of two. Create related lists where appropriate.
1985 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1986 for method name changes in OnlineGlomService.
1987 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1988 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1989 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1991 * src/main/java/org/glom/web/client/ui/ListView.java:
1992 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1993 tableName from setCellTable(). Create a ListViewTable instead of
1995 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1996 represent a data field in the details view.
1997 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1998 from addDetailsCell() to Field class. Keep track of the Fields and
1999 Portals in the details view.
2000 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2001 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2002 and add a method to get it. Add method to set the contents of the
2004 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2005 New class for related list tables. This class has the data provider
2006 for the related list table.
2007 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2008 abstract class which is the base class for the ListViewTable and the
2010 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2011 New class for list view tables. This class has the data provider for
2012 the list view table.
2013 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2014 methods for related list tables. Add more information to the
2015 LayoutItemField and LayoutItemPortal DTOs.
2016 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2017 Remove debugging print statement.
2018 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2019 Remove debugging print statements. Add primary key field to SQL count
2021 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2022 Remove unnecessary LayoutFieldVector parameter from
2023 getResultSizeOfSQLQuery() method.
2024 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2025 New class for related list table database access.
2026 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2027 class that is a wrapper DTO for details view layout and data.
2028 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2029 new 'fromField' string to this DTO.
2030 * src/main/webapp/style.css: Remove bottom margin and override top
2033 2011-09-15 Ben Konrath <ben@bagu.org>
2035 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2037 This sets things up to make it easier to add the data retrieval for
2038 related lists (portals). No user noticeable changes were made with
2041 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2042 class has the code to retrieve the layouts and access the
2043 database using the new database helper classes.
2044 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2045 Most of the functionality has been removed from this class. This
2046 class now represents the public interface for the client side
2047 code. It also deals with configuring the servlet and cleaning
2048 things up when the servlet is stopped.
2049 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2050 of static methods into this utility class.
2051 * src/main/java/org/glom/web/server/database/DBAccess.java:
2052 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2053 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2054 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2055 These classes have the database retrieval code. The class hierarchy
2056 has been setup to make it easy to reuse code for similar
2059 2011-09-06 Ben Konrath <ben@bagu.org>
2061 Create separate classes for list table code and the data provider.
2063 As part of this refactor, I also split up the code a bit to make it
2066 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2067 table code to two new classes (below).
2068 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2069 with code from ListViewImpl.
2070 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2071 New file with code from ListViewImpl.
2073 2011-09-06 Ben Konrath <ben@bagu.org>
2075 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2077 This fixes the LayoutItemPortal DTO to match the libglom layout object
2080 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2082 2011-09-01 Ben Konrath <ben@bagu.org>
2084 Set title of Portals in the Details View.
2086 * pom.xml: Bump required version of java-libglom to 1.17.1.
2087 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2088 widget creation to its own class. Add comments to constructor.
2089 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2090 The code is mostly from the Group class with the title now set.
2091 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2092 title of Portal. Update some comments. Fix some code formatting.
2094 2011-09-01 Ben Konrath <ben@bagu.org>
2096 Remove TODO comment for the flow table column width.
2098 The flow table column width is working correctly and doesn't need to be
2099 changed. See this mailing list post for more info:
2101 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2103 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2105 2011-08-27 Ben Konrath <ben@bagu.org>
2107 Add document title (database name) to top of the browser page.
2109 I added the document title to the TableSelecitonView but that will
2110 change if / when we add a view that doesn't require table selection.
2112 * mockups/details-contacts.html:
2113 * mockups/details-projects.html:
2114 * mockups/listview-contacts.html:
2115 * mockups/listview-projects.html:
2116 * mockups/style.css: Add document title to mockups to keep things
2118 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2119 sizes to account for the document title.
2120 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2121 Set the document title when it has been retrieved from the server.
2122 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2123 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2124 and implement setDocumentTitle(String) method.
2125 * src/main/webapp/style.css: Add ID for document title style.
2127 2011-08-25 Ben Konrath <ben@bagu.org>
2129 Add NavigationType enum to LayoutItemPortal DTO.
2131 This is the start of adding support for Portals to the Details View.
2133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2134 LayoutItem_Portal.navigation_type enum from libglom to
2135 LayoutItemPortal.NavigationType enum.
2136 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2137 NavigationType enum, field for storing the NavigationType and getter
2140 2011-08-25 Ben Konrath <ben@bagu.org>
2142 Implement the flow table layout in the Details View.
2144 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2145 FlowTable to Group to account for the renamed class.
2146 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2147 File. This is a container widget that implements the Glom details view
2148 flow table behaviour.
2149 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2150 org/glom/web/client/ui/FlowTable.java.
2151 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2152 so that the size of the subgroups are a closer match to the size of
2153 the Glom subgroups. This makes the flowtable layout match the layout
2154 in Glom for the Music Collection example file.
2156 2011-08-16 Ben Konrath <ben@bagu.org>
2158 Create container element for LayoutItemPortal in Details View.
2160 This will help me develop the layout for the FlowTable.
2162 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2163 fieldPanel variable to detailsCell.
2165 2011-08-15 Ben Konrath <ben@bagu.org>
2167 Set the height of the data element in the Details View.
2169 I changed the InlineLabels (text in a span element) to Labels (text in
2170 a div element) so that I could set the height of the details-data
2171 elements instead of the details-cell parent elements. This allows the
2172 the details-data element to display the correct height if style is
2173 applied that shows the height.
2175 This change has the added benefit of allowing the order of the labels
2176 and data elements to be changed for right-to-left languages.
2178 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2179 InlineLabels to Labels.
2180 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2181 InlineLabels to Labels. Set the height of the data element.
2182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2183 multiline text height in the Formatting DTO.
2184 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2185 for multiline height along with getter and setter methods.
2186 * src/main/webapp/style.css: Adjust style to account for the change
2187 from span elements to div elements in the details cell.
2189 2011-08-15 Ben Konrath <ben@bagu.org>
2191 Make the List View appearance match the mockups.
2193 It doesn't match exactly but it's much better than it was.
2195 * mockups/listview-contacts.html: Remove unused css classes.
2196 * mockups/listview-projects.html: Remove unused css classes.
2197 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2198 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2199 for mainPanel instead of VerticalPanel (table). Set style name on
2200 CellTable. Set style name on Details column. Right-align Details
2202 * src/main/webapp/style.css: Adjust properties to match the mockups.
2204 2011-08-12 Ben Konrath <ben@bagu.org>
2206 Add better support for subgroups in the details view.
2208 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2209 changed FlowTable constructor.
2210 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2211 support for subgroups and subgroup-titles.
2212 * src/main/webapp/style.css: Add CSS class for subgroups and
2215 2011-08-12 Ben Konrath <ben@bagu.org>
2217 Return the top level LayoutGroup title.
2219 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2221 2011-08-11 Ben Konrath <ben@bagu.org>
2223 Make the TableSelector header match the mockup.
2225 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2226 the layout panel. Properly lineup the table selection header with
2227 the list and details view.
2228 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2229 margin around the details view.
2230 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2231 Rename listBox variable to tableSelector. Set id for the style sheet.
2232 Use a FlowPanel instead of a HorizontalPanel.
2233 * src/main/webapp/style.css: Add properties to make the TableSelector
2234 box match the mockups.
2236 2011-07-13 Ben Konrath <ben@bagu.org>
2238 Update install script for java-libglom version change.
2240 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2243 2011-07-13 Ben Konrath <ben@bagu.org>
2245 Add support sub-group in the details view.
2247 I also removed the code that special-cased the default details view
2250 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2252 I still have to make a proper flowtable.
2254 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2255 Don't special-case default details view layout.
2256 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2257 addLayoutField() as I'm going to use it.
2258 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2259 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2261 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2262 extracted from DetailsViewImpl.GroupPanel. Add support for
2264 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2265 column count when getting the details layout.
2267 2011-07-12 Ben Konrath <ben@bagu.org>
2269 Set browser title with database and table titles.
2271 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2272 Set the browser title when the table changes and when the activity
2274 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2275 title when retrieving document info (the GlomDocument object).
2276 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2277 with getter and setter methods. Remove unused convenience constructor.
2278 Use default code formatting.
2280 2011-07-12 Ben Konrath <ben@bagu.org>
2282 Ignore LayoutItemPortals in the details view.
2284 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2287 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2288 LayoutItemPortal layout objects.
2289 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2290 LayoutItemPortal objects when retrieving the details layout.
2291 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2292 file. This is an empty class and just used to get type information for
2295 2011-07-12 Ben Konrath <ben@bagu.org>
2297 Use java-libglom 1.17.0.
2301 2011-07-11 Ben Konrath <ben@bagu.org>
2303 Remove "Table:" label from table selector.
2305 This matches a recent change in the Glom UI.
2307 * mockups/details-contacts.html:
2308 * mockups/details-projects.html:
2309 * mockups/listview-contacts.html:
2310 * mockups/listview-projects.html: Remove the "Table:" label from the
2312 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2314 2011-07-11 Ben Konrath <ben@bagu.org>
2316 Add main groups to the details view.
2318 This makes things look a little nicer in the details view. The next step
2319 is to implement the flowtable.
2321 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2322 resources from the standard gwt css theme. Standard.css is now
2323 included in OnlineGlom.html so that the online glom css rules have
2324 precedence over the gwt theme.
2325 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2326 the whole LayoutGroup to the DetailsView instead of just the titles.
2327 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2328 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2329 details layout with a helper class (GroupPanel). I might extract this
2330 class when I make the full flowtable.
2331 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2332 string as default so I don't have to worry about NPEs when processing
2334 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2335 note beside OnlineGlom.gwt.xml above).
2336 * src/main/webapp/style.css: Add default font-size to body to override
2337 the font-size set by the standard theme. Don't use h2 tags for
2338 group-title. Create new details-cell class.
2340 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2342 ConfiguredDocument: Set the port number too.
2344 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2345 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2346 Glom document. Presumably this worked sometimes so far because there is a
2347 default port number.
2349 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2351 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2353 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2354 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2355 correct, though we should throw an exception too.
2357 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2359 Fix a addDocuemnt typo.
2361 * src/main/java/org/glom/web/shared/Documents.java
2362 (Documents.addDocuemnt): Rename to addDocument().
2363 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2364 (OnlineGlomServiceImpl.getDocuments): Adapt.
2366 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2368 Slightly improved log output when connection fails.
2370 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2371 (ConfiguredDocument.setUsernameAndPassword):
2372 We don't know for sure if it' the username/password that's wrong, so
2373 rephrase the message.
2374 Also ouput the exception message, though it's generic in this case.
2376 2011-07-08 Ben Konrath <ben@bagu.org>
2380 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2381 added braces to a one line if statement because the Eclipse formatter
2382 was getting confused.
2384 2011-07-07 Ben Konrath <ben@bagu.org>
2386 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2388 These should really be two separate tasks but I counldn't get things to
2389 work with GWT 2.2.0 and Eclipse 3.7.
2393 * .settings/org.eclipse.jdt.core.prefs:
2394 * .settings/org.eclipse.jdt.ui.prefs:
2395 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2396 * .settings/org.eclipse.m2e.core.prefs:
2397 Add new config files. Update current files. Remove references to the
2398 webtools plugins as we're not using any of the webtools features.
2399 * .gitignore: Add logs directory which is created when running with
2401 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2402 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2403 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2405 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2407 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2409 onlineglom.properties: Add explanatory comments.
2411 * src/main/resources/onlineglom.properties: Also change the default user
2412 from ben to someuser, to avoid the risk of people thinking we just
2413 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2415 2011-06-28 Ben Konrath <ben@bagu.org>
2417 Use filename in Log for incorrect passwords.
2419 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2420 getFileName(String) method to get the filename from the URI.
2422 2011-06-28 Ben Konrath <ben@bagu.org>
2424 Add the table name to the URL token for the ListPlace.
2426 This makes things consistent between the DetailsPlace and the
2427 ListPlace. It also allows the the ListPlace to be bookmarked.
2429 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2430 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2432 Remove getDefaultListLayout(). The default layout is now returned
2433 by the getListLayout() method when the table name is an empty string.
2434 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2435 Add table name field. Change to a new ListPlace when the table
2436 has been changed. Use getListLayout() for getting the default
2438 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2439 Add table name field. Set the correct table name in the list box
2440 when loading from bookmark. This corrects a problem for the
2442 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2443 Move table name to super-class (HasSelectableTable). Move document
2444 and table URL keys to super-class in HasSelectableTable.
2445 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2446 Add table name field. Add Tokenizer class with URL key common to
2447 the subclasses (DetailsPlace and ListPlace).
2448 * src/main/java/org/glom/web/client/place/ListPlace.java:
2449 Add table name. Add code to parse the URL token.
2450 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2451 Update ListPlace construction with empty table name string.
2452 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2453 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2454 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2455 Update ListPlace construction with table name string.
2456 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2457 Change defaultTableName field to tableName to reflect how it's now
2458 used. Update the getter and setter methods.
2460 2011-06-28 Ben Konrath <ben@bagu.org>
2462 Enable the table selector in the DetailsView.
2464 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2465 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2466 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2467 Remove getDefaultDetailsLayout(). The default layout is now returned
2468 by the getDetailsLayout() method when the table name is an empty
2470 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2471 event handler for table change event. Change to using
2472 getDetailsLayout() for the default details layout.
2473 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2475 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2476 when navigating to the details place.
2478 2011-06-27 Ben Konrath <ben@bagu.org>
2480 Use filename based unique document ID in URL and for RPC.
2482 The document ID is the glom document name with spaces (' ') replaced
2483 with pluses ('+') and without the .glom extension.
2485 This change is mostly a string substitution of 'documentTitle' for
2486 'documentID'. The only code change is the addition of a Documents DTO to get the
2487 filename to document title mappings as indicated below.
2489 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2490 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2491 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2492 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2493 Use Documents DTO to create the document links in the document
2495 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2496 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2497 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2498 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2499 * src/main/java/org/glom/web/client/place/ListPlace.java:
2500 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2501 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2502 * src/main/java/org/glom/web/client/ui/ListView.java:
2503 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2504 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2505 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2506 * src/main/java/org/glom/web/server/Log.java:
2507 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2508 getDocumentTitles() to getDocuments() and return the Documents DTO.
2509 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2510 transferring the filename to document title mappings.
2512 2011-06-25 Ben Konrath <ben@bagu.org>
2514 Make the authentication popup work again.
2516 This bug was introduced when I extracted ConfiguredDocument to its own class.
2518 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2519 correct success / fail status in setUsernameAndPassword().
2521 2011-06-25 Ben Konrath <ben@bagu.org>
2523 Use filename as unique key for configuring database usernames and passwords.
2525 This replaces the use of the Glom document title which could change
2526 depending on the locale. Thanks to Murray Cumming for pointing out this
2529 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2530 * src/main/resources/onlineglom.properties:
2532 2011-06-24 Ben Konrath <ben@bagu.org>
2534 Pass primary key value to DetailsView.
2536 This enables the DetailsView to load the correct data.
2538 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2539 primary key value field and set in constructor. Pass primary key
2540 value to getDetailsData().
2541 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2542 variables for document title and primary key value.
2543 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2544 key value to the DetailsPlace.
2546 2011-06-24 Ben Konrath <ben@bagu.org>
2548 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2550 This allows the primary key to be retrieved by the Details button. This
2551 functionality has not been implemented yet but it's in the works.
2553 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2554 the LayoutGroup result to ListView.setCellTable instead of all of its
2555 fields individually.
2556 * src/main/java/org/glom/web/client/ui/ListView.java:
2557 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2558 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2559 get the primary key for the table.
2560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2561 index of the primary key in the LayoutGroup accounting for hidden
2562 primary keys. Rename getJavaNumberFormat() to
2563 convertToJavaNumberFormat() for consistency. Cleanup / add some
2565 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2566 field for primary key index and a field to indicate whether the
2567 primary key is hidden or not.
2569 2011-06-23 Ben Konrath <ben@bagu.org>
2571 Rename getTableData methods to getListData.
2573 This is a rename refactor for consistency with other methods.
2575 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2576 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2577 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2578 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2580 2011-06-23 Ben Konrath <ben@bagu.org>
2582 Extract the ConfiguredDocument innerclass into its own class.
2584 This makes the servlet code more object oriented.
2586 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2587 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2588 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2589 new ConfiguredDocument class.
2591 2011-06-21 Ben Konrath <ben@bagu.org>
2593 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2595 This makes things more inline with how libglom works and reduces code
2596 duplication. This refactor lays the groundwork for adding the primary key to
2597 the LayoutGroup object.
2599 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2600 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2601 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2602 Change method names to getListLayout and getDefaultListLayout for
2603 consistency. Use LayoutGroup as the DTO for the list layout instead of
2604 ColumnInfo and LayoutListTable.
2605 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2606 new method names along with the LayoutGroup object for transferring the
2608 * src/main/java/org/glom/web/client/ui/ListView.java:
2609 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2610 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2611 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2613 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2614 Replaced with LayoutGroup.
2615 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2616 expectedResultSize and defaultTableName fields which are needed for
2618 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2619 type field which is needed for the list layout but will also be
2620 useful for the details layout as things progress.
2621 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2622 Make class abstract. Remove the unnecessary
2623 getFormattingHorizontalAlignment method. Add setFormatting method.
2625 2011-06-16 Ben Konrath <ben@bagu.org>
2627 Add scripts for building and installing war.
2629 These will help when updating OnlineGlom but they're also good
2630 supplemental documentation of the build and deployment proceeding.
2632 * utils/build-onlineglom-war.sh: New file.
2633 * utils/install-onlineglom-war.sh: New file.
2635 2011-06-16 Ben Konrath <ben@bagu.org>
2637 Create wrapper class to create consistent log messages.
2639 I wrapped methods in the Log class of gwt-log to add the method names
2640 from the servlet and create consistent formatting of the document title
2641 and table names in the log messages.
2643 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2644 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2645 log methods to use methods from wrapped Log class.
2647 2011-06-16 Ben Konrath <ben@bagu.org>
2649 Remove superfluous conditional return.
2651 Thanks to Murray Cumming for pointing this out!
2653 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2655 2011-06-15 Ben Konrath <ben@bagu.org>
2657 Return an ArrayList of LayoutGroups for the Details layout.
2659 This corrects a problem with the details layout as it can have more
2660 than one top level LayoutGroup.
2662 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2663 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2664 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2665 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2666 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2667 with ArrayList of LayoutGroups for the details view layout.
2668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2669 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2670 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2671 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2672 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2673 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2675 2011-06-14 Ben Konrath <ben@bagu.org>
2677 Use cast_dynamic method to determine the libglom LayoutItem type.
2679 This is better than finding the LayoutItem type by using the string
2680 returned from the get_part_type_name() method.
2682 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2684 2011-06-14 Ben Konrath <ben@bagu.org>
2686 Add method names to log entries in the servlet.
2688 This helps when tracking down deployment problems.
2690 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2692 2011-06-14 Ben Konrath <ben@bagu.org>
2694 Add data to the DetailsView using a hard-coded primary key value.
2696 The layout and functionality of the DetailsView is not complete. This
2697 is just a checkpoint so the patch doesn't get too big.
2699 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2700 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2701 Add getDetailsData() servlet method.
2702 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2703 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2704 LayoutFields are added to the DetailsView.
2705 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2706 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2707 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2708 take the string for the title instead of the object.
2709 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2710 Add implementation getDetailsData() along with some private helper
2712 * src/main/webapp/style.css: Add padding to details-data class. Add a
2713 details-label class with the same padding as the details-data class.
2715 2011-06-03 Ben Konrath <ben@bagu.org>
2717 Use presenter.goTo() to change to the DetailsPlace.
2719 This will make things easier when we need to open the DetailsView with
2720 data specific to the row that was clicked.
2722 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2724 2011-06-02 Ben Konrath <ben@bagu.org>
2726 Add CSS file from mockups.
2728 I'm adding this now because it's going to be useful to have when
2729 developing the DetailsView. The TableSelectionView and ListView aren't
2732 * src/main/webapp/OnlineGlom.html:
2733 * src/main/webapp/style.css:
2735 2011-06-02 Ben Konrath <ben@bagu.org>
2737 Use String.isEmpty() to check for empty string.
2739 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2741 2011-06-02 Ben Konrath <ben@bagu.org>
2743 Display main layout group titles in the DetailsView.
2745 This is the start of the DetailsActivity/DetailsView implementation.
2747 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2748 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2749 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2750 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2751 Get the layout information for the details view from the server and set
2752 the main layout group titles.
2753 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2754 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2755 Add addLayoutGroup() and addLayoutField() methods. This are just
2756 temporary methods for creating the the details view that will change
2758 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2759 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2761 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2762 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2763 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2764 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2765 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2766 Data Transfer Objects that mimic the libglom object structure. These are
2767 used for transferring the details layout but could also be used for
2768 transferring the list layout.
2770 2011-05-27 Ben Konrath <ben@bagu.org>
2772 Reset the AuthenticationPopup when clearing the ListView.
2774 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2776 2011-05-27 Ben Konrath <ben@bagu.org>
2778 Fix problem with onlineglom.properties file loading.
2780 The old way worked in Eclipse but not on the server. Loading the
2781 onlineglom.properties file now works in Eclipse and on the server.
2783 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2785 2011-05-24 Ben Konrath <ben@bagu.org>
2787 Update gwt-log from 3.1.0 to 3.1.2.
2789 Gwt-log 3.1.0 has been marked as depreciated.
2793 2011-05-24 Ben Konrath <ben@bagu.org>
2795 Add comment to ListActivity.goTo() method.
2797 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2799 2011-05-24 Ben Konrath <ben@bagu.org>
2801 Remove FIXME in convertGdkColorToHtmlColour()
2803 The Gdk::Color value returned by libglom is 16-bits per channel on both
2804 64 and 32-bit platforms.
2806 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2808 2011-05-19 Ben Konrath <ben@bagu.org>
2810 Improve performance of initial ListView load.
2812 I removed a round trip to the server for getting the default table name
2813 and then requesting information about that table. This also removes a potential
2814 problem with the table change handler not being setup in time to receive the
2815 table change event from the ListActivity.
2817 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2818 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2819 getDefaultLayoutListTable() method. Improve comments.
2820 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2821 getDefaultLayoutListTable() method instead of firing a table change
2822 event to get the table to load.
2823 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2824 implementation of getDefaultLayoutListTable() method.
2825 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2828 2011-05-19 Ben Konrath <ben@bagu.org>
2830 Override toDebugString() in TableChangeEvent.
2832 This is useful to have for debugging.
2834 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2836 2011-05-19 Ben Konrath <ben@bagu.org>
2838 Add a "Back to List" link when at the DetailsPlace.
2840 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2841 Populate the CellTable based on the selected table of the ListBox if
2842 it's set otherwise use the default table. This allows the "Back to
2844 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2845 Remove Place from constructors. Add a setPlace() method. Add
2846 goToPlace() method. Set class as presenter for TableSelectionView.
2847 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2848 Use the same TableSelectionActivity when switching between the List and
2850 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2851 Subclass the new HasSelectableTablePlace. This removes some duplicate
2853 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2854 New class to represent Places that display the TableSelectionView.
2855 * src/main/java/org/glom/web/client/place/ListPlace.java:
2856 Subclass the new HasSelectableTablePlace. This removes some duplicate
2858 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2859 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2860 Add Presenter interface. Add setBackLinkVisible() method. Add
2861 setBackLink() method.
2863 2011-05-18 Ben Konrath <ben@bagu.org>
2865 Enable the "Details" buttons.
2867 Right now only an empty details view is displayed.
2869 * src/main/java/org/glom/web/client/ClientFactory.java:
2870 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2871 Add DetailsView to ClientFactory.
2872 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2873 A basic activity for the details view.
2874 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2875 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2877 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2878 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2880 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2881 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2882 unnecessary super() in constructor.
2883 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2884 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2885 really shouldn't create a new TableSelectionActivity for both the ListPlace
2886 and the DetailsPlace so this should be considered a temporary solution.
2887 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2888 New file. Represents a URL for the details view.
2889 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2890 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2891 A basic details view interface and implementation.
2892 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2893 Enable the "Details" buttons.
2895 2011-05-12 Ben Konrath <ben@bagu.org>
2897 Use a LayoutPanel with multiple display areas for main layout.
2899 This is mostly a refactor in that there are no changes from the user
2900 point of view. These changes are required so that we can swap out the list view
2901 with the details view when the user clicks the "Details" button.
2903 * src/main/java/org/glom/web/client/ClientFactory.java:
2904 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2905 OnlineGlomView. Add TableSelectionView, ListView and
2906 AuthenticationPopup.
2907 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2908 for main layout. Add display regions for main activities. Add
2909 activity manager for for main activities.
2910 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2911 file from parts of the deleted OnlineGlomActivity.
2912 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2913 New file from parts of the deleted OnlineGlomActivity.
2914 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2915 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2916 New files for app wide table change event.
2917 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2918 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2919 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2920 Activity mappers for the main activities replace the deleted app-wide
2922 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2923 Fix a spelling error in he comment.
2924 * src/main/java/org/glom/web/client/ui/ListView.java:
2925 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2926 Renamed from LayoutListView and modified for MVP. This still not a
2927 proper dumb view as prescribed by the MVP pattern but it works for now.
2928 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2929 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2930 New widget stripped out of the deleted OnlineGlomView.
2931 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2932 Remove hack that is fixed by this patch.
2934 2011-05-06 Ben Konrath <ben@bagu.org>
2936 Rename OnlineGlomPlace to ListPlace.
2938 The only change besides the rename is that url will now display #list
2939 instead of #Document.
2941 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2942 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2943 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2944 * src/main/java/org/glom/web/client/place/ListPlace.java:
2945 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2947 2011-05-06 Ben Konrath <ben@bagu.org>
2949 Use Presenter for app navigation.
2951 This is the proper way to deal with Place (URL) changes with the MVP
2954 * src/main/java/org/glom/web/client/ClientFactory.java:
2955 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2956 PlaceHistoryMapper and PlaceHistoryHandler.
2957 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2958 PlaceHistoryMapper and PlaceHistoryHandler.
2959 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2960 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2961 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2962 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2963 Add Presenter interface and setPresenter methods. Rename addHyperLink
2964 to addDocumentLink taking only the document title as a parameter.
2966 2011-04-14 Ben Konrath <ben@bagu.org>
2968 Prompt for db username/password if they haven't been set.
2970 This is implemented with a popup widget that is contained within the
2971 OnlineGlomView and managed by the OnlineGlomActivity.
2973 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2974 methods for checking and setting the database username and password.
2975 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2976 new methods for checking and setting the database username and
2978 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2979 Display authentication popup if the JDBC connection to the database
2980 has not been authenticated.
2981 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2983 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2984 for dealing with the authentication popup.
2985 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2986 Implement the methods for dealing with the authentication popup.
2987 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2988 try to executed queries if the database connection hasn't been
2989 authenticated. Implement methods for checking and setting the
2990 database username and password.
2992 2011-04-12 Ben Konrath <ben@bagu.org>
2994 Make log messages a little clearer.
2996 Add a dash betweeen the document title and the table name.
2998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3000 2011-04-12 Ben Konrath <ben@bagu.org>
3002 Protect against NPEs when cleaning up database resources.
3004 While this isn't strictly necessary because the exception is caught,
3005 not protecting against the NPEs makes it harder to find the real error
3008 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3010 2011-04-12 Ben Konrath <ben@bagu.org>
3012 Move configuration of the servlet to the constructor.
3014 The servlet will be initialized even if the database authentication
3015 information is not set or correct. I still need to add the UI for prompting
3016 the user for the authentication information when it's required.
3018 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3019 javadocs for getDocumentTitles() method.
3020 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3021 Set error message when RPC fails.
3022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3023 glom files directory from the configuration file. Try to set the
3024 database authentication information for the specific document if it's
3025 set and works otherwise try to use the global authentication
3026 information set for the directory.
3027 * src/main/resources/onlineglom.properties: Moved from
3028 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3029 Added detailed comments for the new keys.
3031 2011-04-11 Ben Konrath <ben@bagu.org>
3033 Remove unnecessary @Override in DocumentSelectionViewImpl.
3035 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3037 2011-04-11 Ben Konrath <ben@bagu.org>
3039 Remove center alignment in DocumentSelectionView.
3041 The title element is still centred but the document titles and bottom
3042 sentence are both left-aligned.
3044 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3046 2011-04-11 Ben Konrath <ben@bagu.org>
3048 Change 'Demo' naming convention to 'Document'.
3050 This is just a rename refactor with no functional changes to the code.
3052 * src/main/java/org/glom/web/client/ClientFactory.java:
3053 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3054 * src/main/java/org/glom/web/client/OnlineGlom.java:
3055 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3056 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3057 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3058 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3059 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3060 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3061 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3062 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3063 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3064 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3066 2011-04-08 Ben Konrath <ben@bagu.org>
3068 Remove FIXME from safeLongToInt() method.
3070 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3073 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3075 2011-04-08 Ben Konrath <ben@bagu.org>
3077 Display an error if no glom documents are found in the specified directory.
3079 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3080 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3081 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3082 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3084 2011-04-08 Ben Konrath <ben@bagu.org>
3086 Add copyright header to one more file ... oops.
3088 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3090 2011-04-08 Ben Konrath <ben@bagu.org>
3092 Add copyright header to files without it.
3094 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3095 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3096 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3097 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3098 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3099 * src/main/java/org/glom/web/shared/GlomField.java:
3101 2011-04-08 Ben Konrath <ben@bagu.org>
3103 Add support for accessing multiple glom documents in the servlet.
3105 This completes the demo selection functionality.
3107 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3108 document title to methods.
3109 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3110 document title to methods.
3111 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3112 Set browser window title when the activity starts. Correct name of
3113 document title variable.
3114 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3115 Set browser window title when the activity starts. Set the table
3116 selector change handler after table selector has been set. Clear the
3117 OnlineGlomView when the activity has been stopped.
3118 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3119 document title as the place token. Use "#Document:" instead of
3120 "#OnlineGlomPlace:" in the URL.
3121 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3122 Change heading to "Online Glom"
3123 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3124 document title in RPC methods.
3125 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3126 setDocumentTitle() method. Add clear() method.
3127 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3128 setDocumentTitle() method. Implement clear() method which removes the
3129 change handler on the ListBox, clears the ListBox and clears the
3131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3132 Implement methods with document title. Keep track for the configured
3133 glom documents and their corresponding JDBC configurations in a hash
3134 table. This information is retrieved using the document title as the
3135 key in the hash table.
3136 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3137 document title field as it's no longer needed.
3139 2011-04-08 Ben Konrath <ben@bagu.org>
3141 Update the Eclipse JDT configuration.
3143 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3144 methods. Automatically add the copyright header to new files.
3146 2011-04-05 Ben Konrath <ben@bagu.org>
3148 Add new page for demo selection.
3150 This patch adds all the components required to view and start an
3151 OnlineGlom demo by clicking on the desired hyperlink. The user is
3152 able to return to the demo selection page with the browser's back
3153 button. I still need to modify the servlet to work with multiple
3154 documents so all demo links will load the file defined in the
3155 OnlineGlom.properties.
3157 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3158 This is only useful during development so we don't need to save it.
3159 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3160 get a reference to the DemoSelectionView.
3161 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3162 method to get a reference to the DemoSelectionView.
3163 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3164 default view to DemoSelectionView.
3165 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3166 to get glom document titles for glom files in a hard-coded directory.
3167 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3168 method to get glom document titles for glom files in a hard-coded
3170 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3171 Presenter for DemoSelectionView.
3172 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3173 for DemoSelectionView.
3174 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3175 Update for DemoSelectionView.
3176 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3177 Basic 'Place' implementation for the DemoSelectionView.
3178 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3179 The interface for the DemoSelectionView.
3180 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3181 The implementation of the DemoSelectionView.
3182 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3183 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3184 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3185 implementation of method to get glom document titles for glom files
3186 in a hard-coded directory.
3187 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3188 on longer being used.
3189 * src/main/webapp/glom.png: Glom logo.
3191 2011-04-05 Ben Konrath <ben@bagu.org>
3193 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3195 This is the forth and final commit of a refactor that will allow
3196 OnlineGlom to be used with multiple documents.
3198 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3199 Move RPC code from OnlineGlomViewImpl to this class.
3200 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3202 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3203 RPC code to the presenter class (the P in MVP).
3205 2011-04-04 Ben Konrath <ben@bagu.org>
3207 Start moving the existing OnlineGlom code to MVP.
3209 This work is based on the GWT MVP framework that is documented here:
3211 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3213 This is the third commit of a refactor that will allow OnlineGlom to
3214 be used with multiple documents.
3216 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3217 Interface for client factory which is used to get instances of various
3218 classes throughout the app.
3219 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3220 Implementation of client factory.
3221 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3222 initialize the MVP framework.
3223 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3224 New file. Activity manager for the main container widget. This is the
3226 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3227 Maps place (URL) to its corresponding activity.
3228 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3229 New file. This is just a place holder for a generated file.
3230 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: