1 2012-01-04 Murray Cumming <murrayc@murrayc.com>
3 Remove all javadoc author tags.
5 Because they are awkward and meaningless when many people touch
7 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
9 2012-01-04 Murray Cumming <murrayc@murrayc.com>
11 Revert the COPYING.LESSER to COPYING rename.
13 Apparently both should be there if it is LGPL.
15 2012-01-03 Murray Cumming <murrayc@murrayc.com>
17 *View: Remove unused imports.
19 * src/main/java/org/glom/web/client/ui/DetailsView.java:
20 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
21 * src/main/java/org/glom/web/client/ui/ListView.java:
22 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
23 Remove unused imports, as suggested by Eclipse.
25 2012-01-02 Murray Cumming <murrayc@murrayc.com>
27 Move the *View::Presenter types, and some API into one base View.
29 * src/main/java/org/glom/web/client/ui/DetailsView.java:
30 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
31 * src/main/java/org/glom/web/client/ui/ListView.java:
32 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
33 Presenter, setPresenter() and clear() into a shared base interface,
34 to avoid the unnecessary duplicate Presenter types and to more clearly
35 show how the *Views share the same structure, even if they are not
38 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
39 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
41 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
42 * src/main/java/org/glom/web/client/activity/ListActivity.java:
43 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
45 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
48 Feel free to revert this if there is a good reason for the duplicate
51 2012-01-02 Murray Cumming <murrayc@murrayc.com>
53 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
55 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
56 a class member instead of a local variable in the method.
57 This lets us use it to get the view instances, for use in tests.
58 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
59 beforeOnlineGlom(): Test some more details of the initial view.
60 Again, this is not very useful.
62 To really test gwt-glom we will need to start a local postgresql
63 instance with local data, like the Glom tests in C++.
65 2012-01-02 Murray Cumming <murrayc@murrayc.com>
67 pom.xml: Mention the LGPL license.
69 * pom.xml: Add a licenses section.
70 * COPYING.LESSER: Move this to COPYING, which
71 previously contained the GPL. But gwt-glom is all LGPL.
73 2012-01-02 Murray Cumming <murrayc@murrayc.com>
75 Add project information to README and pom.xml.
77 * README: Add a brief description and mention some mvn
79 * pom.xml: This extra information shows up in mvn site
82 2011-01-02 Murray Cumming <murrayc@murrayc.com>
84 Use the latest java-libglom version.
86 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
88 2012-01-01 Murray Cumming <murrayc@murrayc.com>
90 GwtTestOnlineGlom: Test a little more.
92 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
93 protected rather than private, as suggested by the gwt-test-utils
95 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
96 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
97 Test the initial visibility of the panels.
99 However, this is not a very useful test.
100 And I wonder how we should generally test using this idea for an
101 activity/places app like ours where the real changes happen implicitly
102 based on the history token/URL.
104 2012-01-01 Murray Cumming <murrayc@murrayc.com>
106 Slight modification to *Mapper comments.
108 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
110 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
112 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
114 Remove comments mentioning GIN because they are just copied from
115 the example code and are apparently not helpful:
116 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
117 Also change the mention of a class that is only in the example code.
119 2012-01-01 Murray Cumming <murrayc@murrayc.com>
121 GwtTestOnlineGlom test: Minor changes.
123 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
124 Avoid the long qualified class name and modify the comment
125 because it is now obvious to me that the mocked class is the only
126 custom one created via GWT.create().
128 2012-01-01 Murray Cumming <murrayc@murrayc.com>
130 Tests: Added the beginnings of a test using gwt-test-utils.
132 * pom.xml: Add dependencies on gwt-test-utils and easymock.
133 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
134 which tells gwt-test-utils what class will be tested.
135 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
136 Add a simple (but empty) test case. One class, used by the OnlineGlom
137 class, is mocked so that it can be created. However, I am not sure
138 why only this class needs to be mocked.
140 Note that mockito seems more popular, and clearer, than easymock,
141 but I have not got that working yet. It might be a matter of the
144 This test is run during mvn integration-test.
146 2011-12-31 Murray Cumming <murrayc@murrayc.com>
148 Tests: Use junit4-style syntax instead of junit3-style.
150 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
151 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
152 * src/test/java/org/glom/web/shared/DataItemTest.java:
153 Use the @Test annotation rather than relying on the test*() prefix.
154 Also no longer implement TestCase, to avoid triggering support for
155 the junit3-way, which stops the annotations from working.
156 Change the imports from import junit.framework.* to
157 import org.junit.*, which is apparently the new way.
159 2011-12-31 Murray Cumming <murrayc@murrayc.com>
161 Added a test for ListPlace token parsing and creation.
163 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
164 This is much the same as DetailsPlaceTest.
166 I wonder how we could test the other parts of the *Place API.
168 2011-12-30 Murray Cumming <murrayc@murrayc.com>
170 DetailsPlace test: Also test getToken() and recreation via getPlace().
172 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
173 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
174 recreate it, testing the recreated DetailsPlace for the same parameter
177 2011-12-30 Murray Cumming <murrayc@murrayc.com>
179 Use the surefire-report plugin.
181 * pom.xml: This generates a HTML report about the tests in
182 target/site/surefire-report.html
183 when you do mvn surefire-report:report. It seems to be popular/normal.
185 2011-12-30 Murray Cumming <murrayc@murrayc.com>
187 Added a test for DetailsPlace.
189 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
190 Test the getPlace() token parsing.
192 2011-12-30 Murray Cumming <murrayc@murrayc.com>
194 Added a first unit test.
196 * pom.xml: Add a test goal, and a dependency on junit in that scope.
197 * src/test/java/org/glom/web/shared/DataItemTest.java:
198 This is a silly test but it is just to get things started. Note that
199 maven/junit finds the test because it looks in src/test by default.
201 2011-12-22 Ben Konrath <ben@bagu.org>
203 Change charsetName to "UTF-8" when replacing line breaks.
205 JavaScript requires the charsetName to be "UTF-8". CharsetName values
206 that work in Java (such as "UTF8") will not work when compiled to
209 This fixes a problem with multi-line details view fields that have hard
210 line breaks. The "License Text" field on this page demonstrates the
213 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
215 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
217 2011-12-22 Ben Konrath <ben@bagu.org>
219 Fix another bug with related list navigation.
221 I've tested all the navigation buttons in all of the related lists
222 so things should be good now.
224 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
226 2011-12-22 Ben Konrath <ben@bagu.org>
228 Fix a crasher when refreshing the list view with the default table.
230 This crash will also happen when loading the list view with the default
231 table from a link or bookmark.
233 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
234 to the main document selection page when the document id hasn't been
236 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
237 the main document selection page when the document id hasn't been
239 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
240 values for the details place when the document id hasn't been set.
241 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
242 values for the list place when the document id hasn't been set.
244 2011-12-21 Ben Konrath <ben@bagu.org>
246 Protect against NPE when glom.document.locale is not in config.
248 This patch protects against an NPE when glom.document.locale is not in
249 the config file. This NPE will also happen if glom.document.locale is
252 The patch also updates the error message to display the class name when
253 the getMessage() returns null. This was happening when the NPE was
254 thrown and I had "Configuration Error: null". If an NPE is encountered
255 with this patch, "Configuration Error: NullPointerException " will be
258 This commit closes this bug:
260 https://bugzilla.gnome.org/show_bug.cgi?id=666669
262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
264 2011-12-20 Murray Cumming <murrayc@murrayc.com>
266 Rename onlineglom.properties to onlineglom.properties.sample.
268 * src/main/resources/onlineglom.properties: Rename to:
269 * src/main/resources/onlineglom.properties.sample:
270 * src/main/resources/README: And add this file explaining that people
271 should rename it back when deploying.
273 2011-12-20 Murray Cumming <murrayc@murrayc.com>
275 Allow choosing the translation in the .properties file.
277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
278 init(): Read a glom.document.locale value from the configuration file
279 and call Glom's TransatableItem::set_current_locale() method.
280 * src/main/resources/onlineglom.properties: Add a commented-out
281 example of this new setting.
283 It would be better to add &lang=de_DE to the URL, but the current
284 libglom API does not allow us to do this easily. I am working on that.
286 2011-12-19 Murray Cumming <murrayc@murrayc.com>
288 Avoid a crash in parsing of token parameters.
290 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
291 ava: getTokenParams(): Do not crash if a parameter has a key but no
292 value, and ignore parameters with neither.
294 2011-12-17 Murray Cumming <murrayc@murayc.com>
296 History token building/handling: Improve use of token parameters.
298 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
299 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
300 and buildParamsToken(HashMap), for use by derived classes.
301 Make the separator private because it is no longer be needed.
302 * src/main/java/org/glom/web/client/place/DetailsPlace.java
303 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
304 instead of manual string concatenation.
305 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
306 of hardcoded indices and awkward splitting code.
307 * src/main/java/org/glom/web/client/place/ListPlace.java
308 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
309 instead of manual string concatenation.
310 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
311 of hardcoded indices and awkward splitting code.
312 This should fix bug #666420
314 2011-12-16 Murray Cumming <murrayc@murrayc.com>
316 Fix a Navgiation->Navigation typo in the code.
318 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
319 Rename processNavgiation() to processNavigation().
321 2011-12-16 Murray Cumming <murrayc@murrayc.com>
323 Fix a seperator->separator typo in the code.
325 * src/main/java/org/glom/web/client/place/DetailsPlace.java
326 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
327 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
330 2011-12-15 Ben Konrath <ben@bagu.org>
332 Cleanup some comments.
334 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
336 2011-12-14 Ben Konrath <ben@bagu.org>
338 Replace \n with <br/> for multiline text in the details view.
340 Vertical scrollbars are added when needed as well.
342 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
344 2011-12-14 Ben Konrath <ben@bagu.org>
346 Specify the font for document selection links.
348 * src/main/webapp/style.css:
350 2011-12-14 Ben Konrath <ben@bagu.org>
352 Fix bouncy CellTable while paging.
354 This doesn't currently work with related list tables in unselected
357 * src/main/java/org/glom/web/client/ui/list/ListTable.java
359 2011-12-14 Ben Konrath <ben@bagu.org>
361 Revamp the appearance of the document selection page.
363 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
364 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
365 * src/main/webapp/style.css:
367 2011-12-13 Ben Konrath <ben@bagu.org>
369 Set navigation button column to the smallest size possible.
371 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
373 2011-12-13 Ben Konrath <ben@bagu.org>
375 Change OpenButton nomenclature to NavigationButton.
377 Using NavigtionButton makes things more generic. Classes, methods and
378 variables have been changed.
380 This is a rename-only refactor.
382 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
383 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
384 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
385 Renamed from OpenButtonCell.
386 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
387 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
388 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
390 2011-12-12 Ben Konrath <ben@bagu.org>
392 Remove unnecessary String argument in RelatedListTable and ListViewTable.
394 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
395 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
396 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
397 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
399 2011-12-12 Ben Konrath <ben@bagu.org>
401 Update variable names and comments.
403 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
404 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
406 2011-12-12 Ben Konrath <ben@bagu.org>
408 Properly initialize numNonEmptyRows variable to zero.
410 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
411 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
413 2011-12-05 Ben Konrath <ben@bagu.org>
415 Add latest mockup with HTML tables.
417 Features of this mockup:
419 -> HTML table for flowtable
420 -> HTML table for flowtable column
421 -> Example of how related lists would look
422 -> Not using text entries for data items
424 The current version of Online Glom doesn't use HTML tables for the
427 This mockup has been sent to the glom-devel mailing list but it's good
428 to have it here as well.
430 * mockups/details-view-html-tables.html:
432 2011-12-05 Ben Konrath <ben@bagu.org>
434 Remove unnecessary getPrimaryKeyField() method.
436 getPrimaryKeyFieldForTable(String) has been renamed to
437 getPrimaryKeyField(String).
439 * src/main/java/org/glom/web/server/database/DBAccess.java:
440 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
441 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
443 2011-12-05 Ben Konrath <ben@bagu.org>
445 Add string representation of TypedDataItem value to conversion error message.
447 * src/main/java/org/glom/web/server/Utils.java: Logging the error
448 message was extracted into its own method to avoid duplication.
450 2011-12-05 Ben Konrath <ben@bagu.org>
452 Add type checking to navigation primary key value creation.
454 Create navigation primary key only if the expected type from the Glom
455 document matches the type returned by the SQL query.
457 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
459 2011-12-05 Ben Konrath <ben@bagu.org>
461 Rename a couple of variables in RelatedListNavigation.
463 This is a rename-only refactor.
465 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
467 2011-12-05 Ben Konrath <ben@bagu.org>
469 Move getListLayoutGroup() into getListViewLayoutGroup().
471 This removes getListLayoutGroup(). It was only being called by
472 getListViewLayoutGroup().
474 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
476 2011-12-05 Ben Konrath <ben@bagu.org>
478 Remove check for LayoutItem_Portal in list table method.
480 This check is no longer necessary because the method isn't being used
481 to create the LayoutItemPortal DTO.
483 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
485 2011-12-05 Ben Konrath <ben@bagu.org>
487 Properly support related list navigation.
489 Navigation from the "Repository Analyzer -> Package Scans ->
490 Dependencies" related table wasn't working because the primary key for
491 related tables wasn't being set properly. This commit fixes the
494 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
495 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
496 doesn't set the primary key properly for related list tables.
497 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
498 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
499 useful for getting the primary key for list view tables and for related
501 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
502 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
503 Move code to set the primary key for the table from the abstract
504 ListDBAccess class to ListViewDBAccess as it's only correct for list
506 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
507 Properly add primary key to related list tables.
509 2011-12-02 Ben Konrath <ben@bagu.org>
511 Properly set the horizontal alignment of fields.
513 This fix is for both the list tables and the details view.
515 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
516 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
517 to set the horizontal alignment of fields.
519 2011-12-02 Ben Konrath <ben@bagu.org>
521 Display currency codes in the details view.
523 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
525 2011-12-02 Ben Konrath <ben@bagu.org>
527 Avoid duplicate JNI call.
529 JNI is not as efficient as pure Java and this is an easy (and small)
532 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
533 Use previously retrieved value for whereClauseToTableName instead of
536 2011-12-02 Ben Konrath <ben@bagu.org>
538 Rename a couple of variables in RelatedListNavigation.
540 This is a rename-only refactor.
542 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
544 2011-12-02 Ben Konrath <ben@bagu.org>
546 Indicate clearly that a mismatched primary key type is a bug.
548 * src/main/java/org/glom/web/server/Utils.java: Change log level from
549 warning to error. Add 'This is a bug.' to message.
551 2011-12-02 Ben Konrath <ben@bagu.org>
553 Update / fix some comments.
555 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
557 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
559 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
560 Fix comments. Add some TODOs.
562 2011-12-02 Ben Konrath <ben@bagu.org>
564 Enable navigation to details view with string primary key from related list.
566 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
567 Create a text primary key value when return type of result is
568 java.sql.Types.VARCHAR.
570 2011-12-02 Ben Konrath <ben@bagu.org>
572 Use checkboxes for booleans in the details view.
574 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
576 2011-12-01 Ben Konrath <ben@bagu.org>
578 Improve performance of related list height calculation.
580 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
581 Put code to calculate the expected height in a static initializer so
582 that that it's only called once.
584 2011-12-01 Ben Konrath <ben@bagu.org>
586 Show related list tables in notebooks (again).
588 Calculate the height of the related list tables so the Notebook can be
589 set the correct height. The height of the related list table is also needed by
590 FlowTable to be able decide how to create the layout.
592 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
593 and set the Portal height based on the height of the related list
594 table and the Portal container.
595 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
596 Add method to calculate the height of the related list tables.
597 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
598 * src/main/webapp/style.css: Add css class for Pager. This is needed to
599 calculate the height of the Pager widget.
601 2011-12-01 Ben Konrath <ben@bagu.org>
603 Use CellTable API for table property instead of setting style on Element.
605 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
607 2011-12-01 Ben Konrath <ben@bagu.org>
609 Make ListViewTable and RelatedListTable a consistent height.
611 The tables are now a consistent height regardless of the contents of
612 the table. A hidden button is added to empty rows to ensure that the
613 height of these rows will match the height of rows with data.
615 A navigation button column is now added to every table. The width of
616 the navigation column is set to 0px when a RelatedListTable shouldn't
617 have navigation buttons. This maintains the a consistent row height in
618 tables that don't show the navigation buttons.
620 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
621 navigation column when not needed.
622 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
623 arguments for navigation button to constructor of ListViewTable.
624 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
625 hidden button for empty data rows.
626 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
627 arguments for navigation button to constructor.
628 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
629 create navigation buttons. Add hideNavigationButtons() method.
630 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
631 arguments for navigation button to constructor.
633 2011-12-01 Ben Konrath <ben@bagu.org>
635 Use 'visibility: hidden' in Utils.getWidgetHeight().
637 This is better choice because hidden elements are invisible, don't
638 respond to events and are not part of the tab order. They will,
639 however, take up space which is required to be able to calculate the
640 height of the widget.
642 * src/main/java/org/glom/web/client/Utils.java:
644 2011-12-01 Ben Konrath <ben@bagu.org>
646 Use Utils.getWidgetHeight() in FlowTable.
648 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
650 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
652 2011-12-01 Ben Konrath <ben@bagu.org>
654 Put the details css class name on the correct table column.
656 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
658 2011-11-30 Ben Konrath <ben@bagu.org>
660 Update for java-libglom API change.
662 The getters and setters on FieldFormatting and NumericFormat were
663 changed to remove the 'M'.
665 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
667 2011-11-29 Ben Konrath <ben@bagu.org>
669 Only allow RelatedListTables in Portals.
671 * src/main/java/org/glom/web/client/ui/details/Portal.java:
673 2011-11-29 Ben Konrath <ben@bagu.org>
675 Only create a contents panel for Portals when title is being set.
677 * src/main/java/org/glom/web/client/ui/details/Portal.java:
679 2011-11-29 Ben Konrath <ben@bagu.org>
681 Set TabLayoutPanel height based on calculated height its widgets.
683 This is a potential fix for this bug:
685 https://bugzilla.gnome.org/show_bug.cgi?id=665133
687 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
689 2011-11-29 Ben Konrath <ben@bagu.org>
691 Align details field labels and data with the Open buttons.
693 * src/main/webapp/style.css:
695 2011-11-29 Ben Konrath <ben@bagu.org>
697 Remove unnecessary <div> in the Notebook widget.
699 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
700 method to get container FlowPanel (<div>).
701 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
702 initWidget() method directly on the TabLayoutPanel widget instead of
703 Group's container widget.
705 2011-11-29 Ben Konrath <ben@bagu.org>
707 Don't add group titles for Portals in Notebooks.
709 This reverts the previous patch and fixes a bug I introduced with
710 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
712 * src/main/java/org/glom/web/client/ui/details/Group.java:
713 * src/main/java/org/glom/web/client/ui/details/Portal.java:
715 2011-11-28 Ben Konrath <ben@bagu.org>
717 Remove unused boolean argument in Portal constructor.
721 * src/main/java/org/glom/web/client/ui/details/Group.java:
722 * src/main/java/org/glom/web/client/ui/details/Portal.java:
724 2011-11-28 Ben Konrath <ben@bagu.org>
726 Remove hack for glom 1.18 style glom files.
728 * src/main/java/org/glom/web/client/ui/details/Group.java:
729 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
730 * src/main/java/org/glom/web/client/ui/details/Portal.java:
732 2011-11-28 Ben Konrath <ben@bagu.org>
734 Use Gda Value version of primary key to log result too large error.
736 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
738 2011-11-28 Ben Konrath <ben@bagu.org>
740 Don't use TypedDataItem.getText() for Unknown types from the URL.
742 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
743 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
744 instead of getText().
745 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
746 String field and getUnknown() method.
748 2011-11-28 Ben Konrath <ben@bagu.org>
750 Log an error message when the java-libglom .so is not present.
752 The error message was being set in the exception but not logged.
754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
756 2011-11-28 Ben Konrath <ben@bagu.org>
758 Ignore LayoutItem_CalendarPortals.
760 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
761 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
763 2011-11-28 Ben Konrath <ben@bagu.org>
765 Extract method for creating the LayoutItemPortal DTO.
767 Just breaking the code up into smaller chunks.
769 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
771 2011-11-28 Ben Konrath <ben@bagu.org>
775 This should have been added with the refactor. Oops!
777 * src/main/java/org/glom/web/shared/TypedDataItem.java:
779 2011-11-28 Ben Konrath <ben@bagu.org>
781 Create primary key value from URL string using type from Glom document.
783 See this bug, comments 19 - 25:
785 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
787 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
788 create a TypeDataItem for the primary key here when loading from a
789 URL. Show the same string for the primary key value as was received
790 from the URL string (when loading from a URL).
791 * src/main/java/org/glom/web/server/Utils.java: Update method for
792 creating the Gda Value from the TypeDataItem to properly deal with
793 creating a Gda Value based on the Glom document type for the primary
794 key value string when loading from a URL.
795 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
796 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
797 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
798 Update for changed method name.
800 2011-11-27 Ben Konrath <ben@bagu.org>
802 Rename PrimaryKeyItem to TypedDataItem.
804 The name PrimaryKeyItem suggests what the class should be used for.
805 TypedDataItem is a neutral name that describes the class better.
807 This is a rename-only refactor.
809 * src/main/java/org/glom/web/client/OnlineGlomService.java:
810 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
811 * src/main/java/org/glom/web/client/Utils.java:
812 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
813 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
814 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
815 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
816 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
817 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
818 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
819 * src/main/java/org/glom/web/server/Utils.java:
820 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
821 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
822 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
823 * src/main/java/org/glom/web/shared/NavigationRecord.java:
825 2011-11-25 Ben Konrath <ben@bagu.org>
827 Improve Gda Value conversion from PrimaryKeyItem.
829 The value from the PrimaryKeyItem is only used if its type match the
830 type from the glom document.
832 * src/main/java/org/glom/web/server/Utils.java:
834 2011-11-25 Ben Konrath <ben@bagu.org>
836 Manually check if the java-liblgom .so is visible to the JVM.
838 It seems that Tomcat has problems when a static initializer throws an
839 exception. This check is done before the first method call into
840 java-libglom so that execution doesn't continue if the .so is not
843 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
845 2011-11-25 Ben Konrath <ben@bagu.org>
847 Improve browser configuration error messages.
851 https://bugzilla.gnome.org/show_bug.cgi?id=662792
853 * src/main/java/org/glom/web/client/OnlineGlomService.java:
854 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
855 getConfigurationErrorMessage() method.
856 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
857 Get and display a specific configuration error message when no Glom
859 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
860 Implement getConfigurationErrorMessage() method. Surround configuration
861 code in the init() method with a try/catch block. This allows the
862 errors to be caught while keeping the servlet available to retrieve the
863 configuration error message.
865 2011-11-25 Ben Konrath <ben@bagu.org>
867 Don't use Strings to hold primary key values.
869 The primary key values are now held in a new data object
870 (PrimaryKeyItem) that holds type information and the primary key value
871 using the correct type.
873 * src/main/java/org/glom/web/client/OnlineGlomService.java:
874 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
876 PrimaryKeyItem instead of String to hold the primary key value.
877 * src/main/java/org/glom/web/client/Utils.java: Remove
878 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
879 PrimaryKeyItem based on the GlomFieldType and the DataItem.
880 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
881 PrimaryKeyItem instead of String to hold the primary key value. Load
882 document selection page when the documentID has not been set correctly.
883 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
884 DetailsPlace -> URL and URL -> DetailsPlace conversion with
886 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
887 Return empty string for URL instead of "null".
888 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
889 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
890 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
891 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
892 PrimaryKeyItem instead of String to hold primary key values.
893 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
894 PrimaryKeyValue to a Gda Value.
895 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
896 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
897 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
898 Replace temporary database access code that uses the PrimaryKeyValue to
899 Gda Value conversion.
900 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
901 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
902 PrimaryKeyItem instead of String.
903 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
904 hold primary key values.
906 2011-11-24 Ben Konrath <ben@bagu.org>
908 Use newly added java-libglom API to create queries.
910 This isn't finished. I still need to stop using Strings for primary key
911 values in the client code.
913 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
914 libglom to use fake connections so that retrieving the query string will
916 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
917 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
918 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
919 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
920 Use the newly added libglom sql methods and classes to create the
921 query. Add temporary hack to convert primary value strings to Gda
924 2011-11-23 Ben Konrath <ben@bagu.org>
926 Don't explicitly set the height of Portals.
928 See comments 6 - 10 of this bug for details:
930 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
932 * src/main/java/org/glom/web/client/ui/details/Portal.java:
934 2011-11-23 Ben Konrath <ben@bagu.org>
936 Use an HTML table instead of CSS for the FlowTable layout.
938 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
939 GWT's FlexTable to implement the FlowTable.
940 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
942 2011-11-18 Ben Konrath <ben@bagu.org>
944 Add boolean example to HTML table mockup.
946 * mockups/details-view-html-tables-text-entries.html:
948 2011-11-17 Ben Konrath <ben@bagu.org>
950 Ensure the pager buttons are always visible for related lists.
952 To accomplish this, I've turned off text wrapping in the list view and
953 related list tables for both the header and data text. The related list
954 table now has a fixed layout so the it doesn't overflow its container.
955 This is required to ensure that the cell text is clipped when it
956 overflows the cell and an ellipsis is added to the right side of the
957 cell when text is clipped.
959 A fixed table layout for the related list table in the details view
960 seems what we want for the details view anyway, so the side-effect is
963 The ellipsis will only be displayed in Firefox >= 7.
967 https://bugzilla.gnome.org/show_bug.cgi?id=662930
969 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
970 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
971 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
973 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
974 Set the 'table-layout: fixed' CSS property to the related list table.
975 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
976 'white-space: nowrap;' CSS property on both the list view and the
979 2011-11-16 Ben Konrath <ben@bagu.org>
981 Rework the fix for empty notebook tab labels.
983 Setting the empty group titles with its name caused problems for the
984 details layout. Instead of using libglom's
985 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
986 to the client when the title is empty. This allows the Notebook to use
987 the name when the title is empty without affecting anything else.
989 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
990 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
992 2011-11-16 Ben Konrath <ben@bagu.org>
994 Set group titles with name when title is empty.
996 This fixes a problem with an empty notebook tab label in the Lesson
997 Planner document. The forth tab in the notebook should be "Internet":
999 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1001 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1002 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1005 2011-11-16 Ben Konrath <ben@bagu.org>
1007 Remove whitespace from the configured username properties.
1009 This assumes that usernames won't have whitespace at the beginning
1010 or end. But I think this is a reasonable assumption.
1012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1013 String.trim() to remove the whitespace from the username properties.
1015 2011-11-15 Ben Konrath <ben@bagu.org>
1017 Add details view mockup with HTML tables and text entries.
1019 This is from the attachment on this bug:
1021 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1023 * mockups/details-view-html-tables-text-entries.html:
1025 2011-11-15 Ben Konrath <ben@bagu.org>
1027 Add space between the columns of the flow table.
1031 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1033 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1034 space between columns in the flow table.
1036 2011-11-15 Ben Konrath <ben@bagu.org>
1038 Add backup files to the .gitignore.
1040 * .gitignore: Ignore files that end with ~.
1042 2011-11-09 Ben Konrath <ben@bagu.org>
1044 Use latest release of gwt-log.
1046 Gwt-log releases are now being submitted to the maven central
1047 repository so manual installation of the jar is no longer required.
1049 * pom.xml: Update version and groupId of gwt-log dependency.
1051 2011-10-31 Ben Konrath <ben@bagu.org>
1053 Don't use GWT numeric formatting to override the glom currency formatting.
1055 Currencies are now displayed like they are in Glom. See this bug:
1057 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1059 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1061 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1062 currency code to constructor and set it when the cell is rendered.
1063 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1064 currency code to the constructor of the NumericCell.
1066 2011-10-27 Ben Konrath <ben@bagu.org>
1068 Require the latest release of java-libglom (1.17.4).
1072 2011-10-26 Ben Konrath <ben@bagu.org>
1074 Add style to Notebook that matches current theme.
1076 It's not the best style in the world but it's better than the default.
1078 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1079 padding at the bottom of the child widgets.
1080 * src/main/webapp/style.css: Add style for the Notebook.
1082 2011-10-26 Ben Konrath <ben@bagu.org>
1084 Move servlet initialization code to overridden init method.
1086 This is half of the solution to getting proper error messages
1087 displayed when configuration errors occur. Here's the relevant bug:
1089 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1091 The rest of the solution involves surrounding the init method with a
1092 try/catch block and setting a global variable with the error /
1093 exception. A new async method should be created to retrieve and display
1094 the error message / exception.
1096 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1097 code from constructor to init method adding exceptions as needed.
1099 2011-10-26 Ben Konrath <ben@bagu.org>
1101 Add script to monitor and restart tomcat if required.
1103 * utils/check-and-recover-tomcat.py: New file.
1105 2011-10-26 Ben Konrath <ben@bagu.org>
1107 Display the correct number of data items in the pager.
1111 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1113 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1114 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1115 The implementation is the same for both tables: Keep track of the
1116 number of non-empty rows and fire and RowCountChangeEvent after the data has
1118 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1119 custom Pager class that subclasses SimplePager to handle displaying
1120 the correct number when empty rows have been added.
1122 2011-10-26 Ben Konrath <ben@bagu.org>
1124 Correct error in previous commit.
1126 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1127 eventBus parameter from listView.setCellTable().
1129 2011-10-26 Ben Konrath <ben@bagu.org>
1131 Fix error in TODO comment.
1133 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1135 2011-10-24 Ben Konrath <ben@bagu.org>
1137 Create Notebook widgets to the details view.
1139 This isn't finished just yet - I still need to create a reasonable
1140 style to match the current theme.
1142 * src/main/java/org/glom/web/client/Utils.java: Add method for
1143 calculating the height of a widget. This is used in the Notebook class.
1144 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1145 new constructor method in Group.
1146 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1147 method for creating child widget that can be used by subclasses
1148 like Notebook. New constructor that allows disabling the group
1149 titles - Notebooks don't set a group title for their child groups.
1150 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1151 to make Notebooks using GWT's TabLayoutPanel.
1152 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1153 constructor that allows disabling the group titles.
1154 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1155 LayoutItemNotebook DTO.
1156 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1157 DTO for Notebooks. It's just an empty class for now but we might need
1158 it to transfer some specific information in the future.
1160 2011-10-21 Ben Konrath <ben@bagu.org>
1162 Add navigation buttons to related list tables.
1164 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1165 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1167 method getSuitableRecordToViewDetails() for getting the table name
1168 and primary key value for related list navigation buttons.
1169 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1170 private cell renderer class to get the navigation information for
1171 related list tables from the server. Extract the navigation
1172 processing code from the details cell navigation and use it for the
1173 related list navigation as well.
1174 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1175 cell renderer class for the details open buttons. This was needed
1176 because the related list navigation buttons and the list view
1177 navigation buttons need to react differently when clicked.
1178 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1179 the onEnterKeyDown() method because it's now overriden in the
1180 subclasses that are specific to the related list tables and the list
1182 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1183 the vertical size a little because the buttons add a bit of vertical
1184 space to table. This is not a perfect solution because the vertical
1185 size of with table fewer than 5 rows will be a little smaller.
1186 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1187 changes in how navigation buttons are handled.
1188 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1189 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1190 database access object.
1191 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1192 to find the portal for a given relationship name from
1193 RelatedListDBAccess. Add method to find a primary key field for a
1195 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1196 Move code to find the portal for a given relationship name to
1198 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1199 New file: database access object for getting the related list
1200 navigation information (the table name and the primary key value).
1201 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1202 DTO for transferring a table name to navigate to and a primary key
1204 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1205 boolean and getter/setter to specifies if the related list should add
1208 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1210 Use the master branch of java-libglom
1212 * pom.xml: Depend on java-libglom 1.19 instead.
1214 This is the master branch. See also the libglom-1-18 branch.
1216 2011-10-11 Ben Konrath <ben@bagu.org>
1218 Enable the open navigation button when the data has been set.
1220 This avoids having active buttons that don't do anything when the data
1223 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1225 2011-10-11 Ben Konrath <ben@bagu.org>
1227 Use IsWidget interface for FlowTableItem.
1229 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1230 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1232 2011-10-11 Ben Konrath <ben@bagu.org>
1234 Remove GWT styling from open button in details view.
1236 There are still some issues with how the details cell is arranged but
1237 this should be made to match Glom 1.20. I'm going to leave fixing this
1238 until I have Glom 1.20 up and running.
1240 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1241 style name on open button.
1242 * src/main/webapp/style.css: Move and edit details-navigation class.
1243 Re-arrange some classes to make them appear in the same order as the
1246 2011-10-07 Ben Konrath <ben@bagu.org>
1248 Update to GWT 2.4.0.
1250 * .gitignore: Ignore new cache directory.
1251 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1252 * pom.xml: Change GWT and maven plugin to 2.4.0.
1253 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1255 * src/main/java/org/glom/web/client/ClientFactory.java:
1256 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1257 * src/main/java/org/glom/web/client/OnlineGlom.java:
1258 Update source for API changes.
1259 * utils/build-onlineglom-war.sh: Remove cache directory before the
1262 2011-10-07 Ben Konrath <ben@bagu.org>
1264 Add navigation buttons in the details view.
1266 This isn't finished but I thought I'd commit what I have as it's a
1267 pretty good start. I still need to:
1269 1. Change the style so that it fits better into the current theme
1270 2. Adjust the details cell to expand as much as possible.
1272 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1273 click handlers to navigation buttons in the DetailsCells. Create a
1274 refreshData() method to get just the data from the server without the
1276 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1277 Update the tableSelector and browser title when the table name
1278 changes without using the tableSelector.
1279 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1280 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1281 getDetailsCells() to getCells(). Update variable names.
1282 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1283 method to set click handler on navigation button. Rename a few
1284 variables. Add navigation buttons where needed.
1285 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1286 variables and methods.
1287 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1288 navigation boolean and navigation table as required in the
1289 LayoutItemField DTO.
1290 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1291 variables for navigation along with getter/setter methods.
1293 2011-10-07 Ben Konrath <ben@bagu.org>
1295 Rename Field to DetailsCell.
1297 This is a refactor-only commit. No functionality has been added or
1300 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1301 Update variable and method names.
1302 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1303 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1304 variable and method names.
1305 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1307 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1308 variable and method names.
1310 2011-10-07 Ben Konrath <ben@bagu.org>
1312 Create separate methods for layout and data the details view.
1314 This is a refactor-only commit. No functionality has been added or
1317 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1318 private methods: setData(), createLayout().
1320 2011-10-07 Ben Konrath <ben@bagu.org>
1322 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1324 This is part of a change to get navigation buttons in the details view
1325 but it should have been done this way from the start.
1327 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1328 for method name change in TableSelectionView.
1329 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1330 Create TableChangeEvent and set the browser title using the
1331 TableSelectionView API.
1332 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1333 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1334 Change getSelectedTable() to getSelectedTableName(). Add
1335 getSelectedTableTitle().
1337 2011-10-07 Ben Konrath <ben@bagu.org>
1339 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1341 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1343 2011-10-07 Ben Konrath <ben@bagu.org>
1345 Update TableChangeEvent to use newTableName naming convention.
1347 This makes the class more consistent with GWT naming conventions.
1349 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1350 Update for method name change in TableChangeEvent.
1351 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1352 for method name change in TableChangeEvent.
1353 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1354 newTableName variable and getter method. Make toDebugString()
1357 2011-09-30 Ben Konrath <ben@bagu.org>
1359 Disable the pager in the list tables when the data row count is less than the minimum.
1361 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1362 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1364 2011-09-30 Ben Konrath <ben@bagu.org>
1366 Add empty rows to the end of related list and list view tables.
1368 I also extracted the cell rendering classes from the ListTable because
1369 the code was becoming a little crazy with all the anonymous inner
1370 classes. My plan is to use these cell rendering classes in the details
1371 view as well so this refactor will be needed for that change.
1373 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1374 set the row count in related list tables if the data has more rows
1375 than the minimum number of rows visible.
1376 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1377 row count in list view tables if the data has more rows than the
1378 minimum number of rows visible.
1379 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1380 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1382 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1383 for rendering TYPE_NUMERIC cells. The code was extracted from the
1385 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1386 class for rendering cells with buttons in list views. The code was
1387 extracted from the ListTable class.
1388 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1389 for rendering TYPE_TEXT cells. The code was extracted from the
1391 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1392 Add empty rows to the end of the data if required. Implement
1393 ListTable.getMinNumVisibleRows().
1394 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1395 cell renderer code to public classes. Return null in
1396 Column.getValue() for empty rows. Add new abstract method:
1397 getMinNumVisibleRows(). Move code to set the row count of the list view
1398 table to ListViewImpl.
1399 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1400 empty rows to the end of the data if required. Implement
1401 ListTable.getMinNumVisibleRows().
1404 2011-09-27 Ben Konrath <ben@bagu.org>
1406 Use GWT.log for client-side debugging statements.
1408 These are optimized out when deployed so I should have used this method
1409 in the first place. These statements will eventually be replaced with some sort
1410 of notification in the browser.
1412 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1413 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1414 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1415 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1416 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1418 2011-09-27 Ben Konrath <ben@bagu.org>
1420 Put tableselector on the right, back to list link on right.
1422 The idea is that the table selector is acting like a label for the
1423 currently displayed table so it should be placed below the document title. This
1424 puts the table title in a similar position to where it is in Glom.
1426 * mockups/details-contacts.html:
1427 * mockups/details-projects.html:
1428 * mockups/listview-contacts.html:
1429 * mockups/listview-projects.html:
1430 * mockups/style.css:
1431 Update mockups to match how the interfaces currently look.
1432 * src/main/webapp/style.css: Swap positions of backlink with the table
1433 selector. Add some space on the left side of the table selector to
1434 line things up with the document title.
1436 2011-09-27 Ben Konrath <ben@bagu.org>
1438 Add field colouring to details view.
1440 This change re-works how field colouring works. The colour formatting
1441 information is now set to the client with the layout information instead of
1442 with the data. This eliminates the need to send the same colour strings for
1443 data in list view column when colour information is set.
1445 In order to set an alternate colour for negative numeric values, the
1446 number is now sent to client and formatted with the GWT NumberFormat class.
1448 This change also fixes:
1450 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1452 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1453 internationalization framework which is needed for client side numeric
1455 * src/main/java/org/glom/web/client/Utils.java: New file for some
1456 client static utility methods.
1457 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1458 the DataItem object to the Field class. Use a utility method to
1459 create the foreignKeyValue string.
1460 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1461 alignment and text colours in the constructor. Add setData(DataItem)
1462 method. Remove setText(String) method.
1463 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1464 colour information to GlomTextCell. Create and use GlomNumberCell for
1465 rendering numbers. Use utility method to get the string for the
1466 primary key of the key provider. Re-work how the horizontal alignment
1468 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1469 formatting to layout information. Methods for converting the libglom
1470 formatting information were moved from DBAccess.
1471 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1472 numeric formatting (it's now done on the client side). Don't set text
1473 colours in DataItem. Move libglom formatting conversion methods to
1475 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1476 getters/setters for text colour information.
1477 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1478 for transferring the libglom NumericFormat information to the client.
1479 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1480 and getters/setters for: GlomNumericFormat, background colour and
1481 foreground colour strings.
1483 2011-09-26 Ben Konrath <ben@bagu.org>
1485 Simplify code that iterates through the LayoutGroup.
1487 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1489 2011-09-26 Ben Konrath <ben@bagu.org>
1491 Accept Eclipse formatting for OnlineGlomServiceAsync.
1493 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1495 2011-09-26 Ben Konrath <ben@bagu.org>
1497 Don't use the ListDBAccess classes to get the primary key layout information.
1499 This was causing a bug where the wrong index for the hidden primary key
1500 was being sent to the client.
1502 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1503 primary key while creating the LayoutGroup DTO. Create a
1504 LayoutItemField DTO for hidden primary keys. Don't use the
1505 RelatedListDBAccess because it was only used for getting the primary
1507 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1508 access modifier from public to protected for getPrimaryKeyField() and
1509 getPrimaryKeyLayoutItemField().
1510 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1511 abstract method getExpectedResultSize() because RelatedListDBAccess
1512 doesn't have enough info to implement it.
1513 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1514 Remove @Override for getExpectedResultSize().
1515 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1516 Remove method getExpectedResultSize().
1518 2011-09-23 Ben Konrath <ben@bagu.org>
1520 Log which layout (list or details) the ignored item is from.
1522 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1524 2011-09-23 Ben Konrath <ben@bagu.org>
1526 Remove annotations that turn off code formatting in DataItem.
1528 * src/main/java/org/glom/web/shared/DataItem.java:
1530 2011-09-23 Ben Konrath <ben@bagu.org>
1532 Rename GlomField to DataItem and update associated methods.
1534 This is a rename-only refactor. No functionality has been added or
1537 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1538 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1539 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1540 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1541 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1542 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1543 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1544 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1545 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1546 * src/main/java/org/glom/web/server/database/DBAccess.java:
1547 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1548 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1549 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1550 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1551 * src/main/java/org/glom/web/shared/DataItem.java:
1552 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1553 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1555 2011-09-23 Ben Konrath <ben@bagu.org>
1557 Rename GlomDocument to DocumentInfo and update associated methods.
1559 This is a rename-only refactor. No functionality has been added or
1562 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1563 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1564 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1565 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1566 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1567 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1568 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1570 2011-09-20 Ben Konrath <ben@bagu.org>
1572 Require java-libglom 1.17.3.
1574 This picks up the fix for the seg fault problem with the Scenes table
1575 in the Openismus Film Manager example.
1579 2011-09-20 Ben Konrath <ben@bagu.org>
1581 Change the way sort clause is added for primary key when no sort clause is requested.
1583 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1584 before the sort clause is created. When a sort clause is not requested, the
1585 sort clause is created by finding the primary key in the LayoutFieldVector
1588 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1590 2011-09-20 Ben Konrath <ben@bagu.org>
1592 Log error message if no documents are found in the configured directory.
1594 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1595 Extract the glom file extension string to a private static final class
1596 variable (mostly as syntactic sugar). Accept a minor formatting change.
1597 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1598 the example glom.document.directory configuration property to make it
1599 more clear that it can any directory, not just the home directory.
1601 2011-09-18 Ben Konrath <ben@bagu.org>
1603 Add related lists to details view.
1605 The related list table has support for paging and sorting just like the
1606 table in the list view.
1608 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1609 SQL queries for the related list tables.
1610 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1611 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1612 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1613 Rename getList methods to getListView and add comments. Remove
1614 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1615 it being unused. Add methods: getDetailsLayoutAndData(),
1616 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1617 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1618 Create the layout and set the data for the fields in one async call
1619 instead of two. Create related lists where appropriate.
1620 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1621 for method name changes in OnlineGlomService.
1622 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1623 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1624 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1626 * src/main/java/org/glom/web/client/ui/ListView.java:
1627 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1628 tableName from setCellTable(). Create a ListViewTable instead of
1630 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1631 represent a data field in the details view.
1632 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1633 from addDetailsCell() to Field class. Keep track of the Fields and
1634 Portals in the details view.
1635 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1636 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1637 and add a method to get it. Add method to set the contents of the
1639 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1640 New class for related list tables. This class has the data provider
1641 for the related list table.
1642 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1643 abstract class which is the base class for the ListViewTable and the
1645 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1646 New class for list view tables. This class has the data provider for
1647 the list view table.
1648 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1649 methods for related list tables. Add more information to the
1650 LayoutItemField and LayoutItemPortal DTOs.
1651 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1652 Remove debugging print statement.
1653 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1654 Remove debugging print statements. Add primary key field to SQL count
1656 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1657 Remove unnecessary LayoutFieldVector parameter from
1658 getResultSizeOfSQLQuery() method.
1659 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1660 New class for related list table database access.
1661 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1662 class that is a wrapper DTO for details view layout and data.
1663 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1664 new 'fromField' string to this DTO.
1665 * src/main/webapp/style.css: Remove bottom margin and override top
1668 2011-09-15 Ben Konrath <ben@bagu.org>
1670 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1672 This sets things up to make it easier to add the data retrieval for
1673 related lists (portals). No user noticeable changes were made with
1676 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1677 class has the code to retrieve the layouts and access the
1678 database using the new database helper classes.
1679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1680 Most of the functionality has been removed from this class. This
1681 class now represents the public interface for the client side
1682 code. It also deals with configuring the servlet and cleaning
1683 things up when the servlet is stopped.
1684 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1685 of static methods into this utility class.
1686 * src/main/java/org/glom/web/server/database/DBAccess.java:
1687 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1688 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1689 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1690 These classes have the database retrieval code. The class hierarchy
1691 has been setup to make it easy to reuse code for similar
1694 2011-09-06 Ben Konrath <ben@bagu.org>
1696 Create separate classes for list table code and the data provider.
1698 As part of this refactor, I also split up the code a bit to make it
1701 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1702 table code to two new classes (below).
1703 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1704 with code from ListViewImpl.
1705 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1706 New file with code from ListViewImpl.
1708 2011-09-06 Ben Konrath <ben@bagu.org>
1710 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1712 This fixes the LayoutItemPortal DTO to match the libglom layout object
1715 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1717 2011-09-01 Ben Konrath <ben@bagu.org>
1719 Set title of Portals in the Details View.
1721 * pom.xml: Bump required version of java-libglom to 1.17.1.
1722 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1723 widget creation to its own class. Add comments to constructor.
1724 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1725 The code is mostly from the Group class with the title now set.
1726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1727 title of Portal. Update some comments. Fix some code formatting.
1729 2011-09-01 Ben Konrath <ben@bagu.org>
1731 Remove TODO comment for the flow table column width.
1733 The flow table column width is working correctly and doesn't need to be
1734 changed. See this mailing list post for more info:
1736 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1738 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1740 2011-08-27 Ben Konrath <ben@bagu.org>
1742 Add document title (database name) to top of the browser page.
1744 I added the document title to the TableSelecitonView but that will
1745 change if / when we add a view that doesn't require table selection.
1747 * mockups/details-contacts.html:
1748 * mockups/details-projects.html:
1749 * mockups/listview-contacts.html:
1750 * mockups/listview-projects.html:
1751 * mockups/style.css: Add document title to mockups to keep things
1753 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1754 sizes to account for the document title.
1755 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1756 Set the document title when it has been retrieved from the server.
1757 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1758 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1759 and implement setDocumentTitle(String) method.
1760 * src/main/webapp/style.css: Add ID for document title style.
1762 2011-08-25 Ben Konrath <ben@bagu.org>
1764 Add NavigationType enum to LayoutItemPortal DTO.
1766 This is the start of adding support for Portals to the Details View.
1768 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1769 LayoutItem_Portal.navigation_type enum from libglom to
1770 LayoutItemPortal.NavigationType enum.
1771 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1772 NavigationType enum, field for storing the NavigationType and getter
1775 2011-08-25 Ben Konrath <ben@bagu.org>
1777 Implement the flow table layout in the Details View.
1779 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1780 FlowTable to Group to account for the renamed class.
1781 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1782 File. This is a container widget that implements the Glom details view
1783 flow table behaviour.
1784 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1785 org/glom/web/client/ui/FlowTable.java.
1786 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1787 so that the size of the subgroups are a closer match to the size of
1788 the Glom subgroups. This makes the flowtable layout match the layout
1789 in Glom for the Music Collection example file.
1791 2011-08-16 Ben Konrath <ben@bagu.org>
1793 Create container element for LayoutItemPortal in Details View.
1795 This will help me develop the layout for the FlowTable.
1797 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1798 fieldPanel variable to detailsCell.
1800 2011-08-15 Ben Konrath <ben@bagu.org>
1802 Set the height of the data element in the Details View.
1804 I changed the InlineLabels (text in a span element) to Labels (text in
1805 a div element) so that I could set the height of the details-data
1806 elements instead of the details-cell parent elements. This allows the
1807 the details-data element to display the correct height if style is
1808 applied that shows the height.
1810 This change has the added benefit of allowing the order of the labels
1811 and data elements to be changed for right-to-left languages.
1813 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1814 InlineLabels to Labels.
1815 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1816 InlineLabels to Labels. Set the height of the data element.
1817 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1818 multiline text height in the Formatting DTO.
1819 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1820 for multiline height along with getter and setter methods.
1821 * src/main/webapp/style.css: Adjust style to account for the change
1822 from span elements to div elements in the details cell.
1824 2011-08-15 Ben Konrath <ben@bagu.org>
1826 Make the List View appearance match the mockups.
1828 It doesn't match exactly but it's much better than it was.
1830 * mockups/listview-contacts.html: Remove unused css classes.
1831 * mockups/listview-projects.html: Remove unused css classes.
1832 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1833 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1834 for mainPanel instead of VerticalPanel (table). Set style name on
1835 CellTable. Set style name on Details column. Right-align Details
1837 * src/main/webapp/style.css: Adjust properties to match the mockups.
1839 2011-08-12 Ben Konrath <ben@bagu.org>
1841 Add better support for subgroups in the details view.
1843 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1844 changed FlowTable constructor.
1845 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1846 support for subgroups and subgroup-titles.
1847 * src/main/webapp/style.css: Add CSS class for subgroups and
1850 2011-08-12 Ben Konrath <ben@bagu.org>
1852 Return the top level LayoutGroup title.
1854 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1856 2011-08-11 Ben Konrath <ben@bagu.org>
1858 Make the TableSelector header match the mockup.
1860 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1861 the layout panel. Properly lineup the table selection header with
1862 the list and details view.
1863 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1864 margin around the details view.
1865 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1866 Rename listBox variable to tableSelector. Set id for the style sheet.
1867 Use a FlowPanel instead of a HorizontalPanel.
1868 * src/main/webapp/style.css: Add properties to make the TableSelector
1869 box match the mockups.
1871 2011-07-13 Ben Konrath <ben@bagu.org>
1873 Update install script for java-libglom version change.
1875 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1878 2011-07-13 Ben Konrath <ben@bagu.org>
1880 Add support sub-group in the details view.
1882 I also removed the code that special-cased the default details view
1885 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1887 I still have to make a proper flowtable.
1889 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1890 Don't special-case default details view layout.
1891 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1892 addLayoutField() as I'm going to use it.
1893 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1894 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1896 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1897 extracted from DetailsViewImpl.GroupPanel. Add support for
1899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1900 column count when getting the details layout.
1902 2011-07-12 Ben Konrath <ben@bagu.org>
1904 Set browser title with database and table titles.
1906 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1907 Set the browser title when the table changes and when the activity
1909 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1910 title when retrieving document info (the GlomDocument object).
1911 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1912 with getter and setter methods. Remove unused convenience constructor.
1913 Use default code formatting.
1915 2011-07-12 Ben Konrath <ben@bagu.org>
1917 Ignore LayoutItemPortals in the details view.
1919 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1922 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1923 LayoutItemPortal layout objects.
1924 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1925 LayoutItemPortal objects when retrieving the details layout.
1926 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1927 file. This is an empty class and just used to get type information for
1930 2011-07-12 Ben Konrath <ben@bagu.org>
1932 Use java-libglom 1.17.0.
1936 2011-07-11 Ben Konrath <ben@bagu.org>
1938 Remove "Table:" label from table selector.
1940 This matches a recent change in the Glom UI.
1942 * mockups/details-contacts.html:
1943 * mockups/details-projects.html:
1944 * mockups/listview-contacts.html:
1945 * mockups/listview-projects.html: Remove the "Table:" label from the
1947 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1949 2011-07-11 Ben Konrath <ben@bagu.org>
1951 Add main groups to the details view.
1953 This makes things look a little nicer in the details view. The next step
1954 is to implement the flowtable.
1956 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1957 resources from the standard gwt css theme. Standard.css is now
1958 included in OnlineGlom.html so that the online glom css rules have
1959 precedence over the gwt theme.
1960 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1961 the whole LayoutGroup to the DetailsView instead of just the titles.
1962 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1963 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1964 details layout with a helper class (GroupPanel). I might extract this
1965 class when I make the full flowtable.
1966 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1967 string as default so I don't have to worry about NPEs when processing
1969 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1970 note beside OnlineGlom.gwt.xml above).
1971 * src/main/webapp/style.css: Add default font-size to body to override
1972 the font-size set by the standard theme. Don't use h2 tags for
1973 group-title. Create new details-cell class.
1975 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1977 ConfiguredDocument: Set the port number too.
1979 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1980 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1981 Glom document. Presumably this worked sometimes so far because there is a
1982 default port number.
1984 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1986 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1988 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1989 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1990 correct, though we should throw an exception too.
1992 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1994 Fix a addDocuemnt typo.
1996 * src/main/java/org/glom/web/shared/Documents.java
1997 (Documents.addDocuemnt): Rename to addDocument().
1998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1999 (OnlineGlomServiceImpl.getDocuments): Adapt.
2001 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2003 Slightly improved log output when connection fails.
2005 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2006 (ConfiguredDocument.setUsernameAndPassword):
2007 We don't know for sure if it' the username/password that's wrong, so
2008 rephrase the message.
2009 Also ouput the exception message, though it's generic in this case.
2011 2011-07-08 Ben Konrath <ben@bagu.org>
2015 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2016 added braces to a one line if statement because the Eclipse formatter
2017 was getting confused.
2019 2011-07-07 Ben Konrath <ben@bagu.org>
2021 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2023 These should really be two separate tasks but I counldn't get things to
2024 work with GWT 2.2.0 and Eclipse 3.7.
2028 * .settings/org.eclipse.jdt.core.prefs:
2029 * .settings/org.eclipse.jdt.ui.prefs:
2030 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2031 * .settings/org.eclipse.m2e.core.prefs:
2032 Add new config files. Update current files. Remove references to the
2033 webtools plugins as we're not using any of the webtools features.
2034 * .gitignore: Add logs directory which is created when running with
2036 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2037 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2038 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2040 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2042 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2044 onlineglom.properties: Add explanatory comments.
2046 * src/main/resources/onlineglom.properties: Also change the default user
2047 from ben to someuser, to avoid the risk of people thinking we just
2048 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2050 2011-06-28 Ben Konrath <ben@bagu.org>
2052 Use filename in Log for incorrect passwords.
2054 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2055 getFileName(String) method to get the filename from the URI.
2057 2011-06-28 Ben Konrath <ben@bagu.org>
2059 Add the table name to the URL token for the ListPlace.
2061 This makes things consistent between the DetailsPlace and the
2062 ListPlace. It also allows the the ListPlace to be bookmarked.
2064 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2065 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2066 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2067 Remove getDefaultListLayout(). The default layout is now returned
2068 by the getListLayout() method when the table name is an empty string.
2069 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2070 Add table name field. Change to a new ListPlace when the table
2071 has been changed. Use getListLayout() for getting the default
2073 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2074 Add table name field. Set the correct table name in the list box
2075 when loading from bookmark. This corrects a problem for the
2077 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2078 Move table name to super-class (HasSelectableTable). Move document
2079 and table URL keys to super-class in HasSelectableTable.
2080 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2081 Add table name field. Add Tokenizer class with URL key common to
2082 the subclasses (DetailsPlace and ListPlace).
2083 * src/main/java/org/glom/web/client/place/ListPlace.java:
2084 Add table name. Add code to parse the URL token.
2085 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2086 Update ListPlace construction with empty table name string.
2087 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2088 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2089 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2090 Update ListPlace construction with table name string.
2091 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2092 Change defaultTableName field to tableName to reflect how it's now
2093 used. Update the getter and setter methods.
2095 2011-06-28 Ben Konrath <ben@bagu.org>
2097 Enable the table selector in the DetailsView.
2099 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2100 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2102 Remove getDefaultDetailsLayout(). The default layout is now returned
2103 by the getDetailsLayout() method when the table name is an empty
2105 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2106 event handler for table change event. Change to using
2107 getDetailsLayout() for the default details layout.
2108 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2110 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2111 when navigating to the details place.
2113 2011-06-27 Ben Konrath <ben@bagu.org>
2115 Use filename based unique document ID in URL and for RPC.
2117 The document ID is the glom document name with spaces (' ') replaced
2118 with pluses ('+') and without the .glom extension.
2120 This change is mostly a string substitution of 'documentTitle' for
2121 'documentID'. The only code change is the addition of a Documents DTO to get the
2122 filename to document title mappings as indicated below.
2124 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2125 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2126 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2127 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2128 Use Documents DTO to create the document links in the document
2130 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2131 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2132 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2133 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2134 * src/main/java/org/glom/web/client/place/ListPlace.java:
2135 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2136 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2137 * src/main/java/org/glom/web/client/ui/ListView.java:
2138 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2139 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2140 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2141 * src/main/java/org/glom/web/server/Log.java:
2142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2143 getDocumentTitles() to getDocuments() and return the Documents DTO.
2144 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2145 transferring the filename to document title mappings.
2147 2011-06-25 Ben Konrath <ben@bagu.org>
2149 Make the authentication popup work again.
2151 This bug was introduced when I extracted ConfiguredDocument to its own class.
2153 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2154 correct success / fail status in setUsernameAndPassword().
2156 2011-06-25 Ben Konrath <ben@bagu.org>
2158 Use filename as unique key for configuring database usernames and passwords.
2160 This replaces the use of the Glom document title which could change
2161 depending on the locale. Thanks to Murray Cumming for pointing out this
2164 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2165 * src/main/resources/onlineglom.properties:
2167 2011-06-24 Ben Konrath <ben@bagu.org>
2169 Pass primary key value to DetailsView.
2171 This enables the DetailsView to load the correct data.
2173 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2174 primary key value field and set in constructor. Pass primary key
2175 value to getDetailsData().
2176 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2177 variables for document title and primary key value.
2178 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2179 key value to the DetailsPlace.
2181 2011-06-24 Ben Konrath <ben@bagu.org>
2183 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2185 This allows the primary key to be retrieved by the Details button. This
2186 functionality has not been implemented yet but it's in the works.
2188 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2189 the LayoutGroup result to ListView.setCellTable instead of all of its
2190 fields individually.
2191 * src/main/java/org/glom/web/client/ui/ListView.java:
2192 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2193 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2194 get the primary key for the table.
2195 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2196 index of the primary key in the LayoutGroup accounting for hidden
2197 primary keys. Rename getJavaNumberFormat() to
2198 convertToJavaNumberFormat() for consistency. Cleanup / add some
2200 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2201 field for primary key index and a field to indicate whether the
2202 primary key is hidden or not.
2204 2011-06-23 Ben Konrath <ben@bagu.org>
2206 Rename getTableData methods to getListData.
2208 This is a rename refactor for consistency with other methods.
2210 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2211 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2212 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2215 2011-06-23 Ben Konrath <ben@bagu.org>
2217 Extract the ConfiguredDocument innerclass into its own class.
2219 This makes the servlet code more object oriented.
2221 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2222 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2224 new ConfiguredDocument class.
2226 2011-06-21 Ben Konrath <ben@bagu.org>
2228 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2230 This makes things more inline with how libglom works and reduces code
2231 duplication. This refactor lays the groundwork for adding the primary key to
2232 the LayoutGroup object.
2234 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2235 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2236 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2237 Change method names to getListLayout and getDefaultListLayout for
2238 consistency. Use LayoutGroup as the DTO for the list layout instead of
2239 ColumnInfo and LayoutListTable.
2240 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2241 new method names along with the LayoutGroup object for transferring the
2243 * src/main/java/org/glom/web/client/ui/ListView.java:
2244 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2245 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2246 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2248 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2249 Replaced with LayoutGroup.
2250 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2251 expectedResultSize and defaultTableName fields which are needed for
2253 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2254 type field which is needed for the list layout but will also be
2255 useful for the details layout as things progress.
2256 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2257 Make class abstract. Remove the unnecessary
2258 getFormattingHorizontalAlignment method. Add setFormatting method.
2260 2011-06-16 Ben Konrath <ben@bagu.org>
2262 Add scripts for building and installing war.
2264 These will help when updating OnlineGlom but they're also good
2265 supplemental documentation of the build and deployment proceeding.
2267 * utils/build-onlineglom-war.sh: New file.
2268 * utils/install-onlineglom-war.sh: New file.
2270 2011-06-16 Ben Konrath <ben@bagu.org>
2272 Create wrapper class to create consistent log messages.
2274 I wrapped methods in the Log class of gwt-log to add the method names
2275 from the servlet and create consistent formatting of the document title
2276 and table names in the log messages.
2278 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2279 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2280 log methods to use methods from wrapped Log class.
2282 2011-06-16 Ben Konrath <ben@bagu.org>
2284 Remove superfluous conditional return.
2286 Thanks to Murray Cumming for pointing this out!
2288 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2290 2011-06-15 Ben Konrath <ben@bagu.org>
2292 Return an ArrayList of LayoutGroups for the Details layout.
2294 This corrects a problem with the details layout as it can have more
2295 than one top level LayoutGroup.
2297 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2298 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2299 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2300 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2301 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2302 with ArrayList of LayoutGroups for the details view layout.
2303 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2304 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2305 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2306 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2307 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2308 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2310 2011-06-14 Ben Konrath <ben@bagu.org>
2312 Use cast_dynamic method to determine the libglom LayoutItem type.
2314 This is better than finding the LayoutItem type by using the string
2315 returned from the get_part_type_name() method.
2317 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2319 2011-06-14 Ben Konrath <ben@bagu.org>
2321 Add method names to log entries in the servlet.
2323 This helps when tracking down deployment problems.
2325 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2327 2011-06-14 Ben Konrath <ben@bagu.org>
2329 Add data to the DetailsView using a hard-coded primary key value.
2331 The layout and functionality of the DetailsView is not complete. This
2332 is just a checkpoint so the patch doesn't get too big.
2334 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2335 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2336 Add getDetailsData() servlet method.
2337 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2338 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2339 LayoutFields are added to the DetailsView.
2340 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2341 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2342 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2343 take the string for the title instead of the object.
2344 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2345 Add implementation getDetailsData() along with some private helper
2347 * src/main/webapp/style.css: Add padding to details-data class. Add a
2348 details-label class with the same padding as the details-data class.
2350 2011-06-03 Ben Konrath <ben@bagu.org>
2352 Use presenter.goTo() to change to the DetailsPlace.
2354 This will make things easier when we need to open the DetailsView with
2355 data specific to the row that was clicked.
2357 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2359 2011-06-02 Ben Konrath <ben@bagu.org>
2361 Add CSS file from mockups.
2363 I'm adding this now because it's going to be useful to have when
2364 developing the DetailsView. The TableSelectionView and ListView aren't
2367 * src/main/webapp/OnlineGlom.html:
2368 * src/main/webapp/style.css:
2370 2011-06-02 Ben Konrath <ben@bagu.org>
2372 Use String.isEmpty() to check for empty string.
2374 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2376 2011-06-02 Ben Konrath <ben@bagu.org>
2378 Display main layout group titles in the DetailsView.
2380 This is the start of the DetailsActivity/DetailsView implementation.
2382 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2383 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2384 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2385 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2386 Get the layout information for the details view from the server and set
2387 the main layout group titles.
2388 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2389 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2390 Add addLayoutGroup() and addLayoutField() methods. This are just
2391 temporary methods for creating the the details view that will change
2393 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2394 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2396 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2397 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2398 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2399 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2400 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2401 Data Transfer Objects that mimic the libglom object structure. These are
2402 used for transferring the details layout but could also be used for
2403 transferring the list layout.
2405 2011-05-27 Ben Konrath <ben@bagu.org>
2407 Reset the AuthenticationPopup when clearing the ListView.
2409 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2411 2011-05-27 Ben Konrath <ben@bagu.org>
2413 Fix problem with onlineglom.properties file loading.
2415 The old way worked in Eclipse but not on the server. Loading the
2416 onlineglom.properties file now works in Eclipse and on the server.
2418 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2420 2011-05-24 Ben Konrath <ben@bagu.org>
2422 Update gwt-log from 3.1.0 to 3.1.2.
2424 Gwt-log 3.1.0 has been marked as depreciated.
2428 2011-05-24 Ben Konrath <ben@bagu.org>
2430 Add comment to ListActivity.goTo() method.
2432 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2434 2011-05-24 Ben Konrath <ben@bagu.org>
2436 Remove FIXME in convertGdkColorToHtmlColour()
2438 The Gdk::Color value returned by libglom is 16-bits per channel on both
2439 64 and 32-bit platforms.
2441 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2443 2011-05-19 Ben Konrath <ben@bagu.org>
2445 Improve performance of initial ListView load.
2447 I removed a round trip to the server for getting the default table name
2448 and then requesting information about that table. This also removes a potential
2449 problem with the table change handler not being setup in time to receive the
2450 table change event from the ListActivity.
2452 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2453 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2454 getDefaultLayoutListTable() method. Improve comments.
2455 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2456 getDefaultLayoutListTable() method instead of firing a table change
2457 event to get the table to load.
2458 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2459 implementation of getDefaultLayoutListTable() method.
2460 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2463 2011-05-19 Ben Konrath <ben@bagu.org>
2465 Override toDebugString() in TableChangeEvent.
2467 This is useful to have for debugging.
2469 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2471 2011-05-19 Ben Konrath <ben@bagu.org>
2473 Add a "Back to List" link when at the DetailsPlace.
2475 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2476 Populate the CellTable based on the selected table of the ListBox if
2477 it's set otherwise use the default table. This allows the "Back to
2479 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2480 Remove Place from constructors. Add a setPlace() method. Add
2481 goToPlace() method. Set class as presenter for TableSelectionView.
2482 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2483 Use the same TableSelectionActivity when switching between the List and
2485 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2486 Subclass the new HasSelectableTablePlace. This removes some duplicate
2488 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2489 New class to represent Places that display the TableSelectionView.
2490 * src/main/java/org/glom/web/client/place/ListPlace.java:
2491 Subclass the new HasSelectableTablePlace. This removes some duplicate
2493 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2494 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2495 Add Presenter interface. Add setBackLinkVisible() method. Add
2496 setBackLink() method.
2498 2011-05-18 Ben Konrath <ben@bagu.org>
2500 Enable the "Details" buttons.
2502 Right now only an empty details view is displayed.
2504 * src/main/java/org/glom/web/client/ClientFactory.java:
2505 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2506 Add DetailsView to ClientFactory.
2507 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2508 A basic activity for the details view.
2509 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2510 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2512 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2513 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2515 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2516 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2517 unnecessary super() in constructor.
2518 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2519 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2520 really shouldn't create a new TableSelectionActivity for both the ListPlace
2521 and the DetailsPlace so this should be considered a temporary solution.
2522 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2523 New file. Represents a URL for the details view.
2524 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2525 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2526 A basic details view interface and implementation.
2527 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2528 Enable the "Details" buttons.
2530 2011-05-12 Ben Konrath <ben@bagu.org>
2532 Use a LayoutPanel with multiple display areas for main layout.
2534 This is mostly a refactor in that there are no changes from the user
2535 point of view. These changes are required so that we can swap out the list view
2536 with the details view when the user clicks the "Details" button.
2538 * src/main/java/org/glom/web/client/ClientFactory.java:
2539 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2540 OnlineGlomView. Add TableSelectionView, ListView and
2541 AuthenticationPopup.
2542 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2543 for main layout. Add display regions for main activities. Add
2544 activity manager for for main activities.
2545 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2546 file from parts of the deleted OnlineGlomActivity.
2547 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2548 New file from parts of the deleted OnlineGlomActivity.
2549 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2550 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2551 New files for app wide table change event.
2552 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2553 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2554 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2555 Activity mappers for the main activities replace the deleted app-wide
2557 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2558 Fix a spelling error in he comment.
2559 * src/main/java/org/glom/web/client/ui/ListView.java:
2560 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2561 Renamed from LayoutListView and modified for MVP. This still not a
2562 proper dumb view as prescribed by the MVP pattern but it works for now.
2563 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2564 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2565 New widget stripped out of the deleted OnlineGlomView.
2566 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2567 Remove hack that is fixed by this patch.
2569 2011-05-06 Ben Konrath <ben@bagu.org>
2571 Rename OnlineGlomPlace to ListPlace.
2573 The only change besides the rename is that url will now display #list
2574 instead of #Document.
2576 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2577 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2578 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2579 * src/main/java/org/glom/web/client/place/ListPlace.java:
2580 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2582 2011-05-06 Ben Konrath <ben@bagu.org>
2584 Use Presenter for app navigation.
2586 This is the proper way to deal with Place (URL) changes with the MVP
2589 * src/main/java/org/glom/web/client/ClientFactory.java:
2590 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2591 PlaceHistoryMapper and PlaceHistoryHandler.
2592 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2593 PlaceHistoryMapper and PlaceHistoryHandler.
2594 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2595 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2596 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2597 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2598 Add Presenter interface and setPresenter methods. Rename addHyperLink
2599 to addDocumentLink taking only the document title as a parameter.
2601 2011-04-14 Ben Konrath <ben@bagu.org>
2603 Prompt for db username/password if they haven't been set.
2605 This is implemented with a popup widget that is contained within the
2606 OnlineGlomView and managed by the OnlineGlomActivity.
2608 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2609 methods for checking and setting the database username and password.
2610 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2611 new methods for checking and setting the database username and
2613 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2614 Display authentication popup if the JDBC connection to the database
2615 has not been authenticated.
2616 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2618 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2619 for dealing with the authentication popup.
2620 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2621 Implement the methods for dealing with the authentication popup.
2622 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2623 try to executed queries if the database connection hasn't been
2624 authenticated. Implement methods for checking and setting the
2625 database username and password.
2627 2011-04-12 Ben Konrath <ben@bagu.org>
2629 Make log messages a little clearer.
2631 Add a dash betweeen the document title and the table name.
2633 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2635 2011-04-12 Ben Konrath <ben@bagu.org>
2637 Protect against NPEs when cleaning up database resources.
2639 While this isn't strictly necessary because the exception is caught,
2640 not protecting against the NPEs makes it harder to find the real error
2643 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2645 2011-04-12 Ben Konrath <ben@bagu.org>
2647 Move configuration of the servlet to the constructor.
2649 The servlet will be initialized even if the database authentication
2650 information is not set or correct. I still need to add the UI for prompting
2651 the user for the authentication information when it's required.
2653 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2654 javadocs for getDocumentTitles() method.
2655 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2656 Set error message when RPC fails.
2657 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2658 glom files directory from the configuration file. Try to set the
2659 database authentication information for the specific document if it's
2660 set and works otherwise try to use the global authentication
2661 information set for the directory.
2662 * src/main/resources/onlineglom.properties: Moved from
2663 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2664 Added detailed comments for the new keys.
2666 2011-04-11 Ben Konrath <ben@bagu.org>
2668 Remove unnecessary @Override in DocumentSelectionViewImpl.
2670 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2672 2011-04-11 Ben Konrath <ben@bagu.org>
2674 Remove center alignment in DocumentSelectionView.
2676 The title element is still centred but the document titles and bottom
2677 sentence are both left-aligned.
2679 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2681 2011-04-11 Ben Konrath <ben@bagu.org>
2683 Change 'Demo' naming convention to 'Document'.
2685 This is just a rename refactor with no functional changes to the code.
2687 * src/main/java/org/glom/web/client/ClientFactory.java:
2688 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2689 * src/main/java/org/glom/web/client/OnlineGlom.java:
2690 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2691 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2692 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2693 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2694 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2695 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2696 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2697 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2698 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2701 2011-04-08 Ben Konrath <ben@bagu.org>
2703 Remove FIXME from safeLongToInt() method.
2705 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2708 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2710 2011-04-08 Ben Konrath <ben@bagu.org>
2712 Display an error if no glom documents are found in the specified directory.
2714 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2715 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2716 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2717 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2719 2011-04-08 Ben Konrath <ben@bagu.org>
2721 Add copyright header to one more file ... oops.
2723 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2725 2011-04-08 Ben Konrath <ben@bagu.org>
2727 Add copyright header to files without it.
2729 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2730 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2731 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2732 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2733 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2734 * src/main/java/org/glom/web/shared/GlomField.java:
2736 2011-04-08 Ben Konrath <ben@bagu.org>
2738 Add support for accessing multiple glom documents in the servlet.
2740 This completes the demo selection functionality.
2742 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2743 document title to methods.
2744 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2745 document title to methods.
2746 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2747 Set browser window title when the activity starts. Correct name of
2748 document title variable.
2749 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2750 Set browser window title when the activity starts. Set the table
2751 selector change handler after table selector has been set. Clear the
2752 OnlineGlomView when the activity has been stopped.
2753 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2754 document title as the place token. Use "#Document:" instead of
2755 "#OnlineGlomPlace:" in the URL.
2756 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2757 Change heading to "Online Glom"
2758 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2759 document title in RPC methods.
2760 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2761 setDocumentTitle() method. Add clear() method.
2762 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2763 setDocumentTitle() method. Implement clear() method which removes the
2764 change handler on the ListBox, clears the ListBox and clears the
2766 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2767 Implement methods with document title. Keep track for the configured
2768 glom documents and their corresponding JDBC configurations in a hash
2769 table. This information is retrieved using the document title as the
2770 key in the hash table.
2771 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2772 document title field as it's no longer needed.
2774 2011-04-08 Ben Konrath <ben@bagu.org>
2776 Update the Eclipse JDT configuration.
2778 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2779 methods. Automatically add the copyright header to new files.
2781 2011-04-05 Ben Konrath <ben@bagu.org>
2783 Add new page for demo selection.
2785 This patch adds all the components required to view and start an
2786 OnlineGlom demo by clicking on the desired hyperlink. The user is
2787 able to return to the demo selection page with the browser's back
2788 button. I still need to modify the servlet to work with multiple
2789 documents so all demo links will load the file defined in the
2790 OnlineGlom.properties.
2792 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2793 This is only useful during development so we don't need to save it.
2794 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2795 get a reference to the DemoSelectionView.
2796 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2797 method to get a reference to the DemoSelectionView.
2798 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2799 default view to DemoSelectionView.
2800 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2801 to get glom document titles for glom files in a hard-coded directory.
2802 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2803 method to get glom document titles for glom files in a hard-coded
2805 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2806 Presenter for DemoSelectionView.
2807 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2808 for DemoSelectionView.
2809 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2810 Update for DemoSelectionView.
2811 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2812 Basic 'Place' implementation for the DemoSelectionView.
2813 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2814 The interface for the DemoSelectionView.
2815 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2816 The implementation of the DemoSelectionView.
2817 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2818 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2819 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2820 implementation of method to get glom document titles for glom files
2821 in a hard-coded directory.
2822 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2823 on longer being used.
2824 * src/main/webapp/glom.png: Glom logo.
2826 2011-04-05 Ben Konrath <ben@bagu.org>
2828 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2830 This is the forth and final commit of a refactor that will allow
2831 OnlineGlom to be used with multiple documents.
2833 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2834 Move RPC code from OnlineGlomViewImpl to this class.
2835 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2837 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2838 RPC code to the presenter class (the P in MVP).
2840 2011-04-04 Ben Konrath <ben@bagu.org>
2842 Start moving the existing OnlineGlom code to MVP.
2844 This work is based on the GWT MVP framework that is documented here:
2846 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2848 This is the third commit of a refactor that will allow OnlineGlom to
2849 be used with multiple documents.
2851 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2852 Interface for client factory which is used to get instances of various
2853 classes throughout the app.
2854 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2855 Implementation of client factory.
2856 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2857 initialize the MVP framework.
2858 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2859 New file. Activity manager for the main container widget. This is the
2861 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2862 Maps place (URL) to its corresponding activity.
2863 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2864 New file. This is just a place holder for a generated file.
2865 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2866 New file. Represents the URL for the main Online Glom app.
2867 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2868 for changes in LayoutListViewImpl.
2869 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2870 interface for View. Move code to OnlineGlomViewImpl class.
2871 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2872 file. Implementation of OnlineGlomView.
2873 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2874 Place resources. Use ClientFactoryImpl by default.
2876 2011-04-04 Ben Konrath <ben@bagu.org>
2878 Move View classes to their own package.
2880 This is the second commit of a refactor that will allow OnlineGlom to
2881 be used with multiple documents.
2883 * src/main/java/org/glom/web/client/OnlineGlom.java:
2884 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2885 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2887 2011-04-02 Ben Konrath <ben@bagu.org>
2889 Move UI code from the main module to its own class.
2891 This is the first commit of a refactor that will allow OnlineGlom to be
2892 used with multiple documents.
2894 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2895 references to OnlineGlom to OnlineGlomView.
2896 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2897 OnlineGlomView and instantiate it here.
2898 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2899 represents the main OnlineGlomView with one document.
2901 2011-04-01 Ben Konrath <ben@bagu.org>
2903 Fix formatting of gwt.xml and add DTD.
2905 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2907 2011-03-30 Ben Konrath <ben@bagu.org>
2909 Propperly convert gdkColor string to html colour string.
2911 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2913 2011-03-28 Ben Konrath <ben@bagu.org>
2915 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2917 This implementation matches
2918 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2919 readable and is not tied to Swig.
2921 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2923 2011-03-28 Ben Konrath <ben@bagu.org>
2925 Use read-only checkboxes for boolean field types.
2927 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2928 in the CellTable based on the field type. It currently only
2929 distinguishes between boolean and text columns but I'll need to add
2930 support for more types.
2931 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2932 column type in the ColumnInfo object. Add method to convert between the
2933 glom field type enum in ColumnInfo and the glom field type in libglom.
2934 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2936 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2937 getting and setting booleans.
2939 2011-03-25 Ben Konrath <ben@bagu.org>
2941 Don't get the Date twice from the ResultSet.
2943 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2945 2011-03-25 Ben Konrath <ben@bagu.org>
2947 Cleanup code in the servlet.
2949 * TODO: Remove item about row count. Add item about testing row count
2950 query with large number of rows.
2951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2952 spelling mistakes, change method parameter to be consistent with
2955 2011-03-25 Ben Konrath <ben@bagu.org>
2957 Add server side logging with the gwt-log library.
2959 * .gitignore: Ignore the log file we're now producing.
2960 * TODO: Add a couple TODO item for logging.
2961 * pom.xml: Add gwt-log and log4j as a dependency.
2962 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2963 logging of errors, warnings and some important info.
2964 * src/main/resources/log4j.properties: New file to configure log4j.
2966 2011-03-24 Ben Konrath <ben@bagu.org>
2968 Add a disable button for the Details view.
2970 * src/main/java/org/glom/web/client/LayoutListView.java:
2972 2011-03-22 Ben Konrath <ben@bagu.org>
2974 Use a count query to get the number of rows for the list view pager.
2976 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2978 2011-03-22 Ben Konrath <ben@bagu.org>
2980 Add more TODO information about CellTable pager positioning.
2984 2011-03-19 Ben Konrath <ben@bagu.org>
2986 Add TODO item about CellTable pager positioning.
2990 2011-03-18 Ben Konrath <ben@bagu.org>
2992 Remove unneeded GlomFieldColumn class.
2994 This is just a small code cleanup.
2996 * src/main/java/org/glom/web/client/LayoutListView.java:
2998 2011-03-18 Ben Konrath <ben@bagu.org>
3000 Use cursor mode in the query that gets data for the list view.
3002 I still need to fix the potential memory problem when getting the row
3003 count for the list view.
3005 * TODO: Add note about testing memory usage with large data sets. Add
3006 item about fixing row counting with large data sets.
3007 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
3008 PostgreSQL JDBC driver into cursor mode when getting data for the
3011 2011-03-15 Ben Konrath <ben@bagu.org>
3013 Remove the GWT Container from the Eclipse build classpath.
3015 The GWT dependencies are set by Maven so this isn't needed.
3019 2011-03-15 Murray Cumming <murrayc@murrayc.com>
3021 Added some earlier mockups to git, but not to the tarball dist.
3023 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
3024 Openismus. These hopefully show how we might structure the HTML so that
3025 it can be styled easily with CSS. However, we probably need to adapt them
3026 for the CSS structure that GWT dictates for common widgets.
3028 2011-03-14 Ben Konrath <ben@bagu.org>
3030 Locate OnlineGlom.properties using the ServletContext.
3032 This is required to be able to locate the file in the deployed servlet.
3034 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3035 Configure the database and glom document in in a helper method so
3036 that the ServletContext can be used to locate OnlineGlom.properties.
3037 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
3038 src/main/webapp. This is the proper location for .properites files.
3040 2011-03-12 Ben Konrath <ben@bagu.org>
3042 Add note to README about why we're compiling down to obfuscated JavaScript.
3046 2011-03-11 Ben Konrath <ben@bagu.org>
3048 Use properties file to configure servlet.
3050 This allows people to change the glom file path, db username and db
3051 password without recompiling the code.
3053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3054 * src/main/webapp/OnlineGlom.properties:
3056 2011-03-11 Ben Konrath <ben@bagu.org>
3058 Use table fields in layout list view if the layout list is not defined.
3060 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3061 Manually create a LayoutFieldVector for the query builder using the
3062 table fields when a layout list is not defined in the glom file.
3064 2011-03-11 Ben Konrath <ben@bagu.org>
3066 Only show FIXME string for images when there's an image.
3068 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
3069 in this change are some small code cleanups.
3071 2011-03-11 Ben Konrath <ben@bagu.org>
3073 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
3075 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3077 2011-03-11 Ben Konrath <ben@bagu.org>
3079 Correctly set the index of the default table.
3081 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3082 Correctly set the index of the default table. Add commented out example
3085 2011-03-10 Ben Konrath <ben@bagu.org>
3087 Add comment to pom.xml about the previous change.
3089 * pom.xml: Add comment about the deployment issue so that it's obvious
3090 why java-libglom is set to the provided scope.
3092 2011-03-10 Ben Konrath <ben@bagu.org>
3094 Change java-libglom dependency from compile to provided in pom.xml.
3096 Since java-libglom uses jni it can only be loaded once and therefore
3097 must be placed in $CATALINA_HOME/lib and not included in each war.
3098 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
3099 More information about this issue can be found in the Tomcat 6 release
3100 notes in the "JNI Based Applications" section:
3102 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
3104 * README: Remove note about this issue. Deployment info should really
3105 be on the wiki anyway so I'll add it right now.
3106 * pom.xml: Change java-libglom dependency from compile to provided so
3107 that it's copied in to the packaged war.
3109 2011-03-09 Ben Konrath <ben@bagu.org>
3111 Change to using a neutral locale for currency, date and time formatting.
3113 This solves the problem of currency values being represented without a
3114 space between the currency code and the number (e.g. "EUR5.89" is now
3115 represented as "EUR 5.89"). More work is required when we implement
3116 a locale preference setting.
3118 * TODO: Add note about currency formatting issues with different
3120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3121 to using the neutral ROOT locale.
3123 2011-03-09 Ben Konrath <ben@bagu.org>
3125 Add support for currency codes that are not ISO 4217 codes.
3127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3128 the currency code defined in the glom file when it's not 3 characters
3129 long or when Java doesn't recognize the string as an ISO 4217 code.
3131 2011-03-08 Ben Konrath <ben@bagu.org>
3133 Remove test classes, launch configurations and configuration.
3135 The test stuff was getting in the way when creating the war. To make
3136 the war file you can now do 'mvn clean package'. The packaged war file
3137 will be in the target directory.
3139 * .classpath: Remove unused classpathentry for tests and i18n.
3140 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
3141 property. Don't run test or i18n goals when packaging the war.
3142 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
3147 * OnlineGlomTest-dev.launch:
3148 * OnlineGlomTest-prod.launch:
3149 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
3150 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
3152 2011-03-07 Ben Konrath <ben@bagu.org>
3154 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
3156 These fixes allow me to use 'mvn deploy' to create the war file.
3158 * .classpath: This generated config has been updated by Eclipse. This
3159 change was probably triggered by me updating from Eclipse 3.6.1 to
3161 * .gitignore: Add entry to ignore the directory
3162 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
3163 * .project: The generated config has been updated by Eclipse. This
3164 change was probably triggered by me updating from Eclipse 3.6.1 to
3166 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3167 so that Eclipse doesn't complain
3168 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3169 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3170 'tests' directory to 'client' directory. This is the new
3171 gwt-maven-plugin convension.
3172 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3173 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3175 2011-03-07 Ben Konrath <ben@bagu.org>
3177 Add support for horizontal alignment in the LayoutList columns.
3179 * TODO: Remove item about horizontal alignment. Add item about
3180 improvements to ColumnInfo.
3181 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3182 alignment on the columns. Use ColumnInfo RPC object get the column
3183 title and horizontal alignment.
3184 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3185 LayoutListView creation with ColumnInfo RPC object.
3186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3187 a ColumnInfo object for every LayoutList columnn. Convert the
3188 FieldFormatting.HorizontalAlignment to the correct
3189 ColumnnInfo.HorizontatlAlignment with the new
3190 getColumnInfoHorizontalAlignment helper method.
3191 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3192 to encapsulate column information like alignment and title. This
3193 could be used to set the colour instead of on a per cell field basis.
3194 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3195 column title storage and retrieval with ColumnInfo.
3197 2011-03-04 Ben Konrath <ben@bagu.org>
3199 Add support for column sorting.
3201 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3202 AsynDataProvider to be an anonymous inner class. Use new
3203 getSortedTableData RPC method when column sort is requested. Set all
3204 columns sortable and add an AsyncHandler to activate sorting in the
3206 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3207 method getSortedTableData(). Cleanup other method signatures.
3208 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3209 new method getSortedTableData(). Cleanup other method signatures.
3210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3211 Implement getSortedTableData() and getTableData() methods by using a
3212 private helper method with the appropriate parameters filled in. Use
3213 user supplied sort clause when supplied, otherwise fall back to
3214 sorting by the primary key. Move destroy() method to be underneath
3215 constructor for readability. Cleanup comments.
3217 2011-03-03 Ben Konrath <ben@bagu.org>
3219 Add support for colour text and colour backgrounds to the layout list cells.
3221 Only the cell backgrounds are coloured which leaves a gap between the
3222 cells that isn't coloured. I need to figure out a way to set
3223 'style=background-colour:' on the whole column rather than just the
3226 * TODO: Add a note about colouring the background of the whole column.
3227 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3228 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3229 render the coloured text and backgrounds. Use GlomField[] for the row type.
3230 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3232 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3233 GlomField[] for the row type.
3234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3235 GlomField[] for the row type. Set the text, text colour and background
3236 colour in the GlomField objects as specified i