1 2012-01-18 Murray Cumming <murrayc@murrayc.com>
3 locales drop-down: Change the tables list when this changes.
5 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
6 .java: TableSelectionActivity.start(): Move the async table titles
7 retrieval into a private fillView() method and also call this when
8 the chosen locale changes.
9 Note that the document title is not actually translatable yet, but
10 that is a problem that I should fix soon in libglom.
12 2012-01-18 Murray Cumming <murrayc@murrayc.com>
14 Improve the placement of the locales drop-down.
16 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
17 Put the title and locales drop-down in a div (gwt.FlowTable).
18 * src/main/webapp/style.css: Add magic css properties to make this work.
19 Also remove the left margin from the title so that it lines up with the
22 2012-01-18 Murray Cumming <murrayc@murrayc.com>
24 locales selector: Show human-readable locale titles.
26 * src/main/java/org/glom/web/server/ConfiguredDocument.java
27 getDocumentInfo(): Use java.util.Locale to show a real title of
28 each locale, in the locale's own language.
30 2012-01-17 Murray Cumming <murrayc@murrayc.com>
32 Add a language/locale selector drop-down.
34 * src/main/java/org/glom/web/shared/DocumentInfo.java:
35 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
36 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
37 getDocumentInfo(): Store the available Locales in the DocumentInfo.
38 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
39 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
40 Add a ListBox to show the available locales. Add getLocaleSelector(),
41 setLocaleList(), getSelectedLocale(), setSelectedLocale().
42 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
43 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
44 java: Add these classes.
45 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
46 start(): Fill the locales ListBox. Handle its change event, firing a
48 setPlace(): Show the selected locale as specified by the URL token.
49 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
50 * src/main/java/org/glom/web/client/activity/ListActivity.java:
51 Handle LocaleChangeEvent, going to a new *Place with that locale.
53 The placement of the ListBox is not pretty, and it currently uses the ID
54 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
58 2012-01-17 Murray Cumming <murrayc@murrayc.com>
60 Search box: Show the search text from the URL token.
62 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
63 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
64 Add setQuickFindText().
65 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
66 .java: setPlace(): Store the queryText if the place is a ListPlace,
67 and call TableSelectionView.setQuickFindText().
69 2012-01-17 Murray Cumming <murrayc@murrayc.com>
71 Allow use of translations via, for instance, &lang=de in the URL.
73 * pom.xml: Use the unstable java-libglom 1.21 version.
75 * src/main/java/org/glom/web/client/OnlineGlomService.java:
76 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
77 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
78 init(): Instead of calling TranslatableItem.set_current_locale()
79 (now removed), call ConfiguredDocument.setDefaultLocaleID().
80 However, this is only for default locales, which are not needed to
81 change the locale in the URL.
82 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
83 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
84 getSortedRelatedListData(): Add a localeID parameter, so we can get the
85 layout for a particular locale.
86 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
87 Add get/setDefaultLocaleID().
88 getDocumentInfo(), getListViewData(), getRelatedListData(),
89 getDetailsLayoutGroup(), getListViewLayoutGroup(),
90 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
91 localeID parameter, so we can get the layout for a particular locale.
93 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
94 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
95 * src/main/java/org/glom/web/client/place/ListPlace.java:
96 Parse and construct a lang parameter too.
98 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
99 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
100 passed to subsequent methods and constructors.
101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
102 * src/main/java/org/glom/web/client/activity/ListActivity.java:
103 Store the localeID from the *Place and pass it to other constructors
104 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
106 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
107 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
108 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
109 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
110 * src/main/java/org/glom/web/client/ui/ListView.java:
111 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
112 Take localeID parameters and pass them to subsequent constructors and
113 methods, so that the layout is always retrieved for that locale.
115 This is rather repetitive.
117 Note that "" means the original (default) locale of the Glom document,
118 which is usually English.
120 2012-01-17 Murray Cumming <murrayc@murrayc.com>
122 Documents: Remove final keyword to fix startup configuration.
124 * src/main/java/org/glom/web/shared/Documents.java: Remove the
125 final keywords on the private member variables because that breaks
126 the startup, apparently (there are warnings) because it stops them
127 from being serialized. I added these in the previous commit.
129 2012-01-13 Murray Cumming <murrayc@murrayc.com>
131 Documents: Add some final keywords.
133 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
136 2012-01-13 Murray Cumming <murrayc@murrayc.com>
138 OnlineGlomServiceImpl: Add to overview comments.
140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
141 Note that this is where all the document are loaded. They are not
142 loaded freshly for each page.
144 2012-01-12 Murray Cumming <murrayc@murrayc.com>
148 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
149 Add a TextBox for the text of a quick find.
150 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
152 setBackLink(): Add a String quickFind parameter.
153 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
154 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
155 to the base interface, because that is how TableSelectionViewImpl is used.
156 * src/main/webapp/style.css: Add style for the search box and its label.
158 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
159 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
160 Add these files, based on the existing TableChangeEvent and
161 TableChangeEventHandlers.
162 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
163 start(): Handle QuickFindChangeEvent, passing its quickFind text to
164 a ListPlace() that the user should be taken to.
165 * src/main/java/org/glom/web/client/activity/ListActivity.java
166 start(): Handle it here too and adapt the TableChangeEvent handler to
167 pass the extra "" quickFind parameter to ListPlace.
168 * src/main/java/org/glom/web/client/place/ListPlace.java:
169 Constructor: Take an extra String quickFind parameter and store it,
170 returning it from a new getQuickFind() method.
171 getToken(): Put the quickFind text in the URL token.
172 getPlace(): Parse the quickFind text from the URL token.
173 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
174 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
175 ListPlace constructor.
176 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
177 .java: start(): Add a Change handler for the TableSelectionView's
178 TextBox (via its base HasChangeHandlers interface), firing the new
179 QuickFindChangeEvent.
180 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
181 pass the extra "" quickFind parameter.
183 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
184 setCellTable(): Add a String quickFind parameter and pass it to
185 the ListViewTable() constructor.
186 * src/main/java/org/glom/web/client/ui/ListView.java: Change
187 setCellTable() in the base interface, because that is how ListViewImpl
190 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
191 Add a String quickFind member variable.
192 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
193 Constructor: Add a String quickFind parameter, storing it in the
194 base ListTable's member variable.
195 onRangeChanged(): Pass quickFind to the
196 OnlineGlomServiceAsync.getSortedListViewData() and
197 OnlineGlomServiceAsync.getListViewData() methods.
199 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
200 getListViewData(), getSortedListViewData(): Add a String quickFind
201 parameter, passing it to ConfiguredDocument.getListViewData().
202 * src/main/java/org/glom/web/client/OnlineGlomService.java:
203 Change getListViewData(), getSortedListViewData() in the base interface,
204 because that is how OnlineGlomServiceImpl is used, via this:
205 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
206 Change getListViewData(), getSortedListViewData() here too.
207 This class can apparently be used to asynchronously call methods on
208 OnlineGlomService, and GWT seems to implement that after recognizing
209 just the *Async name convention and the extra AsyncCallback parameters.
211 * src/main/java/org/glom/web/server/ConfiguredDocument.java
212 getListViewData(): Add a String quickFind parameter, and pass it to
213 ListViewDBAccess.getData().
214 * src/main/java/org/glom/web/server/database/ListDBAccess.java
215 getListData(): Add a String quickFind parameter and pass it to
217 getSelectQuery(): Add a String quickFind parameter.
218 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
219 getSelectQuery(): Add a String quickFind parameter and use it with
220 Glom.get_find_where_clause_quick() to pass a where_clause to
221 Glom.build_sql_select_with_where_clause(), to actually filter the
223 getData(): Add a String quickFind parameter, passing it to getListData().
224 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
225 va: getData(): Pass an empty string to getListData() for the
228 2012-01-12 Murray Cumming <murrayc@murrayc.com>
230 ListTable: Minor change.
232 * src/main/java/org/glom/web/client/ui/list/ListTable.java
233 createCellTable(): Make this protected instead of public.
235 2012-01-12 Murray Cumming <murrayc@murrayc.com>
237 Many files: Use final for the parameters and use the @override attribute.
239 2012-01-22 Ben Konrath <ben@bagu.org>
241 Add anchor links for single line text that starts with http, ftp and www.
245 2012-01-22 Ben Konrath <ben@bagu.org>
247 Add ellipsis to single line text in details view.
251 2012-01-04 Murray Cumming <murrayc@murrayc.com>
253 Remove all javadoc author tags.
255 Because they are awkward and meaningless when many people touch
257 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
259 2012-01-04 Murray Cumming <murrayc@murrayc.com>
261 Revert the COPYING.LESSER to COPYING rename.
263 Apparently both should be there if it is LGPL.
265 2012-01-03 Murray Cumming <murrayc@murrayc.com>
267 *View: Remove unused imports.
269 * src/main/java/org/glom/web/client/ui/DetailsView.java:
270 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
271 * src/main/java/org/glom/web/client/ui/ListView.java:
272 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
273 Remove unused imports, as suggested by Eclipse.
275 2012-01-02 Murray Cumming <murrayc@murrayc.com>
277 Move the *View::Presenter types, and some API into one base View.
279 * src/main/java/org/glom/web/client/ui/DetailsView.java:
280 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
281 * src/main/java/org/glom/web/client/ui/ListView.java:
282 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
283 Presenter, setPresenter() and clear() into a shared base interface,
284 to avoid the unnecessary duplicate Presenter types and to more clearly
285 show how the *Views share the same structure, even if they are not
286 used polymorphically.
288 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
289 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
291 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
292 * src/main/java/org/glom/web/client/activity/ListActivity.java:
293 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
295 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
298 Feel free to revert this if there is a good reason for the duplicate
301 2012-01-02 Murray Cumming <murrayc@murrayc.com>
303 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
305 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
306 a class member instead of a local variable in the method.
307 This lets us use it to get the view instances, for use in tests.
308 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
309 beforeOnlineGlom(): Test some more details of the initial view.
310 Again, this is not very useful.
312 To really test gwt-glom we will need to start a local postgresql
313 instance with local data, like the Glom tests in C++.
315 2012-01-02 Murray Cumming <murrayc@murrayc.com>
317 pom.xml: Mention the LGPL license.
319 * pom.xml: Add a licenses section.
320 * COPYING.LESSER: Move this to COPYING, which
321 previously contained the GPL. But gwt-glom is all LGPL.
323 2012-01-02 Murray Cumming <murrayc@murrayc.com>
325 Add project information to README and pom.xml.
327 * README: Add a brief description and mention some mvn
329 * pom.xml: This extra information shows up in mvn site
332 2011-01-02 Murray Cumming <murrayc@murrayc.com>
334 Use the latest java-libglom version.
336 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
338 2012-01-01 Murray Cumming <murrayc@murrayc.com>
340 GwtTestOnlineGlom: Test a little more.
342 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
343 protected rather than private, as suggested by the gwt-test-utils
345 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
346 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
347 Test the initial visibility of the panels.
349 However, this is not a very useful test.
350 And I wonder how we should generally test using this idea for an
351 activity/places app like ours where the real changes happen implicitly
352 based on the history token/URL.
354 2012-01-01 Murray Cumming <murrayc@murrayc.com>
356 Slight modification to *Mapper comments.
358 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
360 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
362 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
364 Remove comments mentioning GIN because they are just copied from
365 the example code and are apparently not helpful:
366 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
367 Also change the mention of a class that is only in the example code.
369 2012-01-01 Murray Cumming <murrayc@murrayc.com>
371 GwtTestOnlineGlom test: Minor changes.
373 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
374 Avoid the long qualified class name and modify the comment
375 because it is now obvious to me that the mocked class is the only
376 custom one created via GWT.create().
378 2012-01-01 Murray Cumming <murrayc@murrayc.com>
380 Tests: Added the beginnings of a test using gwt-test-utils.
382 * pom.xml: Add dependencies on gwt-test-utils and easymock.
383 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
384 which tells gwt-test-utils what class will be tested.
385 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
386 Add a simple (but empty) test case. One class, used by the OnlineGlom
387 class, is mocked so that it can be created. However, I am not sure
388 why only this class needs to be mocked.
390 Note that mockito seems more popular, and clearer, than easymock,
391 but I have not got that working yet. It might be a matter of the
394 This test is run during mvn integration-test.
396 2011-12-31 Murray Cumming <murrayc@murrayc.com>
398 Tests: Use junit4-style syntax instead of junit3-style.
400 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
401 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
402 * src/test/java/org/glom/web/shared/DataItemTest.java:
403 Use the @Test annotation rather than relying on the test*() prefix.
404 Also no longer implement TestCase, to avoid triggering support for
405 the junit3-way, which stops the annotations from working.
406 Change the imports from import junit.framework.* to
407 import org.junit.*, which is apparently the new way.
409 2011-12-31 Murray Cumming <murrayc@murrayc.com>
411 Added a test for ListPlace token parsing and creation.
413 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
414 This is much the same as DetailsPlaceTest.
416 I wonder how we could test the other parts of the *Place API.
418 2011-12-30 Murray Cumming <murrayc@murrayc.com>
420 DetailsPlace test: Also test getToken() and recreation via getPlace().
422 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
423 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
424 recreate it, testing the recreated DetailsPlace for the same parameter
427 2011-12-30 Murray Cumming <murrayc@murrayc.com>
429 Use the surefire-report plugin.
431 * pom.xml: This generates a HTML report about the tests in
432 target/site/surefire-report.html
433 when you do mvn surefire-report:report. It seems to be popular/normal.
435 2011-12-30 Murray Cumming <murrayc@murrayc.com>
437 Added a test for DetailsPlace.
439 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
440 Test the getPlace() token parsing.
442 2011-12-30 Murray Cumming <murrayc@murrayc.com>
444 Added a first unit test.
446 * pom.xml: Add a test goal, and a dependency on junit in that scope.
447 * src/test/java/org/glom/web/shared/DataItemTest.java:
448 This is a silly test but it is just to get things started. Note that
449 maven/junit finds the test because it looks in src/test by default.
451 2011-12-22 Ben Konrath <ben@bagu.org>
453 Change charsetName to "UTF-8" when replacing line breaks.
455 JavaScript requires the charsetName to be "UTF-8". CharsetName values
456 that work in Java (such as "UTF8") will not work when compiled to
459 This fixes a problem with multi-line details view fields that have hard
460 line breaks. The "License Text" field on this page demonstrates the
463 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
465 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
467 2011-12-22 Ben Konrath <ben@bagu.org>
469 Fix another bug with related list navigation.
471 I've tested all the navigation buttons in all of the related lists
472 so things should be good now.
474 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
476 2011-12-22 Ben Konrath <ben@bagu.org>
478 Fix a crasher when refreshing the list view with the default table.
480 This crash will also happen when loading the list view with the default
481 table from a link or bookmark.
483 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
484 to the main document selection page when the document id hasn't been
486 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
487 the main document selection page when the document id hasn't been
489 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
490 values for the details place when the document id hasn't been set.
491 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
492 values for the list place when the document id hasn't been set.
494 2011-12-21 Ben Konrath <ben@bagu.org>
496 Protect against NPE when glom.document.locale is not in config.
498 This patch protects against an NPE when glom.document.locale is not in
499 the config file. This NPE will also happen if glom.document.locale is
502 The patch also updates the error message to display the class name when
503 the getMessage() returns null. This was happening when the NPE was
504 thrown and I had "Configuration Error: null". If an NPE is encountered
505 with this patch, "Configuration Error: NullPointerException " will be
508 This commit closes this bug:
510 https://bugzilla.gnome.org/show_bug.cgi?id=666669
512 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
514 2011-12-20 Murray Cumming <murrayc@murrayc.com>
516 Rename onlineglom.properties to onlineglom.properties.sample.
518 * src/main/resources/onlineglom.properties: Rename to:
519 * src/main/resources/onlineglom.properties.sample:
520 * src/main/resources/README: And add this file explaining that people
521 should rename it back when deploying.
523 2011-12-20 Murray Cumming <murrayc@murrayc.com>
525 Allow choosing the translation in the .properties file.
527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
528 init(): Read a glom.document.locale value from the configuration file
529 and call Glom's TransatableItem::set_current_locale() method.
530 * src/main/resources/onlineglom.properties: Add a commented-out
531 example of this new setting.
533 It would be better to add &lang=de_DE to the URL, but the current
534 libglom API does not allow us to do this easily. I am working on that.
536 2011-12-19 Murray Cumming <murrayc@murrayc.com>
538 Avoid a crash in parsing of token parameters.
540 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
541 ava: getTokenParams(): Do not crash if a parameter has a key but no
542 value, and ignore parameters with neither.
544 2011-12-17 Murray Cumming <murrayc@murayc.com>
546 History token building/handling: Improve use of token parameters.
548 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
549 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
550 and buildParamsToken(HashMap), for use by derived classes.
551 Make the separator private because it is no longer be needed.
552 * src/main/java/org/glom/web/client/place/DetailsPlace.java
553 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
554 instead of manual string concatenation.
555 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
556 of hardcoded indices and awkward splitting code.
557 * src/main/java/org/glom/web/client/place/ListPlace.java
558 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
559 instead of manual string concatenation.
560 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
561 of hardcoded indices and awkward splitting code.
562 This should fix bug #666420
564 2011-12-16 Murray Cumming <murrayc@murrayc.com>
566 Fix a Navgiation->Navigation typo in the code.
568 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
569 Rename processNavgiation() to processNavigation().
571 2011-12-16 Murray Cumming <murrayc@murrayc.com>
573 Fix a seperator->separator typo in the code.
575 * src/main/java/org/glom/web/client/place/DetailsPlace.java
576 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
577 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
580 2011-12-15 Ben Konrath <ben@bagu.org>
582 Cleanup some comments.
584 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
586 2011-12-14 Ben Konrath <ben@bagu.org>
588 Replace \n with <br/> for multiline text in the details view.
590 Vertical scrollbars are added when needed as well.
592 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
594 2011-12-14 Ben Konrath <ben@bagu.org>
596 Specify the font for document selection links.
598 * src/main/webapp/style.css:
600 2011-12-14 Ben Konrath <ben@bagu.org>
602 Fix bouncy CellTable while paging.
604 This doesn't currently work with related list tables in unselected
607 * src/main/java/org/glom/web/client/ui/list/ListTable.java
609 2011-12-14 Ben Konrath <ben@bagu.org>
611 Revamp the appearance of the document selection page.
613 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
614 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
615 * src/main/webapp/style.css:
617 2011-12-13 Ben Konrath <ben@bagu.org>
619 Set navigation button column to the smallest size possible.
621 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
623 2011-12-13 Ben Konrath <ben@bagu.org>
625 Change OpenButton nomenclature to NavigationButton.
627 Using NavigtionButton makes things more generic. Classes, methods and
628 variables have been changed.
630 This is a rename-only refactor.
632 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
633 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
634 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
635 Renamed from OpenButtonCell.
636 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
637 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
638 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
640 2011-12-12 Ben Konrath <ben@bagu.org>
642 Remove unnecessary String argument in RelatedListTable and ListViewTable.
644 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
645 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
646 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
647 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
649 2011-12-12 Ben Konrath <ben@bagu.org>
651 Update variable names and comments.
653 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
654 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
656 2011-12-12 Ben Konrath <ben@bagu.org>
658 Properly initialize numNonEmptyRows variable to zero.
660 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
661 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
663 2011-12-05 Ben Konrath <ben@bagu.org>
665 Add latest mockup with HTML tables.
667 Features of this mockup:
669 -> HTML table for flowtable
670 -> HTML table for flowtable column
671 -> Example of how related lists would look
672 -> Not using text entries for data items
674 The current version of Online Glom doesn't use HTML tables for the
677 This mockup has been sent to the glom-devel mailing list but it's good
678 to have it here as well.
680 * mockups/details-view-html-tables.html:
682 2011-12-05 Ben Konrath <ben@bagu.org>
684 Remove unnecessary getPrimaryKeyField() method.
686 getPrimaryKeyFieldForTable(String) has been renamed to
687 getPrimaryKeyField(String).
689 * src/main/java/org/glom/web/server/database/DBAccess.java:
690 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
691 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
693 2011-12-05 Ben Konrath <ben@bagu.org>
695 Add string representation of TypedDataItem value to conversion error message.
697 * src/main/java/org/glom/web/server/Utils.java: Logging the error
698 message was extracted into its own method to avoid duplication.
700 2011-12-05 Ben Konrath <ben@bagu.org>
702 Add type checking to navigation primary key value creation.
704 Create navigation primary key only if the expected type from the Glom
705 document matches the type returned by the SQL query.
707 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
709 2011-12-05 Ben Konrath <ben@bagu.org>
711 Rename a couple of variables in RelatedListNavigation.
713 This is a rename-only refactor.
715 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
717 2011-12-05 Ben Konrath <ben@bagu.org>
719 Move getListLayoutGroup() into getListViewLayoutGroup().
721 This removes getListLayoutGroup(). It was only being called by
722 getListViewLayoutGroup().
724 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
726 2011-12-05 Ben Konrath <ben@bagu.org>
728 Remove check for LayoutItem_Portal in list table method.
730 This check is no longer necessary because the method isn't being used
731 to create the LayoutItemPortal DTO.
733 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
735 2011-12-05 Ben Konrath <ben@bagu.org>
737 Properly support related list navigation.
739 Navigation from the "Repository Analyzer -> Package Scans ->
740 Dependencies" related table wasn't working because the primary key for
741 related tables wasn't being set properly. This commit fixes the
744 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
745 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
746 doesn't set the primary key properly for related list tables.
747 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
748 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
749 useful for getting the primary key for list view tables and for related
751 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
752 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
753 Move code to set the primary key for the table from the abstract
754 ListDBAccess class to ListViewDBAccess as it's only correct for list
756 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
757 Properly add primary key to related list tables.
759 2011-12-02 Ben Konrath <ben@bagu.org>
761 Properly set the horizontal alignment of fields.
763 This fix is for both the list tables and the details view.
765 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
766 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
767 to set the horizontal alignment of fields.
769 2011-12-02 Ben Konrath <ben@bagu.org>
771 Display currency codes in the details view.
773 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
775 2011-12-02 Ben Konrath <ben@bagu.org>
777 Avoid duplicate JNI call.
779 JNI is not as efficient as pure Java and this is an easy (and small)
782 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
783 Use previously retrieved value for whereClauseToTableName instead of
786 2011-12-02 Ben Konrath <ben@bagu.org>
788 Rename a couple of variables in RelatedListNavigation.
790 This is a rename-only refactor.
792 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
794 2011-12-02 Ben Konrath <ben@bagu.org>
796 Indicate clearly that a mismatched primary key type is a bug.
798 * src/main/java/org/glom/web/server/Utils.java: Change log level from
799 warning to error. Add 'This is a bug.' to message.
801 2011-12-02 Ben Konrath <ben@bagu.org>
803 Update / fix some comments.
805 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
807 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
809 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
810 Fix comments. Add some TODOs.
812 2011-12-02 Ben Konrath <ben@bagu.org>
814 Enable navigation to details view with string primary key from related list.
816 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
817 Create a text primary key value when return type of result is
818 java.sql.Types.VARCHAR.
820 2011-12-02 Ben Konrath <ben@bagu.org>
822 Use checkboxes for booleans in the details view.
824 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
826 2011-12-01 Ben Konrath <ben@bagu.org>
828 Improve performance of related list height calculation.
830 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
831 Put code to calculate the expected height in a static initializer so
832 that that it's only called once.
834 2011-12-01 Ben Konrath <ben@bagu.org>
836 Show related list tables in notebooks (again).
838 Calculate the height of the related list tables so the Notebook can be
839 set the correct height. The height of the related list table is also needed by
840 FlowTable to be able decide how to create the layout.
842 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
843 and set the Portal height based on the height of the related list
844 table and the Portal container.
845 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
846 Add method to calculate the height of the related list tables.
847 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
848 * src/main/webapp/style.css: Add css class for Pager. This is needed to
849 calculate the height of the Pager widget.
851 2011-12-01 Ben Konrath <ben@bagu.org>
853 Use CellTable API for table property instead of setting style on Element.
855 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
857 2011-12-01 Ben Konrath <ben@bagu.org>
859 Make ListViewTable and RelatedListTable a consistent height.
861 The tables are now a consistent height regardless of the contents of
862 the table. A hidden button is added to empty rows to ensure that the
863 height of these rows will match the height of rows with data.
865 A navigation button column is now added to every table. The width of
866 the navigation column is set to 0px when a RelatedListTable shouldn't
867 have navigation buttons. This maintains the a consistent row height in
868 tables that don't show the navigation buttons.
870 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
871 navigation column when not needed.
872 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
873 arguments for navigation button to constructor of ListViewTable.
874 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
875 hidden button for empty data rows.
876 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
877 arguments for navigation button to constructor.
878 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
879 create navigation buttons. Add hideNavigationButtons() method.
880 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
881 arguments for navigation button to constructor.
883 2011-12-01 Ben Konrath <ben@bagu.org>
885 Use 'visibility: hidden' in Utils.getWidgetHeight().
887 This is better choice because hidden elements are invisible, don't
888 respond to events and are not part of the tab order. They will,
889 however, take up space which is required to be able to calculate the
890 height of the widget.
892 * src/main/java/org/glom/web/client/Utils.java:
894 2011-12-01 Ben Konrath <ben@bagu.org>
896 Use Utils.getWidgetHeight() in FlowTable.
898 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
900 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
902 2011-12-01 Ben Konrath <ben@bagu.org>
904 Put the details css class name on the correct table column.
906 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
908 2011-11-30 Ben Konrath <ben@bagu.org>
910 Update for java-libglom API change.
912 The getters and setters on FieldFormatting and NumericFormat were
913 changed to remove the 'M'.
915 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
917 2011-11-29 Ben Konrath <ben@bagu.org>
919 Only allow RelatedListTables in Portals.
921 * src/main/java/org/glom/web/client/ui/details/Portal.java:
923 2011-11-29 Ben Konrath <ben@bagu.org>
925 Only create a contents panel for Portals when title is being set.
927 * src/main/java/org/glom/web/client/ui/details/Portal.java:
929 2011-11-29 Ben Konrath <ben@bagu.org>
931 Set TabLayoutPanel height based on calculated height its widgets.
933 This is a potential fix for this bug:
935 https://bugzilla.gnome.org/show_bug.cgi?id=665133
937 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
939 2011-11-29 Ben Konrath <ben@bagu.org>
941 Align details field labels and data with the Open buttons.
943 * src/main/webapp/style.css:
945 2011-11-29 Ben Konrath <ben@bagu.org>
947 Remove unnecessary <div> in the Notebook widget.
949 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
950 method to get container FlowPanel (<div>).
951 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
952 initWidget() method directly on the TabLayoutPanel widget instead of
953 Group's container widget.
955 2011-11-29 Ben Konrath <ben@bagu.org>
957 Don't add group titles for Portals in Notebooks.
959 This reverts the previous patch and fixes a bug I introduced with
960 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
962 * src/main/java/org/glom/web/client/ui/details/Group.java:
963 * src/main/java/org/glom/web/client/ui/details/Portal.java:
965 2011-11-28 Ben Konrath <ben@bagu.org>
967 Remove unused boolean argument in Portal constructor.
971 * src/main/java/org/glom/web/client/ui/details/Group.java:
972 * src/main/java/org/glom/web/client/ui/details/Portal.java:
974 2011-11-28 Ben Konrath <ben@bagu.org>
976 Remove hack for glom 1.18 style glom files.
978 * src/main/java/org/glom/web/client/ui/details/Group.java:
979 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
980 * src/main/java/org/glom/web/client/ui/details/Portal.java:
982 2011-11-28 Ben Konrath <ben@bagu.org>
984 Use Gda Value version of primary key to log result too large error.
986 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
988 2011-11-28 Ben Konrath <ben@bagu.org>
990 Don't use TypedDataItem.getText() for Unknown types from the URL.
992 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
993 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
994 instead of getText().
995 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
996 String field and getUnknown() method.
998 2011-11-28 Ben Konrath <ben@bagu.org>
1000 Log an error message when the java-libglom .so is not present.
1002 The error message was being set in the exception but not logged.
1004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1006 2011-11-28 Ben Konrath <ben@bagu.org>
1008 Ignore LayoutItem_CalendarPortals.
1010 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1011 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1013 2011-11-28 Ben Konrath <ben@bagu.org>
1015 Extract method for creating the LayoutItemPortal DTO.
1017 Just breaking the code up into smaller chunks.
1019 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1021 2011-11-28 Ben Konrath <ben@bagu.org>
1025 This should have been added with the refactor. Oops!
1027 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1029 2011-11-28 Ben Konrath <ben@bagu.org>
1031 Create primary key value from URL string using type from Glom document.
1033 See this bug, comments 19 - 25:
1035 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1037 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1038 create a TypeDataItem for the primary key here when loading from a
1039 URL. Show the same string for the primary key value as was received
1040 from the URL string (when loading from a URL).
1041 * src/main/java/org/glom/web/server/Utils.java: Update method for
1042 creating the Gda Value from the TypeDataItem to properly deal with
1043 creating a Gda Value based on the Glom document type for the primary
1044 key value string when loading from a URL.
1045 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1046 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1047 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1048 Update for changed method name.
1050 2011-11-27 Ben Konrath <ben@bagu.org>
1052 Rename PrimaryKeyItem to TypedDataItem.
1054 The name PrimaryKeyItem suggests what the class should be used for.
1055 TypedDataItem is a neutral name that describes the class better.
1057 This is a rename-only refactor.
1059 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1060 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1061 * src/main/java/org/glom/web/client/Utils.java:
1062 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1063 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1064 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1065 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1066 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1067 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1068 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1069 * src/main/java/org/glom/web/server/Utils.java:
1070 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1071 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1072 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1073 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1075 2011-11-25 Ben Konrath <ben@bagu.org>
1077 Improve Gda Value conversion from PrimaryKeyItem.
1079 The value from the PrimaryKeyItem is only used if its type match the
1080 type from the glom document.
1082 * src/main/java/org/glom/web/server/Utils.java:
1084 2011-11-25 Ben Konrath <ben@bagu.org>
1086 Manually check if the java-liblgom .so is visible to the JVM.
1088 It seems that Tomcat has problems when a static initializer throws an
1089 exception. This check is done before the first method call into
1090 java-libglom so that execution doesn't continue if the .so is not
1093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1095 2011-11-25 Ben Konrath <ben@bagu.org>
1097 Improve browser configuration error messages.
1101 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1103 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1104 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1105 getConfigurationErrorMessage() method.
1106 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1107 Get and display a specific configuration error message when no Glom
1108 documents are found.
1109 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1110 Implement getConfigurationErrorMessage() method. Surround configuration
1111 code in the init() method with a try/catch block. This allows the
1112 errors to be caught while keeping the servlet available to retrieve the
1113 configuration error message.
1115 2011-11-25 Ben Konrath <ben@bagu.org>
1117 Don't use Strings to hold primary key values.
1119 The primary key values are now held in a new data object
1120 (PrimaryKeyItem) that holds type information and the primary key value
1121 using the correct type.
1123 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1124 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1126 PrimaryKeyItem instead of String to hold the primary key value.
1127 * src/main/java/org/glom/web/client/Utils.java: Remove
1128 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1129 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1130 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1131 PrimaryKeyItem instead of String to hold the primary key value. Load
1132 document selection page when the documentID has not been set correctly.
1133 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1134 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1136 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1137 Return empty string for URL instead of "null".
1138 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1139 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1140 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1141 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1142 PrimaryKeyItem instead of String to hold primary key values.
1143 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1144 PrimaryKeyValue to a Gda Value.
1145 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1146 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1147 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1148 Replace temporary database access code that uses the PrimaryKeyValue to
1149 Gda Value conversion.
1150 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1151 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1152 PrimaryKeyItem instead of String.
1153 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1154 hold primary key values.
1156 2011-11-24 Ben Konrath <ben@bagu.org>
1158 Use newly added java-libglom API to create queries.
1160 This isn't finished. I still need to stop using Strings for primary key
1161 values in the client code.
1163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1164 libglom to use fake connections so that retrieving the query string will
1166 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1167 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1168 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1169 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1170 Use the newly added libglom sql methods and classes to create the
1171 query. Add temporary hack to convert primary value strings to Gda
1174 2011-11-23 Ben Konrath <ben@bagu.org>
1176 Don't explicitly set the height of Portals.
1178 See comments 6 - 10 of this bug for details:
1180 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1182 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1184 2011-11-23 Ben Konrath <ben@bagu.org>
1186 Use an HTML table instead of CSS for the FlowTable layout.
1188 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1189 GWT's FlexTable to implement the FlowTable.
1190 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1192 2011-11-18 Ben Konrath <ben@bagu.org>
1194 Add boolean example to HTML table mockup.
1196 * mockups/details-view-html-tables-text-entries.html:
1198 2011-11-17 Ben Konrath <ben@bagu.org>
1200 Ensure the pager buttons are always visible for related lists.
1202 To accomplish this, I've turned off text wrapping in the list view and
1203 related list tables for both the header and data text. The related list
1204 table now has a fixed layout so the it doesn't overflow its container.
1205 This is required to ensure that the cell text is clipped when it
1206 overflows the cell and an ellipsis is added to the right side of the
1207 cell when text is clipped.
1209 A fixed table layout for the related list table in the details view
1210 seems what we want for the details view anyway, so the side-effect is
1213 The ellipsis will only be displayed in Firefox >= 7.
1217 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1219 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1220 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1221 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1223 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1224 Set the 'table-layout: fixed' CSS property to the related list table.
1225 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1226 'white-space: nowrap;' CSS property on both the list view and the
1227 related list tables.
1229 2011-11-16 Ben Konrath <ben@bagu.org>
1231 Rework the fix for empty notebook tab labels.
1233 Setting the empty group titles with its name caused problems for the
1234 details layout. Instead of using libglom's
1235 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1236 to the client when the title is empty. This allows the Notebook to use
1237 the name when the title is empty without affecting anything else.
1239 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1240 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1242 2011-11-16 Ben Konrath <ben@bagu.org>
1244 Set group titles with name when title is empty.
1246 This fixes a problem with an empty notebook tab label in the Lesson
1247 Planner document. The forth tab in the notebook should be "Internet":
1249 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1251 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1252 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1255 2011-11-16 Ben Konrath <ben@bagu.org>
1257 Remove whitespace from the configured username properties.
1259 This assumes that usernames won't have whitespace at the beginning
1260 or end. But I think this is a reasonable assumption.
1262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1263 String.trim() to remove the whitespace from the username properties.
1265 2011-11-15 Ben Konrath <ben@bagu.org>
1267 Add details view mockup with HTML tables and text entries.
1269 This is from the attachment on this bug:
1271 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1273 * mockups/details-view-html-tables-text-entries.html:
1275 2011-11-15 Ben Konrath <ben@bagu.org>
1277 Add space between the columns of the flow table.
1281 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1283 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1284 space between columns in the flow table.
1286 2011-11-15 Ben Konrath <ben@bagu.org>
1288 Add backup files to the .gitignore.
1290 * .gitignore: Ignore files that end with ~.
1292 2011-11-09 Ben Konrath <ben@bagu.org>
1294 Use latest release of gwt-log.
1296 Gwt-log releases are now being submitted to the maven central
1297 repository so manual installation of the jar is no longer required.
1299 * pom.xml: Update version and groupId of gwt-log dependency.
1301 2011-10-31 Ben Konrath <ben@bagu.org>
1303 Don't use GWT numeric formatting to override the glom currency formatting.
1305 Currencies are now displayed like they are in Glom. See this bug:
1307 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1309 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1311 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1312 currency code to constructor and set it when the cell is rendered.
1313 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1314 currency code to the constructor of the NumericCell.
1316 2011-10-27 Ben Konrath <ben@bagu.org>
1318 Require the latest release of java-libglom (1.17.4).
1322 2011-10-26 Ben Konrath <ben@bagu.org>
1324 Add style to Notebook that matches current theme.
1326 It's not the best style in the world but it's better than the default.
1328 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1329 padding at the bottom of the child widgets.
1330 * src/main/webapp/style.css: Add style for the Notebook.
1332 2011-10-26 Ben Konrath <ben@bagu.org>
1334 Move servlet initialization code to overridden init method.
1336 This is half of the solution to getting proper error messages
1337 displayed when configuration errors occur. Here's the relevant bug:
1339 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1341 The rest of the solution involves surrounding the init method with a
1342 try/catch block and setting a global variable with the error /
1343 exception. A new async method should be created to retrieve and display
1344 the error message / exception.
1346 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1347 code from constructor to init method adding exceptions as needed.
1349 2011-10-26 Ben Konrath <ben@bagu.org>
1351 Add script to monitor and restart tomcat if required.
1353 * utils/check-and-recover-tomcat.py: New file.
1355 2011-10-26 Ben Konrath <ben@bagu.org>
1357 Display the correct number of data items in the pager.
1361 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1363 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1364 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1365 The implementation is the same for both tables: Keep track of the
1366 number of non-empty rows and fire and RowCountChangeEvent after the data has
1368 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1369 custom Pager class that subclasses SimplePager to handle displaying
1370 the correct number when empty rows have been added.
1372 2011-10-26 Ben Konrath <ben@bagu.org>
1374 Correct error in previous commit.
1376 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1377 eventBus parameter from listView.setCellTable().
1379 2011-10-26 Ben Konrath <ben@bagu.org>
1381 Fix error in TODO comment.
1383 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1385 2011-10-24 Ben Konrath <ben@bagu.org>
1387 Create Notebook widgets to the details view.
1389 This isn't finished just yet - I still need to create a reasonable
1390 style to match the current theme.
1392 * src/main/java/org/glom/web/client/Utils.java: Add method for
1393 calculating the height of a widget. This is used in the Notebook class.
1394 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1395 new constructor method in Group.
1396 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1397 method for creating child widget that can be used by subclasses
1398 like Notebook. New constructor that allows disabling the group
1399 titles - Notebooks don't set a group title for their child groups.
1400 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1401 to make Notebooks using GWT's TabLayoutPanel.
1402 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1403 constructor that allows disabling the group titles.
1404 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1405 LayoutItemNotebook DTO.
1406 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1407 DTO for Notebooks. It's just an empty class for now but we might need
1408 it to transfer some specific information in the future.
1410 2011-10-21 Ben Konrath <ben@bagu.org>
1412 Add navigation buttons to related list tables.
1414 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1415 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1416 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1417 method getSuitableRecordToViewDetails() for getting the table name
1418 and primary key value for related list navigation buttons.
1419 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1420 private cell renderer class to get the navigation information for
1421 related list tables from the server. Extract the navigation
1422 processing code from the details cell navigation and use it for the
1423 related list navigation as well.
1424 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1425 cell renderer class for the details open buttons. This was needed
1426 because the related list navigation buttons and the list view
1427 navigation buttons need to react differently when clicked.
1428 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1429 the onEnterKeyDown() method because it's now overriden in the
1430 subclasses that are specific to the related list tables and the list
1432 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1433 the vertical size a little because the buttons add a bit of vertical
1434 space to table. This is not a perfect solution because the vertical
1435 size of with table fewer than 5 rows will be a little smaller.
1436 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1437 changes in how navigation buttons are handled.
1438 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1439 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1440 database access object.
1441 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1442 to find the portal for a given relationship name from
1443 RelatedListDBAccess. Add method to find a primary key field for a
1445 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1446 Move code to find the portal for a given relationship name to
1448 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1449 New file: database access object for getting the related list
1450 navigation information (the table name and the primary key value).
1451 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1452 DTO for transferring a table name to navigate to and a primary key
1454 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1455 boolean and getter/setter to specifies if the related list should add
1458 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1460 Use the master branch of java-libglom
1462 * pom.xml: Depend on java-libglom 1.19 instead.
1464 This is the master branch. See also the libglom-1-18 branch.
1466 2011-10-11 Ben Konrath <ben@bagu.org>
1468 Enable the open navigation button when the data has been set.
1470 This avoids having active buttons that don't do anything when the data
1473 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1475 2011-10-11 Ben Konrath <ben@bagu.org>
1477 Use IsWidget interface for FlowTableItem.
1479 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1480 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1482 2011-10-11 Ben Konrath <ben@bagu.org>
1484 Remove GWT styling from open button in details view.
1486 There are still some issues with how the details cell is arranged but
1487 this should be made to match Glom 1.20. I'm going to leave fixing this
1488 until I have Glom 1.20 up and running.
1490 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1491 style name on open button.
1492 * src/main/webapp/style.css: Move and edit details-navigation class.
1493 Re-arrange some classes to make them appear in the same order as the
1496 2011-10-07 Ben Konrath <ben@bagu.org>
1498 Update to GWT 2.4.0.
1500 * .gitignore: Ignore new cache directory.
1501 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1502 * pom.xml: Change GWT and maven plugin to 2.4.0.
1503 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1505 * src/main/java/org/glom/web/client/ClientFactory.java:
1506 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1507 * src/main/java/org/glom/web/client/OnlineGlom.java:
1508 Update source for API changes.
1509 * utils/build-onlineglom-war.sh: Remove cache directory before the
1512 2011-10-07 Ben Konrath <ben@bagu.org>
1514 Add navigation buttons in the details view.
1516 This isn't finished but I thought I'd commit what I have as it's a
1517 pretty good start. I still need to:
1519 1. Change the style so that it fits better into the current theme
1520 2. Adjust the details cell to expand as much as possible.
1522 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1523 click handlers to navigation buttons in the DetailsCells. Create a
1524 refreshData() method to get just the data from the server without the
1526 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1527 Update the tableSelector and browser title when the table name
1528 changes without using the tableSelector.
1529 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1530 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1531 getDetailsCells() to getCells(). Update variable names.
1532 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1533 method to set click handler on navigation button. Rename a few
1534 variables. Add navigation buttons where needed.
1535 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1536 variables and methods.
1537 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1538 navigation boolean and navigation table as required in the
1539 LayoutItemField DTO.
1540 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1541 variables for navigation along with getter/setter methods.
1543 2011-10-07 Ben Konrath <ben@bagu.org>
1545 Rename Field to DetailsCell.
1547 This is a refactor-only commit. No functionality has been added or
1550 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1551 Update variable and method names.
1552 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1553 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1554 variable and method names.
1555 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1557 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1558 variable and method names.
1560 2011-10-07 Ben Konrath <ben@bagu.org>
1562 Create separate methods for layout and data the details view.
1564 This is a refactor-only commit. No functionality has been added or
1567 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1568 private methods: setData(), createLayout().
1570 2011-10-07 Ben Konrath <ben@bagu.org>
1572 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1574 This is part of a change to get navigation buttons in the details view
1575 but it should have been done this way from the start.
1577 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1578 for method name change in TableSelectionView.
1579 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1580 Create TableChangeEvent and set the browser title using the
1581 TableSelectionView API.
1582 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1583 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1584 Change getSelectedTable() to getSelectedTableName(). Add
1585 getSelectedTableTitle().
1587 2011-10-07 Ben Konrath <ben@bagu.org>
1589 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1591 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1593 2011-10-07 Ben Konrath <ben@bagu.org>
1595 Update TableChangeEvent to use newTableName naming convention.
1597 This makes the class more consistent with GWT naming conventions.
1599 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1600 Update for method name change in TableChangeEvent.
1601 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1602 for method name change in TableChangeEvent.
1603 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1604 newTableName variable and getter method. Make toDebugString()
1607 2011-09-30 Ben Konrath <ben@bagu.org>
1609 Disable the pager in the list tables when the data row count is less than the minimum.
1611 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1612 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1614 2011-09-30 Ben Konrath <ben@bagu.org>
1616 Add empty rows to the end of related list and list view tables.
1618 I also extracted the cell rendering classes from the ListTable because
1619 the code was becoming a little crazy with all the anonymous inner
1620 classes. My plan is to use these cell rendering classes in the details
1621 view as well so this refactor will be needed for that change.
1623 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1624 set the row count in related list tables if the data has more rows
1625 than the minimum number of rows visible.
1626 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1627 row count in list view tables if the data has more rows than the
1628 minimum number of rows visible.
1629 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1630 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1632 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1633 for rendering TYPE_NUMERIC cells. The code was extracted from the
1635 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1636 class for rendering cells with buttons in list views. The code was
1637 extracted from the ListTable class.
1638 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1639 for rendering TYPE_TEXT cells. The code was extracted from the
1641 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1642 Add empty rows to the end of the data if required. Implement
1643 ListTable.getMinNumVisibleRows().
1644 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1645 cell renderer code to public classes. Return null in
1646 Column.getValue() for empty rows. Add new abstract method:
1647 getMinNumVisibleRows(). Move code to set the row count of the list view
1648 table to ListViewImpl.
1649 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1650 empty rows to the end of the data if required. Implement
1651 ListTable.getMinNumVisibleRows().
1654 2011-09-27 Ben Konrath <ben@bagu.org>
1656 Use GWT.log for client-side debugging statements.
1658 These are optimized out when deployed so I should have used this method
1659 in the first place. These statements will eventually be replaced with some sort
1660 of notification in the browser.
1662 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1663 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1664 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1665 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1666 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1668 2011-09-27 Ben Konrath <ben@bagu.org>
1670 Put tableselector on the right, back to list link on right.
1672 The idea is that the table selector is acting like a label for the
1673 currently displayed table so it should be placed below the document title. This
1674 puts the table title in a similar position to where it is in Glom.
1676 * mockups/details-contacts.html:
1677 * mockups/details-projects.html:
1678 * mockups/listview-contacts.html:
1679 * mockups/listview-projects.html:
1680 * mockups/style.css:
1681 Update mockups to match how the interfaces currently look.
1682 * src/main/webapp/style.css: Swap positions of backlink with the table
1683 selector. Add some space on the left side of the table selector to
1684 line things up with the document title.
1686 2011-09-27 Ben Konrath <ben@bagu.org>
1688 Add field colouring to details view.
1690 This change re-works how field colouring works. The colour formatting
1691 information is now set to the client with the layout information instead of
1692 with the data. This eliminates the need to send the same colour strings for
1693 data in list view column when colour information is set.
1695 In order to set an alternate colour for negative numeric values, the
1696 number is now sent to client and formatted with the GWT NumberFormat class.
1698 This change also fixes:
1700 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1702 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1703 internationalization framework which is needed for client side numeric
1705 * src/main/java/org/glom/web/client/Utils.java: New file for some
1706 client static utility methods.
1707 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1708 the DataItem object to the Field class. Use a utility method to
1709 create the foreignKeyValue string.
1710 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1711 alignment and text colours in the constructor. Add setData(DataItem)
1712 method. Remove setText(String) method.
1713 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1714 colour information to GlomTextCell. Create and use GlomNumberCell for
1715 rendering numbers. Use utility method to get the string for the
1716 primary key of the key provider. Re-work how the horizontal alignment
1718 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1719 formatting to layout information. Methods for converting the libglom
1720 formatting information were moved from DBAccess.
1721 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1722 numeric formatting (it's now done on the client side). Don't set text
1723 colours in DataItem. Move libglom formatting conversion methods to
1725 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1726 getters/setters for text colour information.
1727 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1728 for transferring the libglom NumericFormat information to the client.
1729 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1730 and getters/setters for: GlomNumericFormat, background colour and
1731 foreground colour strings.
1733 2011-09-26 Ben Konrath <ben@bagu.org>
1735 Simplify code that iterates through the LayoutGroup.
1737 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1739 2011-09-26 Ben Konrath <ben@bagu.org>
1741 Accept Eclipse formatting for OnlineGlomServiceAsync.
1743 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1745 2011-09-26 Ben Konrath <ben@bagu.org>
1747 Don't use the ListDBAccess classes to get the primary key layout information.
1749 This was causing a bug where the wrong index for the hidden primary key
1750 was being sent to the client.
1752 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1753 primary key while creating the LayoutGroup DTO. Create a
1754 LayoutItemField DTO for hidden primary keys. Don't use the
1755 RelatedListDBAccess because it was only used for getting the primary
1757 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1758 access modifier from public to protected for getPrimaryKeyField() and
1759 getPrimaryKeyLayoutItemField().
1760 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1761 abstract method getExpectedResultSize() because RelatedListDBAccess
1762 doesn't have enough info to implement it.
1763 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1764 Remove @Override for getExpectedResultSize().
1765 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1766 Remove method getExpectedResultSize().
1768 2011-09-23 Ben Konrath <ben@bagu.org>
1770 Log which layout (list or details) the ignored item is from.
1772 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1774 2011-09-23 Ben Konrath <ben@bagu.org>
1776 Remove annotations that turn off code formatting in DataItem.
1778 * src/main/java/org/glom/web/shared/DataItem.java:
1780 2011-09-23 Ben Konrath <ben@bagu.org>
1782 Rename GlomField to DataItem and update associated methods.
1784 This is a rename-only refactor. No functionality has been added or
1787 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1788 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1789 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1790 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1791 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1792 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1793 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1794 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1795 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1796 * src/main/java/org/glom/web/server/database/DBAccess.java:
1797 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1798 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1799 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1800 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1801 * src/main/java/org/glom/web/shared/DataItem.java:
1802 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1803 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1805 2011-09-23 Ben Konrath <ben@bagu.org>
1807 Rename GlomDocument to DocumentInfo and update associated methods.
1809 This is a rename-only refactor. No functionality has been added or
1812 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1813 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1814 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1815 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1816 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1817 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1818 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1820 2011-09-20 Ben Konrath <ben@bagu.org>
1822 Require java-libglom 1.17.3.
1824 This picks up the fix for the seg fault problem with the Scenes table
1825 in the Openismus Film Manager example.
1829 2011-09-20 Ben Konrath <ben@bagu.org>
1831 Change the way sort clause is added for primary key when no sort clause is requested.
1833 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1834 before the sort clause is created. When a sort clause is not requested, the
1835 sort clause is created by finding the primary key in the LayoutFieldVector
1838 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1840 2011-09-20 Ben Konrath <ben@bagu.org>
1842 Log error message if no documents are found in the configured directory.
1844 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1845 Extract the glom file extension string to a private static final class
1846 variable (mostly as syntactic sugar). Accept a minor formatting change.
1847 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1848 the example glom.document.directory configuration property to make it
1849 more clear that it can any directory, not just the home directory.
1851 2011-09-18 Ben Konrath <ben@bagu.org>
1853 Add related lists to details view.
1855 The related list table has support for paging and sorting just like the
1856 table in the list view.
1858 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1859 SQL queries for the related list tables.
1860 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1861 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1862 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1863 Rename getList methods to getListView and add comments. Remove
1864 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1865 it being unused. Add methods: getDetailsLayoutAndData(),
1866 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1867 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1868 Create the layout and set the data for the fields in one async call
1869 instead of two. Create related lists where appropriate.
1870 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1871 for method name changes in OnlineGlomService.
1872 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1873 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1874 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1876 * src/main/java/org/glom/web/client/ui/ListView.java:
1877 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1878 tableName from setCellTable(). Create a ListViewTable instead of
1880 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1881 represent a data field in the details view.
1882 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1883 from addDetailsCell() to Field class. Keep track of the Fields and
1884 Portals in the details view.
1885 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1886 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1887 and add a method to get it. Add method to set the contents of the
1889 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1890 New class for related list tables. This class has the data provider
1891 for the related list table.
1892 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1893 abstract class which is the base class for the ListViewTable and the
1895 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1896 New class for list view tables. This class has the data provider for
1897 the list view table.
1898 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1899 methods for related list tables. Add more information to the
1900 LayoutItemField and LayoutItemPortal DTOs.
1901 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1902 Remove debugging print statement.
1903 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1904 Remove debugging print statements. Add primary key field to SQL count
1906 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1907 Remove unnecessary LayoutFieldVector parameter from
1908 getResultSizeOfSQLQuery() method.
1909 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1910 New class for related list table database access.
1911 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1912 class that is a wrapper DTO for details view layout and data.
1913 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1914 new 'fromField' string to this DTO.
1915 * src/main/webapp/style.css: Remove bottom margin and override top
1918 2011-09-15 Ben Konrath <ben@bagu.org>
1920 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1922 This sets things up to make it easier to add the data retrieval for
1923 related lists (portals). No user noticeable changes were made with
1926 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1927 class has the code to retrieve the layouts and access the
1928 database using the new database helper classes.
1929 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1930 Most of the functionality has been removed from this class. This
1931 class now represents the public interface for the client side
1932 code. It also deals with configuring the servlet and cleaning
1933 things up when the servlet is stopped.
1934 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1935 of static methods into this utility class.
1936 * src/main/java/org/glom/web/server/database/DBAccess.java:
1937 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1938 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1939 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1940 These classes have the database retrieval code. The class hierarchy
1941 has been setup to make it easy to reuse code for similar
1944 2011-09-06 Ben Konrath <ben@bagu.org>
1946 Create separate classes for list table code and the data provider.
1948 As part of this refactor, I also split up the code a bit to make it
1951 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1952 table code to two new classes (below).
1953 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1954 with code from ListViewImpl.
1955 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1956 New file with code from ListViewImpl.
1958 2011-09-06 Ben Konrath <ben@bagu.org>
1960 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1962 This fixes the LayoutItemPortal DTO to match the libglom layout object
1965 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1967 2011-09-01 Ben Konrath <ben@bagu.org>
1969 Set title of Portals in the Details View.
1971 * pom.xml: Bump required version of java-libglom to 1.17.1.
1972 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1973 widget creation to its own class. Add comments to constructor.
1974 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1975 The code is mostly from the Group class with the title now set.
1976 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1977 title of Portal. Update some comments. Fix some code formatting.
1979 2011-09-01 Ben Konrath <ben@bagu.org>
1981 Remove TODO comment for the flow table column width.
1983 The flow table column width is working correctly and doesn't need to be
1984 changed. See this mailing list post for more info:
1986 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1988 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1990 2011-08-27 Ben Konrath <ben@bagu.org>
1992 Add document title (database name) to top of the browser page.
1994 I added the document title to the TableSelecitonView but that will
1995 change if / when we add a view that doesn't require table selection.
1997 * mockups/details-contacts.html:
1998 * mockups/details-projects.html:
1999 * mockups/listview-contacts.html:
2000 * mockups/listview-projects.html:
2001 * mockups/style.css: Add document title to mockups to keep things
2003 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2004 sizes to account for the document title.
2005 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2006 Set the document title when it has been retrieved from the server.
2007 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2008 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2009 and implement setDocumentTitle(String) method.
2010 * src/main/webapp/style.css: Add ID for document title style.
2012 2011-08-25 Ben Konrath <ben@bagu.org>
2014 Add NavigationType enum to LayoutItemPortal DTO.
2016 This is the start of adding support for Portals to the Details View.
2018 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2019 LayoutItem_Portal.navigation_type enum from libglom to
2020 LayoutItemPortal.NavigationType enum.
2021 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2022 NavigationType enum, field for storing the NavigationType and getter
2025 2011-08-25 Ben Konrath <ben@bagu.org>
2027 Implement the flow table layout in the Details View.
2029 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2030 FlowTable to Group to account for the renamed class.
2031 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2032 File. This is a container widget that implements the Glom details view
2033 flow table behaviour.
2034 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2035 org/glom/web/client/ui/FlowTable.java.
2036 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2037 so that the size of the subgroups are a closer match to the size of
2038 the Glom subgroups. This makes the flowtable layout match the layout
2039 in Glom for the Music Collection example file.
2041 2011-08-16 Ben Konrath <ben@bagu.org>
2043 Create container element for LayoutItemPortal in Details View.
2045 This will help me develop the layout for the FlowTable.
2047 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2048 fieldPanel variable to detailsCell.
2050 2011-08-15 Ben Konrath <ben@bagu.org>
2052 Set the height of the data element in the Details View.
2054 I changed the InlineLabels (text in a span element) to Labels (text in
2055 a div element) so that I could set the height of the details-data
2056 elements instead of the details-cell parent elements. This allows the
2057 the details-data element to display the correct height if style is
2058 applied that shows the height.
2060 This change has the added benefit of allowing the order of the labels
2061 and data elements to be changed for right-to-left languages.
2063 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2064 InlineLabels to Labels.
2065 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2066 InlineLabels to Labels. Set the height of the data element.
2067 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2068 multiline text height in the Formatting DTO.
2069 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2070 for multiline height along with getter and setter methods.
2071 * src/main/webapp/style.css: Adjust style to account for the change
2072 from span elements to div elements in the details cell.
2074 2011-08-15 Ben Konrath <ben@bagu.org>
2076 Make the List View appearance match the mockups.
2078 It doesn't match exactly but it's much better than it was.
2080 * mockups/listview-contacts.html: Remove unused css classes.
2081 * mockups/listview-projects.html: Remove unused css classes.
2082 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2083 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2084 for mainPanel instead of VerticalPanel (table). Set style name on
2085 CellTable. Set style name on Details column. Right-align Details
2087 * src/main/webapp/style.css: Adjust properties to match the mockups.
2089 2011-08-12 Ben Konrath <ben@bagu.org>
2091 Add better support for subgroups in the details view.
2093 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2094 changed FlowTable constructor.
2095 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2096 support for subgroups and subgroup-titles.
2097 * src/main/webapp/style.css: Add CSS class for subgroups and
2100 2011-08-12 Ben Konrath <ben@bagu.org>
2102 Return the top level LayoutGroup title.
2104 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2106 2011-08-11 Ben Konrath <ben@bagu.org>
2108 Make the TableSelector header match the mockup.
2110 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2111 the layout panel. Properly lineup the table selection header with
2112 the list and details view.
2113 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2114 margin around the details view.
2115 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2116 Rename listBox variable to tableSelector. Set id for the style sheet.
2117 Use a FlowPanel instead of a HorizontalPanel.
2118 * src/main/webapp/style.css: Add properties to make the TableSelector
2119 box match the mockups.
2121 2011-07-13 Ben Konrath <ben@bagu.org>
2123 Update install script for java-libglom version change.
2125 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2128 2011-07-13 Ben Konrath <ben@bagu.org>
2130 Add support sub-group in the details view.
2132 I also removed the code that special-cased the default details view
2135 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2137 I still have to make a proper flowtable.
2139 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2140 Don't special-case default details view layout.
2141 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2142 addLayoutField() as I'm going to use it.
2143 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2144 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2146 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2147 extracted from DetailsViewImpl.GroupPanel. Add support for
2149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2150 column count when getting the details layout.
2152 2011-07-12 Ben Konrath <ben@bagu.org>
2154 Set browser title with database and table titles.
2156 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2157 Set the browser title when the table changes and when the activity
2159 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2160 title when retrieving document info (the GlomDocument object).
2161 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2162 with getter and setter methods. Remove unused convenience constructor.
2163 Use default code formatting.
2165 2011-07-12 Ben Konrath <ben@bagu.org>
2167 Ignore LayoutItemPortals in the details view.
2169 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2172 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2173 LayoutItemPortal layout objects.
2174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2175 LayoutItemPortal objects when retrieving the details layout.
2176 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2177 file. This is an empty class and just used to get type information for
2180 2011-07-12 Ben Konrath <ben@bagu.org>
2182 Use java-libglom 1.17.0.
2186 2011-07-11 Ben Konrath <ben@bagu.org>
2188 Remove "Table:" label from table selector.
2190 This matches a recent change in the Glom UI.
2192 * mockups/details-contacts.html:
2193 * mockups/details-projects.html:
2194 * mockups/listview-contacts.html:
2195 * mockups/listview-projects.html: Remove the "Table:" label from the
2197 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2199 2011-07-11 Ben Konrath <ben@bagu.org>
2201 Add main groups to the details view.
2203 This makes things look a little nicer in the details view. The next step
2204 is to implement the flowtable.
2206 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2207 resources from the standard gwt css theme. Standard.css is now
2208 included in OnlineGlom.html so that the online glom css rules have
2209 precedence over the gwt theme.
2210 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2211 the whole LayoutGroup to the DetailsView instead of just the titles.
2212 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2213 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2214 details layout with a helper class (GroupPanel). I might extract this
2215 class when I make the full flowtable.
2216 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2217 string as default so I don't have to worry about NPEs when processing
2219 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2220 note beside OnlineGlom.gwt.xml above).
2221 * src/main/webapp/style.css: Add default font-size to body to override
2222 the font-size set by the standard theme. Don't use h2 tags for
2223 group-title. Create new details-cell class.
2225 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2227 ConfiguredDocument: Set the port number too.
2229 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2230 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2231 Glom document. Presumably this worked sometimes so far because there is a
2232 default port number.
2234 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2236 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2238 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2239 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2240 correct, though we should throw an exception too.
2242 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2244 Fix a addDocuemnt typo.
2246 * src/main/java/org/glom/web/shared/Documents.java
2247 (Documents.addDocuemnt): Rename to addDocument().
2248 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2249 (OnlineGlomServiceImpl.getDocuments): Adapt.
2251 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2253 Slightly improved log output when connection fails.
2255 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2256 (ConfiguredDocument.setUsernameAndPassword):
2257 We don't know for sure if it' the username/password that's wrong, so
2258 rephrase the message.
2259 Also ouput the exception message, though it's generic in this case.
2261 2011-07-08 Ben Konrath <ben@bagu.org>
2265 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2266 added braces to a one line if statement because the Eclipse formatter
2267 was getting confused.
2269 2011-07-07 Ben Konrath <ben@bagu.org>
2271 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2273 These should really be two separate tasks but I counldn't get things to
2274 work with GWT 2.2.0 and Eclipse 3.7.
2278 * .settings/org.eclipse.jdt.core.prefs:
2279 * .settings/org.eclipse.jdt.ui.prefs:
2280 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2281 * .settings/org.eclipse.m2e.core.prefs:
2282 Add new config files. Update current files. Remove references to the
2283 webtools plugins as we're not using any of the webtools features.
2284 * .gitignore: Add logs directory which is created when running with
2286 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2287 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2288 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2290 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2292 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2294 onlineglom.properties: Add explanatory comments.
2296 * src/main/resources/onlineglom.properties: Also change the default user
2297 from ben to someuser, to avoid the risk of people thinking we just
2298 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2300 2011-06-28 Ben Konrath <ben@bagu.org>
2302 Use filename in Log for incorrect passwords.
2304 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2305 getFileName(String) method to get the filename from the URI.
2307 2011-06-28 Ben Konrath <ben@bagu.org>
2309 Add the table name to the URL token for the ListPlace.
2311 This makes things consistent between the DetailsPlace and the
2312 ListPlace. It also allows the the ListPlace to be bookmarked.
2314 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2315 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2316 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2317 Remove getDefaultListLayout(). The default layout is now returned
2318 by the getListLayout() method when the table name is an empty string.
2319 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2320 Add table name field. Change to a new ListPlace when the table
2321 has been changed. Use getListLayout() for getting the default
2323 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2324 Add table name field. Set the correct table name in the list box
2325 when loading from bookmark. This corrects a problem for the
2327 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2328 Move table name to super-class (HasSelectableTable). Move document
2329 and table URL keys to super-class in HasSelectableTable.
2330 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2331 Add table name field. Add Tokenizer class with URL key common to
2332 the subclasses (DetailsPlace and ListPlace).
2333 * src/main/java/org/glom/web/client/place/ListPlace.java:
2334 Add table name. Add code to parse the URL token.
2335 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2336 Update ListPlace construction with empty table name string.
2337 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2338 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2339 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2340 Update ListPlace construction with table name string.
2341 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2342 Change defaultTableName field to tableName to reflect how it's now
2343 used. Update the getter and setter methods.
2345 2011-06-28 Ben Konrath <ben@bagu.org>
2347 Enable the table selector in the DetailsView.
2349 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2350 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2351 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2352 Remove getDefaultDetailsLayout(). The default layout is now returned
2353 by the getDetailsLayout() method when the table name is an empty
2355 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2356 event handler for table change event. Change to using
2357 getDetailsLayout() for the default details layout.
2358 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2360 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2361 when navigating to the details place.
2363 2011-06-27 Ben Konrath <ben@bagu.org>
2365 Use filename based unique document ID in URL and for RPC.
2367 The document ID is the glom document name with spaces (' ') replaced
2368 with pluses ('+') and without the .glom extension.
2370 This change is mostly a string substitution of 'documentTitle' for
2371 'documentID'. The only code change is the addition of a Documents DTO to get the
2372 filename to document title mappings as indicated below.
2374 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2375 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2376 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2377 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2378 Use Documents DTO to create the document links in the document
2380 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2381 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2382 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2383 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2384 * src/main/java/org/glom/web/client/place/ListPlace.java:
2385 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2386 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2387 * src/main/java/org/glom/web/client/ui/ListView.java:
2388 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2389 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2390 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2391 * src/main/java/org/glom/web/server/Log.java:
2392 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2393 getDocumentTitles() to getDocuments() and return the Documents DTO.
2394 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2395 transferring the filename to document title mappings.
2397 2011-06-25 Ben Konrath <ben@bagu.org>
2399 Make the authentication popup work again.
2401 This bug was introduced when I extracted ConfiguredDocument to its own class.
2403 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2404 correct success / fail status in setUsernameAndPassword().
2406 2011-06-25 Ben Konrath <ben@bagu.org>
2408 Use filename as unique key for configuring database usernames and passwords.
2410 This replaces the use of the Glom document title which could change
2411 depending on the locale. Thanks to Murray Cumming for pointing out this
2414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2415 * src/main/resources/onlineglom.properties:
2417 2011-06-24 Ben Konrath <ben@bagu.org>
2419 Pass primary key value to DetailsView.
2421 This enables the DetailsView to load the correct data.
2423 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2424 primary key value field and set in constructor. Pass primary key
2425 value to getDetailsData().
2426 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2427 variables for document title and primary key value.
2428 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2429 key value to the DetailsPlace.
2431 2011-06-24 Ben Konrath <ben@bagu.org>
2433 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2435 This allows the primary key to be retrieved by the Details button. This
2436 functionality has not been implemented yet but it's in the works.
2438 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2439 the LayoutGroup result to ListView.setCellTable instead of all of its
2440 fields individually.
2441 * src/main/java/org/glom/web/client/ui/ListView.java:
2442 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2443 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2444 get the primary key for the table.
2445 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2446 index of the primary key in the LayoutGroup accounting for hidden
2447 primary keys. Rename getJavaNumberFormat() to
2448 convertToJavaNumberFormat() for consistency. Cleanup / add some
2450 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2451 field for primary key index and a field to indicate whether the
2452 primary key is hidden or not.
2454 2011-06-23 Ben Konrath <ben@bagu.org>
2456 Rename getTableData methods to getListData.
2458 This is a rename refactor for consistency with other methods.
2460 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2461 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2462 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2465 2011-06-23 Ben Konrath <ben@bagu.org>
2467 Extract the ConfiguredDocument innerclass into its own class.
2469 This makes the servlet code more object oriented.
2471 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2472 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2473 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2474 new ConfiguredDocument class.
2476 2011-06-21 Ben Konrath <ben@bagu.org>
2478 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2480 This makes things more inline with how libglom works and reduces code
2481 duplication. This refactor lays the groundwork for adding the primary key to
2482 the LayoutGroup object.
2484 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2485 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2486 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2487 Change method names to getListLayout and getDefaultListLayout for
2488 consistency. Use LayoutGroup as the DTO for the list layout instead of
2489 ColumnInfo and LayoutListTable.
2490 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2491 new method names along with the LayoutGroup object for transferring the
2493 * src/main/java/org/glom/web/client/ui/ListView.java:
2494 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2495 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2496 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2498 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2499 Replaced with LayoutGroup.
2500 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2501 expectedResultSize and defaultTableName fields which are needed for
2503 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2504 type field which is needed for the list layout but will also be
2505 useful for the details layout as things progress.
2506 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2507 Make class abstract. Remove the unnecessary
2508 getFormattingHorizontalAlignment method. Add setFormatting method.
2510 2011-06-16 Ben Konrath <ben@bagu.org>
2512 Add scripts for building and installing war.
2514 These will help when updating OnlineGlom but they're also good
2515 supplemental documentation of the build and deployment proceeding.
2517 * utils/build-onlineglom-war.sh: New file.
2518 * utils/install-onlineglom-war.sh: New file.
2520 2011-06-16 Ben Konrath <ben@bagu.org>
2522 Create wrapper class to create consistent log messages.
2524 I wrapped methods in the Log class of gwt-log to add the method names
2525 from the servlet and create consistent formatting of the document title
2526 and table names in the log messages.
2528 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2529 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2530 log methods to use methods from wrapped Log class.
2532 2011-06-16 Ben Konrath <ben@bagu.org>
2534 Remove superfluous conditional return.
2536 Thanks to Murray Cumming for pointing this out!
2538 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2540 2011-06-15 Ben Konrath <ben@bagu.org>
2542 Return an ArrayList of LayoutGroups for the Details layout.
2544 This corrects a problem with the details layout as it can have more
2545 than one top level LayoutGroup.
2547 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2548 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2549 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2550 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2551 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2552 with ArrayList of LayoutGroups for the details view layout.
2553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2554 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2555 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2556 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2557 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2558 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2560 2011-06-14 Ben Konrath <ben@bagu.org>
2562 Use cast_dynamic method to determine the libglom LayoutItem type.
2564 This is better than finding the LayoutItem type by using the string
2565 returned from the get_part_type_name() method.
2567 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2569 2011-06-14 Ben Konrath <ben@bagu.org>
2571 Add method names to log entries in the servlet.
2573 This helps when tracking down deployment problems.
2575 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2577 2011-06-14 Ben Konrath <ben@bagu.org>
2579 Add data to the DetailsView using a hard-coded primary key value.
2581 The layout and functionality of the DetailsView is not complete. This
2582 is just a checkpoint so the patch doesn't get too big.
2584 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2585 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2586 Add getDetailsData() servlet method.
2587 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2588 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2589 LayoutFields are added to the DetailsView.
2590 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2591 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2592 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2593 take the string for the title instead of the object.
2594 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2595 Add implementation getDetailsData() along with some private helper
2597 * src/main/webapp/style.css: Add padding to details-data class. Add a
2598 details-label class with the same padding as the details-data class.
2600 2011-06-03 Ben Konrath <ben@bagu.org>
2602 Use presenter.goTo() to change to the DetailsPlace.
2604 This will make things easier when we need to open the DetailsView with
2605 data specific to the row that was clicked.
2607 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2609 2011-06-02 Ben Konrath <ben@bagu.org>
2611 Add CSS file from mockups.
2613 I'm adding this now because it's going to be useful to have when
2614 developing the DetailsView. The TableSelectionView and ListView aren't
2617 * src/main/webapp/OnlineGlom.html:
2618 * src/main/webapp/style.css:
2620 2011-06-02 Ben Konrath <ben@bagu.org>
2622 Use String.isEmpty() to check for empty string.
2624 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2626 2011-06-02 Ben Konrath <ben@bagu.org>
2628 Display main layout group titles in the DetailsView.
2630 This is the start of the DetailsActivity/DetailsView implementation.
2632 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2633 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2634 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2635 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2636 Get the layout information for the details view from the server and set
2637 the main layout group titles.
2638 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2639 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2640 Add addLayoutGroup() and addLayoutField() methods. This are just
2641 temporary methods for creating the the details view that will change
2643 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2644 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2646 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2647 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2648 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2649 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2650 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2651 Data Transfer Objects that mimic the libglom object structure. These are
2652 used for transferring the details layout but could also be used for
2653 transferring the list layout.
2655 2011-05-27 Ben Konrath <ben@bagu.org>
2657 Reset the AuthenticationPopup when clearing the ListView.
2659 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2661 2011-05-27 Ben Konrath <ben@bagu.org>
2663 Fix problem with onlineglom.properties file loading.
2665 The old way worked in Eclipse but not on the server. Loading the
2666 onlineglom.properties file now works in Eclipse and on the server.
2668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2670 2011-05-24 Ben Konrath <ben@bagu.org>
2672 Update gwt-log from 3.1.0 to 3.1.2.
2674 Gwt-log 3.1.0 has been marked as depreciated.
2678 2011-05-24 Ben Konrath <ben@bagu.org>
2680 Add comment to ListActivity.goTo() method.
2682 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2684 2011-05-24 Ben Konrath <ben@bagu.org>
2686 Remove FIXME in convertGdkColorToHtmlColour()
2688 The Gdk::Color value returned by libglom is 16-bits per channel on both
2689 64 and 32-bit platforms.
2691 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2693 2011-05-19 Ben Konrath <ben@bagu.org>
2695 Improve performance of initial ListView load.
2697 I removed a round trip to the server for getting the default table name
2698 and then requesting information about that table. This also removes a potential
2699 problem with the table change handler not being setup in time to receive the
2700 table change event from the ListActivity.
2702 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2703 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2704 getDefaultLayoutListTable() method. Improve comments.
2705 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2706 getDefaultLayoutListTable() method instead of firing a table change
2707 event to get the table to load.
2708 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2709 implementation of getDefaultLayoutListTable() method.
2710 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2713 2011-05-19 Ben Konrath <ben@bagu.org>
2715 Override toDebugString() in TableChangeEvent.
2717 This is useful to have for debugging.
2719 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2721 2011-05-19 Ben Konrath <ben@bagu.org>
2723 Add a "Back to List" link when at the DetailsPlace.
2725 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2726 Populate the CellTable based on the selected table of the ListBox if
2727 it's set otherwise use the default table. This allows the "Back to
2729 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2730 Remove Place from constructors. Add a setPlace() method. Add
2731 goToPlace() method. Set class as presenter for TableSelectionView.
2732 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2733 Use the same TableSelectionActivity when switching between the List and
2735 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2736 Subclass the new HasSelectableTablePlace. This removes some duplicate
2738 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2739 New class to represent Places that display the TableSelectionView.
2740 * src/main/java/org/glom/web/client/place/ListPlace.java:
2741 Subclass the new HasSelectableTablePlace. This removes some duplicate
2743 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2744 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2745 Add Presenter interface. Add setBackLinkVisible() method. Add
2746 setBackLink() method.
2748 2011-05-18 Ben Konrath <ben@bagu.org>
2750 Enable the "Details" buttons.
2752 Right now only an empty details view is displayed.
2754 * src/main/java/org/glom/web/client/ClientFactory.java:
2755 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2756 Add DetailsView to ClientFactory.
2757 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2758 A basic activity for the details view.
2759 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2760 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2762 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2763 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2765 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2766 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2767 unnecessary super() in constructor.
2768 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2769 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2770 really shouldn't create a new TableSelectionActivity for both the ListPlace
2771 and the DetailsPlace so this should be considered a temporary solution.
2772 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2773 New file. Represents a URL for the details view.
2774 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2775 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2776 A basic details view interface and implementation.
2777 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2778 Enable the "Details" buttons.
2780 2011-05-12 Ben Konrath <ben@bagu.org>
2782 Use a LayoutPanel with multiple display areas for main layout.
2784 This is mostly a refactor in that there are no changes from the user
2785 point of view. These changes are required so that we can swap out the list view
2786 with the details view when the user clicks the "Details" button.
2788 * src/main/java/org/glom/web/client/ClientFactory.java:
2789 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2790 OnlineGlomView. Add TableSelectionView, ListView and
2791 AuthenticationPopup.
2792 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2793 for main layout. Add display regions for main activities. Add
2794 activity manager for for main activities.
2795 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2796 file from parts of the deleted OnlineGlomActivity.
2797 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2798 New file from parts of the deleted OnlineGlomActivity.
2799 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2800 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2801 New files for app wide table change event.
2802 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2803 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2804 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2805 Activity mappers for the main activities replace the deleted app-wide
2807 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2808 Fix a spelling error in he comment.
2809 * src/main/java/org/glom/web/client/ui/ListView.java:
2810 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2811 Renamed from LayoutListView and modified for MVP. This still not a
2812 proper dumb view as prescribed by the MVP pattern but it works for now.
2813 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2814 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2815 New widget stripped out of the deleted OnlineGlomView.
2816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2817 Remove hack that is fixed by this patch.
2819 2011-05-06 Ben Konrath <ben@bagu.org>
2821 Rename OnlineGlomPlace to ListPlace.
2823 The only change besides the rename is that url will now display #list
2824 instead of #Document.
2826 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2827 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2828 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2829 * src/main/java/org/glom/web/client/place/ListPlace.java:
2830 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2832 2011-05-06 Ben Konrath <ben@bagu.org>
2834 Use Presenter for app navigation.
2836 This is the proper way to deal with Place (URL) changes with the MVP
2839 * src/main/java/org/glom/web/client/ClientFactory.java:
2840 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2841 PlaceHistoryMapper and PlaceHistoryHandler.
2842 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2843 PlaceHistoryMapper and PlaceHistoryHandler.
2844 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2845 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2846 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2847 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2848 Add Presenter interface and setPresenter methods. Rename addHyperLink
2849 to addDocumentLink taking only the document title as a parameter.
2851 2011-04-14 Ben Konrath <ben@bagu.org>
2853 Prompt for db username/password if they haven't been set.
2855 This is implemented with a popup widget that is contained within the
2856 OnlineGlomView and managed by the OnlineGlomActivity.
2858 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2859 methods for checking and setting the database username and password.
2860 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2861 new methods for checking and setting the database username and
2863 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2864 Display authentication popup if the JDBC connection to the database
2865 has not been authenticated.
2866 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2868 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2869 for dealing with the authentication popup.
2870 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2871 Implement the methods for dealing with the authentication popup.
2872 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2873 try to executed queries if the database connection hasn't been
2874 authenticated. Implement methods for checking and setting the
2875 database username and password.
2877 2011-04-12 Ben Konrath <ben@bagu.org>
2879 Make log messages a little clearer.
2881 Add a dash betweeen the document title and the table name.
2883 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2885 2011-04-12 Ben Konrath <ben@bagu.org>
2887 Protect against NPEs when cleaning up database resources.
2889 While this isn't strictly necessary because the exception is caught,
2890 not protecting against the NPEs makes it harder to find the real error
2893 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2895 2011-04-12 Ben Konrath <ben@bagu.org>
2897 Move configuration of the servlet to the constructor.
2899 The servlet will be initialized even if the database authentication
2900 information is not set or correct. I still need to add the UI for prompting
2901 the user for the authentication information when it's required.
2903 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2904 javadocs for getDocumentTitles() method.
2905 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2906 Set error message when RPC fails.
2907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2908 glom files directory from the configuration file. Try to set the
2909 database authentication information for the specific document if it's
2910 set and works otherwise try to use the global authentication
2911 information set for the directory.
2912 * src/main/resources/onlineglom.properties: Moved from
2913 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2914 Added detailed comments for the new keys.
2916 2011-04-11 Ben Konrath <ben@bagu.org>
2918 Remove unnecessary @Override in DocumentSelectionViewImpl.
2920 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2922 2011-04-11 Ben Konrath <ben@bagu.org>
2924 Remove center alignment in DocumentSelectionView.
2926 The title element is still centred but the document titles and bottom
2927 sentence are both left-aligned.
2929 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2931 2011-04-11 Ben Konrath <ben@bagu.org>
2933 Change 'Demo' naming convention to 'Document'.
2935 This is just a rename refactor with no functional changes to the code.
2937 * src/main/java/org/glom/web/client/ClientFactory.java:
2938 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2939 * src/main/java/org/glom/web/client/OnlineGlom.java:
2940 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2941 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2942 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2943 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2944 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2945 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2946 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2947 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2948 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2949 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2951 2011-04-08 Ben Konrath <ben@bagu.org>
2953 Remove FIXME from safeLongToInt() method.
2955 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2958 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2960 2011-04-08 Ben Konrath <ben@bagu.org>
2962 Display an error if no glom documents are found in the specified directory.
2964 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2965 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2966 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2967 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2969 2011-04-08 Ben Konrath <ben@bagu.org>
2971 Add copyright header to one more file ... oops.
2973 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2975 2011-04-08 Ben Konrath <ben@bagu.org>
2977 Add copyright header to files without it.
2979 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2980 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2981 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2982 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2983 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2984 * src/main/java/org/glom/web/shared/GlomField.java:
2986 2011-04-08 Ben Konrath <ben@bagu.org>
2988 Add support for accessing multiple glom documents in the servlet.
2990 This completes the demo selection functionality.
2992 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2993 document title to methods.
2994 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2995 document title to methods.
2996 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2997 Set browser window title when the activity starts. Correct name of
2998 document title variable.
2999 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3000 Set browser window title when the activity starts. Set the table
3001 selector change handler after table selector has been set. Clear the
3002 OnlineGlomView when the activity has been stopped.
3003 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3004 document title as the place token. Use "#Document:" instead of
3005 "#OnlineGlomPlace:" in the URL.
3006 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3007 Change heading to "Online Glom"
3008 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3009 document title in RPC methods.
3010 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3011 setDocumentTitle() method. Add clear() method.
3012 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3013 setDocumentTitle() method. Implement clear() method which removes the
3014 change handler on the ListBox, clears the ListBox and clears the
3016 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3017 Implement methods with document title. Keep track for the configured
3018 glom documents and their corresponding JDBC configurations in a hash
3019 table. This information is retrieved using the document title as the
3020 key in the hash table.
3021 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3022 document title field as it's no longer needed.
3024 2011-04-08 Ben Konrath <ben@bagu.org>
3026 Update the Eclipse JDT configuration.
3028 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3029 methods. Automatically add the copyright header to new files.
3031 2011-04-05 Ben Konrath <ben@bagu.org>
3033 Add new page for demo selection.
3035 This patch adds all the components required to view and start an
3036 OnlineGlom demo by clicking on the desired hyperlink. The user is
3037 able to return to the demo selection page with the browser's back
3038 button. I still need to modify the servlet to work with multiple
3039 documents so all demo links will load the file defined in the
3040 OnlineGlom.properties.
3042 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3043 This is only useful during development so we don't need to save it.
3044 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3045 get a reference to the DemoSelectionView.
3046 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3047 method to get a reference to the DemoSelectionView.
3048 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3049 default view to DemoSelectionView.
3050 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3051 to get glom document titles for glom files in a hard-coded directory.
3052 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3053 method to get glom document titles for glom files in a hard-coded
3055 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3056 Presenter for DemoSelectionView.
3057 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3058 for DemoSelectionView.
3059 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3060 Update for DemoSelectionView.
3061 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3062 Basic 'Place' implementation for the DemoSelectionView.
3063 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3064 The interface for the DemoSelectionView.
3065 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3066 The implementation of the DemoSelectionView.
3067 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3068 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3069 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3070 implementation of method to get glom document titles for glom files
3071 in a hard-coded directory.
3072 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3073 on longer being used.
3074 * src/main/webapp/glom.png: Glom logo.
3076 2011-04-05 Ben Konrath <ben@bagu.org>
3078 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3080 This is the forth and final commit of a refactor that will allow
3081 OnlineGlom to be used with multiple documents.
3083 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3084 Move RPC code from OnlineGlomViewImpl to this class.
3085 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3087 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3088 RPC code to the presenter class (the P in MVP).
3090 2011-04-04 Ben Konrath <ben@bagu.org>
3092 Start moving the existing OnlineGlom code to MVP.
3094 This work is based on the GWT MVP framework that is documented here:
3096 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3098 This is the third commit of a refactor that will allow OnlineGlom to
3099 be used with multiple documents.
3101 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3102 Interface for client factory which is used to get instances of various
3103 classes throughout the app.
3104 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3105 Implementation of client factory.
3106 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3107 initialize the MVP framework.
3108 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3109 New file. Activity manager for the main container widget. This is the
3111 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3112 Maps place (URL) to its corresponding activity.
3113 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3114 New file. This is just a place holder for a generated file.
3115 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
3116 New file. Represents the URL for the main Online Glom app.
3117 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
3118 for changes in LayoutListViewImpl.
3119 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
3120 interface for View. Move code to OnlineGlomViewImpl class.
3121 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
3122 file. Implementation of OnlineGlomView.
3123 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
3124 Place resources. Use ClientFactoryImpl by default.
3126 2011-04-04 Ben Konrath <ben@bagu.org>
3128 Move View classes to their own package.
3130 This is the second commit of a refactor that will allow OnlineGlom to
3131 be used with multiple documents.
3133 * src/main/java/org/glom/web/client/OnlineGlom.java:
3134 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
3135 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
3137 2011-04-02 Ben Konrath <ben@bagu.org>
3139 Move UI code from the main module to its own class.
3141 This is the first commit of a refactor that will allow OnlineGlom to be
3142 used with multiple documents.
3144 * src/main/java/org/glom/web/client/LayoutListView.java: Update
3145 references to OnlineGlom to OnlineGlomView.
3146 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
3147 OnlineGlomView and instantiate it here.
3148 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
3149 represents the main OnlineGlomView with one document.
3151 2011-04-01 Ben Konrath <ben@bagu.org>
3153 Fix formatting of gwt.xml and add DTD.
3155 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
3157 2011-03-30 Ben Konrath <ben@bagu.org>
3159 Propperly convert gdkColor string to html colour string.
3161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3163 2011-03-28 Ben Konrath <ben@bagu.org>
3165 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
3167 This implementation matches
3168 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
3169 readable and is not tied to Swig.
3171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3173 2011-03-28 Ben Konrath <ben@bagu.org>
3175 Use read-only checkboxes for boolean field types.
3177 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
3178 in the CellTable based on the field type. It currently only
3179 distinguishes between boolean and text columns but I'll need to add
3180 support for more types.
3181 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3182 column type in the ColumnInfo object. Add method to convert between the
3183 glom field type enum in ColumnInfo and the glom field type in libglom.
3184 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
3186 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
3187 getting and setting booleans.
3189 2011-03-25 Ben Konrath <ben@bagu.org>
3191 Don't get the Date twice from the ResultSet.
3193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3195 2011-03-25 Ben Konrath <ben@bagu.org>
3197 Cleanup code in the servlet.
3199 * TODO: Remove item about row count. Add item about testing row count
3200 query with large number of rows.
3201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
3202 spelling mistakes, change method parameter to be consistent with
3205 2011-03-25 Ben Konrath <ben@bagu.org>
3207 Add server side logging with the gwt-log library.
3209 * .gitignore: Ignore the log file we're now producing.
3210 * TODO: Add a couple TODO item for logging.
3211 * pom.xml: Add gwt-log and log4j as a dependency.
3212 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3213 logging of errors, warnings and some important info.
3214 * src/main/resources/log4j.properties: New file to configure log4j.
3216 2011-03-24 Ben Konrath <ben@bagu.org>
3218 Add a disable button for the Details view.
3220 * src/main/java/org/glom/web/client/LayoutListView.java:
3222 2011-03-22 Ben Konrath <ben@bagu.org>
3224 Use a count query to get the number of rows for the list view pager.
3226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3228 2011-03-22 Ben Konrath <ben@bagu.org>