1 2011-12-21 Ben Konrath <ben@bagu.org>
3 Protect against NPE when glom.document.locale is not in config.
5 This patch protects against an NPE when glom.document.locale is not in
6 the config file. This NPE will also happen if glom.document.locale is
9 The patch also updates the error message to display the class name when
10 the getMessage() returns null. This was happening when the NPE was
11 thrown and I had "Configuration Error: null". If an NPE is encountered
12 with this patch, "Configuration Error: NullPointerException " will be
15 This commit closes this bug:
17 https://bugzilla.gnome.org/show_bug.cgi?id=666669
19 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
21 2011-12-20 Murray Cumming <murrayc@murrayc.com>
23 Rename onlineglom.properties to onlineglom.properties.sample.
25 * src/main/resources/onlineglom.properties: Rename to:
26 * src/main/resources/onlineglom.properties.sample:
27 * src/main/resources/README: And add this file explaining that people
28 should rename it back when deploying.
30 2011-12-20 Murray Cumming <murrayc@murrayc.com>
32 Allow choosing the translation in the .properties file.
34 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
35 init(): Read a glom.document.locale value from the configuration file
36 and call Glom's TransatableItem::set_current_locale() method.
37 * src/main/resources/onlineglom.properties: Add a commented-out
38 example of this new setting.
40 It would be better to add &lang=de_DE to the URL, but the current
41 libglom API does not allow us to do this easily. I am working on that.
43 2011-12-19 Murray Cumming <murrayc@murrayc.com>
45 Avoid a crash in parsing of token parameters.
47 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
48 ava: getTokenParams(): Do not crash if a parameter has a key but no
49 value, and ignore parameters with neither.
51 2011-12-17 Murray Cumming <murrayc@murayc.com>
53 History token building/handling: Improve use of token parameters.
55 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
56 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
57 and buildParamsToken(HashMap), for use by derived classes.
58 Make the separator private because it is no longer be needed.
59 * src/main/java/org/glom/web/client/place/DetailsPlace.java
60 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
61 instead of manual string concatenation.
62 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
63 of hardcoded indices and awkward splitting code.
64 * src/main/java/org/glom/web/client/place/ListPlace.java
65 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
66 instead of manual string concatenation.
67 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
68 of hardcoded indices and awkward splitting code.
69 This should fix bug #666420
71 2011-12-16 Murray Cumming <murrayc@murrayc.com>
73 Fix a Navgiation->Navigation typo in the code.
75 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
76 Rename processNavgiation() to processNavigation().
78 2011-12-16 Murray Cumming <murrayc@murrayc.com>
80 Fix a seperator->separator typo in the code.
82 * src/main/java/org/glom/web/client/place/DetailsPlace.java
83 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
84 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
87 2011-12-15 Ben Konrath <ben@bagu.org>
89 Cleanup some comments.
91 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
93 2011-12-14 Ben Konrath <ben@bagu.org>
95 Replace \n with <br/> for multiline text in the details view.
97 Vertical scrollbars are added when needed as well.
99 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
101 2011-12-14 Ben Konrath <ben@bagu.org>
103 Specify the font for document selection links.
105 * src/main/webapp/style.css:
107 2011-12-14 Ben Konrath <ben@bagu.org>
109 Fix bouncy CellTable while paging.
111 This doesn't currently work with related list tables in unselected
114 * src/main/java/org/glom/web/client/ui/list/ListTable.java
116 2011-12-14 Ben Konrath <ben@bagu.org>
118 Revamp the appearance of the document selection page.
120 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
121 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
122 * src/main/webapp/style.css:
124 2011-12-13 Ben Konrath <ben@bagu.org>
126 Set navigation button column to the smallest size possible.
128 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
130 2011-12-13 Ben Konrath <ben@bagu.org>
132 Change OpenButton nomenclature to NavigationButton.
134 Using NavigtionButton makes things more generic. Classes, methods and
135 variables have been changed.
137 This is a rename-only refactor.
139 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
140 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
141 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
142 Renamed from OpenButtonCell.
143 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
144 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
145 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
147 2011-12-12 Ben Konrath <ben@bagu.org>
149 Remove unnecessary String argument in RelatedListTable and ListViewTable.
151 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
152 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
153 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
154 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
156 2011-12-12 Ben Konrath <ben@bagu.org>
158 Update variable names and comments.
160 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
161 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
163 2011-12-12 Ben Konrath <ben@bagu.org>
165 Properly initialize numNonEmptyRows variable to zero.
167 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
168 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
170 2011-12-05 Ben Konrath <ben@bagu.org>
172 Add latest mockup with HTML tables.
174 Features of this mockup:
176 -> HTML table for flowtable
177 -> HTML table for flowtable column
178 -> Example of how related lists would look
179 -> Not using text entries for data items
181 The current version of Online Glom doesn't use HTML tables for the
184 This mockup has been sent to the glom-devel mailing list but it's good
185 to have it here as well.
187 * mockups/details-view-html-tables.html:
189 2011-12-05 Ben Konrath <ben@bagu.org>
191 Remove unnecessary getPrimaryKeyField() method.
193 getPrimaryKeyFieldForTable(String) has been renamed to
194 getPrimaryKeyField(String).
196 * src/main/java/org/glom/web/server/database/DBAccess.java:
197 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
198 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
200 2011-12-05 Ben Konrath <ben@bagu.org>
202 Add string representation of TypedDataItem value to conversion error message.
204 * src/main/java/org/glom/web/server/Utils.java: Logging the error
205 message was extracted into its own method to avoid duplication.
207 2011-12-05 Ben Konrath <ben@bagu.org>
209 Add type checking to navigation primary key value creation.
211 Create navigation primary key only if the expected type from the Glom
212 document matches the type returned by the SQL query.
214 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
216 2011-12-05 Ben Konrath <ben@bagu.org>
218 Rename a couple of variables in RelatedListNavigation.
220 This is a rename-only refactor.
222 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
224 2011-12-05 Ben Konrath <ben@bagu.org>
226 Move getListLayoutGroup() into getListViewLayoutGroup().
228 This removes getListLayoutGroup(). It was only being called by
229 getListViewLayoutGroup().
231 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
233 2011-12-05 Ben Konrath <ben@bagu.org>
235 Remove check for LayoutItem_Portal in list table method.
237 This check is no longer necessary because the method isn't being used
238 to create the LayoutItemPortal DTO.
240 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
242 2011-12-05 Ben Konrath <ben@bagu.org>
244 Properly support related list navigation.
246 Navigation from the "Repository Analyzer -> Package Scans ->
247 Dependencies" related table wasn't working because the primary key for
248 related tables wasn't being set properly. This commit fixes the
251 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
252 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
253 doesn't set the primary key properly for related list tables.
254 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
255 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
256 useful for getting the primary key for list view tables and for related
258 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
259 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
260 Move code to set the primary key for the table from the abstract
261 ListDBAccess class to ListViewDBAccess as it's only correct for list
263 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
264 Properly add primary key to related list tables.
266 2011-12-02 Ben Konrath <ben@bagu.org>
268 Properly set the horizontal alignment of fields.
270 This fix is for both the list tables and the details view.
272 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
273 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
274 to set the horizontal alignment of fields.
276 2011-12-02 Ben Konrath <ben@bagu.org>
278 Display currency codes in the details view.
280 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
282 2011-12-02 Ben Konrath <ben@bagu.org>
284 Avoid duplicate JNI call.
286 JNI is not as efficient as pure Java and this is an easy (and small)
289 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
290 Use previously retrieved value for whereClauseToTableName instead of
293 2011-12-02 Ben Konrath <ben@bagu.org>
295 Rename a couple of variables in RelatedListNavigation.
297 This is a rename-only refactor.
299 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
301 2011-12-02 Ben Konrath <ben@bagu.org>
303 Indicate clearly that a mismatched primary key type is a bug.
305 * src/main/java/org/glom/web/server/Utils.java: Change log level from
306 warning to error. Add 'This is a bug.' to message.
308 2011-12-02 Ben Konrath <ben@bagu.org>
310 Update / fix some comments.
312 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
314 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
316 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
317 Fix comments. Add some TODOs.
319 2011-12-02 Ben Konrath <ben@bagu.org>
321 Enable navigation to details view with string primary key from related list.
323 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
324 Create a text primary key value when return type of result is
325 java.sql.Types.VARCHAR.
327 2011-12-02 Ben Konrath <ben@bagu.org>
329 Use checkboxes for booleans in the details view.
331 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
333 2011-12-01 Ben Konrath <ben@bagu.org>
335 Improve performance of related list height calculation.
337 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
338 Put code to calculate the expected height in a static initializer so
339 that that it's only called once.
341 2011-12-01 Ben Konrath <ben@bagu.org>
343 Show related list tables in notebooks (again).
345 Calculate the height of the related list tables so the Notebook can be
346 set the correct height. The height of the related list table is also needed by
347 FlowTable to be able decide how to create the layout.
349 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
350 and set the Portal height based on the height of the related list
351 table and the Portal container.
352 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
353 Add method to calculate the height of the related list tables.
354 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
355 * src/main/webapp/style.css: Add css class for Pager. This is needed to
356 calculate the height of the Pager widget.
358 2011-12-01 Ben Konrath <ben@bagu.org>
360 Use CellTable API for table property instead of setting style on Element.
362 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
364 2011-12-01 Ben Konrath <ben@bagu.org>
366 Make ListViewTable and RelatedListTable a consistent height.
368 The tables are now a consistent height regardless of the contents of
369 the table. A hidden button is added to empty rows to ensure that the
370 height of these rows will match the height of rows with data.
372 A navigation button column is now added to every table. The width of
373 the navigation column is set to 0px when a RelatedListTable shouldn't
374 have navigation buttons. This maintains the a consistent row height in
375 tables that don't show the navigation buttons.
377 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
378 navigation column when not needed.
379 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
380 arguments for navigation button to constructor of ListViewTable.
381 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
382 hidden button for empty data rows.
383 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
384 arguments for navigation button to constructor.
385 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
386 create navigation buttons. Add hideNavigationButtons() method.
387 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
388 arguments for navigation button to constructor.
390 2011-12-01 Ben Konrath <ben@bagu.org>
392 Use 'visibility: hidden' in Utils.getWidgetHeight().
394 This is better choice because hidden elements are invisible, don't
395 respond to events and are not part of the tab order. They will,
396 however, take up space which is required to be able to calculate the
397 height of the widget.
399 * src/main/java/org/glom/web/client/Utils.java:
401 2011-12-01 Ben Konrath <ben@bagu.org>
403 Use Utils.getWidgetHeight() in FlowTable.
405 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
407 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
409 2011-12-01 Ben Konrath <ben@bagu.org>
411 Put the details css class name on the correct table column.
413 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
415 2011-11-30 Ben Konrath <ben@bagu.org>
417 Update for java-libglom API change.
419 The getters and setters on FieldFormatting and NumericFormat were
420 changed to remove the 'M'.
422 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
424 2011-11-29 Ben Konrath <ben@bagu.org>
426 Only allow RelatedListTables in Portals.
428 * src/main/java/org/glom/web/client/ui/details/Portal.java:
430 2011-11-29 Ben Konrath <ben@bagu.org>
432 Only create a contents panel for Portals when title is being set.
434 * src/main/java/org/glom/web/client/ui/details/Portal.java:
436 2011-11-29 Ben Konrath <ben@bagu.org>
438 Set TabLayoutPanel height based on calculated height its widgets.
440 This is a potential fix for this bug:
442 https://bugzilla.gnome.org/show_bug.cgi?id=665133
444 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
446 2011-11-29 Ben Konrath <ben@bagu.org>
448 Align details field labels and data with the Open buttons.
450 * src/main/webapp/style.css:
452 2011-11-29 Ben Konrath <ben@bagu.org>
454 Remove unnecessary <div> in the Notebook widget.
456 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
457 method to get container FlowPanel (<div>).
458 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
459 initWidget() method directly on the TabLayoutPanel widget instead of
460 Group's container widget.
462 2011-11-29 Ben Konrath <ben@bagu.org>
464 Don't add group titles for Portals in Notebooks.
466 This reverts the previous patch and fixes a bug I introduced with
467 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
469 * src/main/java/org/glom/web/client/ui/details/Group.java:
470 * src/main/java/org/glom/web/client/ui/details/Portal.java:
472 2011-11-28 Ben Konrath <ben@bagu.org>
474 Remove unused boolean argument in Portal constructor.
478 * src/main/java/org/glom/web/client/ui/details/Group.java:
479 * src/main/java/org/glom/web/client/ui/details/Portal.java:
481 2011-11-28 Ben Konrath <ben@bagu.org>
483 Remove hack for glom 1.18 style glom files.
485 * src/main/java/org/glom/web/client/ui/details/Group.java:
486 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
487 * src/main/java/org/glom/web/client/ui/details/Portal.java:
489 2011-11-28 Ben Konrath <ben@bagu.org>
491 Use Gda Value version of primary key to log result too large error.
493 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
495 2011-11-28 Ben Konrath <ben@bagu.org>
497 Don't use TypedDataItem.getText() for Unknown types from the URL.
499 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
500 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
501 instead of getText().
502 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
503 String field and getUnknown() method.
505 2011-11-28 Ben Konrath <ben@bagu.org>
507 Log an error message when the java-libglom .so is not present.
509 The error message was being set in the exception but not logged.
511 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
513 2011-11-28 Ben Konrath <ben@bagu.org>
515 Ignore LayoutItem_CalendarPortals.
517 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
518 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
520 2011-11-28 Ben Konrath <ben@bagu.org>
522 Extract method for creating the LayoutItemPortal DTO.
524 Just breaking the code up into smaller chunks.
526 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
528 2011-11-28 Ben Konrath <ben@bagu.org>
532 This should have been added with the refactor. Oops!
534 * src/main/java/org/glom/web/shared/TypedDataItem.java:
536 2011-11-28 Ben Konrath <ben@bagu.org>
538 Create primary key value from URL string using type from Glom document.
540 See this bug, comments 19 - 25:
542 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
544 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
545 create a TypeDataItem for the primary key here when loading from a
546 URL. Show the same string for the primary key value as was received
547 from the URL string (when loading from a URL).
548 * src/main/java/org/glom/web/server/Utils.java: Update method for
549 creating the Gda Value from the TypeDataItem to properly deal with
550 creating a Gda Value based on the Glom document type for the primary
551 key value string when loading from a URL.
552 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
553 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
554 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
555 Update for changed method name.
557 2011-11-27 Ben Konrath <ben@bagu.org>
559 Rename PrimaryKeyItem to TypedDataItem.
561 The name PrimaryKeyItem suggests what the class should be used for.
562 TypedDataItem is a neutral name that describes the class better.
564 This is a rename-only refactor.
566 * src/main/java/org/glom/web/client/OnlineGlomService.java:
567 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
568 * src/main/java/org/glom/web/client/Utils.java:
569 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
570 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
571 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
572 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
573 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
574 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
575 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
576 * src/main/java/org/glom/web/server/Utils.java:
577 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
578 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
579 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
580 * src/main/java/org/glom/web/shared/NavigationRecord.java:
582 2011-11-25 Ben Konrath <ben@bagu.org>
584 Improve Gda Value conversion from PrimaryKeyItem.
586 The value from the PrimaryKeyItem is only used if its type match the
587 type from the glom document.
589 * src/main/java/org/glom/web/server/Utils.java:
591 2011-11-25 Ben Konrath <ben@bagu.org>
593 Manually check if the java-liblgom .so is visible to the JVM.
595 It seems that Tomcat has problems when a static initializer throws an
596 exception. This check is done before the first method call into
597 java-libglom so that execution doesn't continue if the .so is not
600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
602 2011-11-25 Ben Konrath <ben@bagu.org>
604 Improve browser configuration error messages.
608 https://bugzilla.gnome.org/show_bug.cgi?id=662792
610 * src/main/java/org/glom/web/client/OnlineGlomService.java:
611 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
612 getConfigurationErrorMessage() method.
613 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
614 Get and display a specific configuration error message when no Glom
616 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
617 Implement getConfigurationErrorMessage() method. Surround configuration
618 code in the init() method with a try/catch block. This allows the
619 errors to be caught while keeping the servlet available to retrieve the
620 configuration error message.
622 2011-11-25 Ben Konrath <ben@bagu.org>
624 Don't use Strings to hold primary key values.
626 The primary key values are now held in a new data object
627 (PrimaryKeyItem) that holds type information and the primary key value
628 using the correct type.
630 * src/main/java/org/glom/web/client/OnlineGlomService.java:
631 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
632 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
633 PrimaryKeyItem instead of String to hold the primary key value.
634 * src/main/java/org/glom/web/client/Utils.java: Remove
635 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
636 PrimaryKeyItem based on the GlomFieldType and the DataItem.
637 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
638 PrimaryKeyItem instead of String to hold the primary key value. Load
639 document selection page when the documentID has not been set correctly.
640 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
641 DetailsPlace -> URL and URL -> DetailsPlace conversion with
643 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
644 Return empty string for URL instead of "null".
645 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
646 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
647 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
648 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
649 PrimaryKeyItem instead of String to hold primary key values.
650 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
651 PrimaryKeyValue to a Gda Value.
652 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
653 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
654 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
655 Replace temporary database access code that uses the PrimaryKeyValue to
656 Gda Value conversion.
657 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
658 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
659 PrimaryKeyItem instead of String.
660 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
661 hold primary key values.
663 2011-11-24 Ben Konrath <ben@bagu.org>
665 Use newly added java-libglom API to create queries.
667 This isn't finished. I still need to stop using Strings for primary key
668 values in the client code.
670 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
671 libglom to use fake connections so that retrieving the query string will
673 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
674 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
675 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
676 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
677 Use the newly added libglom sql methods and classes to create the
678 query. Add temporary hack to convert primary value strings to Gda
681 2011-11-23 Ben Konrath <ben@bagu.org>
683 Don't explicitly set the height of Portals.
685 See comments 6 - 10 of this bug for details:
687 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
689 * src/main/java/org/glom/web/client/ui/details/Portal.java:
691 2011-11-23 Ben Konrath <ben@bagu.org>
693 Use an HTML table instead of CSS for the FlowTable layout.
695 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
696 GWT's FlexTable to implement the FlowTable.
697 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
699 2011-11-18 Ben Konrath <ben@bagu.org>
701 Add boolean example to HTML table mockup.
703 * mockups/details-view-html-tables-text-entries.html:
705 2011-11-17 Ben Konrath <ben@bagu.org>
707 Ensure the pager buttons are always visible for related lists.
709 To accomplish this, I've turned off text wrapping in the list view and
710 related list tables for both the header and data text. The related list
711 table now has a fixed layout so the it doesn't overflow its container.
712 This is required to ensure that the cell text is clipped when it
713 overflows the cell and an ellipsis is added to the right side of the
714 cell when text is clipped.
716 A fixed table layout for the related list table in the details view
717 seems what we want for the details view anyway, so the side-effect is
720 The ellipsis will only be displayed in Firefox >= 7.
724 https://bugzilla.gnome.org/show_bug.cgi?id=662930
726 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
727 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
728 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
730 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
731 Set the 'table-layout: fixed' CSS property to the related list table.
732 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
733 'white-space: nowrap;' CSS property on both the list view and the
736 2011-11-16 Ben Konrath <ben@bagu.org>
738 Rework the fix for empty notebook tab labels.
740 Setting the empty group titles with its name caused problems for the
741 details layout. Instead of using libglom's
742 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
743 to the client when the title is empty. This allows the Notebook to use
744 the name when the title is empty without affecting anything else.
746 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
747 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
749 2011-11-16 Ben Konrath <ben@bagu.org>
751 Set group titles with name when title is empty.
753 This fixes a problem with an empty notebook tab label in the Lesson
754 Planner document. The forth tab in the notebook should be "Internet":
756 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
758 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
759 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
762 2011-11-16 Ben Konrath <ben@bagu.org>
764 Remove whitespace from the configured username properties.
766 This assumes that usernames won't have whitespace at the beginning
767 or end. But I think this is a reasonable assumption.
769 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
770 String.trim() to remove the whitespace from the username properties.
772 2011-11-15 Ben Konrath <ben@bagu.org>
774 Add details view mockup with HTML tables and text entries.
776 This is from the attachment on this bug:
778 https://bugzilla.gnome.org/show_bug.cgi?id=663109
780 * mockups/details-view-html-tables-text-entries.html:
782 2011-11-15 Ben Konrath <ben@bagu.org>
784 Add space between the columns of the flow table.
788 https://bugzilla.gnome.org/show_bug.cgi?id=662918
790 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
791 space between columns in the flow table.
793 2011-11-15 Ben Konrath <ben@bagu.org>
795 Add backup files to the .gitignore.
797 * .gitignore: Ignore files that end with ~.
799 2011-11-09 Ben Konrath <ben@bagu.org>
801 Use latest release of gwt-log.
803 Gwt-log releases are now being submitted to the maven central
804 repository so manual installation of the jar is no longer required.
806 * pom.xml: Update version and groupId of gwt-log dependency.
808 2011-10-31 Ben Konrath <ben@bagu.org>
810 Don't use GWT numeric formatting to override the glom currency formatting.
812 Currencies are now displayed like they are in Glom. See this bug:
814 https://bugzilla.gnome.org/show_bug.cgi?id=646216
816 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
818 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
819 currency code to constructor and set it when the cell is rendered.
820 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
821 currency code to the constructor of the NumericCell.
823 2011-10-27 Ben Konrath <ben@bagu.org>
825 Require the latest release of java-libglom (1.17.4).
829 2011-10-26 Ben Konrath <ben@bagu.org>
831 Add style to Notebook that matches current theme.
833 It's not the best style in the world but it's better than the default.
835 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
836 padding at the bottom of the child widgets.
837 * src/main/webapp/style.css: Add style for the Notebook.
839 2011-10-26 Ben Konrath <ben@bagu.org>
841 Move servlet initialization code to overridden init method.
843 This is half of the solution to getting proper error messages
844 displayed when configuration errors occur. Here's the relevant bug:
846 https://bugzilla.gnome.org/show_bug.cgi?id=662792
848 The rest of the solution involves surrounding the init method with a
849 try/catch block and setting a global variable with the error /
850 exception. A new async method should be created to retrieve and display
851 the error message / exception.
853 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
854 code from constructor to init method adding exceptions as needed.
856 2011-10-26 Ben Konrath <ben@bagu.org>
858 Add script to monitor and restart tomcat if required.
860 * utils/check-and-recover-tomcat.py: New file.
862 2011-10-26 Ben Konrath <ben@bagu.org>
864 Display the correct number of data items in the pager.
868 https://bugzilla.gnome.org/show_bug.cgi?id=661441
870 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
871 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
872 The implementation is the same for both tables: Keep track of the
873 number of non-empty rows and fire and RowCountChangeEvent after the data has
875 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
876 custom Pager class that subclasses SimplePager to handle displaying
877 the correct number when empty rows have been added.
879 2011-10-26 Ben Konrath <ben@bagu.org>
881 Correct error in previous commit.
883 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
884 eventBus parameter from listView.setCellTable().
886 2011-10-26 Ben Konrath <ben@bagu.org>
888 Fix error in TODO comment.
890 * src/main/java/org/glom/web/client/activity/ListActivity.java:
892 2011-10-24 Ben Konrath <ben@bagu.org>
894 Create Notebook widgets to the details view.
896 This isn't finished just yet - I still need to create a reasonable
897 style to match the current theme.
899 * src/main/java/org/glom/web/client/Utils.java: Add method for
900 calculating the height of a widget. This is used in the Notebook class.
901 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
902 new constructor method in Group.
903 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
904 method for creating child widget that can be used by subclasses
905 like Notebook. New constructor that allows disabling the group
906 titles - Notebooks don't set a group title for their child groups.
907 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
908 to make Notebooks using GWT's TabLayoutPanel.
909 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
910 constructor that allows disabling the group titles.
911 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
912 LayoutItemNotebook DTO.
913 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
914 DTO for Notebooks. It's just an empty class for now but we might need
915 it to transfer some specific information in the future.
917 2011-10-21 Ben Konrath <ben@bagu.org>
919 Add navigation buttons to related list tables.
921 * src/main/java/org/glom/web/client/OnlineGlomService.java:
922 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
923 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
924 method getSuitableRecordToViewDetails() for getting the table name
925 and primary key value for related list navigation buttons.
926 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
927 private cell renderer class to get the navigation information for
928 related list tables from the server. Extract the navigation
929 processing code from the details cell navigation and use it for the
930 related list navigation as well.
931 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
932 cell renderer class for the details open buttons. This was needed
933 because the related list navigation buttons and the list view
934 navigation buttons need to react differently when clicked.
935 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
936 the onEnterKeyDown() method because it's now overriden in the
937 subclasses that are specific to the related list tables and the list
939 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
940 the vertical size a little because the buttons add a bit of vertical
941 space to table. This is not a perfect solution because the vertical
942 size of with table fewer than 5 rows will be a little smaller.
943 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
944 changes in how navigation buttons are handled.
945 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
946 getSuitableRecordToViewDetails() using the new RelatedListNavigation
947 database access object.
948 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
949 to find the portal for a given relationship name from
950 RelatedListDBAccess. Add method to find a primary key field for a
952 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
953 Move code to find the portal for a given relationship name to
955 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
956 New file: database access object for getting the related list
957 navigation information (the table name and the primary key value).
958 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
959 DTO for transferring a table name to navigate to and a primary key
961 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
962 boolean and getter/setter to specifies if the related list should add
965 2011-10-24 Murray Cumming <murrayc@murrayc.com>
967 Use the master branch of java-libglom
969 * pom.xml: Depend on java-libglom 1.19 instead.
971 This is the master branch. See also the libglom-1-18 branch.
973 2011-10-11 Ben Konrath <ben@bagu.org>
975 Enable the open navigation button when the data has been set.
977 This avoids having active buttons that don't do anything when the data
980 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
982 2011-10-11 Ben Konrath <ben@bagu.org>
984 Use IsWidget interface for FlowTableItem.
986 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
987 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
989 2011-10-11 Ben Konrath <ben@bagu.org>
991 Remove GWT styling from open button in details view.
993 There are still some issues with how the details cell is arranged but
994 this should be made to match Glom 1.20. I'm going to leave fixing this
995 until I have Glom 1.20 up and running.
997 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
998 style name on open button.
999 * src/main/webapp/style.css: Move and edit details-navigation class.
1000 Re-arrange some classes to make them appear in the same order as the
1003 2011-10-07 Ben Konrath <ben@bagu.org>
1005 Update to GWT 2.4.0.
1007 * .gitignore: Ignore new cache directory.
1008 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1009 * pom.xml: Change GWT and maven plugin to 2.4.0.
1010 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1012 * src/main/java/org/glom/web/client/ClientFactory.java:
1013 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1014 * src/main/java/org/glom/web/client/OnlineGlom.java:
1015 Update source for API changes.
1016 * utils/build-onlineglom-war.sh: Remove cache directory before the
1019 2011-10-07 Ben Konrath <ben@bagu.org>
1021 Add navigation buttons in the details view.
1023 This isn't finished but I thought I'd commit what I have as it's a
1024 pretty good start. I still need to:
1026 1. Change the style so that it fits better into the current theme
1027 2. Adjust the details cell to expand as much as possible.
1029 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1030 click handlers to navigation buttons in the DetailsCells. Create a
1031 refreshData() method to get just the data from the server without the
1033 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1034 Update the tableSelector and browser title when the table name
1035 changes without using the tableSelector.
1036 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1037 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1038 getDetailsCells() to getCells(). Update variable names.
1039 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1040 method to set click handler on navigation button. Rename a few
1041 variables. Add navigation buttons where needed.
1042 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1043 variables and methods.
1044 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1045 navigation boolean and navigation table as required in the
1046 LayoutItemField DTO.
1047 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1048 variables for navigation along with getter/setter methods.
1050 2011-10-07 Ben Konrath <ben@bagu.org>
1052 Rename Field to DetailsCell.
1054 This is a refactor-only commit. No functionality has been added or
1057 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1058 Update variable and method names.
1059 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1060 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1061 variable and method names.
1062 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1064 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1065 variable and method names.
1067 2011-10-07 Ben Konrath <ben@bagu.org>
1069 Create separate methods for layout and data the details view.
1071 This is a refactor-only commit. No functionality has been added or
1074 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1075 private methods: setData(), createLayout().
1077 2011-10-07 Ben Konrath <ben@bagu.org>
1079 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1081 This is part of a change to get navigation buttons in the details view
1082 but it should have been done this way from the start.
1084 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1085 for method name change in TableSelectionView.
1086 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1087 Create TableChangeEvent and set the browser title using the
1088 TableSelectionView API.
1089 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1090 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1091 Change getSelectedTable() to getSelectedTableName(). Add
1092 getSelectedTableTitle().
1094 2011-10-07 Ben Konrath <ben@bagu.org>
1096 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1098 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1100 2011-10-07 Ben Konrath <ben@bagu.org>
1102 Update TableChangeEvent to use newTableName naming convention.
1104 This makes the class more consistent with GWT naming conventions.
1106 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1107 Update for method name change in TableChangeEvent.
1108 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1109 for method name change in TableChangeEvent.
1110 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1111 newTableName variable and getter method. Make toDebugString()
1114 2011-09-30 Ben Konrath <ben@bagu.org>
1116 Disable the pager in the list tables when the data row count is less than the minimum.
1118 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1119 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1121 2011-09-30 Ben Konrath <ben@bagu.org>
1123 Add empty rows to the end of related list and list view tables.
1125 I also extracted the cell rendering classes from the ListTable because
1126 the code was becoming a little crazy with all the anonymous inner
1127 classes. My plan is to use these cell rendering classes in the details
1128 view as well so this refactor will be needed for that change.
1130 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1131 set the row count in related list tables if the data has more rows
1132 than the minimum number of rows visible.
1133 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1134 row count in list view tables if the data has more rows than the
1135 minimum number of rows visible.
1136 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1137 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1139 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1140 for rendering TYPE_NUMERIC cells. The code was extracted from the
1142 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1143 class for rendering cells with buttons in list views. The code was
1144 extracted from the ListTable class.
1145 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1146 for rendering TYPE_TEXT cells. The code was extracted from the
1148 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1149 Add empty rows to the end of the data if required. Implement
1150 ListTable.getMinNumVisibleRows().
1151 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1152 cell renderer code to public classes. Return null in
1153 Column.getValue() for empty rows. Add new abstract method:
1154 getMinNumVisibleRows(). Move code to set the row count of the list view
1155 table to ListViewImpl.
1156 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1157 empty rows to the end of the data if required. Implement
1158 ListTable.getMinNumVisibleRows().
1161 2011-09-27 Ben Konrath <ben@bagu.org>
1163 Use GWT.log for client-side debugging statements.
1165 These are optimized out when deployed so I should have used this method
1166 in the first place. These statements will eventually be replaced with some sort
1167 of notification in the browser.
1169 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1170 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1171 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1172 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1173 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1175 2011-09-27 Ben Konrath <ben@bagu.org>
1177 Put tableselector on the right, back to list link on right.
1179 The idea is that the table selector is acting like a label for the
1180 currently displayed table so it should be placed below the document title. This
1181 puts the table title in a similar position to where it is in Glom.
1183 * mockups/details-contacts.html:
1184 * mockups/details-projects.html:
1185 * mockups/listview-contacts.html:
1186 * mockups/listview-projects.html:
1187 * mockups/style.css:
1188 Update mockups to match how the interfaces currently look.
1189 * src/main/webapp/style.css: Swap positions of backlink with the table
1190 selector. Add some space on the left side of the table selector to
1191 line things up with the document title.
1193 2011-09-27 Ben Konrath <ben@bagu.org>
1195 Add field colouring to details view.
1197 This change re-works how field colouring works. The colour formatting
1198 information is now set to the client with the layout information instead of
1199 with the data. This eliminates the need to send the same colour strings for
1200 data in list view column when colour information is set.
1202 In order to set an alternate colour for negative numeric values, the
1203 number is now sent to client and formatted with the GWT NumberFormat class.
1205 This change also fixes:
1207 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1209 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1210 internationalization framework which is needed for client side numeric
1212 * src/main/java/org/glom/web/client/Utils.java: New file for some
1213 client static utility methods.
1214 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1215 the DataItem object to the Field class. Use a utility method to
1216 create the foreignKeyValue string.
1217 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1218 alignment and text colours in the constructor. Add setData(DataItem)
1219 method. Remove setText(String) method.
1220 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1221 colour information to GlomTextCell. Create and use GlomNumberCell for
1222 rendering numbers. Use utility method to get the string for the
1223 primary key of the key provider. Re-work how the horizontal alignment
1225 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1226 formatting to layout information. Methods for converting the libglom
1227 formatting information were moved from DBAccess.
1228 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1229 numeric formatting (it's now done on the client side). Don't set text
1230 colours in DataItem. Move libglom formatting conversion methods to
1232 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1233 getters/setters for text colour information.
1234 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1235 for transferring the libglom NumericFormat information to the client.
1236 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1237 and getters/setters for: GlomNumericFormat, background colour and
1238 foreground colour strings.
1240 2011-09-26 Ben Konrath <ben@bagu.org>
1242 Simplify code that iterates through the LayoutGroup.
1244 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1246 2011-09-26 Ben Konrath <ben@bagu.org>
1248 Accept Eclipse formatting for OnlineGlomServiceAsync.
1250 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1252 2011-09-26 Ben Konrath <ben@bagu.org>
1254 Don't use the ListDBAccess classes to get the primary key layout information.
1256 This was causing a bug where the wrong index for the hidden primary key
1257 was being sent to the client.
1259 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1260 primary key while creating the LayoutGroup DTO. Create a
1261 LayoutItemField DTO for hidden primary keys. Don't use the
1262 RelatedListDBAccess because it was only used for getting the primary
1264 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1265 access modifier from public to protected for getPrimaryKeyField() and
1266 getPrimaryKeyLayoutItemField().
1267 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1268 abstract method getExpectedResultSize() because RelatedListDBAccess
1269 doesn't have enough info to implement it.
1270 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1271 Remove @Override for getExpectedResultSize().
1272 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1273 Remove method getExpectedResultSize().
1275 2011-09-23 Ben Konrath <ben@bagu.org>
1277 Log which layout (list or details) the ignored item is from.
1279 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1281 2011-09-23 Ben Konrath <ben@bagu.org>
1283 Remove annotations that turn off code formatting in DataItem.
1285 * src/main/java/org/glom/web/shared/DataItem.java:
1287 2011-09-23 Ben Konrath <ben@bagu.org>
1289 Rename GlomField to DataItem and update associated methods.
1291 This is a rename-only refactor. No functionality has been added or
1294 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1295 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1296 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1297 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1298 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1299 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1300 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1301 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1302 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1303 * src/main/java/org/glom/web/server/database/DBAccess.java:
1304 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1305 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1306 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1307 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1308 * src/main/java/org/glom/web/shared/DataItem.java:
1309 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1310 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1312 2011-09-23 Ben Konrath <ben@bagu.org>
1314 Rename GlomDocument to DocumentInfo and update associated methods.
1316 This is a rename-only refactor. No functionality has been added or
1319 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1320 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1321 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1322 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1323 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1324 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1325 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1327 2011-09-20 Ben Konrath <ben@bagu.org>
1329 Require java-libglom 1.17.3.
1331 This picks up the fix for the seg fault problem with the Scenes table
1332 in the Openismus Film Manager example.
1336 2011-09-20 Ben Konrath <ben@bagu.org>
1338 Change the way sort clause is added for primary key when no sort clause is requested.
1340 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1341 before the sort clause is created. When a sort clause is not requested, the
1342 sort clause is created by finding the primary key in the LayoutFieldVector
1345 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1347 2011-09-20 Ben Konrath <ben@bagu.org>
1349 Log error message if no documents are found in the configured directory.
1351 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1352 Extract the glom file extension string to a private static final class
1353 variable (mostly as syntactic sugar). Accept a minor formatting change.
1354 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1355 the example glom.document.directory configuration property to make it
1356 more clear that it can any directory, not just the home directory.
1358 2011-09-18 Ben Konrath <ben@bagu.org>
1360 Add related lists to details view.
1362 The related list table has support for paging and sorting just like the
1363 table in the list view.
1365 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1366 SQL queries for the related list tables.
1367 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1368 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1370 Rename getList methods to getListView and add comments. Remove
1371 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1372 it being unused. Add methods: getDetailsLayoutAndData(),
1373 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1374 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1375 Create the layout and set the data for the fields in one async call
1376 instead of two. Create related lists where appropriate.
1377 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1378 for method name changes in OnlineGlomService.
1379 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1380 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1381 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1383 * src/main/java/org/glom/web/client/ui/ListView.java:
1384 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1385 tableName from setCellTable(). Create a ListViewTable instead of
1387 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1388 represent a data field in the details view.
1389 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1390 from addDetailsCell() to Field class. Keep track of the Fields and
1391 Portals in the details view.
1392 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1393 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1394 and add a method to get it. Add method to set the contents of the
1396 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1397 New class for related list tables. This class has the data provider
1398 for the related list table.
1399 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1400 abstract class which is the base class for the ListViewTable and the
1402 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1403 New class for list view tables. This class has the data provider for
1404 the list view table.
1405 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1406 methods for related list tables. Add more information to the
1407 LayoutItemField and LayoutItemPortal DTOs.
1408 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1409 Remove debugging print statement.
1410 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1411 Remove debugging print statements. Add primary key field to SQL count
1413 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1414 Remove unnecessary LayoutFieldVector parameter from
1415 getResultSizeOfSQLQuery() method.
1416 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1417 New class for related list table database access.
1418 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1419 class that is a wrapper DTO for details view layout and data.
1420 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1421 new 'fromField' string to this DTO.
1422 * src/main/webapp/style.css: Remove bottom margin and override top
1425 2011-09-15 Ben Konrath <ben@bagu.org>
1427 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1429 This sets things up to make it easier to add the data retrieval for
1430 related lists (portals). No user noticeable changes were made with
1433 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1434 class has the code to retrieve the layouts and access the
1435 database using the new database helper classes.
1436 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1437 Most of the functionality has been removed from this class. This
1438 class now represents the public interface for the client side
1439 code. It also deals with configuring the servlet and cleaning
1440 things up when the servlet is stopped.
1441 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1442 of static methods into this utility class.
1443 * src/main/java/org/glom/web/server/database/DBAccess.java:
1444 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1445 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1446 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1447 These classes have the database retrieval code. The class hierarchy
1448 has been setup to make it easy to reuse code for similar
1451 2011-09-06 Ben Konrath <ben@bagu.org>
1453 Create separate classes for list table code and the data provider.
1455 As part of this refactor, I also split up the code a bit to make it
1458 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1459 table code to two new classes (below).
1460 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1461 with code from ListViewImpl.
1462 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1463 New file with code from ListViewImpl.
1465 2011-09-06 Ben Konrath <ben@bagu.org>
1467 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1469 This fixes the LayoutItemPortal DTO to match the libglom layout object
1472 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1474 2011-09-01 Ben Konrath <ben@bagu.org>
1476 Set title of Portals in the Details View.
1478 * pom.xml: Bump required version of java-libglom to 1.17.1.
1479 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1480 widget creation to its own class. Add comments to constructor.
1481 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1482 The code is mostly from the Group class with the title now set.
1483 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1484 title of Portal. Update some comments. Fix some code formatting.
1486 2011-09-01 Ben Konrath <ben@bagu.org>
1488 Remove TODO comment for the flow table column width.
1490 The flow table column width is working correctly and doesn't need to be
1491 changed. See this mailing list post for more info:
1493 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1495 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1497 2011-08-27 Ben Konrath <ben@bagu.org>
1499 Add document title (database name) to top of the browser page.
1501 I added the document title to the TableSelecitonView but that will
1502 change if / when we add a view that doesn't require table selection.
1504 * mockups/details-contacts.html:
1505 * mockups/details-projects.html:
1506 * mockups/listview-contacts.html:
1507 * mockups/listview-projects.html:
1508 * mockups/style.css: Add document title to mockups to keep things
1510 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1511 sizes to account for the document title.
1512 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1513 Set the document title when it has been retrieved from the server.
1514 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1515 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1516 and implement setDocumentTitle(String) method.
1517 * src/main/webapp/style.css: Add ID for document title style.
1519 2011-08-25 Ben Konrath <ben@bagu.org>
1521 Add NavigationType enum to LayoutItemPortal DTO.
1523 This is the start of adding support for Portals to the Details View.
1525 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1526 LayoutItem_Portal.navigation_type enum from libglom to
1527 LayoutItemPortal.NavigationType enum.
1528 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1529 NavigationType enum, field for storing the NavigationType and getter
1532 2011-08-25 Ben Konrath <ben@bagu.org>
1534 Implement the flow table layout in the Details View.
1536 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1537 FlowTable to Group to account for the renamed class.
1538 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1539 File. This is a container widget that implements the Glom details view
1540 flow table behaviour.
1541 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1542 org/glom/web/client/ui/FlowTable.java.
1543 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1544 so that the size of the subgroups are a closer match to the size of
1545 the Glom subgroups. This makes the flowtable layout match the layout
1546 in Glom for the Music Collection example file.
1548 2011-08-16 Ben Konrath <ben@bagu.org>
1550 Create container element for LayoutItemPortal in Details View.
1552 This will help me develop the layout for the FlowTable.
1554 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1555 fieldPanel variable to detailsCell.
1557 2011-08-15 Ben Konrath <ben@bagu.org>
1559 Set the height of the data element in the Details View.
1561 I changed the InlineLabels (text in a span element) to Labels (text in
1562 a div element) so that I could set the height of the details-data
1563 elements instead of the details-cell parent elements. This allows the
1564 the details-data element to display the correct height if style is
1565 applied that shows the height.
1567 This change has the added benefit of allowing the order of the labels
1568 and data elements to be changed for right-to-left languages.
1570 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1571 InlineLabels to Labels.
1572 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1573 InlineLabels to Labels. Set the height of the data element.
1574 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1575 multiline text height in the Formatting DTO.
1576 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1577 for multiline height along with getter and setter methods.
1578 * src/main/webapp/style.css: Adjust style to account for the change
1579 from span elements to div elements in the details cell.
1581 2011-08-15 Ben Konrath <ben@bagu.org>
1583 Make the List View appearance match the mockups.
1585 It doesn't match exactly but it's much better than it was.
1587 * mockups/listview-contacts.html: Remove unused css classes.
1588 * mockups/listview-projects.html: Remove unused css classes.
1589 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1590 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1591 for mainPanel instead of VerticalPanel (table). Set style name on
1592 CellTable. Set style name on Details column. Right-align Details
1594 * src/main/webapp/style.css: Adjust properties to match the mockups.
1596 2011-08-12 Ben Konrath <ben@bagu.org>
1598 Add better support for subgroups in the details view.
1600 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1601 changed FlowTable constructor.
1602 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1603 support for subgroups and subgroup-titles.
1604 * src/main/webapp/style.css: Add CSS class for subgroups and
1607 2011-08-12 Ben Konrath <ben@bagu.org>
1609 Return the top level LayoutGroup title.
1611 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1613 2011-08-11 Ben Konrath <ben@bagu.org>
1615 Make the TableSelector header match the mockup.
1617 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1618 the layout panel. Properly lineup the table selection header with
1619 the list and details view.
1620 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1621 margin around the details view.
1622 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1623 Rename listBox variable to tableSelector. Set id for the style sheet.
1624 Use a FlowPanel instead of a HorizontalPanel.
1625 * src/main/webapp/style.css: Add properties to make the TableSelector
1626 box match the mockups.
1628 2011-07-13 Ben Konrath <ben@bagu.org>
1630 Update install script for java-libglom version change.
1632 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1635 2011-07-13 Ben Konrath <ben@bagu.org>
1637 Add support sub-group in the details view.
1639 I also removed the code that special-cased the default details view
1642 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1644 I still have to make a proper flowtable.
1646 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1647 Don't special-case default details view layout.
1648 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1649 addLayoutField() as I'm going to use it.
1650 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1651 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1653 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1654 extracted from DetailsViewImpl.GroupPanel. Add support for
1656 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1657 column count when getting the details layout.
1659 2011-07-12 Ben Konrath <ben@bagu.org>
1661 Set browser title with database and table titles.
1663 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1664 Set the browser title when the table changes and when the activity
1666 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1667 title when retrieving document info (the GlomDocument object).
1668 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1669 with getter and setter methods. Remove unused convenience constructor.
1670 Use default code formatting.
1672 2011-07-12 Ben Konrath <ben@bagu.org>
1674 Ignore LayoutItemPortals in the details view.
1676 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1679 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1680 LayoutItemPortal layout objects.
1681 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1682 LayoutItemPortal objects when retrieving the details layout.
1683 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1684 file. This is an empty class and just used to get type information for
1687 2011-07-12 Ben Konrath <ben@bagu.org>
1689 Use java-libglom 1.17.0.
1693 2011-07-11 Ben Konrath <ben@bagu.org>
1695 Remove "Table:" label from table selector.
1697 This matches a recent change in the Glom UI.
1699 * mockups/details-contacts.html:
1700 * mockups/details-projects.html:
1701 * mockups/listview-contacts.html:
1702 * mockups/listview-projects.html: Remove the "Table:" label from the
1704 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1706 2011-07-11 Ben Konrath <ben@bagu.org>
1708 Add main groups to the details view.
1710 This makes things look a little nicer in the details view. The next step
1711 is to implement the flowtable.
1713 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1714 resources from the standard gwt css theme. Standard.css is now
1715 included in OnlineGlom.html so that the online glom css rules have
1716 precedence over the gwt theme.
1717 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1718 the whole LayoutGroup to the DetailsView instead of just the titles.
1719 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1720 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1721 details layout with a helper class (GroupPanel). I might extract this
1722 class when I make the full flowtable.
1723 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1724 string as default so I don't have to worry about NPEs when processing
1726 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1727 note beside OnlineGlom.gwt.xml above).
1728 * src/main/webapp/style.css: Add default font-size to body to override
1729 the font-size set by the standard theme. Don't use h2 tags for
1730 group-title. Create new details-cell class.
1732 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1734 ConfiguredDocument: Set the port number too.
1736 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1737 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1738 Glom document. Presumably this worked sometimes so far because there is a
1739 default port number.
1741 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1743 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1745 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1746 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1747 correct, though we should throw an exception too.
1749 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1751 Fix a addDocuemnt typo.
1753 * src/main/java/org/glom/web/shared/Documents.java
1754 (Documents.addDocuemnt): Rename to addDocument().
1755 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1756 (OnlineGlomServiceImpl.getDocuments): Adapt.
1758 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1760 Slightly improved log output when connection fails.
1762 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1763 (ConfiguredDocument.setUsernameAndPassword):
1764 We don't know for sure if it' the username/password that's wrong, so
1765 rephrase the message.
1766 Also ouput the exception message, though it's generic in this case.
1768 2011-07-08 Ben Konrath <ben@bagu.org>
1772 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1773 added braces to a one line if statement because the Eclipse formatter
1774 was getting confused.
1776 2011-07-07 Ben Konrath <ben@bagu.org>
1778 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1780 These should really be two separate tasks but I counldn't get things to
1781 work with GWT 2.2.0 and Eclipse 3.7.
1785 * .settings/org.eclipse.jdt.core.prefs:
1786 * .settings/org.eclipse.jdt.ui.prefs:
1787 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1788 * .settings/org.eclipse.m2e.core.prefs:
1789 Add new config files. Update current files. Remove references to the
1790 webtools plugins as we're not using any of the webtools features.
1791 * .gitignore: Add logs directory which is created when running with
1793 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1794 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1795 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1797 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1799 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1801 onlineglom.properties: Add explanatory comments.
1803 * src/main/resources/onlineglom.properties: Also change the default user
1804 from ben to someuser, to avoid the risk of people thinking we just
1805 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1807 2011-06-28 Ben Konrath <ben@bagu.org>
1809 Use filename in Log for incorrect passwords.
1811 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1812 getFileName(String) method to get the filename from the URI.
1814 2011-06-28 Ben Konrath <ben@bagu.org>
1816 Add the table name to the URL token for the ListPlace.
1818 This makes things consistent between the DetailsPlace and the
1819 ListPlace. It also allows the the ListPlace to be bookmarked.
1821 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1822 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1823 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1824 Remove getDefaultListLayout(). The default layout is now returned
1825 by the getListLayout() method when the table name is an empty string.
1826 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1827 Add table name field. Change to a new ListPlace when the table
1828 has been changed. Use getListLayout() for getting the default
1830 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1831 Add table name field. Set the correct table name in the list box
1832 when loading from bookmark. This corrects a problem for the
1834 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1835 Move table name to super-class (HasSelectableTable). Move document
1836 and table URL keys to super-class in HasSelectableTable.
1837 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1838 Add table name field. Add Tokenizer class with URL key common to
1839 the subclasses (DetailsPlace and ListPlace).
1840 * src/main/java/org/glom/web/client/place/ListPlace.java:
1841 Add table name. Add code to parse the URL token.
1842 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1843 Update ListPlace construction with empty table name string.
1844 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1845 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1846 Change setTableSelectedIndex(int) to setSelectedTableName(String).
1847 Update ListPlace construction with table name string.
1848 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1849 Change defaultTableName field to tableName to reflect how it's now
1850 used. Update the getter and setter methods.
1852 2011-06-28 Ben Konrath <ben@bagu.org>
1854 Enable the table selector in the DetailsView.
1856 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1857 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1858 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1859 Remove getDefaultDetailsLayout(). The default layout is now returned
1860 by the getDetailsLayout() method when the table name is an empty
1862 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1863 event handler for table change event. Change to using
1864 getDetailsLayout() for the default details layout.
1865 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
1867 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
1868 when navigating to the details place.
1870 2011-06-27 Ben Konrath <ben@bagu.org>
1872 Use filename based unique document ID in URL and for RPC.
1874 The document ID is the glom document name with spaces (' ') replaced
1875 with pluses ('+') and without the .glom extension.
1877 This change is mostly a string substitution of 'documentTitle' for
1878 'documentID'. The only code change is the addition of a Documents DTO to get the
1879 filename to document title mappings as indicated below.
1881 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1882 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1883 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1884 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1885 Use Documents DTO to create the document links in the document
1887 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1888 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1889 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1890 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1891 * src/main/java/org/glom/web/client/place/ListPlace.java:
1892 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1893 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1894 * src/main/java/org/glom/web/client/ui/ListView.java:
1895 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1896 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1897 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1898 * src/main/java/org/glom/web/server/Log.java:
1899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
1900 getDocumentTitles() to getDocuments() and return the Documents DTO.
1901 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
1902 transferring the filename to document title mappings.
1904 2011-06-25 Ben Konrath <ben@bagu.org>
1906 Make the authentication popup work again.
1908 This bug was introduced when I extracted ConfiguredDocument to its own class.
1910 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
1911 correct success / fail status in setUsernameAndPassword().
1913 2011-06-25 Ben Konrath <ben@bagu.org>
1915 Use filename as unique key for configuring database usernames and passwords.
1917 This replaces the use of the Glom document title which could change
1918 depending on the locale. Thanks to Murray Cumming for pointing out this
1921 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1922 * src/main/resources/onlineglom.properties:
1924 2011-06-24 Ben Konrath <ben@bagu.org>
1926 Pass primary key value to DetailsView.
1928 This enables the DetailsView to load the correct data.
1930 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1931 primary key value field and set in constructor. Pass primary key
1932 value to getDetailsData().
1933 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
1934 variables for document title and primary key value.
1935 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
1936 key value to the DetailsPlace.
1938 2011-06-24 Ben Konrath <ben@bagu.org>
1940 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
1942 This allows the primary key to be retrieved by the Details button. This
1943 functionality has not been implemented yet but it's in the works.
1945 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
1946 the LayoutGroup result to ListView.setCellTable instead of all of its
1947 fields individually.
1948 * src/main/java/org/glom/web/client/ui/ListView.java:
1949 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
1950 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
1951 get the primary key for the table.
1952 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1953 index of the primary key in the LayoutGroup accounting for hidden
1954 primary keys. Rename getJavaNumberFormat() to
1955 convertToJavaNumberFormat() for consistency. Cleanup / add some
1957 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
1958 field for primary key index and a field to indicate whether the
1959 primary key is hidden or not.
1961 2011-06-23 Ben Konrath <ben@bagu.org>
1963 Rename getTableData methods to getListData.
1965 This is a rename refactor for consistency with other methods.
1967 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1968 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1969 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1970 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1972 2011-06-23 Ben Konrath <ben@bagu.org>
1974 Extract the ConfiguredDocument innerclass into its own class.
1976 This makes the servlet code more object oriented.
1978 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
1979 from private ConfiguredDocument class in OnlineGlomServiceImpl.
1980 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
1981 new ConfiguredDocument class.
1983 2011-06-21 Ben Konrath <ben@bagu.org>
1985 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
1987 This makes things more inline with how libglom works and reduces code
1988 duplication. This refactor lays the groundwork for adding the primary key to
1989 the LayoutGroup object.
1991 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1992 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1994 Change method names to getListLayout and getDefaultListLayout for
1995 consistency. Use LayoutGroup as the DTO for the list layout instead of
1996 ColumnInfo and LayoutListTable.
1997 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
1998 new method names along with the LayoutGroup object for transferring the
2000 * src/main/java/org/glom/web/client/ui/ListView.java:
2001 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2002 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2003 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2005 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2006 Replaced with LayoutGroup.
2007 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2008 expectedResultSize and defaultTableName fields which are needed for
2010 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2011 type field which is needed for the list layout but will also be
2012 useful for the details layout as things progress.
2013 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2014 Make class abstract. Remove the unnecessary
2015 getFormattingHorizontalAlignment method. Add setFormatting method.
2017 2011-06-16 Ben Konrath <ben@bagu.org>
2019 Add scripts for building and installing war.
2021 These will help when updating OnlineGlom but they're also good
2022 supplemental documentation of the build and deployment proceeding.
2024 * utils/build-onlineglom-war.sh: New file.
2025 * utils/install-onlineglom-war.sh: New file.
2027 2011-06-16 Ben Konrath <ben@bagu.org>
2029 Create wrapper class to create consistent log messages.
2031 I wrapped methods in the Log class of gwt-log to add the method names
2032 from the servlet and create consistent formatting of the document title
2033 and table names in the log messages.
2035 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2036 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2037 log methods to use methods from wrapped Log class.
2039 2011-06-16 Ben Konrath <ben@bagu.org>
2041 Remove superfluous conditional return.
2043 Thanks to Murray Cumming for pointing this out!
2045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2047 2011-06-15 Ben Konrath <ben@bagu.org>
2049 Return an ArrayList of LayoutGroups for the Details layout.
2051 This corrects a problem with the details layout as it can have more
2052 than one top level LayoutGroup.
2054 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2055 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2056 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2057 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2058 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2059 with ArrayList of LayoutGroups for the details view layout.
2060 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2061 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2062 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2063 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2064 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2065 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2067 2011-06-14 Ben Konrath <ben@bagu.org>
2069 Use cast_dynamic method to determine the libglom LayoutItem type.
2071 This is better than finding the LayoutItem type by using the string
2072 returned from the get_part_type_name() method.
2074 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2076 2011-06-14 Ben Konrath <ben@bagu.org>
2078 Add method names to log entries in the servlet.
2080 This helps when tracking down deployment problems.
2082 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2084 2011-06-14 Ben Konrath <ben@bagu.org>
2086 Add data to the DetailsView using a hard-coded primary key value.
2088 The layout and functionality of the DetailsView is not complete. This
2089 is just a checkpoint so the patch doesn't get too big.
2091 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2092 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2093 Add getDetailsData() servlet method.
2094 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2095 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2096 LayoutFields are added to the DetailsView.
2097 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2098 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2099 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2100 take the string for the title instead of the object.
2101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2102 Add implementation getDetailsData() along with some private helper
2104 * src/main/webapp/style.css: Add padding to details-data class. Add a
2105 details-label class with the same padding as the details-data class.
2107 2011-06-03 Ben Konrath <ben@bagu.org>
2109 Use presenter.goTo() to change to the DetailsPlace.
2111 This will make things easier when we need to open the DetailsView with
2112 data specific to the row that was clicked.
2114 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2116 2011-06-02 Ben Konrath <ben@bagu.org>
2118 Add CSS file from mockups.
2120 I'm adding this now because it's going to be useful to have when
2121 developing the DetailsView. The TableSelectionView and ListView aren't
2124 * src/main/webapp/OnlineGlom.html:
2125 * src/main/webapp/style.css:
2127 2011-06-02 Ben Konrath <ben@bagu.org>
2129 Use String.isEmpty() to check for empty string.
2131 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2133 2011-06-02 Ben Konrath <ben@bagu.org>
2135 Display main layout group titles in the DetailsView.
2137 This is the start of the DetailsActivity/DetailsView implementation.
2139 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2140 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2141 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2142 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2143 Get the layout information for the details view from the server and set
2144 the main layout group titles.
2145 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2146 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2147 Add addLayoutGroup() and addLayoutField() methods. This are just
2148 temporary methods for creating the the details view that will change
2150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2151 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2153 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2154 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2155 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2156 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2157 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2158 Data Transfer Objects that mimic the libglom object structure. These are
2159 used for transferring the details layout but could also be used for
2160 transferring the list layout.
2162 2011-05-27 Ben Konrath <ben@bagu.org>
2164 Reset the AuthenticationPopup when clearing the ListView.
2166 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2168 2011-05-27 Ben Konrath <ben@bagu.org>
2170 Fix problem with onlineglom.properties file loading.
2172 The old way worked in Eclipse but not on the server. Loading the
2173 onlineglom.properties file now works in Eclipse and on the server.
2175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2177 2011-05-24 Ben Konrath <ben@bagu.org>
2179 Update gwt-log from 3.1.0 to 3.1.2.
2181 Gwt-log 3.1.0 has been marked as depreciated.
2185 2011-05-24 Ben Konrath <ben@bagu.org>
2187 Add comment to ListActivity.goTo() method.
2189 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2191 2011-05-24 Ben Konrath <ben@bagu.org>
2193 Remove FIXME in convertGdkColorToHtmlColour()
2195 The Gdk::Color value returned by libglom is 16-bits per channel on both
2196 64 and 32-bit platforms.
2198 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2200 2011-05-19 Ben Konrath <ben@bagu.org>
2202 Improve performance of initial ListView load.
2204 I removed a round trip to the server for getting the default table name
2205 and then requesting information about that table. This also removes a potential
2206 problem with the table change handler not being setup in time to receive the
2207 table change event from the ListActivity.
2209 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2210 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2211 getDefaultLayoutListTable() method. Improve comments.
2212 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2213 getDefaultLayoutListTable() method instead of firing a table change
2214 event to get the table to load.
2215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2216 implementation of getDefaultLayoutListTable() method.
2217 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2220 2011-05-19 Ben Konrath <ben@bagu.org>
2222 Override toDebugString() in TableChangeEvent.
2224 This is useful to have for debugging.
2226 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2228 2011-05-19 Ben Konrath <ben@bagu.org>
2230 Add a "Back to List" link when at the DetailsPlace.
2232 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2233 Populate the CellTable based on the selected table of the ListBox if
2234 it's set otherwise use the default table. This allows the "Back to
2236 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2237 Remove Place from constructors. Add a setPlace() method. Add
2238 goToPlace() method. Set class as presenter for TableSelectionView.
2239 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2240 Use the same TableSelectionActivity when switching between the List and
2242 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2243 Subclass the new HasSelectableTablePlace. This removes some duplicate
2245 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2246 New class to represent Places that display the TableSelectionView.
2247 * src/main/java/org/glom/web/client/place/ListPlace.java:
2248 Subclass the new HasSelectableTablePlace. This removes some duplicate
2250 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2251 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2252 Add Presenter interface. Add setBackLinkVisible() method. Add
2253 setBackLink() method.
2255 2011-05-18 Ben Konrath <ben@bagu.org>
2257 Enable the "Details" buttons.
2259 Right now only an empty details view is displayed.
2261 * src/main/java/org/glom/web/client/ClientFactory.java:
2262 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2263 Add DetailsView to ClientFactory.
2264 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2265 A basic activity for the details view.
2266 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2267 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2269 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2270 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2272 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2273 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2274 unnecessary super() in constructor.
2275 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2276 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2277 really shouldn't create a new TableSelectionActivity for both the ListPlace
2278 and the DetailsPlace so this should be considered a temporary solution.
2279 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2280 New file. Represents a URL for the details view.
2281 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2282 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2283 A basic details view interface and implementation.
2284 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2285 Enable the "Details" buttons.
2287 2011-05-12 Ben Konrath <ben@bagu.org>
2289 Use a LayoutPanel with multiple display areas for main layout.
2291 This is mostly a refactor in that there are no changes from the user
2292 point of view. These changes are required so that we can swap out the list view
2293 with the details view when the user clicks the "Details" button.
2295 * src/main/java/org/glom/web/client/ClientFactory.java:
2296 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2297 OnlineGlomView. Add TableSelectionView, ListView and
2298 AuthenticationPopup.
2299 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2300 for main layout. Add display regions for main activities. Add
2301 activity manager for for main activities.
2302 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2303 file from parts of the deleted OnlineGlomActivity.
2304 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2305 New file from parts of the deleted OnlineGlomActivity.
2306 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2307 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2308 New files for app wide table change event.
2309 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2310 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2311 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2312 Activity mappers for the main activities replace the deleted app-wide
2314 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2315 Fix a spelling error in he comment.
2316 * src/main/java/org/glom/web/client/ui/ListView.java:
2317 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2318 Renamed from LayoutListView and modified for MVP. This still not a
2319 proper dumb view as prescribed by the MVP pattern but it works for now.
2320 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2321 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2322 New widget stripped out of the deleted OnlineGlomView.
2323 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2324 Remove hack that is fixed by this patch.
2326 2011-05-06 Ben Konrath <ben@bagu.org>
2328 Rename OnlineGlomPlace to ListPlace.
2330 The only change besides the rename is that url will now display #list
2331 instead of #Document.
2333 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2334 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2335 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2336 * src/main/java/org/glom/web/client/place/ListPlace.java:
2337 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2339 2011-05-06 Ben Konrath <ben@bagu.org>
2341 Use Presenter for app navigation.
2343 This is the proper way to deal with Place (URL) changes with the MVP
2346 * src/main/java/org/glom/web/client/ClientFactory.java:
2347 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2348 PlaceHistoryMapper and PlaceHistoryHandler.
2349 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2350 PlaceHistoryMapper and PlaceHistoryHandler.
2351 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2352 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2353 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2354 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2355 Add Presenter interface and setPresenter methods. Rename addHyperLink
2356 to addDocumentLink taking only the document title as a parameter.
2358 2011-04-14 Ben Konrath <ben@bagu.org>
2360 Prompt for db username/password if they haven't been set.
2362 This is implemented with a popup widget that is contained within the
2363 OnlineGlomView and managed by the OnlineGlomActivity.
2365 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2366 methods for checking and setting the database username and password.
2367 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2368 new methods for checking and setting the database username and
2370 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2371 Display authentication popup if the JDBC connection to the database
2372 has not been authenticated.
2373 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2375 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2376 for dealing with the authentication popup.
2377 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2378 Implement the methods for dealing with the authentication popup.
2379 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2380 try to executed queries if the database connection hasn't been
2381 authenticated. Implement methods for checking and setting the
2382 database username and password.
2384 2011-04-12 Ben Konrath <ben@bagu.org>
2386 Make log messages a little clearer.
2388 Add a dash betweeen the document title and the table name.
2390 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2392 2011-04-12 Ben Konrath <ben@bagu.org>
2394 Protect against NPEs when cleaning up database resources.
2396 While this isn't strictly necessary because the exception is caught,
2397 not protecting against the NPEs makes it harder to find the real error
2400 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2402 2011-04-12 Ben Konrath <ben@bagu.org>
2404 Move configuration of the servlet to the constructor.
2406 The servlet will be initialized even if the database authentication
2407 information is not set or correct. I still need to add the UI for prompting
2408 the user for the authentication information when it's required.
2410 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2411 javadocs for getDocumentTitles() method.
2412 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2413 Set error message when RPC fails.
2414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2415 glom files directory from the configuration file. Try to set the
2416 database authentication information for the specific document if it's
2417 set and works otherwise try to use the global authentication
2418 information set for the directory.
2419 * src/main/resources/onlineglom.properties: Moved from
2420 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2421 Added detailed comments for the new keys.
2423 2011-04-11 Ben Konrath <ben@bagu.org>
2425 Remove unnecessary @Override in DocumentSelectionViewImpl.
2427 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2429 2011-04-11 Ben Konrath <ben@bagu.org>
2431 Remove center alignment in DocumentSelectionView.
2433 The title element is still centred but the document titles and bottom
2434 sentence are both left-aligned.
2436 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2438 2011-04-11 Ben Konrath <ben@bagu.org>
2440 Change 'Demo' naming convention to 'Document'.
2442 This is just a rename refactor with no functional changes to the code.
2444 * src/main/java/org/glom/web/client/ClientFactory.java:
2445 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2446 * src/main/java/org/glom/web/client/OnlineGlom.java:
2447 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2448 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2449 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2450 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2451 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2452 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2453 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2454 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2455 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2456 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2458 2011-04-08 Ben Konrath <ben@bagu.org>
2460 Remove FIXME from safeLongToInt() method.
2462 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2465 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2467 2011-04-08 Ben Konrath <ben@bagu.org>
2469 Display an error if no glom documents are found in the specified directory.
2471 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2472 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2473 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2474 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2476 2011-04-08 Ben Konrath <ben@bagu.org>
2478 Add copyright header to one more file ... oops.
2480 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2482 2011-04-08 Ben Konrath <ben@bagu.org>
2484 Add copyright header to files without it.
2486 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2487 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2488 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2489 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2490 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2491 * src/main/java/org/glom/web/shared/GlomField.java:
2493 2011-04-08 Ben Konrath <ben@bagu.org>
2495 Add support for accessing multiple glom documents in the servlet.
2497 This completes the demo selection functionality.
2499 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2500 document title to methods.
2501 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2502 document title to methods.
2503 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2504 Set browser window title when the activity starts. Correct name of
2505 document title variable.
2506 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2507 Set browser window title when the activity starts. Set the table
2508 selector change handler after table selector has been set. Clear the
2509 OnlineGlomView when the activity has been stopped.
2510 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2511 document title as the place token. Use "#Document:" instead of
2512 "#OnlineGlomPlace:" in the URL.
2513 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2514 Change heading to "Online Glom"
2515 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2516 document title in RPC methods.
2517 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2518 setDocumentTitle() method. Add clear() method.
2519 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2520 setDocumentTitle() method. Implement clear() method which removes the
2521 change handler on the ListBox, clears the ListBox and clears the
2523 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2524 Implement methods with document title. Keep track for the configured
2525 glom documents and their corresponding JDBC configurations in a hash
2526 table. This information is retrieved using the document title as the
2527 key in the hash table.
2528 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2529 document title field as it's no longer needed.
2531 2011-04-08 Ben Konrath <ben@bagu.org>
2533 Update the Eclipse JDT configuration.
2535 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2536 methods. Automatically add the copyright header to new files.
2538 2011-04-05 Ben Konrath <ben@bagu.org>
2540 Add new page for demo selection.
2542 This patch adds all the components required to view and start an
2543 OnlineGlom demo by clicking on the desired hyperlink. The user is
2544 able to return to the demo selection page with the browser's back
2545 button. I still need to modify the servlet to work with multiple
2546 documents so all demo links will load the file defined in the
2547 OnlineGlom.properties.
2549 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2550 This is only useful during development so we don't need to save it.
2551 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2552 get a reference to the DemoSelectionView.
2553 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2554 method to get a reference to the DemoSelectionView.
2555 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2556 default view to DemoSelectionView.
2557 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2558 to get glom document titles for glom files in a hard-coded directory.
2559 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2560 method to get glom document titles for glom files in a hard-coded
2562 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2563 Presenter for DemoSelectionView.
2564 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2565 for DemoSelectionView.
2566 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2567 Update for DemoSelectionView.
2568 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2569 Basic 'Place' implementation for the DemoSelectionView.
2570 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2571 The interface for the DemoSelectionView.
2572 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2573 The implementation of the DemoSelectionView.
2574 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2575 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2576 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2577 implementation of method to get glom document titles for glom files
2578 in a hard-coded directory.
2579 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2580 on longer being used.
2581 * src/main/webapp/glom.png: Glom logo.
2583 2011-04-05 Ben Konrath <ben@bagu.org>
2585 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2587 This is the forth and final commit of a refactor that will allow
2588 OnlineGlom to be used with multiple documents.
2590 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2591 Move RPC code from OnlineGlomViewImpl to this class.
2592 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2594 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2595 RPC code to the presenter class (the P in MVP).
2597 2011-04-04 Ben Konrath <ben@bagu.org>
2599 Start moving the existing OnlineGlom code to MVP.
2601 This work is based on the GWT MVP framework that is documented here:
2603 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2605 This is the third commit of a refactor that will allow OnlineGlom to
2606 be used with multiple documents.
2608 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2609 Interface for client factory which is used to get instances of various
2610 classes throughout the app.
2611 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2612 Implementation of client factory.
2613 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2614 initialize the MVP framework.
2615 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2616 New file. Activity manager for the main container widget. This is the
2618 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2619 Maps place (URL) to its corresponding activity.
2620 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2621 New file. This is just a place holder for a generated file.
2622 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2623 New file. Represents the URL for the main Online Glom app.
2624 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2625 for changes in LayoutListViewImpl.
2626 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2627 interface for View. Move code to OnlineGlomViewImpl class.
2628 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2629 file. Implementation of OnlineGlomView.
2630 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2631 Place resources. Use ClientFactoryImpl by default.
2633 2011-04-04 Ben Konrath <ben@bagu.org>
2635 Move View classes to their own package.
2637 This is the second commit of a refactor that will allow OnlineGlom to
2638 be used with multiple documents.
2640 * src/main/java/org/glom/web/client/OnlineGlom.java:
2641 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2642 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2644 2011-04-02 Ben Konrath <ben@bagu.org>
2646 Move UI code from the main module to its own class.
2648 This is the first commit of a refactor that will allow OnlineGlom to be
2649 used with multiple documents.
2651 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2652 references to OnlineGlom to OnlineGlomView.
2653 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2654 OnlineGlomView and instantiate it here.
2655 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2656 represents the main OnlineGlomView with one document.
2658 2011-04-01 Ben Konrath <ben@bagu.org>
2660 Fix formatting of gwt.xml and add DTD.
2662 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2664 2011-03-30 Ben Konrath <ben@bagu.org>
2666 Propperly convert gdkColor string to html colour string.
2668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2670 2011-03-28 Ben Konrath <ben@bagu.org>
2672 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2674 This implementation matches
2675 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2676 readable and is not tied to Swig.
2678 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2680 2011-03-28 Ben Konrath <ben@bagu.org>
2682 Use read-only checkboxes for boolean field types.
2684 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2685 in the CellTable based on the field type. It currently only
2686 distinguishes between boolean and text columns but I'll need to add
2687 support for more types.
2688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2689 column type in the ColumnInfo object. Add method to convert between the
2690 glom field type enum in ColumnInfo and the glom field type in libglom.
2691 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2693 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2694 getting and setting booleans.
2696 2011-03-25 Ben Konrath <ben@bagu.org>
2698 Don't get the Date twice from the ResultSet.
2700 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2702 2011-03-25 Ben Konrath <ben@bagu.org>
2704 Cleanup code in the servlet.
2706 * TODO: Remove item about row count. Add item about testing row count
2707 query with large number of rows.
2708 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2709 spelling mistakes, change method parameter to be consistent with
2712 2011-03-25 Ben Konrath <ben@bagu.org>
2714 Add server side logging with the gwt-log library.
2716 * .gitignore: Ignore the log file we're now producing.
2717 * TODO: Add a couple TODO item for logging.
2718 * pom.xml: Add gwt-log and log4j as a dependency.
2719 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2720 logging of errors, warnings and some important info.
2721 * src/main/resources/log4j.properties: New file to configure log4j.
2723 2011-03-24 Ben Konrath <ben@bagu.org>
2725 Add a disable button for the Details view.
2727 * src/main/java/org/glom/web/client/LayoutListView.java:
2729 2011-03-22 Ben Konrath <ben@bagu.org>
2731 Use a count query to get the number of rows for the list view pager.
2733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2735 2011-03-22 Ben Konrath <ben@bagu.org>
2737 Add more TODO information about CellTable pager positioning.
2741 2011-03-19 Ben Konrath <ben@bagu.org>
2743 Add TODO item about CellTable pager positioning.
2747 2011-03-18 Ben Konrath <ben@bagu.org>
2749 Remove unneeded GlomFieldColumn class.
2751 This is just a small code cleanup.
2753 * src/main/java/org/glom/web/client/LayoutListView.java:
2755 2011-03-18 Ben Konrath <ben@bagu.org>
2757 Use cursor mode in the query that gets data for the list view.
2759 I still need to fix the potential memory problem when getting the row
2760 count for the list view.
2762 * TODO: Add note about testing memory usage with large data sets. Add
2763 item about fixing row counting with large data sets.
2764 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2765 PostgreSQL JDBC driver into cursor mode when getting data for the
2768 2011-03-15 Ben Konrath <ben@bagu.org>
2770 Remove the GWT Container from the Eclipse build classpath.
2772 The GWT dependencies are set by Maven so this isn't needed.
2776 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2778 Added some earlier mockups to git, but not to the tarball dist.
2780 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2781 Openismus. These hopefully show how we might structure the HTML so that
2782 it can be styled easily with CSS. However, we probably need to adapt them
2783 for the CSS structure that GWT dictates for common widgets.
2785 2011-03-14 Ben Konrath <ben@bagu.org>
2787 Locate OnlineGlom.properties using the ServletContext.
2789 This is required to be able to locate the file in the deployed servlet.
2791 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2792 Configure the database and glom document in in a helper method so
2793 that the ServletContext can be used to locate OnlineGlom.properties.
2794 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2795 src/main/webapp. This is the proper location for .properites files.
2797 2011-03-12 Ben Konrath <ben@bagu.org>
2799 Add note to README about why we're compiling down to obfuscated JavaScript.
2803 2011-03-11 Ben Konrath <ben@bagu.org>
2805 Use properties file to configure servlet.
2807 This allows people to change the glom file path, db username and db
2808 password without recompiling the code.
2810 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2811 * src/main/webapp/OnlineGlom.properties:
2813 2011-03-11 Ben Konrath <ben@bagu.org>
2815 Use table fields in layout list view if the layout list is not defined.
2817 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2818 Manually create a LayoutFieldVector for the query builder using the
2819 table fields when a layout list is not defined in the glom file.
2821 2011-03-11 Ben Konrath <ben@bagu.org>
2823 Only show FIXME string for images when there's an image.
2825 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
2826 in this change are some small code cleanups.
2828 2011-03-11 Ben Konrath <ben@bagu.org>
2830 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
2832 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2834 2011-03-11 Ben Konrath <ben@bagu.org>
2836 Correctly set the index of the default table.
2838 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2839 Correctly set the index of the default table. Add commented out example
2842 2011-03-10 Ben Konrath <ben@bagu.org>
2844 Add comment to pom.xml about the previous change.
2846 * pom.xml: Add comment about the deployment issue so that it's obvious
2847 why java-libglom is set to the provided scope.
2849 2011-03-10 Ben Konrath <ben@bagu.org>
2851 Change java-libglom dependency from compile to provided in pom.xml.
2853 Since java-libglom uses jni it can only be loaded once and therefore
2854 must be placed in $CATALINA_HOME/lib and not included in each war.
2855 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
2856 More information about this issue can be found in the Tomcat 6 release
2857 notes in the "JNI Based Applications" section:
2859 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
2861 * README: Remove note about this issue. Deployment info should really
2862 be on the wiki anyway so I'll add it right now.
2863 * pom.xml: Change java-libglom dependency from compile to provided so
2864 that it's copied in to the packaged war.
2866 2011-03-09 Ben Konrath <ben@bagu.org>
2868 Change to using a neutral locale for currency, date and time formatting.
2870 This solves the problem of currency values being represented without a
2871 space between the currency code and the number (e.g. "EUR5.89" is now
2872 represented as "EUR 5.89"). More work is required when we implement
2873 a locale preference setting.
2875 * TODO: Add note about currency formatting issues with different
2877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2878 to using the neutral ROOT locale.
2880 2011-03-09 Ben Konrath <ben@bagu.org>
2882 Add support for currency codes that are not ISO 4217 codes.
2884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2885 the currency code defined in the glom file when it's not 3 characters
2886 long or when Java doesn't recognize the string as an ISO 4217 code.
2888 2011-03-08 Ben Konrath <ben@bagu.org>
2890 Remove test classes, launch configurations and configuration.
2892 The test stuff was getting in the way when creating the war. To make
2893 the war file you can now do 'mvn clean package'. The packaged war file
2894 will be in the target directory.
2896 * .classpath: Remove unused classpathentry for tests and i18n.
2897 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
2898 property. Don't run test or i18n goals when packaging the war.
2899 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
2904 * OnlineGlomTest-dev.launch:
2905 * OnlineGlomTest-prod.launch:
2906 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2907 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
2909 2011-03-07 Ben Konrath <ben@bagu.org>
2911 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
2913 These fixes allow me to use 'mvn deploy' to create the war file.
2915 * .classpath: This generated config has been updated by Eclipse. This
2916 change was probably triggered by me updating from Eclipse 3.6.1 to
2918 * .gitignore: Add entry to ignore the directory
2919 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
2920 * .project: The generated config has been updated by Eclipse. This
2921 change was probably triggered by me updating from Eclipse 3.6.1 to
2923 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
2924 so that Eclipse doesn't complain
2925 * pom.xml: Update to gwt-maven-plugin 2.2.0.
2926 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
2927 'tests' directory to 'client' directory. This is the new
2928 gwt-maven-plugin convension.
2929 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
2930 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
2932 2011-03-07 Ben Konrath <ben@bagu.org>
2934 Add support for horizontal alignment in the LayoutList columns.
2936 * TODO: Remove item about horizontal alignment. Add item about
2937 improvements to ColumnInfo.
2938 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
2939 alignment on the columns. Use ColumnInfo RPC object get the column
2940 title and horizontal alignment.
2941 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
2942 LayoutListView creation with ColumnInfo RPC object.
2943 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2944 a ColumnInfo object for every LayoutList columnn. Convert the
2945 FieldFormatting.HorizontalAlignment to the correct
2946 ColumnnInfo.HorizontatlAlignment with the new
2947 getColumnInfoHorizontalAlignment helper method.
2948 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
2949 to encapsulate column information like alignment and title. This
2950 could be used to set the colour instead of on a per cell field basis.
2951 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
2952 column title storage and retrieval with ColumnInfo.
2954 2011-03-04 Ben Konrath <ben@bagu.org>
2956 Add support for column sorting.
2958 * src/main/java/org/glom/web/client/LayoutListView.java: Change
2959 AsynDataProvider to be an anonymous inner class. Use new
2960 getSortedTableData RPC method when column sort is requested. Set all
2961 columns sortable and add an AsyncHandler to activate sorting in the
2963 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
2964 method getSortedTableData(). Cleanup other method signatures.
2965 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2966 new method getSortedTableData(). Cleanup other method signatures.
2967 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2968 Implement getSortedTableData() and getTableData() methods by using a
2969 private helper method with the appropriate parameters filled in. Use
2970 user supplied sort clause when supplied, otherwise fall back to
2971 sorting by the primary key. Move destroy() method to be underneath
2972 constructor for readability. Cleanup comments.
2974 2011-03-03 Ben Konrath <ben@bagu.org>
2976 Add support for colour text and colour backgrounds to the layout list cells.
2978 Only the cell backgrounds are coloured which leaves a gap between the
2979 cells that isn't coloured. I need to figure out a way to set
2980 'style=background-colour:' on the whole column rather than just the
2983 * TODO: Add a note about colouring the background of the whole column.
2984 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
2985 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
2986 render the coloured text and backgrounds. Use GlomField[] for the row type.
2987 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
2989 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
2990 GlomField[] for the row type.
2991 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2992 GlomField[] for the row type. Set the text, text colour and background
2993 colour in the GlomField objects as specified in the glom document. Add
2994 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
2995 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
2996 the glom field text, foreground colour and background colour.
2998 2011-03-02 Ben Konrath <ben@bagu.org>
3000 Don't display hidden tables in the combo box.
3002 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3004 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3005 code to ignore hidden tables using ArrayLists for the table names and
3007 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3008 tableNames to use ArrayLists instead of String[]. Update getter and setter
3011 2011-03-01 Ben Konrath <ben@bagu.org>
3013 Add support for Date and Time number types.
3015 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3016 Implement formatting for Date and Time values. Change the default glom
3017 file to small business example.
3019 2011-03-01 Ben Konrath <ben@bagu.org>
3021 Add support for formatting glom types as specified in the glom file.
3023 Formatting isn't finished yet - I still need to add support for Date
3026 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3027 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3028 checks for null values in JDBC cleanup code and catch all exceptions
3029 instead of just SQLExceptions.
3030 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3033 2011-03-01 Ben Konrath <ben@bagu.org>
3035 Use GWT 2.2.0 instead of 2.1.1.
3037 * pom.xml: Change GWT version numbers.
3039 2011-03-01 Ben Konrath <ben@bagu.org>
3041 A few small code cleanups.
3043 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3045 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3046 unnecessary object creation in constructor.
3047 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3048 unnecessary object creation in constructor.
3050 2011-02-28 Ben Konrath <ben@bagu.org>
3052 Add file for TODO list.
3056 2011-02-18 Ben Konrath <ben@bagu.org>
3058 Enable the CellTable Pager when more than 20 rows need to be viewed.
3060 The Pager will automatically become active when the results are larger
3061 than the CellTable size which is currently set to 20 lines.
3063 * src/main/java/org/glom/web/client/LayoutListView.java: Correct class
3064 name on debug statment in RPC call in LayoutListDataProvider, add
3065 numRows parameter to LayoutListView constructor, propperly set rowCount
3067 * src/main/java/org/glom/web/client/OnlineGlom.java: Correct class
3068 name on debug statment in RPC call, use LayoutListTable object in RPC
3069 calls, pass rowCount to LayoutListView.
3070 * src/main/java/org/glom/web/client/OnlineGlomService.java: Change
3071 getLayoutListHeaders to getLayoutListTable and return LayoutListTable
3073 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Update
3074 interface for changes in OnlineGlomService.
3075 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3076 getLayoutListHeaders() to getLayoutListTable() and return
3077 LayoutListTable. Using this object allows me to pass other information
3078 about the LayoutList like the expected number of rows in the result set.
3079 The Connection object from the connection pool is now propperly closed.
3080 Only the requested number of lines are returned to the client in
3082 * src/main/java/org/glom/web/shared/LayoutListTable.java: Move from
3083 GlomTable and add columnTitles and numRows.
3085 2011-02-18 Ben Konrath <ben@bagu.org>
3087 Use String arrays instead of GlomTable objects in GlomDocument GWT-RPC object.
3089 This is a small performance boost. I'll use GlomTable to get the required
3090 layoutlist information.
3092 * src/main/java/org/glom/web/client/OnlineGlom.java:
3093 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3094 * src/main/java/org/glom/web/shared/GlomDocument.java:
3096 2011-02-18 Ben Konrath <ben@bagu.org>
3098 Add option to turn off formatting in JDT formatter preferences.
3100 * .settings/org.eclipse.jdt.core.prefs:
3102 2011-02-18 Ben Konrath <ben@bagu.org>
3104 Rename LayoutList to LayoutListView.
3106 I'm working towards setting things up to easily use MVP when the time
3109 * src/main/java/org/glom/web/client/LayoutListView.java: Rename from
3111 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3114 2011-02-17 Ben Konrath <ben@bagu.org>
3116 Move LayoutListDataProvider class into LayoutList.java.
3118 * src/main/java/org/glom/web/client/LayoutList.java:
3120 2011-02-17 Ben Konrath <ben@bagu.org>
3122 Rename RPC service classes from LibGlomService* to OnlineGlomService*.
3124 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Update
3126 * src/main/java/org/glom/web/client/OnlineGlom.java: Update references.
3127 * src/main/java/org/glom/web/client/OnlineGlomService.java: Rename
3128 from LibGlomServer.java.
3129 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3130 Rename from LibGlomServiceAsync.java.
3131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3132 Rename from LibGlomServiceImpl.java.
3133 * src/main/webapp/WEB-INF/web.xml: Update configuration.
3135 2011-02-17 Ben Konrath <ben@bagu.org>
3137 Update JDT settings.
3139 * .settings/org.eclipse.jdt.core.prefs:
3141 2011-02-17 Ben Konrath <ben@bagu.org>
3143 Move GWT-RPC objects to shared package (where they should be).
3145 * src/main/java/org/glom/web/client/LibGlomService.java: Update imports.
3146 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Update imports.
3147 * src/main/java/org/glom/web/client/OnlineGlom.java: Update imports.
3148 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Update imports.
3149 * src/main/java/org/glom/web/shared/GlomDocument.java: Move to
3150 org.glom.web.shared package.
3151 * src/main/java/org/glom/web/shared/GlomTable.java: Move to
3152 org.glom.web.shared package.
3153 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Included shared
3154 directory in compilation to javascript.
3156 2011-02-16 Ben Konrath <ben@bagu.org>
3158 Add sort clause to the sql query that grabs table information.
3160 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Add sort clause
3161 if one of the columns is a primary key.
3163 2011-02-16 Ben Konrath <ben@bagu.org>
3165 Disable generateAsync feature of gwt-maven.
3167 The generated interface does not correctly match the methods in LibGlomService
3168 and the generated singleton Util inner-class doesn't respect the servlet
3171 * pom.xml: Turn off generateAsync feature.
3172 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Re-add file
3173 with singleton Util inner-class.
3175 2011-02-14 Ben Konrath <ben@bagu.org>
3177 Add LGPL v3 licence notices.
3179 Followed directions listed here:
3180 http://www.gnu.org/licenses/gpl-howto.html
3182 * COPYING: This file is a copy of the GPL v3.
3183 * COPYING.LESSER: This file is a copy of the LGPL v3.
3184 * src/main/java/org/glom/web/client/GlomDocument.java: Add licence
3186 * src/main/java/org/glom/web/client/GlomTable.java: Add licence
3188 * src/main/java/org/glom/web/client/LayoutList.java: Add licence
3190 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Add
3192 * src/main/java/org/glom/web/client/LibGlomService.java: Add licence
3194 * src/main/java/org/glom/web/client/OnlineGlom.java: Add licence
3196 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Add
3199 2011-02-14 Ben Konrath <ben@bagu.org>
3201 Use ArrayList instead of Array in GWT-RPC calls.
3203 Apparently this gives a slight performance boost to the compiled
3206 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Use ArrayList
3208 * src/main/java/org/glom/web/client/LibGlomService.java: Use ArrayList instead
3211 2011-02-14 Ben Konrath <ben@bagu.org>
3213 Access data from a postgres db rather than the example glom file.
3215 * .settings/com.google.gwt.eclipse.core.prefs: Change GWT setting to
3216 compile down to obfuscated javascript.
3217 * pom.xml: Add c3p0 and postgres JDBC libraries.
3218 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Return data
3219 using a postgres db accessed through the c3p0 connection pooling library.
3221 2011-02-14 Ben Konrath <ben@bagu.org>
3223 Update Java formatter settings.
3225 * .settings/org.eclipse.jdt.core.prefs: Change comment length to 120.
3227 2011-02-02 Ben Konrath <ben@bagu.org>
3229 Update Eclipse and Maven configs to in preparation for the postgres JDBC jar.
3231 * .classpath: Change JRE to Java 1.6, remove GWT configuration as we're now
3233 * .settings/com.google.gwt.eclipse.core.prefs: Don't copy gwt-servlet.jar to
3234 the compiled webapp directory that Eclipse uses as we're using Maven now.
3235 * .settings/org.eclipse.jdt.core.prefs: Change target platform to Java 1.6.
3236 * .settings/org.eclipse.wst.common.project.facet.core.xml: Change Java version