1 2012-07-21 Murray Cumming <murrayc@murrayc.com>
3 Document: Load title translations and test them.
5 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
6 of titles. I am surprised that we do not do this yet.
7 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
8 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
9 Test translations more.
11 2012-07-20 Murray Cumming <murrayc@murrayc.com>
15 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
16 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
17 Set the timeout here too.
19 2012-07-20 Murray Cumming <murrayc@murrayc.com>
21 tests: ConfiguredDocumentTest: Make this pass.
23 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
24 Disable tests that need a database connection.
26 2012-07-20 Murray Cumming <murrayc@murrayc.com>
28 Use Java 1.7 instead of Java 1.6.
30 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
31 to do this twice, at least for Eclipse.
32 This seems OK because it is the current version.
34 2012-07-20 Murray Cumming <murrayc@murrayc.com>
38 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
39 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
40 Avoid using a null Connection.
42 2012-07-20 Murray Cumming <murrayc@murrayc.com>
44 tests: Add a ConfiguredDocument test.
46 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
49 2012-07-20 Murray Cumming <murrayc@murrayc.com>
51 LayoutItemFIeld: getName(): Use the Field if it is set.
53 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
54 getName(): If the full field details have been set, return its name, so that
55 callers do not need to set the name separately.
56 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
57 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
58 so we can count the rows.
60 2012-07-20 Murray Cumming <murrayc@murrayc.com>
62 tests: SelfHoster: Test SqlUtils too.
64 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
65 Retrieve some data and check it too, as in the regular Glom
66 test_selfhosting_new_from_example.cc test.
67 * src/test/java/org/glom/web/server/SelfHoster.java:
68 createConnection(): Make this public.
70 2012-07-20 Murray Cumming <murrayc@murrayc.com>
72 tests: SelfHoster: createConnection(): Do not warn about expected failures.
74 Let the caller say if the connection is expected to fail, to avoid
75 irrelevant error output.
77 2012-07-20 Murray Cumming <murrayc@murrayc.com>
79 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
81 * src/test/java/org/glom/web/server/SelfHoster.java:
82 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
83 due to the inevitable need to retry the connection while the database server
86 2012-07-20 Murray Cumming <murrayc@murray.com>
88 tests: SelfHoster: createConnection(): Set a timeout.
90 * src/test/java/org/glom/web/server/SelfHoster.java:
91 createConnection(): Use setLoginTimeout() because it otherwise seems to take
92 ages to actually return when it fails.
94 2012-07-20 Murray Cumming <murrayc@murrayc.com>
96 tests: SelfHoster: selfHost(): Close the test connection.
98 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
99 When we check that the connection works, close the connection. This seems
100 to not be closed automatically otherwise.
102 2012-07-20 Murray Cumming <murrayc@murrayc.com>
104 Use slf4j-simple to see JDBC errors.
106 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
108 2012-07-19 Murray Cumming <murrayc@murrayc.com>
110 SelfHoster.discoverFirstFreePort(): Close the socket.
112 * src/test/java/org/glom/web/server/SelfHoster.java:
113 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
115 2012-07-19 Murray Cumming <murrayc@murrayc.com>
117 Avoid another code warning in Eclipse Juno.
119 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
120 Do instanceof checks on the FileUtils.listFiles() result and its
123 2012-07-13 Murray Cumming <murrayc@murrayc.com>
125 Avoid some code warnings in Eclipse Juno
127 * src/main/java/org/glom/web/server/libglom/Document.java:
128 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
129 * src/test/java/org/glom/web/server/SelfHoster.java
130 createTextFile(): Make sure that the FileOutputStream is closed.
132 2012-06-22 Murray Cumming <murrayc@murrayc.com>
134 Added OnlineGlomPropertiesTest.
136 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
137 Make sure we never return a null string.
138 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
139 Added tests of the OnlineGlomProperties API, using our sample file.
141 2012-06-20 Murray Cumming <murrayc@murrayc.com>
143 Make OnlineGlomProperties be a normal class.
145 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
146 Move OnlineGlomProperties into its own file to be a regular class:
147 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
148 This makes testing simpler.
150 2012-06-15 Murray Cumming <murrayc@murrayc.com>
152 OnlineGlomServiceImpl.init(): Move some code into a new method.
154 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
155 Create addDocument().
157 2012-06-15 Murray Cumming <murrayc@murrayc.com>
159 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
162 OnlineGlomProperties.getKey(): Make this more robust by moving the
163 check for *.*.filename to here.
165 2012-06-15 Murray Cumming <murrayc@murrayc.com>
167 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
170 init(): Move knowledge of the config file format into the
171 OnlineGlomProperties inner class.
173 2012-06-15 Murray Cumming <murrayc@murrayc.com>
175 SelfHostExampleTest: Make sure we cleanup on failure.
177 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
178 the use of cleanup() to a tearDown() JUnit method.
180 2012-06-12 Murray Cumming <murrayc@murrayc.com>
182 ConfiguredDocument: Add a primary key to portals at least once.
184 * src/main/java/org/glom/web/server/ConfiguredDocument.java
185 updatePortalsExtras): Fix a typo so that we add the primary key
186 column at least once.
187 This is a fix for the previous commit:
188 ConfiguredDocument: Do not add a primary key to portals each time.
190 2012-06-08 Murray Cumming <murrayc@murrayc.com>
192 SelfHoster: Avoid some compiler warnings.
194 * src/test/java/org/glom/web/server/SelfHoster.java
195 executeCommandLineAndWait():
196 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
197 the now-unused streams for stdout and stderr from the command Processes.
198 These are not used because readln() hangs while waiting for a new line,
199 where there may be no next line. The commented out code is still there
200 to help us figure out how to do this properly.
202 2012-06-08 Murray Cumming <murrayc@murrayc.com>
204 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
206 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
207 Make this actually test the cloning again, though it is not very useful
208 now that we do not use the part that had a problem with cloning before.
210 2012-06-08 Murray Cumming <murrayc@murrayc.com>
212 SelfHoster: Keep trying pg_ctl after starting postgres.
214 * src/test/java/org/glom/web/server/SelfHoster.java
215 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
216 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
217 regular Glom. This seems mad but it seems to work because the first
218 command would fail if pg_ctl would eventually fail.
220 2012-06-08 Murray Cumming <murrayc@murrayc.com>
222 SelfHoster: Wait until the server is really ready.
224 * src/test/java/org/glom/web/server/SelfHoster.java
225 selfHost(): Attempt the connection after starting the server, retrying
226 a few times if necessary, so that the server is really ready already when
227 we return from this method.
228 The regular Glom code does this too because pg_ctl reports success too soon.
230 2012-06-08 Murray Cumming <murrayc@murrayc.com>
232 ConfiguredDocument: Do not add a primary key to portals each time.
234 * src/main/java/org/glom/web/server/ConfiguredDocument.java
235 updatePortalsExtras(): Only add an extra primary key field if there is
236 none, to avoid adding one each time we retrieve the details layout from the
238 This should fix bug #676986 (Ben Konrath)
240 2012-05-25 Murray Cumming <murrayc@murrayc.com>
242 Document.load(): Support version 7 documents.
244 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
245 database_title attribute if the title attribute is not there.
248 2012-05-24 Ben Konrath <ben@bagu.org>
250 Add configuration for auto-generating mvn:i18n from with Eclipse.
252 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
254 2012-05-24 Murray Cumming <murrayc@murrayc.com>
256 Update translations, adding French.
258 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
259 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
260 Add a French translation, using the translation from Glom.
262 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
263 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
264 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
265 Update these based on the translations from Glom.
267 2012-05-24 Murray Cumming <murrayc@murrayc.com>
269 SelfHoster: Add some debug println messages to help when things fail.
271 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
272 System.out.println() lines.
274 2012-05-23 Murray Cumming <murrayc@murrayc.com>
276 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
278 * src/test/java/org/glom/web/server/SelfHoster.java:
279 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
280 instance) instead of just /usr/bin (as on Fedora). Check the result when
283 2012-05-23 Murray Cumming <murrayc@murrayc.com>
285 Remove LayoutItemPortal.get/setNavigationTable().
287 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
288 Remove get/setNavigationTable(), which is only a cache, because it is not
289 used, and does not need to be used, because that decision should be made on
291 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
292 updatePortalsExtras():
293 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
294 getNavigationRecord():
295 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
298 2012-05-21 Murray Cumming <murrayc@murrayc.com>
300 Initial self-hosting for tests.
302 * pom.xml: Change the scope for log4j, to hopefully make it
303 available to the test code which uses it indirectly via jOOQ.
304 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
305 self-hosting, though we only use it for testing.
307 * src/main/java/org/glom/web/server/libglom/Document.java:
308 example rows: Use a map instead of a list for each row of values,
309 so we know what field they are for, instead of relying on the sequence
310 being correct. This is not very efficient, but it does not really need
312 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
313 testReadTableExampleRows(): Adapted.
315 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
316 that returns an Object, for generic use. Note that Object seems to be
317 the implicit base even of double.
318 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
319 for use in CREATE TABLE SQL queries.
320 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
321 to do self-hosting of PostgreSQL databases via its command-line
322 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
323 backends/postgres_self.cc. This is incomplete - it needs more
324 warnings about failures and it needs to clean up properly when things
326 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
327 test of this new class.
329 2012-05-21 Murray Cumming <murrayc@murrayc.com>
331 Document: loading example data: Handle exceptions.
333 * src/main/java/org/glom/web/server/libglom/Document.java:
334 DateFormat.parse() and Double.valueOf() can throw exceptions, though
335 Eclipse did not warn about that.
337 2012-05-20 Murray Cumming <murrayc@murrayc.com>
339 Document: load(), save(): Handle the example rows.
341 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
343 * src/main/java/org/glom/web/server/libglom/Document.java:
344 load(), save(): Load and save the example rows, though the date, time
345 and image types are not handled properly yet.
346 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
347 Add testReadTableExampleRows() just to check that something is read.
349 2012-05-20 Murray Cumming <murrayc@murrayc.com>
351 Document: Add save().
353 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
354 Added getTranslationsMap() for use while saving.
355 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
356 Adedd getUseDefaultFormatting() for use while saving.
357 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
358 and several private methods that it uses.
360 This will be useful while testing via self-hosting.
361 It is not complete, but should be complete enough for testing.
363 2012-05-17 Murray Cumming <murrayc@murrayc.com>
365 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
367 * src/main/java/org/glom/web/client/OnlineGlomService.java
368 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
370 Remove getSortedListViewData() and getSortedRelatedListData(), adding
371 the sort column index and ascending bool to the regular method.
372 Instead, a sort column index of -1 now means no sort.
373 This is less explicit, but it's fairly simple, reduces the amount of
374 code, and makes the OnlineGlomService API slightly smaller.
375 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
376 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
378 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
379 getListViewData(), getRelatedListData():
380 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
381 getListViewData(), getRelatedListData():
382 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
384 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
386 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
391 2012-05-16 Murray Cumming <murrayc@murrayc.com>
393 Use translations for top-level groups too.
395 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
396 updateTitlesForLocale(): Use the translation for the group
397 as well as for child items.
401 Just recompiled to fix a problem in the released .tar.gz file.
405 2012-05-15 Murray Cumming <murrayc@murrayc.com>
407 Corrections to navigation to related records.
409 * src/main/java/org/glom/web/client/OnlineGlomService.java:
410 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
411 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
412 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
413 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
414 relationship name, because the relationship name is not necessarily unique
416 TOOD: This is inefficient, because it passes the whole list of
417 child field items back to the server, but it is more correct, and happens
418 to fix a bug with the primary key being lost after a few navigations.
419 There is probably a chance to make this more efficient anyway in some
422 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
423 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
424 * src/main/java/org/glom/web/server/ConfiguredDocument.java
425 * src/main/java/org/glom/web/server/database/DBAccess.java
426 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
427 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
430 2012-05-15 Murray Cumming <murrayc@murrayc.com>
432 Fix the use of translations.
434 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
435 Add updateTitlesForLocale().
436 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
437 Call it to discard unwanted translations and to make getTitle() return
438 the wanted translation wihout the need for the client code to specify a locale.
439 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
440 getTitle(): Fallback to the original title, as libglom does.
442 2012-05-15 Murray Cumming <murrayc@murrayc.com>
444 Document: Correctly report the number of available translation locales.
446 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
447 the available locale IDs list.
448 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
449 testLocales: Test this.
451 2012-05-15 Murray Cumming <murrayc@murrayc.com>
453 SqlUtils: Use camelCase.
455 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
456 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
457 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
458 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
459 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
460 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
462 2012-05-15 Murray Cumming <murrayc@murrayc.com>
464 Use jOOQ's tableByName() and fieldByName.
466 * pom.xml: Use jOOQ 2.3.1 to get the new API.
467 * src/main/java/org/glom/web/server/SqlUtils.java:
468 build_sql_select_step_with_where_clause(), .createField(),
469 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
470 so we can get correct quoting and escaping. Thanks to Lukas Eder for
471 adding this, and other things, to jOOQ.
473 2012-05-15 Murray Cumming <murrayc@murrayc.com>
475 SqlUtils: Remove the Connection parameters.
477 * src/main/java/org/glom/web/server/SqlUtils.java:
478 build_sql_select_with_key(), build_sql_select_with_where_clause(),
479 createSelect(), build_sql_select_step_with_where_clause(),
480 build_sql_count_select_with_where_clause(),
481 build_sql_select_count_rows(): Remove the Connection parameter because
482 jOOQ does not actually need a connectionwhen it is just used to build
484 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
486 * src/main/java/org/glom/web/server/ReportGenerator.java:
488 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
490 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
491 Constructor, getListData(), getResultSizeOfSQLQuery():
492 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
493 getSelectQuery(), getCountQuery():
494 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
495 getSelectQuery(), getCountQuery():
496 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
497 getNavigationRecord(): Adapted.
499 2012-05-14 Murray Cumming <murrayc@murrayc.com>
503 * src/main/java/org/glom/web/server/SqlUtils.java:
504 get_find_where_clause_quick(): Use a comparison of
505 lowercase values, instead of a simple equals. Regular Glom
506 uses the PostgreSQL ILIKE operator but jOOQ does not
507 support that just yet, though it will soon.
509 2012-05-14 Murray Cumming <murrayc@murrayc.com>
511 TableToViewDetails: Use a real serialization ID.
513 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
514 Though this does not fix the serialization problem.
516 2012-05-12 Murray Cumming <murrayc@murrayc.com>
518 Added LayoutItemPortalDeepCloneTest.
520 2012-05-11 Murray Cumming <murrayc@murrayc.com>
522 Make navigation work again.
524 * src/main/java/org/glom/web/server/libglom/Document.java:
525 Add getLayoutItemFieldShouldHaveNavigation().
526 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
527 Replace get/setAddNavigation() with the partly-existing
528 get/setNavigationTableName(), with an empty string being no navigation,
529 because this is simpler. Use the new
530 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
532 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
533 Add updateFieldsExtras() and call setNavigationTableName in it.
534 getDetailsLayoutGroup(),
535 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
536 createLayout(): Adapted.
537 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
538 Constructor: Adapted.
540 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
541 Replace get/setAddNavigation() with get/setNavigation(), returning a
542 TableToViewDetails class with both the table name and UsesRelationship,
543 because both are need. The previous code used java-libglom's output
544 variable (strangely, via sharedptr) to return both, but we cannot really
546 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
547 getNavigationRecord(): Adapt. However, we cannot actually use the cache
548 here because it somehow gets set to null during deepCopy(). I must test this.
549 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
550 testGetSuitableTableToViewDetails(): Adapted.
552 TODO: Find out why deepClone() is not quite working.
554 2012-05-11 Murray Cumming <murrayc@murrayc.com>
556 DBAccess: Simplify the retrievel of full field details.
558 * src/main/java/org/glom/web/server/database/DBAccess.java
559 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
560 because the Document loading should have done this.
562 2012-05-11 Murray Cumming <murrayc@murrayc.com>
564 Document: Correct loading of doubly-related layout fields.
566 * src/main/java/org/glom/web/server/libglom/Document.java:
567 loadUsesRelationship(): Actually set the related relationship, instead
568 of only setting it if it's not found.
570 2012-05-09 Murray Cumming <murrayc@murrayc.com>
572 Replace all appearances of Colour with color.
574 Because US English is dominant.
576 2012-05-09 Murray Cumming <murrayc@murrayc.com>
578 Use colors in HTML format, solving a warning about an unused function.
580 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
581 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
582 Add *asHTMLColor() versions of methods.
583 TODO: However, we should create and cache the results on the server.
584 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
585 * src/main/java/org/glom/web/client/ui/list/ListTable.java
586 * src/main/java/org/glom/web/server/ConfiguredDocument.java
587 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
588 Use the asHTMLcolor() versions.
590 2012-05-09 Murray Cumming <murrayc@murrayc.com>
592 ListViewTable: Constructor: Take the table name as a parameter.
594 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
595 Constructor: Take the tableName, and set the member variable, because
597 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
598 setCellTable(): Pass the table name.
599 This makes navigation to non-default tables work again. I don't know
600 why it worked before in the master branch.
602 2012-05-07 Murray Cumming <murrayc@murrayc.com>
604 ConfiguredDocument: Restore correct addition of hidden primary key items.
606 * src/main/java/org/glom/web/client/ui/list/ListTable.java
607 (ListTable.createCellTable): Uncomment out the check for the hidden
609 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
610 add primary key items for top-level lists and portals, as before,
611 instead of adding them to each group.
612 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
613 Actually implement the extra methods such as setHiddenPrimaryKey() and
614 comment that these are used only for top-level list groups and in portals.
615 This strangeness suggests even more that this should not be squeezed
616 into the LayoutGroup class.
618 2012-05-07 Murray Cumming <murrayc@murrayc.com>
620 Fix Formatting loading.
622 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
623 getFormattingUsed(): Remove the duplicate Formatting member variable
624 in favour of the one from the base class.
625 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
626 Initialize a new Formatting instead of using null by default, so we
627 have some defaults, instead of having to initialize one later just to
628 get the same defaults. This also makes loading of formatting from the
629 document work, because that expected a non-null.
631 2012-05-07 Murray Cumming <murrayc@murrayc.com>
633 RelatedListTable: Make sure that the tableName is set.
635 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
636 Constructor: Take the tableName so it is available later. Otherwise,
637 the server assumes that we mean the default table and cannot find the
639 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
640 setData(): Pass the tableName to the RelatedListTable constructor.
642 2012-05-07 Murray Cumming <murrayc@murrayc.com>
646 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
647 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
648 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
650 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
652 * src/main/java/org/glom/web/server/database/DBAccess.java:
653 convertResultSetToDTO(), getPortal():
654 * src/main/java/org/glom/web/server/database/ListDBAccess.java
656 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
657 Add checks for null objects and out of range access, with log messages to
658 give hints so we can fix these properly.
660 2012-05-07 Murray Cumming <murrayc@murrayc.com>
662 Portals: some corrections.
664 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
666 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
667 constructor: Use getRelationshipNameUsed() instead of getName(), because
668 that is what is meant.
669 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
670 getFromField(): Fix a typo, to get the field name, not the table name.
671 * src/main/java/org/glom/web/server/database/DBAccess.java:
672 getPortal(): Fix a typo that stopped this from working.
674 2012-05-07 Murray Cumming <murrayc@murrayc.com>
676 LayoutItemPortal: Also override getTitleOriginal().
678 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
679 This lets the base getTitle() with no parameters work.
680 TODO: Test this properly.
682 2012-05-06 Murray Cumming <murrayc@murrayc.com>
684 LayoutItemPortal: getTitle*(): Use the relationship title.
686 2012-05-06 Murray Cumming <murrayc@murrayc.com>
688 LayoutItemField: Fix loading of custom titles.
690 * src/main/java/org/glom/web/server/libglom/Document.java
691 loadDataLayoutItemField(): The title, if any, instead of the field
692 title, is stored in a title_custom node. Load it from there.
693 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
695 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
696 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
697 getTitle*() overrides.
698 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
701 2012-05-06 Murray Cumming <murrayc@murrayc.com>
703 LayoutItemField: Fall back to field titles, so some are really shown.
705 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
706 Override getTitleOriginal() and getTitle(), as in java-libglom.
707 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
710 2012-05-06 Murray Cumming <murrayc@murrayc.com>
712 Correct use of setExpectedResultSize().
714 * src/main/java/org/glom/web/server/ConfiguredDocument.java
715 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
716 Use setExpectedResultSize only on top-level groups (for instance, the
717 list layout) or on child portals (in details views).
718 Use the correct table name for portals to avoid SQL errors.
719 Update the expected counts when returning cached layouts.
721 2012-05-06 Murray Cumming <murrayc@murrayc.com>
723 Document: Interpret no group column count as 1.
725 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
726 default, though we now check for this in the UI code anyway.
728 2012-05-06 Murray Cumming <murrayc@murrayc.com>
732 2012-05-06 Murray Cumming <murrayc@murrayc.com>
734 Translatable: Use Hashmap instead of Treemap because GWT supports it.
736 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
737 The use of Treemap lead to this error from async methods, with no
739 "The response could not be deserialized"
741 2012-05-06 Murray Cumming <murrayc@murrayc.com>
743 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
745 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
746 when using the Google -> GWT Compile, or
747 g toolbar button -> GWT Compile Project... feature in Eclipse.
749 2012-05-06 Murray Cumming <murrayc@murrayc.com>
751 ListTable.addColumn(): Protect against a null Formatting.
753 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
754 Create a default Formatting if it is null, because that is the simplest
757 2012-05-06 Murray Cumming <murrayc@murrayc.com>
759 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
761 * src/main/java/org/glom/web/server/ConfiguredDocument.java
762 updateLayoutGroup(): Check that the field is not null.
764 2012-05-06 Murray Cumming <murrayc@murrayc.com>
766 ListViewImpl: Protected against a bad cast error.
768 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
769 onEnterKeyDown(): Do not cast without an instanceof check.
771 2012-05-06 Murray Cumming <murrayc@murrayc.com>
773 ListTable: Protect against an out of range error.
775 * src/main/java/org/glom/web/client/ui/list/ListTable.java
776 createCellTable(): This is unlikely, but can happen while debugging.
778 2012-05-06 Murray Cumming <murrayc@murrayc.com>
780 AsyncMessage onFailure() callbacks: Log the exception message.
782 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
783 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
784 * src/main/java/org/glom/web/client/activity/ListActivity.java:
785 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
786 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
787 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
788 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
789 These are useful clues when something is wrong.
791 2012-05-06 Murray Cumming <murrayc@murrayc.com>
793 ConfiguredDocument: Avoid a null dereference.
795 * src/main/java/org/glom/web/server/ConfiguredDocument.java
796 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
797 details maps are created.
799 2012-05-06 Murray Cumming <murrayc@murrayc.com>
801 Document: Correct the port number parsing.
803 * src/main/java/org/glom/web/server/libglom/Document.java:
804 This lets us actually connect to the database and show the document.
806 2012-05-05 Murray Cumming <murrayc@murrayc.com>
810 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
811 user-interaction, asking us to load a temporary URL in a browser.s
812 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
813 which is apparently necessary for testing the service. See the comment.
814 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
815 Show the exception, if any. This is how I saw the 404 in the HTML in
818 2012-05-05 Murray Cumming <murrayc@murrayc.com>
820 DocumentTest: Move the .glom files into the resources directory.
822 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
823 URI via getResource().
825 2012-05-05 Murray Cumming <murrayc@murrayc.com>
827 Document: Remove the FieldIdentifies inner class.
829 * src/main/java/org/glom/web/server/libglom/Document.java: We only
830 use the Relationship (though the same function in libglom is maybe
831 used in other ways) and so this removes a compiler warning.
833 2012-05-05 Murray Cumming <murrayc@murrayc.com>
835 Document.load() Remove the error code parameter.
837 * src/main/java/org/glom/web/server/libglom/Document.java: load():
838 Remove the parameter. We do not set it yet and it could never have
839 worked as an output parameter (though maybe it did in java-libglom).
840 We could use an exception if we really want the failure reason.
841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
843 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
844 setUp(), testGetSuitableTableToViewDetails(): Adapt.
846 2012-05-05 Murray Cumming <murrayc@murrayc.com>
848 Make some inner classes static.
850 * src/main/java/org/glom/web/server/ConfiguredDocument.java
851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
852 * src/main/java/org/glom/web/server/ReportGenerator.java
853 * src/main/java/org/glom/web/server/libglom/Document.java
854 Make all inner classes static that can be static.
856 2012-05-05 Murray Cumming <murrayc@murrayc.com>
858 OnlineGlomServiceImpl: Do not load and check for java-libglom.
860 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
861 init(): We do not use java-libglom any more.
863 2012-05-05 Murray Cumming <murrayc@murrayc.com>
865 Remove mentions of java-libglom.
867 * README: Remove mention of java-libglom, because it no longer needed.
868 * utils/build-onlineglom-war.sh:
869 * utils/check-and-recover-tomcat.py:
870 * utils/install-onlineglom-war.sh: Remove these as they are no longer
871 useful. Building is now far easier, with no need for jhbuild.
873 2012-05-05 Murray Cumming <murrayc@murrayc.com>
875 Fix the build (mvn package)
877 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
878 (LayoutGroup): Make the LayoutItemList inner class static and protected.
879 Otherwise the GWT Java->Javascript compilation fails with just this
880 error, during mvn package or when attempting to view in a browser,
881 in the GWT developer mode in Eclipse.
883 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
884 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
885 [INFO] Compiling module org.glom.web.OnlineGlom
886 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
887 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
888 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
889 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
890 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
891 [INFO] [ERROR] Cannot proceed due to previous errors
893 It has taken me 2 days to find out what was causing that. After reducing
894 the code, the compiler eventually showed me the full error message.
896 2012-05-04 Murray Cumming <murrayc@murrayc.com>
898 ConfiguredDocument: Cache the cloned and stripped layouts.
900 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
901 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
902 layout in a map, so we can retrieve it again without rebuilding it.
904 2012-05-04 Murray Cumming <murrayc@murrayc.com>
906 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
908 2012-05-04 Murray Cumming <murrayc@murrayc.com>
910 libglom classes: Implement some auto-generated emthods.
912 2012-05-04 Murray Cumming <murrayc@murrayc.com>
914 Add GwtTestOnlineGlomService.
916 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
917 However, this (and the other GwtTest*) does not seem to run during
920 2012-05-04 Murray Cumming <murrayc@murrayc.com>
922 Remove use of unsupported features from client code.
924 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
925 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
926 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
927 Use our client version of StringUtils instead of the apache commons one.
929 However, the GWT Javascript compliation still fails.
931 2012-04-25 Murray Cumming <murrayc@murrayc.com>
933 Add a Field class and implement some loading of it in Document.
935 2012-04-25 Murray Cumming <murrayc@murrayc.com>
937 Initial Document loading implementation, instead of libglom.
939 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
940 and Translatable classes, and adapt the rest of the code to use them.
941 However, this is still missing Layout and Field classes and loading.
943 2012-04-24 Murray Cumming <murrayc@murrayc.com>
945 Use of jOOQ: Move Field creation into a utility method.
947 * src/main/java/org/glom/web/server/SqlUtils.java:
948 This lets us improve it more easily.
950 2012-04-24 Murray Cumming <murrayc@murrayc.com>
952 Use of jOOQ: Improve the code to COUNT a sub-select.
954 * src/main/java/org/glom/web/server/SqlUtils.java:
955 Move initial query creation into
956 build_sql_select_step_with_where_clause().
957 build_sql_select_count_rows(): Use the jOOQ API instead of
958 concatentating text, because a jOOQ Select*Step is a TableLike,
959 which is what from() takes.
961 2012-04-23 Murray Cumming <murrayc@murrayc.com>
963 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
965 * pom.xml: Depend on jooq.
966 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
967 methods with jOOQ, based on the C++ implementations in libglom,
968 with some changes to the logic required by jooQ.
969 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
971 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
972 * src/main/java/org/glom/web/server/ReportGenerator.java:
973 * src/main/java/org/glom/web/server/SqlUtils.java:
974 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
975 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
976 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
977 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
978 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
979 Adapt. In particular, the SqlUtils methods now need to take a Connection,
980 because jOOQ needs that, though it seems unnecessary.
982 This is not quite finished. Ideally jOOQ would help us to build
983 table_name.field_name names, quoting and escaping them properly.
984 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
986 2012-04-21 Murray Cumming <murrayc@murrayc.com>
988 Move use of Glom.build_sql*() into a new SqlUtils class.
990 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
991 to wrap Glom.build_sql*(). The parameter types are still Glom one,
992 but this will make it easier to start using something other than
993 libglom or SqlBuilder.
995 2012-04-21 Murray Cumming <murrayc@murrayc.com>
997 Update the project URL.
999 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1001 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1003 Main layout: Use a FlowTable instead of absolute positioning.
1005 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1006 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1007 child panels/widgets must have an absolute position. But that is annoying, so
1008 this adds a FlowTable and puts the child panels in there.
1010 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1012 GwtTestOnlineGlom: Comment out unused code.
1014 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1015 Eclipse has started to say that some code is unused.
1017 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1019 Update to the latest versions of dependencies.
1021 * pom.xml: Update version numbers of dependencies to the latest
1023 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1024 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1025 * src/main/java/org/glom/web/server/ReportGenerator.java:
1026 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1027 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1028 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1030 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1031 Modify the imports where necessary.
1033 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1035 Style: Remove overflow:hidden from searchbox
1037 * src/main/webapp/style.css: Because this pushes the Back To Link
1038 label/link on to the next row, which is then hidden due to the
1039 hard-coded (in ems) height.
1041 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1043 Remove some duplicate code.
1045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1046 getDocumentInfo(): This must have been duplicated during the merge from the
1051 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1053 Reports: Localize the waiting for report message.
1055 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1056 start(): Get the message from the contants.
1057 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1058 Add the string here.
1059 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1060 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1061 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1062 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1063 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1064 Update these files with the English text for newer strings for now.
1066 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1068 Reports: Show a message while waiting for the report.
1070 * src/main/java/org/glom/web/client/ui/ReportView.java
1071 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1072 Add setWaitingText(), to show a message saying that we are
1073 waiting for the report to be ready.
1074 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1075 start(): Call setWaitingText() before calling the async
1078 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1080 ReportGenerator: Specify date and time formats.
1082 * src/main/java/org/glom/web/server/ReportGenerator.java:
1083 createFieldValueElement(): Use the default (and localized)
1084 short formats, though we still need a way to show 4-digit
1085 years without providing the format for every locale.
1086 * src/main/java/org/glom/web/server/database/DBAccess.java:
1087 convertResultSetToDTO(): Use the short formats here too.
1089 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1091 ReportGenerator: Use the correct numeric formatting.
1093 * src/main/java/org/glom/web/server/ReportGenerator.java
1094 createFieldExpression(), createFieldValueElement(): Take the
1095 whole LayoutItem_Field instead of just the field name, so
1096 we have access to the formatting.
1097 createFieldValueElement(): Use JRTextField.setPattern() to
1098 specify the numeric formatting, with the help of a
1099 regular DecimalFormat.
1101 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1103 ReportGenerator: Avoid showing null for group by titles.
1105 * src/main/java/org/glom/web/server/ReportGenerator.java
1106 generateReport(): Use setBlankWhenNull() on the field title
1107 style too, because this is used for values in group by
1110 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1112 ReportGenerator: Add a colon to titles in vertical groups.
1114 * src/main/java/org/glom/web/server/ReportGenerator.java
1115 addFieldToDetailBandVertical(): Pass true for the withColon
1118 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1120 ReportGenerator: Simplify the code by using Position more.
1122 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1124 Reports: Support vertical groups, roughly.
1126 * src/main/java/org/glom/web/server/ReportGenerator.java:
1127 addToReport(): Rename to addGroupToReport() and, if necessary,
1128 call the new addVerticalGroupToReport() method.
1129 createFieldValueElement(): Let the caller specify the Y position
1132 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1134 Reports: Allow a second report to be shown.
1136 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1137 clear(): Do not remove the HTML widget, which broke the whole layout.
1139 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1141 Locales drop-down: Show that we use English by default.
1143 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1144 fillView(): When we use English, just because that is the default, when
1145 no locale is specified, show that in the Locales drop-down instead of
1146 just showing the first item.
1148 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1150 Unselect the Report/Locale/Table combo item when appropriate.
1152 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1153 setPlace(): clear reportName if this is not a ReportPlace.
1154 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1155 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1156 When the provided name is empty, unselect all items, so that none are
1157 indicated. This uses a for loop because I cannot find a single method
1160 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1162 Report: Give the user a way to get back to the list.
1164 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1165 start(), setPlace(): Show the Back To List link on reports, and also
1166 interpret selecting the empty report item as back to list.
1168 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1170 Really show the selected Report name.
1172 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1173 setPlace(): Store the reportName here, if it is that kind of Place.
1174 fillView(): Set the selected Report after filling the list of reports.
1175 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1176 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1177 null Strings, though we need some way to unselect all ListBox items
1180 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1182 ReportGenerator: Try to avoid some problems.
1184 * src/main/java/org/glom/web/server/ReportGenerator.java
1185 addField(): Try to avoid duplicates, and avoid using a null
1188 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1190 Reports: Use quickFind.
1192 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1193 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1195 getReportHTML(): Add a quickFind parameter.
1196 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1197 start(): Pass the quickFind parameter.
1198 * src/main/java/org/glom/web/server/ReportGenerator.java
1199 generateReport(): Take a quickFind parameter.
1201 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1203 ReportPlace: Actually use the report name.
1205 * src/main/java/org/glom/web/client/place/ReportPlace.java
1206 getPlace(): Do not assign the report name to the quickfind.
1208 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1210 Show java.library.path when complaining.
1212 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1213 init(): When telling us to check java.library.path, show the
1216 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1218 ReportGenerator: Do not show nulls.
1220 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1222 ReportGenerator: Make the title font larger.
1224 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1226 ReportGenerator: Put field titles inside groups, if there are groups.
1228 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1230 ReportGenerator: Take the Report itself instead of the name and group.
1232 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1233 Remove getReportLayoutGroup().
1234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1235 getReportHTML(): Pass the report instead
1236 of its name and layout group.
1237 * src/main/java/org/glom/web/server/ReportGenerator.java
1238 generateReport(): Use the report object to use the title
1239 instead of the name.
1241 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1243 ReportGenerator: Remove designBand parameters.
1245 * src/main/java/org/glom/web/server/ReportGenerator.java:
1246 Make designBand a class member instead of passing it to all
1249 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1251 ReportGenerator: Add lines, a bit like in the desktop version.
1253 * src/main/java/org/glom/web/server/ReportGenerator.java
1254 addToReport(): Use JRDesignLine.
1256 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1258 ReportGenerator: Correct the title positions and use some bold style.
1260 * src/main/java/org/glom/web/server/ReportGenerator.java:
1261 Break the code up into reusable functions, correct the placement of
1262 titles, and use normal/bold styles as in the reports in the desktop
1265 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1267 ReportGenerator: Add a header band to show the field titles.
1269 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1270 getReportHTML(): Pass the localeId to the ReportGenerator
1272 * src/main/java/org/glom/web/server/ReportGenerator.java
1273 constructor: Take the localeID so we can get translated field
1275 generateReport(), addToReport(), addFieldToBand(): Add field
1276 titles in a column header band.
1278 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1280 Reports drop-down list: Some improvement.
1282 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1283 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1284 Adedd setSelectedReport(),
1285 setReportList(): Add a blank line so that the user can select the
1287 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1288 start(): Show the current report by calling setSelectedReport().
1289 This does not seem to work yet.
1291 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1293 DetailsActivity, ListActivity: Move some variables into a base class.
1295 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1296 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1297 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1298 the clientFactory, documentID, tableName and authenticationPopup into
1299 a base class, to avoid duplication.
1301 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1303 Translate the Reports label.
1305 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1306 Get the "Reports" label string from the constants.
1307 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1308 perties: Add Reports to the constants.
1310 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1312 Reports: Implement grouping.
1314 * src/main/java/org/glom/web/server/ReportGenerator.java:
1315 Handle LayoutItem_GroupBy items and try to do the right thing
1316 with JRDesignGroup. It seems to work.
1318 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1320 Actually show some data with JasperReports.
1322 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1323 getReportHTML(): Move most code into a ReportGenerator class.
1324 * src/main/java/org/glom/web/server/ReportGenerator.java:
1325 Recurse into sub-groups, adding fields to the JasperDesign's details
1326 band. Note that we must set an arbitrary width and height, or it just
1327 will not show any data.
1329 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1331 Reports Chooser: Show the titles, not the names.
1333 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1334 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1335 and the names as the values.
1336 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1337 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1338 group now that we provide the report name, so it should always
1341 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1343 Depend on jasperreports.
1345 * pom.xml: Add the dependency. My plan is to use this on the
1348 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1350 Implement navigation to report places.
1352 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1353 start(): Do not bother to handle all events here.
1354 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1355 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1356 Added getSelectedReport().
1357 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1358 .java: start(): When handling a change to the reports chooser,
1359 call getSelectedReport() and goTo() its ReportPlace.
1360 * src/main/java/org/glom/web/client/ui/ReportView.java
1361 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1362 Added setReportHTML() which puts the html in a gwt HTML widget.
1363 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1364 getReportHTML(): Return "TODO" just to show that this works.
1366 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1368 Make ReportPlace usable.
1370 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1371 Mention ReportPlace.
1372 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1373 Correct the @prefix annotation.
1375 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1377 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1379 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1380 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1381 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1382 Change getReportLayout() to getReportHMTL() because we will not need to
1383 parse or render the report layout on the client side.
1384 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1385 getReportLayout(): Return the libglom LayoutGroup type because we will
1386 not need to convert to a shared type, because this will not be used on
1388 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1391 Note that there is still no implementation for this.
1394 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1396 Add a (empty) Report Place, View, and Activity.
1398 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1400 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1401 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1402 this into a superclass:
1403 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1404 and also use it as the base of this new ReportPlace:
1405 * src/main/java/org/glom/web/client/place/ReportPlace.java
1407 * src/main/java/org/glom/web/client/ui/ReportView.java
1408 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1409 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1410 Add these, containing mostly boiler-plate for now.
1412 * src/main/java/org/glom/web/client/OnlineGlomService.java
1413 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1414 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1415 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1416 Add API to get the LayoutGroup for the report.
1418 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1420 Add and fill a Reports drop-down list box.
1422 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1424 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1425 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1426 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1427 Added getReports(document, table, localeID), calling
1428 ConfiguredDocument.getReports().
1429 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1430 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1431 Added setReportsList() and a list widget.
1432 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1433 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1438 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1440 Translations: Add Esperanto.
1442 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1443 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1444 properties: Add this translation because someone took the time to make it.
1446 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1448 Adapt to the java-libglom 1.21.7 API.
1450 * src/main/java/org/glom/web/server/ReportGenerator.java:
1451 addToReport(): get_group_secondary_fields() is now
1452 get_secondary_fields().
1455 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1457 Use the latest java-libglom version.
1459 * pom.xml: Use java-libglom 1.21.7.
1461 2012-03-03 Ben Konrath <ben@bagu.org>
1463 Display date and time in details view.
1465 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1467 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1469 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1471 Require the latest java-libglom.
1473 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1475 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1477 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1479 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1480 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1481 an empty quickfind string. I also corrected libglom to create only
1482 empty where clauses for empty quickfind strings, but this avoids the
1485 2012-02-24 Ben Konrath <ben@bagu.org>
1487 Improve the tabs in the Notebook widget.
1491 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1493 Translations: Try to translate the strings.
1495 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1496 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1497 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1498 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1499 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1500 Take the Open translation from GTK+'s .po files.
1501 Take the Details translation from Glom's po files.
1502 I have added the other strings to Glom so we can get translations that way:
1503 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1505 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1507 TableSelectionViewImpl: Put the search label and entry in a div.
1509 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1510 Put the search widgets in a FlowTable so that the CSS can be used to
1511 style them while keeping them together.
1512 * src/main/webapp/style.css: Mention the new div.
1514 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1516 Translate more strings in more locales.
1518 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1519 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1520 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1521 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1522 Translate the "Details" and "Open" string too.
1524 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1525 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1526 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1527 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1528 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1529 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1530 Add these new locales as placeholders though they currently contain English.
1532 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1534 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1536 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1537 Check the ConfiguredDocument* for null before using it.
1539 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1541 Tell Eclipse about the generated java files.
1543 * .classpath: This lets it find OnlineGlomConstants.java.
1544 It would be nice if Eclipse just used the maven build files.
1546 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1548 Prevent a crash when no locale is specified in the URL.
1550 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1551 Avoid returning a null string, obtained from
1552 Window.Location.getParameter(). This caused a crash when it was
1553 later passed to libglom's API.
1554 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1555 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1556 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1557 guard against future null strings.
1559 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1561 Use the ?locale= query param instead of the &lang= token param.
1563 * src/main/java/org/glom/web/client/place/ListPlace.java
1564 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1565 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1566 Remove the lang token key and value.
1568 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1569 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1570 When the user selects a different locale from the chooser, use
1571 Window.Location.assign() to change the URL, which then causes a reload.
1573 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1574 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1575 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1576 * src/main/java/org/glom/web/client/activity/ListActivity.java
1577 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1578 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1579 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1580 * src/main/java/org/glom/web/client/ui/ListView.java:
1581 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1583 Remove localeID member variables and method/constructor parameters, instead
1584 using Utils.getCurrentLocaleID() when we need a localID to pass to
1587 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1589 Internationalize the UI strings.
1591 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1592 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1593 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1594 because it is unused. Messages are apparently strings that can have
1595 parameters, but we do not need that yet, so Contants will be enough for now.
1596 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1597 to say that we support the en and de locales.
1598 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1599 The original English strings.
1600 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1601 Some German translations of the English strings.
1602 The i18n goal then uses the .properties file to generate an
1603 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1604 returns an implementation that returns the translated strings.
1605 The documentation suggests putting these in src/java/*/client/, but it seems
1606 best to put it in src/resources/*/client/.
1607 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1608 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1609 instead of hard-coding them.
1610 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1611 but that does not seem to stop the build, though it confuses Eclipse.
1613 You can see the translated string by adding ?locale=de to the URL, like so:
1614 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1616 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1618 Improve null/empty String checks.
1620 * pom.xml: Add a dependency on commons-lang, to use
1621 org.apache.commons.lang.StringUtils.
1622 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1623 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1624 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1625 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1626 Use StringUtils.isEmpty().
1628 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1629 StringUtils class with a static isEmpty() function because we
1630 cannot use org.apache.commons.lang.StringUtils in client-side
1631 GWT code because it (apparently) cannot be compiled to javascript.
1632 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1633 * src/main/java/org/glom/web/client/activity/ListActivity.java
1634 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1635 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1636 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1637 * src/main/java/org/glom/web/client/place/ListPlace.java
1638 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1639 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1640 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1641 * src/main/java/org/glom/web/client/ui/details/Group.java
1642 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1643 our StringUtils.isEmpty() function.
1645 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1647 Update to the latest java-libglom API.
1649 * pom.xml: Require java-libglom 1.21.4.
1650 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1651 getDocumentInfo(), getListViewLayoutGroup():
1652 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1654 * src/main/java/org/glom/web/server/database/DBAccess.java
1655 getFieldsToShowForSQLQueryAddGroup(),
1656 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1657 with either get_database_title_original() or
1658 get_database_title(localeID).
1660 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1662 ConfiguredDocument: Avoid a null pointer exception.
1664 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1665 Initialize localeID to "" to avoid returning a null String which
1666 causes a crash in java-libglom's swing-generated code.
1668 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1670 Some simple renaming.
1672 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1673 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1674 for localeChooser. This seems more appropriate and is less ambiguous
1675 particularly in the .css file.
1677 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1679 ConfiguredDocument: Rename the localedID private member variable.
1681 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1683 Adapt to the latest java-libglom API from git master.
1685 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1686 libglom now uses only Vector instead of List, which uses add() instead of
1689 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1691 ConfiguredDocument: Rename the localedID private member variable.
1693 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1695 Build a source tarball with mvn assembly:single
1697 * assembly.xml: Add this file.
1698 * pom.xml: Use the maven-assembly-plugin and tell it to use
1699 our assembly.xml file.
1701 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1703 OnlineGlomServiceImpl: Get .glom files recursively.
1705 * pom.xml: Depend on commons-io from org.apache.commons.
1706 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1707 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1708 files recursively, and with the easier filter for the extension.
1709 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1710 simplify that code too.
1712 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1714 README: Mention that you must install java-libglom packages separately.
1716 But then it works, because java-libglom is now in the central maven
1719 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1721 locales drop-down: Show the correct selected locale when the URL changes.
1723 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1724 .java: setPlace(): Move some code into fillView().
1726 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1728 locales drop-down: Do not lose the primary key.
1730 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1731 start(): onLocaleChange(): Pass the current primary key value,
1732 instead of an empty value.
1734 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1736 locales drop-down: Do not lose the drop-down selection.
1738 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1739 .java (TableSelectionActivity.fillView): Set the selected locale
1740 after changing the drop-down items (though we do not really need
1741 to change them just because the locale changes.)
1743 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1745 locales drop-down: Change the tables list when this changes.
1747 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1748 .java: TableSelectionActivity.start(): Move the async table titles
1749 retrieval into a private fillView() method and also call this when
1750 the chosen locale changes.
1751 Note that the document title is not actually translatable yet, but
1752 that is a problem that I should fix soon in libglom.
1754 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1756 Improve the placement of the locales drop-down.
1758 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1759 Put the title and locales drop-down in a div (gwt.FlowTable).
1760 * src/main/webapp/style.css: Add magic css properties to make this work.
1761 Also remove the left margin from the title so that it lines up with the
1764 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1766 locales selector: Show human-readable locale titles.
1768 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1769 getDocumentInfo(): Use java.util.Locale to show a real title of
1770 each locale, in the locale's own language.
1772 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1774 Add a language/locale selector drop-down.
1776 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1777 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1778 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1779 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1780 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1781 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1782 Add a ListBox to show the available locales. Add getLocaleSelector(),
1783 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1784 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1785 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1786 java: Add these classes.
1787 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1788 start(): Fill the locales ListBox. Handle its change event, firing a
1790 setPlace(): Show the selected locale as specified by the URL token.
1791 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1792 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1793 Handle LocaleChangeEvent, going to a new *Place with that locale.
1795 The placement of the ListBox is not pretty, and it currently uses the ID
1796 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1800 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1802 Search box: Show the search text from the URL token.
1804 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1805 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1806 Add setQuickFindText().
1807 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1808 .java: setPlace(): Store the queryText if the place is a ListPlace,
1809 and call TableSelectionView.setQuickFindText().
1811 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1813 Allow use of translations via, for instance, &lang=de in the URL.
1815 * pom.xml: Use the unstable java-libglom 1.21 version.
1817 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1818 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1819 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1820 init(): Instead of calling TranslatableItem.set_current_locale()
1821 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1822 However, this is only for default locales, which are not needed to
1823 change the locale in the URL.
1824 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1825 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1826 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1827 layout for a particular locale.
1828 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1829 Add get/setDefaultLocaleID().
1830 getDocumentInfo(), getListViewData(), getRelatedListData(),
1831 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1832 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1833 localeID parameter, so we can get the layout for a particular locale.
1835 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1836 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1837 * src/main/java/org/glom/web/client/place/ListPlace.java:
1838 Parse and construct a lang parameter too.
1840 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1841 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1842 passed to subsequent methods and constructors.
1843 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1844 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1845 Store the localeID from the *Place and pass it to other constructors
1846 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1848 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1849 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1850 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1851 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1852 * src/main/java/org/glom/web/client/ui/ListView.java:
1853 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1854 Take localeID parameters and pass them to subsequent constructors and
1855 methods, so that the layout is always retrieved for that locale.
1857 This is rather repetitive.
1859 Note that "" means the original (default) locale of the Glom document,
1860 which is usually English.
1862 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1864 Documents: Remove final keyword to fix startup configuration.
1866 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1867 final keywords on the private member variables because that breaks
1868 the startup, apparently (there are warnings) because it stops them
1869 from being serialized. I added these in the previous commit.
1871 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1873 Documents: Add some final keywords.
1875 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1878 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1880 OnlineGlomServiceImpl: Add to overview comments.
1882 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1883 Note that this is where all the document are loaded. They are not
1884 loaded freshly for each page.
1886 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1890 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1891 Add a TextBox for the text of a quick find.
1892 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1894 setBackLink(): Add a String quickFind parameter.
1895 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1896 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1897 to the base interface, because that is how TableSelectionViewImpl is used.
1898 * src/main/webapp/style.css: Add style for the search box and its label.
1900 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1901 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1902 Add these files, based on the existing TableChangeEvent and
1903 TableChangeEventHandlers.
1904 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1905 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1906 a ListPlace() that the user should be taken to.
1907 * src/main/java/org/glom/web/client/activity/ListActivity.java
1908 start(): Handle it here too and adapt the TableChangeEvent handler to
1909 pass the extra "" quickFind parameter to ListPlace.
1910 * src/main/java/org/glom/web/client/place/ListPlace.java:
1911 Constructor: Take an extra String quickFind parameter and store it,
1912 returning it from a new getQuickFind() method.
1913 getToken(): Put the quickFind text in the URL token.
1914 getPlace(): Parse the quickFind text from the URL token.
1915 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1916 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1917 ListPlace constructor.
1918 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1919 .java: start(): Add a Change handler for the TableSelectionView's
1920 TextBox (via its base HasChangeHandlers interface), firing the new
1921 QuickFindChangeEvent.
1922 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1923 pass the extra "" quickFind parameter.
1925 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1926 setCellTable(): Add a String quickFind parameter and pass it to
1927 the ListViewTable() constructor.
1928 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1929 setCellTable() in the base interface, because that is how ListViewImpl
1932 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1933 Add a String quickFind member variable.
1934 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1935 Constructor: Add a String quickFind parameter, storing it in the
1936 base ListTable's member variable.
1937 onRangeChanged(): Pass quickFind to the
1938 OnlineGlomServiceAsync.getSortedListViewData() and
1939 OnlineGlomServiceAsync.getListViewData() methods.
1941 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1942 getListViewData(), getSortedListViewData(): Add a String quickFind
1943 parameter, passing it to ConfiguredDocument.getListViewData().
1944 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1945 Change getListViewData(), getSortedListViewData() in the base interface,
1946 because that is how OnlineGlomServiceImpl is used, via this:
1947 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1948 Change getListViewData(), getSortedListViewData() here too.
1949 This class can apparently be used to asynchronously call methods on
1950 OnlineGlomService, and GWT seems to implement that after recognizing
1951 just the *Async name convention and the extra AsyncCallback parameters.
1953 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1954 getListViewData(): Add a String quickFind parameter, and pass it to
1955 ListViewDBAccess.getData().
1956 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1957 getListData(): Add a String quickFind parameter and pass it to
1959 getSelectQuery(): Add a String quickFind parameter.
1960 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1961 getSelectQuery(): Add a String quickFind parameter and use it with
1962 Glom.get_find_where_clause_quick() to pass a where_clause to
1963 Glom.build_sql_select_with_where_clause(), to actually filter the
1965 getData(): Add a String quickFind parameter, passing it to getListData().
1966 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1967 va: getData(): Pass an empty string to getListData() for the
1968 quickFind parameter.
1970 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1972 ListTable: Minor change.
1974 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1975 createCellTable(): Make this protected instead of public.
1977 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1979 Many files: Use final for the parameters and use the @override attribute.
1981 2012-01-22 Ben Konrath <ben@bagu.org>
1983 Add anchor links for single line text that starts with http, ftp and www.
1987 2012-01-22 Ben Konrath <ben@bagu.org>
1989 Add ellipsis to single line text in details view.
1993 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1995 Remove all javadoc author tags.
1997 Because they are awkward and meaningless when many people touch
1999 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2001 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2003 Revert the COPYING.LESSER to COPYING rename.
2005 Apparently both should be there if it is LGPL.
2007 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2009 *View: Remove unused imports.
2011 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2012 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2013 * src/main/java/org/glom/web/client/ui/ListView.java:
2014 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2015 Remove unused imports, as suggested by Eclipse.
2017 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2019 Move the *View::Presenter types, and some API into one base View.
2021 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2022 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2023 * src/main/java/org/glom/web/client/ui/ListView.java:
2024 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2025 Presenter, setPresenter() and clear() into a shared base interface,
2026 to avoid the unnecessary duplicate Presenter types and to more clearly
2027 show how the *Views share the same structure, even if they are not
2028 used polymorphically.
2030 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2031 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2033 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2034 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2035 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2037 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2040 Feel free to revert this if there is a good reason for the duplicate
2043 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2045 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2047 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2048 a class member instead of a local variable in the method.
2049 This lets us use it to get the view instances, for use in tests.
2050 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2051 beforeOnlineGlom(): Test some more details of the initial view.
2052 Again, this is not very useful.
2054 To really test gwt-glom we will need to start a local postgresql
2055 instance with local data, like the Glom tests in C++.
2057 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2059 pom.xml: Mention the LGPL license.
2061 * pom.xml: Add a licenses section.
2062 * COPYING.LESSER: Move this to COPYING, which
2063 previously contained the GPL. But gwt-glom is all LGPL.
2065 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2067 Add project information to README and pom.xml.
2069 * README: Add a brief description and mention some mvn
2071 * pom.xml: This extra information shows up in mvn site
2074 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2076 Use the latest java-libglom version.
2078 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2080 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2082 GwtTestOnlineGlom: Test a little more.
2084 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2085 protected rather than private, as suggested by the gwt-test-utils
2087 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2088 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2089 Test the initial visibility of the panels.
2091 However, this is not a very useful test.
2092 And I wonder how we should generally test using this idea for an
2093 activity/places app like ours where the real changes happen implicitly
2094 based on the history token/URL.
2096 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2098 Slight modification to *Mapper comments.
2100 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2101 (DataActivityMapper)
2102 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2104 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2106 Remove comments mentioning GIN because they are just copied from
2107 the example code and are apparently not helpful:
2108 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2109 Also change the mention of a class that is only in the example code.
2111 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2113 GwtTestOnlineGlom test: Minor changes.
2115 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2116 Avoid the long qualified class name and modify the comment
2117 because it is now obvious to me that the mocked class is the only
2118 custom one created via GWT.create().
2120 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2122 Tests: Added the beginnings of a test using gwt-test-utils.
2124 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2125 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2126 which tells gwt-test-utils what class will be tested.
2127 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2128 Add a simple (but empty) test case. One class, used by the OnlineGlom
2129 class, is mocked so that it can be created. However, I am not sure
2130 why only this class needs to be mocked.
2132 Note that mockito seems more popular, and clearer, than easymock,
2133 but I have not got that working yet. It might be a matter of the
2136 This test is run during mvn integration-test.
2138 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2140 Tests: Use junit4-style syntax instead of junit3-style.
2142 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2143 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2144 * src/test/java/org/glom/web/shared/DataItemTest.java:
2145 Use the @Test annotation rather than relying on the test*() prefix.
2146 Also no longer implement TestCase, to avoid triggering support for
2147 the junit3-way, which stops the annotations from working.
2148 Change the imports from import junit.framework.* to
2149 import org.junit.*, which is apparently the new way.
2151 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2153 Added a test for ListPlace token parsing and creation.
2155 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2156 This is much the same as DetailsPlaceTest.
2158 I wonder how we could test the other parts of the *Place API.
2160 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2162 DetailsPlace test: Also test getToken() and recreation via getPlace().
2164 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2165 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2166 recreate it, testing the recreated DetailsPlace for the same parameter
2169 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2171 Use the surefire-report plugin.
2173 * pom.xml: This generates a HTML report about the tests in
2174 target/site/surefire-report.html
2175 when you do mvn surefire-report:report. It seems to be popular/normal.
2177 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2179 Added a test for DetailsPlace.
2181 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2182 Test the getPlace() token parsing.
2184 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2186 Added a first unit test.
2188 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2189 * src/test/java/org/glom/web/shared/DataItemTest.java:
2190 This is a silly test but it is just to get things started. Note that
2191 maven/junit finds the test because it looks in src/test by default.
2193 2011-12-22 Ben Konrath <ben@bagu.org>
2195 Change charsetName to "UTF-8" when replacing line breaks.
2197 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2198 that work in Java (such as "UTF8") will not work when compiled to
2201 This fixes a problem with multi-line details view fields that have hard
2202 line breaks. The "License Text" field on this page demonstrates the
2205 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2207 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2209 2011-12-22 Ben Konrath <ben@bagu.org>
2211 Fix another bug with related list navigation.
2213 I've tested all the navigation buttons in all of the related lists
2214 so things should be good now.
2216 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2218 2011-12-22 Ben Konrath <ben@bagu.org>
2220 Fix a crasher when refreshing the list view with the default table.
2222 This crash will also happen when loading the list view with the default
2223 table from a link or bookmark.
2225 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2226 to the main document selection page when the document id hasn't been
2228 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2229 the main document selection page when the document id hasn't been
2231 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2232 values for the details place when the document id hasn't been set.
2233 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2234 values for the list place when the document id hasn't been set.
2236 2011-12-21 Ben Konrath <ben@bagu.org>
2238 Protect against NPE when glom.document.locale is not in config.
2240 This patch protects against an NPE when glom.document.locale is not in
2241 the config file. This NPE will also happen if glom.document.locale is
2244 The patch also updates the error message to display the class name when
2245 the getMessage() returns null. This was happening when the NPE was
2246 thrown and I had "Configuration Error: null". If an NPE is encountered
2247 with this patch, "Configuration Error: NullPointerException " will be
2250 This commit closes this bug:
2252 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2254 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2256 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2258 Rename onlineglom.properties to onlineglom.properties.sample.
2260 * src/main/resources/onlineglom.properties: Rename to:
2261 * src/main/resources/onlineglom.properties.sample:
2262 * src/main/resources/README: And add this file explaining that people
2263 should rename it back when deploying.
2265 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2267 Allow choosing the translation in the .properties file.
2269 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2270 init(): Read a glom.document.locale value from the configuration file
2271 and call Glom's TransatableItem::set_current_locale() method.
2272 * src/main/resources/onlineglom.properties: Add a commented-out
2273 example of this new setting.
2275 It would be better to add &lang=de_DE to the URL, but the current
2276 libglom API does not allow us to do this easily. I am working on that.
2278 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2280 Avoid a crash in parsing of token parameters.
2282 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2283 ava: getTokenParams(): Do not crash if a parameter has a key but no
2284 value, and ignore parameters with neither.
2286 2011-12-17 Murray Cumming <murrayc@murayc.com>
2288 History token building/handling: Improve use of token parameters.
2290 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2291 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2292 and buildParamsToken(HashMap), for use by derived classes.
2293 Make the separator private because it is no longer be needed.
2294 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2295 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2296 instead of manual string concatenation.
2297 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2298 of hardcoded indices and awkward splitting code.
2299 * src/main/java/org/glom/web/client/place/ListPlace.java
2300 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2301 instead of manual string concatenation.
2302 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2303 of hardcoded indices and awkward splitting code.
2304 This should fix bug #666420
2306 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2308 Fix a Navgiation->Navigation typo in the code.
2310 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2311 Rename processNavgiation() to processNavigation().
2313 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2315 Fix a seperator->separator typo in the code.
2317 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2318 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2319 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2322 2011-12-15 Ben Konrath <ben@bagu.org>
2324 Cleanup some comments.
2326 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2328 2011-12-14 Ben Konrath <ben@bagu.org>
2330 Replace \n with <br/> for multiline text in the details view.
2332 Vertical scrollbars are added when needed as well.
2334 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2336 2011-12-14 Ben Konrath <ben@bagu.org>
2338 Specify the font for document selection links.
2340 * src/main/webapp/style.css:
2342 2011-12-14 Ben Konrath <ben@bagu.org>
2344 Fix bouncy CellTable while paging.
2346 This doesn't currently work with related list tables in unselected
2349 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2351 2011-12-14 Ben Konrath <ben@bagu.org>
2353 Revamp the appearance of the document selection page.
2355 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2356 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2357 * src/main/webapp/style.css:
2359 2011-12-13 Ben Konrath <ben@bagu.org>
2361 Set navigation button column to the smallest size possible.
2363 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2365 2011-12-13 Ben Konrath <ben@bagu.org>
2367 Change OpenButton nomenclature to NavigationButton.
2369 Using NavigtionButton makes things more generic. Classes, methods and
2370 variables have been changed.
2372 This is a rename-only refactor.
2374 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2375 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2376 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2377 Renamed from OpenButtonCell.
2378 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2379 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2380 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2382 2011-12-12 Ben Konrath <ben@bagu.org>
2384 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2386 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2387 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2388 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2389 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2391 2011-12-12 Ben Konrath <ben@bagu.org>
2393 Update variable names and comments.
2395 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2396 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2398 2011-12-12 Ben Konrath <ben@bagu.org>
2400 Properly initialize numNonEmptyRows variable to zero.
2402 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2403 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2405 2011-12-05 Ben Konrath <ben@bagu.org>
2407 Add latest mockup with HTML tables.
2409 Features of this mockup:
2411 -> HTML table for flowtable
2412 -> HTML table for flowtable column
2413 -> Example of how related lists would look
2414 -> Not using text entries for data items
2416 The current version of Online Glom doesn't use HTML tables for the
2419 This mockup has been sent to the glom-devel mailing list but it's good
2420 to have it here as well.
2422 * mockups/details-view-html-tables.html:
2424 2011-12-05 Ben Konrath <ben@bagu.org>
2426 Remove unnecessary getPrimaryKeyField() method.
2428 getPrimaryKeyFieldForTable(String) has been renamed to
2429 getPrimaryKeyField(String).
2431 * src/main/java/org/glom/web/server/database/DBAccess.java:
2432 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2433 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2435 2011-12-05 Ben Konrath <ben@bagu.org>
2437 Add string representation of TypedDataItem value to conversion error message.
2439 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2440 message was extracted into its own method to avoid duplication.
2442 2011-12-05 Ben Konrath <ben@bagu.org>
2444 Add type checking to navigation primary key value creation.
2446 Create navigation primary key only if the expected type from the Glom
2447 document matches the type returned by the SQL query.
2449 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2451 2011-12-05 Ben Konrath <ben@bagu.org>
2453 Rename a couple of variables in RelatedListNavigation.
2455 This is a rename-only refactor.
2457 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2459 2011-12-05 Ben Konrath <ben@bagu.org>
2461 Move getListLayoutGroup() into getListViewLayoutGroup().
2463 This removes getListLayoutGroup(). It was only being called by
2464 getListViewLayoutGroup().
2466 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2468 2011-12-05 Ben Konrath <ben@bagu.org>
2470 Remove check for LayoutItem_Portal in list table method.
2472 This check is no longer necessary because the method isn't being used
2473 to create the LayoutItemPortal DTO.
2475 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2477 2011-12-05 Ben Konrath <ben@bagu.org>
2479 Properly support related list navigation.
2481 Navigation from the "Repository Analyzer -> Package Scans ->
2482 Dependencies" related table wasn't working because the primary key for
2483 related tables wasn't being set properly. This commit fixes the
2486 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2487 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2488 doesn't set the primary key properly for related list tables.
2489 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2490 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2491 useful for getting the primary key for list view tables and for related
2493 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2494 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2495 Move code to set the primary key for the table from the abstract
2496 ListDBAccess class to ListViewDBAccess as it's only correct for list
2498 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2499 Properly add primary key to related list tables.
2501 2011-12-02 Ben Konrath <ben@bagu.org>
2503 Properly set the horizontal alignment of fields.
2505 This fix is for both the list tables and the details view.
2507 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2508 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2509 to set the horizontal alignment of fields.
2511 2011-12-02 Ben Konrath <ben@bagu.org>
2513 Display currency codes in the details view.
2515 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2517 2011-12-02 Ben Konrath <ben@bagu.org>
2519 Avoid duplicate JNI call.
2521 JNI is not as efficient as pure Java and this is an easy (and small)
2524 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2525 Use previously retrieved value for whereClauseToTableName instead of
2528 2011-12-02 Ben Konrath <ben@bagu.org>
2530 Rename a couple of variables in RelatedListNavigation.
2532 This is a rename-only refactor.
2534 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2536 2011-12-02 Ben Konrath <ben@bagu.org>
2538 Indicate clearly that a mismatched primary key type is a bug.
2540 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2541 warning to error. Add 'This is a bug.' to message.
2543 2011-12-02 Ben Konrath <ben@bagu.org>
2545 Update / fix some comments.
2547 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2549 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2551 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2552 Fix comments. Add some TODOs.
2554 2011-12-02 Ben Konrath <ben@bagu.org>
2556 Enable navigation to details view with string primary key from related list.
2558 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2559 Create a text primary key value when return type of result is
2560 java.sql.Types.VARCHAR.
2562 2011-12-02 Ben Konrath <ben@bagu.org>
2564 Use checkboxes for booleans in the details view.
2566 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2568 2011-12-01 Ben Konrath <ben@bagu.org>
2570 Improve performance of related list height calculation.
2572 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2573 Put code to calculate the expected height in a static initializer so
2574 that that it's only called once.
2576 2011-12-01 Ben Konrath <ben@bagu.org>
2578 Show related list tables in notebooks (again).
2580 Calculate the height of the related list tables so the Notebook can be
2581 set the correct height. The height of the related list table is also needed by
2582 FlowTable to be able decide how to create the layout.
2584 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2585 and set the Portal height based on the height of the related list
2586 table and the Portal container.
2587 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2588 Add method to calculate the height of the related list tables.
2589 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2590 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2591 calculate the height of the Pager widget.
2593 2011-12-01 Ben Konrath <ben@bagu.org>
2595 Use CellTable API for table property instead of setting style on Element.
2597 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2599 2011-12-01 Ben Konrath <ben@bagu.org>
2601 Make ListViewTable and RelatedListTable a consistent height.
2603 The tables are now a consistent height regardless of the contents of
2604 the table. A hidden button is added to empty rows to ensure that the
2605 height of these rows will match the height of rows with data.
2607 A navigation button column is now added to every table. The width of
2608 the navigation column is set to 0px when a RelatedListTable shouldn't
2609 have navigation buttons. This maintains the a consistent row height in
2610 tables that don't show the navigation buttons.
2612 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2613 navigation column when not needed.
2614 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2615 arguments for navigation button to constructor of ListViewTable.
2616 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2617 hidden button for empty data rows.
2618 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2619 arguments for navigation button to constructor.
2620 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2621 create navigation buttons. Add hideNavigationButtons() method.
2622 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2623 arguments for navigation button to constructor.
2625 2011-12-01 Ben Konrath <ben@bagu.org>
2627 Use 'visibility: hidden' in Utils.getWidgetHeight().
2629 This is better choice because hidden elements are invisible, don't
2630 respond to events and are not part of the tab order. They will,