1 2012-03-03 Ben Konrath <ben@bagu.org>
3 Display date and time in details view.
5 https://bugzilla.gnome.org/show_bug.cgi?id=671257
7 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
9 2012-02-24 Ben Konrath <ben@bagu.org>
11 Improve the tabs in the Notebook widget.
15 2012-01-30 Murray Cumming <murrayc@murrayc.com>
17 Translations: Try to translate the strings.
19 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
20 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
21 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
22 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
23 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
24 Take the Open translation from GTK+'s .po files.
25 Take the Details translation from Glom's po files.
26 I have added the other strings to Glom so we can get translations that way:
27 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
29 2012-01-27 Murray Cumming <murrayc@murrayc.com>
31 TableSelectionViewImpl: Put the search label and entry in a div.
33 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
34 Put the search widgets in a FlowTable so that the CSS can be used to
35 style them while keeping them together.
36 * src/main/webapp/style.css: Mention the new div.
38 2012-01-27 Murray Cumming <murrayc@murrayc.com>
40 Translate more strings in more locales.
42 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
43 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
44 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
45 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
46 Translate the "Details" and "Open" string too.
48 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
49 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
50 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
51 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
52 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
53 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
54 Add these new locales as placeholders though they currently contain English.
56 2012-01-27 Murray Cumming <murrayc@murrayc.com>
58 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
60 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
61 Check the ConfiguredDocument* for null before using it.
63 2012-01-26 Murray Cumming <murrayc@murrayc.com>
65 Tell Eclipse about the generated java files.
67 * .classpath: This lets it find OnlineGlomConstants.java.
68 It would be nice if Eclipse just used the maven build files.
70 2012-01-26 Murray Cumming <murrayc@murrayc.com>
72 Prevent a crash when no locale is specified in the URL.
74 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
75 Avoid returning a null string, obtained from
76 Window.Location.getParameter(). This caused a crash when it was
77 later passed to libglom's API.
78 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
79 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
80 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
81 guard against future null strings.
83 2012-01-26 Murray Cumming <murrayc@murrayc.com>
85 Use the ?locale= query param instead of the &lang= token param.
87 * src/main/java/org/glom/web/client/place/ListPlace.java
88 * src/main/java/org/glom/web/client/place/DetailsPlace.java
89 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
90 Remove the lang token key and value.
92 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
93 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
94 When the user selects a different locale from the chooser, use
95 Window.Location.assign() to change the URL, which then causes a reload.
97 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
98 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
99 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
100 * src/main/java/org/glom/web/client/activity/ListActivity.java
101 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
102 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
103 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
104 * src/main/java/org/glom/web/client/ui/ListView.java:
105 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
107 Remove localeID member variables and method/constructor parameters, instead
108 using Utils.getCurrentLocaleID() when we need a localID to pass to
111 2012-01-26 Murray Cumming <murrayc@murrayc.com>
113 Internationalize the UI strings.
115 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
116 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
117 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
118 because it is unused. Messages are apparently strings that can have
119 parameters, but we do not need that yet, so Contants will be enough for now.
120 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
121 to say that we support the en and de locales.
122 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
123 The original English strings.
124 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
125 Some German translations of the English strings.
126 The i18n goal then uses the .properties file to generate an
127 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
128 returns an implementation that returns the translated strings.
129 The documentation suggests putting these in src/java/*/client/, but it seems
130 best to put it in src/resources/*/client/.
131 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
132 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
133 instead of hard-coding them.
134 Note that we cannot import OnlineGlomConstants because it does not exist yet,
135 but that does not seem to stop the build, though it confuses Eclipse.
137 You can see the translated string by adding ?locale=de to the URL, like so:
138 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
140 2012-01-24 Murray Cumming <murrayc@murrayc.com>
142 Improve null/empty String checks.
144 * pom.xml: Add a dependency on commons-lang, to use
145 org.apache.commons.lang.StringUtils.
146 * src/main/java/org/glom/web/server/ConfiguredDocument.java
147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
148 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
149 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
150 Use StringUtils.isEmpty().
152 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
153 StringUtils class with a static isEmpty() function because we
154 cannot use org.apache.commons.lang.StringUtils in client-side
155 GWT code because it (apparently) cannot be compiled to javascript.
156 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
157 * src/main/java/org/glom/web/client/activity/ListActivity.java
158 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
159 * src/main/java/org/glom/web/client/place/DetailsPlace.java
160 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
161 * src/main/java/org/glom/web/client/place/ListPlace.java
162 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
163 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
164 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
165 * src/main/java/org/glom/web/client/ui/details/Group.java
166 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
167 our StringUtils.isEmpty() function.
169 2012-01-24 Murray Cumming <murrayc@murrayc.com>
171 Update to the latest java-libglom API.
173 * pom.xml: Require java-libglom 1.21.4.
174 * src/main/java/org/glom/web/server/ConfiguredDocument.java
175 getDocumentInfo(), getListViewLayoutGroup():
176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
178 * src/main/java/org/glom/web/server/database/DBAccess.java
179 getFieldsToShowForSQLQueryAddGroup(),
180 getPrimaryKeyLayoutItemField(): Replace get_database_title()
181 with either get_database_title_original() or
182 get_database_title(localeID).
184 2012-01-24 Murray Cumming <murrayc@murrayc.com>
186 ConfiguredDocument: Avoid a null pointer exception.
188 * src/main/java/org/glom/web/server/ConfiguredDocument.java
189 Initialize localeID to "" to avoid returning a null String which
190 causes a crash in java-libglom's swing-generated code.
192 2012-01-23 Murray Cumming <murrayc@murrayc.com>
194 Some simple renaming.
196 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
197 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
198 for localeChooser. This seems more appropriate and is less ambiguous
199 particularly in the .css file.
201 2012-01-23 Murray Cumming <murrayc@murrayc.com>
203 ConfiguredDocument: Rename the localedID private member variable.
205 2012-01-23 Murray Cumming <murrayc@murrayc.com>
207 Adapt to the latest java-libglom API from git master.
209 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
210 libglom now uses only Vector instead of List, which uses add() instead of
213 2012-01-20 Murray Cumming <murrayc@murrayc.com>
215 Build a source tarball with mvn assembly:single
217 * assembly.xml: Add this file.
218 * pom.xml: Use the maven-assembly-plugin and tell it to use
219 our assembly.xml file.
221 2012-01-19 Murray Cumming <murrayc@murrayc.com>
223 OnlineGlomServiceImpl: Get .glom files recursively.
225 * pom.xml: Depend on commons-io from org.apache.commons.
226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
227 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
228 files recursively, and with the easier filter for the extension.
229 Use org.apache.commons.io.FilenameUtils.removeExtension() to
230 simplify that code too.
232 2012-01-19 Murray Cumming <murrayc@murrayc.com>
234 README: Mention that you must install java-libglom packages separately.
236 But then it works, because java-libglom is now in the central maven
239 2012-01-18 Murray Cumming <murrayc@murrayc.com>
241 locales drop-down: Show the correct selected locale when the URL changes.
243 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
244 .java: setPlace(): Move some code into fillView().
246 2012-01-18 Murray Cumming <murrayc@murrayc.com>
248 locales drop-down: Do not lose the primary key.
250 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
251 start(): onLocaleChange(): Pass the current primary key value,
252 instead of an empty value.
254 2012-01-18 Murray Cumming <murrayc@murrayc.com>
256 locales drop-down: Do not lose the drop-down selection.
258 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
259 .java (TableSelectionActivity.fillView): Set the selected locale
260 after changing the drop-down items (though we do not really need
261 to change them just because the locale changes.)
263 2012-01-18 Murray Cumming <murrayc@murrayc.com>
265 locales drop-down: Change the tables list when this changes.
267 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
268 .java: TableSelectionActivity.start(): Move the async table titles
269 retrieval into a private fillView() method and also call this when
270 the chosen locale changes.
271 Note that the document title is not actually translatable yet, but
272 that is a problem that I should fix soon in libglom.
274 2012-01-18 Murray Cumming <murrayc@murrayc.com>
276 Improve the placement of the locales drop-down.
278 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
279 Put the title and locales drop-down in a div (gwt.FlowTable).
280 * src/main/webapp/style.css: Add magic css properties to make this work.
281 Also remove the left margin from the title so that it lines up with the
284 2012-01-18 Murray Cumming <murrayc@murrayc.com>
286 locales selector: Show human-readable locale titles.
288 * src/main/java/org/glom/web/server/ConfiguredDocument.java
289 getDocumentInfo(): Use java.util.Locale to show a real title of
290 each locale, in the locale's own language.
292 2012-01-17 Murray Cumming <murrayc@murrayc.com>
294 Add a language/locale selector drop-down.
296 * src/main/java/org/glom/web/shared/DocumentInfo.java:
297 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
298 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
299 getDocumentInfo(): Store the available Locales in the DocumentInfo.
300 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
301 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
302 Add a ListBox to show the available locales. Add getLocaleSelector(),
303 setLocaleList(), getSelectedLocale(), setSelectedLocale().
304 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
305 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
306 java: Add these classes.
307 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
308 start(): Fill the locales ListBox. Handle its change event, firing a
310 setPlace(): Show the selected locale as specified by the URL token.
311 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
312 * src/main/java/org/glom/web/client/activity/ListActivity.java:
313 Handle LocaleChangeEvent, going to a new *Place with that locale.
315 The placement of the ListBox is not pretty, and it currently uses the ID
316 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
320 2012-01-17 Murray Cumming <murrayc@murrayc.com>
322 Search box: Show the search text from the URL token.
324 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
325 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
326 Add setQuickFindText().
327 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
328 .java: setPlace(): Store the queryText if the place is a ListPlace,
329 and call TableSelectionView.setQuickFindText().
331 2012-01-17 Murray Cumming <murrayc@murrayc.com>
333 Allow use of translations via, for instance, &lang=de in the URL.
335 * pom.xml: Use the unstable java-libglom 1.21 version.
337 * src/main/java/org/glom/web/client/OnlineGlomService.java:
338 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
340 init(): Instead of calling TranslatableItem.set_current_locale()
341 (now removed), call ConfiguredDocument.setDefaultLocaleID().
342 However, this is only for default locales, which are not needed to
343 change the locale in the URL.
344 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
345 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
346 getSortedRelatedListData(): Add a localeID parameter, so we can get the
347 layout for a particular locale.
348 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
349 Add get/setDefaultLocaleID().
350 getDocumentInfo(), getListViewData(), getRelatedListData(),
351 getDetailsLayoutGroup(), getListViewLayoutGroup(),
352 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
353 localeID parameter, so we can get the layout for a particular locale.
355 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
356 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
357 * src/main/java/org/glom/web/client/place/ListPlace.java:
358 Parse and construct a lang parameter too.
360 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
361 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
362 passed to subsequent methods and constructors.
363 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
364 * src/main/java/org/glom/web/client/activity/ListActivity.java:
365 Store the localeID from the *Place and pass it to other constructors
366 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
368 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
369 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
370 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
371 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
372 * src/main/java/org/glom/web/client/ui/ListView.java:
373 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
374 Take localeID parameters and pass them to subsequent constructors and
375 methods, so that the layout is always retrieved for that locale.
377 This is rather repetitive.
379 Note that "" means the original (default) locale of the Glom document,
380 which is usually English.
382 2012-01-17 Murray Cumming <murrayc@murrayc.com>
384 Documents: Remove final keyword to fix startup configuration.
386 * src/main/java/org/glom/web/shared/Documents.java: Remove the
387 final keywords on the private member variables because that breaks
388 the startup, apparently (there are warnings) because it stops them
389 from being serialized. I added these in the previous commit.
391 2012-01-13 Murray Cumming <murrayc@murrayc.com>
393 Documents: Add some final keywords.
395 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
398 2012-01-13 Murray Cumming <murrayc@murrayc.com>
400 OnlineGlomServiceImpl: Add to overview comments.
402 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
403 Note that this is where all the document are loaded. They are not
404 loaded freshly for each page.
406 2012-01-12 Murray Cumming <murrayc@murrayc.com>
410 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
411 Add a TextBox for the text of a quick find.
412 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
414 setBackLink(): Add a String quickFind parameter.
415 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
416 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
417 to the base interface, because that is how TableSelectionViewImpl is used.
418 * src/main/webapp/style.css: Add style for the search box and its label.
420 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
421 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
422 Add these files, based on the existing TableChangeEvent and
423 TableChangeEventHandlers.
424 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
425 start(): Handle QuickFindChangeEvent, passing its quickFind text to
426 a ListPlace() that the user should be taken to.
427 * src/main/java/org/glom/web/client/activity/ListActivity.java
428 start(): Handle it here too and adapt the TableChangeEvent handler to
429 pass the extra "" quickFind parameter to ListPlace.
430 * src/main/java/org/glom/web/client/place/ListPlace.java:
431 Constructor: Take an extra String quickFind parameter and store it,
432 returning it from a new getQuickFind() method.
433 getToken(): Put the quickFind text in the URL token.
434 getPlace(): Parse the quickFind text from the URL token.
435 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
436 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
437 ListPlace constructor.
438 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
439 .java: start(): Add a Change handler for the TableSelectionView's
440 TextBox (via its base HasChangeHandlers interface), firing the new
441 QuickFindChangeEvent.
442 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
443 pass the extra "" quickFind parameter.
445 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
446 setCellTable(): Add a String quickFind parameter and pass it to
447 the ListViewTable() constructor.
448 * src/main/java/org/glom/web/client/ui/ListView.java: Change
449 setCellTable() in the base interface, because that is how ListViewImpl
452 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
453 Add a String quickFind member variable.
454 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
455 Constructor: Add a String quickFind parameter, storing it in the
456 base ListTable's member variable.
457 onRangeChanged(): Pass quickFind to the
458 OnlineGlomServiceAsync.getSortedListViewData() and
459 OnlineGlomServiceAsync.getListViewData() methods.
461 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
462 getListViewData(), getSortedListViewData(): Add a String quickFind
463 parameter, passing it to ConfiguredDocument.getListViewData().
464 * src/main/java/org/glom/web/client/OnlineGlomService.java:
465 Change getListViewData(), getSortedListViewData() in the base interface,
466 because that is how OnlineGlomServiceImpl is used, via this:
467 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
468 Change getListViewData(), getSortedListViewData() here too.
469 This class can apparently be used to asynchronously call methods on
470 OnlineGlomService, and GWT seems to implement that after recognizing
471 just the *Async name convention and the extra AsyncCallback parameters.
473 * src/main/java/org/glom/web/server/ConfiguredDocument.java
474 getListViewData(): Add a String quickFind parameter, and pass it to
475 ListViewDBAccess.getData().
476 * src/main/java/org/glom/web/server/database/ListDBAccess.java
477 getListData(): Add a String quickFind parameter and pass it to
479 getSelectQuery(): Add a String quickFind parameter.
480 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
481 getSelectQuery(): Add a String quickFind parameter and use it with
482 Glom.get_find_where_clause_quick() to pass a where_clause to
483 Glom.build_sql_select_with_where_clause(), to actually filter the
485 getData(): Add a String quickFind parameter, passing it to getListData().
486 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
487 va: getData(): Pass an empty string to getListData() for the
490 2012-01-12 Murray Cumming <murrayc@murrayc.com>
492 ListTable: Minor change.
494 * src/main/java/org/glom/web/client/ui/list/ListTable.java
495 createCellTable(): Make this protected instead of public.
497 2012-01-12 Murray Cumming <murrayc@murrayc.com>
499 Many files: Use final for the parameters and use the @override attribute.
501 2012-01-22 Ben Konrath <ben@bagu.org>
503 Add anchor links for single line text that starts with http, ftp and www.
507 2012-01-22 Ben Konrath <ben@bagu.org>
509 Add ellipsis to single line text in details view.
513 2012-01-04 Murray Cumming <murrayc@murrayc.com>
515 Remove all javadoc author tags.
517 Because they are awkward and meaningless when many people touch
519 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
521 2012-01-04 Murray Cumming <murrayc@murrayc.com>
523 Revert the COPYING.LESSER to COPYING rename.
525 Apparently both should be there if it is LGPL.
527 2012-01-03 Murray Cumming <murrayc@murrayc.com>
529 *View: Remove unused imports.
531 * src/main/java/org/glom/web/client/ui/DetailsView.java:
532 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
533 * src/main/java/org/glom/web/client/ui/ListView.java:
534 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
535 Remove unused imports, as suggested by Eclipse.
537 2012-01-02 Murray Cumming <murrayc@murrayc.com>
539 Move the *View::Presenter types, and some API into one base View.
541 * src/main/java/org/glom/web/client/ui/DetailsView.java:
542 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
543 * src/main/java/org/glom/web/client/ui/ListView.java:
544 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
545 Presenter, setPresenter() and clear() into a shared base interface,
546 to avoid the unnecessary duplicate Presenter types and to more clearly
547 show how the *Views share the same structure, even if they are not
548 used polymorphically.
550 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
551 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
553 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
554 * src/main/java/org/glom/web/client/activity/ListActivity.java:
555 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
557 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
560 Feel free to revert this if there is a good reason for the duplicate
563 2012-01-02 Murray Cumming <murrayc@murrayc.com>
565 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
567 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
568 a class member instead of a local variable in the method.
569 This lets us use it to get the view instances, for use in tests.
570 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
571 beforeOnlineGlom(): Test some more details of the initial view.
572 Again, this is not very useful.
574 To really test gwt-glom we will need to start a local postgresql
575 instance with local data, like the Glom tests in C++.
577 2012-01-02 Murray Cumming <murrayc@murrayc.com>
579 pom.xml: Mention the LGPL license.
581 * pom.xml: Add a licenses section.
582 * COPYING.LESSER: Move this to COPYING, which
583 previously contained the GPL. But gwt-glom is all LGPL.
585 2012-01-02 Murray Cumming <murrayc@murrayc.com>
587 Add project information to README and pom.xml.
589 * README: Add a brief description and mention some mvn
591 * pom.xml: This extra information shows up in mvn site
594 2011-01-02 Murray Cumming <murrayc@murrayc.com>
596 Use the latest java-libglom version.
598 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
600 2012-01-01 Murray Cumming <murrayc@murrayc.com>
602 GwtTestOnlineGlom: Test a little more.
604 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
605 protected rather than private, as suggested by the gwt-test-utils
607 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
608 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
609 Test the initial visibility of the panels.
611 However, this is not a very useful test.
612 And I wonder how we should generally test using this idea for an
613 activity/places app like ours where the real changes happen implicitly
614 based on the history token/URL.
616 2012-01-01 Murray Cumming <murrayc@murrayc.com>
618 Slight modification to *Mapper comments.
620 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
622 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
624 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
626 Remove comments mentioning GIN because they are just copied from
627 the example code and are apparently not helpful:
628 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
629 Also change the mention of a class that is only in the example code.
631 2012-01-01 Murray Cumming <murrayc@murrayc.com>
633 GwtTestOnlineGlom test: Minor changes.
635 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
636 Avoid the long qualified class name and modify the comment
637 because it is now obvious to me that the mocked class is the only
638 custom one created via GWT.create().
640 2012-01-01 Murray Cumming <murrayc@murrayc.com>
642 Tests: Added the beginnings of a test using gwt-test-utils.
644 * pom.xml: Add dependencies on gwt-test-utils and easymock.
645 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
646 which tells gwt-test-utils what class will be tested.
647 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
648 Add a simple (but empty) test case. One class, used by the OnlineGlom
649 class, is mocked so that it can be created. However, I am not sure
650 why only this class needs to be mocked.
652 Note that mockito seems more popular, and clearer, than easymock,
653 but I have not got that working yet. It might be a matter of the
656 This test is run during mvn integration-test.
658 2011-12-31 Murray Cumming <murrayc@murrayc.com>
660 Tests: Use junit4-style syntax instead of junit3-style.
662 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
663 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
664 * src/test/java/org/glom/web/shared/DataItemTest.java:
665 Use the @Test annotation rather than relying on the test*() prefix.
666 Also no longer implement TestCase, to avoid triggering support for
667 the junit3-way, which stops the annotations from working.
668 Change the imports from import junit.framework.* to
669 import org.junit.*, which is apparently the new way.
671 2011-12-31 Murray Cumming <murrayc@murrayc.com>
673 Added a test for ListPlace token parsing and creation.
675 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
676 This is much the same as DetailsPlaceTest.
678 I wonder how we could test the other parts of the *Place API.
680 2011-12-30 Murray Cumming <murrayc@murrayc.com>
682 DetailsPlace test: Also test getToken() and recreation via getPlace().
684 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
685 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
686 recreate it, testing the recreated DetailsPlace for the same parameter
689 2011-12-30 Murray Cumming <murrayc@murrayc.com>
691 Use the surefire-report plugin.
693 * pom.xml: This generates a HTML report about the tests in
694 target/site/surefire-report.html
695 when you do mvn surefire-report:report. It seems to be popular/normal.
697 2011-12-30 Murray Cumming <murrayc@murrayc.com>
699 Added a test for DetailsPlace.
701 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
702 Test the getPlace() token parsing.
704 2011-12-30 Murray Cumming <murrayc@murrayc.com>
706 Added a first unit test.
708 * pom.xml: Add a test goal, and a dependency on junit in that scope.
709 * src/test/java/org/glom/web/shared/DataItemTest.java:
710 This is a silly test but it is just to get things started. Note that
711 maven/junit finds the test because it looks in src/test by default.
713 2011-12-22 Ben Konrath <ben@bagu.org>
715 Change charsetName to "UTF-8" when replacing line breaks.
717 JavaScript requires the charsetName to be "UTF-8". CharsetName values
718 that work in Java (such as "UTF8") will not work when compiled to
721 This fixes a problem with multi-line details view fields that have hard
722 line breaks. The "License Text" field on this page demonstrates the
725 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
727 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
729 2011-12-22 Ben Konrath <ben@bagu.org>
731 Fix another bug with related list navigation.
733 I've tested all the navigation buttons in all of the related lists
734 so things should be good now.
736 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
738 2011-12-22 Ben Konrath <ben@bagu.org>
740 Fix a crasher when refreshing the list view with the default table.
742 This crash will also happen when loading the list view with the default
743 table from a link or bookmark.
745 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
746 to the main document selection page when the document id hasn't been
748 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
749 the main document selection page when the document id hasn't been
751 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
752 values for the details place when the document id hasn't been set.
753 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
754 values for the list place when the document id hasn't been set.
756 2011-12-21 Ben Konrath <ben@bagu.org>
758 Protect against NPE when glom.document.locale is not in config.
760 This patch protects against an NPE when glom.document.locale is not in
761 the config file. This NPE will also happen if glom.document.locale is
764 The patch also updates the error message to display the class name when
765 the getMessage() returns null. This was happening when the NPE was
766 thrown and I had "Configuration Error: null". If an NPE is encountered
767 with this patch, "Configuration Error: NullPointerException " will be
770 This commit closes this bug:
772 https://bugzilla.gnome.org/show_bug.cgi?id=666669
774 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
776 2011-12-20 Murray Cumming <murrayc@murrayc.com>
778 Rename onlineglom.properties to onlineglom.properties.sample.
780 * src/main/resources/onlineglom.properties: Rename to:
781 * src/main/resources/onlineglom.properties.sample:
782 * src/main/resources/README: And add this file explaining that people
783 should rename it back when deploying.
785 2011-12-20 Murray Cumming <murrayc@murrayc.com>
787 Allow choosing the translation in the .properties file.
789 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
790 init(): Read a glom.document.locale value from the configuration file
791 and call Glom's TransatableItem::set_current_locale() method.
792 * src/main/resources/onlineglom.properties: Add a commented-out
793 example of this new setting.
795 It would be better to add &lang=de_DE to the URL, but the current
796 libglom API does not allow us to do this easily. I am working on that.
798 2011-12-19 Murray Cumming <murrayc@murrayc.com>
800 Avoid a crash in parsing of token parameters.
802 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
803 ava: getTokenParams(): Do not crash if a parameter has a key but no
804 value, and ignore parameters with neither.
806 2011-12-17 Murray Cumming <murrayc@murayc.com>
808 History token building/handling: Improve use of token parameters.
810 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
811 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
812 and buildParamsToken(HashMap), for use by derived classes.
813 Make the separator private because it is no longer be needed.
814 * src/main/java/org/glom/web/client/place/DetailsPlace.java
815 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
816 instead of manual string concatenation.
817 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
818 of hardcoded indices and awkward splitting code.
819 * src/main/java/org/glom/web/client/place/ListPlace.java
820 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
821 instead of manual string concatenation.
822 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
823 of hardcoded indices and awkward splitting code.
824 This should fix bug #666420
826 2011-12-16 Murray Cumming <murrayc@murrayc.com>
828 Fix a Navgiation->Navigation typo in the code.
830 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
831 Rename processNavgiation() to processNavigation().
833 2011-12-16 Murray Cumming <murrayc@murrayc.com>
835 Fix a seperator->separator typo in the code.
837 * src/main/java/org/glom/web/client/place/DetailsPlace.java
838 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
839 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
842 2011-12-15 Ben Konrath <ben@bagu.org>
844 Cleanup some comments.
846 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
848 2011-12-14 Ben Konrath <ben@bagu.org>
850 Replace \n with <br/> for multiline text in the details view.
852 Vertical scrollbars are added when needed as well.
854 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
856 2011-12-14 Ben Konrath <ben@bagu.org>
858 Specify the font for document selection links.
860 * src/main/webapp/style.css:
862 2011-12-14 Ben Konrath <ben@bagu.org>
864 Fix bouncy CellTable while paging.
866 This doesn't currently work with related list tables in unselected
869 * src/main/java/org/glom/web/client/ui/list/ListTable.java
871 2011-12-14 Ben Konrath <ben@bagu.org>
873 Revamp the appearance of the document selection page.
875 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
876 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
877 * src/main/webapp/style.css:
879 2011-12-13 Ben Konrath <ben@bagu.org>
881 Set navigation button column to the smallest size possible.
883 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
885 2011-12-13 Ben Konrath <ben@bagu.org>
887 Change OpenButton nomenclature to NavigationButton.
889 Using NavigtionButton makes things more generic. Classes, methods and
890 variables have been changed.
892 This is a rename-only refactor.
894 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
895 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
896 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
897 Renamed from OpenButtonCell.
898 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
899 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
900 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
902 2011-12-12 Ben Konrath <ben@bagu.org>
904 Remove unnecessary String argument in RelatedListTable and ListViewTable.
906 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
907 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
908 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
909 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
911 2011-12-12 Ben Konrath <ben@bagu.org>
913 Update variable names and comments.
915 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
916 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
918 2011-12-12 Ben Konrath <ben@bagu.org>
920 Properly initialize numNonEmptyRows variable to zero.
922 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
923 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
925 2011-12-05 Ben Konrath <ben@bagu.org>
927 Add latest mockup with HTML tables.
929 Features of this mockup:
931 -> HTML table for flowtable
932 -> HTML table for flowtable column
933 -> Example of how related lists would look
934 -> Not using text entries for data items
936 The current version of Online Glom doesn't use HTML tables for the
939 This mockup has been sent to the glom-devel mailing list but it's good
940 to have it here as well.
942 * mockups/details-view-html-tables.html:
944 2011-12-05 Ben Konrath <ben@bagu.org>
946 Remove unnecessary getPrimaryKeyField() method.
948 getPrimaryKeyFieldForTable(String) has been renamed to
949 getPrimaryKeyField(String).
951 * src/main/java/org/glom/web/server/database/DBAccess.java:
952 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
953 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
955 2011-12-05 Ben Konrath <ben@bagu.org>
957 Add string representation of TypedDataItem value to conversion error message.
959 * src/main/java/org/glom/web/server/Utils.java: Logging the error
960 message was extracted into its own method to avoid duplication.
962 2011-12-05 Ben Konrath <ben@bagu.org>
964 Add type checking to navigation primary key value creation.
966 Create navigation primary key only if the expected type from the Glom
967 document matches the type returned by the SQL query.
969 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
971 2011-12-05 Ben Konrath <ben@bagu.org>
973 Rename a couple of variables in RelatedListNavigation.
975 This is a rename-only refactor.
977 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
979 2011-12-05 Ben Konrath <ben@bagu.org>
981 Move getListLayoutGroup() into getListViewLayoutGroup().
983 This removes getListLayoutGroup(). It was only being called by
984 getListViewLayoutGroup().
986 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
988 2011-12-05 Ben Konrath <ben@bagu.org>
990 Remove check for LayoutItem_Portal in list table method.
992 This check is no longer necessary because the method isn't being used
993 to create the LayoutItemPortal DTO.
995 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
997 2011-12-05 Ben Konrath <ben@bagu.org>
999 Properly support related list navigation.
1001 Navigation from the "Repository Analyzer -> Package Scans ->
1002 Dependencies" related table wasn't working because the primary key for
1003 related tables wasn't being set properly. This commit fixes the
1006 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1007 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1008 doesn't set the primary key properly for related list tables.
1009 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1010 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1011 useful for getting the primary key for list view tables and for related
1013 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1014 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1015 Move code to set the primary key for the table from the abstract
1016 ListDBAccess class to ListViewDBAccess as it's only correct for list
1018 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1019 Properly add primary key to related list tables.
1021 2011-12-02 Ben Konrath <ben@bagu.org>
1023 Properly set the horizontal alignment of fields.
1025 This fix is for both the list tables and the details view.
1027 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1028 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1029 to set the horizontal alignment of fields.
1031 2011-12-02 Ben Konrath <ben@bagu.org>
1033 Display currency codes in the details view.
1035 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1037 2011-12-02 Ben Konrath <ben@bagu.org>
1039 Avoid duplicate JNI call.
1041 JNI is not as efficient as pure Java and this is an easy (and small)
1044 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1045 Use previously retrieved value for whereClauseToTableName instead of
1048 2011-12-02 Ben Konrath <ben@bagu.org>
1050 Rename a couple of variables in RelatedListNavigation.
1052 This is a rename-only refactor.
1054 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1056 2011-12-02 Ben Konrath <ben@bagu.org>
1058 Indicate clearly that a mismatched primary key type is a bug.
1060 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1061 warning to error. Add 'This is a bug.' to message.
1063 2011-12-02 Ben Konrath <ben@bagu.org>
1065 Update / fix some comments.
1067 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1069 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1071 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1072 Fix comments. Add some TODOs.
1074 2011-12-02 Ben Konrath <ben@bagu.org>
1076 Enable navigation to details view with string primary key from related list.
1078 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1079 Create a text primary key value when return type of result is
1080 java.sql.Types.VARCHAR.
1082 2011-12-02 Ben Konrath <ben@bagu.org>
1084 Use checkboxes for booleans in the details view.
1086 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1088 2011-12-01 Ben Konrath <ben@bagu.org>
1090 Improve performance of related list height calculation.
1092 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1093 Put code to calculate the expected height in a static initializer so
1094 that that it's only called once.
1096 2011-12-01 Ben Konrath <ben@bagu.org>
1098 Show related list tables in notebooks (again).
1100 Calculate the height of the related list tables so the Notebook can be
1101 set the correct height. The height of the related list table is also needed by
1102 FlowTable to be able decide how to create the layout.
1104 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1105 and set the Portal height based on the height of the related list
1106 table and the Portal container.
1107 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1108 Add method to calculate the height of the related list tables.
1109 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1110 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1111 calculate the height of the Pager widget.
1113 2011-12-01 Ben Konrath <ben@bagu.org>
1115 Use CellTable API for table property instead of setting style on Element.
1117 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1119 2011-12-01 Ben Konrath <ben@bagu.org>
1121 Make ListViewTable and RelatedListTable a consistent height.
1123 The tables are now a consistent height regardless of the contents of
1124 the table. A hidden button is added to empty rows to ensure that the
1125 height of these rows will match the height of rows with data.
1127 A navigation button column is now added to every table. The width of
1128 the navigation column is set to 0px when a RelatedListTable shouldn't
1129 have navigation buttons. This maintains the a consistent row height in
1130 tables that don't show the navigation buttons.
1132 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1133 navigation column when not needed.
1134 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1135 arguments for navigation button to constructor of ListViewTable.
1136 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1137 hidden button for empty data rows.
1138 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1139 arguments for navigation button to constructor.
1140 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1141 create navigation buttons. Add hideNavigationButtons() method.
1142 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1143 arguments for navigation button to constructor.
1145 2011-12-01 Ben Konrath <ben@bagu.org>
1147 Use 'visibility: hidden' in Utils.getWidgetHeight().
1149 This is better choice because hidden elements are invisible, don't
1150 respond to events and are not part of the tab order. They will,
1151 however, take up space which is required to be able to calculate the
1152 height of the widget.
1154 * src/main/java/org/glom/web/client/Utils.java:
1156 2011-12-01 Ben Konrath <ben@bagu.org>
1158 Use Utils.getWidgetHeight() in FlowTable.
1160 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1162 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1164 2011-12-01 Ben Konrath <ben@bagu.org>
1166 Put the details css class name on the correct table column.
1168 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1170 2011-11-30 Ben Konrath <ben@bagu.org>
1172 Update for java-libglom API change.
1174 The getters and setters on FieldFormatting and NumericFormat were
1175 changed to remove the 'M'.
1177 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1179 2011-11-29 Ben Konrath <ben@bagu.org>
1181 Only allow RelatedListTables in Portals.
1183 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1185 2011-11-29 Ben Konrath <ben@bagu.org>
1187 Only create a contents panel for Portals when title is being set.
1189 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1191 2011-11-29 Ben Konrath <ben@bagu.org>
1193 Set TabLayoutPanel height based on calculated height its widgets.
1195 This is a potential fix for this bug:
1197 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1199 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1201 2011-11-29 Ben Konrath <ben@bagu.org>
1203 Align details field labels and data with the Open buttons.
1205 * src/main/webapp/style.css:
1207 2011-11-29 Ben Konrath <ben@bagu.org>
1209 Remove unnecessary <div> in the Notebook widget.
1211 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1212 method to get container FlowPanel (<div>).
1213 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1214 initWidget() method directly on the TabLayoutPanel widget instead of
1215 Group's container widget.
1217 2011-11-29 Ben Konrath <ben@bagu.org>
1219 Don't add group titles for Portals in Notebooks.
1221 This reverts the previous patch and fixes a bug I introduced with
1222 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1224 * src/main/java/org/glom/web/client/ui/details/Group.java:
1225 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1227 2011-11-28 Ben Konrath <ben@bagu.org>
1229 Remove unused boolean argument in Portal constructor.
1231 Just a code cleanup.
1233 * src/main/java/org/glom/web/client/ui/details/Group.java:
1234 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1236 2011-11-28 Ben Konrath <ben@bagu.org>
1238 Remove hack for glom 1.18 style glom files.
1240 * src/main/java/org/glom/web/client/ui/details/Group.java:
1241 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1242 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1244 2011-11-28 Ben Konrath <ben@bagu.org>
1246 Use Gda Value version of primary key to log result too large error.
1248 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1250 2011-11-28 Ben Konrath <ben@bagu.org>
1252 Don't use TypedDataItem.getText() for Unknown types from the URL.
1254 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1255 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1256 instead of getText().
1257 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1258 String field and getUnknown() method.
1260 2011-11-28 Ben Konrath <ben@bagu.org>
1262 Log an error message when the java-libglom .so is not present.
1264 The error message was being set in the exception but not logged.
1266 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1268 2011-11-28 Ben Konrath <ben@bagu.org>
1270 Ignore LayoutItem_CalendarPortals.
1272 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1273 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1275 2011-11-28 Ben Konrath <ben@bagu.org>
1277 Extract method for creating the LayoutItemPortal DTO.
1279 Just breaking the code up into smaller chunks.
1281 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1283 2011-11-28 Ben Konrath <ben@bagu.org>
1287 This should have been added with the refactor. Oops!
1289 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1291 2011-11-28 Ben Konrath <ben@bagu.org>
1293 Create primary key value from URL string using type from Glom document.
1295 See this bug, comments 19 - 25:
1297 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1299 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1300 create a TypeDataItem for the primary key here when loading from a
1301 URL. Show the same string for the primary key value as was received
1302 from the URL string (when loading from a URL).
1303 * src/main/java/org/glom/web/server/Utils.java: Update method for
1304 creating the Gda Value from the TypeDataItem to properly deal with
1305 creating a Gda Value based on the Glom document type for the primary
1306 key value string when loading from a URL.
1307 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1308 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1309 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1310 Update for changed method name.
1312 2011-11-27 Ben Konrath <ben@bagu.org>
1314 Rename PrimaryKeyItem to TypedDataItem.
1316 The name PrimaryKeyItem suggests what the class should be used for.
1317 TypedDataItem is a neutral name that describes the class better.
1319 This is a rename-only refactor.
1321 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1322 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1323 * src/main/java/org/glom/web/client/Utils.java:
1324 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1325 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1326 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1327 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1328 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1329 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1330 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1331 * src/main/java/org/glom/web/server/Utils.java:
1332 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1333 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1334 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1335 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1337 2011-11-25 Ben Konrath <ben@bagu.org>
1339 Improve Gda Value conversion from PrimaryKeyItem.
1341 The value from the PrimaryKeyItem is only used if its type match the
1342 type from the glom document.
1344 * src/main/java/org/glom/web/server/Utils.java:
1346 2011-11-25 Ben Konrath <ben@bagu.org>
1348 Manually check if the java-liblgom .so is visible to the JVM.
1350 It seems that Tomcat has problems when a static initializer throws an
1351 exception. This check is done before the first method call into
1352 java-libglom so that execution doesn't continue if the .so is not
1355 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1357 2011-11-25 Ben Konrath <ben@bagu.org>
1359 Improve browser configuration error messages.
1363 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1365 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1366 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1367 getConfigurationErrorMessage() method.
1368 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1369 Get and display a specific configuration error message when no Glom
1370 documents are found.
1371 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1372 Implement getConfigurationErrorMessage() method. Surround configuration
1373 code in the init() method with a try/catch block. This allows the
1374 errors to be caught while keeping the servlet available to retrieve the
1375 configuration error message.
1377 2011-11-25 Ben Konrath <ben@bagu.org>
1379 Don't use Strings to hold primary key values.
1381 The primary key values are now held in a new data object
1382 (PrimaryKeyItem) that holds type information and the primary key value
1383 using the correct type.
1385 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1386 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1387 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1388 PrimaryKeyItem instead of String to hold the primary key value.
1389 * src/main/java/org/glom/web/client/Utils.java: Remove
1390 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1391 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1392 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1393 PrimaryKeyItem instead of String to hold the primary key value. Load
1394 document selection page when the documentID has not been set correctly.
1395 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1396 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1398 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1399 Return empty string for URL instead of "null".
1400 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1401 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1402 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1403 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1404 PrimaryKeyItem instead of String to hold primary key values.
1405 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1406 PrimaryKeyValue to a Gda Value.
1407 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1408 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1409 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1410 Replace temporary database access code that uses the PrimaryKeyValue to
1411 Gda Value conversion.
1412 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1413 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1414 PrimaryKeyItem instead of String.
1415 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1416 hold primary key values.
1418 2011-11-24 Ben Konrath <ben@bagu.org>
1420 Use newly added java-libglom API to create queries.
1422 This isn't finished. I still need to stop using Strings for primary key
1423 values in the client code.
1425 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1426 libglom to use fake connections so that retrieving the query string will
1428 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1429 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1430 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1431 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1432 Use the newly added libglom sql methods and classes to create the
1433 query. Add temporary hack to convert primary value strings to Gda
1436 2011-11-23 Ben Konrath <ben@bagu.org>
1438 Don't explicitly set the height of Portals.
1440 See comments 6 - 10 of this bug for details:
1442 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1444 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1446 2011-11-23 Ben Konrath <ben@bagu.org>
1448 Use an HTML table instead of CSS for the FlowTable layout.
1450 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1451 GWT's FlexTable to implement the FlowTable.
1452 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1454 2011-11-18 Ben Konrath <ben@bagu.org>
1456 Add boolean example to HTML table mockup.
1458 * mockups/details-view-html-tables-text-entries.html:
1460 2011-11-17 Ben Konrath <ben@bagu.org>
1462 Ensure the pager buttons are always visible for related lists.
1464 To accomplish this, I've turned off text wrapping in the list view and
1465 related list tables for both the header and data text. The related list
1466 table now has a fixed layout so the it doesn't overflow its container.
1467 This is required to ensure that the cell text is clipped when it
1468 overflows the cell and an ellipsis is added to the right side of the
1469 cell when text is clipped.
1471 A fixed table layout for the related list table in the details view
1472 seems what we want for the details view anyway, so the side-effect is
1475 The ellipsis will only be displayed in Firefox >= 7.
1479 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1481 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1482 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1483 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1485 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1486 Set the 'table-layout: fixed' CSS property to the related list table.
1487 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1488 'white-space: nowrap;' CSS property on both the list view and the
1489 related list tables.
1491 2011-11-16 Ben Konrath <ben@bagu.org>
1493 Rework the fix for empty notebook tab labels.
1495 Setting the empty group titles with its name caused problems for the
1496 details layout. Instead of using libglom's
1497 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1498 to the client when the title is empty. This allows the Notebook to use
1499 the name when the title is empty without affecting anything else.
1501 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1502 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1504 2011-11-16 Ben Konrath <ben@bagu.org>
1506 Set group titles with name when title is empty.
1508 This fixes a problem with an empty notebook tab label in the Lesson
1509 Planner document. The forth tab in the notebook should be "Internet":
1511 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1513 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1514 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1517 2011-11-16 Ben Konrath <ben@bagu.org>
1519 Remove whitespace from the configured username properties.
1521 This assumes that usernames won't have whitespace at the beginning
1522 or end. But I think this is a reasonable assumption.
1524 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1525 String.trim() to remove the whitespace from the username properties.
1527 2011-11-15 Ben Konrath <ben@bagu.org>
1529 Add details view mockup with HTML tables and text entries.
1531 This is from the attachment on this bug:
1533 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1535 * mockups/details-view-html-tables-text-entries.html:
1537 2011-11-15 Ben Konrath <ben@bagu.org>
1539 Add space between the columns of the flow table.
1543 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1545 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1546 space between columns in the flow table.
1548 2011-11-15 Ben Konrath <ben@bagu.org>
1550 Add backup files to the .gitignore.
1552 * .gitignore: Ignore files that end with ~.
1554 2011-11-09 Ben Konrath <ben@bagu.org>
1556 Use latest release of gwt-log.
1558 Gwt-log releases are now being submitted to the maven central
1559 repository so manual installation of the jar is no longer required.
1561 * pom.xml: Update version and groupId of gwt-log dependency.
1563 2011-10-31 Ben Konrath <ben@bagu.org>
1565 Don't use GWT numeric formatting to override the glom currency formatting.
1567 Currencies are now displayed like they are in Glom. See this bug:
1569 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1571 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1573 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1574 currency code to constructor and set it when the cell is rendered.
1575 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1576 currency code to the constructor of the NumericCell.
1578 2011-10-27 Ben Konrath <ben@bagu.org>
1580 Require the latest release of java-libglom (1.17.4).
1584 2011-10-26 Ben Konrath <ben@bagu.org>
1586 Add style to Notebook that matches current theme.
1588 It's not the best style in the world but it's better than the default.
1590 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1591 padding at the bottom of the child widgets.
1592 * src/main/webapp/style.css: Add style for the Notebook.
1594 2011-10-26 Ben Konrath <ben@bagu.org>
1596 Move servlet initialization code to overridden init method.
1598 This is half of the solution to getting proper error messages
1599 displayed when configuration errors occur. Here's the relevant bug:
1601 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1603 The rest of the solution involves surrounding the init method with a
1604 try/catch block and setting a global variable with the error /
1605 exception. A new async method should be created to retrieve and display
1606 the error message / exception.
1608 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1609 code from constructor to init method adding exceptions as needed.
1611 2011-10-26 Ben Konrath <ben@bagu.org>
1613 Add script to monitor and restart tomcat if required.
1615 * utils/check-and-recover-tomcat.py: New file.
1617 2011-10-26 Ben Konrath <ben@bagu.org>
1619 Display the correct number of data items in the pager.
1623 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1625 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1626 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1627 The implementation is the same for both tables: Keep track of the
1628 number of non-empty rows and fire and RowCountChangeEvent after the data has
1630 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1631 custom Pager class that subclasses SimplePager to handle displaying
1632 the correct number when empty rows have been added.
1634 2011-10-26 Ben Konrath <ben@bagu.org>
1636 Correct error in previous commit.
1638 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1639 eventBus parameter from listView.setCellTable().
1641 2011-10-26 Ben Konrath <ben@bagu.org>
1643 Fix error in TODO comment.
1645 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1647 2011-10-24 Ben Konrath <ben@bagu.org>
1649 Create Notebook widgets to the details view.
1651 This isn't finished just yet - I still need to create a reasonable
1652 style to match the current theme.
1654 * src/main/java/org/glom/web/client/Utils.java: Add method for
1655 calculating the height of a widget. This is used in the Notebook class.
1656 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1657 new constructor method in Group.
1658 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1659 method for creating child widget that can be used by subclasses
1660 like Notebook. New constructor that allows disabling the group
1661 titles - Notebooks don't set a group title for their child groups.
1662 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1663 to make Notebooks using GWT's TabLayoutPanel.
1664 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1665 constructor that allows disabling the group titles.
1666 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1667 LayoutItemNotebook DTO.
1668 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1669 DTO for Notebooks. It's just an empty class for now but we might need
1670 it to transfer some specific information in the future.
1672 2011-10-21 Ben Konrath <ben@bagu.org>
1674 Add navigation buttons to related list tables.
1676 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1677 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1678 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1679 method getSuitableRecordToViewDetails() for getting the table name
1680 and primary key value for related list navigation buttons.
1681 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1682 private cell renderer class to get the navigation information for
1683 related list tables from the server. Extract the navigation
1684 processing code from the details cell navigation and use it for the
1685 related list navigation as well.
1686 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1687 cell renderer class for the details open buttons. This was needed
1688 because the related list navigation buttons and the list view
1689 navigation buttons need to react differently when clicked.
1690 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1691 the onEnterKeyDown() method because it's now overriden in the
1692 subclasses that are specific to the related list tables and the list
1694 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1695 the vertical size a little because the buttons add a bit of vertical
1696 space to table. This is not a perfect solution because the vertical
1697 size of with table fewer than 5 rows will be a little smaller.
1698 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1699 changes in how navigation buttons are handled.
1700 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1701 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1702 database access object.
1703 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1704 to find the portal for a given relationship name from
1705 RelatedListDBAccess. Add method to find a primary key field for a
1707 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1708 Move code to find the portal for a given relationship name to
1710 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1711 New file: database access object for getting the related list
1712 navigation information (the table name and the primary key value).
1713 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1714 DTO for transferring a table name to navigate to and a primary key
1716 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1717 boolean and getter/setter to specifies if the related list should add
1720 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1722 Use the master branch of java-libglom
1724 * pom.xml: Depend on java-libglom 1.19 instead.
1726 This is the master branch. See also the libglom-1-18 branch.
1728 2011-10-11 Ben Konrath <ben@bagu.org>
1730 Enable the open navigation button when the data has been set.
1732 This avoids having active buttons that don't do anything when the data
1735 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1737 2011-10-11 Ben Konrath <ben@bagu.org>
1739 Use IsWidget interface for FlowTableItem.
1741 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1742 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1744 2011-10-11 Ben Konrath <ben@bagu.org>
1746 Remove GWT styling from open button in details view.
1748 There are still some issues with how the details cell is arranged but
1749 this should be made to match Glom 1.20. I'm going to leave fixing this
1750 until I have Glom 1.20 up and running.
1752 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1753 style name on open button.
1754 * src/main/webapp/style.css: Move and edit details-navigation class.
1755 Re-arrange some classes to make them appear in the same order as the
1758 2011-10-07 Ben Konrath <ben@bagu.org>
1760 Update to GWT 2.4.0.
1762 * .gitignore: Ignore new cache directory.
1763 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1764 * pom.xml: Change GWT and maven plugin to 2.4.0.
1765 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1767 * src/main/java/org/glom/web/client/ClientFactory.java:
1768 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1769 * src/main/java/org/glom/web/client/OnlineGlom.java:
1770 Update source for API changes.
1771 * utils/build-onlineglom-war.sh: Remove cache directory before the
1774 2011-10-07 Ben Konrath <ben@bagu.org>
1776 Add navigation buttons in the details view.
1778 This isn't finished but I thought I'd commit what I have as it's a
1779 pretty good start. I still need to:
1781 1. Change the style so that it fits better into the current theme
1782 2. Adjust the details cell to expand as much as possible.
1784 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1785 click handlers to navigation buttons in the DetailsCells. Create a
1786 refreshData() method to get just the data from the server without the
1788 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1789 Update the tableSelector and browser title when the table name
1790 changes without using the tableSelector.
1791 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1792 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1793 getDetailsCells() to getCells(). Update variable names.
1794 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1795 method to set click handler on navigation button. Rename a few
1796 variables. Add navigation buttons where needed.
1797 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1798 variables and methods.
1799 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1800 navigation boolean and navigation table as required in the
1801 LayoutItemField DTO.
1802 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1803 variables for navigation along with getter/setter methods.
1805 2011-10-07 Ben Konrath <ben@bagu.org>
1807 Rename Field to DetailsCell.
1809 This is a refactor-only commit. No functionality has been added or
1812 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1813 Update variable and method names.
1814 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1815 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1816 variable and method names.
1817 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1819 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1820 variable and method names.
1822 2011-10-07 Ben Konrath <ben@bagu.org>
1824 Create separate methods for layout and data the details view.
1826 This is a refactor-only commit. No functionality has been added or
1829 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1830 private methods: setData(), createLayout().
1832 2011-10-07 Ben Konrath <ben@bagu.org>
1834 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1836 This is part of a change to get navigation buttons in the details view
1837 but it should have been done this way from the start.
1839 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1840 for method name change in TableSelectionView.
1841 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1842 Create TableChangeEvent and set the browser title using the
1843 TableSelectionView API.
1844 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1845 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1846 Change getSelectedTable() to getSelectedTableName(). Add
1847 getSelectedTableTitle().
1849 2011-10-07 Ben Konrath <ben@bagu.org>
1851 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1853 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1855 2011-10-07 Ben Konrath <ben@bagu.org>
1857 Update TableChangeEvent to use newTableName naming convention.
1859 This makes the class more consistent with GWT naming conventions.
1861 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1862 Update for method name change in TableChangeEvent.
1863 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1864 for method name change in TableChangeEvent.
1865 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1866 newTableName variable and getter method. Make toDebugString()
1869 2011-09-30 Ben Konrath <ben@bagu.org>
1871 Disable the pager in the list tables when the data row count is less than the minimum.
1873 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1874 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1876 2011-09-30 Ben Konrath <ben@bagu.org>
1878 Add empty rows to the end of related list and list view tables.
1880 I also extracted the cell rendering classes from the ListTable because
1881 the code was becoming a little crazy with all the anonymous inner
1882 classes. My plan is to use these cell rendering classes in the details
1883 view as well so this refactor will be needed for that change.
1885 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1886 set the row count in related list tables if the data has more rows
1887 than the minimum number of rows visible.
1888 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1889 row count in list view tables if the data has more rows than the
1890 minimum number of rows visible.
1891 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1892 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1894 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1895 for rendering TYPE_NUMERIC cells. The code was extracted from the
1897 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1898 class for rendering cells with buttons in list views. The code was
1899 extracted from the ListTable class.
1900 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1901 for rendering TYPE_TEXT cells. The code was extracted from the
1903 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1904 Add empty rows to the end of the data if required. Implement
1905 ListTable.getMinNumVisibleRows().
1906 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1907 cell renderer code to public classes. Return null in
1908 Column.getValue() for empty rows. Add new abstract method:
1909 getMinNumVisibleRows(). Move code to set the row count of the list view
1910 table to ListViewImpl.
1911 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1912 empty rows to the end of the data if required. Implement
1913 ListTable.getMinNumVisibleRows().
1916 2011-09-27 Ben Konrath <ben@bagu.org>
1918 Use GWT.log for client-side debugging statements.
1920 These are optimized out when deployed so I should have used this method
1921 in the first place. These statements will eventually be replaced with some sort
1922 of notification in the browser.
1924 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1925 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1926 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1927 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1928 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1930 2011-09-27 Ben Konrath <ben@bagu.org>
1932 Put tableselector on the right, back to list link on right.
1934 The idea is that the table selector is acting like a label for the
1935 currently displayed table so it should be placed below the document title. This
1936 puts the table title in a similar position to where it is in Glom.
1938 * mockups/details-contacts.html:
1939 * mockups/details-projects.html:
1940 * mockups/listview-contacts.html:
1941 * mockups/listview-projects.html:
1942 * mockups/style.css:
1943 Update mockups to match how the interfaces currently look.
1944 * src/main/webapp/style.css: Swap positions of backlink with the table
1945 selector. Add some space on the left side of the table selector to
1946 line things up with the document title.
1948 2011-09-27 Ben Konrath <ben@bagu.org>
1950 Add field colouring to details view.
1952 This change re-works how field colouring works. The colour formatting
1953 information is now set to the client with the layout information instead of
1954 with the data. This eliminates the need to send the same colour strings for
1955 data in list view column when colour information is set.
1957 In order to set an alternate colour for negative numeric values, the
1958 number is now sent to client and formatted with the GWT NumberFormat class.
1960 This change also fixes:
1962 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1964 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1965 internationalization framework which is needed for client side numeric
1967 * src/main/java/org/glom/web/client/Utils.java: New file for some
1968 client static utility methods.
1969 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1970 the DataItem object to the Field class. Use a utility method to
1971 create the foreignKeyValue string.
1972 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1973 alignment and text colours in the constructor. Add setData(DataItem)
1974 method. Remove setText(String) method.
1975 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1976 colour information to GlomTextCell. Create and use GlomNumberCell for
1977 rendering numbers. Use utility method to get the string for the
1978 primary key of the key provider. Re-work how the horizontal alignment
1980 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1981 formatting to layout information. Methods for converting the libglom
1982 formatting information were moved from DBAccess.
1983 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1984 numeric formatting (it's now done on the client side). Don't set text
1985 colours in DataItem. Move libglom formatting conversion methods to
1987 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1988 getters/setters for text colour information.
1989 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1990 for transferring the libglom NumericFormat information to the client.
1991 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1992 and getters/setters for: GlomNumericFormat, background colour and
1993 foreground colour strings.
1995 2011-09-26 Ben Konrath <ben@bagu.org>
1997 Simplify code that iterates through the LayoutGroup.
1999 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2001 2011-09-26 Ben Konrath <ben@bagu.org>
2003 Accept Eclipse formatting for OnlineGlomServiceAsync.
2005 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2007 2011-09-26 Ben Konrath <ben@bagu.org>
2009 Don't use the ListDBAccess classes to get the primary key layout information.
2011 This was causing a bug where the wrong index for the hidden primary key
2012 was being sent to the client.
2014 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2015 primary key while creating the LayoutGroup DTO. Create a
2016 LayoutItemField DTO for hidden primary keys. Don't use the
2017 RelatedListDBAccess because it was only used for getting the primary
2019 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2020 access modifier from public to protected for getPrimaryKeyField() and
2021 getPrimaryKeyLayoutItemField().
2022 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2023 abstract method getExpectedResultSize() because RelatedListDBAccess
2024 doesn't have enough info to implement it.
2025 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2026 Remove @Override for getExpectedResultSize().
2027 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2028 Remove method getExpectedResultSize().
2030 2011-09-23 Ben Konrath <ben@bagu.org>
2032 Log which layout (list or details) the ignored item is from.
2034 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2036 2011-09-23 Ben Konrath <ben@bagu.org>
2038 Remove annotations that turn off code formatting in DataItem.
2040 * src/main/java/org/glom/web/shared/DataItem.java:
2042 2011-09-23 Ben Konrath <ben@bagu.org>
2044 Rename GlomField to DataItem and update associated methods.
2046 This is a rename-only refactor. No functionality has been added or
2049 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2050 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2051 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2052 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2053 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2054 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2055 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2056 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2057 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2058 * src/main/java/org/glom/web/server/database/DBAccess.java:
2059 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2060 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2061 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2062 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2063 * src/main/java/org/glom/web/shared/DataItem.java:
2064 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2065 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2067 2011-09-23 Ben Konrath <ben@bagu.org>
2069 Rename GlomDocument to DocumentInfo and update associated methods.
2071 This is a rename-only refactor. No functionality has been added or
2074 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2075 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2076 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2077 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2078 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2079 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2080 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2082 2011-09-20 Ben Konrath <ben@bagu.org>
2084 Require java-libglom 1.17.3.
2086 This picks up the fix for the seg fault problem with the Scenes table
2087 in the Openismus Film Manager example.
2091 2011-09-20 Ben Konrath <ben@bagu.org>
2093 Change the way sort clause is added for primary key when no sort clause is requested.
2095 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2096 before the sort clause is created. When a sort clause is not requested, the
2097 sort clause is created by finding the primary key in the LayoutFieldVector
2100 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2102 2011-09-20 Ben Konrath <ben@bagu.org>
2104 Log error message if no documents are found in the configured directory.
2106 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2107 Extract the glom file extension string to a private static final class
2108 variable (mostly as syntactic sugar). Accept a minor formatting change.
2109 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2110 the example glom.document.directory configuration property to make it
2111 more clear that it can any directory, not just the home directory.
2113 2011-09-18 Ben Konrath <ben@bagu.org>
2115 Add related lists to details view.
2117 The related list table has support for paging and sorting just like the
2118 table in the list view.
2120 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2121 SQL queries for the related list tables.
2122 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2123 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2124 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2125 Rename getList methods to getListView and add comments. Remove
2126 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2127 it being unused. Add methods: getDetailsLayoutAndData(),
2128 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2129 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2130 Create the layout and set the data for the fields in one async call
2131 instead of two. Create related lists where appropriate.
2132 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2133 for method name changes in OnlineGlomService.
2134 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2135 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2136 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2138 * src/main/java/org/glom/web/client/ui/ListView.java:
2139 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2140 tableName from setCellTable(). Create a ListViewTable instead of
2142 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2143 represent a data field in the details view.
2144 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2145 from addDetailsCell() to Field class. Keep track of the Fields and
2146 Portals in the details view.
2147 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2148 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2149 and add a method to get it. Add method to set the contents of the
2151 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2152 New class for related list tables. This class has the data provider
2153 for the related list table.
2154 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2155 abstract class which is the base class for the ListViewTable and the
2157 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2158 New class for list view tables. This class has the data provider for
2159 the list view table.
2160 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2161 methods for related list tables. Add more information to the
2162 LayoutItemField and LayoutItemPortal DTOs.
2163 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2164 Remove debugging print statement.
2165 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2166 Remove debugging print statements. Add primary key field to SQL count
2168 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2169 Remove unnecessary LayoutFieldVector parameter from
2170 getResultSizeOfSQLQuery() method.
2171 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2172 New class for related list table database access.
2173 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2174 class that is a wrapper DTO for details view layout and data.
2175 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2176 new 'fromField' string to this DTO.
2177 * src/main/webapp/style.css: Remove bottom margin and override top
2180 2011-09-15 Ben Konrath <ben@bagu.org>
2182 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2184 This sets things up to make it easier to add the data retrieval for
2185 related lists (portals). No user noticeable changes were made with
2188 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2189 class has the code to retrieve the layouts and access the
2190 database using the new database helper classes.
2191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2192 Most of the functionality has been removed from this class. This
2193 class now represents the public interface for the client side
2194 code. It also deals with configuring the servlet and cleaning
2195 things up when the servlet is stopped.
2196 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2197 of static methods into this utility class.
2198 * src/main/java/org/glom/web/server/database/DBAccess.java:
2199 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2200 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2201 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2202 These classes have the database retrieval code. The class hierarchy
2203 has been setup to make it easy to reuse code for similar
2206 2011-09-06 Ben Konrath <ben@bagu.org>
2208 Create separate classes for list table code and the data provider.
2210 As part of this refactor, I also split up the code a bit to make it
2213 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2214 table code to two new classes (below).
2215 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2216 with code from ListViewImpl.
2217 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2218 New file with code from ListViewImpl.
2220 2011-09-06 Ben Konrath <ben@bagu.org>
2222 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2224 This fixes the LayoutItemPortal DTO to match the libglom layout object
2227 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2229 2011-09-01 Ben Konrath <ben@bagu.org>
2231 Set title of Portals in the Details View.
2233 * pom.xml: Bump required version of java-libglom to 1.17.1.
2234 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2235 widget creation to its own class. Add comments to constructor.
2236 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2237 The code is mostly from the Group class with the title now set.
2238 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2239 title of Portal. Update some comments. Fix some code formatting.
2241 2011-09-01 Ben Konrath <ben@bagu.org>
2243 Remove TODO comment for the flow table column width.
2245 The flow table column width is working correctly and doesn't need to be
2246 changed. See this mailing list post for more info:
2248 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2250 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2252 2011-08-27 Ben Konrath <ben@bagu.org>
2254 Add document title (database name) to top of the browser page.
2256 I added the document title to the TableSelecitonView but that will
2257 change if / when we add a view that doesn't require table selection.
2259 * mockups/details-contacts.html:
2260 * mockups/details-projects.html:
2261 * mockups/listview-contacts.html:
2262 * mockups/listview-projects.html:
2263 * mockups/style.css: Add document title to mockups to keep things
2265 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2266 sizes to account for the document title.
2267 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2268 Set the document title when it has been retrieved from the server.
2269 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2270 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2271 and implement setDocumentTitle(String) method.
2272 * src/main/webapp/style.css: Add ID for document title style.
2274 2011-08-25 Ben Konrath <ben@bagu.org>
2276 Add NavigationType enum to LayoutItemPortal DTO.
2278 This is the start of adding support for Portals to the Details View.
2280 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2281 LayoutItem_Portal.navigation_type enum from libglom to
2282 LayoutItemPortal.NavigationType enum.
2283 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2284 NavigationType enum, field for storing the NavigationType and getter
2287 2011-08-25 Ben Konrath <ben@bagu.org>
2289 Implement the flow table layout in the Details View.
2291 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2292 FlowTable to Group to account for the renamed class.
2293 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2294 File. This is a container widget that implements the Glom details view
2295 flow table behaviour.
2296 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2297 org/glom/web/client/ui/FlowTable.java.
2298 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2299 so that the size of the subgroups are a closer match to the size of
2300 the Glom subgroups. This makes the flowtable layout match the layout
2301 in Glom for the Music Collection example file.
2303 2011-08-16 Ben Konrath <ben@bagu.org>
2305 Create container element for LayoutItemPortal in Details View.
2307 This will help me develop the layout for the FlowTable.
2309 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2310 fieldPanel variable to detailsCell.
2312 2011-08-15 Ben Konrath <ben@bagu.org>
2314 Set the height of the data element in the Details View.
2316 I changed the InlineLabels (text in a span element) to Labels (text in
2317 a div element) so that I could set the height of the details-data
2318 elements instead of the details-cell parent elements. This allows the
2319 the details-data element to display the correct height if style is
2320 applied that shows the height.
2322 This change has the added benefit of allowing the order of the labels
2323 and data elements to be changed for right-to-left languages.
2325 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2326 InlineLabels to Labels.
2327 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2328 InlineLabels to Labels. Set the height of the data element.
2329 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2330 multiline text height in the Formatting DTO.
2331 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2332 for multiline height along with getter and setter methods.
2333 * src/main/webapp/style.css: Adjust style to account for the change
2334 from span elements to div elements in the details cell.
2336 2011-08-15 Ben Konrath <ben@bagu.org>
2338 Make the List View appearance match the mockups.
2340 It doesn't match exactly but it's much better than it was.
2342 * mockups/listview-contacts.html: Remove unused css classes.
2343 * mockups/listview-projects.html: Remove unused css classes.
2344 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2345 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2346 for mainPanel instead of VerticalPanel (table). Set style name on
2347 CellTable. Set style name on Details column. Right-align Details
2349 * src/main/webapp/style.css: Adjust properties to match the mockups.
2351 2011-08-12 Ben Konrath <ben@bagu.org>
2353 Add better support for subgroups in the details view.
2355 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2356 changed FlowTable constructor.
2357 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2358 support for subgroups and subgroup-titles.
2359 * src/main/webapp/style.css: Add CSS class for subgroups and
2362 2011-08-12 Ben Konrath <ben@bagu.org>
2364 Return the top level LayoutGroup title.
2366 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2368 2011-08-11 Ben Konrath <ben@bagu.org>
2370 Make the TableSelector header match the mockup.
2372 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2373 the layout panel. Properly lineup the table selection header with
2374 the list and details view.
2375 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2376 margin around the details view.
2377 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2378 Rename listBox variable to tableSelector. Set id for the style sheet.
2379 Use a FlowPanel instead of a HorizontalPanel.
2380 * src/main/webapp/style.css: Add properties to make the TableSelector
2381 box match the mockups.
2383 2011-07-13 Ben Konrath <ben@bagu.org>
2385 Update install script for java-libglom version change.
2387 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2390 2011-07-13 Ben Konrath <ben@bagu.org>
2392 Add support sub-group in the details view.
2394 I also removed the code that special-cased the default details view
2397 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2399 I still have to make a proper flowtable.
2401 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2402 Don't special-case default details view layout.
2403 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2404 addLayoutField() as I'm going to use it.
2405 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2406 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2408 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2409 extracted from DetailsViewImpl.GroupPanel. Add support for
2411 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2412 column count when getting the details layout.
2414 2011-07-12 Ben Konrath <ben@bagu.org>
2416 Set browser title with database and table titles.
2418 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2419 Set the browser title when the table changes and when the activity
2421 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2422 title when retrieving document info (the GlomDocument object).
2423 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2424 with getter and setter methods. Remove unused convenience constructor.
2425 Use default code formatting.
2427 2011-07-12 Ben Konrath <ben@bagu.org>
2429 Ignore LayoutItemPortals in the details view.
2431 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2434 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2435 LayoutItemPortal layout objects.
2436 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2437 LayoutItemPortal objects when retrieving the details layout.
2438 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2439 file. This is an empty class and just used to get type information for
2442 2011-07-12 Ben Konrath <ben@bagu.org>
2444 Use java-libglom 1.17.0.
2448 2011-07-11 Ben Konrath <ben@bagu.org>
2450 Remove "Table:" label from table selector.
2452 This matches a recent change in the Glom UI.
2454 * mockups/details-contacts.html:
2455 * mockups/details-projects.html:
2456 * mockups/listview-contacts.html:
2457 * mockups/listview-projects.html: Remove the "Table:" label from the
2459 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2461 2011-07-11 Ben Konrath <ben@bagu.org>
2463 Add main groups to the details view.
2465 This makes things look a little nicer in the details view. The next step
2466 is to implement the flowtable.
2468 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2469 resources from the standard gwt css theme. Standard.css is now
2470 included in OnlineGlom.html so that the online glom css rules have
2471 precedence over the gwt theme.
2472 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2473 the whole LayoutGroup to the DetailsView instead of just the titles.
2474 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2475 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2476 details layout with a helper class (GroupPanel). I might extract this
2477 class when I make the full flowtable.
2478 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2479 string as default so I don't have to worry about NPEs when processing
2481 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2482 note beside OnlineGlom.gwt.xml above).
2483 * src/main/webapp/style.css: Add default font-size to body to override
2484 the font-size set by the standard theme. Don't use h2 tags for
2485 group-title. Create new details-cell class.
2487 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2489 ConfiguredDocument: Set the port number too.
2491 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2492 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2493 Glom document. Presumably this worked sometimes so far because there is a
2494 default port number.
2496 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2498 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2500 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2501 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2502 correct, though we should throw an exception too.
2504 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2506 Fix a addDocuemnt typo.
2508 * src/main/java/org/glom/web/shared/Documents.java
2509 (Documents.addDocuemnt): Rename to addDocument().
2510 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2511 (OnlineGlomServiceImpl.getDocuments): Adapt.
2513 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2515 Slightly improved log output when connection fails.
2517 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2518 (ConfiguredDocument.setUsernameAndPassword):
2519 We don't know for sure if it' the username/password that's wrong, so
2520 rephrase the message.
2521 Also ouput the exception message, though it's generic in this case.
2523 2011-07-08 Ben Konrath <ben@bagu.org>
2527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2528 added braces to a one line if statement because the Eclipse formatter
2529 was getting confused.
2531 2011-07-07 Ben Konrath <ben@bagu.org>
2533 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2535 These should really be two separate tasks but I counldn't get things to
2536 work with GWT 2.2.0 and Eclipse 3.7.
2540 * .settings/org.eclipse.jdt.core.prefs:
2541 * .settings/org.eclipse.jdt.ui.prefs:
2542 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2543 * .settings/org.eclipse.m2e.core.prefs:
2544 Add new config files. Update current files. Remove references to the
2545 webtools plugins as we're not using any of the webtools features.
2546 * .gitignore: Add logs directory which is created when running with
2548 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2549 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2550 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2552 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2554 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2556 onlineglom.properties: Add explanatory comments.
2558 * src/main/resources/onlineglom.properties: Also change the default user
2559 from ben to someuser, to avoid the risk of people thinking we just
2560 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2562 2011-06-28 Ben Konrath <ben@bagu.org>
2564 Use filename in Log for incorrect passwords.
2566 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2567 getFileName(String) method to get the filename from the URI.
2569 2011-06-28 Ben Konrath <ben@bagu.org>
2571 Add the table name to the URL token for the ListPlace.
2573 This makes things consistent between the DetailsPlace and the
2574 ListPlace. It also allows the the ListPlace to be bookmarked.
2576 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2577 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2578 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2579 Remove getDefaultListLayout(). The default layout is now returned
2580 by the getListLayout() method when the table name is an empty string.
2581 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2582 Add table name field. Change to a new ListPlace when the table
2583 has been changed. Use getListLayout() for getting the default
2585 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2586 Add table name field. Set the correct table name in the list box
2587 when loading from bookmark. This corrects a problem for the
2589 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2590 Move table name to super-class (HasSelectableTable). Move document
2591 and table URL keys to super-class in HasSelectableTable.
2592 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2593 Add table name field. Add Tokenizer class with URL key common to
2594 the subclasses (DetailsPlace and ListPlace).
2595 * src/main/java/org/glom/web/client/place/ListPlace.java:
2596 Add table name. Add code to parse the URL token.
2597 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2598 Update ListPlace construction with empty table name string.
2599 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2600 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2601 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2602 Update ListPlace construction with table name string.
2603 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2604 Change defaultTableName field to tableName to reflect how it's now
2605 used. Update the getter and setter methods.
2607 2011-06-28 Ben Konrath <ben@bagu.org>
2609 Enable the table selector in the DetailsView.
2611 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2612 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2613 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2614 Remove getDefaultDetailsLayout(). The default layout is now returned
2615 by the getDetailsLayout() method when the table name is an empty
2617 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2618 event handler for table change event. Change to using
2619 getDetailsLayout() for the default details layout.
2620 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2622 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2623 when navigating to the details place.
2625 2011-06-27 Ben Konrath <ben@bagu.org>
2627 Use filename based unique document ID in URL and for RPC.
2629 The document ID is the glom document name with spaces (' ') replaced
2630 with pluses ('+') and without the .glom extension.
2632 This change is mostly a string substitution of 'documentTitle' for
2633 'documentID'. The only code change is the addition of a Documents DTO to get the
2634 filename to document title mappings as indicated below.
2636 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2637 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2638 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2639 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2640 Use Documents DTO to create the document links in the document
2642 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2643 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2644 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2645 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2646 * src/main/java/org/glom/web/client/place/ListPlace.java:
2647 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2648 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2649 * src/main/java/org/glom/web/client/ui/ListView.java:
2650 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2651 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2652 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2653 * src/main/java/org/glom/web/server/Log.java:
2654 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2655 getDocumentTitles() to getDocuments() and return the Documents DTO.
2656 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2657 transferring the filename to document title mappings.
2659 2011-06-25 Ben Konrath <ben@bagu.org>
2661 Make the authentication popup work again.
2663 This bug was introduced when I extracted ConfiguredDocument to its own class.
2665 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2666 correct success / fail status in setUsernameAndPassword().
2668 2011-06-25 Ben Konrath <ben@bagu.org>
2670 Use filename as unique key for configuring database usernames and passwords.
2672 This replaces the use of the Glom document title which could change
2673 depending on the locale. Thanks to Murray Cumming for pointing out this
2676 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2677 * src/main/resources/onlineglom.properties:
2679 2011-06-24 Ben Konrath <ben@bagu.org>
2681 Pass primary key value to DetailsView.
2683 This enables the DetailsView to load the correct data.
2685 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2686 primary key value field and set in constructor. Pass primary key
2687 value to getDetailsData().
2688 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2689 variables for document title and primary key value.
2690 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2691 key value to the DetailsPlace.
2693 2011-06-24 Ben Konrath <ben@bagu.org>
2695 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2697 This allows the primary key to be retrieved by the Details button. This
2698 functionality has not been implemented yet but it's in the works.
2700 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2701 the LayoutGroup result to ListView.setCellTable instead of all of its
2702 fields individually.
2703 * src/main/java/org/glom/web/client/ui/ListView.java:
2704 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2705 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2706 get the primary key for the table.
2707 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2708 index of the primary key in the LayoutGroup accounting for hidden
2709 primary keys. Rename getJavaNumberFormat() to
2710 convertToJavaNumberFormat() for consistency. Cleanup / add some
2712 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2713 field for primary key index and a field to indicate whether the
2714 primary key is hidden or not.
2716 2011-06-23 Ben Konrath <ben@bagu.org>
2718 Rename getTableData methods to getListData.
2720 This is a rename refactor for consistency with other methods.
2722 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2723 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2724 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2725 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2727 2011-06-23 Ben Konrath <ben@bagu.org>
2729 Extract the ConfiguredDocument innerclass into its own class.
2731 This makes the servlet code more object oriented.
2733 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2734 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2735 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2736 new ConfiguredDocument class.
2738 2011-06-21 Ben Konrath <ben@bagu.org>
2740 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2742 This makes things more inline with how libglom works and reduces code
2743 duplication. This refactor lays the groundwork for adding the primary key to
2744 the LayoutGroup object.
2746 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2747 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2748 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2749 Change method names to getListLayout and getDefaultListLayout for
2750 consistency. Use LayoutGroup as the DTO for the list layout instead of
2751 ColumnInfo and LayoutListTable.
2752 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2753 new method names along with the LayoutGroup object for transferring the
2755 * src/main/java/org/glom/web/client/ui/ListView.java:
2756 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2757 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2758 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2760 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2761 Replaced with LayoutGroup.
2762 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2763 expectedResultSize and defaultTableName fields which are needed for
2765 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2766 type field which is needed for the list layout but will also be
2767 useful for the details layout as things progress.
2768 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2769 Make class abstract. Remove the unnecessary
2770 getFormattingHorizontalAlignment method. Add setFormatting method.
2772 2011-06-16 Ben Konrath <ben@bagu.org>
2774 Add scripts for building and installing war.
2776 These will help when updating OnlineGlom but they're also good
2777 supplemental documentation of the build and deployment proceeding.
2779 * utils/build-onlineglom-war.sh: New file.
2780 * utils/install-onlineglom-war.sh: New file.
2782 2011-06-16 Ben Konrath <ben@bagu.org>
2784 Create wrapper class to create consistent log messages.
2786 I wrapped methods in the Log class of gwt-log to add the method names
2787 from the servlet and create consistent formatting of the document title
2788 and table names in the log messages.
2790 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2791 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2792 log methods to use methods from wrapped Log class.
2794 2011-06-16 Ben Konrath <ben@bagu.org>
2796 Remove superfluous conditional return.
2798 Thanks to Murray Cumming for pointing this out!
2800 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2802 2011-06-15 Ben Konrath <ben@bagu.org>
2804 Return an ArrayList of LayoutGroups for the Details layout.
2806 This corrects a problem with the details layout as it can have more
2807 than one top level LayoutGroup.
2809 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2810 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2811 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2812 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2813 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2814 with ArrayList of LayoutGroups for the details view layout.
2815 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2816 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2817 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2818 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2819 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2820 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2822 2011-06-14 Ben Konrath <ben@bagu.org>
2824 Use cast_dynamic method to determine the libglom LayoutItem type.
2826 This is better than finding the LayoutItem type by using the string
2827 returned from the get_part_type_name() method.
2829 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2831 2011-06-14 Ben Konrath <ben@bagu.org>
2833 Add method names to log entries in the servlet.
2835 This helps when tracking down deployment problems.
2837 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2839 2011-06-14 Ben Konrath <ben@bagu.org>
2841 Add data to the DetailsView using a hard-coded primary key value.
2843 The layout and functionality of the DetailsView is not complete. This
2844 is just a checkpoint so the patch doesn't get too big.
2846 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2847 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2848 Add getDetailsData() servlet method.
2849 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2850 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2851 LayoutFields are added to the DetailsView.
2852 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2853 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2854 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2855 take the string for the title instead of the object.
2856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2857 Add implementation getDetailsData() along with some private helper
2859 * src/main/webapp/style.css: Add padding to details-data class. Add a
2860 details-label class with the same padding as the details-data class.
2862 2011-06-03 Ben Konrath <ben@bagu.org>
2864 Use presenter.goTo() to change to the DetailsPlace.
2866 This will make things easier when we need to open the DetailsView with
2867 data specific to the row that was clicked.
2869 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2871 2011-06-02 Ben Konrath <ben@bagu.org>
2873 Add CSS file from mockups.
2875 I'm adding this now because it's going to be useful to have when
2876 developing the DetailsView. The TableSelectionView and ListView aren't
2879 * src/main/webapp/OnlineGlom.html:
2880 * src/main/webapp/style.css:
2882 2011-06-02 Ben Konrath <ben@bagu.org>
2884 Use String.isEmpty() to check for empty string.
2886 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2888 2011-06-02 Ben Konrath <ben@bagu.org>
2890 Display main layout group titles in the DetailsView.
2892 This is the start of the DetailsActivity/DetailsView implementation.
2894 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2895 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2896 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2897 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2898 Get the layout information for the details view from the server and set
2899 the main layout group titles.
2900 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2901 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2902 Add addLayoutGroup() and addLayoutField() methods. This are just
2903 temporary methods for creating the the details view that will change
2905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2906 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2908 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2909 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2910 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2911 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2912 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2913 Data Transfer Objects that mimic the libglom object structure. These are
2914 used for transferring the details layout but could also be used for
2915 transferring the list layout.
2917 2011-05-27 Ben Konrath <ben@bagu.org>
2919 Reset the AuthenticationPopup when clearing the ListView.
2921 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2923 2011-05-27 Ben Konrath <ben@bagu.org>
2925 Fix problem with onlineglom.properties file loading.
2927 The old way worked in Eclipse but not on the server. Loading the
2928 onlineglom.properties file now works in Eclipse and on the server.
2930 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2932 2011-05-24 Ben Konrath <ben@bagu.org>
2934 Update gwt-log from 3.1.0 to 3.1.2.
2936 Gwt-log 3.1.0 has been marked as depreciated.
2940 2011-05-24 Ben Konrath <ben@bagu.org>
2942 Add comment to ListActivity.goTo() method.
2944 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2946 2011-05-24 Ben Konrath <ben@bagu.org>
2948 Remove FIXME in convertGdkColorToHtmlColour()
2950 The Gdk::Color value returned by libglom is 16-bits per channel on both
2951 64 and 32-bit platforms.
2953 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2955 2011-05-19 Ben Konrath <ben@bagu.org>
2957 Improve performance of initial ListView load.
2959 I removed a round trip to the server for getting the default table name
2960 and then requesting information about that table. This also removes a potential
2961 problem with the table change handler not being setup in time to receive the
2962 table change event from the ListActivity.
2964 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2965 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2966 getDefaultLayoutListTable() method. Improve comments.
2967 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2968 getDefaultLayoutListTable() method instead of firing a table change
2969 event to get the table to load.
2970 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2971 implementation of getDefaultLayoutListTable() method.
2972 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2975 2011-05-19 Ben Konrath <ben@bagu.org>
2977 Override toDebugString() in TableChangeEvent.
2979 This is useful to have for debugging.
2981 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2983 2011-05-19 Ben Konrath <ben@bagu.org>
2985 Add a "Back to List" link when at the DetailsPlace.
2987 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2988 Populate the CellTable based on the selected table of the ListBox if
2989 it's set otherwise use the default table. This allows the "Back to
2991 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2992 Remove Place from constructors. Add a setPlace() method. Add
2993 goToPlace() method. Set class as presenter for TableSelectionView.
2994 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2995 Use the same TableSelectionActivity when switching between the List and
2997 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2998 Subclass the new HasSelectableTablePlace. This removes some duplicate
3000 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3001 New class to represent Places that display the TableSelectionView.
3002 * src/main/java/org/glom/web/client/place/ListPlace.java:
3003 Subclass the new HasSelectableTablePlace. This removes some duplicate
3005 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3006 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3007 Add Presenter interface. Add setBackLinkVisible() method. Add
3008 setBackLink() method.
3010 2011-05-18 Ben Konrath <ben@bagu.org>
3012 Enable the "Details" buttons.
3014 Right now only an empty details view is displayed.
3016 * src/main/java/org/glom/web/client/ClientFactory.java:
3017 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3018 Add DetailsView to ClientFactory.
3019 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3020 A basic activity for the details view.
3021 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3022 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3024 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3025 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3027 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3028 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3029 unnecessary super() in constructor.
3030 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3031 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3032 really shouldn't create a new TableSelectionActivity for both the ListPlace
3033 and the DetailsPlace so this should be considered a temporary solution.
3034 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3035 New file. Represents a URL for the details view.
3036 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3037 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3038 A basic details view interface and implementation.
3039 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3040 Enable the "Details" buttons.
3042 2011-05-12 Ben Konrath <ben@bagu.org>
3044 Use a LayoutPanel with multiple display areas for main layout.
3046 This is mostly a refactor in that there are no changes from the user
3047 point of view. These changes are required so that we can swap out the list view
3048 with the details view when the user clicks the "Details" button.
3050 * src/main/java/org/glom/web/client/ClientFactory.java:
3051 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3052 OnlineGlomView. Add TableSelectionView, ListView and
3053 AuthenticationPopup.
3054 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3055 for main layout. Add display regions for main activities. Add
3056 activity manager for for main activities.
3057 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3058 file from parts of the deleted OnlineGlomActivity.
3059 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3060 New file from parts of the deleted OnlineGlomActivity.
3061 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3062 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3063 New files for app wide table change event.
3064 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3065 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3066 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3067 Activity mappers for the main activities replace the deleted app-wide
3069 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3070 Fix a spelling error in he comment.
3071 * src/main/java/org/glom/web/client/ui/ListView.java:
3072 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3073 Renamed from LayoutListView and modified for MVP. This still not a
3074 proper dumb view as prescribed by the MVP pattern but it works for now.
3075 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3076 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3077 New widget stripped out of the deleted OnlineGlomView.
3078 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3079 Remove hack that is fixed by this patch.
3081 2011-05-06 Ben Konrath <ben@bagu.org>
3083 Rename OnlineGlomPlace to ListPlace.
3085 The only change besides the rename is that url will now display #list
3086 instead of #Document.
3088 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3089 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3090 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3091 * src/main/java/org/glom/web/client/place/ListPlace.java:
3092 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3094 2011-05-06 Ben Konrath <ben@bagu.org>
3096 Use Presenter for app navigation.
3098 This is the proper way to deal with Place (URL) changes with the MVP
3101 * src/main/java/org/glom/web/client/ClientFactory.java:
3102 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3103 PlaceHistoryMapper and PlaceHistoryHandler.
3104 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3105 PlaceHistoryMapper and PlaceHistoryHandler.
3106 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3107 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3108 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3109 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3110 Add Presenter interface and setPresenter methods. Rename addHyperLink
3111 to addDocumentLink taking only the document title as a parameter.
3113 2011-04-14 Ben Konrath <ben@bagu.org>
3115 Prompt for db username/password if they haven't been set.
3117 This is implemented with a popup widget that is contained within the
3118 OnlineGlomView and managed by the OnlineGlomActivity.
3120 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3121 methods for checking and setting the database username and password.
3122 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3123 new methods for checking and setting the database username and
3125 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3126 Display authentication popup if the JDBC connection to the database
3127 has not been authenticated.
3128 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3130 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3131 for dealing with the authentication popup.
3132 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3133 Implement the methods for dealing with the authentication popup.
3134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3135 try to executed queries if the database connection hasn't been
3136 authenticated. Implement methods for checking and setting the
3137 database username and password.
3139 2011-04-12 Ben Konrath <ben@bagu.org>
3141 Make log messages a little clearer.
3143 Add a dash betweeen the document title and the table name.
3145 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3147 2011-04-12 Ben Konrath <ben@bagu.org>
3149 Protect against NPEs when cleaning up database resources.
3151 While this isn't strictly necessary because the exception is caught,
3152 not protecting against the NPEs makes it harder to find the real error
3155 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3157 2011-04-12 Ben Konrath <ben@bagu.org>
3159 Move configuration of the servlet to the constructor.
3161 The servlet will be initialized even if the database authentication
3162 information is not set or correct. I still need to add the UI for prompting
3163 the user for the authentication information when it's required.
3165 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3166 javadocs for getDocumentTitles() method.
3167 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3168 Set error message when RPC fails.
3169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3170 glom files directory from the configuration file. Try to set the
3171 database authentication information for the specific document if it's
3172 set and works otherwise try to use the global authentication
3173 information set for the directory.
3174 * src/main/resources/onlineglom.properties: Moved from
3175 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3176 Added detailed comments for the new keys.
3178 2011-04-11 Ben Konrath <ben@bagu.org>
3180 Remove unnecessary @Override in DocumentSelectionViewImpl.
3182 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3184 2011-04-11 Ben Konrath <ben@bagu.org>
3186 Remove center alignment in DocumentSelectionView.
3188 The title element is still centred but the document titles and bottom
3189 sentence are both left-aligned.
3191 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3193 2011-04-11 Ben Konrath <ben@bagu.org>
3195 Change 'Demo' naming convention to 'Document'.
3197 This is just a rename refactor with no functional changes to the code.
3199 * src/main/java/org/glom/web/client/ClientFactory.java:
3200 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3201 * src/main/java/org/glom/web/client/OnlineGlom.java:
3202 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3203 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3204 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3205 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3206 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3207 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3208 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3209 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3210 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3213 2011-04-08 Ben Konrath <ben@bagu.org>
3215 Remove FIXME from safeLongToInt() method.
3217 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3222 2011-04-08 Ben Konrath <ben@bagu.org>
3224 Display an error if no glom documents are found in the specified directory.
3226 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3227 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3228 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3229 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3231 2011-04-08 Ben Konrath <ben@bagu.org>
projects / online-glom:gwt-glom.git / blob