1 2012-01-26 Murray Cumming <murrayc@murrayc.com>
3 Prevent a crash when no locale is specified in the URL.
5 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
6 Avoid returning a null string, obtained from
7 Window.Location.getParameter(). This caused a crash when it was
8 later passed to libglom's API.
9 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
10 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
11 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
12 guard against future null strings.
14 2012-01-26 Murray Cumming <murrayc@murrayc.com>
16 Use the ?locale= query param instead of the &lang= token param.
18 * src/main/java/org/glom/web/client/place/ListPlace.java
19 * src/main/java/org/glom/web/client/place/DetailsPlace.java
20 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
21 Remove the lang token key and value.
23 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
24 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
25 When the user selects a different locale from the chooser, use
26 Window.Location.assign() to change the URL, which then causes a reload.
28 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
29 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
30 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
31 * src/main/java/org/glom/web/client/activity/ListActivity.java
32 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
33 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
34 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
35 * src/main/java/org/glom/web/client/ui/ListView.java:
36 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
38 Remove localeID member variables and method/constructor parameters, instead
39 using Utils.getCurrentLocaleID() when we need a localID to pass to
42 2012-01-26 Murray Cumming <murrayc@murrayc.com>
44 Internationalize the UI strings.
46 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
47 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
48 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
49 because it is unused. Messages are apparently strings that can have
50 parameters, but we do not need that yet, so Contants will be enough for now.
51 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
52 to say that we support the en and de locales.
53 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
54 The original English strings.
55 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
56 Some German translations of the English strings.
57 The i18n goal then uses the .properties file to generate an
58 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
59 returns an implementation that returns the translated strings.
60 The documentation suggests putting these in src/java/*/client/, but it seems
61 best to put it in src/resources/*/client/.
62 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
63 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
64 instead of hard-coding them.
65 Note that we cannot import OnlineGlomConstants because it does not exist yet,
66 but that does not seem to stop the build, though it confuses Eclipse.
68 You can see the translated string by adding ?locale=de to the URL, like so:
69 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
71 2012-01-24 Murray Cumming <murrayc@murrayc.com>
73 Improve null/empty String checks.
75 * pom.xml: Add a dependency on commons-lang, to use
76 org.apache.commons.lang.StringUtils.
77 * src/main/java/org/glom/web/server/ConfiguredDocument.java
78 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
79 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
80 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
81 Use StringUtils.isEmpty().
83 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
84 StringUtils class with a static isEmpty() function because we
85 cannot use org.apache.commons.lang.StringUtils in client-side
86 GWT code because it (apparently) cannot be compiled to javascript.
87 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
88 * src/main/java/org/glom/web/client/activity/ListActivity.java
89 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
90 * src/main/java/org/glom/web/client/place/DetailsPlace.java
91 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
92 * src/main/java/org/glom/web/client/place/ListPlace.java
93 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
94 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
95 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
96 * src/main/java/org/glom/web/client/ui/details/Group.java
97 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
98 our StringUtils.isEmpty() function.
100 2012-01-24 Murray Cumming <murrayc@murrayc.com>
102 Update to the latest java-libglom API.
104 * pom.xml: Require java-libglom 1.21.4.
105 * src/main/java/org/glom/web/server/ConfiguredDocument.java
106 getDocumentInfo(), getListViewLayoutGroup():
107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
109 * src/main/java/org/glom/web/server/database/DBAccess.java
110 getFieldsToShowForSQLQueryAddGroup(),
111 getPrimaryKeyLayoutItemField(): Replace get_database_title()
112 with either get_database_title_original() or
113 get_database_title(localeID).
115 2012-01-24 Murray Cumming <murrayc@murrayc.com>
117 ConfiguredDocument: Avoid a null pointer exception.
119 * src/main/java/org/glom/web/server/ConfiguredDocument.java
120 Initialize localeID to "" to avoid returning a null String which
121 causes a crash in java-libglom's swing-generated code.
123 2012-01-23 Murray Cumming <murrayc@murrayc.com>
125 Some simple renaming.
127 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
128 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
129 for localeChooser. This seems more appropriate and is less ambiguous
130 particularly in the .css file.
132 2012-01-23 Murray Cumming <murrayc@murrayc.com>
134 ConfiguredDocument: Rename the localedID private member variable.
136 2012-01-23 Murray Cumming <murrayc@murrayc.com>
138 Adapt to the latest java-libglom API from git master.
140 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
141 libglom now uses only Vector instead of List, which uses add() instead of
144 2012-01-23 Murray Cumming <murrayc@murrayc.com>
146 Add and fill a Reports drop-down list box.
148 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
150 * src/main/java/org/glom/web/client/OnlineGlomService.java:
151 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
153 Added getReports(document, table, localeID), calling
154 ConfiguredDocument.getReports().
155 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
156 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
157 Added setReportsList() and a list widget.
158 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
159 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
161 2012-01-22 Murray Cumming <murrayc@murrayc.com>
163 ConfiguredDocument: Rename the localedID private member variable.
165 2012-01-20 Murray Cumming <murrayc@murrayc.com>
167 Build a source tarball with mvn assembly:single
169 * assembly.xml: Add this file.
170 * pom.xml: Use the maven-assembly-plugin and tell it to use
171 our assembly.xml file.
173 2012-01-19 Murray Cumming <murrayc@murrayc.com>
175 OnlineGlomServiceImpl: Get .glom files recursively.
177 * pom.xml: Depend on commons-io from org.apache.commons.
178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
179 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
180 files recursively, and with the easier filter for the extension.
181 Use org.apache.commons.io.FilenameUtils.removeExtension() to
182 simplify that code too.
184 2012-01-19 Murray Cumming <murrayc@murrayc.com>
186 README: Mention that you must install java-libglom packages separately.
188 But then it works, because java-libglom is now in the central maven
191 2012-01-18 Murray Cumming <murrayc@murrayc.com>
193 locales drop-down: Show the correct selected locale when the URL changes.
195 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
196 .java: setPlace(): Move some code into fillView().
198 2012-01-18 Murray Cumming <murrayc@murrayc.com>
200 locales drop-down: Do not lose the primary key.
202 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
203 start(): onLocaleChange(): Pass the current primary key value,
204 instead of an empty value.
206 2012-01-18 Murray Cumming <murrayc@murrayc.com>
208 locales drop-down: Do not lose the drop-down selection.
210 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
211 .java (TableSelectionActivity.fillView): Set the selected locale
212 after changing the drop-down items (though we do not really need
213 to change them just because the locale changes.)
215 2012-01-18 Murray Cumming <murrayc@murrayc.com>
217 locales drop-down: Change the tables list when this changes.
219 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
220 .java: TableSelectionActivity.start(): Move the async table titles
221 retrieval into a private fillView() method and also call this when
222 the chosen locale changes.
223 Note that the document title is not actually translatable yet, but
224 that is a problem that I should fix soon in libglom.
226 2012-01-18 Murray Cumming <murrayc@murrayc.com>
228 Improve the placement of the locales drop-down.
230 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
231 Put the title and locales drop-down in a div (gwt.FlowTable).
232 * src/main/webapp/style.css: Add magic css properties to make this work.
233 Also remove the left margin from the title so that it lines up with the
236 2012-01-18 Murray Cumming <murrayc@murrayc.com>
238 locales selector: Show human-readable locale titles.
240 * src/main/java/org/glom/web/server/ConfiguredDocument.java
241 getDocumentInfo(): Use java.util.Locale to show a real title of
242 each locale, in the locale's own language.
244 2012-01-17 Murray Cumming <murrayc@murrayc.com>
246 Add a language/locale selector drop-down.
248 * src/main/java/org/glom/web/shared/DocumentInfo.java:
249 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
250 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
251 getDocumentInfo(): Store the available Locales in the DocumentInfo.
252 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
253 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
254 Add a ListBox to show the available locales. Add getLocaleSelector(),
255 setLocaleList(), getSelectedLocale(), setSelectedLocale().
256 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
257 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
258 java: Add these classes.
259 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
260 start(): Fill the locales ListBox. Handle its change event, firing a
262 setPlace(): Show the selected locale as specified by the URL token.
263 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
264 * src/main/java/org/glom/web/client/activity/ListActivity.java:
265 Handle LocaleChangeEvent, going to a new *Place with that locale.
267 The placement of the ListBox is not pretty, and it currently uses the ID
268 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
272 2012-01-17 Murray Cumming <murrayc@murrayc.com>
274 Search box: Show the search text from the URL token.
276 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
277 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
278 Add setQuickFindText().
279 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
280 .java: setPlace(): Store the queryText if the place is a ListPlace,
281 and call TableSelectionView.setQuickFindText().
283 2012-01-17 Murray Cumming <murrayc@murrayc.com>
285 Allow use of translations via, for instance, &lang=de in the URL.
287 * pom.xml: Use the unstable java-libglom 1.21 version.
289 * src/main/java/org/glom/web/client/OnlineGlomService.java:
290 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
291 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
292 init(): Instead of calling TranslatableItem.set_current_locale()
293 (now removed), call ConfiguredDocument.setDefaultLocaleID().
294 However, this is only for default locales, which are not needed to
295 change the locale in the URL.
296 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
297 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
298 getSortedRelatedListData(): Add a localeID parameter, so we can get the
299 layout for a particular locale.
300 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
301 Add get/setDefaultLocaleID().
302 getDocumentInfo(), getListViewData(), getRelatedListData(),
303 getDetailsLayoutGroup(), getListViewLayoutGroup(),
304 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
305 localeID parameter, so we can get the layout for a particular locale.
307 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
308 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
309 * src/main/java/org/glom/web/client/place/ListPlace.java:
310 Parse and construct a lang parameter too.
312 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
313 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
314 passed to subsequent methods and constructors.
315 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
316 * src/main/java/org/glom/web/client/activity/ListActivity.java:
317 Store the localeID from the *Place and pass it to other constructors
318 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
320 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
321 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
322 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
323 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
324 * src/main/java/org/glom/web/client/ui/ListView.java:
325 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
326 Take localeID parameters and pass them to subsequent constructors and
327 methods, so that the layout is always retrieved for that locale.
329 This is rather repetitive.
331 Note that "" means the original (default) locale of the Glom document,
332 which is usually English.
334 2012-01-17 Murray Cumming <murrayc@murrayc.com>
336 Documents: Remove final keyword to fix startup configuration.
338 * src/main/java/org/glom/web/shared/Documents.java: Remove the
339 final keywords on the private member variables because that breaks
340 the startup, apparently (there are warnings) because it stops them
341 from being serialized. I added these in the previous commit.
343 2012-01-13 Murray Cumming <murrayc@murrayc.com>
345 Documents: Add some final keywords.
347 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
350 2012-01-13 Murray Cumming <murrayc@murrayc.com>
352 OnlineGlomServiceImpl: Add to overview comments.
354 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
355 Note that this is where all the document are loaded. They are not
356 loaded freshly for each page.
358 2012-01-12 Murray Cumming <murrayc@murrayc.com>
362 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
363 Add a TextBox for the text of a quick find.
364 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
366 setBackLink(): Add a String quickFind parameter.
367 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
368 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
369 to the base interface, because that is how TableSelectionViewImpl is used.
370 * src/main/webapp/style.css: Add style for the search box and its label.
372 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
373 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
374 Add these files, based on the existing TableChangeEvent and
375 TableChangeEventHandlers.
376 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
377 start(): Handle QuickFindChangeEvent, passing its quickFind text to
378 a ListPlace() that the user should be taken to.
379 * src/main/java/org/glom/web/client/activity/ListActivity.java
380 start(): Handle it here too and adapt the TableChangeEvent handler to
381 pass the extra "" quickFind parameter to ListPlace.
382 * src/main/java/org/glom/web/client/place/ListPlace.java:
383 Constructor: Take an extra String quickFind parameter and store it,
384 returning it from a new getQuickFind() method.
385 getToken(): Put the quickFind text in the URL token.
386 getPlace(): Parse the quickFind text from the URL token.
387 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
388 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
389 ListPlace constructor.
390 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
391 .java: start(): Add a Change handler for the TableSelectionView's
392 TextBox (via its base HasChangeHandlers interface), firing the new
393 QuickFindChangeEvent.
394 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
395 pass the extra "" quickFind parameter.
397 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
398 setCellTable(): Add a String quickFind parameter and pass it to
399 the ListViewTable() constructor.
400 * src/main/java/org/glom/web/client/ui/ListView.java: Change
401 setCellTable() in the base interface, because that is how ListViewImpl
404 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
405 Add a String quickFind member variable.
406 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
407 Constructor: Add a String quickFind parameter, storing it in the
408 base ListTable's member variable.
409 onRangeChanged(): Pass quickFind to the
410 OnlineGlomServiceAsync.getSortedListViewData() and
411 OnlineGlomServiceAsync.getListViewData() methods.
413 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
414 getListViewData(), getSortedListViewData(): Add a String quickFind
415 parameter, passing it to ConfiguredDocument.getListViewData().
416 * src/main/java/org/glom/web/client/OnlineGlomService.java:
417 Change getListViewData(), getSortedListViewData() in the base interface,
418 because that is how OnlineGlomServiceImpl is used, via this:
419 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
420 Change getListViewData(), getSortedListViewData() here too.
421 This class can apparently be used to asynchronously call methods on
422 OnlineGlomService, and GWT seems to implement that after recognizing
423 just the *Async name convention and the extra AsyncCallback parameters.
425 * src/main/java/org/glom/web/server/ConfiguredDocument.java
426 getListViewData(): Add a String quickFind parameter, and pass it to
427 ListViewDBAccess.getData().
428 * src/main/java/org/glom/web/server/database/ListDBAccess.java
429 getListData(): Add a String quickFind parameter and pass it to
431 getSelectQuery(): Add a String quickFind parameter.
432 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
433 getSelectQuery(): Add a String quickFind parameter and use it with
434 Glom.get_find_where_clause_quick() to pass a where_clause to
435 Glom.build_sql_select_with_where_clause(), to actually filter the
437 getData(): Add a String quickFind parameter, passing it to getListData().
438 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
439 va: getData(): Pass an empty string to getListData() for the
442 2012-01-12 Murray Cumming <murrayc@murrayc.com>
444 ListTable: Minor change.
446 * src/main/java/org/glom/web/client/ui/list/ListTable.java
447 createCellTable(): Make this protected instead of public.
449 2012-01-12 Murray Cumming <murrayc@murrayc.com>
451 Many files: Use final for the parameters and use the @override attribute.
453 2012-01-22 Ben Konrath <ben@bagu.org>
455 Add anchor links for single line text that starts with http, ftp and www.
459 2012-01-22 Ben Konrath <ben@bagu.org>
461 Add ellipsis to single line text in details view.
465 2012-01-04 Murray Cumming <murrayc@murrayc.com>
467 Remove all javadoc author tags.
469 Because they are awkward and meaningless when many people touch
471 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
473 2012-01-04 Murray Cumming <murrayc@murrayc.com>
475 Revert the COPYING.LESSER to COPYING rename.
477 Apparently both should be there if it is LGPL.
479 2012-01-03 Murray Cumming <murrayc@murrayc.com>
481 *View: Remove unused imports.
483 * src/main/java/org/glom/web/client/ui/DetailsView.java:
484 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
485 * src/main/java/org/glom/web/client/ui/ListView.java:
486 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
487 Remove unused imports, as suggested by Eclipse.
489 2012-01-02 Murray Cumming <murrayc@murrayc.com>
491 Move the *View::Presenter types, and some API into one base View.
493 * src/main/java/org/glom/web/client/ui/DetailsView.java:
494 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
495 * src/main/java/org/glom/web/client/ui/ListView.java:
496 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
497 Presenter, setPresenter() and clear() into a shared base interface,
498 to avoid the unnecessary duplicate Presenter types and to more clearly
499 show how the *Views share the same structure, even if they are not
500 used polymorphically.
502 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
503 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
505 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
506 * src/main/java/org/glom/web/client/activity/ListActivity.java:
507 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
509 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
512 Feel free to revert this if there is a good reason for the duplicate
515 2012-01-02 Murray Cumming <murrayc@murrayc.com>
517 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
519 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
520 a class member instead of a local variable in the method.
521 This lets us use it to get the view instances, for use in tests.
522 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
523 beforeOnlineGlom(): Test some more details of the initial view.
524 Again, this is not very useful.
526 To really test gwt-glom we will need to start a local postgresql
527 instance with local data, like the Glom tests in C++.
529 2012-01-02 Murray Cumming <murrayc@murrayc.com>
531 pom.xml: Mention the LGPL license.
533 * pom.xml: Add a licenses section.
534 * COPYING.LESSER: Move this to COPYING, which
535 previously contained the GPL. But gwt-glom is all LGPL.
537 2012-01-02 Murray Cumming <murrayc@murrayc.com>
539 Add project information to README and pom.xml.
541 * README: Add a brief description and mention some mvn
543 * pom.xml: This extra information shows up in mvn site
546 2011-01-02 Murray Cumming <murrayc@murrayc.com>
548 Use the latest java-libglom version.
550 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
552 2012-01-01 Murray Cumming <murrayc@murrayc.com>
554 GwtTestOnlineGlom: Test a little more.
556 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
557 protected rather than private, as suggested by the gwt-test-utils
559 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
560 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
561 Test the initial visibility of the panels.
563 However, this is not a very useful test.
564 And I wonder how we should generally test using this idea for an
565 activity/places app like ours where the real changes happen implicitly
566 based on the history token/URL.
568 2012-01-01 Murray Cumming <murrayc@murrayc.com>
570 Slight modification to *Mapper comments.
572 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
574 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
576 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
578 Remove comments mentioning GIN because they are just copied from
579 the example code and are apparently not helpful:
580 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
581 Also change the mention of a class that is only in the example code.
583 2012-01-01 Murray Cumming <murrayc@murrayc.com>
585 GwtTestOnlineGlom test: Minor changes.
587 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
588 Avoid the long qualified class name and modify the comment
589 because it is now obvious to me that the mocked class is the only
590 custom one created via GWT.create().
592 2012-01-01 Murray Cumming <murrayc@murrayc.com>
594 Tests: Added the beginnings of a test using gwt-test-utils.
596 * pom.xml: Add dependencies on gwt-test-utils and easymock.
597 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
598 which tells gwt-test-utils what class will be tested.
599 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
600 Add a simple (but empty) test case. One class, used by the OnlineGlom
601 class, is mocked so that it can be created. However, I am not sure
602 why only this class needs to be mocked.
604 Note that mockito seems more popular, and clearer, than easymock,
605 but I have not got that working yet. It might be a matter of the
608 This test is run during mvn integration-test.
610 2011-12-31 Murray Cumming <murrayc@murrayc.com>
612 Tests: Use junit4-style syntax instead of junit3-style.
614 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
615 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
616 * src/test/java/org/glom/web/shared/DataItemTest.java:
617 Use the @Test annotation rather than relying on the test*() prefix.
618 Also no longer implement TestCase, to avoid triggering support for
619 the junit3-way, which stops the annotations from working.
620 Change the imports from import junit.framework.* to
621 import org.junit.*, which is apparently the new way.
623 2011-12-31 Murray Cumming <murrayc@murrayc.com>
625 Added a test for ListPlace token parsing and creation.
627 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
628 This is much the same as DetailsPlaceTest.
630 I wonder how we could test the other parts of the *Place API.
632 2011-12-30 Murray Cumming <murrayc@murrayc.com>
634 DetailsPlace test: Also test getToken() and recreation via getPlace().
636 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
637 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
638 recreate it, testing the recreated DetailsPlace for the same parameter
641 2011-12-30 Murray Cumming <murrayc@murrayc.com>
643 Use the surefire-report plugin.
645 * pom.xml: This generates a HTML report about the tests in
646 target/site/surefire-report.html
647 when you do mvn surefire-report:report. It seems to be popular/normal.
649 2011-12-30 Murray Cumming <murrayc@murrayc.com>
651 Added a test for DetailsPlace.
653 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
654 Test the getPlace() token parsing.
656 2011-12-30 Murray Cumming <murrayc@murrayc.com>
658 Added a first unit test.
660 * pom.xml: Add a test goal, and a dependency on junit in that scope.
661 * src/test/java/org/glom/web/shared/DataItemTest.java:
662 This is a silly test but it is just to get things started. Note that
663 maven/junit finds the test because it looks in src/test by default.
665 2011-12-22 Ben Konrath <ben@bagu.org>
667 Change charsetName to "UTF-8" when replacing line breaks.
669 JavaScript requires the charsetName to be "UTF-8". CharsetName values
670 that work in Java (such as "UTF8") will not work when compiled to
673 This fixes a problem with multi-line details view fields that have hard
674 line breaks. The "License Text" field on this page demonstrates the
677 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
679 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
681 2011-12-22 Ben Konrath <ben@bagu.org>
683 Fix another bug with related list navigation.
685 I've tested all the navigation buttons in all of the related lists
686 so things should be good now.
688 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
690 2011-12-22 Ben Konrath <ben@bagu.org>
692 Fix a crasher when refreshing the list view with the default table.
694 This crash will also happen when loading the list view with the default
695 table from a link or bookmark.
697 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
698 to the main document selection page when the document id hasn't been
700 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
701 the main document selection page when the document id hasn't been
703 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
704 values for the details place when the document id hasn't been set.
705 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
706 values for the list place when the document id hasn't been set.
708 2011-12-21 Ben Konrath <ben@bagu.org>
710 Protect against NPE when glom.document.locale is not in config.
712 This patch protects against an NPE when glom.document.locale is not in
713 the config file. This NPE will also happen if glom.document.locale is
716 The patch also updates the error message to display the class name when
717 the getMessage() returns null. This was happening when the NPE was
718 thrown and I had "Configuration Error: null". If an NPE is encountered
719 with this patch, "Configuration Error: NullPointerException " will be
722 This commit closes this bug:
724 https://bugzilla.gnome.org/show_bug.cgi?id=666669
726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
728 2011-12-20 Murray Cumming <murrayc@murrayc.com>
730 Rename onlineglom.properties to onlineglom.properties.sample.
732 * src/main/resources/onlineglom.properties: Rename to:
733 * src/main/resources/onlineglom.properties.sample:
734 * src/main/resources/README: And add this file explaining that people
735 should rename it back when deploying.
737 2011-12-20 Murray Cumming <murrayc@murrayc.com>
739 Allow choosing the translation in the .properties file.
741 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
742 init(): Read a glom.document.locale value from the configuration file
743 and call Glom's TransatableItem::set_current_locale() method.
744 * src/main/resources/onlineglom.properties: Add a commented-out
745 example of this new setting.
747 It would be better to add &lang=de_DE to the URL, but the current
748 libglom API does not allow us to do this easily. I am working on that.
750 2011-12-19 Murray Cumming <murrayc@murrayc.com>
752 Avoid a crash in parsing of token parameters.
754 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
755 ava: getTokenParams(): Do not crash if a parameter has a key but no
756 value, and ignore parameters with neither.
758 2011-12-17 Murray Cumming <murrayc@murayc.com>
760 History token building/handling: Improve use of token parameters.
762 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
763 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
764 and buildParamsToken(HashMap), for use by derived classes.
765 Make the separator private because it is no longer be needed.
766 * src/main/java/org/glom/web/client/place/DetailsPlace.java
767 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
768 instead of manual string concatenation.
769 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
770 of hardcoded indices and awkward splitting code.
771 * src/main/java/org/glom/web/client/place/ListPlace.java
772 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
773 instead of manual string concatenation.
774 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
775 of hardcoded indices and awkward splitting code.
776 This should fix bug #666420
778 2011-12-16 Murray Cumming <murrayc@murrayc.com>
780 Fix a Navgiation->Navigation typo in the code.
782 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
783 Rename processNavgiation() to processNavigation().
785 2011-12-16 Murray Cumming <murrayc@murrayc.com>
787 Fix a seperator->separator typo in the code.
789 * src/main/java/org/glom/web/client/place/DetailsPlace.java
790 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
791 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
794 2011-12-15 Ben Konrath <ben@bagu.org>
796 Cleanup some comments.
798 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
800 2011-12-14 Ben Konrath <ben@bagu.org>
802 Replace \n with <br/> for multiline text in the details view.
804 Vertical scrollbars are added when needed as well.
806 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
808 2011-12-14 Ben Konrath <ben@bagu.org>
810 Specify the font for document selection links.
812 * src/main/webapp/style.css:
814 2011-12-14 Ben Konrath <ben@bagu.org>
816 Fix bouncy CellTable while paging.
818 This doesn't currently work with related list tables in unselected
821 * src/main/java/org/glom/web/client/ui/list/ListTable.java
823 2011-12-14 Ben Konrath <ben@bagu.org>
825 Revamp the appearance of the document selection page.
827 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
828 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
829 * src/main/webapp/style.css:
831 2011-12-13 Ben Konrath <ben@bagu.org>
833 Set navigation button column to the smallest size possible.
835 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
837 2011-12-13 Ben Konrath <ben@bagu.org>
839 Change OpenButton nomenclature to NavigationButton.
841 Using NavigtionButton makes things more generic. Classes, methods and
842 variables have been changed.
844 This is a rename-only refactor.
846 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
847 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
848 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
849 Renamed from OpenButtonCell.
850 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
851 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
852 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
854 2011-12-12 Ben Konrath <ben@bagu.org>
856 Remove unnecessary String argument in RelatedListTable and ListViewTable.
858 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
859 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
860 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
861 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
863 2011-12-12 Ben Konrath <ben@bagu.org>
865 Update variable names and comments.
867 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
868 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
870 2011-12-12 Ben Konrath <ben@bagu.org>
872 Properly initialize numNonEmptyRows variable to zero.
874 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
875 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
877 2011-12-05 Ben Konrath <ben@bagu.org>
879 Add latest mockup with HTML tables.
881 Features of this mockup:
883 -> HTML table for flowtable
884 -> HTML table for flowtable column
885 -> Example of how related lists would look
886 -> Not using text entries for data items
888 The current version of Online Glom doesn't use HTML tables for the
891 This mockup has been sent to the glom-devel mailing list but it's good
892 to have it here as well.
894 * mockups/details-view-html-tables.html:
896 2011-12-05 Ben Konrath <ben@bagu.org>
898 Remove unnecessary getPrimaryKeyField() method.
900 getPrimaryKeyFieldForTable(String) has been renamed to
901 getPrimaryKeyField(String).
903 * src/main/java/org/glom/web/server/database/DBAccess.java:
904 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
905 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
907 2011-12-05 Ben Konrath <ben@bagu.org>
909 Add string representation of TypedDataItem value to conversion error message.
911 * src/main/java/org/glom/web/server/Utils.java: Logging the error
912 message was extracted into its own method to avoid duplication.
914 2011-12-05 Ben Konrath <ben@bagu.org>
916 Add type checking to navigation primary key value creation.
918 Create navigation primary key only if the expected type from the Glom
919 document matches the type returned by the SQL query.
921 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
923 2011-12-05 Ben Konrath <ben@bagu.org>
925 Rename a couple of variables in RelatedListNavigation.
927 This is a rename-only refactor.
929 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
931 2011-12-05 Ben Konrath <ben@bagu.org>
933 Move getListLayoutGroup() into getListViewLayoutGroup().
935 This removes getListLayoutGroup(). It was only being called by
936 getListViewLayoutGroup().
938 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
940 2011-12-05 Ben Konrath <ben@bagu.org>
942 Remove check for LayoutItem_Portal in list table method.
944 This check is no longer necessary because the method isn't being used
945 to create the LayoutItemPortal DTO.
947 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
949 2011-12-05 Ben Konrath <ben@bagu.org>
951 Properly support related list navigation.
953 Navigation from the "Repository Analyzer -> Package Scans ->
954 Dependencies" related table wasn't working because the primary key for
955 related tables wasn't being set properly. This commit fixes the
958 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
959 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
960 doesn't set the primary key properly for related list tables.
961 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
962 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
963 useful for getting the primary key for list view tables and for related
965 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
966 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
967 Move code to set the primary key for the table from the abstract
968 ListDBAccess class to ListViewDBAccess as it's only correct for list
970 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
971 Properly add primary key to related list tables.
973 2011-12-02 Ben Konrath <ben@bagu.org>
975 Properly set the horizontal alignment of fields.
977 This fix is for both the list tables and the details view.
979 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
980 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
981 to set the horizontal alignment of fields.
983 2011-12-02 Ben Konrath <ben@bagu.org>
985 Display currency codes in the details view.
987 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
989 2011-12-02 Ben Konrath <ben@bagu.org>
991 Avoid duplicate JNI call.
993 JNI is not as efficient as pure Java and this is an easy (and small)
996 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
997 Use previously retrieved value for whereClauseToTableName instead of
1000 2011-12-02 Ben Konrath <ben@bagu.org>
1002 Rename a couple of variables in RelatedListNavigation.
1004 This is a rename-only refactor.
1006 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1008 2011-12-02 Ben Konrath <ben@bagu.org>
1010 Indicate clearly that a mismatched primary key type is a bug.
1012 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1013 warning to error. Add 'This is a bug.' to message.
1015 2011-12-02 Ben Konrath <ben@bagu.org>
1017 Update / fix some comments.
1019 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1021 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1023 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1024 Fix comments. Add some TODOs.
1026 2011-12-02 Ben Konrath <ben@bagu.org>
1028 Enable navigation to details view with string primary key from related list.
1030 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1031 Create a text primary key value when return type of result is
1032 java.sql.Types.VARCHAR.
1034 2011-12-02 Ben Konrath <ben@bagu.org>
1036 Use checkboxes for booleans in the details view.
1038 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1040 2011-12-01 Ben Konrath <ben@bagu.org>
1042 Improve performance of related list height calculation.
1044 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1045 Put code to calculate the expected height in a static initializer so
1046 that that it's only called once.
1048 2011-12-01 Ben Konrath <ben@bagu.org>
1050 Show related list tables in notebooks (again).
1052 Calculate the height of the related list tables so the Notebook can be
1053 set the correct height. The height of the related list table is also needed by
1054 FlowTable to be able decide how to create the layout.
1056 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1057 and set the Portal height based on the height of the related list
1058 table and the Portal container.
1059 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1060 Add method to calculate the height of the related list tables.
1061 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1062 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1063 calculate the height of the Pager widget.
1065 2011-12-01 Ben Konrath <ben@bagu.org>
1067 Use CellTable API for table property instead of setting style on Element.
1069 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1071 2011-12-01 Ben Konrath <ben@bagu.org>
1073 Make ListViewTable and RelatedListTable a consistent height.
1075 The tables are now a consistent height regardless of the contents of
1076 the table. A hidden button is added to empty rows to ensure that the
1077 height of these rows will match the height of rows with data.
1079 A navigation button column is now added to every table. The width of
1080 the navigation column is set to 0px when a RelatedListTable shouldn't
1081 have navigation buttons. This maintains the a consistent row height in
1082 tables that don't show the navigation buttons.
1084 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1085 navigation column when not needed.
1086 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1087 arguments for navigation button to constructor of ListViewTable.
1088 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1089 hidden button for empty data rows.
1090 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1091 arguments for navigation button to constructor.
1092 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1093 create navigation buttons. Add hideNavigationButtons() method.
1094 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1095 arguments for navigation button to constructor.
1097 2011-12-01 Ben Konrath <ben@bagu.org>
1099 Use 'visibility: hidden' in Utils.getWidgetHeight().
1101 This is better choice because hidden elements are invisible, don't
1102 respond to events and are not part of the tab order. They will,
1103 however, take up space which is required to be able to calculate the
1104 height of the widget.
1106 * src/main/java/org/glom/web/client/Utils.java:
1108 2011-12-01 Ben Konrath <ben@bagu.org>
1110 Use Utils.getWidgetHeight() in FlowTable.
1112 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1114 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1116 2011-12-01 Ben Konrath <ben@bagu.org>
1118 Put the details css class name on the correct table column.
1120 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1122 2011-11-30 Ben Konrath <ben@bagu.org>
1124 Update for java-libglom API change.
1126 The getters and setters on FieldFormatting and NumericFormat were
1127 changed to remove the 'M'.
1129 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1131 2011-11-29 Ben Konrath <ben@bagu.org>
1133 Only allow RelatedListTables in Portals.
1135 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1137 2011-11-29 Ben Konrath <ben@bagu.org>
1139 Only create a contents panel for Portals when title is being set.
1141 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1143 2011-11-29 Ben Konrath <ben@bagu.org>
1145 Set TabLayoutPanel height based on calculated height its widgets.
1147 This is a potential fix for this bug:
1149 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1151 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1153 2011-11-29 Ben Konrath <ben@bagu.org>
1155 Align details field labels and data with the Open buttons.
1157 * src/main/webapp/style.css:
1159 2011-11-29 Ben Konrath <ben@bagu.org>
1161 Remove unnecessary <div> in the Notebook widget.
1163 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1164 method to get container FlowPanel (<div>).
1165 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1166 initWidget() method directly on the TabLayoutPanel widget instead of
1167 Group's container widget.
1169 2011-11-29 Ben Konrath <ben@bagu.org>
1171 Don't add group titles for Portals in Notebooks.
1173 This reverts the previous patch and fixes a bug I introduced with
1174 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1176 * src/main/java/org/glom/web/client/ui/details/Group.java:
1177 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1179 2011-11-28 Ben Konrath <ben@bagu.org>
1181 Remove unused boolean argument in Portal constructor.
1183 Just a code cleanup.
1185 * src/main/java/org/glom/web/client/ui/details/Group.java:
1186 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1188 2011-11-28 Ben Konrath <ben@bagu.org>
1190 Remove hack for glom 1.18 style glom files.
1192 * src/main/java/org/glom/web/client/ui/details/Group.java:
1193 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1194 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1196 2011-11-28 Ben Konrath <ben@bagu.org>
1198 Use Gda Value version of primary key to log result too large error.
1200 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1202 2011-11-28 Ben Konrath <ben@bagu.org>
1204 Don't use TypedDataItem.getText() for Unknown types from the URL.
1206 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1207 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1208 instead of getText().
1209 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1210 String field and getUnknown() method.
1212 2011-11-28 Ben Konrath <ben@bagu.org>
1214 Log an error message when the java-libglom .so is not present.
1216 The error message was being set in the exception but not logged.
1218 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1220 2011-11-28 Ben Konrath <ben@bagu.org>
1222 Ignore LayoutItem_CalendarPortals.
1224 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1225 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1227 2011-11-28 Ben Konrath <ben@bagu.org>
1229 Extract method for creating the LayoutItemPortal DTO.
1231 Just breaking the code up into smaller chunks.
1233 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1235 2011-11-28 Ben Konrath <ben@bagu.org>
1239 This should have been added with the refactor. Oops!
1241 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1243 2011-11-28 Ben Konrath <ben@bagu.org>
1245 Create primary key value from URL string using type from Glom document.
1247 See this bug, comments 19 - 25:
1249 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1251 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1252 create a TypeDataItem for the primary key here when loading from a
1253 URL. Show the same string for the primary key value as was received
1254 from the URL string (when loading from a URL).
1255 * src/main/java/org/glom/web/server/Utils.java: Update method for
1256 creating the Gda Value from the TypeDataItem to properly deal with
1257 creating a Gda Value based on the Glom document type for the primary
1258 key value string when loading from a URL.
1259 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1260 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1261 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1262 Update for changed method name.
1264 2011-11-27 Ben Konrath <ben@bagu.org>
1266 Rename PrimaryKeyItem to TypedDataItem.
1268 The name PrimaryKeyItem suggests what the class should be used for.
1269 TypedDataItem is a neutral name that describes the class better.
1271 This is a rename-only refactor.
1273 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1274 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1275 * src/main/java/org/glom/web/client/Utils.java:
1276 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1277 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1278 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1279 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1280 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1281 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1283 * src/main/java/org/glom/web/server/Utils.java:
1284 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1285 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1286 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1287 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1289 2011-11-25 Ben Konrath <ben@bagu.org>
1291 Improve Gda Value conversion from PrimaryKeyItem.
1293 The value from the PrimaryKeyItem is only used if its type match the
1294 type from the glom document.
1296 * src/main/java/org/glom/web/server/Utils.java:
1298 2011-11-25 Ben Konrath <ben@bagu.org>
1300 Manually check if the java-liblgom .so is visible to the JVM.
1302 It seems that Tomcat has problems when a static initializer throws an
1303 exception. This check is done before the first method call into
1304 java-libglom so that execution doesn't continue if the .so is not
1307 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1309 2011-11-25 Ben Konrath <ben@bagu.org>
1311 Improve browser configuration error messages.
1315 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1317 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1318 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1319 getConfigurationErrorMessage() method.
1320 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1321 Get and display a specific configuration error message when no Glom
1322 documents are found.
1323 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1324 Implement getConfigurationErrorMessage() method. Surround configuration
1325 code in the init() method with a try/catch block. This allows the
1326 errors to be caught while keeping the servlet available to retrieve the
1327 configuration error message.
1329 2011-11-25 Ben Konrath <ben@bagu.org>
1331 Don't use Strings to hold primary key values.
1333 The primary key values are now held in a new data object
1334 (PrimaryKeyItem) that holds type information and the primary key value
1335 using the correct type.
1337 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1338 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1340 PrimaryKeyItem instead of String to hold the primary key value.
1341 * src/main/java/org/glom/web/client/Utils.java: Remove
1342 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1343 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1344 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1345 PrimaryKeyItem instead of String to hold the primary key value. Load
1346 document selection page when the documentID has not been set correctly.
1347 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1348 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1350 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1351 Return empty string for URL instead of "null".
1352 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1353 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1354 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1355 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1356 PrimaryKeyItem instead of String to hold primary key values.
1357 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1358 PrimaryKeyValue to a Gda Value.
1359 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1360 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1361 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1362 Replace temporary database access code that uses the PrimaryKeyValue to
1363 Gda Value conversion.
1364 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1365 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1366 PrimaryKeyItem instead of String.
1367 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1368 hold primary key values.
1370 2011-11-24 Ben Konrath <ben@bagu.org>
1372 Use newly added java-libglom API to create queries.
1374 This isn't finished. I still need to stop using Strings for primary key
1375 values in the client code.
1377 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1378 libglom to use fake connections so that retrieving the query string will
1380 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1381 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1382 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1383 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1384 Use the newly added libglom sql methods and classes to create the
1385 query. Add temporary hack to convert primary value strings to Gda
1388 2011-11-23 Ben Konrath <ben@bagu.org>
1390 Don't explicitly set the height of Portals.
1392 See comments 6 - 10 of this bug for details:
1394 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1396 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1398 2011-11-23 Ben Konrath <ben@bagu.org>
1400 Use an HTML table instead of CSS for the FlowTable layout.
1402 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1403 GWT's FlexTable to implement the FlowTable.
1404 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1406 2011-11-18 Ben Konrath <ben@bagu.org>
1408 Add boolean example to HTML table mockup.
1410 * mockups/details-view-html-tables-text-entries.html:
1412 2011-11-17 Ben Konrath <ben@bagu.org>
1414 Ensure the pager buttons are always visible for related lists.
1416 To accomplish this, I've turned off text wrapping in the list view and
1417 related list tables for both the header and data text. The related list
1418 table now has a fixed layout so the it doesn't overflow its container.
1419 This is required to ensure that the cell text is clipped when it
1420 overflows the cell and an ellipsis is added to the right side of the
1421 cell when text is clipped.
1423 A fixed table layout for the related list table in the details view
1424 seems what we want for the details view anyway, so the side-effect is
1427 The ellipsis will only be displayed in Firefox >= 7.
1431 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1433 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1434 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1435 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1437 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1438 Set the 'table-layout: fixed' CSS property to the related list table.
1439 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1440 'white-space: nowrap;' CSS property on both the list view and the
1441 related list tables.
1443 2011-11-16 Ben Konrath <ben@bagu.org>
1445 Rework the fix for empty notebook tab labels.
1447 Setting the empty group titles with its name caused problems for the
1448 details layout. Instead of using libglom's
1449 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1450 to the client when the title is empty. This allows the Notebook to use
1451 the name when the title is empty without affecting anything else.
1453 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1454 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1456 2011-11-16 Ben Konrath <ben@bagu.org>
1458 Set group titles with name when title is empty.
1460 This fixes a problem with an empty notebook tab label in the Lesson
1461 Planner document. The forth tab in the notebook should be "Internet":
1463 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1465 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1466 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1469 2011-11-16 Ben Konrath <ben@bagu.org>
1471 Remove whitespace from the configured username properties.
1473 This assumes that usernames won't have whitespace at the beginning
1474 or end. But I think this is a reasonable assumption.
1476 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1477 String.trim() to remove the whitespace from the username properties.
1479 2011-11-15 Ben Konrath <ben@bagu.org>
1481 Add details view mockup with HTML tables and text entries.
1483 This is from the attachment on this bug:
1485 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1487 * mockups/details-view-html-tables-text-entries.html:
1489 2011-11-15 Ben Konrath <ben@bagu.org>
1491 Add space between the columns of the flow table.
1495 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1497 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1498 space between columns in the flow table.
1500 2011-11-15 Ben Konrath <ben@bagu.org>
1502 Add backup files to the .gitignore.
1504 * .gitignore: Ignore files that end with ~.
1506 2011-11-09 Ben Konrath <ben@bagu.org>
1508 Use latest release of gwt-log.
1510 Gwt-log releases are now being submitted to the maven central
1511 repository so manual installation of the jar is no longer required.
1513 * pom.xml: Update version and groupId of gwt-log dependency.
1515 2011-10-31 Ben Konrath <ben@bagu.org>
1517 Don't use GWT numeric formatting to override the glom currency formatting.
1519 Currencies are now displayed like they are in Glom. See this bug:
1521 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1523 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1525 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1526 currency code to constructor and set it when the cell is rendered.
1527 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1528 currency code to the constructor of the NumericCell.
1530 2011-10-27 Ben Konrath <ben@bagu.org>
1532 Require the latest release of java-libglom (1.17.4).
1536 2011-10-26 Ben Konrath <ben@bagu.org>
1538 Add style to Notebook that matches current theme.
1540 It's not the best style in the world but it's better than the default.
1542 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1543 padding at the bottom of the child widgets.
1544 * src/main/webapp/style.css: Add style for the Notebook.
1546 2011-10-26 Ben Konrath <ben@bagu.org>
1548 Move servlet initialization code to overridden init method.
1550 This is half of the solution to getting proper error messages
1551 displayed when configuration errors occur. Here's the relevant bug:
1553 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1555 The rest of the solution involves surrounding the init method with a
1556 try/catch block and setting a global variable with the error /
1557 exception. A new async method should be created to retrieve and display
1558 the error message / exception.
1560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1561 code from constructor to init method adding exceptions as needed.
1563 2011-10-26 Ben Konrath <ben@bagu.org>
1565 Add script to monitor and restart tomcat if required.
1567 * utils/check-and-recover-tomcat.py: New file.
1569 2011-10-26 Ben Konrath <ben@bagu.org>
1571 Display the correct number of data items in the pager.
1575 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1577 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1578 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1579 The implementation is the same for both tables: Keep track of the
1580 number of non-empty rows and fire and RowCountChangeEvent after the data has
1582 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1583 custom Pager class that subclasses SimplePager to handle displaying
1584 the correct number when empty rows have been added.
1586 2011-10-26 Ben Konrath <ben@bagu.org>
1588 Correct error in previous commit.
1590 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1591 eventBus parameter from listView.setCellTable().
1593 2011-10-26 Ben Konrath <ben@bagu.org>
1595 Fix error in TODO comment.
1597 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1599 2011-10-24 Ben Konrath <ben@bagu.org>
1601 Create Notebook widgets to the details view.
1603 This isn't finished just yet - I still need to create a reasonable
1604 style to match the current theme.
1606 * src/main/java/org/glom/web/client/Utils.java: Add method for
1607 calculating the height of a widget. This is used in the Notebook class.
1608 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1609 new constructor method in Group.
1610 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1611 method for creating child widget that can be used by subclasses
1612 like Notebook. New constructor that allows disabling the group
1613 titles - Notebooks don't set a group title for their child groups.
1614 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1615 to make Notebooks using GWT's TabLayoutPanel.
1616 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1617 constructor that allows disabling the group titles.
1618 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1619 LayoutItemNotebook DTO.
1620 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1621 DTO for Notebooks. It's just an empty class for now but we might need
1622 it to transfer some specific information in the future.
1624 2011-10-21 Ben Konrath <ben@bagu.org>
1626 Add navigation buttons to related list tables.
1628 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1629 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1630 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1631 method getSuitableRecordToViewDetails() for getting the table name
1632 and primary key value for related list navigation buttons.
1633 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1634 private cell renderer class to get the navigation information for
1635 related list tables from the server. Extract the navigation
1636 processing code from the details cell navigation and use it for the
1637 related list navigation as well.
1638 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1639 cell renderer class for the details open buttons. This was needed
1640 because the related list navigation buttons and the list view
1641 navigation buttons need to react differently when clicked.
1642 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1643 the onEnterKeyDown() method because it's now overriden in the
1644 subclasses that are specific to the related list tables and the list
1646 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1647 the vertical size a little because the buttons add a bit of vertical
1648 space to table. This is not a perfect solution because the vertical
1649 size of with table fewer than 5 rows will be a little smaller.
1650 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1651 changes in how navigation buttons are handled.
1652 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1653 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1654 database access object.
1655 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1656 to find the portal for a given relationship name from
1657 RelatedListDBAccess. Add method to find a primary key field for a
1659 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1660 Move code to find the portal for a given relationship name to
1662 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1663 New file: database access object for getting the related list
1664 navigation information (the table name and the primary key value).
1665 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1666 DTO for transferring a table name to navigate to and a primary key
1668 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1669 boolean and getter/setter to specifies if the related list should add
1672 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1674 Use the master branch of java-libglom
1676 * pom.xml: Depend on java-libglom 1.19 instead.
1678 This is the master branch. See also the libglom-1-18 branch.
1680 2011-10-11 Ben Konrath <ben@bagu.org>
1682 Enable the open navigation button when the data has been set.
1684 This avoids having active buttons that don't do anything when the data
1687 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1689 2011-10-11 Ben Konrath <ben@bagu.org>
1691 Use IsWidget interface for FlowTableItem.
1693 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1694 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1696 2011-10-11 Ben Konrath <ben@bagu.org>
1698 Remove GWT styling from open button in details view.
1700 There are still some issues with how the details cell is arranged but
1701 this should be made to match Glom 1.20. I'm going to leave fixing this
1702 until I have Glom 1.20 up and running.
1704 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1705 style name on open button.
1706 * src/main/webapp/style.css: Move and edit details-navigation class.
1707 Re-arrange some classes to make them appear in the same order as the
1710 2011-10-07 Ben Konrath <ben@bagu.org>
1712 Update to GWT 2.4.0.
1714 * .gitignore: Ignore new cache directory.
1715 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1716 * pom.xml: Change GWT and maven plugin to 2.4.0.
1717 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1719 * src/main/java/org/glom/web/client/ClientFactory.java:
1720 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1721 * src/main/java/org/glom/web/client/OnlineGlom.java:
1722 Update source for API changes.
1723 * utils/build-onlineglom-war.sh: Remove cache directory before the
1726 2011-10-07 Ben Konrath <ben@bagu.org>
1728 Add navigation buttons in the details view.
1730 This isn't finished but I thought I'd commit what I have as it's a
1731 pretty good start. I still need to:
1733 1. Change the style so that it fits better into the current theme
1734 2. Adjust the details cell to expand as much as possible.
1736 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1737 click handlers to navigation buttons in the DetailsCells. Create a
1738 refreshData() method to get just the data from the server without the
1740 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1741 Update the tableSelector and browser title when the table name
1742 changes without using the tableSelector.
1743 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1744 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1745 getDetailsCells() to getCells(). Update variable names.
1746 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1747 method to set click handler on navigation button. Rename a few
1748 variables. Add navigation buttons where needed.
1749 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1750 variables and methods.
1751 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1752 navigation boolean and navigation table as required in the
1753 LayoutItemField DTO.
1754 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1755 variables for navigation along with getter/setter methods.
1757 2011-10-07 Ben Konrath <ben@bagu.org>
1759 Rename Field to DetailsCell.
1761 This is a refactor-only commit. No functionality has been added or
1764 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1765 Update variable and method names.
1766 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1767 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1768 variable and method names.
1769 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1771 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1772 variable and method names.
1774 2011-10-07 Ben Konrath <ben@bagu.org>
1776 Create separate methods for layout and data the details view.
1778 This is a refactor-only commit. No functionality has been added or
1781 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1782 private methods: setData(), createLayout().
1784 2011-10-07 Ben Konrath <ben@bagu.org>
1786 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1788 This is part of a change to get navigation buttons in the details view
1789 but it should have been done this way from the start.
1791 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1792 for method name change in TableSelectionView.
1793 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1794 Create TableChangeEvent and set the browser title using the
1795 TableSelectionView API.
1796 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1797 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1798 Change getSelectedTable() to getSelectedTableName(). Add
1799 getSelectedTableTitle().
1801 2011-10-07 Ben Konrath <ben@bagu.org>
1803 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1805 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1807 2011-10-07 Ben Konrath <ben@bagu.org>
1809 Update TableChangeEvent to use newTableName naming convention.
1811 This makes the class more consistent with GWT naming conventions.
1813 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1814 Update for method name change in TableChangeEvent.
1815 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1816 for method name change in TableChangeEvent.
1817 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1818 newTableName variable and getter method. Make toDebugString()
1821 2011-09-30 Ben Konrath <ben@bagu.org>
1823 Disable the pager in the list tables when the data row count is less than the minimum.
1825 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1826 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1828 2011-09-30 Ben Konrath <ben@bagu.org>
1830 Add empty rows to the end of related list and list view tables.
1832 I also extracted the cell rendering classes from the ListTable because
1833 the code was becoming a little crazy with all the anonymous inner
1834 classes. My plan is to use these cell rendering classes in the details
1835 view as well so this refactor will be needed for that change.
1837 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1838 set the row count in related list tables if the data has more rows
1839 than the minimum number of rows visible.
1840 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1841 row count in list view tables if the data has more rows than the
1842 minimum number of rows visible.
1843 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1844 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1846 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1847 for rendering TYPE_NUMERIC cells. The code was extracted from the
1849 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1850 class for rendering cells with buttons in list views. The code was
1851 extracted from the ListTable class.
1852 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1853 for rendering TYPE_TEXT cells. The code was extracted from the
1855 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1856 Add empty rows to the end of the data if required. Implement
1857 ListTable.getMinNumVisibleRows().
1858 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1859 cell renderer code to public classes. Return null in
1860 Column.getValue() for empty rows. Add new abstract method:
1861 getMinNumVisibleRows(). Move code to set the row count of the list view
1862 table to ListViewImpl.
1863 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1864 empty rows to the end of the data if required. Implement
1865 ListTable.getMinNumVisibleRows().
1868 2011-09-27 Ben Konrath <ben@bagu.org>
1870 Use GWT.log for client-side debugging statements.
1872 These are optimized out when deployed so I should have used this method
1873 in the first place. These statements will eventually be replaced with some sort
1874 of notification in the browser.
1876 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1877 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1878 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1879 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1880 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1882 2011-09-27 Ben Konrath <ben@bagu.org>
1884 Put tableselector on the right, back to list link on right.
1886 The idea is that the table selector is acting like a label for the
1887 currently displayed table so it should be placed below the document title. This
1888 puts the table title in a similar position to where it is in Glom.
1890 * mockups/details-contacts.html:
1891 * mockups/details-projects.html:
1892 * mockups/listview-contacts.html:
1893 * mockups/listview-projects.html:
1894 * mockups/style.css:
1895 Update mockups to match how the interfaces currently look.
1896 * src/main/webapp/style.css: Swap positions of backlink with the table
1897 selector. Add some space on the left side of the table selector to
1898 line things up with the document title.
1900 2011-09-27 Ben Konrath <ben@bagu.org>
1902 Add field colouring to details view.
1904 This change re-works how field colouring works. The colour formatting
1905 information is now set to the client with the layout information instead of
1906 with the data. This eliminates the need to send the same colour strings for
1907 data in list view column when colour information is set.
1909 In order to set an alternate colour for negative numeric values, the
1910 number is now sent to client and formatted with the GWT NumberFormat class.
1912 This change also fixes:
1914 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1916 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1917 internationalization framework which is needed for client side numeric
1919 * src/main/java/org/glom/web/client/Utils.java: New file for some
1920 client static utility methods.
1921 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1922 the DataItem object to the Field class. Use a utility method to
1923 create the foreignKeyValue string.
1924 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1925 alignment and text colours in the constructor. Add setData(DataItem)
1926 method. Remove setText(String) method.
1927 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1928 colour information to GlomTextCell. Create and use GlomNumberCell for
1929 rendering numbers. Use utility method to get the string for the
1930 primary key of the key provider. Re-work how the horizontal alignment
1932 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1933 formatting to layout information. Methods for converting the libglom
1934 formatting information were moved from DBAccess.
1935 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1936 numeric formatting (it's now done on the client side). Don't set text
1937 colours in DataItem. Move libglom formatting conversion methods to
1939 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1940 getters/setters for text colour information.
1941 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1942 for transferring the libglom NumericFormat information to the client.
1943 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1944 and getters/setters for: GlomNumericFormat, background colour and
1945 foreground colour strings.
1947 2011-09-26 Ben Konrath <ben@bagu.org>
1949 Simplify code that iterates through the LayoutGroup.
1951 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1953 2011-09-26 Ben Konrath <ben@bagu.org>
1955 Accept Eclipse formatting for OnlineGlomServiceAsync.
1957 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1959 2011-09-26 Ben Konrath <ben@bagu.org>
1961 Don't use the ListDBAccess classes to get the primary key layout information.
1963 This was causing a bug where the wrong index for the hidden primary key
1964 was being sent to the client.
1966 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1967 primary key while creating the LayoutGroup DTO. Create a
1968 LayoutItemField DTO for hidden primary keys. Don't use the
1969 RelatedListDBAccess because it was only used for getting the primary
1971 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1972 access modifier from public to protected for getPrimaryKeyField() and
1973 getPrimaryKeyLayoutItemField().
1974 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1975 abstract method getExpectedResultSize() because RelatedListDBAccess
1976 doesn't have enough info to implement it.
1977 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1978 Remove @Override for getExpectedResultSize().
1979 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1980 Remove method getExpectedResultSize().
1982 2011-09-23 Ben Konrath <ben@bagu.org>
1984 Log which layout (list or details) the ignored item is from.
1986 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1988 2011-09-23 Ben Konrath <ben@bagu.org>
1990 Remove annotations that turn off code formatting in DataItem.
1992 * src/main/java/org/glom/web/shared/DataItem.java:
1994 2011-09-23 Ben Konrath <ben@bagu.org>
1996 Rename GlomField to DataItem and update associated methods.
1998 This is a rename-only refactor. No functionality has been added or
2001 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2002 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2003 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2004 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2005 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2006 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2007 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2008 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2009 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2010 * src/main/java/org/glom/web/server/database/DBAccess.java:
2011 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2012 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2013 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2014 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2015 * src/main/java/org/glom/web/shared/DataItem.java:
2016 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2017 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2019 2011-09-23 Ben Konrath <ben@bagu.org>
2021 Rename GlomDocument to DocumentInfo and update associated methods.
2023 This is a rename-only refactor. No functionality has been added or
2026 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2027 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2028 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2029 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2030 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2031 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2032 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2034 2011-09-20 Ben Konrath <ben@bagu.org>
2036 Require java-libglom 1.17.3.
2038 This picks up the fix for the seg fault problem with the Scenes table
2039 in the Openismus Film Manager example.
2043 2011-09-20 Ben Konrath <ben@bagu.org>
2045 Change the way sort clause is added for primary key when no sort clause is requested.
2047 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2048 before the sort clause is created. When a sort clause is not requested, the
2049 sort clause is created by finding the primary key in the LayoutFieldVector
2052 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2054 2011-09-20 Ben Konrath <ben@bagu.org>
2056 Log error message if no documents are found in the configured directory.
2058 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2059 Extract the glom file extension string to a private static final class
2060 variable (mostly as syntactic sugar). Accept a minor formatting change.
2061 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2062 the example glom.document.directory configuration property to make it
2063 more clear that it can any directory, not just the home directory.
2065 2011-09-18 Ben Konrath <ben@bagu.org>
2067 Add related lists to details view.
2069 The related list table has support for paging and sorting just like the
2070 table in the list view.
2072 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2073 SQL queries for the related list tables.
2074 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2075 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2076 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2077 Rename getList methods to getListView and add comments. Remove
2078 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2079 it being unused. Add methods: getDetailsLayoutAndData(),
2080 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2081 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2082 Create the layout and set the data for the fields in one async call
2083 instead of two. Create related lists where appropriate.
2084 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2085 for method name changes in OnlineGlomService.
2086 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2087 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2088 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2090 * src/main/java/org/glom/web/client/ui/ListView.java:
2091 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2092 tableName from setCellTable(). Create a ListViewTable instead of
2094 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2095 represent a data field in the details view.
2096 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2097 from addDetailsCell() to Field class. Keep track of the Fields and
2098 Portals in the details view.
2099 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2100 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2101 and add a method to get it. Add method to set the contents of the
2103 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2104 New class for related list tables. This class has the data provider
2105 for the related list table.
2106 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2107 abstract class which is the base class for the ListViewTable and the
2109 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2110 New class for list view tables. This class has the data provider for
2111 the list view table.
2112 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2113 methods for related list tables. Add more information to the
2114 LayoutItemField and LayoutItemPortal DTOs.
2115 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2116 Remove debugging print statement.
2117 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2118 Remove debugging print statements. Add primary key field to SQL count
2120 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2121 Remove unnecessary LayoutFieldVector parameter from
2122 getResultSizeOfSQLQuery() method.
2123 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2124 New class for related list table database access.
2125 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2126 class that is a wrapper DTO for details view layout and data.
2127 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2128 new 'fromField' string to this DTO.
2129 * src/main/webapp/style.css: Remove bottom margin and override top
2132 2011-09-15 Ben Konrath <ben@bagu.org>
2134 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2136 This sets things up to make it easier to add the data retrieval for
2137 related lists (portals). No user noticeable changes were made with
2140 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2141 class has the code to retrieve the layouts and access the
2142 database using the new database helper classes.
2143 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2144 Most of the functionality has been removed from this class. This
2145 class now represents the public interface for the client side
2146 code. It also deals with configuring the servlet and cleaning
2147 things up when the servlet is stopped.
2148 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2149 of static methods into this utility class.
2150 * src/main/java/org/glom/web/server/database/DBAccess.java:
2151 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2152 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2153 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2154 These classes have the database retrieval code. The class hierarchy
2155 has been setup to make it easy to reuse code for similar
2158 2011-09-06 Ben Konrath <ben@bagu.org>
2160 Create separate classes for list table code and the data provider.
2162 As part of this refactor, I also split up the code a bit to make it
2165 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2166 table code to two new classes (below).
2167 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2168 with code from ListViewImpl.
2169 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2170 New file with code from ListViewImpl.
2172 2011-09-06 Ben Konrath <ben@bagu.org>
2174 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2176 This fixes the LayoutItemPortal DTO to match the libglom layout object
2179 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2181 2011-09-01 Ben Konrath <ben@bagu.org>
2183 Set title of Portals in the Details View.
2185 * pom.xml: Bump required version of java-libglom to 1.17.1.
2186 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2187 widget creation to its own class. Add comments to constructor.
2188 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2189 The code is mostly from the Group class with the title now set.
2190 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2191 title of Portal. Update some comments. Fix some code formatting.
2193 2011-09-01 Ben Konrath <ben@bagu.org>
2195 Remove TODO comment for the flow table column width.
2197 The flow table column width is working correctly and doesn't need to be
2198 changed. See this mailing list post for more info:
2200 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2202 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2204 2011-08-27 Ben Konrath <ben@bagu.org>
2206 Add document title (database name) to top of the browser page.
2208 I added the document title to the TableSelecitonView but that will
2209 change if / when we add a view that doesn't require table selection.
2211 * mockups/details-contacts.html:
2212 * mockups/details-projects.html:
2213 * mockups/listview-contacts.html:
2214 * mockups/listview-projects.html:
2215 * mockups/style.css: Add document title to mockups to keep things
2217 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2218 sizes to account for the document title.
2219 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2220 Set the document title when it has been retrieved from the server.
2221 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2222 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2223 and implement setDocumentTitle(String) method.
2224 * src/main/webapp/style.css: Add ID for document title style.
2226 2011-08-25 Ben Konrath <ben@bagu.org>
2228 Add NavigationType enum to LayoutItemPortal DTO.
2230 This is the start of adding support for Portals to the Details View.
2232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2233 LayoutItem_Portal.navigation_type enum from libglom to
2234 LayoutItemPortal.NavigationType enum.
2235 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2236 NavigationType enum, field for storing the NavigationType and getter
2239 2011-08-25 Ben Konrath <ben@bagu.org>
2241 Implement the flow table layout in the Details View.
2243 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2244 FlowTable to Group to account for the renamed class.
2245 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2246 File. This is a container widget that implements the Glom details view
2247 flow table behaviour.
2248 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2249 org/glom/web/client/ui/FlowTable.java.
2250 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2251 so that the size of the subgroups are a closer match to the size of
2252 the Glom subgroups. This makes the flowtable layout match the layout
2253 in Glom for the Music Collection example file.
2255 2011-08-16 Ben Konrath <ben@bagu.org>
2257 Create container element for LayoutItemPortal in Details View.
2259 This will help me develop the layout for the FlowTable.
2261 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2262 fieldPanel variable to detailsCell.
2264 2011-08-15 Ben Konrath <ben@bagu.org>
2266 Set the height of the data element in the Details View.
2268 I changed the InlineLabels (text in a span element) to Labels (text in
2269 a div element) so that I could set the height of the details-data
2270 elements instead of the details-cell parent elements. This allows the
2271 the details-data element to display the correct height if style is
2272 applied that shows the height.
2274 This change has the added benefit of allowing the order of the labels
2275 and data elements to be changed for right-to-left languages.
2277 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2278 InlineLabels to Labels.
2279 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2280 InlineLabels to Labels. Set the height of the data element.
2281 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2282 multiline text height in the Formatting DTO.
2283 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2284 for multiline height along with getter and setter methods.
2285 * src/main/webapp/style.css: Adjust style to account for the change
2286 from span elements to div elements in the details cell.
2288 2011-08-15 Ben Konrath <ben@bagu.org>
2290 Make the List View appearance match the mockups.
2292 It doesn't match exactly but it's much better than it was.
2294 * mockups/listview-contacts.html: Remove unused css classes.
2295 * mockups/listview-projects.html: Remove unused css classes.
2296 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2297 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2298 for mainPanel instead of VerticalPanel (table). Set style name on
2299 CellTable. Set style name on Details column. Right-align Details
2301 * src/main/webapp/style.css: Adjust properties to match the mockups.
2303 2011-08-12 Ben Konrath <ben@bagu.org>
2305 Add better support for subgroups in the details view.
2307 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2308 changed FlowTable constructor.
2309 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2310 support for subgroups and subgroup-titles.
2311 * src/main/webapp/style.css: Add CSS class for subgroups and
2314 2011-08-12 Ben Konrath <ben@bagu.org>
2316 Return the top level LayoutGroup title.
2318 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2320 2011-08-11 Ben Konrath <ben@bagu.org>
2322 Make the TableSelector header match the mockup.
2324 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2325 the layout panel. Properly lineup the table selection header with
2326 the list and details view.
2327 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2328 margin around the details view.
2329 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2330 Rename listBox variable to tableSelector. Set id for the style sheet.
2331 Use a FlowPanel instead of a HorizontalPanel.
2332 * src/main/webapp/style.css: Add properties to make the TableSelector
2333 box match the mockups.
2335 2011-07-13 Ben Konrath <ben@bagu.org>
2337 Update install script for java-libglom version change.
2339 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2342 2011-07-13 Ben Konrath <ben@bagu.org>
2344 Add support sub-group in the details view.
2346 I also removed the code that special-cased the default details view
2349 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2351 I still have to make a proper flowtable.
2353 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2354 Don't special-case default details view layout.
2355 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2356 addLayoutField() as I'm going to use it.
2357 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2358 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2360 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2361 extracted from DetailsViewImpl.GroupPanel. Add support for
2363 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2364 column count when getting the details layout.
2366 2011-07-12 Ben Konrath <ben@bagu.org>
2368 Set browser title with database and table titles.
2370 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2371 Set the browser title when the table changes and when the activity
2373 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2374 title when retrieving document info (the GlomDocument object).
2375 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2376 with getter and setter methods. Remove unused convenience constructor.
2377 Use default code formatting.
2379 2011-07-12 Ben Konrath <ben@bagu.org>
2381 Ignore LayoutItemPortals in the details view.
2383 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2386 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2387 LayoutItemPortal layout objects.
2388 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2389 LayoutItemPortal objects when retrieving the details layout.
2390 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2391 file. This is an empty class and just used to get type information for
2394 2011-07-12 Ben Konrath <ben@bagu.org>
2396 Use java-libglom 1.17.0.
2400 2011-07-11 Ben Konrath <ben@bagu.org>
2402 Remove "Table:" label from table selector.
2404 This matches a recent change in the Glom UI.
2406 * mockups/details-contacts.html:
2407 * mockups/details-projects.html:
2408 * mockups/listview-contacts.html:
2409 * mockups/listview-projects.html: Remove the "Table:" label from the
2411 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2413 2011-07-11 Ben Konrath <ben@bagu.org>
2415 Add main groups to the details view.
2417 This makes things look a little nicer in the details view. The next step
2418 is to implement the flowtable.
2420 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2421 resources from the standard gwt css theme. Standard.css is now
2422 included in OnlineGlom.html so that the online glom css rules have
2423 precedence over the gwt theme.
2424 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2425 the whole LayoutGroup to the DetailsView instead of just the titles.
2426 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2427 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2428 details layout with a helper class (GroupPanel). I might extract this
2429 class when I make the full flowtable.
2430 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2431 string as default so I don't have to worry about NPEs when processing
2433 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2434 note beside OnlineGlom.gwt.xml above).
2435 * src/main/webapp/style.css: Add default font-size to body to override
2436 the font-size set by the standard theme. Don't use h2 tags for
2437 group-title. Create new details-cell class.
2439 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2441 ConfiguredDocument: Set the port number too.
2443 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2444 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2445 Glom document. Presumably this worked sometimes so far because there is a
2446 default port number.
2448 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2450 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2452 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2453 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2454 correct, though we should throw an exception too.
2456 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2458 Fix a addDocuemnt typo.
2460 * src/main/java/org/glom/web/shared/Documents.java
2461 (Documents.addDocuemnt): Rename to addDocument().
2462 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2463 (OnlineGlomServiceImpl.getDocuments): Adapt.
2465 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2467 Slightly improved log output when connection fails.
2469 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2470 (ConfiguredDocument.setUsernameAndPassword):
2471 We don't know for sure if it' the username/password that's wrong, so
2472 rephrase the message.
2473 Also ouput the exception message, though it's generic in this case.
2475 2011-07-08 Ben Konrath <ben@bagu.org>
2479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2480 added braces to a one line if statement because the Eclipse formatter
2481 was getting confused.
2483 2011-07-07 Ben Konrath <ben@bagu.org>
2485 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2487 These should really be two separate tasks but I counldn't get things to
2488 work with GWT 2.2.0 and Eclipse 3.7.
2492 * .settings/org.eclipse.jdt.core.prefs:
2493 * .settings/org.eclipse.jdt.ui.prefs:
2494 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2495 * .settings/org.eclipse.m2e.core.prefs:
2496 Add new config files. Update current files. Remove references to the
2497 webtools plugins as we're not using any of the webtools features.
2498 * .gitignore: Add logs directory which is created when running with
2500 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2501 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2502 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2504 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2506 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2508 onlineglom.properties: Add explanatory comments.
2510 * src/main/resources/onlineglom.properties: Also change the default user
2511 from ben to someuser, to avoid the risk of people thinking we just
2512 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2514 2011-06-28 Ben Konrath <ben@bagu.org>
2516 Use filename in Log for incorrect passwords.
2518 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2519 getFileName(String) method to get the filename from the URI.
2521 2011-06-28 Ben Konrath <ben@bagu.org>
2523 Add the table name to the URL token for the ListPlace.
2525 This makes things consistent between the DetailsPlace and the
2526 ListPlace. It also allows the the ListPlace to be bookmarked.
2528 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2529 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2530 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2531 Remove getDefaultListLayout(). The default layout is now returned
2532 by the getListLayout() method when the table name is an empty string.
2533 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2534 Add table name field. Change to a new ListPlace when the table
2535 has been changed. Use getListLayout() for getting the default
2537 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2538 Add table name field. Set the correct table name in the list box
2539 when loading from bookmark. This corrects a problem for the
2541 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2542 Move table name to super-class (HasSelectableTable). Move document
2543 and table URL keys to super-class in HasSelectableTable.
2544 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2545 Add table name field. Add Tokenizer class with URL key common to
2546 the subclasses (DetailsPlace and ListPlace).
2547 * src/main/java/org/glom/web/client/place/ListPlace.java:
2548 Add table name. Add code to parse the URL token.
2549 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2550 Update ListPlace construction with empty table name string.
2551 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2552 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2553 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2554 Update ListPlace construction with table name string.
2555 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2556 Change defaultTableName field to tableName to reflect how it's now
2557 used. Update the getter and setter methods.
2559 2011-06-28 Ben Konrath <ben@bagu.org>
2561 Enable the table selector in the DetailsView.
2563 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2564 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2565 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2566 Remove getDefaultDetailsLayout(). The default layout is now returned
2567 by the getDetailsLayout() method when the table name is an empty
2569 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2570 event handler for table change event. Change to using
2571 getDetailsLayout() for the default details layout.
2572 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2574 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2575 when navigating to the details place.
2577 2011-06-27 Ben Konrath <ben@bagu.org>
2579 Use filename based unique document ID in URL and for RPC.
2581 The document ID is the glom document name with spaces (' ') replaced
2582 with pluses ('+') and without the .glom extension.
2584 This change is mostly a string substitution of 'documentTitle' for
2585 'documentID'. The only code change is the addition of a Documents DTO to get the
2586 filename to document title mappings as indicated below.
2588 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2589 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2590 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2591 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2592 Use Documents DTO to create the document links in the document
2594 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2595 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2596 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2597 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2598 * src/main/java/org/glom/web/client/place/ListPlace.java:
2599 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2600 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2601 * src/main/java/org/glom/web/client/ui/ListView.java:
2602 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2603 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2604 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2605 * src/main/java/org/glom/web/server/Log.java:
2606 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2607 getDocumentTitles() to getDocuments() and return the Documents DTO.
2608 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2609 transferring the filename to document title mappings.
2611 2011-06-25 Ben Konrath <ben@bagu.org>
2613 Make the authentication popup work again.
2615 This bug was introduced when I extracted ConfiguredDocument to its own class.
2617 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2618 correct success / fail status in setUsernameAndPassword().
2620 2011-06-25 Ben Konrath <ben@bagu.org>
2622 Use filename as unique key for configuring database usernames and passwords.
2624 This replaces the use of the Glom document title which could change
2625 depending on the locale. Thanks to Murray Cumming for pointing out this
2628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2629 * src/main/resources/onlineglom.properties:
2631 2011-06-24 Ben Konrath <ben@bagu.org>
2633 Pass primary key value to DetailsView.
2635 This enables the DetailsView to load the correct data.
2637 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2638 primary key value field and set in constructor. Pass primary key
2639 value to getDetailsData().
2640 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2641 variables for document title and primary key value.
2642 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2643 key value to the DetailsPlace.
2645 2011-06-24 Ben Konrath <ben@bagu.org>
2647 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2649 This allows the primary key to be retrieved by the Details button. This
2650 functionality has not been implemented yet but it's in the works.
2652 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2653 the LayoutGroup result to ListView.setCellTable instead of all of its
2654 fields individually.
2655 * src/main/java/org/glom/web/client/ui/ListView.java:
2656 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2657 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2658 get the primary key for the table.
2659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2660 index of the primary key in the LayoutGroup accounting for hidden
2661 primary keys. Rename getJavaNumberFormat() to
2662 convertToJavaNumberFormat() for consistency. Cleanup / add some
2664 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2665 field for primary key index and a field to indicate whether the
2666 primary key is hidden or not.
2668 2011-06-23 Ben Konrath <ben@bagu.org>
2670 Rename getTableData methods to getListData.
2672 This is a rename refactor for consistency with other methods.
2674 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2675 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2676 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2677 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2679 2011-06-23 Ben Konrath <ben@bagu.org>
2681 Extract the ConfiguredDocument innerclass into its own class.
2683 This makes the servlet code more object oriented.
2685 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2686 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2687 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2688 new ConfiguredDocument class.
2690 2011-06-21 Ben Konrath <ben@bagu.org>
2692 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2694 This makes things more inline with how libglom works and reduces code
2695 duplication. This refactor lays the groundwork for adding the primary key to
2696 the LayoutGroup object.
2698 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2699 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2700 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2701 Change method names to getListLayout and getDefaultListLayout for
2702 consistency. Use LayoutGroup as the DTO for the list layout instead of
2703 ColumnInfo and LayoutListTable.
2704 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2705 new method names along with the LayoutGroup object for transferring the
2707 * src/main/java/org/glom/web/client/ui/ListView.java:
2708 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2709 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2710 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2712 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2713 Replaced with LayoutGroup.
2714 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2715 expectedResultSize and defaultTableName fields which are needed for
2717 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2718 type field which is needed for the list layout but will also be
2719 useful for the details layout as things progress.
2720 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2721 Make class abstract. Remove the unnecessary
2722 getFormattingHorizontalAlignment method. Add setFormatting method.
2724 2011-06-16 Ben Konrath <ben@bagu.org>
2726 Add scripts for building and installing war.
2728 These will help when updating OnlineGlom but they're also good
2729 supplemental documentation of the build and deployment proceeding.
2731 * utils/build-onlineglom-war.sh: New file.
2732 * utils/install-onlineglom-war.sh: New file.
2734 2011-06-16 Ben Konrath <ben@bagu.org>
2736 Create wrapper class to create consistent log messages.
2738 I wrapped methods in the Log class of gwt-log to add the method names
2739 from the servlet and create consistent formatting of the document title
2740 and table names in the log messages.
2742 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2743 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2744 log methods to use methods from wrapped Log class.
2746 2011-06-16 Ben Konrath <ben@bagu.org>
2748 Remove superfluous conditional return.
2750 Thanks to Murray Cumming for pointing this out!
2752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2754 2011-06-15 Ben Konrath <ben@bagu.org>
2756 Return an ArrayList of LayoutGroups for the Details layout.
2758 This corrects a problem with the details layout as it can have more
2759 than one top level LayoutGroup.
2761 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2762 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2763 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2764 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2765 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2766 with ArrayList of LayoutGroups for the details view layout.
2767 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2768 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2769 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2770 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2771 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2772 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2774 2011-06-14 Ben Konrath <ben@bagu.org>
2776 Use cast_dynamic method to determine the libglom LayoutItem type.
2778 This is better than finding the LayoutItem type by using the string
2779 returned from the get_part_type_name() method.
2781 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2783 2011-06-14 Ben Konrath <ben@bagu.org>
2785 Add method names to log entries in the servlet.
2787 This helps when tracking down deployment problems.
2789 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2791 2011-06-14 Ben Konrath <ben@bagu.org>
2793 Add data to the DetailsView using a hard-coded primary key value.
2795 The layout and functionality of the DetailsView is not complete. This
2796 is just a checkpoint so the patch doesn't get too big.
2798 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2799 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2800 Add getDetailsData() servlet method.
2801 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2802 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2803 LayoutFields are added to the DetailsView.
2804 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2805 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2806 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2807 take the string for the title instead of the object.
2808 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2809 Add implementation getDetailsData() along with some private helper
2811 * src/main/webapp/style.css: Add padding to details-data class. Add a
2812 details-label class with the same padding as the details-data class.
2814 2011-06-03 Ben Konrath <ben@bagu.org>
2816 Use presenter.goTo() to change to the DetailsPlace.
2818 This will make things easier when we need to open the DetailsView with
2819 data specific to the row that was clicked.
2821 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2823 2011-06-02 Ben Konrath <ben@bagu.org>
2825 Add CSS file from mockups.
2827 I'm adding this now because it's going to be useful to have when
2828 developing the DetailsView. The TableSelectionView and ListView aren't
2831 * src/main/webapp/OnlineGlom.html:
2832 * src/main/webapp/style.css:
2834 2011-06-02 Ben Konrath <ben@bagu.org>
2836 Use String.isEmpty() to check for empty string.
2838 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2840 2011-06-02 Ben Konrath <ben@bagu.org>
2842 Display main layout group titles in the DetailsView.
2844 This is the start of the DetailsActivity/DetailsView implementation.
2846 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2847 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2848 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2849 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2850 Get the layout information for the details view from the server and set
2851 the main layout group titles.
2852 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2853 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2854 Add addLayoutGroup() and addLayoutField() methods. This are just
2855 temporary methods for creating the the details view that will change
2857 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2858 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2860 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2861 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2862 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2863 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2864 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2865 Data Transfer Objects that mimic the libglom object structure. These are
2866 used for transferring the details layout but could also be used for
2867 transferring the list layout.
2869 2011-05-27 Ben Konrath <ben@bagu.org>
2871 Reset the AuthenticationPopup when clearing the ListView.
2873 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2875 2011-05-27 Ben Konrath <ben@bagu.org>
2877 Fix problem with onlineglom.properties file loading.
2879 The old way worked in Eclipse but not on the server. Loading the
2880 onlineglom.properties file now works in Eclipse and on the server.
2882 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2884 2011-05-24 Ben Konrath <ben@bagu.org>
2886 Update gwt-log from 3.1.0 to 3.1.2.
2888 Gwt-log 3.1.0 has been marked as depreciated.
2892 2011-05-24 Ben Konrath <ben@bagu.org>
2894 Add comment to ListActivity.goTo() method.
2896 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2898 2011-05-24 Ben Konrath <ben@bagu.org>
2900 Remove FIXME in convertGdkColorToHtmlColour()
2902 The Gdk::Color value returned by libglom is 16-bits per channel on both
2903 64 and 32-bit platforms.
2905 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2907 2011-05-19 Ben Konrath <ben@bagu.org>
2909 Improve performance of initial ListView load.
2911 I removed a round trip to the server for getting the default table name
2912 and then requesting information about that table. This also removes a potential
2913 problem with the table change handler not being setup in time to receive the
2914 table change event from the ListActivity.
2916 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2917 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2918 getDefaultLayoutListTable() method. Improve comments.
2919 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2920 getDefaultLayoutListTable() method instead of firing a table change
2921 event to get the table to load.
2922 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2923 implementation of getDefaultLayoutListTable() method.
2924 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2927 2011-05-19 Ben Konrath <ben@bagu.org>
2929 Override toDebugString() in TableChangeEvent.
2931 This is useful to have for debugging.
2933 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2935 2011-05-19 Ben Konrath <ben@bagu.org>
2937 Add a "Back to List" link when at the DetailsPlace.
2939 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2940 Populate the CellTable based on the selected table of the ListBox if
2941 it's set otherwise use the default table. This allows the "Back to
2943 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2944 Remove Place from constructors. Add a setPlace() method. Add
2945 goToPlace() method. Set class as presenter for TableSelectionView.
2946 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2947 Use the same TableSelectionActivity when switching between the List and
2949 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2950 Subclass the new HasSelectableTablePlace. This removes some duplicate
2952 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2953 New class to represent Places that display the TableSelectionView.
2954 * src/main/java/org/glom/web/client/place/ListPlace.java:
2955 Subclass the new HasSelectableTablePlace. This removes some duplicate
2957 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2958 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2959 Add Presenter interface. Add setBackLinkVisible() method. Add
2960 setBackLink() method.
2962 2011-05-18 Ben Konrath <ben@bagu.org>
2964 Enable the "Details" buttons.
2966 Right now only an empty details view is displayed.
2968 * src/main/java/org/glom/web/client/ClientFactory.java:
2969 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2970 Add DetailsView to ClientFactory.
2971 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2972 A basic activity for the details view.
2973 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2974 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2976 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2977 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2979 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2980 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2981 unnecessary super() in constructor.
2982 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2983 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2984 really shouldn't create a new TableSelectionActivity for both the ListPlace
2985 and the DetailsPlace so this should be considered a temporary solution.
2986 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2987 New file. Represents a URL for the details view.
2988 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2989 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2990 A basic details view interface and implementation.
2991 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2992 Enable the "Details" buttons.
2994 2011-05-12 Ben Konrath <ben@bagu.org>
2996 Use a LayoutPanel with multiple display areas for main layout.
2998 This is mostly a refactor in that there are no changes from the user
2999 point of view. These changes are required so that we can swap out the list view
3000 with the details view when the user clicks the "Details" button.
3002 * src/main/java/org/glom/web/client/ClientFactory.java:
3003 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3004 OnlineGlomView. Add TableSelectionView, ListView and
3005 AuthenticationPopup.
3006 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3007 for main layout. Add display regions for main activities. Add
3008 activity manager for for main activities.
3009 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3010 file from parts of the deleted OnlineGlomActivity.
3011 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3012 New file from parts of the deleted OnlineGlomActivity.
3013 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3014 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3015 New files for app wide table change event.
3016 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3017 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3018 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3019 Activity mappers for the main activities replace the deleted app-wide
3021 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3022 Fix a spelling error in he comment.
3023 * src/main/java/org/glom/web/client/ui/ListView.java:
3024 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3025 Renamed from LayoutListView and modified for MVP. This still not a
3026 proper dumb view as prescribed by the MVP pattern but it works for now.
3027 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3028 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3029 New widget stripped out of the deleted OnlineGlomView.
3030 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3031 Remove hack that is fixed by this patch.
3033 2011-05-06 Ben Konrath <ben@bagu.org>
3035 Rename OnlineGlomPlace to ListPlace.
3037 The only change besides the rename is that url will now display #list
3038 instead of #Document.
3040 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3041 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3042 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3043 * src/main/java/org/glom/web/client/place/ListPlace.java:
3044 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3046 2011-05-06 Ben Konrath <ben@bagu.org>
3048 Use Presenter for app navigation.
3050 This is the proper way to deal with Place (URL) changes with the MVP
3053 * src/main/java/org/glom/web/client/ClientFactory.java:
3054 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3055 PlaceHistoryMapper and PlaceHistoryHandler.
3056 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3057 PlaceHistoryMapper and PlaceHistoryHandler.
3058 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3059 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3060 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3061 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3062 Add Presenter interface and setPresenter methods. Rename addHyperLink
3063 to addDocumentLink taking only the document title as a parameter.
3065 2011-04-14 Ben Konrath <ben@bagu.org>
3067 Prompt for db username/password if they haven't been set.
3069 This is implemented with a popup widget that is contained within the
3070 OnlineGlomView and managed by the OnlineGlomActivity.
3072 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3073 methods for checking and setting the database username and password.
3074 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3075 new methods for checking and setting the database username and
3077 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3078 Display authentication popup if the JDBC connection to the database
3079 has not been authenticated.
3080 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3082 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3083 for dealing with the authentication popup.
3084 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3085 Implement the methods for dealing with the authentication popup.
3086 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3087 try to executed queries if the database connection hasn't been
3088 authenticated. Implement methods for checking and setting the
3089 database username and password.
3091 2011-04-12 Ben Konrath <ben@bagu.org>
3093 Make log messages a little clearer.
3095 Add a dash betweeen the document title and the table name.
3097 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3099 2011-04-12 Ben Konrath <ben@bagu.org>
3101 Protect against NPEs when cleaning up database resources.
3103 While this isn't strictly necessary because the exception is caught,
3104 not protecting against the NPEs makes it harder to find the real error
3107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3109 2011-04-12 Ben Konrath <ben@bagu.org>
3111 Move configuration of the servlet to the constructor.
3113 The servlet will be initialized even if the database authentication
3114 information is not set or correct. I still need to add the UI for prompting
3115 the user for the authentication information when it's required.
3117 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3118 javadocs for getDocumentTitles() method.
3119 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3120 Set error message when RPC fails.
3121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3122 glom files directory from the configuration file. Try to set the
3123 database authentication information for the specific document if it's
3124 set and works otherwise try to use the global authentication
3125 information set for the directory.
3126 * src/main/resources/onlineglom.properties: Moved from
3127 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3128 Added detailed comments for the new keys.
3130 2011-04-11 Ben Konrath <ben@bagu.org>
3132 Remove unnecessary @Override in DocumentSelectionViewImpl.
3134 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3136 2011-04-11 Ben Konrath <ben@bagu.org>
3138 Remove center alignment in DocumentSelectionView.
3140 The title element is still centred but the document titles and bottom
3141 sentence are both left-aligned.
3143 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3145 2011-04-11 Ben Konrath <ben@bagu.org>
3147 Change 'Demo' naming convention to 'Document'.
3149 This is just a rename refactor with no functional changes to the code.
3151 * src/main/java/org/glom/web/client/ClientFactory.java:
3152 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3153 * src/main/java/org/glom/web/client/OnlineGlom.java:
3154 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3155 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3156 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3157 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3158 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3159 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3160 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3161 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3162 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3165 2011-04-08 Ben Konrath <ben@bagu.org>
3167 Remove FIXME from safeLongToInt() method.
3169 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3172 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3174 2011-04-08 Ben Konrath <ben@bagu.org>
3176 Display an error if no glom documents are found in the specified directory.
3178 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3179 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3180 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3181 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3183 2011-04-08 Ben Konrath <ben@bagu.org>
3185 Add copyright header to one more file ... oops.
3187 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3189 2011-04-08 Ben Konrath <ben@bagu.org>
3191 Add copyright header to files without it.
3193 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3194 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3195 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3196 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3197 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3198 * src/main/java/org/glom/web/shared/GlomField.java:
3200 2011-04-08 Ben Konrath <ben@bagu.org>
3202 Add support for accessing multiple glom documents in the servlet.
3204 This completes the demo selection functionality.
3206 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3207 document title to methods.
3208 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3209 document title to methods.
3210 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3211 Set browser window title when the activity starts. Correct name of
3212 document title variable.
3213 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3214 Set browser window title when the activity starts. Set the table
3215 selector change handler after table selector has been set. Clear the
3216 OnlineGlomView when the activity has been stopped.
3217 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3218 document title as the place token. Use "#Document:" instead of
3219 "#OnlineGlomPlace:" in the URL.
3220 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3221 Change heading to "Online Glom"
3222 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3223 document title in RPC methods.
3224 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3225 setDocumentTitle() method. Add clear() method.
3226 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3227 setDocumentTitle() method. Implement clear() method which removes the
3228 change handler on the ListBox, clears the ListBox and clears the