1 2012-05-04 Murray Cumming <murrayc@murrayc.com>
3 ConfiguredDocument: Cache the cloned and stripped layouts.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
6 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
7 layout in a map, so we can retrieve it again without rebuilding it.
9 2012-05-04 Murray Cumming <murrayc@murrayc.com>
11 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
13 2012-05-04 Murray Cumming <murrayc@murrayc.com>
15 libglom classes: Implement some auto-generated emthods.
17 2012-05-04 Murray Cumming <murrayc@murrayc.com>
19 Add GwtTestOnlineGlomService.
21 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
22 However, this (and the other GwtTest*) does not seem to run during
25 2012-05-04 Murray Cumming <murrayc@murrayc.com>
27 Remove use of unsupported features from client code.
29 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
30 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
31 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
32 Use our client version of StringUtils instead of the apache commons one.
34 However, the GWT Javascript compliation still fails.
36 2012-04-25 Murray Cumming <murrayc@murrayc.com>
38 Add a Field class and implement some loading of it in Document.
40 2012-04-25 Murray Cumming <murrayc@murrayc.com>
42 Initial Document loading implementation, instead of libglom.
44 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
45 and Translatable classes, and adapt the rest of the code to use them.
46 However, this is still missing Layout and Field classes and loading.
48 2012-04-24 Murray Cumming <murrayc@murrayc.com>
50 Use of jOOQ: Move Field creation into a utility method.
52 * src/main/java/org/glom/web/server/SqlUtils.java:
53 This lets us improve it more easily.
55 2012-04-24 Murray Cumming <murrayc@murrayc.com>
57 Use of jOOQ: Improve the code to COUNT a sub-select.
59 * src/main/java/org/glom/web/server/SqlUtils.java:
60 Move initial query creation into
61 build_sql_select_step_with_where_clause().
62 build_sql_select_count_rows(): Use the jOOQ API instead of
63 concatentating text, because a jOOQ Select*Step is a TableLike,
64 which is what from() takes.
66 2012-04-23 Murray Cumming <murrayc@murrayc.com>
68 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
70 * pom.xml: Depend on jooq.
71 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
72 methods with jOOQ, based on the C++ implementations in libglom,
73 with some changes to the logic required by jooQ.
74 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
76 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
77 * src/main/java/org/glom/web/server/ReportGenerator.java:
78 * src/main/java/org/glom/web/server/SqlUtils.java:
79 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
80 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
81 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
82 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
83 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
84 Adapt. In particular, the SqlUtils methods now need to take a Connection,
85 because jOOQ needs that, though it seems unnecessary.
87 This is not quite finished. Ideally jOOQ would help us to build
88 table_name.field_name names, quoting and escaping them properly.
89 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
91 2012-04-21 Murray Cumming <murrayc@murrayc.com>
93 Move use of Glom.build_sql*() into a new SqlUtils class.
95 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
96 to wrap Glom.build_sql*(). The parameter types are still Glom one,
97 but this will make it easier to start using something other than
98 libglom or SqlBuilder.
100 2012-04-21 Murray Cumming <murrayc@murrayc.com>
102 Update the project URL.
104 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
106 2012-04-21 Murray Cumming <murrayc@murrayc.com>
108 Main layout: Use a FlowTable instead of absolute positioning.
110 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
111 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
112 child panels/widgets must have an absolute position. But that is annoying, so
113 this adds a FlowTable and puts the child panels in there.
115 2012-04-21 Murray Cumming <murrayc@murrayc.com>
117 GwtTestOnlineGlom: Comment out unused code.
119 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
120 Eclipse has started to say that some code is unused.
122 2012-04-21 Murray Cumming <murrayc@murrayc.com>
124 Update to the latest versions of dependencies.
126 * pom.xml: Update version numbers of dependencies to the latest
128 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
130 * src/main/java/org/glom/web/server/ReportGenerator.java:
131 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
132 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
133 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
135 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
136 Modify the imports where necessary.
138 2012-04-17 Murray Cumming <murrayc@murrayc.com>
140 Style: Remove overflow:hidden from searchbox
142 * src/main/webapp/style.css: Because this pushes the Back To Link
143 label/link on to the next row, which is then hidden due to the
144 hard-coded (in ems) height.
146 2012-04-20 Murray Cumming <murrayc@murrayc.com>
148 Remove some duplicate code.
150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
151 getDocumentInfo(): This must have been duplicated during the merge from the
156 2012-04-19 Murray Cumming <murrayc@murrayc.com>
158 Reports: Localize the waiting for report message.
160 * src/main/java/org/glom/web/client/activity/ReportActivity.java
161 start(): Get the message from the contants.
162 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
164 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
165 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
166 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
167 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
168 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
169 Update these files with the English text for newer strings for now.
171 2012-04-19 Murray Cumming <murrayc@murrayc.com>
173 Reports: Show a message while waiting for the report.
175 * src/main/java/org/glom/web/client/ui/ReportView.java
176 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
177 Add setWaitingText(), to show a message saying that we are
178 waiting for the report to be ready.
179 * src/main/java/org/glom/web/client/activity/ReportActivity.java
180 start(): Call setWaitingText() before calling the async
183 2012-04-19 Murray Cumming <murrayc@murrayc.com>
185 ReportGenerator: Specify date and time formats.
187 * src/main/java/org/glom/web/server/ReportGenerator.java:
188 createFieldValueElement(): Use the default (and localized)
189 short formats, though we still need a way to show 4-digit
190 years without providing the format for every locale.
191 * src/main/java/org/glom/web/server/database/DBAccess.java:
192 convertResultSetToDTO(): Use the short formats here too.
194 2012-04-18 Murray Cumming <murrayc@murrayc.com>
196 ReportGenerator: Use the correct numeric formatting.
198 * src/main/java/org/glom/web/server/ReportGenerator.java
199 createFieldExpression(), createFieldValueElement(): Take the
200 whole LayoutItem_Field instead of just the field name, so
201 we have access to the formatting.
202 createFieldValueElement(): Use JRTextField.setPattern() to
203 specify the numeric formatting, with the help of a
204 regular DecimalFormat.
206 2012-04-18 Murray Cumming <murrayc@murrayc.com>
208 ReportGenerator: Avoid showing null for group by titles.
210 * src/main/java/org/glom/web/server/ReportGenerator.java
211 generateReport(): Use setBlankWhenNull() on the field title
212 style too, because this is used for values in group by
215 2012-04-18 Murray Cumming <murrayc@murrayc.com>
217 ReportGenerator: Add a colon to titles in vertical groups.
219 * src/main/java/org/glom/web/server/ReportGenerator.java
220 addFieldToDetailBandVertical(): Pass true for the withColon
223 2012-04-18 Murray Cumming <murrayc@murrayc.com>
225 ReportGenerator: Simplify the code by using Position more.
227 2012-04-18 Murray Cumming <murrayc@murrayc.com>
229 Reports: Support vertical groups, roughly.
231 * src/main/java/org/glom/web/server/ReportGenerator.java:
232 addToReport(): Rename to addGroupToReport() and, if necessary,
233 call the new addVerticalGroupToReport() method.
234 createFieldValueElement(): Let the caller specify the Y position
237 2012-04-17 Murray Cumming <murrayc@murrayc.com>
239 Reports: Allow a second report to be shown.
241 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
242 clear(): Do not remove the HTML widget, which broke the whole layout.
244 2012-04-17 Murray Cumming <murrayc@murrayc.com>
246 Locales drop-down: Show that we use English by default.
248 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
249 fillView(): When we use English, just because that is the default, when
250 no locale is specified, show that in the Locales drop-down instead of
251 just showing the first item.
253 2012-04-17 Murray Cumming <murrayc@murrayc.com>
255 Unselect the Report/Locale/Table combo item when appropriate.
257 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
258 setPlace(): clear reportName if this is not a ReportPlace.
259 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
260 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
261 When the provided name is empty, unselect all items, so that none are
262 indicated. This uses a for loop because I cannot find a single method
265 2012-04-17 Murray Cumming <murrayc@murrayc.com>
267 Report: Give the user a way to get back to the list.
269 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
270 start(), setPlace(): Show the Back To List link on reports, and also
271 interpret selecting the empty report item as back to list.
273 2012-04-13 Murray Cumming <murrayc@murrayc.com>
275 Really show the selected Report name.
277 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
278 setPlace(): Store the reportName here, if it is that kind of Place.
279 fillView(): Set the selected Report after filling the list of reports.
280 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
281 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
282 null Strings, though we need some way to unselect all ListBox items
285 2012-04-13 Murray Cumming <murrayc@murrayc.com>
287 ReportGenerator: Try to avoid some problems.
289 * src/main/java/org/glom/web/server/ReportGenerator.java
290 addField(): Try to avoid duplicates, and avoid using a null
293 2012-04-13 Murray Cumming <murrayc@murrayc.com>
295 Reports: Use quickFind.
297 * src/main/java/org/glom/web/client/OnlineGlomService.java;
298 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
299 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
300 getReportHTML(): Add a quickFind parameter.
301 * src/main/java/org/glom/web/client/activity/ReportActivity.java
302 start(): Pass the quickFind parameter.
303 * src/main/java/org/glom/web/server/ReportGenerator.java
304 generateReport(): Take a quickFind parameter.
306 2012-04-13 Murray Cumming <murrayc@murrayc.com>
308 ReportPlace: Actually use the report name.
310 * src/main/java/org/glom/web/client/place/ReportPlace.java
311 getPlace(): Do not assign the report name to the quickfind.
313 2012-04-13 Murray Cumming <murrayc@murrayc.com>
315 Show java.library.path when complaining.
317 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
318 init(): When telling us to check java.library.path, show the
321 2012-03-06 Murray Cumming <murrayc@murrayc.com>
323 ReportGenerator: Do not show nulls.
325 2012-03-06 Murray Cumming <murrayc@murrayc.com>
327 ReportGenerator: Make the title font larger.
329 2012-03-06 Murray Cumming <murrayc@murrayc.com>
331 ReportGenerator: Put field titles inside groups, if there are groups.
333 2012-03-06 Murray Cumming <murrayc@murrayc.com>
335 ReportGenerator: Take the Report itself instead of the name and group.
337 * src/main/java/org/glom/web/server/ConfiguredDocument.java
338 Remove getReportLayoutGroup().
339 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
340 getReportHTML(): Pass the report instead
341 of its name and layout group.
342 * src/main/java/org/glom/web/server/ReportGenerator.java
343 generateReport(): Use the report object to use the title
346 2012-03-06 Murray Cumming <murrayc@murrayc.com>
348 ReportGenerator: Remove designBand parameters.
350 * src/main/java/org/glom/web/server/ReportGenerator.java:
351 Make designBand a class member instead of passing it to all
354 2012-03-06 Murray Cumming <murrayc@murrayc.com>
356 ReportGenerator: Add lines, a bit like in the desktop version.
358 * src/main/java/org/glom/web/server/ReportGenerator.java
359 addToReport(): Use JRDesignLine.
361 2012-03-06 Murray Cumming <murrayc@murrayc.com>
363 ReportGenerator: Correct the title positions and use some bold style.
365 * src/main/java/org/glom/web/server/ReportGenerator.java:
366 Break the code up into reusable functions, correct the placement of
367 titles, and use normal/bold styles as in the reports in the desktop
370 2012-03-06 Murray Cumming <murrayc@murrayc.com>
372 ReportGenerator: Add a header band to show the field titles.
374 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
375 getReportHTML(): Pass the localeId to the ReportGenerator
377 * src/main/java/org/glom/web/server/ReportGenerator.java
378 constructor: Take the localeID so we can get translated field
380 generateReport(), addToReport(), addFieldToBand(): Add field
381 titles in a column header band.
383 2012-03-05 Murray Cumming <murrayc@murrayc.com>
385 Reports drop-down list: Some improvement.
387 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
388 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
389 Adedd setSelectedReport(),
390 setReportList(): Add a blank line so that the user can select the
392 * src/main/java/org/glom/web/client/activity/ReportActivity.java
393 start(): Show the current report by calling setSelectedReport().
394 This does not seem to work yet.
396 2012-03-05 Murray Cumming <murrayc@murrayc.com>
398 DetailsActivity, ListActivity: Move some variables into a base class.
400 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
401 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
402 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
403 the clientFactory, documentID, tableName and authenticationPopup into
404 a base class, to avoid duplication.
406 2012-03-05 Murray Cumming <murrayc@murrayc.com>
408 Translate the Reports label.
410 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
411 Get the "Reports" label string from the constants.
412 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
413 perties: Add Reports to the constants.
415 2012-03-05 Murray Cumming <murrayc@murrayc.com>
417 Reports: Implement grouping.
419 * src/main/java/org/glom/web/server/ReportGenerator.java:
420 Handle LayoutItem_GroupBy items and try to do the right thing
421 with JRDesignGroup. It seems to work.
423 2012-03-04 Murray Cumming <murrayc@murrayc.com>
425 Actually show some data with JasperReports.
427 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
428 getReportHTML(): Move most code into a ReportGenerator class.
429 * src/main/java/org/glom/web/server/ReportGenerator.java:
430 Recurse into sub-groups, adding fields to the JasperDesign's details
431 band. Note that we must set an arbitrary width and height, or it just
432 will not show any data.
434 2012-03-04 Murray Cumming <murrayc@murrayc.com>
436 Reports Chooser: Show the titles, not the names.
438 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
439 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
440 and the names as the values.
441 * src/main/java/org/glom/web/server/ConfiguredDocument.java
442 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
443 group now that we provide the report name, so it should always
446 2012-02-15 Murray Cumming <murrayc@murrayc.com>
448 Depend on jasperreports.
450 * pom.xml: Add the dependency. My plan is to use this on the
453 2012-01-31 Murray Cumming <murrayc@murrayc.com>
455 Implement navigation to report places.
457 * src/main/java/org/glom/web/client/activity/ReportActivity.java
458 start(): Do not bother to handle all events here.
459 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
460 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
461 Added getSelectedReport().
462 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
463 .java: start(): When handling a change to the reports chooser,
464 call getSelectedReport() and goTo() its ReportPlace.
465 * src/main/java/org/glom/web/client/ui/ReportView.java
466 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
467 Added setReportHTML() which puts the html in a gwt HTML widget.
468 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
469 getReportHTML(): Return "TODO" just to show that this works.
471 2012-01-31 Murray Cumming <murrayc@murrayc.com>
473 Make ReportPlace usable.
475 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
477 * src/main/java/org/glom/web/client/place/ReportPlace.java:
478 Correct the @prefix annotation.
480 2012-01-31 Murray Cumming <murrayc@murrayc.com>
482 OnlineGlomService: Return report HTML rather than the LayoutGroup.
484 * src/main/java/org/glom/web/client/OnlineGlomService.java:
485 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
486 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
487 Change getReportLayout() to getReportHMTL() because we will not need to
488 parse or render the report layout on the client side.
489 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
490 getReportLayout(): Return the libglom LayoutGroup type because we will
491 not need to convert to a shared type, because this will not be used on
493 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
496 Note that there is still no implementation for this.
499 2012-01-27 Murray Cumming <murrayc@murrayc.com>
501 Add a (empty) Report Place, View, and Activity.
503 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
505 * src/main/java/org/glom/web/client/place/HasTablePlace.java
506 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
507 this into a superclass:
508 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
509 and also use it as the base of this new ReportPlace:
510 * src/main/java/org/glom/web/client/place/ReportPlace.java
512 * src/main/java/org/glom/web/client/ui/ReportView.java
513 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
514 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
515 Add these, containing mostly boiler-plate for now.
517 * src/main/java/org/glom/web/client/OnlineGlomService.java
518 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
519 * src/main/java/org/glom/web/server/ConfiguredDocument.java
520 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
521 Add API to get the LayoutGroup for the report.
523 2012-01-23 Murray Cumming <murrayc@murrayc.com>
525 Add and fill a Reports drop-down list box.
527 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
529 * src/main/java/org/glom/web/client/OnlineGlomService.java:
530 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
531 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
532 Added getReports(document, table, localeID), calling
533 ConfiguredDocument.getReports().
534 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
535 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
536 Added setReportsList() and a list widget.
537 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
538 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
543 2012-04-12 Murray Cumming <murrayc@murrayc.com>
545 Translations: Add Esperanto.
547 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
548 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
549 properties: Add this translation because someone took the time to make it.
551 2012-03-15 Murray Cumming <murrayc@murrayc.com>
553 Adapt to the java-libglom 1.21.7 API.
555 * src/main/java/org/glom/web/server/ReportGenerator.java:
556 addToReport(): get_group_secondary_fields() is now
557 get_secondary_fields().
560 2012-03-15 Murray Cumming <murrayc@murrayc.com>
562 Use the latest java-libglom version.
564 * pom.xml: Use java-libglom 1.21.7.
566 2012-03-03 Ben Konrath <ben@bagu.org>
568 Display date and time in details view.
570 https://bugzilla.gnome.org/show_bug.cgi?id=671257
572 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
574 2012-03-05 Murray Cumming <murrayc@murrayc.com>
576 Require the latest java-libglom.
578 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
580 2012-03-04 Murray Cumming <murrayc@murrayc.com>
582 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
584 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
585 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
586 an empty quickfind string. I also corrected libglom to create only
587 empty where clauses for empty quickfind strings, but this avoids the
590 2012-02-24 Ben Konrath <ben@bagu.org>
592 Improve the tabs in the Notebook widget.
596 2012-01-30 Murray Cumming <murrayc@murrayc.com>
598 Translations: Try to translate the strings.
600 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
601 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
602 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
603 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
604 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
605 Take the Open translation from GTK+'s .po files.
606 Take the Details translation from Glom's po files.
607 I have added the other strings to Glom so we can get translations that way:
608 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
610 2012-01-27 Murray Cumming <murrayc@murrayc.com>
612 TableSelectionViewImpl: Put the search label and entry in a div.
614 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
615 Put the search widgets in a FlowTable so that the CSS can be used to
616 style them while keeping them together.
617 * src/main/webapp/style.css: Mention the new div.
619 2012-01-27 Murray Cumming <murrayc@murrayc.com>
621 Translate more strings in more locales.
623 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
624 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
625 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
626 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
627 Translate the "Details" and "Open" string too.
629 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
630 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
631 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
632 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
633 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
634 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
635 Add these new locales as placeholders though they currently contain English.
637 2012-01-27 Murray Cumming <murrayc@murrayc.com>
639 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
641 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
642 Check the ConfiguredDocument* for null before using it.
644 2012-01-26 Murray Cumming <murrayc@murrayc.com>
646 Tell Eclipse about the generated java files.
648 * .classpath: This lets it find OnlineGlomConstants.java.
649 It would be nice if Eclipse just used the maven build files.
651 2012-01-26 Murray Cumming <murrayc@murrayc.com>
653 Prevent a crash when no locale is specified in the URL.
655 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
656 Avoid returning a null string, obtained from
657 Window.Location.getParameter(). This caused a crash when it was
658 later passed to libglom's API.
659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
660 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
661 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
662 guard against future null strings.
664 2012-01-26 Murray Cumming <murrayc@murrayc.com>
666 Use the ?locale= query param instead of the &lang= token param.
668 * src/main/java/org/glom/web/client/place/ListPlace.java
669 * src/main/java/org/glom/web/client/place/DetailsPlace.java
670 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
671 Remove the lang token key and value.
673 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
674 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
675 When the user selects a different locale from the chooser, use
676 Window.Location.assign() to change the URL, which then causes a reload.
678 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
679 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
680 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
681 * src/main/java/org/glom/web/client/activity/ListActivity.java
682 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
683 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
684 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
685 * src/main/java/org/glom/web/client/ui/ListView.java:
686 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
688 Remove localeID member variables and method/constructor parameters, instead
689 using Utils.getCurrentLocaleID() when we need a localID to pass to
692 2012-01-26 Murray Cumming <murrayc@murrayc.com>
694 Internationalize the UI strings.
696 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
697 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
698 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
699 because it is unused. Messages are apparently strings that can have
700 parameters, but we do not need that yet, so Contants will be enough for now.
701 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
702 to say that we support the en and de locales.
703 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
704 The original English strings.
705 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
706 Some German translations of the English strings.
707 The i18n goal then uses the .properties file to generate an
708 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
709 returns an implementation that returns the translated strings.
710 The documentation suggests putting these in src/java/*/client/, but it seems
711 best to put it in src/resources/*/client/.
712 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
713 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
714 instead of hard-coding them.
715 Note that we cannot import OnlineGlomConstants because it does not exist yet,
716 but that does not seem to stop the build, though it confuses Eclipse.
718 You can see the translated string by adding ?locale=de to the URL, like so:
719 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
721 2012-01-24 Murray Cumming <murrayc@murrayc.com>
723 Improve null/empty String checks.
725 * pom.xml: Add a dependency on commons-lang, to use
726 org.apache.commons.lang.StringUtils.
727 * src/main/java/org/glom/web/server/ConfiguredDocument.java
728 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
729 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
730 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
731 Use StringUtils.isEmpty().
733 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
734 StringUtils class with a static isEmpty() function because we
735 cannot use org.apache.commons.lang.StringUtils in client-side
736 GWT code because it (apparently) cannot be compiled to javascript.
737 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
738 * src/main/java/org/glom/web/client/activity/ListActivity.java
739 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
740 * src/main/java/org/glom/web/client/place/DetailsPlace.java
741 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
742 * src/main/java/org/glom/web/client/place/ListPlace.java
743 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
744 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
745 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
746 * src/main/java/org/glom/web/client/ui/details/Group.java
747 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
748 our StringUtils.isEmpty() function.
750 2012-01-24 Murray Cumming <murrayc@murrayc.com>
752 Update to the latest java-libglom API.
754 * pom.xml: Require java-libglom 1.21.4.
755 * src/main/java/org/glom/web/server/ConfiguredDocument.java
756 getDocumentInfo(), getListViewLayoutGroup():
757 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
759 * src/main/java/org/glom/web/server/database/DBAccess.java
760 getFieldsToShowForSQLQueryAddGroup(),
761 getPrimaryKeyLayoutItemField(): Replace get_database_title()
762 with either get_database_title_original() or
763 get_database_title(localeID).
765 2012-01-24 Murray Cumming <murrayc@murrayc.com>
767 ConfiguredDocument: Avoid a null pointer exception.
769 * src/main/java/org/glom/web/server/ConfiguredDocument.java
770 Initialize localeID to "" to avoid returning a null String which
771 causes a crash in java-libglom's swing-generated code.
773 2012-01-23 Murray Cumming <murrayc@murrayc.com>
775 Some simple renaming.
777 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
778 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
779 for localeChooser. This seems more appropriate and is less ambiguous
780 particularly in the .css file.
782 2012-01-23 Murray Cumming <murrayc@murrayc.com>
784 ConfiguredDocument: Rename the localedID private member variable.
786 2012-01-23 Murray Cumming <murrayc@murrayc.com>
788 Adapt to the latest java-libglom API from git master.
790 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
791 libglom now uses only Vector instead of List, which uses add() instead of
794 2012-01-22 Murray Cumming <murrayc@murrayc.com>
796 ConfiguredDocument: Rename the localedID private member variable.
798 2012-01-20 Murray Cumming <murrayc@murrayc.com>
800 Build a source tarball with mvn assembly:single
802 * assembly.xml: Add this file.
803 * pom.xml: Use the maven-assembly-plugin and tell it to use
804 our assembly.xml file.
806 2012-01-19 Murray Cumming <murrayc@murrayc.com>
808 OnlineGlomServiceImpl: Get .glom files recursively.
810 * pom.xml: Depend on commons-io from org.apache.commons.
811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
812 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
813 files recursively, and with the easier filter for the extension.
814 Use org.apache.commons.io.FilenameUtils.removeExtension() to
815 simplify that code too.
817 2012-01-19 Murray Cumming <murrayc@murrayc.com>
819 README: Mention that you must install java-libglom packages separately.
821 But then it works, because java-libglom is now in the central maven
824 2012-01-18 Murray Cumming <murrayc@murrayc.com>
826 locales drop-down: Show the correct selected locale when the URL changes.
828 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
829 .java: setPlace(): Move some code into fillView().
831 2012-01-18 Murray Cumming <murrayc@murrayc.com>
833 locales drop-down: Do not lose the primary key.
835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
836 start(): onLocaleChange(): Pass the current primary key value,
837 instead of an empty value.
839 2012-01-18 Murray Cumming <murrayc@murrayc.com>
841 locales drop-down: Do not lose the drop-down selection.
843 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
844 .java (TableSelectionActivity.fillView): Set the selected locale
845 after changing the drop-down items (though we do not really need
846 to change them just because the locale changes.)
848 2012-01-18 Murray Cumming <murrayc@murrayc.com>
850 locales drop-down: Change the tables list when this changes.
852 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
853 .java: TableSelectionActivity.start(): Move the async table titles
854 retrieval into a private fillView() method and also call this when
855 the chosen locale changes.
856 Note that the document title is not actually translatable yet, but
857 that is a problem that I should fix soon in libglom.
859 2012-01-18 Murray Cumming <murrayc@murrayc.com>
861 Improve the placement of the locales drop-down.
863 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
864 Put the title and locales drop-down in a div (gwt.FlowTable).
865 * src/main/webapp/style.css: Add magic css properties to make this work.
866 Also remove the left margin from the title so that it lines up with the
869 2012-01-18 Murray Cumming <murrayc@murrayc.com>
871 locales selector: Show human-readable locale titles.
873 * src/main/java/org/glom/web/server/ConfiguredDocument.java
874 getDocumentInfo(): Use java.util.Locale to show a real title of
875 each locale, in the locale's own language.
877 2012-01-17 Murray Cumming <murrayc@murrayc.com>
879 Add a language/locale selector drop-down.
881 * src/main/java/org/glom/web/shared/DocumentInfo.java:
882 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
883 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
884 getDocumentInfo(): Store the available Locales in the DocumentInfo.
885 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
886 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
887 Add a ListBox to show the available locales. Add getLocaleSelector(),
888 setLocaleList(), getSelectedLocale(), setSelectedLocale().
889 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
890 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
891 java: Add these classes.
892 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
893 start(): Fill the locales ListBox. Handle its change event, firing a
895 setPlace(): Show the selected locale as specified by the URL token.
896 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
897 * src/main/java/org/glom/web/client/activity/ListActivity.java:
898 Handle LocaleChangeEvent, going to a new *Place with that locale.
900 The placement of the ListBox is not pretty, and it currently uses the ID
901 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
905 2012-01-17 Murray Cumming <murrayc@murrayc.com>
907 Search box: Show the search text from the URL token.
909 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
910 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
911 Add setQuickFindText().
912 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
913 .java: setPlace(): Store the queryText if the place is a ListPlace,
914 and call TableSelectionView.setQuickFindText().
916 2012-01-17 Murray Cumming <murrayc@murrayc.com>
918 Allow use of translations via, for instance, &lang=de in the URL.
920 * pom.xml: Use the unstable java-libglom 1.21 version.
922 * src/main/java/org/glom/web/client/OnlineGlomService.java:
923 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
924 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
925 init(): Instead of calling TranslatableItem.set_current_locale()
926 (now removed), call ConfiguredDocument.setDefaultLocaleID().
927 However, this is only for default locales, which are not needed to
928 change the locale in the URL.
929 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
930 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
931 getSortedRelatedListData(): Add a localeID parameter, so we can get the
932 layout for a particular locale.
933 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
934 Add get/setDefaultLocaleID().
935 getDocumentInfo(), getListViewData(), getRelatedListData(),
936 getDetailsLayoutGroup(), getListViewLayoutGroup(),
937 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
938 localeID parameter, so we can get the layout for a particular locale.
940 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
941 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
942 * src/main/java/org/glom/web/client/place/ListPlace.java:
943 Parse and construct a lang parameter too.
945 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
946 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
947 passed to subsequent methods and constructors.
948 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
949 * src/main/java/org/glom/web/client/activity/ListActivity.java:
950 Store the localeID from the *Place and pass it to other constructors
951 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
953 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
954 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
955 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
956 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
957 * src/main/java/org/glom/web/client/ui/ListView.java:
958 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
959 Take localeID parameters and pass them to subsequent constructors and
960 methods, so that the layout is always retrieved for that locale.
962 This is rather repetitive.
964 Note that "" means the original (default) locale of the Glom document,
965 which is usually English.
967 2012-01-17 Murray Cumming <murrayc@murrayc.com>
969 Documents: Remove final keyword to fix startup configuration.
971 * src/main/java/org/glom/web/shared/Documents.java: Remove the
972 final keywords on the private member variables because that breaks
973 the startup, apparently (there are warnings) because it stops them
974 from being serialized. I added these in the previous commit.
976 2012-01-13 Murray Cumming <murrayc@murrayc.com>
978 Documents: Add some final keywords.
980 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
983 2012-01-13 Murray Cumming <murrayc@murrayc.com>
985 OnlineGlomServiceImpl: Add to overview comments.
987 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
988 Note that this is where all the document are loaded. They are not
989 loaded freshly for each page.
991 2012-01-12 Murray Cumming <murrayc@murrayc.com>
995 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
996 Add a TextBox for the text of a quick find.
997 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
999 setBackLink(): Add a String quickFind parameter.
1000 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1001 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1002 to the base interface, because that is how TableSelectionViewImpl is used.
1003 * src/main/webapp/style.css: Add style for the search box and its label.
1005 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1006 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1007 Add these files, based on the existing TableChangeEvent and
1008 TableChangeEventHandlers.
1009 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1010 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1011 a ListPlace() that the user should be taken to.
1012 * src/main/java/org/glom/web/client/activity/ListActivity.java
1013 start(): Handle it here too and adapt the TableChangeEvent handler to
1014 pass the extra "" quickFind parameter to ListPlace.
1015 * src/main/java/org/glom/web/client/place/ListPlace.java:
1016 Constructor: Take an extra String quickFind parameter and store it,
1017 returning it from a new getQuickFind() method.
1018 getToken(): Put the quickFind text in the URL token.
1019 getPlace(): Parse the quickFind text from the URL token.
1020 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1021 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1022 ListPlace constructor.
1023 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1024 .java: start(): Add a Change handler for the TableSelectionView's
1025 TextBox (via its base HasChangeHandlers interface), firing the new
1026 QuickFindChangeEvent.
1027 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1028 pass the extra "" quickFind parameter.
1030 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1031 setCellTable(): Add a String quickFind parameter and pass it to
1032 the ListViewTable() constructor.
1033 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1034 setCellTable() in the base interface, because that is how ListViewImpl
1037 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1038 Add a String quickFind member variable.
1039 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1040 Constructor: Add a String quickFind parameter, storing it in the
1041 base ListTable's member variable.
1042 onRangeChanged(): Pass quickFind to the
1043 OnlineGlomServiceAsync.getSortedListViewData() and
1044 OnlineGlomServiceAsync.getListViewData() methods.
1046 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1047 getListViewData(), getSortedListViewData(): Add a String quickFind
1048 parameter, passing it to ConfiguredDocument.getListViewData().
1049 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1050 Change getListViewData(), getSortedListViewData() in the base interface,
1051 because that is how OnlineGlomServiceImpl is used, via this:
1052 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1053 Change getListViewData(), getSortedListViewData() here too.
1054 This class can apparently be used to asynchronously call methods on
1055 OnlineGlomService, and GWT seems to implement that after recognizing
1056 just the *Async name convention and the extra AsyncCallback parameters.
1058 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1059 getListViewData(): Add a String quickFind parameter, and pass it to
1060 ListViewDBAccess.getData().
1061 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1062 getListData(): Add a String quickFind parameter and pass it to
1064 getSelectQuery(): Add a String quickFind parameter.
1065 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1066 getSelectQuery(): Add a String quickFind parameter and use it with
1067 Glom.get_find_where_clause_quick() to pass a where_clause to
1068 Glom.build_sql_select_with_where_clause(), to actually filter the
1070 getData(): Add a String quickFind parameter, passing it to getListData().
1071 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1072 va: getData(): Pass an empty string to getListData() for the
1073 quickFind parameter.
1075 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1077 ListTable: Minor change.
1079 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1080 createCellTable(): Make this protected instead of public.
1082 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1084 Many files: Use final for the parameters and use the @override attribute.
1086 2012-01-22 Ben Konrath <ben@bagu.org>
1088 Add anchor links for single line text that starts with http, ftp and www.
1092 2012-01-22 Ben Konrath <ben@bagu.org>
1094 Add ellipsis to single line text in details view.
1098 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1100 Remove all javadoc author tags.
1102 Because they are awkward and meaningless when many people touch
1104 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1106 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1108 Revert the COPYING.LESSER to COPYING rename.
1110 Apparently both should be there if it is LGPL.
1112 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1114 *View: Remove unused imports.
1116 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1117 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1118 * src/main/java/org/glom/web/client/ui/ListView.java:
1119 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1120 Remove unused imports, as suggested by Eclipse.
1122 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1124 Move the *View::Presenter types, and some API into one base View.
1126 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1127 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1128 * src/main/java/org/glom/web/client/ui/ListView.java:
1129 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1130 Presenter, setPresenter() and clear() into a shared base interface,
1131 to avoid the unnecessary duplicate Presenter types and to more clearly
1132 show how the *Views share the same structure, even if they are not
1133 used polymorphically.
1135 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1136 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1138 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1139 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1140 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1142 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1145 Feel free to revert this if there is a good reason for the duplicate
1148 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1150 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1152 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1153 a class member instead of a local variable in the method.
1154 This lets us use it to get the view instances, for use in tests.
1155 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1156 beforeOnlineGlom(): Test some more details of the initial view.
1157 Again, this is not very useful.
1159 To really test gwt-glom we will need to start a local postgresql
1160 instance with local data, like the Glom tests in C++.
1162 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1164 pom.xml: Mention the LGPL license.
1166 * pom.xml: Add a licenses section.
1167 * COPYING.LESSER: Move this to COPYING, which
1168 previously contained the GPL. But gwt-glom is all LGPL.
1170 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1172 Add project information to README and pom.xml.
1174 * README: Add a brief description and mention some mvn
1176 * pom.xml: This extra information shows up in mvn site
1179 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1181 Use the latest java-libglom version.
1183 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1185 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1187 GwtTestOnlineGlom: Test a little more.
1189 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1190 protected rather than private, as suggested by the gwt-test-utils
1192 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1193 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1194 Test the initial visibility of the panels.
1196 However, this is not a very useful test.
1197 And I wonder how we should generally test using this idea for an
1198 activity/places app like ours where the real changes happen implicitly
1199 based on the history token/URL.
1201 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1203 Slight modification to *Mapper comments.
1205 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1206 (DataActivityMapper)
1207 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1209 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1211 Remove comments mentioning GIN because they are just copied from
1212 the example code and are apparently not helpful:
1213 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1214 Also change the mention of a class that is only in the example code.
1216 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1218 GwtTestOnlineGlom test: Minor changes.
1220 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1221 Avoid the long qualified class name and modify the comment
1222 because it is now obvious to me that the mocked class is the only
1223 custom one created via GWT.create().
1225 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1227 Tests: Added the beginnings of a test using gwt-test-utils.
1229 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1230 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1231 which tells gwt-test-utils what class will be tested.
1232 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1233 Add a simple (but empty) test case. One class, used by the OnlineGlom
1234 class, is mocked so that it can be created. However, I am not sure
1235 why only this class needs to be mocked.
1237 Note that mockito seems more popular, and clearer, than easymock,
1238 but I have not got that working yet. It might be a matter of the
1241 This test is run during mvn integration-test.
1243 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1245 Tests: Use junit4-style syntax instead of junit3-style.
1247 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1248 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1249 * src/test/java/org/glom/web/shared/DataItemTest.java:
1250 Use the @Test annotation rather than relying on the test*() prefix.
1251 Also no longer implement TestCase, to avoid triggering support for
1252 the junit3-way, which stops the annotations from working.
1253 Change the imports from import junit.framework.* to
1254 import org.junit.*, which is apparently the new way.
1256 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1258 Added a test for ListPlace token parsing and creation.
1260 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1261 This is much the same as DetailsPlaceTest.
1263 I wonder how we could test the other parts of the *Place API.
1265 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1267 DetailsPlace test: Also test getToken() and recreation via getPlace().
1269 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1270 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1271 recreate it, testing the recreated DetailsPlace for the same parameter
1274 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1276 Use the surefire-report plugin.
1278 * pom.xml: This generates a HTML report about the tests in
1279 target/site/surefire-report.html
1280 when you do mvn surefire-report:report. It seems to be popular/normal.
1282 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1284 Added a test for DetailsPlace.
1286 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1287 Test the getPlace() token parsing.
1289 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1291 Added a first unit test.
1293 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1294 * src/test/java/org/glom/web/shared/DataItemTest.java:
1295 This is a silly test but it is just to get things started. Note that
1296 maven/junit finds the test because it looks in src/test by default.
1298 2011-12-22 Ben Konrath <ben@bagu.org>
1300 Change charsetName to "UTF-8" when replacing line breaks.
1302 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1303 that work in Java (such as "UTF8") will not work when compiled to
1306 This fixes a problem with multi-line details view fields that have hard
1307 line breaks. The "License Text" field on this page demonstrates the
1310 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1312 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1314 2011-12-22 Ben Konrath <ben@bagu.org>
1316 Fix another bug with related list navigation.
1318 I've tested all the navigation buttons in all of the related lists
1319 so things should be good now.
1321 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1323 2011-12-22 Ben Konrath <ben@bagu.org>
1325 Fix a crasher when refreshing the list view with the default table.
1327 This crash will also happen when loading the list view with the default
1328 table from a link or bookmark.
1330 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1331 to the main document selection page when the document id hasn't been
1333 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1334 the main document selection page when the document id hasn't been
1336 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1337 values for the details place when the document id hasn't been set.
1338 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1339 values for the list place when the document id hasn't been set.
1341 2011-12-21 Ben Konrath <ben@bagu.org>
1343 Protect against NPE when glom.document.locale is not in config.
1345 This patch protects against an NPE when glom.document.locale is not in
1346 the config file. This NPE will also happen if glom.document.locale is
1349 The patch also updates the error message to display the class name when
1350 the getMessage() returns null. This was happening when the NPE was
1351 thrown and I had "Configuration Error: null". If an NPE is encountered
1352 with this patch, "Configuration Error: NullPointerException " will be
1355 This commit closes this bug:
1357 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1359 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1361 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1363 Rename onlineglom.properties to onlineglom.properties.sample.
1365 * src/main/resources/onlineglom.properties: Rename to:
1366 * src/main/resources/onlineglom.properties.sample:
1367 * src/main/resources/README: And add this file explaining that people
1368 should rename it back when deploying.
1370 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1372 Allow choosing the translation in the .properties file.
1374 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1375 init(): Read a glom.document.locale value from the configuration file
1376 and call Glom's TransatableItem::set_current_locale() method.
1377 * src/main/resources/onlineglom.properties: Add a commented-out
1378 example of this new setting.
1380 It would be better to add &lang=de_DE to the URL, but the current
1381 libglom API does not allow us to do this easily. I am working on that.
1383 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1385 Avoid a crash in parsing of token parameters.
1387 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1388 ava: getTokenParams(): Do not crash if a parameter has a key but no
1389 value, and ignore parameters with neither.
1391 2011-12-17 Murray Cumming <murrayc@murayc.com>
1393 History token building/handling: Improve use of token parameters.
1395 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1396 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1397 and buildParamsToken(HashMap), for use by derived classes.
1398 Make the separator private because it is no longer be needed.
1399 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1400 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1401 instead of manual string concatenation.
1402 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1403 of hardcoded indices and awkward splitting code.
1404 * src/main/java/org/glom/web/client/place/ListPlace.java
1405 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1406 instead of manual string concatenation.
1407 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1408 of hardcoded indices and awkward splitting code.
1409 This should fix bug #666420
1411 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1413 Fix a Navgiation->Navigation typo in the code.
1415 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1416 Rename processNavgiation() to processNavigation().
1418 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1420 Fix a seperator->separator typo in the code.
1422 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1423 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1424 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1427 2011-12-15 Ben Konrath <ben@bagu.org>
1429 Cleanup some comments.
1431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1433 2011-12-14 Ben Konrath <ben@bagu.org>
1435 Replace \n with <br/> for multiline text in the details view.
1437 Vertical scrollbars are added when needed as well.
1439 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1441 2011-12-14 Ben Konrath <ben@bagu.org>
1443 Specify the font for document selection links.
1445 * src/main/webapp/style.css:
1447 2011-12-14 Ben Konrath <ben@bagu.org>
1449 Fix bouncy CellTable while paging.
1451 This doesn't currently work with related list tables in unselected
1454 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1456 2011-12-14 Ben Konrath <ben@bagu.org>
1458 Revamp the appearance of the document selection page.
1460 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1461 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1462 * src/main/webapp/style.css:
1464 2011-12-13 Ben Konrath <ben@bagu.org>
1466 Set navigation button column to the smallest size possible.
1468 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1470 2011-12-13 Ben Konrath <ben@bagu.org>
1472 Change OpenButton nomenclature to NavigationButton.
1474 Using NavigtionButton makes things more generic. Classes, methods and
1475 variables have been changed.
1477 This is a rename-only refactor.
1479 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1480 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1481 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1482 Renamed from OpenButtonCell.
1483 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1484 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1485 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1487 2011-12-12 Ben Konrath <ben@bagu.org>
1489 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1491 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1492 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1493 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1494 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1496 2011-12-12 Ben Konrath <ben@bagu.org>
1498 Update variable names and comments.
1500 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1501 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1503 2011-12-12 Ben Konrath <ben@bagu.org>
1505 Properly initialize numNonEmptyRows variable to zero.
1507 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1508 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1510 2011-12-05 Ben Konrath <ben@bagu.org>
1512 Add latest mockup with HTML tables.
1514 Features of this mockup:
1516 -> HTML table for flowtable
1517 -> HTML table for flowtable column
1518 -> Example of how related lists would look
1519 -> Not using text entries for data items
1521 The current version of Online Glom doesn't use HTML tables for the
1524 This mockup has been sent to the glom-devel mailing list but it's good
1525 to have it here as well.
1527 * mockups/details-view-html-tables.html:
1529 2011-12-05 Ben Konrath <ben@bagu.org>
1531 Remove unnecessary getPrimaryKeyField() method.
1533 getPrimaryKeyFieldForTable(String) has been renamed to
1534 getPrimaryKeyField(String).
1536 * src/main/java/org/glom/web/server/database/DBAccess.java:
1537 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1538 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1540 2011-12-05 Ben Konrath <ben@bagu.org>
1542 Add string representation of TypedDataItem value to conversion error message.
1544 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1545 message was extracted into its own method to avoid duplication.
1547 2011-12-05 Ben Konrath <ben@bagu.org>
1549 Add type checking to navigation primary key value creation.
1551 Create navigation primary key only if the expected type from the Glom
1552 document matches the type returned by the SQL query.
1554 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1556 2011-12-05 Ben Konrath <ben@bagu.org>
1558 Rename a couple of variables in RelatedListNavigation.
1560 This is a rename-only refactor.
1562 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1564 2011-12-05 Ben Konrath <ben@bagu.org>
1566 Move getListLayoutGroup() into getListViewLayoutGroup().
1568 This removes getListLayoutGroup(). It was only being called by
1569 getListViewLayoutGroup().
1571 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1573 2011-12-05 Ben Konrath <ben@bagu.org>
1575 Remove check for LayoutItem_Portal in list table method.
1577 This check is no longer necessary because the method isn't being used
1578 to create the LayoutItemPortal DTO.
1580 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1582 2011-12-05 Ben Konrath <ben@bagu.org>
1584 Properly support related list navigation.
1586 Navigation from the "Repository Analyzer -> Package Scans ->
1587 Dependencies" related table wasn't working because the primary key for
1588 related tables wasn't being set properly. This commit fixes the
1591 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1592 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1593 doesn't set the primary key properly for related list tables.
1594 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1595 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1596 useful for getting the primary key for list view tables and for related
1598 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1599 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1600 Move code to set the primary key for the table from the abstract
1601 ListDBAccess class to ListViewDBAccess as it's only correct for list
1603 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1604 Properly add primary key to related list tables.
1606 2011-12-02 Ben Konrath <ben@bagu.org>
1608 Properly set the horizontal alignment of fields.
1610 This fix is for both the list tables and the details view.
1612 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1613 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1614 to set the horizontal alignment of fields.
1616 2011-12-02 Ben Konrath <ben@bagu.org>
1618 Display currency codes in the details view.
1620 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1622 2011-12-02 Ben Konrath <ben@bagu.org>
1624 Avoid duplicate JNI call.
1626 JNI is not as efficient as pure Java and this is an easy (and small)
1629 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1630 Use previously retrieved value for whereClauseToTableName instead of
1633 2011-12-02 Ben Konrath <ben@bagu.org>
1635 Rename a couple of variables in RelatedListNavigation.
1637 This is a rename-only refactor.
1639 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1641 2011-12-02 Ben Konrath <ben@bagu.org>
1643 Indicate clearly that a mismatched primary key type is a bug.
1645 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1646 warning to error. Add 'This is a bug.' to message.
1648 2011-12-02 Ben Konrath <ben@bagu.org>
1650 Update / fix some comments.
1652 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1654 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1656 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1657 Fix comments. Add some TODOs.
1659 2011-12-02 Ben Konrath <ben@bagu.org>
1661 Enable navigation to details view with string primary key from related list.
1663 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1664 Create a text primary key value when return type of result is
1665 java.sql.Types.VARCHAR.
1667 2011-12-02 Ben Konrath <ben@bagu.org>
1669 Use checkboxes for booleans in the details view.
1671 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1673 2011-12-01 Ben Konrath <ben@bagu.org>
1675 Improve performance of related list height calculation.
1677 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1678 Put code to calculate the expected height in a static initializer so
1679 that that it's only called once.
1681 2011-12-01 Ben Konrath <ben@bagu.org>
1683 Show related list tables in notebooks (again).
1685 Calculate the height of the related list tables so the Notebook can be
1686 set the correct height. The height of the related list table is also needed by
1687 FlowTable to be able decide how to create the layout.
1689 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1690 and set the Portal height based on the height of the related list
1691 table and the Portal container.
1692 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1693 Add method to calculate the height of the related list tables.
1694 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1695 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1696 calculate the height of the Pager widget.
1698 2011-12-01 Ben Konrath <ben@bagu.org>
1700 Use CellTable API for table property instead of setting style on Element.
1702 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1704 2011-12-01 Ben Konrath <ben@bagu.org>
1706 Make ListViewTable and RelatedListTable a consistent height.
1708 The tables are now a consistent height regardless of the contents of
1709 the table. A hidden button is added to empty rows to ensure that the
1710 height of these rows will match the height of rows with data.
1712 A navigation button column is now added to every table. The width of
1713 the navigation column is set to 0px when a RelatedListTable shouldn't
1714 have navigation buttons. This maintains the a consistent row height in
1715 tables that don't show the navigation buttons.
1717 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1718 navigation column when not needed.
1719 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1720 arguments for navigation button to constructor of ListViewTable.
1721 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1722 hidden button for empty data rows.
1723 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1724 arguments for navigation button to constructor.
1725 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1726 create navigation buttons. Add hideNavigationButtons() method.
1727 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1728 arguments for navigation button to constructor.
1730 2011-12-01 Ben Konrath <ben@bagu.org>
1732 Use 'visibility: hidden' in Utils.getWidgetHeight().
1734 This is better choice because hidden elements are invisible, don't
1735 respond to events and are not part of the tab order. They will,
1736 however, take up space which is required to be able to calculate the
1737 height of the widget.
1739 * src/main/java/org/glom/web/client/Utils.java:
1741 2011-12-01 Ben Konrath <ben@bagu.org>
1743 Use Utils.getWidgetHeight() in FlowTable.
1745 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1747 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1749 2011-12-01 Ben Konrath <ben@bagu.org>
1751 Put the details css class name on the correct table column.
1753 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1755 2011-11-30 Ben Konrath <ben@bagu.org>
1757 Update for java-libglom API change.
1759 The getters and setters on FieldFormatting and NumericFormat were
1760 changed to remove the 'M'.
1762 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1764 2011-11-29 Ben Konrath <ben@bagu.org>
1766 Only allow RelatedListTables in Portals.
1768 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1770 2011-11-29 Ben Konrath <ben@bagu.org>
1772 Only create a contents panel for Portals when title is being set.
1774 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1776 2011-11-29 Ben Konrath <ben@bagu.org>
1778 Set TabLayoutPanel height based on calculated height its widgets.
1780 This is a potential fix for this bug:
1782 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1784 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1786 2011-11-29 Ben Konrath <ben@bagu.org>
1788 Align details field labels and data with the Open buttons.
1790 * src/main/webapp/style.css:
1792 2011-11-29 Ben Konrath <ben@bagu.org>
1794 Remove unnecessary <div> in the Notebook widget.
1796 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1797 method to get container FlowPanel (<div>).
1798 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1799 initWidget() method directly on the TabLayoutPanel widget instead of
1800 Group's container widget.
1802 2011-11-29 Ben Konrath <ben@bagu.org>
1804 Don't add group titles for Portals in Notebooks.
1806 This reverts the previous patch and fixes a bug I introduced with
1807 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1809 * src/main/java/org/glom/web/client/ui/details/Group.java:
1810 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1812 2011-11-28 Ben Konrath <ben@bagu.org>
1814 Remove unused boolean argument in Portal constructor.
1816 Just a code cleanup.
1818 * src/main/java/org/glom/web/client/ui/details/Group.java:
1819 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1821 2011-11-28 Ben Konrath <ben@bagu.org>
1823 Remove hack for glom 1.18 style glom files.
1825 * src/main/java/org/glom/web/client/ui/details/Group.java:
1826 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1827 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1829 2011-11-28 Ben Konrath <ben@bagu.org>
1831 Use Gda Value version of primary key to log result too large error.
1833 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1835 2011-11-28 Ben Konrath <ben@bagu.org>
1837 Don't use TypedDataItem.getText() for Unknown types from the URL.
1839 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1840 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1841 instead of getText().
1842 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1843 String field and getUnknown() method.
1845 2011-11-28 Ben Konrath <ben@bagu.org>
1847 Log an error message when the java-libglom .so is not present.
1849 The error message was being set in the exception but not logged.
1851 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1853 2011-11-28 Ben Konrath <ben@bagu.org>
1855 Ignore LayoutItem_CalendarPortals.
1857 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1858 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1860 2011-11-28 Ben Konrath <ben@bagu.org>
1862 Extract method for creating the LayoutItemPortal DTO.
1864 Just breaking the code up into smaller chunks.
1866 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1868 2011-11-28 Ben Konrath <ben@bagu.org>
1872 This should have been added with the refactor. Oops!
1874 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1876 2011-11-28 Ben Konrath <ben@bagu.org>
1878 Create primary key value from URL string using type from Glom document.
1880 See this bug, comments 19 - 25:
1882 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1884 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1885 create a TypeDataItem for the primary key here when loading from a
1886 URL. Show the same string for the primary key value as was received
1887 from the URL string (when loading from a URL).
1888 * src/main/java/org/glom/web/server/Utils.java: Update method for
1889 creating the Gda Value from the TypeDataItem to properly deal with
1890 creating a Gda Value based on the Glom document type for the primary
1891 key value string when loading from a URL.
1892 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1893 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1894 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1895 Update for changed method name.
1897 2011-11-27 Ben Konrath <ben@bagu.org>
1899 Rename PrimaryKeyItem to TypedDataItem.
1901 The name PrimaryKeyItem suggests what the class should be used for.
1902 TypedDataItem is a neutral name that describes the class better.
1904 This is a rename-only refactor.
1906 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1907 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1908 * src/main/java/org/glom/web/client/Utils.java:
1909 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1910 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1911 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1912 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1913 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1914 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1915 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1916 * src/main/java/org/glom/web/server/Utils.java:
1917 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1918 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1919 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1920 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1922 2011-11-25 Ben Konrath <ben@bagu.org>
1924 Improve Gda Value conversion from PrimaryKeyItem.
1926 The value from the PrimaryKeyItem is only used if its type match the
1927 type from the glom document.
1929 * src/main/java/org/glom/web/server/Utils.java:
1931 2011-11-25 Ben Konrath <ben@bagu.org>
1933 Manually check if the java-liblgom .so is visible to the JVM.
1935 It seems that Tomcat has problems when a static initializer throws an
1936 exception. This check is done before the first method call into
1937 java-libglom so that execution doesn't continue if the .so is not
1940 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1942 2011-11-25 Ben Konrath <ben@bagu.org>
1944 Improve browser configuration error messages.
1948 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1950 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1951 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1952 getConfigurationErrorMessage() method.
1953 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1954 Get and display a specific configuration error message when no Glom
1955 documents are found.
1956 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1957 Implement getConfigurationErrorMessage() method. Surround configuration
1958 code in the init() method with a try/catch block. This allows the
1959 errors to be caught while keeping the servlet available to retrieve the
1960 configuration error message.
1962 2011-11-25 Ben Konrath <ben@bagu.org>
1964 Don't use Strings to hold primary key values.
1966 The primary key values are now held in a new data object
1967 (PrimaryKeyItem) that holds type information and the primary key value
1968 using the correct type.
1970 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1971 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1972 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1973 PrimaryKeyItem instead of String to hold the primary key value.
1974 * src/main/java/org/glom/web/client/Utils.java: Remove
1975 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1976 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1977 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1978 PrimaryKeyItem instead of String to hold the primary key value. Load
1979 document selection page when the documentID has not been set correctly.
1980 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1981 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1983 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1984 Return empty string for URL instead of "null".
1985 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1986 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1987 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1988 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1989 PrimaryKeyItem instead of String to hold primary key values.
1990 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1991 PrimaryKeyValue to a Gda Value.
1992 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1993 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1994 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1995 Replace temporary database access code that uses the PrimaryKeyValue to
1996 Gda Value conversion.
1997 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1998 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1999 PrimaryKeyItem instead of String.
2000 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2001 hold primary key values.
2003 2011-11-24 Ben Konrath <ben@bagu.org>
2005 Use newly added java-libglom API to create queries.
2007 This isn't finished. I still need to stop using Strings for primary key
2008 values in the client code.
2010 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2011 libglom to use fake connections so that retrieving the query string will
2013 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2014 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2015 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2016 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2017 Use the newly added libglom sql methods and classes to create the
2018 query. Add temporary hack to convert primary value strings to Gda
2021 2011-11-23 Ben Konrath <ben@bagu.org>
2023 Don't explicitly set the height of Portals.
2025 See comments 6 - 10 of this bug for details:
2027 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2029 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2031 2011-11-23 Ben Konrath <ben@bagu.org>
2033 Use an HTML table instead of CSS for the FlowTable layout.
2035 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2036 GWT's FlexTable to implement the FlowTable.
2037 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2039 2011-11-18 Ben Konrath <ben@bagu.org>
2041 Add boolean example to HTML table mockup.
2043 * mockups/details-view-html-tables-text-entries.html:
2045 2011-11-17 Ben Konrath <ben@bagu.org>
2047 Ensure the pager buttons are always visible for related lists.
2049 To accomplish this, I've turned off text wrapping in the list view and
2050 related list tables for both the header and data text. The related list
2051 table now has a fixed layout so the it doesn't overflow its container.
2052 This is required to ensure that the cell text is clipped when it
2053 overflows the cell and an ellipsis is added to the right side of the
2054 cell when text is clipped.
2056 A fixed table layout for the related list table in the details view
2057 seems what we want for the details view anyway, so the side-effect is
2060 The ellipsis will only be displayed in Firefox >= 7.
2064 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2066 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2067 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2068 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2070 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2071 Set the 'table-layout: fixed' CSS property to the related list table.
2072 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2073 'white-space: nowrap;' CSS property on both the list view and the
2074 related list tables.
2076 2011-11-16 Ben Konrath <ben@bagu.org>
2078 Rework the fix for empty notebook tab labels.
2080 Setting the empty group titles with its name caused problems for the
2081 details layout. Instead of using libglom's
2082 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2083 to the client when the title is empty. This allows the Notebook to use
2084 the name when the title is empty without affecting anything else.
2086 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2087 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2089 2011-11-16 Ben Konrath <ben@bagu.org>
2091 Set group titles with name when title is empty.
2093 This fixes a problem with an empty notebook tab label in the Lesson
2094 Planner document. The forth tab in the notebook should be "Internet":
2096 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2098 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2099 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2102 2011-11-16 Ben Konrath <ben@bagu.org>
2104 Remove whitespace from the configured username properties.
2106 This assumes that usernames won't have whitespace at the beginning
2107 or end. But I think this is a reasonable assumption.
2109 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2110 String.trim() to remove the whitespace from the username properties.
2112 2011-11-15 Ben Konrath <ben@bagu.org>
2114 Add details view mockup with HTML tables and text entries.
2116 This is from the attachment on this bug:
2118 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2120 * mockups/details-view-html-tables-text-entries.html:
2122 2011-11-15 Ben Konrath <ben@bagu.org>
2124 Add space between the columns of the flow table.
2128 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2130 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2131 space between columns in the flow table.
2133 2011-11-15 Ben Konrath <ben@bagu.org>
2135 Add backup files to the .gitignore.
2137 * .gitignore: Ignore files that end with ~.
2139 2011-11-09 Ben Konrath <ben@bagu.org>
2141 Use latest release of gwt-log.
2143 Gwt-log releases are now being submitted to the maven central
2144 repository so manual installation of the jar is no longer required.
2146 * pom.xml: Update version and groupId of gwt-log dependency.
2148 2011-10-31 Ben Konrath <ben@bagu.org>
2150 Don't use GWT numeric formatting to override the glom currency formatting.
2152 Currencies are now displayed like they are in Glom. See this bug:
2154 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2156 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2158 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2159 currency code to constructor and set it when the cell is rendered.
2160 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2161 currency code to the constructor of the NumericCell.
2163 2011-10-27 Ben Konrath <ben@bagu.org>
2165 Require the latest release of java-libglom (1.17.4).
2169 2011-10-26 Ben Konrath <ben@bagu.org>
2171 Add style to Notebook that matches current theme.
2173 It's not the best style in the world but it's better than the default.
2175 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2176 padding at the bottom of the child widgets.
2177 * src/main/webapp/style.css: Add style for the Notebook.
2179 2011-10-26 Ben Konrath <ben@bagu.org>
2181 Move servlet initialization code to overridden init method.
2183 This is half of the solution to getting proper error messages
2184 displayed when configuration errors occur. Here's the relevant bug:
2186 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2188 The rest of the solution involves surrounding the init method with a
2189 try/catch block and setting a global variable with the error /
2190 exception. A new async method should be created to retrieve and display
2191 the error message / exception.
2193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2194 code from constructor to init method adding exceptions as needed.
2196 2011-10-26 Ben Konrath <ben@bagu.org>
2198 Add script to monitor and restart tomcat if required.
2200 * utils/check-and-recover-tomcat.py: New file.
2202 2011-10-26 Ben Konrath <ben@bagu.org>
2204 Display the correct number of data items in the pager.
2208 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2210 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2211 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2212 The implementation is the same for both tables: Keep track of the
2213 number of non-empty rows and fire and RowCountChangeEvent after the data has
2215 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2216 custom Pager class that subclasses SimplePager to handle displaying
2217 the correct number when empty rows have been added.
2219 2011-10-26 Ben Konrath <ben@bagu.org>
2221 Correct error in previous commit.
2223 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2224 eventBus parameter from listView.setCellTable().
2226 2011-10-26 Ben Konrath <ben@bagu.org>
2228 Fix error in TODO comment.
2230 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2232 2011-10-24 Ben Konrath <ben@bagu.org>
2234 Create Notebook widgets to the details view.
2236 This isn't finished just yet - I still need to create a reasonable
2237 style to match the current theme.
2239 * src/main/java/org/glom/web/client/Utils.java: Add method for
2240 calculating the height of a widget. This is used in the Notebook class.
2241 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2242 new constructor method in Group.
2243 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2244 method for creating child widget that can be used by subclasses
2245 like Notebook. New constructor that allows disabling the group
2246 titles - Notebooks don't set a group title for their child groups.
2247 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2248 to make Notebooks using GWT's TabLayoutPanel.
2249 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2250 constructor that allows disabling the group titles.
2251 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2252 LayoutItemNotebook DTO.
2253 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2254 DTO for Notebooks. It's just an empty class for now but we might need
2255 it to transfer some specific information in the future.
2257 2011-10-21 Ben Konrath <ben@bagu.org>
2259 Add navigation buttons to related list tables.
2261 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2262 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2263 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2264 method getSuitableRecordToViewDetails() for getting the table name
2265 and primary key value for related list navigation buttons.
2266 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2267 private cell renderer class to get the navigation information for
2268 related list tables from the server. Extract the navigation
2269 processing code from the details cell navigation and use it for the
2270 related list navigation as well.
2271 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2272 cell renderer class for the details open buttons. This was needed
2273 because the related list navigation buttons and the list view
2274 navigation buttons need to react differently when clicked.
2275 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2276 the onEnterKeyDown() method because it's now overriden in the
2277 subclasses that are specific to the related list tables and the list
2279 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2280 the vertical size a little because the buttons add a bit of vertical
2281 space to table. This is not a perfect solution because the vertical
2282 size of with table fewer than 5 rows will be a little smaller.
2283 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2284 changes in how navigation buttons are handled.
2285 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2286 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2287 database access object.
2288 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2289 to find the portal for a given relationship name from
2290 RelatedListDBAccess. Add method to find a primary key field for a
2292 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2293 Move code to find the portal for a given relationship name to
2295 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2296 New file: database access object for getting the related list
2297 navigation information (the table name and the primary key value).
2298 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2299 DTO for transferring a table name to navigate to and a primary key
2301 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2302 boolean and getter/setter to specifies if the related list should add
2305 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2307 Use the master branch of java-libglom
2309 * pom.xml: Depend on java-libglom 1.19 instead.
2311 This is the master branch. See also the libglom-1-18 branch.
2313 2011-10-11 Ben Konrath <ben@bagu.org>
2315 Enable the open navigation button when the data has been set.
2317 This avoids having active buttons that don't do anything when the data
2320 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2322 2011-10-11 Ben Konrath <ben@bagu.org>
2324 Use IsWidget interface for FlowTableItem.
2326 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2327 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2329 2011-10-11 Ben Konrath <ben@bagu.org>
2331 Remove GWT styling from open button in details view.
2333 There are still some issues with how the details cell is arranged but
2334 this should be made to match Glom 1.20. I'm going to leave fixing this
2335 until I have Glom 1.20 up and running.
2337 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2338 style name on open button.
2339 * src/main/webapp/style.css: Move and edit details-navigation class.
2340 Re-arrange some classes to make them appear in the same order as the
2343 2011-10-07 Ben Konrath <ben@bagu.org>
2345 Update to GWT 2.4.0.
2347 * .gitignore: Ignore new cache directory.
2348 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2349 * pom.xml: Change GWT and maven plugin to 2.4.0.
2350 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2352 * src/main/java/org/glom/web/client/ClientFactory.java:
2353 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2354 * src/main/java/org/glom/web/client/OnlineGlom.java:
2355 Update source for API changes.
2356 * utils/build-onlineglom-war.sh: Remove cache directory before the
2359 2011-10-07 Ben Konrath <ben@bagu.org>
2361 Add navigation buttons in the details view.
2363 This isn't finished but I thought I'd commit what I have as it's a
2364 pretty good start. I still need to:
2366 1. Change the style so that it fits better into the current theme
2367 2. Adjust the details cell to expand as much as possible.
2369 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2370 click handlers to navigation buttons in the DetailsCells. Create a
2371 refreshData() method to get just the data from the server without the
2373 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2374 Update the tableSelector and browser title when the table name
2375 changes without using the tableSelector.
2376 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2377 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2378 getDetailsCells() to getCells(). Update variable names.
2379 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2380 method to set click handler on navigation button. Rename a few
2381 variables. Add navigation buttons where needed.
2382 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2383 variables and methods.
2384 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2385 navigation boolean and navigation table as required in the
2386 LayoutItemField DTO.
2387 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2388 variables for navigation along with getter/setter methods.
2390 2011-10-07 Ben Konrath <ben@bagu.org>
2392 Rename Field to DetailsCell.
2394 This is a refactor-only commit. No functionality has been added or
2397 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2398 Update variable and method names.
2399 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2400 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2401 variable and method names.
2402 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2404 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2405 variable and method names.
2407 2011-10-07 Ben Konrath <ben@bagu.org>
2409 Create separate methods for layout and data the details view.
2411 This is a refactor-only commit. No functionality has been added or
2414 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2415 private methods: setData(), createLayout().
2417 2011-10-07 Ben Konrath <ben@bagu.org>
2419 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2421 This is part of a change to get navigation buttons in the details view
2422 but it should have been done this way from the start.
2424 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2425 for method name change in TableSelectionView.
2426 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2427 Create TableChangeEvent and set the browser title using the
2428 TableSelectionView API.
2429 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2430 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2431 Change getSelectedTable() to getSelectedTableName(). Add
2432 getSelectedTableTitle().
2434 2011-10-07 Ben Konrath <ben@bagu.org>
2436 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2438 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2440 2011-10-07 Ben Konrath <ben@bagu.org>
2442 Update TableChangeEvent to use newTableName naming convention.
2444 This makes the class more consistent with GWT naming conventions.
2446 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2447 Update for method name change in TableChangeEvent.
2448 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2449 for method name change in TableChangeEvent.
2450 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2451 newTableName variable and getter method. Make toDebugString()
2454 2011-09-30 Ben Konrath <ben@bagu.org>
2456 Disable the pager in the list tables when the data row count is less than the minimum.
2458 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2459 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2461 2011-09-30 Ben Konrath <ben@bagu.org>
2463 Add empty rows to the end of related list and list view tables.
2465 I also extracted the cell rendering classes from the ListTable because
2466 the code was becoming a little crazy with all the anonymous inner
2467 classes. My plan is to use these cell rendering classes in the details
2468 view as well so this refactor will be needed for that change.
2470 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2471 set the row count in related list tables if the data has more rows
2472 than the minimum number of rows visible.
2473 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2474 row count in list view tables if the data has more rows than the
2475 minimum number of rows visible.
2476 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2477 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2479 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2480 for rendering TYPE_NUMERIC cells. The code was extracted from the
2482 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2483 class for rendering cells with buttons in list views. The code was
2484 extracted from the ListTable class.
2485 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2486 for rendering TYPE_TEXT cells. The code was extracted from the
2488 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2489 Add empty rows to the end of the data if required. Implement
2490 ListTable.getMinNumVisibleRows().
2491 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2492 cell renderer code to public classes. Return null in
2493 Column.getValue() for empty rows. Add new abstract method:
2494 getMinNumVisibleRows(). Move code to set the row count of the list view
2495 table to ListViewImpl.
2496 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2497 empty rows to the end of the data if required. Implement
2498 ListTable.getMinNumVisibleRows().
2501 2011-09-27 Ben Konrath <ben@bagu.org>
2503 Use GWT.log for client-side debugging statements.
2505 These are optimized out when deployed so I should have used this method
2506 in the first place. These statements will eventually be replaced with some sort
2507 of notification in the browser.
2509 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2510 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2511 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2512 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2513 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2515 2011-09-27 Ben Konrath <ben@bagu.org>
2517 Put tableselector on the right, back to list link on right.
2519 The idea is that the table selector is acting like a label for the
2520 currently displayed table so it should be placed below the document title. This
2521 puts the table title in a similar position to where it is in Glom.
2523 * mockups/details-contacts.html:
2524 * mockups/details-projects.html:
2525 * mockups/listview-contacts.html:
2526 * mockups/listview-projects.html:
2527 * mockups/style.css:
2528 Update mockups to match how the interfaces currently look.
2529 * src/main/webapp/style.css: Swap positions of backlink with the table
2530 selector. Add some space on the left side of the table selector to
2531 line things up with the document title.
2533 2011-09-27 Ben Konrath <ben@bagu.org>
2535 Add field colouring to details view.
2537 This change re-works how field colouring works. The colour formatting
2538 information is now set to the client with the layout information instead of
2539 with the data. This eliminates the need to send the same colour strings for
2540 data in list view column when colour information is set.
2542 In order to set an alternate colour for negative numeric values, the
2543 number is now sent to client and formatted with the GWT NumberFormat class.
2545 This change also fixes:
2547 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2549 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2550 internationalization framework which is needed for client side numeric
2552 * src/main/java/org/glom/web/client/Utils.java: New file for some
2553 client static utility methods.
2554 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2555 the DataItem object to the Field class. Use a utility method to
2556 create the foreignKeyValue string.
2557 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2558 alignment and text colours in the constructor. Add setData(DataItem)
2559 method. Remove setText(String) method.
2560 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2561 colour information to GlomTextCell. Create and use GlomNumberCell for
2562 rendering numbers. Use utility method to get the string for the
2563 primary key of the key provider. Re-work how the horizontal alignment
2565 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2566 formatting to layout information. Methods for converting the libglom
2567 formatting information were moved from DBAccess.
2568 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2569 numeric formatting (it's now done on the client side). Don't set text
2570 colours in DataItem. Move libglom formatting conversion methods to
2572 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2573 getters/setters for text colour information.
2574 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2575 for transferring the libglom NumericFormat information to the client.
2576 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2577 and getters/setters for: GlomNumericFormat, background colour and
2578 foreground colour strings.
2580 2011-09-26 Ben Konrath <ben@bagu.org>
2582 Simplify code that iterates through the LayoutGroup.
2584 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2586 2011-09-26 Ben Konrath <ben@bagu.org>
2588 Accept Eclipse formatting for OnlineGlomServiceAsync.
2590 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2592 2011-09-26 Ben Konrath <ben@bagu.org>
2594 Don't use the ListDBAccess classes to get the primary key layout information.
2596 This was causing a bug where the wrong index for the hidden primary key
2597 was being sent to the client.
2599 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2600 primary key while creating the LayoutGroup DTO. Create a
2601 LayoutItemField DTO for hidden primary keys. Don't use the
2602 RelatedListDBAccess because it was only used for getting the primary
2604 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2605 access modifier from public to protected for getPrimaryKeyField() and
2606 getPrimaryKeyLayoutItemField().
2607 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2608 abstract method getExpectedResultSize() because RelatedListDBAccess
2609 doesn't have enough info to implement it.
2610 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2611 Remove @Override for getExpectedResultSize().
2612 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2613 Remove method getExpectedResultSize().
2615 2011-09-23 Ben Konrath <ben@bagu.org>
2617 Log which layout (list or details) the ignored item is from.
2619 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2621 2011-09-23 Ben Konrath <ben@bagu.org>
2623 Remove annotations that turn off code formatting in DataItem.
2625 * src/main/java/org/glom/web/shared/DataItem.java:
2627 2011-09-23 Ben Konrath <ben@bagu.org>
2629 Rename GlomField to DataItem and update associated methods.
2631 This is a rename-only refactor. No functionality has been added or
2634 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2635 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2636 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2637 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2638 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2639 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2640 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2641 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2642 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2643 * src/main/java/org/glom/web/server/database/DBAccess.java:
2644 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2645 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2646 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2647 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2648 * src/main/java/org/glom/web/shared/DataItem.java:
2649 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2650 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2652 2011-09-23 Ben Konrath <ben@bagu.org>
2654 Rename GlomDocument to DocumentInfo and update associated methods.
2656 This is a rename-only refactor. No functionality has been added or
2659 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2660 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2661 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2662 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2663 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2664 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2665 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2667 2011-09-20 Ben Konrath <ben@bagu.org>
2669 Require java-libglom 1.17.3.
2671 This picks up the fix for the seg fault problem with the Scenes table
2672 in the Openismus Film Manager example.
2676 2011-09-20 Ben Konrath <ben@bagu.org>
2678 Change the way sort clause is added for primary key when no sort clause is requested.
2680 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2681 before the sort clause is created. When a sort clause is not requested, the
2682 sort clause is created by finding the primary key in the LayoutFieldVector
2685 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2687 2011-09-20 Ben Konrath <ben@bagu.org>
2689 Log error message if no documents are found in the configured directory.
2691 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2692 Extract the glom file extension string to a private static final class
2693 variable (mostly as syntactic sugar). Accept a minor formatting change.
2694 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2695 the example glom.document.directory configuration property to make it
2696 more clear that it can any directory, not just the home directory.
2698 2011-09-18 Ben Konrath <ben@bagu.org>
2700 Add related lists to details view.
2702 The related list table has support for paging and sorting just like the
2703 table in the list view.
2705 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2706 SQL queries for the related list tables.
2707 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2708 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2709 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2710 Rename getList methods to getListView and add comments. Remove
2711 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2712 it being unused. Add methods: getDetailsLayoutAndData(),
2713 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2714 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2715 Create the layout and set the data for the fields in one async call
2716 instead of two. Create related lists where appropriate.
2717 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2718 for method name changes in OnlineGlomService.
2719 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2720 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2721 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2723 * src/main/java/org/glom/web/client/ui/ListView.java:
2724 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2725 tableName from setCellTable(). Create a ListViewTable instead of
2727 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2728 represent a data field in the details view.
2729 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2730 from addDetailsCell() to Field class. Keep track of the Fields and
2731 Portals in the details view.
2732 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2733 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2734 and add a method to get it. Add method to set the contents of the
2736 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2737 New class for related list tables. This class has the data provider
2738 for the related list table.
2739 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2740 abstract class which is the base class for the ListViewTable and the
2742 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2743 New class for list view tables. This class has the data provider for
2744 the list view table.
2745 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2746 methods for related list tables. Add more information to the
2747 LayoutItemField and LayoutItemPortal DTOs.
2748 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2749 Remove debugging print statement.
2750 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2751 Remove debugging print statements. Add primary key field to SQL count
2753 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2754 Remove unnecessary LayoutFieldVector parameter from
2755 getResultSizeOfSQLQuery() method.
2756 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2757 New class for related list table database access.
2758 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2759 class that is a wrapper DTO for details view layout and data.
2760 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2761 new 'fromField' string to this DTO.
2762 * src/main/webapp/style.css: Remove bottom margin and override top
2765 2011-09-15 Ben Konrath <ben@bagu.org>
2767 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2769 This sets things up to make it easier to add the data retrieval for
2770 related lists (portals). No user noticeable changes were made with
2773 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2774 class has the code to retrieve the layouts and access the
2775 database using the new database helper classes.
2776 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2777 Most of the functionality has been removed from this class. This
2778 class now represents the public interface for the client side
2779 code. It also deals with configuring the servlet and cleaning
2780 things up when the servlet is stopped.
2781 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2782 of static methods into this utility class.
2783 * src/main/java/org/glom/web/server/database/DBAccess.java:
2784 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2785 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2786 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2787 These classes have the database retrieval code. The class hierarchy
2788 has been setup to make it easy to reuse code for similar
2791 2011-09-06 Ben Konrath <ben@bagu.org>
2793 Create separate classes for list table code and the data provider.
2795 As part of this refactor, I also split up the code a bit to make it
2798 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2799 table code to two new classes (below).
2800 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2801 with code from ListViewImpl.
2802 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2803 New file with code from ListViewImpl.
2805 2011-09-06 Ben Konrath <ben@bagu.org>
2807 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2809 This fixes the LayoutItemPortal DTO to match the libglom layout object
2812 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2814 2011-09-01 Ben Konrath <ben@bagu.org>
2816 Set title of Portals in the Details View.
2818 * pom.xml: Bump required version of java-libglom to 1.17.1.
2819 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2820 widget creation to its own class. Add comments to constructor.
2821 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2822 The code is mostly from the Group class with the title now set.
2823 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2824 title of Portal. Update some comments. Fix some code formatting.
2826 2011-09-01 Ben Konrath <ben@bagu.org>
2828 Remove TODO comment for the flow table column width.
2830 The flow table column width is working correctly and doesn't need to be
2831 changed. See this mailing list post for more info:
2833 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2835 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2837 2011-08-27 Ben Konrath <ben@bagu.org>
2839 Add document title (database name) to top of the browser page.
2841 I added the document title to the TableSelecitonView but that will
2842 change if / when we add a view that doesn't require table selection.
2844 * mockups/details-contacts.html:
2845 * mockups/details-projects.html:
2846 * mockups/listview-contacts.html:
2847 * mockups/listview-projects.html:
2848 * mockups/style.css: Add document title to mockups to keep things
2850 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2851 sizes to account for the document title.
2852 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2853 Set the document title when it has been retrieved from the server.
2854 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2855 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2856 and implement setDocumentTitle(String) method.
2857 * src/main/webapp/style.css: Add ID for document title style.
2859 2011-08-25 Ben Konrath <ben@bagu.org>
2861 Add NavigationType enum to LayoutItemPortal DTO.
2863 This is the start of adding support for Portals to the Details View.
2865 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2866 LayoutItem_Portal.navigation_type enum from libglom to
2867 LayoutItemPortal.NavigationType enum.
2868 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2869 NavigationType enum, field for storing the NavigationType and getter
2872 2011-08-25 Ben Konrath <ben@bagu.org>
2874 Implement the flow table layout in the Details View.
2876 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2877 FlowTable to Group to account for the renamed class.
2878 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2879 File. This is a container widget that implements the Glom details view
2880 flow table behaviour.
2881 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2882 org/glom/web/client/ui/FlowTable.java.
2883 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2884 so that the size of the subgroups are a closer match to the size of
2885 the Glom subgroups. This makes the flowtable layout match the layout
2886 in Glom for the Music Collection example file.
2888 2011-08-16 Ben Konrath <ben@bagu.org>
2890 Create container element for LayoutItemPortal in Details View.
2892 This will help me develop the layout for the FlowTable.
2894 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2895 fieldPanel variable to detailsCell.
2897 2011-08-15 Ben Konrath <ben@bagu.org>
2899 Set the height of the data element in the Details View.
2901 I changed the InlineLabels (text in a span element) to Labels (text in
2902 a div element) so that I could set the height of the details-data
2903 elements instead of the details-cell parent elements. This allows the
2904 the details-data element to display the correct height if style is
2905 applied that shows the height.
2907 This change has the added benefit of allowing the order of the labels
2908 and data elements to be changed for right-to-left languages.
2910 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2911 InlineLabels to Labels.
2912 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2913 InlineLabels to Labels. Set the height of the data element.
2914 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2915 multiline text height in the Formatting DTO.
2916 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2917 for multiline height along with getter and setter methods.
2918 * src/main/webapp/style.css: Adjust style to account for the change
2919 from span elements to div elements in the details cell.
2921 2011-08-15 Ben Konrath <ben@bagu.org>
2923 Make the List View appearance match the mockups.
2925 It doesn't match exactly but it's much better than it was.
2927 * mockups/listview-contacts.html: Remove unused css classes.
2928 * mockups/listview-projects.html: Remove unused css classes.
2929 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2930 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2931 for mainPanel instead of VerticalPanel (table). Set style name on
2932 CellTable. Set style name on Details column. Right-align Details
2934 * src/main/webapp/style.css: Adjust properties to match the mockups.
2936 2011-08-12 Ben Konrath <ben@bagu.org>
2938 Add better support for subgroups in the details view.
2940 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2941 changed FlowTable constructor.
2942 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2943 support for subgroups and subgroup-titles.
2944 * src/main/webapp/style.css: Add CSS class for subgroups and
2947 2011-08-12 Ben Konrath <ben@bagu.org>
2949 Return the top level LayoutGroup title.
2951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2953 2011-08-11 Ben Konrath <ben@bagu.org>
2955 Make the TableSelector header match the mockup.
2957 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2958 the layout panel. Properly lineup the table selection header with
2959 the list and details view.
2960 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2961 margin around the details view.
2962 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2963 Rename listBox variable to tableSelector. Set id for the style sheet.
2964 Use a FlowPanel instead of a HorizontalPanel.
2965 * src/main/webapp/style.css: Add properties to make the TableSelector
2966 box match the mockups.
2968 2011-07-13 Ben Konrath <ben@bagu.org>
2970 Update install script for java-libglom version change.
2972 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2975 2011-07-13 Ben Konrath <ben@bagu.org>
2977 Add support sub-group in the details view.
2979 I also removed the code that special-cased the default details view
2982 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2984 I still have to make a proper flowtable.
2986 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2987 Don't special-case default details view layout.
2988 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2989 addLayoutField() as I'm going to use it.
2990 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2991 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2993 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2994 extracted from DetailsViewImpl.GroupPanel. Add support for
2996 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2997 column count when getting the details layout.
2999 2011-07-12 Ben Konrath <ben@bagu.org>
3001 Set browser title with database and table titles.
3003 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3004 Set the browser title when the table changes and when the activity
3006 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3007 title when retrieving document info (the GlomDocument object).
3008 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3009 with getter and setter methods. Remove unused convenience constructor.
3010 Use default code formatting.
3012 2011-07-12 Ben Konrath <ben@bagu.org>
3014 Ignore LayoutItemPortals in the details view.
3016 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3019 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3020 LayoutItemPortal layout objects.
3021 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3022 LayoutItemPortal objects when retrieving the details layout.
3023 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3024 file. This is an empty class and just used to get type information for
3027 2011-07-12 Ben Konrath <ben@bagu.org>
3029 Use java-libglom 1.17.0.
3033 2011-07-11 Ben Konrath <ben@bagu.org>
3035 Remove "Table:" label from table selector.
3037 This matches a recent change in the Glom UI.
3039 * mockups/details-contacts.html:
3040 * mockups/details-projects.html:
3041 * mockups/listview-contacts.html:
3042 * mockups/listview-projects.html: Remove the "Table:" label from the
3044 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3046 2011-07-11 Ben Konrath <ben@bagu.org>
3048 Add main groups to the details view.
3050 This makes things look a little nicer in the details view. The next step
3051 is to implement the flowtable.
3053 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3054 resources from the standard gwt css theme. Standard.css is now
3055 included in OnlineGlom.html so that the online glom css rules have
3056 precedence over the gwt theme.
3057 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3058 the whole LayoutGroup to the DetailsView instead of just the titles.
3059 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3060 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3061 details layout with a helper class (GroupPanel). I might extract this
3062 class when I make the full flowtable.
3063 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3064 string as default so I don't have to worry about NPEs when processing
3066 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3067 note beside OnlineGlom.gwt.xml above).
3068 * src/main/webapp/style.css: Add default font-size to body to override
3069 the font-size set by the standard theme. Don't use h2 tags for
3070 group-title. Create new details-cell class.
3072 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3074 ConfiguredDocument: Set the port number too.
3076 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3077 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3078 Glom document. Presumably this worked sometimes so far because there is a
3079 default port number.
3081 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3083 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3085 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3086 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3087 correct, though we should throw an exception too.
3089 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3091 Fix a addDocuemnt typo.
3093 * src/main/java/org/glom/web/shared/Documents.java
3094 (Documents.addDocuemnt): Rename to addDocument().
3095 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3096 (OnlineGlomServiceImpl.getDocuments): Adapt.
3098 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3100 Slightly improved log output when connection fails.
3102 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3103 (ConfiguredDocument.setUsernameAndPassword):
3104 We don't know for sure if it' the username/password that's wrong, so
3105 rephrase the message.
3106 Also ouput the exception message, though it's generic in this case.
3108 2011-07-08 Ben Konrath <ben@bagu.org>
3112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3113 added braces to a one line if statement because the Eclipse formatter
3114 was getting confused.
3116 2011-07-07 Ben Konrath <ben@bagu.org>
3118 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
3120 These should really be two separate tasks but I counldn't get things to
3121 work with GWT 2.2.0 and Eclipse 3.7.
3125 * .settings/org.eclipse.jdt.core.prefs:
3126 * .settings/org.eclipse.jdt.ui.prefs:
3127 * .settings/org.eclipse.ltk.core.refactoring.prefs:
3128 * .settings/org.eclipse.m2e.core.prefs:
3129 Add new config files. Update current files. Remove references to the
3130 webtools plugins as we're not using any of the webtools features.
3131 * .gitignore: Add logs directory which is created when running with
3133 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
3134 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
3135 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
3137 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
3139 2011-07-07 Murray Cumming <murrayc@murrayc.com>
3141 onlineglom.properties: Add explanatory comments.
3143 * src/main/resources/onlineglom.properties: Also change the default user
3144 from ben to someuser, to avoid the risk of people thinking we just
3145 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3147 2011-06-28 Ben Konrath <ben@bagu.org>
3149 Use filename in Log for incorrect passwords.
3151 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3152 getFileName(String) method to get the filename from the URI.
3154 2011-06-28 Ben Konrath <ben@bagu.org>
3156 Add the table name to the URL token for the ListPlace.
3158 This makes things consistent between the DetailsPlace and the
3159 ListPlace. It also allows the the ListPlace to be bookmarked.
3161 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3162 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3164 Remove getDefaultListLayout(). The default layout is now returned
3165 by the getListLayout() method when the table name is an empty string.
3166 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3167 Add table name field. Change to a new ListPlace when the table
3168 has been changed. Use getListLayout() for getting the default
3170 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3171 Add table name field. Set the correct table name in the list box
3172 when loading from bookmark. This corrects a problem for the
3174 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3175 Move table name to super-class (HasSelectableTable). Move document
3176 and table URL keys to super-class in HasSelectableTable.
3177 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3178 Add table name field. Add Tokenizer class with URL key common to
3179 the subclasses (DetailsPlace and ListPlace).
3180 * src/main/java/org/glom/web/client/place/ListPlace.java:
3181 Add table name. Add code to parse the URL token.
3182 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3183 Update ListPlace construction with empty table name string.
3184 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3185 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3186 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3187 Update ListPlace construction with table name string.
3188 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3189 Change defaultTableName field to tableName to reflect how it's now
3190 used. Update the getter and setter methods.
3192 2011-06-28 Ben Konrath <ben@bagu.org>
3194 Enable the table selector in the DetailsView.
3196 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3197 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3198 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3199 Remove getDefaultDetailsLayout(). The default layout is now returned
3200 by the getDetailsLayout() method when the table name is an empty
3202 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3203 event handler for table change event. Change to using
3204 getDetailsLayout() for the default details layout.
3205 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3207 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3208 when navigating to the details place.
3210 2011-06-27 Ben Konrath <ben@bagu.org>
3212 Use filename based unique document ID in URL and for RPC.
3214 The document ID is the glom document name with spaces (' ') replaced
3215 with pluses ('+') and without the .glom extension.
3217 This change is mostly a string substitution of 'documentTitle' for
3218 'documentID'. The only code change is the addition of a Documents DTO to get the
3219 filename to document title mappings as indicated below.
3221 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3222 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3223 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3224 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3225 Use Documents DTO to create the document links in the document
3227 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3228 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3229 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3230 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3231 * src/main/java/org/glom/web/client/place/ListPlace.java:
3232 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3233 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3234 * src/main/java/org/glom/web/client/ui/ListView.java:
3235 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3236 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3237 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3238 * src/main/java/org/glom/web/server/Log.java:
3239 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3240 getDocumentTitles() to getDocuments() and return the Documents DTO.
3241 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3242 transferring the filename to document title mappings.
3244 2011-06-25 Ben Konrath <ben@bagu.org>
3246 Make the authentication popup work again.
3248 This bug was introduced when I extracted ConfiguredDocument to its own class.
3250 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the