1 2012-01-02 Murray Cumming <murrayc@murrayc.com>
3 Add project information to README and pom.xml.
5 * README: Add a brief description and mention some mvn
7 * pom.xml: This extra information shows up in mvn site
10 2011-01-02 Murray Cumming <murrayc@murrayc.com>
12 Use the latest java-libglom version.
14 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
16 2012-01-01 Murray Cumming <murrayc@murrayc.com>
18 GwtTestOnlineGlom: Test a little more.
20 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
21 protected rather than private, as suggested by the gwt-test-utils
23 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
24 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
25 Test the initial visibility of the panels.
27 However, this is not a very useful test.
28 And I wonder how we should generally test using this idea for an
29 activity/places app like ours where the real changes happen implicitly
30 based on the history token/URL.
32 2012-01-01 Murray Cumming <murrayc@murrayc.com>
34 Slight modification to *Mapper comments.
36 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
38 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
40 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
42 Remove comments mentioning GIN because they are just copied from
43 the example code and are apparently not helpful:
44 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
45 Also change the mention of a class that is only in the example code.
47 2012-01-01 Murray Cumming <murrayc@murrayc.com>
49 GwtTestOnlineGlom test: Minor changes.
51 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
52 Avoid the long qualified class name and modify the comment
53 because it is now obvious to me that the mocked class is the only
54 custom one created via GWT.create().
56 2012-01-01 Murray Cumming <murrayc@murrayc.com>
58 Tests: Added the beginnings of a test using gwt-test-utils.
60 * pom.xml: Add dependencies on gwt-test-utils and easymock.
61 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
62 which tells gwt-test-utils what class will be tested.
63 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
64 Add a simple (but empty) test case. One class, used by the OnlineGlom
65 class, is mocked so that it can be created. However, I am not sure
66 why only this class needs to be mocked.
68 Note that mockito seems more popular, and clearer, than easymock,
69 but I have not got that working yet. It might be a matter of the
72 This test is run during mvn integration-test.
74 2011-12-31 Murray Cumming <murrayc@murrayc.com>
76 Tests: Use junit4-style syntax instead of junit3-style.
78 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
79 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
80 * src/test/java/org/glom/web/shared/DataItemTest.java:
81 Use the @Test annotation rather than relying on the test*() prefix.
82 Also no longer implement TestCase, to avoid triggering support for
83 the junit3-way, which stops the annotations from working.
84 Change the imports from import junit.framework.* to
85 import org.junit.*, which is apparently the new way.
87 2011-12-31 Murray Cumming <murrayc@murrayc.com>
89 Added a test for ListPlace token parsing and creation.
91 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
92 This is much the same as DetailsPlaceTest.
94 I wonder how we could test the other parts of the *Place API.
96 2011-12-30 Murray Cumming <murrayc@murrayc.com>
98 DetailsPlace test: Also test getToken() and recreation via getPlace().
100 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
101 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
102 recreate it, testing the recreated DetailsPlace for the same parameter
105 2011-12-30 Murray Cumming <murrayc@murrayc.com>
107 Use the surefire-report plugin.
109 * pom.xml: This generates a HTML report about the tests in
110 target/site/surefire-report.html
111 when you do mvn surefire-report:report. It seems to be popular/normal.
113 2011-12-30 Murray Cumming <murrayc@murrayc.com>
115 Added a test for DetailsPlace.
117 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
118 Test the getPlace() token parsing.
120 2011-12-30 Murray Cumming <murrayc@murrayc.com>
122 Added a first unit test.
124 * pom.xml: Add a test goal, and a dependency on junit in that scope.
125 * src/test/java/org/glom/web/shared/DataItemTest.java:
126 This is a silly test but it is just to get things started. Note that
127 maven/junit finds the test because it looks in src/test by default.
129 2011-12-22 Ben Konrath <ben@bagu.org>
131 Change charsetName to "UTF-8" when replacing line breaks.
133 JavaScript requires the charsetName to be "UTF-8". CharsetName values
134 that work in Java (such as "UTF8") will not work when compiled to
137 This fixes a problem with multi-line details view fields that have hard
138 line breaks. The "License Text" field on this page demonstrates the
141 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
143 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
145 2011-12-22 Ben Konrath <ben@bagu.org>
147 Fix another bug with related list navigation.
149 I've tested all the navigation buttons in all of the related lists
150 so things should be good now.
152 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
154 2011-12-22 Ben Konrath <ben@bagu.org>
156 Fix a crasher when refreshing the list view with the default table.
158 This crash will also happen when loading the list view with the default
159 table from a link or bookmark.
161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
162 to the main document selection page when the document id hasn't been
164 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
165 the main document selection page when the document id hasn't been
167 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
168 values for the details place when the document id hasn't been set.
169 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
170 values for the list place when the document id hasn't been set.
172 2011-12-21 Ben Konrath <ben@bagu.org>
174 Protect against NPE when glom.document.locale is not in config.
176 This patch protects against an NPE when glom.document.locale is not in
177 the config file. This NPE will also happen if glom.document.locale is
180 The patch also updates the error message to display the class name when
181 the getMessage() returns null. This was happening when the NPE was
182 thrown and I had "Configuration Error: null". If an NPE is encountered
183 with this patch, "Configuration Error: NullPointerException " will be
186 This commit closes this bug:
188 https://bugzilla.gnome.org/show_bug.cgi?id=666669
190 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
192 2011-12-20 Murray Cumming <murrayc@murrayc.com>
194 Rename onlineglom.properties to onlineglom.properties.sample.
196 * src/main/resources/onlineglom.properties: Rename to:
197 * src/main/resources/onlineglom.properties.sample:
198 * src/main/resources/README: And add this file explaining that people
199 should rename it back when deploying.
201 2011-12-20 Murray Cumming <murrayc@murrayc.com>
203 Allow choosing the translation in the .properties file.
205 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
206 init(): Read a glom.document.locale value from the configuration file
207 and call Glom's TransatableItem::set_current_locale() method.
208 * src/main/resources/onlineglom.properties: Add a commented-out
209 example of this new setting.
211 It would be better to add &lang=de_DE to the URL, but the current
212 libglom API does not allow us to do this easily. I am working on that.
214 2011-12-19 Murray Cumming <murrayc@murrayc.com>
216 Avoid a crash in parsing of token parameters.
218 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
219 ava: getTokenParams(): Do not crash if a parameter has a key but no
220 value, and ignore parameters with neither.
222 2011-12-17 Murray Cumming <murrayc@murayc.com>
224 History token building/handling: Improve use of token parameters.
226 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
227 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
228 and buildParamsToken(HashMap), for use by derived classes.
229 Make the separator private because it is no longer be needed.
230 * src/main/java/org/glom/web/client/place/DetailsPlace.java
231 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
232 instead of manual string concatenation.
233 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
234 of hardcoded indices and awkward splitting code.
235 * src/main/java/org/glom/web/client/place/ListPlace.java
236 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
237 instead of manual string concatenation.
238 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
239 of hardcoded indices and awkward splitting code.
240 This should fix bug #666420
242 2011-12-16 Murray Cumming <murrayc@murrayc.com>
244 Fix a Navgiation->Navigation typo in the code.
246 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
247 Rename processNavgiation() to processNavigation().
249 2011-12-16 Murray Cumming <murrayc@murrayc.com>
251 Fix a seperator->separator typo in the code.
253 * src/main/java/org/glom/web/client/place/DetailsPlace.java
254 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
255 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
258 2011-12-15 Ben Konrath <ben@bagu.org>
260 Cleanup some comments.
262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
264 2011-12-14 Ben Konrath <ben@bagu.org>
266 Replace \n with <br/> for multiline text in the details view.
268 Vertical scrollbars are added when needed as well.
270 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
272 2011-12-14 Ben Konrath <ben@bagu.org>
274 Specify the font for document selection links.
276 * src/main/webapp/style.css:
278 2011-12-14 Ben Konrath <ben@bagu.org>
280 Fix bouncy CellTable while paging.
282 This doesn't currently work with related list tables in unselected
285 * src/main/java/org/glom/web/client/ui/list/ListTable.java
287 2011-12-14 Ben Konrath <ben@bagu.org>
289 Revamp the appearance of the document selection page.
291 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
292 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
293 * src/main/webapp/style.css:
295 2011-12-13 Ben Konrath <ben@bagu.org>
297 Set navigation button column to the smallest size possible.
299 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
301 2011-12-13 Ben Konrath <ben@bagu.org>
303 Change OpenButton nomenclature to NavigationButton.
305 Using NavigtionButton makes things more generic. Classes, methods and
306 variables have been changed.
308 This is a rename-only refactor.
310 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
311 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
312 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
313 Renamed from OpenButtonCell.
314 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
315 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
316 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
318 2011-12-12 Ben Konrath <ben@bagu.org>
320 Remove unnecessary String argument in RelatedListTable and ListViewTable.
322 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
323 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
324 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
325 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
327 2011-12-12 Ben Konrath <ben@bagu.org>
329 Update variable names and comments.
331 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
332 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
334 2011-12-12 Ben Konrath <ben@bagu.org>
336 Properly initialize numNonEmptyRows variable to zero.
338 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
339 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
341 2011-12-05 Ben Konrath <ben@bagu.org>
343 Add latest mockup with HTML tables.
345 Features of this mockup:
347 -> HTML table for flowtable
348 -> HTML table for flowtable column
349 -> Example of how related lists would look
350 -> Not using text entries for data items
352 The current version of Online Glom doesn't use HTML tables for the
355 This mockup has been sent to the glom-devel mailing list but it's good
356 to have it here as well.
358 * mockups/details-view-html-tables.html:
360 2011-12-05 Ben Konrath <ben@bagu.org>
362 Remove unnecessary getPrimaryKeyField() method.
364 getPrimaryKeyFieldForTable(String) has been renamed to
365 getPrimaryKeyField(String).
367 * src/main/java/org/glom/web/server/database/DBAccess.java:
368 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
369 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
371 2011-12-05 Ben Konrath <ben@bagu.org>
373 Add string representation of TypedDataItem value to conversion error message.
375 * src/main/java/org/glom/web/server/Utils.java: Logging the error
376 message was extracted into its own method to avoid duplication.
378 2011-12-05 Ben Konrath <ben@bagu.org>
380 Add type checking to navigation primary key value creation.
382 Create navigation primary key only if the expected type from the Glom
383 document matches the type returned by the SQL query.
385 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
387 2011-12-05 Ben Konrath <ben@bagu.org>
389 Rename a couple of variables in RelatedListNavigation.
391 This is a rename-only refactor.
393 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
395 2011-12-05 Ben Konrath <ben@bagu.org>
397 Move getListLayoutGroup() into getListViewLayoutGroup().
399 This removes getListLayoutGroup(). It was only being called by
400 getListViewLayoutGroup().
402 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
404 2011-12-05 Ben Konrath <ben@bagu.org>
406 Remove check for LayoutItem_Portal in list table method.
408 This check is no longer necessary because the method isn't being used
409 to create the LayoutItemPortal DTO.
411 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
413 2011-12-05 Ben Konrath <ben@bagu.org>
415 Properly support related list navigation.
417 Navigation from the "Repository Analyzer -> Package Scans ->
418 Dependencies" related table wasn't working because the primary key for
419 related tables wasn't being set properly. This commit fixes the
422 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
423 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
424 doesn't set the primary key properly for related list tables.
425 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
426 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
427 useful for getting the primary key for list view tables and for related
429 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
430 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
431 Move code to set the primary key for the table from the abstract
432 ListDBAccess class to ListViewDBAccess as it's only correct for list
434 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
435 Properly add primary key to related list tables.
437 2011-12-02 Ben Konrath <ben@bagu.org>
439 Properly set the horizontal alignment of fields.
441 This fix is for both the list tables and the details view.
443 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
444 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
445 to set the horizontal alignment of fields.
447 2011-12-02 Ben Konrath <ben@bagu.org>
449 Display currency codes in the details view.
451 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
453 2011-12-02 Ben Konrath <ben@bagu.org>
455 Avoid duplicate JNI call.
457 JNI is not as efficient as pure Java and this is an easy (and small)
460 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
461 Use previously retrieved value for whereClauseToTableName instead of
464 2011-12-02 Ben Konrath <ben@bagu.org>
466 Rename a couple of variables in RelatedListNavigation.
468 This is a rename-only refactor.
470 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
472 2011-12-02 Ben Konrath <ben@bagu.org>
474 Indicate clearly that a mismatched primary key type is a bug.
476 * src/main/java/org/glom/web/server/Utils.java: Change log level from
477 warning to error. Add 'This is a bug.' to message.
479 2011-12-02 Ben Konrath <ben@bagu.org>
481 Update / fix some comments.
483 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
485 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
487 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
488 Fix comments. Add some TODOs.
490 2011-12-02 Ben Konrath <ben@bagu.org>
492 Enable navigation to details view with string primary key from related list.
494 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
495 Create a text primary key value when return type of result is
496 java.sql.Types.VARCHAR.
498 2011-12-02 Ben Konrath <ben@bagu.org>
500 Use checkboxes for booleans in the details view.
502 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
504 2011-12-01 Ben Konrath <ben@bagu.org>
506 Improve performance of related list height calculation.
508 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
509 Put code to calculate the expected height in a static initializer so
510 that that it's only called once.
512 2011-12-01 Ben Konrath <ben@bagu.org>
514 Show related list tables in notebooks (again).
516 Calculate the height of the related list tables so the Notebook can be
517 set the correct height. The height of the related list table is also needed by
518 FlowTable to be able decide how to create the layout.
520 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
521 and set the Portal height based on the height of the related list
522 table and the Portal container.
523 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
524 Add method to calculate the height of the related list tables.
525 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
526 * src/main/webapp/style.css: Add css class for Pager. This is needed to
527 calculate the height of the Pager widget.
529 2011-12-01 Ben Konrath <ben@bagu.org>
531 Use CellTable API for table property instead of setting style on Element.
533 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
535 2011-12-01 Ben Konrath <ben@bagu.org>
537 Make ListViewTable and RelatedListTable a consistent height.
539 The tables are now a consistent height regardless of the contents of
540 the table. A hidden button is added to empty rows to ensure that the
541 height of these rows will match the height of rows with data.
543 A navigation button column is now added to every table. The width of
544 the navigation column is set to 0px when a RelatedListTable shouldn't
545 have navigation buttons. This maintains the a consistent row height in
546 tables that don't show the navigation buttons.
548 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
549 navigation column when not needed.
550 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
551 arguments for navigation button to constructor of ListViewTable.
552 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
553 hidden button for empty data rows.
554 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
555 arguments for navigation button to constructor.
556 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
557 create navigation buttons. Add hideNavigationButtons() method.
558 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
559 arguments for navigation button to constructor.
561 2011-12-01 Ben Konrath <ben@bagu.org>
563 Use 'visibility: hidden' in Utils.getWidgetHeight().
565 This is better choice because hidden elements are invisible, don't
566 respond to events and are not part of the tab order. They will,
567 however, take up space which is required to be able to calculate the
568 height of the widget.
570 * src/main/java/org/glom/web/client/Utils.java:
572 2011-12-01 Ben Konrath <ben@bagu.org>
574 Use Utils.getWidgetHeight() in FlowTable.
576 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
578 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
580 2011-12-01 Ben Konrath <ben@bagu.org>
582 Put the details css class name on the correct table column.
584 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
586 2011-11-30 Ben Konrath <ben@bagu.org>
588 Update for java-libglom API change.
590 The getters and setters on FieldFormatting and NumericFormat were
591 changed to remove the 'M'.
593 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
595 2011-11-29 Ben Konrath <ben@bagu.org>
597 Only allow RelatedListTables in Portals.
599 * src/main/java/org/glom/web/client/ui/details/Portal.java:
601 2011-11-29 Ben Konrath <ben@bagu.org>
603 Only create a contents panel for Portals when title is being set.
605 * src/main/java/org/glom/web/client/ui/details/Portal.java:
607 2011-11-29 Ben Konrath <ben@bagu.org>
609 Set TabLayoutPanel height based on calculated height its widgets.
611 This is a potential fix for this bug:
613 https://bugzilla.gnome.org/show_bug.cgi?id=665133
615 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
617 2011-11-29 Ben Konrath <ben@bagu.org>
619 Align details field labels and data with the Open buttons.
621 * src/main/webapp/style.css:
623 2011-11-29 Ben Konrath <ben@bagu.org>
625 Remove unnecessary <div> in the Notebook widget.
627 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
628 method to get container FlowPanel (<div>).
629 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
630 initWidget() method directly on the TabLayoutPanel widget instead of
631 Group's container widget.
633 2011-11-29 Ben Konrath <ben@bagu.org>
635 Don't add group titles for Portals in Notebooks.
637 This reverts the previous patch and fixes a bug I introduced with
638 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
640 * src/main/java/org/glom/web/client/ui/details/Group.java:
641 * src/main/java/org/glom/web/client/ui/details/Portal.java:
643 2011-11-28 Ben Konrath <ben@bagu.org>
645 Remove unused boolean argument in Portal constructor.
649 * src/main/java/org/glom/web/client/ui/details/Group.java:
650 * src/main/java/org/glom/web/client/ui/details/Portal.java:
652 2011-11-28 Ben Konrath <ben@bagu.org>
654 Remove hack for glom 1.18 style glom files.
656 * src/main/java/org/glom/web/client/ui/details/Group.java:
657 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
658 * src/main/java/org/glom/web/client/ui/details/Portal.java:
660 2011-11-28 Ben Konrath <ben@bagu.org>
662 Use Gda Value version of primary key to log result too large error.
664 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
666 2011-11-28 Ben Konrath <ben@bagu.org>
668 Don't use TypedDataItem.getText() for Unknown types from the URL.
670 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
671 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
672 instead of getText().
673 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
674 String field and getUnknown() method.
676 2011-11-28 Ben Konrath <ben@bagu.org>
678 Log an error message when the java-libglom .so is not present.
680 The error message was being set in the exception but not logged.
682 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
684 2011-11-28 Ben Konrath <ben@bagu.org>
686 Ignore LayoutItem_CalendarPortals.
688 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
689 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
691 2011-11-28 Ben Konrath <ben@bagu.org>
693 Extract method for creating the LayoutItemPortal DTO.
695 Just breaking the code up into smaller chunks.
697 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
699 2011-11-28 Ben Konrath <ben@bagu.org>
703 This should have been added with the refactor. Oops!
705 * src/main/java/org/glom/web/shared/TypedDataItem.java:
707 2011-11-28 Ben Konrath <ben@bagu.org>
709 Create primary key value from URL string using type from Glom document.
711 See this bug, comments 19 - 25:
713 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
715 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
716 create a TypeDataItem for the primary key here when loading from a
717 URL. Show the same string for the primary key value as was received
718 from the URL string (when loading from a URL).
719 * src/main/java/org/glom/web/server/Utils.java: Update method for
720 creating the Gda Value from the TypeDataItem to properly deal with
721 creating a Gda Value based on the Glom document type for the primary
722 key value string when loading from a URL.
723 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
724 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
725 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
726 Update for changed method name.
728 2011-11-27 Ben Konrath <ben@bagu.org>
730 Rename PrimaryKeyItem to TypedDataItem.
732 The name PrimaryKeyItem suggests what the class should be used for.
733 TypedDataItem is a neutral name that describes the class better.
735 This is a rename-only refactor.
737 * src/main/java/org/glom/web/client/OnlineGlomService.java:
738 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
739 * src/main/java/org/glom/web/client/Utils.java:
740 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
741 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
742 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
743 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
744 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
745 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
746 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
747 * src/main/java/org/glom/web/server/Utils.java:
748 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
749 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
750 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
751 * src/main/java/org/glom/web/shared/NavigationRecord.java:
753 2011-11-25 Ben Konrath <ben@bagu.org>
755 Improve Gda Value conversion from PrimaryKeyItem.
757 The value from the PrimaryKeyItem is only used if its type match the
758 type from the glom document.
760 * src/main/java/org/glom/web/server/Utils.java:
762 2011-11-25 Ben Konrath <ben@bagu.org>
764 Manually check if the java-liblgom .so is visible to the JVM.
766 It seems that Tomcat has problems when a static initializer throws an
767 exception. This check is done before the first method call into
768 java-libglom so that execution doesn't continue if the .so is not
771 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
773 2011-11-25 Ben Konrath <ben@bagu.org>
775 Improve browser configuration error messages.
779 https://bugzilla.gnome.org/show_bug.cgi?id=662792
781 * src/main/java/org/glom/web/client/OnlineGlomService.java:
782 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
783 getConfigurationErrorMessage() method.
784 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
785 Get and display a specific configuration error message when no Glom
787 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
788 Implement getConfigurationErrorMessage() method. Surround configuration
789 code in the init() method with a try/catch block. This allows the
790 errors to be caught while keeping the servlet available to retrieve the
791 configuration error message.
793 2011-11-25 Ben Konrath <ben@bagu.org>
795 Don't use Strings to hold primary key values.
797 The primary key values are now held in a new data object
798 (PrimaryKeyItem) that holds type information and the primary key value
799 using the correct type.
801 * src/main/java/org/glom/web/client/OnlineGlomService.java:
802 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
803 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
804 PrimaryKeyItem instead of String to hold the primary key value.
805 * src/main/java/org/glom/web/client/Utils.java: Remove
806 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
807 PrimaryKeyItem based on the GlomFieldType and the DataItem.
808 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
809 PrimaryKeyItem instead of String to hold the primary key value. Load
810 document selection page when the documentID has not been set correctly.
811 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
812 DetailsPlace -> URL and URL -> DetailsPlace conversion with
814 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
815 Return empty string for URL instead of "null".
816 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
817 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
818 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
819 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
820 PrimaryKeyItem instead of String to hold primary key values.
821 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
822 PrimaryKeyValue to a Gda Value.
823 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
824 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
825 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
826 Replace temporary database access code that uses the PrimaryKeyValue to
827 Gda Value conversion.
828 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
829 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
830 PrimaryKeyItem instead of String.
831 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
832 hold primary key values.
834 2011-11-24 Ben Konrath <ben@bagu.org>
836 Use newly added java-libglom API to create queries.
838 This isn't finished. I still need to stop using Strings for primary key
839 values in the client code.
841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
842 libglom to use fake connections so that retrieving the query string will
844 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
845 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
846 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
847 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
848 Use the newly added libglom sql methods and classes to create the
849 query. Add temporary hack to convert primary value strings to Gda
852 2011-11-23 Ben Konrath <ben@bagu.org>
854 Don't explicitly set the height of Portals.
856 See comments 6 - 10 of this bug for details:
858 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
860 * src/main/java/org/glom/web/client/ui/details/Portal.java:
862 2011-11-23 Ben Konrath <ben@bagu.org>
864 Use an HTML table instead of CSS for the FlowTable layout.
866 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
867 GWT's FlexTable to implement the FlowTable.
868 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
870 2011-11-18 Ben Konrath <ben@bagu.org>
872 Add boolean example to HTML table mockup.
874 * mockups/details-view-html-tables-text-entries.html:
876 2011-11-17 Ben Konrath <ben@bagu.org>
878 Ensure the pager buttons are always visible for related lists.
880 To accomplish this, I've turned off text wrapping in the list view and
881 related list tables for both the header and data text. The related list
882 table now has a fixed layout so the it doesn't overflow its container.
883 This is required to ensure that the cell text is clipped when it
884 overflows the cell and an ellipsis is added to the right side of the
885 cell when text is clipped.
887 A fixed table layout for the related list table in the details view
888 seems what we want for the details view anyway, so the side-effect is
891 The ellipsis will only be displayed in Firefox >= 7.
895 https://bugzilla.gnome.org/show_bug.cgi?id=662930
897 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
898 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
899 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
901 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
902 Set the 'table-layout: fixed' CSS property to the related list table.
903 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
904 'white-space: nowrap;' CSS property on both the list view and the
907 2011-11-16 Ben Konrath <ben@bagu.org>
909 Rework the fix for empty notebook tab labels.
911 Setting the empty group titles with its name caused problems for the
912 details layout. Instead of using libglom's
913 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
914 to the client when the title is empty. This allows the Notebook to use
915 the name when the title is empty without affecting anything else.
917 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
918 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
920 2011-11-16 Ben Konrath <ben@bagu.org>
922 Set group titles with name when title is empty.
924 This fixes a problem with an empty notebook tab label in the Lesson
925 Planner document. The forth tab in the notebook should be "Internet":
927 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
929 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
930 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
933 2011-11-16 Ben Konrath <ben@bagu.org>
935 Remove whitespace from the configured username properties.
937 This assumes that usernames won't have whitespace at the beginning
938 or end. But I think this is a reasonable assumption.
940 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
941 String.trim() to remove the whitespace from the username properties.
943 2011-11-15 Ben Konrath <ben@bagu.org>
945 Add details view mockup with HTML tables and text entries.
947 This is from the attachment on this bug:
949 https://bugzilla.gnome.org/show_bug.cgi?id=663109
951 * mockups/details-view-html-tables-text-entries.html:
953 2011-11-15 Ben Konrath <ben@bagu.org>
955 Add space between the columns of the flow table.
959 https://bugzilla.gnome.org/show_bug.cgi?id=662918
961 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
962 space between columns in the flow table.
964 2011-11-15 Ben Konrath <ben@bagu.org>
966 Add backup files to the .gitignore.
968 * .gitignore: Ignore files that end with ~.
970 2011-11-09 Ben Konrath <ben@bagu.org>
972 Use latest release of gwt-log.
974 Gwt-log releases are now being submitted to the maven central
975 repository so manual installation of the jar is no longer required.
977 * pom.xml: Update version and groupId of gwt-log dependency.
979 2011-10-31 Ben Konrath <ben@bagu.org>
981 Don't use GWT numeric formatting to override the glom currency formatting.
983 Currencies are now displayed like they are in Glom. See this bug:
985 https://bugzilla.gnome.org/show_bug.cgi?id=646216
987 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
989 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
990 currency code to constructor and set it when the cell is rendered.
991 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
992 currency code to the constructor of the NumericCell.
994 2011-10-27 Ben Konrath <ben@bagu.org>
996 Require the latest release of java-libglom (1.17.4).
1000 2011-10-26 Ben Konrath <ben@bagu.org>
1002 Add style to Notebook that matches current theme.
1004 It's not the best style in the world but it's better than the default.
1006 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1007 padding at the bottom of the child widgets.
1008 * src/main/webapp/style.css: Add style for the Notebook.
1010 2011-10-26 Ben Konrath <ben@bagu.org>
1012 Move servlet initialization code to overridden init method.
1014 This is half of the solution to getting proper error messages
1015 displayed when configuration errors occur. Here's the relevant bug:
1017 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1019 The rest of the solution involves surrounding the init method with a
1020 try/catch block and setting a global variable with the error /
1021 exception. A new async method should be created to retrieve and display
1022 the error message / exception.
1024 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1025 code from constructor to init method adding exceptions as needed.
1027 2011-10-26 Ben Konrath <ben@bagu.org>
1029 Add script to monitor and restart tomcat if required.
1031 * utils/check-and-recover-tomcat.py: New file.
1033 2011-10-26 Ben Konrath <ben@bagu.org>
1035 Display the correct number of data items in the pager.
1039 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1041 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1042 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1043 The implementation is the same for both tables: Keep track of the
1044 number of non-empty rows and fire and RowCountChangeEvent after the data has
1046 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1047 custom Pager class that subclasses SimplePager to handle displaying
1048 the correct number when empty rows have been added.
1050 2011-10-26 Ben Konrath <ben@bagu.org>
1052 Correct error in previous commit.
1054 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1055 eventBus parameter from listView.setCellTable().
1057 2011-10-26 Ben Konrath <ben@bagu.org>
1059 Fix error in TODO comment.
1061 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1063 2011-10-24 Ben Konrath <ben@bagu.org>
1065 Create Notebook widgets to the details view.
1067 This isn't finished just yet - I still need to create a reasonable
1068 style to match the current theme.
1070 * src/main/java/org/glom/web/client/Utils.java: Add method for
1071 calculating the height of a widget. This is used in the Notebook class.
1072 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1073 new constructor method in Group.
1074 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1075 method for creating child widget that can be used by subclasses
1076 like Notebook. New constructor that allows disabling the group
1077 titles - Notebooks don't set a group title for their child groups.
1078 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1079 to make Notebooks using GWT's TabLayoutPanel.
1080 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1081 constructor that allows disabling the group titles.
1082 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1083 LayoutItemNotebook DTO.
1084 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1085 DTO for Notebooks. It's just an empty class for now but we might need
1086 it to transfer some specific information in the future.
1088 2011-10-21 Ben Konrath <ben@bagu.org>
1090 Add navigation buttons to related list tables.
1092 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1093 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1094 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1095 method getSuitableRecordToViewDetails() for getting the table name
1096 and primary key value for related list navigation buttons.
1097 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1098 private cell renderer class to get the navigation information for
1099 related list tables from the server. Extract the navigation
1100 processing code from the details cell navigation and use it for the
1101 related list navigation as well.
1102 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1103 cell renderer class for the details open buttons. This was needed
1104 because the related list navigation buttons and the list view
1105 navigation buttons need to react differently when clicked.
1106 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1107 the onEnterKeyDown() method because it's now overriden in the
1108 subclasses that are specific to the related list tables and the list
1110 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1111 the vertical size a little because the buttons add a bit of vertical
1112 space to table. This is not a perfect solution because the vertical
1113 size of with table fewer than 5 rows will be a little smaller.
1114 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1115 changes in how navigation buttons are handled.
1116 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1117 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1118 database access object.
1119 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1120 to find the portal for a given relationship name from
1121 RelatedListDBAccess. Add method to find a primary key field for a
1123 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1124 Move code to find the portal for a given relationship name to
1126 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1127 New file: database access object for getting the related list
1128 navigation information (the table name and the primary key value).
1129 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1130 DTO for transferring a table name to navigate to and a primary key
1132 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1133 boolean and getter/setter to specifies if the related list should add
1136 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1138 Use the master branch of java-libglom
1140 * pom.xml: Depend on java-libglom 1.19 instead.
1142 This is the master branch. See also the libglom-1-18 branch.
1144 2011-10-11 Ben Konrath <ben@bagu.org>
1146 Enable the open navigation button when the data has been set.
1148 This avoids having active buttons that don't do anything when the data
1151 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1153 2011-10-11 Ben Konrath <ben@bagu.org>
1155 Use IsWidget interface for FlowTableItem.
1157 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1158 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1160 2011-10-11 Ben Konrath <ben@bagu.org>
1162 Remove GWT styling from open button in details view.
1164 There are still some issues with how the details cell is arranged but
1165 this should be made to match Glom 1.20. I'm going to leave fixing this
1166 until I have Glom 1.20 up and running.
1168 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1169 style name on open button.
1170 * src/main/webapp/style.css: Move and edit details-navigation class.
1171 Re-arrange some classes to make them appear in the same order as the
1174 2011-10-07 Ben Konrath <ben@bagu.org>
1176 Update to GWT 2.4.0.
1178 * .gitignore: Ignore new cache directory.
1179 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1180 * pom.xml: Change GWT and maven plugin to 2.4.0.
1181 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1183 * src/main/java/org/glom/web/client/ClientFactory.java:
1184 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1185 * src/main/java/org/glom/web/client/OnlineGlom.java:
1186 Update source for API changes.
1187 * utils/build-onlineglom-war.sh: Remove cache directory before the
1190 2011-10-07 Ben Konrath <ben@bagu.org>
1192 Add navigation buttons in the details view.
1194 This isn't finished but I thought I'd commit what I have as it's a
1195 pretty good start. I still need to:
1197 1. Change the style so that it fits better into the current theme
1198 2. Adjust the details cell to expand as much as possible.
1200 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1201 click handlers to navigation buttons in the DetailsCells. Create a
1202 refreshData() method to get just the data from the server without the
1204 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1205 Update the tableSelector and browser title when the table name
1206 changes without using the tableSelector.
1207 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1208 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1209 getDetailsCells() to getCells(). Update variable names.
1210 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1211 method to set click handler on navigation button. Rename a few
1212 variables. Add navigation buttons where needed.
1213 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1214 variables and methods.
1215 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1216 navigation boolean and navigation table as required in the
1217 LayoutItemField DTO.
1218 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1219 variables for navigation along with getter/setter methods.
1221 2011-10-07 Ben Konrath <ben@bagu.org>
1223 Rename Field to DetailsCell.
1225 This is a refactor-only commit. No functionality has been added or
1228 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1229 Update variable and method names.
1230 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1231 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1232 variable and method names.
1233 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1235 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1236 variable and method names.
1238 2011-10-07 Ben Konrath <ben@bagu.org>
1240 Create separate methods for layout and data the details view.
1242 This is a refactor-only commit. No functionality has been added or
1245 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1246 private methods: setData(), createLayout().
1248 2011-10-07 Ben Konrath <ben@bagu.org>
1250 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1252 This is part of a change to get navigation buttons in the details view
1253 but it should have been done this way from the start.
1255 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1256 for method name change in TableSelectionView.
1257 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1258 Create TableChangeEvent and set the browser title using the
1259 TableSelectionView API.
1260 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1261 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1262 Change getSelectedTable() to getSelectedTableName(). Add
1263 getSelectedTableTitle().
1265 2011-10-07 Ben Konrath <ben@bagu.org>
1267 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1269 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1271 2011-10-07 Ben Konrath <ben@bagu.org>
1273 Update TableChangeEvent to use newTableName naming convention.
1275 This makes the class more consistent with GWT naming conventions.
1277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1278 Update for method name change in TableChangeEvent.
1279 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1280 for method name change in TableChangeEvent.
1281 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1282 newTableName variable and getter method. Make toDebugString()
1285 2011-09-30 Ben Konrath <ben@bagu.org>
1287 Disable the pager in the list tables when the data row count is less than the minimum.
1289 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1290 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1292 2011-09-30 Ben Konrath <ben@bagu.org>
1294 Add empty rows to the end of related list and list view tables.
1296 I also extracted the cell rendering classes from the ListTable because
1297 the code was becoming a little crazy with all the anonymous inner
1298 classes. My plan is to use these cell rendering classes in the details
1299 view as well so this refactor will be needed for that change.
1301 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1302 set the row count in related list tables if the data has more rows
1303 than the minimum number of rows visible.
1304 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1305 row count in list view tables if the data has more rows than the
1306 minimum number of rows visible.
1307 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1308 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1310 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1311 for rendering TYPE_NUMERIC cells. The code was extracted from the
1313 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1314 class for rendering cells with buttons in list views. The code was
1315 extracted from the ListTable class.
1316 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1317 for rendering TYPE_TEXT cells. The code was extracted from the
1319 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1320 Add empty rows to the end of the data if required. Implement
1321 ListTable.getMinNumVisibleRows().
1322 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1323 cell renderer code to public classes. Return null in
1324 Column.getValue() for empty rows. Add new abstract method:
1325 getMinNumVisibleRows(). Move code to set the row count of the list view
1326 table to ListViewImpl.
1327 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1328 empty rows to the end of the data if required. Implement
1329 ListTable.getMinNumVisibleRows().
1332 2011-09-27 Ben Konrath <ben@bagu.org>
1334 Use GWT.log for client-side debugging statements.
1336 These are optimized out when deployed so I should have used this method
1337 in the first place. These statements will eventually be replaced with some sort
1338 of notification in the browser.
1340 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1341 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1342 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1343 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1344 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1346 2011-09-27 Ben Konrath <ben@bagu.org>
1348 Put tableselector on the right, back to list link on right.
1350 The idea is that the table selector is acting like a label for the
1351 currently displayed table so it should be placed below the document title. This
1352 puts the table title in a similar position to where it is in Glom.
1354 * mockups/details-contacts.html:
1355 * mockups/details-projects.html:
1356 * mockups/listview-contacts.html:
1357 * mockups/listview-projects.html:
1358 * mockups/style.css:
1359 Update mockups to match how the interfaces currently look.
1360 * src/main/webapp/style.css: Swap positions of backlink with the table
1361 selector. Add some space on the left side of the table selector to
1362 line things up with the document title.
1364 2011-09-27 Ben Konrath <ben@bagu.org>
1366 Add field colouring to details view.
1368 This change re-works how field colouring works. The colour formatting
1369 information is now set to the client with the layout information instead of
1370 with the data. This eliminates the need to send the same colour strings for
1371 data in list view column when colour information is set.
1373 In order to set an alternate colour for negative numeric values, the
1374 number is now sent to client and formatted with the GWT NumberFormat class.
1376 This change also fixes:
1378 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1380 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1381 internationalization framework which is needed for client side numeric
1383 * src/main/java/org/glom/web/client/Utils.java: New file for some
1384 client static utility methods.
1385 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1386 the DataItem object to the Field class. Use a utility method to
1387 create the foreignKeyValue string.
1388 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1389 alignment and text colours in the constructor. Add setData(DataItem)
1390 method. Remove setText(String) method.
1391 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1392 colour information to GlomTextCell. Create and use GlomNumberCell for
1393 rendering numbers. Use utility method to get the string for the
1394 primary key of the key provider. Re-work how the horizontal alignment
1396 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1397 formatting to layout information. Methods for converting the libglom
1398 formatting information were moved from DBAccess.
1399 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1400 numeric formatting (it's now done on the client side). Don't set text
1401 colours in DataItem. Move libglom formatting conversion methods to
1403 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1404 getters/setters for text colour information.
1405 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1406 for transferring the libglom NumericFormat information to the client.
1407 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1408 and getters/setters for: GlomNumericFormat, background colour and
1409 foreground colour strings.
1411 2011-09-26 Ben Konrath <ben@bagu.org>
1413 Simplify code that iterates through the LayoutGroup.
1415 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1417 2011-09-26 Ben Konrath <ben@bagu.org>
1419 Accept Eclipse formatting for OnlineGlomServiceAsync.
1421 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1423 2011-09-26 Ben Konrath <ben@bagu.org>
1425 Don't use the ListDBAccess classes to get the primary key layout information.
1427 This was causing a bug where the wrong index for the hidden primary key
1428 was being sent to the client.
1430 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1431 primary key while creating the LayoutGroup DTO. Create a
1432 LayoutItemField DTO for hidden primary keys. Don't use the
1433 RelatedListDBAccess because it was only used for getting the primary
1435 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1436 access modifier from public to protected for getPrimaryKeyField() and
1437 getPrimaryKeyLayoutItemField().
1438 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1439 abstract method getExpectedResultSize() because RelatedListDBAccess
1440 doesn't have enough info to implement it.
1441 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1442 Remove @Override for getExpectedResultSize().
1443 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1444 Remove method getExpectedResultSize().
1446 2011-09-23 Ben Konrath <ben@bagu.org>
1448 Log which layout (list or details) the ignored item is from.
1450 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1452 2011-09-23 Ben Konrath <ben@bagu.org>
1454 Remove annotations that turn off code formatting in DataItem.
1456 * src/main/java/org/glom/web/shared/DataItem.java:
1458 2011-09-23 Ben Konrath <ben@bagu.org>
1460 Rename GlomField to DataItem and update associated methods.
1462 This is a rename-only refactor. No functionality has been added or
1465 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1466 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1467 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1468 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1469 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1470 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1471 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1472 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1473 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1474 * src/main/java/org/glom/web/server/database/DBAccess.java:
1475 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1476 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1477 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1478 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1479 * src/main/java/org/glom/web/shared/DataItem.java:
1480 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1481 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1483 2011-09-23 Ben Konrath <ben@bagu.org>
1485 Rename GlomDocument to DocumentInfo and update associated methods.
1487 This is a rename-only refactor. No functionality has been added or
1490 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1491 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1492 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1493 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1494 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1495 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1496 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1498 2011-09-20 Ben Konrath <ben@bagu.org>
1500 Require java-libglom 1.17.3.
1502 This picks up the fix for the seg fault problem with the Scenes table
1503 in the Openismus Film Manager example.
1507 2011-09-20 Ben Konrath <ben@bagu.org>
1509 Change the way sort clause is added for primary key when no sort clause is requested.
1511 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1512 before the sort clause is created. When a sort clause is not requested, the
1513 sort clause is created by finding the primary key in the LayoutFieldVector
1516 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1518 2011-09-20 Ben Konrath <ben@bagu.org>
1520 Log error message if no documents are found in the configured directory.
1522 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1523 Extract the glom file extension string to a private static final class
1524 variable (mostly as syntactic sugar). Accept a minor formatting change.
1525 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1526 the example glom.document.directory configuration property to make it
1527 more clear that it can any directory, not just the home directory.
1529 2011-09-18 Ben Konrath <ben@bagu.org>
1531 Add related lists to details view.
1533 The related list table has support for paging and sorting just like the
1534 table in the list view.
1536 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1537 SQL queries for the related list tables.
1538 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1539 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1540 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1541 Rename getList methods to getListView and add comments. Remove
1542 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1543 it being unused. Add methods: getDetailsLayoutAndData(),
1544 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1545 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1546 Create the layout and set the data for the fields in one async call
1547 instead of two. Create related lists where appropriate.
1548 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1549 for method name changes in OnlineGlomService.
1550 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1551 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1552 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1554 * src/main/java/org/glom/web/client/ui/ListView.java:
1555 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1556 tableName from setCellTable(). Create a ListViewTable instead of
1558 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1559 represent a data field in the details view.
1560 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1561 from addDetailsCell() to Field class. Keep track of the Fields and
1562 Portals in the details view.
1563 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1564 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1565 and add a method to get it. Add method to set the contents of the
1567 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1568 New class for related list tables. This class has the data provider
1569 for the related list table.
1570 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1571 abstract class which is the base class for the ListViewTable and the
1573 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1574 New class for list view tables. This class has the data provider for
1575 the list view table.
1576 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1577 methods for related list tables. Add more information to the
1578 LayoutItemField and LayoutItemPortal DTOs.
1579 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1580 Remove debugging print statement.
1581 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1582 Remove debugging print statements. Add primary key field to SQL count
1584 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1585 Remove unnecessary LayoutFieldVector parameter from
1586 getResultSizeOfSQLQuery() method.
1587 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1588 New class for related list table database access.
1589 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1590 class that is a wrapper DTO for details view layout and data.
1591 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1592 new 'fromField' string to this DTO.
1593 * src/main/webapp/style.css: Remove bottom margin and override top
1596 2011-09-15 Ben Konrath <ben@bagu.org>
1598 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1600 This sets things up to make it easier to add the data retrieval for
1601 related lists (portals). No user noticeable changes were made with
1604 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1605 class has the code to retrieve the layouts and access the
1606 database using the new database helper classes.
1607 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1608 Most of the functionality has been removed from this class. This
1609 class now represents the public interface for the client side
1610 code. It also deals with configuring the servlet and cleaning
1611 things up when the servlet is stopped.
1612 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1613 of static methods into this utility class.
1614 * src/main/java/org/glom/web/server/database/DBAccess.java:
1615 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1616 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1617 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1618 These classes have the database retrieval code. The class hierarchy
1619 has been setup to make it easy to reuse code for similar
1622 2011-09-06 Ben Konrath <ben@bagu.org>
1624 Create separate classes for list table code and the data provider.
1626 As part of this refactor, I also split up the code a bit to make it
1629 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1630 table code to two new classes (below).
1631 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1632 with code from ListViewImpl.
1633 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1634 New file with code from ListViewImpl.
1636 2011-09-06 Ben Konrath <ben@bagu.org>
1638 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1640 This fixes the LayoutItemPortal DTO to match the libglom layout object
1643 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1645 2011-09-01 Ben Konrath <ben@bagu.org>
1647 Set title of Portals in the Details View.
1649 * pom.xml: Bump required version of java-libglom to 1.17.1.
1650 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1651 widget creation to its own class. Add comments to constructor.
1652 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1653 The code is mostly from the Group class with the title now set.
1654 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1655 title of Portal. Update some comments. Fix some code formatting.
1657 2011-09-01 Ben Konrath <ben@bagu.org>
1659 Remove TODO comment for the flow table column width.
1661 The flow table column width is working correctly and doesn't need to be
1662 changed. See this mailing list post for more info:
1664 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1666 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1668 2011-08-27 Ben Konrath <ben@bagu.org>
1670 Add document title (database name) to top of the browser page.
1672 I added the document title to the TableSelecitonView but that will
1673 change if / when we add a view that doesn't require table selection.
1675 * mockups/details-contacts.html:
1676 * mockups/details-projects.html:
1677 * mockups/listview-contacts.html:
1678 * mockups/listview-projects.html:
1679 * mockups/style.css: Add document title to mockups to keep things
1681 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1682 sizes to account for the document title.
1683 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1684 Set the document title when it has been retrieved from the server.
1685 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1686 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1687 and implement setDocumentTitle(String) method.
1688 * src/main/webapp/style.css: Add ID for document title style.
1690 2011-08-25 Ben Konrath <ben@bagu.org>
1692 Add NavigationType enum to LayoutItemPortal DTO.
1694 This is the start of adding support for Portals to the Details View.
1696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1697 LayoutItem_Portal.navigation_type enum from libglom to
1698 LayoutItemPortal.NavigationType enum.
1699 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1700 NavigationType enum, field for storing the NavigationType and getter
1703 2011-08-25 Ben Konrath <ben@bagu.org>
1705 Implement the flow table layout in the Details View.
1707 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1708 FlowTable to Group to account for the renamed class.
1709 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1710 File. This is a container widget that implements the Glom details view
1711 flow table behaviour.
1712 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1713 org/glom/web/client/ui/FlowTable.java.
1714 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1715 so that the size of the subgroups are a closer match to the size of
1716 the Glom subgroups. This makes the flowtable layout match the layout
1717 in Glom for the Music Collection example file.
1719 2011-08-16 Ben Konrath <ben@bagu.org>
1721 Create container element for LayoutItemPortal in Details View.
1723 This will help me develop the layout for the FlowTable.
1725 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1726 fieldPanel variable to detailsCell.
1728 2011-08-15 Ben Konrath <ben@bagu.org>
1730 Set the height of the data element in the Details View.
1732 I changed the InlineLabels (text in a span element) to Labels (text in
1733 a div element) so that I could set the height of the details-data
1734 elements instead of the details-cell parent elements. This allows the
1735 the details-data element to display the correct height if style is
1736 applied that shows the height.
1738 This change has the added benefit of allowing the order of the labels
1739 and data elements to be changed for right-to-left languages.
1741 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1742 InlineLabels to Labels.
1743 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1744 InlineLabels to Labels. Set the height of the data element.
1745 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1746 multiline text height in the Formatting DTO.
1747 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1748 for multiline height along with getter and setter methods.
1749 * src/main/webapp/style.css: Adjust style to account for the change
1750 from span elements to div elements in the details cell.
1752 2011-08-15 Ben Konrath <ben@bagu.org>
1754 Make the List View appearance match the mockups.
1756 It doesn't match exactly but it's much better than it was.
1758 * mockups/listview-contacts.html: Remove unused css classes.
1759 * mockups/listview-projects.html: Remove unused css classes.
1760 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1761 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1762 for mainPanel instead of VerticalPanel (table). Set style name on
1763 CellTable. Set style name on Details column. Right-align Details
1765 * src/main/webapp/style.css: Adjust properties to match the mockups.
1767 2011-08-12 Ben Konrath <ben@bagu.org>
1769 Add better support for subgroups in the details view.
1771 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1772 changed FlowTable constructor.
1773 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1774 support for subgroups and subgroup-titles.
1775 * src/main/webapp/style.css: Add CSS class for subgroups and
1778 2011-08-12 Ben Konrath <ben@bagu.org>
1780 Return the top level LayoutGroup title.
1782 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1784 2011-08-11 Ben Konrath <ben@bagu.org>
1786 Make the TableSelector header match the mockup.
1788 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1789 the layout panel. Properly lineup the table selection header with
1790 the list and details view.
1791 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1792 margin around the details view.
1793 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1794 Rename listBox variable to tableSelector. Set id for the style sheet.
1795 Use a FlowPanel instead of a HorizontalPanel.
1796 * src/main/webapp/style.css: Add properties to make the TableSelector
1797 box match the mockups.
1799 2011-07-13 Ben Konrath <ben@bagu.org>
1801 Update install script for java-libglom version change.
1803 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1806 2011-07-13 Ben Konrath <ben@bagu.org>
1808 Add support sub-group in the details view.
1810 I also removed the code that special-cased the default details view
1813 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1815 I still have to make a proper flowtable.
1817 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1818 Don't special-case default details view layout.
1819 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1820 addLayoutField() as I'm going to use it.
1821 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1822 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1824 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1825 extracted from DetailsViewImpl.GroupPanel. Add support for
1827 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1828 column count when getting the details layout.
1830 2011-07-12 Ben Konrath <ben@bagu.org>
1832 Set browser title with database and table titles.
1834 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1835 Set the browser title when the table changes and when the activity
1837 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1838 title when retrieving document info (the GlomDocument object).
1839 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1840 with getter and setter methods. Remove unused convenience constructor.
1841 Use default code formatting.
1843 2011-07-12 Ben Konrath <ben@bagu.org>
1845 Ignore LayoutItemPortals in the details view.
1847 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1850 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1851 LayoutItemPortal layout objects.
1852 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1853 LayoutItemPortal objects when retrieving the details layout.
1854 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1855 file. This is an empty class and just used to get type information for
1858 2011-07-12 Ben Konrath <ben@bagu.org>
1860 Use java-libglom 1.17.0.
1864 2011-07-11 Ben Konrath <ben@bagu.org>
1866 Remove "Table:" label from table selector.
1868 This matches a recent change in the Glom UI.
1870 * mockups/details-contacts.html:
1871 * mockups/details-projects.html:
1872 * mockups/listview-contacts.html:
1873 * mockups/listview-projects.html: Remove the "Table:" label from the
1875 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1877 2011-07-11 Ben Konrath <ben@bagu.org>
1879 Add main groups to the details view.
1881 This makes things look a little nicer in the details view. The next step
1882 is to implement the flowtable.
1884 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1885 resources from the standard gwt css theme. Standard.css is now
1886 included in OnlineGlom.html so that the online glom css rules have
1887 precedence over the gwt theme.
1888 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1889 the whole LayoutGroup to the DetailsView instead of just the titles.
1890 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1891 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1892 details layout with a helper class (GroupPanel). I might extract this
1893 class when I make the full flowtable.
1894 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1895 string as default so I don't have to worry about NPEs when processing
1897 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1898 note beside OnlineGlom.gwt.xml above).
1899 * src/main/webapp/style.css: Add default font-size to body to override
1900 the font-size set by the standard theme. Don't use h2 tags for
1901 group-title. Create new details-cell class.
1903 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1905 ConfiguredDocument: Set the port number too.
1907 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1908 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1909 Glom document. Presumably this worked sometimes so far because there is a
1910 default port number.
1912 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1914 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1916 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1917 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1918 correct, though we should throw an exception too.
1920 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1922 Fix a addDocuemnt typo.
1924 * src/main/java/org/glom/web/shared/Documents.java
1925 (Documents.addDocuemnt): Rename to addDocument().
1926 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1927 (OnlineGlomServiceImpl.getDocuments): Adapt.
1929 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1931 Slightly improved log output when connection fails.
1933 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1934 (ConfiguredDocument.setUsernameAndPassword):
1935 We don't know for sure if it' the username/password that's wrong, so
1936 rephrase the message.
1937 Also ouput the exception message, though it's generic in this case.
1939 2011-07-08 Ben Konrath <ben@bagu.org>
1943 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1944 added braces to a one line if statement because the Eclipse formatter
1945 was getting confused.
1947 2011-07-07 Ben Konrath <ben@bagu.org>
1949 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1951 These should really be two separate tasks but I counldn't get things to
1952 work with GWT 2.2.0 and Eclipse 3.7.
1956 * .settings/org.eclipse.jdt.core.prefs:
1957 * .settings/org.eclipse.jdt.ui.prefs:
1958 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1959 * .settings/org.eclipse.m2e.core.prefs:
1960 Add new config files. Update current files. Remove references to the
1961 webtools plugins as we're not using any of the webtools features.
1962 * .gitignore: Add logs directory which is created when running with
1964 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1965 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1966 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1968 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1970 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1972 onlineglom.properties: Add explanatory comments.
1974 * src/main/resources/onlineglom.properties: Also change the default user
1975 from ben to someuser, to avoid the risk of people thinking we just
1976 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1978 2011-06-28 Ben Konrath <ben@bagu.org>
1980 Use filename in Log for incorrect passwords.
1982 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1983 getFileName(String) method to get the filename from the URI.
1985 2011-06-28 Ben Konrath <ben@bagu.org>
1987 Add the table name to the URL token for the ListPlace.
1989 This makes things consistent between the DetailsPlace and the
1990 ListPlace. It also allows the the ListPlace to be bookmarked.
1992 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1993 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1994 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1995 Remove getDefaultListLayout(). The default layout is now returned
1996 by the getListLayout() method when the table name is an empty string.
1997 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1998 Add table name field. Change to a new ListPlace when the table
1999 has been changed. Use getListLayout() for getting the default
2001 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2002 Add table name field. Set the correct table name in the list box
2003 when loading from bookmark. This corrects a problem for the
2005 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2006 Move table name to super-class (HasSelectableTable). Move document
2007 and table URL keys to super-class in HasSelectableTable.
2008 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2009 Add table name field. Add Tokenizer class with URL key common to
2010 the subclasses (DetailsPlace and ListPlace).
2011 * src/main/java/org/glom/web/client/place/ListPlace.java:
2012 Add table name. Add code to parse the URL token.
2013 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2014 Update ListPlace construction with empty table name string.
2015 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2016 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2017 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2018 Update ListPlace construction with table name string.
2019 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2020 Change defaultTableName field to tableName to reflect how it's now
2021 used. Update the getter and setter methods.
2023 2011-06-28 Ben Konrath <ben@bagu.org>
2025 Enable the table selector in the DetailsView.
2027 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2028 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2030 Remove getDefaultDetailsLayout(). The default layout is now returned
2031 by the getDetailsLayout() method when the table name is an empty
2033 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2034 event handler for table change event. Change to using
2035 getDetailsLayout() for the default details layout.
2036 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2038 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2039 when navigating to the details place.
2041 2011-06-27 Ben Konrath <ben@bagu.org>
2043 Use filename based unique document ID in URL and for RPC.
2045 The document ID is the glom document name with spaces (' ') replaced
2046 with pluses ('+') and without the .glom extension.
2048 This change is mostly a string substitution of 'documentTitle' for
2049 'documentID'. The only code change is the addition of a Documents DTO to get the
2050 filename to document title mappings as indicated below.
2052 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2053 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2054 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2055 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2056 Use Documents DTO to create the document links in the document
2058 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2059 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2060 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2061 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2062 * src/main/java/org/glom/web/client/place/ListPlace.java:
2063 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2064 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2065 * src/main/java/org/glom/web/client/ui/ListView.java:
2066 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2067 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2068 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2069 * src/main/java/org/glom/web/server/Log.java:
2070 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2071 getDocumentTitles() to getDocuments() and return the Documents DTO.
2072 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2073 transferring the filename to document title mappings.
2075 2011-06-25 Ben Konrath <ben@bagu.org>
2077 Make the authentication popup work again.
2079 This bug was introduced when I extracted ConfiguredDocument to its own class.
2081 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2082 correct success / fail status in setUsernameAndPassword().
2084 2011-06-25 Ben Konrath <ben@bagu.org>
2086 Use filename as unique key for configuring database usernames and passwords.
2088 This replaces the use of the Glom document title which could change
2089 depending on the locale. Thanks to Murray Cumming for pointing out this
2092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2093 * src/main/resources/onlineglom.properties:
2095 2011-06-24 Ben Konrath <ben@bagu.org>
2097 Pass primary key value to DetailsView.
2099 This enables the DetailsView to load the correct data.
2101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2102 primary key value field and set in constructor. Pass primary key
2103 value to getDetailsData().
2104 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2105 variables for document title and primary key value.
2106 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2107 key value to the DetailsPlace.
2109 2011-06-24 Ben Konrath <ben@bagu.org>
2111 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2113 This allows the primary key to be retrieved by the Details button. This
2114 functionality has not been implemented yet but it's in the works.
2116 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2117 the LayoutGroup result to ListView.setCellTable instead of all of its
2118 fields individually.
2119 * src/main/java/org/glom/web/client/ui/ListView.java:
2120 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2121 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2122 get the primary key for the table.
2123 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2124 index of the primary key in the LayoutGroup accounting for hidden
2125 primary keys. Rename getJavaNumberFormat() to
2126 convertToJavaNumberFormat() for consistency. Cleanup / add some
2128 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2129 field for primary key index and a field to indicate whether the
2130 primary key is hidden or not.
2132 2011-06-23 Ben Konrath <ben@bagu.org>
2134 Rename getTableData methods to getListData.
2136 This is a rename refactor for consistency with other methods.
2138 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2139 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2140 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2141 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2143 2011-06-23 Ben Konrath <ben@bagu.org>
2145 Extract the ConfiguredDocument innerclass into its own class.
2147 This makes the servlet code more object oriented.
2149 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2150 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2152 new ConfiguredDocument class.
2154 2011-06-21 Ben Konrath <ben@bagu.org>
2156 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2158 This makes things more inline with how libglom works and reduces code
2159 duplication. This refactor lays the groundwork for adding the primary key to
2160 the LayoutGroup object.
2162 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2163 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2164 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2165 Change method names to getListLayout and getDefaultListLayout for
2166 consistency. Use LayoutGroup as the DTO for the list layout instead of
2167 ColumnInfo and LayoutListTable.
2168 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2169 new method names along with the LayoutGroup object for transferring the
2171 * src/main/java/org/glom/web/client/ui/ListView.java:
2172 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2173 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2174 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2176 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2177 Replaced with LayoutGroup.
2178 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2179 expectedResultSize and defaultTableName fields which are needed for
2181 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2182 type field which is needed for the list layout but will also be
2183 useful for the details layout as things progress.
2184 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2185 Make class abstract. Remove the unnecessary
2186 getFormattingHorizontalAlignment method. Add setFormatting method.
2188 2011-06-16 Ben Konrath <ben@bagu.org>
2190 Add scripts for building and installing war.
2192 These will help when updating OnlineGlom but they're also good
2193 supplemental documentation of the build and deployment proceeding.
2195 * utils/build-onlineglom-war.sh: New file.
2196 * utils/install-onlineglom-war.sh: New file.
2198 2011-06-16 Ben Konrath <ben@bagu.org>
2200 Create wrapper class to create consistent log messages.
2202 I wrapped methods in the Log class of gwt-log to add the method names
2203 from the servlet and create consistent formatting of the document title
2204 and table names in the log messages.
2206 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2207 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2208 log methods to use methods from wrapped Log class.
2210 2011-06-16 Ben Konrath <ben@bagu.org>
2212 Remove superfluous conditional return.
2214 Thanks to Murray Cumming for pointing this out!
2216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2218 2011-06-15 Ben Konrath <ben@bagu.org>
2220 Return an ArrayList of LayoutGroups for the Details layout.
2222 This corrects a problem with the details layout as it can have more
2223 than one top level LayoutGroup.
2225 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2226 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2227 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2228 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2229 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2230 with ArrayList of LayoutGroups for the details view layout.
2231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2232 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2233 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2234 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2235 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2236 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2238 2011-06-14 Ben Konrath <ben@bagu.org>
2240 Use cast_dynamic method to determine the libglom LayoutItem type.
2242 This is better than finding the LayoutItem type by using the string
2243 returned from the get_part_type_name() method.
2245 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2247 2011-06-14 Ben Konrath <ben@bagu.org>
2249 Add method names to log entries in the servlet.
2251 This helps when tracking down deployment problems.
2253 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2255 2011-06-14 Ben Konrath <ben@bagu.org>
2257 Add data to the DetailsView using a hard-coded primary key value.
2259 The layout and functionality of the DetailsView is not complete. This
2260 is just a checkpoint so the patch doesn't get too big.
2262 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2263 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2264 Add getDetailsData() servlet method.
2265 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2266 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2267 LayoutFields are added to the DetailsView.
2268 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2269 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2270 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2271 take the string for the title instead of the object.
2272 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2273 Add implementation getDetailsData() along with some private helper
2275 * src/main/webapp/style.css: Add padding to details-data class. Add a
2276 details-label class with the same padding as the details-data class.
2278 2011-06-03 Ben Konrath <ben@bagu.org>
2280 Use presenter.goTo() to change to the DetailsPlace.
2282 This will make things easier when we need to open the DetailsView with
2283 data specific to the row that was clicked.
2285 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2287 2011-06-02 Ben Konrath <ben@bagu.org>
2289 Add CSS file from mockups.
2291 I'm adding this now because it's going to be useful to have when
2292 developing the DetailsView. The TableSelectionView and ListView aren't
2295 * src/main/webapp/OnlineGlom.html:
2296 * src/main/webapp/style.css:
2298 2011-06-02 Ben Konrath <ben@bagu.org>
2300 Use String.isEmpty() to check for empty string.
2302 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2304 2011-06-02 Ben Konrath <ben@bagu.org>
2306 Display main layout group titles in the DetailsView.
2308 This is the start of the DetailsActivity/DetailsView implementation.
2310 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2311 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2312 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2313 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2314 Get the layout information for the details view from the server and set
2315 the main layout group titles.
2316 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2317 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2318 Add addLayoutGroup() and addLayoutField() methods. This are just
2319 temporary methods for creating the the details view that will change
2321 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2322 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2324 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2325 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2326 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2327 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2328 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2329 Data Transfer Objects that mimic the libglom object structure. These are
2330 used for transferring the details layout but could also be used for
2331 transferring the list layout.
2333 2011-05-27 Ben Konrath <ben@bagu.org>
2335 Reset the AuthenticationPopup when clearing the ListView.
2337 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2339 2011-05-27 Ben Konrath <ben@bagu.org>
2341 Fix problem with onlineglom.properties file loading.
2343 The old way worked in Eclipse but not on the server. Loading the
2344 onlineglom.properties file now works in Eclipse and on the server.
2346 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2348 2011-05-24 Ben Konrath <ben@bagu.org>
2350 Update gwt-log from 3.1.0 to 3.1.2.
2352 Gwt-log 3.1.0 has been marked as depreciated.
2356 2011-05-24 Ben Konrath <ben@bagu.org>
2358 Add comment to ListActivity.goTo() method.
2360 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2362 2011-05-24 Ben Konrath <ben@bagu.org>
2364 Remove FIXME in convertGdkColorToHtmlColour()
2366 The Gdk::Color value returned by libglom is 16-bits per channel on both
2367 64 and 32-bit platforms.
2369 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2371 2011-05-19 Ben Konrath <ben@bagu.org>
2373 Improve performance of initial ListView load.
2375 I removed a round trip to the server for getting the default table name
2376 and then requesting information about that table. This also removes a potential
2377 problem with the table change handler not being setup in time to receive the
2378 table change event from the ListActivity.
2380 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2381 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2382 getDefaultLayoutListTable() method. Improve comments.
2383 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2384 getDefaultLayoutListTable() method instead of firing a table change
2385 event to get the table to load.
2386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2387 implementation of getDefaultLayoutListTable() method.
2388 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2391 2011-05-19 Ben Konrath <ben@bagu.org>
2393 Override toDebugString() in TableChangeEvent.
2395 This is useful to have for debugging.
2397 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2399 2011-05-19 Ben Konrath <ben@bagu.org>
2401 Add a "Back to List" link when at the DetailsPlace.
2403 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2404 Populate the CellTable based on the selected table of the ListBox if
2405 it's set otherwise use the default table. This allows the "Back to
2407 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2408 Remove Place from constructors. Add a setPlace() method. Add
2409 goToPlace() method. Set class as presenter for TableSelectionView.
2410 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2411 Use the same TableSelectionActivity when switching between the List and
2413 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2414 Subclass the new HasSelectableTablePlace. This removes some duplicate
2416 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2417 New class to represent Places that display the TableSelectionView.
2418 * src/main/java/org/glom/web/client/place/ListPlace.java:
2419 Subclass the new HasSelectableTablePlace. This removes some duplicate
2421 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2422 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2423 Add Presenter interface. Add setBackLinkVisible() method. Add
2424 setBackLink() method.
2426 2011-05-18 Ben Konrath <ben@bagu.org>
2428 Enable the "Details" buttons.
2430 Right now only an empty details view is displayed.
2432 * src/main/java/org/glom/web/client/ClientFactory.java:
2433 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2434 Add DetailsView to ClientFactory.
2435 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2436 A basic activity for the details view.
2437 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2438 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2440 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2441 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2443 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2444 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2445 unnecessary super() in constructor.
2446 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2447 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2448 really shouldn't create a new TableSelectionActivity for both the ListPlace
2449 and the DetailsPlace so this should be considered a temporary solution.
2450 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2451 New file. Represents a URL for the details view.
2452 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2453 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2454 A basic details view interface and implementation.
2455 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2456 Enable the "Details" buttons.
2458 2011-05-12 Ben Konrath <ben@bagu.org>
2460 Use a LayoutPanel with multiple display areas for main layout.
2462 This is mostly a refactor in that there are no changes from the user
2463 point of view. These changes are required so that we can swap out the list view
2464 with the details view when the user clicks the "Details" button.
2466 * src/main/java/org/glom/web/client/ClientFactory.java:
2467 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2468 OnlineGlomView. Add TableSelectionView, ListView and
2469 AuthenticationPopup.
2470 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2471 for main layout. Add display regions for main activities. Add
2472 activity manager for for main activities.
2473 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2474 file from parts of the deleted OnlineGlomActivity.
2475 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2476 New file from parts of the deleted OnlineGlomActivity.
2477 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2478 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2479 New files for app wide table change event.
2480 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2481 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2482 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2483 Activity mappers for the main activities replace the deleted app-wide
2485 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2486 Fix a spelling error in he comment.
2487 * src/main/java/org/glom/web/client/ui/ListView.java:
2488 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2489 Renamed from LayoutListView and modified for MVP. This still not a
2490 proper dumb view as prescribed by the MVP pattern but it works for now.
2491 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2492 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2493 New widget stripped out of the deleted OnlineGlomView.
2494 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2495 Remove hack that is fixed by this patch.
2497 2011-05-06 Ben Konrath <ben@bagu.org>
2499 Rename OnlineGlomPlace to ListPlace.
2501 The only change besides the rename is that url will now display #list
2502 instead of #Document.
2504 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2505 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2506 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2507 * src/main/java/org/glom/web/client/place/ListPlace.java:
2508 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2510 2011-05-06 Ben Konrath <ben@bagu.org>
2512 Use Presenter for app navigation.
2514 This is the proper way to deal with Place (URL) changes with the MVP
2517 * src/main/java/org/glom/web/client/ClientFactory.java:
2518 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2519 PlaceHistoryMapper and PlaceHistoryHandler.
2520 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2521 PlaceHistoryMapper and PlaceHistoryHandler.
2522 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2523 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2524 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2525 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2526 Add Presenter interface and setPresenter methods. Rename addHyperLink
2527 to addDocumentLink taking only the document title as a parameter.
2529 2011-04-14 Ben Konrath <ben@bagu.org>
2531 Prompt for db username/password if they haven't been set.
2533 This is implemented with a popup widget that is contained within the
2534 OnlineGlomView and managed by the OnlineGlomActivity.
2536 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2537 methods for checking and setting the database username and password.
2538 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2539 new methods for checking and setting the database username and
2541 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2542 Display authentication popup if the JDBC connection to the database
2543 has not been authenticated.
2544 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2546 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2547 for dealing with the authentication popup.
2548 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2549 Implement the methods for dealing with the authentication popup.
2550 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2551 try to executed queries if the database connection hasn't been
2552 authenticated. Implement methods for checking and setting the
2553 database username and password.
2555 2011-04-12 Ben Konrath <ben@bagu.org>
2557 Make log messages a little clearer.
2559 Add a dash betweeen the document title and the table name.
2561 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2563 2011-04-12 Ben Konrath <ben@bagu.org>
2565 Protect against NPEs when cleaning up database resources.
2567 While this isn't strictly necessary because the exception is caught,
2568 not protecting against the NPEs makes it harder to find the real error
2571 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2573 2011-04-12 Ben Konrath <ben@bagu.org>
2575 Move configuration of the servlet to the constructor.
2577 The servlet will be initialized even if the database authentication
2578 information is not set or correct. I still need to add the UI for prompting
2579 the user for the authentication information when it's required.
2581 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2582 javadocs for getDocumentTitles() method.
2583 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2584 Set error message when RPC fails.
2585 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2586 glom files directory from the configuration file. Try to set the
2587 database authentication information for the specific document if it's
2588 set and works otherwise try to use the global authentication
2589 information set for the directory.
2590 * src/main/resources/onlineglom.properties: Moved from
2591 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2592 Added detailed comments for the new keys.
2594 2011-04-11 Ben Konrath <ben@bagu.org>
2596 Remove unnecessary @Override in DocumentSelectionViewImpl.
2598 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2600 2011-04-11 Ben Konrath <ben@bagu.org>
2602 Remove center alignment in DocumentSelectionView.
2604 The title element is still centred but the document titles and bottom
2605 sentence are both left-aligned.
2607 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2609 2011-04-11 Ben Konrath <ben@bagu.org>
2611 Change 'Demo' naming convention to 'Document'.
2613 This is just a rename refactor with no functional changes to the code.
2615 * src/main/java/org/glom/web/client/ClientFactory.java:
2616 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2617 * src/main/java/org/glom/web/client/OnlineGlom.java:
2618 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2619 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2620 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2621 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2622 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2623 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2624 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2625 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2626 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2627 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2629 2011-04-08 Ben Konrath <ben@bagu.org>
2631 Remove FIXME from safeLongToInt() method.
2633 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2636 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2638 2011-04-08 Ben Konrath <ben@bagu.org>
2640 Display an error if no glom documents are found in the specified directory.
2642 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2643 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2644 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2645 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2647 2011-04-08 Ben Konrath <ben@bagu.org>
2649 Add copyright header to one more file ... oops.
2651 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2653 2011-04-08 Ben Konrath <ben@bagu.org>
2655 Add copyright header to files without it.
2657 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2658 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2659 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2660 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2661 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2662 * src/main/java/org/glom/web/shared/GlomField.java:
2664 2011-04-08 Ben Konrath <ben@bagu.org>
2666 Add support for accessing multiple glom documents in the servlet.
2668 This completes the demo selection functionality.
2670 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2671 document title to methods.
2672 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2673 document title to methods.
2674 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2675 Set browser window title when the activity starts. Correct name of
2676 document title variable.
2677 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2678 Set browser window title when the activity starts. Set the table
2679 selector change handler after table selector has been set. Clear the
2680 OnlineGlomView when the activity has been stopped.
2681 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2682 document title as the place token. Use "#Document:" instead of
2683 "#OnlineGlomPlace:" in the URL.
2684 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2685 Change heading to "Online Glom"
2686 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2687 document title in RPC methods.
2688 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2689 setDocumentTitle() method. Add clear() method.
2690 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2691 setDocumentTitle() method. Implement clear() method which removes the
2692 change handler on the ListBox, clears the ListBox and clears the
2694 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2695 Implement methods with document title. Keep track for the configured
2696 glom documents and their corresponding JDBC configurations in a hash
2697 table. This information is retrieved using the document title as the
2698 key in the hash table.
2699 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2700 document title field as it's no longer needed.
2702 2011-04-08 Ben Konrath <ben@bagu.org>
2704 Update the Eclipse JDT configuration.
2706 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2707 methods. Automatically add the copyright header to new files.
2709 2011-04-05 Ben Konrath <ben@bagu.org>
2711 Add new page for demo selection.
2713 This patch adds all the components required to view and start an
2714 OnlineGlom demo by clicking on the desired hyperlink. The user is
2715 able to return to the demo selection page with the browser's back
2716 button. I still need to modify the servlet to work with multiple
2717 documents so all demo links will load the file defined in the
2718 OnlineGlom.properties.
2720 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2721 This is only useful during development so we don't need to save it.
2722 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2723 get a reference to the DemoSelectionView.
2724 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2725 method to get a reference to the DemoSelectionView.
2726 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2727 default view to DemoSelectionView.
2728 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2729 to get glom document titles for glom files in a hard-coded directory.
2730 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2731 method to get glom document titles for glom files in a hard-coded
2733 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2734 Presenter for DemoSelectionView.
2735 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2736 for DemoSelectionView.
2737 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2738 Update for DemoSelectionView.
2739 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2740 Basic 'Place' implementation for the DemoSelectionView.
2741 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2742 The interface for the DemoSelectionView.
2743 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2744 The implementation of the DemoSelectionView.
2745 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2746 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2747 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2748 implementation of method to get glom document titles for glom files
2749 in a hard-coded directory.
2750 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2751 on longer being used.
2752 * src/main/webapp/glom.png: Glom logo.
2754 2011-04-05 Ben Konrath <ben@bagu.org>
2756 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2758 This is the forth and final commit of a refactor that will allow
2759 OnlineGlom to be used with multiple documents.
2761 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2762 Move RPC code from OnlineGlomViewImpl to this class.
2763 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2765 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2766 RPC code to the presenter class (the P in MVP).
2768 2011-04-04 Ben Konrath <ben@bagu.org>
2770 Start moving the existing OnlineGlom code to MVP.
2772 This work is based on the GWT MVP framework that is documented here:
2774 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2776 This is the third commit of a refactor that will allow OnlineGlom to
2777 be used with multiple documents.
2779 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2780 Interface for client factory which is used to get instances of various
2781 classes throughout the app.
2782 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2783 Implementation of client factory.
2784 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2785 initialize the MVP framework.
2786 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2787 New file. Activity manager for the main container widget. This is the
2789 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2790 Maps place (URL) to its corresponding activity.
2791 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2792 New file. This is just a place holder for a generated file.
2793 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2794 New file. Represents the URL for the main Online Glom app.
2795 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2796 for changes in LayoutListViewImpl.
2797 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2798 interface for View. Move code to OnlineGlomViewImpl class.
2799 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2800 file. Implementation of OnlineGlomView.
2801 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2802 Place resources. Use ClientFactoryImpl by default.
2804 2011-04-04 Ben Konrath <ben@bagu.org>
2806 Move View classes to their own package.
2808 This is the second commit of a refactor that will allow OnlineGlom to
2809 be used with multiple documents.
2811 * src/main/java/org/glom/web/client/OnlineGlom.java:
2812 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2813 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2815 2011-04-02 Ben Konrath <ben@bagu.org>
2817 Move UI code from the main module to its own class.
2819 This is the first commit of a refactor that will allow OnlineGlom to be
2820 used with multiple documents.
2822 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2823 references to OnlineGlom to OnlineGlomView.
2824 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2825 OnlineGlomView and instantiate it here.
2826 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2827 represents the main OnlineGlomView with one document.
2829 2011-04-01 Ben Konrath <ben@bagu.org>
2831 Fix formatting of gwt.xml and add DTD.
2833 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2835 2011-03-30 Ben Konrath <ben@bagu.org>
2837 Propperly convert gdkColor string to html colour string.
2839 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2841 2011-03-28 Ben Konrath <ben@bagu.org>
2843 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2845 This implementation matches
2846 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2847 readable and is not tied to Swig.
2849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2851 2011-03-28 Ben Konrath <ben@bagu.org>
2853 Use read-only checkboxes for boolean field types.
2855 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2856 in the CellTable based on the field type. It currently only
2857 distinguishes between boolean and text columns but I'll need to add
2858 support for more types.
2859 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2860 column type in the ColumnInfo object. Add method to convert between the
2861 glom field type enum in ColumnInfo and the glom field type in libglom.
2862 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2864 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2865 getting and setting booleans.
2867 2011-03-25 Ben Konrath <ben@bagu.org>
2869 Don't get the Date twice from the ResultSet.
2871 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2873 2011-03-25 Ben Konrath <ben@bagu.org>
2875 Cleanup code in the servlet.
2877 * TODO: Remove item about row count. Add item about testing row count
2878 query with large number of rows.
2879 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2880 spelling mistakes, change method parameter to be consistent with
2883 2011-03-25 Ben Konrath <ben@bagu.org>
2885 Add server side logging with the gwt-log library.
2887 * .gitignore: Ignore the log file we're now producing.
2888 * TODO: Add a couple TODO item for logging.
2889 * pom.xml: Add gwt-log and log4j as a dependency.
2890 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2891 logging of errors, warnings and some important info.
2892 * src/main/resources/log4j.properties: New file to configure log4j.
2894 2011-03-24 Ben Konrath <ben@bagu.org>
2896 Add a disable button for the Details view.
2898 * src/main/java/org/glom/web/client/LayoutListView.java:
2900 2011-03-22 Ben Konrath <ben@bagu.org>
2902 Use a count query to get the number of rows for the list view pager.
2904 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2906 2011-03-22 Ben Konrath <ben@bagu.org>
2908 Add more TODO information about CellTable pager positioning.
2912 2011-03-19 Ben Konrath <ben@bagu.org>
2914 Add TODO item about CellTable pager positioning.
2918 2011-03-18 Ben Konrath <ben@bagu.org>
2920 Remove unneeded GlomFieldColumn class.
2922 This is just a small code cleanup.
2924 * src/main/java/org/glom/web/client/LayoutListView.java:
2926 2011-03-18 Ben Konrath <ben@bagu.org>
2928 Use cursor mode in the query that gets data for the list view.
2930 I still need to fix the potential memory problem when getting the row
2931 count for the list view.
2933 * TODO: Add note about testing memory usage with large data sets. Add
2934 item about fixing row counting with large data sets.
2935 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2936 PostgreSQL JDBC driver into cursor mode when getting data for the
2939 2011-03-15 Ben Konrath <ben@bagu.org>
2941 Remove the GWT Container from the Eclipse build classpath.
2943 The GWT dependencies are set by Maven so this isn't needed.
2947 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2949 Added some earlier mockups to git, but not to the tarball dist.
2951 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2952 Openismus. These hopefully show how we might structure the HTML so that
2953 it can be styled easily with CSS. However, we probably need to adapt them
2954 for the CSS structure that GWT dictates for common widgets.
2956 2011-03-14 Ben Konrath <ben@bagu.org>
2958 Locate OnlineGlom.properties using the ServletContext.
2960 This is required to be able to locate the file in the deployed servlet.
2962 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2963 Configure the database and glom document in in a helper method so
2964 that the ServletContext can be used to locate OnlineGlom.properties.
2965 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2966 src/main/webapp. This is the proper location for .properites files.
2968 2011-03-12 Ben Konrath <ben@bagu.org>
2970 Add note to README about why we're compiling down to obfuscated JavaScript.
2974 2011-03-11 Ben Konrath <ben@bagu.org>
2976 Use properties file to configure servlet.
2978 This allows people to change the glom file path, db username and db
2979 password without recompiling the code.
2981 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2982 * src/main/webapp/OnlineGlom.properties:
2984 2011-03-11 Ben Konrath <ben@bagu.org>
2986 Use table fields in layout list view if the layout list is not defined.
2988 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2989 Manually create a LayoutFieldVector for the query builder using the
2990 table fields when a layout list is not defined in the glom file.
2992 2011-03-11 Ben Konrath <ben@bagu.org>
2994 Only show FIXME string for images when there's an image.
2996 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
2997 in this change are some small code cleanups.
2999 2011-03-11 Ben Konrath <ben@bagu.org>
3001 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
3003 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3005 2011-03-11 Ben Konrath <ben@bagu.org>
3007 Correctly set the index of the default table.
3009 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3010 Correctly set the index of the default table. Add commented out example
3013 2011-03-10 Ben Konrath <ben@bagu.org>
3015 Add comment to pom.xml about the previous change.
3017 * pom.xml: Add comment about the deployment issue so that it's obvious
3018 why java-libglom is set to the provided scope.
3020 2011-03-10 Ben Konrath <ben@bagu.org>
3022 Change java-libglom dependency from compile to provided in pom.xml.
3024 Since java-libglom uses jni it can only be loaded once and therefore
3025 must be placed in $CATALINA_HOME/lib and not included in each war.
3026 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
3027 More information about this issue can be found in the Tomcat 6 release
3028 notes in the "JNI Based Applications" section:
3030 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
3032 * README: Remove note about this issue. Deployment info should really
3033 be on the wiki anyway so I'll add it right now.
3034 * pom.xml: Change java-libglom dependency from compile to provided so
3035 that it's copied in to the packaged war.
3037 2011-03-09 Ben Konrath <ben@bagu.org>
3039 Change to using a neutral locale for currency, date and time formatting.
3041 This solves the problem of currency values being represented without a
3042 space between the currency code and the number (e.g. "EUR5.89" is now
3043 represented as "EUR 5.89"). More work is required when we implement
3044 a locale preference setting.
3046 * TODO: Add note about currency formatting issues with different
3048 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3049 to using the neutral ROOT locale.
3051 2011-03-09 Ben Konrath <ben@bagu.org>
3053 Add support for currency codes that are not ISO 4217 codes.
3055 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3056 the currency code defined in the glom file when it's not 3 characters
3057 long or when Java doesn't recognize the string as an ISO 4217 code.
3059 2011-03-08 Ben Konrath <ben@bagu.org>
3061 Remove test classes, launch configurations and configuration.
3063 The test stuff was getting in the way when creating the war. To make
3064 the war file you can now do 'mvn clean package'. The packaged war file
3065 will be in the target directory.
3067 * .classpath: Remove unused classpathentry for tests and i18n.
3068 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
3069 property. Don't run test or i18n goals when packaging the war.
3070 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
3075 * OnlineGlomTest-dev.launch:
3076 * OnlineGlomTest-prod.launch:
3077 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
3078 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
3080 2011-03-07 Ben Konrath <ben@bagu.org>
3082 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
3084 These fixes allow me to use 'mvn deploy' to create the war file.
3086 * .classpath: This generated config has been updated by Eclipse. This
3087 change was probably triggered by me updating from Eclipse 3.6.1 to
3089 * .gitignore: Add entry to ignore the directory
3090 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
3091 * .project: The generated config has been updated by Eclipse. This
3092 change was probably triggered by me updating from Eclipse 3.6.1 to
3094 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3095 so that Eclipse doesn't complain
3096 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3097 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3098 'tests' directory to 'client' directory. This is the new
3099 gwt-maven-plugin convension.
3100 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3101 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3103 2011-03-07 Ben Konrath <ben@bagu.org>
3105 Add support for horizontal alignment in the LayoutList columns.
3107 * TODO: Remove item about horizontal alignment. Add item about
3108 improvements to ColumnInfo.
3109 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3110 alignment on the columns. Use ColumnInfo RPC object get the column
3111 title and horizontal alignment.
3112 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3113 LayoutListView creation with ColumnInfo RPC object.
3114 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3115 a ColumnInfo object for every LayoutList columnn. Convert the
3116 FieldFormatting.HorizontalAlignment to the correct
3117 ColumnnInfo.HorizontatlAlignment with the new
3118 getColumnInfoHorizontalAlignment helper method.
3119 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3120 to encapsulate column information like alignment and title. This
3121 could be used to set the colour instead of on a per cell field basis.
3122 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3123 column title storage and retrieval with ColumnInfo.
3125 2011-03-04 Ben Konrath <ben@bagu.org>
3127 Add support for column sorting.
3129 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3130 AsynDataProvider to be an anonymous inner class. Use new
3131 getSortedTableData RPC method when column sort is requested. Set all
3132 columns sortable and add an AsyncHandler to activate sorting in the
3134 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3135 method getSortedTableData(). Cleanup other method signatures.
3136 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3137 new method getSortedTableData(). Cleanup other method signatures.
3138 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3139 Implement getSortedTableData() and getTableData() methods by using a
3140 private helper method with the appropriate parameters filled in. Use
3141 user supplied sort clause when supplied, otherwise fall back to
3142 sorting by the primary key. Move destroy() method to be underneath
3143 constructor for readability. Cleanup comments.
3145 2011-03-03 Ben Konrath <ben@bagu.org>
3147 Add support for colour text and colour backgrounds to the layout list cells.
3149 Only the cell backgrounds are coloured which leaves a gap between the
3150 cells that isn't coloured. I need to figure out a way to set
3151 'style=background-colour:' on the whole column rather than just the
3154 * TODO: Add a note about colouring the background of the whole column.
3155 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3156 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3157 render the coloured text and backgrounds. Use GlomField[] for the row type.
3158 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3160 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3161 GlomField[] for the row type.
3162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3163 GlomField[] for the row type. Set the text, text colour and background
3164 colour in the GlomField objects as specified in the glom document. Add
3165 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3166 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3167 the glom field text, foreground colour and background colour.
3169 2011-03-02 Ben Konrath <ben@bagu.org>
3171 Don't display hidden tables in the combo box.
3173 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3176 code to ignore hidden tables using ArrayLists for the table names and
3178 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3179 tableNames to use ArrayLists instead of String[]. Update getter and setter
3182 2011-03-01 Ben Konrath <ben@bagu.org>
3184 Add support for Date and Time number types.
3186 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3187 Implement formatting for Date and Time values. Change the default glom
3188 file to small business example.
3190 2011-03-01 Ben Konrath <ben@bagu.org>
3192 Add support for formatting glom types as specified in the glom file.
3194 Formatting isn't finished yet - I still need to add support for Date
3197 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3198 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3199 checks for null values in JDBC cleanup code and catch all exceptions
3200 instead of just SQLExceptions.
3201 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3204 2011-03-01 Ben Konrath <ben@bagu.org>
3206 Use GWT 2.2.0 instead of 2.1.1.
3208 * pom.xml: Change GWT version numbers.
3210 2011-03-01 Ben Konrath <ben@bagu.org>
3212 A few small code cleanups.
3214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3216 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3217 unnecessary object creation in constructor.
3218 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3219 unnecessary object creation in constructor.
3221 2011-02-28 Ben Konrath <ben@bagu.org>
3223 Add file for TODO list.
3227 2011-02-18 Ben Konrath <ben@bagu.org>
3229 Enable the CellTable Pager when more than 20 rows need to be viewed.
3231 The Pager will automatically become active when the results are larger
3232 than the CellTable size which is currently set to 20 lines.
3234 * src/main/java/org/glom/web/client/LayoutListView.java: Correct class
3235 name on debug statment in RPC call in LayoutListDataProvider, add
3236 numRows parameter to LayoutListView constructor, propperly set rowCount