1 2012-03-04 Murray Cumming <murrayc@murrayc.com>
3 Actually show some data with JasperReports.
5 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
6 getReportHTML(): Move most code into a ReportGenerator class.
7 * src/main/java/org/glom/web/server/ReportGenerator.java:
8 Recurse into sub-groups, adding fields to the JasperDesign's details
9 band. Note that we must set an arbitrary width and height, or it just
10 will not show any data.
12 2012-03-04 Murray Cumming <murrayc@murrayc.com>
14 Reports Chooser: Show the titles, not the names.
16 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
17 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
18 and the names as the values.
19 * src/main/java/org/glom/web/server/ConfiguredDocument.java
20 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
21 group now that we provide the report name, so it should always
24 2012-03-04 Murray Cumming <murrayc@murrayc.com>
26 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
28 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
29 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
30 an empty quickfind string. I also corrected libglom to create only
31 empty where clauses for empty quickfind strings, but this avoids the
34 2012-02-24 Ben Konrath <ben@bagu.org>
36 Improve the tabs in the Notebook widget.
40 2012-02-15 Murray Cumming <murrayc@murrayc.com>
42 Depend on jasperreports.
44 * pom.xml: Add the dependency. My plan is to use this on the
47 2012-01-31 Murray Cumming <murrayc@murrayc.com>
49 Implement navigation to report places.
51 * src/main/java/org/glom/web/client/activity/ReportActivity.java
52 start(): Do not bother to handle all events here.
53 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
54 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
55 Added getSelectedReport().
56 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
57 .java: start(): When handling a change to the reports chooser,
58 call getSelectedReport() and goTo() its ReportPlace.
59 * src/main/java/org/glom/web/client/ui/ReportView.java
60 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
61 Added setReportHTML() which puts the html in a gwt HTML widget.
62 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
63 getReportHTML(): Return "TODO" just to show that this works.
65 2012-01-31 Murray Cumming <murrayc@murrayc.com>
67 Make ReportPlace usable.
69 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
71 * src/main/java/org/glom/web/client/place/ReportPlace.java:
72 Correct the @prefix annotation.
74 2012-01-31 Murray Cumming <murrayc@murrayc.com>
76 OnlineGlomService: Return report HTML rather than the LayoutGroup.
78 * src/main/java/org/glom/web/client/OnlineGlomService.java:
79 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
80 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
81 Change getReportLayout() to getReportHMTL() because we will not need to
82 parse or render the report layout on the client side.
83 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
84 getReportLayout(): Return the libglom LayoutGroup type because we will
85 not need to convert to a shared type, because this will not be used on
87 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
90 Note that there is still no implementation for this.
92 2012-01-30 Murray Cumming <murrayc@murrayc.com>
94 Translations: Try to translate the strings.
96 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
97 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
98 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
99 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
100 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
101 Take the Open translation from GTK+'s .po files.
102 Take the Details translation from Glom's po files.
103 I have added the other strings to Glom so we can get translations that way:
104 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
106 2012-01-27 Murray Cumming <murrayc@murrayc.com>
108 Add a (empty) Report Place, View, and Activity.
110 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
112 * src/main/java/org/glom/web/client/place/HasTablePlace.java
113 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
114 this into a superclass:
115 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
116 and also use it as the base of this new ReportPlace:
117 * src/main/java/org/glom/web/client/place/ReportPlace.java
119 * src/main/java/org/glom/web/client/ui/ReportView.java
120 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
121 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
122 Add these, containing mostly boiler-plate for now.
124 * src/main/java/org/glom/web/client/OnlineGlomService.java
125 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
126 * src/main/java/org/glom/web/server/ConfiguredDocument.java
127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
128 Add API to get the LayoutGroup for the report.
130 2012-01-27 Murray Cumming <murrayc@murrayc.com>
132 TableSelectionViewImpl: Put the search label and entry in a div.
134 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
135 Put the search widgets in a FlowTable so that the CSS can be used to
136 style them while keeping them together.
137 * src/main/webapp/style.css: Mention the new div.
139 2012-01-27 Murray Cumming <murrayc@murrayc.com>
141 Translate more strings in more locales.
143 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
144 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
145 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
146 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
147 Translate the "Details" and "Open" string too.
149 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
150 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
151 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
152 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
153 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
154 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
155 Add these new locales as placeholders though they currently contain English.
157 2012-01-27 Murray Cumming <murrayc@murrayc.com>
159 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
162 Check the ConfiguredDocument* for null before using it.
164 2012-01-26 Murray Cumming <murrayc@murrayc.com>
166 Tell Eclipse about the generated java files.
168 * .classpath: This lets it find OnlineGlomConstants.java.
169 It would be nice if Eclipse just used the maven build files.
171 2012-01-26 Murray Cumming <murrayc@murrayc.com>
173 Prevent a crash when no locale is specified in the URL.
175 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
176 Avoid returning a null string, obtained from
177 Window.Location.getParameter(). This caused a crash when it was
178 later passed to libglom's API.
179 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
180 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
181 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
182 guard against future null strings.
184 2012-01-26 Murray Cumming <murrayc@murrayc.com>
186 Use the ?locale= query param instead of the &lang= token param.
188 * src/main/java/org/glom/web/client/place/ListPlace.java
189 * src/main/java/org/glom/web/client/place/DetailsPlace.java
190 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
191 Remove the lang token key and value.
193 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
194 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
195 When the user selects a different locale from the chooser, use
196 Window.Location.assign() to change the URL, which then causes a reload.
198 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
199 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
200 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
201 * src/main/java/org/glom/web/client/activity/ListActivity.java
202 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
203 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
204 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
205 * src/main/java/org/glom/web/client/ui/ListView.java:
206 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
208 Remove localeID member variables and method/constructor parameters, instead
209 using Utils.getCurrentLocaleID() when we need a localID to pass to
212 2012-01-26 Murray Cumming <murrayc@murrayc.com>
214 Internationalize the UI strings.
216 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
217 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
218 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
219 because it is unused. Messages are apparently strings that can have
220 parameters, but we do not need that yet, so Contants will be enough for now.
221 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
222 to say that we support the en and de locales.
223 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
224 The original English strings.
225 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
226 Some German translations of the English strings.
227 The i18n goal then uses the .properties file to generate an
228 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
229 returns an implementation that returns the translated strings.
230 The documentation suggests putting these in src/java/*/client/, but it seems
231 best to put it in src/resources/*/client/.
232 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
233 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
234 instead of hard-coding them.
235 Note that we cannot import OnlineGlomConstants because it does not exist yet,
236 but that does not seem to stop the build, though it confuses Eclipse.
238 You can see the translated string by adding ?locale=de to the URL, like so:
239 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
241 2012-01-24 Murray Cumming <murrayc@murrayc.com>
243 Improve null/empty String checks.
245 * pom.xml: Add a dependency on commons-lang, to use
246 org.apache.commons.lang.StringUtils.
247 * src/main/java/org/glom/web/server/ConfiguredDocument.java
248 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
249 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
250 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
251 Use StringUtils.isEmpty().
253 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
254 StringUtils class with a static isEmpty() function because we
255 cannot use org.apache.commons.lang.StringUtils in client-side
256 GWT code because it (apparently) cannot be compiled to javascript.
257 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
258 * src/main/java/org/glom/web/client/activity/ListActivity.java
259 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
260 * src/main/java/org/glom/web/client/place/DetailsPlace.java
261 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
262 * src/main/java/org/glom/web/client/place/ListPlace.java
263 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
264 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
265 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
266 * src/main/java/org/glom/web/client/ui/details/Group.java
267 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
268 our StringUtils.isEmpty() function.
270 2012-01-24 Murray Cumming <murrayc@murrayc.com>
272 Update to the latest java-libglom API.
274 * pom.xml: Require java-libglom 1.21.4.
275 * src/main/java/org/glom/web/server/ConfiguredDocument.java
276 getDocumentInfo(), getListViewLayoutGroup():
277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
279 * src/main/java/org/glom/web/server/database/DBAccess.java
280 getFieldsToShowForSQLQueryAddGroup(),
281 getPrimaryKeyLayoutItemField(): Replace get_database_title()
282 with either get_database_title_original() or
283 get_database_title(localeID).
285 2012-01-24 Murray Cumming <murrayc@murrayc.com>
287 ConfiguredDocument: Avoid a null pointer exception.
289 * src/main/java/org/glom/web/server/ConfiguredDocument.java
290 Initialize localeID to "" to avoid returning a null String which
291 causes a crash in java-libglom's swing-generated code.
293 2012-01-23 Murray Cumming <murrayc@murrayc.com>
295 Some simple renaming.
297 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
298 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
299 for localeChooser. This seems more appropriate and is less ambiguous
300 particularly in the .css file.
302 2012-01-23 Murray Cumming <murrayc@murrayc.com>
304 ConfiguredDocument: Rename the localedID private member variable.
306 2012-01-23 Murray Cumming <murrayc@murrayc.com>
308 Adapt to the latest java-libglom API from git master.
310 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
311 libglom now uses only Vector instead of List, which uses add() instead of
314 2012-01-23 Murray Cumming <murrayc@murrayc.com>
316 Add and fill a Reports drop-down list box.
318 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
320 * src/main/java/org/glom/web/client/OnlineGlomService.java:
321 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
322 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
323 Added getReports(document, table, localeID), calling
324 ConfiguredDocument.getReports().
325 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
326 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
327 Added setReportsList() and a list widget.
328 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
329 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
331 2012-01-22 Murray Cumming <murrayc@murrayc.com>
333 ConfiguredDocument: Rename the localedID private member variable.
335 2012-01-20 Murray Cumming <murrayc@murrayc.com>
337 Build a source tarball with mvn assembly:single
339 * assembly.xml: Add this file.
340 * pom.xml: Use the maven-assembly-plugin and tell it to use
341 our assembly.xml file.
343 2012-01-19 Murray Cumming <murrayc@murrayc.com>
345 OnlineGlomServiceImpl: Get .glom files recursively.
347 * pom.xml: Depend on commons-io from org.apache.commons.
348 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
349 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
350 files recursively, and with the easier filter for the extension.
351 Use org.apache.commons.io.FilenameUtils.removeExtension() to
352 simplify that code too.
354 2012-01-19 Murray Cumming <murrayc@murrayc.com>
356 README: Mention that you must install java-libglom packages separately.
358 But then it works, because java-libglom is now in the central maven
361 2012-01-18 Murray Cumming <murrayc@murrayc.com>
363 locales drop-down: Show the correct selected locale when the URL changes.
365 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
366 .java: setPlace(): Move some code into fillView().
368 2012-01-18 Murray Cumming <murrayc@murrayc.com>
370 locales drop-down: Do not lose the primary key.
372 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
373 start(): onLocaleChange(): Pass the current primary key value,
374 instead of an empty value.
376 2012-01-18 Murray Cumming <murrayc@murrayc.com>
378 locales drop-down: Do not lose the drop-down selection.
380 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
381 .java (TableSelectionActivity.fillView): Set the selected locale
382 after changing the drop-down items (though we do not really need
383 to change them just because the locale changes.)
385 2012-01-18 Murray Cumming <murrayc@murrayc.com>
387 locales drop-down: Change the tables list when this changes.
389 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
390 .java: TableSelectionActivity.start(): Move the async table titles
391 retrieval into a private fillView() method and also call this when
392 the chosen locale changes.
393 Note that the document title is not actually translatable yet, but
394 that is a problem that I should fix soon in libglom.
396 2012-01-18 Murray Cumming <murrayc@murrayc.com>
398 Improve the placement of the locales drop-down.
400 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
401 Put the title and locales drop-down in a div (gwt.FlowTable).
402 * src/main/webapp/style.css: Add magic css properties to make this work.
403 Also remove the left margin from the title so that it lines up with the
406 2012-01-18 Murray Cumming <murrayc@murrayc.com>
408 locales selector: Show human-readable locale titles.
410 * src/main/java/org/glom/web/server/ConfiguredDocument.java
411 getDocumentInfo(): Use java.util.Locale to show a real title of
412 each locale, in the locale's own language.
414 2012-01-17 Murray Cumming <murrayc@murrayc.com>
416 Add a language/locale selector drop-down.
418 * src/main/java/org/glom/web/shared/DocumentInfo.java:
419 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
420 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
421 getDocumentInfo(): Store the available Locales in the DocumentInfo.
422 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
423 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
424 Add a ListBox to show the available locales. Add getLocaleSelector(),
425 setLocaleList(), getSelectedLocale(), setSelectedLocale().
426 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
427 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
428 java: Add these classes.
429 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
430 start(): Fill the locales ListBox. Handle its change event, firing a
432 setPlace(): Show the selected locale as specified by the URL token.
433 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
434 * src/main/java/org/glom/web/client/activity/ListActivity.java:
435 Handle LocaleChangeEvent, going to a new *Place with that locale.
437 The placement of the ListBox is not pretty, and it currently uses the ID
438 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
442 2012-01-17 Murray Cumming <murrayc@murrayc.com>
444 Search box: Show the search text from the URL token.
446 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
447 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
448 Add setQuickFindText().
449 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
450 .java: setPlace(): Store the queryText if the place is a ListPlace,
451 and call TableSelectionView.setQuickFindText().
453 2012-01-17 Murray Cumming <murrayc@murrayc.com>
455 Allow use of translations via, for instance, &lang=de in the URL.
457 * pom.xml: Use the unstable java-libglom 1.21 version.
459 * src/main/java/org/glom/web/client/OnlineGlomService.java:
460 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
461 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
462 init(): Instead of calling TranslatableItem.set_current_locale()
463 (now removed), call ConfiguredDocument.setDefaultLocaleID().
464 However, this is only for default locales, which are not needed to
465 change the locale in the URL.
466 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
467 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
468 getSortedRelatedListData(): Add a localeID parameter, so we can get the
469 layout for a particular locale.
470 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
471 Add get/setDefaultLocaleID().
472 getDocumentInfo(), getListViewData(), getRelatedListData(),
473 getDetailsLayoutGroup(), getListViewLayoutGroup(),
474 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
475 localeID parameter, so we can get the layout for a particular locale.
477 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
478 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
479 * src/main/java/org/glom/web/client/place/ListPlace.java:
480 Parse and construct a lang parameter too.
482 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
483 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
484 passed to subsequent methods and constructors.
485 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
486 * src/main/java/org/glom/web/client/activity/ListActivity.java:
487 Store the localeID from the *Place and pass it to other constructors
488 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
490 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
491 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
492 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
493 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
494 * src/main/java/org/glom/web/client/ui/ListView.java:
495 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
496 Take localeID parameters and pass them to subsequent constructors and
497 methods, so that the layout is always retrieved for that locale.
499 This is rather repetitive.
501 Note that "" means the original (default) locale of the Glom document,
502 which is usually English.
504 2012-01-17 Murray Cumming <murrayc@murrayc.com>
506 Documents: Remove final keyword to fix startup configuration.
508 * src/main/java/org/glom/web/shared/Documents.java: Remove the
509 final keywords on the private member variables because that breaks
510 the startup, apparently (there are warnings) because it stops them
511 from being serialized. I added these in the previous commit.
513 2012-01-13 Murray Cumming <murrayc@murrayc.com>
515 Documents: Add some final keywords.
517 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
520 2012-01-13 Murray Cumming <murrayc@murrayc.com>
522 OnlineGlomServiceImpl: Add to overview comments.
524 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
525 Note that this is where all the document are loaded. They are not
526 loaded freshly for each page.
528 2012-01-12 Murray Cumming <murrayc@murrayc.com>
532 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
533 Add a TextBox for the text of a quick find.
534 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
536 setBackLink(): Add a String quickFind parameter.
537 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
538 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
539 to the base interface, because that is how TableSelectionViewImpl is used.
540 * src/main/webapp/style.css: Add style for the search box and its label.
542 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
543 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
544 Add these files, based on the existing TableChangeEvent and
545 TableChangeEventHandlers.
546 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
547 start(): Handle QuickFindChangeEvent, passing its quickFind text to
548 a ListPlace() that the user should be taken to.
549 * src/main/java/org/glom/web/client/activity/ListActivity.java
550 start(): Handle it here too and adapt the TableChangeEvent handler to
551 pass the extra "" quickFind parameter to ListPlace.
552 * src/main/java/org/glom/web/client/place/ListPlace.java:
553 Constructor: Take an extra String quickFind parameter and store it,
554 returning it from a new getQuickFind() method.
555 getToken(): Put the quickFind text in the URL token.
556 getPlace(): Parse the quickFind text from the URL token.
557 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
558 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
559 ListPlace constructor.
560 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
561 .java: start(): Add a Change handler for the TableSelectionView's
562 TextBox (via its base HasChangeHandlers interface), firing the new
563 QuickFindChangeEvent.
564 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
565 pass the extra "" quickFind parameter.
567 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
568 setCellTable(): Add a String quickFind parameter and pass it to
569 the ListViewTable() constructor.
570 * src/main/java/org/glom/web/client/ui/ListView.java: Change
571 setCellTable() in the base interface, because that is how ListViewImpl
574 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
575 Add a String quickFind member variable.
576 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
577 Constructor: Add a String quickFind parameter, storing it in the
578 base ListTable's member variable.
579 onRangeChanged(): Pass quickFind to the
580 OnlineGlomServiceAsync.getSortedListViewData() and
581 OnlineGlomServiceAsync.getListViewData() methods.
583 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
584 getListViewData(), getSortedListViewData(): Add a String quickFind
585 parameter, passing it to ConfiguredDocument.getListViewData().
586 * src/main/java/org/glom/web/client/OnlineGlomService.java:
587 Change getListViewData(), getSortedListViewData() in the base interface,
588 because that is how OnlineGlomServiceImpl is used, via this:
589 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
590 Change getListViewData(), getSortedListViewData() here too.
591 This class can apparently be used to asynchronously call methods on
592 OnlineGlomService, and GWT seems to implement that after recognizing
593 just the *Async name convention and the extra AsyncCallback parameters.
595 * src/main/java/org/glom/web/server/ConfiguredDocument.java
596 getListViewData(): Add a String quickFind parameter, and pass it to
597 ListViewDBAccess.getData().
598 * src/main/java/org/glom/web/server/database/ListDBAccess.java
599 getListData(): Add a String quickFind parameter and pass it to
601 getSelectQuery(): Add a String quickFind parameter.
602 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
603 getSelectQuery(): Add a String quickFind parameter and use it with
604 Glom.get_find_where_clause_quick() to pass a where_clause to
605 Glom.build_sql_select_with_where_clause(), to actually filter the
607 getData(): Add a String quickFind parameter, passing it to getListData().
608 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
609 va: getData(): Pass an empty string to getListData() for the
612 2012-01-12 Murray Cumming <murrayc@murrayc.com>
614 ListTable: Minor change.
616 * src/main/java/org/glom/web/client/ui/list/ListTable.java
617 createCellTable(): Make this protected instead of public.
619 2012-01-12 Murray Cumming <murrayc@murrayc.com>
621 Many files: Use final for the parameters and use the @override attribute.
623 2012-01-22 Ben Konrath <ben@bagu.org>
625 Add anchor links for single line text that starts with http, ftp and www.
629 2012-01-22 Ben Konrath <ben@bagu.org>
631 Add ellipsis to single line text in details view.
635 2012-01-04 Murray Cumming <murrayc@murrayc.com>
637 Remove all javadoc author tags.
639 Because they are awkward and meaningless when many people touch
641 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
643 2012-01-04 Murray Cumming <murrayc@murrayc.com>
645 Revert the COPYING.LESSER to COPYING rename.
647 Apparently both should be there if it is LGPL.
649 2012-01-03 Murray Cumming <murrayc@murrayc.com>
651 *View: Remove unused imports.
653 * src/main/java/org/glom/web/client/ui/DetailsView.java:
654 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
655 * src/main/java/org/glom/web/client/ui/ListView.java:
656 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
657 Remove unused imports, as suggested by Eclipse.
659 2012-01-02 Murray Cumming <murrayc@murrayc.com>
661 Move the *View::Presenter types, and some API into one base View.
663 * src/main/java/org/glom/web/client/ui/DetailsView.java:
664 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
665 * src/main/java/org/glom/web/client/ui/ListView.java:
666 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
667 Presenter, setPresenter() and clear() into a shared base interface,
668 to avoid the unnecessary duplicate Presenter types and to more clearly
669 show how the *Views share the same structure, even if they are not
670 used polymorphically.
672 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
673 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
675 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
676 * src/main/java/org/glom/web/client/activity/ListActivity.java:
677 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
679 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
682 Feel free to revert this if there is a good reason for the duplicate
685 2012-01-02 Murray Cumming <murrayc@murrayc.com>
687 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
689 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
690 a class member instead of a local variable in the method.
691 This lets us use it to get the view instances, for use in tests.
692 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
693 beforeOnlineGlom(): Test some more details of the initial view.
694 Again, this is not very useful.
696 To really test gwt-glom we will need to start a local postgresql
697 instance with local data, like the Glom tests in C++.
699 2012-01-02 Murray Cumming <murrayc@murrayc.com>
701 pom.xml: Mention the LGPL license.
703 * pom.xml: Add a licenses section.
704 * COPYING.LESSER: Move this to COPYING, which
705 previously contained the GPL. But gwt-glom is all LGPL.
707 2012-01-02 Murray Cumming <murrayc@murrayc.com>
709 Add project information to README and pom.xml.
711 * README: Add a brief description and mention some mvn
713 * pom.xml: This extra information shows up in mvn site
716 2011-01-02 Murray Cumming <murrayc@murrayc.com>
718 Use the latest java-libglom version.
720 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
722 2012-01-01 Murray Cumming <murrayc@murrayc.com>
724 GwtTestOnlineGlom: Test a little more.
726 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
727 protected rather than private, as suggested by the gwt-test-utils
729 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
730 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
731 Test the initial visibility of the panels.
733 However, this is not a very useful test.
734 And I wonder how we should generally test using this idea for an
735 activity/places app like ours where the real changes happen implicitly
736 based on the history token/URL.
738 2012-01-01 Murray Cumming <murrayc@murrayc.com>
740 Slight modification to *Mapper comments.
742 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
744 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
746 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
748 Remove comments mentioning GIN because they are just copied from
749 the example code and are apparently not helpful:
750 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
751 Also change the mention of a class that is only in the example code.
753 2012-01-01 Murray Cumming <murrayc@murrayc.com>
755 GwtTestOnlineGlom test: Minor changes.
757 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
758 Avoid the long qualified class name and modify the comment
759 because it is now obvious to me that the mocked class is the only
760 custom one created via GWT.create().
762 2012-01-01 Murray Cumming <murrayc@murrayc.com>
764 Tests: Added the beginnings of a test using gwt-test-utils.
766 * pom.xml: Add dependencies on gwt-test-utils and easymock.
767 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
768 which tells gwt-test-utils what class will be tested.
769 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
770 Add a simple (but empty) test case. One class, used by the OnlineGlom
771 class, is mocked so that it can be created. However, I am not sure
772 why only this class needs to be mocked.
774 Note that mockito seems more popular, and clearer, than easymock,
775 but I have not got that working yet. It might be a matter of the
778 This test is run during mvn integration-test.
780 2011-12-31 Murray Cumming <murrayc@murrayc.com>
782 Tests: Use junit4-style syntax instead of junit3-style.
784 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
785 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
786 * src/test/java/org/glom/web/shared/DataItemTest.java:
787 Use the @Test annotation rather than relying on the test*() prefix.
788 Also no longer implement TestCase, to avoid triggering support for
789 the junit3-way, which stops the annotations from working.
790 Change the imports from import junit.framework.* to
791 import org.junit.*, which is apparently the new way.
793 2011-12-31 Murray Cumming <murrayc@murrayc.com>
795 Added a test for ListPlace token parsing and creation.
797 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
798 This is much the same as DetailsPlaceTest.
800 I wonder how we could test the other parts of the *Place API.
802 2011-12-30 Murray Cumming <murrayc@murrayc.com>
804 DetailsPlace test: Also test getToken() and recreation via getPlace().
806 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
807 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
808 recreate it, testing the recreated DetailsPlace for the same parameter
811 2011-12-30 Murray Cumming <murrayc@murrayc.com>
813 Use the surefire-report plugin.
815 * pom.xml: This generates a HTML report about the tests in
816 target/site/surefire-report.html
817 when you do mvn surefire-report:report. It seems to be popular/normal.
819 2011-12-30 Murray Cumming <murrayc@murrayc.com>
821 Added a test for DetailsPlace.
823 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
824 Test the getPlace() token parsing.
826 2011-12-30 Murray Cumming <murrayc@murrayc.com>
828 Added a first unit test.
830 * pom.xml: Add a test goal, and a dependency on junit in that scope.
831 * src/test/java/org/glom/web/shared/DataItemTest.java:
832 This is a silly test but it is just to get things started. Note that
833 maven/junit finds the test because it looks in src/test by default.
835 2011-12-22 Ben Konrath <ben@bagu.org>
837 Change charsetName to "UTF-8" when replacing line breaks.
839 JavaScript requires the charsetName to be "UTF-8". CharsetName values
840 that work in Java (such as "UTF8") will not work when compiled to
843 This fixes a problem with multi-line details view fields that have hard
844 line breaks. The "License Text" field on this page demonstrates the
847 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
849 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
851 2011-12-22 Ben Konrath <ben@bagu.org>
853 Fix another bug with related list navigation.
855 I've tested all the navigation buttons in all of the related lists
856 so things should be good now.
858 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
860 2011-12-22 Ben Konrath <ben@bagu.org>
862 Fix a crasher when refreshing the list view with the default table.
864 This crash will also happen when loading the list view with the default
865 table from a link or bookmark.
867 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
868 to the main document selection page when the document id hasn't been
870 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
871 the main document selection page when the document id hasn't been
873 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
874 values for the details place when the document id hasn't been set.
875 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
876 values for the list place when the document id hasn't been set.
878 2011-12-21 Ben Konrath <ben@bagu.org>
880 Protect against NPE when glom.document.locale is not in config.
882 This patch protects against an NPE when glom.document.locale is not in
883 the config file. This NPE will also happen if glom.document.locale is
886 The patch also updates the error message to display the class name when
887 the getMessage() returns null. This was happening when the NPE was
888 thrown and I had "Configuration Error: null". If an NPE is encountered
889 with this patch, "Configuration Error: NullPointerException " will be
892 This commit closes this bug:
894 https://bugzilla.gnome.org/show_bug.cgi?id=666669
896 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
898 2011-12-20 Murray Cumming <murrayc@murrayc.com>
900 Rename onlineglom.properties to onlineglom.properties.sample.
902 * src/main/resources/onlineglom.properties: Rename to:
903 * src/main/resources/onlineglom.properties.sample:
904 * src/main/resources/README: And add this file explaining that people
905 should rename it back when deploying.
907 2011-12-20 Murray Cumming <murrayc@murrayc.com>
909 Allow choosing the translation in the .properties file.
911 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
912 init(): Read a glom.document.locale value from the configuration file
913 and call Glom's TransatableItem::set_current_locale() method.
914 * src/main/resources/onlineglom.properties: Add a commented-out
915 example of this new setting.
917 It would be better to add &lang=de_DE to the URL, but the current
918 libglom API does not allow us to do this easily. I am working on that.
920 2011-12-19 Murray Cumming <murrayc@murrayc.com>
922 Avoid a crash in parsing of token parameters.
924 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
925 ava: getTokenParams(): Do not crash if a parameter has a key but no
926 value, and ignore parameters with neither.
928 2011-12-17 Murray Cumming <murrayc@murayc.com>
930 History token building/handling: Improve use of token parameters.
932 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
933 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
934 and buildParamsToken(HashMap), for use by derived classes.
935 Make the separator private because it is no longer be needed.
936 * src/main/java/org/glom/web/client/place/DetailsPlace.java
937 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
938 instead of manual string concatenation.
939 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
940 of hardcoded indices and awkward splitting code.
941 * src/main/java/org/glom/web/client/place/ListPlace.java
942 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
943 instead of manual string concatenation.
944 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
945 of hardcoded indices and awkward splitting code.
946 This should fix bug #666420
948 2011-12-16 Murray Cumming <murrayc@murrayc.com>
950 Fix a Navgiation->Navigation typo in the code.
952 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
953 Rename processNavgiation() to processNavigation().
955 2011-12-16 Murray Cumming <murrayc@murrayc.com>
957 Fix a seperator->separator typo in the code.
959 * src/main/java/org/glom/web/client/place/DetailsPlace.java
960 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
961 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
964 2011-12-15 Ben Konrath <ben@bagu.org>
966 Cleanup some comments.
968 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
970 2011-12-14 Ben Konrath <ben@bagu.org>
972 Replace \n with <br/> for multiline text in the details view.
974 Vertical scrollbars are added when needed as well.
976 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
978 2011-12-14 Ben Konrath <ben@bagu.org>
980 Specify the font for document selection links.
982 * src/main/webapp/style.css:
984 2011-12-14 Ben Konrath <ben@bagu.org>
986 Fix bouncy CellTable while paging.
988 This doesn't currently work with related list tables in unselected
991 * src/main/java/org/glom/web/client/ui/list/ListTable.java
993 2011-12-14 Ben Konrath <ben@bagu.org>
995 Revamp the appearance of the document selection page.
997 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
998 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
999 * src/main/webapp/style.css:
1001 2011-12-13 Ben Konrath <ben@bagu.org>
1003 Set navigation button column to the smallest size possible.
1005 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1007 2011-12-13 Ben Konrath <ben@bagu.org>
1009 Change OpenButton nomenclature to NavigationButton.
1011 Using NavigtionButton makes things more generic. Classes, methods and
1012 variables have been changed.
1014 This is a rename-only refactor.
1016 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1017 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1018 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1019 Renamed from OpenButtonCell.
1020 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1021 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1022 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1024 2011-12-12 Ben Konrath <ben@bagu.org>
1026 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1028 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1029 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1030 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1031 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1033 2011-12-12 Ben Konrath <ben@bagu.org>
1035 Update variable names and comments.
1037 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1038 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1040 2011-12-12 Ben Konrath <ben@bagu.org>
1042 Properly initialize numNonEmptyRows variable to zero.
1044 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1045 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1047 2011-12-05 Ben Konrath <ben@bagu.org>
1049 Add latest mockup with HTML tables.
1051 Features of this mockup:
1053 -> HTML table for flowtable
1054 -> HTML table for flowtable column
1055 -> Example of how related lists would look
1056 -> Not using text entries for data items
1058 The current version of Online Glom doesn't use HTML tables for the
1061 This mockup has been sent to the glom-devel mailing list but it's good
1062 to have it here as well.
1064 * mockups/details-view-html-tables.html:
1066 2011-12-05 Ben Konrath <ben@bagu.org>
1068 Remove unnecessary getPrimaryKeyField() method.
1070 getPrimaryKeyFieldForTable(String) has been renamed to
1071 getPrimaryKeyField(String).
1073 * src/main/java/org/glom/web/server/database/DBAccess.java:
1074 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1075 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1077 2011-12-05 Ben Konrath <ben@bagu.org>
1079 Add string representation of TypedDataItem value to conversion error message.
1081 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1082 message was extracted into its own method to avoid duplication.
1084 2011-12-05 Ben Konrath <ben@bagu.org>
1086 Add type checking to navigation primary key value creation.
1088 Create navigation primary key only if the expected type from the Glom
1089 document matches the type returned by the SQL query.
1091 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1093 2011-12-05 Ben Konrath <ben@bagu.org>
1095 Rename a couple of variables in RelatedListNavigation.
1097 This is a rename-only refactor.
1099 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1101 2011-12-05 Ben Konrath <ben@bagu.org>
1103 Move getListLayoutGroup() into getListViewLayoutGroup().
1105 This removes getListLayoutGroup(). It was only being called by
1106 getListViewLayoutGroup().
1108 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1110 2011-12-05 Ben Konrath <ben@bagu.org>
1112 Remove check for LayoutItem_Portal in list table method.
1114 This check is no longer necessary because the method isn't being used
1115 to create the LayoutItemPortal DTO.
1117 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1119 2011-12-05 Ben Konrath <ben@bagu.org>
1121 Properly support related list navigation.
1123 Navigation from the "Repository Analyzer -> Package Scans ->
1124 Dependencies" related table wasn't working because the primary key for
1125 related tables wasn't being set properly. This commit fixes the
1128 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1129 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1130 doesn't set the primary key properly for related list tables.
1131 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1132 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1133 useful for getting the primary key for list view tables and for related
1135 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1136 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1137 Move code to set the primary key for the table from the abstract
1138 ListDBAccess class to ListViewDBAccess as it's only correct for list
1140 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1141 Properly add primary key to related list tables.
1143 2011-12-02 Ben Konrath <ben@bagu.org>
1145 Properly set the horizontal alignment of fields.
1147 This fix is for both the list tables and the details view.
1149 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1150 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1151 to set the horizontal alignment of fields.
1153 2011-12-02 Ben Konrath <ben@bagu.org>
1155 Display currency codes in the details view.
1157 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1159 2011-12-02 Ben Konrath <ben@bagu.org>
1161 Avoid duplicate JNI call.
1163 JNI is not as efficient as pure Java and this is an easy (and small)
1166 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1167 Use previously retrieved value for whereClauseToTableName instead of
1170 2011-12-02 Ben Konrath <ben@bagu.org>
1172 Rename a couple of variables in RelatedListNavigation.
1174 This is a rename-only refactor.
1176 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1178 2011-12-02 Ben Konrath <ben@bagu.org>
1180 Indicate clearly that a mismatched primary key type is a bug.
1182 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1183 warning to error. Add 'This is a bug.' to message.
1185 2011-12-02 Ben Konrath <ben@bagu.org>
1187 Update / fix some comments.
1189 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1191 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1193 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1194 Fix comments. Add some TODOs.
1196 2011-12-02 Ben Konrath <ben@bagu.org>
1198 Enable navigation to details view with string primary key from related list.
1200 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1201 Create a text primary key value when return type of result is
1202 java.sql.Types.VARCHAR.
1204 2011-12-02 Ben Konrath <ben@bagu.org>
1206 Use checkboxes for booleans in the details view.
1208 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1210 2011-12-01 Ben Konrath <ben@bagu.org>
1212 Improve performance of related list height calculation.
1214 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1215 Put code to calculate the expected height in a static initializer so
1216 that that it's only called once.
1218 2011-12-01 Ben Konrath <ben@bagu.org>
1220 Show related list tables in notebooks (again).
1222 Calculate the height of the related list tables so the Notebook can be
1223 set the correct height. The height of the related list table is also needed by
1224 FlowTable to be able decide how to create the layout.
1226 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1227 and set the Portal height based on the height of the related list
1228 table and the Portal container.
1229 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1230 Add method to calculate the height of the related list tables.
1231 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1232 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1233 calculate the height of the Pager widget.
1235 2011-12-01 Ben Konrath <ben@bagu.org>
1237 Use CellTable API for table property instead of setting style on Element.
1239 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1241 2011-12-01 Ben Konrath <ben@bagu.org>
1243 Make ListViewTable and RelatedListTable a consistent height.
1245 The tables are now a consistent height regardless of the contents of
1246 the table. A hidden button is added to empty rows to ensure that the
1247 height of these rows will match the height of rows with data.
1249 A navigation button column is now added to every table. The width of
1250 the navigation column is set to 0px when a RelatedListTable shouldn't
1251 have navigation buttons. This maintains the a consistent row height in
1252 tables that don't show the navigation buttons.
1254 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1255 navigation column when not needed.
1256 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1257 arguments for navigation button to constructor of ListViewTable.
1258 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1259 hidden button for empty data rows.
1260 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1261 arguments for navigation button to constructor.
1262 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1263 create navigation buttons. Add hideNavigationButtons() method.
1264 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1265 arguments for navigation button to constructor.
1267 2011-12-01 Ben Konrath <ben@bagu.org>
1269 Use 'visibility: hidden' in Utils.getWidgetHeight().
1271 This is better choice because hidden elements are invisible, don't
1272 respond to events and are not part of the tab order. They will,
1273 however, take up space which is required to be able to calculate the
1274 height of the widget.
1276 * src/main/java/org/glom/web/client/Utils.java:
1278 2011-12-01 Ben Konrath <ben@bagu.org>
1280 Use Utils.getWidgetHeight() in FlowTable.
1282 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1284 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1286 2011-12-01 Ben Konrath <ben@bagu.org>
1288 Put the details css class name on the correct table column.
1290 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1292 2011-11-30 Ben Konrath <ben@bagu.org>
1294 Update for java-libglom API change.
1296 The getters and setters on FieldFormatting and NumericFormat were
1297 changed to remove the 'M'.
1299 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1301 2011-11-29 Ben Konrath <ben@bagu.org>
1303 Only allow RelatedListTables in Portals.
1305 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1307 2011-11-29 Ben Konrath <ben@bagu.org>
1309 Only create a contents panel for Portals when title is being set.
1311 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1313 2011-11-29 Ben Konrath <ben@bagu.org>
1315 Set TabLayoutPanel height based on calculated height its widgets.
1317 This is a potential fix for this bug:
1319 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1321 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1323 2011-11-29 Ben Konrath <ben@bagu.org>
1325 Align details field labels and data with the Open buttons.
1327 * src/main/webapp/style.css:
1329 2011-11-29 Ben Konrath <ben@bagu.org>
1331 Remove unnecessary <div> in the Notebook widget.
1333 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1334 method to get container FlowPanel (<div>).
1335 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1336 initWidget() method directly on the TabLayoutPanel widget instead of
1337 Group's container widget.
1339 2011-11-29 Ben Konrath <ben@bagu.org>
1341 Don't add group titles for Portals in Notebooks.
1343 This reverts the previous patch and fixes a bug I introduced with
1344 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1346 * src/main/java/org/glom/web/client/ui/details/Group.java:
1347 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1349 2011-11-28 Ben Konrath <ben@bagu.org>
1351 Remove unused boolean argument in Portal constructor.
1353 Just a code cleanup.
1355 * src/main/java/org/glom/web/client/ui/details/Group.java:
1356 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1358 2011-11-28 Ben Konrath <ben@bagu.org>
1360 Remove hack for glom 1.18 style glom files.
1362 * src/main/java/org/glom/web/client/ui/details/Group.java:
1363 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1364 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1366 2011-11-28 Ben Konrath <ben@bagu.org>
1368 Use Gda Value version of primary key to log result too large error.
1370 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1372 2011-11-28 Ben Konrath <ben@bagu.org>
1374 Don't use TypedDataItem.getText() for Unknown types from the URL.
1376 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1377 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1378 instead of getText().
1379 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1380 String field and getUnknown() method.
1382 2011-11-28 Ben Konrath <ben@bagu.org>
1384 Log an error message when the java-libglom .so is not present.
1386 The error message was being set in the exception but not logged.
1388 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1390 2011-11-28 Ben Konrath <ben@bagu.org>
1392 Ignore LayoutItem_CalendarPortals.
1394 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1395 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1397 2011-11-28 Ben Konrath <ben@bagu.org>
1399 Extract method for creating the LayoutItemPortal DTO.
1401 Just breaking the code up into smaller chunks.
1403 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1405 2011-11-28 Ben Konrath <ben@bagu.org>
1409 This should have been added with the refactor. Oops!
1411 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1413 2011-11-28 Ben Konrath <ben@bagu.org>
1415 Create primary key value from URL string using type from Glom document.
1417 See this bug, comments 19 - 25:
1419 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1421 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1422 create a TypeDataItem for the primary key here when loading from a
1423 URL. Show the same string for the primary key value as was received
1424 from the URL string (when loading from a URL).
1425 * src/main/java/org/glom/web/server/Utils.java: Update method for
1426 creating the Gda Value from the TypeDataItem to properly deal with
1427 creating a Gda Value based on the Glom document type for the primary
1428 key value string when loading from a URL.
1429 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1430 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1431 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1432 Update for changed method name.
1434 2011-11-27 Ben Konrath <ben@bagu.org>
1436 Rename PrimaryKeyItem to TypedDataItem.
1438 The name PrimaryKeyItem suggests what the class should be used for.
1439 TypedDataItem is a neutral name that describes the class better.
1441 This is a rename-only refactor.
1443 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1444 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1445 * src/main/java/org/glom/web/client/Utils.java:
1446 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1447 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1448 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1449 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1450 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1451 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1452 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1453 * src/main/java/org/glom/web/server/Utils.java:
1454 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1455 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1456 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1457 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1459 2011-11-25 Ben Konrath <ben@bagu.org>
1461 Improve Gda Value conversion from PrimaryKeyItem.
1463 The value from the PrimaryKeyItem is only used if its type match the
1464 type from the glom document.
1466 * src/main/java/org/glom/web/server/Utils.java:
1468 2011-11-25 Ben Konrath <ben@bagu.org>
1470 Manually check if the java-liblgom .so is visible to the JVM.
1472 It seems that Tomcat has problems when a static initializer throws an
1473 exception. This check is done before the first method call into
1474 java-libglom so that execution doesn't continue if the .so is not
1477 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1479 2011-11-25 Ben Konrath <ben@bagu.org>
1481 Improve browser configuration error messages.
1485 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1487 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1488 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1489 getConfigurationErrorMessage() method.
1490 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1491 Get and display a specific configuration error message when no Glom
1492 documents are found.
1493 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1494 Implement getConfigurationErrorMessage() method. Surround configuration
1495 code in the init() method with a try/catch block. This allows the
1496 errors to be caught while keeping the servlet available to retrieve the
1497 configuration error message.
1499 2011-11-25 Ben Konrath <ben@bagu.org>
1501 Don't use Strings to hold primary key values.
1503 The primary key values are now held in a new data object
1504 (PrimaryKeyItem) that holds type information and the primary key value
1505 using the correct type.
1507 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1508 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1509 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1510 PrimaryKeyItem instead of String to hold the primary key value.
1511 * src/main/java/org/glom/web/client/Utils.java: Remove
1512 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1513 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1514 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1515 PrimaryKeyItem instead of String to hold the primary key value. Load
1516 document selection page when the documentID has not been set correctly.
1517 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1518 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1520 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1521 Return empty string for URL instead of "null".
1522 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1523 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1524 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1525 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1526 PrimaryKeyItem instead of String to hold primary key values.
1527 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1528 PrimaryKeyValue to a Gda Value.
1529 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1530 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1531 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1532 Replace temporary database access code that uses the PrimaryKeyValue to
1533 Gda Value conversion.
1534 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1535 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1536 PrimaryKeyItem instead of String.
1537 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1538 hold primary key values.
1540 2011-11-24 Ben Konrath <ben@bagu.org>
1542 Use newly added java-libglom API to create queries.
1544 This isn't finished. I still need to stop using Strings for primary key
1545 values in the client code.
1547 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1548 libglom to use fake connections so that retrieving the query string will
1550 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1551 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1552 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1553 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1554 Use the newly added libglom sql methods and classes to create the
1555 query. Add temporary hack to convert primary value strings to Gda
1558 2011-11-23 Ben Konrath <ben@bagu.org>
1560 Don't explicitly set the height of Portals.
1562 See comments 6 - 10 of this bug for details:
1564 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1566 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1568 2011-11-23 Ben Konrath <ben@bagu.org>
1570 Use an HTML table instead of CSS for the FlowTable layout.
1572 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1573 GWT's FlexTable to implement the FlowTable.
1574 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1576 2011-11-18 Ben Konrath <ben@bagu.org>
1578 Add boolean example to HTML table mockup.
1580 * mockups/details-view-html-tables-text-entries.html:
1582 2011-11-17 Ben Konrath <ben@bagu.org>
1584 Ensure the pager buttons are always visible for related lists.
1586 To accomplish this, I've turned off text wrapping in the list view and
1587 related list tables for both the header and data text. The related list
1588 table now has a fixed layout so the it doesn't overflow its container.
1589 This is required to ensure that the cell text is clipped when it
1590 overflows the cell and an ellipsis is added to the right side of the
1591 cell when text is clipped.
1593 A fixed table layout for the related list table in the details view
1594 seems what we want for the details view anyway, so the side-effect is
1597 The ellipsis will only be displayed in Firefox >= 7.
1601 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1603 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1604 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1605 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1607 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1608 Set the 'table-layout: fixed' CSS property to the related list table.
1609 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1610 'white-space: nowrap;' CSS property on both the list view and the
1611 related list tables.
1613 2011-11-16 Ben Konrath <ben@bagu.org>
1615 Rework the fix for empty notebook tab labels.
1617 Setting the empty group titles with its name caused problems for the
1618 details layout. Instead of using libglom's
1619 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1620 to the client when the title is empty. This allows the Notebook to use
1621 the name when the title is empty without affecting anything else.
1623 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1624 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1626 2011-11-16 Ben Konrath <ben@bagu.org>
1628 Set group titles with name when title is empty.
1630 This fixes a problem with an empty notebook tab label in the Lesson
1631 Planner document. The forth tab in the notebook should be "Internet":
1633 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1635 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1636 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1639 2011-11-16 Ben Konrath <ben@bagu.org>
1641 Remove whitespace from the configured username properties.
1643 This assumes that usernames won't have whitespace at the beginning
1644 or end. But I think this is a reasonable assumption.
1646 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1647 String.trim() to remove the whitespace from the username properties.
1649 2011-11-15 Ben Konrath <ben@bagu.org>
1651 Add details view mockup with HTML tables and text entries.
1653 This is from the attachment on this bug:
1655 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1657 * mockups/details-view-html-tables-text-entries.html:
1659 2011-11-15 Ben Konrath <ben@bagu.org>
1661 Add space between the columns of the flow table.
1665 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1667 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1668 space between columns in the flow table.
1670 2011-11-15 Ben Konrath <ben@bagu.org>
1672 Add backup files to the .gitignore.
1674 * .gitignore: Ignore files that end with ~.
1676 2011-11-09 Ben Konrath <ben@bagu.org>
1678 Use latest release of gwt-log.
1680 Gwt-log releases are now being submitted to the maven central
1681 repository so manual installation of the jar is no longer required.
1683 * pom.xml: Update version and groupId of gwt-log dependency.
1685 2011-10-31 Ben Konrath <ben@bagu.org>
1687 Don't use GWT numeric formatting to override the glom currency formatting.
1689 Currencies are now displayed like they are in Glom. See this bug:
1691 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1693 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1695 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1696 currency code to constructor and set it when the cell is rendered.
1697 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1698 currency code to the constructor of the NumericCell.
1700 2011-10-27 Ben Konrath <ben@bagu.org>
1702 Require the latest release of java-libglom (1.17.4).
1706 2011-10-26 Ben Konrath <ben@bagu.org>
1708 Add style to Notebook that matches current theme.
1710 It's not the best style in the world but it's better than the default.
1712 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1713 padding at the bottom of the child widgets.
1714 * src/main/webapp/style.css: Add style for the Notebook.
1716 2011-10-26 Ben Konrath <ben@bagu.org>
1718 Move servlet initialization code to overridden init method.
1720 This is half of the solution to getting proper error messages
1721 displayed when configuration errors occur. Here's the relevant bug:
1723 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1725 The rest of the solution involves surrounding the init method with a
1726 try/catch block and setting a global variable with the error /
1727 exception. A new async method should be created to retrieve and display
1728 the error message / exception.
1730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1731 code from constructor to init method adding exceptions as needed.
1733 2011-10-26 Ben Konrath <ben@bagu.org>
1735 Add script to monitor and restart tomcat if required.
1737 * utils/check-and-recover-tomcat.py: New file.
1739 2011-10-26 Ben Konrath <ben@bagu.org>
1741 Display the correct number of data items in the pager.
1745 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1747 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1748 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1749 The implementation is the same for both tables: Keep track of the
1750 number of non-empty rows and fire and RowCountChangeEvent after the data has
1752 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1753 custom Pager class that subclasses SimplePager to handle displaying
1754 the correct number when empty rows have been added.
1756 2011-10-26 Ben Konrath <ben@bagu.org>
1758 Correct error in previous commit.
1760 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1761 eventBus parameter from listView.setCellTable().
1763 2011-10-26 Ben Konrath <ben@bagu.org>
1765 Fix error in TODO comment.
1767 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1769 2011-10-24 Ben Konrath <ben@bagu.org>
1771 Create Notebook widgets to the details view.
1773 This isn't finished just yet - I still need to create a reasonable
1774 style to match the current theme.
1776 * src/main/java/org/glom/web/client/Utils.java: Add method for
1777 calculating the height of a widget. This is used in the Notebook class.
1778 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1779 new constructor method in Group.
1780 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1781 method for creating child widget that can be used by subclasses
1782 like Notebook. New constructor that allows disabling the group
1783 titles - Notebooks don't set a group title for their child groups.
1784 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1785 to make Notebooks using GWT's TabLayoutPanel.
1786 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1787 constructor that allows disabling the group titles.
1788 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1789 LayoutItemNotebook DTO.
1790 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1791 DTO for Notebooks. It's just an empty class for now but we might need
1792 it to transfer some specific information in the future.
1794 2011-10-21 Ben Konrath <ben@bagu.org>
1796 Add navigation buttons to related list tables.
1798 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1799 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1800 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1801 method getSuitableRecordToViewDetails() for getting the table name
1802 and primary key value for related list navigation buttons.
1803 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1804 private cell renderer class to get the navigation information for
1805 related list tables from the server. Extract the navigation
1806 processing code from the details cell navigation and use it for the
1807 related list navigation as well.
1808 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1809 cell renderer class for the details open buttons. This was needed
1810 because the related list navigation buttons and the list view
1811 navigation buttons need to react differently when clicked.
1812 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1813 the onEnterKeyDown() method because it's now overriden in the
1814 subclasses that are specific to the related list tables and the list
1816 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1817 the vertical size a little because the buttons add a bit of vertical
1818 space to table. This is not a perfect solution because the vertical
1819 size of with table fewer than 5 rows will be a little smaller.
1820 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1821 changes in how navigation buttons are handled.
1822 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1823 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1824 database access object.
1825 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1826 to find the portal for a given relationship name from
1827 RelatedListDBAccess. Add method to find a primary key field for a
1829 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1830 Move code to find the portal for a given relationship name to
1832 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1833 New file: database access object for getting the related list
1834 navigation information (the table name and the primary key value).
1835 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1836 DTO for transferring a table name to navigate to and a primary key
1838 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1839 boolean and getter/setter to specifies if the related list should add
1842 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1844 Use the master branch of java-libglom
1846 * pom.xml: Depend on java-libglom 1.19 instead.
1848 This is the master branch. See also the libglom-1-18 branch.
1850 2011-10-11 Ben Konrath <ben@bagu.org>
1852 Enable the open navigation button when the data has been set.
1854 This avoids having active buttons that don't do anything when the data
1857 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1859 2011-10-11 Ben Konrath <ben@bagu.org>
1861 Use IsWidget interface for FlowTableItem.
1863 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1864 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1866 2011-10-11 Ben Konrath <ben@bagu.org>
1868 Remove GWT styling from open button in details view.
1870 There are still some issues with how the details cell is arranged but
1871 this should be made to match Glom 1.20. I'm going to leave fixing this
1872 until I have Glom 1.20 up and running.
1874 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1875 style name on open button.
1876 * src/main/webapp/style.css: Move and edit details-navigation class.
1877 Re-arrange some classes to make them appear in the same order as the
1880 2011-10-07 Ben Konrath <ben@bagu.org>
1882 Update to GWT 2.4.0.
1884 * .gitignore: Ignore new cache directory.
1885 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1886 * pom.xml: Change GWT and maven plugin to 2.4.0.
1887 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1889 * src/main/java/org/glom/web/client/ClientFactory.java:
1890 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1891 * src/main/java/org/glom/web/client/OnlineGlom.java:
1892 Update source for API changes.
1893 * utils/build-onlineglom-war.sh: Remove cache directory before the
1896 2011-10-07 Ben Konrath <ben@bagu.org>
1898 Add navigation buttons in the details view.
1900 This isn't finished but I thought I'd commit what I have as it's a
1901 pretty good start. I still need to:
1903 1. Change the style so that it fits better into the current theme
1904 2. Adjust the details cell to expand as much as possible.
1906 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1907 click handlers to navigation buttons in the DetailsCells. Create a
1908 refreshData() method to get just the data from the server without the
1910 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1911 Update the tableSelector and browser title when the table name
1912 changes without using the tableSelector.
1913 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1914 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1915 getDetailsCells() to getCells(). Update variable names.
1916 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1917 method to set click handler on navigation button. Rename a few
1918 variables. Add navigation buttons where needed.
1919 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1920 variables and methods.
1921 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1922 navigation boolean and navigation table as required in the
1923 LayoutItemField DTO.
1924 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1925 variables for navigation along with getter/setter methods.
1927 2011-10-07 Ben Konrath <ben@bagu.org>
1929 Rename Field to DetailsCell.
1931 This is a refactor-only commit. No functionality has been added or
1934 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1935 Update variable and method names.
1936 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1937 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1938 variable and method names.
1939 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1941 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1942 variable and method names.
1944 2011-10-07 Ben Konrath <ben@bagu.org>
1946 Create separate methods for layout and data the details view.
1948 This is a refactor-only commit. No functionality has been added or
1951 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1952 private methods: setData(), createLayout().
1954 2011-10-07 Ben Konrath <ben@bagu.org>
1956 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1958 This is part of a change to get navigation buttons in the details view
1959 but it should have been done this way from the start.
1961 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1962 for method name change in TableSelectionView.
1963 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1964 Create TableChangeEvent and set the browser title using the
1965 TableSelectionView API.
1966 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1967 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1968 Change getSelectedTable() to getSelectedTableName(). Add
1969 getSelectedTableTitle().
1971 2011-10-07 Ben Konrath <ben@bagu.org>
1973 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1975 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1977 2011-10-07 Ben Konrath <ben@bagu.org>
1979 Update TableChangeEvent to use newTableName naming convention.
1981 This makes the class more consistent with GWT naming conventions.
1983 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1984 Update for method name change in TableChangeEvent.
1985 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1986 for method name change in TableChangeEvent.
1987 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1988 newTableName variable and getter method. Make toDebugString()
1991 2011-09-30 Ben Konrath <ben@bagu.org>
1993 Disable the pager in the list tables when the data row count is less than the minimum.
1995 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1996 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1998 2011-09-30 Ben Konrath <ben@bagu.org>
2000 Add empty rows to the end of related list and list view tables.
2002 I also extracted the cell rendering classes from the ListTable because
2003 the code was becoming a little crazy with all the anonymous inner
2004 classes. My plan is to use these cell rendering classes in the details
2005 view as well so this refactor will be needed for that change.
2007 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2008 set the row count in related list tables if the data has more rows
2009 than the minimum number of rows visible.
2010 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2011 row count in list view tables if the data has more rows than the
2012 minimum number of rows visible.
2013 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2014 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2016 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2017 for rendering TYPE_NUMERIC cells. The code was extracted from the
2019 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2020 class for rendering cells with buttons in list views. The code was
2021 extracted from the ListTable class.
2022 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2023 for rendering TYPE_TEXT cells. The code was extracted from the
2025 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2026 Add empty rows to the end of the data if required. Implement
2027 ListTable.getMinNumVisibleRows().
2028 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2029 cell renderer code to public classes. Return null in
2030 Column.getValue() for empty rows. Add new abstract method:
2031 getMinNumVisibleRows(). Move code to set the row count of the list view
2032 table to ListViewImpl.
2033 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2034 empty rows to the end of the data if required. Implement
2035 ListTable.getMinNumVisibleRows().
2038 2011-09-27 Ben Konrath <ben@bagu.org>
2040 Use GWT.log for client-side debugging statements.
2042 These are optimized out when deployed so I should have used this method
2043 in the first place. These statements will eventually be replaced with some sort
2044 of notification in the browser.
2046 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2047 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2048 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2049 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2050 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2052 2011-09-27 Ben Konrath <ben@bagu.org>
2054 Put tableselector on the right, back to list link on right.
2056 The idea is that the table selector is acting like a label for the
2057 currently displayed table so it should be placed below the document title. This
2058 puts the table title in a similar position to where it is in Glom.
2060 * mockups/details-contacts.html:
2061 * mockups/details-projects.html:
2062 * mockups/listview-contacts.html:
2063 * mockups/listview-projects.html:
2064 * mockups/style.css:
2065 Update mockups to match how the interfaces currently look.
2066 * src/main/webapp/style.css: Swap positions of backlink with the table
2067 selector. Add some space on the left side of the table selector to
2068 line things up with the document title.
2070 2011-09-27 Ben Konrath <ben@bagu.org>
2072 Add field colouring to details view.
2074 This change re-works how field colouring works. The colour formatting
2075 information is now set to the client with the layout information instead of
2076 with the data. This eliminates the need to send the same colour strings for
2077 data in list view column when colour information is set.
2079 In order to set an alternate colour for negative numeric values, the
2080 number is now sent to client and formatted with the GWT NumberFormat class.
2082 This change also fixes:
2084 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2086 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2087 internationalization framework which is needed for client side numeric
2089 * src/main/java/org/glom/web/client/Utils.java: New file for some
2090 client static utility methods.
2091 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2092 the DataItem object to the Field class. Use a utility method to
2093 create the foreignKeyValue string.
2094 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2095 alignment and text colours in the constructor. Add setData(DataItem)
2096 method. Remove setText(String) method.
2097 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2098 colour information to GlomTextCell. Create and use GlomNumberCell for
2099 rendering numbers. Use utility method to get the string for the
2100 primary key of the key provider. Re-work how the horizontal alignment
2102 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2103 formatting to layout information. Methods for converting the libglom
2104 formatting information were moved from DBAccess.
2105 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2106 numeric formatting (it's now done on the client side). Don't set text
2107 colours in DataItem. Move libglom formatting conversion methods to
2109 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2110 getters/setters for text colour information.
2111 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2112 for transferring the libglom NumericFormat information to the client.
2113 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2114 and getters/setters for: GlomNumericFormat, background colour and
2115 foreground colour strings.
2117 2011-09-26 Ben Konrath <ben@bagu.org>
2119 Simplify code that iterates through the LayoutGroup.
2121 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2123 2011-09-26 Ben Konrath <ben@bagu.org>
2125 Accept Eclipse formatting for OnlineGlomServiceAsync.
2127 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2129 2011-09-26 Ben Konrath <ben@bagu.org>
2131 Don't use the ListDBAccess classes to get the primary key layout information.
2133 This was causing a bug where the wrong index for the hidden primary key
2134 was being sent to the client.
2136 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2137 primary key while creating the LayoutGroup DTO. Create a
2138 LayoutItemField DTO for hidden primary keys. Don't use the
2139 RelatedListDBAccess because it was only used for getting the primary
2141 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2142 access modifier from public to protected for getPrimaryKeyField() and
2143 getPrimaryKeyLayoutItemField().
2144 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2145 abstract method getExpectedResultSize() because RelatedListDBAccess
2146 doesn't have enough info to implement it.
2147 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2148 Remove @Override for getExpectedResultSize().
2149 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2150 Remove method getExpectedResultSize().
2152 2011-09-23 Ben Konrath <ben@bagu.org>
2154 Log which layout (list or details) the ignored item is from.
2156 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2158 2011-09-23 Ben Konrath <ben@bagu.org>
2160 Remove annotations that turn off code formatting in DataItem.
2162 * src/main/java/org/glom/web/shared/DataItem.java:
2164 2011-09-23 Ben Konrath <ben@bagu.org>
2166 Rename GlomField to DataItem and update associated methods.
2168 This is a rename-only refactor. No functionality has been added or
2171 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2172 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2173 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2174 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2175 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2176 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2177 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2178 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2179 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2180 * src/main/java/org/glom/web/server/database/DBAccess.java:
2181 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2182 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2183 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2184 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2185 * src/main/java/org/glom/web/shared/DataItem.java:
2186 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2187 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2189 2011-09-23 Ben Konrath <ben@bagu.org>
2191 Rename GlomDocument to DocumentInfo and update associated methods.
2193 This is a rename-only refactor. No functionality has been added or
2196 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2197 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2198 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2199 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2200 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2202 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2204 2011-09-20 Ben Konrath <ben@bagu.org>
2206 Require java-libglom 1.17.3.
2208 This picks up the fix for the seg fault problem with the Scenes table
2209 in the Openismus Film Manager example.
2213 2011-09-20 Ben Konrath <ben@bagu.org>
2215 Change the way sort clause is added for primary key when no sort clause is requested.
2217 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2218 before the sort clause is created. When a sort clause is not requested, the
2219 sort clause is created by finding the primary key in the LayoutFieldVector
2222 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2224 2011-09-20 Ben Konrath <ben@bagu.org>
2226 Log error message if no documents are found in the configured directory.
2228 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2229 Extract the glom file extension string to a private static final class
2230 variable (mostly as syntactic sugar). Accept a minor formatting change.
2231 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2232 the example glom.document.directory configuration property to make it
2233 more clear that it can any directory, not just the home directory.
2235 2011-09-18 Ben Konrath <ben@bagu.org>
2237 Add related lists to details view.
2239 The related list table has support for paging and sorting just like the
2240 table in the list view.
2242 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2243 SQL queries for the related list tables.
2244 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2245 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2246 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2247 Rename getList methods to getListView and add comments. Remove
2248 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2249 it being unused. Add methods: getDetailsLayoutAndData(),
2250 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2251 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2252 Create the layout and set the data for the fields in one async call
2253 instead of two. Create related lists where appropriate.
2254 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2255 for method name changes in OnlineGlomService.
2256 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2257 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2258 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2260 * src/main/java/org/glom/web/client/ui/ListView.java:
2261 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2262 tableName from setCellTable(). Create a ListViewTable instead of
2264 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2265 represent a data field in the details view.
2266 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2267 from addDetailsCell() to Field class. Keep track of the Fields and
2268 Portals in the details view.
2269 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2270 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2271 and add a method to get it. Add method to set the contents of the
2273 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2274 New class for related list tables. This class has the data provider
2275 for the related list table.
2276 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2277 abstract class which is the base class for the ListViewTable and the
2279 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2280 New class for list view tables. This class has the data provider for
2281 the list view table.
2282 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2283 methods for related list tables. Add more information to the
2284 LayoutItemField and LayoutItemPortal DTOs.
2285 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2286 Remove debugging print statement.
2287 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2288 Remove debugging print statements. Add primary key field to SQL count
2290 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2291 Remove unnecessary LayoutFieldVector parameter from
2292 getResultSizeOfSQLQuery() method.
2293 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2294 New class for related list table database access.
2295 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2296 class that is a wrapper DTO for details view layout and data.
2297 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2298 new 'fromField' string to this DTO.
2299 * src/main/webapp/style.css: Remove bottom margin and override top
2302 2011-09-15 Ben Konrath <ben@bagu.org>
2304 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2306 This sets things up to make it easier to add the data retrieval for
2307 related lists (portals). No user noticeable changes were made with
2310 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2311 class has the code to retrieve the layouts and access the
2312 database using the new database helper classes.
2313 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2314 Most of the functionality has been removed from this class. This
2315 class now represents the public interface for the client side
2316 code. It also deals with configuring the servlet and cleaning
2317 things up when the servlet is stopped.
2318 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2319 of static methods into this utility class.
2320 * src/main/java/org/glom/web/server/database/DBAccess.java:
2321 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2322 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2323 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2324 These classes have the database retrieval code. The class hierarchy
2325 has been setup to make it easy to reuse code for similar
2328 2011-09-06 Ben Konrath <ben@bagu.org>
2330 Create separate classes for list table code and the data provider.
2332 As part of this refactor, I also split up the code a bit to make it
2335 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2336 table code to two new classes (below).
2337 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2338 with code from ListViewImpl.
2339 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2340 New file with code from ListViewImpl.
2342 2011-09-06 Ben Konrath <ben@bagu.org>
2344 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2346 This fixes the LayoutItemPortal DTO to match the libglom layout object
2349 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2351 2011-09-01 Ben Konrath <ben@bagu.org>
2353 Set title of Portals in the Details View.
2355 * pom.xml: Bump required version of java-libglom to 1.17.1.
2356 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2357 widget creation to its own class. Add comments to constructor.
2358 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2359 The code is mostly from the Group class with the title now set.
2360 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2361 title of Portal. Update some comments. Fix some code formatting.
2363 2011-09-01 Ben Konrath <ben@bagu.org>
2365 Remove TODO comment for the flow table column width.
2367 The flow table column width is working correctly and doesn't need to be
2368 changed. See this mailing list post for more info:
2370 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2372 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2374 2011-08-27 Ben Konrath <ben@bagu.org>
2376 Add document title (database name) to top of the browser page.
2378 I added the document title to the TableSelecitonView but that will
2379 change if / when we add a view that doesn't require table selection.
2381 * mockups/details-contacts.html:
2382 * mockups/details-projects.html:
2383 * mockups/listview-contacts.html:
2384 * mockups/listview-projects.html:
2385 * mockups/style.css: Add document title to mockups to keep things
2387 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2388 sizes to account for the document title.
2389 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2390 Set the document title when it has been retrieved from the server.
2391 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2392 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2393 and implement setDocumentTitle(String) method.
2394 * src/main/webapp/style.css: Add ID for document title style.
2396 2011-08-25 Ben Konrath <ben@bagu.org>
2398 Add NavigationType enum to LayoutItemPortal DTO.
2400 This is the start of adding support for Portals to the Details View.
2402 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2403 LayoutItem_Portal.navigation_type enum from libglom to
2404 LayoutItemPortal.NavigationType enum.
2405 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2406 NavigationType enum, field for storing the NavigationType and getter
2409 2011-08-25 Ben Konrath <ben@bagu.org>
2411 Implement the flow table layout in the Details View.
2413 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2414 FlowTable to Group to account for the renamed class.
2415 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2416 File. This is a container widget that implements the Glom details view
2417 flow table behaviour.
2418 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2419 org/glom/web/client/ui/FlowTable.java.
2420 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2421 so that the size of the subgroups are a closer match to the size of
2422 the Glom subgroups. This makes the flowtable layout match the layout
2423 in Glom for the Music Collection example file.
2425 2011-08-16 Ben Konrath <ben@bagu.org>
2427 Create container element for LayoutItemPortal in Details View.
2429 This will help me develop the layout for the FlowTable.
2431 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2432 fieldPanel variable to detailsCell.
2434 2011-08-15 Ben Konrath <ben@bagu.org>
2436 Set the height of the data element in the Details View.
2438 I changed the InlineLabels (text in a span element) to Labels (text in
2439 a div element) so that I could set the height of the details-data
2440 elements instead of the details-cell parent elements. This allows the
2441 the details-data element to display the correct height if style is
2442 applied that shows the height.
2444 This change has the added benefit of allowing the order of the labels
2445 and data elements to be changed for right-to-left languages.
2447 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2448 InlineLabels to Labels.
2449 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2450 InlineLabels to Labels. Set the height of the data element.
2451 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2452 multiline text height in the Formatting DTO.
2453 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2454 for multiline height along with getter and setter methods.
2455 * src/main/webapp/style.css: Adjust style to account for the change
2456 from span elements to div elements in the details cell.
2458 2011-08-15 Ben Konrath <ben@bagu.org>
2460 Make the List View appearance match the mockups.
2462 It doesn't match exactly but it's much better than it was.
2464 * mockups/listview-contacts.html: Remove unused css classes.
2465 * mockups/listview-projects.html: Remove unused css classes.
2466 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2467 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2468 for mainPanel instead of VerticalPanel (table). Set style name on
2469 CellTable. Set style name on Details column. Right-align Details
2471 * src/main/webapp/style.css: Adjust properties to match the mockups.
2473 2011-08-12 Ben Konrath <ben@bagu.org>
2475 Add better support for subgroups in the details view.
2477 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2478 changed FlowTable constructor.
2479 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2480 support for subgroups and subgroup-titles.
2481 * src/main/webapp/style.css: Add CSS class for subgroups and
2484 2011-08-12 Ben Konrath <ben@bagu.org>
2486 Return the top level LayoutGroup title.
2488 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2490 2011-08-11 Ben Konrath <ben@bagu.org>
2492 Make the TableSelector header match the mockup.
2494 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2495 the layout panel. Properly lineup the table selection header with
2496 the list and details view.
2497 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2498 margin around the details view.
2499 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2500 Rename listBox variable to tableSelector. Set id for the style sheet.
2501 Use a FlowPanel instead of a HorizontalPanel.
2502 * src/main/webapp/style.css: Add properties to make the TableSelector
2503 box match the mockups.
2505 2011-07-13 Ben Konrath <ben@bagu.org>
2507 Update install script for java-libglom version change.
2509 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2512 2011-07-13 Ben Konrath <ben@bagu.org>
2514 Add support sub-group in the details view.
2516 I also removed the code that special-cased the default details view
2519 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2521 I still have to make a proper flowtable.
2523 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2524 Don't special-case default details view layout.
2525 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2526 addLayoutField() as I'm going to use it.
2527 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2528 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2530 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2531 extracted from DetailsViewImpl.GroupPanel. Add support for
2533 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2534 column count when getting the details layout.
2536 2011-07-12 Ben Konrath <ben@bagu.org>
2538 Set browser title with database and table titles.
2540 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2541 Set the browser title when the table changes and when the activity
2543 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2544 title when retrieving document info (the GlomDocument object).
2545 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2546 with getter and setter methods. Remove unused convenience constructor.
2547 Use default code formatting.
2549 2011-07-12 Ben Konrath <ben@bagu.org>
2551 Ignore LayoutItemPortals in the details view.
2553 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2556 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2557 LayoutItemPortal layout objects.
2558 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2559 LayoutItemPortal objects when retrieving the details layout.
2560 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2561 file. This is an empty class and just used to get type information for
2564 2011-07-12 Ben Konrath <ben@bagu.org>
2566 Use java-libglom 1.17.0.
2570 2011-07-11 Ben Konrath <ben@bagu.org>
2572 Remove "Table:" label from table selector.
2574 This matches a recent change in the Glom UI.
2576 * mockups/details-contacts.html:
2577 * mockups/details-projects.html:
2578 * mockups/listview-contacts.html:
2579 * mockups/listview-projects.html: Remove the "Table:" label from the
2581 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2583 2011-07-11 Ben Konrath <ben@bagu.org>
2585 Add main groups to the details view.
2587 This makes things look a little nicer in the details view. The next step
2588 is to implement the flowtable.
2590 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2591 resources from the standard gwt css theme. Standard.css is now
2592 included in OnlineGlom.html so that the online glom css rules have
2593 precedence over the gwt theme.
2594 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2595 the whole LayoutGroup to the DetailsView instead of just the titles.
2596 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2597 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2598 details layout with a helper class (GroupPanel). I might extract this
2599 class when I make the full flowtable.
2600 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2601 string as default so I don't have to worry about NPEs when processing
2603 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2604 note beside OnlineGlom.gwt.xml above).
2605 * src/main/webapp/style.css: Add default font-size to body to override
2606 the font-size set by the standard theme. Don't use h2 tags for
2607 group-title. Create new details-cell class.
2609 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2611 ConfiguredDocument: Set the port number too.
2613 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2614 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2615 Glom document. Presumably this worked sometimes so far because there is a
2616 default port number.
2618 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2620 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2622 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2623 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2624 correct, though we should throw an exception too.
2626 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2628 Fix a addDocuemnt typo.
2630 * src/main/java/org/glom/web/shared/Documents.java
2631 (Documents.addDocuemnt): Rename to addDocument().
2632 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2633 (OnlineGlomServiceImpl.getDocuments): Adapt.
2635 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2637 Slightly improved log output when connection fails.
2639 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2640 (ConfiguredDocument.setUsernameAndPassword):
2641 We don't know for sure if it' the username/password that's wrong, so
2642 rephrase the message.
2643 Also ouput the exception message, though it's generic in this case.
2645 2011-07-08 Ben Konrath <ben@bagu.org>
2649 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2650 added braces to a one line if statement because the Eclipse formatter
2651 was getting confused.
2653 2011-07-07 Ben Konrath <ben@bagu.org>
2655 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2657 These should really be two separate tasks but I counldn't get things to
2658 work with GWT 2.2.0 and Eclipse 3.7.
2662 * .settings/org.eclipse.jdt.core.prefs:
2663 * .settings/org.eclipse.jdt.ui.prefs:
2664 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2665 * .settings/org.eclipse.m2e.core.prefs:
2666 Add new config files. Update current files. Remove references to the
2667 webtools plugins as we're not using any of the webtools features.
2668 * .gitignore: Add logs directory which is created when running with
2670 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2671 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2672 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2674 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2676 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2678 onlineglom.properties: Add explanatory comments.
2680 * src/main/resources/onlineglom.properties: Also change the default user
2681 from ben to someuser, to avoid the risk of people thinking we just
2682 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2684 2011-06-28 Ben Konrath <ben@bagu.org>
2686 Use filename in Log for incorrect passwords.
2688 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2689 getFileName(String) method to get the filename from the URI.
2691 2011-06-28 Ben Konrath <ben@bagu.org>
2693 Add the table name to the URL token for the ListPlace.
2695 This makes things consistent between the DetailsPlace and the
2696 ListPlace. It also allows the the ListPlace to be bookmarked.
2698 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2699 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2700 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2701 Remove getDefaultListLayout(). The default layout is now returned
2702 by the getListLayout() method when the table name is an empty string.
2703 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2704 Add table name field. Change to a new ListPlace when the table
2705 has been changed. Use getListLayout() for getting the default
2707 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2708 Add table name field. Set the correct table name in the list box
2709 when loading from bookmark. This corrects a problem for the
2711 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2712 Move table name to super-class (HasSelectableTable). Move document
2713 and table URL keys to super-class in HasSelectableTable.
2714 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2715 Add table name field. Add Tokenizer class with URL key common to
2716 the subclasses (DetailsPlace and ListPlace).
2717 * src/main/java/org/glom/web/client/place/ListPlace.java:
2718 Add table name. Add code to parse the URL token.
2719 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2720 Update ListPlace construction with empty table name string.
2721 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2722 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2723 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2724 Update ListPlace construction with table name string.
2725 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2726 Change defaultTableName field to tableName to reflect how it's now
2727 used. Update the getter and setter methods.
2729 2011-06-28 Ben Konrath <ben@bagu.org>
2731 Enable the table selector in the DetailsView.
2733 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2734 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2735 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2736 Remove getDefaultDetailsLayout(). The default layout is now returned
2737 by the getDetailsLayout() method when the table name is an empty
2739 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2740 event handler for table change event. Change to using
2741 getDetailsLayout() for the default details layout.
2742 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2744 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2745 when navigating to the details place.
2747 2011-06-27 Ben Konrath <ben@bagu.org>
2749 Use filename based unique document ID in URL and for RPC.
2751 The document ID is the glom document name with spaces (' ') replaced
2752 with pluses ('+') and without the .glom extension.
2754 This change is mostly a string substitution of 'documentTitle' for
2755 'documentID'. The only code change is the addition of a Documents DTO to get the
2756 filename to document title mappings as indicated below.
2758 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2759 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2760 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2761 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2762 Use Documents DTO to create the document links in the document
2764 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2765 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2766 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2767 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2768 * src/main/java/org/glom/web/client/place/ListPlace.java:
2769 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2770 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2771 * src/main/java/org/glom/web/client/ui/ListView.java:
2772 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2773 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2774 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2775 * src/main/java/org/glom/web/server/Log.java:
2776 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2777 getDocumentTitles() to getDocuments() and return the Documents DTO.
2778 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2779 transferring the filename to document title mappings.
2781 2011-06-25 Ben Konrath <ben@bagu.org>
2783 Make the authentication popup work again.
2785 This bug was introduced when I extracted ConfiguredDocument to its own class.
2787 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2788 correct success / fail status in setUsernameAndPassword().
2790 2011-06-25 Ben Konrath <ben@bagu.org>
2792 Use filename as unique key for configuring database usernames and passwords.
2794 This replaces the use of the Glom document title which could change
2795 depending on the locale. Thanks to Murray Cumming for pointing out this
2798 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2799 * src/main/resources/onlineglom.properties:
2801 2011-06-24 Ben Konrath <ben@bagu.org>
2803 Pass primary key value to DetailsView.
2805 This enables the DetailsView to load the correct data.
2807 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2808 primary key value field and set in constructor. Pass primary key
2809 value to getDetailsData().
2810 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2811 variables for document title and primary key value.
2812 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2813 key value to the DetailsPlace.
2815 2011-06-24 Ben Konrath <ben@bagu.org>
2817 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2819 This allows the primary key to be retrieved by the Details button. This
2820 functionality has not been implemented yet but it's in the works.
2822 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2823 the LayoutGroup result to ListView.setCellTable instead of all of its
2824 fields individually.
2825 * src/main/java/org/glom/web/client/ui/ListView.java:
2826 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2827 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2828 get the primary key for the table.
2829 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2830 index of the primary key in the LayoutGroup accounting for hidden
2831 primary keys. Rename getJavaNumberFormat() to
2832 convertToJavaNumberFormat() for consistency. Cleanup / add some
2834 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2835 field for primary key index and a field to indicate whether the
2836 primary key is hidden or not.
2838 2011-06-23 Ben Konrath <ben@bagu.org>
2840 Rename getTableData methods to getListData.
2842 This is a rename refactor for consistency with other methods.
2844 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2845 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2846 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2847 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2849 2011-06-23 Ben Konrath <ben@bagu.org>
2851 Extract the ConfiguredDocument innerclass into its own class.
2853 This makes the servlet code more object oriented.
2855 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2856 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2857 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2858 new ConfiguredDocument class.
2860 2011-06-21 Ben Konrath <ben@bagu.org>
2862 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2864 This makes things more inline with how libglom works and reduces code
2865 duplication. This refactor lays the groundwork for adding the primary key to
2866 the LayoutGroup object.
2868 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2869 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2870 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2871 Change method names to getListLayout and getDefaultListLayout for
2872 consistency. Use LayoutGroup as the DTO for the list layout instead of
2873 ColumnInfo and LayoutListTable.
2874 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2875 new method names along with the LayoutGroup object for transferring the
2877 * src/main/java/org/glom/web/client/ui/ListView.java:
2878 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2879 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2880 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2882 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2883 Replaced with LayoutGroup.
2884 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2885 expectedResultSize and defaultTableName fields which are needed for
2887 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2888 type field which is needed for the list layout but will also be
2889 useful for the details layout as things progress.
2890 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2891 Make class abstract. Remove the unnecessary
2892 getFormattingHorizontalAlignment method. Add setFormatting method.
2894 2011-06-16 Ben Konrath <ben@bagu.org>
2896 Add scripts for building and installing war.
2898 These will help when updating OnlineGlom but they're also good
2899 supplemental documentation of the build and deployment proceeding.
2901 * utils/build-onlineglom-war.sh: New file.
2902 * utils/install-onlineglom-war.sh: New file.
2904 2011-06-16 Ben Konrath <ben@bagu.org>
2906 Create wrapper class to create consistent log messages.
2908 I wrapped methods in the Log class of gwt-log to add the method names
2909 from the servlet and create consistent formatting of the document title
2910 and table names in the log messages.
2912 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2913 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2914 log methods to use methods from wrapped Log class.
2916 2011-06-16 Ben Konrath <ben@bagu.org>
2918 Remove superfluous conditional return.
2920 Thanks to Murray Cumming for pointing this out!
2922 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2924 2011-06-15 Ben Konrath <ben@bagu.org>
2926 Return an ArrayList of LayoutGroups for the Details layout.
2928 This corrects a problem with the details layout as it can have more
2929 than one top level LayoutGroup.
2931 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2932 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2933 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2934 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2935 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2936 with ArrayList of LayoutGroups for the details view layout.
2937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2938 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2939 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2940 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2941 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2942 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2944 2011-06-14 Ben Konrath <ben@bagu.org>
2946 Use cast_dynamic method to determine the libglom LayoutItem type.
2948 This is better than finding the LayoutItem type by using the string
2949 returned from the get_part_type_name() method.
2951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2953 2011-06-14 Ben Konrath <ben@bagu.org>
2955 Add method names to log entries in the servlet.
2957 This helps when tracking down deployment problems.
2959 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2961 2011-06-14 Ben Konrath <ben@bagu.org>
2963 Add data to the DetailsView using a hard-coded primary key value.
2965 The layout and functionality of the DetailsView is not complete. This
2966 is just a checkpoint so the patch doesn't get too big.
2968 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2969 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2970 Add getDetailsData() servlet method.
2971 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2972 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2973 LayoutFields are added to the DetailsView.
2974 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2975 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2976 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2977 take the string for the title instead of the object.
2978 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2979 Add implementation getDetailsData() along with some private helper
2981 * src/main/webapp/style.css: Add padding to details-data class. Add a
2982 details-label class with the same padding as the details-data class.
2984 2011-06-03 Ben Konrath <ben@bagu.org>
2986 Use presenter.goTo() to change to the DetailsPlace.
2988 This will make things easier when we need to open the DetailsView with
2989 data specific to the row that was clicked.
2991 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2993 2011-06-02 Ben Konrath <ben@bagu.org>
2995 Add CSS file from mockups.
2997 I'm adding this now because it's going to be useful to have when
2998 developing the DetailsView. The TableSelectionView and ListView aren't
3001 * src/main/webapp/OnlineGlom.html:
3002 * src/main/webapp/style.css:
3004 2011-06-02 Ben Konrath <ben@bagu.org>
3006 Use String.isEmpty() to check for empty string.
3008 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3010 2011-06-02 Ben Konrath <ben@bagu.org>
3012 Display main layout group titles in the DetailsView.
3014 This is the start of the DetailsActivity/DetailsView implementation.
3016 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3017 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3018 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
3019 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3020 Get the layout information for the details view from the server and set
3021 the main layout group titles.
3022 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3023 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3024 Add addLayoutGroup() and addLayoutField() methods. This are just
3025 temporary methods for creating the the details view that will change
3027 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3028 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
3030 * src/main/java/org/glom/web/shared/layout/Formatting.java:
3031 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3032 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
3033 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
3034 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3035 Data Transfer Objects that mimic the libglom object structure. These are
3036 used for transferring the details layout but could also be used for
3037 transferring the list layout.
3039 2011-05-27 Ben Konrath <ben@bagu.org>
3041 Reset the AuthenticationPopup when clearing the ListView.
3043 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3045 2011-05-27 Ben Konrath <ben@bagu.org>
3047 Fix problem with onlineglom.properties file loading.
3049 The old way worked in Eclipse but not on the server. Loading the
3050 onlineglom.properties file now works in Eclipse and on the server.
3052 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3054 2011-05-24 Ben Konrath <ben@bagu.org>
3056 Update gwt-log from 3.1.0 to 3.1.2.
3058 Gwt-log 3.1.0 has been marked as depreciated.
3062 2011-05-24 Ben Konrath <ben@bagu.org>
3064 Add comment to ListActivity.goTo() method.
3066 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3068 2011-05-24 Ben Konrath <ben@bagu.org>
3070 Remove FIXME in convertGdkColorToHtmlColour()
3072 The Gdk::Color value returned by libglom is 16-bits per channel on both
3073 64 and 32-bit platforms.
3075 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3077 2011-05-19 Ben Konrath <ben@bagu.org>
3079 Improve performance of initial ListView load.
3081 I removed a round trip to the server for getting the default table name
3082 and then requesting information about that table. This also removes a potential
3083 problem with the table change handler not being setup in time to receive the
3084 table change event from the ListActivity.
3086 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3087 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3088 getDefaultLayoutListTable() method. Improve comments.
3089 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
3090 getDefaultLayoutListTable() method instead of firing a table change
3091 event to get the table to load.
3092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3093 implementation of getDefaultLayoutListTable() method.
3094 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3097 2011-05-19 Ben Konrath <ben@bagu.org>
3099 Override toDebugString() in TableChangeEvent.
3101 This is useful to have for debugging.
3103 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3105 2011-05-19 Ben Konrath <ben@bagu.org>
3107 Add a "Back to List" link when at the DetailsPlace.
3109 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3110 Populate the CellTable based on the selected table of the ListBox if
3111 it's set otherwise use the default table. This allows the "Back to
3113 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3114 Remove Place from constructors. Add a setPlace() method. Add
3115 goToPlace() method. Set class as presenter for TableSelectionView.
3116 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3117 Use the same TableSelectionActivity when switching between the List and
3119 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3120 Subclass the new HasSelectableTablePlace. This removes some duplicate
3122 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3123 New class to represent Places that display the TableSelectionView.
3124 * src/main/java/org/glom/web/client/place/ListPlace.java:
3125 Subclass the new HasSelectableTablePlace. This removes some duplicate
3127 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3128 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3129 Add Presenter interface. Add setBackLinkVisible() method. Add
3130 setBackLink() method.
3132 2011-05-18 Ben Konrath <ben@bagu.org>
3134 Enable the "Details" buttons.
3136 Right now only an empty details view is displayed.
3138 * src/main/java/org/glom/web/client/ClientFactory.java:
3139 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3140 Add DetailsView to ClientFactory.
3141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3142 A basic activity for the details view.
3143 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3144 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3146 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3147 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3149 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3150 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3151 unnecessary super() in constructor.
3152 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3153 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3154 really shouldn't create a new TableSelectionActivity for both the ListPlace
3155 and the DetailsPlace so this should be considered a temporary solution.
3156 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3157 New file. Represents a URL for the details view.
3158 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3159 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3160 A basic details view interface and implementation.
3161 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3162 Enable the "Details" buttons.
3164 2011-05-12 Ben Konrath <ben@bagu.org>
3166 Use a LayoutPanel with multiple display areas for main layout.
3168 This is mostly a refactor in that there are no changes from the user
3169 point of view. These changes are required so that we can swap out the list view
3170 with the details view when the user clicks the "Details" button.
3172 * src/main/java/org/glom/web/client/ClientFactory.java:
3173 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3174 OnlineGlomView. Add TableSelectionView, ListView and
3175 AuthenticationPopup.
3176 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3177 for main layout. Add display regions for main activities. Add
3178 activity manager for for main activities.
3179 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3180 file from parts of the deleted OnlineGlomActivity.
3181 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3182 New file from parts of the deleted OnlineGlomActivity.
3183 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3184 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3185 New files for app wide table change event.
3186 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3187 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3188 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3189 Activity mappers for the main activities replace the deleted app-wide
3191 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3192 Fix a spelling error in he comment.
3193 * src/main/java/org/glom/web/client/ui/ListView.java:
3194 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3195 Renamed from LayoutListView and modified for MVP. This still not a
3196 proper dumb view as prescribed by the MVP pattern but it works for now.
3197 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3198 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3199 New widget stripped out of the deleted OnlineGlomView.
3200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3201 Remove hack that is fixed by this patch.
3203 2011-05-06 Ben Konrath <ben@bagu.org>
3205 Rename OnlineGlomPlace to ListPlace.
3207 The only change besides the rename is that url will now display #list
3208 instead of #Document.
3210 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3211 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3212 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3213 * src/main/java/org/glom/web/client/place/ListPlace.java:
3214 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3216 2011-05-06 Ben Konrath <ben@bagu.org>
3218 Use Presenter for app navigation.
3220 This is the proper way to deal with Place (URL) changes with the MVP
3223 * src/main/java/org/glom/web/client/ClientFactory.java:
3224 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3225 PlaceHistoryMapper and PlaceHistoryHandler.
3226 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3227 PlaceHistoryMapper and PlaceHistoryHandler.
3228 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3229 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3230 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java: