1 2012-04-12 Murray Cumming <murrayc@murrayc.com>
3 Use the latest java-libglom version.
5 * pom.xml: Use java-libglom 1.21.8.
7 2012-04-12 Murray Cumming <murrayc@murrayc.com>
9 Translations: Add Esperanto.
11 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
12 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
13 properties: Add this translation because someone took the time to make it.
15 2012-03-15 Murray Cumming <murrayc@murrayc.com>
17 Use the latest java-libglom version.
19 * pom.xml: Use java-libglom 1.21.7.
21 2012-03-03 Ben Konrath <ben@bagu.org>
23 Display date and time in details view.
25 https://bugzilla.gnome.org/show_bug.cgi?id=671257
27 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
29 2012-02-24 Ben Konrath <ben@bagu.org>
31 Improve the tabs in the Notebook widget.
35 2012-01-30 Murray Cumming <murrayc@murrayc.com>
37 Translations: Try to translate the strings.
39 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
40 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
41 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
42 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
43 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
44 Take the Open translation from GTK+'s .po files.
45 Take the Details translation from Glom's po files.
46 I have added the other strings to Glom so we can get translations that way:
47 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
49 2012-01-27 Murray Cumming <murrayc@murrayc.com>
51 TableSelectionViewImpl: Put the search label and entry in a div.
53 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
54 Put the search widgets in a FlowTable so that the CSS can be used to
55 style them while keeping them together.
56 * src/main/webapp/style.css: Mention the new div.
58 2012-01-27 Murray Cumming <murrayc@murrayc.com>
60 Translate more strings in more locales.
62 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
63 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
64 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
65 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
66 Translate the "Details" and "Open" string too.
68 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
69 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
70 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
71 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
72 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
73 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
74 Add these new locales as placeholders though they currently contain English.
76 2012-01-27 Murray Cumming <murrayc@murrayc.com>
78 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
80 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
81 Check the ConfiguredDocument* for null before using it.
83 2012-01-26 Murray Cumming <murrayc@murrayc.com>
85 Tell Eclipse about the generated java files.
87 * .classpath: This lets it find OnlineGlomConstants.java.
88 It would be nice if Eclipse just used the maven build files.
90 2012-01-26 Murray Cumming <murrayc@murrayc.com>
92 Prevent a crash when no locale is specified in the URL.
94 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
95 Avoid returning a null string, obtained from
96 Window.Location.getParameter(). This caused a crash when it was
97 later passed to libglom's API.
98 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
99 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
100 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
101 guard against future null strings.
103 2012-01-26 Murray Cumming <murrayc@murrayc.com>
105 Use the ?locale= query param instead of the &lang= token param.
107 * src/main/java/org/glom/web/client/place/ListPlace.java
108 * src/main/java/org/glom/web/client/place/DetailsPlace.java
109 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
110 Remove the lang token key and value.
112 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
113 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
114 When the user selects a different locale from the chooser, use
115 Window.Location.assign() to change the URL, which then causes a reload.
117 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
118 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
119 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
120 * src/main/java/org/glom/web/client/activity/ListActivity.java
121 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
122 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
123 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
124 * src/main/java/org/glom/web/client/ui/ListView.java:
125 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
127 Remove localeID member variables and method/constructor parameters, instead
128 using Utils.getCurrentLocaleID() when we need a localID to pass to
131 2012-01-26 Murray Cumming <murrayc@murrayc.com>
133 Internationalize the UI strings.
135 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
136 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
137 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
138 because it is unused. Messages are apparently strings that can have
139 parameters, but we do not need that yet, so Contants will be enough for now.
140 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
141 to say that we support the en and de locales.
142 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
143 The original English strings.
144 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
145 Some German translations of the English strings.
146 The i18n goal then uses the .properties file to generate an
147 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
148 returns an implementation that returns the translated strings.
149 The documentation suggests putting these in src/java/*/client/, but it seems
150 best to put it in src/resources/*/client/.
151 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
152 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
153 instead of hard-coding them.
154 Note that we cannot import OnlineGlomConstants because it does not exist yet,
155 but that does not seem to stop the build, though it confuses Eclipse.
157 You can see the translated string by adding ?locale=de to the URL, like so:
158 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
160 2012-01-24 Murray Cumming <murrayc@murrayc.com>
162 Improve null/empty String checks.
164 * pom.xml: Add a dependency on commons-lang, to use
165 org.apache.commons.lang.StringUtils.
166 * src/main/java/org/glom/web/server/ConfiguredDocument.java
167 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
168 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
169 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
170 Use StringUtils.isEmpty().
172 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
173 StringUtils class with a static isEmpty() function because we
174 cannot use org.apache.commons.lang.StringUtils in client-side
175 GWT code because it (apparently) cannot be compiled to javascript.
176 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
177 * src/main/java/org/glom/web/client/activity/ListActivity.java
178 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
179 * src/main/java/org/glom/web/client/place/DetailsPlace.java
180 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
181 * src/main/java/org/glom/web/client/place/ListPlace.java
182 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
183 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
184 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
185 * src/main/java/org/glom/web/client/ui/details/Group.java
186 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
187 our StringUtils.isEmpty() function.
189 2012-01-24 Murray Cumming <murrayc@murrayc.com>
191 Update to the latest java-libglom API.
193 * pom.xml: Require java-libglom 1.21.4.
194 * src/main/java/org/glom/web/server/ConfiguredDocument.java
195 getDocumentInfo(), getListViewLayoutGroup():
196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
198 * src/main/java/org/glom/web/server/database/DBAccess.java
199 getFieldsToShowForSQLQueryAddGroup(),
200 getPrimaryKeyLayoutItemField(): Replace get_database_title()
201 with either get_database_title_original() or
202 get_database_title(localeID).
204 2012-01-24 Murray Cumming <murrayc@murrayc.com>
206 ConfiguredDocument: Avoid a null pointer exception.
208 * src/main/java/org/glom/web/server/ConfiguredDocument.java
209 Initialize localeID to "" to avoid returning a null String which
210 causes a crash in java-libglom's swing-generated code.
212 2012-01-23 Murray Cumming <murrayc@murrayc.com>
214 Some simple renaming.
216 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
217 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
218 for localeChooser. This seems more appropriate and is less ambiguous
219 particularly in the .css file.
221 2012-01-23 Murray Cumming <murrayc@murrayc.com>
223 ConfiguredDocument: Rename the localedID private member variable.
225 2012-01-23 Murray Cumming <murrayc@murrayc.com>
227 Adapt to the latest java-libglom API from git master.
229 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
230 libglom now uses only Vector instead of List, which uses add() instead of
233 2012-01-20 Murray Cumming <murrayc@murrayc.com>
235 Build a source tarball with mvn assembly:single
237 * assembly.xml: Add this file.
238 * pom.xml: Use the maven-assembly-plugin and tell it to use
239 our assembly.xml file.
241 2012-01-19 Murray Cumming <murrayc@murrayc.com>
243 OnlineGlomServiceImpl: Get .glom files recursively.
245 * pom.xml: Depend on commons-io from org.apache.commons.
246 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
247 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
248 files recursively, and with the easier filter for the extension.
249 Use org.apache.commons.io.FilenameUtils.removeExtension() to
250 simplify that code too.
252 2012-01-19 Murray Cumming <murrayc@murrayc.com>
254 README: Mention that you must install java-libglom packages separately.
256 But then it works, because java-libglom is now in the central maven
259 2012-01-18 Murray Cumming <murrayc@murrayc.com>
261 locales drop-down: Show the correct selected locale when the URL changes.
263 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
264 .java: setPlace(): Move some code into fillView().
266 2012-01-18 Murray Cumming <murrayc@murrayc.com>
268 locales drop-down: Do not lose the primary key.
270 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
271 start(): onLocaleChange(): Pass the current primary key value,
272 instead of an empty value.
274 2012-01-18 Murray Cumming <murrayc@murrayc.com>
276 locales drop-down: Do not lose the drop-down selection.
278 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
279 .java (TableSelectionActivity.fillView): Set the selected locale
280 after changing the drop-down items (though we do not really need
281 to change them just because the locale changes.)
283 2012-01-18 Murray Cumming <murrayc@murrayc.com>
285 locales drop-down: Change the tables list when this changes.
287 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
288 .java: TableSelectionActivity.start(): Move the async table titles
289 retrieval into a private fillView() method and also call this when
290 the chosen locale changes.
291 Note that the document title is not actually translatable yet, but
292 that is a problem that I should fix soon in libglom.
294 2012-01-18 Murray Cumming <murrayc@murrayc.com>
296 Improve the placement of the locales drop-down.
298 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
299 Put the title and locales drop-down in a div (gwt.FlowTable).
300 * src/main/webapp/style.css: Add magic css properties to make this work.
301 Also remove the left margin from the title so that it lines up with the
304 2012-01-18 Murray Cumming <murrayc@murrayc.com>
306 locales selector: Show human-readable locale titles.
308 * src/main/java/org/glom/web/server/ConfiguredDocument.java
309 getDocumentInfo(): Use java.util.Locale to show a real title of
310 each locale, in the locale's own language.
312 2012-01-17 Murray Cumming <murrayc@murrayc.com>
314 Add a language/locale selector drop-down.
316 * src/main/java/org/glom/web/shared/DocumentInfo.java:
317 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
318 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
319 getDocumentInfo(): Store the available Locales in the DocumentInfo.
320 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
321 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
322 Add a ListBox to show the available locales. Add getLocaleSelector(),
323 setLocaleList(), getSelectedLocale(), setSelectedLocale().
324 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
325 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
326 java: Add these classes.
327 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
328 start(): Fill the locales ListBox. Handle its change event, firing a
330 setPlace(): Show the selected locale as specified by the URL token.
331 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
332 * src/main/java/org/glom/web/client/activity/ListActivity.java:
333 Handle LocaleChangeEvent, going to a new *Place with that locale.
335 The placement of the ListBox is not pretty, and it currently uses the ID
336 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
340 2012-01-17 Murray Cumming <murrayc@murrayc.com>
342 Search box: Show the search text from the URL token.
344 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
345 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
346 Add setQuickFindText().
347 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
348 .java: setPlace(): Store the queryText if the place is a ListPlace,
349 and call TableSelectionView.setQuickFindText().
351 2012-01-17 Murray Cumming <murrayc@murrayc.com>
353 Allow use of translations via, for instance, &lang=de in the URL.
355 * pom.xml: Use the unstable java-libglom 1.21 version.
357 * src/main/java/org/glom/web/client/OnlineGlomService.java:
358 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
359 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
360 init(): Instead of calling TranslatableItem.set_current_locale()
361 (now removed), call ConfiguredDocument.setDefaultLocaleID().
362 However, this is only for default locales, which are not needed to
363 change the locale in the URL.
364 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
365 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
366 getSortedRelatedListData(): Add a localeID parameter, so we can get the
367 layout for a particular locale.
368 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
369 Add get/setDefaultLocaleID().
370 getDocumentInfo(), getListViewData(), getRelatedListData(),
371 getDetailsLayoutGroup(), getListViewLayoutGroup(),
372 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
373 localeID parameter, so we can get the layout for a particular locale.
375 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
376 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
377 * src/main/java/org/glom/web/client/place/ListPlace.java:
378 Parse and construct a lang parameter too.
380 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
381 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
382 passed to subsequent methods and constructors.
383 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
384 * src/main/java/org/glom/web/client/activity/ListActivity.java:
385 Store the localeID from the *Place and pass it to other constructors
386 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
388 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
389 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
390 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
391 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
392 * src/main/java/org/glom/web/client/ui/ListView.java:
393 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
394 Take localeID parameters and pass them to subsequent constructors and
395 methods, so that the layout is always retrieved for that locale.
397 This is rather repetitive.
399 Note that "" means the original (default) locale of the Glom document,
400 which is usually English.
402 2012-01-17 Murray Cumming <murrayc@murrayc.com>
404 Documents: Remove final keyword to fix startup configuration.
406 * src/main/java/org/glom/web/shared/Documents.java: Remove the
407 final keywords on the private member variables because that breaks
408 the startup, apparently (there are warnings) because it stops them
409 from being serialized. I added these in the previous commit.
411 2012-01-13 Murray Cumming <murrayc@murrayc.com>
413 Documents: Add some final keywords.
415 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
418 2012-01-13 Murray Cumming <murrayc@murrayc.com>
420 OnlineGlomServiceImpl: Add to overview comments.
422 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
423 Note that this is where all the document are loaded. They are not
424 loaded freshly for each page.
426 2012-01-12 Murray Cumming <murrayc@murrayc.com>
430 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
431 Add a TextBox for the text of a quick find.
432 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
434 setBackLink(): Add a String quickFind parameter.
435 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
436 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
437 to the base interface, because that is how TableSelectionViewImpl is used.
438 * src/main/webapp/style.css: Add style for the search box and its label.
440 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
441 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
442 Add these files, based on the existing TableChangeEvent and
443 TableChangeEventHandlers.
444 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
445 start(): Handle QuickFindChangeEvent, passing its quickFind text to
446 a ListPlace() that the user should be taken to.
447 * src/main/java/org/glom/web/client/activity/ListActivity.java
448 start(): Handle it here too and adapt the TableChangeEvent handler to
449 pass the extra "" quickFind parameter to ListPlace.
450 * src/main/java/org/glom/web/client/place/ListPlace.java:
451 Constructor: Take an extra String quickFind parameter and store it,
452 returning it from a new getQuickFind() method.
453 getToken(): Put the quickFind text in the URL token.
454 getPlace(): Parse the quickFind text from the URL token.
455 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
456 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
457 ListPlace constructor.
458 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
459 .java: start(): Add a Change handler for the TableSelectionView's
460 TextBox (via its base HasChangeHandlers interface), firing the new
461 QuickFindChangeEvent.
462 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
463 pass the extra "" quickFind parameter.
465 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
466 setCellTable(): Add a String quickFind parameter and pass it to
467 the ListViewTable() constructor.
468 * src/main/java/org/glom/web/client/ui/ListView.java: Change
469 setCellTable() in the base interface, because that is how ListViewImpl
472 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
473 Add a String quickFind member variable.
474 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
475 Constructor: Add a String quickFind parameter, storing it in the
476 base ListTable's member variable.
477 onRangeChanged(): Pass quickFind to the
478 OnlineGlomServiceAsync.getSortedListViewData() and
479 OnlineGlomServiceAsync.getListViewData() methods.
481 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
482 getListViewData(), getSortedListViewData(): Add a String quickFind
483 parameter, passing it to ConfiguredDocument.getListViewData().
484 * src/main/java/org/glom/web/client/OnlineGlomService.java:
485 Change getListViewData(), getSortedListViewData() in the base interface,
486 because that is how OnlineGlomServiceImpl is used, via this:
487 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
488 Change getListViewData(), getSortedListViewData() here too.
489 This class can apparently be used to asynchronously call methods on
490 OnlineGlomService, and GWT seems to implement that after recognizing
491 just the *Async name convention and the extra AsyncCallback parameters.
493 * src/main/java/org/glom/web/server/ConfiguredDocument.java
494 getListViewData(): Add a String quickFind parameter, and pass it to
495 ListViewDBAccess.getData().
496 * src/main/java/org/glom/web/server/database/ListDBAccess.java
497 getListData(): Add a String quickFind parameter and pass it to
499 getSelectQuery(): Add a String quickFind parameter.
500 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
501 getSelectQuery(): Add a String quickFind parameter and use it with
502 Glom.get_find_where_clause_quick() to pass a where_clause to
503 Glom.build_sql_select_with_where_clause(), to actually filter the
505 getData(): Add a String quickFind parameter, passing it to getListData().
506 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
507 va: getData(): Pass an empty string to getListData() for the
510 2012-01-12 Murray Cumming <murrayc@murrayc.com>
512 ListTable: Minor change.
514 * src/main/java/org/glom/web/client/ui/list/ListTable.java
515 createCellTable(): Make this protected instead of public.
517 2012-01-12 Murray Cumming <murrayc@murrayc.com>
519 Many files: Use final for the parameters and use the @override attribute.
521 2012-01-22 Ben Konrath <ben@bagu.org>
523 Add anchor links for single line text that starts with http, ftp and www.
527 2012-01-22 Ben Konrath <ben@bagu.org>
529 Add ellipsis to single line text in details view.
533 2012-01-04 Murray Cumming <murrayc@murrayc.com>
535 Remove all javadoc author tags.
537 Because they are awkward and meaningless when many people touch
539 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
541 2012-01-04 Murray Cumming <murrayc@murrayc.com>
543 Revert the COPYING.LESSER to COPYING rename.
545 Apparently both should be there if it is LGPL.
547 2012-01-03 Murray Cumming <murrayc@murrayc.com>
549 *View: Remove unused imports.
551 * src/main/java/org/glom/web/client/ui/DetailsView.java:
552 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
553 * src/main/java/org/glom/web/client/ui/ListView.java:
554 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
555 Remove unused imports, as suggested by Eclipse.
557 2012-01-02 Murray Cumming <murrayc@murrayc.com>
559 Move the *View::Presenter types, and some API into one base View.
561 * src/main/java/org/glom/web/client/ui/DetailsView.java:
562 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
563 * src/main/java/org/glom/web/client/ui/ListView.java:
564 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
565 Presenter, setPresenter() and clear() into a shared base interface,
566 to avoid the unnecessary duplicate Presenter types and to more clearly
567 show how the *Views share the same structure, even if they are not
568 used polymorphically.
570 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
571 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
573 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
574 * src/main/java/org/glom/web/client/activity/ListActivity.java:
575 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
577 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
580 Feel free to revert this if there is a good reason for the duplicate
583 2012-01-02 Murray Cumming <murrayc@murrayc.com>
585 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
587 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
588 a class member instead of a local variable in the method.
589 This lets us use it to get the view instances, for use in tests.
590 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
591 beforeOnlineGlom(): Test some more details of the initial view.
592 Again, this is not very useful.
594 To really test gwt-glom we will need to start a local postgresql
595 instance with local data, like the Glom tests in C++.
597 2012-01-02 Murray Cumming <murrayc@murrayc.com>
599 pom.xml: Mention the LGPL license.
601 * pom.xml: Add a licenses section.
602 * COPYING.LESSER: Move this to COPYING, which
603 previously contained the GPL. But gwt-glom is all LGPL.
605 2012-01-02 Murray Cumming <murrayc@murrayc.com>
607 Add project information to README and pom.xml.
609 * README: Add a brief description and mention some mvn
611 * pom.xml: This extra information shows up in mvn site
614 2011-01-02 Murray Cumming <murrayc@murrayc.com>
616 Use the latest java-libglom version.
618 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
620 2012-01-01 Murray Cumming <murrayc@murrayc.com>
622 GwtTestOnlineGlom: Test a little more.
624 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
625 protected rather than private, as suggested by the gwt-test-utils
627 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
628 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
629 Test the initial visibility of the panels.
631 However, this is not a very useful test.
632 And I wonder how we should generally test using this idea for an
633 activity/places app like ours where the real changes happen implicitly
634 based on the history token/URL.
636 2012-01-01 Murray Cumming <murrayc@murrayc.com>
638 Slight modification to *Mapper comments.
640 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
642 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
644 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
646 Remove comments mentioning GIN because they are just copied from
647 the example code and are apparently not helpful:
648 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
649 Also change the mention of a class that is only in the example code.
651 2012-01-01 Murray Cumming <murrayc@murrayc.com>
653 GwtTestOnlineGlom test: Minor changes.
655 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
656 Avoid the long qualified class name and modify the comment
657 because it is now obvious to me that the mocked class is the only
658 custom one created via GWT.create().
660 2012-01-01 Murray Cumming <murrayc@murrayc.com>
662 Tests: Added the beginnings of a test using gwt-test-utils.
664 * pom.xml: Add dependencies on gwt-test-utils and easymock.
665 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
666 which tells gwt-test-utils what class will be tested.
667 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
668 Add a simple (but empty) test case. One class, used by the OnlineGlom
669 class, is mocked so that it can be created. However, I am not sure
670 why only this class needs to be mocked.
672 Note that mockito seems more popular, and clearer, than easymock,
673 but I have not got that working yet. It might be a matter of the
676 This test is run during mvn integration-test.
678 2011-12-31 Murray Cumming <murrayc@murrayc.com>
680 Tests: Use junit4-style syntax instead of junit3-style.
682 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
683 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
684 * src/test/java/org/glom/web/shared/DataItemTest.java:
685 Use the @Test annotation rather than relying on the test*() prefix.
686 Also no longer implement TestCase, to avoid triggering support for
687 the junit3-way, which stops the annotations from working.
688 Change the imports from import junit.framework.* to
689 import org.junit.*, which is apparently the new way.
691 2011-12-31 Murray Cumming <murrayc@murrayc.com>
693 Added a test for ListPlace token parsing and creation.
695 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
696 This is much the same as DetailsPlaceTest.
698 I wonder how we could test the other parts of the *Place API.
700 2011-12-30 Murray Cumming <murrayc@murrayc.com>
702 DetailsPlace test: Also test getToken() and recreation via getPlace().
704 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
705 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
706 recreate it, testing the recreated DetailsPlace for the same parameter
709 2011-12-30 Murray Cumming <murrayc@murrayc.com>
711 Use the surefire-report plugin.
713 * pom.xml: This generates a HTML report about the tests in
714 target/site/surefire-report.html
715 when you do mvn surefire-report:report. It seems to be popular/normal.
717 2011-12-30 Murray Cumming <murrayc@murrayc.com>
719 Added a test for DetailsPlace.
721 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
722 Test the getPlace() token parsing.
724 2011-12-30 Murray Cumming <murrayc@murrayc.com>
726 Added a first unit test.
728 * pom.xml: Add a test goal, and a dependency on junit in that scope.
729 * src/test/java/org/glom/web/shared/DataItemTest.java:
730 This is a silly test but it is just to get things started. Note that
731 maven/junit finds the test because it looks in src/test by default.
733 2011-12-22 Ben Konrath <ben@bagu.org>
735 Change charsetName to "UTF-8" when replacing line breaks.
737 JavaScript requires the charsetName to be "UTF-8". CharsetName values
738 that work in Java (such as "UTF8") will not work when compiled to
741 This fixes a problem with multi-line details view fields that have hard
742 line breaks. The "License Text" field on this page demonstrates the
745 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
747 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
749 2011-12-22 Ben Konrath <ben@bagu.org>
751 Fix another bug with related list navigation.
753 I've tested all the navigation buttons in all of the related lists
754 so things should be good now.
756 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
758 2011-12-22 Ben Konrath <ben@bagu.org>
760 Fix a crasher when refreshing the list view with the default table.
762 This crash will also happen when loading the list view with the default
763 table from a link or bookmark.
765 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
766 to the main document selection page when the document id hasn't been
768 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
769 the main document selection page when the document id hasn't been
771 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
772 values for the details place when the document id hasn't been set.
773 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
774 values for the list place when the document id hasn't been set.
776 2011-12-21 Ben Konrath <ben@bagu.org>
778 Protect against NPE when glom.document.locale is not in config.
780 This patch protects against an NPE when glom.document.locale is not in
781 the config file. This NPE will also happen if glom.document.locale is
784 The patch also updates the error message to display the class name when
785 the getMessage() returns null. This was happening when the NPE was
786 thrown and I had "Configuration Error: null". If an NPE is encountered
787 with this patch, "Configuration Error: NullPointerException " will be
790 This commit closes this bug:
792 https://bugzilla.gnome.org/show_bug.cgi?id=666669
794 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
796 2011-12-20 Murray Cumming <murrayc@murrayc.com>
798 Rename onlineglom.properties to onlineglom.properties.sample.
800 * src/main/resources/onlineglom.properties: Rename to:
801 * src/main/resources/onlineglom.properties.sample:
802 * src/main/resources/README: And add this file explaining that people
803 should rename it back when deploying.
805 2011-12-20 Murray Cumming <murrayc@murrayc.com>
807 Allow choosing the translation in the .properties file.
809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
810 init(): Read a glom.document.locale value from the configuration file
811 and call Glom's TransatableItem::set_current_locale() method.
812 * src/main/resources/onlineglom.properties: Add a commented-out
813 example of this new setting.
815 It would be better to add &lang=de_DE to the URL, but the current
816 libglom API does not allow us to do this easily. I am working on that.
818 2011-12-19 Murray Cumming <murrayc@murrayc.com>
820 Avoid a crash in parsing of token parameters.
822 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
823 ava: getTokenParams(): Do not crash if a parameter has a key but no
824 value, and ignore parameters with neither.
826 2011-12-17 Murray Cumming <murrayc@murayc.com>
828 History token building/handling: Improve use of token parameters.
830 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
831 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
832 and buildParamsToken(HashMap), for use by derived classes.
833 Make the separator private because it is no longer be needed.
834 * src/main/java/org/glom/web/client/place/DetailsPlace.java
835 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
836 instead of manual string concatenation.
837 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
838 of hardcoded indices and awkward splitting code.
839 * src/main/java/org/glom/web/client/place/ListPlace.java
840 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
841 instead of manual string concatenation.
842 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
843 of hardcoded indices and awkward splitting code.
844 This should fix bug #666420
846 2011-12-16 Murray Cumming <murrayc@murrayc.com>
848 Fix a Navgiation->Navigation typo in the code.
850 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
851 Rename processNavgiation() to processNavigation().
853 2011-12-16 Murray Cumming <murrayc@murrayc.com>
855 Fix a seperator->separator typo in the code.
857 * src/main/java/org/glom/web/client/place/DetailsPlace.java
858 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
859 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
862 2011-12-15 Ben Konrath <ben@bagu.org>
864 Cleanup some comments.
866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
868 2011-12-14 Ben Konrath <ben@bagu.org>
870 Replace \n with <br/> for multiline text in the details view.
872 Vertical scrollbars are added when needed as well.
874 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
876 2011-12-14 Ben Konrath <ben@bagu.org>
878 Specify the font for document selection links.
880 * src/main/webapp/style.css:
882 2011-12-14 Ben Konrath <ben@bagu.org>
884 Fix bouncy CellTable while paging.
886 This doesn't currently work with related list tables in unselected
889 * src/main/java/org/glom/web/client/ui/list/ListTable.java
891 2011-12-14 Ben Konrath <ben@bagu.org>
893 Revamp the appearance of the document selection page.
895 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
896 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
897 * src/main/webapp/style.css:
899 2011-12-13 Ben Konrath <ben@bagu.org>
901 Set navigation button column to the smallest size possible.
903 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
905 2011-12-13 Ben Konrath <ben@bagu.org>
907 Change OpenButton nomenclature to NavigationButton.
909 Using NavigtionButton makes things more generic. Classes, methods and
910 variables have been changed.
912 This is a rename-only refactor.
914 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
915 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
916 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
917 Renamed from OpenButtonCell.
918 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
919 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
920 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
922 2011-12-12 Ben Konrath <ben@bagu.org>
924 Remove unnecessary String argument in RelatedListTable and ListViewTable.
926 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
927 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
928 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
929 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
931 2011-12-12 Ben Konrath <ben@bagu.org>
933 Update variable names and comments.
935 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
936 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
938 2011-12-12 Ben Konrath <ben@bagu.org>
940 Properly initialize numNonEmptyRows variable to zero.
942 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
943 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
945 2011-12-05 Ben Konrath <ben@bagu.org>
947 Add latest mockup with HTML tables.
949 Features of this mockup:
951 -> HTML table for flowtable
952 -> HTML table for flowtable column
953 -> Example of how related lists would look
954 -> Not using text entries for data items
956 The current version of Online Glom doesn't use HTML tables for the
959 This mockup has been sent to the glom-devel mailing list but it's good
960 to have it here as well.
962 * mockups/details-view-html-tables.html:
964 2011-12-05 Ben Konrath <ben@bagu.org>
966 Remove unnecessary getPrimaryKeyField() method.
968 getPrimaryKeyFieldForTable(String) has been renamed to
969 getPrimaryKeyField(String).
971 * src/main/java/org/glom/web/server/database/DBAccess.java:
972 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
973 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
975 2011-12-05 Ben Konrath <ben@bagu.org>
977 Add string representation of TypedDataItem value to conversion error message.
979 * src/main/java/org/glom/web/server/Utils.java: Logging the error
980 message was extracted into its own method to avoid duplication.
982 2011-12-05 Ben Konrath <ben@bagu.org>
984 Add type checking to navigation primary key value creation.
986 Create navigation primary key only if the expected type from the Glom
987 document matches the type returned by the SQL query.
989 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
991 2011-12-05 Ben Konrath <ben@bagu.org>
993 Rename a couple of variables in RelatedListNavigation.
995 This is a rename-only refactor.
997 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
999 2011-12-05 Ben Konrath <ben@bagu.org>
1001 Move getListLayoutGroup() into getListViewLayoutGroup().
1003 This removes getListLayoutGroup(). It was only being called by
1004 getListViewLayoutGroup().
1006 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1008 2011-12-05 Ben Konrath <ben@bagu.org>
1010 Remove check for LayoutItem_Portal in list table method.
1012 This check is no longer necessary because the method isn't being used
1013 to create the LayoutItemPortal DTO.
1015 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1017 2011-12-05 Ben Konrath <ben@bagu.org>
1019 Properly support related list navigation.
1021 Navigation from the "Repository Analyzer -> Package Scans ->
1022 Dependencies" related table wasn't working because the primary key for
1023 related tables wasn't being set properly. This commit fixes the
1026 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1027 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1028 doesn't set the primary key properly for related list tables.
1029 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1030 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1031 useful for getting the primary key for list view tables and for related
1033 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1034 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1035 Move code to set the primary key for the table from the abstract
1036 ListDBAccess class to ListViewDBAccess as it's only correct for list
1038 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1039 Properly add primary key to related list tables.
1041 2011-12-02 Ben Konrath <ben@bagu.org>
1043 Properly set the horizontal alignment of fields.
1045 This fix is for both the list tables and the details view.
1047 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1048 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1049 to set the horizontal alignment of fields.
1051 2011-12-02 Ben Konrath <ben@bagu.org>
1053 Display currency codes in the details view.
1055 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1057 2011-12-02 Ben Konrath <ben@bagu.org>
1059 Avoid duplicate JNI call.
1061 JNI is not as efficient as pure Java and this is an easy (and small)
1064 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1065 Use previously retrieved value for whereClauseToTableName instead of
1068 2011-12-02 Ben Konrath <ben@bagu.org>
1070 Rename a couple of variables in RelatedListNavigation.
1072 This is a rename-only refactor.
1074 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1076 2011-12-02 Ben Konrath <ben@bagu.org>
1078 Indicate clearly that a mismatched primary key type is a bug.
1080 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1081 warning to error. Add 'This is a bug.' to message.
1083 2011-12-02 Ben Konrath <ben@bagu.org>
1085 Update / fix some comments.
1087 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1089 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1091 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1092 Fix comments. Add some TODOs.
1094 2011-12-02 Ben Konrath <ben@bagu.org>
1096 Enable navigation to details view with string primary key from related list.
1098 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1099 Create a text primary key value when return type of result is
1100 java.sql.Types.VARCHAR.
1102 2011-12-02 Ben Konrath <ben@bagu.org>
1104 Use checkboxes for booleans in the details view.
1106 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1108 2011-12-01 Ben Konrath <ben@bagu.org>
1110 Improve performance of related list height calculation.
1112 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1113 Put code to calculate the expected height in a static initializer so
1114 that that it's only called once.
1116 2011-12-01 Ben Konrath <ben@bagu.org>
1118 Show related list tables in notebooks (again).
1120 Calculate the height of the related list tables so the Notebook can be
1121 set the correct height. The height of the related list table is also needed by
1122 FlowTable to be able decide how to create the layout.
1124 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1125 and set the Portal height based on the height of the related list
1126 table and the Portal container.
1127 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1128 Add method to calculate the height of the related list tables.
1129 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1130 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1131 calculate the height of the Pager widget.
1133 2011-12-01 Ben Konrath <ben@bagu.org>
1135 Use CellTable API for table property instead of setting style on Element.
1137 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1139 2011-12-01 Ben Konrath <ben@bagu.org>
1141 Make ListViewTable and RelatedListTable a consistent height.
1143 The tables are now a consistent height regardless of the contents of
1144 the table. A hidden button is added to empty rows to ensure that the
1145 height of these rows will match the height of rows with data.
1147 A navigation button column is now added to every table. The width of
1148 the navigation column is set to 0px when a RelatedListTable shouldn't
1149 have navigation buttons. This maintains the a consistent row height in
1150 tables that don't show the navigation buttons.
1152 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1153 navigation column when not needed.
1154 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1155 arguments for navigation button to constructor of ListViewTable.
1156 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1157 hidden button for empty data rows.
1158 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1159 arguments for navigation button to constructor.
1160 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1161 create navigation buttons. Add hideNavigationButtons() method.
1162 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1163 arguments for navigation button to constructor.
1165 2011-12-01 Ben Konrath <ben@bagu.org>
1167 Use 'visibility: hidden' in Utils.getWidgetHeight().
1169 This is better choice because hidden elements are invisible, don't
1170 respond to events and are not part of the tab order. They will,
1171 however, take up space which is required to be able to calculate the
1172 height of the widget.
1174 * src/main/java/org/glom/web/client/Utils.java:
1176 2011-12-01 Ben Konrath <ben@bagu.org>
1178 Use Utils.getWidgetHeight() in FlowTable.
1180 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1182 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1184 2011-12-01 Ben Konrath <ben@bagu.org>
1186 Put the details css class name on the correct table column.
1188 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1190 2011-11-30 Ben Konrath <ben@bagu.org>
1192 Update for java-libglom API change.
1194 The getters and setters on FieldFormatting and NumericFormat were
1195 changed to remove the 'M'.
1197 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1199 2011-11-29 Ben Konrath <ben@bagu.org>
1201 Only allow RelatedListTables in Portals.
1203 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1205 2011-11-29 Ben Konrath <ben@bagu.org>
1207 Only create a contents panel for Portals when title is being set.
1209 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1211 2011-11-29 Ben Konrath <ben@bagu.org>
1213 Set TabLayoutPanel height based on calculated height its widgets.
1215 This is a potential fix for this bug:
1217 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1219 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1221 2011-11-29 Ben Konrath <ben@bagu.org>
1223 Align details field labels and data with the Open buttons.
1225 * src/main/webapp/style.css:
1227 2011-11-29 Ben Konrath <ben@bagu.org>
1229 Remove unnecessary <div> in the Notebook widget.
1231 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1232 method to get container FlowPanel (<div>).
1233 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1234 initWidget() method directly on the TabLayoutPanel widget instead of
1235 Group's container widget.
1237 2011-11-29 Ben Konrath <ben@bagu.org>
1239 Don't add group titles for Portals in Notebooks.
1241 This reverts the previous patch and fixes a bug I introduced with
1242 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1244 * src/main/java/org/glom/web/client/ui/details/Group.java:
1245 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1247 2011-11-28 Ben Konrath <ben@bagu.org>
1249 Remove unused boolean argument in Portal constructor.
1251 Just a code cleanup.
1253 * src/main/java/org/glom/web/client/ui/details/Group.java:
1254 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1256 2011-11-28 Ben Konrath <ben@bagu.org>
1258 Remove hack for glom 1.18 style glom files.
1260 * src/main/java/org/glom/web/client/ui/details/Group.java:
1261 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1262 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1264 2011-11-28 Ben Konrath <ben@bagu.org>
1266 Use Gda Value version of primary key to log result too large error.
1268 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1270 2011-11-28 Ben Konrath <ben@bagu.org>
1272 Don't use TypedDataItem.getText() for Unknown types from the URL.
1274 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1275 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1276 instead of getText().
1277 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1278 String field and getUnknown() method.
1280 2011-11-28 Ben Konrath <ben@bagu.org>
1282 Log an error message when the java-libglom .so is not present.
1284 The error message was being set in the exception but not logged.
1286 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1288 2011-11-28 Ben Konrath <ben@bagu.org>
1290 Ignore LayoutItem_CalendarPortals.
1292 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1293 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1295 2011-11-28 Ben Konrath <ben@bagu.org>
1297 Extract method for creating the LayoutItemPortal DTO.
1299 Just breaking the code up into smaller chunks.
1301 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1303 2011-11-28 Ben Konrath <ben@bagu.org>
1307 This should have been added with the refactor. Oops!
1309 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1311 2011-11-28 Ben Konrath <ben@bagu.org>
1313 Create primary key value from URL string using type from Glom document.
1315 See this bug, comments 19 - 25:
1317 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1319 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1320 create a TypeDataItem for the primary key here when loading from a
1321 URL. Show the same string for the primary key value as was received
1322 from the URL string (when loading from a URL).
1323 * src/main/java/org/glom/web/server/Utils.java: Update method for
1324 creating the Gda Value from the TypeDataItem to properly deal with
1325 creating a Gda Value based on the Glom document type for the primary
1326 key value string when loading from a URL.
1327 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1328 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1329 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1330 Update for changed method name.
1332 2011-11-27 Ben Konrath <ben@bagu.org>
1334 Rename PrimaryKeyItem to TypedDataItem.
1336 The name PrimaryKeyItem suggests what the class should be used for.
1337 TypedDataItem is a neutral name that describes the class better.
1339 This is a rename-only refactor.
1341 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1342 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1343 * src/main/java/org/glom/web/client/Utils.java:
1344 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1345 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1346 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1347 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1348 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1349 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1351 * src/main/java/org/glom/web/server/Utils.java:
1352 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1353 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1354 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1355 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1357 2011-11-25 Ben Konrath <ben@bagu.org>
1359 Improve Gda Value conversion from PrimaryKeyItem.
1361 The value from the PrimaryKeyItem is only used if its type match the
1362 type from the glom document.
1364 * src/main/java/org/glom/web/server/Utils.java:
1366 2011-11-25 Ben Konrath <ben@bagu.org>
1368 Manually check if the java-liblgom .so is visible to the JVM.
1370 It seems that Tomcat has problems when a static initializer throws an
1371 exception. This check is done before the first method call into
1372 java-libglom so that execution doesn't continue if the .so is not
1375 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1377 2011-11-25 Ben Konrath <ben@bagu.org>
1379 Improve browser configuration error messages.
1383 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1385 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1386 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1387 getConfigurationErrorMessage() method.
1388 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1389 Get and display a specific configuration error message when no Glom
1390 documents are found.
1391 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1392 Implement getConfigurationErrorMessage() method. Surround configuration
1393 code in the init() method with a try/catch block. This allows the
1394 errors to be caught while keeping the servlet available to retrieve the
1395 configuration error message.
1397 2011-11-25 Ben Konrath <ben@bagu.org>
1399 Don't use Strings to hold primary key values.
1401 The primary key values are now held in a new data object
1402 (PrimaryKeyItem) that holds type information and the primary key value
1403 using the correct type.
1405 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1406 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1407 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1408 PrimaryKeyItem instead of String to hold the primary key value.
1409 * src/main/java/org/glom/web/client/Utils.java: Remove
1410 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1411 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1412 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1413 PrimaryKeyItem instead of String to hold the primary key value. Load
1414 document selection page when the documentID has not been set correctly.
1415 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1416 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1418 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1419 Return empty string for URL instead of "null".
1420 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1421 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1422 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1423 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1424 PrimaryKeyItem instead of String to hold primary key values.
1425 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1426 PrimaryKeyValue to a Gda Value.
1427 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1428 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1429 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1430 Replace temporary database access code that uses the PrimaryKeyValue to
1431 Gda Value conversion.
1432 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1433 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1434 PrimaryKeyItem instead of String.
1435 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1436 hold primary key values.
1438 2011-11-24 Ben Konrath <ben@bagu.org>
1440 Use newly added java-libglom API to create queries.
1442 This isn't finished. I still need to stop using Strings for primary key
1443 values in the client code.
1445 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1446 libglom to use fake connections so that retrieving the query string will
1448 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1449 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1450 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1451 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1452 Use the newly added libglom sql methods and classes to create the
1453 query. Add temporary hack to convert primary value strings to Gda
1456 2011-11-23 Ben Konrath <ben@bagu.org>
1458 Don't explicitly set the height of Portals.
1460 See comments 6 - 10 of this bug for details:
1462 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1464 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1466 2011-11-23 Ben Konrath <ben@bagu.org>
1468 Use an HTML table instead of CSS for the FlowTable layout.
1470 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1471 GWT's FlexTable to implement the FlowTable.
1472 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1474 2011-11-18 Ben Konrath <ben@bagu.org>
1476 Add boolean example to HTML table mockup.
1478 * mockups/details-view-html-tables-text-entries.html:
1480 2011-11-17 Ben Konrath <ben@bagu.org>
1482 Ensure the pager buttons are always visible for related lists.
1484 To accomplish this, I've turned off text wrapping in the list view and
1485 related list tables for both the header and data text. The related list
1486 table now has a fixed layout so the it doesn't overflow its container.
1487 This is required to ensure that the cell text is clipped when it
1488 overflows the cell and an ellipsis is added to the right side of the
1489 cell when text is clipped.
1491 A fixed table layout for the related list table in the details view
1492 seems what we want for the details view anyway, so the side-effect is
1495 The ellipsis will only be displayed in Firefox >= 7.
1499 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1501 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1502 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1503 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1505 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1506 Set the 'table-layout: fixed' CSS property to the related list table.
1507 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1508 'white-space: nowrap;' CSS property on both the list view and the
1509 related list tables.
1511 2011-11-16 Ben Konrath <ben@bagu.org>
1513 Rework the fix for empty notebook tab labels.
1515 Setting the empty group titles with its name caused problems for the
1516 details layout. Instead of using libglom's
1517 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1518 to the client when the title is empty. This allows the Notebook to use
1519 the name when the title is empty without affecting anything else.
1521 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1522 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1524 2011-11-16 Ben Konrath <ben@bagu.org>
1526 Set group titles with name when title is empty.
1528 This fixes a problem with an empty notebook tab label in the Lesson
1529 Planner document. The forth tab in the notebook should be "Internet":
1531 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1533 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1534 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1537 2011-11-16 Ben Konrath <ben@bagu.org>
1539 Remove whitespace from the configured username properties.
1541 This assumes that usernames won't have whitespace at the beginning
1542 or end. But I think this is a reasonable assumption.
1544 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1545 String.trim() to remove the whitespace from the username properties.
1547 2011-11-15 Ben Konrath <ben@bagu.org>
1549 Add details view mockup with HTML tables and text entries.
1551 This is from the attachment on this bug:
1553 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1555 * mockups/details-view-html-tables-text-entries.html:
1557 2011-11-15 Ben Konrath <ben@bagu.org>
1559 Add space between the columns of the flow table.
1563 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1565 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1566 space between columns in the flow table.
1568 2011-11-15 Ben Konrath <ben@bagu.org>
1570 Add backup files to the .gitignore.
1572 * .gitignore: Ignore files that end with ~.
1574 2011-11-09 Ben Konrath <ben@bagu.org>
1576 Use latest release of gwt-log.
1578 Gwt-log releases are now being submitted to the maven central
1579 repository so manual installation of the jar is no longer required.
1581 * pom.xml: Update version and groupId of gwt-log dependency.
1583 2011-10-31 Ben Konrath <ben@bagu.org>
1585 Don't use GWT numeric formatting to override the glom currency formatting.
1587 Currencies are now displayed like they are in Glom. See this bug:
1589 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1591 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1593 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1594 currency code to constructor and set it when the cell is rendered.
1595 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1596 currency code to the constructor of the NumericCell.
1598 2011-10-27 Ben Konrath <ben@bagu.org>
1600 Require the latest release of java-libglom (1.17.4).
1604 2011-10-26 Ben Konrath <ben@bagu.org>
1606 Add style to Notebook that matches current theme.
1608 It's not the best style in the world but it's better than the default.
1610 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1611 padding at the bottom of the child widgets.
1612 * src/main/webapp/style.css: Add style for the Notebook.
1614 2011-10-26 Ben Konrath <ben@bagu.org>
1616 Move servlet initialization code to overridden init method.
1618 This is half of the solution to getting proper error messages
1619 displayed when configuration errors occur. Here's the relevant bug:
1621 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1623 The rest of the solution involves surrounding the init method with a
1624 try/catch block and setting a global variable with the error /
1625 exception. A new async method should be created to retrieve and display
1626 the error message / exception.
1628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1629 code from constructor to init method adding exceptions as needed.
1631 2011-10-26 Ben Konrath <ben@bagu.org>
1633 Add script to monitor and restart tomcat if required.
1635 * utils/check-and-recover-tomcat.py: New file.
1637 2011-10-26 Ben Konrath <ben@bagu.org>
1639 Display the correct number of data items in the pager.
1643 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1645 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1646 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1647 The implementation is the same for both tables: Keep track of the
1648 number of non-empty rows and fire and RowCountChangeEvent after the data has
1650 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1651 custom Pager class that subclasses SimplePager to handle displaying
1652 the correct number when empty rows have been added.
1654 2011-10-26 Ben Konrath <ben@bagu.org>
1656 Correct error in previous commit.
1658 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1659 eventBus parameter from listView.setCellTable().
1661 2011-10-26 Ben Konrath <ben@bagu.org>
1663 Fix error in TODO comment.
1665 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1667 2011-10-24 Ben Konrath <ben@bagu.org>
1669 Create Notebook widgets to the details view.
1671 This isn't finished just yet - I still need to create a reasonable
1672 style to match the current theme.
1674 * src/main/java/org/glom/web/client/Utils.java: Add method for
1675 calculating the height of a widget. This is used in the Notebook class.
1676 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1677 new constructor method in Group.
1678 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1679 method for creating child widget that can be used by subclasses
1680 like Notebook. New constructor that allows disabling the group
1681 titles - Notebooks don't set a group title for their child groups.
1682 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1683 to make Notebooks using GWT's TabLayoutPanel.
1684 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1685 constructor that allows disabling the group titles.
1686 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1687 LayoutItemNotebook DTO.
1688 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1689 DTO for Notebooks. It's just an empty class for now but we might need
1690 it to transfer some specific information in the future.
1692 2011-10-21 Ben Konrath <ben@bagu.org>
1694 Add navigation buttons to related list tables.
1696 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1697 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1698 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1699 method getSuitableRecordToViewDetails() for getting the table name
1700 and primary key value for related list navigation buttons.
1701 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1702 private cell renderer class to get the navigation information for
1703 related list tables from the server. Extract the navigation
1704 processing code from the details cell navigation and use it for the
1705 related list navigation as well.
1706 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1707 cell renderer class for the details open buttons. This was needed
1708 because the related list navigation buttons and the list view
1709 navigation buttons need to react differently when clicked.
1710 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1711 the onEnterKeyDown() method because it's now overriden in the
1712 subclasses that are specific to the related list tables and the list
1714 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1715 the vertical size a little because the buttons add a bit of vertical
1716 space to table. This is not a perfect solution because the vertical
1717 size of with table fewer than 5 rows will be a little smaller.
1718 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1719 changes in how navigation buttons are handled.
1720 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1721 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1722 database access object.
1723 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1724 to find the portal for a given relationship name from
1725 RelatedListDBAccess. Add method to find a primary key field for a
1727 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1728 Move code to find the portal for a given relationship name to
1730 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1731 New file: database access object for getting the related list
1732 navigation information (the table name and the primary key value).
1733 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1734 DTO for transferring a table name to navigate to and a primary key
1736 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1737 boolean and getter/setter to specifies if the related list should add
1740 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1742 Use the master branch of java-libglom
1744 * pom.xml: Depend on java-libglom 1.19 instead.
1746 This is the master branch. See also the libglom-1-18 branch.
1748 2011-10-11 Ben Konrath <ben@bagu.org>
1750 Enable the open navigation button when the data has been set.
1752 This avoids having active buttons that don't do anything when the data
1755 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1757 2011-10-11 Ben Konrath <ben@bagu.org>
1759 Use IsWidget interface for FlowTableItem.
1761 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1762 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1764 2011-10-11 Ben Konrath <ben@bagu.org>
1766 Remove GWT styling from open button in details view.
1768 There are still some issues with how the details cell is arranged but
1769 this should be made to match Glom 1.20. I'm going to leave fixing this
1770 until I have Glom 1.20 up and running.
1772 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1773 style name on open button.
1774 * src/main/webapp/style.css: Move and edit details-navigation class.
1775 Re-arrange some classes to make them appear in the same order as the
1778 2011-10-07 Ben Konrath <ben@bagu.org>
1780 Update to GWT 2.4.0.
1782 * .gitignore: Ignore new cache directory.
1783 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1784 * pom.xml: Change GWT and maven plugin to 2.4.0.
1785 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1787 * src/main/java/org/glom/web/client/ClientFactory.java:
1788 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1789 * src/main/java/org/glom/web/client/OnlineGlom.java:
1790 Update source for API changes.
1791 * utils/build-onlineglom-war.sh: Remove cache directory before the
1794 2011-10-07 Ben Konrath <ben@bagu.org>
1796 Add navigation buttons in the details view.
1798 This isn't finished but I thought I'd commit what I have as it's a
1799 pretty good start. I still need to:
1801 1. Change the style so that it fits better into the current theme
1802 2. Adjust the details cell to expand as much as possible.
1804 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1805 click handlers to navigation buttons in the DetailsCells. Create a
1806 refreshData() method to get just the data from the server without the
1808 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1809 Update the tableSelector and browser title when the table name
1810 changes without using the tableSelector.
1811 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1812 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1813 getDetailsCells() to getCells(). Update variable names.
1814 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1815 method to set click handler on navigation button. Rename a few
1816 variables. Add navigation buttons where needed.
1817 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1818 variables and methods.
1819 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1820 navigation boolean and navigation table as required in the
1821 LayoutItemField DTO.
1822 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1823 variables for navigation along with getter/setter methods.
1825 2011-10-07 Ben Konrath <ben@bagu.org>
1827 Rename Field to DetailsCell.
1829 This is a refactor-only commit. No functionality has been added or
1832 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1833 Update variable and method names.
1834 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1835 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1836 variable and method names.
1837 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1839 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1840 variable and method names.
1842 2011-10-07 Ben Konrath <ben@bagu.org>
1844 Create separate methods for layout and data the details view.
1846 This is a refactor-only commit. No functionality has been added or
1849 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1850 private methods: setData(), createLayout().
1852 2011-10-07 Ben Konrath <ben@bagu.org>
1854 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1856 This is part of a change to get navigation buttons in the details view
1857 but it should have been done this way from the start.
1859 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1860 for method name change in TableSelectionView.
1861 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1862 Create TableChangeEvent and set the browser title using the
1863 TableSelectionView API.
1864 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1865 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1866 Change getSelectedTable() to getSelectedTableName(). Add
1867 getSelectedTableTitle().
1869 2011-10-07 Ben Konrath <ben@bagu.org>
1871 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1873 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1875 2011-10-07 Ben Konrath <ben@bagu.org>
1877 Update TableChangeEvent to use newTableName naming convention.
1879 This makes the class more consistent with GWT naming conventions.
1881 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1882 Update for method name change in TableChangeEvent.
1883 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1884 for method name change in TableChangeEvent.
1885 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1886 newTableName variable and getter method. Make toDebugString()
1889 2011-09-30 Ben Konrath <ben@bagu.org>
1891 Disable the pager in the list tables when the data row count is less than the minimum.
1893 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1894 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1896 2011-09-30 Ben Konrath <ben@bagu.org>
1898 Add empty rows to the end of related list and list view tables.
1900 I also extracted the cell rendering classes from the ListTable because
1901 the code was becoming a little crazy with all the anonymous inner
1902 classes. My plan is to use these cell rendering classes in the details
1903 view as well so this refactor will be needed for that change.
1905 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1906 set the row count in related list tables if the data has more rows
1907 than the minimum number of rows visible.
1908 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1909 row count in list view tables if the data has more rows than the
1910 minimum number of rows visible.
1911 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1912 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1914 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1915 for rendering TYPE_NUMERIC cells. The code was extracted from the
1917 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1918 class for rendering cells with buttons in list views. The code was
1919 extracted from the ListTable class.
1920 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1921 for rendering TYPE_TEXT cells. The code was extracted from the
1923 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1924 Add empty rows to the end of the data if required. Implement
1925 ListTable.getMinNumVisibleRows().
1926 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1927 cell renderer code to public classes. Return null in
1928 Column.getValue() for empty rows. Add new abstract method:
1929 getMinNumVisibleRows(). Move code to set the row count of the list view
1930 table to ListViewImpl.
1931 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1932 empty rows to the end of the data if required. Implement
1933 ListTable.getMinNumVisibleRows().
1936 2011-09-27 Ben Konrath <ben@bagu.org>
1938 Use GWT.log for client-side debugging statements.
1940 These are optimized out when deployed so I should have used this method
1941 in the first place. These statements will eventually be replaced with some sort
1942 of notification in the browser.
1944 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1945 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1946 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1947 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1948 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1950 2011-09-27 Ben Konrath <ben@bagu.org>
1952 Put tableselector on the right, back to list link on right.
1954 The idea is that the table selector is acting like a label for the
1955 currently displayed table so it should be placed below the document title. This
1956 puts the table title in a similar position to where it is in Glom.
1958 * mockups/details-contacts.html:
1959 * mockups/details-projects.html:
1960 * mockups/listview-contacts.html:
1961 * mockups/listview-projects.html:
1962 * mockups/style.css:
1963 Update mockups to match how the interfaces currently look.
1964 * src/main/webapp/style.css: Swap positions of backlink with the table
1965 selector. Add some space on the left side of the table selector to
1966 line things up with the document title.
1968 2011-09-27 Ben Konrath <ben@bagu.org>
1970 Add field colouring to details view.
1972 This change re-works how field colouring works. The colour formatting
1973 information is now set to the client with the layout information instead of
1974 with the data. This eliminates the need to send the same colour strings for
1975 data in list view column when colour information is set.
1977 In order to set an alternate colour for negative numeric values, the
1978 number is now sent to client and formatted with the GWT NumberFormat class.
1980 This change also fixes:
1982 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1984 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1985 internationalization framework which is needed for client side numeric
1987 * src/main/java/org/glom/web/client/Utils.java: New file for some
1988 client static utility methods.
1989 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1990 the DataItem object to the Field class. Use a utility method to
1991 create the foreignKeyValue string.
1992 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1993 alignment and text colours in the constructor. Add setData(DataItem)
1994 method. Remove setText(String) method.
1995 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1996 colour information to GlomTextCell. Create and use GlomNumberCell for
1997 rendering numbers. Use utility method to get the string for the
1998 primary key of the key provider. Re-work how the horizontal alignment
2000 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2001 formatting to layout information. Methods for converting the libglom
2002 formatting information were moved from DBAccess.
2003 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2004 numeric formatting (it's now done on the client side). Don't set text
2005 colours in DataItem. Move libglom formatting conversion methods to
2007 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2008 getters/setters for text colour information.
2009 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2010 for transferring the libglom NumericFormat information to the client.
2011 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2012 and getters/setters for: GlomNumericFormat, background colour and
2013 foreground colour strings.
2015 2011-09-26 Ben Konrath <ben@bagu.org>
2017 Simplify code that iterates through the LayoutGroup.
2019 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2021 2011-09-26 Ben Konrath <ben@bagu.org>
2023 Accept Eclipse formatting for OnlineGlomServiceAsync.
2025 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2027 2011-09-26 Ben Konrath <ben@bagu.org>
2029 Don't use the ListDBAccess classes to get the primary key layout information.
2031 This was causing a bug where the wrong index for the hidden primary key
2032 was being sent to the client.
2034 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2035 primary key while creating the LayoutGroup DTO. Create a
2036 LayoutItemField DTO for hidden primary keys. Don't use the
2037 RelatedListDBAccess because it was only used for getting the primary
2039 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2040 access modifier from public to protected for getPrimaryKeyField() and
2041 getPrimaryKeyLayoutItemField().
2042 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2043 abstract method getExpectedResultSize() because RelatedListDBAccess
2044 doesn't have enough info to implement it.
2045 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2046 Remove @Override for getExpectedResultSize().
2047 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2048 Remove method getExpectedResultSize().
2050 2011-09-23 Ben Konrath <ben@bagu.org>
2052 Log which layout (list or details) the ignored item is from.
2054 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2056 2011-09-23 Ben Konrath <ben@bagu.org>
2058 Remove annotations that turn off code formatting in DataItem.
2060 * src/main/java/org/glom/web/shared/DataItem.java:
2062 2011-09-23 Ben Konrath <ben@bagu.org>
2064 Rename GlomField to DataItem and update associated methods.
2066 This is a rename-only refactor. No functionality has been added or
2069 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2070 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2071 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2072 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2073 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2074 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2075 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2076 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2077 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2078 * src/main/java/org/glom/web/server/database/DBAccess.java:
2079 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2080 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2081 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2082 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2083 * src/main/java/org/glom/web/shared/DataItem.java:
2084 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2085 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2087 2011-09-23 Ben Konrath <ben@bagu.org>
2089 Rename GlomDocument to DocumentInfo and update associated methods.
2091 This is a rename-only refactor. No functionality has been added or
2094 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2095 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2096 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2097 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2098 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2099 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2100 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2102 2011-09-20 Ben Konrath <ben@bagu.org>
2104 Require java-libglom 1.17.3.
2106 This picks up the fix for the seg fault problem with the Scenes table
2107 in the Openismus Film Manager example.
2111 2011-09-20 Ben Konrath <ben@bagu.org>
2113 Change the way sort clause is added for primary key when no sort clause is requested.
2115 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2116 before the sort clause is created. When a sort clause is not requested, the
2117 sort clause is created by finding the primary key in the LayoutFieldVector
2120 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2122 2011-09-20 Ben Konrath <ben@bagu.org>
2124 Log error message if no documents are found in the configured directory.
2126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2127 Extract the glom file extension string to a private static final class
2128 variable (mostly as syntactic sugar). Accept a minor formatting change.
2129 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2130 the example glom.document.directory configuration property to make it
2131 more clear that it can any directory, not just the home directory.
2133 2011-09-18 Ben Konrath <ben@bagu.org>
2135 Add related lists to details view.
2137 The related list table has support for paging and sorting just like the
2138 table in the list view.
2140 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2141 SQL queries for the related list tables.
2142 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2143 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2144 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2145 Rename getList methods to getListView and add comments. Remove
2146 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2147 it being unused. Add methods: getDetailsLayoutAndData(),
2148 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2149 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2150 Create the layout and set the data for the fields in one async call
2151 instead of two. Create related lists where appropriate.
2152 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2153 for method name changes in OnlineGlomService.
2154 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2155 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2156 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2158 * src/main/java/org/glom/web/client/ui/ListView.java:
2159 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2160 tableName from setCellTable(). Create a ListViewTable instead of
2162 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2163 represent a data field in the details view.
2164 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2165 from addDetailsCell() to Field class. Keep track of the Fields and
2166 Portals in the details view.
2167 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2168 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2169 and add a method to get it. Add method to set the contents of the
2171 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2172 New class for related list tables. This class has the data provider
2173 for the related list table.
2174 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2175 abstract class which is the base class for the ListViewTable and the
2177 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2178 New class for list view tables. This class has the data provider for
2179 the list view table.
2180 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2181 methods for related list tables. Add more information to the
2182 LayoutItemField and LayoutItemPortal DTOs.
2183 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2184 Remove debugging print statement.
2185 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2186 Remove debugging print statements. Add primary key field to SQL count
2188 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2189 Remove unnecessary LayoutFieldVector parameter from
2190 getResultSizeOfSQLQuery() method.
2191 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2192 New class for related list table database access.
2193 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2194 class that is a wrapper DTO for details view layout and data.
2195 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2196 new 'fromField' string to this DTO.
2197 * src/main/webapp/style.css: Remove bottom margin and override top
2200 2011-09-15 Ben Konrath <ben@bagu.org>
2202 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2204 This sets things up to make it easier to add the data retrieval for
2205 related lists (portals). No user noticeable changes were made with
2208 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2209 class has the code to retrieve the layouts and access the
2210 database using the new database helper classes.
2211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2212 Most of the functionality has been removed from this class. This
2213 class now represents the public interface for the client side
2214 code. It also deals with configuring the servlet and cleaning
2215 things up when the servlet is stopped.
2216 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2217 of static methods into this utility class.
2218 * src/main/java/org/glom/web/server/database/DBAccess.java:
2219 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2220 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2221 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2222 These classes have the database retrieval code. The class hierarchy
2223 has been setup to make it easy to reuse code for similar
2226 2011-09-06 Ben Konrath <ben@bagu.org>
2228 Create separate classes for list table code and the data provider.
2230 As part of this refactor, I also split up the code a bit to make it
2233 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2234 table code to two new classes (below).
2235 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2236 with code from ListViewImpl.
2237 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2238 New file with code from ListViewImpl.
2240 2011-09-06 Ben Konrath <ben@bagu.org>
2242 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2244 This fixes the LayoutItemPortal DTO to match the libglom layout object
2247 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2249 2011-09-01 Ben Konrath <ben@bagu.org>
2251 Set title of Portals in the Details View.
2253 * pom.xml: Bump required version of java-libglom to 1.17.1.
2254 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2255 widget creation to its own class. Add comments to constructor.
2256 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2257 The code is mostly from the Group class with the title now set.
2258 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2259 title of Portal. Update some comments. Fix some code formatting.
2261 2011-09-01 Ben Konrath <ben@bagu.org>
2263 Remove TODO comment for the flow table column width.
2265 The flow table column width is working correctly and doesn't need to be
2266 changed. See this mailing list post for more info:
2268 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2270 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2272 2011-08-27 Ben Konrath <ben@bagu.org>
2274 Add document title (database name) to top of the browser page.
2276 I added the document title to the TableSelecitonView but that will
2277 change if / when we add a view that doesn't require table selection.
2279 * mockups/details-contacts.html:
2280 * mockups/details-projects.html:
2281 * mockups/listview-contacts.html:
2282 * mockups/listview-projects.html:
2283 * mockups/style.css: Add document title to mockups to keep things
2285 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2286 sizes to account for the document title.
2287 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2288 Set the document title when it has been retrieved from the server.
2289 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2290 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2291 and implement setDocumentTitle(String) method.
2292 * src/main/webapp/style.css: Add ID for document title style.
2294 2011-08-25 Ben Konrath <ben@bagu.org>
2296 Add NavigationType enum to LayoutItemPortal DTO.
2298 This is the start of adding support for Portals to the Details View.
2300 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2301 LayoutItem_Portal.navigation_type enum from libglom to
2302 LayoutItemPortal.NavigationType enum.
2303 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2304 NavigationType enum, field for storing the NavigationType and getter
2307 2011-08-25 Ben Konrath <ben@bagu.org>
2309 Implement the flow table layout in the Details View.
2311 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2312 FlowTable to Group to account for the renamed class.
2313 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2314 File. This is a container widget that implements the Glom details view
2315 flow table behaviour.
2316 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2317 org/glom/web/client/ui/FlowTable.java.
2318 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2319 so that the size of the subgroups are a closer match to the size of
2320 the Glom subgroups. This makes the flowtable layout match the layout
2321 in Glom for the Music Collection example file.
2323 2011-08-16 Ben Konrath <ben@bagu.org>
2325 Create container element for LayoutItemPortal in Details View.
2327 This will help me develop the layout for the FlowTable.
2329 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2330 fieldPanel variable to detailsCell.
2332 2011-08-15 Ben Konrath <ben@bagu.org>
2334 Set the height of the data element in the Details View.
2336 I changed the InlineLabels (text in a span element) to Labels (text in
2337 a div element) so that I could set the height of the details-data
2338 elements instead of the details-cell parent elements. This allows the
2339 the details-data element to display the correct height if style is
2340 applied that shows the height.
2342 This change has the added benefit of allowing the order of the labels
2343 and data elements to be changed for right-to-left languages.
2345 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2346 InlineLabels to Labels.
2347 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2348 InlineLabels to Labels. Set the height of the data element.
2349 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2350 multiline text height in the Formatting DTO.
2351 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2352 for multiline height along with getter and setter methods.
2353 * src/main/webapp/style.css: Adjust style to account for the change
2354 from span elements to div elements in the details cell.
2356 2011-08-15 Ben Konrath <ben@bagu.org>
2358 Make the List View appearance match the mockups.
2360 It doesn't match exactly but it's much better than it was.
2362 * mockups/listview-contacts.html: Remove unused css classes.
2363 * mockups/listview-projects.html: Remove unused css classes.
2364 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2365 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2366 for mainPanel instead of VerticalPanel (table). Set style name on
2367 CellTable. Set style name on Details column. Right-align Details
2369 * src/main/webapp/style.css: Adjust properties to match the mockups.
2371 2011-08-12 Ben Konrath <ben@bagu.org>
2373 Add better support for subgroups in the details view.
2375 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2376 changed FlowTable constructor.
2377 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2378 support for subgroups and subgroup-titles.
2379 * src/main/webapp/style.css: Add CSS class for subgroups and
2382 2011-08-12 Ben Konrath <ben@bagu.org>
2384 Return the top level LayoutGroup title.
2386 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2388 2011-08-11 Ben Konrath <ben@bagu.org>
2390 Make the TableSelector header match the mockup.
2392 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2393 the layout panel. Properly lineup the table selection header with
2394 the list and details view.
2395 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2396 margin around the details view.
2397 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2398 Rename listBox variable to tableSelector. Set id for the style sheet.
2399 Use a FlowPanel instead of a HorizontalPanel.
2400 * src/main/webapp/style.css: Add properties to make the TableSelector
2401 box match the mockups.
2403 2011-07-13 Ben Konrath <ben@bagu.org>
2405 Update install script for java-libglom version change.
2407 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2410 2011-07-13 Ben Konrath <ben@bagu.org>
2412 Add support sub-group in the details view.
2414 I also removed the code that special-cased the default details view
2417 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2419 I still have to make a proper flowtable.
2421 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2422 Don't special-case default details view layout.
2423 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2424 addLayoutField() as I'm going to use it.
2425 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2426 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2428 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2429 extracted from DetailsViewImpl.GroupPanel. Add support for
2431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2432 column count when getting the details layout.
2434 2011-07-12 Ben Konrath <ben@bagu.org>
2436 Set browser title with database and table titles.
2438 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2439 Set the browser title when the table changes and when the activity
2441 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2442 title when retrieving document info (the GlomDocument object).
2443 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2444 with getter and setter methods. Remove unused convenience constructor.
2445 Use default code formatting.
2447 2011-07-12 Ben Konrath <ben@bagu.org>
2449 Ignore LayoutItemPortals in the details view.
2451 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2454 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2455 LayoutItemPortal layout objects.
2456 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2457 LayoutItemPortal objects when retrieving the details layout.
2458 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2459 file. This is an empty class and just used to get type information for
2462 2011-07-12 Ben Konrath <ben@bagu.org>
2464 Use java-libglom 1.17.0.
2468 2011-07-11 Ben Konrath <ben@bagu.org>
2470 Remove "Table:" label from table selector.
2472 This matches a recent change in the Glom UI.
2474 * mockups/details-contacts.html:
2475 * mockups/details-projects.html:
2476 * mockups/listview-contacts.html:
2477 * mockups/listview-projects.html: Remove the "Table:" label from the
2479 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2481 2011-07-11 Ben Konrath <ben@bagu.org>
2483 Add main groups to the details view.
2485 This makes things look a little nicer in the details view. The next step
2486 is to implement the flowtable.
2488 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2489 resources from the standard gwt css theme. Standard.css is now
2490 included in OnlineGlom.html so that the online glom css rules have
2491 precedence over the gwt theme.
2492 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2493 the whole LayoutGroup to the DetailsView instead of just the titles.
2494 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2495 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2496 details layout with a helper class (GroupPanel). I might extract this
2497 class when I make the full flowtable.
2498 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2499 string as default so I don't have to worry about NPEs when processing
2501 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2502 note beside OnlineGlom.gwt.xml above).
2503 * src/main/webapp/style.css: Add default font-size to body to override
2504 the font-size set by the standard theme. Don't use h2 tags for
2505 group-title. Create new details-cell class.
2507 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2509 ConfiguredDocument: Set the port number too.
2511 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2512 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2513 Glom document. Presumably this worked sometimes so far because there is a
2514 default port number.
2516 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2518 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2520 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2521 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2522 correct, though we should throw an exception too.
2524 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2526 Fix a addDocuemnt typo.
2528 * src/main/java/org/glom/web/shared/Documents.java
2529 (Documents.addDocuemnt): Rename to addDocument().
2530 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2531 (OnlineGlomServiceImpl.getDocuments): Adapt.
2533 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2535 Slightly improved log output when connection fails.
2537 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2538 (ConfiguredDocument.setUsernameAndPassword):
2539 We don't know for sure if it' the username/password that's wrong, so
2540 rephrase the message.
2541 Also ouput the exception message, though it's generic in this case.
2543 2011-07-08 Ben Konrath <ben@bagu.org>
2547 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2548 added braces to a one line if statement because the Eclipse formatter
2549 was getting confused.
2551 2011-07-07 Ben Konrath <ben@bagu.org>
2553 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2555 These should really be two separate tasks but I counldn't get things to
2556 work with GWT 2.2.0 and Eclipse 3.7.
2560 * .settings/org.eclipse.jdt.core.prefs:
2561 * .settings/org.eclipse.jdt.ui.prefs:
2562 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2563 * .settings/org.eclipse.m2e.core.prefs:
2564 Add new config files. Update current files. Remove references to the
2565 webtools plugins as we're not using any of the webtools features.
2566 * .gitignore: Add logs directory which is created when running with
2568 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2569 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2570 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2572 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2574 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2576 onlineglom.properties: Add explanatory comments.
2578 * src/main/resources/onlineglom.properties: Also change the default user
2579 from ben to someuser, to avoid the risk of people thinking we just
2580 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2582 2011-06-28 Ben Konrath <ben@bagu.org>
2584 Use filename in Log for incorrect passwords.
2586 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2587 getFileName(String) method to get the filename from the URI.
2589 2011-06-28 Ben Konrath <ben@bagu.org>
2591 Add the table name to the URL token for the ListPlace.
2593 This makes things consistent between the DetailsPlace and the
2594 ListPlace. It also allows the the ListPlace to be bookmarked.
2596 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2597 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2598 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2599 Remove getDefaultListLayout(). The default layout is now returned
2600 by the getListLayout() method when the table name is an empty string.
2601 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2602 Add table name field. Change to a new ListPlace when the table
2603 has been changed. Use getListLayout() for getting the default
2605 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2606 Add table name field. Set the correct table name in the list box
2607 when loading from bookmark. This corrects a problem for the
2609 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2610 Move table name to super-class (HasSelectableTable). Move document
2611 and table URL keys to super-class in HasSelectableTable.
2612 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2613 Add table name field. Add Tokenizer class with URL key common to
2614 the subclasses (DetailsPlace and ListPlace).
2615 * src/main/java/org/glom/web/client/place/ListPlace.java:
2616 Add table name. Add code to parse the URL token.
2617 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2618 Update ListPlace construction with empty table name string.
2619 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2620 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2621 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2622 Update ListPlace construction with table name string.
2623 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2624 Change defaultTableName field to tableName to reflect how it's now
2625 used. Update the getter and setter methods.
2627 2011-06-28 Ben Konrath <ben@bagu.org>
2629 Enable the table selector in the DetailsView.
2631 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2632 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2633 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2634 Remove getDefaultDetailsLayout(). The default layout is now returned
2635 by the getDetailsLayout() method when the table name is an empty
2637 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2638 event handler for table change event. Change to using
2639 getDetailsLayout() for the default details layout.
2640 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2642 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2643 when navigating to the details place.
2645 2011-06-27 Ben Konrath <ben@bagu.org>
2647 Use filename based unique document ID in URL and for RPC.
2649 The document ID is the glom document name with spaces (' ') replaced
2650 with pluses ('+') and without the .glom extension.
2652 This change is mostly a string substitution of 'documentTitle' for
2653 'documentID'. The only code change is the addition of a Documents DTO to get the
2654 filename to document title mappings as indicated below.
2656 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2657 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2658 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2659 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2660 Use Documents DTO to create the document links in the document
2662 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2663 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2664 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2665 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2666 * src/main/java/org/glom/web/client/place/ListPlace.java:
2667 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2668 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2669 * src/main/java/org/glom/web/client/ui/ListView.java:
2670 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2671 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2672 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2673 * src/main/java/org/glom/web/server/Log.java:
2674 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2675 getDocumentTitles() to getDocuments() and return the Documents DTO.
2676 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2677 transferring the filename to document title mappings.
2679 2011-06-25 Ben Konrath <ben@bagu.org>
2681 Make the authentication popup work again.
2683 This bug was introduced when I extracted ConfiguredDocument to its own class.
2685 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2686 correct success / fail status in setUsernameAndPassword().
2688 2011-06-25 Ben Konrath <ben@bagu.org>
2690 Use filename as unique key for configuring database usernames and passwords.
2692 This replaces the use of the Glom document title which could change
2693 depending on the locale. Thanks to Murray Cumming for pointing out this
2696 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2697 * src/main/resources/onlineglom.properties:
2699 2011-06-24 Ben Konrath <ben@bagu.org>
2701 Pass primary key value to DetailsView.
2703 This enables the DetailsView to load the correct data.
2705 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2706 primary key value field and set in constructor. Pass primary key
2707 value to getDetailsData().
2708 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2709 variables for document title and primary key value.
2710 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2711 key value to the DetailsPlace.
2713 2011-06-24 Ben Konrath <ben@bagu.org>
2715 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2717 This allows the primary key to be retrieved by the Details button. This
2718 functionality has not been implemented yet but it's in the works.
2720 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2721 the LayoutGroup result to ListView.setCellTable instead of all of its
2722 fields individually.
2723 * src/main/java/org/glom/web/client/ui/ListView.java:
2724 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2725 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2726 get the primary key for the table.
2727 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2728 index of the primary key in the LayoutGroup accounting for hidden
2729 primary keys. Rename getJavaNumberFormat() to
2730 convertToJavaNumberFormat() for consistency. Cleanup / add some
2732 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2733 field for primary key index and a field to indicate whether the
2734 primary key is hidden or not.
2736 2011-06-23 Ben Konrath <ben@bagu.org>
2738 Rename getTableData methods to getListData.
2740 This is a rename refactor for consistency with other methods.
2742 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2743 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2744 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2745 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2747 2011-06-23 Ben Konrath <ben@bagu.org>
2749 Extract the ConfiguredDocument innerclass into its own class.
2751 This makes the servlet code more object oriented.
2753 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2754 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2755 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2756 new ConfiguredDocument class.
2758 2011-06-21 Ben Konrath <ben@bagu.org>
2760 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2762 This makes things more inline with how libglom works and reduces code
2763 duplication. This refactor lays the groundwork for adding the primary key to
2764 the LayoutGroup object.
2766 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2767 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2768 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2769 Change method names to getListLayout and getDefaultListLayout for
2770 consistency. Use LayoutGroup as the DTO for the list layout instead of
2771 ColumnInfo and LayoutListTable.
2772 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2773 new method names along with the LayoutGroup object for transferring the
2775 * src/main/java/org/glom/web/client/ui/ListView.java:
2776 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2777 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2778 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2780 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2781 Replaced with LayoutGroup.
2782 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2783 expectedResultSize and defaultTableName fields which are needed for
2785 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2786 type field which is needed for the list layout but will also be
2787 useful for the details layout as things progress.
2788 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2789 Make class abstract. Remove the unnecessary
2790 getFormattingHorizontalAlignment method. Add setFormatting method.
2792 2011-06-16 Ben Konrath <ben@bagu.org>
2794 Add scripts for building and installing war.
2796 These will help when updating OnlineGlom but they're also good
2797 supplemental documentation of the build and deployment proceeding.
2799 * utils/build-onlineglom-war.sh: New file.
2800 * utils/install-onlineglom-war.sh: New file.
2802 2011-06-16 Ben Konrath <ben@bagu.org>
2804 Create wrapper class to create consistent log messages.
2806 I wrapped methods in the Log class of gwt-log to add the method names
2807 from the servlet and create consistent formatting of the document title
2808 and table names in the log messages.
2810 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2812 log methods to use methods from wrapped Log class.
2814 2011-06-16 Ben Konrath <ben@bagu.org>
2816 Remove superfluous conditional return.
2818 Thanks to Murray Cumming for pointing this out!
2820 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2822 2011-06-15 Ben Konrath <ben@bagu.org>
2824 Return an ArrayList of LayoutGroups for the Details layout.
2826 This corrects a problem with the details layout as it can have more
2827 than one top level LayoutGroup.
2829 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2830 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2831 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2832 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2833 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2834 with ArrayList of LayoutGroups for the details view layout.
2835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2836 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2837 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2838 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2839 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2840 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2842 2011-06-14 Ben Konrath <ben@bagu.org>
2844 Use cast_dynamic method to determine the libglom LayoutItem type.
2846 This is better than finding the LayoutItem type by using the string
2847 returned from the get_part_type_name() method.
2849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2851 2011-06-14 Ben Konrath <ben@bagu.org>
2853 Add method names to log entries in the servlet.
2855 This helps when tracking down deployment problems.
2857 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2859 2011-06-14 Ben Konrath <ben@bagu.org>
2861 Add data to the DetailsView using a hard-coded primary key value.
2863 The layout and functionality of the DetailsView is not complete. This
2864 is just a checkpoint so the patch doesn't get too big.
2866 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2867 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2868 Add getDetailsData() servlet method.
2869 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2870 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2871 LayoutFields are added to the DetailsView.
2872 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2873 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2874 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2875 take the string for the title instead of the object.
2876 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2877 Add implementation getDetailsData() along with some private helper
2879 * src/main/webapp/style.css: Add padding to details-data class. Add a
2880 details-label class with the same padding as the details-data class.
2882 2011-06-03 Ben Konrath <ben@bagu.org>
2884 Use presenter.goTo() to change to the DetailsPlace.
2886 This will make things easier when we need to open the DetailsView with
2887 data specific to the row that was clicked.
2889 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2891 2011-06-02 Ben Konrath <ben@bagu.org>
2893 Add CSS file from mockups.
2895 I'm adding this now because it's going to be useful to have when
2896 developing the DetailsView. The TableSelectionView and ListView aren't
2899 * src/main/webapp/OnlineGlom.html:
2900 * src/main/webapp/style.css:
2902 2011-06-02 Ben Konrath <ben@bagu.org>
2904 Use String.isEmpty() to check for empty string.
2906 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2908 2011-06-02 Ben Konrath <ben@bagu.org>
2910 Display main layout group titles in the DetailsView.
2912 This is the start of the DetailsActivity/DetailsView implementation.
2914 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2915 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2916 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2917 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2918 Get the layout information for the details view from the server and set
2919 the main layout group titles.
2920 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2921 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2922 Add addLayoutGroup() and addLayoutField() methods. This are just
2923 temporary methods for creating the the details view that will change
2925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2926 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2928 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2929 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2930 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2931 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2932 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2933 Data Transfer Objects that mimic the libglom object structure. These are
2934 used for transferring the details layout but could also be used for
2935 transferring the list layout.
2937 2011-05-27 Ben Konrath <ben@bagu.org>
2939 Reset the AuthenticationPopup when clearing the ListView.
2941 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2943 2011-05-27 Ben Konrath <ben@bagu.org>
2945 Fix problem with onlineglom.properties file loading.
2947 The old way worked in Eclipse but not on the server. Loading the
2948 onlineglom.properties file now works in Eclipse and on the server.
2950 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2952 2011-05-24 Ben Konrath <ben@bagu.org>
2954 Update gwt-log from 3.1.0 to 3.1.2.
2956 Gwt-log 3.1.0 has been marked as depreciated.
2960 2011-05-24 Ben Konrath <ben@bagu.org>
2962 Add comment to ListActivity.goTo() method.
2964 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2966 2011-05-24 Ben Konrath <ben@bagu.org>
2968 Remove FIXME in convertGdkColorToHtmlColour()
2970 The Gdk::Color value returned by libglom is 16-bits per channel on both
2971 64 and 32-bit platforms.
2973 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2975 2011-05-19 Ben Konrath <ben@bagu.org>
2977 Improve performance of initial ListView load.
2979 I removed a round trip to the server for getting the default table name
2980 and then requesting information about that table. This also removes a potential
2981 problem with the table change handler not being setup in time to receive the
2982 table change event from the ListActivity.
2984 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2985 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2986 getDefaultLayoutListTable() method. Improve comments.
2987 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2988 getDefaultLayoutListTable() method instead of firing a table change
2989 event to get the table to load.
2990 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2991 implementation of getDefaultLayoutListTable() method.
2992 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2995 2011-05-19 Ben Konrath <ben@bagu.org>
2997 Override toDebugString() in TableChangeEvent.
2999 This is useful to have for debugging.
3001 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3003 2011-05-19 Ben Konrath <ben@bagu.org>
3005 Add a "Back to List" link when at the DetailsPlace.
3007 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3008 Populate the CellTable based on the selected table of the ListBox if
3009 it's set otherwise use the default table. This allows the "Back to
3011 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3012 Remove Place from constructors. Add a setPlace() method. Add
3013 goToPlace() method. Set class as presenter for TableSelectionView.
3014 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3015 Use the same TableSelectionActivity when switching between the List and
3017 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3018 Subclass the new HasSelectableTablePlace. This removes some duplicate
3020 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3021 New class to represent Places that display the TableSelectionView.
3022 * src/main/java/org/glom/web/client/place/ListPlace.java:
3023 Subclass the new HasSelectableTablePlace. This removes some duplicate
3025 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3026 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3027 Add Presenter interface. Add setBackLinkVisible() method. Add
3028 setBackLink() method.
3030 2011-05-18 Ben Konrath <ben@bagu.org>
3032 Enable the "Details" buttons.
3034 Right now only an empty details view is displayed.
3036 * src/main/java/org/glom/web/client/ClientFactory.java:
3037 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3038 Add DetailsView to ClientFactory.
3039 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3040 A basic activity for the details view.
3041 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3042 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3044 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3045 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3047 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3048 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3049 unnecessary super() in constructor.
3050 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3051 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3052 really shouldn't create a new TableSelectionActivity for both the ListPlace
3053 and the DetailsPlace so this should be considered a temporary solution.
3054 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3055 New file. Represents a URL for the details view.
3056 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3057 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3058 A basic details view interface and implementation.
3059 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3060 Enable the "Details" buttons.
3062 2011-05-12 Ben Konrath <ben@bagu.org>
3064 Use a LayoutPanel with multiple display areas for main layout.
3066 This is mostly a refactor in that there are no changes from the user
3067 point of view. These changes are required so that we can swap out the list view
3068 with the details view when the user clicks the "Details" button.
3070 * src/main/java/org/glom/web/client/ClientFactory.java:
3071 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3072 OnlineGlomView. Add TableSelectionView, ListView and
3073 AuthenticationPopup.
3074 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3075 for main layout. Add display regions for main activities. Add
3076 activity manager for for main activities.
3077 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3078 file from parts of the deleted OnlineGlomActivity.
3079 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3080 New file from parts of the deleted OnlineGlomActivity.
3081 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3082 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
3083 New files for app wide table change event.
3084 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3085 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
3086 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3087 Activity mappers for the main activities replace the deleted app-wide
3089 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
3090 Fix a spelling error in he comment.
3091 * src/main/java/org/glom/web/client/ui/ListView.java:
3092 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3093 Renamed from LayoutListView and modified for MVP. This still not a
3094 proper dumb view as prescribed by the MVP pattern but it works for now.
3095 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3096 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3097 New widget stripped out of the deleted OnlineGlomView.
3098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3099 Remove hack that is fixed by this patch.
3101 2011-05-06 Ben Konrath <ben@bagu.org>
3103 Rename OnlineGlomPlace to ListPlace.
3105 The only change besides the rename is that url will now display #list
3106 instead of #Document.
3108 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3109 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3110 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3111 * src/main/java/org/glom/web/client/place/ListPlace.java:
3112 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3114 2011-05-06 Ben Konrath <ben@bagu.org>
3116 Use Presenter for app navigation.
3118 This is the proper way to deal with Place (URL) changes with the MVP
3121 * src/main/java/org/glom/web/client/ClientFactory.java:
3122 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3123 PlaceHistoryMapper and PlaceHistoryHandler.
3124 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3125 PlaceHistoryMapper and PlaceHistoryHandler.
3126 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3127 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3128 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3129 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3130 Add Presenter interface and setPresenter methods. Rename addHyperLink
3131 to addDocumentLink taking only the document title as a parameter.
3133 2011-04-14 Ben Konrath <ben@bagu.org>
3135 Prompt for db username/password if they haven't been set.
3137 This is implemented with a popup widget that is contained within the
3138 OnlineGlomView and managed by the OnlineGlomActivity.
3140 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3141 methods for checking and setting the database username and password.
3142 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3143 new methods for checking and setting the database username and
3145 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3146 Display authentication popup if the JDBC connection to the database
3147 has not been authenticated.
3148 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3150 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3151 for dealing with the authentication popup.
3152 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3153 Implement the methods for dealing with the authentication popup.
3154 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3155 try to executed queries if the database connection hasn't been
3156 authenticated. Implement methods for checking and setting the
3157 database username and password.
3159 2011-04-12 Ben Konrath <ben@bagu.org>
3161 Make log messages a little clearer.
3163 Add a dash betweeen the document title and the table name.
3165 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3167 2011-04-12 Ben Konrath <ben@bagu.org>
3169 Protect against NPEs when cleaning up database resources.
3171 While this isn't strictly necessary because the exception is caught,
3172 not protecting against the NPEs makes it harder to find the real error
3175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3177 2011-04-12 Ben Konrath <ben@bagu.org>
3179 Move configuration of the servlet to the constructor.
3181 The servlet will be initialized even if the database authentication
3182 information is not set or correct. I still need to add the UI for prompting
3183 the user for the authentication information when it's required.
3185 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3186 javadocs for getDocumentTitles() method.
3187 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3188 Set error message when RPC fails.
3189 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3190 glom files directory from the configuration file. Try to set the
3191 database authentication information for the specific document if it's
3192 set and works otherwise try to use the global authentication
3193 information set for the directory.
3194 * src/main/resources/onlineglom.properties: Moved from
3195 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3196 Added detailed comments for the new keys.
3198 2011-04-11 Ben Konrath <ben@bagu.org>
3200 Remove unnecessary @Override in DocumentSelectionViewImpl.
3202 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3204 2011-04-11 Ben Konrath <ben@bagu.org>
3206 Remove center alignment in DocumentSelectionView.
3208 The title element is still centred but the document titles and bottom
3209 sentence are both left-aligned.
3211 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3213 2011-04-11 Ben Konrath <ben@bagu.org>
3215 Change 'Demo' naming convention to 'Document'.
3217 This is just a rename refactor with no functional changes to the code.
3219 * src/main/java/org/glom/web/client/ClientFactory.java:
3220 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3221 * src/main/java/org/glom/web/client/OnlineGlom.java:
3222 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3223 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3224 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3225 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3226 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3227 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3228 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3229 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3230 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
projects / online-glom:gwt-glom.git / blob