1 2011-12-22 Ben Konrath <ben@bagu.org>
3 Change charsetName to "UTF-8" when replacing line breaks.
5 JavaScript requires the charsetName to be "UTF-8". CharsetName values
6 that work in Java (such as "UTF8") will not work when compiled to
9 This fixes a problem with multi-line details view fields that have hard
10 line breaks. The "License Text" field on this page demonstrates the
13 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
15 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
17 2011-12-22 Ben Konrath <ben@bagu.org>
19 Fix another bug with related list navigation.
21 I've tested all the navigation buttons in all of the related lists
22 so things should be good now.
24 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
26 2011-12-22 Ben Konrath <ben@bagu.org>
28 Fix a crasher when refreshing the list view with the default table.
30 This crash will also happen when loading the list view with the default
31 table from a link or bookmark.
33 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
34 to the main document selection page when the document id hasn't been
36 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
37 the main document selection page when the document id hasn't been
39 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
40 values for the details place when the document id hasn't been set.
41 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
42 values for the list place when the document id hasn't been set.
44 2011-12-21 Ben Konrath <ben@bagu.org>
46 Protect against NPE when glom.document.locale is not in config.
48 This patch protects against an NPE when glom.document.locale is not in
49 the config file. This NPE will also happen if glom.document.locale is
52 The patch also updates the error message to display the class name when
53 the getMessage() returns null. This was happening when the NPE was
54 thrown and I had "Configuration Error: null". If an NPE is encountered
55 with this patch, "Configuration Error: NullPointerException " will be
58 This commit closes this bug:
60 https://bugzilla.gnome.org/show_bug.cgi?id=666669
62 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
64 2011-12-20 Murray Cumming <murrayc@murrayc.com>
66 Rename onlineglom.properties to onlineglom.properties.sample.
68 * src/main/resources/onlineglom.properties: Rename to:
69 * src/main/resources/onlineglom.properties.sample:
70 * src/main/resources/README: And add this file explaining that people
71 should rename it back when deploying.
73 2011-12-20 Murray Cumming <murrayc@murrayc.com>
75 Allow choosing the translation in the .properties file.
77 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
78 init(): Read a glom.document.locale value from the configuration file
79 and call Glom's TransatableItem::set_current_locale() method.
80 * src/main/resources/onlineglom.properties: Add a commented-out
81 example of this new setting.
83 It would be better to add &lang=de_DE to the URL, but the current
84 libglom API does not allow us to do this easily. I am working on that.
86 2011-12-19 Murray Cumming <murrayc@murrayc.com>
88 Avoid a crash in parsing of token parameters.
90 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
91 ava: getTokenParams(): Do not crash if a parameter has a key but no
92 value, and ignore parameters with neither.
94 2011-12-17 Murray Cumming <murrayc@murayc.com>
96 History token building/handling: Improve use of token parameters.
98 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
99 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
100 and buildParamsToken(HashMap), for use by derived classes.
101 Make the separator private because it is no longer be needed.
102 * src/main/java/org/glom/web/client/place/DetailsPlace.java
103 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
104 instead of manual string concatenation.
105 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
106 of hardcoded indices and awkward splitting code.
107 * src/main/java/org/glom/web/client/place/ListPlace.java
108 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
109 instead of manual string concatenation.
110 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
111 of hardcoded indices and awkward splitting code.
112 This should fix bug #666420
114 2011-12-16 Murray Cumming <murrayc@murrayc.com>
116 Fix a Navgiation->Navigation typo in the code.
118 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
119 Rename processNavgiation() to processNavigation().
121 2011-12-16 Murray Cumming <murrayc@murrayc.com>
123 Fix a seperator->separator typo in the code.
125 * src/main/java/org/glom/web/client/place/DetailsPlace.java
126 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
127 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
130 2011-12-15 Ben Konrath <ben@bagu.org>
132 Cleanup some comments.
134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
136 2011-12-14 Ben Konrath <ben@bagu.org>
138 Replace \n with <br/> for multiline text in the details view.
140 Vertical scrollbars are added when needed as well.
142 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
144 2011-12-14 Ben Konrath <ben@bagu.org>
146 Specify the font for document selection links.
148 * src/main/webapp/style.css:
150 2011-12-14 Ben Konrath <ben@bagu.org>
152 Fix bouncy CellTable while paging.
154 This doesn't currently work with related list tables in unselected
157 * src/main/java/org/glom/web/client/ui/list/ListTable.java
159 2011-12-14 Ben Konrath <ben@bagu.org>
161 Revamp the appearance of the document selection page.
163 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
164 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
165 * src/main/webapp/style.css:
167 2011-12-13 Ben Konrath <ben@bagu.org>
169 Set navigation button column to the smallest size possible.
171 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
173 2011-12-13 Ben Konrath <ben@bagu.org>
175 Change OpenButton nomenclature to NavigationButton.
177 Using NavigtionButton makes things more generic. Classes, methods and
178 variables have been changed.
180 This is a rename-only refactor.
182 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
183 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
184 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
185 Renamed from OpenButtonCell.
186 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
187 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
188 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
190 2011-12-12 Ben Konrath <ben@bagu.org>
192 Remove unnecessary String argument in RelatedListTable and ListViewTable.
194 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
195 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
196 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
197 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
199 2011-12-12 Ben Konrath <ben@bagu.org>
201 Update variable names and comments.
203 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
204 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
206 2011-12-12 Ben Konrath <ben@bagu.org>
208 Properly initialize numNonEmptyRows variable to zero.
210 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
211 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
213 2011-12-05 Ben Konrath <ben@bagu.org>
215 Add latest mockup with HTML tables.
217 Features of this mockup:
219 -> HTML table for flowtable
220 -> HTML table for flowtable column
221 -> Example of how related lists would look
222 -> Not using text entries for data items
224 The current version of Online Glom doesn't use HTML tables for the
227 This mockup has been sent to the glom-devel mailing list but it's good
228 to have it here as well.
230 * mockups/details-view-html-tables.html:
232 2011-12-05 Ben Konrath <ben@bagu.org>
234 Remove unnecessary getPrimaryKeyField() method.
236 getPrimaryKeyFieldForTable(String) has been renamed to
237 getPrimaryKeyField(String).
239 * src/main/java/org/glom/web/server/database/DBAccess.java:
240 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
241 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
243 2011-12-05 Ben Konrath <ben@bagu.org>
245 Add string representation of TypedDataItem value to conversion error message.
247 * src/main/java/org/glom/web/server/Utils.java: Logging the error
248 message was extracted into its own method to avoid duplication.
250 2011-12-05 Ben Konrath <ben@bagu.org>
252 Add type checking to navigation primary key value creation.
254 Create navigation primary key only if the expected type from the Glom
255 document matches the type returned by the SQL query.
257 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
259 2011-12-05 Ben Konrath <ben@bagu.org>
261 Rename a couple of variables in RelatedListNavigation.
263 This is a rename-only refactor.
265 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
267 2011-12-05 Ben Konrath <ben@bagu.org>
269 Move getListLayoutGroup() into getListViewLayoutGroup().
271 This removes getListLayoutGroup(). It was only being called by
272 getListViewLayoutGroup().
274 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
276 2011-12-05 Ben Konrath <ben@bagu.org>
278 Remove check for LayoutItem_Portal in list table method.
280 This check is no longer necessary because the method isn't being used
281 to create the LayoutItemPortal DTO.
283 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
285 2011-12-05 Ben Konrath <ben@bagu.org>
287 Properly support related list navigation.
289 Navigation from the "Repository Analyzer -> Package Scans ->
290 Dependencies" related table wasn't working because the primary key for
291 related tables wasn't being set properly. This commit fixes the
294 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
295 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
296 doesn't set the primary key properly for related list tables.
297 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
298 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
299 useful for getting the primary key for list view tables and for related
301 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
302 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
303 Move code to set the primary key for the table from the abstract
304 ListDBAccess class to ListViewDBAccess as it's only correct for list
306 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
307 Properly add primary key to related list tables.
309 2011-12-02 Ben Konrath <ben@bagu.org>
311 Properly set the horizontal alignment of fields.
313 This fix is for both the list tables and the details view.
315 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
316 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
317 to set the horizontal alignment of fields.
319 2011-12-02 Ben Konrath <ben@bagu.org>
321 Display currency codes in the details view.
323 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
325 2011-12-02 Ben Konrath <ben@bagu.org>
327 Avoid duplicate JNI call.
329 JNI is not as efficient as pure Java and this is an easy (and small)
332 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
333 Use previously retrieved value for whereClauseToTableName instead of
336 2011-12-02 Ben Konrath <ben@bagu.org>
338 Rename a couple of variables in RelatedListNavigation.
340 This is a rename-only refactor.
342 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
344 2011-12-02 Ben Konrath <ben@bagu.org>
346 Indicate clearly that a mismatched primary key type is a bug.
348 * src/main/java/org/glom/web/server/Utils.java: Change log level from
349 warning to error. Add 'This is a bug.' to message.
351 2011-12-02 Ben Konrath <ben@bagu.org>
353 Update / fix some comments.
355 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
357 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
359 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
360 Fix comments. Add some TODOs.
362 2011-12-02 Ben Konrath <ben@bagu.org>
364 Enable navigation to details view with string primary key from related list.
366 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
367 Create a text primary key value when return type of result is
368 java.sql.Types.VARCHAR.
370 2011-12-02 Ben Konrath <ben@bagu.org>
372 Use checkboxes for booleans in the details view.
374 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
376 2011-12-01 Ben Konrath <ben@bagu.org>
378 Improve performance of related list height calculation.
380 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
381 Put code to calculate the expected height in a static initializer so
382 that that it's only called once.
384 2011-12-01 Ben Konrath <ben@bagu.org>
386 Show related list tables in notebooks (again).
388 Calculate the height of the related list tables so the Notebook can be
389 set the correct height. The height of the related list table is also needed by
390 FlowTable to be able decide how to create the layout.
392 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
393 and set the Portal height based on the height of the related list
394 table and the Portal container.
395 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
396 Add method to calculate the height of the related list tables.
397 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
398 * src/main/webapp/style.css: Add css class for Pager. This is needed to
399 calculate the height of the Pager widget.
401 2011-12-01 Ben Konrath <ben@bagu.org>
403 Use CellTable API for table property instead of setting style on Element.
405 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
407 2011-12-01 Ben Konrath <ben@bagu.org>
409 Make ListViewTable and RelatedListTable a consistent height.
411 The tables are now a consistent height regardless of the contents of
412 the table. A hidden button is added to empty rows to ensure that the
413 height of these rows will match the height of rows with data.
415 A navigation button column is now added to every table. The width of
416 the navigation column is set to 0px when a RelatedListTable shouldn't
417 have navigation buttons. This maintains the a consistent row height in
418 tables that don't show the navigation buttons.
420 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
421 navigation column when not needed.
422 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
423 arguments for navigation button to constructor of ListViewTable.
424 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
425 hidden button for empty data rows.
426 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
427 arguments for navigation button to constructor.
428 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
429 create navigation buttons. Add hideNavigationButtons() method.
430 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
431 arguments for navigation button to constructor.
433 2011-12-01 Ben Konrath <ben@bagu.org>
435 Use 'visibility: hidden' in Utils.getWidgetHeight().
437 This is better choice because hidden elements are invisible, don't
438 respond to events and are not part of the tab order. They will,
439 however, take up space which is required to be able to calculate the
440 height of the widget.
442 * src/main/java/org/glom/web/client/Utils.java:
444 2011-12-01 Ben Konrath <ben@bagu.org>
446 Use Utils.getWidgetHeight() in FlowTable.
448 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
450 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
452 2011-12-01 Ben Konrath <ben@bagu.org>
454 Put the details css class name on the correct table column.
456 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
458 2011-11-30 Ben Konrath <ben@bagu.org>
460 Update for java-libglom API change.
462 The getters and setters on FieldFormatting and NumericFormat were
463 changed to remove the 'M'.
465 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
467 2011-11-29 Ben Konrath <ben@bagu.org>
469 Only allow RelatedListTables in Portals.
471 * src/main/java/org/glom/web/client/ui/details/Portal.java:
473 2011-11-29 Ben Konrath <ben@bagu.org>
475 Only create a contents panel for Portals when title is being set.
477 * src/main/java/org/glom/web/client/ui/details/Portal.java:
479 2011-11-29 Ben Konrath <ben@bagu.org>
481 Set TabLayoutPanel height based on calculated height its widgets.
483 This is a potential fix for this bug:
485 https://bugzilla.gnome.org/show_bug.cgi?id=665133
487 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
489 2011-11-29 Ben Konrath <ben@bagu.org>
491 Align details field labels and data with the Open buttons.
493 * src/main/webapp/style.css:
495 2011-11-29 Ben Konrath <ben@bagu.org>
497 Remove unnecessary <div> in the Notebook widget.
499 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
500 method to get container FlowPanel (<div>).
501 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
502 initWidget() method directly on the TabLayoutPanel widget instead of
503 Group's container widget.
505 2011-11-29 Ben Konrath <ben@bagu.org>
507 Don't add group titles for Portals in Notebooks.
509 This reverts the previous patch and fixes a bug I introduced with
510 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
512 * src/main/java/org/glom/web/client/ui/details/Group.java:
513 * src/main/java/org/glom/web/client/ui/details/Portal.java:
515 2011-11-28 Ben Konrath <ben@bagu.org>
517 Remove unused boolean argument in Portal constructor.
521 * src/main/java/org/glom/web/client/ui/details/Group.java:
522 * src/main/java/org/glom/web/client/ui/details/Portal.java:
524 2011-11-28 Ben Konrath <ben@bagu.org>
526 Remove hack for glom 1.18 style glom files.
528 * src/main/java/org/glom/web/client/ui/details/Group.java:
529 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
530 * src/main/java/org/glom/web/client/ui/details/Portal.java:
532 2011-11-28 Ben Konrath <ben@bagu.org>
534 Use Gda Value version of primary key to log result too large error.
536 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
538 2011-11-28 Ben Konrath <ben@bagu.org>
540 Don't use TypedDataItem.getText() for Unknown types from the URL.
542 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
543 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
544 instead of getText().
545 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
546 String field and getUnknown() method.
548 2011-11-28 Ben Konrath <ben@bagu.org>
550 Log an error message when the java-libglom .so is not present.
552 The error message was being set in the exception but not logged.
554 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
556 2011-11-28 Ben Konrath <ben@bagu.org>
558 Ignore LayoutItem_CalendarPortals.
560 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
561 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
563 2011-11-28 Ben Konrath <ben@bagu.org>
565 Extract method for creating the LayoutItemPortal DTO.
567 Just breaking the code up into smaller chunks.
569 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
571 2011-11-28 Ben Konrath <ben@bagu.org>
575 This should have been added with the refactor. Oops!
577 * src/main/java/org/glom/web/shared/TypedDataItem.java:
579 2011-11-28 Ben Konrath <ben@bagu.org>
581 Create primary key value from URL string using type from Glom document.
583 See this bug, comments 19 - 25:
585 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
587 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
588 create a TypeDataItem for the primary key here when loading from a
589 URL. Show the same string for the primary key value as was received
590 from the URL string (when loading from a URL).
591 * src/main/java/org/glom/web/server/Utils.java: Update method for
592 creating the Gda Value from the TypeDataItem to properly deal with
593 creating a Gda Value based on the Glom document type for the primary
594 key value string when loading from a URL.
595 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
596 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
597 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
598 Update for changed method name.
600 2011-11-27 Ben Konrath <ben@bagu.org>
602 Rename PrimaryKeyItem to TypedDataItem.
604 The name PrimaryKeyItem suggests what the class should be used for.
605 TypedDataItem is a neutral name that describes the class better.
607 This is a rename-only refactor.
609 * src/main/java/org/glom/web/client/OnlineGlomService.java:
610 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
611 * src/main/java/org/glom/web/client/Utils.java:
612 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
613 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
614 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
615 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
616 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
617 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
618 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
619 * src/main/java/org/glom/web/server/Utils.java:
620 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
621 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
622 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
623 * src/main/java/org/glom/web/shared/NavigationRecord.java:
625 2011-11-25 Ben Konrath <ben@bagu.org>
627 Improve Gda Value conversion from PrimaryKeyItem.
629 The value from the PrimaryKeyItem is only used if its type match the
630 type from the glom document.
632 * src/main/java/org/glom/web/server/Utils.java:
634 2011-11-25 Ben Konrath <ben@bagu.org>
636 Manually check if the java-liblgom .so is visible to the JVM.
638 It seems that Tomcat has problems when a static initializer throws an
639 exception. This check is done before the first method call into
640 java-libglom so that execution doesn't continue if the .so is not
643 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
645 2011-11-25 Ben Konrath <ben@bagu.org>
647 Improve browser configuration error messages.
651 https://bugzilla.gnome.org/show_bug.cgi?id=662792
653 * src/main/java/org/glom/web/client/OnlineGlomService.java:
654 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
655 getConfigurationErrorMessage() method.
656 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
657 Get and display a specific configuration error message when no Glom
659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
660 Implement getConfigurationErrorMessage() method. Surround configuration
661 code in the init() method with a try/catch block. This allows the
662 errors to be caught while keeping the servlet available to retrieve the
663 configuration error message.
665 2011-11-25 Ben Konrath <ben@bagu.org>
667 Don't use Strings to hold primary key values.
669 The primary key values are now held in a new data object
670 (PrimaryKeyItem) that holds type information and the primary key value
671 using the correct type.
673 * src/main/java/org/glom/web/client/OnlineGlomService.java:
674 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
675 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
676 PrimaryKeyItem instead of String to hold the primary key value.
677 * src/main/java/org/glom/web/client/Utils.java: Remove
678 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
679 PrimaryKeyItem based on the GlomFieldType and the DataItem.
680 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
681 PrimaryKeyItem instead of String to hold the primary key value. Load
682 document selection page when the documentID has not been set correctly.
683 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
684 DetailsPlace -> URL and URL -> DetailsPlace conversion with
686 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
687 Return empty string for URL instead of "null".
688 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
689 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
690 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
691 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
692 PrimaryKeyItem instead of String to hold primary key values.
693 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
694 PrimaryKeyValue to a Gda Value.
695 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
696 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
697 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
698 Replace temporary database access code that uses the PrimaryKeyValue to
699 Gda Value conversion.
700 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
701 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
702 PrimaryKeyItem instead of String.
703 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
704 hold primary key values.
706 2011-11-24 Ben Konrath <ben@bagu.org>
708 Use newly added java-libglom API to create queries.
710 This isn't finished. I still need to stop using Strings for primary key
711 values in the client code.
713 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
714 libglom to use fake connections so that retrieving the query string will
716 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
717 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
718 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
719 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
720 Use the newly added libglom sql methods and classes to create the
721 query. Add temporary hack to convert primary value strings to Gda
724 2011-11-23 Ben Konrath <ben@bagu.org>
726 Don't explicitly set the height of Portals.
728 See comments 6 - 10 of this bug for details:
730 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
732 * src/main/java/org/glom/web/client/ui/details/Portal.java:
734 2011-11-23 Ben Konrath <ben@bagu.org>
736 Use an HTML table instead of CSS for the FlowTable layout.
738 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
739 GWT's FlexTable to implement the FlowTable.
740 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
742 2011-11-18 Ben Konrath <ben@bagu.org>
744 Add boolean example to HTML table mockup.
746 * mockups/details-view-html-tables-text-entries.html:
748 2011-11-17 Ben Konrath <ben@bagu.org>
750 Ensure the pager buttons are always visible for related lists.
752 To accomplish this, I've turned off text wrapping in the list view and
753 related list tables for both the header and data text. The related list
754 table now has a fixed layout so the it doesn't overflow its container.
755 This is required to ensure that the cell text is clipped when it
756 overflows the cell and an ellipsis is added to the right side of the
757 cell when text is clipped.
759 A fixed table layout for the related list table in the details view
760 seems what we want for the details view anyway, so the side-effect is
763 The ellipsis will only be displayed in Firefox >= 7.
767 https://bugzilla.gnome.org/show_bug.cgi?id=662930
769 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
770 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
771 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
773 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
774 Set the 'table-layout: fixed' CSS property to the related list table.
775 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
776 'white-space: nowrap;' CSS property on both the list view and the
779 2011-11-16 Ben Konrath <ben@bagu.org>
781 Rework the fix for empty notebook tab labels.
783 Setting the empty group titles with its name caused problems for the
784 details layout. Instead of using libglom's
785 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
786 to the client when the title is empty. This allows the Notebook to use
787 the name when the title is empty without affecting anything else.
789 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
790 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
792 2011-11-16 Ben Konrath <ben@bagu.org>
794 Set group titles with name when title is empty.
796 This fixes a problem with an empty notebook tab label in the Lesson
797 Planner document. The forth tab in the notebook should be "Internet":
799 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
801 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
802 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
805 2011-11-16 Ben Konrath <ben@bagu.org>
807 Remove whitespace from the configured username properties.
809 This assumes that usernames won't have whitespace at the beginning
810 or end. But I think this is a reasonable assumption.
812 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
813 String.trim() to remove the whitespace from the username properties.
815 2011-11-15 Ben Konrath <ben@bagu.org>
817 Add details view mockup with HTML tables and text entries.
819 This is from the attachment on this bug:
821 https://bugzilla.gnome.org/show_bug.cgi?id=663109
823 * mockups/details-view-html-tables-text-entries.html:
825 2011-11-15 Ben Konrath <ben@bagu.org>
827 Add space between the columns of the flow table.
831 https://bugzilla.gnome.org/show_bug.cgi?id=662918
833 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
834 space between columns in the flow table.
836 2011-11-15 Ben Konrath <ben@bagu.org>
838 Add backup files to the .gitignore.
840 * .gitignore: Ignore files that end with ~.
842 2011-11-09 Ben Konrath <ben@bagu.org>
844 Use latest release of gwt-log.
846 Gwt-log releases are now being submitted to the maven central
847 repository so manual installation of the jar is no longer required.
849 * pom.xml: Update version and groupId of gwt-log dependency.
851 2011-10-31 Ben Konrath <ben@bagu.org>
853 Don't use GWT numeric formatting to override the glom currency formatting.
855 Currencies are now displayed like they are in Glom. See this bug:
857 https://bugzilla.gnome.org/show_bug.cgi?id=646216
859 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
861 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
862 currency code to constructor and set it when the cell is rendered.
863 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
864 currency code to the constructor of the NumericCell.
866 2011-10-27 Ben Konrath <ben@bagu.org>
868 Require the latest release of java-libglom (1.17.4).
872 2011-10-26 Ben Konrath <ben@bagu.org>
874 Add style to Notebook that matches current theme.
876 It's not the best style in the world but it's better than the default.
878 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
879 padding at the bottom of the child widgets.
880 * src/main/webapp/style.css: Add style for the Notebook.
882 2011-10-26 Ben Konrath <ben@bagu.org>
884 Move servlet initialization code to overridden init method.
886 This is half of the solution to getting proper error messages
887 displayed when configuration errors occur. Here's the relevant bug:
889 https://bugzilla.gnome.org/show_bug.cgi?id=662792
891 The rest of the solution involves surrounding the init method with a
892 try/catch block and setting a global variable with the error /
893 exception. A new async method should be created to retrieve and display
894 the error message / exception.
896 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
897 code from constructor to init method adding exceptions as needed.
899 2011-10-26 Ben Konrath <ben@bagu.org>
901 Add script to monitor and restart tomcat if required.
903 * utils/check-and-recover-tomcat.py: New file.
905 2011-10-26 Ben Konrath <ben@bagu.org>
907 Display the correct number of data items in the pager.
911 https://bugzilla.gnome.org/show_bug.cgi?id=661441
913 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
914 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
915 The implementation is the same for both tables: Keep track of the
916 number of non-empty rows and fire and RowCountChangeEvent after the data has
918 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
919 custom Pager class that subclasses SimplePager to handle displaying
920 the correct number when empty rows have been added.
922 2011-10-26 Ben Konrath <ben@bagu.org>
924 Correct error in previous commit.
926 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
927 eventBus parameter from listView.setCellTable().
929 2011-10-26 Ben Konrath <ben@bagu.org>
931 Fix error in TODO comment.
933 * src/main/java/org/glom/web/client/activity/ListActivity.java:
935 2011-10-24 Ben Konrath <ben@bagu.org>
937 Create Notebook widgets to the details view.
939 This isn't finished just yet - I still need to create a reasonable
940 style to match the current theme.
942 * src/main/java/org/glom/web/client/Utils.java: Add method for
943 calculating the height of a widget. This is used in the Notebook class.
944 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
945 new constructor method in Group.
946 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
947 method for creating child widget that can be used by subclasses
948 like Notebook. New constructor that allows disabling the group
949 titles - Notebooks don't set a group title for their child groups.
950 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
951 to make Notebooks using GWT's TabLayoutPanel.
952 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
953 constructor that allows disabling the group titles.
954 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
955 LayoutItemNotebook DTO.
956 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
957 DTO for Notebooks. It's just an empty class for now but we might need
958 it to transfer some specific information in the future.
960 2011-10-21 Ben Konrath <ben@bagu.org>
962 Add navigation buttons to related list tables.
964 * src/main/java/org/glom/web/client/OnlineGlomService.java:
965 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
966 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
967 method getSuitableRecordToViewDetails() for getting the table name
968 and primary key value for related list navigation buttons.
969 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
970 private cell renderer class to get the navigation information for
971 related list tables from the server. Extract the navigation
972 processing code from the details cell navigation and use it for the
973 related list navigation as well.
974 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
975 cell renderer class for the details open buttons. This was needed
976 because the related list navigation buttons and the list view
977 navigation buttons need to react differently when clicked.
978 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
979 the onEnterKeyDown() method because it's now overriden in the
980 subclasses that are specific to the related list tables and the list
982 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
983 the vertical size a little because the buttons add a bit of vertical
984 space to table. This is not a perfect solution because the vertical
985 size of with table fewer than 5 rows will be a little smaller.
986 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
987 changes in how navigation buttons are handled.
988 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
989 getSuitableRecordToViewDetails() using the new RelatedListNavigation
990 database access object.
991 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
992 to find the portal for a given relationship name from
993 RelatedListDBAccess. Add method to find a primary key field for a
995 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
996 Move code to find the portal for a given relationship name to
998 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
999 New file: database access object for getting the related list
1000 navigation information (the table name and the primary key value).
1001 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1002 DTO for transferring a table name to navigate to and a primary key
1004 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1005 boolean and getter/setter to specifies if the related list should add
1008 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1010 Use the master branch of java-libglom
1012 * pom.xml: Depend on java-libglom 1.19 instead.
1014 This is the master branch. See also the libglom-1-18 branch.
1016 2011-10-11 Ben Konrath <ben@bagu.org>
1018 Enable the open navigation button when the data has been set.
1020 This avoids having active buttons that don't do anything when the data
1023 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1025 2011-10-11 Ben Konrath <ben@bagu.org>
1027 Use IsWidget interface for FlowTableItem.
1029 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1030 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1032 2011-10-11 Ben Konrath <ben@bagu.org>
1034 Remove GWT styling from open button in details view.
1036 There are still some issues with how the details cell is arranged but
1037 this should be made to match Glom 1.20. I'm going to leave fixing this
1038 until I have Glom 1.20 up and running.
1040 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1041 style name on open button.
1042 * src/main/webapp/style.css: Move and edit details-navigation class.
1043 Re-arrange some classes to make them appear in the same order as the
1046 2011-10-07 Ben Konrath <ben@bagu.org>
1048 Update to GWT 2.4.0.
1050 * .gitignore: Ignore new cache directory.
1051 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1052 * pom.xml: Change GWT and maven plugin to 2.4.0.
1053 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1055 * src/main/java/org/glom/web/client/ClientFactory.java:
1056 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1057 * src/main/java/org/glom/web/client/OnlineGlom.java:
1058 Update source for API changes.
1059 * utils/build-onlineglom-war.sh: Remove cache directory before the
1062 2011-10-07 Ben Konrath <ben@bagu.org>
1064 Add navigation buttons in the details view.
1066 This isn't finished but I thought I'd commit what I have as it's a
1067 pretty good start. I still need to:
1069 1. Change the style so that it fits better into the current theme
1070 2. Adjust the details cell to expand as much as possible.
1072 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1073 click handlers to navigation buttons in the DetailsCells. Create a
1074 refreshData() method to get just the data from the server without the
1076 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1077 Update the tableSelector and browser title when the table name
1078 changes without using the tableSelector.
1079 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1080 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1081 getDetailsCells() to getCells(). Update variable names.
1082 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1083 method to set click handler on navigation button. Rename a few
1084 variables. Add navigation buttons where needed.
1085 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1086 variables and methods.
1087 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1088 navigation boolean and navigation table as required in the
1089 LayoutItemField DTO.
1090 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1091 variables for navigation along with getter/setter methods.
1093 2011-10-07 Ben Konrath <ben@bagu.org>
1095 Rename Field to DetailsCell.
1097 This is a refactor-only commit. No functionality has been added or
1100 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1101 Update variable and method names.
1102 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1103 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1104 variable and method names.
1105 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1107 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1108 variable and method names.
1110 2011-10-07 Ben Konrath <ben@bagu.org>
1112 Create separate methods for layout and data the details view.
1114 This is a refactor-only commit. No functionality has been added or
1117 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1118 private methods: setData(), createLayout().
1120 2011-10-07 Ben Konrath <ben@bagu.org>
1122 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1124 This is part of a change to get navigation buttons in the details view
1125 but it should have been done this way from the start.
1127 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1128 for method name change in TableSelectionView.
1129 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1130 Create TableChangeEvent and set the browser title using the
1131 TableSelectionView API.
1132 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1133 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1134 Change getSelectedTable() to getSelectedTableName(). Add
1135 getSelectedTableTitle().
1137 2011-10-07 Ben Konrath <ben@bagu.org>
1139 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1141 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1143 2011-10-07 Ben Konrath <ben@bagu.org>
1145 Update TableChangeEvent to use newTableName naming convention.
1147 This makes the class more consistent with GWT naming conventions.
1149 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1150 Update for method name change in TableChangeEvent.
1151 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1152 for method name change in TableChangeEvent.
1153 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1154 newTableName variable and getter method. Make toDebugString()
1157 2011-09-30 Ben Konrath <ben@bagu.org>
1159 Disable the pager in the list tables when the data row count is less than the minimum.
1161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1162 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1164 2011-09-30 Ben Konrath <ben@bagu.org>
1166 Add empty rows to the end of related list and list view tables.
1168 I also extracted the cell rendering classes from the ListTable because
1169 the code was becoming a little crazy with all the anonymous inner
1170 classes. My plan is to use these cell rendering classes in the details
1171 view as well so this refactor will be needed for that change.
1173 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1174 set the row count in related list tables if the data has more rows
1175 than the minimum number of rows visible.
1176 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1177 row count in list view tables if the data has more rows than the
1178 minimum number of rows visible.
1179 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1180 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1182 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1183 for rendering TYPE_NUMERIC cells. The code was extracted from the
1185 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1186 class for rendering cells with buttons in list views. The code was
1187 extracted from the ListTable class.
1188 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1189 for rendering TYPE_TEXT cells. The code was extracted from the
1191 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1192 Add empty rows to the end of the data if required. Implement
1193 ListTable.getMinNumVisibleRows().
1194 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1195 cell renderer code to public classes. Return null in
1196 Column.getValue() for empty rows. Add new abstract method:
1197 getMinNumVisibleRows(). Move code to set the row count of the list view
1198 table to ListViewImpl.
1199 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1200 empty rows to the end of the data if required. Implement
1201 ListTable.getMinNumVisibleRows().
1204 2011-09-27 Ben Konrath <ben@bagu.org>
1206 Use GWT.log for client-side debugging statements.
1208 These are optimized out when deployed so I should have used this method
1209 in the first place. These statements will eventually be replaced with some sort
1210 of notification in the browser.
1212 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1213 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1214 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1215 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1216 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1218 2011-09-27 Ben Konrath <ben@bagu.org>
1220 Put tableselector on the right, back to list link on right.
1222 The idea is that the table selector is acting like a label for the
1223 currently displayed table so it should be placed below the document title. This
1224 puts the table title in a similar position to where it is in Glom.
1226 * mockups/details-contacts.html:
1227 * mockups/details-projects.html:
1228 * mockups/listview-contacts.html:
1229 * mockups/listview-projects.html:
1230 * mockups/style.css:
1231 Update mockups to match how the interfaces currently look.
1232 * src/main/webapp/style.css: Swap positions of backlink with the table
1233 selector. Add some space on the left side of the table selector to
1234 line things up with the document title.
1236 2011-09-27 Ben Konrath <ben@bagu.org>
1238 Add field colouring to details view.
1240 This change re-works how field colouring works. The colour formatting
1241 information is now set to the client with the layout information instead of
1242 with the data. This eliminates the need to send the same colour strings for
1243 data in list view column when colour information is set.
1245 In order to set an alternate colour for negative numeric values, the
1246 number is now sent to client and formatted with the GWT NumberFormat class.
1248 This change also fixes:
1250 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1252 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1253 internationalization framework which is needed for client side numeric
1255 * src/main/java/org/glom/web/client/Utils.java: New file for some
1256 client static utility methods.
1257 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1258 the DataItem object to the Field class. Use a utility method to
1259 create the foreignKeyValue string.
1260 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1261 alignment and text colours in the constructor. Add setData(DataItem)
1262 method. Remove setText(String) method.
1263 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1264 colour information to GlomTextCell. Create and use GlomNumberCell for
1265 rendering numbers. Use utility method to get the string for the
1266 primary key of the key provider. Re-work how the horizontal alignment
1268 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1269 formatting to layout information. Methods for converting the libglom
1270 formatting information were moved from DBAccess.
1271 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1272 numeric formatting (it's now done on the client side). Don't set text
1273 colours in DataItem. Move libglom formatting conversion methods to
1275 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1276 getters/setters for text colour information.
1277 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1278 for transferring the libglom NumericFormat information to the client.
1279 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1280 and getters/setters for: GlomNumericFormat, background colour and
1281 foreground colour strings.
1283 2011-09-26 Ben Konrath <ben@bagu.org>
1285 Simplify code that iterates through the LayoutGroup.
1287 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1289 2011-09-26 Ben Konrath <ben@bagu.org>
1291 Accept Eclipse formatting for OnlineGlomServiceAsync.
1293 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1295 2011-09-26 Ben Konrath <ben@bagu.org>
1297 Don't use the ListDBAccess classes to get the primary key layout information.
1299 This was causing a bug where the wrong index for the hidden primary key
1300 was being sent to the client.
1302 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1303 primary key while creating the LayoutGroup DTO. Create a
1304 LayoutItemField DTO for hidden primary keys. Don't use the
1305 RelatedListDBAccess because it was only used for getting the primary
1307 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1308 access modifier from public to protected for getPrimaryKeyField() and
1309 getPrimaryKeyLayoutItemField().
1310 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1311 abstract method getExpectedResultSize() because RelatedListDBAccess
1312 doesn't have enough info to implement it.
1313 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1314 Remove @Override for getExpectedResultSize().
1315 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1316 Remove method getExpectedResultSize().
1318 2011-09-23 Ben Konrath <ben@bagu.org>
1320 Log which layout (list or details) the ignored item is from.
1322 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1324 2011-09-23 Ben Konrath <ben@bagu.org>
1326 Remove annotations that turn off code formatting in DataItem.
1328 * src/main/java/org/glom/web/shared/DataItem.java:
1330 2011-09-23 Ben Konrath <ben@bagu.org>
1332 Rename GlomField to DataItem and update associated methods.
1334 This is a rename-only refactor. No functionality has been added or
1337 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1338 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1339 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1340 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1341 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1342 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1343 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1344 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1345 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1346 * src/main/java/org/glom/web/server/database/DBAccess.java:
1347 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1348 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1349 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1350 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1351 * src/main/java/org/glom/web/shared/DataItem.java:
1352 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1353 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1355 2011-09-23 Ben Konrath <ben@bagu.org>
1357 Rename GlomDocument to DocumentInfo and update associated methods.
1359 This is a rename-only refactor. No functionality has been added or
1362 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1363 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1364 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1365 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1366 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1367 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1368 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1370 2011-09-20 Ben Konrath <ben@bagu.org>
1372 Require java-libglom 1.17.3.
1374 This picks up the fix for the seg fault problem with the Scenes table
1375 in the Openismus Film Manager example.
1379 2011-09-20 Ben Konrath <ben@bagu.org>
1381 Change the way sort clause is added for primary key when no sort clause is requested.
1383 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1384 before the sort clause is created. When a sort clause is not requested, the
1385 sort clause is created by finding the primary key in the LayoutFieldVector
1388 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1390 2011-09-20 Ben Konrath <ben@bagu.org>
1392 Log error message if no documents are found in the configured directory.
1394 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1395 Extract the glom file extension string to a private static final class
1396 variable (mostly as syntactic sugar). Accept a minor formatting change.
1397 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1398 the example glom.document.directory configuration property to make it
1399 more clear that it can any directory, not just the home directory.
1401 2011-09-18 Ben Konrath <ben@bagu.org>
1403 Add related lists to details view.
1405 The related list table has support for paging and sorting just like the
1406 table in the list view.
1408 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1409 SQL queries for the related list tables.
1410 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1411 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1412 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1413 Rename getList methods to getListView and add comments. Remove
1414 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1415 it being unused. Add methods: getDetailsLayoutAndData(),
1416 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1417 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1418 Create the layout and set the data for the fields in one async call
1419 instead of two. Create related lists where appropriate.
1420 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1421 for method name changes in OnlineGlomService.
1422 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1423 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1424 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1426 * src/main/java/org/glom/web/client/ui/ListView.java:
1427 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1428 tableName from setCellTable(). Create a ListViewTable instead of
1430 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1431 represent a data field in the details view.
1432 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1433 from addDetailsCell() to Field class. Keep track of the Fields and
1434 Portals in the details view.
1435 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1436 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1437 and add a method to get it. Add method to set the contents of the
1439 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1440 New class for related list tables. This class has the data provider
1441 for the related list table.
1442 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1443 abstract class which is the base class for the ListViewTable and the
1445 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1446 New class for list view tables. This class has the data provider for
1447 the list view table.
1448 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1449 methods for related list tables. Add more information to the
1450 LayoutItemField and LayoutItemPortal DTOs.
1451 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1452 Remove debugging print statement.
1453 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1454 Remove debugging print statements. Add primary key field to SQL count
1456 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1457 Remove unnecessary LayoutFieldVector parameter from
1458 getResultSizeOfSQLQuery() method.
1459 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1460 New class for related list table database access.
1461 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1462 class that is a wrapper DTO for details view layout and data.
1463 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1464 new 'fromField' string to this DTO.
1465 * src/main/webapp/style.css: Remove bottom margin and override top
1468 2011-09-15 Ben Konrath <ben@bagu.org>
1470 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1472 This sets things up to make it easier to add the data retrieval for
1473 related lists (portals). No user noticeable changes were made with
1476 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1477 class has the code to retrieve the layouts and access the
1478 database using the new database helper classes.
1479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1480 Most of the functionality has been removed from this class. This
1481 class now represents the public interface for the client side
1482 code. It also deals with configuring the servlet and cleaning
1483 things up when the servlet is stopped.
1484 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1485 of static methods into this utility class.
1486 * src/main/java/org/glom/web/server/database/DBAccess.java:
1487 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1488 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1489 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1490 These classes have the database retrieval code. The class hierarchy
1491 has been setup to make it easy to reuse code for similar
1494 2011-09-06 Ben Konrath <ben@bagu.org>
1496 Create separate classes for list table code and the data provider.
1498 As part of this refactor, I also split up the code a bit to make it
1501 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1502 table code to two new classes (below).
1503 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1504 with code from ListViewImpl.
1505 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1506 New file with code from ListViewImpl.
1508 2011-09-06 Ben Konrath <ben@bagu.org>
1510 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1512 This fixes the LayoutItemPortal DTO to match the libglom layout object
1515 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1517 2011-09-01 Ben Konrath <ben@bagu.org>
1519 Set title of Portals in the Details View.
1521 * pom.xml: Bump required version of java-libglom to 1.17.1.
1522 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1523 widget creation to its own class. Add comments to constructor.
1524 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1525 The code is mostly from the Group class with the title now set.
1526 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1527 title of Portal. Update some comments. Fix some code formatting.
1529 2011-09-01 Ben Konrath <ben@bagu.org>
1531 Remove TODO comment for the flow table column width.
1533 The flow table column width is working correctly and doesn't need to be
1534 changed. See this mailing list post for more info:
1536 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1538 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1540 2011-08-27 Ben Konrath <ben@bagu.org>
1542 Add document title (database name) to top of the browser page.
1544 I added the document title to the TableSelecitonView but that will
1545 change if / when we add a view that doesn't require table selection.
1547 * mockups/details-contacts.html:
1548 * mockups/details-projects.html:
1549 * mockups/listview-contacts.html:
1550 * mockups/listview-projects.html:
1551 * mockups/style.css: Add document title to mockups to keep things
1553 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1554 sizes to account for the document title.
1555 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1556 Set the document title when it has been retrieved from the server.
1557 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1558 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1559 and implement setDocumentTitle(String) method.
1560 * src/main/webapp/style.css: Add ID for document title style.
1562 2011-08-25 Ben Konrath <ben@bagu.org>
1564 Add NavigationType enum to LayoutItemPortal DTO.
1566 This is the start of adding support for Portals to the Details View.
1568 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1569 LayoutItem_Portal.navigation_type enum from libglom to
1570 LayoutItemPortal.NavigationType enum.
1571 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1572 NavigationType enum, field for storing the NavigationType and getter
1575 2011-08-25 Ben Konrath <ben@bagu.org>
1577 Implement the flow table layout in the Details View.
1579 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1580 FlowTable to Group to account for the renamed class.
1581 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1582 File. This is a container widget that implements the Glom details view
1583 flow table behaviour.
1584 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1585 org/glom/web/client/ui/FlowTable.java.
1586 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1587 so that the size of the subgroups are a closer match to the size of
1588 the Glom subgroups. This makes the flowtable layout match the layout
1589 in Glom for the Music Collection example file.
1591 2011-08-16 Ben Konrath <ben@bagu.org>
1593 Create container element for LayoutItemPortal in Details View.
1595 This will help me develop the layout for the FlowTable.
1597 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1598 fieldPanel variable to detailsCell.
1600 2011-08-15 Ben Konrath <ben@bagu.org>
1602 Set the height of the data element in the Details View.
1604 I changed the InlineLabels (text in a span element) to Labels (text in
1605 a div element) so that I could set the height of the details-data
1606 elements instead of the details-cell parent elements. This allows the
1607 the details-data element to display the correct height if style is
1608 applied that shows the height.
1610 This change has the added benefit of allowing the order of the labels
1611 and data elements to be changed for right-to-left languages.
1613 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1614 InlineLabels to Labels.
1615 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1616 InlineLabels to Labels. Set the height of the data element.
1617 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1618 multiline text height in the Formatting DTO.
1619 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1620 for multiline height along with getter and setter methods.
1621 * src/main/webapp/style.css: Adjust style to account for the change
1622 from span elements to div elements in the details cell.
1624 2011-08-15 Ben Konrath <ben@bagu.org>
1626 Make the List View appearance match the mockups.
1628 It doesn't match exactly but it's much better than it was.
1630 * mockups/listview-contacts.html: Remove unused css classes.
1631 * mockups/listview-projects.html: Remove unused css classes.
1632 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1633 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1634 for mainPanel instead of VerticalPanel (table). Set style name on
1635 CellTable. Set style name on Details column. Right-align Details
1637 * src/main/webapp/style.css: Adjust properties to match the mockups.
1639 2011-08-12 Ben Konrath <ben@bagu.org>
1641 Add better support for subgroups in the details view.
1643 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1644 changed FlowTable constructor.
1645 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1646 support for subgroups and subgroup-titles.
1647 * src/main/webapp/style.css: Add CSS class for subgroups and
1650 2011-08-12 Ben Konrath <ben@bagu.org>
1652 Return the top level LayoutGroup title.
1654 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1656 2011-08-11 Ben Konrath <ben@bagu.org>
1658 Make the TableSelector header match the mockup.
1660 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1661 the layout panel. Properly lineup the table selection header with
1662 the list and details view.
1663 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1664 margin around the details view.
1665 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1666 Rename listBox variable to tableSelector. Set id for the style sheet.
1667 Use a FlowPanel instead of a HorizontalPanel.
1668 * src/main/webapp/style.css: Add properties to make the TableSelector
1669 box match the mockups.
1671 2011-07-13 Ben Konrath <ben@bagu.org>
1673 Update install script for java-libglom version change.
1675 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1678 2011-07-13 Ben Konrath <ben@bagu.org>
1680 Add support sub-group in the details view.
1682 I also removed the code that special-cased the default details view
1685 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1687 I still have to make a proper flowtable.
1689 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1690 Don't special-case default details view layout.
1691 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1692 addLayoutField() as I'm going to use it.
1693 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1694 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1696 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1697 extracted from DetailsViewImpl.GroupPanel. Add support for
1699 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1700 column count when getting the details layout.
1702 2011-07-12 Ben Konrath <ben@bagu.org>
1704 Set browser title with database and table titles.
1706 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1707 Set the browser title when the table changes and when the activity
1709 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1710 title when retrieving document info (the GlomDocument object).
1711 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1712 with getter and setter methods. Remove unused convenience constructor.
1713 Use default code formatting.
1715 2011-07-12 Ben Konrath <ben@bagu.org>
1717 Ignore LayoutItemPortals in the details view.
1719 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1722 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1723 LayoutItemPortal layout objects.
1724 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1725 LayoutItemPortal objects when retrieving the details layout.
1726 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1727 file. This is an empty class and just used to get type information for
1730 2011-07-12 Ben Konrath <ben@bagu.org>
1732 Use java-libglom 1.17.0.
1736 2011-07-11 Ben Konrath <ben@bagu.org>
1738 Remove "Table:" label from table selector.
1740 This matches a recent change in the Glom UI.
1742 * mockups/details-contacts.html:
1743 * mockups/details-projects.html:
1744 * mockups/listview-contacts.html:
1745 * mockups/listview-projects.html: Remove the "Table:" label from the
1747 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1749 2011-07-11 Ben Konrath <ben@bagu.org>
1751 Add main groups to the details view.
1753 This makes things look a little nicer in the details view. The next step
1754 is to implement the flowtable.
1756 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1757 resources from the standard gwt css theme. Standard.css is now
1758 included in OnlineGlom.html so that the online glom css rules have
1759 precedence over the gwt theme.
1760 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1761 the whole LayoutGroup to the DetailsView instead of just the titles.
1762 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1763 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1764 details layout with a helper class (GroupPanel). I might extract this
1765 class when I make the full flowtable.
1766 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1767 string as default so I don't have to worry about NPEs when processing
1769 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1770 note beside OnlineGlom.gwt.xml above).
1771 * src/main/webapp/style.css: Add default font-size to body to override
1772 the font-size set by the standard theme. Don't use h2 tags for
1773 group-title. Create new details-cell class.
1775 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1777 ConfiguredDocument: Set the port number too.
1779 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1780 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1781 Glom document. Presumably this worked sometimes so far because there is a
1782 default port number.
1784 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1786 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1788 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1789 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1790 correct, though we should throw an exception too.
1792 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1794 Fix a addDocuemnt typo.
1796 * src/main/java/org/glom/web/shared/Documents.java
1797 (Documents.addDocuemnt): Rename to addDocument().
1798 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1799 (OnlineGlomServiceImpl.getDocuments): Adapt.
1801 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1803 Slightly improved log output when connection fails.
1805 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1806 (ConfiguredDocument.setUsernameAndPassword):
1807 We don't know for sure if it' the username/password that's wrong, so
1808 rephrase the message.
1809 Also ouput the exception message, though it's generic in this case.
1811 2011-07-08 Ben Konrath <ben@bagu.org>
1815 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1816 added braces to a one line if statement because the Eclipse formatter
1817 was getting confused.
1819 2011-07-07 Ben Konrath <ben@bagu.org>
1821 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1823 These should really be two separate tasks but I counldn't get things to
1824 work with GWT 2.2.0 and Eclipse 3.7.
1828 * .settings/org.eclipse.jdt.core.prefs:
1829 * .settings/org.eclipse.jdt.ui.prefs:
1830 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1831 * .settings/org.eclipse.m2e.core.prefs:
1832 Add new config files. Update current files. Remove references to the
1833 webtools plugins as we're not using any of the webtools features.
1834 * .gitignore: Add logs directory which is created when running with
1836 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1837 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1838 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1840 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1842 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1844 onlineglom.properties: Add explanatory comments.
1846 * src/main/resources/onlineglom.properties: Also change the default user
1847 from ben to someuser, to avoid the risk of people thinking we just
1848 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1850 2011-06-28 Ben Konrath <ben@bagu.org>
1852 Use filename in Log for incorrect passwords.
1854 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1855 getFileName(String) method to get the filename from the URI.
1857 2011-06-28 Ben Konrath <ben@bagu.org>
1859 Add the table name to the URL token for the ListPlace.
1861 This makes things consistent between the DetailsPlace and the
1862 ListPlace. It also allows the the ListPlace to be bookmarked.
1864 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1865 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1867 Remove getDefaultListLayout(). The default layout is now returned
1868 by the getListLayout() method when the table name is an empty string.
1869 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1870 Add table name field. Change to a new ListPlace when the table
1871 has been changed. Use getListLayout() for getting the default
1873 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1874 Add table name field. Set the correct table name in the list box
1875 when loading from bookmark. This corrects a problem for the
1877 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1878 Move table name to super-class (HasSelectableTable). Move document
1879 and table URL keys to super-class in HasSelectableTable.
1880 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1881 Add table name field. Add Tokenizer class with URL key common to
1882 the subclasses (DetailsPlace and ListPlace).
1883 * src/main/java/org/glom/web/client/place/ListPlace.java:
1884 Add table name. Add code to parse the URL token.
1885 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1886 Update ListPlace construction with empty table name string.
1887 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1888 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1889 Change setTableSelectedIndex(int) to setSelectedTableName(String).
1890 Update ListPlace construction with table name string.
1891 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1892 Change defaultTableName field to tableName to reflect how it's now
1893 used. Update the getter and setter methods.
1895 2011-06-28 Ben Konrath <ben@bagu.org>
1897 Enable the table selector in the DetailsView.
1899 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1900 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1901 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1902 Remove getDefaultDetailsLayout(). The default layout is now returned
1903 by the getDetailsLayout() method when the table name is an empty
1905 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1906 event handler for table change event. Change to using
1907 getDetailsLayout() for the default details layout.
1908 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
1910 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
1911 when navigating to the details place.
1913 2011-06-27 Ben Konrath <ben@bagu.org>
1915 Use filename based unique document ID in URL and for RPC.
1917 The document ID is the glom document name with spaces (' ') replaced
1918 with pluses ('+') and without the .glom extension.
1920 This change is mostly a string substitution of 'documentTitle' for
1921 'documentID'. The only code change is the addition of a Documents DTO to get the
1922 filename to document title mappings as indicated below.
1924 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1925 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1926 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1927 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1928 Use Documents DTO to create the document links in the document
1930 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1931 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1932 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1933 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1934 * src/main/java/org/glom/web/client/place/ListPlace.java:
1935 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1936 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1937 * src/main/java/org/glom/web/client/ui/ListView.java:
1938 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1939 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1940 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1941 * src/main/java/org/glom/web/server/Log.java:
1942 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
1943 getDocumentTitles() to getDocuments() and return the Documents DTO.
1944 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
1945 transferring the filename to document title mappings.
1947 2011-06-25 Ben Konrath <ben@bagu.org>
1949 Make the authentication popup work again.
1951 This bug was introduced when I extracted ConfiguredDocument to its own class.
1953 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
1954 correct success / fail status in setUsernameAndPassword().
1956 2011-06-25 Ben Konrath <ben@bagu.org>
1958 Use filename as unique key for configuring database usernames and passwords.
1960 This replaces the use of the Glom document title which could change
1961 depending on the locale. Thanks to Murray Cumming for pointing out this
1964 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1965 * src/main/resources/onlineglom.properties:
1967 2011-06-24 Ben Konrath <ben@bagu.org>
1969 Pass primary key value to DetailsView.
1971 This enables the DetailsView to load the correct data.
1973 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1974 primary key value field and set in constructor. Pass primary key
1975 value to getDetailsData().
1976 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
1977 variables for document title and primary key value.
1978 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
1979 key value to the DetailsPlace.
1981 2011-06-24 Ben Konrath <ben@bagu.org>
1983 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
1985 This allows the primary key to be retrieved by the Details button. This
1986 functionality has not been implemented yet but it's in the works.
1988 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
1989 the LayoutGroup result to ListView.setCellTable instead of all of its
1990 fields individually.
1991 * src/main/java/org/glom/web/client/ui/ListView.java:
1992 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
1993 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
1994 get the primary key for the table.
1995 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1996 index of the primary key in the LayoutGroup accounting for hidden
1997 primary keys. Rename getJavaNumberFormat() to
1998 convertToJavaNumberFormat() for consistency. Cleanup / add some
2000 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2001 field for primary key index and a field to indicate whether the
2002 primary key is hidden or not.
2004 2011-06-23 Ben Konrath <ben@bagu.org>
2006 Rename getTableData methods to getListData.
2008 This is a rename refactor for consistency with other methods.
2010 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2011 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2012 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2013 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2015 2011-06-23 Ben Konrath <ben@bagu.org>
2017 Extract the ConfiguredDocument innerclass into its own class.
2019 This makes the servlet code more object oriented.
2021 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2022 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2023 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2024 new ConfiguredDocument class.
2026 2011-06-21 Ben Konrath <ben@bagu.org>
2028 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2030 This makes things more inline with how libglom works and reduces code
2031 duplication. This refactor lays the groundwork for adding the primary key to
2032 the LayoutGroup object.
2034 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2035 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2036 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2037 Change method names to getListLayout and getDefaultListLayout for
2038 consistency. Use LayoutGroup as the DTO for the list layout instead of
2039 ColumnInfo and LayoutListTable.
2040 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2041 new method names along with the LayoutGroup object for transferring the
2043 * src/main/java/org/glom/web/client/ui/ListView.java:
2044 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2045 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2046 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2048 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2049 Replaced with LayoutGroup.
2050 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2051 expectedResultSize and defaultTableName fields which are needed for
2053 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2054 type field which is needed for the list layout but will also be
2055 useful for the details layout as things progress.
2056 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2057 Make class abstract. Remove the unnecessary
2058 getFormattingHorizontalAlignment method. Add setFormatting method.
2060 2011-06-16 Ben Konrath <ben@bagu.org>
2062 Add scripts for building and installing war.
2064 These will help when updating OnlineGlom but they're also good
2065 supplemental documentation of the build and deployment proceeding.
2067 * utils/build-onlineglom-war.sh: New file.
2068 * utils/install-onlineglom-war.sh: New file.
2070 2011-06-16 Ben Konrath <ben@bagu.org>
2072 Create wrapper class to create consistent log messages.
2074 I wrapped methods in the Log class of gwt-log to add the method names
2075 from the servlet and create consistent formatting of the document title
2076 and table names in the log messages.
2078 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2079 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2080 log methods to use methods from wrapped Log class.
2082 2011-06-16 Ben Konrath <ben@bagu.org>
2084 Remove superfluous conditional return.
2086 Thanks to Murray Cumming for pointing this out!
2088 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2090 2011-06-15 Ben Konrath <ben@bagu.org>
2092 Return an ArrayList of LayoutGroups for the Details layout.
2094 This corrects a problem with the details layout as it can have more
2095 than one top level LayoutGroup.
2097 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2098 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2099 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2100 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2102 with ArrayList of LayoutGroups for the details view layout.
2103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2104 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2105 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2106 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2107 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2108 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2110 2011-06-14 Ben Konrath <ben@bagu.org>
2112 Use cast_dynamic method to determine the libglom LayoutItem type.
2114 This is better than finding the LayoutItem type by using the string
2115 returned from the get_part_type_name() method.
2117 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2119 2011-06-14 Ben Konrath <ben@bagu.org>
2121 Add method names to log entries in the servlet.
2123 This helps when tracking down deployment problems.
2125 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2127 2011-06-14 Ben Konrath <ben@bagu.org>
2129 Add data to the DetailsView using a hard-coded primary key value.
2131 The layout and functionality of the DetailsView is not complete. This
2132 is just a checkpoint so the patch doesn't get too big.
2134 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2135 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2136 Add getDetailsData() servlet method.
2137 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2138 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2139 LayoutFields are added to the DetailsView.
2140 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2141 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2142 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2143 take the string for the title instead of the object.
2144 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2145 Add implementation getDetailsData() along with some private helper
2147 * src/main/webapp/style.css: Add padding to details-data class. Add a
2148 details-label class with the same padding as the details-data class.
2150 2011-06-03 Ben Konrath <ben@bagu.org>
2152 Use presenter.goTo() to change to the DetailsPlace.
2154 This will make things easier when we need to open the DetailsView with
2155 data specific to the row that was clicked.
2157 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2159 2011-06-02 Ben Konrath <ben@bagu.org>
2161 Add CSS file from mockups.
2163 I'm adding this now because it's going to be useful to have when
2164 developing the DetailsView. The TableSelectionView and ListView aren't
2167 * src/main/webapp/OnlineGlom.html:
2168 * src/main/webapp/style.css:
2170 2011-06-02 Ben Konrath <ben@bagu.org>
2172 Use String.isEmpty() to check for empty string.
2174 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2176 2011-06-02 Ben Konrath <ben@bagu.org>
2178 Display main layout group titles in the DetailsView.
2180 This is the start of the DetailsActivity/DetailsView implementation.
2182 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2183 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2184 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2186 Get the layout information for the details view from the server and set
2187 the main layout group titles.
2188 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2189 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2190 Add addLayoutGroup() and addLayoutField() methods. This are just
2191 temporary methods for creating the the details view that will change
2193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2194 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2196 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2197 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2198 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2199 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2200 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2201 Data Transfer Objects that mimic the libglom object structure. These are
2202 used for transferring the details layout but could also be used for
2203 transferring the list layout.
2205 2011-05-27 Ben Konrath <ben@bagu.org>
2207 Reset the AuthenticationPopup when clearing the ListView.
2209 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2211 2011-05-27 Ben Konrath <ben@bagu.org>
2213 Fix problem with onlineglom.properties file loading.
2215 The old way worked in Eclipse but not on the server. Loading the
2216 onlineglom.properties file now works in Eclipse and on the server.
2218 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2220 2011-05-24 Ben Konrath <ben@bagu.org>
2222 Update gwt-log from 3.1.0 to 3.1.2.
2224 Gwt-log 3.1.0 has been marked as depreciated.
2228 2011-05-24 Ben Konrath <ben@bagu.org>
2230 Add comment to ListActivity.goTo() method.
2232 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2234 2011-05-24 Ben Konrath <ben@bagu.org>
2236 Remove FIXME in convertGdkColorToHtmlColour()
2238 The Gdk::Color value returned by libglom is 16-bits per channel on both
2239 64 and 32-bit platforms.
2241 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2243 2011-05-19 Ben Konrath <ben@bagu.org>
2245 Improve performance of initial ListView load.
2247 I removed a round trip to the server for getting the default table name
2248 and then requesting information about that table. This also removes a potential
2249 problem with the table change handler not being setup in time to receive the
2250 table change event from the ListActivity.
2252 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2253 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2254 getDefaultLayoutListTable() method. Improve comments.
2255 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2256 getDefaultLayoutListTable() method instead of firing a table change
2257 event to get the table to load.
2258 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2259 implementation of getDefaultLayoutListTable() method.
2260 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2263 2011-05-19 Ben Konrath <ben@bagu.org>
2265 Override toDebugString() in TableChangeEvent.
2267 This is useful to have for debugging.
2269 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2271 2011-05-19 Ben Konrath <ben@bagu.org>
2273 Add a "Back to List" link when at the DetailsPlace.
2275 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2276 Populate the CellTable based on the selected table of the ListBox if
2277 it's set otherwise use the default table. This allows the "Back to
2279 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2280 Remove Place from constructors. Add a setPlace() method. Add
2281 goToPlace() method. Set class as presenter for TableSelectionView.
2282 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2283 Use the same TableSelectionActivity when switching between the List and
2285 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2286 Subclass the new HasSelectableTablePlace. This removes some duplicate
2288 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2289 New class to represent Places that display the TableSelectionView.
2290 * src/main/java/org/glom/web/client/place/ListPlace.java:
2291 Subclass the new HasSelectableTablePlace. This removes some duplicate
2293 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2294 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2295 Add Presenter interface. Add setBackLinkVisible() method. Add
2296 setBackLink() method.
2298 2011-05-18 Ben Konrath <ben@bagu.org>
2300 Enable the "Details" buttons.
2302 Right now only an empty details view is displayed.
2304 * src/main/java/org/glom/web/client/ClientFactory.java:
2305 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2306 Add DetailsView to ClientFactory.
2307 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2308 A basic activity for the details view.
2309 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2310 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2312 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2313 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2315 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2316 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2317 unnecessary super() in constructor.
2318 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2319 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2320 really shouldn't create a new TableSelectionActivity for both the ListPlace
2321 and the DetailsPlace so this should be considered a temporary solution.
2322 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2323 New file. Represents a URL for the details view.
2324 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2325 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2326 A basic details view interface and implementation.
2327 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2328 Enable the "Details" buttons.
2330 2011-05-12 Ben Konrath <ben@bagu.org>
2332 Use a LayoutPanel with multiple display areas for main layout.
2334 This is mostly a refactor in that there are no changes from the user
2335 point of view. These changes are required so that we can swap out the list view
2336 with the details view when the user clicks the "Details" button.
2338 * src/main/java/org/glom/web/client/ClientFactory.java:
2339 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2340 OnlineGlomView. Add TableSelectionView, ListView and
2341 AuthenticationPopup.
2342 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2343 for main layout. Add display regions for main activities. Add
2344 activity manager for for main activities.
2345 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2346 file from parts of the deleted OnlineGlomActivity.
2347 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2348 New file from parts of the deleted OnlineGlomActivity.
2349 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2350 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2351 New files for app wide table change event.
2352 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2353 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2354 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2355 Activity mappers for the main activities replace the deleted app-wide
2357 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2358 Fix a spelling error in he comment.
2359 * src/main/java/org/glom/web/client/ui/ListView.java:
2360 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2361 Renamed from LayoutListView and modified for MVP. This still not a
2362 proper dumb view as prescribed by the MVP pattern but it works for now.
2363 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2364 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2365 New widget stripped out of the deleted OnlineGlomView.
2366 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2367 Remove hack that is fixed by this patch.
2369 2011-05-06 Ben Konrath <ben@bagu.org>
2371 Rename OnlineGlomPlace to ListPlace.
2373 The only change besides the rename is that url will now display #list
2374 instead of #Document.
2376 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2377 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2378 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2379 * src/main/java/org/glom/web/client/place/ListPlace.java:
2380 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2382 2011-05-06 Ben Konrath <ben@bagu.org>
2384 Use Presenter for app navigation.
2386 This is the proper way to deal with Place (URL) changes with the MVP
2389 * src/main/java/org/glom/web/client/ClientFactory.java:
2390 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2391 PlaceHistoryMapper and PlaceHistoryHandler.
2392 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2393 PlaceHistoryMapper and PlaceHistoryHandler.
2394 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2395 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2396 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2397 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2398 Add Presenter interface and setPresenter methods. Rename addHyperLink
2399 to addDocumentLink taking only the document title as a parameter.
2401 2011-04-14 Ben Konrath <ben@bagu.org>
2403 Prompt for db username/password if they haven't been set.
2405 This is implemented with a popup widget that is contained within the
2406 OnlineGlomView and managed by the OnlineGlomActivity.
2408 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2409 methods for checking and setting the database username and password.
2410 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2411 new methods for checking and setting the database username and
2413 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2414 Display authentication popup if the JDBC connection to the database
2415 has not been authenticated.
2416 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2418 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2419 for dealing with the authentication popup.
2420 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2421 Implement the methods for dealing with the authentication popup.
2422 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2423 try to executed queries if the database connection hasn't been
2424 authenticated. Implement methods for checking and setting the
2425 database username and password.
2427 2011-04-12 Ben Konrath <ben@bagu.org>
2429 Make log messages a little clearer.
2431 Add a dash betweeen the document title and the table name.
2433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2435 2011-04-12 Ben Konrath <ben@bagu.org>
2437 Protect against NPEs when cleaning up database resources.
2439 While this isn't strictly necessary because the exception is caught,
2440 not protecting against the NPEs makes it harder to find the real error
2443 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2445 2011-04-12 Ben Konrath <ben@bagu.org>
2447 Move configuration of the servlet to the constructor.
2449 The servlet will be initialized even if the database authentication
2450 information is not set or correct. I still need to add the UI for prompting
2451 the user for the authentication information when it's required.
2453 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2454 javadocs for getDocumentTitles() method.
2455 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2456 Set error message when RPC fails.
2457 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2458 glom files directory from the configuration file. Try to set the
2459 database authentication information for the specific document if it's
2460 set and works otherwise try to use the global authentication
2461 information set for the directory.
2462 * src/main/resources/onlineglom.properties: Moved from
2463 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2464 Added detailed comments for the new keys.
2466 2011-04-11 Ben Konrath <ben@bagu.org>
2468 Remove unnecessary @Override in DocumentSelectionViewImpl.
2470 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2472 2011-04-11 Ben Konrath <ben@bagu.org>
2474 Remove center alignment in DocumentSelectionView.
2476 The title element is still centred but the document titles and bottom
2477 sentence are both left-aligned.
2479 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2481 2011-04-11 Ben Konrath <ben@bagu.org>
2483 Change 'Demo' naming convention to 'Document'.
2485 This is just a rename refactor with no functional changes to the code.
2487 * src/main/java/org/glom/web/client/ClientFactory.java:
2488 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2489 * src/main/java/org/glom/web/client/OnlineGlom.java:
2490 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2491 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2492 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2493 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2494 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2495 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2496 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2497 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2498 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2501 2011-04-08 Ben Konrath <ben@bagu.org>
2503 Remove FIXME from safeLongToInt() method.
2505 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2508 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2510 2011-04-08 Ben Konrath <ben@bagu.org>
2512 Display an error if no glom documents are found in the specified directory.
2514 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2515 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2516 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2519 2011-04-08 Ben Konrath <ben@bagu.org>
2521 Add copyright header to one more file ... oops.
2523 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2525 2011-04-08 Ben Konrath <ben@bagu.org>
2527 Add copyright header to files without it.
2529 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2530 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2531 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2532 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2533 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2534 * src/main/java/org/glom/web/shared/GlomField.java:
2536 2011-04-08 Ben Konrath <ben@bagu.org>
2538 Add support for accessing multiple glom documents in the servlet.
2540 This completes the demo selection functionality.
2542 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2543 document title to methods.
2544 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2545 document title to methods.
2546 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2547 Set browser window title when the activity starts. Correct name of
2548 document title variable.
2549 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2550 Set browser window title when the activity starts. Set the table
2551 selector change handler after table selector has been set. Clear the
2552 OnlineGlomView when the activity has been stopped.
2553 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2554 document title as the place token. Use "#Document:" instead of
2555 "#OnlineGlomPlace:" in the URL.
2556 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2557 Change heading to "Online Glom"
2558 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2559 document title in RPC methods.
2560 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2561 setDocumentTitle() method. Add clear() method.
2562 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2563 setDocumentTitle() method. Implement clear() method which removes the
2564 change handler on the ListBox, clears the ListBox and clears the
2566 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2567 Implement methods with document title. Keep track for the configured
2568 glom documents and their corresponding JDBC configurations in a hash
2569 table. This information is retrieved using the document title as the
2570 key in the hash table.
2571 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2572 document title field as it's no longer needed.
2574 2011-04-08 Ben Konrath <ben@bagu.org>
2576 Update the Eclipse JDT configuration.
2578 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2579 methods. Automatically add the copyright header to new files.
2581 2011-04-05 Ben Konrath <ben@bagu.org>
2583 Add new page for demo selection.
2585 This patch adds all the components required to view and start an
2586 OnlineGlom demo by clicking on the desired hyperlink. The user is
2587 able to return to the demo selection page with the browser's back
2588 button. I still need to modify the servlet to work with multiple
2589 documents so all demo links will load the file defined in the
2590 OnlineGlom.properties.
2592 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2593 This is only useful during development so we don't need to save it.
2594 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2595 get a reference to the DemoSelectionView.
2596 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2597 method to get a reference to the DemoSelectionView.
2598 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2599 default view to DemoSelectionView.
2600 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2601 to get glom document titles for glom files in a hard-coded directory.
2602 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2603 method to get glom document titles for glom files in a hard-coded
2605 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2606 Presenter for DemoSelectionView.
2607 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2608 for DemoSelectionView.
2609 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2610 Update for DemoSelectionView.
2611 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2612 Basic 'Place' implementation for the DemoSelectionView.
2613 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2614 The interface for the DemoSelectionView.
2615 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2616 The implementation of the DemoSelectionView.
2617 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2618 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2619 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2620 implementation of method to get glom document titles for glom files
2621 in a hard-coded directory.
2622 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2623 on longer being used.
2624 * src/main/webapp/glom.png: Glom logo.
2626 2011-04-05 Ben Konrath <ben@bagu.org>
2628 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2630 This is the forth and final commit of a refactor that will allow
2631 OnlineGlom to be used with multiple documents.
2633 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2634 Move RPC code from OnlineGlomViewImpl to this class.
2635 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2637 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2638 RPC code to the presenter class (the P in MVP).
2640 2011-04-04 Ben Konrath <ben@bagu.org>
2642 Start moving the existing OnlineGlom code to MVP.
2644 This work is based on the GWT MVP framework that is documented here:
2646 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2648 This is the third commit of a refactor that will allow OnlineGlom to
2649 be used with multiple documents.
2651 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2652 Interface for client factory which is used to get instances of various
2653 classes throughout the app.
2654 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2655 Implementation of client factory.
2656 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2657 initialize the MVP framework.
2658 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2659 New file. Activity manager for the main container widget. This is the
2661 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2662 Maps place (URL) to its corresponding activity.
2663 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2664 New file. This is just a place holder for a generated file.
2665 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2666 New file. Represents the URL for the main Online Glom app.
2667 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2668 for changes in LayoutListViewImpl.
2669 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2670 interface for View. Move code to OnlineGlomViewImpl class.
2671 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2672 file. Implementation of OnlineGlomView.
2673 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2674 Place resources. Use ClientFactoryImpl by default.
2676 2011-04-04 Ben Konrath <ben@bagu.org>
2678 Move View classes to their own package.
2680 This is the second commit of a refactor that will allow OnlineGlom to
2681 be used with multiple documents.
2683 * src/main/java/org/glom/web/client/OnlineGlom.java:
2684 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2685 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2687 2011-04-02 Ben Konrath <ben@bagu.org>
2689 Move UI code from the main module to its own class.
2691 This is the first commit of a refactor that will allow OnlineGlom to be
2692 used with multiple documents.
2694 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2695 references to OnlineGlom to OnlineGlomView.
2696 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2697 OnlineGlomView and instantiate it here.
2698 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2699 represents the main OnlineGlomView with one document.
2701 2011-04-01 Ben Konrath <ben@bagu.org>
2703 Fix formatting of gwt.xml and add DTD.
2705 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2707 2011-03-30 Ben Konrath <ben@bagu.org>
2709 Propperly convert gdkColor string to html colour string.
2711 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2713 2011-03-28 Ben Konrath <ben@bagu.org>
2715 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2717 This implementation matches
2718 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2719 readable and is not tied to Swig.
2721 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2723 2011-03-28 Ben Konrath <ben@bagu.org>
2725 Use read-only checkboxes for boolean field types.
2727 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2728 in the CellTable based on the field type. It currently only
2729 distinguishes between boolean and text columns but I'll need to add
2730 support for more types.
2731 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2732 column type in the ColumnInfo object. Add method to convert between the
2733 glom field type enum in ColumnInfo and the glom field type in libglom.
2734 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2736 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2737 getting and setting booleans.
2739 2011-03-25 Ben Konrath <ben@bagu.org>
2741 Don't get the Date twice from the ResultSet.
2743 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2745 2011-03-25 Ben Konrath <ben@bagu.org>
2747 Cleanup code in the servlet.
2749 * TODO: Remove item about row count. Add item about testing row count
2750 query with large number of rows.
2751 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2752 spelling mistakes, change method parameter to be consistent with
2755 2011-03-25 Ben Konrath <ben@bagu.org>
2757 Add server side logging with the gwt-log library.
2759 * .gitignore: Ignore the log file we're now producing.
2760 * TODO: Add a couple TODO item for logging.
2761 * pom.xml: Add gwt-log and log4j as a dependency.
2762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2763 logging of errors, warnings and some important info.
2764 * src/main/resources/log4j.properties: New file to configure log4j.
2766 2011-03-24 Ben Konrath <ben@bagu.org>
2768 Add a disable button for the Details view.
2770 * src/main/java/org/glom/web/client/LayoutListView.java:
2772 2011-03-22 Ben Konrath <ben@bagu.org>
2774 Use a count query to get the number of rows for the list view pager.
2776 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2778 2011-03-22 Ben Konrath <ben@bagu.org>
2780 Add more TODO information about CellTable pager positioning.
2784 2011-03-19 Ben Konrath <ben@bagu.org>
2786 Add TODO item about CellTable pager positioning.
2790 2011-03-18 Ben Konrath <ben@bagu.org>
2792 Remove unneeded GlomFieldColumn class.
2794 This is just a small code cleanup.
2796 * src/main/java/org/glom/web/client/LayoutListView.java:
2798 2011-03-18 Ben Konrath <ben@bagu.org>
2800 Use cursor mode in the query that gets data for the list view.
2802 I still need to fix the potential memory problem when getting the row
2803 count for the list view.
2805 * TODO: Add note about testing memory usage with large data sets. Add
2806 item about fixing row counting with large data sets.
2807 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2808 PostgreSQL JDBC driver into cursor mode when getting data for the
2811 2011-03-15 Ben Konrath <ben@bagu.org>
2813 Remove the GWT Container from the Eclipse build classpath.
2815 The GWT dependencies are set by Maven so this isn't needed.
2819 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2821 Added some earlier mockups to git, but not to the tarball dist.
2823 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2824 Openismus. These hopefully show how we might structure the HTML so that
2825 it can be styled easily with CSS. However, we probably need to adapt them
2826 for the CSS structure that GWT dictates for common widgets.
2828 2011-03-14 Ben Konrath <ben@bagu.org>
2830 Locate OnlineGlom.properties using the ServletContext.
2832 This is required to be able to locate the file in the deployed servlet.
2834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2835 Configure the database and glom document in in a helper method so
2836 that the ServletContext can be used to locate OnlineGlom.properties.
2837 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2838 src/main/webapp. This is the proper location for .properites files.
2840 2011-03-12 Ben Konrath <ben@bagu.org>
2842 Add note to README about why we're compiling down to obfuscated JavaScript.
2846 2011-03-11 Ben Konrath <ben@bagu.org>
2848 Use properties file to configure servlet.
2850 This allows people to change the glom file path, db username and db
2851 password without recompiling the code.
2853 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2854 * src/main/webapp/OnlineGlom.properties:
2856 2011-03-11 Ben Konrath <ben@bagu.org>
2858 Use table fields in layout list view if the layout list is not defined.
2860 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2861 Manually create a LayoutFieldVector for the query builder using the
2862 table fields when a layout list is not defined in the glom file.
2864 2011-03-11 Ben Konrath <ben@bagu.org>
2866 Only show FIXME string for images when there's an image.
2868 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
2869 in this change are some small code cleanups.
2871 2011-03-11 Ben Konrath <ben@bagu.org>
2873 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
2875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2877 2011-03-11 Ben Konrath <ben@bagu.org>
2879 Correctly set the index of the default table.
2881 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2882 Correctly set the index of the default table. Add commented out example
2885 2011-03-10 Ben Konrath <ben@bagu.org>
2887 Add comment to pom.xml about the previous change.
2889 * pom.xml: Add comment about the deployment issue so that it's obvious
2890 why java-libglom is set to the provided scope.
2892 2011-03-10 Ben Konrath <ben@bagu.org>
2894 Change java-libglom dependency from compile to provided in pom.xml.
2896 Since java-libglom uses jni it can only be loaded once and therefore
2897 must be placed in $CATALINA_HOME/lib and not included in each war.
2898 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
2899 More information about this issue can be found in the Tomcat 6 release
2900 notes in the "JNI Based Applications" section:
2902 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
2904 * README: Remove note about this issue. Deployment info should really
2905 be on the wiki anyway so I'll add it right now.
2906 * pom.xml: Change java-libglom dependency from compile to provided so
2907 that it's copied in to the packaged war.
2909 2011-03-09 Ben Konrath <ben@bagu.org>
2911 Change to using a neutral locale for currency, date and time formatting.
2913 This solves the problem of currency values being represented without a
2914 space between the currency code and the number (e.g. "EUR5.89" is now
2915 represented as "EUR 5.89"). More work is required when we implement
2916 a locale preference setting.
2918 * TODO: Add note about currency formatting issues with different
2920 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2921 to using the neutral ROOT locale.
2923 2011-03-09 Ben Konrath <ben@bagu.org>
2925 Add support for currency codes that are not ISO 4217 codes.
2927 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2928 the currency code defined in the glom file when it's not 3 characters
2929 long or when Java doesn't recognize the string as an ISO 4217 code.
2931 2011-03-08 Ben Konrath <ben@bagu.org>
2933 Remove test classes, launch configurations and configuration.
2935 The test stuff was getting in the way when creating the war. To make
2936 the war file you can now do 'mvn clean package'. The packaged war file
2937 will be in the target directory.
2939 * .classpath: Remove unused classpathentry for tests and i18n.
2940 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
2941 property. Don't run test or i18n goals when packaging the war.
2942 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
2947 * OnlineGlomTest-dev.launch:
2948 * OnlineGlomTest-prod.launch:
2949 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2950 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
2952 2011-03-07 Ben Konrath <ben@bagu.org>
2954 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
2956 These fixes allow me to use 'mvn deploy' to create the war file.
2958 * .classpath: This generated config has been updated by Eclipse. This
2959 change was probably triggered by me updating from Eclipse 3.6.1 to
2961 * .gitignore: Add entry to ignore the directory
2962 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
2963 * .project: The generated config has been updated by Eclipse. This
2964 change was probably triggered by me updating from Eclipse 3.6.1 to
2966 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
2967 so that Eclipse doesn't complain
2968 * pom.xml: Update to gwt-maven-plugin 2.2.0.
2969 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
2970 'tests' directory to 'client' directory. This is the new
2971 gwt-maven-plugin convension.
2972 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
2973 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
2975 2011-03-07 Ben Konrath <ben@bagu.org>
2977 Add support for horizontal alignment in the LayoutList columns.
2979 * TODO: Remove item about horizontal alignment. Add item about
2980 improvements to ColumnInfo.
2981 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
2982 alignment on the columns. Use ColumnInfo RPC object get the column
2983 title and horizontal alignment.
2984 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
2985 LayoutListView creation with ColumnInfo RPC object.
2986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2987 a ColumnInfo object for every LayoutList columnn. Convert the
2988 FieldFormatting.HorizontalAlignment to the correct
2989 ColumnnInfo.HorizontatlAlignment with the new
2990 getColumnInfoHorizontalAlignment helper method.
2991 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
2992 to encapsulate column information like alignment and title. This
2993 could be used to set the colour instead of on a per cell field basis.
2994 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
2995 column title storage and retrieval with ColumnInfo.
2997 2011-03-04 Ben Konrath <ben@bagu.org>
2999 Add support for column sorting.
3001 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3002 AsynDataProvider to be an anonymous inner class. Use new
3003 getSortedTableData RPC method when column sort is requested. Set all
3004 columns sortable and add an AsyncHandler to activate sorting in the
3006 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3007 method getSortedTableData(). Cleanup other method signatures.
3008 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3009 new method getSortedTableData(). Cleanup other method signatures.
3010 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3011 Implement getSortedTableData() and getTableData() methods by using a
3012 private helper method with the appropriate parameters filled in. Use
3013 user supplied sort clause when supplied, otherwise fall back to
3014 sorting by the primary key. Move destroy() method to be underneath
3015 constructor for readability. Cleanup comments.
3017 2011-03-03 Ben Konrath <ben@bagu.org>
3019 Add support for colour text and colour backgrounds to the layout list cells.
3021 Only the cell backgrounds are coloured which leaves a gap between the
3022 cells that isn't coloured. I need to figure out a way to set
3023 'style=background-colour:' on the whole column rather than just the
3026 * TODO: Add a note about colouring the background of the whole column.
3027 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3028 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3029 render the coloured text and backgrounds. Use GlomField[] for the row type.
3030 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3032 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3033 GlomField[] for the row type.
3034 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3035 GlomField[] for the row type. Set the text, text colour and background
3036 colour in the GlomField objects as specified in the glom document. Add
3037 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3038 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3039 the glom field text, foreground colour and background colour.
3041 2011-03-02 Ben Konrath <ben@bagu.org>
3043 Don't display hidden tables in the combo box.
3045 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3047 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3048 code to ignore hidden tables using ArrayLists for the table names and
3050 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3051 tableNames to use ArrayLists instead of String[]. Update getter and setter
3054 2011-03-01 Ben Konrath <ben@bagu.org>
3056 Add support for Date and Time number types.
3058 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3059 Implement formatting for Date and Time values. Change the default glom
3060 file to small business example.
3062 2011-03-01 Ben Konrath <ben@bagu.org>
3064 Add support for formatting glom types as specified in the glom file.
3066 Formatting isn't finished yet - I still need to add support for Date
3069 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3070 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3071 checks for null values in JDBC cleanup code and catch all exceptions
3072 instead of just SQLExceptions.
3073 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3076 2011-03-01 Ben Konrath <ben@bagu.org>
3078 Use GWT 2.2.0 instead of 2.1.1.
3080 * pom.xml: Change GWT version numbers.
3082 2011-03-01 Ben Konrath <ben@bagu.org>
3084 A few small code cleanups.
3086 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3088 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3089 unnecessary object creation in constructor.
3090 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3091 unnecessary object creation in constructor.
3093 2011-02-28 Ben Konrath <ben@bagu.org>
3095 Add file for TODO list.
3099 2011-02-18 Ben Konrath <ben@bagu.org>
3101 Enable the CellTable Pager when more than 20 rows need to be viewed.
3103 The Pager will automatically become active when the results are larger
3104 than the CellTable size which is currently set to 20 lines.
3106 * src/main/java/org/glom/web/client/LayoutListView.java: Correct class
3107 name on debug statment in RPC call in LayoutListDataProvider, add
3108 numRows parameter to LayoutListView constructor, propperly set rowCount
3110 * src/main/java/org/glom/web/client/OnlineGlom.java: Correct class
3111 name on debug statment in RPC call, use LayoutListTable object in RPC
3112 calls, pass rowCount to LayoutListView.
3113 * src/main/java/org/glom/web/client/OnlineGlomService.java: Change
3114 getLayoutListHeaders to getLayoutListTable and return LayoutListTable
3116 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Update
3117 interface for changes in OnlineGlomService.
3118 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3119 getLayoutListHeaders() to getLayoutListTable() and return
3120 LayoutListTable. Using this object allows me to pass other information
3121 about the LayoutList like the expected number of rows in the result set.
3122 The Connection object from the connection pool is now propperly closed.
3123 Only the requested number of lines are returned to the client in
3125 * src/main/java/org/glom/web/shared/LayoutListTable.java: Move from
3126 GlomTable and add columnTitles and numRows.
3128 2011-02-18 Ben Konrath <ben@bagu.org>
3130 Use String arrays instead of GlomTable objects in GlomDocument GWT-RPC object.
3132 This is a small performance boost. I'll use GlomTable to get the required
3133 layoutlist information.
3135 * src/main/java/org/glom/web/client/OnlineGlom.java:
3136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3137 * src/main/java/org/glom/web/shared/GlomDocument.java:
3139 2011-02-18 Ben Konrath <ben@bagu.org>
3141 Add option to turn off formatting in JDT formatter preferences.
3143 * .settings/org.eclipse.jdt.core.prefs:
3145 2011-02-18 Ben Konrath <ben@bagu.org>
3147 Rename LayoutList to LayoutListView.
3149 I'm working towards setting things up to easily use MVP when the time
3152 * src/main/java/org/glom/web/client/LayoutListView.java: Rename from
3154 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3157 2011-02-17 Ben Konrath <ben@bagu.org>
3159 Move LayoutListDataProvider class into LayoutList.java.
3161 * src/main/java/org/glom/web/client/LayoutList.java:
3163 2011-02-17 Ben Konrath <ben@bagu.org>
3165 Rename RPC service classes from LibGlomService* to OnlineGlomService*.
3167 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Update
3169 * src/main/java/org/glom/web/client/OnlineGlom.java: Update references.
3170 * src/main/java/org/glom/web/client/OnlineGlomService.java: Rename
3171 from LibGlomServer.java.
3172 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3173 Rename from LibGlomServiceAsync.java.
3174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3175 Rename from LibGlomServiceImpl.java.
3176 * src/main/webapp/WEB-INF/web.xml: Update configuration.
3178 2011-02-17 Ben Konrath <ben@bagu.org>
3180 Update JDT settings.
3182 * .settings/org.eclipse.jdt.core.prefs:
3184 2011-02-17 Ben Konrath <ben@bagu.org>
3186 Move GWT-RPC objects to shared package (where they should be).
3188 * src/main/java/org/glom/web/client/LibGlomService.java: Update imports.
3189 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Update imports.
3190 * src/main/java/org/glom/web/client/OnlineGlom.java: Update imports.
3191 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Update imports.
3192 * src/main/java/org/glom/web/shared/GlomDocument.java: Move to
3193 org.glom.web.shared package.
3194 * src/main/java/org/glom/web/shared/GlomTable.java: Move to
3195 org.glom.web.shared package.
3196 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Included shared
3197 directory in compilation to javascript.
3199 2011-02-16 Ben Konrath <ben@bagu.org>
3201 Add sort clause to the sql query that grabs table information.
3203 * src/main/java/org/glom/web/server/LibGlomServiceImpl.java: Add sort clause
3204 if one of the columns is a primary key.
3206 2011-02-16 Ben Konrath <ben@bagu.org>
3208 Disable generateAsync feature of gwt-maven.
3210 The generated interface does not correctly match the methods in LibGlomService
3211 and the generated singleton Util inner-class doesn't respect the servlet
3214 * pom.xml: Turn off generateAsync feature.
3215 * src/main/java/org/glom/web/client/LibGlomServiceAsync.java: Re-add file
3216 with singleton Util inner-class.
3218 2011-02-14 Ben Konrath <ben@bagu.org>
3220 Add LGPL v3 licence notices.
3222 Followed directions listed here:
3223 http://www.gnu.org/licenses/gpl-howto.html
3225 * COPYING: This file is a copy of the GPL v3.
3226 * COPYING.LESSER: This file is a copy of the LGPL v3.
3227 * src/main/java/org/glom/web/client/GlomDocument.java: Add licence
3229 * src/main/java/org/glom/web/client/GlomTable.java: Add licence
3231 * src/main/java/org/glom/web/client/LayoutList.java: Add licence
3233 * src/main/java/org/glom/web/client/LayoutListDataProvider.java: Add
3235 * src/main/java/org/glom/web/client/LibGlomService.java: Add licence
3237 * src/main/java/org/glom/web/client/OnlineGlom.java: Add licence