1 2012-03-05 Murray Cumming <murrayc@murrayc.com>
3 Reports drop-down list: Some improvement.
5 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
6 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
7 Adedd setSelectedReport(),
8 setReportList(): Add a blank line so that the user can select the
10 * src/main/java/org/glom/web/client/activity/ReportActivity.java
11 start(): Show the current report by calling setSelectedReport().
12 This does not seem to work yet.
14 2012-03-05 Murray Cumming <murrayc@murrayc.com>
16 DetailsActivity, ListActivity: Move some variables into a base class.
18 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
19 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
20 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
21 the clientFactory, documentID, tableName and authenticationPopup into
22 a base class, to avoid duplication.
24 2012-03-05 Murray Cumming <murrayc@murrayc.com>
26 Translate the Reports label.
28 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
29 Get the "Reports" label string from the constants.
30 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
31 perties: Add Reports to the constants.
33 2012-03-03 Ben Konrath <ben@bagu.org>
35 Display date and time in details view.
37 https://bugzilla.gnome.org/show_bug.cgi?id=671257
39 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
41 2012-03-05 Murray Cumming <murrayc@murrayc.com>
43 Require the latest java-libglom.
45 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
47 2012-03-05 Murray Cumming <murrayc@murrayc.com>
49 Reports: Implement grouping.
51 * src/main/java/org/glom/web/server/ReportGenerator.java:
52 Handle LayoutItem_GroupBy items and try to do the right thing
53 with JRDesignGroup. It seems to work.
55 2012-03-04 Murray Cumming <murrayc@murrayc.com>
57 Actually show some data with JasperReports.
59 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
60 getReportHTML(): Move most code into a ReportGenerator class.
61 * src/main/java/org/glom/web/server/ReportGenerator.java:
62 Recurse into sub-groups, adding fields to the JasperDesign's details
63 band. Note that we must set an arbitrary width and height, or it just
64 will not show any data.
66 2012-03-04 Murray Cumming <murrayc@murrayc.com>
68 Reports Chooser: Show the titles, not the names.
70 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
71 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
72 and the names as the values.
73 * src/main/java/org/glom/web/server/ConfiguredDocument.java
74 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
75 group now that we provide the report name, so it should always
78 2012-03-04 Murray Cumming <murrayc@murrayc.com>
80 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
82 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
83 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
84 an empty quickfind string. I also corrected libglom to create only
85 empty where clauses for empty quickfind strings, but this avoids the
88 2012-02-24 Ben Konrath <ben@bagu.org>
90 Improve the tabs in the Notebook widget.
94 2012-02-15 Murray Cumming <murrayc@murrayc.com>
96 Depend on jasperreports.
98 * pom.xml: Add the dependency. My plan is to use this on the
101 2012-01-31 Murray Cumming <murrayc@murrayc.com>
103 Implement navigation to report places.
105 * src/main/java/org/glom/web/client/activity/ReportActivity.java
106 start(): Do not bother to handle all events here.
107 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
108 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
109 Added getSelectedReport().
110 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
111 .java: start(): When handling a change to the reports chooser,
112 call getSelectedReport() and goTo() its ReportPlace.
113 * src/main/java/org/glom/web/client/ui/ReportView.java
114 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
115 Added setReportHTML() which puts the html in a gwt HTML widget.
116 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
117 getReportHTML(): Return "TODO" just to show that this works.
119 2012-01-31 Murray Cumming <murrayc@murrayc.com>
121 Make ReportPlace usable.
123 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
125 * src/main/java/org/glom/web/client/place/ReportPlace.java:
126 Correct the @prefix annotation.
128 2012-01-31 Murray Cumming <murrayc@murrayc.com>
130 OnlineGlomService: Return report HTML rather than the LayoutGroup.
132 * src/main/java/org/glom/web/client/OnlineGlomService.java:
133 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
135 Change getReportLayout() to getReportHMTL() because we will not need to
136 parse or render the report layout on the client side.
137 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
138 getReportLayout(): Return the libglom LayoutGroup type because we will
139 not need to convert to a shared type, because this will not be used on
141 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
144 Note that there is still no implementation for this.
146 2012-01-30 Murray Cumming <murrayc@murrayc.com>
148 Translations: Try to translate the strings.
150 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
151 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
152 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
153 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
154 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
155 Take the Open translation from GTK+'s .po files.
156 Take the Details translation from Glom's po files.
157 I have added the other strings to Glom so we can get translations that way:
158 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
160 2012-01-27 Murray Cumming <murrayc@murrayc.com>
162 Add a (empty) Report Place, View, and Activity.
164 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
166 * src/main/java/org/glom/web/client/place/HasTablePlace.java
167 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
168 this into a superclass:
169 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
170 and also use it as the base of this new ReportPlace:
171 * src/main/java/org/glom/web/client/place/ReportPlace.java
173 * src/main/java/org/glom/web/client/ui/ReportView.java
174 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
175 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
176 Add these, containing mostly boiler-plate for now.
178 * src/main/java/org/glom/web/client/OnlineGlomService.java
179 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
180 * src/main/java/org/glom/web/server/ConfiguredDocument.java
181 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
182 Add API to get the LayoutGroup for the report.
184 2012-01-27 Murray Cumming <murrayc@murrayc.com>
186 TableSelectionViewImpl: Put the search label and entry in a div.
188 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
189 Put the search widgets in a FlowTable so that the CSS can be used to
190 style them while keeping them together.
191 * src/main/webapp/style.css: Mention the new div.
193 2012-01-27 Murray Cumming <murrayc@murrayc.com>
195 Translate more strings in more locales.
197 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
198 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
199 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
200 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
201 Translate the "Details" and "Open" string too.
203 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
204 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
205 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
206 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
207 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
208 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
209 Add these new locales as placeholders though they currently contain English.
211 2012-01-27 Murray Cumming <murrayc@murrayc.com>
213 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
216 Check the ConfiguredDocument* for null before using it.
218 2012-01-26 Murray Cumming <murrayc@murrayc.com>
220 Tell Eclipse about the generated java files.
222 * .classpath: This lets it find OnlineGlomConstants.java.
223 It would be nice if Eclipse just used the maven build files.
225 2012-01-26 Murray Cumming <murrayc@murrayc.com>
227 Prevent a crash when no locale is specified in the URL.
229 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
230 Avoid returning a null string, obtained from
231 Window.Location.getParameter(). This caused a crash when it was
232 later passed to libglom's API.
233 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
234 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
235 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
236 guard against future null strings.
238 2012-01-26 Murray Cumming <murrayc@murrayc.com>
240 Use the ?locale= query param instead of the &lang= token param.
242 * src/main/java/org/glom/web/client/place/ListPlace.java
243 * src/main/java/org/glom/web/client/place/DetailsPlace.java
244 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
245 Remove the lang token key and value.
247 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
248 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
249 When the user selects a different locale from the chooser, use
250 Window.Location.assign() to change the URL, which then causes a reload.
252 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
253 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
254 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
255 * src/main/java/org/glom/web/client/activity/ListActivity.java
256 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
257 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
258 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
259 * src/main/java/org/glom/web/client/ui/ListView.java:
260 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
262 Remove localeID member variables and method/constructor parameters, instead
263 using Utils.getCurrentLocaleID() when we need a localID to pass to
266 2012-01-26 Murray Cumming <murrayc@murrayc.com>
268 Internationalize the UI strings.
270 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
271 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
272 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
273 because it is unused. Messages are apparently strings that can have
274 parameters, but we do not need that yet, so Contants will be enough for now.
275 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
276 to say that we support the en and de locales.
277 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
278 The original English strings.
279 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
280 Some German translations of the English strings.
281 The i18n goal then uses the .properties file to generate an
282 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
283 returns an implementation that returns the translated strings.
284 The documentation suggests putting these in src/java/*/client/, but it seems
285 best to put it in src/resources/*/client/.
286 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
287 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
288 instead of hard-coding them.
289 Note that we cannot import OnlineGlomConstants because it does not exist yet,
290 but that does not seem to stop the build, though it confuses Eclipse.
292 You can see the translated string by adding ?locale=de to the URL, like so:
293 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
295 2012-01-24 Murray Cumming <murrayc@murrayc.com>
297 Improve null/empty String checks.
299 * pom.xml: Add a dependency on commons-lang, to use
300 org.apache.commons.lang.StringUtils.
301 * src/main/java/org/glom/web/server/ConfiguredDocument.java
302 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
303 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
304 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
305 Use StringUtils.isEmpty().
307 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
308 StringUtils class with a static isEmpty() function because we
309 cannot use org.apache.commons.lang.StringUtils in client-side
310 GWT code because it (apparently) cannot be compiled to javascript.
311 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
312 * src/main/java/org/glom/web/client/activity/ListActivity.java
313 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
314 * src/main/java/org/glom/web/client/place/DetailsPlace.java
315 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
316 * src/main/java/org/glom/web/client/place/ListPlace.java
317 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
318 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
319 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
320 * src/main/java/org/glom/web/client/ui/details/Group.java
321 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
322 our StringUtils.isEmpty() function.
324 2012-01-24 Murray Cumming <murrayc@murrayc.com>
326 Update to the latest java-libglom API.
328 * pom.xml: Require java-libglom 1.21.4.
329 * src/main/java/org/glom/web/server/ConfiguredDocument.java
330 getDocumentInfo(), getListViewLayoutGroup():
331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
333 * src/main/java/org/glom/web/server/database/DBAccess.java
334 getFieldsToShowForSQLQueryAddGroup(),
335 getPrimaryKeyLayoutItemField(): Replace get_database_title()
336 with either get_database_title_original() or
337 get_database_title(localeID).
339 2012-01-24 Murray Cumming <murrayc@murrayc.com>
341 ConfiguredDocument: Avoid a null pointer exception.
343 * src/main/java/org/glom/web/server/ConfiguredDocument.java
344 Initialize localeID to "" to avoid returning a null String which
345 causes a crash in java-libglom's swing-generated code.
347 2012-01-23 Murray Cumming <murrayc@murrayc.com>
349 Some simple renaming.
351 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
352 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
353 for localeChooser. This seems more appropriate and is less ambiguous
354 particularly in the .css file.
356 2012-01-23 Murray Cumming <murrayc@murrayc.com>
358 ConfiguredDocument: Rename the localedID private member variable.
360 2012-01-23 Murray Cumming <murrayc@murrayc.com>
362 Adapt to the latest java-libglom API from git master.
364 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
365 libglom now uses only Vector instead of List, which uses add() instead of
368 2012-01-23 Murray Cumming <murrayc@murrayc.com>
370 Add and fill a Reports drop-down list box.
372 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
374 * src/main/java/org/glom/web/client/OnlineGlomService.java:
375 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
376 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
377 Added getReports(document, table, localeID), calling
378 ConfiguredDocument.getReports().
379 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
380 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
381 Added setReportsList() and a list widget.
382 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
383 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
385 2012-01-22 Murray Cumming <murrayc@murrayc.com>
387 ConfiguredDocument: Rename the localedID private member variable.
389 2012-01-20 Murray Cumming <murrayc@murrayc.com>
391 Build a source tarball with mvn assembly:single
393 * assembly.xml: Add this file.
394 * pom.xml: Use the maven-assembly-plugin and tell it to use
395 our assembly.xml file.
397 2012-01-19 Murray Cumming <murrayc@murrayc.com>
399 OnlineGlomServiceImpl: Get .glom files recursively.
401 * pom.xml: Depend on commons-io from org.apache.commons.
402 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
403 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
404 files recursively, and with the easier filter for the extension.
405 Use org.apache.commons.io.FilenameUtils.removeExtension() to
406 simplify that code too.
408 2012-01-19 Murray Cumming <murrayc@murrayc.com>
410 README: Mention that you must install java-libglom packages separately.
412 But then it works, because java-libglom is now in the central maven
415 2012-01-18 Murray Cumming <murrayc@murrayc.com>
417 locales drop-down: Show the correct selected locale when the URL changes.
419 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
420 .java: setPlace(): Move some code into fillView().
422 2012-01-18 Murray Cumming <murrayc@murrayc.com>
424 locales drop-down: Do not lose the primary key.
426 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
427 start(): onLocaleChange(): Pass the current primary key value,
428 instead of an empty value.
430 2012-01-18 Murray Cumming <murrayc@murrayc.com>
432 locales drop-down: Do not lose the drop-down selection.
434 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
435 .java (TableSelectionActivity.fillView): Set the selected locale
436 after changing the drop-down items (though we do not really need
437 to change them just because the locale changes.)
439 2012-01-18 Murray Cumming <murrayc@murrayc.com>
441 locales drop-down: Change the tables list when this changes.
443 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
444 .java: TableSelectionActivity.start(): Move the async table titles
445 retrieval into a private fillView() method and also call this when
446 the chosen locale changes.
447 Note that the document title is not actually translatable yet, but
448 that is a problem that I should fix soon in libglom.
450 2012-01-18 Murray Cumming <murrayc@murrayc.com>
452 Improve the placement of the locales drop-down.
454 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
455 Put the title and locales drop-down in a div (gwt.FlowTable).
456 * src/main/webapp/style.css: Add magic css properties to make this work.
457 Also remove the left margin from the title so that it lines up with the
460 2012-01-18 Murray Cumming <murrayc@murrayc.com>
462 locales selector: Show human-readable locale titles.
464 * src/main/java/org/glom/web/server/ConfiguredDocument.java
465 getDocumentInfo(): Use java.util.Locale to show a real title of
466 each locale, in the locale's own language.
468 2012-01-17 Murray Cumming <murrayc@murrayc.com>
470 Add a language/locale selector drop-down.
472 * src/main/java/org/glom/web/shared/DocumentInfo.java:
473 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
474 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
475 getDocumentInfo(): Store the available Locales in the DocumentInfo.
476 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
477 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
478 Add a ListBox to show the available locales. Add getLocaleSelector(),
479 setLocaleList(), getSelectedLocale(), setSelectedLocale().
480 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
481 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
482 java: Add these classes.
483 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
484 start(): Fill the locales ListBox. Handle its change event, firing a
486 setPlace(): Show the selected locale as specified by the URL token.
487 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
488 * src/main/java/org/glom/web/client/activity/ListActivity.java:
489 Handle LocaleChangeEvent, going to a new *Place with that locale.
491 The placement of the ListBox is not pretty, and it currently uses the ID
492 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
496 2012-01-17 Murray Cumming <murrayc@murrayc.com>
498 Search box: Show the search text from the URL token.
500 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
501 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
502 Add setQuickFindText().
503 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
504 .java: setPlace(): Store the queryText if the place is a ListPlace,
505 and call TableSelectionView.setQuickFindText().
507 2012-01-17 Murray Cumming <murrayc@murrayc.com>
509 Allow use of translations via, for instance, &lang=de in the URL.
511 * pom.xml: Use the unstable java-libglom 1.21 version.
513 * src/main/java/org/glom/web/client/OnlineGlomService.java:
514 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
515 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
516 init(): Instead of calling TranslatableItem.set_current_locale()
517 (now removed), call ConfiguredDocument.setDefaultLocaleID().
518 However, this is only for default locales, which are not needed to
519 change the locale in the URL.
520 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
521 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
522 getSortedRelatedListData(): Add a localeID parameter, so we can get the
523 layout for a particular locale.
524 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
525 Add get/setDefaultLocaleID().
526 getDocumentInfo(), getListViewData(), getRelatedListData(),
527 getDetailsLayoutGroup(), getListViewLayoutGroup(),
528 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
529 localeID parameter, so we can get the layout for a particular locale.
531 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
532 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
533 * src/main/java/org/glom/web/client/place/ListPlace.java:
534 Parse and construct a lang parameter too.
536 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
537 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
538 passed to subsequent methods and constructors.
539 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
540 * src/main/java/org/glom/web/client/activity/ListActivity.java:
541 Store the localeID from the *Place and pass it to other constructors
542 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
544 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
545 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
546 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
547 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
548 * src/main/java/org/glom/web/client/ui/ListView.java:
549 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
550 Take localeID parameters and pass them to subsequent constructors and
551 methods, so that the layout is always retrieved for that locale.
553 This is rather repetitive.
555 Note that "" means the original (default) locale of the Glom document,
556 which is usually English.
558 2012-01-17 Murray Cumming <murrayc@murrayc.com>
560 Documents: Remove final keyword to fix startup configuration.
562 * src/main/java/org/glom/web/shared/Documents.java: Remove the
563 final keywords on the private member variables because that breaks
564 the startup, apparently (there are warnings) because it stops them
565 from being serialized. I added these in the previous commit.
567 2012-01-13 Murray Cumming <murrayc@murrayc.com>
569 Documents: Add some final keywords.
571 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
574 2012-01-13 Murray Cumming <murrayc@murrayc.com>
576 OnlineGlomServiceImpl: Add to overview comments.
578 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
579 Note that this is where all the document are loaded. They are not
580 loaded freshly for each page.
582 2012-01-12 Murray Cumming <murrayc@murrayc.com>
586 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
587 Add a TextBox for the text of a quick find.
588 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
590 setBackLink(): Add a String quickFind parameter.
591 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
592 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
593 to the base interface, because that is how TableSelectionViewImpl is used.
594 * src/main/webapp/style.css: Add style for the search box and its label.
596 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
597 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
598 Add these files, based on the existing TableChangeEvent and
599 TableChangeEventHandlers.
600 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
601 start(): Handle QuickFindChangeEvent, passing its quickFind text to
602 a ListPlace() that the user should be taken to.
603 * src/main/java/org/glom/web/client/activity/ListActivity.java
604 start(): Handle it here too and adapt the TableChangeEvent handler to
605 pass the extra "" quickFind parameter to ListPlace.
606 * src/main/java/org/glom/web/client/place/ListPlace.java:
607 Constructor: Take an extra String quickFind parameter and store it,
608 returning it from a new getQuickFind() method.
609 getToken(): Put the quickFind text in the URL token.
610 getPlace(): Parse the quickFind text from the URL token.
611 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
612 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
613 ListPlace constructor.
614 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
615 .java: start(): Add a Change handler for the TableSelectionView's
616 TextBox (via its base HasChangeHandlers interface), firing the new
617 QuickFindChangeEvent.
618 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
619 pass the extra "" quickFind parameter.
621 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
622 setCellTable(): Add a String quickFind parameter and pass it to
623 the ListViewTable() constructor.
624 * src/main/java/org/glom/web/client/ui/ListView.java: Change
625 setCellTable() in the base interface, because that is how ListViewImpl
628 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
629 Add a String quickFind member variable.
630 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
631 Constructor: Add a String quickFind parameter, storing it in the
632 base ListTable's member variable.
633 onRangeChanged(): Pass quickFind to the
634 OnlineGlomServiceAsync.getSortedListViewData() and
635 OnlineGlomServiceAsync.getListViewData() methods.
637 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
638 getListViewData(), getSortedListViewData(): Add a String quickFind
639 parameter, passing it to ConfiguredDocument.getListViewData().
640 * src/main/java/org/glom/web/client/OnlineGlomService.java:
641 Change getListViewData(), getSortedListViewData() in the base interface,
642 because that is how OnlineGlomServiceImpl is used, via this:
643 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
644 Change getListViewData(), getSortedListViewData() here too.
645 This class can apparently be used to asynchronously call methods on
646 OnlineGlomService, and GWT seems to implement that after recognizing
647 just the *Async name convention and the extra AsyncCallback parameters.
649 * src/main/java/org/glom/web/server/ConfiguredDocument.java
650 getListViewData(): Add a String quickFind parameter, and pass it to
651 ListViewDBAccess.getData().
652 * src/main/java/org/glom/web/server/database/ListDBAccess.java
653 getListData(): Add a String quickFind parameter and pass it to
655 getSelectQuery(): Add a String quickFind parameter.
656 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
657 getSelectQuery(): Add a String quickFind parameter and use it with
658 Glom.get_find_where_clause_quick() to pass a where_clause to
659 Glom.build_sql_select_with_where_clause(), to actually filter the
661 getData(): Add a String quickFind parameter, passing it to getListData().
662 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
663 va: getData(): Pass an empty string to getListData() for the
666 2012-01-12 Murray Cumming <murrayc@murrayc.com>
668 ListTable: Minor change.
670 * src/main/java/org/glom/web/client/ui/list/ListTable.java
671 createCellTable(): Make this protected instead of public.
673 2012-01-12 Murray Cumming <murrayc@murrayc.com>
675 Many files: Use final for the parameters and use the @override attribute.
677 2012-01-22 Ben Konrath <ben@bagu.org>
679 Add anchor links for single line text that starts with http, ftp and www.
683 2012-01-22 Ben Konrath <ben@bagu.org>
685 Add ellipsis to single line text in details view.
689 2012-01-04 Murray Cumming <murrayc@murrayc.com>
691 Remove all javadoc author tags.
693 Because they are awkward and meaningless when many people touch
695 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
697 2012-01-04 Murray Cumming <murrayc@murrayc.com>
699 Revert the COPYING.LESSER to COPYING rename.
701 Apparently both should be there if it is LGPL.
703 2012-01-03 Murray Cumming <murrayc@murrayc.com>
705 *View: Remove unused imports.
707 * src/main/java/org/glom/web/client/ui/DetailsView.java:
708 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
709 * src/main/java/org/glom/web/client/ui/ListView.java:
710 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
711 Remove unused imports, as suggested by Eclipse.
713 2012-01-02 Murray Cumming <murrayc@murrayc.com>
715 Move the *View::Presenter types, and some API into one base View.
717 * src/main/java/org/glom/web/client/ui/DetailsView.java:
718 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
719 * src/main/java/org/glom/web/client/ui/ListView.java:
720 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
721 Presenter, setPresenter() and clear() into a shared base interface,
722 to avoid the unnecessary duplicate Presenter types and to more clearly
723 show how the *Views share the same structure, even if they are not
724 used polymorphically.
726 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
727 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
729 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
730 * src/main/java/org/glom/web/client/activity/ListActivity.java:
731 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
733 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
736 Feel free to revert this if there is a good reason for the duplicate
739 2012-01-02 Murray Cumming <murrayc@murrayc.com>
741 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
743 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
744 a class member instead of a local variable in the method.
745 This lets us use it to get the view instances, for use in tests.
746 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
747 beforeOnlineGlom(): Test some more details of the initial view.
748 Again, this is not very useful.
750 To really test gwt-glom we will need to start a local postgresql
751 instance with local data, like the Glom tests in C++.
753 2012-01-02 Murray Cumming <murrayc@murrayc.com>
755 pom.xml: Mention the LGPL license.
757 * pom.xml: Add a licenses section.
758 * COPYING.LESSER: Move this to COPYING, which
759 previously contained the GPL. But gwt-glom is all LGPL.
761 2012-01-02 Murray Cumming <murrayc@murrayc.com>
763 Add project information to README and pom.xml.
765 * README: Add a brief description and mention some mvn
767 * pom.xml: This extra information shows up in mvn site
770 2011-01-02 Murray Cumming <murrayc@murrayc.com>
772 Use the latest java-libglom version.
774 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
776 2012-01-01 Murray Cumming <murrayc@murrayc.com>
778 GwtTestOnlineGlom: Test a little more.
780 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
781 protected rather than private, as suggested by the gwt-test-utils
783 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
784 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
785 Test the initial visibility of the panels.
787 However, this is not a very useful test.
788 And I wonder how we should generally test using this idea for an
789 activity/places app like ours where the real changes happen implicitly
790 based on the history token/URL.
792 2012-01-01 Murray Cumming <murrayc@murrayc.com>
794 Slight modification to *Mapper comments.
796 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
798 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
800 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
802 Remove comments mentioning GIN because they are just copied from
803 the example code and are apparently not helpful:
804 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
805 Also change the mention of a class that is only in the example code.
807 2012-01-01 Murray Cumming <murrayc@murrayc.com>
809 GwtTestOnlineGlom test: Minor changes.
811 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
812 Avoid the long qualified class name and modify the comment
813 because it is now obvious to me that the mocked class is the only
814 custom one created via GWT.create().
816 2012-01-01 Murray Cumming <murrayc@murrayc.com>
818 Tests: Added the beginnings of a test using gwt-test-utils.
820 * pom.xml: Add dependencies on gwt-test-utils and easymock.
821 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
822 which tells gwt-test-utils what class will be tested.
823 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
824 Add a simple (but empty) test case. One class, used by the OnlineGlom
825 class, is mocked so that it can be created. However, I am not sure
826 why only this class needs to be mocked.
828 Note that mockito seems more popular, and clearer, than easymock,
829 but I have not got that working yet. It might be a matter of the
832 This test is run during mvn integration-test.
834 2011-12-31 Murray Cumming <murrayc@murrayc.com>
836 Tests: Use junit4-style syntax instead of junit3-style.
838 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
839 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
840 * src/test/java/org/glom/web/shared/DataItemTest.java:
841 Use the @Test annotation rather than relying on the test*() prefix.
842 Also no longer implement TestCase, to avoid triggering support for
843 the junit3-way, which stops the annotations from working.
844 Change the imports from import junit.framework.* to
845 import org.junit.*, which is apparently the new way.
847 2011-12-31 Murray Cumming <murrayc@murrayc.com>
849 Added a test for ListPlace token parsing and creation.
851 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
852 This is much the same as DetailsPlaceTest.
854 I wonder how we could test the other parts of the *Place API.
856 2011-12-30 Murray Cumming <murrayc@murrayc.com>
858 DetailsPlace test: Also test getToken() and recreation via getPlace().
860 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
861 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
862 recreate it, testing the recreated DetailsPlace for the same parameter
865 2011-12-30 Murray Cumming <murrayc@murrayc.com>
867 Use the surefire-report plugin.
869 * pom.xml: This generates a HTML report about the tests in
870 target/site/surefire-report.html
871 when you do mvn surefire-report:report. It seems to be popular/normal.
873 2011-12-30 Murray Cumming <murrayc@murrayc.com>
875 Added a test for DetailsPlace.
877 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
878 Test the getPlace() token parsing.
880 2011-12-30 Murray Cumming <murrayc@murrayc.com>
882 Added a first unit test.
884 * pom.xml: Add a test goal, and a dependency on junit in that scope.
885 * src/test/java/org/glom/web/shared/DataItemTest.java:
886 This is a silly test but it is just to get things started. Note that
887 maven/junit finds the test because it looks in src/test by default.
889 2011-12-22 Ben Konrath <ben@bagu.org>
891 Change charsetName to "UTF-8" when replacing line breaks.
893 JavaScript requires the charsetName to be "UTF-8". CharsetName values
894 that work in Java (such as "UTF8") will not work when compiled to
897 This fixes a problem with multi-line details view fields that have hard
898 line breaks. The "License Text" field on this page demonstrates the
901 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
903 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
905 2011-12-22 Ben Konrath <ben@bagu.org>
907 Fix another bug with related list navigation.
909 I've tested all the navigation buttons in all of the related lists
910 so things should be good now.
912 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
914 2011-12-22 Ben Konrath <ben@bagu.org>
916 Fix a crasher when refreshing the list view with the default table.
918 This crash will also happen when loading the list view with the default
919 table from a link or bookmark.
921 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
922 to the main document selection page when the document id hasn't been
924 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
925 the main document selection page when the document id hasn't been
927 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
928 values for the details place when the document id hasn't been set.
929 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
930 values for the list place when the document id hasn't been set.
932 2011-12-21 Ben Konrath <ben@bagu.org>
934 Protect against NPE when glom.document.locale is not in config.
936 This patch protects against an NPE when glom.document.locale is not in
937 the config file. This NPE will also happen if glom.document.locale is
940 The patch also updates the error message to display the class name when
941 the getMessage() returns null. This was happening when the NPE was
942 thrown and I had "Configuration Error: null". If an NPE is encountered
943 with this patch, "Configuration Error: NullPointerException " will be
946 This commit closes this bug:
948 https://bugzilla.gnome.org/show_bug.cgi?id=666669
950 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
952 2011-12-20 Murray Cumming <murrayc@murrayc.com>
954 Rename onlineglom.properties to onlineglom.properties.sample.
956 * src/main/resources/onlineglom.properties: Rename to:
957 * src/main/resources/onlineglom.properties.sample:
958 * src/main/resources/README: And add this file explaining that people
959 should rename it back when deploying.
961 2011-12-20 Murray Cumming <murrayc@murrayc.com>
963 Allow choosing the translation in the .properties file.
965 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
966 init(): Read a glom.document.locale value from the configuration file
967 and call Glom's TransatableItem::set_current_locale() method.
968 * src/main/resources/onlineglom.properties: Add a commented-out
969 example of this new setting.
971 It would be better to add &lang=de_DE to the URL, but the current
972 libglom API does not allow us to do this easily. I am working on that.
974 2011-12-19 Murray Cumming <murrayc@murrayc.com>
976 Avoid a crash in parsing of token parameters.
978 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
979 ava: getTokenParams(): Do not crash if a parameter has a key but no
980 value, and ignore parameters with neither.
982 2011-12-17 Murray Cumming <murrayc@murayc.com>
984 History token building/handling: Improve use of token parameters.
986 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
987 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
988 and buildParamsToken(HashMap), for use by derived classes.
989 Make the separator private because it is no longer be needed.
990 * src/main/java/org/glom/web/client/place/DetailsPlace.java
991 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
992 instead of manual string concatenation.
993 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
994 of hardcoded indices and awkward splitting code.
995 * src/main/java/org/glom/web/client/place/ListPlace.java
996 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
997 instead of manual string concatenation.
998 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
999 of hardcoded indices and awkward splitting code.
1000 This should fix bug #666420
1002 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1004 Fix a Navgiation->Navigation typo in the code.
1006 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1007 Rename processNavgiation() to processNavigation().
1009 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1011 Fix a seperator->separator typo in the code.
1013 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1014 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1015 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1018 2011-12-15 Ben Konrath <ben@bagu.org>
1020 Cleanup some comments.
1022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1024 2011-12-14 Ben Konrath <ben@bagu.org>
1026 Replace \n with <br/> for multiline text in the details view.
1028 Vertical scrollbars are added when needed as well.
1030 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1032 2011-12-14 Ben Konrath <ben@bagu.org>
1034 Specify the font for document selection links.
1036 * src/main/webapp/style.css:
1038 2011-12-14 Ben Konrath <ben@bagu.org>
1040 Fix bouncy CellTable while paging.
1042 This doesn't currently work with related list tables in unselected
1045 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1047 2011-12-14 Ben Konrath <ben@bagu.org>
1049 Revamp the appearance of the document selection page.
1051 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1052 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1053 * src/main/webapp/style.css:
1055 2011-12-13 Ben Konrath <ben@bagu.org>
1057 Set navigation button column to the smallest size possible.
1059 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1061 2011-12-13 Ben Konrath <ben@bagu.org>
1063 Change OpenButton nomenclature to NavigationButton.
1065 Using NavigtionButton makes things more generic. Classes, methods and
1066 variables have been changed.
1068 This is a rename-only refactor.
1070 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1071 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1072 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1073 Renamed from OpenButtonCell.
1074 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1075 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1076 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1078 2011-12-12 Ben Konrath <ben@bagu.org>
1080 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1082 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1083 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1084 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1085 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1087 2011-12-12 Ben Konrath <ben@bagu.org>
1089 Update variable names and comments.
1091 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1092 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1094 2011-12-12 Ben Konrath <ben@bagu.org>
1096 Properly initialize numNonEmptyRows variable to zero.
1098 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1099 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1101 2011-12-05 Ben Konrath <ben@bagu.org>
1103 Add latest mockup with HTML tables.
1105 Features of this mockup:
1107 -> HTML table for flowtable
1108 -> HTML table for flowtable column
1109 -> Example of how related lists would look
1110 -> Not using text entries for data items
1112 The current version of Online Glom doesn't use HTML tables for the
1115 This mockup has been sent to the glom-devel mailing list but it's good
1116 to have it here as well.
1118 * mockups/details-view-html-tables.html:
1120 2011-12-05 Ben Konrath <ben@bagu.org>
1122 Remove unnecessary getPrimaryKeyField() method.
1124 getPrimaryKeyFieldForTable(String) has been renamed to
1125 getPrimaryKeyField(String).
1127 * src/main/java/org/glom/web/server/database/DBAccess.java:
1128 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1129 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1131 2011-12-05 Ben Konrath <ben@bagu.org>
1133 Add string representation of TypedDataItem value to conversion error message.
1135 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1136 message was extracted into its own method to avoid duplication.
1138 2011-12-05 Ben Konrath <ben@bagu.org>
1140 Add type checking to navigation primary key value creation.
1142 Create navigation primary key only if the expected type from the Glom
1143 document matches the type returned by the SQL query.
1145 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1147 2011-12-05 Ben Konrath <ben@bagu.org>
1149 Rename a couple of variables in RelatedListNavigation.
1151 This is a rename-only refactor.
1153 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1155 2011-12-05 Ben Konrath <ben@bagu.org>
1157 Move getListLayoutGroup() into getListViewLayoutGroup().
1159 This removes getListLayoutGroup(). It was only being called by
1160 getListViewLayoutGroup().
1162 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1164 2011-12-05 Ben Konrath <ben@bagu.org>
1166 Remove check for LayoutItem_Portal in list table method.
1168 This check is no longer necessary because the method isn't being used
1169 to create the LayoutItemPortal DTO.
1171 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1173 2011-12-05 Ben Konrath <ben@bagu.org>
1175 Properly support related list navigation.
1177 Navigation from the "Repository Analyzer -> Package Scans ->
1178 Dependencies" related table wasn't working because the primary key for
1179 related tables wasn't being set properly. This commit fixes the
1182 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1183 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1184 doesn't set the primary key properly for related list tables.
1185 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1186 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1187 useful for getting the primary key for list view tables and for related
1189 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1190 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1191 Move code to set the primary key for the table from the abstract
1192 ListDBAccess class to ListViewDBAccess as it's only correct for list
1194 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1195 Properly add primary key to related list tables.
1197 2011-12-02 Ben Konrath <ben@bagu.org>
1199 Properly set the horizontal alignment of fields.
1201 This fix is for both the list tables and the details view.
1203 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1204 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1205 to set the horizontal alignment of fields.
1207 2011-12-02 Ben Konrath <ben@bagu.org>
1209 Display currency codes in the details view.
1211 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1213 2011-12-02 Ben Konrath <ben@bagu.org>
1215 Avoid duplicate JNI call.
1217 JNI is not as efficient as pure Java and this is an easy (and small)
1220 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1221 Use previously retrieved value for whereClauseToTableName instead of
1224 2011-12-02 Ben Konrath <ben@bagu.org>
1226 Rename a couple of variables in RelatedListNavigation.
1228 This is a rename-only refactor.
1230 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1232 2011-12-02 Ben Konrath <ben@bagu.org>
1234 Indicate clearly that a mismatched primary key type is a bug.
1236 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1237 warning to error. Add 'This is a bug.' to message.
1239 2011-12-02 Ben Konrath <ben@bagu.org>
1241 Update / fix some comments.
1243 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1245 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1247 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1248 Fix comments. Add some TODOs.
1250 2011-12-02 Ben Konrath <ben@bagu.org>
1252 Enable navigation to details view with string primary key from related list.
1254 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1255 Create a text primary key value when return type of result is
1256 java.sql.Types.VARCHAR.
1258 2011-12-02 Ben Konrath <ben@bagu.org>
1260 Use checkboxes for booleans in the details view.
1262 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1264 2011-12-01 Ben Konrath <ben@bagu.org>
1266 Improve performance of related list height calculation.
1268 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1269 Put code to calculate the expected height in a static initializer so
1270 that that it's only called once.
1272 2011-12-01 Ben Konrath <ben@bagu.org>
1274 Show related list tables in notebooks (again).
1276 Calculate the height of the related list tables so the Notebook can be
1277 set the correct height. The height of the related list table is also needed by
1278 FlowTable to be able decide how to create the layout.
1280 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1281 and set the Portal height based on the height of the related list
1282 table and the Portal container.
1283 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1284 Add method to calculate the height of the related list tables.
1285 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1286 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1287 calculate the height of the Pager widget.
1289 2011-12-01 Ben Konrath <ben@bagu.org>
1291 Use CellTable API for table property instead of setting style on Element.
1293 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1295 2011-12-01 Ben Konrath <ben@bagu.org>
1297 Make ListViewTable and RelatedListTable a consistent height.
1299 The tables are now a consistent height regardless of the contents of
1300 the table. A hidden button is added to empty rows to ensure that the
1301 height of these rows will match the height of rows with data.
1303 A navigation button column is now added to every table. The width of
1304 the navigation column is set to 0px when a RelatedListTable shouldn't
1305 have navigation buttons. This maintains the a consistent row height in
1306 tables that don't show the navigation buttons.
1308 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1309 navigation column when not needed.
1310 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1311 arguments for navigation button to constructor of ListViewTable.
1312 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1313 hidden button for empty data rows.
1314 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1315 arguments for navigation button to constructor.
1316 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1317 create navigation buttons. Add hideNavigationButtons() method.
1318 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1319 arguments for navigation button to constructor.
1321 2011-12-01 Ben Konrath <ben@bagu.org>
1323 Use 'visibility: hidden' in Utils.getWidgetHeight().
1325 This is better choice because hidden elements are invisible, don't
1326 respond to events and are not part of the tab order. They will,
1327 however, take up space which is required to be able to calculate the
1328 height of the widget.
1330 * src/main/java/org/glom/web/client/Utils.java:
1332 2011-12-01 Ben Konrath <ben@bagu.org>
1334 Use Utils.getWidgetHeight() in FlowTable.
1336 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1338 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1340 2011-12-01 Ben Konrath <ben@bagu.org>
1342 Put the details css class name on the correct table column.
1344 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1346 2011-11-30 Ben Konrath <ben@bagu.org>
1348 Update for java-libglom API change.
1350 The getters and setters on FieldFormatting and NumericFormat were
1351 changed to remove the 'M'.
1353 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1355 2011-11-29 Ben Konrath <ben@bagu.org>
1357 Only allow RelatedListTables in Portals.
1359 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1361 2011-11-29 Ben Konrath <ben@bagu.org>
1363 Only create a contents panel for Portals when title is being set.
1365 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1367 2011-11-29 Ben Konrath <ben@bagu.org>
1369 Set TabLayoutPanel height based on calculated height its widgets.
1371 This is a potential fix for this bug:
1373 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1375 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1377 2011-11-29 Ben Konrath <ben@bagu.org>
1379 Align details field labels and data with the Open buttons.
1381 * src/main/webapp/style.css:
1383 2011-11-29 Ben Konrath <ben@bagu.org>
1385 Remove unnecessary <div> in the Notebook widget.
1387 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1388 method to get container FlowPanel (<div>).
1389 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1390 initWidget() method directly on the TabLayoutPanel widget instead of
1391 Group's container widget.
1393 2011-11-29 Ben Konrath <ben@bagu.org>
1395 Don't add group titles for Portals in Notebooks.
1397 This reverts the previous patch and fixes a bug I introduced with
1398 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1400 * src/main/java/org/glom/web/client/ui/details/Group.java:
1401 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1403 2011-11-28 Ben Konrath <ben@bagu.org>
1405 Remove unused boolean argument in Portal constructor.
1407 Just a code cleanup.
1409 * src/main/java/org/glom/web/client/ui/details/Group.java:
1410 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1412 2011-11-28 Ben Konrath <ben@bagu.org>
1414 Remove hack for glom 1.18 style glom files.
1416 * src/main/java/org/glom/web/client/ui/details/Group.java:
1417 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1418 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1420 2011-11-28 Ben Konrath <ben@bagu.org>
1422 Use Gda Value version of primary key to log result too large error.
1424 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1426 2011-11-28 Ben Konrath <ben@bagu.org>
1428 Don't use TypedDataItem.getText() for Unknown types from the URL.
1430 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1431 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1432 instead of getText().
1433 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1434 String field and getUnknown() method.
1436 2011-11-28 Ben Konrath <ben@bagu.org>
1438 Log an error message when the java-libglom .so is not present.
1440 The error message was being set in the exception but not logged.
1442 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1444 2011-11-28 Ben Konrath <ben@bagu.org>
1446 Ignore LayoutItem_CalendarPortals.
1448 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1449 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1451 2011-11-28 Ben Konrath <ben@bagu.org>
1453 Extract method for creating the LayoutItemPortal DTO.
1455 Just breaking the code up into smaller chunks.
1457 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1459 2011-11-28 Ben Konrath <ben@bagu.org>
1463 This should have been added with the refactor. Oops!
1465 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1467 2011-11-28 Ben Konrath <ben@bagu.org>
1469 Create primary key value from URL string using type from Glom document.
1471 See this bug, comments 19 - 25:
1473 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1475 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1476 create a TypeDataItem for the primary key here when loading from a
1477 URL. Show the same string for the primary key value as was received
1478 from the URL string (when loading from a URL).
1479 * src/main/java/org/glom/web/server/Utils.java: Update method for
1480 creating the Gda Value from the TypeDataItem to properly deal with
1481 creating a Gda Value based on the Glom document type for the primary
1482 key value string when loading from a URL.
1483 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1484 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1485 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1486 Update for changed method name.
1488 2011-11-27 Ben Konrath <ben@bagu.org>
1490 Rename PrimaryKeyItem to TypedDataItem.
1492 The name PrimaryKeyItem suggests what the class should be used for.
1493 TypedDataItem is a neutral name that describes the class better.
1495 This is a rename-only refactor.
1497 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1498 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1499 * src/main/java/org/glom/web/client/Utils.java:
1500 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1501 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1502 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1503 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1504 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1505 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1507 * src/main/java/org/glom/web/server/Utils.java:
1508 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1509 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1510 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1511 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1513 2011-11-25 Ben Konrath <ben@bagu.org>
1515 Improve Gda Value conversion from PrimaryKeyItem.
1517 The value from the PrimaryKeyItem is only used if its type match the
1518 type from the glom document.
1520 * src/main/java/org/glom/web/server/Utils.java:
1522 2011-11-25 Ben Konrath <ben@bagu.org>
1524 Manually check if the java-liblgom .so is visible to the JVM.
1526 It seems that Tomcat has problems when a static initializer throws an
1527 exception. This check is done before the first method call into
1528 java-libglom so that execution doesn't continue if the .so is not
1531 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1533 2011-11-25 Ben Konrath <ben@bagu.org>
1535 Improve browser configuration error messages.
1539 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1541 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1542 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1543 getConfigurationErrorMessage() method.
1544 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1545 Get and display a specific configuration error message when no Glom
1546 documents are found.
1547 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1548 Implement getConfigurationErrorMessage() method. Surround configuration
1549 code in the init() method with a try/catch block. This allows the
1550 errors to be caught while keeping the servlet available to retrieve the
1551 configuration error message.
1553 2011-11-25 Ben Konrath <ben@bagu.org>
1555 Don't use Strings to hold primary key values.
1557 The primary key values are now held in a new data object
1558 (PrimaryKeyItem) that holds type information and the primary key value
1559 using the correct type.
1561 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1562 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1563 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1564 PrimaryKeyItem instead of String to hold the primary key value.
1565 * src/main/java/org/glom/web/client/Utils.java: Remove
1566 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1567 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1568 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1569 PrimaryKeyItem instead of String to hold the primary key value. Load
1570 document selection page when the documentID has not been set correctly.
1571 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1572 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1574 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1575 Return empty string for URL instead of "null".
1576 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1577 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1578 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1579 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1580 PrimaryKeyItem instead of String to hold primary key values.
1581 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1582 PrimaryKeyValue to a Gda Value.
1583 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1584 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1585 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1586 Replace temporary database access code that uses the PrimaryKeyValue to
1587 Gda Value conversion.
1588 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1589 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1590 PrimaryKeyItem instead of String.
1591 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1592 hold primary key values.
1594 2011-11-24 Ben Konrath <ben@bagu.org>
1596 Use newly added java-libglom API to create queries.
1598 This isn't finished. I still need to stop using Strings for primary key
1599 values in the client code.
1601 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1602 libglom to use fake connections so that retrieving the query string will
1604 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1605 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1606 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1607 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1608 Use the newly added libglom sql methods and classes to create the
1609 query. Add temporary hack to convert primary value strings to Gda
1612 2011-11-23 Ben Konrath <ben@bagu.org>
1614 Don't explicitly set the height of Portals.
1616 See comments 6 - 10 of this bug for details:
1618 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1620 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1622 2011-11-23 Ben Konrath <ben@bagu.org>
1624 Use an HTML table instead of CSS for the FlowTable layout.
1626 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1627 GWT's FlexTable to implement the FlowTable.
1628 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1630 2011-11-18 Ben Konrath <ben@bagu.org>
1632 Add boolean example to HTML table mockup.
1634 * mockups/details-view-html-tables-text-entries.html:
1636 2011-11-17 Ben Konrath <ben@bagu.org>
1638 Ensure the pager buttons are always visible for related lists.
1640 To accomplish this, I've turned off text wrapping in the list view and
1641 related list tables for both the header and data text. The related list
1642 table now has a fixed layout so the it doesn't overflow its container.
1643 This is required to ensure that the cell text is clipped when it
1644 overflows the cell and an ellipsis is added to the right side of the
1645 cell when text is clipped.
1647 A fixed table layout for the related list table in the details view
1648 seems what we want for the details view anyway, so the side-effect is
1651 The ellipsis will only be displayed in Firefox >= 7.
1655 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1657 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1658 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1659 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1661 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1662 Set the 'table-layout: fixed' CSS property to the related list table.
1663 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1664 'white-space: nowrap;' CSS property on both the list view and the
1665 related list tables.
1667 2011-11-16 Ben Konrath <ben@bagu.org>
1669 Rework the fix for empty notebook tab labels.
1671 Setting the empty group titles with its name caused problems for the
1672 details layout. Instead of using libglom's
1673 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1674 to the client when the title is empty. This allows the Notebook to use
1675 the name when the title is empty without affecting anything else.
1677 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1678 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1680 2011-11-16 Ben Konrath <ben@bagu.org>
1682 Set group titles with name when title is empty.
1684 This fixes a problem with an empty notebook tab label in the Lesson
1685 Planner document. The forth tab in the notebook should be "Internet":
1687 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1689 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1690 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1693 2011-11-16 Ben Konrath <ben@bagu.org>
1695 Remove whitespace from the configured username properties.
1697 This assumes that usernames won't have whitespace at the beginning
1698 or end. But I think this is a reasonable assumption.
1700 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1701 String.trim() to remove the whitespace from the username properties.
1703 2011-11-15 Ben Konrath <ben@bagu.org>
1705 Add details view mockup with HTML tables and text entries.
1707 This is from the attachment on this bug:
1709 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1711 * mockups/details-view-html-tables-text-entries.html:
1713 2011-11-15 Ben Konrath <ben@bagu.org>
1715 Add space between the columns of the flow table.
1719 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1721 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1722 space between columns in the flow table.
1724 2011-11-15 Ben Konrath <ben@bagu.org>
1726 Add backup files to the .gitignore.
1728 * .gitignore: Ignore files that end with ~.
1730 2011-11-09 Ben Konrath <ben@bagu.org>
1732 Use latest release of gwt-log.
1734 Gwt-log releases are now being submitted to the maven central
1735 repository so manual installation of the jar is no longer required.
1737 * pom.xml: Update version and groupId of gwt-log dependency.
1739 2011-10-31 Ben Konrath <ben@bagu.org>
1741 Don't use GWT numeric formatting to override the glom currency formatting.
1743 Currencies are now displayed like they are in Glom. See this bug:
1745 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1747 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1749 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1750 currency code to constructor and set it when the cell is rendered.
1751 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1752 currency code to the constructor of the NumericCell.
1754 2011-10-27 Ben Konrath <ben@bagu.org>
1756 Require the latest release of java-libglom (1.17.4).
1760 2011-10-26 Ben Konrath <ben@bagu.org>
1762 Add style to Notebook that matches current theme.
1764 It's not the best style in the world but it's better than the default.
1766 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1767 padding at the bottom of the child widgets.
1768 * src/main/webapp/style.css: Add style for the Notebook.
1770 2011-10-26 Ben Konrath <ben@bagu.org>
1772 Move servlet initialization code to overridden init method.
1774 This is half of the solution to getting proper error messages
1775 displayed when configuration errors occur. Here's the relevant bug:
1777 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1779 The rest of the solution involves surrounding the init method with a
1780 try/catch block and setting a global variable with the error /
1781 exception. A new async method should be created to retrieve and display
1782 the error message / exception.
1784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1785 code from constructor to init method adding exceptions as needed.
1787 2011-10-26 Ben Konrath <ben@bagu.org>
1789 Add script to monitor and restart tomcat if required.
1791 * utils/check-and-recover-tomcat.py: New file.
1793 2011-10-26 Ben Konrath <ben@bagu.org>
1795 Display the correct number of data items in the pager.
1799 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1801 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1802 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1803 The implementation is the same for both tables: Keep track of the
1804 number of non-empty rows and fire and RowCountChangeEvent after the data has
1806 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1807 custom Pager class that subclasses SimplePager to handle displaying
1808 the correct number when empty rows have been added.
1810 2011-10-26 Ben Konrath <ben@bagu.org>
1812 Correct error in previous commit.
1814 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1815 eventBus parameter from listView.setCellTable().
1817 2011-10-26 Ben Konrath <ben@bagu.org>
1819 Fix error in TODO comment.
1821 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1823 2011-10-24 Ben Konrath <ben@bagu.org>
1825 Create Notebook widgets to the details view.
1827 This isn't finished just yet - I still need to create a reasonable
1828 style to match the current theme.
1830 * src/main/java/org/glom/web/client/Utils.java: Add method for
1831 calculating the height of a widget. This is used in the Notebook class.
1832 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1833 new constructor method in Group.
1834 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1835 method for creating child widget that can be used by subclasses
1836 like Notebook. New constructor that allows disabling the group
1837 titles - Notebooks don't set a group title for their child groups.
1838 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1839 to make Notebooks using GWT's TabLayoutPanel.
1840 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1841 constructor that allows disabling the group titles.
1842 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1843 LayoutItemNotebook DTO.
1844 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1845 DTO for Notebooks. It's just an empty class for now but we might need
1846 it to transfer some specific information in the future.
1848 2011-10-21 Ben Konrath <ben@bagu.org>
1850 Add navigation buttons to related list tables.
1852 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1853 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1854 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1855 method getSuitableRecordToViewDetails() for getting the table name
1856 and primary key value for related list navigation buttons.
1857 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1858 private cell renderer class to get the navigation information for
1859 related list tables from the server. Extract the navigation
1860 processing code from the details cell navigation and use it for the
1861 related list navigation as well.
1862 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1863 cell renderer class for the details open buttons. This was needed
1864 because the related list navigation buttons and the list view
1865 navigation buttons need to react differently when clicked.
1866 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1867 the onEnterKeyDown() method because it's now overriden in the
1868 subclasses that are specific to the related list tables and the list
1870 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1871 the vertical size a little because the buttons add a bit of vertical
1872 space to table. This is not a perfect solution because the vertical
1873 size of with table fewer than 5 rows will be a little smaller.
1874 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1875 changes in how navigation buttons are handled.
1876 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1877 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1878 database access object.
1879 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1880 to find the portal for a given relationship name from
1881 RelatedListDBAccess. Add method to find a primary key field for a
1883 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1884 Move code to find the portal for a given relationship name to
1886 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1887 New file: database access object for getting the related list
1888 navigation information (the table name and the primary key value).
1889 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1890 DTO for transferring a table name to navigate to and a primary key
1892 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1893 boolean and getter/setter to specifies if the related list should add
1896 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1898 Use the master branch of java-libglom
1900 * pom.xml: Depend on java-libglom 1.19 instead.
1902 This is the master branch. See also the libglom-1-18 branch.
1904 2011-10-11 Ben Konrath <ben@bagu.org>
1906 Enable the open navigation button when the data has been set.
1908 This avoids having active buttons that don't do anything when the data
1911 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1913 2011-10-11 Ben Konrath <ben@bagu.org>
1915 Use IsWidget interface for FlowTableItem.
1917 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1918 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1920 2011-10-11 Ben Konrath <ben@bagu.org>
1922 Remove GWT styling from open button in details view.
1924 There are still some issues with how the details cell is arranged but
1925 this should be made to match Glom 1.20. I'm going to leave fixing this
1926 until I have Glom 1.20 up and running.
1928 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1929 style name on open button.
1930 * src/main/webapp/style.css: Move and edit details-navigation class.
1931 Re-arrange some classes to make them appear in the same order as the
1934 2011-10-07 Ben Konrath <ben@bagu.org>
1936 Update to GWT 2.4.0.
1938 * .gitignore: Ignore new cache directory.
1939 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1940 * pom.xml: Change GWT and maven plugin to 2.4.0.
1941 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1943 * src/main/java/org/glom/web/client/ClientFactory.java:
1944 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1945 * src/main/java/org/glom/web/client/OnlineGlom.java:
1946 Update source for API changes.
1947 * utils/build-onlineglom-war.sh: Remove cache directory before the
1950 2011-10-07 Ben Konrath <ben@bagu.org>
1952 Add navigation buttons in the details view.
1954 This isn't finished but I thought I'd commit what I have as it's a
1955 pretty good start. I still need to:
1957 1. Change the style so that it fits better into the current theme
1958 2. Adjust the details cell to expand as much as possible.
1960 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1961 click handlers to navigation buttons in the DetailsCells. Create a
1962 refreshData() method to get just the data from the server without the
1964 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1965 Update the tableSelector and browser title when the table name
1966 changes without using the tableSelector.
1967 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1968 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1969 getDetailsCells() to getCells(). Update variable names.
1970 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1971 method to set click handler on navigation button. Rename a few
1972 variables. Add navigation buttons where needed.
1973 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1974 variables and methods.
1975 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1976 navigation boolean and navigation table as required in the
1977 LayoutItemField DTO.
1978 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1979 variables for navigation along with getter/setter methods.
1981 2011-10-07 Ben Konrath <ben@bagu.org>
1983 Rename Field to DetailsCell.
1985 This is a refactor-only commit. No functionality has been added or
1988 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1989 Update variable and method names.
1990 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1991 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1992 variable and method names.
1993 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1995 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1996 variable and method names.
1998 2011-10-07 Ben Konrath <ben@bagu.org>
2000 Create separate methods for layout and data the details view.
2002 This is a refactor-only commit. No functionality has been added or
2005 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2006 private methods: setData(), createLayout().
2008 2011-10-07 Ben Konrath <ben@bagu.org>
2010 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2012 This is part of a change to get navigation buttons in the details view
2013 but it should have been done this way from the start.
2015 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2016 for method name change in TableSelectionView.
2017 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2018 Create TableChangeEvent and set the browser title using the
2019 TableSelectionView API.
2020 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2021 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2022 Change getSelectedTable() to getSelectedTableName(). Add
2023 getSelectedTableTitle().
2025 2011-10-07 Ben Konrath <ben@bagu.org>
2027 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2029 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2031 2011-10-07 Ben Konrath <ben@bagu.org>
2033 Update TableChangeEvent to use newTableName naming convention.
2035 This makes the class more consistent with GWT naming conventions.
2037 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2038 Update for method name change in TableChangeEvent.
2039 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2040 for method name change in TableChangeEvent.
2041 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2042 newTableName variable and getter method. Make toDebugString()
2045 2011-09-30 Ben Konrath <ben@bagu.org>
2047 Disable the pager in the list tables when the data row count is less than the minimum.
2049 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2050 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2052 2011-09-30 Ben Konrath <ben@bagu.org>
2054 Add empty rows to the end of related list and list view tables.
2056 I also extracted the cell rendering classes from the ListTable because
2057 the code was becoming a little crazy with all the anonymous inner
2058 classes. My plan is to use these cell rendering classes in the details
2059 view as well so this refactor will be needed for that change.
2061 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2062 set the row count in related list tables if the data has more rows
2063 than the minimum number of rows visible.
2064 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2065 row count in list view tables if the data has more rows than the
2066 minimum number of rows visible.
2067 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2068 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2070 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2071 for rendering TYPE_NUMERIC cells. The code was extracted from the
2073 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2074 class for rendering cells with buttons in list views. The code was
2075 extracted from the ListTable class.
2076 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2077 for rendering TYPE_TEXT cells. The code was extracted from the
2079 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2080 Add empty rows to the end of the data if required. Implement
2081 ListTable.getMinNumVisibleRows().
2082 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2083 cell renderer code to public classes. Return null in
2084 Column.getValue() for empty rows. Add new abstract method:
2085 getMinNumVisibleRows(). Move code to set the row count of the list view
2086 table to ListViewImpl.
2087 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2088 empty rows to the end of the data if required. Implement
2089 ListTable.getMinNumVisibleRows().
2092 2011-09-27 Ben Konrath <ben@bagu.org>
2094 Use GWT.log for client-side debugging statements.
2096 These are optimized out when deployed so I should have used this method
2097 in the first place. These statements will eventually be replaced with some sort
2098 of notification in the browser.
2100 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2101 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2102 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2103 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2104 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2106 2011-09-27 Ben Konrath <ben@bagu.org>
2108 Put tableselector on the right, back to list link on right.
2110 The idea is that the table selector is acting like a label for the
2111 currently displayed table so it should be placed below the document title. This
2112 puts the table title in a similar position to where it is in Glom.
2114 * mockups/details-contacts.html:
2115 * mockups/details-projects.html:
2116 * mockups/listview-contacts.html:
2117 * mockups/listview-projects.html:
2118 * mockups/style.css:
2119 Update mockups to match how the interfaces currently look.
2120 * src/main/webapp/style.css: Swap positions of backlink with the table
2121 selector. Add some space on the left side of the table selector to
2122 line things up with the document title.
2124 2011-09-27 Ben Konrath <ben@bagu.org>
2126 Add field colouring to details view.
2128 This change re-works how field colouring works. The colour formatting
2129 information is now set to the client with the layout information instead of
2130 with the data. This eliminates the need to send the same colour strings for
2131 data in list view column when colour information is set.
2133 In order to set an alternate colour for negative numeric values, the
2134 number is now sent to client and formatted with the GWT NumberFormat class.
2136 This change also fixes:
2138 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2140 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2141 internationalization framework which is needed for client side numeric
2143 * src/main/java/org/glom/web/client/Utils.java: New file for some
2144 client static utility methods.
2145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2146 the DataItem object to the Field class. Use a utility method to
2147 create the foreignKeyValue string.
2148 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2149 alignment and text colours in the constructor. Add setData(DataItem)
2150 method. Remove setText(String) method.
2151 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2152 colour information to GlomTextCell. Create and use GlomNumberCell for
2153 rendering numbers. Use utility method to get the string for the
2154 primary key of the key provider. Re-work how the horizontal alignment
2156 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2157 formatting to layout information. Methods for converting the libglom
2158 formatting information were moved from DBAccess.
2159 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2160 numeric formatting (it's now done on the client side). Don't set text
2161 colours in DataItem. Move libglom formatting conversion methods to
2163 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2164 getters/setters for text colour information.
2165 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2166 for transferring the libglom NumericFormat information to the client.
2167 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2168 and getters/setters for: GlomNumericFormat, background colour and
2169 foreground colour strings.
2171 2011-09-26 Ben Konrath <ben@bagu.org>
2173 Simplify code that iterates through the LayoutGroup.
2175 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2177 2011-09-26 Ben Konrath <ben@bagu.org>
2179 Accept Eclipse formatting for OnlineGlomServiceAsync.
2181 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2183 2011-09-26 Ben Konrath <ben@bagu.org>
2185 Don't use the ListDBAccess classes to get the primary key layout information.
2187 This was causing a bug where the wrong index for the hidden primary key
2188 was being sent to the client.
2190 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2191 primary key while creating the LayoutGroup DTO. Create a
2192 LayoutItemField DTO for hidden primary keys. Don't use the
2193 RelatedListDBAccess because it was only used for getting the primary
2195 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2196 access modifier from public to protected for getPrimaryKeyField() and
2197 getPrimaryKeyLayoutItemField().
2198 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2199 abstract method getExpectedResultSize() because RelatedListDBAccess
2200 doesn't have enough info to implement it.
2201 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2202 Remove @Override for getExpectedResultSize().
2203 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2204 Remove method getExpectedResultSize().
2206 2011-09-23 Ben Konrath <ben@bagu.org>
2208 Log which layout (list or details) the ignored item is from.
2210 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2212 2011-09-23 Ben Konrath <ben@bagu.org>
2214 Remove annotations that turn off code formatting in DataItem.
2216 * src/main/java/org/glom/web/shared/DataItem.java:
2218 2011-09-23 Ben Konrath <ben@bagu.org>
2220 Rename GlomField to DataItem and update associated methods.
2222 This is a rename-only refactor. No functionality has been added or
2225 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2226 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2227 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2228 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2229 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2230 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2231 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2232 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2233 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2234 * src/main/java/org/glom/web/server/database/DBAccess.java:
2235 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2236 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2237 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2238 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2239 * src/main/java/org/glom/web/shared/DataItem.java:
2240 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2241 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2243 2011-09-23 Ben Konrath <ben@bagu.org>
2245 Rename GlomDocument to DocumentInfo and update associated methods.
2247 This is a rename-only refactor. No functionality has been added or
2250 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2251 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2252 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2253 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2254 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2255 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2256 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2258 2011-09-20 Ben Konrath <ben@bagu.org>
2260 Require java-libglom 1.17.3.
2262 This picks up the fix for the seg fault problem with the Scenes table
2263 in the Openismus Film Manager example.
2267 2011-09-20 Ben Konrath <ben@bagu.org>
2269 Change the way sort clause is added for primary key when no sort clause is requested.
2271 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2272 before the sort clause is created. When a sort clause is not requested, the
2273 sort clause is created by finding the primary key in the LayoutFieldVector
2276 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2278 2011-09-20 Ben Konrath <ben@bagu.org>
2280 Log error message if no documents are found in the configured directory.
2282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2283 Extract the glom file extension string to a private static final class
2284 variable (mostly as syntactic sugar). Accept a minor formatting change.
2285 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2286 the example glom.document.directory configuration property to make it
2287 more clear that it can any directory, not just the home directory.
2289 2011-09-18 Ben Konrath <ben@bagu.org>
2291 Add related lists to details view.
2293 The related list table has support for paging and sorting just like the
2294 table in the list view.
2296 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2297 SQL queries for the related list tables.
2298 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2299 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2300 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2301 Rename getList methods to getListView and add comments. Remove
2302 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2303 it being unused. Add methods: getDetailsLayoutAndData(),
2304 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2305 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2306 Create the layout and set the data for the fields in one async call
2307 instead of two. Create related lists where appropriate.
2308 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2309 for method name changes in OnlineGlomService.
2310 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2311 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2312 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2314 * src/main/java/org/glom/web/client/ui/ListView.java:
2315 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2316 tableName from setCellTable(). Create a ListViewTable instead of
2318 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2319 represent a data field in the details view.
2320 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2321 from addDetailsCell() to Field class. Keep track of the Fields and
2322 Portals in the details view.
2323 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2324 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2325 and add a method to get it. Add method to set the contents of the
2327 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2328 New class for related list tables. This class has the data provider
2329 for the related list table.
2330 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2331 abstract class which is the base class for the ListViewTable and the
2333 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2334 New class for list view tables. This class has the data provider for
2335 the list view table.
2336 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2337 methods for related list tables. Add more information to the
2338 LayoutItemField and LayoutItemPortal DTOs.
2339 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2340 Remove debugging print statement.
2341 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2342 Remove debugging print statements. Add primary key field to SQL count
2344 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2345 Remove unnecessary LayoutFieldVector parameter from
2346 getResultSizeOfSQLQuery() method.
2347 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2348 New class for related list table database access.
2349 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2350 class that is a wrapper DTO for details view layout and data.
2351 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2352 new 'fromField' string to this DTO.
2353 * src/main/webapp/style.css: Remove bottom margin and override top
2356 2011-09-15 Ben Konrath <ben@bagu.org>
2358 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2360 This sets things up to make it easier to add the data retrieval for
2361 related lists (portals). No user noticeable changes were made with
2364 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2365 class has the code to retrieve the layouts and access the
2366 database using the new database helper classes.
2367 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2368 Most of the functionality has been removed from this class. This
2369 class now represents the public interface for the client side
2370 code. It also deals with configuring the servlet and cleaning
2371 things up when the servlet is stopped.
2372 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2373 of static methods into this utility class.
2374 * src/main/java/org/glom/web/server/database/DBAccess.java:
2375 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2376 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2377 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2378 These classes have the database retrieval code. The class hierarchy
2379 has been setup to make it easy to reuse code for similar
2382 2011-09-06 Ben Konrath <ben@bagu.org>
2384 Create separate classes for list table code and the data provider.
2386 As part of this refactor, I also split up the code a bit to make it
2389 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2390 table code to two new classes (below).
2391 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2392 with code from ListViewImpl.
2393 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2394 New file with code from ListViewImpl.
2396 2011-09-06 Ben Konrath <ben@bagu.org>
2398 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2400 This fixes the LayoutItemPortal DTO to match the libglom layout object
2403 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2405 2011-09-01 Ben Konrath <ben@bagu.org>
2407 Set title of Portals in the Details View.
2409 * pom.xml: Bump required version of java-libglom to 1.17.1.
2410 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2411 widget creation to its own class. Add comments to constructor.
2412 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2413 The code is mostly from the Group class with the title now set.
2414 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2415 title of Portal. Update some comments. Fix some code formatting.
2417 2011-09-01 Ben Konrath <ben@bagu.org>
2419 Remove TODO comment for the flow table column width.
2421 The flow table column width is working correctly and doesn't need to be
2422 changed. See this mailing list post for more info:
2424 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2426 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2428 2011-08-27 Ben Konrath <ben@bagu.org>
2430 Add document title (database name) to top of the browser page.
2432 I added the document title to the TableSelecitonView but that will
2433 change if / when we add a view that doesn't require table selection.
2435 * mockups/details-contacts.html:
2436 * mockups/details-projects.html:
2437 * mockups/listview-contacts.html:
2438 * mockups/listview-projects.html:
2439 * mockups/style.css: Add document title to mockups to keep things
2441 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2442 sizes to account for the document title.
2443 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2444 Set the document title when it has been retrieved from the server.
2445 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2446 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2447 and implement setDocumentTitle(String) method.
2448 * src/main/webapp/style.css: Add ID for document title style.
2450 2011-08-25 Ben Konrath <ben@bagu.org>
2452 Add NavigationType enum to LayoutItemPortal DTO.
2454 This is the start of adding support for Portals to the Details View.
2456 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2457 LayoutItem_Portal.navigation_type enum from libglom to
2458 LayoutItemPortal.NavigationType enum.
2459 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2460 NavigationType enum, field for storing the NavigationType and getter
2463 2011-08-25 Ben Konrath <ben@bagu.org>
2465 Implement the flow table layout in the Details View.
2467 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2468 FlowTable to Group to account for the renamed class.
2469 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2470 File. This is a container widget that implements the Glom details view
2471 flow table behaviour.
2472 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2473 org/glom/web/client/ui/FlowTable.java.
2474 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2475 so that the size of the subgroups are a closer match to the size of
2476 the Glom subgroups. This makes the flowtable layout match the layout
2477 in Glom for the Music Collection example file.
2479 2011-08-16 Ben Konrath <ben@bagu.org>
2481 Create container element for LayoutItemPortal in Details View.
2483 This will help me develop the layout for the FlowTable.
2485 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2486 fieldPanel variable to detailsCell.
2488 2011-08-15 Ben Konrath <ben@bagu.org>
2490 Set the height of the data element in the Details View.
2492 I changed the InlineLabels (text in a span element) to Labels (text in
2493 a div element) so that I could set the height of the details-data
2494 elements instead of the details-cell parent elements. This allows the
2495 the details-data element to display the correct height if style is
2496 applied that shows the height.
2498 This change has the added benefit of allowing the order of the labels
2499 and data elements to be changed for right-to-left languages.
2501 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2502 InlineLabels to Labels.
2503 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2504 InlineLabels to Labels. Set the height of the data element.
2505 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2506 multiline text height in the Formatting DTO.
2507 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2508 for multiline height along with getter and setter methods.
2509 * src/main/webapp/style.css: Adjust style to account for the change
2510 from span elements to div elements in the details cell.
2512 2011-08-15 Ben Konrath <ben@bagu.org>
2514 Make the List View appearance match the mockups.
2516 It doesn't match exactly but it's much better than it was.
2518 * mockups/listview-contacts.html: Remove unused css classes.
2519 * mockups/listview-projects.html: Remove unused css classes.
2520 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2521 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2522 for mainPanel instead of VerticalPanel (table). Set style name on
2523 CellTable. Set style name on Details column. Right-align Details
2525 * src/main/webapp/style.css: Adjust properties to match the mockups.
2527 2011-08-12 Ben Konrath <ben@bagu.org>
2529 Add better support for subgroups in the details view.
2531 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2532 changed FlowTable constructor.
2533 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2534 support for subgroups and subgroup-titles.
2535 * src/main/webapp/style.css: Add CSS class for subgroups and
2538 2011-08-12 Ben Konrath <ben@bagu.org>
2540 Return the top level LayoutGroup title.
2542 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2544 2011-08-11 Ben Konrath <ben@bagu.org>
2546 Make the TableSelector header match the mockup.
2548 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2549 the layout panel. Properly lineup the table selection header with
2550 the list and details view.
2551 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2552 margin around the details view.
2553 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2554 Rename listBox variable to tableSelector. Set id for the style sheet.
2555 Use a FlowPanel instead of a HorizontalPanel.
2556 * src/main/webapp/style.css: Add properties to make the TableSelector
2557 box match the mockups.
2559 2011-07-13 Ben Konrath <ben@bagu.org>
2561 Update install script for java-libglom version change.
2563 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2566 2011-07-13 Ben Konrath <ben@bagu.org>
2568 Add support sub-group in the details view.
2570 I also removed the code that special-cased the default details view
2573 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2575 I still have to make a proper flowtable.
2577 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2578 Don't special-case default details view layout.
2579 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2580 addLayoutField() as I'm going to use it.
2581 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2582 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2584 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2585 extracted from DetailsViewImpl.GroupPanel. Add support for
2587 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2588 column count when getting the details layout.
2590 2011-07-12 Ben Konrath <ben@bagu.org>
2592 Set browser title with database and table titles.
2594 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2595 Set the browser title when the table changes and when the activity
2597 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2598 title when retrieving document info (the GlomDocument object).
2599 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2600 with getter and setter methods. Remove unused convenience constructor.
2601 Use default code formatting.
2603 2011-07-12 Ben Konrath <ben@bagu.org>
2605 Ignore LayoutItemPortals in the details view.
2607 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2610 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2611 LayoutItemPortal layout objects.
2612 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2613 LayoutItemPortal objects when retrieving the details layout.
2614 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2615 file. This is an empty class and just used to get type information for
2618 2011-07-12 Ben Konrath <ben@bagu.org>
2620 Use java-libglom 1.17.0.
2624 2011-07-11 Ben Konrath <ben@bagu.org>
2626 Remove "Table:" label from table selector.
2628 This matches a recent change in the Glom UI.
2630 * mockups/details-contacts.html:
2631 * mockups/details-projects.html:
2632 * mockups/listview-contacts.html:
2633 * mockups/listview-projects.html: Remove the "Table:" label from the
2635 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2637 2011-07-11 Ben Konrath <ben@bagu.org>
2639 Add main groups to the details view.
2641 This makes things look a little nicer in the details view. The next step
2642 is to implement the flowtable.
2644 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2645 resources from the standard gwt css theme. Standard.css is now
2646 included in OnlineGlom.html so that the online glom css rules have
2647 precedence over the gwt theme.
2648 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2649 the whole LayoutGroup to the DetailsView instead of just the titles.
2650 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2651 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2652 details layout with a helper class (GroupPanel). I might extract this
2653 class when I make the full flowtable.
2654 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2655 string as default so I don't have to worry about NPEs when processing
2657 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2658 note beside OnlineGlom.gwt.xml above).
2659 * src/main/webapp/style.css: Add default font-size to body to override
2660 the font-size set by the standard theme. Don't use h2 tags for
2661 group-title. Create new details-cell class.
2663 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2665 ConfiguredDocument: Set the port number too.
2667 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2668 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2669 Glom document. Presumably this worked sometimes so far because there is a
2670 default port number.
2672 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2674 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2676 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2677 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2678 correct, though we should throw an exception too.
2680 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2682 Fix a addDocuemnt typo.
2684 * src/main/java/org/glom/web/shared/Documents.java
2685 (Documents.addDocuemnt): Rename to addDocument().
2686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2687 (OnlineGlomServiceImpl.getDocuments): Adapt.
2689 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2691 Slightly improved log output when connection fails.
2693 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2694 (ConfiguredDocument.setUsernameAndPassword):
2695 We don't know for sure if it' the username/password that's wrong, so
2696 rephrase the message.
2697 Also ouput the exception message, though it's generic in this case.
2699 2011-07-08 Ben Konrath <ben@bagu.org>
2703 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2704 added braces to a one line if statement because the Eclipse formatter
2705 was getting confused.
2707 2011-07-07 Ben Konrath <ben@bagu.org>
2709 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2711 These should really be two separate tasks but I counldn't get things to
2712 work with GWT 2.2.0 and Eclipse 3.7.
2716 * .settings/org.eclipse.jdt.core.prefs:
2717 * .settings/org.eclipse.jdt.ui.prefs:
2718 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2719 * .settings/org.eclipse.m2e.core.prefs:
2720 Add new config files. Update current files. Remove references to the
2721 webtools plugins as we're not using any of the webtools features.
2722 * .gitignore: Add logs directory which is created when running with
2724 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2725 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2726 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2728 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2730 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2732 onlineglom.properties: Add explanatory comments.
2734 * src/main/resources/onlineglom.properties: Also change the default user
2735 from ben to someuser, to avoid the risk of people thinking we just
2736 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2738 2011-06-28 Ben Konrath <ben@bagu.org>
2740 Use filename in Log for incorrect passwords.
2742 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2743 getFileName(String) method to get the filename from the URI.
2745 2011-06-28 Ben Konrath <ben@bagu.org>
2747 Add the table name to the URL token for the ListPlace.
2749 This makes things consistent between the DetailsPlace and the
2750 ListPlace. It also allows the the ListPlace to be bookmarked.
2752 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2753 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2755 Remove getDefaultListLayout(). The default layout is now returned
2756 by the getListLayout() method when the table name is an empty string.
2757 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2758 Add table name field. Change to a new ListPlace when the table
2759 has been changed. Use getListLayout() for getting the default
2761 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2762 Add table name field. Set the correct table name in the list box
2763 when loading from bookmark. This corrects a problem for the
2765 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2766 Move table name to super-class (HasSelectableTable). Move document
2767 and table URL keys to super-class in HasSelectableTable.
2768 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2769 Add table name field. Add Tokenizer class with URL key common to
2770 the subclasses (DetailsPlace and ListPlace).
2771 * src/main/java/org/glom/web/client/place/ListPlace.java:
2772 Add table name. Add code to parse the URL token.
2773 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2774 Update ListPlace construction with empty table name string.
2775 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2776 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2777 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2778 Update ListPlace construction with table name string.
2779 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2780 Change defaultTableName field to tableName to reflect how it's now
2781 used. Update the getter and setter methods.
2783 2011-06-28 Ben Konrath <ben@bagu.org>
2785 Enable the table selector in the DetailsView.
2787 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2788 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2789 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2790 Remove getDefaultDetailsLayout(). The default layout is now returned
2791 by the getDetailsLayout() method when the table name is an empty
2793 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2794 event handler for table change event. Change to using
2795 getDetailsLayout() for the default details layout.
2796 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2798 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2799 when navigating to the details place.
2801 2011-06-27 Ben Konrath <ben@bagu.org>
2803 Use filename based unique document ID in URL and for RPC.
2805 The document ID is the glom document name with spaces (' ') replaced
2806 with pluses ('+') and without the .glom extension.
2808 This change is mostly a string substitution of 'documentTitle' for
2809 'documentID'. The only code change is the addition of a Documents DTO to get the
2810 filename to document title mappings as indicated below.
2812 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2813 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2814 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2815 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2816 Use Documents DTO to create the document links in the document
2818 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2819 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2820 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2821 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2822 * src/main/java/org/glom/web/client/place/ListPlace.java:
2823 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2824 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2825 * src/main/java/org/glom/web/client/ui/ListView.java:
2826 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2827 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2828 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2829 * src/main/java/org/glom/web/server/Log.java:
2830 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2831 getDocumentTitles() to getDocuments() and return the Documents DTO.
2832 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2833 transferring the filename to document title mappings.
2835 2011-06-25 Ben Konrath <ben@bagu.org>
2837 Make the authentication popup work again.
2839 This bug was introduced when I extracted ConfiguredDocument to its own class.
2841 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2842 correct success / fail status in setUsernameAndPassword().
2844 2011-06-25 Ben Konrath <ben@bagu.org>
2846 Use filename as unique key for configuring database usernames and passwords.
2848 This replaces the use of the Glom document title which could change
2849 depending on the locale. Thanks to Murray Cumming for pointing out this
2852 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2853 * src/main/resources/onlineglom.properties:
2855 2011-06-24 Ben Konrath <ben@bagu.org>
2857 Pass primary key value to DetailsView.
2859 This enables the DetailsView to load the correct data.
2861 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2862 primary key value field and set in constructor. Pass primary key
2863 value to getDetailsData().
2864 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2865 variables for document title and primary key value.
2866 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2867 key value to the DetailsPlace.
2869 2011-06-24 Ben Konrath <ben@bagu.org>
2871 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2873 This allows the primary key to be retrieved by the Details button. This
2874 functionality has not been implemented yet but it's in the works.
2876 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2877 the LayoutGroup result to ListView.setCellTable instead of all of its
2878 fields individually.
2879 * src/main/java/org/glom/web/client/ui/ListView.java:
2880 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2881 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2882 get the primary key for the table.
2883 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2884 index of the primary key in the LayoutGroup accounting for hidden
2885 primary keys. Rename getJavaNumberFormat() to
2886 convertToJavaNumberFormat() for consistency. Cleanup / add some
2888 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2889 field for primary key index and a field to indicate whether the
2890 primary key is hidden or not.
2892 2011-06-23 Ben Konrath <ben@bagu.org>
2894 Rename getTableData methods to getListData.
2896 This is a rename refactor for consistency with other methods.
2898 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2899 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2900 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2901 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2903 2011-06-23 Ben Konrath <ben@bagu.org>
2905 Extract the ConfiguredDocument innerclass into its own class.
2907 This makes the servlet code more object oriented.
2909 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2910 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2911 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2912 new ConfiguredDocument class.
2914 2011-06-21 Ben Konrath <ben@bagu.org>
2916 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2918 This makes things more inline with how libglom works and reduces code
2919 duplication. This refactor lays the groundwork for adding the primary key to
2920 the LayoutGroup object.
2922 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2923 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2924 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2925 Change method names to getListLayout and getDefaultListLayout for
2926 consistency. Use LayoutGroup as the DTO for the list layout instead of
2927 ColumnInfo and LayoutListTable.
2928 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2929 new method names along with the LayoutGroup object for transferring the
2931 * src/main/java/org/glom/web/client/ui/ListView.java:
2932 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2933 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2934 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2936 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2937 Replaced with LayoutGroup.
2938 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2939 expectedResultSize and defaultTableName fields which are needed for
2941 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2942 type field which is needed for the list layout but will also be
2943 useful for the details layout as things progress.
2944 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2945 Make class abstract. Remove the unnecessary
2946 getFormattingHorizontalAlignment method. Add setFormatting method.
2948 2011-06-16 Ben Konrath <ben@bagu.org>
2950 Add scripts for building and installing war.
2952 These will help when updating OnlineGlom but they're also good
2953 supplemental documentation of the build and deployment proceeding.
2955 * utils/build-onlineglom-war.sh: New file.
2956 * utils/install-onlineglom-war.sh: New file.
2958 2011-06-16 Ben Konrath <ben@bagu.org>
2960 Create wrapper class to create consistent log messages.
2962 I wrapped methods in the Log class of gwt-log to add the method names
2963 from the servlet and create consistent formatting of the document title
2964 and table names in the log messages.
2966 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2967 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2968 log methods to use methods from wrapped Log class.
2970 2011-06-16 Ben Konrath <ben@bagu.org>
2972 Remove superfluous conditional return.
2974 Thanks to Murray Cumming for pointing this out!
2976 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2978 2011-06-15 Ben Konrath <ben@bagu.org>
2980 Return an ArrayList of LayoutGroups for the Details layout.
2982 This corrects a problem with the details layout as it can have more
2983 than one top level LayoutGroup.
2985 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2986 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2987 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2988 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2989 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2990 with ArrayList of LayoutGroups for the details view layout.
2991 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2992 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2993 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2994 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2995 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2996 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2998 2011-06-14 Ben Konrath <ben@bagu.org>
3000 Use cast_dynamic method to determine the libglom LayoutItem type.
3002 This is better than finding the LayoutItem type by using the string
3003 returned from the get_part_type_name() method.
3005 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3007 2011-06-14 Ben Konrath <ben@bagu.org>
3009 Add method names to log entries in the servlet.
3011 This helps when tracking down deployment problems.
3013 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3015 2011-06-14 Ben Konrath <ben@bagu.org>
3017 Add data to the DetailsView using a hard-coded primary key value.
3019 The layout and functionality of the DetailsView is not complete. This
3020 is just a checkpoint so the patch doesn't get too big.
3022 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3023 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3024 Add getDetailsData() servlet method.
3025 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3026 Add RPC to getDetailsData(). Change the way the LayoutGroups and
3027 LayoutFields are added to the DetailsView.
3028 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3029 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3030 Add setData() method. Change addLayoutGroup() and addLayoutField() to
3031 take the string for the title instead of the object.
3032 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3033 Add implementation getDetailsData() along with some private helper
3035 * src/main/webapp/style.css: Add padding to details-data class. Add a
3036 details-label class with the same padding as the details-data class.
3038 2011-06-03 Ben Konrath <ben@bagu.org>
3040 Use presenter.goTo() to change to the DetailsPlace.
3042 This will make things easier when we need to open the DetailsView with
3043 data specific to the row that was clicked.
3045 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3047 2011-06-02 Ben Konrath <ben@bagu.org>
3049 Add CSS file from mockups.
3051 I'm adding this now because it's going to be useful to have when
3052 developing the DetailsView. The TableSelectionView and ListView aren't
3055 * src/main/webapp/OnlineGlom.html:
3056 * src/main/webapp/style.css:
3058 2011-06-02 Ben Konrath <ben@bagu.org>
3060 Use String.isEmpty() to check for empty string.
3062 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3064 2011-06-02 Ben Konrath <ben@bagu.org>
3066 Display main layout group titles in the DetailsView.
3068 This is the start of the DetailsActivity/DetailsView implementation.
3070 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3071 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3072 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
3073 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3074 Get the layout information for the details view from the server and set
3075 the main layout group titles.
3076 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3077 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3078 Add addLayoutGroup() and addLayoutField() methods. This are just
3079 temporary methods for creating the the details view that will change
3081 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3082 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
3084 * src/main/java/org/glom/web/shared/layout/Formatting.java:
3085 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3086 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
3087 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
3088 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3089 Data Transfer Objects that mimic the libglom object structure. These are
3090 used for transferring the details layout but could also be used for
3091 transferring the list layout.
3093 2011-05-27 Ben Konrath <ben@bagu.org>
3095 Reset the AuthenticationPopup when clearing the ListView.
3097 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3099 2011-05-27 Ben Konrath <ben@bagu.org>
3101 Fix problem with onlineglom.properties file loading.
3103 The old way worked in Eclipse but not on the server. Loading the
3104 onlineglom.properties file now works in Eclipse and on the server.
3106 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3108 2011-05-24 Ben Konrath <ben@bagu.org>
3110 Update gwt-log from 3.1.0 to 3.1.2.
3112 Gwt-log 3.1.0 has been marked as depreciated.
3116 2011-05-24 Ben Konrath <ben@bagu.org>
3118 Add comment to ListActivity.goTo() method.
3120 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3122 2011-05-24 Ben Konrath <ben@bagu.org>
3124 Remove FIXME in convertGdkColorToHtmlColour()
3126 The Gdk::Color value returned by libglom is 16-bits per channel on both
3127 64 and 32-bit platforms.
3129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3131 2011-05-19 Ben Konrath <ben@bagu.org>
3133 Improve performance of initial ListView load.
3135 I removed a round trip to the server for getting the default table name
3136 and then requesting information about that table. This also removes a potential
3137 problem with the table change handler not being setup in time to receive the
3138 table change event from the ListActivity.
3140 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3141 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3142 getDefaultLayoutListTable() method. Improve comments.
3143 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
3144 getDefaultLayoutListTable() method instead of firing a table change
3145 event to get the table to load.
3146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3147 implementation of getDefaultLayoutListTable() method.
3148 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
3151 2011-05-19 Ben Konrath <ben@bagu.org>
3153 Override toDebugString() in TableChangeEvent.
3155 This is useful to have for debugging.
3157 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
3159 2011-05-19 Ben Konrath <ben@bagu.org>
3161 Add a "Back to List" link when at the DetailsPlace.
3163 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3164 Populate the CellTable based on the selected table of the ListBox if
3165 it's set otherwise use the default table. This allows the "Back to
3167 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3168 Remove Place from constructors. Add a setPlace() method. Add
3169 goToPlace() method. Set class as presenter for TableSelectionView.
3170 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3171 Use the same TableSelectionActivity when switching between the List and
3173 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3174 Subclass the new HasSelectableTablePlace. This removes some duplicate
3176 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3177 New class to represent Places that display the TableSelectionView.
3178 * src/main/java/org/glom/web/client/place/ListPlace.java:
3179 Subclass the new HasSelectableTablePlace. This removes some duplicate
3181 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3182 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3183 Add Presenter interface. Add setBackLinkVisible() method. Add
3184 setBackLink() method.
3186 2011-05-18 Ben Konrath <ben@bagu.org>
3188 Enable the "Details" buttons.
3190 Right now only an empty details view is displayed.
3192 * src/main/java/org/glom/web/client/ClientFactory.java:
3193 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3194 Add DetailsView to ClientFactory.
3195 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3196 A basic activity for the details view.
3197 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3198 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
3200 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3201 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
3203 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
3204 Create a new DetailsActivity when a DetailsPlace is requested. Remove
3205 unnecessary super() in constructor.
3206 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
3207 Create a new TableSelectionActivity when a DetailsPlace is requested. We
3208 really shouldn't create a new TableSelectionActivity for both the ListPlace
3209 and the DetailsPlace so this should be considered a temporary solution.
3210 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3211 New file. Represents a URL for the details view.
3212 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3213 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3214 A basic details view interface and implementation.
3215 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3216 Enable the "Details" buttons.
3218 2011-05-12 Ben Konrath <ben@bagu.org>
3220 Use a LayoutPanel with multiple display areas for main layout.
3222 This is mostly a refactor in that there are no changes from the user
3223 point of view. These changes are required so that we can swap out the list view
3224 with the details view when the user clicks the "Details" button.
3226 * src/main/java/org/glom/web/client/ClientFactory.java:
3227 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3228 OnlineGlomView. Add TableSelectionView, ListView and
3229 AuthenticationPopup.
3230 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
3231 for main layout. Add display regions for main activities. Add
3232 activity manager for for main activities.
3233 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
3234 file from parts of the deleted OnlineGlomActivity.
3235 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java: