1 2012-05-16 Murray Cumming <murrayc@murrayc.com>
3 Use translations for top-level groups too.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
6 updateTitlesForLocale(): Use the translation for the group
7 as well as for child items.
11 Just recompiled to fix a problem in the released .tar.gz file.
15 2012-05-15 Murray Cumming <murrayc@murrayc.com>
17 Corrections to navigation to related records.
19 * src/main/java/org/glom/web/client/OnlineGlomService.java:
20 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
21 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
22 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
23 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
24 relationship name, because the relationship name is not necessarily unique
26 TOOD: This is inefficient, because it passes the whole list of
27 child field items back to the server, but it is more correct, and happens
28 to fix a bug with the primary key being lost after a few navigations.
29 There is probably a chance to make this more efficient anyway in some
32 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
33 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
34 * src/main/java/org/glom/web/server/ConfiguredDocument.java
35 * src/main/java/org/glom/web/server/database/DBAccess.java
36 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
37 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
40 2012-05-15 Murray Cumming <murrayc@murrayc.com>
42 Fix the use of translations.
44 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
45 Add updateTitlesForLocale().
46 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
47 Call it to discard unwanted translations and to make getTitle() return
48 the wanted translation wihout the need for the client code to specify a locale.
49 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
50 getTitle(): Fallback to the original title, as libglom does.
52 2012-05-15 Murray Cumming <murrayc@murrayc.com>
54 Document: Correctly report the number of available translation locales.
56 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
57 the available locale IDs list.
58 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
59 testLocales: Test this.
61 2012-05-15 Murray Cumming <murrayc@murrayc.com>
63 SqlUtils: Use camelCase.
65 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
66 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
67 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
68 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
69 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
70 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
72 2012-05-15 Murray Cumming <murrayc@murrayc.com>
74 Use jOOQ's tableByName() and fieldByName.
76 * pom.xml: Use jOOQ 2.3.1 to get the new API.
77 * src/main/java/org/glom/web/server/SqlUtils.java:
78 build_sql_select_step_with_where_clause(), .createField(),
79 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
80 so we can get correct quoting and escaping. Thanks to Lukas Eder for
81 adding this, and other things, to jOOQ.
83 2012-05-15 Murray Cumming <murrayc@murrayc.com>
85 SqlUtils: Remove the Connection parameters.
87 * src/main/java/org/glom/web/server/SqlUtils.java:
88 build_sql_select_with_key(), build_sql_select_with_where_clause(),
89 createSelect(), build_sql_select_step_with_where_clause(),
90 build_sql_count_select_with_where_clause(),
91 build_sql_select_count_rows(): Remove the Connection parameter because
92 jOOQ does not actually need a connectionwhen it is just used to build
94 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
96 * src/main/java/org/glom/web/server/ReportGenerator.java:
98 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
100 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
101 Constructor, getListData(), getResultSizeOfSQLQuery():
102 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
103 getSelectQuery(), getCountQuery():
104 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
105 getSelectQuery(), getCountQuery():
106 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
107 getNavigationRecord(): Adapted.
109 2012-05-14 Murray Cumming <murrayc@murrayc.com>
113 * src/main/java/org/glom/web/server/SqlUtils.java:
114 get_find_where_clause_quick(): Use a comparison of
115 lowercase values, instead of a simple equals. Regular Glom
116 uses the PostgreSQL ILIKE operator but jOOQ does not
117 support that just yet, though it will soon.
119 2012-05-14 Murray Cumming <murrayc@murrayc.com>
121 TableToViewDetails: Use a real serialization ID.
123 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
124 Though this does not fix the serialization problem.
126 2012-05-12 Murray Cumming <murrayc@murrayc.com>
128 Added LayoutItemPortalDeepCloneTest.
130 2012-05-11 Murray Cumming <murrayc@murrayc.com>
132 Make navigation work again.
134 * src/main/java/org/glom/web/server/libglom/Document.java:
135 Add getLayoutItemFieldShouldHaveNavigation().
136 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
137 Replace get/setAddNavigation() with the partly-existing
138 get/setNavigationTableName(), with an empty string being no navigation,
139 because this is simpler. Use the new
140 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
142 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
143 Add updateFieldsExtras() and call setNavigationTableName in it.
144 getDetailsLayoutGroup(),
145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
146 createLayout(): Adapted.
147 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
148 Constructor: Adapted.
150 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
151 Replace get/setAddNavigation() with get/setNavigation(), returning a
152 TableToViewDetails class with both the table name and UsesRelationship,
153 because both are need. The previous code used java-libglom's output
154 variable (strangely, via sharedptr) to return both, but we cannot really
156 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
157 getNavigationRecord(): Adapt. However, we cannot actually use the cache
158 here because it somehow gets set to null during deepCopy(). I must test this.
159 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
160 testGetSuitableTableToViewDetails(): Adapted.
162 TODO: Find out why deepClone() is not quite working.
164 2012-05-11 Murray Cumming <murrayc@murrayc.com>
166 DBAccess: Simplify the retrievel of full field details.
168 * src/main/java/org/glom/web/server/database/DBAccess.java
169 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
170 because the Document loading should have done this.
172 2012-05-11 Murray Cumming <murrayc@murrayc.com>
174 Document: Correct loading of doubly-related layout fields.
176 * src/main/java/org/glom/web/server/libglom/Document.java:
177 loadUsesRelationship(): Actually set the related relationship, instead
178 of only setting it if it's not found.
180 2012-05-09 Murray Cumming <murrayc@murrayc.com>
182 Replace all appearances of Colour with color.
184 Because US English is dominant.
186 2012-05-09 Murray Cumming <murrayc@murrayc.com>
188 Use colors in HTML format, solving a warning about an unused function.
190 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
191 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
192 Add *asHTMLColor() versions of methods.
193 TODO: However, we should create and cache the results on the server.
194 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
195 * src/main/java/org/glom/web/client/ui/list/ListTable.java
196 * src/main/java/org/glom/web/server/ConfiguredDocument.java
197 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
198 Use the asHTMLcolor() versions.
200 2012-05-09 Murray Cumming <murrayc@murrayc.com>
202 ListViewTable: Constructor: Take the table name as a parameter.
204 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
205 Constructor: Take the tableName, and set the member variable, because
207 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
208 setCellTable(): Pass the table name.
209 This makes navigation to non-default tables work again. I don't know
210 why it worked before in the master branch.
212 2012-05-07 Murray Cumming <murrayc@murrayc.com>
214 ConfiguredDocument: Restore correct addition of hidden primary key items.
216 * src/main/java/org/glom/web/client/ui/list/ListTable.java
217 (ListTable.createCellTable): Uncomment out the check for the hidden
219 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
220 add primary key items for top-level lists and portals, as before,
221 instead of adding them to each group.
222 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
223 Actually implement the extra methods such as setHiddenPrimaryKey() and
224 comment that these are used only for top-level list groups and in portals.
225 This strangeness suggests even more that this should not be squeezed
226 into the LayoutGroup class.
228 2012-05-07 Murray Cumming <murrayc@murrayc.com>
230 Fix Formatting loading.
232 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
233 getFormattingUsed(): Remove the duplicate Formatting member variable
234 in favour of the one from the base class.
235 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
236 Initialize a new Formatting instead of using null by default, so we
237 have some defaults, instead of having to initialize one later just to
238 get the same defaults. This also makes loading of formatting from the
239 document work, because that expected a non-null.
241 2012-05-07 Murray Cumming <murrayc@murrayc.com>
243 RelatedListTable: Make sure that the tableName is set.
245 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
246 Constructor: Take the tableName so it is available later. Otherwise,
247 the server assumes that we mean the default table and cannot find the
249 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
250 setData(): Pass the tableName to the RelatedListTable constructor.
252 2012-05-07 Murray Cumming <murrayc@murrayc.com>
256 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
257 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
258 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
260 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
262 * src/main/java/org/glom/web/server/database/DBAccess.java:
263 convertResultSetToDTO(), getPortal():
264 * src/main/java/org/glom/web/server/database/ListDBAccess.java
266 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
267 Add checks for null objects and out of range access, with log messages to
268 give hints so we can fix these properly.
270 2012-05-07 Murray Cumming <murrayc@murrayc.com>
272 Portals: some corrections.
274 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
276 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
277 constructor: Use getRelationshipNameUsed() instead of getName(), because
278 that is what is meant.
279 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
280 getFromField(): Fix a typo, to get the field name, not the table name.
281 * src/main/java/org/glom/web/server/database/DBAccess.java:
282 getPortal(): Fix a typo that stopped this from working.
284 2012-05-07 Murray Cumming <murrayc@murrayc.com>
286 LayoutItemPortal: Also override getTitleOriginal().
288 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
289 This lets the base getTitle() with no parameters work.
290 TODO: Test this properly.
292 2012-05-06 Murray Cumming <murrayc@murrayc.com>
294 LayoutItemPortal: getTitle*(): Use the relationship title.
296 2012-05-06 Murray Cumming <murrayc@murrayc.com>
298 LayoutItemField: Fix loading of custom titles.
300 * src/main/java/org/glom/web/server/libglom/Document.java
301 loadDataLayoutItemField(): The title, if any, instead of the field
302 title, is stored in a title_custom node. Load it from there.
303 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
305 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
306 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
307 getTitle*() overrides.
308 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
311 2012-05-06 Murray Cumming <murrayc@murrayc.com>
313 LayoutItemField: Fall back to field titles, so some are really shown.
315 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
316 Override getTitleOriginal() and getTitle(), as in java-libglom.
317 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
320 2012-05-06 Murray Cumming <murrayc@murrayc.com>
322 Correct use of setExpectedResultSize().
324 * src/main/java/org/glom/web/server/ConfiguredDocument.java
325 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
326 Use setExpectedResultSize only on top-level groups (for instance, the
327 list layout) or on child portals (in details views).
328 Use the correct table name for portals to avoid SQL errors.
329 Update the expected counts when returning cached layouts.
331 2012-05-06 Murray Cumming <murrayc@murrayc.com>
333 Document: Interpret no group column count as 1.
335 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
336 default, though we now check for this in the UI code anyway.
338 2012-05-06 Murray Cumming <murrayc@murrayc.com>
342 2012-05-06 Murray Cumming <murrayc@murrayc.com>
344 Translatable: Use Hashmap instead of Treemap because GWT supports it.
346 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
347 The use of Treemap lead to this error from async methods, with no
349 "The response could not be deserialized"
351 2012-05-06 Murray Cumming <murrayc@murrayc.com>
353 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
355 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
356 when using the Google -> GWT Compile, or
357 g toolbar button -> GWT Compile Project... feature in Eclipse.
359 2012-05-06 Murray Cumming <murrayc@murrayc.com>
361 ListTable.addColumn(): Protect against a null Formatting.
363 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
364 Create a default Formatting if it is null, because that is the simplest
367 2012-05-06 Murray Cumming <murrayc@murrayc.com>
369 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
371 * src/main/java/org/glom/web/server/ConfiguredDocument.java
372 updateLayoutGroup(): Check that the field is not null.
374 2012-05-06 Murray Cumming <murrayc@murrayc.com>
376 ListViewImpl: Protected against a bad cast error.
378 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
379 onEnterKeyDown(): Do not cast without an instanceof check.
381 2012-05-06 Murray Cumming <murrayc@murrayc.com>
383 ListTable: Protect against an out of range error.
385 * src/main/java/org/glom/web/client/ui/list/ListTable.java
386 createCellTable(): This is unlikely, but can happen while debugging.
388 2012-05-06 Murray Cumming <murrayc@murrayc.com>
390 AsyncMessage onFailure() callbacks: Log the exception message.
392 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
393 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
394 * src/main/java/org/glom/web/client/activity/ListActivity.java:
395 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
396 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
397 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
398 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
399 These are useful clues when something is wrong.
401 2012-05-06 Murray Cumming <murrayc@murrayc.com>
403 ConfiguredDocument: Avoid a null dereference.
405 * src/main/java/org/glom/web/server/ConfiguredDocument.java
406 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
407 details maps are created.
409 2012-05-06 Murray Cumming <murrayc@murrayc.com>
411 Document: Correct the port number parsing.
413 * src/main/java/org/glom/web/server/libglom/Document.java:
414 This lets us actually connect to the database and show the document.
416 2012-05-05 Murray Cumming <murrayc@murrayc.com>
420 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
421 user-interaction, asking us to load a temporary URL in a browser.s
422 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
423 which is apparently necessary for testing the service. See the comment.
424 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
425 Show the exception, if any. This is how I saw the 404 in the HTML in
428 2012-05-05 Murray Cumming <murrayc@murrayc.com>
430 DocumentTest: Move the .glom files into the resources directory.
432 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
433 URI via getResource().
435 2012-05-05 Murray Cumming <murrayc@murrayc.com>
437 Document: Remove the FieldIdentifies inner class.
439 * src/main/java/org/glom/web/server/libglom/Document.java: We only
440 use the Relationship (though the same function in libglom is maybe
441 used in other ways) and so this removes a compiler warning.
443 2012-05-05 Murray Cumming <murrayc@murrayc.com>
445 Document.load() Remove the error code parameter.
447 * src/main/java/org/glom/web/server/libglom/Document.java: load():
448 Remove the parameter. We do not set it yet and it could never have
449 worked as an output parameter (though maybe it did in java-libglom).
450 We could use an exception if we really want the failure reason.
451 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
453 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
454 setUp(), testGetSuitableTableToViewDetails(): Adapt.
456 2012-05-05 Murray Cumming <murrayc@murrayc.com>
458 Make some inner classes static.
460 * src/main/java/org/glom/web/server/ConfiguredDocument.java
461 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
462 * src/main/java/org/glom/web/server/ReportGenerator.java
463 * src/main/java/org/glom/web/server/libglom/Document.java
464 Make all inner classes static that can be static.
466 2012-05-05 Murray Cumming <murrayc@murrayc.com>
468 OnlineGlomServiceImpl: Do not load and check for java-libglom.
470 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
471 init(): We do not use java-libglom any more.
473 2012-05-05 Murray Cumming <murrayc@murrayc.com>
475 Remove mentions of java-libglom.
477 * README: Remove mention of java-libglom, because it no longer needed.
478 * utils/build-onlineglom-war.sh:
479 * utils/check-and-recover-tomcat.py:
480 * utils/install-onlineglom-war.sh: Remove these as they are no longer
481 useful. Building is now far easier, with no need for jhbuild.
483 2012-05-05 Murray Cumming <murrayc@murrayc.com>
485 Fix the build (mvn package)
487 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
488 (LayoutGroup): Make the LayoutItemList inner class static and protected.
489 Otherwise the GWT Java->Javascript compilation fails with just this
490 error, during mvn package or when attempting to view in a browser,
491 in the GWT developer mode in Eclipse.
493 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
494 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
495 [INFO] Compiling module org.glom.web.OnlineGlom
496 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
497 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
498 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
499 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
500 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
501 [INFO] [ERROR] Cannot proceed due to previous errors
503 It has taken me 2 days to find out what was causing that. After reducing
504 the code, the compiler eventually showed me the full error message.
506 2012-05-04 Murray Cumming <murrayc@murrayc.com>
508 ConfiguredDocument: Cache the cloned and stripped layouts.
510 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
511 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
512 layout in a map, so we can retrieve it again without rebuilding it.
514 2012-05-04 Murray Cumming <murrayc@murrayc.com>
516 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
518 2012-05-04 Murray Cumming <murrayc@murrayc.com>
520 libglom classes: Implement some auto-generated emthods.
522 2012-05-04 Murray Cumming <murrayc@murrayc.com>
524 Add GwtTestOnlineGlomService.
526 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
527 However, this (and the other GwtTest*) does not seem to run during
530 2012-05-04 Murray Cumming <murrayc@murrayc.com>
532 Remove use of unsupported features from client code.
534 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
535 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
536 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
537 Use our client version of StringUtils instead of the apache commons one.
539 However, the GWT Javascript compliation still fails.
541 2012-04-25 Murray Cumming <murrayc@murrayc.com>
543 Add a Field class and implement some loading of it in Document.
545 2012-04-25 Murray Cumming <murrayc@murrayc.com>
547 Initial Document loading implementation, instead of libglom.
549 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
550 and Translatable classes, and adapt the rest of the code to use them.
551 However, this is still missing Layout and Field classes and loading.
553 2012-04-24 Murray Cumming <murrayc@murrayc.com>
555 Use of jOOQ: Move Field creation into a utility method.
557 * src/main/java/org/glom/web/server/SqlUtils.java:
558 This lets us improve it more easily.
560 2012-04-24 Murray Cumming <murrayc@murrayc.com>
562 Use of jOOQ: Improve the code to COUNT a sub-select.
564 * src/main/java/org/glom/web/server/SqlUtils.java:
565 Move initial query creation into
566 build_sql_select_step_with_where_clause().
567 build_sql_select_count_rows(): Use the jOOQ API instead of
568 concatentating text, because a jOOQ Select*Step is a TableLike,
569 which is what from() takes.
571 2012-04-23 Murray Cumming <murrayc@murrayc.com>
573 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
575 * pom.xml: Depend on jooq.
576 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
577 methods with jOOQ, based on the C++ implementations in libglom,
578 with some changes to the logic required by jooQ.
579 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
581 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
582 * src/main/java/org/glom/web/server/ReportGenerator.java:
583 * src/main/java/org/glom/web/server/SqlUtils.java:
584 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
585 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
586 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
587 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
588 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
589 Adapt. In particular, the SqlUtils methods now need to take a Connection,
590 because jOOQ needs that, though it seems unnecessary.
592 This is not quite finished. Ideally jOOQ would help us to build
593 table_name.field_name names, quoting and escaping them properly.
594 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
596 2012-04-21 Murray Cumming <murrayc@murrayc.com>
598 Move use of Glom.build_sql*() into a new SqlUtils class.
600 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
601 to wrap Glom.build_sql*(). The parameter types are still Glom one,
602 but this will make it easier to start using something other than
603 libglom or SqlBuilder.
605 2012-04-21 Murray Cumming <murrayc@murrayc.com>
607 Update the project URL.
609 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
611 2012-04-21 Murray Cumming <murrayc@murrayc.com>
613 Main layout: Use a FlowTable instead of absolute positioning.
615 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
616 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
617 child panels/widgets must have an absolute position. But that is annoying, so
618 this adds a FlowTable and puts the child panels in there.
620 2012-04-21 Murray Cumming <murrayc@murrayc.com>
622 GwtTestOnlineGlom: Comment out unused code.
624 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
625 Eclipse has started to say that some code is unused.
627 2012-04-21 Murray Cumming <murrayc@murrayc.com>
629 Update to the latest versions of dependencies.
631 * pom.xml: Update version numbers of dependencies to the latest
633 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
634 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
635 * src/main/java/org/glom/web/server/ReportGenerator.java:
636 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
637 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
638 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
640 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
641 Modify the imports where necessary.
643 2012-04-17 Murray Cumming <murrayc@murrayc.com>
645 Style: Remove overflow:hidden from searchbox
647 * src/main/webapp/style.css: Because this pushes the Back To Link
648 label/link on to the next row, which is then hidden due to the
649 hard-coded (in ems) height.
651 2012-04-20 Murray Cumming <murrayc@murrayc.com>
653 Remove some duplicate code.
655 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
656 getDocumentInfo(): This must have been duplicated during the merge from the
661 2012-04-19 Murray Cumming <murrayc@murrayc.com>
663 Reports: Localize the waiting for report message.
665 * src/main/java/org/glom/web/client/activity/ReportActivity.java
666 start(): Get the message from the contants.
667 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
669 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
670 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
671 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
672 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
673 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
674 Update these files with the English text for newer strings for now.
676 2012-04-19 Murray Cumming <murrayc@murrayc.com>
678 Reports: Show a message while waiting for the report.
680 * src/main/java/org/glom/web/client/ui/ReportView.java
681 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
682 Add setWaitingText(), to show a message saying that we are
683 waiting for the report to be ready.
684 * src/main/java/org/glom/web/client/activity/ReportActivity.java
685 start(): Call setWaitingText() before calling the async
688 2012-04-19 Murray Cumming <murrayc@murrayc.com>
690 ReportGenerator: Specify date and time formats.
692 * src/main/java/org/glom/web/server/ReportGenerator.java:
693 createFieldValueElement(): Use the default (and localized)
694 short formats, though we still need a way to show 4-digit
695 years without providing the format for every locale.
696 * src/main/java/org/glom/web/server/database/DBAccess.java:
697 convertResultSetToDTO(): Use the short formats here too.
699 2012-04-18 Murray Cumming <murrayc@murrayc.com>
701 ReportGenerator: Use the correct numeric formatting.
703 * src/main/java/org/glom/web/server/ReportGenerator.java
704 createFieldExpression(), createFieldValueElement(): Take the
705 whole LayoutItem_Field instead of just the field name, so
706 we have access to the formatting.
707 createFieldValueElement(): Use JRTextField.setPattern() to
708 specify the numeric formatting, with the help of a
709 regular DecimalFormat.
711 2012-04-18 Murray Cumming <murrayc@murrayc.com>
713 ReportGenerator: Avoid showing null for group by titles.
715 * src/main/java/org/glom/web/server/ReportGenerator.java
716 generateReport(): Use setBlankWhenNull() on the field title
717 style too, because this is used for values in group by
720 2012-04-18 Murray Cumming <murrayc@murrayc.com>
722 ReportGenerator: Add a colon to titles in vertical groups.
724 * src/main/java/org/glom/web/server/ReportGenerator.java
725 addFieldToDetailBandVertical(): Pass true for the withColon
728 2012-04-18 Murray Cumming <murrayc@murrayc.com>
730 ReportGenerator: Simplify the code by using Position more.
732 2012-04-18 Murray Cumming <murrayc@murrayc.com>
734 Reports: Support vertical groups, roughly.
736 * src/main/java/org/glom/web/server/ReportGenerator.java:
737 addToReport(): Rename to addGroupToReport() and, if necessary,
738 call the new addVerticalGroupToReport() method.
739 createFieldValueElement(): Let the caller specify the Y position
742 2012-04-17 Murray Cumming <murrayc@murrayc.com>
744 Reports: Allow a second report to be shown.
746 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
747 clear(): Do not remove the HTML widget, which broke the whole layout.
749 2012-04-17 Murray Cumming <murrayc@murrayc.com>
751 Locales drop-down: Show that we use English by default.
753 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
754 fillView(): When we use English, just because that is the default, when
755 no locale is specified, show that in the Locales drop-down instead of
756 just showing the first item.
758 2012-04-17 Murray Cumming <murrayc@murrayc.com>
760 Unselect the Report/Locale/Table combo item when appropriate.
762 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
763 setPlace(): clear reportName if this is not a ReportPlace.
764 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
765 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
766 When the provided name is empty, unselect all items, so that none are
767 indicated. This uses a for loop because I cannot find a single method
770 2012-04-17 Murray Cumming <murrayc@murrayc.com>
772 Report: Give the user a way to get back to the list.
774 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
775 start(), setPlace(): Show the Back To List link on reports, and also
776 interpret selecting the empty report item as back to list.
778 2012-04-13 Murray Cumming <murrayc@murrayc.com>
780 Really show the selected Report name.
782 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
783 setPlace(): Store the reportName here, if it is that kind of Place.
784 fillView(): Set the selected Report after filling the list of reports.
785 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
786 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
787 null Strings, though we need some way to unselect all ListBox items
790 2012-04-13 Murray Cumming <murrayc@murrayc.com>
792 ReportGenerator: Try to avoid some problems.
794 * src/main/java/org/glom/web/server/ReportGenerator.java
795 addField(): Try to avoid duplicates, and avoid using a null
798 2012-04-13 Murray Cumming <murrayc@murrayc.com>
800 Reports: Use quickFind.
802 * src/main/java/org/glom/web/client/OnlineGlomService.java;
803 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
804 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
805 getReportHTML(): Add a quickFind parameter.
806 * src/main/java/org/glom/web/client/activity/ReportActivity.java
807 start(): Pass the quickFind parameter.
808 * src/main/java/org/glom/web/server/ReportGenerator.java
809 generateReport(): Take a quickFind parameter.
811 2012-04-13 Murray Cumming <murrayc@murrayc.com>
813 ReportPlace: Actually use the report name.
815 * src/main/java/org/glom/web/client/place/ReportPlace.java
816 getPlace(): Do not assign the report name to the quickfind.
818 2012-04-13 Murray Cumming <murrayc@murrayc.com>
820 Show java.library.path when complaining.
822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
823 init(): When telling us to check java.library.path, show the
826 2012-03-06 Murray Cumming <murrayc@murrayc.com>
828 ReportGenerator: Do not show nulls.
830 2012-03-06 Murray Cumming <murrayc@murrayc.com>
832 ReportGenerator: Make the title font larger.
834 2012-03-06 Murray Cumming <murrayc@murrayc.com>
836 ReportGenerator: Put field titles inside groups, if there are groups.
838 2012-03-06 Murray Cumming <murrayc@murrayc.com>
840 ReportGenerator: Take the Report itself instead of the name and group.
842 * src/main/java/org/glom/web/server/ConfiguredDocument.java
843 Remove getReportLayoutGroup().
844 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
845 getReportHTML(): Pass the report instead
846 of its name and layout group.
847 * src/main/java/org/glom/web/server/ReportGenerator.java
848 generateReport(): Use the report object to use the title
851 2012-03-06 Murray Cumming <murrayc@murrayc.com>
853 ReportGenerator: Remove designBand parameters.
855 * src/main/java/org/glom/web/server/ReportGenerator.java:
856 Make designBand a class member instead of passing it to all
859 2012-03-06 Murray Cumming <murrayc@murrayc.com>
861 ReportGenerator: Add lines, a bit like in the desktop version.
863 * src/main/java/org/glom/web/server/ReportGenerator.java
864 addToReport(): Use JRDesignLine.
866 2012-03-06 Murray Cumming <murrayc@murrayc.com>
868 ReportGenerator: Correct the title positions and use some bold style.
870 * src/main/java/org/glom/web/server/ReportGenerator.java:
871 Break the code up into reusable functions, correct the placement of
872 titles, and use normal/bold styles as in the reports in the desktop
875 2012-03-06 Murray Cumming <murrayc@murrayc.com>
877 ReportGenerator: Add a header band to show the field titles.
879 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
880 getReportHTML(): Pass the localeId to the ReportGenerator
882 * src/main/java/org/glom/web/server/ReportGenerator.java
883 constructor: Take the localeID so we can get translated field
885 generateReport(), addToReport(), addFieldToBand(): Add field
886 titles in a column header band.
888 2012-03-05 Murray Cumming <murrayc@murrayc.com>
890 Reports drop-down list: Some improvement.
892 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
893 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
894 Adedd setSelectedReport(),
895 setReportList(): Add a blank line so that the user can select the
897 * src/main/java/org/glom/web/client/activity/ReportActivity.java
898 start(): Show the current report by calling setSelectedReport().
899 This does not seem to work yet.
901 2012-03-05 Murray Cumming <murrayc@murrayc.com>
903 DetailsActivity, ListActivity: Move some variables into a base class.
905 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
906 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
907 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
908 the clientFactory, documentID, tableName and authenticationPopup into
909 a base class, to avoid duplication.
911 2012-03-05 Murray Cumming <murrayc@murrayc.com>
913 Translate the Reports label.
915 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
916 Get the "Reports" label string from the constants.
917 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
918 perties: Add Reports to the constants.
920 2012-03-05 Murray Cumming <murrayc@murrayc.com>
922 Reports: Implement grouping.
924 * src/main/java/org/glom/web/server/ReportGenerator.java:
925 Handle LayoutItem_GroupBy items and try to do the right thing
926 with JRDesignGroup. It seems to work.
928 2012-03-04 Murray Cumming <murrayc@murrayc.com>
930 Actually show some data with JasperReports.
932 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
933 getReportHTML(): Move most code into a ReportGenerator class.
934 * src/main/java/org/glom/web/server/ReportGenerator.java:
935 Recurse into sub-groups, adding fields to the JasperDesign's details
936 band. Note that we must set an arbitrary width and height, or it just
937 will not show any data.
939 2012-03-04 Murray Cumming <murrayc@murrayc.com>
941 Reports Chooser: Show the titles, not the names.
943 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
944 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
945 and the names as the values.
946 * src/main/java/org/glom/web/server/ConfiguredDocument.java
947 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
948 group now that we provide the report name, so it should always
951 2012-02-15 Murray Cumming <murrayc@murrayc.com>
953 Depend on jasperreports.
955 * pom.xml: Add the dependency. My plan is to use this on the
958 2012-01-31 Murray Cumming <murrayc@murrayc.com>
960 Implement navigation to report places.
962 * src/main/java/org/glom/web/client/activity/ReportActivity.java
963 start(): Do not bother to handle all events here.
964 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
965 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
966 Added getSelectedReport().
967 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
968 .java: start(): When handling a change to the reports chooser,
969 call getSelectedReport() and goTo() its ReportPlace.
970 * src/main/java/org/glom/web/client/ui/ReportView.java
971 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
972 Added setReportHTML() which puts the html in a gwt HTML widget.
973 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
974 getReportHTML(): Return "TODO" just to show that this works.
976 2012-01-31 Murray Cumming <murrayc@murrayc.com>
978 Make ReportPlace usable.
980 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
982 * src/main/java/org/glom/web/client/place/ReportPlace.java:
983 Correct the @prefix annotation.
985 2012-01-31 Murray Cumming <murrayc@murrayc.com>
987 OnlineGlomService: Return report HTML rather than the LayoutGroup.
989 * src/main/java/org/glom/web/client/OnlineGlomService.java:
990 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
991 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
992 Change getReportLayout() to getReportHMTL() because we will not need to
993 parse or render the report layout on the client side.
994 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
995 getReportLayout(): Return the libglom LayoutGroup type because we will
996 not need to convert to a shared type, because this will not be used on
998 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1001 Note that there is still no implementation for this.
1004 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1006 Add a (empty) Report Place, View, and Activity.
1008 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1010 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1011 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1012 this into a superclass:
1013 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1014 and also use it as the base of this new ReportPlace:
1015 * src/main/java/org/glom/web/client/place/ReportPlace.java
1017 * src/main/java/org/glom/web/client/ui/ReportView.java
1018 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1019 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1020 Add these, containing mostly boiler-plate for now.
1022 * src/main/java/org/glom/web/client/OnlineGlomService.java
1023 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1024 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1025 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1026 Add API to get the LayoutGroup for the report.
1028 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1030 Add and fill a Reports drop-down list box.
1032 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1034 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1035 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1036 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1037 Added getReports(document, table, localeID), calling
1038 ConfiguredDocument.getReports().
1039 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1040 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1041 Added setReportsList() and a list widget.
1042 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1043 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1048 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1050 Translations: Add Esperanto.
1052 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1053 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1054 properties: Add this translation because someone took the time to make it.
1056 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1058 Adapt to the java-libglom 1.21.7 API.
1060 * src/main/java/org/glom/web/server/ReportGenerator.java:
1061 addToReport(): get_group_secondary_fields() is now
1062 get_secondary_fields().
1065 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1067 Use the latest java-libglom version.
1069 * pom.xml: Use java-libglom 1.21.7.
1071 2012-03-03 Ben Konrath <ben@bagu.org>
1073 Display date and time in details view.
1075 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1077 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1079 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1081 Require the latest java-libglom.
1083 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1085 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1087 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1089 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1090 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1091 an empty quickfind string. I also corrected libglom to create only
1092 empty where clauses for empty quickfind strings, but this avoids the
1095 2012-02-24 Ben Konrath <ben@bagu.org>
1097 Improve the tabs in the Notebook widget.
1101 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1103 Translations: Try to translate the strings.
1105 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1106 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1107 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1108 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1109 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1110 Take the Open translation from GTK+'s .po files.
1111 Take the Details translation from Glom's po files.
1112 I have added the other strings to Glom so we can get translations that way:
1113 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1115 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1117 TableSelectionViewImpl: Put the search label and entry in a div.
1119 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1120 Put the search widgets in a FlowTable so that the CSS can be used to
1121 style them while keeping them together.
1122 * src/main/webapp/style.css: Mention the new div.
1124 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1126 Translate more strings in more locales.
1128 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1129 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1130 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1131 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1132 Translate the "Details" and "Open" string too.
1134 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1135 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1136 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1137 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1138 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1139 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1140 Add these new locales as placeholders though they currently contain English.
1142 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1144 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1147 Check the ConfiguredDocument* for null before using it.
1149 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1151 Tell Eclipse about the generated java files.
1153 * .classpath: This lets it find OnlineGlomConstants.java.
1154 It would be nice if Eclipse just used the maven build files.
1156 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1158 Prevent a crash when no locale is specified in the URL.
1160 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1161 Avoid returning a null string, obtained from
1162 Window.Location.getParameter(). This caused a crash when it was
1163 later passed to libglom's API.
1164 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1165 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1166 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1167 guard against future null strings.
1169 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1171 Use the ?locale= query param instead of the &lang= token param.
1173 * src/main/java/org/glom/web/client/place/ListPlace.java
1174 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1175 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1176 Remove the lang token key and value.
1178 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1179 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1180 When the user selects a different locale from the chooser, use
1181 Window.Location.assign() to change the URL, which then causes a reload.
1183 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1184 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1185 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1186 * src/main/java/org/glom/web/client/activity/ListActivity.java
1187 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1188 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1189 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1190 * src/main/java/org/glom/web/client/ui/ListView.java:
1191 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1193 Remove localeID member variables and method/constructor parameters, instead
1194 using Utils.getCurrentLocaleID() when we need a localID to pass to
1197 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1199 Internationalize the UI strings.
1201 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1202 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1203 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1204 because it is unused. Messages are apparently strings that can have
1205 parameters, but we do not need that yet, so Contants will be enough for now.
1206 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1207 to say that we support the en and de locales.
1208 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1209 The original English strings.
1210 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1211 Some German translations of the English strings.
1212 The i18n goal then uses the .properties file to generate an
1213 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1214 returns an implementation that returns the translated strings.
1215 The documentation suggests putting these in src/java/*/client/, but it seems
1216 best to put it in src/resources/*/client/.
1217 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1218 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1219 instead of hard-coding them.
1220 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1221 but that does not seem to stop the build, though it confuses Eclipse.
1223 You can see the translated string by adding ?locale=de to the URL, like so:
1224 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1226 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1228 Improve null/empty String checks.
1230 * pom.xml: Add a dependency on commons-lang, to use
1231 org.apache.commons.lang.StringUtils.
1232 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1233 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1234 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1235 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1236 Use StringUtils.isEmpty().
1238 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1239 StringUtils class with a static isEmpty() function because we
1240 cannot use org.apache.commons.lang.StringUtils in client-side
1241 GWT code because it (apparently) cannot be compiled to javascript.
1242 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1243 * src/main/java/org/glom/web/client/activity/ListActivity.java
1244 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1245 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1246 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1247 * src/main/java/org/glom/web/client/place/ListPlace.java
1248 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1249 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1250 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1251 * src/main/java/org/glom/web/client/ui/details/Group.java
1252 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1253 our StringUtils.isEmpty() function.
1255 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1257 Update to the latest java-libglom API.
1259 * pom.xml: Require java-libglom 1.21.4.
1260 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1261 getDocumentInfo(), getListViewLayoutGroup():
1262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1264 * src/main/java/org/glom/web/server/database/DBAccess.java
1265 getFieldsToShowForSQLQueryAddGroup(),
1266 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1267 with either get_database_title_original() or
1268 get_database_title(localeID).
1270 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1272 ConfiguredDocument: Avoid a null pointer exception.
1274 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1275 Initialize localeID to "" to avoid returning a null String which
1276 causes a crash in java-libglom's swing-generated code.
1278 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1280 Some simple renaming.
1282 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1283 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1284 for localeChooser. This seems more appropriate and is less ambiguous
1285 particularly in the .css file.
1287 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1289 ConfiguredDocument: Rename the localedID private member variable.
1291 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1293 Adapt to the latest java-libglom API from git master.
1295 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1296 libglom now uses only Vector instead of List, which uses add() instead of
1299 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1301 ConfiguredDocument: Rename the localedID private member variable.
1303 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1305 Build a source tarball with mvn assembly:single
1307 * assembly.xml: Add this file.
1308 * pom.xml: Use the maven-assembly-plugin and tell it to use
1309 our assembly.xml file.
1311 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1313 OnlineGlomServiceImpl: Get .glom files recursively.
1315 * pom.xml: Depend on commons-io from org.apache.commons.
1316 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1317 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1318 files recursively, and with the easier filter for the extension.
1319 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1320 simplify that code too.
1322 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1324 README: Mention that you must install java-libglom packages separately.
1326 But then it works, because java-libglom is now in the central maven
1329 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1331 locales drop-down: Show the correct selected locale when the URL changes.
1333 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1334 .java: setPlace(): Move some code into fillView().
1336 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1338 locales drop-down: Do not lose the primary key.
1340 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1341 start(): onLocaleChange(): Pass the current primary key value,
1342 instead of an empty value.
1344 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1346 locales drop-down: Do not lose the drop-down selection.
1348 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1349 .java (TableSelectionActivity.fillView): Set the selected locale
1350 after changing the drop-down items (though we do not really need
1351 to change them just because the locale changes.)
1353 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1355 locales drop-down: Change the tables list when this changes.
1357 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1358 .java: TableSelectionActivity.start(): Move the async table titles
1359 retrieval into a private fillView() method and also call this when
1360 the chosen locale changes.
1361 Note that the document title is not actually translatable yet, but
1362 that is a problem that I should fix soon in libglom.
1364 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1366 Improve the placement of the locales drop-down.
1368 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1369 Put the title and locales drop-down in a div (gwt.FlowTable).
1370 * src/main/webapp/style.css: Add magic css properties to make this work.
1371 Also remove the left margin from the title so that it lines up with the
1374 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1376 locales selector: Show human-readable locale titles.
1378 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1379 getDocumentInfo(): Use java.util.Locale to show a real title of
1380 each locale, in the locale's own language.
1382 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1384 Add a language/locale selector drop-down.
1386 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1387 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1388 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1389 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1390 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1391 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1392 Add a ListBox to show the available locales. Add getLocaleSelector(),
1393 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1394 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1395 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1396 java: Add these classes.
1397 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1398 start(): Fill the locales ListBox. Handle its change event, firing a
1400 setPlace(): Show the selected locale as specified by the URL token.
1401 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1402 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1403 Handle LocaleChangeEvent, going to a new *Place with that locale.
1405 The placement of the ListBox is not pretty, and it currently uses the ID
1406 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1410 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1412 Search box: Show the search text from the URL token.
1414 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1415 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1416 Add setQuickFindText().
1417 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1418 .java: setPlace(): Store the queryText if the place is a ListPlace,
1419 and call TableSelectionView.setQuickFindText().
1421 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1423 Allow use of translations via, for instance, &lang=de in the URL.
1425 * pom.xml: Use the unstable java-libglom 1.21 version.
1427 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1428 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1429 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1430 init(): Instead of calling TranslatableItem.set_current_locale()
1431 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1432 However, this is only for default locales, which are not needed to
1433 change the locale in the URL.
1434 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1435 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1436 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1437 layout for a particular locale.
1438 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1439 Add get/setDefaultLocaleID().
1440 getDocumentInfo(), getListViewData(), getRelatedListData(),
1441 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1442 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1443 localeID parameter, so we can get the layout for a particular locale.
1445 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1446 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1447 * src/main/java/org/glom/web/client/place/ListPlace.java:
1448 Parse and construct a lang parameter too.
1450 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1451 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1452 passed to subsequent methods and constructors.
1453 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1454 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1455 Store the localeID from the *Place and pass it to other constructors
1456 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1458 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1459 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1460 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1461 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1462 * src/main/java/org/glom/web/client/ui/ListView.java:
1463 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1464 Take localeID parameters and pass them to subsequent constructors and
1465 methods, so that the layout is always retrieved for that locale.
1467 This is rather repetitive.
1469 Note that "" means the original (default) locale of the Glom document,
1470 which is usually English.
1472 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1474 Documents: Remove final keyword to fix startup configuration.
1476 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1477 final keywords on the private member variables because that breaks
1478 the startup, apparently (there are warnings) because it stops them
1479 from being serialized. I added these in the previous commit.
1481 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1483 Documents: Add some final keywords.
1485 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1488 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1490 OnlineGlomServiceImpl: Add to overview comments.
1492 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1493 Note that this is where all the document are loaded. They are not
1494 loaded freshly for each page.
1496 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1500 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1501 Add a TextBox for the text of a quick find.
1502 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1504 setBackLink(): Add a String quickFind parameter.
1505 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1506 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1507 to the base interface, because that is how TableSelectionViewImpl is used.
1508 * src/main/webapp/style.css: Add style for the search box and its label.
1510 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1511 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1512 Add these files, based on the existing TableChangeEvent and
1513 TableChangeEventHandlers.
1514 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1515 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1516 a ListPlace() that the user should be taken to.
1517 * src/main/java/org/glom/web/client/activity/ListActivity.java
1518 start(): Handle it here too and adapt the TableChangeEvent handler to
1519 pass the extra "" quickFind parameter to ListPlace.
1520 * src/main/java/org/glom/web/client/place/ListPlace.java:
1521 Constructor: Take an extra String quickFind parameter and store it,
1522 returning it from a new getQuickFind() method.
1523 getToken(): Put the quickFind text in the URL token.
1524 getPlace(): Parse the quickFind text from the URL token.
1525 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1526 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1527 ListPlace constructor.
1528 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1529 .java: start(): Add a Change handler for the TableSelectionView's
1530 TextBox (via its base HasChangeHandlers interface), firing the new
1531 QuickFindChangeEvent.
1532 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1533 pass the extra "" quickFind parameter.
1535 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1536 setCellTable(): Add a String quickFind parameter and pass it to
1537 the ListViewTable() constructor.
1538 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1539 setCellTable() in the base interface, because that is how ListViewImpl
1542 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1543 Add a String quickFind member variable.
1544 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1545 Constructor: Add a String quickFind parameter, storing it in the
1546 base ListTable's member variable.
1547 onRangeChanged(): Pass quickFind to the
1548 OnlineGlomServiceAsync.getSortedListViewData() and
1549 OnlineGlomServiceAsync.getListViewData() methods.
1551 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1552 getListViewData(), getSortedListViewData(): Add a String quickFind
1553 parameter, passing it to ConfiguredDocument.getListViewData().
1554 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1555 Change getListViewData(), getSortedListViewData() in the base interface,
1556 because that is how OnlineGlomServiceImpl is used, via this:
1557 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1558 Change getListViewData(), getSortedListViewData() here too.
1559 This class can apparently be used to asynchronously call methods on
1560 OnlineGlomService, and GWT seems to implement that after recognizing
1561 just the *Async name convention and the extra AsyncCallback parameters.
1563 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1564 getListViewData(): Add a String quickFind parameter, and pass it to
1565 ListViewDBAccess.getData().
1566 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1567 getListData(): Add a String quickFind parameter and pass it to
1569 getSelectQuery(): Add a String quickFind parameter.
1570 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1571 getSelectQuery(): Add a String quickFind parameter and use it with
1572 Glom.get_find_where_clause_quick() to pass a where_clause to
1573 Glom.build_sql_select_with_where_clause(), to actually filter the
1575 getData(): Add a String quickFind parameter, passing it to getListData().
1576 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1577 va: getData(): Pass an empty string to getListData() for the
1578 quickFind parameter.
1580 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1582 ListTable: Minor change.
1584 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1585 createCellTable(): Make this protected instead of public.
1587 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1589 Many files: Use final for the parameters and use the @override attribute.
1591 2012-01-22 Ben Konrath <ben@bagu.org>
1593 Add anchor links for single line text that starts with http, ftp and www.
1597 2012-01-22 Ben Konrath <ben@bagu.org>
1599 Add ellipsis to single line text in details view.
1603 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1605 Remove all javadoc author tags.
1607 Because they are awkward and meaningless when many people touch
1609 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1611 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1613 Revert the COPYING.LESSER to COPYING rename.
1615 Apparently both should be there if it is LGPL.
1617 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1619 *View: Remove unused imports.
1621 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1622 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1623 * src/main/java/org/glom/web/client/ui/ListView.java:
1624 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1625 Remove unused imports, as suggested by Eclipse.
1627 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1629 Move the *View::Presenter types, and some API into one base View.
1631 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1632 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1633 * src/main/java/org/glom/web/client/ui/ListView.java:
1634 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1635 Presenter, setPresenter() and clear() into a shared base interface,
1636 to avoid the unnecessary duplicate Presenter types and to more clearly
1637 show how the *Views share the same structure, even if they are not
1638 used polymorphically.
1640 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1641 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1643 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1644 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1645 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1647 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1650 Feel free to revert this if there is a good reason for the duplicate
1653 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1655 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1657 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1658 a class member instead of a local variable in the method.
1659 This lets us use it to get the view instances, for use in tests.
1660 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1661 beforeOnlineGlom(): Test some more details of the initial view.
1662 Again, this is not very useful.
1664 To really test gwt-glom we will need to start a local postgresql
1665 instance with local data, like the Glom tests in C++.
1667 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1669 pom.xml: Mention the LGPL license.
1671 * pom.xml: Add a licenses section.
1672 * COPYING.LESSER: Move this to COPYING, which
1673 previously contained the GPL. But gwt-glom is all LGPL.
1675 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1677 Add project information to README and pom.xml.
1679 * README: Add a brief description and mention some mvn
1681 * pom.xml: This extra information shows up in mvn site
1684 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1686 Use the latest java-libglom version.
1688 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1690 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1692 GwtTestOnlineGlom: Test a little more.
1694 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1695 protected rather than private, as suggested by the gwt-test-utils
1697 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1698 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1699 Test the initial visibility of the panels.
1701 However, this is not a very useful test.
1702 And I wonder how we should generally test using this idea for an
1703 activity/places app like ours where the real changes happen implicitly
1704 based on the history token/URL.
1706 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1708 Slight modification to *Mapper comments.
1710 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1711 (DataActivityMapper)
1712 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1714 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1716 Remove comments mentioning GIN because they are just copied from
1717 the example code and are apparently not helpful:
1718 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1719 Also change the mention of a class that is only in the example code.
1721 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1723 GwtTestOnlineGlom test: Minor changes.
1725 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1726 Avoid the long qualified class name and modify the comment
1727 because it is now obvious to me that the mocked class is the only
1728 custom one created via GWT.create().
1730 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1732 Tests: Added the beginnings of a test using gwt-test-utils.
1734 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1735 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1736 which tells gwt-test-utils what class will be tested.
1737 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1738 Add a simple (but empty) test case. One class, used by the OnlineGlom
1739 class, is mocked so that it can be created. However, I am not sure
1740 why only this class needs to be mocked.
1742 Note that mockito seems more popular, and clearer, than easymock,
1743 but I have not got that working yet. It might be a matter of the
1746 This test is run during mvn integration-test.
1748 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1750 Tests: Use junit4-style syntax instead of junit3-style.
1752 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1753 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1754 * src/test/java/org/glom/web/shared/DataItemTest.java:
1755 Use the @Test annotation rather than relying on the test*() prefix.
1756 Also no longer implement TestCase, to avoid triggering support for
1757 the junit3-way, which stops the annotations from working.
1758 Change the imports from import junit.framework.* to
1759 import org.junit.*, which is apparently the new way.
1761 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1763 Added a test for ListPlace token parsing and creation.
1765 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1766 This is much the same as DetailsPlaceTest.
1768 I wonder how we could test the other parts of the *Place API.
1770 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1772 DetailsPlace test: Also test getToken() and recreation via getPlace().
1774 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1775 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1776 recreate it, testing the recreated DetailsPlace for the same parameter
1779 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1781 Use the surefire-report plugin.
1783 * pom.xml: This generates a HTML report about the tests in
1784 target/site/surefire-report.html
1785 when you do mvn surefire-report:report. It seems to be popular/normal.
1787 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1789 Added a test for DetailsPlace.
1791 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1792 Test the getPlace() token parsing.
1794 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1796 Added a first unit test.
1798 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1799 * src/test/java/org/glom/web/shared/DataItemTest.java:
1800 This is a silly test but it is just to get things started. Note that
1801 maven/junit finds the test because it looks in src/test by default.
1803 2011-12-22 Ben Konrath <ben@bagu.org>
1805 Change charsetName to "UTF-8" when replacing line breaks.
1807 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1808 that work in Java (such as "UTF8") will not work when compiled to
1811 This fixes a problem with multi-line details view fields that have hard
1812 line breaks. The "License Text" field on this page demonstrates the
1815 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1817 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1819 2011-12-22 Ben Konrath <ben@bagu.org>
1821 Fix another bug with related list navigation.
1823 I've tested all the navigation buttons in all of the related lists
1824 so things should be good now.
1826 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1828 2011-12-22 Ben Konrath <ben@bagu.org>
1830 Fix a crasher when refreshing the list view with the default table.
1832 This crash will also happen when loading the list view with the default
1833 table from a link or bookmark.
1835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1836 to the main document selection page when the document id hasn't been
1838 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1839 the main document selection page when the document id hasn't been
1841 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1842 values for the details place when the document id hasn't been set.
1843 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1844 values for the list place when the document id hasn't been set.
1846 2011-12-21 Ben Konrath <ben@bagu.org>
1848 Protect against NPE when glom.document.locale is not in config.
1850 This patch protects against an NPE when glom.document.locale is not in
1851 the config file. This NPE will also happen if glom.document.locale is
1854 The patch also updates the error message to display the class name when
1855 the getMessage() returns null. This was happening when the NPE was
1856 thrown and I had "Configuration Error: null". If an NPE is encountered
1857 with this patch, "Configuration Error: NullPointerException " will be
1860 This commit closes this bug:
1862 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1864 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1866 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1868 Rename onlineglom.properties to onlineglom.properties.sample.
1870 * src/main/resources/onlineglom.properties: Rename to:
1871 * src/main/resources/onlineglom.properties.sample:
1872 * src/main/resources/README: And add this file explaining that people
1873 should rename it back when deploying.
1875 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1877 Allow choosing the translation in the .properties file.
1879 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1880 init(): Read a glom.document.locale value from the configuration file
1881 and call Glom's TransatableItem::set_current_locale() method.
1882 * src/main/resources/onlineglom.properties: Add a commented-out
1883 example of this new setting.
1885 It would be better to add &lang=de_DE to the URL, but the current
1886 libglom API does not allow us to do this easily. I am working on that.
1888 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1890 Avoid a crash in parsing of token parameters.
1892 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1893 ava: getTokenParams(): Do not crash if a parameter has a key but no
1894 value, and ignore parameters with neither.
1896 2011-12-17 Murray Cumming <murrayc@murayc.com>
1898 History token building/handling: Improve use of token parameters.
1900 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1901 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1902 and buildParamsToken(HashMap), for use by derived classes.
1903 Make the separator private because it is no longer be needed.
1904 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1905 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1906 instead of manual string concatenation.
1907 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1908 of hardcoded indices and awkward splitting code.
1909 * src/main/java/org/glom/web/client/place/ListPlace.java
1910 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1911 instead of manual string concatenation.
1912 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1913 of hardcoded indices and awkward splitting code.
1914 This should fix bug #666420
1916 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1918 Fix a Navgiation->Navigation typo in the code.
1920 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1921 Rename processNavgiation() to processNavigation().
1923 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1925 Fix a seperator->separator typo in the code.
1927 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1928 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1929 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1932 2011-12-15 Ben Konrath <ben@bagu.org>
1934 Cleanup some comments.
1936 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1938 2011-12-14 Ben Konrath <ben@bagu.org>
1940 Replace \n with <br/> for multiline text in the details view.
1942 Vertical scrollbars are added when needed as well.
1944 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1946 2011-12-14 Ben Konrath <ben@bagu.org>
1948 Specify the font for document selection links.
1950 * src/main/webapp/style.css:
1952 2011-12-14 Ben Konrath <ben@bagu.org>
1954 Fix bouncy CellTable while paging.
1956 This doesn't currently work with related list tables in unselected
1959 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1961 2011-12-14 Ben Konrath <ben@bagu.org>
1963 Revamp the appearance of the document selection page.
1965 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1966 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1967 * src/main/webapp/style.css:
1969 2011-12-13 Ben Konrath <ben@bagu.org>
1971 Set navigation button column to the smallest size possible.
1973 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1975 2011-12-13 Ben Konrath <ben@bagu.org>
1977 Change OpenButton nomenclature to NavigationButton.
1979 Using NavigtionButton makes things more generic. Classes, methods and
1980 variables have been changed.
1982 This is a rename-only refactor.
1984 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1985 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1986 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1987 Renamed from OpenButtonCell.
1988 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1989 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1990 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1992 2011-12-12 Ben Konrath <ben@bagu.org>
1994 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1996 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1997 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1998 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1999 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2001 2011-12-12 Ben Konrath <ben@bagu.org>
2003 Update variable names and comments.
2005 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2006 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2008 2011-12-12 Ben Konrath <ben@bagu.org>
2010 Properly initialize numNonEmptyRows variable to zero.
2012 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2013 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2015 2011-12-05 Ben Konrath <ben@bagu.org>
2017 Add latest mockup with HTML tables.
2019 Features of this mockup:
2021 -> HTML table for flowtable
2022 -> HTML table for flowtable column
2023 -> Example of how related lists would look
2024 -> Not using text entries for data items
2026 The current version of Online Glom doesn't use HTML tables for the
2029 This mockup has been sent to the glom-devel mailing list but it's good
2030 to have it here as well.
2032 * mockups/details-view-html-tables.html:
2034 2011-12-05 Ben Konrath <ben@bagu.org>
2036 Remove unnecessary getPrimaryKeyField() method.
2038 getPrimaryKeyFieldForTable(String) has been renamed to
2039 getPrimaryKeyField(String).
2041 * src/main/java/org/glom/web/server/database/DBAccess.java:
2042 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2043 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2045 2011-12-05 Ben Konrath <ben@bagu.org>
2047 Add string representation of TypedDataItem value to conversion error message.
2049 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2050 message was extracted into its own method to avoid duplication.
2052 2011-12-05 Ben Konrath <ben@bagu.org>
2054 Add type checking to navigation primary key value creation.
2056 Create navigation primary key only if the expected type from the Glom
2057 document matches the type returned by the SQL query.
2059 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2061 2011-12-05 Ben Konrath <ben@bagu.org>
2063 Rename a couple of variables in RelatedListNavigation.
2065 This is a rename-only refactor.
2067 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2069 2011-12-05 Ben Konrath <ben@bagu.org>
2071 Move getListLayoutGroup() into getListViewLayoutGroup().
2073 This removes getListLayoutGroup(). It was only being called by
2074 getListViewLayoutGroup().
2076 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2078 2011-12-05 Ben Konrath <ben@bagu.org>
2080 Remove check for LayoutItem_Portal in list table method.
2082 This check is no longer necessary because the method isn't being used
2083 to create the LayoutItemPortal DTO.
2085 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2087 2011-12-05 Ben Konrath <ben@bagu.org>
2089 Properly support related list navigation.
2091 Navigation from the "Repository Analyzer -> Package Scans ->
2092 Dependencies" related table wasn't working because the primary key for
2093 related tables wasn't being set properly. This commit fixes the
2096 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2097 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2098 doesn't set the primary key properly for related list tables.
2099 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2100 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2101 useful for getting the primary key for list view tables and for related
2103 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2104 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2105 Move code to set the primary key for the table from the abstract
2106 ListDBAccess class to ListViewDBAccess as it's only correct for list
2108 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2109 Properly add primary key to related list tables.
2111 2011-12-02 Ben Konrath <ben@bagu.org>
2113 Properly set the horizontal alignment of fields.
2115 This fix is for both the list tables and the details view.
2117 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2118 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2119 to set the horizontal alignment of fields.
2121 2011-12-02 Ben Konrath <ben@bagu.org>
2123 Display currency codes in the details view.
2125 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2127 2011-12-02 Ben Konrath <ben@bagu.org>
2129 Avoid duplicate JNI call.
2131 JNI is not as efficient as pure Java and this is an easy (and small)
2134 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2135 Use previously retrieved value for whereClauseToTableName instead of
2138 2011-12-02 Ben Konrath <ben@bagu.org>
2140 Rename a couple of variables in RelatedListNavigation.
2142 This is a rename-only refactor.
2144 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2146 2011-12-02 Ben Konrath <ben@bagu.org>
2148 Indicate clearly that a mismatched primary key type is a bug.
2150 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2151 warning to error. Add 'This is a bug.' to message.
2153 2011-12-02 Ben Konrath <ben@bagu.org>
2155 Update / fix some comments.
2157 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2159 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2161 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2162 Fix comments. Add some TODOs.
2164 2011-12-02 Ben Konrath <ben@bagu.org>
2166 Enable navigation to details view with string primary key from related list.
2168 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2169 Create a text primary key value when return type of result is
2170 java.sql.Types.VARCHAR.
2172 2011-12-02 Ben Konrath <ben@bagu.org>
2174 Use checkboxes for booleans in the details view.
2176 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2178 2011-12-01 Ben Konrath <ben@bagu.org>
2180 Improve performance of related list height calculation.
2182 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2183 Put code to calculate the expected height in a static initializer so
2184 that that it's only called once.
2186 2011-12-01 Ben Konrath <ben@bagu.org>
2188 Show related list tables in notebooks (again).
2190 Calculate the height of the related list tables so the Notebook can be
2191 set the correct height. The height of the related list table is also needed by
2192 FlowTable to be able decide how to create the layout.
2194 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2195 and set the Portal height based on the height of the related list
2196 table and the Portal container.
2197 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2198 Add method to calculate the height of the related list tables.
2199 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2200 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2201 calculate the height of the Pager widget.
2203 2011-12-01 Ben Konrath <ben@bagu.org>
2205 Use CellTable API for table property instead of setting style on Element.
2207 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2209 2011-12-01 Ben Konrath <ben@bagu.org>
2211 Make ListViewTable and RelatedListTable a consistent height.
2213 The tables are now a consistent height regardless of the contents of
2214 the table. A hidden button is added to empty rows to ensure that the
2215 height of these rows will match the height of rows with data.
2217 A navigation button column is now added to every table. The width of
2218 the navigation column is set to 0px when a RelatedListTable shouldn't
2219 have navigation buttons. This maintains the a consistent row height in
2220 tables that don't show the navigation buttons.
2222 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2223 navigation column when not needed.
2224 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2225 arguments for navigation button to constructor of ListViewTable.
2226 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2227 hidden button for empty data rows.
2228 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2229 arguments for navigation button to constructor.
2230 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2231 create navigation buttons. Add hideNavigationButtons() method.
2232 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2233 arguments for navigation button to constructor.
2235 2011-12-01 Ben Konrath <ben@bagu.org>
2237 Use 'visibility: hidden' in Utils.getWidgetHeight().
2239 This is better choice because hidden elements are invisible, don't
2240 respond to events and are not part of the tab order. They will,
2241 however, take up space which is required to be able to calculate the
2242 height of the widget.
2244 * src/main/java/org/glom/web/client/Utils.java:
2246 2011-12-01 Ben Konrath <ben@bagu.org>
2248 Use Utils.getWidgetHeight() in FlowTable.
2250 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2252 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2254 2011-12-01 Ben Konrath <ben@bagu.org>
2256 Put the details css class name on the correct table column.
2258 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2260 2011-11-30 Ben Konrath <ben@bagu.org>
2262 Update for java-libglom API change.
2264 The getters and setters on FieldFormatting and NumericFormat were
2265 changed to remove the 'M'.
2267 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2269 2011-11-29 Ben Konrath <ben@bagu.org>
2271 Only allow RelatedListTables in Portals.
2273 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2275 2011-11-29 Ben Konrath <ben@bagu.org>
2277 Only create a contents panel for Portals when title is being set.
2279 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2281 2011-11-29 Ben Konrath <ben@bagu.org>
2283 Set TabLayoutPanel height based on calculated height its widgets.
2285 This is a potential fix for this bug:
2287 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2289 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2291 2011-11-29 Ben Konrath <ben@bagu.org>
2293 Align details field labels and data with the Open buttons.
2295 * src/main/webapp/style.css:
2297 2011-11-29 Ben Konrath <ben@bagu.org>
2299 Remove unnecessary <div> in the Notebook widget.
2301 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2302 method to get container FlowPanel (<div>).
2303 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2304 initWidget() method directly on the TabLayoutPanel widget instead of
2305 Group's container widget.
2307 2011-11-29 Ben Konrath <ben@bagu.org>
2309 Don't add group titles for Portals in Notebooks.
2311 This reverts the previous patch and fixes a bug I introduced with
2312 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2314 * src/main/java/org/glom/web/client/ui/details/Group.java:
2315 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2317 2011-11-28 Ben Konrath <ben@bagu.org>
2319 Remove unused boolean argument in Portal constructor.
2321 Just a code cleanup.
2323 * src/main/java/org/glom/web/client/ui/details/Group.java:
2324 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2326 2011-11-28 Ben Konrath <ben@bagu.org>
2328 Remove hack for glom 1.18 style glom files.
2330 * src/main/java/org/glom/web/client/ui/details/Group.java:
2331 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2332 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2334 2011-11-28 Ben Konrath <ben@bagu.org>
2336 Use Gda Value version of primary key to log result too large error.
2338 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2340 2011-11-28 Ben Konrath <ben@bagu.org>
2342 Don't use TypedDataItem.getText() for Unknown types from the URL.
2344 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2345 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2346 instead of getText().
2347 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2348 String field and getUnknown() method.
2350 2011-11-28 Ben Konrath <ben@bagu.org>
2352 Log an error message when the java-libglom .so is not present.
2354 The error message was being set in the exception but not logged.
2356 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2358 2011-11-28 Ben Konrath <ben@bagu.org>
2360 Ignore LayoutItem_CalendarPortals.
2362 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2363 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2365 2011-11-28 Ben Konrath <ben@bagu.org>
2367 Extract method for creating the LayoutItemPortal DTO.
2369 Just breaking the code up into smaller chunks.
2371 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2373 2011-11-28 Ben Konrath <ben@bagu.org>
2377 This should have been added with the refactor. Oops!
2379 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2381 2011-11-28 Ben Konrath <ben@bagu.org>
2383 Create primary key value from URL string using type from Glom document.
2385 See this bug, comments 19 - 25:
2387 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2389 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2390 create a TypeDataItem for the primary key here when loading from a
2391 URL. Show the same string for the primary key value as was received
2392 from the URL string (when loading from a URL).
2393 * src/main/java/org/glom/web/server/Utils.java: Update method for
2394 creating the Gda Value from the TypeDataItem to properly deal with
2395 creating a Gda Value based on the Glom document type for the primary
2396 key value string when loading from a URL.
2397 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2398 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2399 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2400 Update for changed method name.
2402 2011-11-27 Ben Konrath <ben@bagu.org>
2404 Rename PrimaryKeyItem to TypedDataItem.
2406 The name PrimaryKeyItem suggests what the class should be used for.
2407 TypedDataItem is a neutral name that describes the class better.
2409 This is a rename-only refactor.
2411 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2412 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2413 * src/main/java/org/glom/web/client/Utils.java:
2414 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2415 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2416 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2417 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2418 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2419 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2420 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2421 * src/main/java/org/glom/web/server/Utils.java:
2422 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2423 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2424 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2425 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2427 2011-11-25 Ben Konrath <ben@bagu.org>
2429 Improve Gda Value conversion from PrimaryKeyItem.
2431 The value from the PrimaryKeyItem is only used if its type match the
2432 type from the glom document.
2434 * src/main/java/org/glom/web/server/Utils.java:
2436 2011-11-25 Ben Konrath <ben@bagu.org>
2438 Manually check if the java-liblgom .so is visible to the JVM.
2440 It seems that Tomcat has problems when a static initializer throws an
2441 exception. This check is done before the first method call into
2442 java-libglom so that execution doesn't continue if the .so is not
2445 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2447 2011-11-25 Ben Konrath <ben@bagu.org>
2449 Improve browser configuration error messages.
2453 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2455 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2456 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2457 getConfigurationErrorMessage() method.
2458 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2459 Get and display a specific configuration error message when no Glom
2460 documents are found.
2461 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2462 Implement getConfigurationErrorMessage() method. Surround configuration
2463 code in the init() method with a try/catch block. This allows the
2464 errors to be caught while keeping the servlet available to retrieve the
2465 configuration error message.
2467 2011-11-25 Ben Konrath <ben@bagu.org>
2469 Don't use Strings to hold primary key values.
2471 The primary key values are now held in a new data object
2472 (PrimaryKeyItem) that holds type information and the primary key value
2473 using the correct type.
2475 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2476 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2477 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2478 PrimaryKeyItem instead of String to hold the primary key value.
2479 * src/main/java/org/glom/web/client/Utils.java: Remove
2480 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2481 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2482 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2483 PrimaryKeyItem instead of String to hold the primary key value. Load
2484 document selection page when the documentID has not been set correctly.
2485 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2486 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2488 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2489 Return empty string for URL instead of "null".
2490 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2491 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2492 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2493 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2494 PrimaryKeyItem instead of String to hold primary key values.
2495 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2496 PrimaryKeyValue to a Gda Value.
2497 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2498 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2499 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2500 Replace temporary database access code that uses the PrimaryKeyValue to
2501 Gda Value conversion.
2502 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2503 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2504 PrimaryKeyItem instead of String.
2505 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2506 hold primary key values.
2508 2011-11-24 Ben Konrath <ben@bagu.org>
2510 Use newly added java-libglom API to create queries.
2512 This isn't finished. I still need to stop using Strings for primary key
2513 values in the client code.
2515 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2516 libglom to use fake connections so that retrieving the query string will
2518 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2519 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2520 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2521 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2522 Use the newly added libglom sql methods and classes to create the
2523 query. Add temporary hack to convert primary value strings to Gda
2526 2011-11-23 Ben Konrath <ben@bagu.org>
2528 Don't explicitly set the height of Portals.
2530 See comments 6 - 10 of this bug for details:
2532 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2534 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2536 2011-11-23 Ben Konrath <ben@bagu.org>
2538 Use an HTML table instead of CSS for the FlowTable layout.
2540 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2541 GWT's FlexTable to implement the FlowTable.
2542 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2544 2011-11-18 Ben Konrath <ben@bagu.org>
2546 Add boolean example to HTML table mockup.
2548 * mockups/details-view-html-tables-text-entries.html:
2550 2011-11-17 Ben Konrath <ben@bagu.org>
2552 Ensure the pager buttons are always visible for related lists.
2554 To accomplish this, I've turned off text wrapping in the list view and
2555 related list tables for both the header and data text. The related list
2556 table now has a fixed layout so the it doesn't overflow its container.
2557 This is required to ensure that the cell text is clipped when it
2558 overflows the cell and an ellipsis is added to the right side of the
2559 cell when text is clipped.
2561 A fixed table layout for the related list table in the details view
2562 seems what we want for the details view anyway, so the side-effect is
2565 The ellipsis will only be displayed in Firefox >= 7.
2569 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2571 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2572 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2573 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2575 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2576 Set the 'table-layout: fixed' CSS property to the related list table.
2577 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2578 'white-space: nowrap;' CSS property on both the list view and the
2579 related list tables.
2581 2011-11-16 Ben Konrath <ben@bagu.org>
2583 Rework the fix for empty notebook tab labels.
2585 Setting the empty group titles with its name caused problems for the
2586 details layout. Instead of using libglom's
2587 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2588 to the client when the title is empty. This allows the Notebook to use
2589 the name when the title is empty without affecting anything else.
2591 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2592 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2594 2011-11-16 Ben Konrath <ben@bagu.org>
2596 Set group titles with name when title is empty.
2598 This fixes a problem with an empty notebook tab label in the Lesson
2599 Planner document. The forth tab in the notebook should be "Internet":
2601 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2603 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2604 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2607 2011-11-16 Ben Konrath <ben@bagu.org>
2609 Remove whitespace from the configured username properties.
2611 This assumes that usernames won't have whitespace at the beginning
2612 or end. But I think this is a reasonable assumption.
2614 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2615 String.trim() to remove the whitespace from the username properties.
2617 2011-11-15 Ben Konrath <ben@bagu.org>
2619 Add details view mockup with HTML tables and text entries.
2621 This is from the attachment on this bug:
2623 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2625 * mockups/details-view-html-tables-text-entries.html:
2627 2011-11-15 Ben Konrath <ben@bagu.org>
2629 Add space between the columns of the flow table.
2633 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2635 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2636 space between columns in the flow table.
2638 2011-11-15 Ben Konrath <ben@bagu.org>
2640 Add backup files to the .gitignore.
2642 * .gitignore: Ignore files that end with ~.
2644 2011-11-09 Ben Konrath <ben@bagu.org>
2646 Use latest release of gwt-log.
2648 Gwt-log releases are now being submitted to the maven central
2649 repository so manual installation of the jar is no longer required.
2651 * pom.xml: Update version and groupId of gwt-log dependency.
2653 2011-10-31 Ben Konrath <ben@bagu.org>
2655 Don't use GWT numeric formatting to override the glom currency formatting.
2657 Currencies are now displayed like they are in Glom. See this bug:
2659 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2661 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2663 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2664 currency code to constructor and set it when the cell is rendered.
2665 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2666 currency code to the constructor of the NumericCell.
2668 2011-10-27 Ben Konrath <ben@bagu.org>
2670 Require the latest release of java-libglom (1.17.4).
2674 2011-10-26 Ben Konrath <ben@bagu.org>
2676 Add style to Notebook that matches current theme.
2678 It's not the best style in the world but it's better than the default.
2680 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2681 padding at the bottom of the child widgets.
2682 * src/main/webapp/style.css: Add style for the Notebook.
2684 2011-10-26 Ben Konrath <ben@bagu.org>
2686 Move servlet initialization code to overridden init method.
2688 This is half of the solution to getting proper error messages
2689 displayed when configuration errors occur. Here's the relevant bug:
2691 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2693 The rest of the solution involves surrounding the init method with a
2694 try/catch block and setting a global variable with the error /
2695 exception. A new async method should be created to retrieve and display
2696 the error message / exception.
2698 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2699 code from constructor to init method adding exceptions as needed.
2701 2011-10-26 Ben Konrath <ben@bagu.org>
2703 Add script to monitor and restart tomcat if required.
2705 * utils/check-and-recover-tomcat.py: New file.
2707 2011-10-26 Ben Konrath <ben@bagu.org>
2709 Display the correct number of data items in the pager.
2713 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2715 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2716 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2717 The implementation is the same for both tables: Keep track of the
2718 number of non-empty rows and fire and RowCountChangeEvent after the data has
2720 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2721 custom Pager class that subclasses SimplePager to handle displaying
2722 the correct number when empty rows have been added.
2724 2011-10-26 Ben Konrath <ben@bagu.org>
2726 Correct error in previous commit.
2728 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2729 eventBus parameter from listView.setCellTable().
2731 2011-10-26 Ben Konrath <ben@bagu.org>
2733 Fix error in TODO comment.
2735 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2737 2011-10-24 Ben Konrath <ben@bagu.org>
2739 Create Notebook widgets to the details view.
2741 This isn't finished just yet - I still need to create a reasonable
2742 style to match the current theme.
2744 * src/main/java/org/glom/web/client/Utils.java: Add method for
2745 calculating the height of a widget. This is used in the Notebook class.
2746 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2747 new constructor method in Group.
2748 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2749 method for creating child widget that can be used by subclasses
2750 like Notebook. New constructor that allows disabling the group
2751 titles - Notebooks don't set a group title for their child groups.
2752 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2753 to make Notebooks using GWT's TabLayoutPanel.
2754 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2755 constructor that allows disabling the group titles.
2756 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2757 LayoutItemNotebook DTO.
2758 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2759 DTO for Notebooks. It's just an empty class for now but we might need
2760 it to transfer some specific information in the future.
2762 2011-10-21 Ben Konrath <ben@bagu.org>
2764 Add navigation buttons to related list tables.
2766 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2767 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2768 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2769 method getSuitableRecordToViewDetails() for getting the table name
2770 and primary key value for related list navigation buttons.
2771 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2772 private cell renderer class to get the navigation information for
2773 related list tables from the server. Extract the navigation
2774 processing code from the details cell navigation and use it for the
2775 related list navigation as well.
2776 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2777 cell renderer class for the details open buttons. This was needed
2778 because the related list navigation buttons and the list view
2779 navigation buttons need to react differently when clicked.
2780 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2781 the onEnterKeyDown() method because it's now overriden in the
2782 subclasses that are specific to the related list tables and the list
2784 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2785 the vertical size a little because the buttons add a bit of vertical
2786 space to table. This is not a perfect solution because the vertical
2787 size of with table fewer than 5 rows will be a little smaller.
2788 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2789 changes in how navigation buttons are handled.
2790 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2791 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2792 database access object.
2793 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2794 to find the portal for a given relationship name from
2795 RelatedListDBAccess. Add method to find a primary key field for a
2797 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2798 Move code to find the portal for a given relationship name to
2800 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2801 New file: database access object for getting the related list
2802 navigation information (the table name and the primary key value).
2803 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2804 DTO for transferring a table name to navigate to and a primary key
2806 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2807 boolean and getter/setter to specifies if the related list should add
2810 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2812 Use the master branch of java-libglom
2814 * pom.xml: Depend on java-libglom 1.19 instead.
2816 This is the master branch. See also the libglom-1-18 branch.
2818 2011-10-11 Ben Konrath <ben@bagu.org>
2820 Enable the open navigation button when the data has been set.
2822 This avoids having active buttons that don't do anything when the data
2825 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2827 2011-10-11 Ben Konrath <ben@bagu.org>
2829 Use IsWidget interface for FlowTableItem.
2831 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2832 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2834 2011-10-11 Ben Konrath <ben@bagu.org>
2836 Remove GWT styling from open button in details view.
2838 There are still some issues with how the details cell is arranged but
2839 this should be made to match Glom 1.20. I'm going to leave fixing this
2840 until I have Glom 1.20 up and running.
2842 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2843 style name on open button.
2844 * src/main/webapp/style.css: Move and edit details-navigation class.
2845 Re-arrange some classes to make them appear in the same order as the
2848 2011-10-07 Ben Konrath <ben@bagu.org>
2850 Update to GWT 2.4.0.
2852 * .gitignore: Ignore new cache directory.
2853 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2854 * pom.xml: Change GWT and maven plugin to 2.4.0.
2855 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2857 * src/main/java/org/glom/web/client/ClientFactory.java:
2858 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2859 * src/main/java/org/glom/web/client/OnlineGlom.java:
2860 Update source for API changes.
2861 * utils/build-onlineglom-war.sh: Remove cache directory before the
2864 2011-10-07 Ben Konrath <ben@bagu.org>
2866 Add navigation buttons in the details view.
2868 This isn't finished but I thought I'd commit what I have as it's a
2869 pretty good start. I still need to:
2871 1. Change the style so that it fits better into the current theme
2872 2. Adjust the details cell to expand as much as possible.
2874 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2875 click handlers to navigation buttons in the DetailsCells. Create a
2876 refreshData() method to get just the data from the server without the
2878 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2879 Update the tableSelector and browser title when the table name
2880 changes without using the tableSelector.
2881 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2882 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2883 getDetailsCells() to getCells(). Update variable names.
2884 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2885 method to set click handler on navigation button. Rename a few
2886 variables. Add navigation buttons where needed.
2887 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2888 variables and methods.
2889 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2890 navigation boolean and navigation table as required in the
2891 LayoutItemField DTO.
2892 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2893 variables for navigation along with getter/setter methods.
2895 2011-10-07 Ben Konrath <ben@bagu.org>
2897 Rename Field to DetailsCell.
2899 This is a refactor-only commit. No functionality has been added or
2902 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2903 Update variable and method names.
2904 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2905 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2906 variable and method names.
2907 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2909 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2910 variable and method names.
2912 2011-10-07 Ben Konrath <ben@bagu.org>
2914 Create separate methods for layout and data the details view.
2916 This is a refactor-only commit. No functionality has been added or
2919 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2920 private methods: setData(), createLayout().
2922 2011-10-07 Ben Konrath <ben@bagu.org>
2924 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2926 This is part of a change to get navigation buttons in the details view
2927 but it should have been done this way from the start.
2929 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2930 for method name change in TableSelectionView.
2931 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2932 Create TableChangeEvent and set the browser title using the
2933 TableSelectionView API.
2934 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2935 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2936 Change getSelectedTable() to getSelectedTableName(). Add
2937 getSelectedTableTitle().
2939 2011-10-07 Ben Konrath <ben@bagu.org>
2941 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2943 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2945 2011-10-07 Ben Konrath <ben@bagu.org>
2947 Update TableChangeEvent to use newTableName naming convention.
2949 This makes the class more consistent with GWT naming conventions.
2951 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2952 Update for method name change in TableChangeEvent.
2953 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2954 for method name change in TableChangeEvent.
2955 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2956 newTableName variable and getter method. Make toDebugString()
2959 2011-09-30 Ben Konrath <ben@bagu.org>
2961 Disable the pager in the list tables when the data row count is less than the minimum.
2963 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2964 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2966 2011-09-30 Ben Konrath <ben@bagu.org>
2968 Add empty rows to the end of related list and list view tables.
2970 I also extracted the cell rendering classes from the ListTable because
2971 the code was becoming a little crazy with all the anonymous inner
2972 classes. My plan is to use these cell rendering classes in the details
2973 view as well so this refactor will be needed for that change.
2975 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2976 set the row count in related list tables if the data has more rows
2977 than the minimum number of rows visible.
2978 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2979 row count in list view tables if the data has more rows than the
2980 minimum number of rows visible.
2981 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2982 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2984 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2985 for rendering TYPE_NUMERIC cells. The code was extracted from the
2987 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2988 class for rendering cells with buttons in list views. The code was
2989 extracted from the ListTable class.
2990 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2991 for rendering TYPE_TEXT cells. The code was extracted from the
2993 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2994 Add empty rows to the end of the data if required. Implement
2995 ListTable.getMinNumVisibleRows().
2996 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2997 cell renderer code to public classes. Return null in
2998 Column.getValue() for empty rows. Add new abstract method:
2999 getMinNumVisibleRows(). Move code to set the row count of the list view
3000 table to ListViewImpl.
3001 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3002 empty rows to the end of the data if required. Implement
3003 ListTable.getMinNumVisibleRows().
3006 2011-09-27 Ben Konrath <ben@bagu.org>
3008 Use GWT.log for client-side debugging statements.
3010 These are optimized out when deployed so I should have used this method
3011 in the first place. These statements will eventually be replaced with some sort
3012 of notification in the browser.
3014 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3015 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3016 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3017 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3018 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3020 2011-09-27 Ben Konrath <ben@bagu.org>
3022 Put tableselector on the right, back to list link on right.
3024 The idea is that the table selector is acting like a label for the
3025 currently displayed table so it should be placed below the document title. This
3026 puts the table title in a similar position to where it is in Glom.
3028 * mockups/details-contacts.html:
3029 * mockups/details-projects.html:
3030 * mockups/listview-contacts.html:
3031 * mockups/listview-projects.html:
3032 * mockups/style.css:
3033 Update mockups to match how the interfaces currently look.
3034 * src/main/webapp/style.css: Swap positions of backlink with the table
3035 selector. Add some space on the left side of the table selector to
3036 line things up with the document title.
3038 2011-09-27 Ben Konrath <ben@bagu.org>
3040 Add field colouring to details view.
3042 This change re-works how field colouring works. The colour formatting
3043 information is now set to the client with the layout information instead of
3044 with the data. This eliminates the need to send the same colour strings for
3045 data in list view column when colour information is set.
3047 In order to set an alternate colour for negative numeric values, the
3048 number is now sent to client and formatted with the GWT NumberFormat class.
3050 This change also fixes:
3052 https://bugzilla.gnome.org/show_bug.cgi?id=659752
3054 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
3055 internationalization framework which is needed for client side numeric
3057 * src/main/java/org/glom/web/client/Utils.java: New file for some
3058 client static utility methods.
3059 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3060 the DataItem object to the Field class. Use a utility method to
3061 create the foreignKeyValue string.
3062 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
3063 alignment and text colours in the constructor. Add setData(DataItem)
3064 method. Remove setText(String) method.
3065 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
3066 colour information to GlomTextCell. Create and use GlomNumberCell for
3067 rendering numbers. Use utility method to get the string for the
3068 primary key of the key provider. Re-work how the horizontal alignment
3070 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3071 formatting to layout information. Methods for converting the libglom
3072 formatting information were moved from DBAccess.
3073 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
3074 numeric formatting (it's now done on the client side). Don't set text
3075 colours in DataItem. Move libglom formatting conversion methods to
3077 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
3078 getters/setters for text colour information.
3079 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
3080 for transferring the libglom NumericFormat information to the client.
3081 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
3082 and getters/setters for: GlomNumericFormat, background colour and
3083 foreground colour strings.
3085 2011-09-26 Ben Konrath <ben@bagu.org>
3087 Simplify code that iterates through the LayoutGroup.
3089 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3091 2011-09-26 Ben Konrath <ben@bagu.org>
3093 Accept Eclipse formatting for OnlineGlomServiceAsync.
3095 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3097 2011-09-26 Ben Konrath <ben@bagu.org>
3099 Don't use the ListDBAccess classes to get the primary key layout information.
3101 This was causing a bug where the wrong index for the hidden primary key
3102 was being sent to the client.
3104 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
3105 primary key while creating the LayoutGroup DTO. Create a
3106 LayoutItemField DTO for hidden primary keys. Don't use the
3107 RelatedListDBAccess because it was only used for getting the primary
3109 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
3110 access modifier from public to protected for getPrimaryKeyField() and
3111 getPrimaryKeyLayoutItemField().
3112 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
3113 abstract method getExpectedResultSize() because RelatedListDBAccess
3114 doesn't have enough info to implement it.
3115 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3116 Remove @Override for getExpectedResultSize().
3117 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3118 Remove method getExpectedResultSize().
3120 2011-09-23 Ben Konrath <ben@bagu.org>
3122 Log which layout (list or details) the ignored item is from.
3124 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3126 2011-09-23 Ben Konrath <ben@bagu.org>
3128 Remove annotations that turn off code formatting in DataItem.
3130 * src/main/java/org/glom/web/shared/DataItem.java:
3132 2011-09-23 Ben Konrath <ben@bagu.org>
3134 Rename GlomField to DataItem and update associated methods.
3136 This is a rename-only refactor. No functionality has been added or
3139 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3140 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3141 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3142 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3143 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3144 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
3145 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3146 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3148 * src/main/java/org/glom/web/server/database/DBAccess.java:
3149 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3150 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3151 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3152 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3153 * src/main/java/org/glom/web/shared/DataItem.java:
3154 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
3155 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3157 2011-09-23 Ben Konrath <ben@bagu.org>
3159 Rename GlomDocument to DocumentInfo and update associated methods.
3161 This is a rename-only refactor. No functionality has been added or
3164 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3165 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3166 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3167 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3168 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
3169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3170 * src/main/java/org/glom/web/shared/DocumentInfo.java:
3172 2011-09-20 Ben Konrath <ben@bagu.org>
3174 Require java-libglom 1.17.3.
3176 This picks up the fix for the seg fault problem with the Scenes table
3177 in the Openismus Film Manager example.
3181 2011-09-20 Ben Konrath <ben@bagu.org>
3183 Change the way sort clause is added for primary key when no sort clause is requested.
3185 The primary key is now added to the LayoutFieldVector (fieldsToGet)
3186 before the sort clause is created. When a sort clause is not requested, the
3187 sort clause is created by finding the primary key in the LayoutFieldVector
3190 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3192 2011-09-20 Ben Konrath <ben@bagu.org>
3194 Log error message if no documents are found in the configured directory.
3196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3197 Extract the glom file extension string to a private static final class
3198 variable (mostly as syntactic sugar). Accept a minor formatting change.
3199 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3200 the example glom.document.directory configuration property to make it
3201 more clear that it can any directory, not just the home directory.
3203 2011-09-18 Ben Konrath <ben@bagu.org>
3205 Add related lists to details view.
3207 The related list table has support for paging and sorting just like the
3208 table in the list view.
3210 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3211 SQL queries for the related list tables.
3212 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3213 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3215 Rename getList methods to getListView and add comments. Remove
3216 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3217 it being unused. Add methods: getDetailsLayoutAndData(),
3218 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3219 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3220 Create the layout and set the data for the fields in one async call
3221 instead of two. Create related lists where appropriate.
3222 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3223 for method name changes in OnlineGlomService.
3224 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3225 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3226 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3228 * src/main/java/org/glom/web/client/ui/ListView.java:
3229 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3230 tableName from setCellTable(). Create a ListViewTable instead of
3232 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3233 represent a data field in the details view.
3234 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3235 from addDetailsCell() to Field class. Keep track of the Fields and
3236 Portals in the details view.
3237 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3238 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3239 and add a method to get it. Add method to set the contents of the
3241 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3242 New class for related list tables. This class has the data provider
3243 for the related list table.
3244 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3245 abstract class which is the base class for the ListViewTable and the
3247 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3248 New class for list view tables. This class has the data provider for
3249 the list view table.
3250 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3251 methods for related list tables. Add more information to the
3252 LayoutItemField and LayoutItemPortal DTOs.
3253 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3254 Remove debugging print statement.
3255 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3256 Remove debugging print statements. Add primary key field to SQL count
3258 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3259 Remove unnecessary LayoutFieldVector parameter from