1 2012-01-23 Murray Cumming <murrayc@murrayc.com>
3 ConfiguredDocument: Rename the localedID private member variable.
5 2012-01-23 Murray Cumming <murrayc@murrayc.com>
7 Adapt to the latest java-libglom API from git master.
9 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
10 libglom now uses only Vector instead of List, which uses add() instead of
13 2012-01-23 Murray Cumming <murrayc@murrayc.com>
15 Add and fill a Reports drop-down list box.
17 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
19 * src/main/java/org/glom/web/client/OnlineGlomService.java:
20 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
21 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
22 Added getReports(document, table, localeID), calling
23 ConfiguredDocument.getReports().
24 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
25 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
26 Added setReportsList() and a list widget.
27 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
28 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
30 2012-01-22 Murray Cumming <murrayc@murrayc.com>
32 ConfiguredDocument: Rename the localedID private member variable.
34 2012-01-20 Murray Cumming <murrayc@murrayc.com>
36 Build a source tarball with mvn assembly:single
38 * assembly.xml: Add this file.
39 * pom.xml: Use the maven-assembly-plugin and tell it to use
40 our assembly.xml file.
42 2012-01-19 Murray Cumming <murrayc@murrayc.com>
44 OnlineGlomServiceImpl: Get .glom files recursively.
46 * pom.xml: Depend on commons-io from org.apache.commons.
47 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
48 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
49 files recursively, and with the easier filter for the extension.
50 Use org.apache.commons.io.FilenameUtils.removeExtension() to
51 simplify that code too.
53 2012-01-19 Murray Cumming <murrayc@murrayc.com>
55 README: Mention that you must install java-libglom packages separately.
57 But then it works, because java-libglom is now in the central maven
60 2012-01-18 Murray Cumming <murrayc@murrayc.com>
62 locales drop-down: Show the correct selected locale when the URL changes.
64 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
65 .java: setPlace(): Move some code into fillView().
67 2012-01-18 Murray Cumming <murrayc@murrayc.com>
69 locales drop-down: Do not lose the primary key.
71 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
72 start(): onLocaleChange(): Pass the current primary key value,
73 instead of an empty value.
75 2012-01-18 Murray Cumming <murrayc@murrayc.com>
77 locales drop-down: Do not lose the drop-down selection.
79 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
80 .java (TableSelectionActivity.fillView): Set the selected locale
81 after changing the drop-down items (though we do not really need
82 to change them just because the locale changes.)
84 2012-01-18 Murray Cumming <murrayc@murrayc.com>
86 locales drop-down: Change the tables list when this changes.
88 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
89 .java: TableSelectionActivity.start(): Move the async table titles
90 retrieval into a private fillView() method and also call this when
91 the chosen locale changes.
92 Note that the document title is not actually translatable yet, but
93 that is a problem that I should fix soon in libglom.
95 2012-01-18 Murray Cumming <murrayc@murrayc.com>
97 Improve the placement of the locales drop-down.
99 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
100 Put the title and locales drop-down in a div (gwt.FlowTable).
101 * src/main/webapp/style.css: Add magic css properties to make this work.
102 Also remove the left margin from the title so that it lines up with the
105 2012-01-18 Murray Cumming <murrayc@murrayc.com>
107 locales selector: Show human-readable locale titles.
109 * src/main/java/org/glom/web/server/ConfiguredDocument.java
110 getDocumentInfo(): Use java.util.Locale to show a real title of
111 each locale, in the locale's own language.
113 2012-01-17 Murray Cumming <murrayc@murrayc.com>
115 Add a language/locale selector drop-down.
117 * src/main/java/org/glom/web/shared/DocumentInfo.java:
118 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
119 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
120 getDocumentInfo(): Store the available Locales in the DocumentInfo.
121 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
122 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
123 Add a ListBox to show the available locales. Add getLocaleSelector(),
124 setLocaleList(), getSelectedLocale(), setSelectedLocale().
125 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
126 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
127 java: Add these classes.
128 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
129 start(): Fill the locales ListBox. Handle its change event, firing a
131 setPlace(): Show the selected locale as specified by the URL token.
132 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
133 * src/main/java/org/glom/web/client/activity/ListActivity.java:
134 Handle LocaleChangeEvent, going to a new *Place with that locale.
136 The placement of the ListBox is not pretty, and it currently uses the ID
137 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
141 2012-01-17 Murray Cumming <murrayc@murrayc.com>
143 Search box: Show the search text from the URL token.
145 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
146 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
147 Add setQuickFindText().
148 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
149 .java: setPlace(): Store the queryText if the place is a ListPlace,
150 and call TableSelectionView.setQuickFindText().
152 2012-01-17 Murray Cumming <murrayc@murrayc.com>
154 Allow use of translations via, for instance, &lang=de in the URL.
156 * pom.xml: Use the unstable java-libglom 1.21 version.
158 * src/main/java/org/glom/web/client/OnlineGlomService.java:
159 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
161 init(): Instead of calling TranslatableItem.set_current_locale()
162 (now removed), call ConfiguredDocument.setDefaultLocaleID().
163 However, this is only for default locales, which are not needed to
164 change the locale in the URL.
165 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
166 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
167 getSortedRelatedListData(): Add a localeID parameter, so we can get the
168 layout for a particular locale.
169 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
170 Add get/setDefaultLocaleID().
171 getDocumentInfo(), getListViewData(), getRelatedListData(),
172 getDetailsLayoutGroup(), getListViewLayoutGroup(),
173 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
174 localeID parameter, so we can get the layout for a particular locale.
176 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
177 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
178 * src/main/java/org/glom/web/client/place/ListPlace.java:
179 Parse and construct a lang parameter too.
181 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
182 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
183 passed to subsequent methods and constructors.
184 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
185 * src/main/java/org/glom/web/client/activity/ListActivity.java:
186 Store the localeID from the *Place and pass it to other constructors
187 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
189 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
190 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
191 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
192 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
193 * src/main/java/org/glom/web/client/ui/ListView.java:
194 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
195 Take localeID parameters and pass them to subsequent constructors and
196 methods, so that the layout is always retrieved for that locale.
198 This is rather repetitive.
200 Note that "" means the original (default) locale of the Glom document,
201 which is usually English.
203 2012-01-17 Murray Cumming <murrayc@murrayc.com>
205 Documents: Remove final keyword to fix startup configuration.
207 * src/main/java/org/glom/web/shared/Documents.java: Remove the
208 final keywords on the private member variables because that breaks
209 the startup, apparently (there are warnings) because it stops them
210 from being serialized. I added these in the previous commit.
212 2012-01-13 Murray Cumming <murrayc@murrayc.com>
214 Documents: Add some final keywords.
216 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
219 2012-01-13 Murray Cumming <murrayc@murrayc.com>
221 OnlineGlomServiceImpl: Add to overview comments.
223 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
224 Note that this is where all the document are loaded. They are not
225 loaded freshly for each page.
227 2012-01-12 Murray Cumming <murrayc@murrayc.com>
231 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
232 Add a TextBox for the text of a quick find.
233 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
235 setBackLink(): Add a String quickFind parameter.
236 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
237 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
238 to the base interface, because that is how TableSelectionViewImpl is used.
239 * src/main/webapp/style.css: Add style for the search box and its label.
241 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
242 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
243 Add these files, based on the existing TableChangeEvent and
244 TableChangeEventHandlers.
245 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
246 start(): Handle QuickFindChangeEvent, passing its quickFind text to
247 a ListPlace() that the user should be taken to.
248 * src/main/java/org/glom/web/client/activity/ListActivity.java
249 start(): Handle it here too and adapt the TableChangeEvent handler to
250 pass the extra "" quickFind parameter to ListPlace.
251 * src/main/java/org/glom/web/client/place/ListPlace.java:
252 Constructor: Take an extra String quickFind parameter and store it,
253 returning it from a new getQuickFind() method.
254 getToken(): Put the quickFind text in the URL token.
255 getPlace(): Parse the quickFind text from the URL token.
256 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
257 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
258 ListPlace constructor.
259 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
260 .java: start(): Add a Change handler for the TableSelectionView's
261 TextBox (via its base HasChangeHandlers interface), firing the new
262 QuickFindChangeEvent.
263 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
264 pass the extra "" quickFind parameter.
266 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
267 setCellTable(): Add a String quickFind parameter and pass it to
268 the ListViewTable() constructor.
269 * src/main/java/org/glom/web/client/ui/ListView.java: Change
270 setCellTable() in the base interface, because that is how ListViewImpl
273 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
274 Add a String quickFind member variable.
275 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
276 Constructor: Add a String quickFind parameter, storing it in the
277 base ListTable's member variable.
278 onRangeChanged(): Pass quickFind to the
279 OnlineGlomServiceAsync.getSortedListViewData() and
280 OnlineGlomServiceAsync.getListViewData() methods.
282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
283 getListViewData(), getSortedListViewData(): Add a String quickFind
284 parameter, passing it to ConfiguredDocument.getListViewData().
285 * src/main/java/org/glom/web/client/OnlineGlomService.java:
286 Change getListViewData(), getSortedListViewData() in the base interface,
287 because that is how OnlineGlomServiceImpl is used, via this:
288 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
289 Change getListViewData(), getSortedListViewData() here too.
290 This class can apparently be used to asynchronously call methods on
291 OnlineGlomService, and GWT seems to implement that after recognizing
292 just the *Async name convention and the extra AsyncCallback parameters.
294 * src/main/java/org/glom/web/server/ConfiguredDocument.java
295 getListViewData(): Add a String quickFind parameter, and pass it to
296 ListViewDBAccess.getData().
297 * src/main/java/org/glom/web/server/database/ListDBAccess.java
298 getListData(): Add a String quickFind parameter and pass it to
300 getSelectQuery(): Add a String quickFind parameter.
301 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
302 getSelectQuery(): Add a String quickFind parameter and use it with
303 Glom.get_find_where_clause_quick() to pass a where_clause to
304 Glom.build_sql_select_with_where_clause(), to actually filter the
306 getData(): Add a String quickFind parameter, passing it to getListData().
307 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
308 va: getData(): Pass an empty string to getListData() for the
311 2012-01-12 Murray Cumming <murrayc@murrayc.com>
313 ListTable: Minor change.
315 * src/main/java/org/glom/web/client/ui/list/ListTable.java
316 createCellTable(): Make this protected instead of public.
318 2012-01-12 Murray Cumming <murrayc@murrayc.com>
320 Many files: Use final for the parameters and use the @override attribute.
322 2012-01-22 Ben Konrath <ben@bagu.org>
324 Add anchor links for single line text that starts with http, ftp and www.
328 2012-01-22 Ben Konrath <ben@bagu.org>
330 Add ellipsis to single line text in details view.
334 2012-01-04 Murray Cumming <murrayc@murrayc.com>
336 Remove all javadoc author tags.
338 Because they are awkward and meaningless when many people touch
340 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
342 2012-01-04 Murray Cumming <murrayc@murrayc.com>
344 Revert the COPYING.LESSER to COPYING rename.
346 Apparently both should be there if it is LGPL.
348 2012-01-03 Murray Cumming <murrayc@murrayc.com>
350 *View: Remove unused imports.
352 * src/main/java/org/glom/web/client/ui/DetailsView.java:
353 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
354 * src/main/java/org/glom/web/client/ui/ListView.java:
355 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
356 Remove unused imports, as suggested by Eclipse.
358 2012-01-02 Murray Cumming <murrayc@murrayc.com>
360 Move the *View::Presenter types, and some API into one base View.
362 * src/main/java/org/glom/web/client/ui/DetailsView.java:
363 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
364 * src/main/java/org/glom/web/client/ui/ListView.java:
365 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
366 Presenter, setPresenter() and clear() into a shared base interface,
367 to avoid the unnecessary duplicate Presenter types and to more clearly
368 show how the *Views share the same structure, even if they are not
369 used polymorphically.
371 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
372 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
374 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
375 * src/main/java/org/glom/web/client/activity/ListActivity.java:
376 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
378 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
381 Feel free to revert this if there is a good reason for the duplicate
384 2012-01-02 Murray Cumming <murrayc@murrayc.com>
386 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
388 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
389 a class member instead of a local variable in the method.
390 This lets us use it to get the view instances, for use in tests.
391 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
392 beforeOnlineGlom(): Test some more details of the initial view.
393 Again, this is not very useful.
395 To really test gwt-glom we will need to start a local postgresql
396 instance with local data, like the Glom tests in C++.
398 2012-01-02 Murray Cumming <murrayc@murrayc.com>
400 pom.xml: Mention the LGPL license.
402 * pom.xml: Add a licenses section.
403 * COPYING.LESSER: Move this to COPYING, which
404 previously contained the GPL. But gwt-glom is all LGPL.
406 2012-01-02 Murray Cumming <murrayc@murrayc.com>
408 Add project information to README and pom.xml.
410 * README: Add a brief description and mention some mvn
412 * pom.xml: This extra information shows up in mvn site
415 2011-01-02 Murray Cumming <murrayc@murrayc.com>
417 Use the latest java-libglom version.
419 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
421 2012-01-01 Murray Cumming <murrayc@murrayc.com>
423 GwtTestOnlineGlom: Test a little more.
425 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
426 protected rather than private, as suggested by the gwt-test-utils
428 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
429 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
430 Test the initial visibility of the panels.
432 However, this is not a very useful test.
433 And I wonder how we should generally test using this idea for an
434 activity/places app like ours where the real changes happen implicitly
435 based on the history token/URL.
437 2012-01-01 Murray Cumming <murrayc@murrayc.com>
439 Slight modification to *Mapper comments.
441 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
443 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
445 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
447 Remove comments mentioning GIN because they are just copied from
448 the example code and are apparently not helpful:
449 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
450 Also change the mention of a class that is only in the example code.
452 2012-01-01 Murray Cumming <murrayc@murrayc.com>
454 GwtTestOnlineGlom test: Minor changes.
456 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
457 Avoid the long qualified class name and modify the comment
458 because it is now obvious to me that the mocked class is the only
459 custom one created via GWT.create().
461 2012-01-01 Murray Cumming <murrayc@murrayc.com>
463 Tests: Added the beginnings of a test using gwt-test-utils.
465 * pom.xml: Add dependencies on gwt-test-utils and easymock.
466 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
467 which tells gwt-test-utils what class will be tested.
468 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
469 Add a simple (but empty) test case. One class, used by the OnlineGlom
470 class, is mocked so that it can be created. However, I am not sure
471 why only this class needs to be mocked.
473 Note that mockito seems more popular, and clearer, than easymock,
474 but I have not got that working yet. It might be a matter of the
477 This test is run during mvn integration-test.
479 2011-12-31 Murray Cumming <murrayc@murrayc.com>
481 Tests: Use junit4-style syntax instead of junit3-style.
483 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
484 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
485 * src/test/java/org/glom/web/shared/DataItemTest.java:
486 Use the @Test annotation rather than relying on the test*() prefix.
487 Also no longer implement TestCase, to avoid triggering support for
488 the junit3-way, which stops the annotations from working.
489 Change the imports from import junit.framework.* to
490 import org.junit.*, which is apparently the new way.
492 2011-12-31 Murray Cumming <murrayc@murrayc.com>
494 Added a test for ListPlace token parsing and creation.
496 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
497 This is much the same as DetailsPlaceTest.
499 I wonder how we could test the other parts of the *Place API.
501 2011-12-30 Murray Cumming <murrayc@murrayc.com>
503 DetailsPlace test: Also test getToken() and recreation via getPlace().
505 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
506 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
507 recreate it, testing the recreated DetailsPlace for the same parameter
510 2011-12-30 Murray Cumming <murrayc@murrayc.com>
512 Use the surefire-report plugin.
514 * pom.xml: This generates a HTML report about the tests in
515 target/site/surefire-report.html
516 when you do mvn surefire-report:report. It seems to be popular/normal.
518 2011-12-30 Murray Cumming <murrayc@murrayc.com>
520 Added a test for DetailsPlace.
522 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
523 Test the getPlace() token parsing.
525 2011-12-30 Murray Cumming <murrayc@murrayc.com>
527 Added a first unit test.
529 * pom.xml: Add a test goal, and a dependency on junit in that scope.
530 * src/test/java/org/glom/web/shared/DataItemTest.java:
531 This is a silly test but it is just to get things started. Note that
532 maven/junit finds the test because it looks in src/test by default.
534 2011-12-22 Ben Konrath <ben@bagu.org>
536 Change charsetName to "UTF-8" when replacing line breaks.
538 JavaScript requires the charsetName to be "UTF-8". CharsetName values
539 that work in Java (such as "UTF8") will not work when compiled to
542 This fixes a problem with multi-line details view fields that have hard
543 line breaks. The "License Text" field on this page demonstrates the
546 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
548 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
550 2011-12-22 Ben Konrath <ben@bagu.org>
552 Fix another bug with related list navigation.
554 I've tested all the navigation buttons in all of the related lists
555 so things should be good now.
557 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
559 2011-12-22 Ben Konrath <ben@bagu.org>
561 Fix a crasher when refreshing the list view with the default table.
563 This crash will also happen when loading the list view with the default
564 table from a link or bookmark.
566 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
567 to the main document selection page when the document id hasn't been
569 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
570 the main document selection page when the document id hasn't been
572 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
573 values for the details place when the document id hasn't been set.
574 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
575 values for the list place when the document id hasn't been set.
577 2011-12-21 Ben Konrath <ben@bagu.org>
579 Protect against NPE when glom.document.locale is not in config.
581 This patch protects against an NPE when glom.document.locale is not in
582 the config file. This NPE will also happen if glom.document.locale is
585 The patch also updates the error message to display the class name when
586 the getMessage() returns null. This was happening when the NPE was
587 thrown and I had "Configuration Error: null". If an NPE is encountered
588 with this patch, "Configuration Error: NullPointerException " will be
591 This commit closes this bug:
593 https://bugzilla.gnome.org/show_bug.cgi?id=666669
595 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
597 2011-12-20 Murray Cumming <murrayc@murrayc.com>
599 Rename onlineglom.properties to onlineglom.properties.sample.
601 * src/main/resources/onlineglom.properties: Rename to:
602 * src/main/resources/onlineglom.properties.sample:
603 * src/main/resources/README: And add this file explaining that people
604 should rename it back when deploying.
606 2011-12-20 Murray Cumming <murrayc@murrayc.com>
608 Allow choosing the translation in the .properties file.
610 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
611 init(): Read a glom.document.locale value from the configuration file
612 and call Glom's TransatableItem::set_current_locale() method.
613 * src/main/resources/onlineglom.properties: Add a commented-out
614 example of this new setting.
616 It would be better to add &lang=de_DE to the URL, but the current
617 libglom API does not allow us to do this easily. I am working on that.
619 2011-12-19 Murray Cumming <murrayc@murrayc.com>
621 Avoid a crash in parsing of token parameters.
623 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
624 ava: getTokenParams(): Do not crash if a parameter has a key but no
625 value, and ignore parameters with neither.
627 2011-12-17 Murray Cumming <murrayc@murayc.com>
629 History token building/handling: Improve use of token parameters.
631 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
632 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
633 and buildParamsToken(HashMap), for use by derived classes.
634 Make the separator private because it is no longer be needed.
635 * src/main/java/org/glom/web/client/place/DetailsPlace.java
636 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
637 instead of manual string concatenation.
638 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
639 of hardcoded indices and awkward splitting code.
640 * src/main/java/org/glom/web/client/place/ListPlace.java
641 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
642 instead of manual string concatenation.
643 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
644 of hardcoded indices and awkward splitting code.
645 This should fix bug #666420
647 2011-12-16 Murray Cumming <murrayc@murrayc.com>
649 Fix a Navgiation->Navigation typo in the code.
651 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
652 Rename processNavgiation() to processNavigation().
654 2011-12-16 Murray Cumming <murrayc@murrayc.com>
656 Fix a seperator->separator typo in the code.
658 * src/main/java/org/glom/web/client/place/DetailsPlace.java
659 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
660 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
663 2011-12-15 Ben Konrath <ben@bagu.org>
665 Cleanup some comments.
667 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
669 2011-12-14 Ben Konrath <ben@bagu.org>
671 Replace \n with <br/> for multiline text in the details view.
673 Vertical scrollbars are added when needed as well.
675 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
677 2011-12-14 Ben Konrath <ben@bagu.org>
679 Specify the font for document selection links.
681 * src/main/webapp/style.css:
683 2011-12-14 Ben Konrath <ben@bagu.org>
685 Fix bouncy CellTable while paging.
687 This doesn't currently work with related list tables in unselected
690 * src/main/java/org/glom/web/client/ui/list/ListTable.java
692 2011-12-14 Ben Konrath <ben@bagu.org>
694 Revamp the appearance of the document selection page.
696 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
697 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
698 * src/main/webapp/style.css:
700 2011-12-13 Ben Konrath <ben@bagu.org>
702 Set navigation button column to the smallest size possible.
704 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
706 2011-12-13 Ben Konrath <ben@bagu.org>
708 Change OpenButton nomenclature to NavigationButton.
710 Using NavigtionButton makes things more generic. Classes, methods and
711 variables have been changed.
713 This is a rename-only refactor.
715 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
716 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
717 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
718 Renamed from OpenButtonCell.
719 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
720 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
721 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
723 2011-12-12 Ben Konrath <ben@bagu.org>
725 Remove unnecessary String argument in RelatedListTable and ListViewTable.
727 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
728 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
729 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
730 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
732 2011-12-12 Ben Konrath <ben@bagu.org>
734 Update variable names and comments.
736 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
737 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
739 2011-12-12 Ben Konrath <ben@bagu.org>
741 Properly initialize numNonEmptyRows variable to zero.
743 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
744 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
746 2011-12-05 Ben Konrath <ben@bagu.org>
748 Add latest mockup with HTML tables.
750 Features of this mockup:
752 -> HTML table for flowtable
753 -> HTML table for flowtable column
754 -> Example of how related lists would look
755 -> Not using text entries for data items
757 The current version of Online Glom doesn't use HTML tables for the
760 This mockup has been sent to the glom-devel mailing list but it's good
761 to have it here as well.
763 * mockups/details-view-html-tables.html:
765 2011-12-05 Ben Konrath <ben@bagu.org>
767 Remove unnecessary getPrimaryKeyField() method.
769 getPrimaryKeyFieldForTable(String) has been renamed to
770 getPrimaryKeyField(String).
772 * src/main/java/org/glom/web/server/database/DBAccess.java:
773 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
774 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
776 2011-12-05 Ben Konrath <ben@bagu.org>
778 Add string representation of TypedDataItem value to conversion error message.
780 * src/main/java/org/glom/web/server/Utils.java: Logging the error
781 message was extracted into its own method to avoid duplication.
783 2011-12-05 Ben Konrath <ben@bagu.org>
785 Add type checking to navigation primary key value creation.
787 Create navigation primary key only if the expected type from the Glom
788 document matches the type returned by the SQL query.
790 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
792 2011-12-05 Ben Konrath <ben@bagu.org>
794 Rename a couple of variables in RelatedListNavigation.
796 This is a rename-only refactor.
798 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
800 2011-12-05 Ben Konrath <ben@bagu.org>
802 Move getListLayoutGroup() into getListViewLayoutGroup().
804 This removes getListLayoutGroup(). It was only being called by
805 getListViewLayoutGroup().
807 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
809 2011-12-05 Ben Konrath <ben@bagu.org>
811 Remove check for LayoutItem_Portal in list table method.
813 This check is no longer necessary because the method isn't being used
814 to create the LayoutItemPortal DTO.
816 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
818 2011-12-05 Ben Konrath <ben@bagu.org>
820 Properly support related list navigation.
822 Navigation from the "Repository Analyzer -> Package Scans ->
823 Dependencies" related table wasn't working because the primary key for
824 related tables wasn't being set properly. This commit fixes the
827 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
828 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
829 doesn't set the primary key properly for related list tables.
830 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
831 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
832 useful for getting the primary key for list view tables and for related
834 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
835 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
836 Move code to set the primary key for the table from the abstract
837 ListDBAccess class to ListViewDBAccess as it's only correct for list
839 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
840 Properly add primary key to related list tables.
842 2011-12-02 Ben Konrath <ben@bagu.org>
844 Properly set the horizontal alignment of fields.
846 This fix is for both the list tables and the details view.
848 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
849 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
850 to set the horizontal alignment of fields.
852 2011-12-02 Ben Konrath <ben@bagu.org>
854 Display currency codes in the details view.
856 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
858 2011-12-02 Ben Konrath <ben@bagu.org>
860 Avoid duplicate JNI call.
862 JNI is not as efficient as pure Java and this is an easy (and small)
865 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
866 Use previously retrieved value for whereClauseToTableName instead of
869 2011-12-02 Ben Konrath <ben@bagu.org>
871 Rename a couple of variables in RelatedListNavigation.
873 This is a rename-only refactor.
875 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
877 2011-12-02 Ben Konrath <ben@bagu.org>
879 Indicate clearly that a mismatched primary key type is a bug.
881 * src/main/java/org/glom/web/server/Utils.java: Change log level from
882 warning to error. Add 'This is a bug.' to message.
884 2011-12-02 Ben Konrath <ben@bagu.org>
886 Update / fix some comments.
888 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
890 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
892 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
893 Fix comments. Add some TODOs.
895 2011-12-02 Ben Konrath <ben@bagu.org>
897 Enable navigation to details view with string primary key from related list.
899 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
900 Create a text primary key value when return type of result is
901 java.sql.Types.VARCHAR.
903 2011-12-02 Ben Konrath <ben@bagu.org>
905 Use checkboxes for booleans in the details view.
907 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
909 2011-12-01 Ben Konrath <ben@bagu.org>
911 Improve performance of related list height calculation.
913 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
914 Put code to calculate the expected height in a static initializer so
915 that that it's only called once.
917 2011-12-01 Ben Konrath <ben@bagu.org>
919 Show related list tables in notebooks (again).
921 Calculate the height of the related list tables so the Notebook can be
922 set the correct height. The height of the related list table is also needed by
923 FlowTable to be able decide how to create the layout.
925 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
926 and set the Portal height based on the height of the related list
927 table and the Portal container.
928 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
929 Add method to calculate the height of the related list tables.
930 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
931 * src/main/webapp/style.css: Add css class for Pager. This is needed to
932 calculate the height of the Pager widget.
934 2011-12-01 Ben Konrath <ben@bagu.org>
936 Use CellTable API for table property instead of setting style on Element.
938 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
940 2011-12-01 Ben Konrath <ben@bagu.org>
942 Make ListViewTable and RelatedListTable a consistent height.
944 The tables are now a consistent height regardless of the contents of
945 the table. A hidden button is added to empty rows to ensure that the
946 height of these rows will match the height of rows with data.
948 A navigation button column is now added to every table. The width of
949 the navigation column is set to 0px when a RelatedListTable shouldn't
950 have navigation buttons. This maintains the a consistent row height in
951 tables that don't show the navigation buttons.
953 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
954 navigation column when not needed.
955 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
956 arguments for navigation button to constructor of ListViewTable.
957 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
958 hidden button for empty data rows.
959 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
960 arguments for navigation button to constructor.
961 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
962 create navigation buttons. Add hideNavigationButtons() method.
963 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
964 arguments for navigation button to constructor.
966 2011-12-01 Ben Konrath <ben@bagu.org>
968 Use 'visibility: hidden' in Utils.getWidgetHeight().
970 This is better choice because hidden elements are invisible, don't
971 respond to events and are not part of the tab order. They will,
972 however, take up space which is required to be able to calculate the
973 height of the widget.
975 * src/main/java/org/glom/web/client/Utils.java:
977 2011-12-01 Ben Konrath <ben@bagu.org>
979 Use Utils.getWidgetHeight() in FlowTable.
981 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
983 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
985 2011-12-01 Ben Konrath <ben@bagu.org>
987 Put the details css class name on the correct table column.
989 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
991 2011-11-30 Ben Konrath <ben@bagu.org>
993 Update for java-libglom API change.
995 The getters and setters on FieldFormatting and NumericFormat were
996 changed to remove the 'M'.
998 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1000 2011-11-29 Ben Konrath <ben@bagu.org>
1002 Only allow RelatedListTables in Portals.
1004 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1006 2011-11-29 Ben Konrath <ben@bagu.org>
1008 Only create a contents panel for Portals when title is being set.
1010 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1012 2011-11-29 Ben Konrath <ben@bagu.org>
1014 Set TabLayoutPanel height based on calculated height its widgets.
1016 This is a potential fix for this bug:
1018 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1020 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1022 2011-11-29 Ben Konrath <ben@bagu.org>
1024 Align details field labels and data with the Open buttons.
1026 * src/main/webapp/style.css:
1028 2011-11-29 Ben Konrath <ben@bagu.org>
1030 Remove unnecessary <div> in the Notebook widget.
1032 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1033 method to get container FlowPanel (<div>).
1034 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1035 initWidget() method directly on the TabLayoutPanel widget instead of
1036 Group's container widget.
1038 2011-11-29 Ben Konrath <ben@bagu.org>
1040 Don't add group titles for Portals in Notebooks.
1042 This reverts the previous patch and fixes a bug I introduced with
1043 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1045 * src/main/java/org/glom/web/client/ui/details/Group.java:
1046 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1048 2011-11-28 Ben Konrath <ben@bagu.org>
1050 Remove unused boolean argument in Portal constructor.
1052 Just a code cleanup.
1054 * src/main/java/org/glom/web/client/ui/details/Group.java:
1055 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1057 2011-11-28 Ben Konrath <ben@bagu.org>
1059 Remove hack for glom 1.18 style glom files.
1061 * src/main/java/org/glom/web/client/ui/details/Group.java:
1062 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1063 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1065 2011-11-28 Ben Konrath <ben@bagu.org>
1067 Use Gda Value version of primary key to log result too large error.
1069 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1071 2011-11-28 Ben Konrath <ben@bagu.org>
1073 Don't use TypedDataItem.getText() for Unknown types from the URL.
1075 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1076 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1077 instead of getText().
1078 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1079 String field and getUnknown() method.
1081 2011-11-28 Ben Konrath <ben@bagu.org>
1083 Log an error message when the java-libglom .so is not present.
1085 The error message was being set in the exception but not logged.
1087 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1089 2011-11-28 Ben Konrath <ben@bagu.org>
1091 Ignore LayoutItem_CalendarPortals.
1093 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1094 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1096 2011-11-28 Ben Konrath <ben@bagu.org>
1098 Extract method for creating the LayoutItemPortal DTO.
1100 Just breaking the code up into smaller chunks.
1102 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1104 2011-11-28 Ben Konrath <ben@bagu.org>
1108 This should have been added with the refactor. Oops!
1110 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1112 2011-11-28 Ben Konrath <ben@bagu.org>
1114 Create primary key value from URL string using type from Glom document.
1116 See this bug, comments 19 - 25:
1118 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1120 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1121 create a TypeDataItem for the primary key here when loading from a
1122 URL. Show the same string for the primary key value as was received
1123 from the URL string (when loading from a URL).
1124 * src/main/java/org/glom/web/server/Utils.java: Update method for
1125 creating the Gda Value from the TypeDataItem to properly deal with
1126 creating a Gda Value based on the Glom document type for the primary
1127 key value string when loading from a URL.
1128 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1129 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1130 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1131 Update for changed method name.
1133 2011-11-27 Ben Konrath <ben@bagu.org>
1135 Rename PrimaryKeyItem to TypedDataItem.
1137 The name PrimaryKeyItem suggests what the class should be used for.
1138 TypedDataItem is a neutral name that describes the class better.
1140 This is a rename-only refactor.
1142 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1143 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1144 * src/main/java/org/glom/web/client/Utils.java:
1145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1146 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1147 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1148 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1149 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1150 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1152 * src/main/java/org/glom/web/server/Utils.java:
1153 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1154 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1155 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1156 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1158 2011-11-25 Ben Konrath <ben@bagu.org>
1160 Improve Gda Value conversion from PrimaryKeyItem.
1162 The value from the PrimaryKeyItem is only used if its type match the
1163 type from the glom document.
1165 * src/main/java/org/glom/web/server/Utils.java:
1167 2011-11-25 Ben Konrath <ben@bagu.org>
1169 Manually check if the java-liblgom .so is visible to the JVM.
1171 It seems that Tomcat has problems when a static initializer throws an
1172 exception. This check is done before the first method call into
1173 java-libglom so that execution doesn't continue if the .so is not
1176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1178 2011-11-25 Ben Konrath <ben@bagu.org>
1180 Improve browser configuration error messages.
1184 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1186 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1187 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1188 getConfigurationErrorMessage() method.
1189 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1190 Get and display a specific configuration error message when no Glom
1191 documents are found.
1192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1193 Implement getConfigurationErrorMessage() method. Surround configuration
1194 code in the init() method with a try/catch block. This allows the
1195 errors to be caught while keeping the servlet available to retrieve the
1196 configuration error message.
1198 2011-11-25 Ben Konrath <ben@bagu.org>
1200 Don't use Strings to hold primary key values.
1202 The primary key values are now held in a new data object
1203 (PrimaryKeyItem) that holds type information and the primary key value
1204 using the correct type.
1206 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1207 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1208 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1209 PrimaryKeyItem instead of String to hold the primary key value.
1210 * src/main/java/org/glom/web/client/Utils.java: Remove
1211 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1212 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1213 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1214 PrimaryKeyItem instead of String to hold the primary key value. Load
1215 document selection page when the documentID has not been set correctly.
1216 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1217 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1219 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1220 Return empty string for URL instead of "null".
1221 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1222 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1223 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1224 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1225 PrimaryKeyItem instead of String to hold primary key values.
1226 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1227 PrimaryKeyValue to a Gda Value.
1228 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1229 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1230 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1231 Replace temporary database access code that uses the PrimaryKeyValue to
1232 Gda Value conversion.
1233 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1234 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1235 PrimaryKeyItem instead of String.
1236 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1237 hold primary key values.
1239 2011-11-24 Ben Konrath <ben@bagu.org>
1241 Use newly added java-libglom API to create queries.
1243 This isn't finished. I still need to stop using Strings for primary key
1244 values in the client code.
1246 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1247 libglom to use fake connections so that retrieving the query string will
1249 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1250 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1251 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1252 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1253 Use the newly added libglom sql methods and classes to create the
1254 query. Add temporary hack to convert primary value strings to Gda
1257 2011-11-23 Ben Konrath <ben@bagu.org>
1259 Don't explicitly set the height of Portals.
1261 See comments 6 - 10 of this bug for details:
1263 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1265 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1267 2011-11-23 Ben Konrath <ben@bagu.org>
1269 Use an HTML table instead of CSS for the FlowTable layout.
1271 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1272 GWT's FlexTable to implement the FlowTable.
1273 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1275 2011-11-18 Ben Konrath <ben@bagu.org>
1277 Add boolean example to HTML table mockup.
1279 * mockups/details-view-html-tables-text-entries.html:
1281 2011-11-17 Ben Konrath <ben@bagu.org>
1283 Ensure the pager buttons are always visible for related lists.
1285 To accomplish this, I've turned off text wrapping in the list view and
1286 related list tables for both the header and data text. The related list
1287 table now has a fixed layout so the it doesn't overflow its container.
1288 This is required to ensure that the cell text is clipped when it
1289 overflows the cell and an ellipsis is added to the right side of the
1290 cell when text is clipped.
1292 A fixed table layout for the related list table in the details view
1293 seems what we want for the details view anyway, so the side-effect is
1296 The ellipsis will only be displayed in Firefox >= 7.
1300 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1302 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1303 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1304 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1306 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1307 Set the 'table-layout: fixed' CSS property to the related list table.
1308 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1309 'white-space: nowrap;' CSS property on both the list view and the
1310 related list tables.
1312 2011-11-16 Ben Konrath <ben@bagu.org>
1314 Rework the fix for empty notebook tab labels.
1316 Setting the empty group titles with its name caused problems for the
1317 details layout. Instead of using libglom's
1318 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1319 to the client when the title is empty. This allows the Notebook to use
1320 the name when the title is empty without affecting anything else.
1322 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1323 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1325 2011-11-16 Ben Konrath <ben@bagu.org>
1327 Set group titles with name when title is empty.
1329 This fixes a problem with an empty notebook tab label in the Lesson
1330 Planner document. The forth tab in the notebook should be "Internet":
1332 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1334 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1335 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1338 2011-11-16 Ben Konrath <ben@bagu.org>
1340 Remove whitespace from the configured username properties.
1342 This assumes that usernames won't have whitespace at the beginning
1343 or end. But I think this is a reasonable assumption.
1345 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1346 String.trim() to remove the whitespace from the username properties.
1348 2011-11-15 Ben Konrath <ben@bagu.org>
1350 Add details view mockup with HTML tables and text entries.
1352 This is from the attachment on this bug:
1354 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1356 * mockups/details-view-html-tables-text-entries.html:
1358 2011-11-15 Ben Konrath <ben@bagu.org>
1360 Add space between the columns of the flow table.
1364 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1366 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1367 space between columns in the flow table.
1369 2011-11-15 Ben Konrath <ben@bagu.org>
1371 Add backup files to the .gitignore.
1373 * .gitignore: Ignore files that end with ~.
1375 2011-11-09 Ben Konrath <ben@bagu.org>
1377 Use latest release of gwt-log.
1379 Gwt-log releases are now being submitted to the maven central
1380 repository so manual installation of the jar is no longer required.
1382 * pom.xml: Update version and groupId of gwt-log dependency.
1384 2011-10-31 Ben Konrath <ben@bagu.org>
1386 Don't use GWT numeric formatting to override the glom currency formatting.
1388 Currencies are now displayed like they are in Glom. See this bug:
1390 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1392 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1394 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1395 currency code to constructor and set it when the cell is rendered.
1396 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1397 currency code to the constructor of the NumericCell.
1399 2011-10-27 Ben Konrath <ben@bagu.org>
1401 Require the latest release of java-libglom (1.17.4).
1405 2011-10-26 Ben Konrath <ben@bagu.org>
1407 Add style to Notebook that matches current theme.
1409 It's not the best style in the world but it's better than the default.
1411 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1412 padding at the bottom of the child widgets.
1413 * src/main/webapp/style.css: Add style for the Notebook.
1415 2011-10-26 Ben Konrath <ben@bagu.org>
1417 Move servlet initialization code to overridden init method.
1419 This is half of the solution to getting proper error messages
1420 displayed when configuration errors occur. Here's the relevant bug:
1422 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1424 The rest of the solution involves surrounding the init method with a
1425 try/catch block and setting a global variable with the error /
1426 exception. A new async method should be created to retrieve and display
1427 the error message / exception.
1429 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1430 code from constructor to init method adding exceptions as needed.
1432 2011-10-26 Ben Konrath <ben@bagu.org>
1434 Add script to monitor and restart tomcat if required.
1436 * utils/check-and-recover-tomcat.py: New file.
1438 2011-10-26 Ben Konrath <ben@bagu.org>
1440 Display the correct number of data items in the pager.
1444 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1446 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1447 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1448 The implementation is the same for both tables: Keep track of the
1449 number of non-empty rows and fire and RowCountChangeEvent after the data has
1451 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1452 custom Pager class that subclasses SimplePager to handle displaying
1453 the correct number when empty rows have been added.
1455 2011-10-26 Ben Konrath <ben@bagu.org>
1457 Correct error in previous commit.
1459 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1460 eventBus parameter from listView.setCellTable().
1462 2011-10-26 Ben Konrath <ben@bagu.org>
1464 Fix error in TODO comment.
1466 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1468 2011-10-24 Ben Konrath <ben@bagu.org>
1470 Create Notebook widgets to the details view.
1472 This isn't finished just yet - I still need to create a reasonable
1473 style to match the current theme.
1475 * src/main/java/org/glom/web/client/Utils.java: Add method for
1476 calculating the height of a widget. This is used in the Notebook class.
1477 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1478 new constructor method in Group.
1479 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1480 method for creating child widget that can be used by subclasses
1481 like Notebook. New constructor that allows disabling the group
1482 titles - Notebooks don't set a group title for their child groups.
1483 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1484 to make Notebooks using GWT's TabLayoutPanel.
1485 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1486 constructor that allows disabling the group titles.
1487 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1488 LayoutItemNotebook DTO.
1489 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1490 DTO for Notebooks. It's just an empty class for now but we might need
1491 it to transfer some specific information in the future.
1493 2011-10-21 Ben Konrath <ben@bagu.org>
1495 Add navigation buttons to related list tables.
1497 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1498 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1500 method getSuitableRecordToViewDetails() for getting the table name
1501 and primary key value for related list navigation buttons.
1502 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1503 private cell renderer class to get the navigation information for
1504 related list tables from the server. Extract the navigation
1505 processing code from the details cell navigation and use it for the
1506 related list navigation as well.
1507 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1508 cell renderer class for the details open buttons. This was needed
1509 because the related list navigation buttons and the list view
1510 navigation buttons need to react differently when clicked.
1511 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1512 the onEnterKeyDown() method because it's now overriden in the
1513 subclasses that are specific to the related list tables and the list
1515 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1516 the vertical size a little because the buttons add a bit of vertical
1517 space to table. This is not a perfect solution because the vertical
1518 size of with table fewer than 5 rows will be a little smaller.
1519 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1520 changes in how navigation buttons are handled.
1521 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1522 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1523 database access object.
1524 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1525 to find the portal for a given relationship name from
1526 RelatedListDBAccess. Add method to find a primary key field for a
1528 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1529 Move code to find the portal for a given relationship name to
1531 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1532 New file: database access object for getting the related list
1533 navigation information (the table name and the primary key value).
1534 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1535 DTO for transferring a table name to navigate to and a primary key
1537 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1538 boolean and getter/setter to specifies if the related list should add
1541 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1543 Use the master branch of java-libglom
1545 * pom.xml: Depend on java-libglom 1.19 instead.
1547 This is the master branch. See also the libglom-1-18 branch.
1549 2011-10-11 Ben Konrath <ben@bagu.org>
1551 Enable the open navigation button when the data has been set.
1553 This avoids having active buttons that don't do anything when the data
1556 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1558 2011-10-11 Ben Konrath <ben@bagu.org>
1560 Use IsWidget interface for FlowTableItem.
1562 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1563 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1565 2011-10-11 Ben Konrath <ben@bagu.org>
1567 Remove GWT styling from open button in details view.
1569 There are still some issues with how the details cell is arranged but
1570 this should be made to match Glom 1.20. I'm going to leave fixing this
1571 until I have Glom 1.20 up and running.
1573 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1574 style name on open button.
1575 * src/main/webapp/style.css: Move and edit details-navigation class.
1576 Re-arrange some classes to make them appear in the same order as the
1579 2011-10-07 Ben Konrath <ben@bagu.org>
1581 Update to GWT 2.4.0.
1583 * .gitignore: Ignore new cache directory.
1584 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1585 * pom.xml: Change GWT and maven plugin to 2.4.0.
1586 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1588 * src/main/java/org/glom/web/client/ClientFactory.java:
1589 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1590 * src/main/java/org/glom/web/client/OnlineGlom.java:
1591 Update source for API changes.
1592 * utils/build-onlineglom-war.sh: Remove cache directory before the
1595 2011-10-07 Ben Konrath <ben@bagu.org>
1597 Add navigation buttons in the details view.
1599 This isn't finished but I thought I'd commit what I have as it's a
1600 pretty good start. I still need to:
1602 1. Change the style so that it fits better into the current theme
1603 2. Adjust the details cell to expand as much as possible.
1605 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1606 click handlers to navigation buttons in the DetailsCells. Create a
1607 refreshData() method to get just the data from the server without the
1609 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1610 Update the tableSelector and browser title when the table name
1611 changes without using the tableSelector.
1612 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1613 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1614 getDetailsCells() to getCells(). Update variable names.
1615 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1616 method to set click handler on navigation button. Rename a few
1617 variables. Add navigation buttons where needed.
1618 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1619 variables and methods.
1620 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1621 navigation boolean and navigation table as required in the
1622 LayoutItemField DTO.
1623 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1624 variables for navigation along with getter/setter methods.
1626 2011-10-07 Ben Konrath <ben@bagu.org>
1628 Rename Field to DetailsCell.
1630 This is a refactor-only commit. No functionality has been added or
1633 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1634 Update variable and method names.
1635 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1636 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1637 variable and method names.
1638 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1640 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1641 variable and method names.
1643 2011-10-07 Ben Konrath <ben@bagu.org>
1645 Create separate methods for layout and data the details view.
1647 This is a refactor-only commit. No functionality has been added or
1650 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1651 private methods: setData(), createLayout().
1653 2011-10-07 Ben Konrath <ben@bagu.org>
1655 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1657 This is part of a change to get navigation buttons in the details view
1658 but it should have been done this way from the start.
1660 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1661 for method name change in TableSelectionView.
1662 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1663 Create TableChangeEvent and set the browser title using the
1664 TableSelectionView API.
1665 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1666 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1667 Change getSelectedTable() to getSelectedTableName(). Add
1668 getSelectedTableTitle().
1670 2011-10-07 Ben Konrath <ben@bagu.org>
1672 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1674 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1676 2011-10-07 Ben Konrath <ben@bagu.org>
1678 Update TableChangeEvent to use newTableName naming convention.
1680 This makes the class more consistent with GWT naming conventions.
1682 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1683 Update for method name change in TableChangeEvent.
1684 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1685 for method name change in TableChangeEvent.
1686 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1687 newTableName variable and getter method. Make toDebugString()
1690 2011-09-30 Ben Konrath <ben@bagu.org>
1692 Disable the pager in the list tables when the data row count is less than the minimum.
1694 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1695 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1697 2011-09-30 Ben Konrath <ben@bagu.org>
1699 Add empty rows to the end of related list and list view tables.
1701 I also extracted the cell rendering classes from the ListTable because
1702 the code was becoming a little crazy with all the anonymous inner
1703 classes. My plan is to use these cell rendering classes in the details
1704 view as well so this refactor will be needed for that change.
1706 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1707 set the row count in related list tables if the data has more rows
1708 than the minimum number of rows visible.
1709 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1710 row count in list view tables if the data has more rows than the
1711 minimum number of rows visible.
1712 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1713 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1715 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1716 for rendering TYPE_NUMERIC cells. The code was extracted from the
1718 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1719 class for rendering cells with buttons in list views. The code was
1720 extracted from the ListTable class.
1721 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1722 for rendering TYPE_TEXT cells. The code was extracted from the
1724 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1725 Add empty rows to the end of the data if required. Implement
1726 ListTable.getMinNumVisibleRows().
1727 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1728 cell renderer code to public classes. Return null in
1729 Column.getValue() for empty rows. Add new abstract method:
1730 getMinNumVisibleRows(). Move code to set the row count of the list view
1731 table to ListViewImpl.
1732 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1733 empty rows to the end of the data if required. Implement
1734 ListTable.getMinNumVisibleRows().
1737 2011-09-27 Ben Konrath <ben@bagu.org>
1739 Use GWT.log for client-side debugging statements.
1741 These are optimized out when deployed so I should have used this method
1742 in the first place. These statements will eventually be replaced with some sort
1743 of notification in the browser.
1745 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1746 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1747 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1748 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1749 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1751 2011-09-27 Ben Konrath <ben@bagu.org>
1753 Put tableselector on the right, back to list link on right.
1755 The idea is that the table selector is acting like a label for the
1756 currently displayed table so it should be placed below the document title. This
1757 puts the table title in a similar position to where it is in Glom.
1759 * mockups/details-contacts.html:
1760 * mockups/details-projects.html:
1761 * mockups/listview-contacts.html:
1762 * mockups/listview-projects.html:
1763 * mockups/style.css:
1764 Update mockups to match how the interfaces currently look.
1765 * src/main/webapp/style.css: Swap positions of backlink with the table
1766 selector. Add some space on the left side of the table selector to
1767 line things up with the document title.
1769 2011-09-27 Ben Konrath <ben@bagu.org>
1771 Add field colouring to details view.
1773 This change re-works how field colouring works. The colour formatting
1774 information is now set to the client with the layout information instead of
1775 with the data. This eliminates the need to send the same colour strings for
1776 data in list view column when colour information is set.
1778 In order to set an alternate colour for negative numeric values, the
1779 number is now sent to client and formatted with the GWT NumberFormat class.
1781 This change also fixes:
1783 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1785 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1786 internationalization framework which is needed for client side numeric
1788 * src/main/java/org/glom/web/client/Utils.java: New file for some
1789 client static utility methods.
1790 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1791 the DataItem object to the Field class. Use a utility method to
1792 create the foreignKeyValue string.
1793 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1794 alignment and text colours in the constructor. Add setData(DataItem)
1795 method. Remove setText(String) method.
1796 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1797 colour information to GlomTextCell. Create and use GlomNumberCell for
1798 rendering numbers. Use utility method to get the string for the
1799 primary key of the key provider. Re-work how the horizontal alignment
1801 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1802 formatting to layout information. Methods for converting the libglom
1803 formatting information were moved from DBAccess.
1804 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1805 numeric formatting (it's now done on the client side). Don't set text
1806 colours in DataItem. Move libglom formatting conversion methods to
1808 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1809 getters/setters for text colour information.
1810 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1811 for transferring the libglom NumericFormat information to the client.
1812 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1813 and getters/setters for: GlomNumericFormat, background colour and
1814 foreground colour strings.
1816 2011-09-26 Ben Konrath <ben@bagu.org>
1818 Simplify code that iterates through the LayoutGroup.
1820 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1822 2011-09-26 Ben Konrath <ben@bagu.org>
1824 Accept Eclipse formatting for OnlineGlomServiceAsync.
1826 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1828 2011-09-26 Ben Konrath <ben@bagu.org>
1830 Don't use the ListDBAccess classes to get the primary key layout information.
1832 This was causing a bug where the wrong index for the hidden primary key
1833 was being sent to the client.
1835 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1836 primary key while creating the LayoutGroup DTO. Create a
1837 LayoutItemField DTO for hidden primary keys. Don't use the
1838 RelatedListDBAccess because it was only used for getting the primary
1840 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1841 access modifier from public to protected for getPrimaryKeyField() and
1842 getPrimaryKeyLayoutItemField().
1843 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1844 abstract method getExpectedResultSize() because RelatedListDBAccess
1845 doesn't have enough info to implement it.
1846 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1847 Remove @Override for getExpectedResultSize().
1848 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1849 Remove method getExpectedResultSize().
1851 2011-09-23 Ben Konrath <ben@bagu.org>
1853 Log which layout (list or details) the ignored item is from.
1855 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1857 2011-09-23 Ben Konrath <ben@bagu.org>
1859 Remove annotations that turn off code formatting in DataItem.
1861 * src/main/java/org/glom/web/shared/DataItem.java:
1863 2011-09-23 Ben Konrath <ben@bagu.org>
1865 Rename GlomField to DataItem and update associated methods.
1867 This is a rename-only refactor. No functionality has been added or
1870 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1871 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1872 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1873 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1874 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1875 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1876 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1877 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1878 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1879 * src/main/java/org/glom/web/server/database/DBAccess.java:
1880 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1881 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1882 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1883 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1884 * src/main/java/org/glom/web/shared/DataItem.java:
1885 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1886 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1888 2011-09-23 Ben Konrath <ben@bagu.org>
1890 Rename GlomDocument to DocumentInfo and update associated methods.
1892 This is a rename-only refactor. No functionality has been added or
1895 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1896 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1897 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1898 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1899 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1900 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1901 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1903 2011-09-20 Ben Konrath <ben@bagu.org>
1905 Require java-libglom 1.17.3.
1907 This picks up the fix for the seg fault problem with the Scenes table
1908 in the Openismus Film Manager example.
1912 2011-09-20 Ben Konrath <ben@bagu.org>
1914 Change the way sort clause is added for primary key when no sort clause is requested.
1916 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1917 before the sort clause is created. When a sort clause is not requested, the
1918 sort clause is created by finding the primary key in the LayoutFieldVector
1921 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1923 2011-09-20 Ben Konrath <ben@bagu.org>
1925 Log error message if no documents are found in the configured directory.
1927 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1928 Extract the glom file extension string to a private static final class
1929 variable (mostly as syntactic sugar). Accept a minor formatting change.
1930 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1931 the example glom.document.directory configuration property to make it
1932 more clear that it can any directory, not just the home directory.
1934 2011-09-18 Ben Konrath <ben@bagu.org>
1936 Add related lists to details view.
1938 The related list table has support for paging and sorting just like the
1939 table in the list view.
1941 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1942 SQL queries for the related list tables.
1943 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1944 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1945 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1946 Rename getList methods to getListView and add comments. Remove
1947 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1948 it being unused. Add methods: getDetailsLayoutAndData(),
1949 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1950 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1951 Create the layout and set the data for the fields in one async call
1952 instead of two. Create related lists where appropriate.
1953 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1954 for method name changes in OnlineGlomService.
1955 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1956 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1957 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1959 * src/main/java/org/glom/web/client/ui/ListView.java:
1960 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1961 tableName from setCellTable(). Create a ListViewTable instead of
1963 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1964 represent a data field in the details view.
1965 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1966 from addDetailsCell() to Field class. Keep track of the Fields and
1967 Portals in the details view.
1968 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1969 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1970 and add a method to get it. Add method to set the contents of the
1972 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1973 New class for related list tables. This class has the data provider
1974 for the related list table.
1975 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1976 abstract class which is the base class for the ListViewTable and the
1978 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1979 New class for list view tables. This class has the data provider for
1980 the list view table.
1981 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1982 methods for related list tables. Add more information to the
1983 LayoutItemField and LayoutItemPortal DTOs.
1984 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1985 Remove debugging print statement.
1986 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1987 Remove debugging print statements. Add primary key field to SQL count
1989 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1990 Remove unnecessary LayoutFieldVector parameter from
1991 getResultSizeOfSQLQuery() method.
1992 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1993 New class for related list table database access.
1994 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1995 class that is a wrapper DTO for details view layout and data.
1996 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1997 new 'fromField' string to this DTO.
1998 * src/main/webapp/style.css: Remove bottom margin and override top
2001 2011-09-15 Ben Konrath <ben@bagu.org>
2003 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2005 This sets things up to make it easier to add the data retrieval for
2006 related lists (portals). No user noticeable changes were made with
2009 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2010 class has the code to retrieve the layouts and access the
2011 database using the new database helper classes.
2012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2013 Most of the functionality has been removed from this class. This
2014 class now represents the public interface for the client side
2015 code. It also deals with configuring the servlet and cleaning
2016 things up when the servlet is stopped.
2017 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2018 of static methods into this utility class.
2019 * src/main/java/org/glom/web/server/database/DBAccess.java:
2020 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2021 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2022 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2023 These classes have the database retrieval code. The class hierarchy
2024 has been setup to make it easy to reuse code for similar
2027 2011-09-06 Ben Konrath <ben@bagu.org>
2029 Create separate classes for list table code and the data provider.
2031 As part of this refactor, I also split up the code a bit to make it
2034 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2035 table code to two new classes (below).
2036 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2037 with code from ListViewImpl.
2038 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2039 New file with code from ListViewImpl.
2041 2011-09-06 Ben Konrath <ben@bagu.org>
2043 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2045 This fixes the LayoutItemPortal DTO to match the libglom layout object
2048 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2050 2011-09-01 Ben Konrath <ben@bagu.org>
2052 Set title of Portals in the Details View.
2054 * pom.xml: Bump required version of java-libglom to 1.17.1.
2055 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2056 widget creation to its own class. Add comments to constructor.
2057 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2058 The code is mostly from the Group class with the title now set.
2059 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2060 title of Portal. Update some comments. Fix some code formatting.
2062 2011-09-01 Ben Konrath <ben@bagu.org>
2064 Remove TODO comment for the flow table column width.
2066 The flow table column width is working correctly and doesn't need to be
2067 changed. See this mailing list post for more info:
2069 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2071 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2073 2011-08-27 Ben Konrath <ben@bagu.org>
2075 Add document title (database name) to top of the browser page.
2077 I added the document title to the TableSelecitonView but that will
2078 change if / when we add a view that doesn't require table selection.
2080 * mockups/details-contacts.html:
2081 * mockups/details-projects.html:
2082 * mockups/listview-contacts.html:
2083 * mockups/listview-projects.html:
2084 * mockups/style.css: Add document title to mockups to keep things
2086 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2087 sizes to account for the document title.
2088 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2089 Set the document title when it has been retrieved from the server.
2090 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2091 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2092 and implement setDocumentTitle(String) method.
2093 * src/main/webapp/style.css: Add ID for document title style.
2095 2011-08-25 Ben Konrath <ben@bagu.org>
2097 Add NavigationType enum to LayoutItemPortal DTO.
2099 This is the start of adding support for Portals to the Details View.
2101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2102 LayoutItem_Portal.navigation_type enum from libglom to
2103 LayoutItemPortal.NavigationType enum.
2104 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2105 NavigationType enum, field for storing the NavigationType and getter
2108 2011-08-25 Ben Konrath <ben@bagu.org>
2110 Implement the flow table layout in the Details View.
2112 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2113 FlowTable to Group to account for the renamed class.
2114 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2115 File. This is a container widget that implements the Glom details view
2116 flow table behaviour.
2117 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2118 org/glom/web/client/ui/FlowTable.java.
2119 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2120 so that the size of the subgroups are a closer match to the size of
2121 the Glom subgroups. This makes the flowtable layout match the layout
2122 in Glom for the Music Collection example file.
2124 2011-08-16 Ben Konrath <ben@bagu.org>
2126 Create container element for LayoutItemPortal in Details View.
2128 This will help me develop the layout for the FlowTable.
2130 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2131 fieldPanel variable to detailsCell.
2133 2011-08-15 Ben Konrath <ben@bagu.org>
2135 Set the height of the data element in the Details View.
2137 I changed the InlineLabels (text in a span element) to Labels (text in
2138 a div element) so that I could set the height of the details-data
2139 elements instead of the details-cell parent elements. This allows the
2140 the details-data element to display the correct height if style is
2141 applied that shows the height.
2143 This change has the added benefit of allowing the order of the labels
2144 and data elements to be changed for right-to-left languages.
2146 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2147 InlineLabels to Labels.
2148 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2149 InlineLabels to Labels. Set the height of the data element.
2150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2151 multiline text height in the Formatting DTO.
2152 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2153 for multiline height along with getter and setter methods.
2154 * src/main/webapp/style.css: Adjust style to account for the change
2155 from span elements to div elements in the details cell.
2157 2011-08-15 Ben Konrath <ben@bagu.org>
2159 Make the List View appearance match the mockups.
2161 It doesn't match exactly but it's much better than it was.
2163 * mockups/listview-contacts.html: Remove unused css classes.
2164 * mockups/listview-projects.html: Remove unused css classes.
2165 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2166 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2167 for mainPanel instead of VerticalPanel (table). Set style name on
2168 CellTable. Set style name on Details column. Right-align Details
2170 * src/main/webapp/style.css: Adjust properties to match the mockups.
2172 2011-08-12 Ben Konrath <ben@bagu.org>
2174 Add better support for subgroups in the details view.
2176 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2177 changed FlowTable constructor.
2178 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2179 support for subgroups and subgroup-titles.
2180 * src/main/webapp/style.css: Add CSS class for subgroups and
2183 2011-08-12 Ben Konrath <ben@bagu.org>
2185 Return the top level LayoutGroup title.
2187 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2189 2011-08-11 Ben Konrath <ben@bagu.org>
2191 Make the TableSelector header match the mockup.
2193 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2194 the layout panel. Properly lineup the table selection header with
2195 the list and details view.
2196 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2197 margin around the details view.
2198 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2199 Rename listBox variable to tableSelector. Set id for the style sheet.
2200 Use a FlowPanel instead of a HorizontalPanel.
2201 * src/main/webapp/style.css: Add properties to make the TableSelector
2202 box match the mockups.
2204 2011-07-13 Ben Konrath <ben@bagu.org>
2206 Update install script for java-libglom version change.
2208 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2211 2011-07-13 Ben Konrath <ben@bagu.org>
2213 Add support sub-group in the details view.
2215 I also removed the code that special-cased the default details view
2218 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2220 I still have to make a proper flowtable.
2222 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2223 Don't special-case default details view layout.
2224 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2225 addLayoutField() as I'm going to use it.
2226 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2227 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2229 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2230 extracted from DetailsViewImpl.GroupPanel. Add support for
2232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2233 column count when getting the details layout.
2235 2011-07-12 Ben Konrath <ben@bagu.org>
2237 Set browser title with database and table titles.
2239 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2240 Set the browser title when the table changes and when the activity
2242 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2243 title when retrieving document info (the GlomDocument object).
2244 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2245 with getter and setter methods. Remove unused convenience constructor.
2246 Use default code formatting.
2248 2011-07-12 Ben Konrath <ben@bagu.org>
2250 Ignore LayoutItemPortals in the details view.
2252 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2255 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2256 LayoutItemPortal layout objects.
2257 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2258 LayoutItemPortal objects when retrieving the details layout.
2259 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2260 file. This is an empty class and just used to get type information for
2263 2011-07-12 Ben Konrath <ben@bagu.org>
2265 Use java-libglom 1.17.0.
2269 2011-07-11 Ben Konrath <ben@bagu.org>
2271 Remove "Table:" label from table selector.
2273 This matches a recent change in the Glom UI.
2275 * mockups/details-contacts.html:
2276 * mockups/details-projects.html:
2277 * mockups/listview-contacts.html:
2278 * mockups/listview-projects.html: Remove the "Table:" label from the
2280 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2282 2011-07-11 Ben Konrath <ben@bagu.org>
2284 Add main groups to the details view.
2286 This makes things look a little nicer in the details view. The next step
2287 is to implement the flowtable.
2289 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2290 resources from the standard gwt css theme. Standard.css is now
2291 included in OnlineGlom.html so that the online glom css rules have
2292 precedence over the gwt theme.
2293 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2294 the whole LayoutGroup to the DetailsView instead of just the titles.
2295 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2296 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2297 details layout with a helper class (GroupPanel). I might extract this
2298 class when I make the full flowtable.
2299 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2300 string as default so I don't have to worry about NPEs when processing
2302 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2303 note beside OnlineGlom.gwt.xml above).
2304 * src/main/webapp/style.css: Add default font-size to body to override
2305 the font-size set by the standard theme. Don't use h2 tags for
2306 group-title. Create new details-cell class.
2308 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2310 ConfiguredDocument: Set the port number too.
2312 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2313 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2314 Glom document. Presumably this worked sometimes so far because there is a
2315 default port number.
2317 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2319 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2321 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2322 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2323 correct, though we should throw an exception too.
2325 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2327 Fix a addDocuemnt typo.
2329 * src/main/java/org/glom/web/shared/Documents.java
2330 (Documents.addDocuemnt): Rename to addDocument().
2331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2332 (OnlineGlomServiceImpl.getDocuments): Adapt.
2334 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2336 Slightly improved log output when connection fails.
2338 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2339 (ConfiguredDocument.setUsernameAndPassword):
2340 We don't know for sure if it' the username/password that's wrong, so
2341 rephrase the message.
2342 Also ouput the exception message, though it's generic in this case.
2344 2011-07-08 Ben Konrath <ben@bagu.org>
2348 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2349 added braces to a one line if statement because the Eclipse formatter
2350 was getting confused.
2352 2011-07-07 Ben Konrath <ben@bagu.org>
2354 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2356 These should really be two separate tasks but I counldn't get things to
2357 work with GWT 2.2.0 and Eclipse 3.7.
2361 * .settings/org.eclipse.jdt.core.prefs:
2362 * .settings/org.eclipse.jdt.ui.prefs:
2363 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2364 * .settings/org.eclipse.m2e.core.prefs:
2365 Add new config files. Update current files. Remove references to the
2366 webtools plugins as we're not using any of the webtools features.
2367 * .gitignore: Add logs directory which is created when running with
2369 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2370 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2371 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2373 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2375 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2377 onlineglom.properties: Add explanatory comments.
2379 * src/main/resources/onlineglom.properties: Also change the default user
2380 from ben to someuser, to avoid the risk of people thinking we just
2381 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2383 2011-06-28 Ben Konrath <ben@bagu.org>
2385 Use filename in Log for incorrect passwords.
2387 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2388 getFileName(String) method to get the filename from the URI.
2390 2011-06-28 Ben Konrath <ben@bagu.org>
2392 Add the table name to the URL token for the ListPlace.
2394 This makes things consistent between the DetailsPlace and the
2395 ListPlace. It also allows the the ListPlace to be bookmarked.
2397 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2398 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2399 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2400 Remove getDefaultListLayout(). The default layout is now returned
2401 by the getListLayout() method when the table name is an empty string.
2402 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2403 Add table name field. Change to a new ListPlace when the table
2404 has been changed. Use getListLayout() for getting the default
2406 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2407 Add table name field. Set the correct table name in the list box
2408 when loading from bookmark. This corrects a problem for the
2410 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2411 Move table name to super-class (HasSelectableTable). Move document
2412 and table URL keys to super-class in HasSelectableTable.
2413 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2414 Add table name field. Add Tokenizer class with URL key common to
2415 the subclasses (DetailsPlace and ListPlace).
2416 * src/main/java/org/glom/web/client/place/ListPlace.java:
2417 Add table name. Add code to parse the URL token.
2418 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2419 Update ListPlace construction with empty table name string.
2420 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2421 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2422 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2423 Update ListPlace construction with table name string.
2424 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2425 Change defaultTableName field to tableName to reflect how it's now
2426 used. Update the getter and setter methods.
2428 2011-06-28 Ben Konrath <ben@bagu.org>
2430 Enable the table selector in the DetailsView.
2432 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2433 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2434 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2435 Remove getDefaultDetailsLayout(). The default layout is now returned
2436 by the getDetailsLayout() method when the table name is an empty
2438 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2439 event handler for table change event. Change to using
2440 getDetailsLayout() for the default details layout.
2441 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2443 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2444 when navigating to the details place.
2446 2011-06-27 Ben Konrath <ben@bagu.org>
2448 Use filename based unique document ID in URL and for RPC.
2450 The document ID is the glom document name with spaces (' ') replaced
2451 with pluses ('+') and without the .glom extension.
2453 This change is mostly a string substitution of 'documentTitle' for
2454 'documentID'. The only code change is the addition of a Documents DTO to get the
2455 filename to document title mappings as indicated below.
2457 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2458 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2459 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2460 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2461 Use Documents DTO to create the document links in the document
2463 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2464 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2465 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2466 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2467 * src/main/java/org/glom/web/client/place/ListPlace.java:
2468 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2469 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2470 * src/main/java/org/glom/web/client/ui/ListView.java:
2471 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2472 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2473 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2474 * src/main/java/org/glom/web/server/Log.java:
2475 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2476 getDocumentTitles() to getDocuments() and return the Documents DTO.
2477 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2478 transferring the filename to document title mappings.
2480 2011-06-25 Ben Konrath <ben@bagu.org>
2482 Make the authentication popup work again.
2484 This bug was introduced when I extracted ConfiguredDocument to its own class.
2486 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2487 correct success / fail status in setUsernameAndPassword().
2489 2011-06-25 Ben Konrath <ben@bagu.org>
2491 Use filename as unique key for configuring database usernames and passwords.
2493 This replaces the use of the Glom document title which could change
2494 depending on the locale. Thanks to Murray Cumming for pointing out this
2497 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2498 * src/main/resources/onlineglom.properties:
2500 2011-06-24 Ben Konrath <ben@bagu.org>
2502 Pass primary key value to DetailsView.
2504 This enables the DetailsView to load the correct data.
2506 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2507 primary key value field and set in constructor. Pass primary key
2508 value to getDetailsData().
2509 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2510 variables for document title and primary key value.
2511 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2512 key value to the DetailsPlace.
2514 2011-06-24 Ben Konrath <ben@bagu.org>
2516 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2518 This allows the primary key to be retrieved by the Details button. This
2519 functionality has not been implemented yet but it's in the works.
2521 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2522 the LayoutGroup result to ListView.setCellTable instead of all of its
2523 fields individually.
2524 * src/main/java/org/glom/web/client/ui/ListView.java:
2525 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2526 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2527 get the primary key for the table.
2528 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2529 index of the primary key in the LayoutGroup accounting for hidden
2530 primary keys. Rename getJavaNumberFormat() to
2531 convertToJavaNumberFormat() for consistency. Cleanup / add some
2533 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2534 field for primary key index and a field to indicate whether the
2535 primary key is hidden or not.
2537 2011-06-23 Ben Konrath <ben@bagu.org>
2539 Rename getTableData methods to getListData.
2541 This is a rename refactor for consistency with other methods.
2543 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2544 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2545 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2546 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2548 2011-06-23 Ben Konrath <ben@bagu.org>
2550 Extract the ConfiguredDocument innerclass into its own class.
2552 This makes the servlet code more object oriented.
2554 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2555 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2556 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2557 new ConfiguredDocument class.
2559 2011-06-21 Ben Konrath <ben@bagu.org>
2561 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2563 This makes things more inline with how libglom works and reduces code
2564 duplication. This refactor lays the groundwork for adding the primary key to
2565 the LayoutGroup object.
2567 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2568 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2570 Change method names to getListLayout and getDefaultListLayout for
2571 consistency. Use LayoutGroup as the DTO for the list layout instead of
2572 ColumnInfo and LayoutListTable.
2573 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2574 new method names along with the LayoutGroup object for transferring the
2576 * src/main/java/org/glom/web/client/ui/ListView.java:
2577 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2578 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2579 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2581 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2582 Replaced with LayoutGroup.
2583 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2584 expectedResultSize and defaultTableName fields which are needed for
2586 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2587 type field which is needed for the list layout but will also be
2588 useful for the details layout as things progress.
2589 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2590 Make class abstract. Remove the unnecessary
2591 getFormattingHorizontalAlignment method. Add setFormatting method.
2593 2011-06-16 Ben Konrath <ben@bagu.org>
2595 Add scripts for building and installing war.
2597 These will help when updating OnlineGlom but they're also good
2598 supplemental documentation of the build and deployment proceeding.
2600 * utils/build-onlineglom-war.sh: New file.
2601 * utils/install-onlineglom-war.sh: New file.
2603 2011-06-16 Ben Konrath <ben@bagu.org>
2605 Create wrapper class to create consistent log messages.
2607 I wrapped methods in the Log class of gwt-log to add the method names
2608 from the servlet and create consistent formatting of the document title
2609 and table names in the log messages.
2611 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2612 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2613 log methods to use methods from wrapped Log class.
2615 2011-06-16 Ben Konrath <ben@bagu.org>
2617 Remove superfluous conditional return.
2619 Thanks to Murray Cumming for pointing this out!
2621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2623 2011-06-15 Ben Konrath <ben@bagu.org>
2625 Return an ArrayList of LayoutGroups for the Details layout.
2627 This corrects a problem with the details layout as it can have more
2628 than one top level LayoutGroup.
2630 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2631 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2632 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2633 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2634 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2635 with ArrayList of LayoutGroups for the details view layout.
2636 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2637 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2638 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2639 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2640 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2641 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2643 2011-06-14 Ben Konrath <ben@bagu.org>
2645 Use cast_dynamic method to determine the libglom LayoutItem type.
2647 This is better than finding the LayoutItem type by using the string
2648 returned from the get_part_type_name() method.
2650 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2652 2011-06-14 Ben Konrath <ben@bagu.org>
2654 Add method names to log entries in the servlet.
2656 This helps when tracking down deployment problems.
2658 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2660 2011-06-14 Ben Konrath <ben@bagu.org>
2662 Add data to the DetailsView using a hard-coded primary key value.
2664 The layout and functionality of the DetailsView is not complete. This
2665 is just a checkpoint so the patch doesn't get too big.
2667 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2668 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2669 Add getDetailsData() servlet method.
2670 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2671 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2672 LayoutFields are added to the DetailsView.
2673 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2674 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2675 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2676 take the string for the title instead of the object.
2677 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2678 Add implementation getDetailsData() along with some private helper
2680 * src/main/webapp/style.css: Add padding to details-data class. Add a
2681 details-label class with the same padding as the details-data class.
2683 2011-06-03 Ben Konrath <ben@bagu.org>
2685 Use presenter.goTo() to change to the DetailsPlace.
2687 This will make things easier when we need to open the DetailsView with
2688 data specific to the row that was clicked.
2690 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2692 2011-06-02 Ben Konrath <ben@bagu.org>
2694 Add CSS file from mockups.
2696 I'm adding this now because it's going to be useful to have when
2697 developing the DetailsView. The TableSelectionView and ListView aren't
2700 * src/main/webapp/OnlineGlom.html:
2701 * src/main/webapp/style.css:
2703 2011-06-02 Ben Konrath <ben@bagu.org>
2705 Use String.isEmpty() to check for empty string.
2707 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2709 2011-06-02 Ben Konrath <ben@bagu.org>
2711 Display main layout group titles in the DetailsView.
2713 This is the start of the DetailsActivity/DetailsView implementation.
2715 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2716 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2717 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2718 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2719 Get the layout information for the details view from the server and set
2720 the main layout group titles.
2721 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2722 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2723 Add addLayoutGroup() and addLayoutField() methods. This are just
2724 temporary methods for creating the the details view that will change
2726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2727 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2729 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2730 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2731 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2732 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2733 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2734 Data Transfer Objects that mimic the libglom object structure. These are
2735 used for transferring the details layout but could also be used for
2736 transferring the list layout.
2738 2011-05-27 Ben Konrath <ben@bagu.org>
2740 Reset the AuthenticationPopup when clearing the ListView.
2742 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2744 2011-05-27 Ben Konrath <ben@bagu.org>
2746 Fix problem with onlineglom.properties file loading.
2748 The old way worked in Eclipse but not on the server. Loading the
2749 onlineglom.properties file now works in Eclipse and on the server.
2751 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2753 2011-05-24 Ben Konrath <ben@bagu.org>
2755 Update gwt-log from 3.1.0 to 3.1.2.
2757 Gwt-log 3.1.0 has been marked as depreciated.
2761 2011-05-24 Ben Konrath <ben@bagu.org>
2763 Add comment to ListActivity.goTo() method.
2765 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2767 2011-05-24 Ben Konrath <ben@bagu.org>
2769 Remove FIXME in convertGdkColorToHtmlColour()
2771 The Gdk::Color value returned by libglom is 16-bits per channel on both
2772 64 and 32-bit platforms.
2774 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2776 2011-05-19 Ben Konrath <ben@bagu.org>
2778 Improve performance of initial ListView load.
2780 I removed a round trip to the server for getting the default table name
2781 and then requesting information about that table. This also removes a potential
2782 problem with the table change handler not being setup in time to receive the
2783 table change event from the ListActivity.
2785 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2786 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2787 getDefaultLayoutListTable() method. Improve comments.
2788 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2789 getDefaultLayoutListTable() method instead of firing a table change
2790 event to get the table to load.
2791 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2792 implementation of getDefaultLayoutListTable() method.
2793 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2796 2011-05-19 Ben Konrath <ben@bagu.org>
2798 Override toDebugString() in TableChangeEvent.
2800 This is useful to have for debugging.
2802 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2804 2011-05-19 Ben Konrath <ben@bagu.org>
2806 Add a "Back to List" link when at the DetailsPlace.
2808 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2809 Populate the CellTable based on the selected table of the ListBox if
2810 it's set otherwise use the default table. This allows the "Back to
2812 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2813 Remove Place from constructors. Add a setPlace() method. Add
2814 goToPlace() method. Set class as presenter for TableSelectionView.
2815 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2816 Use the same TableSelectionActivity when switching between the List and
2818 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2819 Subclass the new HasSelectableTablePlace. This removes some duplicate
2821 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2822 New class to represent Places that display the TableSelectionView.
2823 * src/main/java/org/glom/web/client/place/ListPlace.java:
2824 Subclass the new HasSelectableTablePlace. This removes some duplicate
2826 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2827 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2828 Add Presenter interface. Add setBackLinkVisible() method. Add
2829 setBackLink() method.
2831 2011-05-18 Ben Konrath <ben@bagu.org>
2833 Enable the "Details" buttons.
2835 Right now only an empty details view is displayed.
2837 * src/main/java/org/glom/web/client/ClientFactory.java:
2838 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2839 Add DetailsView to ClientFactory.
2840 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2841 A basic activity for the details view.
2842 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2843 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2845 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2846 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2848 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2849 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2850 unnecessary super() in constructor.
2851 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2852 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2853 really shouldn't create a new TableSelectionActivity for both the ListPlace
2854 and the DetailsPlace so this should be considered a temporary solution.
2855 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2856 New file. Represents a URL for the details view.
2857 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2858 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2859 A basic details view interface and implementation.
2860 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2861 Enable the "Details" buttons.
2863 2011-05-12 Ben Konrath <ben@bagu.org>
2865 Use a LayoutPanel with multiple display areas for main layout.
2867 This is mostly a refactor in that there are no changes from the user
2868 point of view. These changes are required so that we can swap out the list view
2869 with the details view when the user clicks the "Details" button.
2871 * src/main/java/org/glom/web/client/ClientFactory.java:
2872 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2873 OnlineGlomView. Add TableSelectionView, ListView and
2874 AuthenticationPopup.
2875 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2876 for main layout. Add display regions for main activities. Add
2877 activity manager for for main activities.
2878 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2879 file from parts of the deleted OnlineGlomActivity.
2880 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2881 New file from parts of the deleted OnlineGlomActivity.
2882 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2883 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2884 New files for app wide table change event.
2885 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2886 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2887 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2888 Activity mappers for the main activities replace the deleted app-wide
2890 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2891 Fix a spelling error in he comment.
2892 * src/main/java/org/glom/web/client/ui/ListView.java:
2893 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2894 Renamed from LayoutListView and modified for MVP. This still not a
2895 proper dumb view as prescribed by the MVP pattern but it works for now.
2896 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2897 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2898 New widget stripped out of the deleted OnlineGlomView.
2899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2900 Remove hack that is fixed by this patch.
2902 2011-05-06 Ben Konrath <ben@bagu.org>
2904 Rename OnlineGlomPlace to ListPlace.
2906 The only change besides the rename is that url will now display #list
2907 instead of #Document.
2909 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2910 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2911 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2912 * src/main/java/org/glom/web/client/place/ListPlace.java:
2913 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2915 2011-05-06 Ben Konrath <ben@bagu.org>
2917 Use Presenter for app navigation.
2919 This is the proper way to deal with Place (URL) changes with the MVP
2922 * src/main/java/org/glom/web/client/ClientFactory.java:
2923 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2924 PlaceHistoryMapper and PlaceHistoryHandler.
2925 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2926 PlaceHistoryMapper and PlaceHistoryHandler.
2927 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2928 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2929 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2930 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2931 Add Presenter interface and setPresenter methods. Rename addHyperLink
2932 to addDocumentLink taking only the document title as a parameter.
2934 2011-04-14 Ben Konrath <ben@bagu.org>
2936 Prompt for db username/password if they haven't been set.
2938 This is implemented with a popup widget that is contained within the
2939 OnlineGlomView and managed by the OnlineGlomActivity.
2941 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2942 methods for checking and setting the database username and password.
2943 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2944 new methods for checking and setting the database username and
2946 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2947 Display authentication popup if the JDBC connection to the database
2948 has not been authenticated.
2949 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2951 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2952 for dealing with the authentication popup.
2953 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2954 Implement the methods for dealing with the authentication popup.
2955 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2956 try to executed queries if the database connection hasn't been
2957 authenticated. Implement methods for checking and setting the
2958 database username and password.
2960 2011-04-12 Ben Konrath <ben@bagu.org>
2962 Make log messages a little clearer.
2964 Add a dash betweeen the document title and the table name.
2966 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2968 2011-04-12 Ben Konrath <ben@bagu.org>
2970 Protect against NPEs when cleaning up database resources.
2972 While this isn't strictly necessary because the exception is caught,
2973 not protecting against the NPEs makes it harder to find the real error
2976 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2978 2011-04-12 Ben Konrath <ben@bagu.org>
2980 Move configuration of the servlet to the constructor.
2982 The servlet will be initialized even if the database authentication
2983 information is not set or correct. I still need to add the UI for prompting
2984 the user for the authentication information when it's required.
2986 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2987 javadocs for getDocumentTitles() method.
2988 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2989 Set error message when RPC fails.
2990 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2991 glom files directory from the configuration file. Try to set the
2992 database authentication information for the specific document if it's
2993 set and works otherwise try to use the global authentication
2994 information set for the directory.
2995 * src/main/resources/onlineglom.properties: Moved from
2996 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2997 Added detailed comments for the new keys.
2999 2011-04-11 Ben Konrath <ben@bagu.org>
3001 Remove unnecessary @Override in DocumentSelectionViewImpl.
3003 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3005 2011-04-11 Ben Konrath <ben@bagu.org>
3007 Remove center alignment in DocumentSelectionView.
3009 The title element is still centred but the document titles and bottom
3010 sentence are both left-aligned.
3012 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3014 2011-04-11 Ben Konrath <ben@bagu.org>
3016 Change 'Demo' naming convention to 'Document'.
3018 This is just a rename refactor with no functional changes to the code.
3020 * src/main/java/org/glom/web/client/ClientFactory.java:
3021 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3022 * src/main/java/org/glom/web/client/OnlineGlom.java:
3023 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3024 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3025 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3026 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3027 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3028 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3029 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3030 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3031 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3032 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3034 2011-04-08 Ben Konrath <ben@bagu.org>
3036 Remove FIXME from safeLongToInt() method.
3038 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3041 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3043 2011-04-08 Ben Konrath <ben@bagu.org>
3045 Display an error if no glom documents are found in the specified directory.
3047 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3048 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3049 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3050 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3052 2011-04-08 Ben Konrath <ben@bagu.org>
3054 Add copyright header to one more file ... oops.
3056 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3058 2011-04-08 Ben Konrath <ben@bagu.org>
3060 Add copyright header to files without it.
3062 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3063 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3064 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3065 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3066 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3067 * src/main/java/org/glom/web/shared/GlomField.java:
3069 2011-04-08 Ben Konrath <ben@bagu.org>
3071 Add support for accessing multiple glom documents in the servlet.
3073 This completes the demo selection functionality.
3075 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3076 document title to methods.
3077 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3078 document title to methods.
3079 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3080 Set browser window title when the activity starts. Correct name of
3081 document title variable.
3082 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3083 Set browser window title when the activity starts. Set the table
3084 selector change handler after table selector has been set. Clear the
3085 OnlineGlomView when the activity has been stopped.
3086 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3087 document title as the place token. Use "#Document:" instead of
3088 "#OnlineGlomPlace:" in the URL.
3089 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3090 Change heading to "Online Glom"
3091 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3092 document title in RPC methods.
3093 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3094 setDocumentTitle() method. Add clear() method.
3095 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3096 setDocumentTitle() method. Implement clear() method which removes the
3097 change handler on the ListBox, clears the ListBox and clears the
3099 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3100 Implement methods with document title. Keep track for the configured
3101 glom documents and their corresponding JDBC configurations in a hash
3102 table. This information is retrieved using the document title as the
3103 key in the hash table.
3104 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3105 document title field as it's no longer needed.
3107 2011-04-08 Ben Konrath <ben@bagu.org>
3109 Update the Eclipse JDT configuration.
3111 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3112 methods. Automatically add the copyright header to new files.
3114 2011-04-05 Ben Konrath <ben@bagu.org>
3116 Add new page for demo selection.
3118 This patch adds all the components required to view and start an
3119 OnlineGlom demo by clicking on the desired hyperlink. The user is
3120 able to return to the demo selection page with the browser's back
3121 button. I still need to modify the servlet to work with multiple
3122 documents so all demo links will load the file defined in the
3123 OnlineGlom.properties.
3125 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3126 This is only useful during development so we don't need to save it.
3127 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3128 get a reference to the DemoSelectionView.
3129 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3130 method to get a reference to the DemoSelectionView.
3131 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3132 default view to DemoSelectionView.
3133 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3134 to get glom document titles for glom files in a hard-coded directory.
3135 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3136 method to get glom document titles for glom files in a hard-coded
3138 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3139 Presenter for DemoSelectionView.
3140 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3141 for DemoSelectionView.
3142 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3143 Update for DemoSelectionView.
3144 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3145 Basic 'Place' implementation for the DemoSelectionView.
3146 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3147 The interface for the DemoSelectionView.
3148 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3149 The implementation of the DemoSelectionView.
3150 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3151 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3153 implementation of method to get glom document titles for glom files
3154 in a hard-coded directory.
3155 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3156 on longer being used.
3157 * src/main/webapp/glom.png: Glom logo.
3159 2011-04-05 Ben Konrath <ben@bagu.org>
3161 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3163 This is the forth and final commit of a refactor that will allow
3164 OnlineGlom to be used with multiple documents.
3166 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3167 Move RPC code from OnlineGlomViewImpl to this class.
3168 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3170 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3171 RPC code to the presenter class (the P in MVP).
3173 2011-04-04 Ben Konrath <ben@bagu.org>
3175 Start moving the existing OnlineGlom code to MVP.
3177 This work is based on the GWT MVP framework that is documented here:
3179 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3181 This is the third commit of a refactor that will allow OnlineGlom to
3182 be used with multiple documents.
3184 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3185 Interface for client factory which is used to get instances of various
3186 classes throughout the app.
3187 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3188 Implementation of client factory.
3189 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3190 initialize the MVP framework.
3191 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3192 New file. Activity manager for the main container widget. This is the
3194 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3195 Maps place (URL) to its corresponding activity.
3196 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3197 New file. This is just a place holder for a generated file.
3198 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
3199 New file. Represents the URL for the main Online Glom app.
3200 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
3201 for changes in LayoutListViewImpl.
3202 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
3203 interface for View. Move code to OnlineGlomViewImpl class.
3204 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
3205 file. Implementation of OnlineGlomView.
3206 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
3207 Place resources. Use ClientFactoryImpl by default.
3209 2011-04-04 Ben Konrath <ben@bagu.org>
3211 Move View classes to their own package.
3213 This is the second commit of a refactor that will allow OnlineGlom to
3214 be used with multiple documents.
3216 * src/main/java/org/glom/web/client/OnlineGlom.java:
3217 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
3218 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
3220 2011-04-02 Ben Konrath <ben@bagu.org>
3222 Move UI code from the main module to its own class.
3224 This is the first commit of a refactor that will allow OnlineGlom to be
3225 used with multiple documents.
3227 * src/main/java/org/glom/web/client/LayoutListView.java: Update
3228 references to OnlineGlom to OnlineGlomView.
3229 * src/main/java/org/glom/web/client/OnlineGlom.java: Move&nbs