1 2012-05-06 Murray Cumming <murrayc@murrayc.com>
3 ListTable.addColumn(): Protect against a null Formatting.
5 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
6 Create a default Formatting if it is null, because that is the simplest
9 2012-05-06 Murray Cumming <murrayc@murrayc.com>
11 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
13 * src/main/java/org/glom/web/server/ConfiguredDocument.java
14 updateLayoutGroup(): Check that the field is not null.
16 2012-05-06 Murray Cumming <murrayc@murrayc.com>
18 ListViewImpl: Protected against a bad cast error.
20 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
21 onEnterKeyDown(): Do not cast without an instanceof check.
23 2012-05-06 Murray Cumming <murrayc@murrayc.com>
25 ListTable: Protect against an out of range error.
27 * src/main/java/org/glom/web/client/ui/list/ListTable.java
28 createCellTable(): This is unlikely, but can happen while debugging.
30 2012-05-06 Murray Cumming <murrayc@murrayc.com>
32 AsyncMessage onFailure() callbacks: Log the exception message.
34 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
35 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
36 * src/main/java/org/glom/web/client/activity/ListActivity.java:
37 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
38 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
39 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
40 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
41 These are useful clues when something is wrong.
43 2012-05-06 Murray Cumming <murrayc@murrayc.com>
45 ConfiguredDocument: Avoid a null dereference.
47 * src/main/java/org/glom/web/server/ConfiguredDocument.java
48 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
49 details maps are created.
51 2012-05-06 Murray Cumming <murrayc@murrayc.com>
53 Document: Correct the port number parsing.
55 * src/main/java/org/glom/web/server/libglom/Document.java:
56 This lets us actually connect to the database and show the document.
58 2012-05-05 Murray Cumming <murrayc@murrayc.com>
62 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
63 user-interaction, asking us to load a temporary URL in a browser.s
64 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
65 which is apparently necessary for testing the service. See the comment.
66 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
67 Show the exception, if any. This is how I saw the 404 in the HTML in
70 2012-05-05 Murray Cumming <murrayc@murrayc.com>
72 DocumentTest: Move the .glom files into the resources directory.
74 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
75 URI via getResource().
77 2012-05-05 Murray Cumming <murrayc@murrayc.com>
79 Document: Remove the FieldIdentifies inner class.
81 * src/main/java/org/glom/web/server/libglom/Document.java: We only
82 use the Relationship (though the same function in libglom is maybe
83 used in other ways) and so this removes a compiler warning.
85 2012-05-05 Murray Cumming <murrayc@murrayc.com>
87 Document.load() Remove the error code parameter.
89 * src/main/java/org/glom/web/server/libglom/Document.java: load():
90 Remove the parameter. We do not set it yet and it could never have
91 worked as an output parameter (though maybe it did in java-libglom).
92 We could use an exception if we really want the failure reason.
93 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
95 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
96 setUp(), testGetSuitableTableToViewDetails(): Adapt.
98 2012-05-05 Murray Cumming <murrayc@murrayc.com>
100 Make some inner classes static.
102 * src/main/java/org/glom/web/server/ConfiguredDocument.java
103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
104 * src/main/java/org/glom/web/server/ReportGenerator.java
105 * src/main/java/org/glom/web/server/libglom/Document.java
106 Make all inner classes static that can be static.
108 2012-05-05 Murray Cumming <murrayc@murrayc.com>
110 OnlineGlomServiceImpl: Do not load and check for java-libglom.
112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
113 init(): We do not use java-libglom any more.
115 2012-05-05 Murray Cumming <murrayc@murrayc.com>
117 Remove mentions of java-libglom.
119 * README: Remove mention of java-libglom, because it no longer needed.
120 * utils/build-onlineglom-war.sh:
121 * utils/check-and-recover-tomcat.py:
122 * utils/install-onlineglom-war.sh: Remove these as they are no longer
123 useful. Building is now far easier, with no need for jhbuild.
125 2012-05-05 Murray Cumming <murrayc@murrayc.com>
127 Fix the build (mvn package)
129 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
130 (LayoutGroup): Make the LayoutItemList inner class static and protected.
131 Otherwise the GWT Java->Javascript compilation fails with just this
132 error, during mvn package or when attempting to view in a browser,
133 in the GWT developer mode in Eclipse.
135 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
136 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
137 [INFO] Compiling module org.glom.web.OnlineGlom
138 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
139 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
140 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
141 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
142 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
143 [INFO] [ERROR] Cannot proceed due to previous errors
145 It has taken me 2 days to find out what was causing that. After reducing
146 the code, the compiler eventually showed me the full error message.
148 2012-05-04 Murray Cumming <murrayc@murrayc.com>
150 ConfiguredDocument: Cache the cloned and stripped layouts.
152 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
153 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
154 layout in a map, so we can retrieve it again without rebuilding it.
156 2012-05-04 Murray Cumming <murrayc@murrayc.com>
158 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
160 2012-05-04 Murray Cumming <murrayc@murrayc.com>
162 libglom classes: Implement some auto-generated emthods.
164 2012-05-04 Murray Cumming <murrayc@murrayc.com>
166 Add GwtTestOnlineGlomService.
168 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
169 However, this (and the other GwtTest*) does not seem to run during
172 2012-05-04 Murray Cumming <murrayc@murrayc.com>
174 Remove use of unsupported features from client code.
176 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
177 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
178 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
179 Use our client version of StringUtils instead of the apache commons one.
181 However, the GWT Javascript compliation still fails.
183 2012-04-25 Murray Cumming <murrayc@murrayc.com>
185 Add a Field class and implement some loading of it in Document.
187 2012-04-25 Murray Cumming <murrayc@murrayc.com>
189 Initial Document loading implementation, instead of libglom.
191 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
192 and Translatable classes, and adapt the rest of the code to use them.
193 However, this is still missing Layout and Field classes and loading.
195 2012-04-24 Murray Cumming <murrayc@murrayc.com>
197 Use of jOOQ: Move Field creation into a utility method.
199 * src/main/java/org/glom/web/server/SqlUtils.java:
200 This lets us improve it more easily.
202 2012-04-24 Murray Cumming <murrayc@murrayc.com>
204 Use of jOOQ: Improve the code to COUNT a sub-select.
206 * src/main/java/org/glom/web/server/SqlUtils.java:
207 Move initial query creation into
208 build_sql_select_step_with_where_clause().
209 build_sql_select_count_rows(): Use the jOOQ API instead of
210 concatentating text, because a jOOQ Select*Step is a TableLike,
211 which is what from() takes.
213 2012-04-23 Murray Cumming <murrayc@murrayc.com>
215 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
217 * pom.xml: Depend on jooq.
218 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
219 methods with jOOQ, based on the C++ implementations in libglom,
220 with some changes to the logic required by jooQ.
221 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
223 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
224 * src/main/java/org/glom/web/server/ReportGenerator.java:
225 * src/main/java/org/glom/web/server/SqlUtils.java:
226 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
227 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
228 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
229 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
230 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
231 Adapt. In particular, the SqlUtils methods now need to take a Connection,
232 because jOOQ needs that, though it seems unnecessary.
234 This is not quite finished. Ideally jOOQ would help us to build
235 table_name.field_name names, quoting and escaping them properly.
236 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
238 2012-04-21 Murray Cumming <murrayc@murrayc.com>
240 Move use of Glom.build_sql*() into a new SqlUtils class.
242 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
243 to wrap Glom.build_sql*(). The parameter types are still Glom one,
244 but this will make it easier to start using something other than
245 libglom or SqlBuilder.
247 2012-04-21 Murray Cumming <murrayc@murrayc.com>
249 Update the project URL.
251 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
253 2012-04-21 Murray Cumming <murrayc@murrayc.com>
255 Main layout: Use a FlowTable instead of absolute positioning.
257 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
258 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
259 child panels/widgets must have an absolute position. But that is annoying, so
260 this adds a FlowTable and puts the child panels in there.
262 2012-04-21 Murray Cumming <murrayc@murrayc.com>
264 GwtTestOnlineGlom: Comment out unused code.
266 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
267 Eclipse has started to say that some code is unused.
269 2012-04-21 Murray Cumming <murrayc@murrayc.com>
271 Update to the latest versions of dependencies.
273 * pom.xml: Update version numbers of dependencies to the latest
275 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
276 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
277 * src/main/java/org/glom/web/server/ReportGenerator.java:
278 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
279 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
280 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
282 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
283 Modify the imports where necessary.
285 2012-04-17 Murray Cumming <murrayc@murrayc.com>
287 Style: Remove overflow:hidden from searchbox
289 * src/main/webapp/style.css: Because this pushes the Back To Link
290 label/link on to the next row, which is then hidden due to the
291 hard-coded (in ems) height.
293 2012-04-20 Murray Cumming <murrayc@murrayc.com>
295 Remove some duplicate code.
297 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
298 getDocumentInfo(): This must have been duplicated during the merge from the
303 2012-04-19 Murray Cumming <murrayc@murrayc.com>
305 Reports: Localize the waiting for report message.
307 * src/main/java/org/glom/web/client/activity/ReportActivity.java
308 start(): Get the message from the contants.
309 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
311 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
312 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
313 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
314 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
315 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
316 Update these files with the English text for newer strings for now.
318 2012-04-19 Murray Cumming <murrayc@murrayc.com>
320 Reports: Show a message while waiting for the report.
322 * src/main/java/org/glom/web/client/ui/ReportView.java
323 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
324 Add setWaitingText(), to show a message saying that we are
325 waiting for the report to be ready.
326 * src/main/java/org/glom/web/client/activity/ReportActivity.java
327 start(): Call setWaitingText() before calling the async
330 2012-04-19 Murray Cumming <murrayc@murrayc.com>
332 ReportGenerator: Specify date and time formats.
334 * src/main/java/org/glom/web/server/ReportGenerator.java:
335 createFieldValueElement(): Use the default (and localized)
336 short formats, though we still need a way to show 4-digit
337 years without providing the format for every locale.
338 * src/main/java/org/glom/web/server/database/DBAccess.java:
339 convertResultSetToDTO(): Use the short formats here too.
341 2012-04-18 Murray Cumming <murrayc@murrayc.com>
343 ReportGenerator: Use the correct numeric formatting.
345 * src/main/java/org/glom/web/server/ReportGenerator.java
346 createFieldExpression(), createFieldValueElement(): Take the
347 whole LayoutItem_Field instead of just the field name, so
348 we have access to the formatting.
349 createFieldValueElement(): Use JRTextField.setPattern() to
350 specify the numeric formatting, with the help of a
351 regular DecimalFormat.
353 2012-04-18 Murray Cumming <murrayc@murrayc.com>
355 ReportGenerator: Avoid showing null for group by titles.
357 * src/main/java/org/glom/web/server/ReportGenerator.java
358 generateReport(): Use setBlankWhenNull() on the field title
359 style too, because this is used for values in group by
362 2012-04-18 Murray Cumming <murrayc@murrayc.com>
364 ReportGenerator: Add a colon to titles in vertical groups.
366 * src/main/java/org/glom/web/server/ReportGenerator.java
367 addFieldToDetailBandVertical(): Pass true for the withColon
370 2012-04-18 Murray Cumming <murrayc@murrayc.com>
372 ReportGenerator: Simplify the code by using Position more.
374 2012-04-18 Murray Cumming <murrayc@murrayc.com>
376 Reports: Support vertical groups, roughly.
378 * src/main/java/org/glom/web/server/ReportGenerator.java:
379 addToReport(): Rename to addGroupToReport() and, if necessary,
380 call the new addVerticalGroupToReport() method.
381 createFieldValueElement(): Let the caller specify the Y position
384 2012-04-17 Murray Cumming <murrayc@murrayc.com>
386 Reports: Allow a second report to be shown.
388 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
389 clear(): Do not remove the HTML widget, which broke the whole layout.
391 2012-04-17 Murray Cumming <murrayc@murrayc.com>
393 Locales drop-down: Show that we use English by default.
395 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
396 fillView(): When we use English, just because that is the default, when
397 no locale is specified, show that in the Locales drop-down instead of
398 just showing the first item.
400 2012-04-17 Murray Cumming <murrayc@murrayc.com>
402 Unselect the Report/Locale/Table combo item when appropriate.
404 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
405 setPlace(): clear reportName if this is not a ReportPlace.
406 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
407 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
408 When the provided name is empty, unselect all items, so that none are
409 indicated. This uses a for loop because I cannot find a single method
412 2012-04-17 Murray Cumming <murrayc@murrayc.com>
414 Report: Give the user a way to get back to the list.
416 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
417 start(), setPlace(): Show the Back To List link on reports, and also
418 interpret selecting the empty report item as back to list.
420 2012-04-13 Murray Cumming <murrayc@murrayc.com>
422 Really show the selected Report name.
424 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
425 setPlace(): Store the reportName here, if it is that kind of Place.
426 fillView(): Set the selected Report after filling the list of reports.
427 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
428 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
429 null Strings, though we need some way to unselect all ListBox items
432 2012-04-13 Murray Cumming <murrayc@murrayc.com>
434 ReportGenerator: Try to avoid some problems.
436 * src/main/java/org/glom/web/server/ReportGenerator.java
437 addField(): Try to avoid duplicates, and avoid using a null
440 2012-04-13 Murray Cumming <murrayc@murrayc.com>
442 Reports: Use quickFind.
444 * src/main/java/org/glom/web/client/OnlineGlomService.java;
445 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
446 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
447 getReportHTML(): Add a quickFind parameter.
448 * src/main/java/org/glom/web/client/activity/ReportActivity.java
449 start(): Pass the quickFind parameter.
450 * src/main/java/org/glom/web/server/ReportGenerator.java
451 generateReport(): Take a quickFind parameter.
453 2012-04-13 Murray Cumming <murrayc@murrayc.com>
455 ReportPlace: Actually use the report name.
457 * src/main/java/org/glom/web/client/place/ReportPlace.java
458 getPlace(): Do not assign the report name to the quickfind.
460 2012-04-13 Murray Cumming <murrayc@murrayc.com>
462 Show java.library.path when complaining.
464 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
465 init(): When telling us to check java.library.path, show the
468 2012-03-06 Murray Cumming <murrayc@murrayc.com>
470 ReportGenerator: Do not show nulls.
472 2012-03-06 Murray Cumming <murrayc@murrayc.com>
474 ReportGenerator: Make the title font larger.
476 2012-03-06 Murray Cumming <murrayc@murrayc.com>
478 ReportGenerator: Put field titles inside groups, if there are groups.
480 2012-03-06 Murray Cumming <murrayc@murrayc.com>
482 ReportGenerator: Take the Report itself instead of the name and group.
484 * src/main/java/org/glom/web/server/ConfiguredDocument.java
485 Remove getReportLayoutGroup().
486 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
487 getReportHTML(): Pass the report instead
488 of its name and layout group.
489 * src/main/java/org/glom/web/server/ReportGenerator.java
490 generateReport(): Use the report object to use the title
493 2012-03-06 Murray Cumming <murrayc@murrayc.com>
495 ReportGenerator: Remove designBand parameters.
497 * src/main/java/org/glom/web/server/ReportGenerator.java:
498 Make designBand a class member instead of passing it to all
501 2012-03-06 Murray Cumming <murrayc@murrayc.com>
503 ReportGenerator: Add lines, a bit like in the desktop version.
505 * src/main/java/org/glom/web/server/ReportGenerator.java
506 addToReport(): Use JRDesignLine.
508 2012-03-06 Murray Cumming <murrayc@murrayc.com>
510 ReportGenerator: Correct the title positions and use some bold style.
512 * src/main/java/org/glom/web/server/ReportGenerator.java:
513 Break the code up into reusable functions, correct the placement of
514 titles, and use normal/bold styles as in the reports in the desktop
517 2012-03-06 Murray Cumming <murrayc@murrayc.com>
519 ReportGenerator: Add a header band to show the field titles.
521 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
522 getReportHTML(): Pass the localeId to the ReportGenerator
524 * src/main/java/org/glom/web/server/ReportGenerator.java
525 constructor: Take the localeID so we can get translated field
527 generateReport(), addToReport(), addFieldToBand(): Add field
528 titles in a column header band.
530 2012-03-05 Murray Cumming <murrayc@murrayc.com>
532 Reports drop-down list: Some improvement.
534 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
535 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
536 Adedd setSelectedReport(),
537 setReportList(): Add a blank line so that the user can select the
539 * src/main/java/org/glom/web/client/activity/ReportActivity.java
540 start(): Show the current report by calling setSelectedReport().
541 This does not seem to work yet.
543 2012-03-05 Murray Cumming <murrayc@murrayc.com>
545 DetailsActivity, ListActivity: Move some variables into a base class.
547 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
548 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
549 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
550 the clientFactory, documentID, tableName and authenticationPopup into
551 a base class, to avoid duplication.
553 2012-03-05 Murray Cumming <murrayc@murrayc.com>
555 Translate the Reports label.
557 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
558 Get the "Reports" label string from the constants.
559 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
560 perties: Add Reports to the constants.
562 2012-03-05 Murray Cumming <murrayc@murrayc.com>
564 Reports: Implement grouping.
566 * src/main/java/org/glom/web/server/ReportGenerator.java:
567 Handle LayoutItem_GroupBy items and try to do the right thing
568 with JRDesignGroup. It seems to work.
570 2012-03-04 Murray Cumming <murrayc@murrayc.com>
572 Actually show some data with JasperReports.
574 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
575 getReportHTML(): Move most code into a ReportGenerator class.
576 * src/main/java/org/glom/web/server/ReportGenerator.java:
577 Recurse into sub-groups, adding fields to the JasperDesign's details
578 band. Note that we must set an arbitrary width and height, or it just
579 will not show any data.
581 2012-03-04 Murray Cumming <murrayc@murrayc.com>
583 Reports Chooser: Show the titles, not the names.
585 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
586 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
587 and the names as the values.
588 * src/main/java/org/glom/web/server/ConfiguredDocument.java
589 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
590 group now that we provide the report name, so it should always
593 2012-02-15 Murray Cumming <murrayc@murrayc.com>
595 Depend on jasperreports.
597 * pom.xml: Add the dependency. My plan is to use this on the
600 2012-01-31 Murray Cumming <murrayc@murrayc.com>
602 Implement navigation to report places.
604 * src/main/java/org/glom/web/client/activity/ReportActivity.java
605 start(): Do not bother to handle all events here.
606 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
607 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
608 Added getSelectedReport().
609 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
610 .java: start(): When handling a change to the reports chooser,
611 call getSelectedReport() and goTo() its ReportPlace.
612 * src/main/java/org/glom/web/client/ui/ReportView.java
613 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
614 Added setReportHTML() which puts the html in a gwt HTML widget.
615 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
616 getReportHTML(): Return "TODO" just to show that this works.
618 2012-01-31 Murray Cumming <murrayc@murrayc.com>
620 Make ReportPlace usable.
622 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
624 * src/main/java/org/glom/web/client/place/ReportPlace.java:
625 Correct the @prefix annotation.
627 2012-01-31 Murray Cumming <murrayc@murrayc.com>
629 OnlineGlomService: Return report HTML rather than the LayoutGroup.
631 * src/main/java/org/glom/web/client/OnlineGlomService.java:
632 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
633 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
634 Change getReportLayout() to getReportHMTL() because we will not need to
635 parse or render the report layout on the client side.
636 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
637 getReportLayout(): Return the libglom LayoutGroup type because we will
638 not need to convert to a shared type, because this will not be used on
640 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
643 Note that there is still no implementation for this.
646 2012-01-27 Murray Cumming <murrayc@murrayc.com>
648 Add a (empty) Report Place, View, and Activity.
650 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
652 * src/main/java/org/glom/web/client/place/HasTablePlace.java
653 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
654 this into a superclass:
655 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
656 and also use it as the base of this new ReportPlace:
657 * src/main/java/org/glom/web/client/place/ReportPlace.java
659 * src/main/java/org/glom/web/client/ui/ReportView.java
660 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
661 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
662 Add these, containing mostly boiler-plate for now.
664 * src/main/java/org/glom/web/client/OnlineGlomService.java
665 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
666 * src/main/java/org/glom/web/server/ConfiguredDocument.java
667 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
668 Add API to get the LayoutGroup for the report.
670 2012-01-23 Murray Cumming <murrayc@murrayc.com>
672 Add and fill a Reports drop-down list box.
674 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
676 * src/main/java/org/glom/web/client/OnlineGlomService.java:
677 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
678 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
679 Added getReports(document, table, localeID), calling
680 ConfiguredDocument.getReports().
681 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
682 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
683 Added setReportsList() and a list widget.
684 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
685 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
690 2012-04-12 Murray Cumming <murrayc@murrayc.com>
692 Translations: Add Esperanto.
694 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
695 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
696 properties: Add this translation because someone took the time to make it.
698 2012-03-15 Murray Cumming <murrayc@murrayc.com>
700 Adapt to the java-libglom 1.21.7 API.
702 * src/main/java/org/glom/web/server/ReportGenerator.java:
703 addToReport(): get_group_secondary_fields() is now
704 get_secondary_fields().
707 2012-03-15 Murray Cumming <murrayc@murrayc.com>
709 Use the latest java-libglom version.
711 * pom.xml: Use java-libglom 1.21.7.
713 2012-03-03 Ben Konrath <ben@bagu.org>
715 Display date and time in details view.
717 https://bugzilla.gnome.org/show_bug.cgi?id=671257
719 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
721 2012-03-05 Murray Cumming <murrayc@murrayc.com>
723 Require the latest java-libglom.
725 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
727 2012-03-04 Murray Cumming <murrayc@murrayc.com>
729 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
731 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
732 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
733 an empty quickfind string. I also corrected libglom to create only
734 empty where clauses for empty quickfind strings, but this avoids the
737 2012-02-24 Ben Konrath <ben@bagu.org>
739 Improve the tabs in the Notebook widget.
743 2012-01-30 Murray Cumming <murrayc@murrayc.com>
745 Translations: Try to translate the strings.
747 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
748 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
749 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
750 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
751 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
752 Take the Open translation from GTK+'s .po files.
753 Take the Details translation from Glom's po files.
754 I have added the other strings to Glom so we can get translations that way:
755 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
757 2012-01-27 Murray Cumming <murrayc@murrayc.com>
759 TableSelectionViewImpl: Put the search label and entry in a div.
761 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
762 Put the search widgets in a FlowTable so that the CSS can be used to
763 style them while keeping them together.
764 * src/main/webapp/style.css: Mention the new div.
766 2012-01-27 Murray Cumming <murrayc@murrayc.com>
768 Translate more strings in more locales.
770 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
771 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
772 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
773 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
774 Translate the "Details" and "Open" string too.
776 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
777 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
778 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
779 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
780 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
781 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
782 Add these new locales as placeholders though they currently contain English.
784 2012-01-27 Murray Cumming <murrayc@murrayc.com>
786 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
788 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
789 Check the ConfiguredDocument* for null before using it.
791 2012-01-26 Murray Cumming <murrayc@murrayc.com>
793 Tell Eclipse about the generated java files.
795 * .classpath: This lets it find OnlineGlomConstants.java.
796 It would be nice if Eclipse just used the maven build files.
798 2012-01-26 Murray Cumming <murrayc@murrayc.com>
800 Prevent a crash when no locale is specified in the URL.
802 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
803 Avoid returning a null string, obtained from
804 Window.Location.getParameter(). This caused a crash when it was
805 later passed to libglom's API.
806 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
807 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
808 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
809 guard against future null strings.
811 2012-01-26 Murray Cumming <murrayc@murrayc.com>
813 Use the ?locale= query param instead of the &lang= token param.
815 * src/main/java/org/glom/web/client/place/ListPlace.java
816 * src/main/java/org/glom/web/client/place/DetailsPlace.java
817 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
818 Remove the lang token key and value.
820 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
821 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
822 When the user selects a different locale from the chooser, use
823 Window.Location.assign() to change the URL, which then causes a reload.
825 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
826 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
827 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
828 * src/main/java/org/glom/web/client/activity/ListActivity.java
829 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
830 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
831 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
832 * src/main/java/org/glom/web/client/ui/ListView.java:
833 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
835 Remove localeID member variables and method/constructor parameters, instead
836 using Utils.getCurrentLocaleID() when we need a localID to pass to
839 2012-01-26 Murray Cumming <murrayc@murrayc.com>
841 Internationalize the UI strings.
843 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
844 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
845 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
846 because it is unused. Messages are apparently strings that can have
847 parameters, but we do not need that yet, so Contants will be enough for now.
848 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
849 to say that we support the en and de locales.
850 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
851 The original English strings.
852 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
853 Some German translations of the English strings.
854 The i18n goal then uses the .properties file to generate an
855 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
856 returns an implementation that returns the translated strings.
857 The documentation suggests putting these in src/java/*/client/, but it seems
858 best to put it in src/resources/*/client/.
859 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
860 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
861 instead of hard-coding them.
862 Note that we cannot import OnlineGlomConstants because it does not exist yet,
863 but that does not seem to stop the build, though it confuses Eclipse.
865 You can see the translated string by adding ?locale=de to the URL, like so:
866 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
868 2012-01-24 Murray Cumming <murrayc@murrayc.com>
870 Improve null/empty String checks.
872 * pom.xml: Add a dependency on commons-lang, to use
873 org.apache.commons.lang.StringUtils.
874 * src/main/java/org/glom/web/server/ConfiguredDocument.java
875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
876 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
877 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
878 Use StringUtils.isEmpty().
880 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
881 StringUtils class with a static isEmpty() function because we
882 cannot use org.apache.commons.lang.StringUtils in client-side
883 GWT code because it (apparently) cannot be compiled to javascript.
884 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
885 * src/main/java/org/glom/web/client/activity/ListActivity.java
886 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
887 * src/main/java/org/glom/web/client/place/DetailsPlace.java
888 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
889 * src/main/java/org/glom/web/client/place/ListPlace.java
890 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
891 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
892 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
893 * src/main/java/org/glom/web/client/ui/details/Group.java
894 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
895 our StringUtils.isEmpty() function.
897 2012-01-24 Murray Cumming <murrayc@murrayc.com>
899 Update to the latest java-libglom API.
901 * pom.xml: Require java-libglom 1.21.4.
902 * src/main/java/org/glom/web/server/ConfiguredDocument.java
903 getDocumentInfo(), getListViewLayoutGroup():
904 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
906 * src/main/java/org/glom/web/server/database/DBAccess.java
907 getFieldsToShowForSQLQueryAddGroup(),
908 getPrimaryKeyLayoutItemField(): Replace get_database_title()
909 with either get_database_title_original() or
910 get_database_title(localeID).
912 2012-01-24 Murray Cumming <murrayc@murrayc.com>
914 ConfiguredDocument: Avoid a null pointer exception.
916 * src/main/java/org/glom/web/server/ConfiguredDocument.java
917 Initialize localeID to "" to avoid returning a null String which
918 causes a crash in java-libglom's swing-generated code.
920 2012-01-23 Murray Cumming <murrayc@murrayc.com>
922 Some simple renaming.
924 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
925 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
926 for localeChooser. This seems more appropriate and is less ambiguous
927 particularly in the .css file.
929 2012-01-23 Murray Cumming <murrayc@murrayc.com>
931 ConfiguredDocument: Rename the localedID private member variable.
933 2012-01-23 Murray Cumming <murrayc@murrayc.com>
935 Adapt to the latest java-libglom API from git master.
937 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
938 libglom now uses only Vector instead of List, which uses add() instead of
941 2012-01-22 Murray Cumming <murrayc@murrayc.com>
943 ConfiguredDocument: Rename the localedID private member variable.
945 2012-01-20 Murray Cumming <murrayc@murrayc.com>
947 Build a source tarball with mvn assembly:single
949 * assembly.xml: Add this file.
950 * pom.xml: Use the maven-assembly-plugin and tell it to use
951 our assembly.xml file.
953 2012-01-19 Murray Cumming <murrayc@murrayc.com>
955 OnlineGlomServiceImpl: Get .glom files recursively.
957 * pom.xml: Depend on commons-io from org.apache.commons.
958 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
959 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
960 files recursively, and with the easier filter for the extension.
961 Use org.apache.commons.io.FilenameUtils.removeExtension() to
962 simplify that code too.
964 2012-01-19 Murray Cumming <murrayc@murrayc.com>
966 README: Mention that you must install java-libglom packages separately.
968 But then it works, because java-libglom is now in the central maven
971 2012-01-18 Murray Cumming <murrayc@murrayc.com>
973 locales drop-down: Show the correct selected locale when the URL changes.
975 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
976 .java: setPlace(): Move some code into fillView().
978 2012-01-18 Murray Cumming <murrayc@murrayc.com>
980 locales drop-down: Do not lose the primary key.
982 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
983 start(): onLocaleChange(): Pass the current primary key value,
984 instead of an empty value.
986 2012-01-18 Murray Cumming <murrayc@murrayc.com>
988 locales drop-down: Do not lose the drop-down selection.
990 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
991 .java (TableSelectionActivity.fillView): Set the selected locale
992 after changing the drop-down items (though we do not really need
993 to change them just because the locale changes.)
995 2012-01-18 Murray Cumming <murrayc@murrayc.com>
997 locales drop-down: Change the tables list when this changes.
999 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1000 .java: TableSelectionActivity.start(): Move the async table titles
1001 retrieval into a private fillView() method and also call this when
1002 the chosen locale changes.
1003 Note that the document title is not actually translatable yet, but
1004 that is a problem that I should fix soon in libglom.
1006 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1008 Improve the placement of the locales drop-down.
1010 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1011 Put the title and locales drop-down in a div (gwt.FlowTable).
1012 * src/main/webapp/style.css: Add magic css properties to make this work.
1013 Also remove the left margin from the title so that it lines up with the
1016 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1018 locales selector: Show human-readable locale titles.
1020 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1021 getDocumentInfo(): Use java.util.Locale to show a real title of
1022 each locale, in the locale's own language.
1024 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1026 Add a language/locale selector drop-down.
1028 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1029 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1030 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1031 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1032 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1033 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1034 Add a ListBox to show the available locales. Add getLocaleSelector(),
1035 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1036 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1037 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1038 java: Add these classes.
1039 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1040 start(): Fill the locales ListBox. Handle its change event, firing a
1042 setPlace(): Show the selected locale as specified by the URL token.
1043 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1044 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1045 Handle LocaleChangeEvent, going to a new *Place with that locale.
1047 The placement of the ListBox is not pretty, and it currently uses the ID
1048 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1052 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1054 Search box: Show the search text from the URL token.
1056 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1057 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1058 Add setQuickFindText().
1059 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1060 .java: setPlace(): Store the queryText if the place is a ListPlace,
1061 and call TableSelectionView.setQuickFindText().
1063 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1065 Allow use of translations via, for instance, &lang=de in the URL.
1067 * pom.xml: Use the unstable java-libglom 1.21 version.
1069 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1070 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1071 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1072 init(): Instead of calling TranslatableItem.set_current_locale()
1073 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1074 However, this is only for default locales, which are not needed to
1075 change the locale in the URL.
1076 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1077 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1078 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1079 layout for a particular locale.
1080 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1081 Add get/setDefaultLocaleID().
1082 getDocumentInfo(), getListViewData(), getRelatedListData(),
1083 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1084 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1085 localeID parameter, so we can get the layout for a particular locale.
1087 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1088 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1089 * src/main/java/org/glom/web/client/place/ListPlace.java:
1090 Parse and construct a lang parameter too.
1092 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1093 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1094 passed to subsequent methods and constructors.
1095 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1096 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1097 Store the localeID from the *Place and pass it to other constructors
1098 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1100 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1101 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1102 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1103 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1104 * src/main/java/org/glom/web/client/ui/ListView.java:
1105 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1106 Take localeID parameters and pass them to subsequent constructors and
1107 methods, so that the layout is always retrieved for that locale.
1109 This is rather repetitive.
1111 Note that "" means the original (default) locale of the Glom document,
1112 which is usually English.
1114 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1116 Documents: Remove final keyword to fix startup configuration.
1118 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1119 final keywords on the private member variables because that breaks
1120 the startup, apparently (there are warnings) because it stops them
1121 from being serialized. I added these in the previous commit.
1123 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1125 Documents: Add some final keywords.
1127 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1130 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1132 OnlineGlomServiceImpl: Add to overview comments.
1134 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1135 Note that this is where all the document are loaded. They are not
1136 loaded freshly for each page.
1138 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1142 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1143 Add a TextBox for the text of a quick find.
1144 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1146 setBackLink(): Add a String quickFind parameter.
1147 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1148 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1149 to the base interface, because that is how TableSelectionViewImpl is used.
1150 * src/main/webapp/style.css: Add style for the search box and its label.
1152 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1153 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1154 Add these files, based on the existing TableChangeEvent and
1155 TableChangeEventHandlers.
1156 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1157 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1158 a ListPlace() that the user should be taken to.
1159 * src/main/java/org/glom/web/client/activity/ListActivity.java
1160 start(): Handle it here too and adapt the TableChangeEvent handler to
1161 pass the extra "" quickFind parameter to ListPlace.
1162 * src/main/java/org/glom/web/client/place/ListPlace.java:
1163 Constructor: Take an extra String quickFind parameter and store it,
1164 returning it from a new getQuickFind() method.
1165 getToken(): Put the quickFind text in the URL token.
1166 getPlace(): Parse the quickFind text from the URL token.
1167 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1168 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1169 ListPlace constructor.
1170 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1171 .java: start(): Add a Change handler for the TableSelectionView's
1172 TextBox (via its base HasChangeHandlers interface), firing the new
1173 QuickFindChangeEvent.
1174 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1175 pass the extra "" quickFind parameter.
1177 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1178 setCellTable(): Add a String quickFind parameter and pass it to
1179 the ListViewTable() constructor.
1180 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1181 setCellTable() in the base interface, because that is how ListViewImpl
1184 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1185 Add a String quickFind member variable.
1186 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1187 Constructor: Add a String quickFind parameter, storing it in the
1188 base ListTable's member variable.
1189 onRangeChanged(): Pass quickFind to the
1190 OnlineGlomServiceAsync.getSortedListViewData() and
1191 OnlineGlomServiceAsync.getListViewData() methods.
1193 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1194 getListViewData(), getSortedListViewData(): Add a String quickFind
1195 parameter, passing it to ConfiguredDocument.getListViewData().
1196 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1197 Change getListViewData(), getSortedListViewData() in the base interface,
1198 because that is how OnlineGlomServiceImpl is used, via this:
1199 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1200 Change getListViewData(), getSortedListViewData() here too.
1201 This class can apparently be used to asynchronously call methods on
1202 OnlineGlomService, and GWT seems to implement that after recognizing
1203 just the *Async name convention and the extra AsyncCallback parameters.
1205 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1206 getListViewData(): Add a String quickFind parameter, and pass it to
1207 ListViewDBAccess.getData().
1208 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1209 getListData(): Add a String quickFind parameter and pass it to
1211 getSelectQuery(): Add a String quickFind parameter.
1212 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1213 getSelectQuery(): Add a String quickFind parameter and use it with
1214 Glom.get_find_where_clause_quick() to pass a where_clause to
1215 Glom.build_sql_select_with_where_clause(), to actually filter the
1217 getData(): Add a String quickFind parameter, passing it to getListData().
1218 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1219 va: getData(): Pass an empty string to getListData() for the
1220 quickFind parameter.
1222 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1224 ListTable: Minor change.
1226 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1227 createCellTable(): Make this protected instead of public.
1229 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1231 Many files: Use final for the parameters and use the @override attribute.
1233 2012-01-22 Ben Konrath <ben@bagu.org>
1235 Add anchor links for single line text that starts with http, ftp and www.
1239 2012-01-22 Ben Konrath <ben@bagu.org>
1241 Add ellipsis to single line text in details view.
1245 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1247 Remove all javadoc author tags.
1249 Because they are awkward and meaningless when many people touch
1251 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1253 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1255 Revert the COPYING.LESSER to COPYING rename.
1257 Apparently both should be there if it is LGPL.
1259 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1261 *View: Remove unused imports.
1263 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1264 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1265 * src/main/java/org/glom/web/client/ui/ListView.java:
1266 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1267 Remove unused imports, as suggested by Eclipse.
1269 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1271 Move the *View::Presenter types, and some API into one base View.
1273 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1274 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1275 * src/main/java/org/glom/web/client/ui/ListView.java:
1276 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1277 Presenter, setPresenter() and clear() into a shared base interface,
1278 to avoid the unnecessary duplicate Presenter types and to more clearly
1279 show how the *Views share the same structure, even if they are not
1280 used polymorphically.
1282 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1283 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1285 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1286 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1287 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1289 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1292 Feel free to revert this if there is a good reason for the duplicate
1295 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1297 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1299 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1300 a class member instead of a local variable in the method.
1301 This lets us use it to get the view instances, for use in tests.
1302 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1303 beforeOnlineGlom(): Test some more details of the initial view.
1304 Again, this is not very useful.
1306 To really test gwt-glom we will need to start a local postgresql
1307 instance with local data, like the Glom tests in C++.
1309 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1311 pom.xml: Mention the LGPL license.
1313 * pom.xml: Add a licenses section.
1314 * COPYING.LESSER: Move this to COPYING, which
1315 previously contained the GPL. But gwt-glom is all LGPL.
1317 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1319 Add project information to README and pom.xml.
1321 * README: Add a brief description and mention some mvn
1323 * pom.xml: This extra information shows up in mvn site
1326 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1328 Use the latest java-libglom version.
1330 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1332 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1334 GwtTestOnlineGlom: Test a little more.
1336 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1337 protected rather than private, as suggested by the gwt-test-utils
1339 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1340 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1341 Test the initial visibility of the panels.
1343 However, this is not a very useful test.
1344 And I wonder how we should generally test using this idea for an
1345 activity/places app like ours where the real changes happen implicitly
1346 based on the history token/URL.
1348 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1350 Slight modification to *Mapper comments.
1352 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1353 (DataActivityMapper)
1354 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1356 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1358 Remove comments mentioning GIN because they are just copied from
1359 the example code and are apparently not helpful:
1360 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1361 Also change the mention of a class that is only in the example code.
1363 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1365 GwtTestOnlineGlom test: Minor changes.
1367 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1368 Avoid the long qualified class name and modify the comment
1369 because it is now obvious to me that the mocked class is the only
1370 custom one created via GWT.create().
1372 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1374 Tests: Added the beginnings of a test using gwt-test-utils.
1376 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1377 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1378 which tells gwt-test-utils what class will be tested.
1379 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1380 Add a simple (but empty) test case. One class, used by the OnlineGlom
1381 class, is mocked so that it can be created. However, I am not sure
1382 why only this class needs to be mocked.
1384 Note that mockito seems more popular, and clearer, than easymock,
1385 but I have not got that working yet. It might be a matter of the
1388 This test is run during mvn integration-test.
1390 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1392 Tests: Use junit4-style syntax instead of junit3-style.
1394 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1395 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1396 * src/test/java/org/glom/web/shared/DataItemTest.java:
1397 Use the @Test annotation rather than relying on the test*() prefix.
1398 Also no longer implement TestCase, to avoid triggering support for
1399 the junit3-way, which stops the annotations from working.
1400 Change the imports from import junit.framework.* to
1401 import org.junit.*, which is apparently the new way.
1403 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1405 Added a test for ListPlace token parsing and creation.
1407 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1408 This is much the same as DetailsPlaceTest.
1410 I wonder how we could test the other parts of the *Place API.
1412 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1414 DetailsPlace test: Also test getToken() and recreation via getPlace().
1416 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1417 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1418 recreate it, testing the recreated DetailsPlace for the same parameter
1421 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1423 Use the surefire-report plugin.
1425 * pom.xml: This generates a HTML report about the tests in
1426 target/site/surefire-report.html
1427 when you do mvn surefire-report:report. It seems to be popular/normal.
1429 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1431 Added a test for DetailsPlace.
1433 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1434 Test the getPlace() token parsing.
1436 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1438 Added a first unit test.
1440 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1441 * src/test/java/org/glom/web/shared/DataItemTest.java:
1442 This is a silly test but it is just to get things started. Note that
1443 maven/junit finds the test because it looks in src/test by default.
1445 2011-12-22 Ben Konrath <ben@bagu.org>
1447 Change charsetName to "UTF-8" when replacing line breaks.
1449 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1450 that work in Java (such as "UTF8") will not work when compiled to
1453 This fixes a problem with multi-line details view fields that have hard
1454 line breaks. The "License Text" field on this page demonstrates the
1457 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1459 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1461 2011-12-22 Ben Konrath <ben@bagu.org>
1463 Fix another bug with related list navigation.
1465 I've tested all the navigation buttons in all of the related lists
1466 so things should be good now.
1468 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1470 2011-12-22 Ben Konrath <ben@bagu.org>
1472 Fix a crasher when refreshing the list view with the default table.
1474 This crash will also happen when loading the list view with the default
1475 table from a link or bookmark.
1477 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1478 to the main document selection page when the document id hasn't been
1480 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1481 the main document selection page when the document id hasn't been
1483 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1484 values for the details place when the document id hasn't been set.
1485 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1486 values for the list place when the document id hasn't been set.
1488 2011-12-21 Ben Konrath <ben@bagu.org>
1490 Protect against NPE when glom.document.locale is not in config.
1492 This patch protects against an NPE when glom.document.locale is not in
1493 the config file. This NPE will also happen if glom.document.locale is
1496 The patch also updates the error message to display the class name when
1497 the getMessage() returns null. This was happening when the NPE was
1498 thrown and I had "Configuration Error: null". If an NPE is encountered
1499 with this patch, "Configuration Error: NullPointerException " will be
1502 This commit closes this bug:
1504 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1506 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1508 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1510 Rename onlineglom.properties to onlineglom.properties.sample.
1512 * src/main/resources/onlineglom.properties: Rename to:
1513 * src/main/resources/onlineglom.properties.sample:
1514 * src/main/resources/README: And add this file explaining that people
1515 should rename it back when deploying.
1517 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1519 Allow choosing the translation in the .properties file.
1521 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1522 init(): Read a glom.document.locale value from the configuration file
1523 and call Glom's TransatableItem::set_current_locale() method.
1524 * src/main/resources/onlineglom.properties: Add a commented-out
1525 example of this new setting.
1527 It would be better to add &lang=de_DE to the URL, but the current
1528 libglom API does not allow us to do this easily. I am working on that.
1530 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1532 Avoid a crash in parsing of token parameters.
1534 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1535 ava: getTokenParams(): Do not crash if a parameter has a key but no
1536 value, and ignore parameters with neither.
1538 2011-12-17 Murray Cumming <murrayc@murayc.com>
1540 History token building/handling: Improve use of token parameters.
1542 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1543 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1544 and buildParamsToken(HashMap), for use by derived classes.
1545 Make the separator private because it is no longer be needed.
1546 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1547 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1548 instead of manual string concatenation.
1549 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1550 of hardcoded indices and awkward splitting code.
1551 * src/main/java/org/glom/web/client/place/ListPlace.java
1552 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1553 instead of manual string concatenation.
1554 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1555 of hardcoded indices and awkward splitting code.
1556 This should fix bug #666420
1558 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1560 Fix a Navgiation->Navigation typo in the code.
1562 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1563 Rename processNavgiation() to processNavigation().
1565 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1567 Fix a seperator->separator typo in the code.
1569 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1570 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1571 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1574 2011-12-15 Ben Konrath <ben@bagu.org>
1576 Cleanup some comments.
1578 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1580 2011-12-14 Ben Konrath <ben@bagu.org>
1582 Replace \n with <br/> for multiline text in the details view.
1584 Vertical scrollbars are added when needed as well.
1586 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1588 2011-12-14 Ben Konrath <ben@bagu.org>
1590 Specify the font for document selection links.
1592 * src/main/webapp/style.css:
1594 2011-12-14 Ben Konrath <ben@bagu.org>
1596 Fix bouncy CellTable while paging.
1598 This doesn't currently work with related list tables in unselected
1601 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1603 2011-12-14 Ben Konrath <ben@bagu.org>
1605 Revamp the appearance of the document selection page.
1607 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1608 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1609 * src/main/webapp/style.css:
1611 2011-12-13 Ben Konrath <ben@bagu.org>
1613 Set navigation button column to the smallest size possible.
1615 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1617 2011-12-13 Ben Konrath <ben@bagu.org>
1619 Change OpenButton nomenclature to NavigationButton.
1621 Using NavigtionButton makes things more generic. Classes, methods and
1622 variables have been changed.
1624 This is a rename-only refactor.
1626 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1627 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1628 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1629 Renamed from OpenButtonCell.
1630 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1631 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1632 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1634 2011-12-12 Ben Konrath <ben@bagu.org>
1636 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1638 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1639 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1640 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1641 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1643 2011-12-12 Ben Konrath <ben@bagu.org>
1645 Update variable names and comments.
1647 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1648 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1650 2011-12-12 Ben Konrath <ben@bagu.org>
1652 Properly initialize numNonEmptyRows variable to zero.
1654 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1655 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1657 2011-12-05 Ben Konrath <ben@bagu.org>
1659 Add latest mockup with HTML tables.
1661 Features of this mockup:
1663 -> HTML table for flowtable
1664 -> HTML table for flowtable column
1665 -> Example of how related lists would look
1666 -> Not using text entries for data items
1668 The current version of Online Glom doesn't use HTML tables for the
1671 This mockup has been sent to the glom-devel mailing list but it's good
1672 to have it here as well.
1674 * mockups/details-view-html-tables.html:
1676 2011-12-05 Ben Konrath <ben@bagu.org>
1678 Remove unnecessary getPrimaryKeyField() method.
1680 getPrimaryKeyFieldForTable(String) has been renamed to
1681 getPrimaryKeyField(String).
1683 * src/main/java/org/glom/web/server/database/DBAccess.java:
1684 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1685 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1687 2011-12-05 Ben Konrath <ben@bagu.org>
1689 Add string representation of TypedDataItem value to conversion error message.
1691 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1692 message was extracted into its own method to avoid duplication.
1694 2011-12-05 Ben Konrath <ben@bagu.org>
1696 Add type checking to navigation primary key value creation.
1698 Create navigation primary key only if the expected type from the Glom
1699 document matches the type returned by the SQL query.
1701 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1703 2011-12-05 Ben Konrath <ben@bagu.org>
1705 Rename a couple of variables in RelatedListNavigation.
1707 This is a rename-only refactor.
1709 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1711 2011-12-05 Ben Konrath <ben@bagu.org>
1713 Move getListLayoutGroup() into getListViewLayoutGroup().
1715 This removes getListLayoutGroup(). It was only being called by
1716 getListViewLayoutGroup().
1718 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1720 2011-12-05 Ben Konrath <ben@bagu.org>
1722 Remove check for LayoutItem_Portal in list table method.
1724 This check is no longer necessary because the method isn't being used
1725 to create the LayoutItemPortal DTO.
1727 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1729 2011-12-05 Ben Konrath <ben@bagu.org>
1731 Properly support related list navigation.
1733 Navigation from the "Repository Analyzer -> Package Scans ->
1734 Dependencies" related table wasn't working because the primary key for
1735 related tables wasn't being set properly. This commit fixes the
1738 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1739 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1740 doesn't set the primary key properly for related list tables.
1741 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1742 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1743 useful for getting the primary key for list view tables and for related
1745 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1746 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1747 Move code to set the primary key for the table from the abstract
1748 ListDBAccess class to ListViewDBAccess as it's only correct for list
1750 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1751 Properly add primary key to related list tables.
1753 2011-12-02 Ben Konrath <ben@bagu.org>
1755 Properly set the horizontal alignment of fields.
1757 This fix is for both the list tables and the details view.
1759 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1760 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1761 to set the horizontal alignment of fields.
1763 2011-12-02 Ben Konrath <ben@bagu.org>
1765 Display currency codes in the details view.
1767 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1769 2011-12-02 Ben Konrath <ben@bagu.org>
1771 Avoid duplicate JNI call.
1773 JNI is not as efficient as pure Java and this is an easy (and small)
1776 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1777 Use previously retrieved value for whereClauseToTableName instead of
1780 2011-12-02 Ben Konrath <ben@bagu.org>
1782 Rename a couple of variables in RelatedListNavigation.
1784 This is a rename-only refactor.
1786 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1788 2011-12-02 Ben Konrath <ben@bagu.org>
1790 Indicate clearly that a mismatched primary key type is a bug.
1792 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1793 warning to error. Add 'This is a bug.' to message.
1795 2011-12-02 Ben Konrath <ben@bagu.org>
1797 Update / fix some comments.
1799 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1801 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1803 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1804 Fix comments. Add some TODOs.
1806 2011-12-02 Ben Konrath <ben@bagu.org>
1808 Enable navigation to details view with string primary key from related list.
1810 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1811 Create a text primary key value when return type of result is
1812 java.sql.Types.VARCHAR.
1814 2011-12-02 Ben Konrath <ben@bagu.org>
1816 Use checkboxes for booleans in the details view.
1818 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1820 2011-12-01 Ben Konrath <ben@bagu.org>
1822 Improve performance of related list height calculation.
1824 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1825 Put code to calculate the expected height in a static initializer so
1826 that that it's only called once.
1828 2011-12-01 Ben Konrath <ben@bagu.org>
1830 Show related list tables in notebooks (again).
1832 Calculate the height of the related list tables so the Notebook can be
1833 set the correct height. The height of the related list table is also needed by
1834 FlowTable to be able decide how to create the layout.
1836 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1837 and set the Portal height based on the height of the related list
1838 table and the Portal container.
1839 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1840 Add method to calculate the height of the related list tables.
1841 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1842 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1843 calculate the height of the Pager widget.
1845 2011-12-01 Ben Konrath <ben@bagu.org>
1847 Use CellTable API for table property instead of setting style on Element.
1849 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1851 2011-12-01 Ben Konrath <ben@bagu.org>
1853 Make ListViewTable and RelatedListTable a consistent height.
1855 The tables are now a consistent height regardless of the contents of
1856 the table. A hidden button is added to empty rows to ensure that the
1857 height of these rows will match the height of rows with data.
1859 A navigation button column is now added to every table. The width of
1860 the navigation column is set to 0px when a RelatedListTable shouldn't
1861 have navigation buttons. This maintains the a consistent row height in
1862 tables that don't show the navigation buttons.
1864 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1865 navigation column when not needed.
1866 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1867 arguments for navigation button to constructor of ListViewTable.
1868 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1869 hidden button for empty data rows.
1870 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1871 arguments for navigation button to constructor.
1872 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1873 create navigation buttons. Add hideNavigationButtons() method.
1874 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1875 arguments for navigation button to constructor.
1877 2011-12-01 Ben Konrath <ben@bagu.org>
1879 Use 'visibility: hidden' in Utils.getWidgetHeight().
1881 This is better choice because hidden elements are invisible, don't
1882 respond to events and are not part of the tab order. They will,
1883 however, take up space which is required to be able to calculate the
1884 height of the widget.
1886 * src/main/java/org/glom/web/client/Utils.java:
1888 2011-12-01 Ben Konrath <ben@bagu.org>
1890 Use Utils.getWidgetHeight() in FlowTable.
1892 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1894 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1896 2011-12-01 Ben Konrath <ben@bagu.org>
1898 Put the details css class name on the correct table column.
1900 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1902 2011-11-30 Ben Konrath <ben@bagu.org>
1904 Update for java-libglom API change.
1906 The getters and setters on FieldFormatting and NumericFormat were
1907 changed to remove the 'M'.
1909 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1911 2011-11-29 Ben Konrath <ben@bagu.org>
1913 Only allow RelatedListTables in Portals.
1915 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1917 2011-11-29 Ben Konrath <ben@bagu.org>
1919 Only create a contents panel for Portals when title is being set.
1921 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1923 2011-11-29 Ben Konrath <ben@bagu.org>
1925 Set TabLayoutPanel height based on calculated height its widgets.
1927 This is a potential fix for this bug:
1929 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1931 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1933 2011-11-29 Ben Konrath <ben@bagu.org>
1935 Align details field labels and data with the Open buttons.
1937 * src/main/webapp/style.css:
1939 2011-11-29 Ben Konrath <ben@bagu.org>
1941 Remove unnecessary <div> in the Notebook widget.
1943 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1944 method to get container FlowPanel (<div>).
1945 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1946 initWidget() method directly on the TabLayoutPanel widget instead of
1947 Group's container widget.
1949 2011-11-29 Ben Konrath <ben@bagu.org>
1951 Don't add group titles for Portals in Notebooks.
1953 This reverts the previous patch and fixes a bug I introduced with
1954 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1956 * src/main/java/org/glom/web/client/ui/details/Group.java:
1957 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1959 2011-11-28 Ben Konrath <ben@bagu.org>
1961 Remove unused boolean argument in Portal constructor.
1963 Just a code cleanup.
1965 * src/main/java/org/glom/web/client/ui/details/Group.java:
1966 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1968 2011-11-28 Ben Konrath <ben@bagu.org>
1970 Remove hack for glom 1.18 style glom files.
1972 * src/main/java/org/glom/web/client/ui/details/Group.java:
1973 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1974 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1976 2011-11-28 Ben Konrath <ben@bagu.org>
1978 Use Gda Value version of primary key to log result too large error.
1980 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1982 2011-11-28 Ben Konrath <ben@bagu.org>
1984 Don't use TypedDataItem.getText() for Unknown types from the URL.
1986 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1987 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1988 instead of getText().
1989 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1990 String field and getUnknown() method.
1992 2011-11-28 Ben Konrath <ben@bagu.org>
1994 Log an error message when the java-libglom .so is not present.
1996 The error message was being set in the exception but not logged.
1998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2000 2011-11-28 Ben Konrath <ben@bagu.org>
2002 Ignore LayoutItem_CalendarPortals.
2004 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2005 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2007 2011-11-28 Ben Konrath <ben@bagu.org>
2009 Extract method for creating the LayoutItemPortal DTO.
2011 Just breaking the code up into smaller chunks.
2013 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2015 2011-11-28 Ben Konrath <ben@bagu.org>
2019 This should have been added with the refactor. Oops!
2021 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2023 2011-11-28 Ben Konrath <ben@bagu.org>
2025 Create primary key value from URL string using type from Glom document.
2027 See this bug, comments 19 - 25:
2029 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2031 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2032 create a TypeDataItem for the primary key here when loading from a
2033 URL. Show the same string for the primary key value as was received
2034 from the URL string (when loading from a URL).
2035 * src/main/java/org/glom/web/server/Utils.java: Update method for
2036 creating the Gda Value from the TypeDataItem to properly deal with
2037 creating a Gda Value based on the Glom document type for the primary
2038 key value string when loading from a URL.
2039 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2040 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2041 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2042 Update for changed method name.
2044 2011-11-27 Ben Konrath <ben@bagu.org>
2046 Rename PrimaryKeyItem to TypedDataItem.
2048 The name PrimaryKeyItem suggests what the class should be used for.
2049 TypedDataItem is a neutral name that describes the class better.
2051 This is a rename-only refactor.
2053 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2054 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2055 * src/main/java/org/glom/web/client/Utils.java:
2056 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2057 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2058 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2059 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2060 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2061 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2062 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2063 * src/main/java/org/glom/web/server/Utils.java:
2064 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2065 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2066 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2067 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2069 2011-11-25 Ben Konrath <ben@bagu.org>
2071 Improve Gda Value conversion from PrimaryKeyItem.
2073 The value from the PrimaryKeyItem is only used if its type match the
2074 type from the glom document.
2076 * src/main/java/org/glom/web/server/Utils.java:
2078 2011-11-25 Ben Konrath <ben@bagu.org>
2080 Manually check if the java-liblgom .so is visible to the JVM.
2082 It seems that Tomcat has problems when a static initializer throws an
2083 exception. This check is done before the first method call into
2084 java-libglom so that execution doesn't continue if the .so is not
2087 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2089 2011-11-25 Ben Konrath <ben@bagu.org>
2091 Improve browser configuration error messages.
2095 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2097 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2098 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2099 getConfigurationErrorMessage() method.
2100 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2101 Get and display a specific configuration error message when no Glom
2102 documents are found.
2103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2104 Implement getConfigurationErrorMessage() method. Surround configuration
2105 code in the init() method with a try/catch block. This allows the
2106 errors to be caught while keeping the servlet available to retrieve the
2107 configuration error message.
2109 2011-11-25 Ben Konrath <ben@bagu.org>
2111 Don't use Strings to hold primary key values.
2113 The primary key values are now held in a new data object
2114 (PrimaryKeyItem) that holds type information and the primary key value
2115 using the correct type.
2117 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2118 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2119 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2120 PrimaryKeyItem instead of String to hold the primary key value.
2121 * src/main/java/org/glom/web/client/Utils.java: Remove
2122 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2123 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2124 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2125 PrimaryKeyItem instead of String to hold the primary key value. Load
2126 document selection page when the documentID has not been set correctly.
2127 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2128 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2130 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2131 Return empty string for URL instead of "null".
2132 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2133 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2134 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2135 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2136 PrimaryKeyItem instead of String to hold primary key values.
2137 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2138 PrimaryKeyValue to a Gda Value.
2139 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2140 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2141 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2142 Replace temporary database access code that uses the PrimaryKeyValue to
2143 Gda Value conversion.
2144 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2145 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2146 PrimaryKeyItem instead of String.
2147 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2148 hold primary key values.
2150 2011-11-24 Ben Konrath <ben@bagu.org>
2152 Use newly added java-libglom API to create queries.
2154 This isn't finished. I still need to stop using Strings for primary key
2155 values in the client code.
2157 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2158 libglom to use fake connections so that retrieving the query string will
2160 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2161 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2162 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2163 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2164 Use the newly added libglom sql methods and classes to create the
2165 query. Add temporary hack to convert primary value strings to Gda
2168 2011-11-23 Ben Konrath <ben@bagu.org>
2170 Don't explicitly set the height of Portals.
2172 See comments 6 - 10 of this bug for details:
2174 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2176 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2178 2011-11-23 Ben Konrath <ben@bagu.org>
2180 Use an HTML table instead of CSS for the FlowTable layout.
2182 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2183 GWT's FlexTable to implement the FlowTable.
2184 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2186 2011-11-18 Ben Konrath <ben@bagu.org>
2188 Add boolean example to HTML table mockup.
2190 * mockups/details-view-html-tables-text-entries.html:
2192 2011-11-17 Ben Konrath <ben@bagu.org>
2194 Ensure the pager buttons are always visible for related lists.
2196 To accomplish this, I've turned off text wrapping in the list view and
2197 related list tables for both the header and data text. The related list
2198 table now has a fixed layout so the it doesn't overflow its container.
2199 This is required to ensure that the cell text is clipped when it
2200 overflows the cell and an ellipsis is added to the right side of the
2201 cell when text is clipped.
2203 A fixed table layout for the related list table in the details view
2204 seems what we want for the details view anyway, so the side-effect is
2207 The ellipsis will only be displayed in Firefox >= 7.
2211 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2213 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2214 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2215 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2217 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2218 Set the 'table-layout: fixed' CSS property to the related list table.
2219 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2220 'white-space: nowrap;' CSS property on both the list view and the
2221 related list tables.
2223 2011-11-16 Ben Konrath <ben@bagu.org>
2225 Rework the fix for empty notebook tab labels.
2227 Setting the empty group titles with its name caused problems for the
2228 details layout. Instead of using libglom's
2229 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2230 to the client when the title is empty. This allows the Notebook to use
2231 the name when the title is empty without affecting anything else.
2233 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2234 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2236 2011-11-16 Ben Konrath <ben@bagu.org>
2238 Set group titles with name when title is empty.
2240 This fixes a problem with an empty notebook tab label in the Lesson
2241 Planner document. The forth tab in the notebook should be "Internet":
2243 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2245 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2246 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2249 2011-11-16 Ben Konrath <ben@bagu.org>
2251 Remove whitespace from the configured username properties.
2253 This assumes that usernames won't have whitespace at the beginning
2254 or end. But I think this is a reasonable assumption.
2256 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2257 String.trim() to remove the whitespace from the username properties.
2259 2011-11-15 Ben Konrath <ben@bagu.org>
2261 Add details view mockup with HTML tables and text entries.
2263 This is from the attachment on this bug:
2265 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2267 * mockups/details-view-html-tables-text-entries.html:
2269 2011-11-15 Ben Konrath <ben@bagu.org>
2271 Add space between the columns of the flow table.
2275 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2277 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2278 space between columns in the flow table.
2280 2011-11-15 Ben Konrath <ben@bagu.org>
2282 Add backup files to the .gitignore.
2284 * .gitignore: Ignore files that end with ~.
2286 2011-11-09 Ben Konrath <ben@bagu.org>
2288 Use latest release of gwt-log.
2290 Gwt-log releases are now being submitted to the maven central
2291 repository so manual installation of the jar is no longer required.
2293 * pom.xml: Update version and groupId of gwt-log dependency.
2295 2011-10-31 Ben Konrath <ben@bagu.org>
2297 Don't use GWT numeric formatting to override the glom currency formatting.
2299 Currencies are now displayed like they are in Glom. See this bug:
2301 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2303 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2305 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2306 currency code to constructor and set it when the cell is rendered.
2307 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2308 currency code to the constructor of the NumericCell.
2310 2011-10-27 Ben Konrath <ben@bagu.org>
2312 Require the latest release of java-libglom (1.17.4).
2316 2011-10-26 Ben Konrath <ben@bagu.org>
2318 Add style to Notebook that matches current theme.
2320 It's not the best style in the world but it's better than the default.
2322 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2323 padding at the bottom of the child widgets.
2324 * src/main/webapp/style.css: Add style for the Notebook.
2326 2011-10-26 Ben Konrath <ben@bagu.org>
2328 Move servlet initialization code to overridden init method.
2330 This is half of the solution to getting proper error messages
2331 displayed when configuration errors occur. Here's the relevant bug:
2333 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2335 The rest of the solution involves surrounding the init method with a
2336 try/catch block and setting a global variable with the error /
2337 exception. A new async method should be created to retrieve and display
2338 the error message / exception.
2340 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2341 code from constructor to init method adding exceptions as needed.
2343 2011-10-26 Ben Konrath <ben@bagu.org>
2345 Add script to monitor and restart tomcat if required.
2347 * utils/check-and-recover-tomcat.py: New file.
2349 2011-10-26 Ben Konrath <ben@bagu.org>
2351 Display the correct number of data items in the pager.
2355 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2357 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2358 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2359 The implementation is the same for both tables: Keep track of the
2360 number of non-empty rows and fire and RowCountChangeEvent after the data has
2362 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2363 custom Pager class that subclasses SimplePager to handle displaying
2364 the correct number when empty rows have been added.
2366 2011-10-26 Ben Konrath <ben@bagu.org>
2368 Correct error in previous commit.
2370 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2371 eventBus parameter from listView.setCellTable().
2373 2011-10-26 Ben Konrath <ben@bagu.org>
2375 Fix error in TODO comment.
2377 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2379 2011-10-24 Ben Konrath <ben@bagu.org>
2381 Create Notebook widgets to the details view.
2383 This isn't finished just yet - I still need to create a reasonable
2384 style to match the current theme.
2386 * src/main/java/org/glom/web/client/Utils.java: Add method for
2387 calculating the height of a widget. This is used in the Notebook class.
2388 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2389 new constructor method in Group.
2390 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2391 method for creating child widget that can be used by subclasses
2392 like Notebook. New constructor that allows disabling the group
2393 titles - Notebooks don't set a group title for their child groups.
2394 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2395 to make Notebooks using GWT's TabLayoutPanel.
2396 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2397 constructor that allows disabling the group titles.
2398 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2399 LayoutItemNotebook DTO.
2400 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2401 DTO for Notebooks. It's just an empty class for now but we might need
2402 it to transfer some specific information in the future.
2404 2011-10-21 Ben Konrath <ben@bagu.org>
2406 Add navigation buttons to related list tables.
2408 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2409 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2410 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2411 method getSuitableRecordToViewDetails() for getting the table name
2412 and primary key value for related list navigation buttons.
2413 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2414 private cell renderer class to get the navigation information for
2415 related list tables from the server. Extract the navigation
2416 processing code from the details cell navigation and use it for the
2417 related list navigation as well.
2418 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2419 cell renderer class for the details open buttons. This was needed
2420 because the related list navigation buttons and the list view
2421 navigation buttons need to react differently when clicked.
2422 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2423 the onEnterKeyDown() method because it's now overriden in the
2424 subclasses that are specific to the related list tables and the list
2426 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2427 the vertical size a little because the buttons add a bit of vertical
2428 space to table. This is not a perfect solution because the vertical
2429 size of with table fewer than 5 rows will be a little smaller.
2430 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2431 changes in how navigation buttons are handled.
2432 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2433 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2434 database access object.
2435 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2436 to find the portal for a given relationship name from
2437 RelatedListDBAccess. Add method to find a primary key field for a
2439 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2440 Move code to find the portal for a given relationship name to
2442 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2443 New file: database access object for getting the related list
2444 navigation information (the table name and the primary key value).
2445 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2446 DTO for transferring a table name to navigate to and a primary key
2448 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2449 boolean and getter/setter to specifies if the related list should add
2452 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2454 Use the master branch of java-libglom
2456 * pom.xml: Depend on java-libglom 1.19 instead.
2458 This is the master branch. See also the libglom-1-18 branch.
2460 2011-10-11 Ben Konrath <ben@bagu.org>
2462 Enable the open navigation button when the data has been set.
2464 This avoids having active buttons that don't do anything when the data
2467 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2469 2011-10-11 Ben Konrath <ben@bagu.org>
2471 Use IsWidget interface for FlowTableItem.
2473 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2474 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2476 2011-10-11 Ben Konrath <ben@bagu.org>
2478 Remove GWT styling from open button in details view.
2480 There are still some issues with how the details cell is arranged but
2481 this should be made to match Glom 1.20. I'm going to leave fixing this
2482 until I have Glom 1.20 up and running.
2484 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2485 style name on open button.
2486 * src/main/webapp/style.css: Move and edit details-navigation class.
2487 Re-arrange some classes to make them appear in the same order as the
2490 2011-10-07 Ben Konrath <ben@bagu.org>
2492 Update to GWT 2.4.0.
2494 * .gitignore: Ignore new cache directory.
2495 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2496 * pom.xml: Change GWT and maven plugin to 2.4.0.
2497 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2499 * src/main/java/org/glom/web/client/ClientFactory.java:
2500 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2501 * src/main/java/org/glom/web/client/OnlineGlom.java:
2502 Update source for API changes.
2503 * utils/build-onlineglom-war.sh: Remove cache directory before the
2506 2011-10-07 Ben Konrath <ben@bagu.org>
2508 Add navigation buttons in the details view.
2510 This isn't finished but I thought I'd commit what I have as it's a
2511 pretty good start. I still need to:
2513 1. Change the style so that it fits better into the current theme
2514 2. Adjust the details cell to expand as much as possible.
2516 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2517 click handlers to navigation buttons in the DetailsCells. Create a
2518 refreshData() method to get just the data from the server without the
2520 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2521 Update the tableSelector and browser title when the table name
2522 changes without using the tableSelector.
2523 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2524 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2525 getDetailsCells() to getCells(). Update variable names.
2526 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2527 method to set click handler on navigation button. Rename a few
2528 variables. Add navigation buttons where needed.
2529 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2530 variables and methods.
2531 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2532 navigation boolean and navigation table as required in the
2533 LayoutItemField DTO.
2534 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2535 variables for navigation along with getter/setter methods.
2537 2011-10-07 Ben Konrath <ben@bagu.org>
2539 Rename Field to DetailsCell.
2541 This is a refactor-only commit. No functionality has been added or
2544 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2545 Update variable and method names.
2546 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2547 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2548 variable and method names.
2549 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2551 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2552 variable and method names.
2554 2011-10-07 Ben Konrath <ben@bagu.org>
2556 Create separate methods for layout and data the details view.
2558 This is a refactor-only commit. No functionality has been added or
2561 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2562 private methods: setData(), createLayout().
2564 2011-10-07 Ben Konrath <ben@bagu.org>
2566 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2568 This is part of a change to get navigation buttons in the details view
2569 but it should have been done this way from the start.
2571 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2572 for method name change in TableSelectionView.
2573 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2574 Create TableChangeEvent and set the browser title using the
2575 TableSelectionView API.
2576 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2577 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2578 Change getSelectedTable() to getSelectedTableName(). Add
2579 getSelectedTableTitle().
2581 2011-10-07 Ben Konrath <ben@bagu.org>
2583 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2585 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2587 2011-10-07 Ben Konrath <ben@bagu.org>
2589 Update TableChangeEvent to use newTableName naming convention.
2591 This makes the class more consistent with GWT naming conventions.
2593 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2594 Update for method name change in TableChangeEvent.
2595 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2596 for method name change in TableChangeEvent.
2597 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2598 newTableName variable and getter method. Make toDebugString()
2601 2011-09-30 Ben Konrath <ben@bagu.org>
2603 Disable the pager in the list tables when the data row count is less than the minimum.
2605 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2606 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2608 2011-09-30 Ben Konrath <ben@bagu.org>
2610 Add empty rows to the end of related list and list view tables.
2612 I also extracted the cell rendering classes from the ListTable because
2613 the code was becoming a little crazy with all the anonymous inner
2614 classes. My plan is to use these cell rendering classes in the details
2615 view as well so this refactor will be needed for that change.
2617 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2618 set the row count in related list tables if the data has more rows
2619 than the minimum number of rows visible.
2620 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2621 row count in list view tables if the data has more rows than the
2622 minimum number of rows visible.
2623 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2624 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2626 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2627 for rendering TYPE_NUMERIC cells. The code was extracted from the
2629 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2630 class for rendering cells with buttons in list views. The code was
2631 extracted from the ListTable class.
2632 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2633 for rendering TYPE_TEXT cells. The code was extracted from the
2635 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2636 Add empty rows to the end of the data if required. Implement
2637 ListTable.getMinNumVisibleRows().
2638 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2639 cell renderer code to public classes. Return null in
2640 Column.getValue() for empty rows. Add new abstract method:
2641 getMinNumVisibleRows(). Move code to set the row count of the list view
2642 table to ListViewImpl.
2643 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2644 empty rows to the end of the data if required. Implement
2645 ListTable.getMinNumVisibleRows().
2648 2011-09-27 Ben Konrath <ben@bagu.org>
2650 Use GWT.log for client-side debugging statements.
2652 These are optimized out when deployed so I should have used this method
2653 in the first place. These statements will eventually be replaced with some sort
2654 of notification in the browser.
2656 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2657 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2658 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2659 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2660 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2662 2011-09-27 Ben Konrath <ben@bagu.org>
2664 Put tableselector on the right, back to list link on right.
2666 The idea is that the table selector is acting like a label for the
2667 currently displayed table so it should be placed below the document title. This
2668 puts the table title in a similar position to where it is in Glom.
2670 * mockups/details-contacts.html:
2671 * mockups/details-projects.html:
2672 * mockups/listview-contacts.html:
2673 * mockups/listview-projects.html:
2674 * mockups/style.css:
2675 Update mockups to match how the interfaces currently look.
2676 * src/main/webapp/style.css: Swap positions of backlink with the table
2677 selector. Add some space on the left side of the table selector to
2678 line things up with the document title.
2680 2011-09-27 Ben Konrath <ben@bagu.org>
2682 Add field colouring to details view.
2684 This change re-works how field colouring works. The colour formatting
2685 information is now set to the client with the layout information instead of
2686 with the data. This eliminates the need to send the same colour strings for
2687 data in list view column when colour information is set.
2689 In order to set an alternate colour for negative numeric values, the
2690 number is now sent to client and formatted with the GWT NumberFormat class.
2692 This change also fixes:
2694 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2696 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2697 internationalization framework which is needed for client side numeric
2699 * src/main/java/org/glom/web/client/Utils.java: New file for some
2700 client static utility methods.
2701 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2702 the DataItem object to the Field class. Use a utility method to
2703 create the foreignKeyValue string.
2704 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2705 alignment and text colours in the constructor. Add setData(DataItem)
2706 method. Remove setText(String) method.
2707 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2708 colour information to GlomTextCell. Create and use GlomNumberCell for
2709 rendering numbers. Use utility method to get the string for the
2710 primary key of the key provider. Re-work how the horizontal alignment
2712 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2713 formatting to layout information. Methods for converting the libglom
2714 formatting information were moved from DBAccess.
2715 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2716 numeric formatting (it's now done on the client side). Don't set text
2717 colours in DataItem. Move libglom formatting conversion methods to
2719 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2720 getters/setters for text colour information.
2721 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2722 for transferring the libglom NumericFormat information to the client.
2723 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2724 and getters/setters for: GlomNumericFormat, background colour and
2725 foreground colour strings.
2727 2011-09-26 Ben Konrath <ben@bagu.org>
2729 Simplify code that iterates through the LayoutGroup.
2731 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2733 2011-09-26 Ben Konrath <ben@bagu.org>
2735 Accept Eclipse formatting for OnlineGlomServiceAsync.
2737 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2739 2011-09-26 Ben Konrath <ben@bagu.org>
2741 Don't use the ListDBAccess classes to get the primary key layout information.
2743 This was causing a bug where the wrong index for the hidden primary key
2744 was being sent to the client.
2746 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2747 primary key while creating the LayoutGroup DTO. Create a
2748 LayoutItemField DTO for hidden primary keys. Don't use the
2749 RelatedListDBAccess because it was only used for getting the primary
2751 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2752 access modifier from public to protected for getPrimaryKeyField() and
2753 getPrimaryKeyLayoutItemField().
2754 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2755 abstract method getExpectedResultSize() because RelatedListDBAccess
2756 doesn't have enough info to implement it.
2757 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2758 Remove @Override for getExpectedResultSize().
2759 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2760 Remove method getExpectedResultSize().
2762 2011-09-23 Ben Konrath <ben@bagu.org>
2764 Log which layout (list or details) the ignored item is from.
2766 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2768 2011-09-23 Ben Konrath <ben@bagu.org>
2770 Remove annotations that turn off code formatting in DataItem.
2772 * src/main/java/org/glom/web/shared/DataItem.java:
2774 2011-09-23 Ben Konrath <ben@bagu.org>
2776 Rename GlomField to DataItem and update associated methods.
2778 This is a rename-only refactor. No functionality has been added or
2781 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2782 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2783 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2784 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2785 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2786 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2787 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2788 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2789 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2790 * src/main/java/org/glom/web/server/database/DBAccess.java:
2791 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2792 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2793 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2794 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2795 * src/main/java/org/glom/web/shared/DataItem.java:
2796 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2797 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2799 2011-09-23 Ben Konrath <ben@bagu.org>
2801 Rename GlomDocument to DocumentInfo and update associated methods.
2803 This is a rename-only refactor. No functionality has been added or
2806 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2807 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2808 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2809 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2810 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2811 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2812 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2814 2011-09-20 Ben Konrath <ben@bagu.org>
2816 Require java-libglom 1.17.3.
2818 This picks up the fix for the seg fault problem with the Scenes table
2819 in the Openismus Film Manager example.
2823 2011-09-20 Ben Konrath <ben@bagu.org>
2825 Change the way sort clause is added for primary key when no sort clause is requested.
2827 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2828 before the sort clause is created. When a sort clause is not requested, the
2829 sort clause is created by finding the primary key in the LayoutFieldVector
2832 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2834 2011-09-20 Ben Konrath <ben@bagu.org>
2836 Log error message if no documents are found in the configured directory.
2838 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2839 Extract the glom file extension string to a private static final class
2840 variable (mostly as syntactic sugar). Accept a minor formatting change.
2841 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2842 the example glom.document.directory configuration property to make it
2843 more clear that it can any directory, not just the home directory.
2845 2011-09-18 Ben Konrath <ben@bagu.org>
2847 Add related lists to details view.
2849 The related list table has support for paging and sorting just like the
2850 table in the list view.
2852 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2853 SQL queries for the related list tables.
2854 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2855 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2857 Rename getList methods to getListView and add comments. Remove
2858 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2859 it being unused. Add methods: getDetailsLayoutAndData(),
2860 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2861 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2862 Create the layout and set the data for the fields in one async call
2863 instead of two. Create related lists where appropriate.
2864 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2865 for method name changes in OnlineGlomService.
2866 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2867 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2868 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2870 * src/main/java/org/glom/web/client/ui/ListView.java:
2871 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2872 tableName from setCellTable(). Create a ListViewTable instead of
2874 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2875 represent a data field in the details view.
2876 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2877 from addDetailsCell() to Field class. Keep track of the Fields and
2878 Portals in the details view.
2879 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2880 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2881 and add a method to get it. Add method to set the contents of the
2883 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2884 New class for related list tables. This class has the data provider
2885 for the related list table.
2886 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2887 abstract class which is the base class for the ListViewTable and the
2889 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2890 New class for list view tables. This class has the data provider for
2891 the list view table.
2892 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2893 methods for related list tables. Add more information to the
2894 LayoutItemField and LayoutItemPortal DTOs.
2895 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2896 Remove debugging print statement.
2897 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2898 Remove debugging print statements. Add primary key field to SQL count
2900 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2901 Remove unnecessary LayoutFieldVector parameter from
2902 getResultSizeOfSQLQuery() method.
2903 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2904 New class for related list table database access.
2905 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2906 class that is a wrapper DTO for details view layout and data.
2907 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2908 new 'fromField' string to this DTO.
2909 * src/main/webapp/style.css: Remove bottom margin and override top
2912 2011-09-15 Ben Konrath <ben@bagu.org>
2914 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2916 This sets things up to make it easier to add the data retrieval for
2917 related lists (portals). No user noticeable changes were made with
2920 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2921 class has the code to retrieve the layouts and access the
2922 database using the new database helper classes.
2923 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2924 Most of the functionality has been removed from this class. This
2925 class now represents the public interface for the client side
2926 code. It also deals with configuring the servlet and cleaning
2927 things up when the servlet is stopped.
2928 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2929 of static methods into this utility class.
2930 * src/main/java/org/glom/web/server/database/DBAccess.java:
2931 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2932 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2933 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2934 These classes have the database retrieval code. The class hierarchy
2935 has been setup to make it easy to reuse code for similar
2938 2011-09-06 Ben Konrath <ben@bagu.org>
2940 Create separate classes for list table code and the data provider.
2942 As part of this refactor, I also split up the code a bit to make it
2945 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2946 table code to two new classes (below).
2947 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2948 with code from ListViewImpl.
2949 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2950 New file with code from ListViewImpl.
2952 2011-09-06 Ben Konrath <ben@bagu.org>
2954 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2956 This fixes the LayoutItemPortal DTO to match the libglom layout object
2959 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2961 2011-09-01 Ben Konrath <ben@bagu.org>
2963 Set title of Portals in the Details View.
2965 * pom.xml: Bump required version of java-libglom to 1.17.1.
2966 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2967 widget creation to its own class. Add comments to constructor.
2968 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2969 The code is mostly from the Group class with the title now set.
2970 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2971 title of Portal. Update some comments. Fix some code formatting.
2973 2011-09-01 Ben Konrath <ben@bagu.org>
2975 Remove TODO comment for the flow table column width.
2977 The flow table column width is working correctly and doesn't need to be
2978 changed. See this mailing list post for more info:
2980 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2982 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2984 2011-08-27 Ben Konrath <ben@bagu.org>
2986 Add document title (database name) to top of the browser page.
2988 I added the document title to the TableSelecitonView but that will
2989 change if / when we add a view that doesn't require table selection.
2991 * mockups/details-contacts.html:
2992 * mockups/details-projects.html:
2993 * mockups/listview-contacts.html:
2994 * mockups/listview-projects.html:
2995 * mockups/style.css: Add document title to mockups to keep things
2997 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2998 sizes to account for the document title.
2999 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3000 Set the document title when it has been retrieved from the server.
3001 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3002 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3003 and implement setDocumentTitle(String) method.
3004 * src/main/webapp/style.css: Add ID for document title style.
3006 2011-08-25 Ben Konrath <ben@bagu.org>
3008 Add NavigationType enum to LayoutItemPortal DTO.
3010 This is the start of adding support for Portals to the Details View.
3012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3013 LayoutItem_Portal.navigation_type enum from libglom to
3014 LayoutItemPortal.NavigationType enum.
3015 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3016 NavigationType enum, field for storing the NavigationType and getter
3019 2011-08-25 Ben Konrath <ben@bagu.org>
3021 Implement the flow table layout in the Details View.
3023 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3024 FlowTable to Group to account for the renamed class.
3025 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3026 File. This is a container widget that implements the Glom details view
3027 flow table behaviour.
3028 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3029 org/glom/web/client/ui/FlowTable.java.
3030 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3031 so that the size of the subgroups are a closer match to the size of
3032 the Glom subgroups. This makes the flowtable layout match the layout
3033 in Glom for the Music Collection example file.
3035 2011-08-16 Ben Konrath <ben@bagu.org>
3037 Create container element for LayoutItemPortal in Details View.
3039 This will help me develop the layout for the FlowTable.
3041 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3042 fieldPanel variable to detailsCell.
3044 2011-08-15 Ben Konrath <ben@bagu.org>
3046 Set the height of the data element in the Details View.
3048 I changed the InlineLabels (text in a span element) to Labels (text in
3049 a div element) so that I could set the height of the details-data
3050 elements instead of the details-cell parent elements. This allows the
3051 the details-data element to display the correct height if style is
3052 applied that shows the height.
3054 This change has the added benefit of allowing the order of the labels
3055 and data elements to be changed for right-to-left languages.
3057 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3058 InlineLabels to Labels.
3059 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3060 InlineLabels to Labels. Set the height of the data element.
3061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3062 multiline text height in the Formatting DTO.
3063 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3064 for multiline height along with getter and setter methods.
3065 * src/main/webapp/style.css: Adjust style to account for the change
3066 from span elements to div elements in the details cell.
3068 2011-08-15 Ben Konrath <ben@bagu.org>
3070 Make the List View appearance match the mockups.
3072 It doesn't match exactly but it's much better than it was.
3074 * mockups/listview-contacts.html: Remove unused css classes.
3075 * mockups/listview-projects.html: Remove unused css classes.
3076 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3077 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3078 for mainPanel instead of VerticalPanel (table). Set style name on
3079 CellTable. Set style name on Details column. Right-align Details
3081 * src/main/webapp/style.css: Adjust properties to match the mockups.
3083 2011-08-12 Ben Konrath <ben@bagu.org>
3085 Add better support for subgroups in the details view.
3087 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3088 changed FlowTable constructor.
3089 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3090 support for subgroups and subgroup-titles.
3091 * src/main/webapp/style.css: Add CSS class for subgroups and
3094 2011-08-12 Ben Konrath <ben@bagu.org>
3096 Return the top level LayoutGroup title.
3098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3100 2011-08-11 Ben Konrath <ben@bagu.org>
3102 Make the TableSelector header match the mockup.
3104 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3105 the layout panel. Properly lineup the table selection header with
3106 the list and details view.
3107 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3108 margin around the details view.
3109 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3110 Rename listBox variable to tableSelector. Set id for the style sheet.
3111 Use a FlowPanel instead of a HorizontalPanel.
3112 * src/main/webapp/style.css: Add properties to make the TableSelector
3113 box match the mockups.
3115 2011-07-13 Ben Konrath <ben@bagu.org>
3117 Update install script for java-libglom version change.
3119 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3122 2011-07-13 Ben Konrath <ben@bagu.org>
3124 Add support sub-group in the details view.
3126 I also removed the code that special-cased the default details view
3129 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3131 I still have to make a proper flowtable.
3133 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3134 Don't special-case default details view layout.
3135 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3136 addLayoutField() as I'm going to use it.
3137 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3138 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3140 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3141 extracted from DetailsViewImpl.GroupPanel. Add support for
3143 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3144 column count when getting the details layout.
3146 2011-07-12 Ben Konrath <ben@bagu.org>
3148 Set browser title with database and table titles.
3150 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3151 Set the browser title when the table changes and when the activity
3153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3154 title when retrieving document info (the GlomDocument object).
3155 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3156 with getter and setter methods. Remove unused convenience constructor.
3157 Use default code formatting.
3159 2011-07-12 Ben Konrath <ben@bagu.org>
3161 Ignore LayoutItemPortals in the details view.
3163 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3166 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3167 LayoutItemPortal layout objects.
3168 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3169 LayoutItemPortal objects when retrieving the details layout.
3170 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3171 file. This is an empty class and just used to get type information for
3174 2011-07-12 Ben Konrath <ben@bagu.org>
3176 Use java-libglom 1.17.0.
3180 2011-07-11 Ben Konrath <ben@bagu.org>
3182 Remove "Table:" label from table selector.
3184 This matches a recent change in the Glom UI.
3186 * mockups/details-contacts.html:
3187 * mockups/details-projects.html:
3188 * mockups/listview-contacts.html:
3189 * mockups/listview-projects.html: Remove the "Table:" label from the
3191 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3193 2011-07-11 Ben Konrath <ben@bagu.org>
3195 Add main groups to the details view.
3197 This makes things look a little nicer in the details view. The next step
3198 is to implement the flowtable.
3200 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3201 resources from the standard gwt css theme. Standard.css is now
3202 included in OnlineGlom.html so that the online glom css rules have
3203 precedence over the gwt theme.
3204 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3205 the whole LayoutGroup to the DetailsView instead of just the titles.
3206 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3207 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3208 details layout with a helper class (GroupPanel). I might extract this
3209 class when I make the full flowtable.
3210 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3211 string as default so I don't have to worry about NPEs when processing
3213 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3214 note beside OnlineGlom.gwt.xml above).
3215 * src/main/webapp/style.css: Add default font-size to body to override
3216 the font-size set by the standard theme. Don't use h2 tags for
3217 group-title. Create new details-cell class.
3219 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3221 ConfiguredDocument: Set the port number too.
3223 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3224 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3225 Glom document. Presumably this worked sometimes so far because there is a
3226 default port number.
3228 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3230 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3232 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3233 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3234 correct, though we should throw an exception too.
3236 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3238 Fix a addDocuemnt typo.
3240 * src/main/java/org/glom/web/shared/Documents.java
3241 (Documents.addDocuemnt): Rename to addDocument().
3242 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3243 (OnlineGlomServiceImpl.getDocuments): Adapt.
3245 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3247 Slightly improved log output when connection fails.
3249 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3250 (ConfiguredDocument.setUsernameAndPassword):
3251 We don't know for sure if it' the username/password that's wrong, so
3252 rephrase the message.
3253 Also ouput the exception message, though it's generic in this case.
3255 2011-07-08 Ben Konrath <ben@bagu.org>