1 2012-05-11 Murray Cumming <murrayc@murrayc.com>
3 DBAccess: Simplify the retrievel of full field details.
5 * src/main/java/org/glom/web/server/database/DBAccess.java
6 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
7 because the Document loading should have done this.
9 2012-05-11 Murray Cumming <murrayc@murrayc.com>
11 Document: Correct loading of doubly-related layout fields.
13 * src/main/java/org/glom/web/server/libglom/Document.java:
14 loadUsesRelationship(): Actually set the related relationship, instead
15 of only setting it if it's not found.
17 2012-05-07 Murray Cumming <murrayc@murrayc.com>
19 ConfiguredDocument: Restore correct addition of hidden primary key items.
21 * src/main/java/org/glom/web/client/ui/list/ListTable.java
22 (ListTable.createCellTable): Uncomment out the check for the hidden
24 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
25 add primary key items for top-level lists and portals, as before,
26 instead of adding them to each group.
27 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
28 Actually implement the extra methods such as setHiddenPrimaryKey() and
29 comment that these are used only for top-level list groups and in portals.
30 This strangeness suggests even more that this should not be squeezed
31 into the LayoutGroup class.
33 2012-05-07 Murray Cumming <murrayc@murrayc.com>
35 Fix Formatting loading.
37 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
38 getFormattingUsed(): Remove the duplicate Formatting member variable
39 in favour of the one from the base class.
40 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
41 Initialize a new Formatting instead of using null by default, so we
42 have some defaults, instead of having to initialize one later just to
43 get the same defaults. This also makes loading of formatting from the
44 document work, because that expected a non-null.
46 2012-05-07 Murray Cumming <murrayc@murrayc.com>
48 RelatedListTable: Make sure that the tableName is set.
50 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
51 Constructor: Take the tableName so it is available later. Otherwise,
52 the server assumes that we mean the default table and cannot find the
54 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
55 setData(): Pass the tableName to the RelatedListTable constructor.
57 2012-05-07 Murray Cumming <murrayc@murrayc.com>
61 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
62 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
63 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
65 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
67 * src/main/java/org/glom/web/server/database/DBAccess.java:
68 convertResultSetToDTO(), getPortal():
69 * src/main/java/org/glom/web/server/database/ListDBAccess.java
71 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
72 Add checks for null objects and out of range access, with log messages to
73 give hints so we can fix these properly.
75 2012-05-07 Murray Cumming <murrayc@murrayc.com>
77 Portals: some corrections.
79 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
81 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
82 constructor: Use getRelationshipNameUsed() instead of getName(), because
83 that is what is meant.
84 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
85 getFromField(): Fix a typo, to get the field name, not the table name.
86 * src/main/java/org/glom/web/server/database/DBAccess.java:
87 getPortal(): Fix a typo that stopped this from working.
89 2012-05-07 Murray Cumming <murrayc@murrayc.com>
91 LayoutItemPortal: Also override getTitleOriginal().
93 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
94 This lets the base getTitle() with no parameters work.
95 TODO: Test this properly.
97 2012-05-06 Murray Cumming <murrayc@murrayc.com>
99 LayoutItemPortal: getTitle*(): Use the relationship title.
101 2012-05-06 Murray Cumming <murrayc@murrayc.com>
103 LayoutItemField: Fix loading of custom titles.
105 * src/main/java/org/glom/web/server/libglom/Document.java
106 loadDataLayoutItemField(): The title, if any, instead of the field
107 title, is stored in a title_custom node. Load it from there.
108 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
110 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
111 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
112 getTitle*() overrides.
113 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
116 2012-05-06 Murray Cumming <murrayc@murrayc.com>
118 LayoutItemField: Fall back to field titles, so some are really shown.
120 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
121 Override getTitleOriginal() and getTitle(), as in java-libglom.
122 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
125 2012-05-06 Murray Cumming <murrayc@murrayc.com>
127 Correct use of setExpectedResultSize().
129 * src/main/java/org/glom/web/server/ConfiguredDocument.java
130 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
131 Use setExpectedResultSize only on top-level groups (for instance, the
132 list layout) or on child portals (in details views).
133 Use the correct table name for portals to avoid SQL errors.
134 Update the expected counts when returning cached layouts.
136 2012-05-06 Murray Cumming <murrayc@murrayc.com>
138 Document: Interpret no group column count as 1.
140 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
141 default, though we now check for this in the UI code anyway.
143 2012-05-06 Murray Cumming <murrayc@murrayc.com>
147 2012-05-06 Murray Cumming <murrayc@murrayc.com>
149 Translatable: Use Hashmap instead of Treemap because GWT supports it.
151 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
152 The use of Treemap lead to this error from async methods, with no
154 "The response could not be deserialized"
156 2012-05-06 Murray Cumming <murrayc@murrayc.com>
158 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
160 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
161 when using the Google -> GWT Compile, or
162 g toolbar button -> GWT Compile Project... feature in Eclipse.
164 2012-05-06 Murray Cumming <murrayc@murrayc.com>
166 ListTable.addColumn(): Protect against a null Formatting.
168 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
169 Create a default Formatting if it is null, because that is the simplest
172 2012-05-06 Murray Cumming <murrayc@murrayc.com>
174 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
176 * src/main/java/org/glom/web/server/ConfiguredDocument.java
177 updateLayoutGroup(): Check that the field is not null.
179 2012-05-06 Murray Cumming <murrayc@murrayc.com>
181 ListViewImpl: Protected against a bad cast error.
183 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
184 onEnterKeyDown(): Do not cast without an instanceof check.
186 2012-05-06 Murray Cumming <murrayc@murrayc.com>
188 ListTable: Protect against an out of range error.
190 * src/main/java/org/glom/web/client/ui/list/ListTable.java
191 createCellTable(): This is unlikely, but can happen while debugging.
193 2012-05-06 Murray Cumming <murrayc@murrayc.com>
195 AsyncMessage onFailure() callbacks: Log the exception message.
197 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
198 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
199 * src/main/java/org/glom/web/client/activity/ListActivity.java:
200 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
201 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
202 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
203 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
204 These are useful clues when something is wrong.
206 2012-05-06 Murray Cumming <murrayc@murrayc.com>
208 ConfiguredDocument: Avoid a null dereference.
210 * src/main/java/org/glom/web/server/ConfiguredDocument.java
211 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
212 details maps are created.
214 2012-05-06 Murray Cumming <murrayc@murrayc.com>
216 Document: Correct the port number parsing.
218 * src/main/java/org/glom/web/server/libglom/Document.java:
219 This lets us actually connect to the database and show the document.
221 2012-05-05 Murray Cumming <murrayc@murrayc.com>
225 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
226 user-interaction, asking us to load a temporary URL in a browser.s
227 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
228 which is apparently necessary for testing the service. See the comment.
229 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
230 Show the exception, if any. This is how I saw the 404 in the HTML in
233 2012-05-05 Murray Cumming <murrayc@murrayc.com>
235 DocumentTest: Move the .glom files into the resources directory.
237 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
238 URI via getResource().
240 2012-05-05 Murray Cumming <murrayc@murrayc.com>
242 Document: Remove the FieldIdentifies inner class.
244 * src/main/java/org/glom/web/server/libglom/Document.java: We only
245 use the Relationship (though the same function in libglom is maybe
246 used in other ways) and so this removes a compiler warning.
248 2012-05-05 Murray Cumming <murrayc@murrayc.com>
250 Document.load() Remove the error code parameter.
252 * src/main/java/org/glom/web/server/libglom/Document.java: load():
253 Remove the parameter. We do not set it yet and it could never have
254 worked as an output parameter (though maybe it did in java-libglom).
255 We could use an exception if we really want the failure reason.
256 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
258 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
259 setUp(), testGetSuitableTableToViewDetails(): Adapt.
261 2012-05-05 Murray Cumming <murrayc@murrayc.com>
263 Make some inner classes static.
265 * src/main/java/org/glom/web/server/ConfiguredDocument.java
266 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
267 * src/main/java/org/glom/web/server/ReportGenerator.java
268 * src/main/java/org/glom/web/server/libglom/Document.java
269 Make all inner classes static that can be static.
271 2012-05-05 Murray Cumming <murrayc@murrayc.com>
273 OnlineGlomServiceImpl: Do not load and check for java-libglom.
275 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
276 init(): We do not use java-libglom any more.
278 2012-05-05 Murray Cumming <murrayc@murrayc.com>
280 Remove mentions of java-libglom.
282 * README: Remove mention of java-libglom, because it no longer needed.
283 * utils/build-onlineglom-war.sh:
284 * utils/check-and-recover-tomcat.py:
285 * utils/install-onlineglom-war.sh: Remove these as they are no longer
286 useful. Building is now far easier, with no need for jhbuild.
288 2012-05-05 Murray Cumming <murrayc@murrayc.com>
290 Fix the build (mvn package)
292 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
293 (LayoutGroup): Make the LayoutItemList inner class static and protected.
294 Otherwise the GWT Java->Javascript compilation fails with just this
295 error, during mvn package or when attempting to view in a browser,
296 in the GWT developer mode in Eclipse.
298 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
299 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
300 [INFO] Compiling module org.glom.web.OnlineGlom
301 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
302 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
303 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
304 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
305 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
306 [INFO] [ERROR] Cannot proceed due to previous errors
308 It has taken me 2 days to find out what was causing that. After reducing
309 the code, the compiler eventually showed me the full error message.
311 2012-05-04 Murray Cumming <murrayc@murrayc.com>
313 ConfiguredDocument: Cache the cloned and stripped layouts.
315 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
316 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
317 layout in a map, so we can retrieve it again without rebuilding it.
319 2012-05-04 Murray Cumming <murrayc@murrayc.com>
321 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
323 2012-05-04 Murray Cumming <murrayc@murrayc.com>
325 libglom classes: Implement some auto-generated emthods.
327 2012-05-04 Murray Cumming <murrayc@murrayc.com>
329 Add GwtTestOnlineGlomService.
331 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
332 However, this (and the other GwtTest*) does not seem to run during
335 2012-05-04 Murray Cumming <murrayc@murrayc.com>
337 Remove use of unsupported features from client code.
339 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
340 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
341 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
342 Use our client version of StringUtils instead of the apache commons one.
344 However, the GWT Javascript compliation still fails.
346 2012-04-25 Murray Cumming <murrayc@murrayc.com>
348 Add a Field class and implement some loading of it in Document.
350 2012-04-25 Murray Cumming <murrayc@murrayc.com>
352 Initial Document loading implementation, instead of libglom.
354 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
355 and Translatable classes, and adapt the rest of the code to use them.
356 However, this is still missing Layout and Field classes and loading.
358 2012-04-24 Murray Cumming <murrayc@murrayc.com>
360 Use of jOOQ: Move Field creation into a utility method.
362 * src/main/java/org/glom/web/server/SqlUtils.java:
363 This lets us improve it more easily.
365 2012-04-24 Murray Cumming <murrayc@murrayc.com>
367 Use of jOOQ: Improve the code to COUNT a sub-select.
369 * src/main/java/org/glom/web/server/SqlUtils.java:
370 Move initial query creation into
371 build_sql_select_step_with_where_clause().
372 build_sql_select_count_rows(): Use the jOOQ API instead of
373 concatentating text, because a jOOQ Select*Step is a TableLike,
374 which is what from() takes.
376 2012-04-23 Murray Cumming <murrayc@murrayc.com>
378 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
380 * pom.xml: Depend on jooq.
381 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
382 methods with jOOQ, based on the C++ implementations in libglom,
383 with some changes to the logic required by jooQ.
384 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
386 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
387 * src/main/java/org/glom/web/server/ReportGenerator.java:
388 * src/main/java/org/glom/web/server/SqlUtils.java:
389 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
390 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
391 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
392 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
393 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
394 Adapt. In particular, the SqlUtils methods now need to take a Connection,
395 because jOOQ needs that, though it seems unnecessary.
397 This is not quite finished. Ideally jOOQ would help us to build
398 table_name.field_name names, quoting and escaping them properly.
399 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
401 2012-04-21 Murray Cumming <murrayc@murrayc.com>
403 Move use of Glom.build_sql*() into a new SqlUtils class.
405 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
406 to wrap Glom.build_sql*(). The parameter types are still Glom one,
407 but this will make it easier to start using something other than
408 libglom or SqlBuilder.
410 2012-04-21 Murray Cumming <murrayc@murrayc.com>
412 Update the project URL.
414 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
416 2012-04-21 Murray Cumming <murrayc@murrayc.com>
418 Main layout: Use a FlowTable instead of absolute positioning.
420 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
421 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
422 child panels/widgets must have an absolute position. But that is annoying, so
423 this adds a FlowTable and puts the child panels in there.
425 2012-04-21 Murray Cumming <murrayc@murrayc.com>
427 GwtTestOnlineGlom: Comment out unused code.
429 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
430 Eclipse has started to say that some code is unused.
432 2012-04-21 Murray Cumming <murrayc@murrayc.com>
434 Update to the latest versions of dependencies.
436 * pom.xml: Update version numbers of dependencies to the latest
438 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
439 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
440 * src/main/java/org/glom/web/server/ReportGenerator.java:
441 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
442 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
443 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
445 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
446 Modify the imports where necessary.
448 2012-04-17 Murray Cumming <murrayc@murrayc.com>
450 Style: Remove overflow:hidden from searchbox
452 * src/main/webapp/style.css: Because this pushes the Back To Link
453 label/link on to the next row, which is then hidden due to the
454 hard-coded (in ems) height.
456 2012-04-20 Murray Cumming <murrayc@murrayc.com>
458 Remove some duplicate code.
460 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
461 getDocumentInfo(): This must have been duplicated during the merge from the
466 2012-04-19 Murray Cumming <murrayc@murrayc.com>
468 Reports: Localize the waiting for report message.
470 * src/main/java/org/glom/web/client/activity/ReportActivity.java
471 start(): Get the message from the contants.
472 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
474 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
475 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
476 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
477 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
478 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
479 Update these files with the English text for newer strings for now.
481 2012-04-19 Murray Cumming <murrayc@murrayc.com>
483 Reports: Show a message while waiting for the report.
485 * src/main/java/org/glom/web/client/ui/ReportView.java
486 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
487 Add setWaitingText(), to show a message saying that we are
488 waiting for the report to be ready.
489 * src/main/java/org/glom/web/client/activity/ReportActivity.java
490 start(): Call setWaitingText() before calling the async
493 2012-04-19 Murray Cumming <murrayc@murrayc.com>
495 ReportGenerator: Specify date and time formats.
497 * src/main/java/org/glom/web/server/ReportGenerator.java:
498 createFieldValueElement(): Use the default (and localized)
499 short formats, though we still need a way to show 4-digit
500 years without providing the format for every locale.
501 * src/main/java/org/glom/web/server/database/DBAccess.java:
502 convertResultSetToDTO(): Use the short formats here too.
504 2012-04-18 Murray Cumming <murrayc@murrayc.com>
506 ReportGenerator: Use the correct numeric formatting.
508 * src/main/java/org/glom/web/server/ReportGenerator.java
509 createFieldExpression(), createFieldValueElement(): Take the
510 whole LayoutItem_Field instead of just the field name, so
511 we have access to the formatting.
512 createFieldValueElement(): Use JRTextField.setPattern() to
513 specify the numeric formatting, with the help of a
514 regular DecimalFormat.
516 2012-04-18 Murray Cumming <murrayc@murrayc.com>
518 ReportGenerator: Avoid showing null for group by titles.
520 * src/main/java/org/glom/web/server/ReportGenerator.java
521 generateReport(): Use setBlankWhenNull() on the field title
522 style too, because this is used for values in group by
525 2012-04-18 Murray Cumming <murrayc@murrayc.com>
527 ReportGenerator: Add a colon to titles in vertical groups.
529 * src/main/java/org/glom/web/server/ReportGenerator.java
530 addFieldToDetailBandVertical(): Pass true for the withColon
533 2012-04-18 Murray Cumming <murrayc@murrayc.com>
535 ReportGenerator: Simplify the code by using Position more.
537 2012-04-18 Murray Cumming <murrayc@murrayc.com>
539 Reports: Support vertical groups, roughly.
541 * src/main/java/org/glom/web/server/ReportGenerator.java:
542 addToReport(): Rename to addGroupToReport() and, if necessary,
543 call the new addVerticalGroupToReport() method.
544 createFieldValueElement(): Let the caller specify the Y position
547 2012-04-17 Murray Cumming <murrayc@murrayc.com>
549 Reports: Allow a second report to be shown.
551 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
552 clear(): Do not remove the HTML widget, which broke the whole layout.
554 2012-04-17 Murray Cumming <murrayc@murrayc.com>
556 Locales drop-down: Show that we use English by default.
558 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
559 fillView(): When we use English, just because that is the default, when
560 no locale is specified, show that in the Locales drop-down instead of
561 just showing the first item.
563 2012-04-17 Murray Cumming <murrayc@murrayc.com>
565 Unselect the Report/Locale/Table combo item when appropriate.
567 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
568 setPlace(): clear reportName if this is not a ReportPlace.
569 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
570 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
571 When the provided name is empty, unselect all items, so that none are
572 indicated. This uses a for loop because I cannot find a single method
575 2012-04-17 Murray Cumming <murrayc@murrayc.com>
577 Report: Give the user a way to get back to the list.
579 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
580 start(), setPlace(): Show the Back To List link on reports, and also
581 interpret selecting the empty report item as back to list.
583 2012-04-13 Murray Cumming <murrayc@murrayc.com>
585 Really show the selected Report name.
587 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
588 setPlace(): Store the reportName here, if it is that kind of Place.
589 fillView(): Set the selected Report after filling the list of reports.
590 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
591 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
592 null Strings, though we need some way to unselect all ListBox items
595 2012-04-13 Murray Cumming <murrayc@murrayc.com>
597 ReportGenerator: Try to avoid some problems.
599 * src/main/java/org/glom/web/server/ReportGenerator.java
600 addField(): Try to avoid duplicates, and avoid using a null
603 2012-04-13 Murray Cumming <murrayc@murrayc.com>
605 Reports: Use quickFind.
607 * src/main/java/org/glom/web/client/OnlineGlomService.java;
608 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
609 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
610 getReportHTML(): Add a quickFind parameter.
611 * src/main/java/org/glom/web/client/activity/ReportActivity.java
612 start(): Pass the quickFind parameter.
613 * src/main/java/org/glom/web/server/ReportGenerator.java
614 generateReport(): Take a quickFind parameter.
616 2012-04-13 Murray Cumming <murrayc@murrayc.com>
618 ReportPlace: Actually use the report name.
620 * src/main/java/org/glom/web/client/place/ReportPlace.java
621 getPlace(): Do not assign the report name to the quickfind.
623 2012-04-13 Murray Cumming <murrayc@murrayc.com>
625 Show java.library.path when complaining.
627 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
628 init(): When telling us to check java.library.path, show the
631 2012-03-06 Murray Cumming <murrayc@murrayc.com>
633 ReportGenerator: Do not show nulls.
635 2012-03-06 Murray Cumming <murrayc@murrayc.com>
637 ReportGenerator: Make the title font larger.
639 2012-03-06 Murray Cumming <murrayc@murrayc.com>
641 ReportGenerator: Put field titles inside groups, if there are groups.
643 2012-03-06 Murray Cumming <murrayc@murrayc.com>
645 ReportGenerator: Take the Report itself instead of the name and group.
647 * src/main/java/org/glom/web/server/ConfiguredDocument.java
648 Remove getReportLayoutGroup().
649 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
650 getReportHTML(): Pass the report instead
651 of its name and layout group.
652 * src/main/java/org/glom/web/server/ReportGenerator.java
653 generateReport(): Use the report object to use the title
656 2012-03-06 Murray Cumming <murrayc@murrayc.com>
658 ReportGenerator: Remove designBand parameters.
660 * src/main/java/org/glom/web/server/ReportGenerator.java:
661 Make designBand a class member instead of passing it to all
664 2012-03-06 Murray Cumming <murrayc@murrayc.com>
666 ReportGenerator: Add lines, a bit like in the desktop version.
668 * src/main/java/org/glom/web/server/ReportGenerator.java
669 addToReport(): Use JRDesignLine.
671 2012-03-06 Murray Cumming <murrayc@murrayc.com>
673 ReportGenerator: Correct the title positions and use some bold style.
675 * src/main/java/org/glom/web/server/ReportGenerator.java:
676 Break the code up into reusable functions, correct the placement of
677 titles, and use normal/bold styles as in the reports in the desktop
680 2012-03-06 Murray Cumming <murrayc@murrayc.com>
682 ReportGenerator: Add a header band to show the field titles.
684 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
685 getReportHTML(): Pass the localeId to the ReportGenerator
687 * src/main/java/org/glom/web/server/ReportGenerator.java
688 constructor: Take the localeID so we can get translated field
690 generateReport(), addToReport(), addFieldToBand(): Add field
691 titles in a column header band.
693 2012-03-05 Murray Cumming <murrayc@murrayc.com>
695 Reports drop-down list: Some improvement.
697 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
698 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
699 Adedd setSelectedReport(),
700 setReportList(): Add a blank line so that the user can select the
702 * src/main/java/org/glom/web/client/activity/ReportActivity.java
703 start(): Show the current report by calling setSelectedReport().
704 This does not seem to work yet.
706 2012-03-05 Murray Cumming <murrayc@murrayc.com>
708 DetailsActivity, ListActivity: Move some variables into a base class.
710 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
711 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
712 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
713 the clientFactory, documentID, tableName and authenticationPopup into
714 a base class, to avoid duplication.
716 2012-03-05 Murray Cumming <murrayc@murrayc.com>
718 Translate the Reports label.
720 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
721 Get the "Reports" label string from the constants.
722 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
723 perties: Add Reports to the constants.
725 2012-03-05 Murray Cumming <murrayc@murrayc.com>
727 Reports: Implement grouping.
729 * src/main/java/org/glom/web/server/ReportGenerator.java:
730 Handle LayoutItem_GroupBy items and try to do the right thing
731 with JRDesignGroup. It seems to work.
733 2012-03-04 Murray Cumming <murrayc@murrayc.com>
735 Actually show some data with JasperReports.
737 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
738 getReportHTML(): Move most code into a ReportGenerator class.
739 * src/main/java/org/glom/web/server/ReportGenerator.java:
740 Recurse into sub-groups, adding fields to the JasperDesign's details
741 band. Note that we must set an arbitrary width and height, or it just
742 will not show any data.
744 2012-03-04 Murray Cumming <murrayc@murrayc.com>
746 Reports Chooser: Show the titles, not the names.
748 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
749 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
750 and the names as the values.
751 * src/main/java/org/glom/web/server/ConfiguredDocument.java
752 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
753 group now that we provide the report name, so it should always
756 2012-02-15 Murray Cumming <murrayc@murrayc.com>
758 Depend on jasperreports.
760 * pom.xml: Add the dependency. My plan is to use this on the
763 2012-01-31 Murray Cumming <murrayc@murrayc.com>
765 Implement navigation to report places.
767 * src/main/java/org/glom/web/client/activity/ReportActivity.java
768 start(): Do not bother to handle all events here.
769 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
770 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
771 Added getSelectedReport().
772 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
773 .java: start(): When handling a change to the reports chooser,
774 call getSelectedReport() and goTo() its ReportPlace.
775 * src/main/java/org/glom/web/client/ui/ReportView.java
776 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
777 Added setReportHTML() which puts the html in a gwt HTML widget.
778 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
779 getReportHTML(): Return "TODO" just to show that this works.
781 2012-01-31 Murray Cumming <murrayc@murrayc.com>
783 Make ReportPlace usable.
785 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
787 * src/main/java/org/glom/web/client/place/ReportPlace.java:
788 Correct the @prefix annotation.
790 2012-01-31 Murray Cumming <murrayc@murrayc.com>
792 OnlineGlomService: Return report HTML rather than the LayoutGroup.
794 * src/main/java/org/glom/web/client/OnlineGlomService.java:
795 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
796 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
797 Change getReportLayout() to getReportHMTL() because we will not need to
798 parse or render the report layout on the client side.
799 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
800 getReportLayout(): Return the libglom LayoutGroup type because we will
801 not need to convert to a shared type, because this will not be used on
803 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
806 Note that there is still no implementation for this.
809 2012-01-27 Murray Cumming <murrayc@murrayc.com>
811 Add a (empty) Report Place, View, and Activity.
813 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
815 * src/main/java/org/glom/web/client/place/HasTablePlace.java
816 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
817 this into a superclass:
818 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
819 and also use it as the base of this new ReportPlace:
820 * src/main/java/org/glom/web/client/place/ReportPlace.java
822 * src/main/java/org/glom/web/client/ui/ReportView.java
823 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
824 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
825 Add these, containing mostly boiler-plate for now.
827 * src/main/java/org/glom/web/client/OnlineGlomService.java
828 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
829 * src/main/java/org/glom/web/server/ConfiguredDocument.java
830 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
831 Add API to get the LayoutGroup for the report.
833 2012-01-23 Murray Cumming <murrayc@murrayc.com>
835 Add and fill a Reports drop-down list box.
837 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
839 * src/main/java/org/glom/web/client/OnlineGlomService.java:
840 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
842 Added getReports(document, table, localeID), calling
843 ConfiguredDocument.getReports().
844 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
845 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
846 Added setReportsList() and a list widget.
847 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
848 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
853 2012-04-12 Murray Cumming <murrayc@murrayc.com>
855 Translations: Add Esperanto.
857 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
858 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
859 properties: Add this translation because someone took the time to make it.
861 2012-03-15 Murray Cumming <murrayc@murrayc.com>
863 Adapt to the java-libglom 1.21.7 API.
865 * src/main/java/org/glom/web/server/ReportGenerator.java:
866 addToReport(): get_group_secondary_fields() is now
867 get_secondary_fields().
870 2012-03-15 Murray Cumming <murrayc@murrayc.com>
872 Use the latest java-libglom version.
874 * pom.xml: Use java-libglom 1.21.7.
876 2012-03-03 Ben Konrath <ben@bagu.org>
878 Display date and time in details view.
880 https://bugzilla.gnome.org/show_bug.cgi?id=671257
882 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
884 2012-03-05 Murray Cumming <murrayc@murrayc.com>
886 Require the latest java-libglom.
888 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
890 2012-03-04 Murray Cumming <murrayc@murrayc.com>
892 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
894 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
895 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
896 an empty quickfind string. I also corrected libglom to create only
897 empty where clauses for empty quickfind strings, but this avoids the
900 2012-02-24 Ben Konrath <ben@bagu.org>
902 Improve the tabs in the Notebook widget.
906 2012-01-30 Murray Cumming <murrayc@murrayc.com>
908 Translations: Try to translate the strings.
910 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
911 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
912 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
913 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
914 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
915 Take the Open translation from GTK+'s .po files.
916 Take the Details translation from Glom's po files.
917 I have added the other strings to Glom so we can get translations that way:
918 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
920 2012-01-27 Murray Cumming <murrayc@murrayc.com>
922 TableSelectionViewImpl: Put the search label and entry in a div.
924 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
925 Put the search widgets in a FlowTable so that the CSS can be used to
926 style them while keeping them together.
927 * src/main/webapp/style.css: Mention the new div.
929 2012-01-27 Murray Cumming <murrayc@murrayc.com>
931 Translate more strings in more locales.
933 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
934 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
935 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
936 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
937 Translate the "Details" and "Open" string too.
939 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
940 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
941 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
942 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
943 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
944 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
945 Add these new locales as placeholders though they currently contain English.
947 2012-01-27 Murray Cumming <murrayc@murrayc.com>
949 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
951 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
952 Check the ConfiguredDocument* for null before using it.
954 2012-01-26 Murray Cumming <murrayc@murrayc.com>
956 Tell Eclipse about the generated java files.
958 * .classpath: This lets it find OnlineGlomConstants.java.
959 It would be nice if Eclipse just used the maven build files.
961 2012-01-26 Murray Cumming <murrayc@murrayc.com>
963 Prevent a crash when no locale is specified in the URL.
965 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
966 Avoid returning a null string, obtained from
967 Window.Location.getParameter(). This caused a crash when it was
968 later passed to libglom's API.
969 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
970 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
971 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
972 guard against future null strings.
974 2012-01-26 Murray Cumming <murrayc@murrayc.com>
976 Use the ?locale= query param instead of the &lang= token param.
978 * src/main/java/org/glom/web/client/place/ListPlace.java
979 * src/main/java/org/glom/web/client/place/DetailsPlace.java
980 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
981 Remove the lang token key and value.
983 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
984 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
985 When the user selects a different locale from the chooser, use
986 Window.Location.assign() to change the URL, which then causes a reload.
988 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
989 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
990 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
991 * src/main/java/org/glom/web/client/activity/ListActivity.java
992 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
993 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
994 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
995 * src/main/java/org/glom/web/client/ui/ListView.java:
996 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
998 Remove localeID member variables and method/constructor parameters, instead
999 using Utils.getCurrentLocaleID() when we need a localID to pass to
1002 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1004 Internationalize the UI strings.
1006 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1007 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1008 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1009 because it is unused. Messages are apparently strings that can have
1010 parameters, but we do not need that yet, so Contants will be enough for now.
1011 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1012 to say that we support the en and de locales.
1013 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1014 The original English strings.
1015 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1016 Some German translations of the English strings.
1017 The i18n goal then uses the .properties file to generate an
1018 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1019 returns an implementation that returns the translated strings.
1020 The documentation suggests putting these in src/java/*/client/, but it seems
1021 best to put it in src/resources/*/client/.
1022 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1023 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1024 instead of hard-coding them.
1025 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1026 but that does not seem to stop the build, though it confuses Eclipse.
1028 You can see the translated string by adding ?locale=de to the URL, like so:
1029 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1031 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1033 Improve null/empty String checks.
1035 * pom.xml: Add a dependency on commons-lang, to use
1036 org.apache.commons.lang.StringUtils.
1037 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1038 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1039 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1040 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1041 Use StringUtils.isEmpty().
1043 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1044 StringUtils class with a static isEmpty() function because we
1045 cannot use org.apache.commons.lang.StringUtils in client-side
1046 GWT code because it (apparently) cannot be compiled to javascript.
1047 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1048 * src/main/java/org/glom/web/client/activity/ListActivity.java
1049 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1050 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1051 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1052 * src/main/java/org/glom/web/client/place/ListPlace.java
1053 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1054 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1055 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1056 * src/main/java/org/glom/web/client/ui/details/Group.java
1057 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1058 our StringUtils.isEmpty() function.
1060 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1062 Update to the latest java-libglom API.
1064 * pom.xml: Require java-libglom 1.21.4.
1065 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1066 getDocumentInfo(), getListViewLayoutGroup():
1067 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1069 * src/main/java/org/glom/web/server/database/DBAccess.java
1070 getFieldsToShowForSQLQueryAddGroup(),
1071 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1072 with either get_database_title_original() or
1073 get_database_title(localeID).
1075 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1077 ConfiguredDocument: Avoid a null pointer exception.
1079 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1080 Initialize localeID to "" to avoid returning a null String which
1081 causes a crash in java-libglom's swing-generated code.
1083 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1085 Some simple renaming.
1087 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1088 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1089 for localeChooser. This seems more appropriate and is less ambiguous
1090 particularly in the .css file.
1092 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1094 ConfiguredDocument: Rename the localedID private member variable.
1096 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1098 Adapt to the latest java-libglom API from git master.
1100 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1101 libglom now uses only Vector instead of List, which uses add() instead of
1104 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1106 ConfiguredDocument: Rename the localedID private member variable.
1108 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1110 Build a source tarball with mvn assembly:single
1112 * assembly.xml: Add this file.
1113 * pom.xml: Use the maven-assembly-plugin and tell it to use
1114 our assembly.xml file.
1116 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1118 OnlineGlomServiceImpl: Get .glom files recursively.
1120 * pom.xml: Depend on commons-io from org.apache.commons.
1121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1122 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1123 files recursively, and with the easier filter for the extension.
1124 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1125 simplify that code too.
1127 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1129 README: Mention that you must install java-libglom packages separately.
1131 But then it works, because java-libglom is now in the central maven
1134 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1136 locales drop-down: Show the correct selected locale when the URL changes.
1138 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1139 .java: setPlace(): Move some code into fillView().
1141 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1143 locales drop-down: Do not lose the primary key.
1145 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1146 start(): onLocaleChange(): Pass the current primary key value,
1147 instead of an empty value.
1149 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1151 locales drop-down: Do not lose the drop-down selection.
1153 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1154 .java (TableSelectionActivity.fillView): Set the selected locale
1155 after changing the drop-down items (though we do not really need
1156 to change them just because the locale changes.)
1158 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1160 locales drop-down: Change the tables list when this changes.
1162 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1163 .java: TableSelectionActivity.start(): Move the async table titles
1164 retrieval into a private fillView() method and also call this when
1165 the chosen locale changes.
1166 Note that the document title is not actually translatable yet, but
1167 that is a problem that I should fix soon in libglom.
1169 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1171 Improve the placement of the locales drop-down.
1173 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1174 Put the title and locales drop-down in a div (gwt.FlowTable).
1175 * src/main/webapp/style.css: Add magic css properties to make this work.
1176 Also remove the left margin from the title so that it lines up with the
1179 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1181 locales selector: Show human-readable locale titles.
1183 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1184 getDocumentInfo(): Use java.util.Locale to show a real title of
1185 each locale, in the locale's own language.
1187 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1189 Add a language/locale selector drop-down.
1191 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1192 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1193 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1194 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1195 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1196 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1197 Add a ListBox to show the available locales. Add getLocaleSelector(),
1198 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1199 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1200 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1201 java: Add these classes.
1202 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1203 start(): Fill the locales ListBox. Handle its change event, firing a
1205 setPlace(): Show the selected locale as specified by the URL token.
1206 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1207 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1208 Handle LocaleChangeEvent, going to a new *Place with that locale.
1210 The placement of the ListBox is not pretty, and it currently uses the ID
1211 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1215 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1217 Search box: Show the search text from the URL token.
1219 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1220 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1221 Add setQuickFindText().
1222 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1223 .java: setPlace(): Store the queryText if the place is a ListPlace,
1224 and call TableSelectionView.setQuickFindText().
1226 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1228 Allow use of translations via, for instance, &lang=de in the URL.
1230 * pom.xml: Use the unstable java-libglom 1.21 version.
1232 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1233 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1235 init(): Instead of calling TranslatableItem.set_current_locale()
1236 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1237 However, this is only for default locales, which are not needed to
1238 change the locale in the URL.
1239 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1240 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1241 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1242 layout for a particular locale.
1243 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1244 Add get/setDefaultLocaleID().
1245 getDocumentInfo(), getListViewData(), getRelatedListData(),
1246 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1247 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1248 localeID parameter, so we can get the layout for a particular locale.
1250 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1251 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1252 * src/main/java/org/glom/web/client/place/ListPlace.java:
1253 Parse and construct a lang parameter too.
1255 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1256 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1257 passed to subsequent methods and constructors.
1258 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1259 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1260 Store the localeID from the *Place and pass it to other constructors
1261 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1263 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1264 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1265 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1266 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1267 * src/main/java/org/glom/web/client/ui/ListView.java:
1268 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1269 Take localeID parameters and pass them to subsequent constructors and
1270 methods, so that the layout is always retrieved for that locale.
1272 This is rather repetitive.
1274 Note that "" means the original (default) locale of the Glom document,
1275 which is usually English.
1277 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1279 Documents: Remove final keyword to fix startup configuration.
1281 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1282 final keywords on the private member variables because that breaks
1283 the startup, apparently (there are warnings) because it stops them
1284 from being serialized. I added these in the previous commit.
1286 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1288 Documents: Add some final keywords.
1290 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1293 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1295 OnlineGlomServiceImpl: Add to overview comments.
1297 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1298 Note that this is where all the document are loaded. They are not
1299 loaded freshly for each page.
1301 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1305 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1306 Add a TextBox for the text of a quick find.
1307 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1309 setBackLink(): Add a String quickFind parameter.
1310 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1311 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1312 to the base interface, because that is how TableSelectionViewImpl is used.
1313 * src/main/webapp/style.css: Add style for the search box and its label.
1315 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1316 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1317 Add these files, based on the existing TableChangeEvent and
1318 TableChangeEventHandlers.
1319 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1320 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1321 a ListPlace() that the user should be taken to.
1322 * src/main/java/org/glom/web/client/activity/ListActivity.java
1323 start(): Handle it here too and adapt the TableChangeEvent handler to
1324 pass the extra "" quickFind parameter to ListPlace.
1325 * src/main/java/org/glom/web/client/place/ListPlace.java:
1326 Constructor: Take an extra String quickFind parameter and store it,
1327 returning it from a new getQuickFind() method.
1328 getToken(): Put the quickFind text in the URL token.
1329 getPlace(): Parse the quickFind text from the URL token.
1330 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1331 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1332 ListPlace constructor.
1333 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1334 .java: start(): Add a Change handler for the TableSelectionView's
1335 TextBox (via its base HasChangeHandlers interface), firing the new
1336 QuickFindChangeEvent.
1337 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1338 pass the extra "" quickFind parameter.
1340 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1341 setCellTable(): Add a String quickFind parameter and pass it to
1342 the ListViewTable() constructor.
1343 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1344 setCellTable() in the base interface, because that is how ListViewImpl
1347 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1348 Add a String quickFind member variable.
1349 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1350 Constructor: Add a String quickFind parameter, storing it in the
1351 base ListTable's member variable.
1352 onRangeChanged(): Pass quickFind to the
1353 OnlineGlomServiceAsync.getSortedListViewData() and
1354 OnlineGlomServiceAsync.getListViewData() methods.
1356 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1357 getListViewData(), getSortedListViewData(): Add a String quickFind
1358 parameter, passing it to ConfiguredDocument.getListViewData().
1359 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1360 Change getListViewData(), getSortedListViewData() in the base interface,
1361 because that is how OnlineGlomServiceImpl is used, via this:
1362 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1363 Change getListViewData(), getSortedListViewData() here too.
1364 This class can apparently be used to asynchronously call methods on
1365 OnlineGlomService, and GWT seems to implement that after recognizing
1366 just the *Async name convention and the extra AsyncCallback parameters.
1368 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1369 getListViewData(): Add a String quickFind parameter, and pass it to
1370 ListViewDBAccess.getData().
1371 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1372 getListData(): Add a String quickFind parameter and pass it to
1374 getSelectQuery(): Add a String quickFind parameter.
1375 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1376 getSelectQuery(): Add a String quickFind parameter and use it with
1377 Glom.get_find_where_clause_quick() to pass a where_clause to
1378 Glom.build_sql_select_with_where_clause(), to actually filter the
1380 getData(): Add a String quickFind parameter, passing it to getListData().
1381 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1382 va: getData(): Pass an empty string to getListData() for the
1383 quickFind parameter.
1385 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1387 ListTable: Minor change.
1389 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1390 createCellTable(): Make this protected instead of public.
1392 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1394 Many files: Use final for the parameters and use the @override attribute.
1396 2012-01-22 Ben Konrath <ben@bagu.org>
1398 Add anchor links for single line text that starts with http, ftp and www.
1402 2012-01-22 Ben Konrath <ben@bagu.org>
1404 Add ellipsis to single line text in details view.
1408 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1410 Remove all javadoc author tags.
1412 Because they are awkward and meaningless when many people touch
1414 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1416 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1418 Revert the COPYING.LESSER to COPYING rename.
1420 Apparently both should be there if it is LGPL.
1422 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1424 *View: Remove unused imports.
1426 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1427 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1428 * src/main/java/org/glom/web/client/ui/ListView.java:
1429 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1430 Remove unused imports, as suggested by Eclipse.
1432 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1434 Move the *View::Presenter types, and some API into one base View.
1436 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1437 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1438 * src/main/java/org/glom/web/client/ui/ListView.java:
1439 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1440 Presenter, setPresenter() and clear() into a shared base interface,
1441 to avoid the unnecessary duplicate Presenter types and to more clearly
1442 show how the *Views share the same structure, even if they are not
1443 used polymorphically.
1445 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1446 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1448 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1449 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1450 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1452 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1455 Feel free to revert this if there is a good reason for the duplicate
1458 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1460 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1462 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1463 a class member instead of a local variable in the method.
1464 This lets us use it to get the view instances, for use in tests.
1465 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1466 beforeOnlineGlom(): Test some more details of the initial view.
1467 Again, this is not very useful.
1469 To really test gwt-glom we will need to start a local postgresql
1470 instance with local data, like the Glom tests in C++.
1472 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1474 pom.xml: Mention the LGPL license.
1476 * pom.xml: Add a licenses section.
1477 * COPYING.LESSER: Move this to COPYING, which
1478 previously contained the GPL. But gwt-glom is all LGPL.
1480 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1482 Add project information to README and pom.xml.
1484 * README: Add a brief description and mention some mvn
1486 * pom.xml: This extra information shows up in mvn site
1489 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1491 Use the latest java-libglom version.
1493 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1495 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1497 GwtTestOnlineGlom: Test a little more.
1499 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1500 protected rather than private, as suggested by the gwt-test-utils
1502 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1503 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1504 Test the initial visibility of the panels.
1506 However, this is not a very useful test.
1507 And I wonder how we should generally test using this idea for an
1508 activity/places app like ours where the real changes happen implicitly
1509 based on the history token/URL.
1511 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1513 Slight modification to *Mapper comments.
1515 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1516 (DataActivityMapper)
1517 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1519 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1521 Remove comments mentioning GIN because they are just copied from
1522 the example code and are apparently not helpful:
1523 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1524 Also change the mention of a class that is only in the example code.
1526 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1528 GwtTestOnlineGlom test: Minor changes.
1530 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1531 Avoid the long qualified class name and modify the comment
1532 because it is now obvious to me that the mocked class is the only
1533 custom one created via GWT.create().
1535 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1537 Tests: Added the beginnings of a test using gwt-test-utils.
1539 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1540 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1541 which tells gwt-test-utils what class will be tested.
1542 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1543 Add a simple (but empty) test case. One class, used by the OnlineGlom
1544 class, is mocked so that it can be created. However, I am not sure
1545 why only this class needs to be mocked.
1547 Note that mockito seems more popular, and clearer, than easymock,
1548 but I have not got that working yet. It might be a matter of the
1551 This test is run during mvn integration-test.
1553 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1555 Tests: Use junit4-style syntax instead of junit3-style.
1557 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1558 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1559 * src/test/java/org/glom/web/shared/DataItemTest.java:
1560 Use the @Test annotation rather than relying on the test*() prefix.
1561 Also no longer implement TestCase, to avoid triggering support for
1562 the junit3-way, which stops the annotations from working.
1563 Change the imports from import junit.framework.* to
1564 import org.junit.*, which is apparently the new way.
1566 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1568 Added a test for ListPlace token parsing and creation.
1570 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1571 This is much the same as DetailsPlaceTest.
1573 I wonder how we could test the other parts of the *Place API.
1575 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1577 DetailsPlace test: Also test getToken() and recreation via getPlace().
1579 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1580 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1581 recreate it, testing the recreated DetailsPlace for the same parameter
1584 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1586 Use the surefire-report plugin.
1588 * pom.xml: This generates a HTML report about the tests in
1589 target/site/surefire-report.html
1590 when you do mvn surefire-report:report. It seems to be popular/normal.
1592 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1594 Added a test for DetailsPlace.
1596 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1597 Test the getPlace() token parsing.
1599 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1601 Added a first unit test.
1603 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1604 * src/test/java/org/glom/web/shared/DataItemTest.java:
1605 This is a silly test but it is just to get things started. Note that
1606 maven/junit finds the test because it looks in src/test by default.
1608 2011-12-22 Ben Konrath <ben@bagu.org>
1610 Change charsetName to "UTF-8" when replacing line breaks.
1612 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1613 that work in Java (such as "UTF8") will not work when compiled to
1616 This fixes a problem with multi-line details view fields that have hard
1617 line breaks. The "License Text" field on this page demonstrates the
1620 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1622 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1624 2011-12-22 Ben Konrath <ben@bagu.org>
1626 Fix another bug with related list navigation.
1628 I've tested all the navigation buttons in all of the related lists
1629 so things should be good now.
1631 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1633 2011-12-22 Ben Konrath <ben@bagu.org>
1635 Fix a crasher when refreshing the list view with the default table.
1637 This crash will also happen when loading the list view with the default
1638 table from a link or bookmark.
1640 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1641 to the main document selection page when the document id hasn't been
1643 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1644 the main document selection page when the document id hasn't been
1646 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1647 values for the details place when the document id hasn't been set.
1648 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1649 values for the list place when the document id hasn't been set.
1651 2011-12-21 Ben Konrath <ben@bagu.org>
1653 Protect against NPE when glom.document.locale is not in config.
1655 This patch protects against an NPE when glom.document.locale is not in
1656 the config file. This NPE will also happen if glom.document.locale is
1659 The patch also updates the error message to display the class name when
1660 the getMessage() returns null. This was happening when the NPE was
1661 thrown and I had "Configuration Error: null". If an NPE is encountered
1662 with this patch, "Configuration Error: NullPointerException " will be
1665 This commit closes this bug:
1667 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1669 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1671 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1673 Rename onlineglom.properties to onlineglom.properties.sample.
1675 * src/main/resources/onlineglom.properties: Rename to:
1676 * src/main/resources/onlineglom.properties.sample:
1677 * src/main/resources/README: And add this file explaining that people
1678 should rename it back when deploying.
1680 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1682 Allow choosing the translation in the .properties file.
1684 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1685 init(): Read a glom.document.locale value from the configuration file
1686 and call Glom's TransatableItem::set_current_locale() method.
1687 * src/main/resources/onlineglom.properties: Add a commented-out
1688 example of this new setting.
1690 It would be better to add &lang=de_DE to the URL, but the current
1691 libglom API does not allow us to do this easily. I am working on that.
1693 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1695 Avoid a crash in parsing of token parameters.
1697 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1698 ava: getTokenParams(): Do not crash if a parameter has a key but no
1699 value, and ignore parameters with neither.
1701 2011-12-17 Murray Cumming <murrayc@murayc.com>
1703 History token building/handling: Improve use of token parameters.
1705 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1706 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1707 and buildParamsToken(HashMap), for use by derived classes.
1708 Make the separator private because it is no longer be needed.
1709 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1710 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1711 instead of manual string concatenation.
1712 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1713 of hardcoded indices and awkward splitting code.
1714 * src/main/java/org/glom/web/client/place/ListPlace.java
1715 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1716 instead of manual string concatenation.
1717 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1718 of hardcoded indices and awkward splitting code.
1719 This should fix bug #666420
1721 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1723 Fix a Navgiation->Navigation typo in the code.
1725 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1726 Rename processNavgiation() to processNavigation().
1728 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1730 Fix a seperator->separator typo in the code.
1732 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1733 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1734 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1737 2011-12-15 Ben Konrath <ben@bagu.org>
1739 Cleanup some comments.
1741 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1743 2011-12-14 Ben Konrath <ben@bagu.org>
1745 Replace \n with <br/> for multiline text in the details view.
1747 Vertical scrollbars are added when needed as well.
1749 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1751 2011-12-14 Ben Konrath <ben@bagu.org>
1753 Specify the font for document selection links.
1755 * src/main/webapp/style.css:
1757 2011-12-14 Ben Konrath <ben@bagu.org>
1759 Fix bouncy CellTable while paging.
1761 This doesn't currently work with related list tables in unselected
1764 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1766 2011-12-14 Ben Konrath <ben@bagu.org>
1768 Revamp the appearance of the document selection page.
1770 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1771 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1772 * src/main/webapp/style.css:
1774 2011-12-13 Ben Konrath <ben@bagu.org>
1776 Set navigation button column to the smallest size possible.
1778 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1780 2011-12-13 Ben Konrath <ben@bagu.org>
1782 Change OpenButton nomenclature to NavigationButton.
1784 Using NavigtionButton makes things more generic. Classes, methods and
1785 variables have been changed.
1787 This is a rename-only refactor.
1789 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1790 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1791 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1792 Renamed from OpenButtonCell.
1793 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1794 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1795 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1797 2011-12-12 Ben Konrath <ben@bagu.org>
1799 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1801 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1802 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1803 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1804 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1806 2011-12-12 Ben Konrath <ben@bagu.org>
1808 Update variable names and comments.
1810 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1811 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1813 2011-12-12 Ben Konrath <ben@bagu.org>
1815 Properly initialize numNonEmptyRows variable to zero.
1817 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1818 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1820 2011-12-05 Ben Konrath <ben@bagu.org>
1822 Add latest mockup with HTML tables.
1824 Features of this mockup:
1826 -> HTML table for flowtable
1827 -> HTML table for flowtable column
1828 -> Example of how related lists would look
1829 -> Not using text entries for data items
1831 The current version of Online Glom doesn't use HTML tables for the
1834 This mockup has been sent to the glom-devel mailing list but it's good
1835 to have it here as well.
1837 * mockups/details-view-html-tables.html:
1839 2011-12-05 Ben Konrath <ben@bagu.org>
1841 Remove unnecessary getPrimaryKeyField() method.
1843 getPrimaryKeyFieldForTable(String) has been renamed to
1844 getPrimaryKeyField(String).
1846 * src/main/java/org/glom/web/server/database/DBAccess.java:
1847 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1848 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1850 2011-12-05 Ben Konrath <ben@bagu.org>
1852 Add string representation of TypedDataItem value to conversion error message.
1854 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1855 message was extracted into its own method to avoid duplication.
1857 2011-12-05 Ben Konrath <ben@bagu.org>
1859 Add type checking to navigation primary key value creation.
1861 Create navigation primary key only if the expected type from the Glom
1862 document matches the type returned by the SQL query.
1864 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1866 2011-12-05 Ben Konrath <ben@bagu.org>
1868 Rename a couple of variables in RelatedListNavigation.
1870 This is a rename-only refactor.
1872 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1874 2011-12-05 Ben Konrath <ben@bagu.org>
1876 Move getListLayoutGroup() into getListViewLayoutGroup().
1878 This removes getListLayoutGroup(). It was only being called by
1879 getListViewLayoutGroup().
1881 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1883 2011-12-05 Ben Konrath <ben@bagu.org>
1885 Remove check for LayoutItem_Portal in list table method.
1887 This check is no longer necessary because the method isn't being used
1888 to create the LayoutItemPortal DTO.
1890 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1892 2011-12-05 Ben Konrath <ben@bagu.org>
1894 Properly support related list navigation.
1896 Navigation from the "Repository Analyzer -> Package Scans ->
1897 Dependencies" related table wasn't working because the primary key for
1898 related tables wasn't being set properly. This commit fixes the
1901 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1902 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1903 doesn't set the primary key properly for related list tables.
1904 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1905 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1906 useful for getting the primary key for list view tables and for related
1908 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1909 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1910 Move code to set the primary key for the table from the abstract
1911 ListDBAccess class to ListViewDBAccess as it's only correct for list
1913 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1914 Properly add primary key to related list tables.
1916 2011-12-02 Ben Konrath <ben@bagu.org>
1918 Properly set the horizontal alignment of fields.
1920 This fix is for both the list tables and the details view.
1922 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1923 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1924 to set the horizontal alignment of fields.
1926 2011-12-02 Ben Konrath <ben@bagu.org>
1928 Display currency codes in the details view.
1930 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1932 2011-12-02 Ben Konrath <ben@bagu.org>
1934 Avoid duplicate JNI call.
1936 JNI is not as efficient as pure Java and this is an easy (and small)
1939 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1940 Use previously retrieved value for whereClauseToTableName instead of
1943 2011-12-02 Ben Konrath <ben@bagu.org>
1945 Rename a couple of variables in RelatedListNavigation.
1947 This is a rename-only refactor.
1949 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1951 2011-12-02 Ben Konrath <ben@bagu.org>
1953 Indicate clearly that a mismatched primary key type is a bug.
1955 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1956 warning to error. Add 'This is a bug.' to message.
1958 2011-12-02 Ben Konrath <ben@bagu.org>
1960 Update / fix some comments.
1962 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1964 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1966 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1967 Fix comments. Add some TODOs.
1969 2011-12-02 Ben Konrath <ben@bagu.org>
1971 Enable navigation to details view with string primary key from related list.
1973 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1974 Create a text primary key value when return type of result is
1975 java.sql.Types.VARCHAR.
1977 2011-12-02 Ben Konrath <ben@bagu.org>
1979 Use checkboxes for booleans in the details view.
1981 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1983 2011-12-01 Ben Konrath <ben@bagu.org>
1985 Improve performance of related list height calculation.
1987 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1988 Put code to calculate the expected height in a static initializer so
1989 that that it's only called once.
1991 2011-12-01 Ben Konrath <ben@bagu.org>
1993 Show related list tables in notebooks (again).
1995 Calculate the height of the related list tables so the Notebook can be
1996 set the correct height. The height of the related list table is also needed by
1997 FlowTable to be able decide how to create the layout.
1999 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2000 and set the Portal height based on the height of the related list
2001 table and the Portal container.
2002 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2003 Add method to calculate the height of the related list tables.
2004 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2005 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2006 calculate the height of the Pager widget.
2008 2011-12-01 Ben Konrath <ben@bagu.org>
2010 Use CellTable API for table property instead of setting style on Element.
2012 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2014 2011-12-01 Ben Konrath <ben@bagu.org>
2016 Make ListViewTable and RelatedListTable a consistent height.
2018 The tables are now a consistent height regardless of the contents of
2019 the table. A hidden button is added to empty rows to ensure that the
2020 height of these rows will match the height of rows with data.
2022 A navigation button column is now added to every table. The width of
2023 the navigation column is set to 0px when a RelatedListTable shouldn't
2024 have navigation buttons. This maintains the a consistent row height in
2025 tables that don't show the navigation buttons.
2027 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2028 navigation column when not needed.
2029 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2030 arguments for navigation button to constructor of ListViewTable.
2031 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2032 hidden button for empty data rows.
2033 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2034 arguments for navigation button to constructor.
2035 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2036 create navigation buttons. Add hideNavigationButtons() method.
2037 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2038 arguments for navigation button to constructor.
2040 2011-12-01 Ben Konrath <ben@bagu.org>
2042 Use 'visibility: hidden' in Utils.getWidgetHeight().
2044 This is better choice because hidden elements are invisible, don't
2045 respond to events and are not part of the tab order. They will,
2046 however, take up space which is required to be able to calculate the
2047 height of the widget.
2049 * src/main/java/org/glom/web/client/Utils.java:
2051 2011-12-01 Ben Konrath <ben@bagu.org>
2053 Use Utils.getWidgetHeight() in FlowTable.
2055 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2057 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2059 2011-12-01 Ben Konrath <ben@bagu.org>
2061 Put the details css class name on the correct table column.
2063 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2065 2011-11-30 Ben Konrath <ben@bagu.org>
2067 Update for java-libglom API change.
2069 The getters and setters on FieldFormatting and NumericFormat were
2070 changed to remove the 'M'.
2072 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2074 2011-11-29 Ben Konrath <ben@bagu.org>
2076 Only allow RelatedListTables in Portals.
2078 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2080 2011-11-29 Ben Konrath <ben@bagu.org>
2082 Only create a contents panel for Portals when title is being set.
2084 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2086 2011-11-29 Ben Konrath <ben@bagu.org>
2088 Set TabLayoutPanel height based on calculated height its widgets.
2090 This is a potential fix for this bug:
2092 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2094 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2096 2011-11-29 Ben Konrath <ben@bagu.org>
2098 Align details field labels and data with the Open buttons.
2100 * src/main/webapp/style.css:
2102 2011-11-29 Ben Konrath <ben@bagu.org>
2104 Remove unnecessary <div> in the Notebook widget.
2106 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2107 method to get container FlowPanel (<div>).
2108 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2109 initWidget() method directly on the TabLayoutPanel widget instead of
2110 Group's container widget.
2112 2011-11-29 Ben Konrath <ben@bagu.org>
2114 Don't add group titles for Portals in Notebooks.
2116 This reverts the previous patch and fixes a bug I introduced with
2117 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2119 * src/main/java/org/glom/web/client/ui/details/Group.java:
2120 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2122 2011-11-28 Ben Konrath <ben@bagu.org>
2124 Remove unused boolean argument in Portal constructor.
2126 Just a code cleanup.
2128 * src/main/java/org/glom/web/client/ui/details/Group.java:
2129 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2131 2011-11-28 Ben Konrath <ben@bagu.org>
2133 Remove hack for glom 1.18 style glom files.
2135 * src/main/java/org/glom/web/client/ui/details/Group.java:
2136 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2137 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2139 2011-11-28 Ben Konrath <ben@bagu.org>
2141 Use Gda Value version of primary key to log result too large error.
2143 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2145 2011-11-28 Ben Konrath <ben@bagu.org>
2147 Don't use TypedDataItem.getText() for Unknown types from the URL.
2149 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2150 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2151 instead of getText().
2152 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2153 String field and getUnknown() method.
2155 2011-11-28 Ben Konrath <ben@bagu.org>
2157 Log an error message when the java-libglom .so is not present.
2159 The error message was being set in the exception but not logged.
2161 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2163 2011-11-28 Ben Konrath <ben@bagu.org>
2165 Ignore LayoutItem_CalendarPortals.
2167 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2168 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2170 2011-11-28 Ben Konrath <ben@bagu.org>
2172 Extract method for creating the LayoutItemPortal DTO.
2174 Just breaking the code up into smaller chunks.
2176 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2178 2011-11-28 Ben Konrath <ben@bagu.org>
2182 This should have been added with the refactor. Oops!
2184 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2186 2011-11-28 Ben Konrath <ben@bagu.org>
2188 Create primary key value from URL string using type from Glom document.
2190 See this bug, comments 19 - 25:
2192 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2194 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2195 create a TypeDataItem for the primary key here when loading from a
2196 URL. Show the same string for the primary key value as was received
2197 from the URL string (when loading from a URL).
2198 * src/main/java/org/glom/web/server/Utils.java: Update method for
2199 creating the Gda Value from the TypeDataItem to properly deal with
2200 creating a Gda Value based on the Glom document type for the primary
2201 key value string when loading from a URL.
2202 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2203 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2204 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2205 Update for changed method name.
2207 2011-11-27 Ben Konrath <ben@bagu.org>
2209 Rename PrimaryKeyItem to TypedDataItem.
2211 The name PrimaryKeyItem suggests what the class should be used for.
2212 TypedDataItem is a neutral name that describes the class better.
2214 This is a rename-only refactor.
2216 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2217 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2218 * src/main/java/org/glom/web/client/Utils.java:
2219 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2220 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2221 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2222 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2223 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2224 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2225 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2226 * src/main/java/org/glom/web/server/Utils.java:
2227 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2228 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2229 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2230 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2232 2011-11-25 Ben Konrath <ben@bagu.org>
2234 Improve Gda Value conversion from PrimaryKeyItem.
2236 The value from the PrimaryKeyItem is only used if its type match the
2237 type from the glom document.
2239 * src/main/java/org/glom/web/server/Utils.java:
2241 2011-11-25 Ben Konrath <ben@bagu.org>
2243 Manually check if the java-liblgom .so is visible to the JVM.
2245 It seems that Tomcat has problems when a static initializer throws an
2246 exception. This check is done before the first method call into
2247 java-libglom so that execution doesn't continue if the .so is not
2250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2252 2011-11-25 Ben Konrath <ben@bagu.org>
2254 Improve browser configuration error messages.
2258 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2260 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2261 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2262 getConfigurationErrorMessage() method.
2263 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2264 Get and display a specific configuration error message when no Glom
2265 documents are found.
2266 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2267 Implement getConfigurationErrorMessage() method. Surround configuration
2268 code in the init() method with a try/catch block. This allows the
2269 errors to be caught while keeping the servlet available to retrieve the
2270 configuration error message.
2272 2011-11-25 Ben Konrath <ben@bagu.org>
2274 Don't use Strings to hold primary key values.
2276 The primary key values are now held in a new data object
2277 (PrimaryKeyItem) that holds type information and the primary key value
2278 using the correct type.
2280 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2281 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2283 PrimaryKeyItem instead of String to hold the primary key value.
2284 * src/main/java/org/glom/web/client/Utils.java: Remove
2285 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2286 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2287 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2288 PrimaryKeyItem instead of String to hold the primary key value. Load
2289 document selection page when the documentID has not been set correctly.
2290 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2291 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2293 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2294 Return empty string for URL instead of "null".
2295 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2296 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2297 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2298 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2299 PrimaryKeyItem instead of String to hold primary key values.
2300 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2301 PrimaryKeyValue to a Gda Value.
2302 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2303 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2304 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2305 Replace temporary database access code that uses the PrimaryKeyValue to
2306 Gda Value conversion.
2307 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2308 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2309 PrimaryKeyItem instead of String.
2310 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2311 hold primary key values.
2313 2011-11-24 Ben Konrath <ben@bagu.org>
2315 Use newly added java-libglom API to create queries.
2317 This isn't finished. I still need to stop using Strings for primary key
2318 values in the client code.
2320 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2321 libglom to use fake connections so that retrieving the query string will
2323 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2324 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2325 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2326 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2327 Use the newly added libglom sql methods and classes to create the
2328 query. Add temporary hack to convert primary value strings to Gda
2331 2011-11-23 Ben Konrath <ben@bagu.org>
2333 Don't explicitly set the height of Portals.
2335 See comments 6 - 10 of this bug for details:
2337 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2339 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2341 2011-11-23 Ben Konrath <ben@bagu.org>
2343 Use an HTML table instead of CSS for the FlowTable layout.
2345 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2346 GWT's FlexTable to implement the FlowTable.
2347 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2349 2011-11-18 Ben Konrath <ben@bagu.org>
2351 Add boolean example to HTML table mockup.
2353 * mockups/details-view-html-tables-text-entries.html:
2355 2011-11-17 Ben Konrath <ben@bagu.org>
2357 Ensure the pager buttons are always visible for related lists.
2359 To accomplish this, I've turned off text wrapping in the list view and
2360 related list tables for both the header and data text. The related list
2361 table now has a fixed layout so the it doesn't overflow its container.
2362 This is required to ensure that the cell text is clipped when it
2363 overflows the cell and an ellipsis is added to the right side of the
2364 cell when text is clipped.
2366 A fixed table layout for the related list table in the details view
2367 seems what we want for the details view anyway, so the side-effect is
2370 The ellipsis will only be displayed in Firefox >= 7.
2374 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2376 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2377 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2378 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2380 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2381 Set the 'table-layout: fixed' CSS property to the related list table.
2382 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2383 'white-space: nowrap;' CSS property on both the list view and the
2384 related list tables.
2386 2011-11-16 Ben Konrath <ben@bagu.org>
2388 Rework the fix for empty notebook tab labels.
2390 Setting the empty group titles with its name caused problems for the
2391 details layout. Instead of using libglom's
2392 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2393 to the client when the title is empty. This allows the Notebook to use
2394 the name when the title is empty without affecting anything else.
2396 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2397 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2399 2011-11-16 Ben Konrath <ben@bagu.org>
2401 Set group titles with name when title is empty.
2403 This fixes a problem with an empty notebook tab label in the Lesson
2404 Planner document. The forth tab in the notebook should be "Internet":
2406 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2408 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2409 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2412 2011-11-16 Ben Konrath <ben@bagu.org>
2414 Remove whitespace from the configured username properties.
2416 This assumes that usernames won't have whitespace at the beginning
2417 or end. But I think this is a reasonable assumption.
2419 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2420 String.trim() to remove the whitespace from the username properties.
2422 2011-11-15 Ben Konrath <ben@bagu.org>
2424 Add details view mockup with HTML tables and text entries.
2426 This is from the attachment on this bug:
2428 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2430 * mockups/details-view-html-tables-text-entries.html:
2432 2011-11-15 Ben Konrath <ben@bagu.org>
2434 Add space between the columns of the flow table.
2438 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2440 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2441 space between columns in the flow table.
2443 2011-11-15 Ben Konrath <ben@bagu.org>
2445 Add backup files to the .gitignore.
2447 * .gitignore: Ignore files that end with ~.
2449 2011-11-09 Ben Konrath <ben@bagu.org>
2451 Use latest release of gwt-log.
2453 Gwt-log releases are now being submitted to the maven central
2454 repository so manual installation of the jar is no longer required.
2456 * pom.xml: Update version and groupId of gwt-log dependency.
2458 2011-10-31 Ben Konrath <ben@bagu.org>
2460 Don't use GWT numeric formatting to override the glom currency formatting.
2462 Currencies are now displayed like they are in Glom. See this bug:
2464 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2466 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2468 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2469 currency code to constructor and set it when the cell is rendered.
2470 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2471 currency code to the constructor of the NumericCell.
2473 2011-10-27 Ben Konrath <ben@bagu.org>
2475 Require the latest release of java-libglom (1.17.4).
2479 2011-10-26 Ben Konrath <ben@bagu.org>
2481 Add style to Notebook that matches current theme.
2483 It's not the best style in the world but it's better than the default.
2485 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2486 padding at the bottom of the child widgets.
2487 * src/main/webapp/style.css: Add style for the Notebook.
2489 2011-10-26 Ben Konrath <ben@bagu.org>
2491 Move servlet initialization code to overridden init method.
2493 This is half of the solution to getting proper error messages
2494 displayed when configuration errors occur. Here's the relevant bug:
2496 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2498 The rest of the solution involves surrounding the init method with a
2499 try/catch block and setting a global variable with the error /
2500 exception. A new async method should be created to retrieve and display
2501 the error message / exception.
2503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2504 code from constructor to init method adding exceptions as needed.
2506 2011-10-26 Ben Konrath <ben@bagu.org>
2508 Add script to monitor and restart tomcat if required.
2510 * utils/check-and-recover-tomcat.py: New file.
2512 2011-10-26 Ben Konrath <ben@bagu.org>
2514 Display the correct number of data items in the pager.
2518 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2520 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2521 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2522 The implementation is the same for both tables: Keep track of the
2523 number of non-empty rows and fire and RowCountChangeEvent after the data has
2525 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2526 custom Pager class that subclasses SimplePager to handle displaying
2527 the correct number when empty rows have been added.
2529 2011-10-26 Ben Konrath <ben@bagu.org>
2531 Correct error in previous commit.
2533 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2534 eventBus parameter from listView.setCellTable().
2536 2011-10-26 Ben Konrath <ben@bagu.org>
2538 Fix error in TODO comment.
2540 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2542 2011-10-24 Ben Konrath <ben@bagu.org>
2544 Create Notebook widgets to the details view.
2546 This isn't finished just yet - I still need to create a reasonable
2547 style to match the current theme.
2549 * src/main/java/org/glom/web/client/Utils.java: Add method for
2550 calculating the height of a widget. This is used in the Notebook class.
2551 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2552 new constructor method in Group.
2553 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2554 method for creating child widget that can be used by subclasses
2555 like Notebook. New constructor that allows disabling the group
2556 titles - Notebooks don't set a group title for their child groups.
2557 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2558 to make Notebooks using GWT's TabLayoutPanel.
2559 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2560 constructor that allows disabling the group titles.
2561 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2562 LayoutItemNotebook DTO.
2563 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2564 DTO for Notebooks. It's just an empty class for now but we might need
2565 it to transfer some specific information in the future.
2567 2011-10-21 Ben Konrath <ben@bagu.org>
2569 Add navigation buttons to related list tables.
2571 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2572 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2573 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2574 method getSuitableRecordToViewDetails() for getting the table name
2575 and primary key value for related list navigation buttons.
2576 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2577 private cell renderer class to get the navigation information for
2578 related list tables from the server. Extract the navigation
2579 processing code from the details cell navigation and use it for the
2580 related list navigation as well.
2581 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2582 cell renderer class for the details open buttons. This was needed
2583 because the related list navigation buttons and the list view
2584 navigation buttons need to react differently when clicked.
2585 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2586 the onEnterKeyDown() method because it's now overriden in the
2587 subclasses that are specific to the related list tables and the list
2589 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2590 the vertical size a little because the buttons add a bit of vertical
2591 space to table. This is not a perfect solution because the vertical
2592 size of with table fewer than 5 rows will be a little smaller.
2593 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2594 changes in how navigation buttons are handled.
2595 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2596 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2597 database access object.
2598 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2599 to find the portal for a given relationship name from
2600 RelatedListDBAccess. Add method to find a primary key field for a
2602 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2603 Move code to find the portal for a given relationship name to
2605 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2606 New file: database access object for getting the related list
2607 navigation information (the table name and the primary key value).
2608 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2609 DTO for transferring a table name to navigate to and a primary key
2611 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2612 boolean and getter/setter to specifies if the related list should add
2615 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2617 Use the master branch of java-libglom
2619 * pom.xml: Depend on java-libglom 1.19 instead.
2621 This is the master branch. See also the libglom-1-18 branch.
2623 2011-10-11 Ben Konrath <ben@bagu.org>
2625 Enable the open navigation button when the data has been set.
2627 This avoids having active buttons that don't do anything when the data
2630 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2632 2011-10-11 Ben Konrath <ben@bagu.org>
2634 Use IsWidget interface for FlowTableItem.
2636 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2637 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2639 2011-10-11 Ben Konrath <ben@bagu.org>
2641 Remove GWT styling from open button in details view.
2643 There are still some issues with how the details cell is arranged but
2644 this should be made to match Glom 1.20. I'm going to leave fixing this
2645 until I have Glom 1.20 up and running.
2647 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2648 style name on open button.
2649 * src/main/webapp/style.css: Move and edit details-navigation class.
2650 Re-arrange some classes to make them appear in the same order as the
2653 2011-10-07 Ben Konrath <ben@bagu.org>
2655 Update to GWT 2.4.0.
2657 * .gitignore: Ignore new cache directory.
2658 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2659 * pom.xml: Change GWT and maven plugin to 2.4.0.
2660 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2662 * src/main/java/org/glom/web/client/ClientFactory.java:
2663 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2664 * src/main/java/org/glom/web/client/OnlineGlom.java:
2665 Update source for API changes.
2666 * utils/build-onlineglom-war.sh: Remove cache directory before the
2669 2011-10-07 Ben Konrath <ben@bagu.org>
2671 Add navigation buttons in the details view.
2673 This isn't finished but I thought I'd commit what I have as it's a
2674 pretty good start. I still need to:
2676 1. Change the style so that it fits better into the current theme
2677 2. Adjust the details cell to expand as much as possible.
2679 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2680 click handlers to navigation buttons in the DetailsCells. Create a
2681 refreshData() method to get just the data from the server without the
2683 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2684 Update the tableSelector and browser title when the table name
2685 changes without using the tableSelector.
2686 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2687 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2688 getDetailsCells() to getCells(). Update variable names.
2689 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2690 method to set click handler on navigation button. Rename a few
2691 variables. Add navigation buttons where needed.
2692 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2693 variables and methods.
2694 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2695 navigation boolean and navigation table as required in the
2696 LayoutItemField DTO.
2697 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2698 variables for navigation along with getter/setter methods.
2700 2011-10-07 Ben Konrath <ben@bagu.org>
2702 Rename Field to DetailsCell.
2704 This is a refactor-only commit. No functionality has been added or
2707 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2708 Update variable and method names.
2709 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2710 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2711 variable and method names.
2712 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2714 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2715 variable and method names.
2717 2011-10-07 Ben Konrath <ben@bagu.org>
2719 Create separate methods for layout and data the details view.
2721 This is a refactor-only commit. No functionality has been added or
2724 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2725 private methods: setData(), createLayout().
2727 2011-10-07 Ben Konrath <ben@bagu.org>
2729 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2731 This is part of a change to get navigation buttons in the details view
2732 but it should have been done this way from the start.
2734 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2735 for method name change in TableSelectionView.
2736 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2737 Create TableChangeEvent and set the browser title using the
2738 TableSelectionView API.
2739 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2740 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2741 Change getSelectedTable() to getSelectedTableName(). Add
2742 getSelectedTableTitle().
2744 2011-10-07 Ben Konrath <ben@bagu.org>
2746 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2748 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2750 2011-10-07 Ben Konrath <ben@bagu.org>
2752 Update TableChangeEvent to use newTableName naming convention.
2754 This makes the class more consistent with GWT naming conventions.
2756 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2757 Update for method name change in TableChangeEvent.
2758 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2759 for method name change in TableChangeEvent.
2760 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2761 newTableName variable and getter method. Make toDebugString()
2764 2011-09-30 Ben Konrath <ben@bagu.org>
2766 Disable the pager in the list tables when the data row count is less than the minimum.
2768 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2769 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2771 2011-09-30 Ben Konrath <ben@bagu.org>
2773 Add empty rows to the end of related list and list view tables.
2775 I also extracted the cell rendering classes from the ListTable because
2776 the code was becoming a little crazy with all the anonymous inner
2777 classes. My plan is to use these cell rendering classes in the details
2778 view as well so this refactor will be needed for that change.
2780 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2781 set the row count in related list tables if the data has more rows
2782 than the minimum number of rows visible.
2783 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2784 row count in list view tables if the data has more rows than the
2785 minimum number of rows visible.
2786 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2787 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2789 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2790 for rendering TYPE_NUMERIC cells. The code was extracted from the
2792 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2793 class for rendering cells with buttons in list views. The code was
2794 extracted from the ListTable class.
2795 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2796 for rendering TYPE_TEXT cells. The code was extracted from the
2798 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2799 Add empty rows to the end of the data if required. Implement
2800 ListTable.getMinNumVisibleRows().
2801 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2802 cell renderer code to public classes. Return null in
2803 Column.getValue() for empty rows. Add new abstract method:
2804 getMinNumVisibleRows(). Move code to set the row count of the list view
2805 table to ListViewImpl.
2806 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2807 empty rows to the end of the data if required. Implement
2808 ListTable.getMinNumVisibleRows().
2811 2011-09-27 Ben Konrath <ben@bagu.org>
2813 Use GWT.log for client-side debugging statements.
2815 These are optimized out when deployed so I should have used this method
2816 in the first place. These statements will eventually be replaced with some sort
2817 of notification in the browser.
2819 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2820 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2821 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2822 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2823 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2825 2011-09-27 Ben Konrath <ben@bagu.org>
2827 Put tableselector on the right, back to list link on right.
2829 The idea is that the table selector is acting like a label for the
2830 currently displayed table so it should be placed below the document title. This
2831 puts the table title in a similar position to where it is in Glom.
2833 * mockups/details-contacts.html:
2834 * mockups/details-projects.html:
2835 * mockups/listview-contacts.html:
2836 * mockups/listview-projects.html:
2837 * mockups/style.css:
2838 Update mockups to match how the interfaces currently look.
2839 * src/main/webapp/style.css: Swap positions of backlink with the table
2840 selector. Add some space on the left side of the table selector to
2841 line things up with the document title.
2843 2011-09-27 Ben Konrath <ben@bagu.org>
2845 Add field colouring to details view.
2847 This change re-works how field colouring works. The colour formatting
2848 information is now set to the client with the layout information instead of
2849 with the data. This eliminates the need to send the same colour strings for
2850 data in list view column when colour information is set.
2852 In order to set an alternate colour for negative numeric values, the
2853 number is now sent to client and formatted with the GWT NumberFormat class.
2855 This change also fixes:
2857 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2859 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2860 internationalization framework which is needed for client side numeric
2862 * src/main/java/org/glom/web/client/Utils.java: New file for some
2863 client static utility methods.
2864 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2865 the DataItem object to the Field class. Use a utility method to
2866 create the foreignKeyValue string.
2867 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2868 alignment and text colours in the constructor. Add setData(DataItem)
2869 method. Remove setText(String) method.
2870 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2871 colour information to GlomTextCell. Create and use GlomNumberCell for
2872 rendering numbers. Use utility method to get the string for the
2873 primary key of the key provider. Re-work how the horizontal alignment
2875 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2876 formatting to layout information. Methods for converting the libglom
2877 formatting information were moved from DBAccess.
2878 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2879 numeric formatting (it's now done on the client side). Don't set text
2880 colours in DataItem. Move libglom formatting conversion methods to
2882 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2883 getters/setters for text colour information.
2884 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2885 for transferring the libglom NumericFormat information to the client.
2886 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2887 and getters/setters for: GlomNumericFormat, background colour and
2888 foreground colour strings.
2890 2011-09-26 Ben Konrath <ben@bagu.org>
2892 Simplify code that iterates through the LayoutGroup.
2894 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2896 2011-09-26 Ben Konrath <ben@bagu.org>
2898 Accept Eclipse formatting for OnlineGlomServiceAsync.
2900 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2902 2011-09-26 Ben Konrath <ben@bagu.org>
2904 Don't use the ListDBAccess classes to get the primary key layout information.
2906 This was causing a bug where the wrong index for the hidden primary key
2907 was being sent to the client.
2909 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2910 primary key while creating the LayoutGroup DTO. Create a
2911 LayoutItemField DTO for hidden primary keys. Don't use the
2912 RelatedListDBAccess because it was only used for getting the primary
2914 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2915 access modifier from public to protected for getPrimaryKeyField() and
2916 getPrimaryKeyLayoutItemField().
2917 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2918 abstract method getExpectedResultSize() because RelatedListDBAccess
2919 doesn't have enough info to implement it.
2920 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2921 Remove @Override for getExpectedResultSize().
2922 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2923 Remove method getExpectedResultSize().
2925 2011-09-23 Ben Konrath <ben@bagu.org>
2927 Log which layout (list or details) the ignored item is from.
2929 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2931 2011-09-23 Ben Konrath <ben@bagu.org>
2933 Remove annotations that turn off code formatting in DataItem.
2935 * src/main/java/org/glom/web/shared/DataItem.java:
2937 2011-09-23 Ben Konrath <ben@bagu.org>
2939 Rename GlomField to DataItem and update associated methods.
2941 This is a rename-only refactor. No functionality has been added or
2944 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2945 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2946 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2947 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2948 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2949 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2950 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2951 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2952 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2953 * src/main/java/org/glom/web/server/database/DBAccess.java:
2954 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2955 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2956 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2957 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2958 * src/main/java/org/glom/web/shared/DataItem.java:
2959 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2960 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2962 2011-09-23 Ben Konrath <ben@bagu.org>
2964 Rename GlomDocument to DocumentInfo and update associated methods.
2966 This is a rename-only refactor. No functionality has been added or
2969 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2970 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2971 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2972 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2973 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2974 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2975 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2977 2011-09-20 Ben Konrath <ben@bagu.org>
2979 Require java-libglom 1.17.3.
2981 This picks up the fix for the seg fault problem with the Scenes table
2982 in the Openismus Film Manager example.
2986 2011-09-20 Ben Konrath <ben@bagu.org>
2988 Change the way sort clause is added for primary key when no sort clause is requested.
2990 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2991 before the sort clause is created. When a sort clause is not requested, the
2992 sort clause is created by finding the primary key in the LayoutFieldVector
2995 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2997 2011-09-20 Ben Konrath <ben@bagu.org>
2999 Log error message if no documents are found in the configured directory.
3001 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
3002 Extract the glom file extension string to a private static final class
3003 variable (mostly as syntactic sugar). Accept a minor formatting change.
3004 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
3005 the example glom.document.directory configuration property to make it
3006 more clear that it can any directory, not just the home directory.
3008 2011-09-18 Ben Konrath <ben@bagu.org>
3010 Add related lists to details view.
3012 The related list table has support for paging and sorting just like the
3013 table in the list view.
3015 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
3016 SQL queries for the related list tables.
3017 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3018 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3020 Rename getList methods to getListView and add comments. Remove
3021 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
3022 it being unused. Add methods: getDetailsLayoutAndData(),
3023 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
3024 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3025 Create the layout and set the data for the fields in one async call
3026 instead of two. Create related lists where appropriate.
3027 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
3028 for method name changes in OnlineGlomService.
3029 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3030 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3031 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
3033 * src/main/java/org/glom/web/client/ui/ListView.java:
3034 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
3035 tableName from setCellTable(). Create a ListViewTable instead of
3037 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
3038 represent a data field in the details view.
3039 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
3040 from addDetailsCell() to Field class. Keep track of the Fields and
3041 Portals in the details view.
3042 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
3043 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
3044 and add a method to get it. Add method to set the contents of the
3046 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3047 New class for related list tables. This class has the data provider
3048 for the related list table.
3049 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
3050 abstract class which is the base class for the ListViewTable and the
3052 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3053 New class for list view tables. This class has the data provider for
3054 the list view table.
3055 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3056 methods for related list tables. Add more information to the
3057 LayoutItemField and LayoutItemPortal DTOs.
3058 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3059 Remove debugging print statement.
3060 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3061 Remove debugging print statements. Add primary key field to SQL count
3063 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3064 Remove unnecessary LayoutFieldVector parameter from
3065 getResultSizeOfSQLQuery() method.
3066 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3067 New class for related list table database access.
3068 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
3069 class that is a wrapper DTO for details view layout and data.
3070 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3071 new 'fromField' string to this DTO.
3072 * src/main/webapp/style.css: Remove bottom margin and override top
3075 2011-09-15 Ben Konrath <ben@bagu.org>
3077 Breakup the OnlineGlomServiceImpl class to make it more manageable.
3079 This sets things up to make it easier to add the data retrieval for
3080 related lists (portals). No user noticeable changes were made with
3083 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
3084 class has the code to retrieve the layouts and access the
3085 database using the new database helper classes.
3086 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3087 Most of the functionality has been removed from this class. This
3088 class now represents the public interface for the client side
3089 code. It also deals with configuring the servlet and cleaning
3090 things up when the servlet is stopped.
3091 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
3092 of static methods into this utility class.
3093 * src/main/java/org/glom/web/server/database/DBAccess.java:
3094 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
3095 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
3096 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
3097 These classes have the database retrieval code. The class hierarchy
3098 has been setup to make it easy to reuse code for similar
3101 2011-09-06 Ben Konrath <ben@bagu.org>
3103 Create separate classes for list table code and the data provider.
3105 As part of this refactor, I also split up the code a bit to make it
3108 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
3109 table code to two new classes (below).
3110 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
3111 with code from ListViewImpl.
3112 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
3113 New file with code from ListViewImpl.
3115 2011-09-06 Ben Konrath <ben@bagu.org>
3117 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
3119 This fixes the LayoutItemPortal DTO to match the libglom layout object
3122 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
3124 2011-09-01 Ben Konrath <ben@bagu.org>
3126 Set title of Portals in the Details View.
3128 * pom.xml: Bump required version of java-libglom to 1.17.1.
3129 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
3130 widget creation to its own class. Add comments to constructor.
3131 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
3132 The code is mostly from the Group class with the title now set.
3133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3134 title of Portal. Update some comments. Fix some code formatting.
3136 2011-09-01 Ben Konrath <ben@bagu.org>
3138 Remove TODO comment for the flow table column width.
3140 The flow table column width is working correctly and doesn't need to be
3141 changed. See this mailing list post for more info:
3143 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
3145 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
3147 2011-08-27 Ben Konrath <ben@bagu.org>
3149 Add document title (database name) to top of the browser page.
3151 I added the document title to the TableSelecitonView but that will
3152 change if / when we add a view that doesn't require table selection.
3154 * mockups/details-contacts.html:
3155 * mockups/details-projects.html:
3156 * mockups/listview-contacts.html:
3157 * mockups/listview-projects.html:
3158 * mockups/style.css: Add document title to mockups to keep things
3160 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
3161 sizes to account for the document title.
3162 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3163 Set the document title when it has been retrieved from the server.
3164 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3165 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
3166 and implement setDocumentTitle(String) method.
3167 * src/main/webapp/style.css: Add ID for document title style.
3169 2011-08-25 Ben Konrath <ben@bagu.org>
3171 Add NavigationType enum to LayoutItemPortal DTO.
3173 This is the start of adding support for Portals to the Details View.
3175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
3176 LayoutItem_Portal.navigation_type enum from libglom to
3177 LayoutItemPortal.NavigationType enum.
3178 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3179 NavigationType enum, field for storing the NavigationType and getter
3182 2011-08-25 Ben Konrath <ben@bagu.org>
3184 Implement the flow table layout in the Details View.
3186 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3187 FlowTable to Group to account for the renamed class.
3188 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
3189 File. This is a container widget that implements the Glom details view
3190 flow table behaviour.
3191 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
3192 org/glom/web/client/ui/FlowTable.java.
3193 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
3194 so that the size of the subgroups are a closer match to the size of
3195 the Glom subgroups. This makes the flowtable layout match the layout
3196 in Glom for the Music Collection example file.
3198 2011-08-16 Ben Konrath <ben@bagu.org>
3200 Create container element for LayoutItemPortal in Details View.
3202 This will help me develop the layout for the FlowTable.
3204 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3205 fieldPanel variable to detailsCell.
3207 2011-08-15 Ben Konrath <ben@bagu.org>
3209 Set the height of the data element in the Details View.
3211 I changed the InlineLabels (text in a span element) to Labels (text in
3212 a div element) so that I could set the height of the details-data
3213 elements instead of the details-cell parent elements. This allows the
3214 the details-data element to display the correct height if style is
3215 applied that shows the height.
3217 This change has the added benefit of allowing the order of the labels
3218 and data elements to be changed for right-to-left languages.
3220 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3221 InlineLabels to Labels.
3222 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3223 InlineLabels to Labels. Set the height of the data element.
3224 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3225 multiline text height in the Formatting DTO.
3226 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3227 for multiline height along with getter and setter methods.
3228 * src/main/webapp/style.css: Adjust style to account for the change
3229 from span elements to div elements in the details cell.
3231 2011-08-15 Ben Konrath <ben@bagu.org>
3233 Make the List View appearance match the mockups.
3235 It doesn't match exactly but it's much better than it was.
3237 * mockups/listview-contacts.html: Remove unused css classes.
3238 * mockups/listview-projects.html: Remove unused css classes.
3239 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3240 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3241 for mainPanel instead of VerticalPanel (table). Set style name on
3242 CellTable. Set style name on Details column. Right-align Details
3244 * src/main/webapp/style.css: Adjust properties to match the mockups.
3246 2011-08-12 Ben Konrath <ben@bagu.org>
3248 Add better support for subgroups in the details view.
3250 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3251 changed FlowTable constructor.
3252 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3253 support for subgroups and subgroup-titles.
3254 * src/main/webapp/style.css: Add CSS class for subgroups and