1 2012-01-26 Murray Cumming <murrayc@murrayc.com>
3 Internationalize the UI strings.
5 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
6 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
7 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
8 because it is unused. Messages are apparently strings that can have
9 parameters, but we do not need that yet, so Contants will be enough for now.
10 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
11 to say that we support the en and de locales.
12 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
13 The original English strings.
14 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
15 Some German translations of the English strings.
16 The i18n goal then uses the .properties file to generate an
17 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
18 returns an implementation that returns the translated strings.
19 The documentation suggests putting these in src/java/*/client/, but it seems
20 best to put it in src/resources/*/client/.
21 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
22 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
23 instead of hard-coding them.
24 Note that we cannot import OnlineGlomConstants because it does not exist yet,
25 but that does not seem to stop the build, though it confuses Eclipse.
27 You can see the translated string by adding ?locale=de to the URL, like so:
28 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
30 2012-01-24 Murray Cumming <murrayc@murrayc.com>
32 Improve null/empty String checks.
34 * pom.xml: Add a dependency on commons-lang, to use
35 org.apache.commons.lang.StringUtils.
36 * src/main/java/org/glom/web/server/ConfiguredDocument.java
37 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
38 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
39 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
40 Use StringUtils.isEmpty().
42 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
43 StringUtils class with a static isEmpty() function because we
44 cannot use org.apache.commons.lang.StringUtils in client-side
45 GWT code because it (apparently) cannot be compiled to javascript.
46 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
47 * src/main/java/org/glom/web/client/activity/ListActivity.java
48 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
49 * src/main/java/org/glom/web/client/place/DetailsPlace.java
50 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
51 * src/main/java/org/glom/web/client/place/ListPlace.java
52 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
53 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
54 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
55 * src/main/java/org/glom/web/client/ui/details/Group.java
56 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
57 our StringUtils.isEmpty() function.
59 2012-01-24 Murray Cumming <murrayc@murrayc.com>
61 Update to the latest java-libglom API.
63 * pom.xml: Require java-libglom 1.21.4.
64 * src/main/java/org/glom/web/server/ConfiguredDocument.java
65 getDocumentInfo(), getListViewLayoutGroup():
66 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
68 * src/main/java/org/glom/web/server/database/DBAccess.java
69 getFieldsToShowForSQLQueryAddGroup(),
70 getPrimaryKeyLayoutItemField(): Replace get_database_title()
71 with either get_database_title_original() or
72 get_database_title(localeID).
74 2012-01-24 Murray Cumming <murrayc@murrayc.com>
76 ConfiguredDocument: Avoid a null pointer exception.
78 * src/main/java/org/glom/web/server/ConfiguredDocument.java
79 Initialize localeID to "" to avoid returning a null String which
80 causes a crash in java-libglom's swing-generated code.
82 2012-01-23 Murray Cumming <murrayc@murrayc.com>
86 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
87 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
88 for localeChooser. This seems more appropriate and is less ambiguous
89 particularly in the .css file.
91 2012-01-23 Murray Cumming <murrayc@murrayc.com>
93 ConfiguredDocument: Rename the localedID private member variable.
95 2012-01-23 Murray Cumming <murrayc@murrayc.com>
97 Adapt to the latest java-libglom API from git master.
99 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
100 libglom now uses only Vector instead of List, which uses add() instead of
103 2012-01-23 Murray Cumming <murrayc@murrayc.com>
105 Add and fill a Reports drop-down list box.
107 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
109 * src/main/java/org/glom/web/client/OnlineGlomService.java:
110 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
112 Added getReports(document, table, localeID), calling
113 ConfiguredDocument.getReports().
114 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
115 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
116 Added setReportsList() and a list widget.
117 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
118 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
120 2012-01-22 Murray Cumming <murrayc@murrayc.com>
122 ConfiguredDocument: Rename the localedID private member variable.
124 2012-01-20 Murray Cumming <murrayc@murrayc.com>
126 Build a source tarball with mvn assembly:single
128 * assembly.xml: Add this file.
129 * pom.xml: Use the maven-assembly-plugin and tell it to use
130 our assembly.xml file.
132 2012-01-19 Murray Cumming <murrayc@murrayc.com>
134 OnlineGlomServiceImpl: Get .glom files recursively.
136 * pom.xml: Depend on commons-io from org.apache.commons.
137 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
138 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
139 files recursively, and with the easier filter for the extension.
140 Use org.apache.commons.io.FilenameUtils.removeExtension() to
141 simplify that code too.
143 2012-01-19 Murray Cumming <murrayc@murrayc.com>
145 README: Mention that you must install java-libglom packages separately.
147 But then it works, because java-libglom is now in the central maven
150 2012-01-18 Murray Cumming <murrayc@murrayc.com>
152 locales drop-down: Show the correct selected locale when the URL changes.
154 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
155 .java: setPlace(): Move some code into fillView().
157 2012-01-18 Murray Cumming <murrayc@murrayc.com>
159 locales drop-down: Do not lose the primary key.
161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
162 start(): onLocaleChange(): Pass the current primary key value,
163 instead of an empty value.
165 2012-01-18 Murray Cumming <murrayc@murrayc.com>
167 locales drop-down: Do not lose the drop-down selection.
169 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
170 .java (TableSelectionActivity.fillView): Set the selected locale
171 after changing the drop-down items (though we do not really need
172 to change them just because the locale changes.)
174 2012-01-18 Murray Cumming <murrayc@murrayc.com>
176 locales drop-down: Change the tables list when this changes.
178 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
179 .java: TableSelectionActivity.start(): Move the async table titles
180 retrieval into a private fillView() method and also call this when
181 the chosen locale changes.
182 Note that the document title is not actually translatable yet, but
183 that is a problem that I should fix soon in libglom.
185 2012-01-18 Murray Cumming <murrayc@murrayc.com>
187 Improve the placement of the locales drop-down.
189 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
190 Put the title and locales drop-down in a div (gwt.FlowTable).
191 * src/main/webapp/style.css: Add magic css properties to make this work.
192 Also remove the left margin from the title so that it lines up with the
195 2012-01-18 Murray Cumming <murrayc@murrayc.com>
197 locales selector: Show human-readable locale titles.
199 * src/main/java/org/glom/web/server/ConfiguredDocument.java
200 getDocumentInfo(): Use java.util.Locale to show a real title of
201 each locale, in the locale's own language.
203 2012-01-17 Murray Cumming <murrayc@murrayc.com>
205 Add a language/locale selector drop-down.
207 * src/main/java/org/glom/web/shared/DocumentInfo.java:
208 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
209 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
210 getDocumentInfo(): Store the available Locales in the DocumentInfo.
211 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
212 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
213 Add a ListBox to show the available locales. Add getLocaleSelector(),
214 setLocaleList(), getSelectedLocale(), setSelectedLocale().
215 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
216 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
217 java: Add these classes.
218 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
219 start(): Fill the locales ListBox. Handle its change event, firing a
221 setPlace(): Show the selected locale as specified by the URL token.
222 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
223 * src/main/java/org/glom/web/client/activity/ListActivity.java:
224 Handle LocaleChangeEvent, going to a new *Place with that locale.
226 The placement of the ListBox is not pretty, and it currently uses the ID
227 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
231 2012-01-17 Murray Cumming <murrayc@murrayc.com>
233 Search box: Show the search text from the URL token.
235 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
236 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
237 Add setQuickFindText().
238 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
239 .java: setPlace(): Store the queryText if the place is a ListPlace,
240 and call TableSelectionView.setQuickFindText().
242 2012-01-17 Murray Cumming <murrayc@murrayc.com>
244 Allow use of translations via, for instance, &lang=de in the URL.
246 * pom.xml: Use the unstable java-libglom 1.21 version.
248 * src/main/java/org/glom/web/client/OnlineGlomService.java:
249 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
250 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
251 init(): Instead of calling TranslatableItem.set_current_locale()
252 (now removed), call ConfiguredDocument.setDefaultLocaleID().
253 However, this is only for default locales, which are not needed to
254 change the locale in the URL.
255 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
256 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
257 getSortedRelatedListData(): Add a localeID parameter, so we can get the
258 layout for a particular locale.
259 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
260 Add get/setDefaultLocaleID().
261 getDocumentInfo(), getListViewData(), getRelatedListData(),
262 getDetailsLayoutGroup(), getListViewLayoutGroup(),
263 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
264 localeID parameter, so we can get the layout for a particular locale.
266 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
267 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
268 * src/main/java/org/glom/web/client/place/ListPlace.java:
269 Parse and construct a lang parameter too.
271 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
272 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
273 passed to subsequent methods and constructors.
274 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
275 * src/main/java/org/glom/web/client/activity/ListActivity.java:
276 Store the localeID from the *Place and pass it to other constructors
277 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
279 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
280 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
281 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
282 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
283 * src/main/java/org/glom/web/client/ui/ListView.java:
284 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
285 Take localeID parameters and pass them to subsequent constructors and
286 methods, so that the layout is always retrieved for that locale.
288 This is rather repetitive.
290 Note that "" means the original (default) locale of the Glom document,
291 which is usually English.
293 2012-01-17 Murray Cumming <murrayc@murrayc.com>
295 Documents: Remove final keyword to fix startup configuration.
297 * src/main/java/org/glom/web/shared/Documents.java: Remove the
298 final keywords on the private member variables because that breaks
299 the startup, apparently (there are warnings) because it stops them
300 from being serialized. I added these in the previous commit.
302 2012-01-13 Murray Cumming <murrayc@murrayc.com>
304 Documents: Add some final keywords.
306 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
309 2012-01-13 Murray Cumming <murrayc@murrayc.com>
311 OnlineGlomServiceImpl: Add to overview comments.
313 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
314 Note that this is where all the document are loaded. They are not
315 loaded freshly for each page.
317 2012-01-12 Murray Cumming <murrayc@murrayc.com>
321 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
322 Add a TextBox for the text of a quick find.
323 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
325 setBackLink(): Add a String quickFind parameter.
326 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
327 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
328 to the base interface, because that is how TableSelectionViewImpl is used.
329 * src/main/webapp/style.css: Add style for the search box and its label.
331 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
332 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
333 Add these files, based on the existing TableChangeEvent and
334 TableChangeEventHandlers.
335 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
336 start(): Handle QuickFindChangeEvent, passing its quickFind text to
337 a ListPlace() that the user should be taken to.
338 * src/main/java/org/glom/web/client/activity/ListActivity.java
339 start(): Handle it here too and adapt the TableChangeEvent handler to
340 pass the extra "" quickFind parameter to ListPlace.
341 * src/main/java/org/glom/web/client/place/ListPlace.java:
342 Constructor: Take an extra String quickFind parameter and store it,
343 returning it from a new getQuickFind() method.
344 getToken(): Put the quickFind text in the URL token.
345 getPlace(): Parse the quickFind text from the URL token.
346 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
347 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
348 ListPlace constructor.
349 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
350 .java: start(): Add a Change handler for the TableSelectionView's
351 TextBox (via its base HasChangeHandlers interface), firing the new
352 QuickFindChangeEvent.
353 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
354 pass the extra "" quickFind parameter.
356 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
357 setCellTable(): Add a String quickFind parameter and pass it to
358 the ListViewTable() constructor.
359 * src/main/java/org/glom/web/client/ui/ListView.java: Change
360 setCellTable() in the base interface, because that is how ListViewImpl
363 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
364 Add a String quickFind member variable.
365 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
366 Constructor: Add a String quickFind parameter, storing it in the
367 base ListTable's member variable.
368 onRangeChanged(): Pass quickFind to the
369 OnlineGlomServiceAsync.getSortedListViewData() and
370 OnlineGlomServiceAsync.getListViewData() methods.
372 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
373 getListViewData(), getSortedListViewData(): Add a String quickFind
374 parameter, passing it to ConfiguredDocument.getListViewData().
375 * src/main/java/org/glom/web/client/OnlineGlomService.java:
376 Change getListViewData(), getSortedListViewData() in the base interface,
377 because that is how OnlineGlomServiceImpl is used, via this:
378 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
379 Change getListViewData(), getSortedListViewData() here too.
380 This class can apparently be used to asynchronously call methods on
381 OnlineGlomService, and GWT seems to implement that after recognizing
382 just the *Async name convention and the extra AsyncCallback parameters.
384 * src/main/java/org/glom/web/server/ConfiguredDocument.java
385 getListViewData(): Add a String quickFind parameter, and pass it to
386 ListViewDBAccess.getData().
387 * src/main/java/org/glom/web/server/database/ListDBAccess.java
388 getListData(): Add a String quickFind parameter and pass it to
390 getSelectQuery(): Add a String quickFind parameter.
391 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
392 getSelectQuery(): Add a String quickFind parameter and use it with
393 Glom.get_find_where_clause_quick() to pass a where_clause to
394 Glom.build_sql_select_with_where_clause(), to actually filter the
396 getData(): Add a String quickFind parameter, passing it to getListData().
397 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
398 va: getData(): Pass an empty string to getListData() for the
401 2012-01-12 Murray Cumming <murrayc@murrayc.com>
403 ListTable: Minor change.
405 * src/main/java/org/glom/web/client/ui/list/ListTable.java
406 createCellTable(): Make this protected instead of public.
408 2012-01-12 Murray Cumming <murrayc@murrayc.com>
410 Many files: Use final for the parameters and use the @override attribute.
412 2012-01-22 Ben Konrath <ben@bagu.org>
414 Add anchor links for single line text that starts with http, ftp and www.
418 2012-01-22 Ben Konrath <ben@bagu.org>
420 Add ellipsis to single line text in details view.
424 2012-01-04 Murray Cumming <murrayc@murrayc.com>
426 Remove all javadoc author tags.
428 Because they are awkward and meaningless when many people touch
430 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
432 2012-01-04 Murray Cumming <murrayc@murrayc.com>
434 Revert the COPYING.LESSER to COPYING rename.
436 Apparently both should be there if it is LGPL.
438 2012-01-03 Murray Cumming <murrayc@murrayc.com>
440 *View: Remove unused imports.
442 * src/main/java/org/glom/web/client/ui/DetailsView.java:
443 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
444 * src/main/java/org/glom/web/client/ui/ListView.java:
445 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
446 Remove unused imports, as suggested by Eclipse.
448 2012-01-02 Murray Cumming <murrayc@murrayc.com>
450 Move the *View::Presenter types, and some API into one base View.
452 * src/main/java/org/glom/web/client/ui/DetailsView.java:
453 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
454 * src/main/java/org/glom/web/client/ui/ListView.java:
455 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
456 Presenter, setPresenter() and clear() into a shared base interface,
457 to avoid the unnecessary duplicate Presenter types and to more clearly
458 show how the *Views share the same structure, even if they are not
459 used polymorphically.
461 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
462 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
464 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
465 * src/main/java/org/glom/web/client/activity/ListActivity.java:
466 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
468 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
471 Feel free to revert this if there is a good reason for the duplicate
474 2012-01-02 Murray Cumming <murrayc@murrayc.com>
476 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
478 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
479 a class member instead of a local variable in the method.
480 This lets us use it to get the view instances, for use in tests.
481 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
482 beforeOnlineGlom(): Test some more details of the initial view.
483 Again, this is not very useful.
485 To really test gwt-glom we will need to start a local postgresql
486 instance with local data, like the Glom tests in C++.
488 2012-01-02 Murray Cumming <murrayc@murrayc.com>
490 pom.xml: Mention the LGPL license.
492 * pom.xml: Add a licenses section.
493 * COPYING.LESSER: Move this to COPYING, which
494 previously contained the GPL. But gwt-glom is all LGPL.
496 2012-01-02 Murray Cumming <murrayc@murrayc.com>
498 Add project information to README and pom.xml.
500 * README: Add a brief description and mention some mvn
502 * pom.xml: This extra information shows up in mvn site
505 2011-01-02 Murray Cumming <murrayc@murrayc.com>
507 Use the latest java-libglom version.
509 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
511 2012-01-01 Murray Cumming <murrayc@murrayc.com>
513 GwtTestOnlineGlom: Test a little more.
515 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
516 protected rather than private, as suggested by the gwt-test-utils
518 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
519 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
520 Test the initial visibility of the panels.
522 However, this is not a very useful test.
523 And I wonder how we should generally test using this idea for an
524 activity/places app like ours where the real changes happen implicitly
525 based on the history token/URL.
527 2012-01-01 Murray Cumming <murrayc@murrayc.com>
529 Slight modification to *Mapper comments.
531 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
533 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
535 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
537 Remove comments mentioning GIN because they are just copied from
538 the example code and are apparently not helpful:
539 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
540 Also change the mention of a class that is only in the example code.
542 2012-01-01 Murray Cumming <murrayc@murrayc.com>
544 GwtTestOnlineGlom test: Minor changes.
546 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
547 Avoid the long qualified class name and modify the comment
548 because it is now obvious to me that the mocked class is the only
549 custom one created via GWT.create().
551 2012-01-01 Murray Cumming <murrayc@murrayc.com>
553 Tests: Added the beginnings of a test using gwt-test-utils.
555 * pom.xml: Add dependencies on gwt-test-utils and easymock.
556 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
557 which tells gwt-test-utils what class will be tested.
558 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
559 Add a simple (but empty) test case. One class, used by the OnlineGlom
560 class, is mocked so that it can be created. However, I am not sure
561 why only this class needs to be mocked.
563 Note that mockito seems more popular, and clearer, than easymock,
564 but I have not got that working yet. It might be a matter of the
567 This test is run during mvn integration-test.
569 2011-12-31 Murray Cumming <murrayc@murrayc.com>
571 Tests: Use junit4-style syntax instead of junit3-style.
573 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
574 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
575 * src/test/java/org/glom/web/shared/DataItemTest.java:
576 Use the @Test annotation rather than relying on the test*() prefix.
577 Also no longer implement TestCase, to avoid triggering support for
578 the junit3-way, which stops the annotations from working.
579 Change the imports from import junit.framework.* to
580 import org.junit.*, which is apparently the new way.
582 2011-12-31 Murray Cumming <murrayc@murrayc.com>
584 Added a test for ListPlace token parsing and creation.
586 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
587 This is much the same as DetailsPlaceTest.
589 I wonder how we could test the other parts of the *Place API.
591 2011-12-30 Murray Cumming <murrayc@murrayc.com>
593 DetailsPlace test: Also test getToken() and recreation via getPlace().
595 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
596 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
597 recreate it, testing the recreated DetailsPlace for the same parameter
600 2011-12-30 Murray Cumming <murrayc@murrayc.com>
602 Use the surefire-report plugin.
604 * pom.xml: This generates a HTML report about the tests in
605 target/site/surefire-report.html
606 when you do mvn surefire-report:report. It seems to be popular/normal.
608 2011-12-30 Murray Cumming <murrayc@murrayc.com>
610 Added a test for DetailsPlace.
612 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
613 Test the getPlace() token parsing.
615 2011-12-30 Murray Cumming <murrayc@murrayc.com>
617 Added a first unit test.
619 * pom.xml: Add a test goal, and a dependency on junit in that scope.
620 * src/test/java/org/glom/web/shared/DataItemTest.java:
621 This is a silly test but it is just to get things started. Note that
622 maven/junit finds the test because it looks in src/test by default.
624 2011-12-22 Ben Konrath <ben@bagu.org>
626 Change charsetName to "UTF-8" when replacing line breaks.
628 JavaScript requires the charsetName to be "UTF-8". CharsetName values
629 that work in Java (such as "UTF8") will not work when compiled to
632 This fixes a problem with multi-line details view fields that have hard
633 line breaks. The "License Text" field on this page demonstrates the
636 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
638 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
640 2011-12-22 Ben Konrath <ben@bagu.org>
642 Fix another bug with related list navigation.
644 I've tested all the navigation buttons in all of the related lists
645 so things should be good now.
647 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
649 2011-12-22 Ben Konrath <ben@bagu.org>
651 Fix a crasher when refreshing the list view with the default table.
653 This crash will also happen when loading the list view with the default
654 table from a link or bookmark.
656 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
657 to the main document selection page when the document id hasn't been
659 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
660 the main document selection page when the document id hasn't been
662 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
663 values for the details place when the document id hasn't been set.
664 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
665 values for the list place when the document id hasn't been set.
667 2011-12-21 Ben Konrath <ben@bagu.org>
669 Protect against NPE when glom.document.locale is not in config.
671 This patch protects against an NPE when glom.document.locale is not in
672 the config file. This NPE will also happen if glom.document.locale is
675 The patch also updates the error message to display the class name when
676 the getMessage() returns null. This was happening when the NPE was
677 thrown and I had "Configuration Error: null". If an NPE is encountered
678 with this patch, "Configuration Error: NullPointerException " will be
681 This commit closes this bug:
683 https://bugzilla.gnome.org/show_bug.cgi?id=666669
685 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
687 2011-12-20 Murray Cumming <murrayc@murrayc.com>
689 Rename onlineglom.properties to onlineglom.properties.sample.
691 * src/main/resources/onlineglom.properties: Rename to:
692 * src/main/resources/onlineglom.properties.sample:
693 * src/main/resources/README: And add this file explaining that people
694 should rename it back when deploying.
696 2011-12-20 Murray Cumming <murrayc@murrayc.com>
698 Allow choosing the translation in the .properties file.
700 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
701 init(): Read a glom.document.locale value from the configuration file
702 and call Glom's TransatableItem::set_current_locale() method.
703 * src/main/resources/onlineglom.properties: Add a commented-out
704 example of this new setting.
706 It would be better to add &lang=de_DE to the URL, but the current
707 libglom API does not allow us to do this easily. I am working on that.
709 2011-12-19 Murray Cumming <murrayc@murrayc.com>
711 Avoid a crash in parsing of token parameters.
713 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
714 ava: getTokenParams(): Do not crash if a parameter has a key but no
715 value, and ignore parameters with neither.
717 2011-12-17 Murray Cumming <murrayc@murayc.com>
719 History token building/handling: Improve use of token parameters.
721 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
722 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
723 and buildParamsToken(HashMap), for use by derived classes.
724 Make the separator private because it is no longer be needed.
725 * src/main/java/org/glom/web/client/place/DetailsPlace.java
726 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
727 instead of manual string concatenation.
728 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
729 of hardcoded indices and awkward splitting code.
730 * src/main/java/org/glom/web/client/place/ListPlace.java
731 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
732 instead of manual string concatenation.
733 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
734 of hardcoded indices and awkward splitting code.
735 This should fix bug #666420
737 2011-12-16 Murray Cumming <murrayc@murrayc.com>
739 Fix a Navgiation->Navigation typo in the code.
741 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
742 Rename processNavgiation() to processNavigation().
744 2011-12-16 Murray Cumming <murrayc@murrayc.com>
746 Fix a seperator->separator typo in the code.
748 * src/main/java/org/glom/web/client/place/DetailsPlace.java
749 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
750 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
753 2011-12-15 Ben Konrath <ben@bagu.org>
755 Cleanup some comments.
757 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
759 2011-12-14 Ben Konrath <ben@bagu.org>
761 Replace \n with <br/> for multiline text in the details view.
763 Vertical scrollbars are added when needed as well.
765 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
767 2011-12-14 Ben Konrath <ben@bagu.org>
769 Specify the font for document selection links.
771 * src/main/webapp/style.css:
773 2011-12-14 Ben Konrath <ben@bagu.org>
775 Fix bouncy CellTable while paging.
777 This doesn't currently work with related list tables in unselected
780 * src/main/java/org/glom/web/client/ui/list/ListTable.java
782 2011-12-14 Ben Konrath <ben@bagu.org>
784 Revamp the appearance of the document selection page.
786 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
787 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
788 * src/main/webapp/style.css:
790 2011-12-13 Ben Konrath <ben@bagu.org>
792 Set navigation button column to the smallest size possible.
794 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
796 2011-12-13 Ben Konrath <ben@bagu.org>
798 Change OpenButton nomenclature to NavigationButton.
800 Using NavigtionButton makes things more generic. Classes, methods and
801 variables have been changed.
803 This is a rename-only refactor.
805 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
806 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
807 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
808 Renamed from OpenButtonCell.
809 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
810 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
811 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
813 2011-12-12 Ben Konrath <ben@bagu.org>
815 Remove unnecessary String argument in RelatedListTable and ListViewTable.
817 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
818 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
819 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
820 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
822 2011-12-12 Ben Konrath <ben@bagu.org>
824 Update variable names and comments.
826 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
827 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
829 2011-12-12 Ben Konrath <ben@bagu.org>
831 Properly initialize numNonEmptyRows variable to zero.
833 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
834 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
836 2011-12-05 Ben Konrath <ben@bagu.org>
838 Add latest mockup with HTML tables.
840 Features of this mockup:
842 -> HTML table for flowtable
843 -> HTML table for flowtable column
844 -> Example of how related lists would look
845 -> Not using text entries for data items
847 The current version of Online Glom doesn't use HTML tables for the
850 This mockup has been sent to the glom-devel mailing list but it's good
851 to have it here as well.
853 * mockups/details-view-html-tables.html:
855 2011-12-05 Ben Konrath <ben@bagu.org>
857 Remove unnecessary getPrimaryKeyField() method.
859 getPrimaryKeyFieldForTable(String) has been renamed to
860 getPrimaryKeyField(String).
862 * src/main/java/org/glom/web/server/database/DBAccess.java:
863 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
864 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
866 2011-12-05 Ben Konrath <ben@bagu.org>
868 Add string representation of TypedDataItem value to conversion error message.
870 * src/main/java/org/glom/web/server/Utils.java: Logging the error
871 message was extracted into its own method to avoid duplication.
873 2011-12-05 Ben Konrath <ben@bagu.org>
875 Add type checking to navigation primary key value creation.
877 Create navigation primary key only if the expected type from the Glom
878 document matches the type returned by the SQL query.
880 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
882 2011-12-05 Ben Konrath <ben@bagu.org>
884 Rename a couple of variables in RelatedListNavigation.
886 This is a rename-only refactor.
888 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
890 2011-12-05 Ben Konrath <ben@bagu.org>
892 Move getListLayoutGroup() into getListViewLayoutGroup().
894 This removes getListLayoutGroup(). It was only being called by
895 getListViewLayoutGroup().
897 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
899 2011-12-05 Ben Konrath <ben@bagu.org>
901 Remove check for LayoutItem_Portal in list table method.
903 This check is no longer necessary because the method isn't being used
904 to create the LayoutItemPortal DTO.
906 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
908 2011-12-05 Ben Konrath <ben@bagu.org>
910 Properly support related list navigation.
912 Navigation from the "Repository Analyzer -> Package Scans ->
913 Dependencies" related table wasn't working because the primary key for
914 related tables wasn't being set properly. This commit fixes the
917 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
918 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
919 doesn't set the primary key properly for related list tables.
920 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
921 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
922 useful for getting the primary key for list view tables and for related
924 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
925 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
926 Move code to set the primary key for the table from the abstract
927 ListDBAccess class to ListViewDBAccess as it's only correct for list
929 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
930 Properly add primary key to related list tables.
932 2011-12-02 Ben Konrath <ben@bagu.org>
934 Properly set the horizontal alignment of fields.
936 This fix is for both the list tables and the details view.
938 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
939 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
940 to set the horizontal alignment of fields.
942 2011-12-02 Ben Konrath <ben@bagu.org>
944 Display currency codes in the details view.
946 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
948 2011-12-02 Ben Konrath <ben@bagu.org>
950 Avoid duplicate JNI call.
952 JNI is not as efficient as pure Java and this is an easy (and small)
955 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
956 Use previously retrieved value for whereClauseToTableName instead of
959 2011-12-02 Ben Konrath <ben@bagu.org>
961 Rename a couple of variables in RelatedListNavigation.
963 This is a rename-only refactor.
965 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
967 2011-12-02 Ben Konrath <ben@bagu.org>
969 Indicate clearly that a mismatched primary key type is a bug.
971 * src/main/java/org/glom/web/server/Utils.java: Change log level from
972 warning to error. Add 'This is a bug.' to message.
974 2011-12-02 Ben Konrath <ben@bagu.org>
976 Update / fix some comments.
978 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
980 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
982 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
983 Fix comments. Add some TODOs.
985 2011-12-02 Ben Konrath <ben@bagu.org>
987 Enable navigation to details view with string primary key from related list.
989 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
990 Create a text primary key value when return type of result is
991 java.sql.Types.VARCHAR.
993 2011-12-02 Ben Konrath <ben@bagu.org>
995 Use checkboxes for booleans in the details view.
997 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
999 2011-12-01 Ben Konrath <ben@bagu.org>
1001 Improve performance of related list height calculation.
1003 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1004 Put code to calculate the expected height in a static initializer so
1005 that that it's only called once.
1007 2011-12-01 Ben Konrath <ben@bagu.org>
1009 Show related list tables in notebooks (again).
1011 Calculate the height of the related list tables so the Notebook can be
1012 set the correct height. The height of the related list table is also needed by
1013 FlowTable to be able decide how to create the layout.
1015 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1016 and set the Portal height based on the height of the related list
1017 table and the Portal container.
1018 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1019 Add method to calculate the height of the related list tables.
1020 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1021 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1022 calculate the height of the Pager widget.
1024 2011-12-01 Ben Konrath <ben@bagu.org>
1026 Use CellTable API for table property instead of setting style on Element.
1028 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1030 2011-12-01 Ben Konrath <ben@bagu.org>
1032 Make ListViewTable and RelatedListTable a consistent height.
1034 The tables are now a consistent height regardless of the contents of
1035 the table. A hidden button is added to empty rows to ensure that the
1036 height of these rows will match the height of rows with data.
1038 A navigation button column is now added to every table. The width of
1039 the navigation column is set to 0px when a RelatedListTable shouldn't
1040 have navigation buttons. This maintains the a consistent row height in
1041 tables that don't show the navigation buttons.
1043 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1044 navigation column when not needed.
1045 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1046 arguments for navigation button to constructor of ListViewTable.
1047 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1048 hidden button for empty data rows.
1049 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1050 arguments for navigation button to constructor.
1051 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1052 create navigation buttons. Add hideNavigationButtons() method.
1053 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1054 arguments for navigation button to constructor.
1056 2011-12-01 Ben Konrath <ben@bagu.org>
1058 Use 'visibility: hidden' in Utils.getWidgetHeight().
1060 This is better choice because hidden elements are invisible, don't
1061 respond to events and are not part of the tab order. They will,
1062 however, take up space which is required to be able to calculate the
1063 height of the widget.
1065 * src/main/java/org/glom/web/client/Utils.java:
1067 2011-12-01 Ben Konrath <ben@bagu.org>
1069 Use Utils.getWidgetHeight() in FlowTable.
1071 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1073 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1075 2011-12-01 Ben Konrath <ben@bagu.org>
1077 Put the details css class name on the correct table column.
1079 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1081 2011-11-30 Ben Konrath <ben@bagu.org>
1083 Update for java-libglom API change.
1085 The getters and setters on FieldFormatting and NumericFormat were
1086 changed to remove the 'M'.
1088 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1090 2011-11-29 Ben Konrath <ben@bagu.org>
1092 Only allow RelatedListTables in Portals.
1094 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1096 2011-11-29 Ben Konrath <ben@bagu.org>
1098 Only create a contents panel for Portals when title is being set.
1100 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1102 2011-11-29 Ben Konrath <ben@bagu.org>
1104 Set TabLayoutPanel height based on calculated height its widgets.
1106 This is a potential fix for this bug:
1108 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1110 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1112 2011-11-29 Ben Konrath <ben@bagu.org>
1114 Align details field labels and data with the Open buttons.
1116 * src/main/webapp/style.css:
1118 2011-11-29 Ben Konrath <ben@bagu.org>
1120 Remove unnecessary <div> in the Notebook widget.
1122 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1123 method to get container FlowPanel (<div>).
1124 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1125 initWidget() method directly on the TabLayoutPanel widget instead of
1126 Group's container widget.
1128 2011-11-29 Ben Konrath <ben@bagu.org>
1130 Don't add group titles for Portals in Notebooks.
1132 This reverts the previous patch and fixes a bug I introduced with
1133 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1135 * src/main/java/org/glom/web/client/ui/details/Group.java:
1136 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1138 2011-11-28 Ben Konrath <ben@bagu.org>
1140 Remove unused boolean argument in Portal constructor.
1142 Just a code cleanup.
1144 * src/main/java/org/glom/web/client/ui/details/Group.java:
1145 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1147 2011-11-28 Ben Konrath <ben@bagu.org>
1149 Remove hack for glom 1.18 style glom files.
1151 * src/main/java/org/glom/web/client/ui/details/Group.java:
1152 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1153 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1155 2011-11-28 Ben Konrath <ben@bagu.org>
1157 Use Gda Value version of primary key to log result too large error.
1159 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1161 2011-11-28 Ben Konrath <ben@bagu.org>
1163 Don't use TypedDataItem.getText() for Unknown types from the URL.
1165 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1166 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1167 instead of getText().
1168 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1169 String field and getUnknown() method.
1171 2011-11-28 Ben Konrath <ben@bagu.org>
1173 Log an error message when the java-libglom .so is not present.
1175 The error message was being set in the exception but not logged.
1177 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1179 2011-11-28 Ben Konrath <ben@bagu.org>
1181 Ignore LayoutItem_CalendarPortals.
1183 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1184 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1186 2011-11-28 Ben Konrath <ben@bagu.org>
1188 Extract method for creating the LayoutItemPortal DTO.
1190 Just breaking the code up into smaller chunks.
1192 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1194 2011-11-28 Ben Konrath <ben@bagu.org>
1198 This should have been added with the refactor. Oops!
1200 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1202 2011-11-28 Ben Konrath <ben@bagu.org>
1204 Create primary key value from URL string using type from Glom document.
1206 See this bug, comments 19 - 25:
1208 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1210 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1211 create a TypeDataItem for the primary key here when loading from a
1212 URL. Show the same string for the primary key value as was received
1213 from the URL string (when loading from a URL).
1214 * src/main/java/org/glom/web/server/Utils.java: Update method for
1215 creating the Gda Value from the TypeDataItem to properly deal with
1216 creating a Gda Value based on the Glom document type for the primary
1217 key value string when loading from a URL.
1218 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1219 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1220 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1221 Update for changed method name.
1223 2011-11-27 Ben Konrath <ben@bagu.org>
1225 Rename PrimaryKeyItem to TypedDataItem.
1227 The name PrimaryKeyItem suggests what the class should be used for.
1228 TypedDataItem is a neutral name that describes the class better.
1230 This is a rename-only refactor.
1232 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1233 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1234 * src/main/java/org/glom/web/client/Utils.java:
1235 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1236 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1237 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1238 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1239 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1240 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1241 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1242 * src/main/java/org/glom/web/server/Utils.java:
1243 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1244 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1245 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1246 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1248 2011-11-25 Ben Konrath <ben@bagu.org>
1250 Improve Gda Value conversion from PrimaryKeyItem.
1252 The value from the PrimaryKeyItem is only used if its type match the
1253 type from the glom document.
1255 * src/main/java/org/glom/web/server/Utils.java:
1257 2011-11-25 Ben Konrath <ben@bagu.org>
1259 Manually check if the java-liblgom .so is visible to the JVM.
1261 It seems that Tomcat has problems when a static initializer throws an
1262 exception. This check is done before the first method call into
1263 java-libglom so that execution doesn't continue if the .so is not
1266 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1268 2011-11-25 Ben Konrath <ben@bagu.org>
1270 Improve browser configuration error messages.
1274 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1276 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1277 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1278 getConfigurationErrorMessage() method.
1279 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1280 Get and display a specific configuration error message when no Glom
1281 documents are found.
1282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1283 Implement getConfigurationErrorMessage() method. Surround configuration
1284 code in the init() method with a try/catch block. This allows the
1285 errors to be caught while keeping the servlet available to retrieve the
1286 configuration error message.
1288 2011-11-25 Ben Konrath <ben@bagu.org>
1290 Don't use Strings to hold primary key values.
1292 The primary key values are now held in a new data object
1293 (PrimaryKeyItem) that holds type information and the primary key value
1294 using the correct type.
1296 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1297 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1298 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1299 PrimaryKeyItem instead of String to hold the primary key value.
1300 * src/main/java/org/glom/web/client/Utils.java: Remove
1301 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1302 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1303 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1304 PrimaryKeyItem instead of String to hold the primary key value. Load
1305 document selection page when the documentID has not been set correctly.
1306 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1307 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1309 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1310 Return empty string for URL instead of "null".
1311 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1312 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1313 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1314 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1315 PrimaryKeyItem instead of String to hold primary key values.
1316 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1317 PrimaryKeyValue to a Gda Value.
1318 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1319 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1320 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1321 Replace temporary database access code that uses the PrimaryKeyValue to
1322 Gda Value conversion.
1323 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1324 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1325 PrimaryKeyItem instead of String.
1326 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1327 hold primary key values.
1329 2011-11-24 Ben Konrath <ben@bagu.org>
1331 Use newly added java-libglom API to create queries.
1333 This isn't finished. I still need to stop using Strings for primary key
1334 values in the client code.
1336 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1337 libglom to use fake connections so that retrieving the query string will
1339 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1340 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1341 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1342 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1343 Use the newly added libglom sql methods and classes to create the
1344 query. Add temporary hack to convert primary value strings to Gda
1347 2011-11-23 Ben Konrath <ben@bagu.org>
1349 Don't explicitly set the height of Portals.
1351 See comments 6 - 10 of this bug for details:
1353 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1355 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1357 2011-11-23 Ben Konrath <ben@bagu.org>
1359 Use an HTML table instead of CSS for the FlowTable layout.
1361 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1362 GWT's FlexTable to implement the FlowTable.
1363 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1365 2011-11-18 Ben Konrath <ben@bagu.org>
1367 Add boolean example to HTML table mockup.
1369 * mockups/details-view-html-tables-text-entries.html:
1371 2011-11-17 Ben Konrath <ben@bagu.org>
1373 Ensure the pager buttons are always visible for related lists.
1375 To accomplish this, I've turned off text wrapping in the list view and
1376 related list tables for both the header and data text. The related list
1377 table now has a fixed layout so the it doesn't overflow its container.
1378 This is required to ensure that the cell text is clipped when it
1379 overflows the cell and an ellipsis is added to the right side of the
1380 cell when text is clipped.
1382 A fixed table layout for the related list table in the details view
1383 seems what we want for the details view anyway, so the side-effect is
1386 The ellipsis will only be displayed in Firefox >= 7.
1390 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1392 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1393 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1394 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1396 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1397 Set the 'table-layout: fixed' CSS property to the related list table.
1398 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1399 'white-space: nowrap;' CSS property on both the list view and the
1400 related list tables.
1402 2011-11-16 Ben Konrath <ben@bagu.org>
1404 Rework the fix for empty notebook tab labels.
1406 Setting the empty group titles with its name caused problems for the
1407 details layout. Instead of using libglom's
1408 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1409 to the client when the title is empty. This allows the Notebook to use
1410 the name when the title is empty without affecting anything else.
1412 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1413 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1415 2011-11-16 Ben Konrath <ben@bagu.org>
1417 Set group titles with name when title is empty.
1419 This fixes a problem with an empty notebook tab label in the Lesson
1420 Planner document. The forth tab in the notebook should be "Internet":
1422 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1424 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1425 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1428 2011-11-16 Ben Konrath <ben@bagu.org>
1430 Remove whitespace from the configured username properties.
1432 This assumes that usernames won't have whitespace at the beginning
1433 or end. But I think this is a reasonable assumption.
1435 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1436 String.trim() to remove the whitespace from the username properties.
1438 2011-11-15 Ben Konrath <ben@bagu.org>
1440 Add details view mockup with HTML tables and text entries.
1442 This is from the attachment on this bug:
1444 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1446 * mockups/details-view-html-tables-text-entries.html:
1448 2011-11-15 Ben Konrath <ben@bagu.org>
1450 Add space between the columns of the flow table.
1454 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1456 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1457 space between columns in the flow table.
1459 2011-11-15 Ben Konrath <ben@bagu.org>
1461 Add backup files to the .gitignore.
1463 * .gitignore: Ignore files that end with ~.
1465 2011-11-09 Ben Konrath <ben@bagu.org>
1467 Use latest release of gwt-log.
1469 Gwt-log releases are now being submitted to the maven central
1470 repository so manual installation of the jar is no longer required.
1472 * pom.xml: Update version and groupId of gwt-log dependency.
1474 2011-10-31 Ben Konrath <ben@bagu.org>
1476 Don't use GWT numeric formatting to override the glom currency formatting.
1478 Currencies are now displayed like they are in Glom. See this bug:
1480 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1482 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1484 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1485 currency code to constructor and set it when the cell is rendered.
1486 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1487 currency code to the constructor of the NumericCell.
1489 2011-10-27 Ben Konrath <ben@bagu.org>
1491 Require the latest release of java-libglom (1.17.4).
1495 2011-10-26 Ben Konrath <ben@bagu.org>
1497 Add style to Notebook that matches current theme.
1499 It's not the best style in the world but it's better than the default.
1501 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1502 padding at the bottom of the child widgets.
1503 * src/main/webapp/style.css: Add style for the Notebook.
1505 2011-10-26 Ben Konrath <ben@bagu.org>
1507 Move servlet initialization code to overridden init method.
1509 This is half of the solution to getting proper error messages
1510 displayed when configuration errors occur. Here's the relevant bug:
1512 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1514 The rest of the solution involves surrounding the init method with a
1515 try/catch block and setting a global variable with the error /
1516 exception. A new async method should be created to retrieve and display
1517 the error message / exception.
1519 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1520 code from constructor to init method adding exceptions as needed.
1522 2011-10-26 Ben Konrath <ben@bagu.org>
1524 Add script to monitor and restart tomcat if required.
1526 * utils/check-and-recover-tomcat.py: New file.
1528 2011-10-26 Ben Konrath <ben@bagu.org>
1530 Display the correct number of data items in the pager.
1534 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1536 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1537 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1538 The implementation is the same for both tables: Keep track of the
1539 number of non-empty rows and fire and RowCountChangeEvent after the data has
1541 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1542 custom Pager class that subclasses SimplePager to handle displaying
1543 the correct number when empty rows have been added.
1545 2011-10-26 Ben Konrath <ben@bagu.org>
1547 Correct error in previous commit.
1549 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1550 eventBus parameter from listView.setCellTable().
1552 2011-10-26 Ben Konrath <ben@bagu.org>
1554 Fix error in TODO comment.
1556 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1558 2011-10-24 Ben Konrath <ben@bagu.org>
1560 Create Notebook widgets to the details view.
1562 This isn't finished just yet - I still need to create a reasonable
1563 style to match the current theme.
1565 * src/main/java/org/glom/web/client/Utils.java: Add method for
1566 calculating the height of a widget. This is used in the Notebook class.
1567 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1568 new constructor method in Group.
1569 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1570 method for creating child widget that can be used by subclasses
1571 like Notebook. New constructor that allows disabling the group
1572 titles - Notebooks don't set a group title for their child groups.
1573 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1574 to make Notebooks using GWT's TabLayoutPanel.
1575 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1576 constructor that allows disabling the group titles.
1577 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1578 LayoutItemNotebook DTO.
1579 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1580 DTO for Notebooks. It's just an empty class for now but we might need
1581 it to transfer some specific information in the future.
1583 2011-10-21 Ben Konrath <ben@bagu.org>
1585 Add navigation buttons to related list tables.
1587 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1588 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1589 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1590 method getSuitableRecordToViewDetails() for getting the table name
1591 and primary key value for related list navigation buttons.
1592 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1593 private cell renderer class to get the navigation information for
1594 related list tables from the server. Extract the navigation
1595 processing code from the details cell navigation and use it for the
1596 related list navigation as well.
1597 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1598 cell renderer class for the details open buttons. This was needed
1599 because the related list navigation buttons and the list view
1600 navigation buttons need to react differently when clicked.
1601 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1602 the onEnterKeyDown() method because it's now overriden in the
1603 subclasses that are specific to the related list tables and the list
1605 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1606 the vertical size a little because the buttons add a bit of vertical
1607 space to table. This is not a perfect solution because the vertical
1608 size of with table fewer than 5 rows will be a little smaller.
1609 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1610 changes in how navigation buttons are handled.
1611 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1612 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1613 database access object.
1614 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1615 to find the portal for a given relationship name from
1616 RelatedListDBAccess. Add method to find a primary key field for a
1618 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1619 Move code to find the portal for a given relationship name to
1621 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1622 New file: database access object for getting the related list
1623 navigation information (the table name and the primary key value).
1624 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1625 DTO for transferring a table name to navigate to and a primary key
1627 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1628 boolean and getter/setter to specifies if the related list should add
1631 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1633 Use the master branch of java-libglom
1635 * pom.xml: Depend on java-libglom 1.19 instead.
1637 This is the master branch. See also the libglom-1-18 branch.
1639 2011-10-11 Ben Konrath <ben@bagu.org>
1641 Enable the open navigation button when the data has been set.
1643 This avoids having active buttons that don't do anything when the data
1646 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1648 2011-10-11 Ben Konrath <ben@bagu.org>
1650 Use IsWidget interface for FlowTableItem.
1652 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1653 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1655 2011-10-11 Ben Konrath <ben@bagu.org>
1657 Remove GWT styling from open button in details view.
1659 There are still some issues with how the details cell is arranged but
1660 this should be made to match Glom 1.20. I'm going to leave fixing this
1661 until I have Glom 1.20 up and running.
1663 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1664 style name on open button.
1665 * src/main/webapp/style.css: Move and edit details-navigation class.
1666 Re-arrange some classes to make them appear in the same order as the
1669 2011-10-07 Ben Konrath <ben@bagu.org>
1671 Update to GWT 2.4.0.
1673 * .gitignore: Ignore new cache directory.
1674 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1675 * pom.xml: Change GWT and maven plugin to 2.4.0.
1676 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1678 * src/main/java/org/glom/web/client/ClientFactory.java:
1679 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1680 * src/main/java/org/glom/web/client/OnlineGlom.java:
1681 Update source for API changes.
1682 * utils/build-onlineglom-war.sh: Remove cache directory before the
1685 2011-10-07 Ben Konrath <ben@bagu.org>
1687 Add navigation buttons in the details view.
1689 This isn't finished but I thought I'd commit what I have as it's a
1690 pretty good start. I still need to:
1692 1. Change the style so that it fits better into the current theme
1693 2. Adjust the details cell to expand as much as possible.
1695 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1696 click handlers to navigation buttons in the DetailsCells. Create a
1697 refreshData() method to get just the data from the server without the
1699 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1700 Update the tableSelector and browser title when the table name
1701 changes without using the tableSelector.
1702 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1703 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1704 getDetailsCells() to getCells(). Update variable names.
1705 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1706 method to set click handler on navigation button. Rename a few
1707 variables. Add navigation buttons where needed.
1708 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1709 variables and methods.
1710 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1711 navigation boolean and navigation table as required in the
1712 LayoutItemField DTO.
1713 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1714 variables for navigation along with getter/setter methods.
1716 2011-10-07 Ben Konrath <ben@bagu.org>
1718 Rename Field to DetailsCell.
1720 This is a refactor-only commit. No functionality has been added or
1723 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1724 Update variable and method names.
1725 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1726 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1727 variable and method names.
1728 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1730 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1731 variable and method names.
1733 2011-10-07 Ben Konrath <ben@bagu.org>
1735 Create separate methods for layout and data the details view.
1737 This is a refactor-only commit. No functionality has been added or
1740 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1741 private methods: setData(), createLayout().
1743 2011-10-07 Ben Konrath <ben@bagu.org>
1745 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1747 This is part of a change to get navigation buttons in the details view
1748 but it should have been done this way from the start.
1750 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1751 for method name change in TableSelectionView.
1752 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1753 Create TableChangeEvent and set the browser title using the
1754 TableSelectionView API.
1755 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1756 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1757 Change getSelectedTable() to getSelectedTableName(). Add
1758 getSelectedTableTitle().
1760 2011-10-07 Ben Konrath <ben@bagu.org>
1762 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1764 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1766 2011-10-07 Ben Konrath <ben@bagu.org>
1768 Update TableChangeEvent to use newTableName naming convention.
1770 This makes the class more consistent with GWT naming conventions.
1772 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1773 Update for method name change in TableChangeEvent.
1774 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1775 for method name change in TableChangeEvent.
1776 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1777 newTableName variable and getter method. Make toDebugString()
1780 2011-09-30 Ben Konrath <ben@bagu.org>
1782 Disable the pager in the list tables when the data row count is less than the minimum.
1784 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1785 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1787 2011-09-30 Ben Konrath <ben@bagu.org>
1789 Add empty rows to the end of related list and list view tables.
1791 I also extracted the cell rendering classes from the ListTable because
1792 the code was becoming a little crazy with all the anonymous inner
1793 classes. My plan is to use these cell rendering classes in the details
1794 view as well so this refactor will be needed for that change.
1796 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1797 set the row count in related list tables if the data has more rows
1798 than the minimum number of rows visible.
1799 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1800 row count in list view tables if the data has more rows than the
1801 minimum number of rows visible.
1802 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1803 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1805 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1806 for rendering TYPE_NUMERIC cells. The code was extracted from the
1808 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1809 class for rendering cells with buttons in list views. The code was
1810 extracted from the ListTable class.
1811 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1812 for rendering TYPE_TEXT cells. The code was extracted from the
1814 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1815 Add empty rows to the end of the data if required. Implement
1816 ListTable.getMinNumVisibleRows().
1817 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1818 cell renderer code to public classes. Return null in
1819 Column.getValue() for empty rows. Add new abstract method:
1820 getMinNumVisibleRows(). Move code to set the row count of the list view
1821 table to ListViewImpl.
1822 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1823 empty rows to the end of the data if required. Implement
1824 ListTable.getMinNumVisibleRows().
1827 2011-09-27 Ben Konrath <ben@bagu.org>
1829 Use GWT.log for client-side debugging statements.
1831 These are optimized out when deployed so I should have used this method
1832 in the first place. These statements will eventually be replaced with some sort
1833 of notification in the browser.
1835 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1836 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1837 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1838 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1839 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1841 2011-09-27 Ben Konrath <ben@bagu.org>
1843 Put tableselector on the right, back to list link on right.
1845 The idea is that the table selector is acting like a label for the
1846 currently displayed table so it should be placed below the document title. This
1847 puts the table title in a similar position to where it is in Glom.
1849 * mockups/details-contacts.html:
1850 * mockups/details-projects.html:
1851 * mockups/listview-contacts.html:
1852 * mockups/listview-projects.html:
1853 * mockups/style.css:
1854 Update mockups to match how the interfaces currently look.
1855 * src/main/webapp/style.css: Swap positions of backlink with the table
1856 selector. Add some space on the left side of the table selector to
1857 line things up with the document title.
1859 2011-09-27 Ben Konrath <ben@bagu.org>
1861 Add field colouring to details view.
1863 This change re-works how field colouring works. The colour formatting
1864 information is now set to the client with the layout information instead of
1865 with the data. This eliminates the need to send the same colour strings for
1866 data in list view column when colour information is set.
1868 In order to set an alternate colour for negative numeric values, the
1869 number is now sent to client and formatted with the GWT NumberFormat class.
1871 This change also fixes:
1873 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1875 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1876 internationalization framework which is needed for client side numeric
1878 * src/main/java/org/glom/web/client/Utils.java: New file for some
1879 client static utility methods.
1880 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1881 the DataItem object to the Field class. Use a utility method to
1882 create the foreignKeyValue string.
1883 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1884 alignment and text colours in the constructor. Add setData(DataItem)
1885 method. Remove setText(String) method.
1886 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1887 colour information to GlomTextCell. Create and use GlomNumberCell for
1888 rendering numbers. Use utility method to get the string for the
1889 primary key of the key provider. Re-work how the horizontal alignment
1891 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1892 formatting to layout information. Methods for converting the libglom
1893 formatting information were moved from DBAccess.
1894 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1895 numeric formatting (it's now done on the client side). Don't set text
1896 colours in DataItem. Move libglom formatting conversion methods to
1898 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1899 getters/setters for text colour information.
1900 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1901 for transferring the libglom NumericFormat information to the client.
1902 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1903 and getters/setters for: GlomNumericFormat, background colour and
1904 foreground colour strings.
1906 2011-09-26 Ben Konrath <ben@bagu.org>
1908 Simplify code that iterates through the LayoutGroup.
1910 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1912 2011-09-26 Ben Konrath <ben@bagu.org>
1914 Accept Eclipse formatting for OnlineGlomServiceAsync.
1916 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1918 2011-09-26 Ben Konrath <ben@bagu.org>
1920 Don't use the ListDBAccess classes to get the primary key layout information.
1922 This was causing a bug where the wrong index for the hidden primary key
1923 was being sent to the client.
1925 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1926 primary key while creating the LayoutGroup DTO. Create a
1927 LayoutItemField DTO for hidden primary keys. Don't use the
1928 RelatedListDBAccess because it was only used for getting the primary
1930 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1931 access modifier from public to protected for getPrimaryKeyField() and
1932 getPrimaryKeyLayoutItemField().
1933 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1934 abstract method getExpectedResultSize() because RelatedListDBAccess
1935 doesn't have enough info to implement it.
1936 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1937 Remove @Override for getExpectedResultSize().
1938 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1939 Remove method getExpectedResultSize().
1941 2011-09-23 Ben Konrath <ben@bagu.org>
1943 Log which layout (list or details) the ignored item is from.
1945 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1947 2011-09-23 Ben Konrath <ben@bagu.org>
1949 Remove annotations that turn off code formatting in DataItem.
1951 * src/main/java/org/glom/web/shared/DataItem.java:
1953 2011-09-23 Ben Konrath <ben@bagu.org>
1955 Rename GlomField to DataItem and update associated methods.
1957 This is a rename-only refactor. No functionality has been added or
1960 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1961 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1962 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1963 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1964 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1965 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1966 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1967 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1968 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1969 * src/main/java/org/glom/web/server/database/DBAccess.java:
1970 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1971 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1972 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1973 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1974 * src/main/java/org/glom/web/shared/DataItem.java:
1975 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1976 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1978 2011-09-23 Ben Konrath <ben@bagu.org>
1980 Rename GlomDocument to DocumentInfo and update associated methods.
1982 This is a rename-only refactor. No functionality has been added or
1985 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1986 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1987 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1988 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1989 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1990 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1991 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1993 2011-09-20 Ben Konrath <ben@bagu.org>
1995 Require java-libglom 1.17.3.
1997 This picks up the fix for the seg fault problem with the Scenes table
1998 in the Openismus Film Manager example.
2002 2011-09-20 Ben Konrath <ben@bagu.org>
2004 Change the way sort clause is added for primary key when no sort clause is requested.
2006 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2007 before the sort clause is created. When a sort clause is not requested, the
2008 sort clause is created by finding the primary key in the LayoutFieldVector
2011 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2013 2011-09-20 Ben Konrath <ben@bagu.org>
2015 Log error message if no documents are found in the configured directory.
2017 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2018 Extract the glom file extension string to a private static final class
2019 variable (mostly as syntactic sugar). Accept a minor formatting change.
2020 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2021 the example glom.document.directory configuration property to make it
2022 more clear that it can any directory, not just the home directory.
2024 2011-09-18 Ben Konrath <ben@bagu.org>
2026 Add related lists to details view.
2028 The related list table has support for paging and sorting just like the
2029 table in the list view.
2031 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2032 SQL queries for the related list tables.
2033 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2034 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2036 Rename getList methods to getListView and add comments. Remove
2037 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2038 it being unused. Add methods: getDetailsLayoutAndData(),
2039 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2040 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2041 Create the layout and set the data for the fields in one async call
2042 instead of two. Create related lists where appropriate.
2043 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2044 for method name changes in OnlineGlomService.
2045 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2046 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2047 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2049 * src/main/java/org/glom/web/client/ui/ListView.java:
2050 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2051 tableName from setCellTable(). Create a ListViewTable instead of
2053 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2054 represent a data field in the details view.
2055 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2056 from addDetailsCell() to Field class. Keep track of the Fields and
2057 Portals in the details view.
2058 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2059 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2060 and add a method to get it. Add method to set the contents of the
2062 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2063 New class for related list tables. This class has the data provider
2064 for the related list table.
2065 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2066 abstract class which is the base class for the ListViewTable and the
2068 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2069 New class for list view tables. This class has the data provider for
2070 the list view table.
2071 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2072 methods for related list tables. Add more information to the
2073 LayoutItemField and LayoutItemPortal DTOs.
2074 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2075 Remove debugging print statement.
2076 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2077 Remove debugging print statements. Add primary key field to SQL count
2079 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2080 Remove unnecessary LayoutFieldVector parameter from
2081 getResultSizeOfSQLQuery() method.
2082 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2083 New class for related list table database access.
2084 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2085 class that is a wrapper DTO for details view layout and data.
2086 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2087 new 'fromField' string to this DTO.
2088 * src/main/webapp/style.css: Remove bottom margin and override top
2091 2011-09-15 Ben Konrath <ben@bagu.org>
2093 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2095 This sets things up to make it easier to add the data retrieval for
2096 related lists (portals). No user noticeable changes were made with
2099 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2100 class has the code to retrieve the layouts and access the
2101 database using the new database helper classes.
2102 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2103 Most of the functionality has been removed from this class. This
2104 class now represents the public interface for the client side
2105 code. It also deals with configuring the servlet and cleaning
2106 things up when the servlet is stopped.
2107 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2108 of static methods into this utility class.
2109 * src/main/java/org/glom/web/server/database/DBAccess.java:
2110 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2111 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2112 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2113 These classes have the database retrieval code. The class hierarchy
2114 has been setup to make it easy to reuse code for similar
2117 2011-09-06 Ben Konrath <ben@bagu.org>
2119 Create separate classes for list table code and the data provider.
2121 As part of this refactor, I also split up the code a bit to make it
2124 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2125 table code to two new classes (below).
2126 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2127 with code from ListViewImpl.
2128 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2129 New file with code from ListViewImpl.
2131 2011-09-06 Ben Konrath <ben@bagu.org>
2133 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2135 This fixes the LayoutItemPortal DTO to match the libglom layout object
2138 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2140 2011-09-01 Ben Konrath <ben@bagu.org>
2142 Set title of Portals in the Details View.
2144 * pom.xml: Bump required version of java-libglom to 1.17.1.
2145 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2146 widget creation to its own class. Add comments to constructor.
2147 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2148 The code is mostly from the Group class with the title now set.
2149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2150 title of Portal. Update some comments. Fix some code formatting.
2152 2011-09-01 Ben Konrath <ben@bagu.org>
2154 Remove TODO comment for the flow table column width.
2156 The flow table column width is working correctly and doesn't need to be
2157 changed. See this mailing list post for more info:
2159 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2161 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2163 2011-08-27 Ben Konrath <ben@bagu.org>
2165 Add document title (database name) to top of the browser page.
2167 I added the document title to the TableSelecitonView but that will
2168 change if / when we add a view that doesn't require table selection.
2170 * mockups/details-contacts.html:
2171 * mockups/details-projects.html:
2172 * mockups/listview-contacts.html:
2173 * mockups/listview-projects.html:
2174 * mockups/style.css: Add document title to mockups to keep things
2176 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2177 sizes to account for the document title.
2178 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2179 Set the document title when it has been retrieved from the server.
2180 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2181 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2182 and implement setDocumentTitle(String) method.
2183 * src/main/webapp/style.css: Add ID for document title style.
2185 2011-08-25 Ben Konrath <ben@bagu.org>
2187 Add NavigationType enum to LayoutItemPortal DTO.
2189 This is the start of adding support for Portals to the Details View.
2191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2192 LayoutItem_Portal.navigation_type enum from libglom to
2193 LayoutItemPortal.NavigationType enum.
2194 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2195 NavigationType enum, field for storing the NavigationType and getter
2198 2011-08-25 Ben Konrath <ben@bagu.org>
2200 Implement the flow table layout in the Details View.
2202 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2203 FlowTable to Group to account for the renamed class.
2204 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2205 File. This is a container widget that implements the Glom details view
2206 flow table behaviour.
2207 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2208 org/glom/web/client/ui/FlowTable.java.
2209 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2210 so that the size of the subgroups are a closer match to the size of
2211 the Glom subgroups. This makes the flowtable layout match the layout
2212 in Glom for the Music Collection example file.
2214 2011-08-16 Ben Konrath <ben@bagu.org>
2216 Create container element for LayoutItemPortal in Details View.
2218 This will help me develop the layout for the FlowTable.
2220 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2221 fieldPanel variable to detailsCell.
2223 2011-08-15 Ben Konrath <ben@bagu.org>
2225 Set the height of the data element in the Details View.
2227 I changed the InlineLabels (text in a span element) to Labels (text in
2228 a div element) so that I could set the height of the details-data
2229 elements instead of the details-cell parent elements. This allows the
2230 the details-data element to display the correct height if style is
2231 applied that shows the height.
2233 This change has the added benefit of allowing the order of the labels
2234 and data elements to be changed for right-to-left languages.
2236 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2237 InlineLabels to Labels.
2238 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2239 InlineLabels to Labels. Set the height of the data element.
2240 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2241 multiline text height in the Formatting DTO.
2242 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2243 for multiline height along with getter and setter methods.
2244 * src/main/webapp/style.css: Adjust style to account for the change
2245 from span elements to div elements in the details cell.
2247 2011-08-15 Ben Konrath <ben@bagu.org>
2249 Make the List View appearance match the mockups.
2251 It doesn't match exactly but it's much better than it was.
2253 * mockups/listview-contacts.html: Remove unused css classes.
2254 * mockups/listview-projects.html: Remove unused css classes.
2255 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2256 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2257 for mainPanel instead of VerticalPanel (table). Set style name on
2258 CellTable. Set style name on Details column. Right-align Details
2260 * src/main/webapp/style.css: Adjust properties to match the mockups.
2262 2011-08-12 Ben Konrath <ben@bagu.org>
2264 Add better support for subgroups in the details view.
2266 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2267 changed FlowTable constructor.
2268 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2269 support for subgroups and subgroup-titles.
2270 * src/main/webapp/style.css: Add CSS class for subgroups and
2273 2011-08-12 Ben Konrath <ben@bagu.org>
2275 Return the top level LayoutGroup title.
2277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2279 2011-08-11 Ben Konrath <ben@bagu.org>
2281 Make the TableSelector header match the mockup.
2283 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2284 the layout panel. Properly lineup the table selection header with
2285 the list and details view.
2286 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2287 margin around the details view.
2288 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2289 Rename listBox variable to tableSelector. Set id for the style sheet.
2290 Use a FlowPanel instead of a HorizontalPanel.
2291 * src/main/webapp/style.css: Add properties to make the TableSelector
2292 box match the mockups.
2294 2011-07-13 Ben Konrath <ben@bagu.org>
2296 Update install script for java-libglom version change.
2298 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2301 2011-07-13 Ben Konrath <ben@bagu.org>
2303 Add support sub-group in the details view.
2305 I also removed the code that special-cased the default details view
2308 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2310 I still have to make a proper flowtable.
2312 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2313 Don't special-case default details view layout.
2314 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2315 addLayoutField() as I'm going to use it.
2316 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2317 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2319 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2320 extracted from DetailsViewImpl.GroupPanel. Add support for
2322 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2323 column count when getting the details layout.
2325 2011-07-12 Ben Konrath <ben@bagu.org>
2327 Set browser title with database and table titles.
2329 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2330 Set the browser title when the table changes and when the activity
2332 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2333 title when retrieving document info (the GlomDocument object).
2334 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2335 with getter and setter methods. Remove unused convenience constructor.
2336 Use default code formatting.
2338 2011-07-12 Ben Konrath <ben@bagu.org>
2340 Ignore LayoutItemPortals in the details view.
2342 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2345 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2346 LayoutItemPortal layout objects.
2347 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2348 LayoutItemPortal objects when retrieving the details layout.
2349 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2350 file. This is an empty class and just used to get type information for
2353 2011-07-12 Ben Konrath <ben@bagu.org>
2355 Use java-libglom 1.17.0.
2359 2011-07-11 Ben Konrath <ben@bagu.org>
2361 Remove "Table:" label from table selector.
2363 This matches a recent change in the Glom UI.
2365 * mockups/details-contacts.html:
2366 * mockups/details-projects.html:
2367 * mockups/listview-contacts.html:
2368 * mockups/listview-projects.html: Remove the "Table:" label from the
2370 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2372 2011-07-11 Ben Konrath <ben@bagu.org>
2374 Add main groups to the details view.
2376 This makes things look a little nicer in the details view. The next step
2377 is to implement the flowtable.
2379 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2380 resources from the standard gwt css theme. Standard.css is now
2381 included in OnlineGlom.html so that the online glom css rules have
2382 precedence over the gwt theme.
2383 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2384 the whole LayoutGroup to the DetailsView instead of just the titles.
2385 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2386 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2387 details layout with a helper class (GroupPanel). I might extract this
2388 class when I make the full flowtable.
2389 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2390 string as default so I don't have to worry about NPEs when processing
2392 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2393 note beside OnlineGlom.gwt.xml above).
2394 * src/main/webapp/style.css: Add default font-size to body to override
2395 the font-size set by the standard theme. Don't use h2 tags for
2396 group-title. Create new details-cell class.
2398 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2400 ConfiguredDocument: Set the port number too.
2402 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2403 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2404 Glom document. Presumably this worked sometimes so far because there is a
2405 default port number.
2407 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2409 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2411 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2412 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2413 correct, though we should throw an exception too.
2415 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2417 Fix a addDocuemnt typo.
2419 * src/main/java/org/glom/web/shared/Documents.java
2420 (Documents.addDocuemnt): Rename to addDocument().
2421 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2422 (OnlineGlomServiceImpl.getDocuments): Adapt.
2424 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2426 Slightly improved log output when connection fails.
2428 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2429 (ConfiguredDocument.setUsernameAndPassword):
2430 We don't know for sure if it' the username/password that's wrong, so
2431 rephrase the message.
2432 Also ouput the exception message, though it's generic in this case.
2434 2011-07-08 Ben Konrath <ben@bagu.org>
2438 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2439 added braces to a one line if statement because the Eclipse formatter
2440 was getting confused.
2442 2011-07-07 Ben Konrath <ben@bagu.org>
2444 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2446 These should really be two separate tasks but I counldn't get things to
2447 work with GWT 2.2.0 and Eclipse 3.7.
2451 * .settings/org.eclipse.jdt.core.prefs:
2452 * .settings/org.eclipse.jdt.ui.prefs:
2453 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2454 * .settings/org.eclipse.m2e.core.prefs:
2455 Add new config files. Update current files. Remove references to the
2456 webtools plugins as we're not using any of the webtools features.
2457 * .gitignore: Add logs directory which is created when running with
2459 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2460 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2461 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2463 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2465 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2467 onlineglom.properties: Add explanatory comments.
2469 * src/main/resources/onlineglom.properties: Also change the default user
2470 from ben to someuser, to avoid the risk of people thinking we just
2471 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2473 2011-06-28 Ben Konrath <ben@bagu.org>
2475 Use filename in Log for incorrect passwords.
2477 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2478 getFileName(String) method to get the filename from the URI.
2480 2011-06-28 Ben Konrath <ben@bagu.org>
2482 Add the table name to the URL token for the ListPlace.
2484 This makes things consistent between the DetailsPlace and the
2485 ListPlace. It also allows the the ListPlace to be bookmarked.
2487 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2488 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2489 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2490 Remove getDefaultListLayout(). The default layout is now returned
2491 by the getListLayout() method when the table name is an empty string.
2492 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2493 Add table name field. Change to a new ListPlace when the table
2494 has been changed. Use getListLayout() for getting the default
2496 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2497 Add table name field. Set the correct table name in the list box
2498 when loading from bookmark. This corrects a problem for the
2500 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2501 Move table name to super-class (HasSelectableTable). Move document
2502 and table URL keys to super-class in HasSelectableTable.
2503 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2504 Add table name field. Add Tokenizer class with URL key common to
2505 the subclasses (DetailsPlace and ListPlace).
2506 * src/main/java/org/glom/web/client/place/ListPlace.java:
2507 Add table name. Add code to parse the URL token.
2508 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2509 Update ListPlace construction with empty table name string.
2510 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2511 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2512 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2513 Update ListPlace construction with table name string.
2514 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2515 Change defaultTableName field to tableName to reflect how it's now
2516 used. Update the getter and setter methods.
2518 2011-06-28 Ben Konrath <ben@bagu.org>
2520 Enable the table selector in the DetailsView.
2522 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2523 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2524 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2525 Remove getDefaultDetailsLayout(). The default layout is now returned
2526 by the getDetailsLayout() method when the table name is an empty
2528 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2529 event handler for table change event. Change to using
2530 getDetailsLayout() for the default details layout.
2531 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2533 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2534 when navigating to the details place.
2536 2011-06-27 Ben Konrath <ben@bagu.org>
2538 Use filename based unique document ID in URL and for RPC.
2540 The document ID is the glom document name with spaces (' ') replaced
2541 with pluses ('+') and without the .glom extension.
2543 This change is mostly a string substitution of 'documentTitle' for
2544 'documentID'. The only code change is the addition of a Documents DTO to get the
2545 filename to document title mappings as indicated below.
2547 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2548 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2549 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2550 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2551 Use Documents DTO to create the document links in the document
2553 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2554 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2555 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2556 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2557 * src/main/java/org/glom/web/client/place/ListPlace.java:
2558 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2559 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2560 * src/main/java/org/glom/web/client/ui/ListView.java:
2561 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2562 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2563 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2564 * src/main/java/org/glom/web/server/Log.java:
2565 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2566 getDocumentTitles() to getDocuments() and return the Documents DTO.
2567 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2568 transferring the filename to document title mappings.
2570 2011-06-25 Ben Konrath <ben@bagu.org>
2572 Make the authentication popup work again.
2574 This bug was introduced when I extracted ConfiguredDocument to its own class.
2576 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2577 correct success / fail status in setUsernameAndPassword().
2579 2011-06-25 Ben Konrath <ben@bagu.org>
2581 Use filename as unique key for configuring database usernames and passwords.
2583 This replaces the use of the Glom document title which could change
2584 depending on the locale. Thanks to Murray Cumming for pointing out this
2587 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2588 * src/main/resources/onlineglom.properties:
2590 2011-06-24 Ben Konrath <ben@bagu.org>
2592 Pass primary key value to DetailsView.
2594 This enables the DetailsView to load the correct data.
2596 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2597 primary key value field and set in constructor. Pass primary key
2598 value to getDetailsData().
2599 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2600 variables for document title and primary key value.
2601 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2602 key value to the DetailsPlace.
2604 2011-06-24 Ben Konrath <ben@bagu.org>
2606 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2608 This allows the primary key to be retrieved by the Details button. This
2609 functionality has not been implemented yet but it's in the works.
2611 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2612 the LayoutGroup result to ListView.setCellTable instead of all of its
2613 fields individually.
2614 * src/main/java/org/glom/web/client/ui/ListView.java:
2615 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2616 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2617 get the primary key for the table.
2618 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2619 index of the primary key in the LayoutGroup accounting for hidden
2620 primary keys. Rename getJavaNumberFormat() to
2621 convertToJavaNumberFormat() for consistency. Cleanup / add some
2623 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2624 field for primary key index and a field to indicate whether the
2625 primary key is hidden or not.
2627 2011-06-23 Ben Konrath <ben@bagu.org>
2629 Rename getTableData methods to getListData.
2631 This is a rename refactor for consistency with other methods.
2633 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2634 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2635 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2636 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2638 2011-06-23 Ben Konrath <ben@bagu.org>
2640 Extract the ConfiguredDocument innerclass into its own class.
2642 This makes the servlet code more object oriented.
2644 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2645 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2646 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2647 new ConfiguredDocument class.
2649 2011-06-21 Ben Konrath <ben@bagu.org>
2651 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2653 This makes things more inline with how libglom works and reduces code
2654 duplication. This refactor lays the groundwork for adding the primary key to
2655 the LayoutGroup object.
2657 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2658 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2660 Change method names to getListLayout and getDefaultListLayout for
2661 consistency. Use LayoutGroup as the DTO for the list layout instead of
2662 ColumnInfo and LayoutListTable.
2663 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2664 new method names along with the LayoutGroup object for transferring the
2666 * src/main/java/org/glom/web/client/ui/ListView.java:
2667 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2668 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2669 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2671 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2672 Replaced with LayoutGroup.
2673 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2674 expectedResultSize and defaultTableName fields which are needed for
2676 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2677 type field which is needed for the list layout but will also be
2678 useful for the details layout as things progress.
2679 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2680 Make class abstract. Remove the unnecessary
2681 getFormattingHorizontalAlignment method. Add setFormatting method.
2683 2011-06-16 Ben Konrath <ben@bagu.org>
2685 Add scripts for building and installing war.
2687 These will help when updating OnlineGlom but they're also good
2688 supplemental documentation of the build and deployment proceeding.
2690 * utils/build-onlineglom-war.sh: New file.
2691 * utils/install-onlineglom-war.sh: New file.
2693 2011-06-16 Ben Konrath <ben@bagu.org>
2695 Create wrapper class to create consistent log messages.
2697 I wrapped methods in the Log class of gwt-log to add the method names
2698 from the servlet and create consistent formatting of the document title
2699 and table names in the log messages.
2701 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2702 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2703 log methods to use methods from wrapped Log class.
2705 2011-06-16 Ben Konrath <ben@bagu.org>
2707 Remove superfluous conditional return.
2709 Thanks to Murray Cumming for pointing this out!
2711 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2713 2011-06-15 Ben Konrath <ben@bagu.org>
2715 Return an ArrayList of LayoutGroups for the Details layout.
2717 This corrects a problem with the details layout as it can have more
2718 than one top level LayoutGroup.
2720 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2721 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2722 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2723 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2724 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2725 with ArrayList of LayoutGroups for the details view layout.
2726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2727 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2728 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2729 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2730 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2731 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2733 2011-06-14 Ben Konrath <ben@bagu.org>
2735 Use cast_dynamic method to determine the libglom LayoutItem type.
2737 This is better than finding the LayoutItem type by using the string
2738 returned from the get_part_type_name() method.
2740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2742 2011-06-14 Ben Konrath <ben@bagu.org>
2744 Add method names to log entries in the servlet.
2746 This helps when tracking down deployment problems.
2748 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2750 2011-06-14 Ben Konrath <ben@bagu.org>
2752 Add data to the DetailsView using a hard-coded primary key value.
2754 The layout and functionality of the DetailsView is not complete. This
2755 is just a checkpoint so the patch doesn't get too big.
2757 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2758 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2759 Add getDetailsData() servlet method.
2760 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2761 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2762 LayoutFields are added to the DetailsView.
2763 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2764 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2765 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2766 take the string for the title instead of the object.
2767 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2768 Add implementation getDetailsData() along with some private helper
2770 * src/main/webapp/style.css: Add padding to details-data class. Add a
2771 details-label class with the same padding as the details-data class.
2773 2011-06-03 Ben Konrath <ben@bagu.org>
2775 Use presenter.goTo() to change to the DetailsPlace.
2777 This will make things easier when we need to open the DetailsView with
2778 data specific to the row that was clicked.
2780 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2782 2011-06-02 Ben Konrath <ben@bagu.org>
2784 Add CSS file from mockups.
2786 I'm adding this now because it's going to be useful to have when
2787 developing the DetailsView. The TableSelectionView and ListView aren't
2790 * src/main/webapp/OnlineGlom.html:
2791 * src/main/webapp/style.css:
2793 2011-06-02 Ben Konrath <ben@bagu.org>
2795 Use String.isEmpty() to check for empty string.
2797 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2799 2011-06-02 Ben Konrath <ben@bagu.org>
2801 Display main layout group titles in the DetailsView.
2803 This is the start of the DetailsActivity/DetailsView implementation.
2805 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2806 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2807 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2808 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2809 Get the layout information for the details view from the server and set
2810 the main layout group titles.
2811 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2812 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2813 Add addLayoutGroup() and addLayoutField() methods. This are just
2814 temporary methods for creating the the details view that will change
2816 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2817 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2819 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2820 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2821 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2822 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2823 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2824 Data Transfer Objects that mimic the libglom object structure. These are
2825 used for transferring the details layout but could also be used for
2826 transferring the list layout.
2828 2011-05-27 Ben Konrath <ben@bagu.org>
2830 Reset the AuthenticationPopup when clearing the ListView.
2832 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2834 2011-05-27 Ben Konrath <ben@bagu.org>
2836 Fix problem with onlineglom.properties file loading.
2838 The old way worked in Eclipse but not on the server. Loading the
2839 onlineglom.properties file now works in Eclipse and on the server.
2841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2843 2011-05-24 Ben Konrath <ben@bagu.org>
2845 Update gwt-log from 3.1.0 to 3.1.2.
2847 Gwt-log 3.1.0 has been marked as depreciated.
2851 2011-05-24 Ben Konrath <ben@bagu.org>
2853 Add comment to ListActivity.goTo() method.
2855 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2857 2011-05-24 Ben Konrath <ben@bagu.org>
2859 Remove FIXME in convertGdkColorToHtmlColour()
2861 The Gdk::Color value returned by libglom is 16-bits per channel on both
2862 64 and 32-bit platforms.
2864 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2866 2011-05-19 Ben Konrath <ben@bagu.org>
2868 Improve performance of initial ListView load.
2870 I removed a round trip to the server for getting the default table name
2871 and then requesting information about that table. This also removes a potential
2872 problem with the table change handler not being setup in time to receive the
2873 table change event from the ListActivity.
2875 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2876 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2877 getDefaultLayoutListTable() method. Improve comments.
2878 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2879 getDefaultLayoutListTable() method instead of firing a table change
2880 event to get the table to load.
2881 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2882 implementation of getDefaultLayoutListTable() method.
2883 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2886 2011-05-19 Ben Konrath <ben@bagu.org>
2888 Override toDebugString() in TableChangeEvent.
2890 This is useful to have for debugging.
2892 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2894 2011-05-19 Ben Konrath <ben@bagu.org>
2896 Add a "Back to List" link when at the DetailsPlace.
2898 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2899 Populate the CellTable based on the selected table of the ListBox if
2900 it's set otherwise use the default table. This allows the "Back to
2902 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2903 Remove Place from constructors. Add a setPlace() method. Add
2904 goToPlace() method. Set class as presenter for TableSelectionView.
2905 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2906 Use the same TableSelectionActivity when switching between the List and
2908 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2909 Subclass the new HasSelectableTablePlace. This removes some duplicate
2911 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2912 New class to represent Places that display the TableSelectionView.
2913 * src/main/java/org/glom/web/client/place/ListPlace.java:
2914 Subclass the new HasSelectableTablePlace. This removes some duplicate
2916 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2917 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2918 Add Presenter interface. Add setBackLinkVisible() method. Add
2919 setBackLink() method.
2921 2011-05-18 Ben Konrath <ben@bagu.org>
2923 Enable the "Details" buttons.
2925 Right now only an empty details view is displayed.
2927 * src/main/java/org/glom/web/client/ClientFactory.java:
2928 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2929 Add DetailsView to ClientFactory.
2930 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2931 A basic activity for the details view.
2932 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2933 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2935 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2936 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2938 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2939 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2940 unnecessary super() in constructor.
2941 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2942 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2943 really shouldn't create a new TableSelectionActivity for both the ListPlace
2944 and the DetailsPlace so this should be considered a temporary solution.
2945 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2946 New file. Represents a URL for the details view.
2947 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2948 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2949 A basic details view interface and implementation.
2950 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2951 Enable the "Details" buttons.
2953 2011-05-12 Ben Konrath <ben@bagu.org>
2955 Use a LayoutPanel with multiple display areas for main layout.
2957 This is mostly a refactor in that there are no changes from the user
2958 point of view. These changes are required so that we can swap out the list view
2959 with the details view when the user clicks the "Details" button.
2961 * src/main/java/org/glom/web/client/ClientFactory.java:
2962 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2963 OnlineGlomView. Add TableSelectionView, ListView and
2964 AuthenticationPopup.
2965 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2966 for main layout. Add display regions for main activities. Add
2967 activity manager for for main activities.
2968 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2969 file from parts of the deleted OnlineGlomActivity.
2970 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2971 New file from parts of the deleted OnlineGlomActivity.
2972 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2973 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2974 New files for app wide table change event.
2975 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2976 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2977 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2978 Activity mappers for the main activities replace the deleted app-wide
2980 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2981 Fix a spelling error in he comment.
2982 * src/main/java/org/glom/web/client/ui/ListView.java:
2983 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2984 Renamed from LayoutListView and modified for MVP. This still not a
2985 proper dumb view as prescribed by the MVP pattern but it works for now.
2986 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2987 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2988 New widget stripped out of the deleted OnlineGlomView.
2989 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2990 Remove hack that is fixed by this patch.
2992 2011-05-06 Ben Konrath <ben@bagu.org>
2994 Rename OnlineGlomPlace to ListPlace.
2996 The only change besides the rename is that url will now display #list
2997 instead of #Document.
2999 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3000 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3001 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3002 * src/main/java/org/glom/web/client/place/ListPlace.java:
3003 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3005 2011-05-06 Ben Konrath <ben@bagu.org>
3007 Use Presenter for app navigation.
3009 This is the proper way to deal with Place (URL) changes with the MVP
3012 * src/main/java/org/glom/web/client/ClientFactory.java:
3013 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
3014 PlaceHistoryMapper and PlaceHistoryHandler.
3015 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
3016 PlaceHistoryMapper and PlaceHistoryHandler.
3017 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3018 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
3019 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3020 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3021 Add Presenter interface and setPresenter methods. Rename addHyperLink
3022 to addDocumentLink taking only the document title as a parameter.
3024 2011-04-14 Ben Konrath <ben@bagu.org>
3026 Prompt for db username/password if they haven't been set.
3028 This is implemented with a popup widget that is contained within the
3029 OnlineGlomView and managed by the OnlineGlomActivity.
3031 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
3032 methods for checking and setting the database username and password.
3033 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
3034 new methods for checking and setting the database username and
3036 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3037 Display authentication popup if the JDBC connection to the database
3038 has not been authenticated.
3039 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
3041 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3042 for dealing with the authentication popup.
3043 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
3044 Implement the methods for dealing with the authentication popup.
3045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
3046 try to executed queries if the database connection hasn't been
3047 authenticated. Implement methods for checking and setting the
3048 database username and password.
3050 2011-04-12 Ben Konrath <ben@bagu.org>
3052 Make log messages a little clearer.
3054 Add a dash betweeen the document title and the table name.
3056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3058 2011-04-12 Ben Konrath <ben@bagu.org>
3060 Protect against NPEs when cleaning up database resources.
3062 While this isn't strictly necessary because the exception is caught,
3063 not protecting against the NPEs makes it harder to find the real error
3066 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3068 2011-04-12 Ben Konrath <ben@bagu.org>
3070 Move configuration of the servlet to the constructor.
3072 The servlet will be initialized even if the database authentication
3073 information is not set or correct. I still need to add the UI for prompting
3074 the user for the authentication information when it's required.
3076 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3077 javadocs for getDocumentTitles() method.
3078 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3079 Set error message when RPC fails.
3080 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
3081 glom files directory from the configuration file. Try to set the
3082 database authentication information for the specific document if it's
3083 set and works otherwise try to use the global authentication
3084 information set for the directory.
3085 * src/main/resources/onlineglom.properties: Moved from
3086 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
3087 Added detailed comments for the new keys.
3089 2011-04-11 Ben Konrath <ben@bagu.org>
3091 Remove unnecessary @Override in DocumentSelectionViewImpl.
3093 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3095 2011-04-11 Ben Konrath <ben@bagu.org>
3097 Remove center alignment in DocumentSelectionView.
3099 The title element is still centred but the document titles and bottom
3100 sentence are both left-aligned.
3102 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3104 2011-04-11 Ben Konrath <ben@bagu.org>
3106 Change 'Demo' naming convention to 'Document'.
3108 This is just a rename refactor with no functional changes to the code.
3110 * src/main/java/org/glom/web/client/ClientFactory.java:
3111 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3112 * src/main/java/org/glom/web/client/OnlineGlom.java:
3113 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3114 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3115 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3116 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
3117 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3118 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3119 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3120 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3121 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3122 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3124 2011-04-08 Ben Konrath <ben@bagu.org>
3126 Remove FIXME from safeLongToInt() method.
3128 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3133 2011-04-08 Ben Konrath <ben@bagu.org>
3135 Display an error if no glom documents are found in the specified directory.
3137 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3138 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3139 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3140 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3142 2011-04-08 Ben Konrath <ben@bagu.org>
3144 Add copyright header to one more file ... oops.
3146 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3148 2011-04-08 Ben Konrath <ben@bagu.org>
3150 Add copyright header to files without it.
3152 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3153 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3154 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3155 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3156 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3157 * src/main/java/org/glom/web/shared/GlomField.java:
3159 2011-04-08 Ben Konrath <ben@bagu.org>
3161 Add support for accessing multiple glom documents in the servlet.
3163 This completes the demo selection functionality.
3165 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3166 document title to methods.
3167 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3168 document title to methods.
3169 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3170 Set browser window title when the activity starts. Correct name of
3171 document title variable.
3172 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3173 Set browser window title when the activity starts. Set the table
3174 selector change handler after table selector has been set. Clear the
3175 OnlineGlomView when the activity has been stopped.
3176 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3177 document title as the place token. Use "#Document:" instead of
3178 "#OnlineGlomPlace:" in the URL.
3179 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3180 Change heading to "Online Glom"
3181 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3182 document title in RPC methods.
3183 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3184 setDocumentTitle() method. Add clear() method.
3185 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3186 setDocumentTitle() method. Implement clear() method which removes the
3187 change handler on the ListBox, clears the ListBox and clears the
3189 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3190 Implement methods with document title. Keep track for the configured
3191 glom documents and their corresponding JDBC configurations in a hash
3192 table. This information is retrieved using the document title as the
3193 key in the hash table.
3194 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3195 document title field as it's no longer needed.
3197 2011-04-08 Ben Konrath <ben@bagu.org>
3199 Update the Eclipse JDT configuration.
3201 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3202 methods. Automatically add the copyright header to new files.
3204 2011-04-05 Ben Konrath <ben@bagu.org>
3206 Add new page for demo selection.
3208 This patch adds all the components required to view and start an
3209 OnlineGlom demo by clicking on the desired hyperlink. The user is
3210 able to return to the demo selection page with the browser's back
3211 button. I still need to modify the servlet to work with multiple
3212 documents so all demo links will load the file defined in the
3213 OnlineGlom.properties.
3215 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3216 This is only useful during development so we don't need to save it.
3217 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3218 get a reference to the DemoSelectionView.
3219 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3220 method to get a reference to the DemoSelectionView.
3221 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3222 default view to DemoSelectionView.
3223 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3224 to get glom document titles for glom files in a hard-coded directory.
3225 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3226 method to get glom document titles for glom files in a hard-coded
3228 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java: