1 2012-04-18 Murray Cumming <murrayc@murrayc.com>
3 ReportGenerator: Avoid showing null for group by titles.
5 * src/main/java/org/glom/web/server/ReportGenerator.java
6 generateReport(): Use setBlankWhenNull() on the field title
7 style too, because this is used for values in group by
10 2012-04-18 Murray Cumming <murrayc@murrayc.com>
12 ReportGenerator: Add a colon to titles in vertical groups.
14 * src/main/java/org/glom/web/server/ReportGenerator.java
15 addFieldToDetailBandVertical(): Pass true for the withColon
18 2012-04-18 Murray Cumming <murrayc@murrayc.com>
20 ReportGenerator: Simplify the code by using Position more.
22 2012-04-18 Murray Cumming <murrayc@murrayc.com>
24 Reports: Support vertical groups, roughly.
26 * src/main/java/org/glom/web/server/ReportGenerator.java:
27 addToReport(): Rename to addGroupToReport() and, if necessary,
28 call the new addVerticalGroupToReport() method.
29 createFieldValueElement(): Let the caller specify the Y position
32 2012-04-17 Murray Cumming <murrayc@murrayc.com>
34 Reports: Allow a second report to be shown.
36 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
37 clear(): Do not remove the HTML widget, which broke the whole layout.
39 2012-04-17 Murray Cumming <murrayc@murrayc.com>
41 Locales drop-down: Show that we use English by default.
43 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
44 fillView(): When we use English, just because that is the default, when
45 no locale is specified, show that in the Locales drop-down instead of
46 just showing the first item.
48 2012-04-17 Murray Cumming <murrayc@murrayc.com>
50 Unselect the Report/Locale/Table combo item when appropriate.
52 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
53 setPlace(): clear reportName if this is not a ReportPlace.
54 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
55 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
56 When the provided name is empty, unselect all items, so that none are
57 indicated. This uses a for loop because I cannot find a single method
60 2012-04-17 Murray Cumming <murrayc@murrayc.com>
62 Report: Give the user a way to get back to the list.
64 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
65 start(), setPlace(): Show the Back To List link on reports, and also
66 interpret selecting the empty report item as back to list.
68 2012-04-17 Murray Cumming <murrayc@murrayc.com>
70 Style: Remove overflow:hidden from searchbox
72 * src/main/webapp/style.css: Because this pushes the Back To Link
73 label/link on to the next row, which is then hidden due to the
74 hard-coded (in ems) height.
76 2012-04-13 Murray Cumming <murrayc@murrayc.com>
78 Really show the selected Report name.
80 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
81 setPlace(): Store the reportName here, if it is that kind of Place.
82 fillView(): Set the selected Report after filling the list of reports.
83 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
84 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
85 null Strings, though we need some way to unselect all ListBox items
88 2012-04-13 Murray Cumming <murrayc@murrayc.com>
90 ReportGenerator: Try to avoid some problems.
92 * src/main/java/org/glom/web/server/ReportGenerator.java
93 addField(): Try to avoid duplicates, and avoid using a null
96 2012-04-13 Murray Cumming <murrayc@murrayc.com>
98 Reports: Use quickFind.
100 * src/main/java/org/glom/web/client/OnlineGlomService.java;
101 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
102 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
103 getReportHTML(): Add a quickFind parameter.
104 * src/main/java/org/glom/web/client/activity/ReportActivity.java
105 start(): Pass the quickFind parameter.
106 * src/main/java/org/glom/web/server/ReportGenerator.java
107 generateReport(): Take a quickFind parameter.
109 2012-04-13 Murray Cumming <murrayc@murrayc.com>
111 ReportPlace: Actually use the report name.
113 * src/main/java/org/glom/web/client/place/ReportPlace.java
114 getPlace(): Do not assign the report name to the quickfind.
116 2012-04-13 Murray Cumming <murrayc@murrayc.com>
118 Show java.library.path when complaining.
120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
121 init(): When telling us to check java.library.path, show the
124 2012-04-12 Murray Cumming <murrayc@murrayc.com>
126 Adapt to the java-libglom 1.21.8 API.
128 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
129 java-libglom's FieldFormatting is now Formatting.
131 2012-04-12 Murray Cumming <murrayc@murrayc.com>
133 Use the latest java-libglom version.
135 * pom.xml: Use java-libglom 1.21.8.
137 2012-03-15 Murray Cumming <murrayc@murrayc.com>
139 Adapt to the java-libglom 1.21.7 API.
141 * src/main/java/org/glom/web/server/ReportGenerator.java:
142 addToReport(): get_group_secondary_fields() is now
143 get_secondary_fields().
145 2012-03-15 Murray Cumming <murrayc@murrayc.com>
147 Use the latest java-libglom version.
149 * pom.xml: Use java-libglom 1.21.7.
151 2012-03-06 Murray Cumming <murrayc@murrayc.com>
153 ReportGenerator: Do not show nulls.
155 2012-03-06 Murray Cumming <murrayc@murrayc.com>
157 ReportGenerator: Make the title font larger.
159 2012-03-06 Murray Cumming <murrayc@murrayc.com>
161 ReportGenerator: Put field titles inside groups, if there are groups.
163 2012-03-06 Murray Cumming <murrayc@murrayc.com>
165 ReportGenerator: Take the Report itself instead of the name and group.
167 * src/main/java/org/glom/web/server/ConfiguredDocument.java
168 Remove getReportLayoutGroup().
169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
170 getReportHTML(): Pass the report instead
171 of its name and layout group.
172 * src/main/java/org/glom/web/server/ReportGenerator.java
173 generateReport(): Use the report object to use the title
176 2012-03-06 Murray Cumming <murrayc@murrayc.com>
178 ReportGenerator: Remove designBand parameters.
180 * src/main/java/org/glom/web/server/ReportGenerator.java:
181 Make designBand a class member instead of passing it to all
184 2012-03-06 Murray Cumming <murrayc@murrayc.com>
186 ReportGenerator: Add lines, a bit like in the desktop version.
188 * src/main/java/org/glom/web/server/ReportGenerator.java
189 addToReport(): Use JRDesignLine.
191 2012-03-06 Murray Cumming <murrayc@murrayc.com>
193 ReportGenerator: Correct the title positions and use some bold style.
195 * src/main/java/org/glom/web/server/ReportGenerator.java:
196 Break the code up into reusable functions, correct the placement of
197 titles, and use normal/bold styles as in the reports in the desktop
200 2012-03-06 Murray Cumming <murrayc@murrayc.com>
202 ReportGenerator: Add a header band to show the field titles.
204 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
205 getReportHTML(): Pass the localeId to the ReportGenerator
207 * src/main/java/org/glom/web/server/ReportGenerator.java
208 constructor: Take the localeID so we can get translated field
210 generateReport(), addToReport(), addFieldToBand(): Add field
211 titles in a column header band.
213 2012-03-05 Murray Cumming <murrayc@murrayc.com>
215 Reports drop-down list: Some improvement.
217 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
218 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
219 Adedd setSelectedReport(),
220 setReportList(): Add a blank line so that the user can select the
222 * src/main/java/org/glom/web/client/activity/ReportActivity.java
223 start(): Show the current report by calling setSelectedReport().
224 This does not seem to work yet.
226 2012-03-05 Murray Cumming <murrayc@murrayc.com>
228 DetailsActivity, ListActivity: Move some variables into a base class.
230 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
231 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
232 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
233 the clientFactory, documentID, tableName and authenticationPopup into
234 a base class, to avoid duplication.
236 2012-03-05 Murray Cumming <murrayc@murrayc.com>
238 Translate the Reports label.
240 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
241 Get the "Reports" label string from the constants.
242 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
243 perties: Add Reports to the constants.
245 2012-03-03 Ben Konrath <ben@bagu.org>
247 Display date and time in details view.
249 https://bugzilla.gnome.org/show_bug.cgi?id=671257
251 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
253 2012-03-05 Murray Cumming <murrayc@murrayc.com>
255 Require the latest java-libglom.
257 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
259 2012-03-05 Murray Cumming <murrayc@murrayc.com>
261 Reports: Implement grouping.
263 * src/main/java/org/glom/web/server/ReportGenerator.java:
264 Handle LayoutItem_GroupBy items and try to do the right thing
265 with JRDesignGroup. It seems to work.
267 2012-03-04 Murray Cumming <murrayc@murrayc.com>
269 Actually show some data with JasperReports.
271 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
272 getReportHTML(): Move most code into a ReportGenerator class.
273 * src/main/java/org/glom/web/server/ReportGenerator.java:
274 Recurse into sub-groups, adding fields to the JasperDesign's details
275 band. Note that we must set an arbitrary width and height, or it just
276 will not show any data.
278 2012-03-04 Murray Cumming <murrayc@murrayc.com>
280 Reports Chooser: Show the titles, not the names.
282 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
283 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
284 and the names as the values.
285 * src/main/java/org/glom/web/server/ConfiguredDocument.java
286 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
287 group now that we provide the report name, so it should always
290 2012-03-04 Murray Cumming <murrayc@murrayc.com>
292 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
294 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
295 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
296 an empty quickfind string. I also corrected libglom to create only
297 empty where clauses for empty quickfind strings, but this avoids the
300 2012-02-24 Ben Konrath <ben@bagu.org>
302 Improve the tabs in the Notebook widget.
306 2012-02-15 Murray Cumming <murrayc@murrayc.com>
308 Depend on jasperreports.
310 * pom.xml: Add the dependency. My plan is to use this on the
313 2012-01-31 Murray Cumming <murrayc@murrayc.com>
315 Implement navigation to report places.
317 * src/main/java/org/glom/web/client/activity/ReportActivity.java
318 start(): Do not bother to handle all events here.
319 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
320 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
321 Added getSelectedReport().
322 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
323 .java: start(): When handling a change to the reports chooser,
324 call getSelectedReport() and goTo() its ReportPlace.
325 * src/main/java/org/glom/web/client/ui/ReportView.java
326 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
327 Added setReportHTML() which puts the html in a gwt HTML widget.
328 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
329 getReportHTML(): Return "TODO" just to show that this works.
331 2012-01-31 Murray Cumming <murrayc@murrayc.com>
333 Make ReportPlace usable.
335 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
337 * src/main/java/org/glom/web/client/place/ReportPlace.java:
338 Correct the @prefix annotation.
340 2012-01-31 Murray Cumming <murrayc@murrayc.com>
342 OnlineGlomService: Return report HTML rather than the LayoutGroup.
344 * src/main/java/org/glom/web/client/OnlineGlomService.java:
345 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
346 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
347 Change getReportLayout() to getReportHMTL() because we will not need to
348 parse or render the report layout on the client side.
349 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
350 getReportLayout(): Return the libglom LayoutGroup type because we will
351 not need to convert to a shared type, because this will not be used on
353 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
356 Note that there is still no implementation for this.
358 2012-01-30 Murray Cumming <murrayc@murrayc.com>
360 Translations: Try to translate the strings.
362 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
363 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
364 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
365 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
366 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
367 Take the Open translation from GTK+'s .po files.
368 Take the Details translation from Glom's po files.
369 I have added the other strings to Glom so we can get translations that way:
370 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
372 2012-01-27 Murray Cumming <murrayc@murrayc.com>
374 Add a (empty) Report Place, View, and Activity.
376 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
378 * src/main/java/org/glom/web/client/place/HasTablePlace.java
379 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
380 this into a superclass:
381 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
382 and also use it as the base of this new ReportPlace:
383 * src/main/java/org/glom/web/client/place/ReportPlace.java
385 * src/main/java/org/glom/web/client/ui/ReportView.java
386 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
387 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
388 Add these, containing mostly boiler-plate for now.
390 * src/main/java/org/glom/web/client/OnlineGlomService.java
391 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
392 * src/main/java/org/glom/web/server/ConfiguredDocument.java
393 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
394 Add API to get the LayoutGroup for the report.
396 2012-01-27 Murray Cumming <murrayc@murrayc.com>
398 TableSelectionViewImpl: Put the search label and entry in a div.
400 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
401 Put the search widgets in a FlowTable so that the CSS can be used to
402 style them while keeping them together.
403 * src/main/webapp/style.css: Mention the new div.
405 2012-01-27 Murray Cumming <murrayc@murrayc.com>
407 Translate more strings in more locales.
409 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
410 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
411 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
412 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
413 Translate the "Details" and "Open" string too.
415 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
416 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
417 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
418 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
419 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
420 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
421 Add these new locales as placeholders though they currently contain English.
423 2012-01-27 Murray Cumming <murrayc@murrayc.com>
425 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
427 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
428 Check the ConfiguredDocument* for null before using it.
430 2012-01-26 Murray Cumming <murrayc@murrayc.com>
432 Tell Eclipse about the generated java files.
434 * .classpath: This lets it find OnlineGlomConstants.java.
435 It would be nice if Eclipse just used the maven build files.
437 2012-01-26 Murray Cumming <murrayc@murrayc.com>
439 Prevent a crash when no locale is specified in the URL.
441 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
442 Avoid returning a null string, obtained from
443 Window.Location.getParameter(). This caused a crash when it was
444 later passed to libglom's API.
445 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
446 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
447 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
448 guard against future null strings.
450 2012-01-26 Murray Cumming <murrayc@murrayc.com>
452 Use the ?locale= query param instead of the &lang= token param.
454 * src/main/java/org/glom/web/client/place/ListPlace.java
455 * src/main/java/org/glom/web/client/place/DetailsPlace.java
456 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
457 Remove the lang token key and value.
459 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
460 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
461 When the user selects a different locale from the chooser, use
462 Window.Location.assign() to change the URL, which then causes a reload.
464 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
465 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
466 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
467 * src/main/java/org/glom/web/client/activity/ListActivity.java
468 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
469 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
470 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
471 * src/main/java/org/glom/web/client/ui/ListView.java:
472 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
474 Remove localeID member variables and method/constructor parameters, instead
475 using Utils.getCurrentLocaleID() when we need a localID to pass to
478 2012-01-26 Murray Cumming <murrayc@murrayc.com>
480 Internationalize the UI strings.
482 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
483 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
484 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
485 because it is unused. Messages are apparently strings that can have
486 parameters, but we do not need that yet, so Contants will be enough for now.
487 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
488 to say that we support the en and de locales.
489 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
490 The original English strings.
491 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
492 Some German translations of the English strings.
493 The i18n goal then uses the .properties file to generate an
494 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
495 returns an implementation that returns the translated strings.
496 The documentation suggests putting these in src/java/*/client/, but it seems
497 best to put it in src/resources/*/client/.
498 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
499 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
500 instead of hard-coding them.
501 Note that we cannot import OnlineGlomConstants because it does not exist yet,
502 but that does not seem to stop the build, though it confuses Eclipse.
504 You can see the translated string by adding ?locale=de to the URL, like so:
505 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
507 2012-01-24 Murray Cumming <murrayc@murrayc.com>
509 Improve null/empty String checks.
511 * pom.xml: Add a dependency on commons-lang, to use
512 org.apache.commons.lang.StringUtils.
513 * src/main/java/org/glom/web/server/ConfiguredDocument.java
514 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
515 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
516 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
517 Use StringUtils.isEmpty().
519 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
520 StringUtils class with a static isEmpty() function because we
521 cannot use org.apache.commons.lang.StringUtils in client-side
522 GWT code because it (apparently) cannot be compiled to javascript.
523 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
524 * src/main/java/org/glom/web/client/activity/ListActivity.java
525 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
526 * src/main/java/org/glom/web/client/place/DetailsPlace.java
527 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
528 * src/main/java/org/glom/web/client/place/ListPlace.java
529 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
530 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
531 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
532 * src/main/java/org/glom/web/client/ui/details/Group.java
533 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
534 our StringUtils.isEmpty() function.
536 2012-01-24 Murray Cumming <murrayc@murrayc.com>
538 Update to the latest java-libglom API.
540 * pom.xml: Require java-libglom 1.21.4.
541 * src/main/java/org/glom/web/server/ConfiguredDocument.java
542 getDocumentInfo(), getListViewLayoutGroup():
543 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
545 * src/main/java/org/glom/web/server/database/DBAccess.java
546 getFieldsToShowForSQLQueryAddGroup(),
547 getPrimaryKeyLayoutItemField(): Replace get_database_title()
548 with either get_database_title_original() or
549 get_database_title(localeID).
551 2012-01-24 Murray Cumming <murrayc@murrayc.com>
553 ConfiguredDocument: Avoid a null pointer exception.
555 * src/main/java/org/glom/web/server/ConfiguredDocument.java
556 Initialize localeID to "" to avoid returning a null String which
557 causes a crash in java-libglom's swing-generated code.
559 2012-01-23 Murray Cumming <murrayc@murrayc.com>
561 Some simple renaming.
563 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
564 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
565 for localeChooser. This seems more appropriate and is less ambiguous
566 particularly in the .css file.
568 2012-01-23 Murray Cumming <murrayc@murrayc.com>
570 ConfiguredDocument: Rename the localedID private member variable.
572 2012-01-23 Murray Cumming <murrayc@murrayc.com>
574 Adapt to the latest java-libglom API from git master.
576 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
577 libglom now uses only Vector instead of List, which uses add() instead of
580 2012-01-23 Murray Cumming <murrayc@murrayc.com>
582 Add and fill a Reports drop-down list box.
584 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
586 * src/main/java/org/glom/web/client/OnlineGlomService.java:
587 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
588 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
589 Added getReports(document, table, localeID), calling
590 ConfiguredDocument.getReports().
591 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
592 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
593 Added setReportsList() and a list widget.
594 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
595 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
597 2012-01-22 Murray Cumming <murrayc@murrayc.com>
599 ConfiguredDocument: Rename the localedID private member variable.
601 2012-01-20 Murray Cumming <murrayc@murrayc.com>
603 Build a source tarball with mvn assembly:single
605 * assembly.xml: Add this file.
606 * pom.xml: Use the maven-assembly-plugin and tell it to use
607 our assembly.xml file.
609 2012-01-19 Murray Cumming <murrayc@murrayc.com>
611 OnlineGlomServiceImpl: Get .glom files recursively.
613 * pom.xml: Depend on commons-io from org.apache.commons.
614 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
615 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
616 files recursively, and with the easier filter for the extension.
617 Use org.apache.commons.io.FilenameUtils.removeExtension() to
618 simplify that code too.
620 2012-01-19 Murray Cumming <murrayc@murrayc.com>
622 README: Mention that you must install java-libglom packages separately.
624 But then it works, because java-libglom is now in the central maven
627 2012-01-18 Murray Cumming <murrayc@murrayc.com>
629 locales drop-down: Show the correct selected locale when the URL changes.
631 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
632 .java: setPlace(): Move some code into fillView().
634 2012-01-18 Murray Cumming <murrayc@murrayc.com>
636 locales drop-down: Do not lose the primary key.
638 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
639 start(): onLocaleChange(): Pass the current primary key value,
640 instead of an empty value.
642 2012-01-18 Murray Cumming <murrayc@murrayc.com>
644 locales drop-down: Do not lose the drop-down selection.
646 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
647 .java (TableSelectionActivity.fillView): Set the selected locale
648 after changing the drop-down items (though we do not really need
649 to change them just because the locale changes.)
651 2012-01-18 Murray Cumming <murrayc@murrayc.com>
653 locales drop-down: Change the tables list when this changes.
655 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
656 .java: TableSelectionActivity.start(): Move the async table titles
657 retrieval into a private fillView() method and also call this when
658 the chosen locale changes.
659 Note that the document title is not actually translatable yet, but
660 that is a problem that I should fix soon in libglom.
662 2012-01-18 Murray Cumming <murrayc@murrayc.com>
664 Improve the placement of the locales drop-down.
666 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
667 Put the title and locales drop-down in a div (gwt.FlowTable).
668 * src/main/webapp/style.css: Add magic css properties to make this work.
669 Also remove the left margin from the title so that it lines up with the
672 2012-01-18 Murray Cumming <murrayc@murrayc.com>
674 locales selector: Show human-readable locale titles.
676 * src/main/java/org/glom/web/server/ConfiguredDocument.java
677 getDocumentInfo(): Use java.util.Locale to show a real title of
678 each locale, in the locale's own language.
680 2012-01-17 Murray Cumming <murrayc@murrayc.com>
682 Add a language/locale selector drop-down.
684 * src/main/java/org/glom/web/shared/DocumentInfo.java:
685 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
686 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
687 getDocumentInfo(): Store the available Locales in the DocumentInfo.
688 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
689 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
690 Add a ListBox to show the available locales. Add getLocaleSelector(),
691 setLocaleList(), getSelectedLocale(), setSelectedLocale().
692 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
693 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
694 java: Add these classes.
695 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
696 start(): Fill the locales ListBox. Handle its change event, firing a
698 setPlace(): Show the selected locale as specified by the URL token.
699 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
700 * src/main/java/org/glom/web/client/activity/ListActivity.java:
701 Handle LocaleChangeEvent, going to a new *Place with that locale.
703 The placement of the ListBox is not pretty, and it currently uses the ID
704 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
708 2012-01-17 Murray Cumming <murrayc@murrayc.com>
710 Search box: Show the search text from the URL token.
712 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
713 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
714 Add setQuickFindText().
715 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
716 .java: setPlace(): Store the queryText if the place is a ListPlace,
717 and call TableSelectionView.setQuickFindText().
719 2012-01-17 Murray Cumming <murrayc@murrayc.com>
721 Allow use of translations via, for instance, &lang=de in the URL.
723 * pom.xml: Use the unstable java-libglom 1.21 version.
725 * src/main/java/org/glom/web/client/OnlineGlomService.java:
726 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
727 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
728 init(): Instead of calling TranslatableItem.set_current_locale()
729 (now removed), call ConfiguredDocument.setDefaultLocaleID().
730 However, this is only for default locales, which are not needed to
731 change the locale in the URL.
732 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
733 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
734 getSortedRelatedListData(): Add a localeID parameter, so we can get the
735 layout for a particular locale.
736 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
737 Add get/setDefaultLocaleID().
738 getDocumentInfo(), getListViewData(), getRelatedListData(),
739 getDetailsLayoutGroup(), getListViewLayoutGroup(),
740 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
741 localeID parameter, so we can get the layout for a particular locale.
743 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
744 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
745 * src/main/java/org/glom/web/client/place/ListPlace.java:
746 Parse and construct a lang parameter too.
748 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
749 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
750 passed to subsequent methods and constructors.
751 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
752 * src/main/java/org/glom/web/client/activity/ListActivity.java:
753 Store the localeID from the *Place and pass it to other constructors
754 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
756 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
757 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
758 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
759 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
760 * src/main/java/org/glom/web/client/ui/ListView.java:
761 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
762 Take localeID parameters and pass them to subsequent constructors and
763 methods, so that the layout is always retrieved for that locale.
765 This is rather repetitive.
767 Note that "" means the original (default) locale of the Glom document,
768 which is usually English.
770 2012-01-17 Murray Cumming <murrayc@murrayc.com>
772 Documents: Remove final keyword to fix startup configuration.
774 * src/main/java/org/glom/web/shared/Documents.java: Remove the
775 final keywords on the private member variables because that breaks
776 the startup, apparently (there are warnings) because it stops them
777 from being serialized. I added these in the previous commit.
779 2012-01-13 Murray Cumming <murrayc@murrayc.com>
781 Documents: Add some final keywords.
783 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
786 2012-01-13 Murray Cumming <murrayc@murrayc.com>
788 OnlineGlomServiceImpl: Add to overview comments.
790 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
791 Note that this is where all the document are loaded. They are not
792 loaded freshly for each page.
794 2012-01-12 Murray Cumming <murrayc@murrayc.com>
798 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
799 Add a TextBox for the text of a quick find.
800 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
802 setBackLink(): Add a String quickFind parameter.
803 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
804 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
805 to the base interface, because that is how TableSelectionViewImpl is used.
806 * src/main/webapp/style.css: Add style for the search box and its label.
808 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
809 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
810 Add these files, based on the existing TableChangeEvent and
811 TableChangeEventHandlers.
812 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
813 start(): Handle QuickFindChangeEvent, passing its quickFind text to
814 a ListPlace() that the user should be taken to.
815 * src/main/java/org/glom/web/client/activity/ListActivity.java
816 start(): Handle it here too and adapt the TableChangeEvent handler to
817 pass the extra "" quickFind parameter to ListPlace.
818 * src/main/java/org/glom/web/client/place/ListPlace.java:
819 Constructor: Take an extra String quickFind parameter and store it,
820 returning it from a new getQuickFind() method.
821 getToken(): Put the quickFind text in the URL token.
822 getPlace(): Parse the quickFind text from the URL token.
823 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
824 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
825 ListPlace constructor.
826 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
827 .java: start(): Add a Change handler for the TableSelectionView's
828 TextBox (via its base HasChangeHandlers interface), firing the new
829 QuickFindChangeEvent.
830 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
831 pass the extra "" quickFind parameter.
833 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
834 setCellTable(): Add a String quickFind parameter and pass it to
835 the ListViewTable() constructor.
836 * src/main/java/org/glom/web/client/ui/ListView.java: Change
837 setCellTable() in the base interface, because that is how ListViewImpl
840 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
841 Add a String quickFind member variable.
842 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
843 Constructor: Add a String quickFind parameter, storing it in the
844 base ListTable's member variable.
845 onRangeChanged(): Pass quickFind to the
846 OnlineGlomServiceAsync.getSortedListViewData() and
847 OnlineGlomServiceAsync.getListViewData() methods.
849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
850 getListViewData(), getSortedListViewData(): Add a String quickFind
851 parameter, passing it to ConfiguredDocument.getListViewData().
852 * src/main/java/org/glom/web/client/OnlineGlomService.java:
853 Change getListViewData(), getSortedListViewData() in the base interface,
854 because that is how OnlineGlomServiceImpl is used, via this:
855 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
856 Change getListViewData(), getSortedListViewData() here too.
857 This class can apparently be used to asynchronously call methods on
858 OnlineGlomService, and GWT seems to implement that after recognizing
859 just the *Async name convention and the extra AsyncCallback parameters.
861 * src/main/java/org/glom/web/server/ConfiguredDocument.java
862 getListViewData(): Add a String quickFind parameter, and pass it to
863 ListViewDBAccess.getData().
864 * src/main/java/org/glom/web/server/database/ListDBAccess.java
865 getListData(): Add a String quickFind parameter and pass it to
867 getSelectQuery(): Add a String quickFind parameter.
868 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
869 getSelectQuery(): Add a String quickFind parameter and use it with
870 Glom.get_find_where_clause_quick() to pass a where_clause to
871 Glom.build_sql_select_with_where_clause(), to actually filter the
873 getData(): Add a String quickFind parameter, passing it to getListData().
874 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
875 va: getData(): Pass an empty string to getListData() for the
878 2012-01-12 Murray Cumming <murrayc@murrayc.com>
880 ListTable: Minor change.
882 * src/main/java/org/glom/web/client/ui/list/ListTable.java
883 createCellTable(): Make this protected instead of public.
885 2012-01-12 Murray Cumming <murrayc@murrayc.com>
887 Many files: Use final for the parameters and use the @override attribute.
889 2012-01-22 Ben Konrath <ben@bagu.org>
891 Add anchor links for single line text that starts with http, ftp and www.
895 2012-01-22 Ben Konrath <ben@bagu.org>
897 Add ellipsis to single line text in details view.
901 2012-01-04 Murray Cumming <murrayc@murrayc.com>
903 Remove all javadoc author tags.
905 Because they are awkward and meaningless when many people touch
907 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
909 2012-01-04 Murray Cumming <murrayc@murrayc.com>
911 Revert the COPYING.LESSER to COPYING rename.
913 Apparently both should be there if it is LGPL.
915 2012-01-03 Murray Cumming <murrayc@murrayc.com>
917 *View: Remove unused imports.
919 * src/main/java/org/glom/web/client/ui/DetailsView.java:
920 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
921 * src/main/java/org/glom/web/client/ui/ListView.java:
922 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
923 Remove unused imports, as suggested by Eclipse.
925 2012-01-02 Murray Cumming <murrayc@murrayc.com>
927 Move the *View::Presenter types, and some API into one base View.
929 * src/main/java/org/glom/web/client/ui/DetailsView.java:
930 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
931 * src/main/java/org/glom/web/client/ui/ListView.java:
932 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
933 Presenter, setPresenter() and clear() into a shared base interface,
934 to avoid the unnecessary duplicate Presenter types and to more clearly
935 show how the *Views share the same structure, even if they are not
936 used polymorphically.
938 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
939 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
941 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
942 * src/main/java/org/glom/web/client/activity/ListActivity.java:
943 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
945 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
948 Feel free to revert this if there is a good reason for the duplicate
951 2012-01-02 Murray Cumming <murrayc@murrayc.com>
953 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
955 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
956 a class member instead of a local variable in the method.
957 This lets us use it to get the view instances, for use in tests.
958 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
959 beforeOnlineGlom(): Test some more details of the initial view.
960 Again, this is not very useful.
962 To really test gwt-glom we will need to start a local postgresql
963 instance with local data, like the Glom tests in C++.
965 2012-01-02 Murray Cumming <murrayc@murrayc.com>
967 pom.xml: Mention the LGPL license.
969 * pom.xml: Add a licenses section.
970 * COPYING.LESSER: Move this to COPYING, which
971 previously contained the GPL. But gwt-glom is all LGPL.
973 2012-01-02 Murray Cumming <murrayc@murrayc.com>
975 Add project information to README and pom.xml.
977 * README: Add a brief description and mention some mvn
979 * pom.xml: This extra information shows up in mvn site
982 2011-01-02 Murray Cumming <murrayc@murrayc.com>
984 Use the latest java-libglom version.
986 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
988 2012-01-01 Murray Cumming <murrayc@murrayc.com>
990 GwtTestOnlineGlom: Test a little more.
992 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
993 protected rather than private, as suggested by the gwt-test-utils
995 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
996 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
997 Test the initial visibility of the panels.
999 However, this is not a very useful test.
1000 And I wonder how we should generally test using this idea for an
1001 activity/places app like ours where the real changes happen implicitly
1002 based on the history token/URL.
1004 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1006 Slight modification to *Mapper comments.
1008 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1009 (DataActivityMapper)
1010 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1012 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1014 Remove comments mentioning GIN because they are just copied from
1015 the example code and are apparently not helpful:
1016 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1017 Also change the mention of a class that is only in the example code.
1019 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1021 GwtTestOnlineGlom test: Minor changes.
1023 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1024 Avoid the long qualified class name and modify the comment
1025 because it is now obvious to me that the mocked class is the only
1026 custom one created via GWT.create().
1028 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1030 Tests: Added the beginnings of a test using gwt-test-utils.
1032 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1033 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1034 which tells gwt-test-utils what class will be tested.
1035 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1036 Add a simple (but empty) test case. One class, used by the OnlineGlom
1037 class, is mocked so that it can be created. However, I am not sure
1038 why only this class needs to be mocked.
1040 Note that mockito seems more popular, and clearer, than easymock,
1041 but I have not got that working yet. It might be a matter of the
1044 This test is run during mvn integration-test.
1046 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1048 Tests: Use junit4-style syntax instead of junit3-style.
1050 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1051 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1052 * src/test/java/org/glom/web/shared/DataItemTest.java:
1053 Use the @Test annotation rather than relying on the test*() prefix.
1054 Also no longer implement TestCase, to avoid triggering support for
1055 the junit3-way, which stops the annotations from working.
1056 Change the imports from import junit.framework.* to
1057 import org.junit.*, which is apparently the new way.
1059 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1061 Added a test for ListPlace token parsing and creation.
1063 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1064 This is much the same as DetailsPlaceTest.
1066 I wonder how we could test the other parts of the *Place API.
1068 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1070 DetailsPlace test: Also test getToken() and recreation via getPlace().
1072 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1073 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1074 recreate it, testing the recreated DetailsPlace for the same parameter
1077 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1079 Use the surefire-report plugin.
1081 * pom.xml: This generates a HTML report about the tests in
1082 target/site/surefire-report.html
1083 when you do mvn surefire-report:report. It seems to be popular/normal.
1085 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1087 Added a test for DetailsPlace.
1089 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1090 Test the getPlace() token parsing.
1092 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1094 Added a first unit test.
1096 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1097 * src/test/java/org/glom/web/shared/DataItemTest.java:
1098 This is a silly test but it is just to get things started. Note that
1099 maven/junit finds the test because it looks in src/test by default.
1101 2011-12-22 Ben Konrath <ben@bagu.org>
1103 Change charsetName to "UTF-8" when replacing line breaks.
1105 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1106 that work in Java (such as "UTF8") will not work when compiled to
1109 This fixes a problem with multi-line details view fields that have hard
1110 line breaks. The "License Text" field on this page demonstrates the
1113 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1115 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1117 2011-12-22 Ben Konrath <ben@bagu.org>
1119 Fix another bug with related list navigation.
1121 I've tested all the navigation buttons in all of the related lists
1122 so things should be good now.
1124 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1126 2011-12-22 Ben Konrath <ben@bagu.org>
1128 Fix a crasher when refreshing the list view with the default table.
1130 This crash will also happen when loading the list view with the default
1131 table from a link or bookmark.
1133 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1134 to the main document selection page when the document id hasn't been
1136 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1137 the main document selection page when the document id hasn't been
1139 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1140 values for the details place when the document id hasn't been set.
1141 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1142 values for the list place when the document id hasn't been set.
1144 2011-12-21 Ben Konrath <ben@bagu.org>
1146 Protect against NPE when glom.document.locale is not in config.
1148 This patch protects against an NPE when glom.document.locale is not in
1149 the config file. This NPE will also happen if glom.document.locale is
1152 The patch also updates the error message to display the class name when
1153 the getMessage() returns null. This was happening when the NPE was
1154 thrown and I had "Configuration Error: null". If an NPE is encountered
1155 with this patch, "Configuration Error: NullPointerException " will be
1158 This commit closes this bug:
1160 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1164 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1166 Rename onlineglom.properties to onlineglom.properties.sample.
1168 * src/main/resources/onlineglom.properties: Rename to:
1169 * src/main/resources/onlineglom.properties.sample:
1170 * src/main/resources/README: And add this file explaining that people
1171 should rename it back when deploying.
1173 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1175 Allow choosing the translation in the .properties file.
1177 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1178 init(): Read a glom.document.locale value from the configuration file
1179 and call Glom's TransatableItem::set_current_locale() method.
1180 * src/main/resources/onlineglom.properties: Add a commented-out
1181 example of this new setting.
1183 It would be better to add &lang=de_DE to the URL, but the current
1184 libglom API does not allow us to do this easily. I am working on that.
1186 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1188 Avoid a crash in parsing of token parameters.
1190 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1191 ava: getTokenParams(): Do not crash if a parameter has a key but no
1192 value, and ignore parameters with neither.
1194 2011-12-17 Murray Cumming <murrayc@murayc.com>
1196 History token building/handling: Improve use of token parameters.
1198 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1199 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1200 and buildParamsToken(HashMap), for use by derived classes.
1201 Make the separator private because it is no longer be needed.
1202 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1203 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1204 instead of manual string concatenation.
1205 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1206 of hardcoded indices and awkward splitting code.
1207 * src/main/java/org/glom/web/client/place/ListPlace.java
1208 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1209 instead of manual string concatenation.
1210 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1211 of hardcoded indices and awkward splitting code.
1212 This should fix bug #666420
1214 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1216 Fix a Navgiation->Navigation typo in the code.
1218 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1219 Rename processNavgiation() to processNavigation().
1221 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1223 Fix a seperator->separator typo in the code.
1225 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1226 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1227 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1230 2011-12-15 Ben Konrath <ben@bagu.org>
1232 Cleanup some comments.
1234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1236 2011-12-14 Ben Konrath <ben@bagu.org>
1238 Replace \n with <br/> for multiline text in the details view.
1240 Vertical scrollbars are added when needed as well.
1242 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1244 2011-12-14 Ben Konrath <ben@bagu.org>
1246 Specify the font for document selection links.
1248 * src/main/webapp/style.css:
1250 2011-12-14 Ben Konrath <ben@bagu.org>
1252 Fix bouncy CellTable while paging.
1254 This doesn't currently work with related list tables in unselected
1257 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1259 2011-12-14 Ben Konrath <ben@bagu.org>
1261 Revamp the appearance of the document selection page.
1263 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1264 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1265 * src/main/webapp/style.css:
1267 2011-12-13 Ben Konrath <ben@bagu.org>
1269 Set navigation button column to the smallest size possible.
1271 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1273 2011-12-13 Ben Konrath <ben@bagu.org>
1275 Change OpenButton nomenclature to NavigationButton.
1277 Using NavigtionButton makes things more generic. Classes, methods and
1278 variables have been changed.
1280 This is a rename-only refactor.
1282 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1283 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1284 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1285 Renamed from OpenButtonCell.
1286 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1287 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1288 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1290 2011-12-12 Ben Konrath <ben@bagu.org>
1292 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1294 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1295 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1296 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1297 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1299 2011-12-12 Ben Konrath <ben@bagu.org>
1301 Update variable names and comments.
1303 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1304 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1306 2011-12-12 Ben Konrath <ben@bagu.org>
1308 Properly initialize numNonEmptyRows variable to zero.
1310 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1311 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1313 2011-12-05 Ben Konrath <ben@bagu.org>
1315 Add latest mockup with HTML tables.
1317 Features of this mockup:
1319 -> HTML table for flowtable
1320 -> HTML table for flowtable column
1321 -> Example of how related lists would look
1322 -> Not using text entries for data items
1324 The current version of Online Glom doesn't use HTML tables for the
1327 This mockup has been sent to the glom-devel mailing list but it's good
1328 to have it here as well.
1330 * mockups/details-view-html-tables.html:
1332 2011-12-05 Ben Konrath <ben@bagu.org>
1334 Remove unnecessary getPrimaryKeyField() method.
1336 getPrimaryKeyFieldForTable(String) has been renamed to
1337 getPrimaryKeyField(String).
1339 * src/main/java/org/glom/web/server/database/DBAccess.java:
1340 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1341 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1343 2011-12-05 Ben Konrath <ben@bagu.org>
1345 Add string representation of TypedDataItem value to conversion error message.
1347 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1348 message was extracted into its own method to avoid duplication.
1350 2011-12-05 Ben Konrath <ben@bagu.org>
1352 Add type checking to navigation primary key value creation.
1354 Create navigation primary key only if the expected type from the Glom
1355 document matches the type returned by the SQL query.
1357 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1359 2011-12-05 Ben Konrath <ben@bagu.org>
1361 Rename a couple of variables in RelatedListNavigation.
1363 This is a rename-only refactor.
1365 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1367 2011-12-05 Ben Konrath <ben@bagu.org>
1369 Move getListLayoutGroup() into getListViewLayoutGroup().
1371 This removes getListLayoutGroup(). It was only being called by
1372 getListViewLayoutGroup().
1374 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1376 2011-12-05 Ben Konrath <ben@bagu.org>
1378 Remove check for LayoutItem_Portal in list table method.
1380 This check is no longer necessary because the method isn't being used
1381 to create the LayoutItemPortal DTO.
1383 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1385 2011-12-05 Ben Konrath <ben@bagu.org>
1387 Properly support related list navigation.
1389 Navigation from the "Repository Analyzer -> Package Scans ->
1390 Dependencies" related table wasn't working because the primary key for
1391 related tables wasn't being set properly. This commit fixes the
1394 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1395 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1396 doesn't set the primary key properly for related list tables.
1397 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1398 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1399 useful for getting the primary key for list view tables and for related
1401 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1402 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1403 Move code to set the primary key for the table from the abstract
1404 ListDBAccess class to ListViewDBAccess as it's only correct for list
1406 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1407 Properly add primary key to related list tables.
1409 2011-12-02 Ben Konrath <ben@bagu.org>
1411 Properly set the horizontal alignment of fields.
1413 This fix is for both the list tables and the details view.
1415 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1416 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1417 to set the horizontal alignment of fields.
1419 2011-12-02 Ben Konrath <ben@bagu.org>
1421 Display currency codes in the details view.
1423 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1425 2011-12-02 Ben Konrath <ben@bagu.org>
1427 Avoid duplicate JNI call.
1429 JNI is not as efficient as pure Java and this is an easy (and small)
1432 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1433 Use previously retrieved value for whereClauseToTableName instead of
1436 2011-12-02 Ben Konrath <ben@bagu.org>
1438 Rename a couple of variables in RelatedListNavigation.
1440 This is a rename-only refactor.
1442 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1444 2011-12-02 Ben Konrath <ben@bagu.org>
1446 Indicate clearly that a mismatched primary key type is a bug.
1448 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1449 warning to error. Add 'This is a bug.' to message.
1451 2011-12-02 Ben Konrath <ben@bagu.org>
1453 Update / fix some comments.
1455 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1457 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1459 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1460 Fix comments. Add some TODOs.
1462 2011-12-02 Ben Konrath <ben@bagu.org>
1464 Enable navigation to details view with string primary key from related list.
1466 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1467 Create a text primary key value when return type of result is
1468 java.sql.Types.VARCHAR.
1470 2011-12-02 Ben Konrath <ben@bagu.org>
1472 Use checkboxes for booleans in the details view.
1474 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1476 2011-12-01 Ben Konrath <ben@bagu.org>
1478 Improve performance of related list height calculation.
1480 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1481 Put code to calculate the expected height in a static initializer so
1482 that that it's only called once.
1484 2011-12-01 Ben Konrath <ben@bagu.org>
1486 Show related list tables in notebooks (again).
1488 Calculate the height of the related list tables so the Notebook can be
1489 set the correct height. The height of the related list table is also needed by
1490 FlowTable to be able decide how to create the layout.
1492 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1493 and set the Portal height based on the height of the related list
1494 table and the Portal container.
1495 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1496 Add method to calculate the height of the related list tables.
1497 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1498 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1499 calculate the height of the Pager widget.
1501 2011-12-01 Ben Konrath <ben@bagu.org>
1503 Use CellTable API for table property instead of setting style on Element.
1505 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1507 2011-12-01 Ben Konrath <ben@bagu.org>
1509 Make ListViewTable and RelatedListTable a consistent height.
1511 The tables are now a consistent height regardless of the contents of
1512 the table. A hidden button is added to empty rows to ensure that the
1513 height of these rows will match the height of rows with data.
1515 A navigation button column is now added to every table. The width of
1516 the navigation column is set to 0px when a RelatedListTable shouldn't
1517 have navigation buttons. This maintains the a consistent row height in
1518 tables that don't show the navigation buttons.
1520 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1521 navigation column when not needed.
1522 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1523 arguments for navigation button to constructor of ListViewTable.
1524 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1525 hidden button for empty data rows.
1526 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1527 arguments for navigation button to constructor.
1528 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1529 create navigation buttons. Add hideNavigationButtons() method.
1530 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1531 arguments for navigation button to constructor.
1533 2011-12-01 Ben Konrath <ben@bagu.org>
1535 Use 'visibility: hidden' in Utils.getWidgetHeight().
1537 This is better choice because hidden elements are invisible, don't
1538 respond to events and are not part of the tab order. They will,
1539 however, take up space which is required to be able to calculate the
1540 height of the widget.
1542 * src/main/java/org/glom/web/client/Utils.java:
1544 2011-12-01 Ben Konrath <ben@bagu.org>
1546 Use Utils.getWidgetHeight() in FlowTable.
1548 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1550 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1552 2011-12-01 Ben Konrath <ben@bagu.org>
1554 Put the details css class name on the correct table column.
1556 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1558 2011-11-30 Ben Konrath <ben@bagu.org>
1560 Update for java-libglom API change.
1562 The getters and setters on FieldFormatting and NumericFormat were
1563 changed to remove the 'M'.
1565 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1567 2011-11-29 Ben Konrath <ben@bagu.org>
1569 Only allow RelatedListTables in Portals.
1571 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1573 2011-11-29 Ben Konrath <ben@bagu.org>
1575 Only create a contents panel for Portals when title is being set.
1577 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1579 2011-11-29 Ben Konrath <ben@bagu.org>
1581 Set TabLayoutPanel height based on calculated height its widgets.
1583 This is a potential fix for this bug:
1585 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1587 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1589 2011-11-29 Ben Konrath <ben@bagu.org>
1591 Align details field labels and data with the Open buttons.
1593 * src/main/webapp/style.css:
1595 2011-11-29 Ben Konrath <ben@bagu.org>
1597 Remove unnecessary <div> in the Notebook widget.
1599 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1600 method to get container FlowPanel (<div>).
1601 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1602 initWidget() method directly on the TabLayoutPanel widget instead of
1603 Group's container widget.
1605 2011-11-29 Ben Konrath <ben@bagu.org>
1607 Don't add group titles for Portals in Notebooks.
1609 This reverts the previous patch and fixes a bug I introduced with
1610 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1612 * src/main/java/org/glom/web/client/ui/details/Group.java:
1613 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1615 2011-11-28 Ben Konrath <ben@bagu.org>
1617 Remove unused boolean argument in Portal constructor.
1619 Just a code cleanup.
1621 * src/main/java/org/glom/web/client/ui/details/Group.java:
1622 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1624 2011-11-28 Ben Konrath <ben@bagu.org>
1626 Remove hack for glom 1.18 style glom files.
1628 * src/main/java/org/glom/web/client/ui/details/Group.java:
1629 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1630 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1632 2011-11-28 Ben Konrath <ben@bagu.org>
1634 Use Gda Value version of primary key to log result too large error.
1636 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1638 2011-11-28 Ben Konrath <ben@bagu.org>
1640 Don't use TypedDataItem.getText() for Unknown types from the URL.
1642 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1643 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1644 instead of getText().
1645 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1646 String field and getUnknown() method.
1648 2011-11-28 Ben Konrath <ben@bagu.org>
1650 Log an error message when the java-libglom .so is not present.
1652 The error message was being set in the exception but not logged.
1654 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1656 2011-11-28 Ben Konrath <ben@bagu.org>
1658 Ignore LayoutItem_CalendarPortals.
1660 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1661 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1663 2011-11-28 Ben Konrath <ben@bagu.org>
1665 Extract method for creating the LayoutItemPortal DTO.
1667 Just breaking the code up into smaller chunks.
1669 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1671 2011-11-28 Ben Konrath <ben@bagu.org>
1675 This should have been added with the refactor. Oops!
1677 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1679 2011-11-28 Ben Konrath <ben@bagu.org>
1681 Create primary key value from URL string using type from Glom document.
1683 See this bug, comments 19 - 25:
1685 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1687 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1688 create a TypeDataItem for the primary key here when loading from a
1689 URL. Show the same string for the primary key value as was received
1690 from the URL string (when loading from a URL).
1691 * src/main/java/org/glom/web/server/Utils.java: Update method for
1692 creating the Gda Value from the TypeDataItem to properly deal with
1693 creating a Gda Value based on the Glom document type for the primary
1694 key value string when loading from a URL.
1695 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1696 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1697 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1698 Update for changed method name.
1700 2011-11-27 Ben Konrath <ben@bagu.org>
1702 Rename PrimaryKeyItem to TypedDataItem.
1704 The name PrimaryKeyItem suggests what the class should be used for.
1705 TypedDataItem is a neutral name that describes the class better.
1707 This is a rename-only refactor.
1709 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1710 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1711 * src/main/java/org/glom/web/client/Utils.java:
1712 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1713 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1714 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1715 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1716 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1717 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1719 * src/main/java/org/glom/web/server/Utils.java:
1720 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1721 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1722 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1723 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1725 2011-11-25 Ben Konrath <ben@bagu.org>
1727 Improve Gda Value conversion from PrimaryKeyItem.
1729 The value from the PrimaryKeyItem is only used if its type match the
1730 type from the glom document.
1732 * src/main/java/org/glom/web/server/Utils.java:
1734 2011-11-25 Ben Konrath <ben@bagu.org>
1736 Manually check if the java-liblgom .so is visible to the JVM.
1738 It seems that Tomcat has problems when a static initializer throws an
1739 exception. This check is done before the first method call into
1740 java-libglom so that execution doesn't continue if the .so is not
1743 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1745 2011-11-25 Ben Konrath <ben@bagu.org>
1747 Improve browser configuration error messages.
1751 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1753 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1754 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1755 getConfigurationErrorMessage() method.
1756 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1757 Get and display a specific configuration error message when no Glom
1758 documents are found.
1759 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1760 Implement getConfigurationErrorMessage() method. Surround configuration
1761 code in the init() method with a try/catch block. This allows the
1762 errors to be caught while keeping the servlet available to retrieve the
1763 configuration error message.
1765 2011-11-25 Ben Konrath <ben@bagu.org>
1767 Don't use Strings to hold primary key values.
1769 The primary key values are now held in a new data object
1770 (PrimaryKeyItem) that holds type information and the primary key value
1771 using the correct type.
1773 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1774 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1775 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1776 PrimaryKeyItem instead of String to hold the primary key value.
1777 * src/main/java/org/glom/web/client/Utils.java: Remove
1778 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1779 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1780 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1781 PrimaryKeyItem instead of String to hold the primary key value. Load
1782 document selection page when the documentID has not been set correctly.
1783 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1784 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1786 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1787 Return empty string for URL instead of "null".
1788 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1789 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1790 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1791 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1792 PrimaryKeyItem instead of String to hold primary key values.
1793 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1794 PrimaryKeyValue to a Gda Value.
1795 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1796 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1797 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1798 Replace temporary database access code that uses the PrimaryKeyValue to
1799 Gda Value conversion.
1800 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1801 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1802 PrimaryKeyItem instead of String.
1803 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1804 hold primary key values.
1806 2011-11-24 Ben Konrath <ben@bagu.org>
1808 Use newly added java-libglom API to create queries.
1810 This isn't finished. I still need to stop using Strings for primary key
1811 values in the client code.
1813 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1814 libglom to use fake connections so that retrieving the query string will
1816 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1817 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1818 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1819 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1820 Use the newly added libglom sql methods and classes to create the
1821 query. Add temporary hack to convert primary value strings to Gda
1824 2011-11-23 Ben Konrath <ben@bagu.org>
1826 Don't explicitly set the height of Portals.
1828 See comments 6 - 10 of this bug for details:
1830 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1832 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1834 2011-11-23 Ben Konrath <ben@bagu.org>
1836 Use an HTML table instead of CSS for the FlowTable layout.
1838 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1839 GWT's FlexTable to implement the FlowTable.
1840 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1842 2011-11-18 Ben Konrath <ben@bagu.org>
1844 Add boolean example to HTML table mockup.
1846 * mockups/details-view-html-tables-text-entries.html:
1848 2011-11-17 Ben Konrath <ben@bagu.org>
1850 Ensure the pager buttons are always visible for related lists.
1852 To accomplish this, I've turned off text wrapping in the list view and
1853 related list tables for both the header and data text. The related list
1854 table now has a fixed layout so the it doesn't overflow its container.
1855 This is required to ensure that the cell text is clipped when it
1856 overflows the cell and an ellipsis is added to the right side of the
1857 cell when text is clipped.
1859 A fixed table layout for the related list table in the details view
1860 seems what we want for the details view anyway, so the side-effect is
1863 The ellipsis will only be displayed in Firefox >= 7.
1867 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1869 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1870 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1871 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1873 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1874 Set the 'table-layout: fixed' CSS property to the related list table.
1875 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1876 'white-space: nowrap;' CSS property on both the list view and the
1877 related list tables.
1879 2011-11-16 Ben Konrath <ben@bagu.org>
1881 Rework the fix for empty notebook tab labels.
1883 Setting the empty group titles with its name caused problems for the
1884 details layout. Instead of using libglom's
1885 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1886 to the client when the title is empty. This allows the Notebook to use
1887 the name when the title is empty without affecting anything else.
1889 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1890 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1892 2011-11-16 Ben Konrath <ben@bagu.org>
1894 Set group titles with name when title is empty.
1896 This fixes a problem with an empty notebook tab label in the Lesson
1897 Planner document. The forth tab in the notebook should be "Internet":
1899 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1901 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1902 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1905 2011-11-16 Ben Konrath <ben@bagu.org>
1907 Remove whitespace from the configured username properties.
1909 This assumes that usernames won't have whitespace at the beginning
1910 or end. But I think this is a reasonable assumption.
1912 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1913 String.trim() to remove the whitespace from the username properties.
1915 2011-11-15 Ben Konrath <ben@bagu.org>
1917 Add details view mockup with HTML tables and text entries.
1919 This is from the attachment on this bug:
1921 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1923 * mockups/details-view-html-tables-text-entries.html:
1925 2011-11-15 Ben Konrath <ben@bagu.org>
1927 Add space between the columns of the flow table.
1931 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1933 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1934 space between columns in the flow table.
1936 2011-11-15 Ben Konrath <ben@bagu.org>
1938 Add backup files to the .gitignore.
1940 * .gitignore: Ignore files that end with ~.
1942 2011-11-09 Ben Konrath <ben@bagu.org>
1944 Use latest release of gwt-log.
1946 Gwt-log releases are now being submitted to the maven central
1947 repository so manual installation of the jar is no longer required.
1949 * pom.xml: Update version and groupId of gwt-log dependency.
1951 2011-10-31 Ben Konrath <ben@bagu.org>
1953 Don't use GWT numeric formatting to override the glom currency formatting.
1955 Currencies are now displayed like they are in Glom. See this bug:
1957 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1959 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1961 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1962 currency code to constructor and set it when the cell is rendered.
1963 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1964 currency code to the constructor of the NumericCell.
1966 2011-10-27 Ben Konrath <ben@bagu.org>
1968 Require the latest release of java-libglom (1.17.4).
1972 2011-10-26 Ben Konrath <ben@bagu.org>
1974 Add style to Notebook that matches current theme.
1976 It's not the best style in the world but it's better than the default.
1978 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1979 padding at the bottom of the child widgets.
1980 * src/main/webapp/style.css: Add style for the Notebook.
1982 2011-10-26 Ben Konrath <ben@bagu.org>
1984 Move servlet initialization code to overridden init method.
1986 This is half of the solution to getting proper error messages
1987 displayed when configuration errors occur. Here's the relevant bug:
1989 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1991 The rest of the solution involves surrounding the init method with a
1992 try/catch block and setting a global variable with the error /
1993 exception. A new async method should be created to retrieve and display
1994 the error message / exception.
1996 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1997 code from constructor to init method adding exceptions as needed.
1999 2011-10-26 Ben Konrath <ben@bagu.org>
2001 Add script to monitor and restart tomcat if required.
2003 * utils/check-and-recover-tomcat.py: New file.
2005 2011-10-26 Ben Konrath <ben@bagu.org>
2007 Display the correct number of data items in the pager.
2011 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2013 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2014 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2015 The implementation is the same for both tables: Keep track of the
2016 number of non-empty rows and fire and RowCountChangeEvent after the data has
2018 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2019 custom Pager class that subclasses SimplePager to handle displaying
2020 the correct number when empty rows have been added.
2022 2011-10-26 Ben Konrath <ben@bagu.org>
2024 Correct error in previous commit.
2026 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2027 eventBus parameter from listView.setCellTable().
2029 2011-10-26 Ben Konrath <ben@bagu.org>
2031 Fix error in TODO comment.
2033 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2035 2011-10-24 Ben Konrath <ben@bagu.org>
2037 Create Notebook widgets to the details view.
2039 This isn't finished just yet - I still need to create a reasonable
2040 style to match the current theme.
2042 * src/main/java/org/glom/web/client/Utils.java: Add method for
2043 calculating the height of a widget. This is used in the Notebook class.
2044 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2045 new constructor method in Group.
2046 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2047 method for creating child widget that can be used by subclasses
2048 like Notebook. New constructor that allows disabling the group
2049 titles - Notebooks don't set a group title for their child groups.
2050 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2051 to make Notebooks using GWT's TabLayoutPanel.
2052 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2053 constructor that allows disabling the group titles.
2054 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2055 LayoutItemNotebook DTO.
2056 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2057 DTO for Notebooks. It's just an empty class for now but we might need
2058 it to transfer some specific information in the future.
2060 2011-10-21 Ben Konrath <ben@bagu.org>
2062 Add navigation buttons to related list tables.
2064 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2065 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2066 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2067 method getSuitableRecordToViewDetails() for getting the table name
2068 and primary key value for related list navigation buttons.
2069 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2070 private cell renderer class to get the navigation information for
2071 related list tables from the server. Extract the navigation
2072 processing code from the details cell navigation and use it for the
2073 related list navigation as well.
2074 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2075 cell renderer class for the details open buttons. This was needed
2076 because the related list navigation buttons and the list view
2077 navigation buttons need to react differently when clicked.
2078 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2079 the onEnterKeyDown() method because it's now overriden in the
2080 subclasses that are specific to the related list tables and the list
2082 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2083 the vertical size a little because the buttons add a bit of vertical
2084 space to table. This is not a perfect solution because the vertical
2085 size of with table fewer than 5 rows will be a little smaller.
2086 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2087 changes in how navigation buttons are handled.
2088 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2089 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2090 database access object.
2091 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2092 to find the portal for a given relationship name from
2093 RelatedListDBAccess. Add method to find a primary key field for a
2095 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2096 Move code to find the portal for a given relationship name to
2098 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2099 New file: database access object for getting the related list
2100 navigation information (the table name and the primary key value).
2101 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2102 DTO for transferring a table name to navigate to and a primary key
2104 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2105 boolean and getter/setter to specifies if the related list should add
2108 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2110 Use the master branch of java-libglom
2112 * pom.xml: Depend on java-libglom 1.19 instead.
2114 This is the master branch. See also the libglom-1-18 branch.
2116 2011-10-11 Ben Konrath <ben@bagu.org>
2118 Enable the open navigation button when the data has been set.
2120 This avoids having active buttons that don't do anything when the data
2123 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2125 2011-10-11 Ben Konrath <ben@bagu.org>
2127 Use IsWidget interface for FlowTableItem.
2129 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2130 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2132 2011-10-11 Ben Konrath <ben@bagu.org>
2134 Remove GWT styling from open button in details view.
2136 There are still some issues with how the details cell is arranged but
2137 this should be made to match Glom 1.20. I'm going to leave fixing this
2138 until I have Glom 1.20 up and running.
2140 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2141 style name on open button.
2142 * src/main/webapp/style.css: Move and edit details-navigation class.
2143 Re-arrange some classes to make them appear in the same order as the
2146 2011-10-07 Ben Konrath <ben@bagu.org>
2148 Update to GWT 2.4.0.
2150 * .gitignore: Ignore new cache directory.
2151 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2152 * pom.xml: Change GWT and maven plugin to 2.4.0.
2153 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2155 * src/main/java/org/glom/web/client/ClientFactory.java:
2156 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2157 * src/main/java/org/glom/web/client/OnlineGlom.java:
2158 Update source for API changes.
2159 * utils/build-onlineglom-war.sh: Remove cache directory before the
2162 2011-10-07 Ben Konrath <ben@bagu.org>
2164 Add navigation buttons in the details view.
2166 This isn't finished but I thought I'd commit what I have as it's a
2167 pretty good start. I still need to:
2169 1. Change the style so that it fits better into the current theme
2170 2. Adjust the details cell to expand as much as possible.
2172 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2173 click handlers to navigation buttons in the DetailsCells. Create a
2174 refreshData() method to get just the data from the server without the
2176 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2177 Update the tableSelector and browser title when the table name
2178 changes without using the tableSelector.
2179 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2180 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2181 getDetailsCells() to getCells(). Update variable names.
2182 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2183 method to set click handler on navigation button. Rename a few
2184 variables. Add navigation buttons where needed.
2185 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2186 variables and methods.
2187 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2188 navigation boolean and navigation table as required in the
2189 LayoutItemField DTO.
2190 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2191 variables for navigation along with getter/setter methods.
2193 2011-10-07 Ben Konrath <ben@bagu.org>
2195 Rename Field to DetailsCell.
2197 This is a refactor-only commit. No functionality has been added or
2200 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2201 Update variable and method names.
2202 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2203 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2204 variable and method names.
2205 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2207 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2208 variable and method names.
2210 2011-10-07 Ben Konrath <ben@bagu.org>
2212 Create separate methods for layout and data the details view.
2214 This is a refactor-only commit. No functionality has been added or
2217 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2218 private methods: setData(), createLayout().
2220 2011-10-07 Ben Konrath <ben@bagu.org>
2222 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2224 This is part of a change to get navigation buttons in the details view
2225 but it should have been done this way from the start.
2227 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2228 for method name change in TableSelectionView.
2229 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2230 Create TableChangeEvent and set the browser title using the
2231 TableSelectionView API.
2232 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2233 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2234 Change getSelectedTable() to getSelectedTableName(). Add
2235 getSelectedTableTitle().
2237 2011-10-07 Ben Konrath <ben@bagu.org>
2239 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2241 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2243 2011-10-07 Ben Konrath <ben@bagu.org>
2245 Update TableChangeEvent to use newTableName naming convention.
2247 This makes the class more consistent with GWT naming conventions.
2249 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2250 Update for method name change in TableChangeEvent.
2251 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2252 for method name change in TableChangeEvent.
2253 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2254 newTableName variable and getter method. Make toDebugString()
2257 2011-09-30 Ben Konrath <ben@bagu.org>
2259 Disable the pager in the list tables when the data row count is less than the minimum.
2261 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2262 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2264 2011-09-30 Ben Konrath <ben@bagu.org>
2266 Add empty rows to the end of related list and list view tables.
2268 I also extracted the cell rendering classes from the ListTable because
2269 the code was becoming a little crazy with all the anonymous inner
2270 classes. My plan is to use these cell rendering classes in the details
2271 view as well so this refactor will be needed for that change.
2273 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2274 set the row count in related list tables if the data has more rows
2275 than the minimum number of rows visible.
2276 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2277 row count in list view tables if the data has more rows than the
2278 minimum number of rows visible.
2279 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2280 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2282 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2283 for rendering TYPE_NUMERIC cells. The code was extracted from the
2285 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2286 class for rendering cells with buttons in list views. The code was
2287 extracted from the ListTable class.
2288 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2289 for rendering TYPE_TEXT cells. The code was extracted from the
2291 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2292 Add empty rows to the end of the data if required. Implement
2293 ListTable.getMinNumVisibleRows().
2294 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2295 cell renderer code to public classes. Return null in
2296 Column.getValue() for empty rows. Add new abstract method:
2297 getMinNumVisibleRows(). Move code to set the row count of the list view
2298 table to ListViewImpl.
2299 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2300 empty rows to the end of the data if required. Implement
2301 ListTable.getMinNumVisibleRows().
2304 2011-09-27 Ben Konrath <ben@bagu.org>
2306 Use GWT.log for client-side debugging statements.
2308 These are optimized out when deployed so I should have used this method
2309 in the first place. These statements will eventually be replaced with some sort
2310 of notification in the browser.
2312 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2313 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2314 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2315 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2316 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2318 2011-09-27 Ben Konrath <ben@bagu.org>
2320 Put tableselector on the right, back to list link on right.
2322 The idea is that the table selector is acting like a label for the
2323 currently displayed table so it should be placed below the document title. This
2324 puts the table title in a similar position to where it is in Glom.
2326 * mockups/details-contacts.html:
2327 * mockups/details-projects.html:
2328 * mockups/listview-contacts.html:
2329 * mockups/listview-projects.html:
2330 * mockups/style.css:
2331 Update mockups to match how the interfaces currently look.
2332 * src/main/webapp/style.css: Swap positions of backlink with the table
2333 selector. Add some space on the left side of the table selector to
2334 line things up with the document title.
2336 2011-09-27 Ben Konrath <ben@bagu.org>
2338 Add field colouring to details view.
2340 This change re-works how field colouring works. The colour formatting
2341 information is now set to the client with the layout information instead of
2342 with the data. This eliminates the need to send the same colour strings for
2343 data in list view column when colour information is set.
2345 In order to set an alternate colour for negative numeric values, the
2346 number is now sent to client and formatted with the GWT NumberFormat class.
2348 This change also fixes:
2350 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2352 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2353 internationalization framework which is needed for client side numeric
2355 * src/main/java/org/glom/web/client/Utils.java: New file for some
2356 client static utility methods.
2357 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2358 the DataItem object to the Field class. Use a utility method to
2359 create the foreignKeyValue string.
2360 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2361 alignment and text colours in the constructor. Add setData(DataItem)
2362 method. Remove setText(String) method.
2363 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2364 colour information to GlomTextCell. Create and use GlomNumberCell for
2365 rendering numbers. Use utility method to get the string for the
2366 primary key of the key provider. Re-work how the horizontal alignment
2368 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2369 formatting to layout information. Methods for converting the libglom
2370 formatting information were moved from DBAccess.
2371 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2372 numeric formatting (it's now done on the client side). Don't set text
2373 colours in DataItem. Move libglom formatting conversion methods to
2375 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2376 getters/setters for text colour information.
2377 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2378 for transferring the libglom NumericFormat information to the client.
2379 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2380 and getters/setters for: GlomNumericFormat, background colour and
2381 foreground colour strings.
2383 2011-09-26 Ben Konrath <ben@bagu.org>
2385 Simplify code that iterates through the LayoutGroup.
2387 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2389 2011-09-26 Ben Konrath <ben@bagu.org>
2391 Accept Eclipse formatting for OnlineGlomServiceAsync.
2393 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2395 2011-09-26 Ben Konrath <ben@bagu.org>
2397 Don't use the ListDBAccess classes to get the primary key layout information.
2399 This was causing a bug where the wrong index for the hidden primary key
2400 was being sent to the client.
2402 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2403 primary key while creating the LayoutGroup DTO. Create a
2404 LayoutItemField DTO for hidden primary keys. Don't use the
2405 RelatedListDBAccess because it was only used for getting the primary
2407 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2408 access modifier from public to protected for getPrimaryKeyField() and
2409 getPrimaryKeyLayoutItemField().
2410 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2411 abstract method getExpectedResultSize() because RelatedListDBAccess
2412 doesn't have enough info to implement it.
2413 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2414 Remove @Override for getExpectedResultSize().
2415 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2416 Remove method getExpectedResultSize().
2418 2011-09-23 Ben Konrath <ben@bagu.org>
2420 Log which layout (list or details) the ignored item is from.
2422 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2424 2011-09-23 Ben Konrath <ben@bagu.org>
2426 Remove annotations that turn off code formatting in DataItem.
2428 * src/main/java/org/glom/web/shared/DataItem.java:
2430 2011-09-23 Ben Konrath <ben@bagu.org>
2432 Rename GlomField to DataItem and update associated methods.
2434 This is a rename-only refactor. No functionality has been added or
2437 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2438 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2439 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2440 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2441 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2442 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2443 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2444 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2445 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2446 * src/main/java/org/glom/web/server/database/DBAccess.java:
2447 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2448 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2449 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2450 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2451 * src/main/java/org/glom/web/shared/DataItem.java:
2452 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2453 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2455 2011-09-23 Ben Konrath <ben@bagu.org>
2457 Rename GlomDocument to DocumentInfo and update associated methods.
2459 This is a rename-only refactor. No functionality has been added or
2462 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2463 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2464 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2465 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2466 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2467 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2468 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2470 2011-09-20 Ben Konrath <ben@bagu.org>
2472 Require java-libglom 1.17.3.
2474 This picks up the fix for the seg fault problem with the Scenes table
2475 in the Openismus Film Manager example.
2479 2011-09-20 Ben Konrath <ben@bagu.org>
2481 Change the way sort clause is added for primary key when no sort clause is requested.
2483 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2484 before the sort clause is created. When a sort clause is not requested, the
2485 sort clause is created by finding the primary key in the LayoutFieldVector
2488 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2490 2011-09-20 Ben Konrath <ben@bagu.org>
2492 Log error message if no documents are found in the configured directory.
2494 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2495 Extract the glom file extension string to a private static final class
2496 variable (mostly as syntactic sugar). Accept a minor formatting change.
2497 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2498 the example glom.document.directory configuration property to make it
2499 more clear that it can any directory, not just the home directory.
2501 2011-09-18 Ben Konrath <ben@bagu.org>
2503 Add related lists to details view.
2505 The related list table has support for paging and sorting just like the
2506 table in the list view.
2508 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2509 SQL queries for the related list tables.
2510 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2511 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2512 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2513 Rename getList methods to getListView and add comments. Remove
2514 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2515 it being unused. Add methods: getDetailsLayoutAndData(),
2516 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2517 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2518 Create the layout and set the data for the fields in one async call
2519 instead of two. Create related lists where appropriate.
2520 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2521 for method name changes in OnlineGlomService.
2522 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2523 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2524 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2526 * src/main/java/org/glom/web/client/ui/ListView.java:
2527 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2528 tableName from setCellTable(). Create a ListViewTable instead of
2530 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2531 represent a data field in the details view.
2532 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2533 from addDetailsCell() to Field class. Keep track of the Fields and
2534 Portals in the details view.
2535 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2536 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2537 and add a method to get it. Add method to set the contents of the
2539 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2540 New class for related list tables. This class has the data provider
2541 for the related list table.
2542 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2543 abstract class which is the base class for the ListViewTable and the
2545 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2546 New class for list view tables. This class has the data provider for
2547 the list view table.
2548 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2549 methods for related list tables. Add more information to the
2550 LayoutItemField and LayoutItemPortal DTOs.
2551 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2552 Remove debugging print statement.
2553 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2554 Remove debugging print statements. Add primary key field to SQL count
2556 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2557 Remove unnecessary LayoutFieldVector parameter from
2558 getResultSizeOfSQLQuery() method.
2559 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2560 New class for related list table database access.
2561 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2562 class that is a wrapper DTO for details view layout and data.
2563 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2564 new 'fromField' string to this DTO.
2565 * src/main/webapp/style.css: Remove bottom margin and override top
2568 2011-09-15 Ben Konrath <ben@bagu.org>
2570 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2572 This sets things up to make it easier to add the data retrieval for
2573 related lists (portals). No user noticeable changes were made with
2576 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2577 class has the code to retrieve the layouts and access the
2578 database using the new database helper classes.
2579 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2580 Most of the functionality has been removed from this class. This
2581 class now represents the public interface for the client side
2582 code. It also deals with configuring the servlet and cleaning
2583 things up when the servlet is stopped.
2584 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2585 of static methods into this utility class.
2586 * src/main/java/org/glom/web/server/database/DBAccess.java:
2587 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2588 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2589 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2590 These classes have the database retrieval code. The class hierarchy
2591 has been setup to make it easy to reuse code for similar
2594 2011-09-06 Ben Konrath <ben@bagu.org>
2596 Create separate classes for list table code and the data provider.
2598 As part of this refactor, I also split up the code a bit to make it
2601 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2602 table code to two new classes (below).
2603 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2604 with code from ListViewImpl.
2605 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2606 New file with code from ListViewImpl.
2608 2011-09-06 Ben Konrath <ben@bagu.org>
2610 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2612 This fixes the LayoutItemPortal DTO to match the libglom layout object
2615 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2617 2011-09-01 Ben Konrath <ben@bagu.org>
2619 Set title of Portals in the Details View.
2621 * pom.xml: Bump required version of java-libglom to 1.17.1.
2622 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2623 widget creation to its own class. Add comments to constructor.
2624 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2625 The code is mostly from the Group class with the title now set.
2626 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2627 title of Portal. Update some comments. Fix some code formatting.
2629 2011-09-01 Ben Konrath <ben@bagu.org>
2631 Remove TODO comment for the flow table column width.
2633 The flow table column width is working correctly and doesn't need to be
2634 changed. See this mailing list post for more info:
2636 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2638 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2640 2011-08-27 Ben Konrath <ben@bagu.org>
2642 Add document title (database name) to top of the browser page.
2644 I added the document title to the TableSelecitonView but that will
2645 change if / when we add a view that doesn't require table selection.
2647 * mockups/details-contacts.html:
2648 * mockups/details-projects.html:
2649 * mockups/listview-contacts.html:
2650 * mockups/listview-projects.html:
2651 * mockups/style.css: Add document title to mockups to keep things
2653 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2654 sizes to account for the document title.
2655 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2656 Set the document title when it has been retrieved from the server.
2657 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2658 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2659 and implement setDocumentTitle(String) method.
2660 * src/main/webapp/style.css: Add ID for document title style.
2662 2011-08-25 Ben Konrath <ben@bagu.org>
2664 Add NavigationType enum to LayoutItemPortal DTO.
2666 This is the start of adding support for Portals to the Details View.
2668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2669 LayoutItem_Portal.navigation_type enum from libglom to
2670 LayoutItemPortal.NavigationType enum.
2671 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2672 NavigationType enum, field for storing the NavigationType and getter
2675 2011-08-25 Ben Konrath <ben@bagu.org>
2677 Implement the flow table layout in the Details View.
2679 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2680 FlowTable to Group to account for the renamed class.
2681 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2682 File. This is a container widget that implements the Glom details view
2683 flow table behaviour.
2684 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2685 org/glom/web/client/ui/FlowTable.java.
2686 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2687 so that the size of the subgroups are a closer match to the size of
2688 the Glom subgroups. This makes the flowtable layout match the layout
2689 in Glom for the Music Collection example file.
2691 2011-08-16 Ben Konrath <ben@bagu.org>
2693 Create container element for LayoutItemPortal in Details View.
2695 This will help me develop the layout for the FlowTable.
2697 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2698 fieldPanel variable to detailsCell.
2700 2011-08-15 Ben Konrath <ben@bagu.org>
2702 Set the height of the data element in the Details View.
2704 I changed the InlineLabels (text in a span element) to Labels (text in
2705 a div element) so that I could set the height of the details-data
2706 elements instead of the details-cell parent elements. This allows the
2707 the details-data element to display the correct height if style is
2708 applied that shows the height.
2710 This change has the added benefit of allowing the order of the labels
2711 and data elements to be changed for right-to-left languages.
2713 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2714 InlineLabels to Labels.
2715 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2716 InlineLabels to Labels. Set the height of the data element.
2717 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2718 multiline text height in the Formatting DTO.
2719 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2720 for multiline height along with getter and setter methods.
2721 * src/main/webapp/style.css: Adjust style to account for the change
2722 from span elements to div elements in the details cell.
2724 2011-08-15 Ben Konrath <ben@bagu.org>
2726 Make the List View appearance match the mockups.
2728 It doesn't match exactly but it's much better than it was.
2730 * mockups/listview-contacts.html: Remove unused css classes.
2731 * mockups/listview-projects.html: Remove unused css classes.
2732 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2733 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2734 for mainPanel instead of VerticalPanel (table). Set style name on
2735 CellTable. Set style name on Details column. Right-align Details
2737 * src/main/webapp/style.css: Adjust properties to match the mockups.
2739 2011-08-12 Ben Konrath <ben@bagu.org>
2741 Add better support for subgroups in the details view.
2743 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2744 changed FlowTable constructor.
2745 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2746 support for subgroups and subgroup-titles.
2747 * src/main/webapp/style.css: Add CSS class for subgroups and
2750 2011-08-12 Ben Konrath <ben@bagu.org>
2752 Return the top level LayoutGroup title.
2754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2756 2011-08-11 Ben Konrath <ben@bagu.org>
2758 Make the TableSelector header match the mockup.
2760 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2761 the layout panel. Properly lineup the table selection header with
2762 the list and details view.
2763 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2764 margin around the details view.
2765 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2766 Rename listBox variable to tableSelector. Set id for the style sheet.
2767 Use a FlowPanel instead of a HorizontalPanel.
2768 * src/main/webapp/style.css: Add properties to make the TableSelector
2769 box match the mockups.
2771 2011-07-13 Ben Konrath <ben@bagu.org>
2773 Update install script for java-libglom version change.
2775 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2778 2011-07-13 Ben Konrath <ben@bagu.org>
2780 Add support sub-group in the details view.
2782 I also removed the code that special-cased the default details view
2785 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2787 I still have to make a proper flowtable.
2789 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2790 Don't special-case default details view layout.
2791 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2792 addLayoutField() as I'm going to use it.
2793 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2794 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2796 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2797 extracted from DetailsViewImpl.GroupPanel. Add support for
2799 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2800 column count when getting the details layout.
2802 2011-07-12 Ben Konrath <ben@bagu.org>
2804 Set browser title with database and table titles.
2806 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2807 Set the browser title when the table changes and when the activity
2809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2810 title when retrieving document info (the GlomDocument object).
2811 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2812 with getter and setter methods. Remove unused convenience constructor.
2813 Use default code formatting.
2815 2011-07-12 Ben Konrath <ben@bagu.org>
2817 Ignore LayoutItemPortals in the details view.
2819 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2822 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2823 LayoutItemPortal layout objects.
2824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2825 LayoutItemPortal objects when retrieving the details layout.
2826 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2827 file. This is an empty class and just used to get type information for
2830 2011-07-12 Ben Konrath <ben@bagu.org>
2832 Use java-libglom 1.17.0.
2836 2011-07-11 Ben Konrath <ben@bagu.org>
2838 Remove "Table:" label from table selector.
2840 This matches a recent change in the Glom UI.
2842 * mockups/details-contacts.html:
2843 * mockups/details-projects.html:
2844 * mockups/listview-contacts.html:
2845 * mockups/listview-projects.html: Remove the "Table:" label from the
2847 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2849 2011-07-11 Ben Konrath <ben@bagu.org>
2851 Add main groups to the details view.
2853 This makes things look a little nicer in the details view. The next step
2854 is to implement the flowtable.
2856 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2857 resources from the standard gwt css theme. Standard.css is now
2858 included in OnlineGlom.html so that the online glom css rules have
2859 precedence over the gwt theme.
2860 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2861 the whole LayoutGroup to the DetailsView instead of just the titles.
2862 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2863 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2864 details layout with a helper class (GroupPanel). I might extract this
2865 class when I make the full flowtable.
2866 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2867 string as default so I don't have to worry about NPEs when processing
2869 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2870 note beside OnlineGlom.gwt.xml above).
2871 * src/main/webapp/style.css: Add default font-size to body to override
2872 the font-size set by the standard theme. Don't use h2 tags for
2873 group-title. Create new details-cell class.
2875 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2877 ConfiguredDocument: Set the port number too.
2879 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2880 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2881 Glom document. Presumably this worked sometimes so far because there is a
2882 default port number.
2884 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2886 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2888 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2889 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2890 correct, though we should throw an exception too.
2892 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2894 Fix a addDocuemnt typo.
2896 * src/main/java/org/glom/web/shared/Documents.java
2897 (Documents.addDocuemnt): Rename to addDocument().
2898 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2899 (OnlineGlomServiceImpl.getDocuments): Adapt.
2901 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2903 Slightly improved log output when connection fails.
2905 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2906 (ConfiguredDocument.setUsernameAndPassword):
2907 We don't know for sure if it' the username/password that's wrong, so
2908 rephrase the message.
2909 Also ouput the exception message, though it's generic in this case.
2911 2011-07-08 Ben Konrath <ben@bagu.org>
2915 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2916 added braces to a one line if statement because the Eclipse formatter
2917 was getting confused.
2919 2011-07-07 Ben Konrath <ben@bagu.org>
2921 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2923 These should really be two separate tasks but I counldn't get things to
2924 work with GWT 2.2.0 and Eclipse 3.7.
2928 * .settings/org.eclipse.jdt.core.prefs:
2929 * .settings/org.eclipse.jdt.ui.prefs:
2930 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2931 * .settings/org.eclipse.m2e.core.prefs:
2932 Add new config files. Update current files. Remove references to the
2933 webtools plugins as we're not using any of the webtools features.
2934 * .gitignore: Add logs directory which is created when running with
2936 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2937 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2938 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2940 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2942 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2944 onlineglom.properties: Add explanatory comments.
2946 * src/main/resources/onlineglom.properties: Also change the default user
2947 from ben to someuser, to avoid the risk of people thinking we just
2948 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2950 2011-06-28 Ben Konrath <ben@bagu.org>
2952 Use filename in Log for incorrect passwords.
2954 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2955 getFileName(String) method to get the filename from the URI.
2957 2011-06-28 Ben Konrath <ben@bagu.org>
2959 Add the table name to the URL token for the ListPlace.
2961 This makes things consistent between the DetailsPlace and the
2962 ListPlace. It also allows the the ListPlace to be bookmarked.
2964 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2965 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2966 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2967 Remove getDefaultListLayout(). The default layout is now returned
2968 by the getListLayout() method when the table name is an empty string.
2969 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2970 Add table name field. Change to a new ListPlace when the table
2971 has been changed. Use getListLayout() for getting the default
2973 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2974 Add table name field. Set the correct table name in the list box
2975 when loading from bookmark. This corrects a problem for the
2977 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2978 Move table name to super-class (HasSelectableTable). Move document
2979 and table URL keys to super-class in HasSelectableTable.
2980 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2981 Add table name field. Add Tokenizer class with URL key common to
2982 the subclasses (DetailsPlace and ListPlace).
2983 * src/main/java/org/glom/web/client/place/ListPlace.java:
2984 Add table name. Add code to parse the URL token.
2985 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2986 Update ListPlace construction with empty table name string.
2987 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2988 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2989 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2990 Update ListPlace construction with table name string.
2991 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2992 Change defaultTableName field to tableName to reflect how it's now
2993 used. Update the getter and setter methods.
2995 2011-06-28 Ben Konrath <ben@bagu.org>
2997 Enable the table selector in the DetailsView.
2999 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3000 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3001 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3002 Remove getDefaultDetailsLayout(). The default layout is now returned
3003 by the getDetailsLayout() method when the table name is an empty
3005 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3006 event handler for table change event. Change to using
3007 getDetailsLayout() for the default details layout.
3008 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3010 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3011 when navigating to the details place.
3013 2011-06-27 Ben Konrath <ben@bagu.org>
3015 Use filename based unique document ID in URL and for RPC.
3017 The document ID is the glom document name with spaces (' ') replaced
3018 with pluses ('+') and without the .glom extension.
3020 This change is mostly a string substitution of 'documentTitle' for
3021 'documentID'. The only code change is the addition of a Documents DTO to get the
3022 filename to document title mappings as indicated below.
3024 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3025 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3026 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3027 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3028 Use Documents DTO to create the document links in the document
3030 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3031 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3032 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3033 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3034 * src/main/java/org/glom/web/client/place/ListPlace.java:
3035 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3036 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3037 * src/main/java/org/glom/web/client/ui/ListView.java:
3038 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3039 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3040 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3041 * src/main/java/org/glom/web/server/Log.java:
3042 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3043 getDocumentTitles() to getDocuments() and return the Documents DTO.
3044 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3045 transferring the filename to document title mappings.
3047 2011-06-25 Ben Konrath <ben@bagu.org>
3049 Make the authentication popup work again.
3051 This bug was introduced when I extracted ConfiguredDocument to its own class.
3053 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3054 correct success / fail status in setUsernameAndPassword().
3056 2011-06-25 Ben Konrath <ben@bagu.org>
3058 Use filename as unique key for configuring database usernames and passwords.
3060 This replaces the use of the Glom document title which could change
3061 depending on the locale. Thanks to Murray Cumming for pointing out this
3064 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3065 * src/main/resources/onlineglom.properties:
3067 2011-06-24 Ben Konrath <ben@bagu.org>
3069 Pass primary key value to DetailsView.
3071 This enables the DetailsView to load the correct data.
3073 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3074 primary key value field and set in constructor. Pass primary key
3075 value to getDetailsData().
3076 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
3077 variables for document title and primary key value.
3078 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
3079 key value to the DetailsPlace.
3081 2011-06-24 Ben Konrath <ben@bagu.org>
3083 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
3085 This allows the primary key to be retrieved by the Details button. This
3086 functionality has not been implemented yet but it's in the works.
3088 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
3089 the LayoutGroup result to ListView.setCellTable instead of all of its
3090 fields individually.
3091 * src/main/java/org/glom/web/client/ui/ListView.java:
3092 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
3093 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
3094 get the primary key for the table.
3095 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3096 index of the primary key in the LayoutGroup accounting for hidden
3097 primary keys. Rename getJavaNumberFormat() to
3098 convertToJavaNumberFormat() for consistency. Cleanup / add some
3100 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
3101 field for primary key index and a field to indicate whether the
3102 primary key is hidden or not.
3104 2011-06-23 Ben Konrath <ben@bagu.org>
3106 Rename getTableData methods to getListData.
3108 This is a rename refactor for consistency with other methods.
3110 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3111 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3112 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3113 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3115 2011-06-23 Ben Konrath <ben@bagu.org>
3117 Extract the ConfiguredDocument innerclass into its own class.
3119 This makes the servlet code more object oriented.
3121 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
3122 from private ConfiguredDocument class in OnlineGlomServiceImpl.
3123 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
3124 new ConfiguredDocument class.
3126 2011-06-21 Ben Konrath <ben@bagu.org>
3128 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
3130 This makes things more inline with how libglom works and reduces code
3131 duplication. This refactor lays the groundwork for adding the primary key to
3132 the LayoutGroup object.
3134 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3135 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3137 Change method names to getListLayout and getDefaultListLayout for
3138 consistency. Use LayoutGroup as the DTO for the list layout instead of
3139 ColumnInfo and LayoutListTable.
3140 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
3141 new method names along with the LayoutGroup object for transferring the
3143 * src/main/java/org/glom/web/client/ui/ListView.java:
3144 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3145 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
3146 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
3148 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
3149 Replaced with LayoutGroup.
3150 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
3151 expectedResultSize and defaultTableName fields which are needed for
3153 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3154 type field which is needed for the list layout but will also be
3155 useful for the details layout as things progress.
3156 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
3157 Make class abstract. Remove the unnecessary
3158 getFormattingHorizontalAlignment method. Add setFormatting method.
3160 2011-06-16 Ben Konrath <ben@bagu.org>
3162 Add scripts for building and installing war.
3164 These will help when updating OnlineGlom but they're also good
3165 supplemental documentation of the build and deployment proceeding.
3167 * utils/build-onlineglom-war.sh: New file.
3168 * utils/install-onlineglom-war.sh: New file.
3170 2011-06-16 Ben Konrath <ben@bagu.org>
3172 Create wrapper class to create consistent log messages.
3174 I wrapped methods in the Log class of gwt-log to add the method names
3175 from the servlet and create consistent formatting of the document title
3176 and table names in the log messages.
3178 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
3179 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
3180 log methods to use methods from wrapped Log class.
3182 2011-06-16 Ben Konrath <ben@bagu.org>
3184 Remove superfluous conditional return.
3186 Thanks to Murray Cumming for pointing this out!
3188 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3190 2011-06-15 Ben Konrath <ben@bagu.org>
3192 Return an ArrayList of LayoutGroups for the Details layout.
3194 This corrects a problem with the details layout as it can have more
3195 than one top level LayoutGroup.
3197 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3198 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
3199 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
3200 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
3201 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
3202 with ArrayList of LayoutGroups for the details view layout.
3203 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3204 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
3205 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
3206 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
3207 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
3208 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
3210 2011-06-14 Ben Konrath <ben@bagu.org>
3212 Use cast_dynamic method to determine the libglom LayoutItem type.
3214 This is better than finding the LayoutItem type by using the string
3215 returned from the get_part_type_name() method.
3217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3219 2011-06-14 Ben Konrath <ben@bagu.org>
3221 Add method names to log entries in the servlet.
3223 This helps when tracking down deployment problems.
3225 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3227 2011-06-14 Ben Konrath <ben@bagu.org>
3229 Add data to the DetailsView using a hard-coded primary key value.
3231 The layout and functionality of the DetailsView is not complete. This
3232 is just a checkpoint so the patch doesn't get too big.
3234 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3235 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3236 Add getDetailsData() servlet method.
3237 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3238 Add RPC to getDetailsData(). Change the way the LayoutGroups and
3239 LayoutFields are added to the DetailsView.
3240 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3241 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
3242 Add setData() method. Change addLayoutGroup() and addLayoutField() to
3243 take the string for the title instead of the object.
3244 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3245 Add implementation getDetailsData() along with&