1 2012-01-22 Murray Cumming <murrayc@murrayc.com>
3 ConfiguredDocument: Rename the localedID private member variable.
5 2012-01-20 Murray Cumming <murrayc@murrayc.com>
7 Build a source tarball with mvn assembly:single
9 * assembly.xml: Add this file.
10 * pom.xml: Use the maven-assembly-plugin and tell it to use
11 our assembly.xml file.
13 2012-01-19 Murray Cumming <murrayc@murrayc.com>
15 OnlineGlomServiceImpl: Get .glom files recursively.
17 * pom.xml: Depend on commons-io from org.apache.commons.
18 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
19 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
20 files recursively, and with the easier filter for the extension.
21 Use org.apache.commons.io.FilenameUtils.removeExtension() to
22 simplify that code too.
24 2012-01-19 Murray Cumming <murrayc@murrayc.com>
26 README: Mention that you must install java-libglom packages separately.
28 But then it works, because java-libglom is now in the central maven
31 2012-01-18 Murray Cumming <murrayc@murrayc.com>
33 locales drop-down: Show the correct selected locale when the URL changes.
35 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
36 .java: setPlace(): Move some code into fillView().
38 2012-01-18 Murray Cumming <murrayc@murrayc.com>
40 locales drop-down: Do not lose the primary key.
42 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
43 start(): onLocaleChange(): Pass the current primary key value,
44 instead of an empty value.
46 2012-01-18 Murray Cumming <murrayc@murrayc.com>
48 locales drop-down: Do not lose the drop-down selection.
50 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
51 .java (TableSelectionActivity.fillView): Set the selected locale
52 after changing the drop-down items (though we do not really need
53 to change them just because the locale changes.)
55 2012-01-18 Murray Cumming <murrayc@murrayc.com>
57 locales drop-down: Change the tables list when this changes.
59 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
60 .java: TableSelectionActivity.start(): Move the async table titles
61 retrieval into a private fillView() method and also call this when
62 the chosen locale changes.
63 Note that the document title is not actually translatable yet, but
64 that is a problem that I should fix soon in libglom.
66 2012-01-18 Murray Cumming <murrayc@murrayc.com>
68 Improve the placement of the locales drop-down.
70 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
71 Put the title and locales drop-down in a div (gwt.FlowTable).
72 * src/main/webapp/style.css: Add magic css properties to make this work.
73 Also remove the left margin from the title so that it lines up with the
76 2012-01-18 Murray Cumming <murrayc@murrayc.com>
78 locales selector: Show human-readable locale titles.
80 * src/main/java/org/glom/web/server/ConfiguredDocument.java
81 getDocumentInfo(): Use java.util.Locale to show a real title of
82 each locale, in the locale's own language.
84 2012-01-17 Murray Cumming <murrayc@murrayc.com>
86 Add a language/locale selector drop-down.
88 * src/main/java/org/glom/web/shared/DocumentInfo.java:
89 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
90 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
91 getDocumentInfo(): Store the available Locales in the DocumentInfo.
92 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
93 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
94 Add a ListBox to show the available locales. Add getLocaleSelector(),
95 setLocaleList(), getSelectedLocale(), setSelectedLocale().
96 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
97 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
98 java: Add these classes.
99 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
100 start(): Fill the locales ListBox. Handle its change event, firing a
102 setPlace(): Show the selected locale as specified by the URL token.
103 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
104 * src/main/java/org/glom/web/client/activity/ListActivity.java:
105 Handle LocaleChangeEvent, going to a new *Place with that locale.
107 The placement of the ListBox is not pretty, and it currently uses the ID
108 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
112 2012-01-17 Murray Cumming <murrayc@murrayc.com>
114 Search box: Show the search text from the URL token.
116 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
117 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
118 Add setQuickFindText().
119 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
120 .java: setPlace(): Store the queryText if the place is a ListPlace,
121 and call TableSelectionView.setQuickFindText().
123 2012-01-17 Murray Cumming <murrayc@murrayc.com>
125 Allow use of translations via, for instance, &lang=de in the URL.
127 * pom.xml: Use the unstable java-libglom 1.21 version.
129 * src/main/java/org/glom/web/client/OnlineGlomService.java:
130 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
131 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
132 init(): Instead of calling TranslatableItem.set_current_locale()
133 (now removed), call ConfiguredDocument.setDefaultLocaleID().
134 However, this is only for default locales, which are not needed to
135 change the locale in the URL.
136 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
137 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
138 getSortedRelatedListData(): Add a localeID parameter, so we can get the
139 layout for a particular locale.
140 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
141 Add get/setDefaultLocaleID().
142 getDocumentInfo(), getListViewData(), getRelatedListData(),
143 getDetailsLayoutGroup(), getListViewLayoutGroup(),
144 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
145 localeID parameter, so we can get the layout for a particular locale.
147 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
148 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
149 * src/main/java/org/glom/web/client/place/ListPlace.java:
150 Parse and construct a lang parameter too.
152 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
153 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
154 passed to subsequent methods and constructors.
155 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
156 * src/main/java/org/glom/web/client/activity/ListActivity.java:
157 Store the localeID from the *Place and pass it to other constructors
158 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
160 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
161 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
162 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
163 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
164 * src/main/java/org/glom/web/client/ui/ListView.java:
165 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
166 Take localeID parameters and pass them to subsequent constructors and
167 methods, so that the layout is always retrieved for that locale.
169 This is rather repetitive.
171 Note that "" means the original (default) locale of the Glom document,
172 which is usually English.
174 2012-01-17 Murray Cumming <murrayc@murrayc.com>
176 Documents: Remove final keyword to fix startup configuration.
178 * src/main/java/org/glom/web/shared/Documents.java: Remove the
179 final keywords on the private member variables because that breaks
180 the startup, apparently (there are warnings) because it stops them
181 from being serialized. I added these in the previous commit.
183 2012-01-13 Murray Cumming <murrayc@murrayc.com>
185 Documents: Add some final keywords.
187 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
190 2012-01-13 Murray Cumming <murrayc@murrayc.com>
192 OnlineGlomServiceImpl: Add to overview comments.
194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
195 Note that this is where all the document are loaded. They are not
196 loaded freshly for each page.
198 2012-01-12 Murray Cumming <murrayc@murrayc.com>
202 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
203 Add a TextBox for the text of a quick find.
204 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
206 setBackLink(): Add a String quickFind parameter.
207 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
208 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
209 to the base interface, because that is how TableSelectionViewImpl is used.
210 * src/main/webapp/style.css: Add style for the search box and its label.
212 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
213 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
214 Add these files, based on the existing TableChangeEvent and
215 TableChangeEventHandlers.
216 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
217 start(): Handle QuickFindChangeEvent, passing its quickFind text to
218 a ListPlace() that the user should be taken to.
219 * src/main/java/org/glom/web/client/activity/ListActivity.java
220 start(): Handle it here too and adapt the TableChangeEvent handler to
221 pass the extra "" quickFind parameter to ListPlace.
222 * src/main/java/org/glom/web/client/place/ListPlace.java:
223 Constructor: Take an extra String quickFind parameter and store it,
224 returning it from a new getQuickFind() method.
225 getToken(): Put the quickFind text in the URL token.
226 getPlace(): Parse the quickFind text from the URL token.
227 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
228 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
229 ListPlace constructor.
230 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
231 .java: start(): Add a Change handler for the TableSelectionView's
232 TextBox (via its base HasChangeHandlers interface), firing the new
233 QuickFindChangeEvent.
234 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
235 pass the extra "" quickFind parameter.
237 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
238 setCellTable(): Add a String quickFind parameter and pass it to
239 the ListViewTable() constructor.
240 * src/main/java/org/glom/web/client/ui/ListView.java: Change
241 setCellTable() in the base interface, because that is how ListViewImpl
244 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
245 Add a String quickFind member variable.
246 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
247 Constructor: Add a String quickFind parameter, storing it in the
248 base ListTable's member variable.
249 onRangeChanged(): Pass quickFind to the
250 OnlineGlomServiceAsync.getSortedListViewData() and
251 OnlineGlomServiceAsync.getListViewData() methods.
253 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
254 getListViewData(), getSortedListViewData(): Add a String quickFind
255 parameter, passing it to ConfiguredDocument.getListViewData().
256 * src/main/java/org/glom/web/client/OnlineGlomService.java:
257 Change getListViewData(), getSortedListViewData() in the base interface,
258 because that is how OnlineGlomServiceImpl is used, via this:
259 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
260 Change getListViewData(), getSortedListViewData() here too.
261 This class can apparently be used to asynchronously call methods on
262 OnlineGlomService, and GWT seems to implement that after recognizing
263 just the *Async name convention and the extra AsyncCallback parameters.
265 * src/main/java/org/glom/web/server/ConfiguredDocument.java
266 getListViewData(): Add a String quickFind parameter, and pass it to
267 ListViewDBAccess.getData().
268 * src/main/java/org/glom/web/server/database/ListDBAccess.java
269 getListData(): Add a String quickFind parameter and pass it to
271 getSelectQuery(): Add a String quickFind parameter.
272 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
273 getSelectQuery(): Add a String quickFind parameter and use it with
274 Glom.get_find_where_clause_quick() to pass a where_clause to
275 Glom.build_sql_select_with_where_clause(), to actually filter the
277 getData(): Add a String quickFind parameter, passing it to getListData().
278 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
279 va: getData(): Pass an empty string to getListData() for the
282 2012-01-12 Murray Cumming <murrayc@murrayc.com>
284 ListTable: Minor change.
286 * src/main/java/org/glom/web/client/ui/list/ListTable.java
287 createCellTable(): Make this protected instead of public.
289 2012-01-12 Murray Cumming <murrayc@murrayc.com>
291 Many files: Use final for the parameters and use the @override attribute.
293 2012-01-22 Ben Konrath <ben@bagu.org>
295 Add anchor links for single line text that starts with http, ftp and www.
299 2012-01-22 Ben Konrath <ben@bagu.org>
301 Add ellipsis to single line text in details view.
305 2012-01-04 Murray Cumming <murrayc@murrayc.com>
307 Remove all javadoc author tags.
309 Because they are awkward and meaningless when many people touch
311 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
313 2012-01-04 Murray Cumming <murrayc@murrayc.com>
315 Revert the COPYING.LESSER to COPYING rename.
317 Apparently both should be there if it is LGPL.
319 2012-01-03 Murray Cumming <murrayc@murrayc.com>
321 *View: Remove unused imports.
323 * src/main/java/org/glom/web/client/ui/DetailsView.java:
324 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
325 * src/main/java/org/glom/web/client/ui/ListView.java:
326 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
327 Remove unused imports, as suggested by Eclipse.
329 2012-01-02 Murray Cumming <murrayc@murrayc.com>
331 Move the *View::Presenter types, and some API into one base View.
333 * src/main/java/org/glom/web/client/ui/DetailsView.java:
334 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
335 * src/main/java/org/glom/web/client/ui/ListView.java:
336 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
337 Presenter, setPresenter() and clear() into a shared base interface,
338 to avoid the unnecessary duplicate Presenter types and to more clearly
339 show how the *Views share the same structure, even if they are not
340 used polymorphically.
342 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
343 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
345 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
346 * src/main/java/org/glom/web/client/activity/ListActivity.java:
347 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
349 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
352 Feel free to revert this if there is a good reason for the duplicate
355 2012-01-02 Murray Cumming <murrayc@murrayc.com>
357 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
359 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
360 a class member instead of a local variable in the method.
361 This lets us use it to get the view instances, for use in tests.
362 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
363 beforeOnlineGlom(): Test some more details of the initial view.
364 Again, this is not very useful.
366 To really test gwt-glom we will need to start a local postgresql
367 instance with local data, like the Glom tests in C++.
369 2012-01-02 Murray Cumming <murrayc@murrayc.com>
371 pom.xml: Mention the LGPL license.
373 * pom.xml: Add a licenses section.
374 * COPYING.LESSER: Move this to COPYING, which
375 previously contained the GPL. But gwt-glom is all LGPL.
377 2012-01-02 Murray Cumming <murrayc@murrayc.com>
379 Add project information to README and pom.xml.
381 * README: Add a brief description and mention some mvn
383 * pom.xml: This extra information shows up in mvn site
386 2011-01-02 Murray Cumming <murrayc@murrayc.com>
388 Use the latest java-libglom version.
390 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
392 2012-01-01 Murray Cumming <murrayc@murrayc.com>
394 GwtTestOnlineGlom: Test a little more.
396 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
397 protected rather than private, as suggested by the gwt-test-utils
399 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
400 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
401 Test the initial visibility of the panels.
403 However, this is not a very useful test.
404 And I wonder how we should generally test using this idea for an
405 activity/places app like ours where the real changes happen implicitly
406 based on the history token/URL.
408 2012-01-01 Murray Cumming <murrayc@murrayc.com>
410 Slight modification to *Mapper comments.
412 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
414 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
416 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
418 Remove comments mentioning GIN because they are just copied from
419 the example code and are apparently not helpful:
420 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
421 Also change the mention of a class that is only in the example code.
423 2012-01-01 Murray Cumming <murrayc@murrayc.com>
425 GwtTestOnlineGlom test: Minor changes.
427 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
428 Avoid the long qualified class name and modify the comment
429 because it is now obvious to me that the mocked class is the only
430 custom one created via GWT.create().
432 2012-01-01 Murray Cumming <murrayc@murrayc.com>
434 Tests: Added the beginnings of a test using gwt-test-utils.
436 * pom.xml: Add dependencies on gwt-test-utils and easymock.
437 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
438 which tells gwt-test-utils what class will be tested.
439 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
440 Add a simple (but empty) test case. One class, used by the OnlineGlom
441 class, is mocked so that it can be created. However, I am not sure
442 why only this class needs to be mocked.
444 Note that mockito seems more popular, and clearer, than easymock,
445 but I have not got that working yet. It might be a matter of the
448 This test is run during mvn integration-test.
450 2011-12-31 Murray Cumming <murrayc@murrayc.com>
452 Tests: Use junit4-style syntax instead of junit3-style.
454 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
455 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
456 * src/test/java/org/glom/web/shared/DataItemTest.java:
457 Use the @Test annotation rather than relying on the test*() prefix.
458 Also no longer implement TestCase, to avoid triggering support for
459 the junit3-way, which stops the annotations from working.
460 Change the imports from import junit.framework.* to
461 import org.junit.*, which is apparently the new way.
463 2011-12-31 Murray Cumming <murrayc@murrayc.com>
465 Added a test for ListPlace token parsing and creation.
467 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
468 This is much the same as DetailsPlaceTest.
470 I wonder how we could test the other parts of the *Place API.
472 2011-12-30 Murray Cumming <murrayc@murrayc.com>
474 DetailsPlace test: Also test getToken() and recreation via getPlace().
476 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
477 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
478 recreate it, testing the recreated DetailsPlace for the same parameter
481 2011-12-30 Murray Cumming <murrayc@murrayc.com>
483 Use the surefire-report plugin.
485 * pom.xml: This generates a HTML report about the tests in
486 target/site/surefire-report.html
487 when you do mvn surefire-report:report. It seems to be popular/normal.
489 2011-12-30 Murray Cumming <murrayc@murrayc.com>
491 Added a test for DetailsPlace.
493 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
494 Test the getPlace() token parsing.
496 2011-12-30 Murray Cumming <murrayc@murrayc.com>
498 Added a first unit test.
500 * pom.xml: Add a test goal, and a dependency on junit in that scope.
501 * src/test/java/org/glom/web/shared/DataItemTest.java:
502 This is a silly test but it is just to get things started. Note that
503 maven/junit finds the test because it looks in src/test by default.
505 2011-12-22 Ben Konrath <ben@bagu.org>
507 Change charsetName to "UTF-8" when replacing line breaks.
509 JavaScript requires the charsetName to be "UTF-8". CharsetName values
510 that work in Java (such as "UTF8") will not work when compiled to
513 This fixes a problem with multi-line details view fields that have hard
514 line breaks. The "License Text" field on this page demonstrates the
517 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
519 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
521 2011-12-22 Ben Konrath <ben@bagu.org>
523 Fix another bug with related list navigation.
525 I've tested all the navigation buttons in all of the related lists
526 so things should be good now.
528 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
530 2011-12-22 Ben Konrath <ben@bagu.org>
532 Fix a crasher when refreshing the list view with the default table.
534 This crash will also happen when loading the list view with the default
535 table from a link or bookmark.
537 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
538 to the main document selection page when the document id hasn't been
540 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
541 the main document selection page when the document id hasn't been
543 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
544 values for the details place when the document id hasn't been set.
545 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
546 values for the list place when the document id hasn't been set.
548 2011-12-21 Ben Konrath <ben@bagu.org>
550 Protect against NPE when glom.document.locale is not in config.
552 This patch protects against an NPE when glom.document.locale is not in
553 the config file. This NPE will also happen if glom.document.locale is
556 The patch also updates the error message to display the class name when
557 the getMessage() returns null. This was happening when the NPE was
558 thrown and I had "Configuration Error: null". If an NPE is encountered
559 with this patch, "Configuration Error: NullPointerException " will be
562 This commit closes this bug:
564 https://bugzilla.gnome.org/show_bug.cgi?id=666669
566 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
568 2011-12-20 Murray Cumming <murrayc@murrayc.com>
570 Rename onlineglom.properties to onlineglom.properties.sample.
572 * src/main/resources/onlineglom.properties: Rename to:
573 * src/main/resources/onlineglom.properties.sample:
574 * src/main/resources/README: And add this file explaining that people
575 should rename it back when deploying.
577 2011-12-20 Murray Cumming <murrayc@murrayc.com>
579 Allow choosing the translation in the .properties file.
581 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
582 init(): Read a glom.document.locale value from the configuration file
583 and call Glom's TransatableItem::set_current_locale() method.
584 * src/main/resources/onlineglom.properties: Add a commented-out
585 example of this new setting.
587 It would be better to add &lang=de_DE to the URL, but the current
588 libglom API does not allow us to do this easily. I am working on that.
590 2011-12-19 Murray Cumming <murrayc@murrayc.com>
592 Avoid a crash in parsing of token parameters.
594 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
595 ava: getTokenParams(): Do not crash if a parameter has a key but no
596 value, and ignore parameters with neither.
598 2011-12-17 Murray Cumming <murrayc@murayc.com>
600 History token building/handling: Improve use of token parameters.
602 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
603 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
604 and buildParamsToken(HashMap), for use by derived classes.
605 Make the separator private because it is no longer be needed.
606 * src/main/java/org/glom/web/client/place/DetailsPlace.java
607 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
608 instead of manual string concatenation.
609 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
610 of hardcoded indices and awkward splitting code.
611 * src/main/java/org/glom/web/client/place/ListPlace.java
612 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
613 instead of manual string concatenation.
614 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
615 of hardcoded indices and awkward splitting code.
616 This should fix bug #666420
618 2011-12-16 Murray Cumming <murrayc@murrayc.com>
620 Fix a Navgiation->Navigation typo in the code.
622 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
623 Rename processNavgiation() to processNavigation().
625 2011-12-16 Murray Cumming <murrayc@murrayc.com>
627 Fix a seperator->separator typo in the code.
629 * src/main/java/org/glom/web/client/place/DetailsPlace.java
630 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
631 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
634 2011-12-15 Ben Konrath <ben@bagu.org>
636 Cleanup some comments.
638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
640 2011-12-14 Ben Konrath <ben@bagu.org>
642 Replace \n with <br/> for multiline text in the details view.
644 Vertical scrollbars are added when needed as well.
646 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
648 2011-12-14 Ben Konrath <ben@bagu.org>
650 Specify the font for document selection links.
652 * src/main/webapp/style.css:
654 2011-12-14 Ben Konrath <ben@bagu.org>
656 Fix bouncy CellTable while paging.
658 This doesn't currently work with related list tables in unselected
661 * src/main/java/org/glom/web/client/ui/list/ListTable.java
663 2011-12-14 Ben Konrath <ben@bagu.org>
665 Revamp the appearance of the document selection page.
667 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
668 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
669 * src/main/webapp/style.css:
671 2011-12-13 Ben Konrath <ben@bagu.org>
673 Set navigation button column to the smallest size possible.
675 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
677 2011-12-13 Ben Konrath <ben@bagu.org>
679 Change OpenButton nomenclature to NavigationButton.
681 Using NavigtionButton makes things more generic. Classes, methods and
682 variables have been changed.
684 This is a rename-only refactor.
686 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
687 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
688 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
689 Renamed from OpenButtonCell.
690 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
691 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
692 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
694 2011-12-12 Ben Konrath <ben@bagu.org>
696 Remove unnecessary String argument in RelatedListTable and ListViewTable.
698 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
699 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
700 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
701 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
703 2011-12-12 Ben Konrath <ben@bagu.org>
705 Update variable names and comments.
707 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
708 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
710 2011-12-12 Ben Konrath <ben@bagu.org>
712 Properly initialize numNonEmptyRows variable to zero.
714 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
715 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
717 2011-12-05 Ben Konrath <ben@bagu.org>
719 Add latest mockup with HTML tables.
721 Features of this mockup:
723 -> HTML table for flowtable
724 -> HTML table for flowtable column
725 -> Example of how related lists would look
726 -> Not using text entries for data items
728 The current version of Online Glom doesn't use HTML tables for the
731 This mockup has been sent to the glom-devel mailing list but it's good
732 to have it here as well.
734 * mockups/details-view-html-tables.html:
736 2011-12-05 Ben Konrath <ben@bagu.org>
738 Remove unnecessary getPrimaryKeyField() method.
740 getPrimaryKeyFieldForTable(String) has been renamed to
741 getPrimaryKeyField(String).
743 * src/main/java/org/glom/web/server/database/DBAccess.java:
744 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
745 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
747 2011-12-05 Ben Konrath <ben@bagu.org>
749 Add string representation of TypedDataItem value to conversion error message.
751 * src/main/java/org/glom/web/server/Utils.java: Logging the error
752 message was extracted into its own method to avoid duplication.
754 2011-12-05 Ben Konrath <ben@bagu.org>
756 Add type checking to navigation primary key value creation.
758 Create navigation primary key only if the expected type from the Glom
759 document matches the type returned by the SQL query.
761 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
763 2011-12-05 Ben Konrath <ben@bagu.org>
765 Rename a couple of variables in RelatedListNavigation.
767 This is a rename-only refactor.
769 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
771 2011-12-05 Ben Konrath <ben@bagu.org>
773 Move getListLayoutGroup() into getListViewLayoutGroup().
775 This removes getListLayoutGroup(). It was only being called by
776 getListViewLayoutGroup().
778 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
780 2011-12-05 Ben Konrath <ben@bagu.org>
782 Remove check for LayoutItem_Portal in list table method.
784 This check is no longer necessary because the method isn't being used
785 to create the LayoutItemPortal DTO.
787 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
789 2011-12-05 Ben Konrath <ben@bagu.org>
791 Properly support related list navigation.
793 Navigation from the "Repository Analyzer -> Package Scans ->
794 Dependencies" related table wasn't working because the primary key for
795 related tables wasn't being set properly. This commit fixes the
798 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
799 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
800 doesn't set the primary key properly for related list tables.
801 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
802 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
803 useful for getting the primary key for list view tables and for related
805 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
806 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
807 Move code to set the primary key for the table from the abstract
808 ListDBAccess class to ListViewDBAccess as it's only correct for list
810 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
811 Properly add primary key to related list tables.
813 2011-12-02 Ben Konrath <ben@bagu.org>
815 Properly set the horizontal alignment of fields.
817 This fix is for both the list tables and the details view.
819 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
820 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
821 to set the horizontal alignment of fields.
823 2011-12-02 Ben Konrath <ben@bagu.org>
825 Display currency codes in the details view.
827 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
829 2011-12-02 Ben Konrath <ben@bagu.org>
831 Avoid duplicate JNI call.
833 JNI is not as efficient as pure Java and this is an easy (and small)
836 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
837 Use previously retrieved value for whereClauseToTableName instead of
840 2011-12-02 Ben Konrath <ben@bagu.org>
842 Rename a couple of variables in RelatedListNavigation.
844 This is a rename-only refactor.
846 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
848 2011-12-02 Ben Konrath <ben@bagu.org>
850 Indicate clearly that a mismatched primary key type is a bug.
852 * src/main/java/org/glom/web/server/Utils.java: Change log level from
853 warning to error. Add 'This is a bug.' to message.
855 2011-12-02 Ben Konrath <ben@bagu.org>
857 Update / fix some comments.
859 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
861 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
863 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
864 Fix comments. Add some TODOs.
866 2011-12-02 Ben Konrath <ben@bagu.org>
868 Enable navigation to details view with string primary key from related list.
870 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
871 Create a text primary key value when return type of result is
872 java.sql.Types.VARCHAR.
874 2011-12-02 Ben Konrath <ben@bagu.org>
876 Use checkboxes for booleans in the details view.
878 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
880 2011-12-01 Ben Konrath <ben@bagu.org>
882 Improve performance of related list height calculation.
884 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
885 Put code to calculate the expected height in a static initializer so
886 that that it's only called once.
888 2011-12-01 Ben Konrath <ben@bagu.org>
890 Show related list tables in notebooks (again).
892 Calculate the height of the related list tables so the Notebook can be
893 set the correct height. The height of the related list table is also needed by
894 FlowTable to be able decide how to create the layout.
896 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
897 and set the Portal height based on the height of the related list
898 table and the Portal container.
899 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
900 Add method to calculate the height of the related list tables.
901 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
902 * src/main/webapp/style.css: Add css class for Pager. This is needed to
903 calculate the height of the Pager widget.
905 2011-12-01 Ben Konrath <ben@bagu.org>
907 Use CellTable API for table property instead of setting style on Element.
909 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
911 2011-12-01 Ben Konrath <ben@bagu.org>
913 Make ListViewTable and RelatedListTable a consistent height.
915 The tables are now a consistent height regardless of the contents of
916 the table. A hidden button is added to empty rows to ensure that the
917 height of these rows will match the height of rows with data.
919 A navigation button column is now added to every table. The width of
920 the navigation column is set to 0px when a RelatedListTable shouldn't
921 have navigation buttons. This maintains the a consistent row height in
922 tables that don't show the navigation buttons.
924 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
925 navigation column when not needed.
926 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
927 arguments for navigation button to constructor of ListViewTable.
928 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
929 hidden button for empty data rows.
930 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
931 arguments for navigation button to constructor.
932 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
933 create navigation buttons. Add hideNavigationButtons() method.
934 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
935 arguments for navigation button to constructor.
937 2011-12-01 Ben Konrath <ben@bagu.org>
939 Use 'visibility: hidden' in Utils.getWidgetHeight().
941 This is better choice because hidden elements are invisible, don't
942 respond to events and are not part of the tab order. They will,
943 however, take up space which is required to be able to calculate the
944 height of the widget.
946 * src/main/java/org/glom/web/client/Utils.java:
948 2011-12-01 Ben Konrath <ben@bagu.org>
950 Use Utils.getWidgetHeight() in FlowTable.
952 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
954 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
956 2011-12-01 Ben Konrath <ben@bagu.org>
958 Put the details css class name on the correct table column.
960 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
962 2011-11-30 Ben Konrath <ben@bagu.org>
964 Update for java-libglom API change.
966 The getters and setters on FieldFormatting and NumericFormat were
967 changed to remove the 'M'.
969 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
971 2011-11-29 Ben Konrath <ben@bagu.org>
973 Only allow RelatedListTables in Portals.
975 * src/main/java/org/glom/web/client/ui/details/Portal.java:
977 2011-11-29 Ben Konrath <ben@bagu.org>
979 Only create a contents panel for Portals when title is being set.
981 * src/main/java/org/glom/web/client/ui/details/Portal.java:
983 2011-11-29 Ben Konrath <ben@bagu.org>
985 Set TabLayoutPanel height based on calculated height its widgets.
987 This is a potential fix for this bug:
989 https://bugzilla.gnome.org/show_bug.cgi?id=665133
991 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
993 2011-11-29 Ben Konrath <ben@bagu.org>
995 Align details field labels and data with the Open buttons.
997 * src/main/webapp/style.css:
999 2011-11-29 Ben Konrath <ben@bagu.org>
1001 Remove unnecessary <div> in the Notebook widget.
1003 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1004 method to get container FlowPanel (<div>).
1005 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1006 initWidget() method directly on the TabLayoutPanel widget instead of
1007 Group's container widget.
1009 2011-11-29 Ben Konrath <ben@bagu.org>
1011 Don't add group titles for Portals in Notebooks.
1013 This reverts the previous patch and fixes a bug I introduced with
1014 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1016 * src/main/java/org/glom/web/client/ui/details/Group.java:
1017 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1019 2011-11-28 Ben Konrath <ben@bagu.org>
1021 Remove unused boolean argument in Portal constructor.
1023 Just a code cleanup.
1025 * src/main/java/org/glom/web/client/ui/details/Group.java:
1026 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1028 2011-11-28 Ben Konrath <ben@bagu.org>
1030 Remove hack for glom 1.18 style glom files.
1032 * src/main/java/org/glom/web/client/ui/details/Group.java:
1033 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1034 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1036 2011-11-28 Ben Konrath <ben@bagu.org>
1038 Use Gda Value version of primary key to log result too large error.
1040 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1042 2011-11-28 Ben Konrath <ben@bagu.org>
1044 Don't use TypedDataItem.getText() for Unknown types from the URL.
1046 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1047 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1048 instead of getText().
1049 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1050 String field and getUnknown() method.
1052 2011-11-28 Ben Konrath <ben@bagu.org>
1054 Log an error message when the java-libglom .so is not present.
1056 The error message was being set in the exception but not logged.
1058 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1060 2011-11-28 Ben Konrath <ben@bagu.org>
1062 Ignore LayoutItem_CalendarPortals.
1064 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1065 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1067 2011-11-28 Ben Konrath <ben@bagu.org>
1069 Extract method for creating the LayoutItemPortal DTO.
1071 Just breaking the code up into smaller chunks.
1073 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1075 2011-11-28 Ben Konrath <ben@bagu.org>
1079 This should have been added with the refactor. Oops!
1081 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1083 2011-11-28 Ben Konrath <ben@bagu.org>
1085 Create primary key value from URL string using type from Glom document.
1087 See this bug, comments 19 - 25:
1089 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1091 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1092 create a TypeDataItem for the primary key here when loading from a
1093 URL. Show the same string for the primary key value as was received
1094 from the URL string (when loading from a URL).
1095 * src/main/java/org/glom/web/server/Utils.java: Update method for
1096 creating the Gda Value from the TypeDataItem to properly deal with
1097 creating a Gda Value based on the Glom document type for the primary
1098 key value string when loading from a URL.
1099 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1100 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1101 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1102 Update for changed method name.
1104 2011-11-27 Ben Konrath <ben@bagu.org>
1106 Rename PrimaryKeyItem to TypedDataItem.
1108 The name PrimaryKeyItem suggests what the class should be used for.
1109 TypedDataItem is a neutral name that describes the class better.
1111 This is a rename-only refactor.
1113 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1114 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1115 * src/main/java/org/glom/web/client/Utils.java:
1116 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1117 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1118 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1119 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1120 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1121 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1122 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1123 * src/main/java/org/glom/web/server/Utils.java:
1124 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1125 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1126 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1127 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1129 2011-11-25 Ben Konrath <ben@bagu.org>
1131 Improve Gda Value conversion from PrimaryKeyItem.
1133 The value from the PrimaryKeyItem is only used if its type match the
1134 type from the glom document.
1136 * src/main/java/org/glom/web/server/Utils.java:
1138 2011-11-25 Ben Konrath <ben@bagu.org>
1140 Manually check if the java-liblgom .so is visible to the JVM.
1142 It seems that Tomcat has problems when a static initializer throws an
1143 exception. This check is done before the first method call into
1144 java-libglom so that execution doesn't continue if the .so is not
1147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1149 2011-11-25 Ben Konrath <ben@bagu.org>
1151 Improve browser configuration error messages.
1155 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1157 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1158 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1159 getConfigurationErrorMessage() method.
1160 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1161 Get and display a specific configuration error message when no Glom
1162 documents are found.
1163 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1164 Implement getConfigurationErrorMessage() method. Surround configuration
1165 code in the init() method with a try/catch block. This allows the
1166 errors to be caught while keeping the servlet available to retrieve the
1167 configuration error message.
1169 2011-11-25 Ben Konrath <ben@bagu.org>
1171 Don't use Strings to hold primary key values.
1173 The primary key values are now held in a new data object
1174 (PrimaryKeyItem) that holds type information and the primary key value
1175 using the correct type.
1177 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1178 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1179 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1180 PrimaryKeyItem instead of String to hold the primary key value.
1181 * src/main/java/org/glom/web/client/Utils.java: Remove
1182 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1183 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1184 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1185 PrimaryKeyItem instead of String to hold the primary key value. Load
1186 document selection page when the documentID has not been set correctly.
1187 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1188 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1190 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1191 Return empty string for URL instead of "null".
1192 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1193 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1194 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1195 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1196 PrimaryKeyItem instead of String to hold primary key values.
1197 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1198 PrimaryKeyValue to a Gda Value.
1199 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1200 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1201 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1202 Replace temporary database access code that uses the PrimaryKeyValue to
1203 Gda Value conversion.
1204 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1205 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1206 PrimaryKeyItem instead of String.
1207 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1208 hold primary key values.
1210 2011-11-24 Ben Konrath <ben@bagu.org>
1212 Use newly added java-libglom API to create queries.
1214 This isn't finished. I still need to stop using Strings for primary key
1215 values in the client code.
1217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1218 libglom to use fake connections so that retrieving the query string will
1220 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1221 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1222 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1223 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1224 Use the newly added libglom sql methods and classes to create the
1225 query. Add temporary hack to convert primary value strings to Gda
1228 2011-11-23 Ben Konrath <ben@bagu.org>
1230 Don't explicitly set the height of Portals.
1232 See comments 6 - 10 of this bug for details:
1234 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1236 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1238 2011-11-23 Ben Konrath <ben@bagu.org>
1240 Use an HTML table instead of CSS for the FlowTable layout.
1242 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1243 GWT's FlexTable to implement the FlowTable.
1244 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1246 2011-11-18 Ben Konrath <ben@bagu.org>
1248 Add boolean example to HTML table mockup.
1250 * mockups/details-view-html-tables-text-entries.html:
1252 2011-11-17 Ben Konrath <ben@bagu.org>
1254 Ensure the pager buttons are always visible for related lists.
1256 To accomplish this, I've turned off text wrapping in the list view and
1257 related list tables for both the header and data text. The related list
1258 table now has a fixed layout so the it doesn't overflow its container.
1259 This is required to ensure that the cell text is clipped when it
1260 overflows the cell and an ellipsis is added to the right side of the
1261 cell when text is clipped.
1263 A fixed table layout for the related list table in the details view
1264 seems what we want for the details view anyway, so the side-effect is
1267 The ellipsis will only be displayed in Firefox >= 7.
1271 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1273 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1274 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1275 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1277 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1278 Set the 'table-layout: fixed' CSS property to the related list table.
1279 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1280 'white-space: nowrap;' CSS property on both the list view and the
1281 related list tables.
1283 2011-11-16 Ben Konrath <ben@bagu.org>
1285 Rework the fix for empty notebook tab labels.
1287 Setting the empty group titles with its name caused problems for the
1288 details layout. Instead of using libglom's
1289 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1290 to the client when the title is empty. This allows the Notebook to use
1291 the name when the title is empty without affecting anything else.
1293 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1294 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1296 2011-11-16 Ben Konrath <ben@bagu.org>
1298 Set group titles with name when title is empty.
1300 This fixes a problem with an empty notebook tab label in the Lesson
1301 Planner document. The forth tab in the notebook should be "Internet":
1303 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1305 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1306 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1309 2011-11-16 Ben Konrath <ben@bagu.org>
1311 Remove whitespace from the configured username properties.
1313 This assumes that usernames won't have whitespace at the beginning
1314 or end. But I think this is a reasonable assumption.
1316 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1317 String.trim() to remove the whitespace from the username properties.
1319 2011-11-15 Ben Konrath <ben@bagu.org>
1321 Add details view mockup with HTML tables and text entries.
1323 This is from the attachment on this bug:
1325 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1327 * mockups/details-view-html-tables-text-entries.html:
1329 2011-11-15 Ben Konrath <ben@bagu.org>
1331 Add space between the columns of the flow table.
1335 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1337 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1338 space between columns in the flow table.
1340 2011-11-15 Ben Konrath <ben@bagu.org>
1342 Add backup files to the .gitignore.
1344 * .gitignore: Ignore files that end with ~.
1346 2011-11-09 Ben Konrath <ben@bagu.org>
1348 Use latest release of gwt-log.
1350 Gwt-log releases are now being submitted to the maven central
1351 repository so manual installation of the jar is no longer required.
1353 * pom.xml: Update version and groupId of gwt-log dependency.
1355 2011-10-31 Ben Konrath <ben@bagu.org>
1357 Don't use GWT numeric formatting to override the glom currency formatting.
1359 Currencies are now displayed like they are in Glom. See this bug:
1361 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1363 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1365 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1366 currency code to constructor and set it when the cell is rendered.
1367 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1368 currency code to the constructor of the NumericCell.
1370 2011-10-27 Ben Konrath <ben@bagu.org>
1372 Require the latest release of java-libglom (1.17.4).
1376 2011-10-26 Ben Konrath <ben@bagu.org>
1378 Add style to Notebook that matches current theme.
1380 It's not the best style in the world but it's better than the default.
1382 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1383 padding at the bottom of the child widgets.
1384 * src/main/webapp/style.css: Add style for the Notebook.
1386 2011-10-26 Ben Konrath <ben@bagu.org>
1388 Move servlet initialization code to overridden init method.
1390 This is half of the solution to getting proper error messages
1391 displayed when configuration errors occur. Here's the relevant bug:
1393 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1395 The rest of the solution involves surrounding the init method with a
1396 try/catch block and setting a global variable with the error /
1397 exception. A new async method should be created to retrieve and display
1398 the error message / exception.
1400 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1401 code from constructor to init method adding exceptions as needed.
1403 2011-10-26 Ben Konrath <ben@bagu.org>
1405 Add script to monitor and restart tomcat if required.
1407 * utils/check-and-recover-tomcat.py: New file.
1409 2011-10-26 Ben Konrath <ben@bagu.org>
1411 Display the correct number of data items in the pager.
1415 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1417 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1418 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1419 The implementation is the same for both tables: Keep track of the
1420 number of non-empty rows and fire and RowCountChangeEvent after the data has
1422 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1423 custom Pager class that subclasses SimplePager to handle displaying
1424 the correct number when empty rows have been added.
1426 2011-10-26 Ben Konrath <ben@bagu.org>
1428 Correct error in previous commit.
1430 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1431 eventBus parameter from listView.setCellTable().
1433 2011-10-26 Ben Konrath <ben@bagu.org>
1435 Fix error in TODO comment.
1437 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1439 2011-10-24 Ben Konrath <ben@bagu.org>
1441 Create Notebook widgets to the details view.
1443 This isn't finished just yet - I still need to create a reasonable
1444 style to match the current theme.
1446 * src/main/java/org/glom/web/client/Utils.java: Add method for
1447 calculating the height of a widget. This is used in the Notebook class.
1448 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1449 new constructor method in Group.
1450 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1451 method for creating child widget that can be used by subclasses
1452 like Notebook. New constructor that allows disabling the group
1453 titles - Notebooks don't set a group title for their child groups.
1454 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1455 to make Notebooks using GWT's TabLayoutPanel.
1456 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1457 constructor that allows disabling the group titles.
1458 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1459 LayoutItemNotebook DTO.
1460 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1461 DTO for Notebooks. It's just an empty class for now but we might need
1462 it to transfer some specific information in the future.
1464 2011-10-21 Ben Konrath <ben@bagu.org>
1466 Add navigation buttons to related list tables.
1468 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1469 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1470 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1471 method getSuitableRecordToViewDetails() for getting the table name
1472 and primary key value for related list navigation buttons.
1473 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1474 private cell renderer class to get the navigation information for
1475 related list tables from the server. Extract the navigation
1476 processing code from the details cell navigation and use it for the
1477 related list navigation as well.
1478 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1479 cell renderer class for the details open buttons. This was needed
1480 because the related list navigation buttons and the list view
1481 navigation buttons need to react differently when clicked.
1482 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1483 the onEnterKeyDown() method because it's now overriden in the
1484 subclasses that are specific to the related list tables and the list
1486 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1487 the vertical size a little because the buttons add a bit of vertical
1488 space to table. This is not a perfect solution because the vertical
1489 size of with table fewer than 5 rows will be a little smaller.
1490 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1491 changes in how navigation buttons are handled.
1492 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1493 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1494 database access object.
1495 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1496 to find the portal for a given relationship name from
1497 RelatedListDBAccess. Add method to find a primary key field for a
1499 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1500 Move code to find the portal for a given relationship name to
1502 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1503 New file: database access object for getting the related list
1504 navigation information (the table name and the primary key value).
1505 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1506 DTO for transferring a table name to navigate to and a primary key
1508 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1509 boolean and getter/setter to specifies if the related list should add
1512 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1514 Use the master branch of java-libglom
1516 * pom.xml: Depend on java-libglom 1.19 instead.
1518 This is the master branch. See also the libglom-1-18 branch.
1520 2011-10-11 Ben Konrath <ben@bagu.org>
1522 Enable the open navigation button when the data has been set.
1524 This avoids having active buttons that don't do anything when the data
1527 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1529 2011-10-11 Ben Konrath <ben@bagu.org>
1531 Use IsWidget interface for FlowTableItem.
1533 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1534 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1536 2011-10-11 Ben Konrath <ben@bagu.org>
1538 Remove GWT styling from open button in details view.
1540 There are still some issues with how the details cell is arranged but
1541 this should be made to match Glom 1.20. I'm going to leave fixing this
1542 until I have Glom 1.20 up and running.
1544 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1545 style name on open button.
1546 * src/main/webapp/style.css: Move and edit details-navigation class.
1547 Re-arrange some classes to make them appear in the same order as the
1550 2011-10-07 Ben Konrath <ben@bagu.org>
1552 Update to GWT 2.4.0.
1554 * .gitignore: Ignore new cache directory.
1555 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1556 * pom.xml: Change GWT and maven plugin to 2.4.0.
1557 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1559 * src/main/java/org/glom/web/client/ClientFactory.java:
1560 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1561 * src/main/java/org/glom/web/client/OnlineGlom.java:
1562 Update source for API changes.
1563 * utils/build-onlineglom-war.sh: Remove cache directory before the
1566 2011-10-07 Ben Konrath <ben@bagu.org>
1568 Add navigation buttons in the details view.
1570 This isn't finished but I thought I'd commit what I have as it's a
1571 pretty good start. I still need to:
1573 1. Change the style so that it fits better into the current theme
1574 2. Adjust the details cell to expand as much as possible.
1576 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1577 click handlers to navigation buttons in the DetailsCells. Create a
1578 refreshData() method to get just the data from the server without the
1580 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1581 Update the tableSelector and browser title when the table name
1582 changes without using the tableSelector.
1583 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1584 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1585 getDetailsCells() to getCells(). Update variable names.
1586 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1587 method to set click handler on navigation button. Rename a few
1588 variables. Add navigation buttons where needed.
1589 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1590 variables and methods.
1591 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1592 navigation boolean and navigation table as required in the
1593 LayoutItemField DTO.
1594 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1595 variables for navigation along with getter/setter methods.
1597 2011-10-07 Ben Konrath <ben@bagu.org>
1599 Rename Field to DetailsCell.
1601 This is a refactor-only commit. No functionality has been added or
1604 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1605 Update variable and method names.
1606 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1607 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1608 variable and method names.
1609 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1611 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1612 variable and method names.
1614 2011-10-07 Ben Konrath <ben@bagu.org>
1616 Create separate methods for layout and data the details view.
1618 This is a refactor-only commit. No functionality has been added or
1621 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1622 private methods: setData(), createLayout().
1624 2011-10-07 Ben Konrath <ben@bagu.org>
1626 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1628 This is part of a change to get navigation buttons in the details view
1629 but it should have been done this way from the start.
1631 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1632 for method name change in TableSelectionView.
1633 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1634 Create TableChangeEvent and set the browser title using the
1635 TableSelectionView API.
1636 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1637 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1638 Change getSelectedTable() to getSelectedTableName(). Add
1639 getSelectedTableTitle().
1641 2011-10-07 Ben Konrath <ben@bagu.org>
1643 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1645 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1647 2011-10-07 Ben Konrath <ben@bagu.org>
1649 Update TableChangeEvent to use newTableName naming convention.
1651 This makes the class more consistent with GWT naming conventions.
1653 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1654 Update for method name change in TableChangeEvent.
1655 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1656 for method name change in TableChangeEvent.
1657 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1658 newTableName variable and getter method. Make toDebugString()
1661 2011-09-30 Ben Konrath <ben@bagu.org>
1663 Disable the pager in the list tables when the data row count is less than the minimum.
1665 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1666 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1668 2011-09-30 Ben Konrath <ben@bagu.org>
1670 Add empty rows to the end of related list and list view tables.
1672 I also extracted the cell rendering classes from the ListTable because
1673 the code was becoming a little crazy with all the anonymous inner
1674 classes. My plan is to use these cell rendering classes in the details
1675 view as well so this refactor will be needed for that change.
1677 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1678 set the row count in related list tables if the data has more rows
1679 than the minimum number of rows visible.
1680 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1681 row count in list view tables if the data has more rows than the
1682 minimum number of rows visible.
1683 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1684 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1686 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1687 for rendering TYPE_NUMERIC cells. The code was extracted from the
1689 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1690 class for rendering cells with buttons in list views. The code was
1691 extracted from the ListTable class.
1692 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1693 for rendering TYPE_TEXT cells. The code was extracted from the
1695 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1696 Add empty rows to the end of the data if required. Implement
1697 ListTable.getMinNumVisibleRows().
1698 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1699 cell renderer code to public classes. Return null in
1700 Column.getValue() for empty rows. Add new abstract method:
1701 getMinNumVisibleRows(). Move code to set the row count of the list view
1702 table to ListViewImpl.
1703 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1704 empty rows to the end of the data if required. Implement
1705 ListTable.getMinNumVisibleRows().
1708 2011-09-27 Ben Konrath <ben@bagu.org>
1710 Use GWT.log for client-side debugging statements.
1712 These are optimized out when deployed so I should have used this method
1713 in the first place. These statements will eventually be replaced with some sort
1714 of notification in the browser.
1716 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1717 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1718 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1719 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1720 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1722 2011-09-27 Ben Konrath <ben@bagu.org>
1724 Put tableselector on the right, back to list link on right.
1726 The idea is that the table selector is acting like a label for the
1727 currently displayed table so it should be placed below the document title. This
1728 puts the table title in a similar position to where it is in Glom.
1730 * mockups/details-contacts.html:
1731 * mockups/details-projects.html:
1732 * mockups/listview-contacts.html:
1733 * mockups/listview-projects.html:
1734 * mockups/style.css:
1735 Update mockups to match how the interfaces currently look.
1736 * src/main/webapp/style.css: Swap positions of backlink with the table
1737 selector. Add some space on the left side of the table selector to
1738 line things up with the document title.
1740 2011-09-27 Ben Konrath <ben@bagu.org>
1742 Add field colouring to details view.
1744 This change re-works how field colouring works. The colour formatting
1745 information is now set to the client with the layout information instead of
1746 with the data. This eliminates the need to send the same colour strings for
1747 data in list view column when colour information is set.
1749 In order to set an alternate colour for negative numeric values, the
1750 number is now sent to client and formatted with the GWT NumberFormat class.
1752 This change also fixes:
1754 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1756 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1757 internationalization framework which is needed for client side numeric
1759 * src/main/java/org/glom/web/client/Utils.java: New file for some
1760 client static utility methods.
1761 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1762 the DataItem object to the Field class. Use a utility method to
1763 create the foreignKeyValue string.
1764 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1765 alignment and text colours in the constructor. Add setData(DataItem)
1766 method. Remove setText(String) method.
1767 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1768 colour information to GlomTextCell. Create and use GlomNumberCell for
1769 rendering numbers. Use utility method to get the string for the
1770 primary key of the key provider. Re-work how the horizontal alignment
1772 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1773 formatting to layout information. Methods for converting the libglom
1774 formatting information were moved from DBAccess.
1775 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1776 numeric formatting (it's now done on the client side). Don't set text
1777 colours in DataItem. Move libglom formatting conversion methods to
1779 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1780 getters/setters for text colour information.
1781 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1782 for transferring the libglom NumericFormat information to the client.
1783 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1784 and getters/setters for: GlomNumericFormat, background colour and
1785 foreground colour strings.
1787 2011-09-26 Ben Konrath <ben@bagu.org>
1789 Simplify code that iterates through the LayoutGroup.
1791 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1793 2011-09-26 Ben Konrath <ben@bagu.org>
1795 Accept Eclipse formatting for OnlineGlomServiceAsync.
1797 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1799 2011-09-26 Ben Konrath <ben@bagu.org>
1801 Don't use the ListDBAccess classes to get the primary key layout information.
1803 This was causing a bug where the wrong index for the hidden primary key
1804 was being sent to the client.
1806 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1807 primary key while creating the LayoutGroup DTO. Create a
1808 LayoutItemField DTO for hidden primary keys. Don't use the
1809 RelatedListDBAccess because it was only used for getting the primary
1811 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1812 access modifier from public to protected for getPrimaryKeyField() and
1813 getPrimaryKeyLayoutItemField().
1814 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1815 abstract method getExpectedResultSize() because RelatedListDBAccess
1816 doesn't have enough info to implement it.
1817 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1818 Remove @Override for getExpectedResultSize().
1819 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1820 Remove method getExpectedResultSize().
1822 2011-09-23 Ben Konrath <ben@bagu.org>
1824 Log which layout (list or details) the ignored item is from.
1826 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1828 2011-09-23 Ben Konrath <ben@bagu.org>
1830 Remove annotations that turn off code formatting in DataItem.
1832 * src/main/java/org/glom/web/shared/DataItem.java:
1834 2011-09-23 Ben Konrath <ben@bagu.org>
1836 Rename GlomField to DataItem and update associated methods.
1838 This is a rename-only refactor. No functionality has been added or
1841 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1842 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1843 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1844 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1845 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1846 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1847 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1848 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1849 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1850 * src/main/java/org/glom/web/server/database/DBAccess.java:
1851 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1852 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1853 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1854 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1855 * src/main/java/org/glom/web/shared/DataItem.java:
1856 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1857 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1859 2011-09-23 Ben Konrath <ben@bagu.org>
1861 Rename GlomDocument to DocumentInfo and update associated methods.
1863 This is a rename-only refactor. No functionality has been added or
1866 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1867 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1868 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1869 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1870 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1871 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1872 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1874 2011-09-20 Ben Konrath <ben@bagu.org>
1876 Require java-libglom 1.17.3.
1878 This picks up the fix for the seg fault problem with the Scenes table
1879 in the Openismus Film Manager example.
1883 2011-09-20 Ben Konrath <ben@bagu.org>
1885 Change the way sort clause is added for primary key when no sort clause is requested.
1887 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1888 before the sort clause is created. When a sort clause is not requested, the
1889 sort clause is created by finding the primary key in the LayoutFieldVector
1892 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1894 2011-09-20 Ben Konrath <ben@bagu.org>
1896 Log error message if no documents are found in the configured directory.
1898 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1899 Extract the glom file extension string to a private static final class
1900 variable (mostly as syntactic sugar). Accept a minor formatting change.
1901 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1902 the example glom.document.directory configuration property to make it
1903 more clear that it can any directory, not just the home directory.
1905 2011-09-18 Ben Konrath <ben@bagu.org>
1907 Add related lists to details view.
1909 The related list table has support for paging and sorting just like the
1910 table in the list view.
1912 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1913 SQL queries for the related list tables.
1914 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1915 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1916 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1917 Rename getList methods to getListView and add comments. Remove
1918 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1919 it being unused. Add methods: getDetailsLayoutAndData(),
1920 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1921 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1922 Create the layout and set the data for the fields in one async call
1923 instead of two. Create related lists where appropriate.
1924 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1925 for method name changes in OnlineGlomService.
1926 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1927 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1928 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1930 * src/main/java/org/glom/web/client/ui/ListView.java:
1931 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1932 tableName from setCellTable(). Create a ListViewTable instead of
1934 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1935 represent a data field in the details view.
1936 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1937 from addDetailsCell() to Field class. Keep track of the Fields and
1938 Portals in the details view.
1939 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1940 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1941 and add a method to get it. Add method to set the contents of the
1943 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1944 New class for related list tables. This class has the data provider
1945 for the related list table.
1946 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1947 abstract class which is the base class for the ListViewTable and the
1949 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1950 New class for list view tables. This class has the data provider for
1951 the list view table.
1952 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1953 methods for related list tables. Add more information to the
1954 LayoutItemField and LayoutItemPortal DTOs.
1955 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1956 Remove debugging print statement.
1957 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1958 Remove debugging print statements. Add primary key field to SQL count
1960 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1961 Remove unnecessary LayoutFieldVector parameter from
1962 getResultSizeOfSQLQuery() method.
1963 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1964 New class for related list table database access.
1965 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1966 class that is a wrapper DTO for details view layout and data.
1967 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1968 new 'fromField' string to this DTO.
1969 * src/main/webapp/style.css: Remove bottom margin and override top
1972 2011-09-15 Ben Konrath <ben@bagu.org>
1974 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1976 This sets things up to make it easier to add the data retrieval for
1977 related lists (portals). No user noticeable changes were made with
1980 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1981 class has the code to retrieve the layouts and access the
1982 database using the new database helper classes.
1983 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1984 Most of the functionality has been removed from this class. This
1985 class now represents the public interface for the client side
1986 code. It also deals with configuring the servlet and cleaning
1987 things up when the servlet is stopped.
1988 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1989 of static methods into this utility class.
1990 * src/main/java/org/glom/web/server/database/DBAccess.java:
1991 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1992 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1993 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1994 These classes have the database retrieval code. The class hierarchy
1995 has been setup to make it easy to reuse code for similar
1998 2011-09-06 Ben Konrath <ben@bagu.org>
2000 Create separate classes for list table code and the data provider.
2002 As part of this refactor, I also split up the code a bit to make it
2005 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2006 table code to two new classes (below).
2007 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2008 with code from ListViewImpl.
2009 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2010 New file with code from ListViewImpl.
2012 2011-09-06 Ben Konrath <ben@bagu.org>
2014 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2016 This fixes the LayoutItemPortal DTO to match the libglom layout object
2019 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2021 2011-09-01 Ben Konrath <ben@bagu.org>
2023 Set title of Portals in the Details View.
2025 * pom.xml: Bump required version of java-libglom to 1.17.1.
2026 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2027 widget creation to its own class. Add comments to constructor.
2028 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2029 The code is mostly from the Group class with the title now set.
2030 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2031 title of Portal. Update some comments. Fix some code formatting.
2033 2011-09-01 Ben Konrath <ben@bagu.org>
2035 Remove TODO comment for the flow table column width.
2037 The flow table column width is working correctly and doesn't need to be
2038 changed. See this mailing list post for more info:
2040 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2042 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2044 2011-08-27 Ben Konrath <ben@bagu.org>
2046 Add document title (database name) to top of the browser page.
2048 I added the document title to the TableSelecitonView but that will
2049 change if / when we add a view that doesn't require table selection.
2051 * mockups/details-contacts.html:
2052 * mockups/details-projects.html:
2053 * mockups/listview-contacts.html:
2054 * mockups/listview-projects.html:
2055 * mockups/style.css: Add document title to mockups to keep things
2057 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2058 sizes to account for the document title.
2059 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2060 Set the document title when it has been retrieved from the server.
2061 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2062 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2063 and implement setDocumentTitle(String) method.
2064 * src/main/webapp/style.css: Add ID for document title style.
2066 2011-08-25 Ben Konrath <ben@bagu.org>
2068 Add NavigationType enum to LayoutItemPortal DTO.
2070 This is the start of adding support for Portals to the Details View.
2072 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2073 LayoutItem_Portal.navigation_type enum from libglom to
2074 LayoutItemPortal.NavigationType enum.
2075 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2076 NavigationType enum, field for storing the NavigationType and getter
2079 2011-08-25 Ben Konrath <ben@bagu.org>
2081 Implement the flow table layout in the Details View.
2083 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2084 FlowTable to Group to account for the renamed class.
2085 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2086 File. This is a container widget that implements the Glom details view
2087 flow table behaviour.
2088 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2089 org/glom/web/client/ui/FlowTable.java.
2090 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2091 so that the size of the subgroups are a closer match to the size of
2092 the Glom subgroups. This makes the flowtable layout match the layout
2093 in Glom for the Music Collection example file.
2095 2011-08-16 Ben Konrath <ben@bagu.org>
2097 Create container element for LayoutItemPortal in Details View.
2099 This will help me develop the layout for the FlowTable.
2101 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2102 fieldPanel variable to detailsCell.
2104 2011-08-15 Ben Konrath <ben@bagu.org>
2106 Set the height of the data element in the Details View.
2108 I changed the InlineLabels (text in a span element) to Labels (text in
2109 a div element) so that I could set the height of the details-data
2110 elements instead of the details-cell parent elements. This allows the
2111 the details-data element to display the correct height if style is
2112 applied that shows the height.
2114 This change has the added benefit of allowing the order of the labels
2115 and data elements to be changed for right-to-left languages.
2117 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2118 InlineLabels to Labels.
2119 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2120 InlineLabels to Labels. Set the height of the data element.
2121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2122 multiline text height in the Formatting DTO.
2123 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2124 for multiline height along with getter and setter methods.
2125 * src/main/webapp/style.css: Adjust style to account for the change
2126 from span elements to div elements in the details cell.
2128 2011-08-15 Ben Konrath <ben@bagu.org>
2130 Make the List View appearance match the mockups.
2132 It doesn't match exactly but it's much better than it was.
2134 * mockups/listview-contacts.html: Remove unused css classes.
2135 * mockups/listview-projects.html: Remove unused css classes.
2136 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2137 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2138 for mainPanel instead of VerticalPanel (table). Set style name on
2139 CellTable. Set style name on Details column. Right-align Details
2141 * src/main/webapp/style.css: Adjust properties to match the mockups.
2143 2011-08-12 Ben Konrath <ben@bagu.org>
2145 Add better support for subgroups in the details view.
2147 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2148 changed FlowTable constructor.
2149 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2150 support for subgroups and subgroup-titles.
2151 * src/main/webapp/style.css: Add CSS class for subgroups and
2154 2011-08-12 Ben Konrath <ben@bagu.org>
2156 Return the top level LayoutGroup title.
2158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2160 2011-08-11 Ben Konrath <ben@bagu.org>
2162 Make the TableSelector header match the mockup.
2164 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2165 the layout panel. Properly lineup the table selection header with
2166 the list and details view.
2167 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2168 margin around the details view.
2169 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2170 Rename listBox variable to tableSelector. Set id for the style sheet.
2171 Use a FlowPanel instead of a HorizontalPanel.
2172 * src/main/webapp/style.css: Add properties to make the TableSelector
2173 box match the mockups.
2175 2011-07-13 Ben Konrath <ben@bagu.org>
2177 Update install script for java-libglom version change.
2179 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2182 2011-07-13 Ben Konrath <ben@bagu.org>
2184 Add support sub-group in the details view.
2186 I also removed the code that special-cased the default details view
2189 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2191 I still have to make a proper flowtable.
2193 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2194 Don't special-case default details view layout.
2195 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2196 addLayoutField() as I'm going to use it.
2197 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2198 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2200 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2201 extracted from DetailsViewImpl.GroupPanel. Add support for
2203 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2204 column count when getting the details layout.
2206 2011-07-12 Ben Konrath <ben@bagu.org>
2208 Set browser title with database and table titles.
2210 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2211 Set the browser title when the table changes and when the activity
2213 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2214 title when retrieving document info (the GlomDocument object).
2215 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2216 with getter and setter methods. Remove unused convenience constructor.
2217 Use default code formatting.
2219 2011-07-12 Ben Konrath <ben@bagu.org>
2221 Ignore LayoutItemPortals in the details view.
2223 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2226 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2227 LayoutItemPortal layout objects.
2228 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2229 LayoutItemPortal objects when retrieving the details layout.
2230 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2231 file. This is an empty class and just used to get type information for
2234 2011-07-12 Ben Konrath <ben@bagu.org>
2236 Use java-libglom 1.17.0.
2240 2011-07-11 Ben Konrath <ben@bagu.org>
2242 Remove "Table:" label from table selector.
2244 This matches a recent change in the Glom UI.
2246 * mockups/details-contacts.html:
2247 * mockups/details-projects.html:
2248 * mockups/listview-contacts.html:
2249 * mockups/listview-projects.html: Remove the "Table:" label from the
2251 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2253 2011-07-11 Ben Konrath <ben@bagu.org>
2255 Add main groups to the details view.
2257 This makes things look a little nicer in the details view. The next step
2258 is to implement the flowtable.
2260 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2261 resources from the standard gwt css theme. Standard.css is now
2262 included in OnlineGlom.html so that the online glom css rules have
2263 precedence over the gwt theme.
2264 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2265 the whole LayoutGroup to the DetailsView instead of just the titles.
2266 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2267 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2268 details layout with a helper class (GroupPanel). I might extract this
2269 class when I make the full flowtable.
2270 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2271 string as default so I don't have to worry about NPEs when processing
2273 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2274 note beside OnlineGlom.gwt.xml above).
2275 * src/main/webapp/style.css: Add default font-size to body to override
2276 the font-size set by the standard theme. Don't use h2 tags for
2277 group-title. Create new details-cell class.
2279 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2281 ConfiguredDocument: Set the port number too.
2283 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2284 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2285 Glom document. Presumably this worked sometimes so far because there is a
2286 default port number.
2288 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2290 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2292 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2293 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2294 correct, though we should throw an exception too.
2296 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2298 Fix a addDocuemnt typo.
2300 * src/main/java/org/glom/web/shared/Documents.java
2301 (Documents.addDocuemnt): Rename to addDocument().
2302 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2303 (OnlineGlomServiceImpl.getDocuments): Adapt.
2305 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2307 Slightly improved log output when connection fails.
2309 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2310 (ConfiguredDocument.setUsernameAndPassword):
2311 We don't know for sure if it' the username/password that's wrong, so
2312 rephrase the message.
2313 Also ouput the exception message, though it's generic in this case.
2315 2011-07-08 Ben Konrath <ben@bagu.org>
2319 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2320 added braces to a one line if statement because the Eclipse formatter
2321 was getting confused.
2323 2011-07-07 Ben Konrath <ben@bagu.org>
2325 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2327 These should really be two separate tasks but I counldn't get things to
2328 work with GWT 2.2.0 and Eclipse 3.7.
2332 * .settings/org.eclipse.jdt.core.prefs:
2333 * .settings/org.eclipse.jdt.ui.prefs:
2334 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2335 * .settings/org.eclipse.m2e.core.prefs:
2336 Add new config files. Update current files. Remove references to the
2337 webtools plugins as we're not using any of the webtools features.
2338 * .gitignore: Add logs directory which is created when running with
2340 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2341 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2342 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2344 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2346 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2348 onlineglom.properties: Add explanatory comments.
2350 * src/main/resources/onlineglom.properties: Also change the default user
2351 from ben to someuser, to avoid the risk of people thinking we just
2352 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2354 2011-06-28 Ben Konrath <ben@bagu.org>
2356 Use filename in Log for incorrect passwords.
2358 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2359 getFileName(String) method to get the filename from the URI.
2361 2011-06-28 Ben Konrath <ben@bagu.org>
2363 Add the table name to the URL token for the ListPlace.
2365 This makes things consistent between the DetailsPlace and the
2366 ListPlace. It also allows the the ListPlace to be bookmarked.
2368 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2369 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2370 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2371 Remove getDefaultListLayout(). The default layout is now returned
2372 by the getListLayout() method when the table name is an empty string.
2373 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2374 Add table name field. Change to a new ListPlace when the table
2375 has been changed. Use getListLayout() for getting the default
2377 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2378 Add table name field. Set the correct table name in the list box
2379 when loading from bookmark. This corrects a problem for the
2381 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2382 Move table name to super-class (HasSelectableTable). Move document
2383 and table URL keys to super-class in HasSelectableTable.
2384 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2385 Add table name field. Add Tokenizer class with URL key common to
2386 the subclasses (DetailsPlace and ListPlace).
2387 * src/main/java/org/glom/web/client/place/ListPlace.java:
2388 Add table name. Add code to parse the URL token.
2389 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2390 Update ListPlace construction with empty table name string.
2391 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2392 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2393 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2394 Update ListPlace construction with table name string.
2395 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2396 Change defaultTableName field to tableName to reflect how it's now
2397 used. Update the getter and setter methods.
2399 2011-06-28 Ben Konrath <ben@bagu.org>
2401 Enable the table selector in the DetailsView.
2403 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2404 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2405 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2406 Remove getDefaultDetailsLayout(). The default layout is now returned
2407 by the getDetailsLayout() method when the table name is an empty
2409 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2410 event handler for table change event. Change to using
2411 getDetailsLayout() for the default details layout.
2412 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2414 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2415 when navigating to the details place.
2417 2011-06-27 Ben Konrath <ben@bagu.org>
2419 Use filename based unique document ID in URL and for RPC.
2421 The document ID is the glom document name with spaces (' ') replaced
2422 with pluses ('+') and without the .glom extension.
2424 This change is mostly a string substitution of 'documentTitle' for
2425 'documentID'. The only code change is the addition of a Documents DTO to get the
2426 filename to document title mappings as indicated below.
2428 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2429 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2430 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2431 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2432 Use Documents DTO to create the document links in the document
2434 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2435 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2436 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2437 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2438 * src/main/java/org/glom/web/client/place/ListPlace.java:
2439 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2440 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2441 * src/main/java/org/glom/web/client/ui/ListView.java:
2442 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2443 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2444 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2445 * src/main/java/org/glom/web/server/Log.java:
2446 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2447 getDocumentTitles() to getDocuments() and return the Documents DTO.
2448 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2449 transferring the filename to document title mappings.
2451 2011-06-25 Ben Konrath <ben@bagu.org>
2453 Make the authentication popup work again.
2455 This bug was introduced when I extracted ConfiguredDocument to its own class.
2457 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2458 correct success / fail status in setUsernameAndPassword().
2460 2011-06-25 Ben Konrath <ben@bagu.org>
2462 Use filename as unique key for configuring database usernames and passwords.
2464 This replaces the use of the Glom document title which could change
2465 depending on the locale. Thanks to Murray Cumming for pointing out this
2468 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2469 * src/main/resources/onlineglom.properties:
2471 2011-06-24 Ben Konrath <ben@bagu.org>
2473 Pass primary key value to DetailsView.
2475 This enables the DetailsView to load the correct data.
2477 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2478 primary key value field and set in constructor. Pass primary key
2479 value to getDetailsData().
2480 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2481 variables for document title and primary key value.
2482 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2483 key value to the DetailsPlace.
2485 2011-06-24 Ben Konrath <ben@bagu.org>
2487 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2489 This allows the primary key to be retrieved by the Details button. This
2490 functionality has not been implemented yet but it's in the works.
2492 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2493 the LayoutGroup result to ListView.setCellTable instead of all of its
2494 fields individually.
2495 * src/main/java/org/glom/web/client/ui/ListView.java:
2496 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2497 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2498 get the primary key for the table.
2499 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2500 index of the primary key in the LayoutGroup accounting for hidden
2501 primary keys. Rename getJavaNumberFormat() to
2502 convertToJavaNumberFormat() for consistency. Cleanup / add some
2504 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2505 field for primary key index and a field to indicate whether the
2506 primary key is hidden or not.
2508 2011-06-23 Ben Konrath <ben@bagu.org>
2510 Rename getTableData methods to getListData.
2512 This is a rename refactor for consistency with other methods.
2514 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2515 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2516 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2519 2011-06-23 Ben Konrath <ben@bagu.org>
2521 Extract the ConfiguredDocument innerclass into its own class.
2523 This makes the servlet code more object oriented.
2525 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2526 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2527 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2528 new ConfiguredDocument class.
2530 2011-06-21 Ben Konrath <ben@bagu.org>
2532 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2534 This makes things more inline with how libglom works and reduces code
2535 duplication. This refactor lays the groundwork for adding the primary key to
2536 the LayoutGroup object.
2538 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2539 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2540 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2541 Change method names to getListLayout and getDefaultListLayout for
2542 consistency. Use LayoutGroup as the DTO for the list layout instead of
2543 ColumnInfo and LayoutListTable.
2544 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2545 new method names along with the LayoutGroup object for transferring the
2547 * src/main/java/org/glom/web/client/ui/ListView.java:
2548 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2549 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2550 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2552 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2553 Replaced with LayoutGroup.
2554 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2555 expectedResultSize and defaultTableName fields which are needed for
2557 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2558 type field which is needed for the list layout but will also be
2559 useful for the details layout as things progress.
2560 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2561 Make class abstract. Remove the unnecessary
2562 getFormattingHorizontalAlignment method. Add setFormatting method.
2564 2011-06-16 Ben Konrath <ben@bagu.org>
2566 Add scripts for building and installing war.
2568 These will help when updating OnlineGlom but they're also good
2569 supplemental documentation of the build and deployment proceeding.
2571 * utils/build-onlineglom-war.sh: New file.
2572 * utils/install-onlineglom-war.sh: New file.
2574 2011-06-16 Ben Konrath <ben@bagu.org>
2576 Create wrapper class to create consistent log messages.
2578 I wrapped methods in the Log class of gwt-log to add the method names
2579 from the servlet and create consistent formatting of the document title
2580 and table names in the log messages.
2582 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2583 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2584 log methods to use methods from wrapped Log class.
2586 2011-06-16 Ben Konrath <ben@bagu.org>
2588 Remove superfluous conditional return.
2590 Thanks to Murray Cumming for pointing this out!
2592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2594 2011-06-15 Ben Konrath <ben@bagu.org>
2596 Return an ArrayList of LayoutGroups for the Details layout.
2598 This corrects a problem with the details layout as it can have more
2599 than one top level LayoutGroup.
2601 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2602 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2603 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2604 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2605 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2606 with ArrayList of LayoutGroups for the details view layout.
2607 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2608 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2609 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2610 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2611 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2612 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2614 2011-06-14 Ben Konrath <ben@bagu.org>
2616 Use cast_dynamic method to determine the libglom LayoutItem type.
2618 This is better than finding the LayoutItem type by using the string
2619 returned from the get_part_type_name() method.
2621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2623 2011-06-14 Ben Konrath <ben@bagu.org>
2625 Add method names to log entries in the servlet.
2627 This helps when tracking down deployment problems.
2629 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2631 2011-06-14 Ben Konrath <ben@bagu.org>
2633 Add data to the DetailsView using a hard-coded primary key value.
2635 The layout and functionality of the DetailsView is not complete. This
2636 is just a checkpoint so the patch doesn't get too big.
2638 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2639 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2640 Add getDetailsData() servlet method.
2641 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2642 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2643 LayoutFields are added to the DetailsView.
2644 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2645 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2646 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2647 take the string for the title instead of the object.
2648 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2649 Add implementation getDetailsData() along with some private helper
2651 * src/main/webapp/style.css: Add padding to details-data class. Add a
2652 details-label class with the same padding as the details-data class.
2654 2011-06-03 Ben Konrath <ben@bagu.org>
2656 Use presenter.goTo() to change to the DetailsPlace.
2658 This will make things easier when we need to open the DetailsView with
2659 data specific to the row that was clicked.
2661 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2663 2011-06-02 Ben Konrath <ben@bagu.org>
2665 Add CSS file from mockups.
2667 I'm adding this now because it's going to be useful to have when
2668 developing the DetailsView. The TableSelectionView and ListView aren't
2671 * src/main/webapp/OnlineGlom.html:
2672 * src/main/webapp/style.css:
2674 2011-06-02 Ben Konrath <ben@bagu.org>
2676 Use String.isEmpty() to check for empty string.
2678 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2680 2011-06-02 Ben Konrath <ben@bagu.org>
2682 Display main layout group titles in the DetailsView.
2684 This is the start of the DetailsActivity/DetailsView implementation.
2686 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2687 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2688 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2689 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2690 Get the layout information for the details view from the server and set
2691 the main layout group titles.
2692 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2693 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2694 Add addLayoutGroup() and addLayoutField() methods. This are just
2695 temporary methods for creating the the details view that will change
2697 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2698 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2700 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2701 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2702 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2703 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2704 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2705 Data Transfer Objects that mimic the libglom object structure. These are
2706 used for transferring the details layout but could also be used for
2707 transferring the list layout.
2709 2011-05-27 Ben Konrath <ben@bagu.org>
2711 Reset the AuthenticationPopup when clearing the ListView.
2713 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2715 2011-05-27 Ben Konrath <ben@bagu.org>
2717 Fix problem with onlineglom.properties file loading.
2719 The old way worked in Eclipse but not on the server. Loading the
2720 onlineglom.properties file now works in Eclipse and on the server.
2722 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2724 2011-05-24 Ben Konrath <ben@bagu.org>
2726 Update gwt-log from 3.1.0 to 3.1.2.
2728 Gwt-log 3.1.0 has been marked as depreciated.
2732 2011-05-24 Ben Konrath <ben@bagu.org>
2734 Add comment to ListActivity.goTo() method.
2736 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2738 2011-05-24 Ben Konrath <ben@bagu.org>
2740 Remove FIXME in convertGdkColorToHtmlColour()
2742 The Gdk::Color value returned by libglom is 16-bits per channel on both
2743 64 and 32-bit platforms.
2745 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2747 2011-05-19 Ben Konrath <ben@bagu.org>
2749 Improve performance of initial ListView load.
2751 I removed a round trip to the server for getting the default table name
2752 and then requesting information about that table. This also removes a potential
2753 problem with the table change handler not being setup in time to receive the
2754 table change event from the ListActivity.
2756 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2757 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2758 getDefaultLayoutListTable() method. Improve comments.
2759 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2760 getDefaultLayoutListTable() method instead of firing a table change
2761 event to get the table to load.
2762 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2763 implementation of getDefaultLayoutListTable() method.
2764 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2767 2011-05-19 Ben Konrath <ben@bagu.org>
2769 Override toDebugString() in TableChangeEvent.
2771 This is useful to have for debugging.
2773 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2775 2011-05-19 Ben Konrath <ben@bagu.org>
2777 Add a "Back to List" link when at the DetailsPlace.
2779 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2780 Populate the CellTable based on the selected table of the ListBox if
2781 it's set otherwise use the default table. This allows the "Back to
2783 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2784 Remove Place from constructors. Add a setPlace() method. Add
2785 goToPlace() method. Set class as presenter for TableSelectionView.
2786 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2787 Use the same TableSelectionActivity when switching between the List and
2789 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2790 Subclass the new HasSelectableTablePlace. This removes some duplicate
2792 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2793 New class to represent Places that display the TableSelectionView.
2794 * src/main/java/org/glom/web/client/place/ListPlace.java:
2795 Subclass the new HasSelectableTablePlace. This removes some duplicate
2797 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2798 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2799 Add Presenter interface. Add setBackLinkVisible() method. Add
2800 setBackLink() method.
2802 2011-05-18 Ben Konrath <ben@bagu.org>
2804 Enable the "Details" buttons.
2806 Right now only an empty details view is displayed.
2808 * src/main/java/org/glom/web/client/ClientFactory.java:
2809 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2810 Add DetailsView to ClientFactory.
2811 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2812 A basic activity for the details view.
2813 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2814 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2816 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2817 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2819 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2820 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2821 unnecessary super() in constructor.
2822 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2823 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2824 really shouldn't create a new TableSelectionActivity for both the ListPlace
2825 and the DetailsPlace so this should be considered a temporary solution.
2826 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2827 New file. Represents a URL for the details view.
2828 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2829 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2830 A basic details view interface and implementation.
2831 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2832 Enable the "Details" buttons.
2834 2011-05-12 Ben Konrath <ben@bagu.org>
2836 Use a LayoutPanel with multiple display areas for main layout.
2838 This is mostly a refactor in that there are no changes from the user
2839 point of view. These changes are required so that we can swap out the list view
2840 with the details view when the user clicks the "Details" button.
2842 * src/main/java/org/glom/web/client/ClientFactory.java:
2843 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2844 OnlineGlomView. Add TableSelectionView, ListView and
2845 AuthenticationPopup.
2846 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2847 for main layout. Add display regions for main activities. Add
2848 activity manager for for main activities.
2849 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2850 file from parts of the deleted OnlineGlomActivity.
2851 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2852 New file from parts of the deleted OnlineGlomActivity.
2853 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2854 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2855 New files for app wide table change event.
2856 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2857 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2858 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2859 Activity mappers for the main activities replace the deleted app-wide
2861 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2862 Fix a spelling error in he comment.
2863 * src/main/java/org/glom/web/client/ui/ListView.java:
2864 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2865 Renamed from LayoutListView and modified for MVP. This still not a
2866 proper dumb view as prescribed by the MVP pattern but it works for now.
2867 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2868 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2869 New widget stripped out of the deleted OnlineGlomView.
2870 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2871 Remove hack that is fixed by this patch.
2873 2011-05-06 Ben Konrath <ben@bagu.org>
2875 Rename OnlineGlomPlace to ListPlace.
2877 The only change besides the rename is that url will now display #list
2878 instead of #Document.
2880 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2881 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2882 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2883 * src/main/java/org/glom/web/client/place/ListPlace.java:
2884 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2886 2011-05-06 Ben Konrath <ben@bagu.org>
2888 Use Presenter for app navigation.
2890 This is the proper way to deal with Place (URL) changes with the MVP
2893 * src/main/java/org/glom/web/client/ClientFactory.java:
2894 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2895 PlaceHistoryMapper and PlaceHistoryHandler.
2896 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2897 PlaceHistoryMapper and PlaceHistoryHandler.
2898 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2899 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2900 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2901 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2902 Add Presenter interface and setPresenter methods. Rename addHyperLink
2903 to addDocumentLink taking only the document title as a parameter.
2905 2011-04-14 Ben Konrath <ben@bagu.org>
2907 Prompt for db username/password if they haven't been set.
2909 This is implemented with a popup widget that is contained within the
2910 OnlineGlomView and managed by the OnlineGlomActivity.
2912 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2913 methods for checking and setting the database username and password.
2914 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2915 new methods for checking and setting the database username and
2917 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2918 Display authentication popup if the JDBC connection to the database
2919 has not been authenticated.
2920 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2922 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2923 for dealing with the authentication popup.
2924 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2925 Implement the methods for dealing with the authentication popup.
2926 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2927 try to executed queries if the database connection hasn't been
2928 authenticated. Implement methods for checking and setting the
2929 database username and password.
2931 2011-04-12 Ben Konrath <ben@bagu.org>
2933 Make log messages a little clearer.
2935 Add a dash betweeen the document title and the table name.
2937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2939 2011-04-12 Ben Konrath <ben@bagu.org>
2941 Protect against NPEs when cleaning up database resources.
2943 While this isn't strictly necessary because the exception is caught,
2944 not protecting against the NPEs makes it harder to find the real error
2947 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2949 2011-04-12 Ben Konrath <ben@bagu.org>
2951 Move configuration of the servlet to the constructor.
2953 The servlet will be initialized even if the database authentication
2954 information is not set or correct. I still need to add the UI for prompting
2955 the user for the authentication information when it's required.
2957 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2958 javadocs for getDocumentTitles() method.
2959 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2960 Set error message when RPC fails.
2961 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2962 glom files directory from the configuration file. Try to set the
2963 database authentication information for the specific document if it's
2964 set and works otherwise try to use the global authentication
2965 information set for the directory.
2966 * src/main/resources/onlineglom.properties: Moved from
2967 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2968 Added detailed comments for the new keys.
2970 2011-04-11 Ben Konrath <ben@bagu.org>
2972 Remove unnecessary @Override in DocumentSelectionViewImpl.
2974 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2976 2011-04-11 Ben Konrath <ben@bagu.org>
2978 Remove center alignment in DocumentSelectionView.
2980 The title element is still centred but the document titles and bottom
2981 sentence are both left-aligned.
2983 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2985 2011-04-11 Ben Konrath <ben@bagu.org>
2987 Change 'Demo' naming convention to 'Document'.
2989 This is just a rename refactor with no functional changes to the code.
2991 * src/main/java/org/glom/web/client/ClientFactory.java:
2992 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2993 * src/main/java/org/glom/web/client/OnlineGlom.java:
2994 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2995 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2996 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2997 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2998 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2999 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
3000 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3001 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3002 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
3003 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3005 2011-04-08 Ben Konrath <ben@bagu.org>
3007 Remove FIXME from safeLongToInt() method.
3009 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
3012 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3014 2011-04-08 Ben Konrath <ben@bagu.org>
3016 Display an error if no glom documents are found in the specified directory.
3018 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3019 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3020 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3021 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3023 2011-04-08 Ben Konrath <ben@bagu.org>
3025 Add copyright header to one more file ... oops.
3027 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3029 2011-04-08 Ben Konrath <ben@bagu.org>
3031 Add copyright header to files without it.
3033 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3034 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3035 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3036 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3037 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3038 * src/main/java/org/glom/web/shared/GlomField.java:
3040 2011-04-08 Ben Konrath <ben@bagu.org>
3042 Add support for accessing multiple glom documents in the servlet.
3044 This completes the demo selection functionality.
3046 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3047 document title to methods.
3048 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3049 document title to methods.
3050 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3051 Set browser window title when the activity starts. Correct name of
3052 document title variable.
3053 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3054 Set browser window title when the activity starts. Set the table
3055 selector change handler after table selector has been set. Clear the
3056 OnlineGlomView when the activity has been stopped.
3057 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3058 document title as the place token. Use "#Document:" instead of
3059 "#OnlineGlomPlace:" in the URL.
3060 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3061 Change heading to "Online Glom"
3062 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3063 document title in RPC methods.
3064 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3065 setDocumentTitle() method. Add clear() method.
3066 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3067 setDocumentTitle() method. Implement clear() method which removes the
3068 change handler on the ListBox, clears the ListBox and clears the
3070 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3071 Implement methods with document title. Keep track for the configured
3072 glom documents and their corresponding JDBC configurations in a hash
3073 table. This information is retrieved using the document title as the
3074 key in the hash table.
3075 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3076 document title field as it's no longer needed.
3078 2011-04-08 Ben Konrath <ben@bagu.org>
3080 Update the Eclipse JDT configuration.
3082 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3083 methods. Automatically add the copyright header to new files.
3085 2011-04-05 Ben Konrath <ben@bagu.org>
3087 Add new page for demo selection.
3089 This patch adds all the components required to view and start an
3090 OnlineGlom demo by clicking on the desired hyperlink. The user is
3091 able to return to the demo selection page with the browser's back
3092 button. I still need to modify the servlet to work with multiple
3093 documents so all demo links will load the file defined in the
3094 OnlineGlom.properties.
3096 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3097 This is only useful during development so we don't need to save it.
3098 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3099 get a reference to the DemoSelectionView.
3100 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3101 method to get a reference to the DemoSelectionView.
3102 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3103 default view to DemoSelectionView.
3104 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3105 to get glom document titles for glom files in a hard-coded directory.
3106 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3107 method to get glom document titles for glom files in a hard-coded
3109 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3110 Presenter for DemoSelectionView.
3111 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3112 for DemoSelectionView.
3113 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3114 Update for DemoSelectionView.
3115 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3116 Basic 'Place' implementation for the DemoSelectionView.
3117 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3118 The interface for the DemoSelectionView.
3119 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3120 The implementation of the DemoSelectionView.
3121 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3122 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3123 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3124 implementation of method to get glom document titles for glom files
3125 in a hard-coded directory.
3126 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3127 on longer being used.
3128 * src/main/webapp/glom.png: Glom logo.
3130 2011-04-05 Ben Konrath <ben@bagu.org>
3132 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3134 This is the forth and final commit of a refactor that will allow
3135 OnlineGlom to be used with multiple documents.
3137 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3138 Move RPC code from OnlineGlomViewImpl to this class.
3139 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3141 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3142 RPC code to the presenter class (the P in MVP).
3144 2011-04-04 Ben Konrath <ben@bagu.org>
3146 Start moving the existing OnlineGlom code to MVP.
3148 This work is based on the GWT MVP framework that is documented here:
3150 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3152 This is the third commit of a refactor that will allow OnlineGlom to
3153 be used with multiple documents.
3155 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3156 Interface for client factory which is used to get instances of various
3157 classes throughout the app.
3158 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3159 Implementation of client factory.
3160 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3161 initialize the MVP framework.
3162 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3163 New file. Activity manager for the main container widget. This is the
3165 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3166 Maps place (URL) to its corresponding activity.
3167 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3168 New file. This is just a place holder for a generated file.
3169 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
3170 New file. Represents the URL for the main Online Glom app.
3171 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
3172 for changes in LayoutListViewImpl.
3173 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
3174 interface for View. Move code to OnlineGlomViewImpl class.
3175 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
3176 file. Implementation of OnlineGlomView.
3177 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
3178 Place resources. Use ClientFactoryImpl by default.
3180 2011-04-04 Ben Konrath <ben@bagu.org>
3182 Move View classes to their own package.
3184 This is the second commit of a refactor that will allow OnlineGlom to
3185 be used with multiple documents.
3187 * src/main/java/org/glom/web/client/OnlineGlom.java:
3188 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
3189 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
3191 2011-04-02 Ben Konrath <ben@bagu.org>
3193 Move UI code from the main module to its own class.
3195 This is the first commit of a refactor that will allow OnlineGlom to be
3196 used with multiple documents.
3198 * src/main/java/org/glom/web/client/LayoutListView.java: Update
3199 references to OnlineGlom to OnlineGlomView.
3200 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
3201 OnlineGlomView and instantiate it here.
3202 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
3203 represents the main OnlineGlomView with one document.
3205 2011-04-01 Ben Konrath <ben@bagu.org>
3207 Fix formatting of gwt.xml and add DTD.
3209 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
3211 2011-03-30 Ben Konrath <ben@bagu.org>
3213 Propperly convert gdkColor string to html colour string.
3215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3217 2011-03-28 Ben Konrath <ben@bagu.org>
3219 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
3221 This implementation matches
3222 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
3223 readable and is not tied to Swig.
3225 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3227 2011-03-28 Ben Konrath <ben@bagu.org>
3229 Use read-only checkboxes for boolean field types.