1 2012-05-06 Murray Cumming <murrayc@murrayc.com>
3 ConfiguredDocument: Avoid a null dereference.
5 * src/main/java/org/glom/web/server/ConfiguredDocument.java
6 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
7 details maps are created.
9 2012-05-06 Murray Cumming <murrayc@murrayc.com>
11 Document: Correct the port number parsing.
13 * src/main/java/org/glom/web/server/libglom/Document.java:
14 This lets us actually connect to the database and show the document.
16 2012-05-05 Murray Cumming <murrayc@murrayc.com>
20 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
21 user-interaction, asking us to load a temporary URL in a browser.s
22 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
23 which is apparently necessary for testing the service. See the comment.
24 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
25 Show the exception, if any. This is how I saw the 404 in the HTML in
28 2012-05-05 Murray Cumming <murrayc@murrayc.com>
30 DocumentTest: Move the .glom files into the resources directory.
32 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
33 URI via getResource().
35 2012-05-05 Murray Cumming <murrayc@murrayc.com>
37 Document: Remove the FieldIdentifies inner class.
39 * src/main/java/org/glom/web/server/libglom/Document.java: We only
40 use the Relationship (though the same function in libglom is maybe
41 used in other ways) and so this removes a compiler warning.
43 2012-05-05 Murray Cumming <murrayc@murrayc.com>
45 Document.load() Remove the error code parameter.
47 * src/main/java/org/glom/web/server/libglom/Document.java: load():
48 Remove the parameter. We do not set it yet and it could never have
49 worked as an output parameter (though maybe it did in java-libglom).
50 We could use an exception if we really want the failure reason.
51 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
53 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
54 setUp(), testGetSuitableTableToViewDetails(): Adapt.
56 2012-05-05 Murray Cumming <murrayc@murrayc.com>
58 Make some inner classes static.
60 * src/main/java/org/glom/web/server/ConfiguredDocument.java
61 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
62 * src/main/java/org/glom/web/server/ReportGenerator.java
63 * src/main/java/org/glom/web/server/libglom/Document.java
64 Make all inner classes static that can be static.
66 2012-05-05 Murray Cumming <murrayc@murrayc.com>
68 OnlineGlomServiceImpl: Do not load and check for java-libglom.
70 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
71 init(): We do not use java-libglom any more.
73 2012-05-05 Murray Cumming <murrayc@murrayc.com>
75 Remove mentions of java-libglom.
77 * README: Remove mention of java-libglom, because it no longer needed.
78 * utils/build-onlineglom-war.sh:
79 * utils/check-and-recover-tomcat.py:
80 * utils/install-onlineglom-war.sh: Remove these as they are no longer
81 useful. Building is now far easier, with no need for jhbuild.
83 2012-05-05 Murray Cumming <murrayc@murrayc.com>
85 Fix the build (mvn package)
87 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
88 (LayoutGroup): Make the LayoutItemList inner class static and protected.
89 Otherwise the GWT Java->Javascript compilation fails with just this
90 error, during mvn package or when attempting to view in a browser,
91 in the GWT developer mode in Eclipse.
93 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
94 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
95 [INFO] Compiling module org.glom.web.OnlineGlom
96 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
97 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
98 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
99 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
100 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
101 [INFO] [ERROR] Cannot proceed due to previous errors
103 It has taken me 2 days to find out what was causing that. After reducing
104 the code, the compiler eventually showed me the full error message.
106 2012-05-04 Murray Cumming <murrayc@murrayc.com>
108 ConfiguredDocument: Cache the cloned and stripped layouts.
110 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
111 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
112 layout in a map, so we can retrieve it again without rebuilding it.
114 2012-05-04 Murray Cumming <murrayc@murrayc.com>
116 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
118 2012-05-04 Murray Cumming <murrayc@murrayc.com>
120 libglom classes: Implement some auto-generated emthods.
122 2012-05-04 Murray Cumming <murrayc@murrayc.com>
124 Add GwtTestOnlineGlomService.
126 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
127 However, this (and the other GwtTest*) does not seem to run during
130 2012-05-04 Murray Cumming <murrayc@murrayc.com>
132 Remove use of unsupported features from client code.
134 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
135 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
136 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
137 Use our client version of StringUtils instead of the apache commons one.
139 However, the GWT Javascript compliation still fails.
141 2012-04-25 Murray Cumming <murrayc@murrayc.com>
143 Add a Field class and implement some loading of it in Document.
145 2012-04-25 Murray Cumming <murrayc@murrayc.com>
147 Initial Document loading implementation, instead of libglom.
149 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
150 and Translatable classes, and adapt the rest of the code to use them.
151 However, this is still missing Layout and Field classes and loading.
153 2012-04-24 Murray Cumming <murrayc@murrayc.com>
155 Use of jOOQ: Move Field creation into a utility method.
157 * src/main/java/org/glom/web/server/SqlUtils.java:
158 This lets us improve it more easily.
160 2012-04-24 Murray Cumming <murrayc@murrayc.com>
162 Use of jOOQ: Improve the code to COUNT a sub-select.
164 * src/main/java/org/glom/web/server/SqlUtils.java:
165 Move initial query creation into
166 build_sql_select_step_with_where_clause().
167 build_sql_select_count_rows(): Use the jOOQ API instead of
168 concatentating text, because a jOOQ Select*Step is a TableLike,
169 which is what from() takes.
171 2012-04-23 Murray Cumming <murrayc@murrayc.com>
173 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
175 * pom.xml: Depend on jooq.
176 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
177 methods with jOOQ, based on the C++ implementations in libglom,
178 with some changes to the logic required by jooQ.
179 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
181 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
182 * src/main/java/org/glom/web/server/ReportGenerator.java:
183 * src/main/java/org/glom/web/server/SqlUtils.java:
184 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
185 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
186 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
187 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
188 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
189 Adapt. In particular, the SqlUtils methods now need to take a Connection,
190 because jOOQ needs that, though it seems unnecessary.
192 This is not quite finished. Ideally jOOQ would help us to build
193 table_name.field_name names, quoting and escaping them properly.
194 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
196 2012-04-21 Murray Cumming <murrayc@murrayc.com>
198 Move use of Glom.build_sql*() into a new SqlUtils class.
200 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
201 to wrap Glom.build_sql*(). The parameter types are still Glom one,
202 but this will make it easier to start using something other than
203 libglom or SqlBuilder.
205 2012-04-21 Murray Cumming <murrayc@murrayc.com>
207 Update the project URL.
209 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
211 2012-04-21 Murray Cumming <murrayc@murrayc.com>
213 Main layout: Use a FlowTable instead of absolute positioning.
215 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
216 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
217 child panels/widgets must have an absolute position. But that is annoying, so
218 this adds a FlowTable and puts the child panels in there.
220 2012-04-21 Murray Cumming <murrayc@murrayc.com>
222 GwtTestOnlineGlom: Comment out unused code.
224 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
225 Eclipse has started to say that some code is unused.
227 2012-04-21 Murray Cumming <murrayc@murrayc.com>
229 Update to the latest versions of dependencies.
231 * pom.xml: Update version numbers of dependencies to the latest
233 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
234 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
235 * src/main/java/org/glom/web/server/ReportGenerator.java:
236 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
237 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
238 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
240 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
241 Modify the imports where necessary.
243 2012-04-17 Murray Cumming <murrayc@murrayc.com>
245 Style: Remove overflow:hidden from searchbox
247 * src/main/webapp/style.css: Because this pushes the Back To Link
248 label/link on to the next row, which is then hidden due to the
249 hard-coded (in ems) height.
251 2012-04-20 Murray Cumming <murrayc@murrayc.com>
253 Remove some duplicate code.
255 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
256 getDocumentInfo(): This must have been duplicated during the merge from the
261 2012-04-19 Murray Cumming <murrayc@murrayc.com>
263 Reports: Localize the waiting for report message.
265 * src/main/java/org/glom/web/client/activity/ReportActivity.java
266 start(): Get the message from the contants.
267 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
269 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
270 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
271 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
272 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
273 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
274 Update these files with the English text for newer strings for now.
276 2012-04-19 Murray Cumming <murrayc@murrayc.com>
278 Reports: Show a message while waiting for the report.
280 * src/main/java/org/glom/web/client/ui/ReportView.java
281 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
282 Add setWaitingText(), to show a message saying that we are
283 waiting for the report to be ready.
284 * src/main/java/org/glom/web/client/activity/ReportActivity.java
285 start(): Call setWaitingText() before calling the async
288 2012-04-19 Murray Cumming <murrayc@murrayc.com>
290 ReportGenerator: Specify date and time formats.
292 * src/main/java/org/glom/web/server/ReportGenerator.java:
293 createFieldValueElement(): Use the default (and localized)
294 short formats, though we still need a way to show 4-digit
295 years without providing the format for every locale.
296 * src/main/java/org/glom/web/server/database/DBAccess.java:
297 convertResultSetToDTO(): Use the short formats here too.
299 2012-04-18 Murray Cumming <murrayc@murrayc.com>
301 ReportGenerator: Use the correct numeric formatting.
303 * src/main/java/org/glom/web/server/ReportGenerator.java
304 createFieldExpression(), createFieldValueElement(): Take the
305 whole LayoutItem_Field instead of just the field name, so
306 we have access to the formatting.
307 createFieldValueElement(): Use JRTextField.setPattern() to
308 specify the numeric formatting, with the help of a
309 regular DecimalFormat.
311 2012-04-18 Murray Cumming <murrayc@murrayc.com>
313 ReportGenerator: Avoid showing null for group by titles.
315 * src/main/java/org/glom/web/server/ReportGenerator.java
316 generateReport(): Use setBlankWhenNull() on the field title
317 style too, because this is used for values in group by
320 2012-04-18 Murray Cumming <murrayc@murrayc.com>
322 ReportGenerator: Add a colon to titles in vertical groups.
324 * src/main/java/org/glom/web/server/ReportGenerator.java
325 addFieldToDetailBandVertical(): Pass true for the withColon
328 2012-04-18 Murray Cumming <murrayc@murrayc.com>
330 ReportGenerator: Simplify the code by using Position more.
332 2012-04-18 Murray Cumming <murrayc@murrayc.com>
334 Reports: Support vertical groups, roughly.
336 * src/main/java/org/glom/web/server/ReportGenerator.java:
337 addToReport(): Rename to addGroupToReport() and, if necessary,
338 call the new addVerticalGroupToReport() method.
339 createFieldValueElement(): Let the caller specify the Y position
342 2012-04-17 Murray Cumming <murrayc@murrayc.com>
344 Reports: Allow a second report to be shown.
346 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
347 clear(): Do not remove the HTML widget, which broke the whole layout.
349 2012-04-17 Murray Cumming <murrayc@murrayc.com>
351 Locales drop-down: Show that we use English by default.
353 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
354 fillView(): When we use English, just because that is the default, when
355 no locale is specified, show that in the Locales drop-down instead of
356 just showing the first item.
358 2012-04-17 Murray Cumming <murrayc@murrayc.com>
360 Unselect the Report/Locale/Table combo item when appropriate.
362 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
363 setPlace(): clear reportName if this is not a ReportPlace.
364 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
365 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
366 When the provided name is empty, unselect all items, so that none are
367 indicated. This uses a for loop because I cannot find a single method
370 2012-04-17 Murray Cumming <murrayc@murrayc.com>
372 Report: Give the user a way to get back to the list.
374 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
375 start(), setPlace(): Show the Back To List link on reports, and also
376 interpret selecting the empty report item as back to list.
378 2012-04-13 Murray Cumming <murrayc@murrayc.com>
380 Really show the selected Report name.
382 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
383 setPlace(): Store the reportName here, if it is that kind of Place.
384 fillView(): Set the selected Report after filling the list of reports.
385 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
386 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
387 null Strings, though we need some way to unselect all ListBox items
390 2012-04-13 Murray Cumming <murrayc@murrayc.com>
392 ReportGenerator: Try to avoid some problems.
394 * src/main/java/org/glom/web/server/ReportGenerator.java
395 addField(): Try to avoid duplicates, and avoid using a null
398 2012-04-13 Murray Cumming <murrayc@murrayc.com>
400 Reports: Use quickFind.
402 * src/main/java/org/glom/web/client/OnlineGlomService.java;
403 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
404 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
405 getReportHTML(): Add a quickFind parameter.
406 * src/main/java/org/glom/web/client/activity/ReportActivity.java
407 start(): Pass the quickFind parameter.
408 * src/main/java/org/glom/web/server/ReportGenerator.java
409 generateReport(): Take a quickFind parameter.
411 2012-04-13 Murray Cumming <murrayc@murrayc.com>
413 ReportPlace: Actually use the report name.
415 * src/main/java/org/glom/web/client/place/ReportPlace.java
416 getPlace(): Do not assign the report name to the quickfind.
418 2012-04-13 Murray Cumming <murrayc@murrayc.com>
420 Show java.library.path when complaining.
422 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
423 init(): When telling us to check java.library.path, show the
426 2012-03-06 Murray Cumming <murrayc@murrayc.com>
428 ReportGenerator: Do not show nulls.
430 2012-03-06 Murray Cumming <murrayc@murrayc.com>
432 ReportGenerator: Make the title font larger.
434 2012-03-06 Murray Cumming <murrayc@murrayc.com>
436 ReportGenerator: Put field titles inside groups, if there are groups.
438 2012-03-06 Murray Cumming <murrayc@murrayc.com>
440 ReportGenerator: Take the Report itself instead of the name and group.
442 * src/main/java/org/glom/web/server/ConfiguredDocument.java
443 Remove getReportLayoutGroup().
444 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
445 getReportHTML(): Pass the report instead
446 of its name and layout group.
447 * src/main/java/org/glom/web/server/ReportGenerator.java
448 generateReport(): Use the report object to use the title
451 2012-03-06 Murray Cumming <murrayc@murrayc.com>
453 ReportGenerator: Remove designBand parameters.
455 * src/main/java/org/glom/web/server/ReportGenerator.java:
456 Make designBand a class member instead of passing it to all
459 2012-03-06 Murray Cumming <murrayc@murrayc.com>
461 ReportGenerator: Add lines, a bit like in the desktop version.
463 * src/main/java/org/glom/web/server/ReportGenerator.java
464 addToReport(): Use JRDesignLine.
466 2012-03-06 Murray Cumming <murrayc@murrayc.com>
468 ReportGenerator: Correct the title positions and use some bold style.
470 * src/main/java/org/glom/web/server/ReportGenerator.java:
471 Break the code up into reusable functions, correct the placement of
472 titles, and use normal/bold styles as in the reports in the desktop
475 2012-03-06 Murray Cumming <murrayc@murrayc.com>
477 ReportGenerator: Add a header band to show the field titles.
479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
480 getReportHTML(): Pass the localeId to the ReportGenerator
482 * src/main/java/org/glom/web/server/ReportGenerator.java
483 constructor: Take the localeID so we can get translated field
485 generateReport(), addToReport(), addFieldToBand(): Add field
486 titles in a column header band.
488 2012-03-05 Murray Cumming <murrayc@murrayc.com>
490 Reports drop-down list: Some improvement.
492 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
493 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
494 Adedd setSelectedReport(),
495 setReportList(): Add a blank line so that the user can select the
497 * src/main/java/org/glom/web/client/activity/ReportActivity.java
498 start(): Show the current report by calling setSelectedReport().
499 This does not seem to work yet.
501 2012-03-05 Murray Cumming <murrayc@murrayc.com>
503 DetailsActivity, ListActivity: Move some variables into a base class.
505 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
506 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
507 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
508 the clientFactory, documentID, tableName and authenticationPopup into
509 a base class, to avoid duplication.
511 2012-03-05 Murray Cumming <murrayc@murrayc.com>
513 Translate the Reports label.
515 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
516 Get the "Reports" label string from the constants.
517 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
518 perties: Add Reports to the constants.
520 2012-03-05 Murray Cumming <murrayc@murrayc.com>
522 Reports: Implement grouping.
524 * src/main/java/org/glom/web/server/ReportGenerator.java:
525 Handle LayoutItem_GroupBy items and try to do the right thing
526 with JRDesignGroup. It seems to work.
528 2012-03-04 Murray Cumming <murrayc@murrayc.com>
530 Actually show some data with JasperReports.
532 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
533 getReportHTML(): Move most code into a ReportGenerator class.
534 * src/main/java/org/glom/web/server/ReportGenerator.java:
535 Recurse into sub-groups, adding fields to the JasperDesign's details
536 band. Note that we must set an arbitrary width and height, or it just
537 will not show any data.
539 2012-03-04 Murray Cumming <murrayc@murrayc.com>
541 Reports Chooser: Show the titles, not the names.
543 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
544 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
545 and the names as the values.
546 * src/main/java/org/glom/web/server/ConfiguredDocument.java
547 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
548 group now that we provide the report name, so it should always
551 2012-02-15 Murray Cumming <murrayc@murrayc.com>
553 Depend on jasperreports.
555 * pom.xml: Add the dependency. My plan is to use this on the
558 2012-01-31 Murray Cumming <murrayc@murrayc.com>
560 Implement navigation to report places.
562 * src/main/java/org/glom/web/client/activity/ReportActivity.java
563 start(): Do not bother to handle all events here.
564 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
565 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
566 Added getSelectedReport().
567 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
568 .java: start(): When handling a change to the reports chooser,
569 call getSelectedReport() and goTo() its ReportPlace.
570 * src/main/java/org/glom/web/client/ui/ReportView.java
571 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
572 Added setReportHTML() which puts the html in a gwt HTML widget.
573 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
574 getReportHTML(): Return "TODO" just to show that this works.
576 2012-01-31 Murray Cumming <murrayc@murrayc.com>
578 Make ReportPlace usable.
580 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
582 * src/main/java/org/glom/web/client/place/ReportPlace.java:
583 Correct the @prefix annotation.
585 2012-01-31 Murray Cumming <murrayc@murrayc.com>
587 OnlineGlomService: Return report HTML rather than the LayoutGroup.
589 * src/main/java/org/glom/web/client/OnlineGlomService.java:
590 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
591 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
592 Change getReportLayout() to getReportHMTL() because we will not need to
593 parse or render the report layout on the client side.
594 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
595 getReportLayout(): Return the libglom LayoutGroup type because we will
596 not need to convert to a shared type, because this will not be used on
598 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
601 Note that there is still no implementation for this.
604 2012-01-27 Murray Cumming <murrayc@murrayc.com>
606 Add a (empty) Report Place, View, and Activity.
608 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
610 * src/main/java/org/glom/web/client/place/HasTablePlace.java
611 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
612 this into a superclass:
613 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
614 and also use it as the base of this new ReportPlace:
615 * src/main/java/org/glom/web/client/place/ReportPlace.java
617 * src/main/java/org/glom/web/client/ui/ReportView.java
618 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
619 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
620 Add these, containing mostly boiler-plate for now.
622 * src/main/java/org/glom/web/client/OnlineGlomService.java
623 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
624 * src/main/java/org/glom/web/server/ConfiguredDocument.java
625 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
626 Add API to get the LayoutGroup for the report.
628 2012-01-23 Murray Cumming <murrayc@murrayc.com>
630 Add and fill a Reports drop-down list box.
632 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
634 * src/main/java/org/glom/web/client/OnlineGlomService.java:
635 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
636 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
637 Added getReports(document, table, localeID), calling
638 ConfiguredDocument.getReports().
639 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
640 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
641 Added setReportsList() and a list widget.
642 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
643 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
648 2012-04-12 Murray Cumming <murrayc@murrayc.com>
650 Translations: Add Esperanto.
652 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
653 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
654 properties: Add this translation because someone took the time to make it.
656 2012-03-15 Murray Cumming <murrayc@murrayc.com>
658 Adapt to the java-libglom 1.21.7 API.
660 * src/main/java/org/glom/web/server/ReportGenerator.java:
661 addToReport(): get_group_secondary_fields() is now
662 get_secondary_fields().
665 2012-03-15 Murray Cumming <murrayc@murrayc.com>
667 Use the latest java-libglom version.
669 * pom.xml: Use java-libglom 1.21.7.
671 2012-03-03 Ben Konrath <ben@bagu.org>
673 Display date and time in details view.
675 https://bugzilla.gnome.org/show_bug.cgi?id=671257
677 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
679 2012-03-05 Murray Cumming <murrayc@murrayc.com>
681 Require the latest java-libglom.
683 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
685 2012-03-04 Murray Cumming <murrayc@murrayc.com>
687 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
689 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
690 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
691 an empty quickfind string. I also corrected libglom to create only
692 empty where clauses for empty quickfind strings, but this avoids the
695 2012-02-24 Ben Konrath <ben@bagu.org>
697 Improve the tabs in the Notebook widget.
701 2012-01-30 Murray Cumming <murrayc@murrayc.com>
703 Translations: Try to translate the strings.
705 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
706 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
707 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
708 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
709 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
710 Take the Open translation from GTK+'s .po files.
711 Take the Details translation from Glom's po files.
712 I have added the other strings to Glom so we can get translations that way:
713 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
715 2012-01-27 Murray Cumming <murrayc@murrayc.com>
717 TableSelectionViewImpl: Put the search label and entry in a div.
719 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
720 Put the search widgets in a FlowTable so that the CSS can be used to
721 style them while keeping them together.
722 * src/main/webapp/style.css: Mention the new div.
724 2012-01-27 Murray Cumming <murrayc@murrayc.com>
726 Translate more strings in more locales.
728 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
729 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
730 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
731 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
732 Translate the "Details" and "Open" string too.
734 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
735 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
736 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
737 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
738 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
739 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
740 Add these new locales as placeholders though they currently contain English.
742 2012-01-27 Murray Cumming <murrayc@murrayc.com>
744 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
746 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
747 Check the ConfiguredDocument* for null before using it.
749 2012-01-26 Murray Cumming <murrayc@murrayc.com>
751 Tell Eclipse about the generated java files.
753 * .classpath: This lets it find OnlineGlomConstants.java.
754 It would be nice if Eclipse just used the maven build files.
756 2012-01-26 Murray Cumming <murrayc@murrayc.com>
758 Prevent a crash when no locale is specified in the URL.
760 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
761 Avoid returning a null string, obtained from
762 Window.Location.getParameter(). This caused a crash when it was
763 later passed to libglom's API.
764 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
765 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
766 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
767 guard against future null strings.
769 2012-01-26 Murray Cumming <murrayc@murrayc.com>
771 Use the ?locale= query param instead of the &lang= token param.
773 * src/main/java/org/glom/web/client/place/ListPlace.java
774 * src/main/java/org/glom/web/client/place/DetailsPlace.java
775 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
776 Remove the lang token key and value.
778 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
779 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
780 When the user selects a different locale from the chooser, use
781 Window.Location.assign() to change the URL, which then causes a reload.
783 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
784 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
785 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
786 * src/main/java/org/glom/web/client/activity/ListActivity.java
787 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
788 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
789 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
790 * src/main/java/org/glom/web/client/ui/ListView.java:
791 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
793 Remove localeID member variables and method/constructor parameters, instead
794 using Utils.getCurrentLocaleID() when we need a localID to pass to
797 2012-01-26 Murray Cumming <murrayc@murrayc.com>
799 Internationalize the UI strings.
801 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
802 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
803 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
804 because it is unused. Messages are apparently strings that can have
805 parameters, but we do not need that yet, so Contants will be enough for now.
806 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
807 to say that we support the en and de locales.
808 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
809 The original English strings.
810 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
811 Some German translations of the English strings.
812 The i18n goal then uses the .properties file to generate an
813 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
814 returns an implementation that returns the translated strings.
815 The documentation suggests putting these in src/java/*/client/, but it seems
816 best to put it in src/resources/*/client/.
817 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
818 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
819 instead of hard-coding them.
820 Note that we cannot import OnlineGlomConstants because it does not exist yet,
821 but that does not seem to stop the build, though it confuses Eclipse.
823 You can see the translated string by adding ?locale=de to the URL, like so:
824 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
826 2012-01-24 Murray Cumming <murrayc@murrayc.com>
828 Improve null/empty String checks.
830 * pom.xml: Add a dependency on commons-lang, to use
831 org.apache.commons.lang.StringUtils.
832 * src/main/java/org/glom/web/server/ConfiguredDocument.java
833 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
834 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
835 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
836 Use StringUtils.isEmpty().
838 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
839 StringUtils class with a static isEmpty() function because we
840 cannot use org.apache.commons.lang.StringUtils in client-side
841 GWT code because it (apparently) cannot be compiled to javascript.
842 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
843 * src/main/java/org/glom/web/client/activity/ListActivity.java
844 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
845 * src/main/java/org/glom/web/client/place/DetailsPlace.java
846 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
847 * src/main/java/org/glom/web/client/place/ListPlace.java
848 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
849 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
850 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
851 * src/main/java/org/glom/web/client/ui/details/Group.java
852 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
853 our StringUtils.isEmpty() function.
855 2012-01-24 Murray Cumming <murrayc@murrayc.com>
857 Update to the latest java-libglom API.
859 * pom.xml: Require java-libglom 1.21.4.
860 * src/main/java/org/glom/web/server/ConfiguredDocument.java
861 getDocumentInfo(), getListViewLayoutGroup():
862 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
864 * src/main/java/org/glom/web/server/database/DBAccess.java
865 getFieldsToShowForSQLQueryAddGroup(),
866 getPrimaryKeyLayoutItemField(): Replace get_database_title()
867 with either get_database_title_original() or
868 get_database_title(localeID).
870 2012-01-24 Murray Cumming <murrayc@murrayc.com>
872 ConfiguredDocument: Avoid a null pointer exception.
874 * src/main/java/org/glom/web/server/ConfiguredDocument.java
875 Initialize localeID to "" to avoid returning a null String which
876 causes a crash in java-libglom's swing-generated code.
878 2012-01-23 Murray Cumming <murrayc@murrayc.com>
880 Some simple renaming.
882 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
883 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
884 for localeChooser. This seems more appropriate and is less ambiguous
885 particularly in the .css file.
887 2012-01-23 Murray Cumming <murrayc@murrayc.com>
889 ConfiguredDocument: Rename the localedID private member variable.
891 2012-01-23 Murray Cumming <murrayc@murrayc.com>
893 Adapt to the latest java-libglom API from git master.
895 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
896 libglom now uses only Vector instead of List, which uses add() instead of
899 2012-01-22 Murray Cumming <murrayc@murrayc.com>
901 ConfiguredDocument: Rename the localedID private member variable.
903 2012-01-20 Murray Cumming <murrayc@murrayc.com>
905 Build a source tarball with mvn assembly:single
907 * assembly.xml: Add this file.
908 * pom.xml: Use the maven-assembly-plugin and tell it to use
909 our assembly.xml file.
911 2012-01-19 Murray Cumming <murrayc@murrayc.com>
913 OnlineGlomServiceImpl: Get .glom files recursively.
915 * pom.xml: Depend on commons-io from org.apache.commons.
916 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
917 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
918 files recursively, and with the easier filter for the extension.
919 Use org.apache.commons.io.FilenameUtils.removeExtension() to
920 simplify that code too.
922 2012-01-19 Murray Cumming <murrayc@murrayc.com>
924 README: Mention that you must install java-libglom packages separately.
926 But then it works, because java-libglom is now in the central maven
929 2012-01-18 Murray Cumming <murrayc@murrayc.com>
931 locales drop-down: Show the correct selected locale when the URL changes.
933 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
934 .java: setPlace(): Move some code into fillView().
936 2012-01-18 Murray Cumming <murrayc@murrayc.com>
938 locales drop-down: Do not lose the primary key.
940 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
941 start(): onLocaleChange(): Pass the current primary key value,
942 instead of an empty value.
944 2012-01-18 Murray Cumming <murrayc@murrayc.com>
946 locales drop-down: Do not lose the drop-down selection.
948 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
949 .java (TableSelectionActivity.fillView): Set the selected locale
950 after changing the drop-down items (though we do not really need
951 to change them just because the locale changes.)
953 2012-01-18 Murray Cumming <murrayc@murrayc.com>
955 locales drop-down: Change the tables list when this changes.
957 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
958 .java: TableSelectionActivity.start(): Move the async table titles
959 retrieval into a private fillView() method and also call this when
960 the chosen locale changes.
961 Note that the document title is not actually translatable yet, but
962 that is a problem that I should fix soon in libglom.
964 2012-01-18 Murray Cumming <murrayc@murrayc.com>
966 Improve the placement of the locales drop-down.
968 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
969 Put the title and locales drop-down in a div (gwt.FlowTable).
970 * src/main/webapp/style.css: Add magic css properties to make this work.
971 Also remove the left margin from the title so that it lines up with the
974 2012-01-18 Murray Cumming <murrayc@murrayc.com>
976 locales selector: Show human-readable locale titles.
978 * src/main/java/org/glom/web/server/ConfiguredDocument.java
979 getDocumentInfo(): Use java.util.Locale to show a real title of
980 each locale, in the locale's own language.
982 2012-01-17 Murray Cumming <murrayc@murrayc.com>
984 Add a language/locale selector drop-down.
986 * src/main/java/org/glom/web/shared/DocumentInfo.java:
987 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
988 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
989 getDocumentInfo(): Store the available Locales in the DocumentInfo.
990 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
991 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
992 Add a ListBox to show the available locales. Add getLocaleSelector(),
993 setLocaleList(), getSelectedLocale(), setSelectedLocale().
994 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
995 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
996 java: Add these classes.
997 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
998 start(): Fill the locales ListBox. Handle its change event, firing a
1000 setPlace(): Show the selected locale as specified by the URL token.
1001 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1002 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1003 Handle LocaleChangeEvent, going to a new *Place with that locale.
1005 The placement of the ListBox is not pretty, and it currently uses the ID
1006 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1010 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1012 Search box: Show the search text from the URL token.
1014 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1015 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1016 Add setQuickFindText().
1017 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1018 .java: setPlace(): Store the queryText if the place is a ListPlace,
1019 and call TableSelectionView.setQuickFindText().
1021 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1023 Allow use of translations via, for instance, &lang=de in the URL.
1025 * pom.xml: Use the unstable java-libglom 1.21 version.
1027 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1028 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1029 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1030 init(): Instead of calling TranslatableItem.set_current_locale()
1031 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1032 However, this is only for default locales, which are not needed to
1033 change the locale in the URL.
1034 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1035 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1036 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1037 layout for a particular locale.
1038 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1039 Add get/setDefaultLocaleID().
1040 getDocumentInfo(), getListViewData(), getRelatedListData(),
1041 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1042 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1043 localeID parameter, so we can get the layout for a particular locale.
1045 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1046 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1047 * src/main/java/org/glom/web/client/place/ListPlace.java:
1048 Parse and construct a lang parameter too.
1050 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1051 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1052 passed to subsequent methods and constructors.
1053 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1054 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1055 Store the localeID from the *Place and pass it to other constructors
1056 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1058 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1059 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1060 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1061 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1062 * src/main/java/org/glom/web/client/ui/ListView.java:
1063 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1064 Take localeID parameters and pass them to subsequent constructors and
1065 methods, so that the layout is always retrieved for that locale.
1067 This is rather repetitive.
1069 Note that "" means the original (default) locale of the Glom document,
1070 which is usually English.
1072 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1074 Documents: Remove final keyword to fix startup configuration.
1076 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1077 final keywords on the private member variables because that breaks
1078 the startup, apparently (there are warnings) because it stops them
1079 from being serialized. I added these in the previous commit.
1081 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1083 Documents: Add some final keywords.
1085 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1088 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1090 OnlineGlomServiceImpl: Add to overview comments.
1092 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1093 Note that this is where all the document are loaded. They are not
1094 loaded freshly for each page.
1096 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1100 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1101 Add a TextBox for the text of a quick find.
1102 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1104 setBackLink(): Add a String quickFind parameter.
1105 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1106 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1107 to the base interface, because that is how TableSelectionViewImpl is used.
1108 * src/main/webapp/style.css: Add style for the search box and its label.
1110 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1111 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1112 Add these files, based on the existing TableChangeEvent and
1113 TableChangeEventHandlers.
1114 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1115 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1116 a ListPlace() that the user should be taken to.
1117 * src/main/java/org/glom/web/client/activity/ListActivity.java
1118 start(): Handle it here too and adapt the TableChangeEvent handler to
1119 pass the extra "" quickFind parameter to ListPlace.
1120 * src/main/java/org/glom/web/client/place/ListPlace.java:
1121 Constructor: Take an extra String quickFind parameter and store it,
1122 returning it from a new getQuickFind() method.
1123 getToken(): Put the quickFind text in the URL token.
1124 getPlace(): Parse the quickFind text from the URL token.
1125 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1126 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1127 ListPlace constructor.
1128 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1129 .java: start(): Add a Change handler for the TableSelectionView's
1130 TextBox (via its base HasChangeHandlers interface), firing the new
1131 QuickFindChangeEvent.
1132 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1133 pass the extra "" quickFind parameter.
1135 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1136 setCellTable(): Add a String quickFind parameter and pass it to
1137 the ListViewTable() constructor.
1138 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1139 setCellTable() in the base interface, because that is how ListViewImpl
1142 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1143 Add a String quickFind member variable.
1144 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1145 Constructor: Add a String quickFind parameter, storing it in the
1146 base ListTable's member variable.
1147 onRangeChanged(): Pass quickFind to the
1148 OnlineGlomServiceAsync.getSortedListViewData() and
1149 OnlineGlomServiceAsync.getListViewData() methods.
1151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1152 getListViewData(), getSortedListViewData(): Add a String quickFind
1153 parameter, passing it to ConfiguredDocument.getListViewData().
1154 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1155 Change getListViewData(), getSortedListViewData() in the base interface,
1156 because that is how OnlineGlomServiceImpl is used, via this:
1157 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1158 Change getListViewData(), getSortedListViewData() here too.
1159 This class can apparently be used to asynchronously call methods on
1160 OnlineGlomService, and GWT seems to implement that after recognizing
1161 just the *Async name convention and the extra AsyncCallback parameters.
1163 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1164 getListViewData(): Add a String quickFind parameter, and pass it to
1165 ListViewDBAccess.getData().
1166 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1167 getListData(): Add a String quickFind parameter and pass it to
1169 getSelectQuery(): Add a String quickFind parameter.
1170 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1171 getSelectQuery(): Add a String quickFind parameter and use it with
1172 Glom.get_find_where_clause_quick() to pass a where_clause to
1173 Glom.build_sql_select_with_where_clause(), to actually filter the
1175 getData(): Add a String quickFind parameter, passing it to getListData().
1176 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1177 va: getData(): Pass an empty string to getListData() for the
1178 quickFind parameter.
1180 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1182 ListTable: Minor change.
1184 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1185 createCellTable(): Make this protected instead of public.
1187 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1189 Many files: Use final for the parameters and use the @override attribute.
1191 2012-01-22 Ben Konrath <ben@bagu.org>
1193 Add anchor links for single line text that starts with http, ftp and www.
1197 2012-01-22 Ben Konrath <ben@bagu.org>
1199 Add ellipsis to single line text in details view.
1203 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1205 Remove all javadoc author tags.
1207 Because they are awkward and meaningless when many people touch
1209 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1211 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1213 Revert the COPYING.LESSER to COPYING rename.
1215 Apparently both should be there if it is LGPL.
1217 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1219 *View: Remove unused imports.
1221 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1222 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1223 * src/main/java/org/glom/web/client/ui/ListView.java:
1224 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1225 Remove unused imports, as suggested by Eclipse.
1227 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1229 Move the *View::Presenter types, and some API into one base View.
1231 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1232 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1233 * src/main/java/org/glom/web/client/ui/ListView.java:
1234 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1235 Presenter, setPresenter() and clear() into a shared base interface,
1236 to avoid the unnecessary duplicate Presenter types and to more clearly
1237 show how the *Views share the same structure, even if they are not
1238 used polymorphically.
1240 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1241 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1243 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1244 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1245 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1247 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1250 Feel free to revert this if there is a good reason for the duplicate
1253 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1255 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1257 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1258 a class member instead of a local variable in the method.
1259 This lets us use it to get the view instances, for use in tests.
1260 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1261 beforeOnlineGlom(): Test some more details of the initial view.
1262 Again, this is not very useful.
1264 To really test gwt-glom we will need to start a local postgresql
1265 instance with local data, like the Glom tests in C++.
1267 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1269 pom.xml: Mention the LGPL license.
1271 * pom.xml: Add a licenses section.
1272 * COPYING.LESSER: Move this to COPYING, which
1273 previously contained the GPL. But gwt-glom is all LGPL.
1275 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1277 Add project information to README and pom.xml.
1279 * README: Add a brief description and mention some mvn
1281 * pom.xml: This extra information shows up in mvn site
1284 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1286 Use the latest java-libglom version.
1288 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1290 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1292 GwtTestOnlineGlom: Test a little more.
1294 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1295 protected rather than private, as suggested by the gwt-test-utils
1297 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1298 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1299 Test the initial visibility of the panels.
1301 However, this is not a very useful test.
1302 And I wonder how we should generally test using this idea for an
1303 activity/places app like ours where the real changes happen implicitly
1304 based on the history token/URL.
1306 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1308 Slight modification to *Mapper comments.
1310 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1311 (DataActivityMapper)
1312 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1314 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1316 Remove comments mentioning GIN because they are just copied from
1317 the example code and are apparently not helpful:
1318 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1319 Also change the mention of a class that is only in the example code.
1321 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1323 GwtTestOnlineGlom test: Minor changes.
1325 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1326 Avoid the long qualified class name and modify the comment
1327 because it is now obvious to me that the mocked class is the only
1328 custom one created via GWT.create().
1330 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1332 Tests: Added the beginnings of a test using gwt-test-utils.
1334 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1335 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1336 which tells gwt-test-utils what class will be tested.
1337 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1338 Add a simple (but empty) test case. One class, used by the OnlineGlom
1339 class, is mocked so that it can be created. However, I am not sure
1340 why only this class needs to be mocked.
1342 Note that mockito seems more popular, and clearer, than easymock,
1343 but I have not got that working yet. It might be a matter of the
1346 This test is run during mvn integration-test.
1348 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1350 Tests: Use junit4-style syntax instead of junit3-style.
1352 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1353 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1354 * src/test/java/org/glom/web/shared/DataItemTest.java:
1355 Use the @Test annotation rather than relying on the test*() prefix.
1356 Also no longer implement TestCase, to avoid triggering support for
1357 the junit3-way, which stops the annotations from working.
1358 Change the imports from import junit.framework.* to
1359 import org.junit.*, which is apparently the new way.
1361 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1363 Added a test for ListPlace token parsing and creation.
1365 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1366 This is much the same as DetailsPlaceTest.
1368 I wonder how we could test the other parts of the *Place API.
1370 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1372 DetailsPlace test: Also test getToken() and recreation via getPlace().
1374 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1375 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1376 recreate it, testing the recreated DetailsPlace for the same parameter
1379 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1381 Use the surefire-report plugin.
1383 * pom.xml: This generates a HTML report about the tests in
1384 target/site/surefire-report.html
1385 when you do mvn surefire-report:report. It seems to be popular/normal.
1387 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1389 Added a test for DetailsPlace.
1391 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1392 Test the getPlace() token parsing.
1394 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1396 Added a first unit test.
1398 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1399 * src/test/java/org/glom/web/shared/DataItemTest.java:
1400 This is a silly test but it is just to get things started. Note that
1401 maven/junit finds the test because it looks in src/test by default.
1403 2011-12-22 Ben Konrath <ben@bagu.org>
1405 Change charsetName to "UTF-8" when replacing line breaks.
1407 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1408 that work in Java (such as "UTF8") will not work when compiled to
1411 This fixes a problem with multi-line details view fields that have hard
1412 line breaks. The "License Text" field on this page demonstrates the
1415 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1417 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1419 2011-12-22 Ben Konrath <ben@bagu.org>
1421 Fix another bug with related list navigation.
1423 I've tested all the navigation buttons in all of the related lists
1424 so things should be good now.
1426 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1428 2011-12-22 Ben Konrath <ben@bagu.org>
1430 Fix a crasher when refreshing the list view with the default table.
1432 This crash will also happen when loading the list view with the default
1433 table from a link or bookmark.
1435 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1436 to the main document selection page when the document id hasn't been
1438 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1439 the main document selection page when the document id hasn't been
1441 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1442 values for the details place when the document id hasn't been set.
1443 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1444 values for the list place when the document id hasn't been set.
1446 2011-12-21 Ben Konrath <ben@bagu.org>
1448 Protect against NPE when glom.document.locale is not in config.
1450 This patch protects against an NPE when glom.document.locale is not in
1451 the config file. This NPE will also happen if glom.document.locale is
1454 The patch also updates the error message to display the class name when
1455 the getMessage() returns null. This was happening when the NPE was
1456 thrown and I had "Configuration Error: null". If an NPE is encountered
1457 with this patch, "Configuration Error: NullPointerException " will be
1460 This commit closes this bug:
1462 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1464 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1466 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1468 Rename onlineglom.properties to onlineglom.properties.sample.
1470 * src/main/resources/onlineglom.properties: Rename to:
1471 * src/main/resources/onlineglom.properties.sample:
1472 * src/main/resources/README: And add this file explaining that people
1473 should rename it back when deploying.
1475 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1477 Allow choosing the translation in the .properties file.
1479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1480 init(): Read a glom.document.locale value from the configuration file
1481 and call Glom's TransatableItem::set_current_locale() method.
1482 * src/main/resources/onlineglom.properties: Add a commented-out
1483 example of this new setting.
1485 It would be better to add &lang=de_DE to the URL, but the current
1486 libglom API does not allow us to do this easily. I am working on that.
1488 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1490 Avoid a crash in parsing of token parameters.
1492 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1493 ava: getTokenParams(): Do not crash if a parameter has a key but no
1494 value, and ignore parameters with neither.
1496 2011-12-17 Murray Cumming <murrayc@murayc.com>
1498 History token building/handling: Improve use of token parameters.
1500 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1501 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1502 and buildParamsToken(HashMap), for use by derived classes.
1503 Make the separator private because it is no longer be needed.
1504 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1505 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1506 instead of manual string concatenation.
1507 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1508 of hardcoded indices and awkward splitting code.
1509 * src/main/java/org/glom/web/client/place/ListPlace.java
1510 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1511 instead of manual string concatenation.
1512 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1513 of hardcoded indices and awkward splitting code.
1514 This should fix bug #666420
1516 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1518 Fix a Navgiation->Navigation typo in the code.
1520 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1521 Rename processNavgiation() to processNavigation().
1523 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1525 Fix a seperator->separator typo in the code.
1527 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1528 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1529 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1532 2011-12-15 Ben Konrath <ben@bagu.org>
1534 Cleanup some comments.
1536 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1538 2011-12-14 Ben Konrath <ben@bagu.org>
1540 Replace \n with <br/> for multiline text in the details view.
1542 Vertical scrollbars are added when needed as well.
1544 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1546 2011-12-14 Ben Konrath <ben@bagu.org>
1548 Specify the font for document selection links.
1550 * src/main/webapp/style.css:
1552 2011-12-14 Ben Konrath <ben@bagu.org>
1554 Fix bouncy CellTable while paging.
1556 This doesn't currently work with related list tables in unselected
1559 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1561 2011-12-14 Ben Konrath <ben@bagu.org>
1563 Revamp the appearance of the document selection page.
1565 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1566 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1567 * src/main/webapp/style.css:
1569 2011-12-13 Ben Konrath <ben@bagu.org>
1571 Set navigation button column to the smallest size possible.
1573 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1575 2011-12-13 Ben Konrath <ben@bagu.org>
1577 Change OpenButton nomenclature to NavigationButton.
1579 Using NavigtionButton makes things more generic. Classes, methods and
1580 variables have been changed.
1582 This is a rename-only refactor.
1584 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1585 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1586 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1587 Renamed from OpenButtonCell.
1588 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1589 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1590 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1592 2011-12-12 Ben Konrath <ben@bagu.org>
1594 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1596 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1597 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1598 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1599 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1601 2011-12-12 Ben Konrath <ben@bagu.org>
1603 Update variable names and comments.
1605 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1606 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1608 2011-12-12 Ben Konrath <ben@bagu.org>
1610 Properly initialize numNonEmptyRows variable to zero.
1612 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1613 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1615 2011-12-05 Ben Konrath <ben@bagu.org>
1617 Add latest mockup with HTML tables.
1619 Features of this mockup:
1621 -> HTML table for flowtable
1622 -> HTML table for flowtable column
1623 -> Example of how related lists would look
1624 -> Not using text entries for data items
1626 The current version of Online Glom doesn't use HTML tables for the
1629 This mockup has been sent to the glom-devel mailing list but it's good
1630 to have it here as well.
1632 * mockups/details-view-html-tables.html:
1634 2011-12-05 Ben Konrath <ben@bagu.org>
1636 Remove unnecessary getPrimaryKeyField() method.
1638 getPrimaryKeyFieldForTable(String) has been renamed to
1639 getPrimaryKeyField(String).
1641 * src/main/java/org/glom/web/server/database/DBAccess.java:
1642 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1643 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1645 2011-12-05 Ben Konrath <ben@bagu.org>
1647 Add string representation of TypedDataItem value to conversion error message.
1649 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1650 message was extracted into its own method to avoid duplication.
1652 2011-12-05 Ben Konrath <ben@bagu.org>
1654 Add type checking to navigation primary key value creation.
1656 Create navigation primary key only if the expected type from the Glom
1657 document matches the type returned by the SQL query.
1659 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1661 2011-12-05 Ben Konrath <ben@bagu.org>
1663 Rename a couple of variables in RelatedListNavigation.
1665 This is a rename-only refactor.
1667 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1669 2011-12-05 Ben Konrath <ben@bagu.org>
1671 Move getListLayoutGroup() into getListViewLayoutGroup().
1673 This removes getListLayoutGroup(). It was only being called by
1674 getListViewLayoutGroup().
1676 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1678 2011-12-05 Ben Konrath <ben@bagu.org>
1680 Remove check for LayoutItem_Portal in list table method.
1682 This check is no longer necessary because the method isn't being used
1683 to create the LayoutItemPortal DTO.
1685 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1687 2011-12-05 Ben Konrath <ben@bagu.org>
1689 Properly support related list navigation.
1691 Navigation from the "Repository Analyzer -> Package Scans ->
1692 Dependencies" related table wasn't working because the primary key for
1693 related tables wasn't being set properly. This commit fixes the
1696 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1697 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1698 doesn't set the primary key properly for related list tables.
1699 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1700 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1701 useful for getting the primary key for list view tables and for related
1703 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1704 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1705 Move code to set the primary key for the table from the abstract
1706 ListDBAccess class to ListViewDBAccess as it's only correct for list
1708 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1709 Properly add primary key to related list tables.
1711 2011-12-02 Ben Konrath <ben@bagu.org>
1713 Properly set the horizontal alignment of fields.
1715 This fix is for both the list tables and the details view.
1717 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1718 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1719 to set the horizontal alignment of fields.
1721 2011-12-02 Ben Konrath <ben@bagu.org>
1723 Display currency codes in the details view.
1725 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1727 2011-12-02 Ben Konrath <ben@bagu.org>
1729 Avoid duplicate JNI call.
1731 JNI is not as efficient as pure Java and this is an easy (and small)
1734 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1735 Use previously retrieved value for whereClauseToTableName instead of
1738 2011-12-02 Ben Konrath <ben@bagu.org>
1740 Rename a couple of variables in RelatedListNavigation.
1742 This is a rename-only refactor.
1744 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1746 2011-12-02 Ben Konrath <ben@bagu.org>
1748 Indicate clearly that a mismatched primary key type is a bug.
1750 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1751 warning to error. Add 'This is a bug.' to message.
1753 2011-12-02 Ben Konrath <ben@bagu.org>
1755 Update / fix some comments.
1757 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1759 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1761 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1762 Fix comments. Add some TODOs.
1764 2011-12-02 Ben Konrath <ben@bagu.org>
1766 Enable navigation to details view with string primary key from related list.
1768 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1769 Create a text primary key value when return type of result is
1770 java.sql.Types.VARCHAR.
1772 2011-12-02 Ben Konrath <ben@bagu.org>
1774 Use checkboxes for booleans in the details view.
1776 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1778 2011-12-01 Ben Konrath <ben@bagu.org>
1780 Improve performance of related list height calculation.
1782 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1783 Put code to calculate the expected height in a static initializer so
1784 that that it's only called once.
1786 2011-12-01 Ben Konrath <ben@bagu.org>
1788 Show related list tables in notebooks (again).
1790 Calculate the height of the related list tables so the Notebook can be
1791 set the correct height. The height of the related list table is also needed by
1792 FlowTable to be able decide how to create the layout.
1794 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1795 and set the Portal height based on the height of the related list
1796 table and the Portal container.
1797 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1798 Add method to calculate the height of the related list tables.
1799 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1800 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1801 calculate the height of the Pager widget.
1803 2011-12-01 Ben Konrath <ben@bagu.org>
1805 Use CellTable API for table property instead of setting style on Element.
1807 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1809 2011-12-01 Ben Konrath <ben@bagu.org>
1811 Make ListViewTable and RelatedListTable a consistent height.
1813 The tables are now a consistent height regardless of the contents of
1814 the table. A hidden button is added to empty rows to ensure that the
1815 height of these rows will match the height of rows with data.
1817 A navigation button column is now added to every table. The width of
1818 the navigation column is set to 0px when a RelatedListTable shouldn't
1819 have navigation buttons. This maintains the a consistent row height in
1820 tables that don't show the navigation buttons.
1822 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1823 navigation column when not needed.
1824 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1825 arguments for navigation button to constructor of ListViewTable.
1826 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1827 hidden button for empty data rows.
1828 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1829 arguments for navigation button to constructor.
1830 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1831 create navigation buttons. Add hideNavigationButtons() method.
1832 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1833 arguments for navigation button to constructor.
1835 2011-12-01 Ben Konrath <ben@bagu.org>
1837 Use 'visibility: hidden' in Utils.getWidgetHeight().
1839 This is better choice because hidden elements are invisible, don't
1840 respond to events and are not part of the tab order. They will,
1841 however, take up space which is required to be able to calculate the
1842 height of the widget.
1844 * src/main/java/org/glom/web/client/Utils.java:
1846 2011-12-01 Ben Konrath <ben@bagu.org>
1848 Use Utils.getWidgetHeight() in FlowTable.
1850 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1852 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1854 2011-12-01 Ben Konrath <ben@bagu.org>
1856 Put the details css class name on the correct table column.
1858 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1860 2011-11-30 Ben Konrath <ben@bagu.org>
1862 Update for java-libglom API change.
1864 The getters and setters on FieldFormatting and NumericFormat were
1865 changed to remove the 'M'.
1867 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1869 2011-11-29 Ben Konrath <ben@bagu.org>
1871 Only allow RelatedListTables in Portals.
1873 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1875 2011-11-29 Ben Konrath <ben@bagu.org>
1877 Only create a contents panel for Portals when title is being set.
1879 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1881 2011-11-29 Ben Konrath <ben@bagu.org>
1883 Set TabLayoutPanel height based on calculated height its widgets.
1885 This is a potential fix for this bug:
1887 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1889 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1891 2011-11-29 Ben Konrath <ben@bagu.org>
1893 Align details field labels and data with the Open buttons.
1895 * src/main/webapp/style.css:
1897 2011-11-29 Ben Konrath <ben@bagu.org>
1899 Remove unnecessary <div> in the Notebook widget.
1901 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1902 method to get container FlowPanel (<div>).
1903 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1904 initWidget() method directly on the TabLayoutPanel widget instead of
1905 Group's container widget.
1907 2011-11-29 Ben Konrath <ben@bagu.org>
1909 Don't add group titles for Portals in Notebooks.
1911 This reverts the previous patch and fixes a bug I introduced with
1912 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1914 * src/main/java/org/glom/web/client/ui/details/Group.java:
1915 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1917 2011-11-28 Ben Konrath <ben@bagu.org>
1919 Remove unused boolean argument in Portal constructor.
1921 Just a code cleanup.
1923 * src/main/java/org/glom/web/client/ui/details/Group.java:
1924 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1926 2011-11-28 Ben Konrath <ben@bagu.org>
1928 Remove hack for glom 1.18 style glom files.
1930 * src/main/java/org/glom/web/client/ui/details/Group.java:
1931 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1932 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1934 2011-11-28 Ben Konrath <ben@bagu.org>
1936 Use Gda Value version of primary key to log result too large error.
1938 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1940 2011-11-28 Ben Konrath <ben@bagu.org>
1942 Don't use TypedDataItem.getText() for Unknown types from the URL.
1944 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1945 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1946 instead of getText().
1947 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1948 String field and getUnknown() method.
1950 2011-11-28 Ben Konrath <ben@bagu.org>
1952 Log an error message when the java-libglom .so is not present.
1954 The error message was being set in the exception but not logged.
1956 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1958 2011-11-28 Ben Konrath <ben@bagu.org>
1960 Ignore LayoutItem_CalendarPortals.
1962 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1963 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1965 2011-11-28 Ben Konrath <ben@bagu.org>
1967 Extract method for creating the LayoutItemPortal DTO.
1969 Just breaking the code up into smaller chunks.
1971 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1973 2011-11-28 Ben Konrath <ben@bagu.org>
1977 This should have been added with the refactor. Oops!
1979 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1981 2011-11-28 Ben Konrath <ben@bagu.org>
1983 Create primary key value from URL string using type from Glom document.
1985 See this bug, comments 19 - 25:
1987 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1989 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1990 create a TypeDataItem for the primary key here when loading from a
1991 URL. Show the same string for the primary key value as was received
1992 from the URL string (when loading from a URL).
1993 * src/main/java/org/glom/web/server/Utils.java: Update method for
1994 creating the Gda Value from the TypeDataItem to properly deal with
1995 creating a Gda Value based on the Glom document type for the primary
1996 key value string when loading from a URL.
1997 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1998 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1999 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2000 Update for changed method name.
2002 2011-11-27 Ben Konrath <ben@bagu.org>
2004 Rename PrimaryKeyItem to TypedDataItem.
2006 The name PrimaryKeyItem suggests what the class should be used for.
2007 TypedDataItem is a neutral name that describes the class better.
2009 This is a rename-only refactor.
2011 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2012 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2013 * src/main/java/org/glom/web/client/Utils.java:
2014 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2015 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2016 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2017 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2018 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2019 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2020 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2021 * src/main/java/org/glom/web/server/Utils.java:
2022 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2023 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2024 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2025 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2027 2011-11-25 Ben Konrath <ben@bagu.org>
2029 Improve Gda Value conversion from PrimaryKeyItem.
2031 The value from the PrimaryKeyItem is only used if its type match the
2032 type from the glom document.
2034 * src/main/java/org/glom/web/server/Utils.java:
2036 2011-11-25 Ben Konrath <ben@bagu.org>
2038 Manually check if the java-liblgom .so is visible to the JVM.
2040 It seems that Tomcat has problems when a static initializer throws an
2041 exception. This check is done before the first method call into
2042 java-libglom so that execution doesn't continue if the .so is not
2045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2047 2011-11-25 Ben Konrath <ben@bagu.org>
2049 Improve browser configuration error messages.
2053 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2055 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2056 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2057 getConfigurationErrorMessage() method.
2058 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2059 Get and display a specific configuration error message when no Glom
2060 documents are found.
2061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2062 Implement getConfigurationErrorMessage() method. Surround configuration
2063 code in the init() method with a try/catch block. This allows the
2064 errors to be caught while keeping the servlet available to retrieve the
2065 configuration error message.
2067 2011-11-25 Ben Konrath <ben@bagu.org>
2069 Don't use Strings to hold primary key values.
2071 The primary key values are now held in a new data object
2072 (PrimaryKeyItem) that holds type information and the primary key value
2073 using the correct type.
2075 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2076 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2077 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2078 PrimaryKeyItem instead of String to hold the primary key value.
2079 * src/main/java/org/glom/web/client/Utils.java: Remove
2080 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2081 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2082 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2083 PrimaryKeyItem instead of String to hold the primary key value. Load
2084 document selection page when the documentID has not been set correctly.
2085 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2086 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2088 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2089 Return empty string for URL instead of "null".
2090 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2091 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2092 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2093 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2094 PrimaryKeyItem instead of String to hold primary key values.
2095 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2096 PrimaryKeyValue to a Gda Value.
2097 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2098 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2099 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2100 Replace temporary database access code that uses the PrimaryKeyValue to
2101 Gda Value conversion.
2102 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2103 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2104 PrimaryKeyItem instead of String.
2105 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2106 hold primary key values.
2108 2011-11-24 Ben Konrath <ben@bagu.org>
2110 Use newly added java-libglom API to create queries.
2112 This isn't finished. I still need to stop using Strings for primary key
2113 values in the client code.
2115 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2116 libglom to use fake connections so that retrieving the query string will
2118 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2119 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2120 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2121 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2122 Use the newly added libglom sql methods and classes to create the
2123 query. Add temporary hack to convert primary value strings to Gda
2126 2011-11-23 Ben Konrath <ben@bagu.org>
2128 Don't explicitly set the height of Portals.
2130 See comments 6 - 10 of this bug for details:
2132 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2134 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2136 2011-11-23 Ben Konrath <ben@bagu.org>
2138 Use an HTML table instead of CSS for the FlowTable layout.
2140 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2141 GWT's FlexTable to implement the FlowTable.
2142 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2144 2011-11-18 Ben Konrath <ben@bagu.org>
2146 Add boolean example to HTML table mockup.
2148 * mockups/details-view-html-tables-text-entries.html:
2150 2011-11-17 Ben Konrath <ben@bagu.org>
2152 Ensure the pager buttons are always visible for related lists.
2154 To accomplish this, I've turned off text wrapping in the list view and
2155 related list tables for both the header and data text. The related list
2156 table now has a fixed layout so the it doesn't overflow its container.
2157 This is required to ensure that the cell text is clipped when it
2158 overflows the cell and an ellipsis is added to the right side of the
2159 cell when text is clipped.
2161 A fixed table layout for the related list table in the details view
2162 seems what we want for the details view anyway, so the side-effect is
2165 The ellipsis will only be displayed in Firefox >= 7.
2169 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2171 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2172 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2173 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2175 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2176 Set the 'table-layout: fixed' CSS property to the related list table.
2177 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2178 'white-space: nowrap;' CSS property on both the list view and the
2179 related list tables.
2181 2011-11-16 Ben Konrath <ben@bagu.org>
2183 Rework the fix for empty notebook tab labels.
2185 Setting the empty group titles with its name caused problems for the
2186 details layout. Instead of using libglom's
2187 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2188 to the client when the title is empty. This allows the Notebook to use
2189 the name when the title is empty without affecting anything else.
2191 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2192 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2194 2011-11-16 Ben Konrath <ben@bagu.org>
2196 Set group titles with name when title is empty.
2198 This fixes a problem with an empty notebook tab label in the Lesson
2199 Planner document. The forth tab in the notebook should be "Internet":
2201 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2203 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2204 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2207 2011-11-16 Ben Konrath <ben@bagu.org>
2209 Remove whitespace from the configured username properties.
2211 This assumes that usernames won't have whitespace at the beginning
2212 or end. But I think this is a reasonable assumption.
2214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2215 String.trim() to remove the whitespace from the username properties.
2217 2011-11-15 Ben Konrath <ben@bagu.org>
2219 Add details view mockup with HTML tables and text entries.
2221 This is from the attachment on this bug:
2223 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2225 * mockups/details-view-html-tables-text-entries.html:
2227 2011-11-15 Ben Konrath <ben@bagu.org>
2229 Add space between the columns of the flow table.
2233 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2235 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2236 space between columns in the flow table.
2238 2011-11-15 Ben Konrath <ben@bagu.org>
2240 Add backup files to the .gitignore.
2242 * .gitignore: Ignore files that end with ~.
2244 2011-11-09 Ben Konrath <ben@bagu.org>
2246 Use latest release of gwt-log.
2248 Gwt-log releases are now being submitted to the maven central
2249 repository so manual installation of the jar is no longer required.
2251 * pom.xml: Update version and groupId of gwt-log dependency.
2253 2011-10-31 Ben Konrath <ben@bagu.org>
2255 Don't use GWT numeric formatting to override the glom currency formatting.
2257 Currencies are now displayed like they are in Glom. See this bug:
2259 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2261 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2263 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2264 currency code to constructor and set it when the cell is rendered.
2265 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2266 currency code to the constructor of the NumericCell.
2268 2011-10-27 Ben Konrath <ben@bagu.org>
2270 Require the latest release of java-libglom (1.17.4).
2274 2011-10-26 Ben Konrath <ben@bagu.org>
2276 Add style to Notebook that matches current theme.
2278 It's not the best style in the world but it's better than the default.
2280 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2281 padding at the bottom of the child widgets.
2282 * src/main/webapp/style.css: Add style for the Notebook.
2284 2011-10-26 Ben Konrath <ben@bagu.org>
2286 Move servlet initialization code to overridden init method.
2288 This is half of the solution to getting proper error messages
2289 displayed when configuration errors occur. Here's the relevant bug:
2291 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2293 The rest of the solution involves surrounding the init method with a
2294 try/catch block and setting a global variable with the error /
2295 exception. A new async method should be created to retrieve and display
2296 the error message / exception.
2298 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2299 code from constructor to init method adding exceptions as needed.
2301 2011-10-26 Ben Konrath <ben@bagu.org>
2303 Add script to monitor and restart tomcat if required.
2305 * utils/check-and-recover-tomcat.py: New file.
2307 2011-10-26 Ben Konrath <ben@bagu.org>
2309 Display the correct number of data items in the pager.
2313 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2315 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2316 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2317 The implementation is the same for both tables: Keep track of the
2318 number of non-empty rows and fire and RowCountChangeEvent after the data has
2320 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2321 custom Pager class that subclasses SimplePager to handle displaying
2322 the correct number when empty rows have been added.
2324 2011-10-26 Ben Konrath <ben@bagu.org>
2326 Correct error in previous commit.
2328 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2329 eventBus parameter from listView.setCellTable().
2331 2011-10-26 Ben Konrath <ben@bagu.org>
2333 Fix error in TODO comment.
2335 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2337 2011-10-24 Ben Konrath <ben@bagu.org>
2339 Create Notebook widgets to the details view.
2341 This isn't finished just yet - I still need to create a reasonable
2342 style to match the current theme.
2344 * src/main/java/org/glom/web/client/Utils.java: Add method for
2345 calculating the height of a widget. This is used in the Notebook class.
2346 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2347 new constructor method in Group.
2348 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2349 method for creating child widget that can be used by subclasses
2350 like Notebook. New constructor that allows disabling the group
2351 titles - Notebooks don't set a group title for their child groups.
2352 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2353 to make Notebooks using GWT's TabLayoutPanel.
2354 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2355 constructor that allows disabling the group titles.
2356 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2357 LayoutItemNotebook DTO.
2358 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2359 DTO for Notebooks. It's just an empty class for now but we might need
2360 it to transfer some specific information in the future.
2362 2011-10-21 Ben Konrath <ben@bagu.org>
2364 Add navigation buttons to related list tables.
2366 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2367 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2368 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2369 method getSuitableRecordToViewDetails() for getting the table name
2370 and primary key value for related list navigation buttons.
2371 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2372 private cell renderer class to get the navigation information for
2373 related list tables from the server. Extract the navigation
2374 processing code from the details cell navigation and use it for the
2375 related list navigation as well.
2376 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2377 cell renderer class for the details open buttons. This was needed
2378 because the related list navigation buttons and the list view
2379 navigation buttons need to react differently when clicked.
2380 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2381 the onEnterKeyDown() method because it's now overriden in the
2382 subclasses that are specific to the related list tables and the list
2384 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2385 the vertical size a little because the buttons add a bit of vertical
2386 space to table. This is not a perfect solution because the vertical
2387 size of with table fewer than 5 rows will be a little smaller.
2388 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2389 changes in how navigation buttons are handled.
2390 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2391 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2392 database access object.
2393 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2394 to find the portal for a given relationship name from
2395 RelatedListDBAccess. Add method to find a primary key field for a
2397 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2398 Move code to find the portal for a given relationship name to
2400 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2401 New file: database access object for getting the related list
2402 navigation information (the table name and the primary key value).
2403 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2404 DTO for transferring a table name to navigate to and a primary key
2406 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2407 boolean and getter/setter to specifies if the related list should add
2410 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2412 Use the master branch of java-libglom
2414 * pom.xml: Depend on java-libglom 1.19 instead.
2416 This is the master branch. See also the libglom-1-18 branch.
2418 2011-10-11 Ben Konrath <ben@bagu.org>
2420 Enable the open navigation button when the data has been set.
2422 This avoids having active buttons that don't do anything when the data
2425 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2427 2011-10-11 Ben Konrath <ben@bagu.org>
2429 Use IsWidget interface for FlowTableItem.
2431 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2432 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2434 2011-10-11 Ben Konrath <ben@bagu.org>
2436 Remove GWT styling from open button in details view.
2438 There are still some issues with how the details cell is arranged but
2439 this should be made to match Glom 1.20. I'm going to leave fixing this
2440 until I have Glom 1.20 up and running.
2442 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2443 style name on open button.
2444 * src/main/webapp/style.css: Move and edit details-navigation class.
2445 Re-arrange some classes to make them appear in the same order as the
2448 2011-10-07 Ben Konrath <ben@bagu.org>
2450 Update to GWT 2.4.0.
2452 * .gitignore: Ignore new cache directory.
2453 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2454 * pom.xml: Change GWT and maven plugin to 2.4.0.
2455 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2457 * src/main/java/org/glom/web/client/ClientFactory.java:
2458 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2459 * src/main/java/org/glom/web/client/OnlineGlom.java:
2460 Update source for API changes.
2461 * utils/build-onlineglom-war.sh: Remove cache directory before the
2464 2011-10-07 Ben Konrath <ben@bagu.org>
2466 Add navigation buttons in the details view.
2468 This isn't finished but I thought I'd commit what I have as it's a
2469 pretty good start. I still need to:
2471 1. Change the style so that it fits better into the current theme
2472 2. Adjust the details cell to expand as much as possible.
2474 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2475 click handlers to navigation buttons in the DetailsCells. Create a
2476 refreshData() method to get just the data from the server without the
2478 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2479 Update the tableSelector and browser title when the table name
2480 changes without using the tableSelector.
2481 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2482 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2483 getDetailsCells() to getCells(). Update variable names.
2484 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2485 method to set click handler on navigation button. Rename a few
2486 variables. Add navigation buttons where needed.
2487 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2488 variables and methods.
2489 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2490 navigation boolean and navigation table as required in the
2491 LayoutItemField DTO.
2492 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2493 variables for navigation along with getter/setter methods.
2495 2011-10-07 Ben Konrath <ben@bagu.org>
2497 Rename Field to DetailsCell.
2499 This is a refactor-only commit. No functionality has been added or
2502 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2503 Update variable and method names.
2504 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2505 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2506 variable and method names.
2507 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2509 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2510 variable and method names.
2512 2011-10-07 Ben Konrath <ben@bagu.org>
2514 Create separate methods for layout and data the details view.
2516 This is a refactor-only commit. No functionality has been added or
2519 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2520 private methods: setData(), createLayout().
2522 2011-10-07 Ben Konrath <ben@bagu.org>
2524 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2526 This is part of a change to get navigation buttons in the details view
2527 but it should have been done this way from the start.
2529 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2530 for method name change in TableSelectionView.
2531 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2532 Create TableChangeEvent and set the browser title using the
2533 TableSelectionView API.
2534 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2535 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2536 Change getSelectedTable() to getSelectedTableName(). Add
2537 getSelectedTableTitle().
2539 2011-10-07 Ben Konrath <ben@bagu.org>
2541 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2543 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2545 2011-10-07 Ben Konrath <ben@bagu.org>
2547 Update TableChangeEvent to use newTableName naming convention.
2549 This makes the class more consistent with GWT naming conventions.
2551 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2552 Update for method name change in TableChangeEvent.
2553 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2554 for method name change in TableChangeEvent.
2555 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2556 newTableName variable and getter method. Make toDebugString()
2559 2011-09-30 Ben Konrath <ben@bagu.org>
2561 Disable the pager in the list tables when the data row count is less than the minimum.
2563 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2564 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2566 2011-09-30 Ben Konrath <ben@bagu.org>
2568 Add empty rows to the end of related list and list view tables.
2570 I also extracted the cell rendering classes from the ListTable because
2571 the code was becoming a little crazy with all the anonymous inner
2572 classes. My plan is to use these cell rendering classes in the details
2573 view as well so this refactor will be needed for that change.
2575 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2576 set the row count in related list tables if the data has more rows
2577 than the minimum number of rows visible.
2578 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2579 row count in list view tables if the data has more rows than the
2580 minimum number of rows visible.
2581 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2582 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2584 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2585 for rendering TYPE_NUMERIC cells. The code was extracted from the
2587 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2588 class for rendering cells with buttons in list views. The code was
2589 extracted from the ListTable class.
2590 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2591 for rendering TYPE_TEXT cells. The code was extracted from the
2593 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2594 Add empty rows to the end of the data if required. Implement
2595 ListTable.getMinNumVisibleRows().
2596 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2597 cell renderer code to public classes. Return null in
2598 Column.getValue() for empty rows. Add new abstract method:
2599 getMinNumVisibleRows(). Move code to set the row count of the list view
2600 table to ListViewImpl.
2601 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2602 empty rows to the end of the data if required. Implement
2603 ListTable.getMinNumVisibleRows().
2606 2011-09-27 Ben Konrath <ben@bagu.org>
2608 Use GWT.log for client-side debugging statements.
2610 These are optimized out when deployed so I should have used this method
2611 in the first place. These statements will eventually be replaced with some sort
2612 of notification in the browser.
2614 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2615 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2616 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2617 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2618 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2620 2011-09-27 Ben Konrath <ben@bagu.org>
2622 Put tableselector on the right, back to list link on right.
2624 The idea is that the table selector is acting like a label for the
2625 currently displayed table so it should be placed below the document title. This
2626 puts the table title in a similar position to where it is in Glom.
2628 * mockups/details-contacts.html:
2629 * mockups/details-projects.html:
2630 * mockups/listview-contacts.html:
2631 * mockups/listview-projects.html:
2632 * mockups/style.css:
2633 Update mockups to match how the interfaces currently look.
2634 * src/main/webapp/style.css: Swap positions of backlink with the table
2635 selector. Add some space on the left side of the table selector to
2636 line things up with the document title.
2638 2011-09-27 Ben Konrath <ben@bagu.org>
2640 Add field colouring to details view.
2642 This change re-works how field colouring works. The colour formatting
2643 information is now set to the client with the layout information instead of
2644 with the data. This eliminates the need to send the same colour strings for
2645 data in list view column when colour information is set.
2647 In order to set an alternate colour for negative numeric values, the
2648 number is now sent to client and formatted with the GWT NumberFormat class.
2650 This change also fixes:
2652 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2654 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2655 internationalization framework which is needed for client side numeric
2657 * src/main/java/org/glom/web/client/Utils.java: New file for some
2658 client static utility methods.
2659 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2660 the DataItem object to the Field class. Use a utility method to
2661 create the foreignKeyValue string.
2662 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2663 alignment and text colours in the constructor. Add setData(DataItem)
2664 method. Remove setText(String) method.
2665 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2666 colour information to GlomTextCell. Create and use GlomNumberCell for
2667 rendering numbers. Use utility method to get the string for the
2668 primary key of the key provider. Re-work how the horizontal alignment
2670 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2671 formatting to layout information. Methods for converting the libglom
2672 formatting information were moved from DBAccess.
2673 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2674 numeric formatting (it's now done on the client side). Don't set text
2675 colours in DataItem. Move libglom formatting conversion methods to
2677 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2678 getters/setters for text colour information.
2679 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2680 for transferring the libglom NumericFormat information to the client.
2681 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2682 and getters/setters for: GlomNumericFormat, background colour and
2683 foreground colour strings.
2685 2011-09-26 Ben Konrath <ben@bagu.org>
2687 Simplify code that iterates through the LayoutGroup.
2689 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2691 2011-09-26 Ben Konrath <ben@bagu.org>
2693 Accept Eclipse formatting for OnlineGlomServiceAsync.
2695 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2697 2011-09-26 Ben Konrath <ben@bagu.org>
2699 Don't use the ListDBAccess classes to get the primary key layout information.
2701 This was causing a bug where the wrong index for the hidden primary key
2702 was being sent to the client.
2704 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2705 primary key while creating the LayoutGroup DTO. Create a
2706 LayoutItemField DTO for hidden primary keys. Don't use the
2707 RelatedListDBAccess because it was only used for getting the primary
2709 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2710 access modifier from public to protected for getPrimaryKeyField() and
2711 getPrimaryKeyLayoutItemField().
2712 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2713 abstract method getExpectedResultSize() because RelatedListDBAccess
2714 doesn't have enough info to implement it.
2715 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2716 Remove @Override for getExpectedResultSize().
2717 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2718 Remove method getExpectedResultSize().
2720 2011-09-23 Ben Konrath <ben@bagu.org>
2722 Log which layout (list or details) the ignored item is from.
2724 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2726 2011-09-23 Ben Konrath <ben@bagu.org>
2728 Remove annotations that turn off code formatting in DataItem.
2730 * src/main/java/org/glom/web/shared/DataItem.java:
2732 2011-09-23 Ben Konrath <ben@bagu.org>
2734 Rename GlomField to DataItem and update associated methods.
2736 This is a rename-only refactor. No functionality has been added or
2739 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2740 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2741 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2742 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2743 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2744 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2745 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2746 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2747 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2748 * src/main/java/org/glom/web/server/database/DBAccess.java:
2749 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2750 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2751 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2752 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2753 * src/main/java/org/glom/web/shared/DataItem.java:
2754 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2755 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2757 2011-09-23 Ben Konrath <ben@bagu.org>
2759 Rename GlomDocument to DocumentInfo and update associated methods.
2761 This is a rename-only refactor. No functionality has been added or
2764 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2765 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2766 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2767 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2768 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2769 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2770 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2772 2011-09-20 Ben Konrath <ben@bagu.org>
2774 Require java-libglom 1.17.3.
2776 This picks up the fix for the seg fault problem with the Scenes table
2777 in the Openismus Film Manager example.
2781 2011-09-20 Ben Konrath <ben@bagu.org>
2783 Change the way sort clause is added for primary key when no sort clause is requested.
2785 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2786 before the sort clause is created. When a sort clause is not requested, the
2787 sort clause is created by finding the primary key in the LayoutFieldVector
2790 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2792 2011-09-20 Ben Konrath <ben@bagu.org>
2794 Log error message if no documents are found in the configured directory.
2796 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2797 Extract the glom file extension string to a private static final class
2798 variable (mostly as syntactic sugar). Accept a minor formatting change.
2799 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2800 the example glom.document.directory configuration property to make it
2801 more clear that it can any directory, not just the home directory.
2803 2011-09-18 Ben Konrath <ben@bagu.org>
2805 Add related lists to details view.
2807 The related list table has support for paging and sorting just like the
2808 table in the list view.
2810 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2811 SQL queries for the related list tables.
2812 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2813 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2814 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2815 Rename getList methods to getListView and add comments. Remove
2816 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2817 it being unused. Add methods: getDetailsLayoutAndData(),
2818 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2819 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2820 Create the layout and set the data for the fields in one async call
2821 instead of two. Create related lists where appropriate.
2822 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2823 for method name changes in OnlineGlomService.
2824 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2825 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2826 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2828 * src/main/java/org/glom/web/client/ui/ListView.java:
2829 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2830 tableName from setCellTable(). Create a ListViewTable instead of
2832 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2833 represent a data field in the details view.
2834 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2835 from addDetailsCell() to Field class. Keep track of the Fields and
2836 Portals in the details view.
2837 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2838 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2839 and add a method to get it. Add method to set the contents of the
2841 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2842 New class for related list tables. This class has the data provider
2843 for the related list table.
2844 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2845 abstract class which is the base class for the ListViewTable and the
2847 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2848 New class for list view tables. This class has the data provider for
2849 the list view table.
2850 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2851 methods for related list tables. Add more information to the
2852 LayoutItemField and LayoutItemPortal DTOs.
2853 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2854 Remove debugging print statement.
2855 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2856 Remove debugging print statements. Add primary key field to SQL count
2858 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2859 Remove unnecessary LayoutFieldVector parameter from
2860 getResultSizeOfSQLQuery() method.
2861 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2862 New class for related list table database access.
2863 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2864 class that is a wrapper DTO for details view layout and data.
2865 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2866 new 'fromField' string to this DTO.
2867 * src/main/webapp/style.css: Remove bottom margin and override top
2870 2011-09-15 Ben Konrath <ben@bagu.org>
2872 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2874 This sets things up to make it easier to add the data retrieval for
2875 related lists (portals). No user noticeable changes were made with
2878 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2879 class has the code to retrieve the layouts and access the
2880 database using the new database helper classes.
2881 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2882 Most of the functionality has been removed from this class. This
2883 class now represents the public interface for the client side
2884 code. It also deals with configuring the servlet and cleaning
2885 things up when the servlet is stopped.
2886 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2887 of static methods into this utility class.
2888 * src/main/java/org/glom/web/server/database/DBAccess.java:
2889 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2890 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2891 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2892 These classes have the database retrieval code. The class hierarchy
2893 has been setup to make it easy to reuse code for similar
2896 2011-09-06 Ben Konrath <ben@bagu.org>
2898 Create separate classes for list table code and the data provider.
2900 As part of this refactor, I also split up the code a bit to make it
2903 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2904 table code to two new classes (below).
2905 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2906 with code from ListViewImpl.
2907 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2908 New file with code from ListViewImpl.
2910 2011-09-06 Ben Konrath <ben@bagu.org>
2912 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2914 This fixes the LayoutItemPortal DTO to match the libglom layout object
2917 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2919 2011-09-01 Ben Konrath <ben@bagu.org>
2921 Set title of Portals in the Details View.
2923 * pom.xml: Bump required version of java-libglom to 1.17.1.
2924 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2925 widget creation to its own class. Add comments to constructor.
2926 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2927 The code is mostly from the Group class with the title now set.
2928 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2929 title of Portal. Update some comments. Fix some code formatting.
2931 2011-09-01 Ben Konrath <ben@bagu.org>
2933 Remove TODO comment for the flow table column width.
2935 The flow table column width is working correctly and doesn't need to be
2936 changed. See this mailing list post for more info:
2938 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2940 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2942 2011-08-27 Ben Konrath <ben@bagu.org>
2944 Add document title (database name) to top of the browser page.
2946 I added the document title to the TableSelecitonView but that will
2947 change if / when we add a view that doesn't require table selection.
2949 * mockups/details-contacts.html:
2950 * mockups/details-projects.html:
2951 * mockups/listview-contacts.html:
2952 * mockups/listview-projects.html:
2953 * mockups/style.css: Add document title to mockups to keep things
2955 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2956 sizes to account for the document title.
2957 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2958 Set the document title when it has been retrieved from the server.
2959 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2960 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2961 and implement setDocumentTitle(String) method.
2962 * src/main/webapp/style.css: Add ID for document title style.
2964 2011-08-25 Ben Konrath <ben@bagu.org>
2966 Add NavigationType enum to LayoutItemPortal DTO.
2968 This is the start of adding support for Portals to the Details View.
2970 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2971 LayoutItem_Portal.navigation_type enum from libglom to
2972 LayoutItemPortal.NavigationType enum.
2973 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2974 NavigationType enum, field for storing the NavigationType and getter
2977 2011-08-25 Ben Konrath <ben@bagu.org>
2979 Implement the flow table layout in the Details View.
2981 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2982 FlowTable to Group to account for the renamed class.
2983 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2984 File. This is a container widget that implements the Glom details view
2985 flow table behaviour.
2986 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2987 org/glom/web/client/ui/FlowTable.java.
2988 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2989 so that the size of the subgroups are a closer match to the size of
2990 the Glom subgroups. This makes the flowtable layout match the layout
2991 in Glom for the Music Collection example file.
2993 2011-08-16 Ben Konrath <ben@bagu.org>
2995 Create container element for LayoutItemPortal in Details View.
2997 This will help me develop the layout for the FlowTable.
2999 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
3000 fieldPanel variable to detailsCell.
3002 2011-08-15 Ben Konrath <ben@bagu.org>
3004 Set the height of the data element in the Details View.
3006 I changed the InlineLabels (text in a span element) to Labels (text in
3007 a div element) so that I could set the height of the details-data
3008 elements instead of the details-cell parent elements. This allows the
3009 the details-data element to display the correct height if style is
3010 applied that shows the height.
3012 This change has the added benefit of allowing the order of the labels
3013 and data elements to be changed for right-to-left languages.
3015 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
3016 InlineLabels to Labels.
3017 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
3018 InlineLabels to Labels. Set the height of the data element.
3019 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3020 multiline text height in the Formatting DTO.
3021 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
3022 for multiline height along with getter and setter methods.
3023 * src/main/webapp/style.css: Adjust style to account for the change
3024 from span elements to div elements in the details cell.
3026 2011-08-15 Ben Konrath <ben@bagu.org>
3028 Make the List View appearance match the mockups.
3030 It doesn't match exactly but it's much better than it was.
3032 * mockups/listview-contacts.html: Remove unused css classes.
3033 * mockups/listview-projects.html: Remove unused css classes.
3034 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
3035 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
3036 for mainPanel instead of VerticalPanel (table). Set style name on
3037 CellTable. Set style name on Details column. Right-align Details
3039 * src/main/webapp/style.css: Adjust properties to match the mockups.
3041 2011-08-12 Ben Konrath <ben@bagu.org>
3043 Add better support for subgroups in the details view.
3045 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
3046 changed FlowTable constructor.
3047 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
3048 support for subgroups and subgroup-titles.
3049 * src/main/webapp/style.css: Add CSS class for subgroups and
3052 2011-08-12 Ben Konrath <ben@bagu.org>
3054 Return the top level LayoutGroup title.
3056 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3058 2011-08-11 Ben Konrath <ben@bagu.org>
3060 Make the TableSelector header match the mockup.
3062 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
3063 the layout panel. Properly lineup the table selection header with
3064 the list and details view.
3065 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
3066 margin around the details view.
3067 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3068 Rename listBox variable to tableSelector. Set id for the style sheet.
3069 Use a FlowPanel instead of a HorizontalPanel.
3070 * src/main/webapp/style.css: Add properties to make the TableSelector
3071 box match the mockups.
3073 2011-07-13 Ben Konrath <ben@bagu.org>
3075 Update install script for java-libglom version change.
3077 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
3080 2011-07-13 Ben Konrath <ben@bagu.org>
3082 Add support sub-group in the details view.
3084 I also removed the code that special-cased the default details view
3087 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
3089 I still have to make a proper flowtable.
3091 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3092 Don't special-case default details view layout.
3093 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
3094 addLayoutField() as I'm going to use it.
3095 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
3096 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
3098 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
3099 extracted from DetailsViewImpl.GroupPanel. Add support for
3101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3102 column count when getting the details layout.
3104 2011-07-12 Ben Konrath <ben@bagu.org>
3106 Set browser title with database and table titles.
3108 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3109 Set the browser title when the table changes and when the activity
3111 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
3112 title when retrieving document info (the GlomDocument object).
3113 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
3114 with getter and setter methods. Remove unused convenience constructor.
3115 Use default code formatting.
3117 2011-07-12 Ben Konrath <ben@bagu.org>
3119 Ignore LayoutItemPortals in the details view.
3121 I added a new DTO for the LayoutItemPortal so that I can ignore it in
3124 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
3125 LayoutItemPortal layout objects.
3126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3127 LayoutItemPortal objects when retrieving the details layout.
3128 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3129 file. This is an empty class and just used to get type information for
3132 2011-07-12 Ben Konrath <ben@bagu.org>
3134 Use java-libglom 1.17.0.
3138 2011-07-11 Ben Konrath <ben@bagu.org>
3140 Remove "Table:" label from table selector.
3142 This matches a recent change in the Glom UI.
3144 * mockups/details-contacts.html:
3145 * mockups/details-projects.html:
3146 * mockups/listview-contacts.html:
3147 * mockups/listview-projects.html: Remove the "Table:" label from the
3149 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3151 2011-07-11 Ben Konrath <ben@bagu.org>
3153 Add main groups to the details view.
3155 This makes things look a little nicer in the details view. The next step
3156 is to implement the flowtable.
3158 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3159 resources from the standard gwt css theme. Standard.css is now
3160 included in OnlineGlom.html so that the online glom css rules have
3161 precedence over the gwt theme.
3162 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3163 the whole LayoutGroup to the DetailsView instead of just the titles.
3164 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3165 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3166 details layout with a helper class (GroupPanel). I might extract this
3167 class when I make the full flowtable.
3168 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3169 string as default so I don't have to worry about NPEs when processing
3171 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3172 note beside OnlineGlom.gwt.xml above).
3173 * src/main/webapp/style.css: Add default font-size to body to override
3174 the font-size set by the standard theme. Don't use h2 tags for
3175 group-title. Create new details-cell class.
3177 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3179 ConfiguredDocument: Set the port number too.
3181 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3182 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3183 Glom document. Presumably this worked sometimes so far because there is a
3184 default port number.
3186 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3188 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3190 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3191 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3192 correct, though we should throw an exception too.
3194 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3196 Fix a addDocuemnt typo.
3198 * src/main/java/org/glom/web/shared/Documents.java
3199 (Documents.addDocuemnt): Rename to addDocument().
3200 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3201 (OnlineGlomServiceImpl.getDocuments): Adapt.
3203 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3205 Slightly improved log output when connection fails.
3207 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3208 (ConfiguredDocument.setUsernameAndPassword):
3209 We don't know for sure if it' the username/password that's wrong, so
3210 rephrase the message.
3211 Also ouput the exception message, though it's generic in this case.
3213 2011-07-08 Ben Konrath <ben@bagu.org>
3217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3218 added braces to a one line if statement because the Eclipse formatter
3219 was getting confused.
3221 2011-07-07 Ben Konrath <ben@bagu.org>
3223 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
3225 These should really be two separate tasks but I counldn't get things to
3226 work with GWT 2.2.0 and Eclipse 3.7.
3230 * .settings/org.eclipse.jdt.core.prefs:
3231 * .settings/org.eclipse.jdt.ui.prefs:
3232 * .settings/org.eclipse.ltk.core.refactoring.prefs:
3233 * .settings/org.eclipse.m2e.core.prefs:
3234 Add new config files. Update current files. Remove references to the
3235 webtools plugins as we're not using any of the webtools features.
3236 * .gitignore: Add logs directory which is created when running with
3238 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
3239 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
3240 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
3242 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
3244 2011-07-07 Murray Cumming <murrayc@murrayc.com>
3246 onlineglom.properties: Add explanatory comments.
3248 * src/main/resources/onlineglom.properties: Also change the default user
3249 from ben to someuser, to avoid the risk of people thinking we just
3250 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3252 2011-06-28 Ben Konrath <ben@bagu.org>
3254 Use filename in Log for incorrect passwords.