1 2012-01-01 Murray Cumming <murrayc@murrayc.com>
3 GwtTestOnlineGlom: Test a little more.
5 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
6 protected rather than private, as suggested by the gwt-test-utils
8 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
9 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
10 Test the initial visibility of the panels.
12 However, this is not a very useful test.
13 And I wonder how we should generally test using this idea for an
14 activity/places app like ours where the real changes happen implicitly
15 based on the history token/URL.
17 2012-01-01 Murray Cumming <murrayc@murrayc.com>
19 Slight modification to *Mapper comments.
21 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
23 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
25 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
27 Remove comments mentioning GIN because they are just copied from
28 the example code and are apparently not helpful:
29 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
30 Also change the mention of a class that is only in the example code.
32 2012-01-01 Murray Cumming <murrayc@murrayc.com>
34 GwtTestOnlineGlom test: Minor changes.
36 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
37 Avoid the long qualified class name and modify the comment
38 because it is now obvious to me that the mocked class is the only
39 custom one created via GWT.create().
41 2012-01-01 Murray Cumming <murrayc@murrayc.com>
43 Tests: Added the beginnings of a test using gwt-test-utils.
45 * pom.xml: Add dependencies on gwt-test-utils and easymock.
46 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
47 which tells gwt-test-utils what class will be tested.
48 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
49 Add a simple (but empty) test case. One class, used by the OnlineGlom
50 class, is mocked so that it can be created. However, I am not sure
51 why only this class needs to be mocked.
53 Note that mockito seems more popular, and clearer, than easymock,
54 but I have not got that working yet. It might be a matter of the
57 This test is run during mvn integration-test.
59 2011-12-31 Murray Cumming <murrayc@murrayc.com>
61 Tests: Use junit4-style syntax instead of junit3-style.
63 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
64 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
65 * src/test/java/org/glom/web/shared/DataItemTest.java:
66 Use the @Test annotation rather than relying on the test*() prefix.
67 Also no longer implement TestCase, to avoid triggering support for
68 the junit3-way, which stops the annotations from working.
69 Change the imports from import junit.framework.* to
70 import org.junit.*, which is apparently the new way.
72 2011-12-31 Murray Cumming <murrayc@murrayc.com>
74 Added a test for ListPlace token parsing and creation.
76 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
77 This is much the same as DetailsPlaceTest.
79 I wonder how we could test the other parts of the *Place API.
81 2011-12-30 Murray Cumming <murrayc@murrayc.com>
83 DetailsPlace test: Also test getToken() and recreation via getPlace().
85 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
86 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
87 recreate it, testing the recreated DetailsPlace for the same parameter
90 2011-12-30 Murray Cumming <murrayc@murrayc.com>
92 Use the surefire-report plugin.
94 * pom.xml: This generates a HTML report about the tests in
95 target/site/surefire-report.html
96 when you do mvn surefire-report:report. It seems to be popular/normal.
98 2011-12-30 Murray Cumming <murrayc@murrayc.com>
100 Added a test for DetailsPlace.
102 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
103 Test the getPlace() token parsing.
105 2011-12-30 Murray Cumming <murrayc@murrayc.com>
107 Added a first unit test.
109 * pom.xml: Add a test goal, and a dependency on junit in that scope.
110 * src/test/java/org/glom/web/shared/DataItemTest.java:
111 This is a silly test but it is just to get things started. Note that
112 maven/junit finds the test because it looks in src/test by default.
114 2011-12-22 Ben Konrath <ben@bagu.org>
116 Change charsetName to "UTF-8" when replacing line breaks.
118 JavaScript requires the charsetName to be "UTF-8". CharsetName values
119 that work in Java (such as "UTF8") will not work when compiled to
122 This fixes a problem with multi-line details view fields that have hard
123 line breaks. The "License Text" field on this page demonstrates the
126 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
128 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
130 2011-12-22 Ben Konrath <ben@bagu.org>
132 Fix another bug with related list navigation.
134 I've tested all the navigation buttons in all of the related lists
135 so things should be good now.
137 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
139 2011-12-22 Ben Konrath <ben@bagu.org>
141 Fix a crasher when refreshing the list view with the default table.
143 This crash will also happen when loading the list view with the default
144 table from a link or bookmark.
146 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
147 to the main document selection page when the document id hasn't been
149 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
150 the main document selection page when the document id hasn't been
152 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
153 values for the details place when the document id hasn't been set.
154 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
155 values for the list place when the document id hasn't been set.
157 2011-12-21 Ben Konrath <ben@bagu.org>
159 Protect against NPE when glom.document.locale is not in config.
161 This patch protects against an NPE when glom.document.locale is not in
162 the config file. This NPE will also happen if glom.document.locale is
165 The patch also updates the error message to display the class name when
166 the getMessage() returns null. This was happening when the NPE was
167 thrown and I had "Configuration Error: null". If an NPE is encountered
168 with this patch, "Configuration Error: NullPointerException " will be
171 This commit closes this bug:
173 https://bugzilla.gnome.org/show_bug.cgi?id=666669
175 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
177 2011-12-20 Murray Cumming <murrayc@murrayc.com>
179 Rename onlineglom.properties to onlineglom.properties.sample.
181 * src/main/resources/onlineglom.properties: Rename to:
182 * src/main/resources/onlineglom.properties.sample:
183 * src/main/resources/README: And add this file explaining that people
184 should rename it back when deploying.
186 2011-12-20 Murray Cumming <murrayc@murrayc.com>
188 Allow choosing the translation in the .properties file.
190 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
191 init(): Read a glom.document.locale value from the configuration file
192 and call Glom's TransatableItem::set_current_locale() method.
193 * src/main/resources/onlineglom.properties: Add a commented-out
194 example of this new setting.
196 It would be better to add &lang=de_DE to the URL, but the current
197 libglom API does not allow us to do this easily. I am working on that.
199 2011-12-19 Murray Cumming <murrayc@murrayc.com>
201 Avoid a crash in parsing of token parameters.
203 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
204 ava: getTokenParams(): Do not crash if a parameter has a key but no
205 value, and ignore parameters with neither.
207 2011-12-17 Murray Cumming <murrayc@murayc.com>
209 History token building/handling: Improve use of token parameters.
211 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
212 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
213 and buildParamsToken(HashMap), for use by derived classes.
214 Make the separator private because it is no longer be needed.
215 * src/main/java/org/glom/web/client/place/DetailsPlace.java
216 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
217 instead of manual string concatenation.
218 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
219 of hardcoded indices and awkward splitting code.
220 * src/main/java/org/glom/web/client/place/ListPlace.java
221 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
222 instead of manual string concatenation.
223 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
224 of hardcoded indices and awkward splitting code.
225 This should fix bug #666420
227 2011-12-16 Murray Cumming <murrayc@murrayc.com>
229 Fix a Navgiation->Navigation typo in the code.
231 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
232 Rename processNavgiation() to processNavigation().
234 2011-12-16 Murray Cumming <murrayc@murrayc.com>
236 Fix a seperator->separator typo in the code.
238 * src/main/java/org/glom/web/client/place/DetailsPlace.java
239 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
240 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
243 2011-12-15 Ben Konrath <ben@bagu.org>
245 Cleanup some comments.
247 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
249 2011-12-14 Ben Konrath <ben@bagu.org>
251 Replace \n with <br/> for multiline text in the details view.
253 Vertical scrollbars are added when needed as well.
255 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
257 2011-12-14 Ben Konrath <ben@bagu.org>
259 Specify the font for document selection links.
261 * src/main/webapp/style.css:
263 2011-12-14 Ben Konrath <ben@bagu.org>
265 Fix bouncy CellTable while paging.
267 This doesn't currently work with related list tables in unselected
270 * src/main/java/org/glom/web/client/ui/list/ListTable.java
272 2011-12-14 Ben Konrath <ben@bagu.org>
274 Revamp the appearance of the document selection page.
276 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
277 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
278 * src/main/webapp/style.css:
280 2011-12-13 Ben Konrath <ben@bagu.org>
282 Set navigation button column to the smallest size possible.
284 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
286 2011-12-13 Ben Konrath <ben@bagu.org>
288 Change OpenButton nomenclature to NavigationButton.
290 Using NavigtionButton makes things more generic. Classes, methods and
291 variables have been changed.
293 This is a rename-only refactor.
295 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
296 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
297 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
298 Renamed from OpenButtonCell.
299 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
300 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
301 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
303 2011-12-12 Ben Konrath <ben@bagu.org>
305 Remove unnecessary String argument in RelatedListTable and ListViewTable.
307 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
308 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
309 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
310 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
312 2011-12-12 Ben Konrath <ben@bagu.org>
314 Update variable names and comments.
316 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
317 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
319 2011-12-12 Ben Konrath <ben@bagu.org>
321 Properly initialize numNonEmptyRows variable to zero.
323 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
324 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
326 2011-12-05 Ben Konrath <ben@bagu.org>
328 Add latest mockup with HTML tables.
330 Features of this mockup:
332 -> HTML table for flowtable
333 -> HTML table for flowtable column
334 -> Example of how related lists would look
335 -> Not using text entries for data items
337 The current version of Online Glom doesn't use HTML tables for the
340 This mockup has been sent to the glom-devel mailing list but it's good
341 to have it here as well.
343 * mockups/details-view-html-tables.html:
345 2011-12-05 Ben Konrath <ben@bagu.org>
347 Remove unnecessary getPrimaryKeyField() method.
349 getPrimaryKeyFieldForTable(String) has been renamed to
350 getPrimaryKeyField(String).
352 * src/main/java/org/glom/web/server/database/DBAccess.java:
353 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
354 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
356 2011-12-05 Ben Konrath <ben@bagu.org>
358 Add string representation of TypedDataItem value to conversion error message.
360 * src/main/java/org/glom/web/server/Utils.java: Logging the error
361 message was extracted into its own method to avoid duplication.
363 2011-12-05 Ben Konrath <ben@bagu.org>
365 Add type checking to navigation primary key value creation.
367 Create navigation primary key only if the expected type from the Glom
368 document matches the type returned by the SQL query.
370 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
372 2011-12-05 Ben Konrath <ben@bagu.org>
374 Rename a couple of variables in RelatedListNavigation.
376 This is a rename-only refactor.
378 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
380 2011-12-05 Ben Konrath <ben@bagu.org>
382 Move getListLayoutGroup() into getListViewLayoutGroup().
384 This removes getListLayoutGroup(). It was only being called by
385 getListViewLayoutGroup().
387 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
389 2011-12-05 Ben Konrath <ben@bagu.org>
391 Remove check for LayoutItem_Portal in list table method.
393 This check is no longer necessary because the method isn't being used
394 to create the LayoutItemPortal DTO.
396 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
398 2011-12-05 Ben Konrath <ben@bagu.org>
400 Properly support related list navigation.
402 Navigation from the "Repository Analyzer -> Package Scans ->
403 Dependencies" related table wasn't working because the primary key for
404 related tables wasn't being set properly. This commit fixes the
407 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
408 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
409 doesn't set the primary key properly for related list tables.
410 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
411 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
412 useful for getting the primary key for list view tables and for related
414 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
415 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
416 Move code to set the primary key for the table from the abstract
417 ListDBAccess class to ListViewDBAccess as it's only correct for list
419 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
420 Properly add primary key to related list tables.
422 2011-12-02 Ben Konrath <ben@bagu.org>
424 Properly set the horizontal alignment of fields.
426 This fix is for both the list tables and the details view.
428 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
429 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
430 to set the horizontal alignment of fields.
432 2011-12-02 Ben Konrath <ben@bagu.org>
434 Display currency codes in the details view.
436 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
438 2011-12-02 Ben Konrath <ben@bagu.org>
440 Avoid duplicate JNI call.
442 JNI is not as efficient as pure Java and this is an easy (and small)
445 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
446 Use previously retrieved value for whereClauseToTableName instead of
449 2011-12-02 Ben Konrath <ben@bagu.org>
451 Rename a couple of variables in RelatedListNavigation.
453 This is a rename-only refactor.
455 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
457 2011-12-02 Ben Konrath <ben@bagu.org>
459 Indicate clearly that a mismatched primary key type is a bug.
461 * src/main/java/org/glom/web/server/Utils.java: Change log level from
462 warning to error. Add 'This is a bug.' to message.
464 2011-12-02 Ben Konrath <ben@bagu.org>
466 Update / fix some comments.
468 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
470 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
472 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
473 Fix comments. Add some TODOs.
475 2011-12-02 Ben Konrath <ben@bagu.org>
477 Enable navigation to details view with string primary key from related list.
479 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
480 Create a text primary key value when return type of result is
481 java.sql.Types.VARCHAR.
483 2011-12-02 Ben Konrath <ben@bagu.org>
485 Use checkboxes for booleans in the details view.
487 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
489 2011-12-01 Ben Konrath <ben@bagu.org>
491 Improve performance of related list height calculation.
493 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
494 Put code to calculate the expected height in a static initializer so
495 that that it's only called once.
497 2011-12-01 Ben Konrath <ben@bagu.org>
499 Show related list tables in notebooks (again).
501 Calculate the height of the related list tables so the Notebook can be
502 set the correct height. The height of the related list table is also needed by
503 FlowTable to be able decide how to create the layout.
505 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
506 and set the Portal height based on the height of the related list
507 table and the Portal container.
508 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
509 Add method to calculate the height of the related list tables.
510 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
511 * src/main/webapp/style.css: Add css class for Pager. This is needed to
512 calculate the height of the Pager widget.
514 2011-12-01 Ben Konrath <ben@bagu.org>
516 Use CellTable API for table property instead of setting style on Element.
518 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
520 2011-12-01 Ben Konrath <ben@bagu.org>
522 Make ListViewTable and RelatedListTable a consistent height.
524 The tables are now a consistent height regardless of the contents of
525 the table. A hidden button is added to empty rows to ensure that the
526 height of these rows will match the height of rows with data.
528 A navigation button column is now added to every table. The width of
529 the navigation column is set to 0px when a RelatedListTable shouldn't
530 have navigation buttons. This maintains the a consistent row height in
531 tables that don't show the navigation buttons.
533 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
534 navigation column when not needed.
535 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
536 arguments for navigation button to constructor of ListViewTable.
537 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
538 hidden button for empty data rows.
539 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
540 arguments for navigation button to constructor.
541 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
542 create navigation buttons. Add hideNavigationButtons() method.
543 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
544 arguments for navigation button to constructor.
546 2011-12-01 Ben Konrath <ben@bagu.org>
548 Use 'visibility: hidden' in Utils.getWidgetHeight().
550 This is better choice because hidden elements are invisible, don't
551 respond to events and are not part of the tab order. They will,
552 however, take up space which is required to be able to calculate the
553 height of the widget.
555 * src/main/java/org/glom/web/client/Utils.java:
557 2011-12-01 Ben Konrath <ben@bagu.org>
559 Use Utils.getWidgetHeight() in FlowTable.
561 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
563 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
565 2011-12-01 Ben Konrath <ben@bagu.org>
567 Put the details css class name on the correct table column.
569 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
571 2011-11-30 Ben Konrath <ben@bagu.org>
573 Update for java-libglom API change.
575 The getters and setters on FieldFormatting and NumericFormat were
576 changed to remove the 'M'.
578 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
580 2011-11-29 Ben Konrath <ben@bagu.org>
582 Only allow RelatedListTables in Portals.
584 * src/main/java/org/glom/web/client/ui/details/Portal.java:
586 2011-11-29 Ben Konrath <ben@bagu.org>
588 Only create a contents panel for Portals when title is being set.
590 * src/main/java/org/glom/web/client/ui/details/Portal.java:
592 2011-11-29 Ben Konrath <ben@bagu.org>
594 Set TabLayoutPanel height based on calculated height its widgets.
596 This is a potential fix for this bug:
598 https://bugzilla.gnome.org/show_bug.cgi?id=665133
600 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
602 2011-11-29 Ben Konrath <ben@bagu.org>
604 Align details field labels and data with the Open buttons.
606 * src/main/webapp/style.css:
608 2011-11-29 Ben Konrath <ben@bagu.org>
610 Remove unnecessary <div> in the Notebook widget.
612 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
613 method to get container FlowPanel (<div>).
614 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
615 initWidget() method directly on the TabLayoutPanel widget instead of
616 Group's container widget.
618 2011-11-29 Ben Konrath <ben@bagu.org>
620 Don't add group titles for Portals in Notebooks.
622 This reverts the previous patch and fixes a bug I introduced with
623 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
625 * src/main/java/org/glom/web/client/ui/details/Group.java:
626 * src/main/java/org/glom/web/client/ui/details/Portal.java:
628 2011-11-28 Ben Konrath <ben@bagu.org>
630 Remove unused boolean argument in Portal constructor.
634 * src/main/java/org/glom/web/client/ui/details/Group.java:
635 * src/main/java/org/glom/web/client/ui/details/Portal.java:
637 2011-11-28 Ben Konrath <ben@bagu.org>
639 Remove hack for glom 1.18 style glom files.
641 * src/main/java/org/glom/web/client/ui/details/Group.java:
642 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
643 * src/main/java/org/glom/web/client/ui/details/Portal.java:
645 2011-11-28 Ben Konrath <ben@bagu.org>
647 Use Gda Value version of primary key to log result too large error.
649 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
651 2011-11-28 Ben Konrath <ben@bagu.org>
653 Don't use TypedDataItem.getText() for Unknown types from the URL.
655 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
656 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
657 instead of getText().
658 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
659 String field and getUnknown() method.
661 2011-11-28 Ben Konrath <ben@bagu.org>
663 Log an error message when the java-libglom .so is not present.
665 The error message was being set in the exception but not logged.
667 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
669 2011-11-28 Ben Konrath <ben@bagu.org>
671 Ignore LayoutItem_CalendarPortals.
673 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
674 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
676 2011-11-28 Ben Konrath <ben@bagu.org>
678 Extract method for creating the LayoutItemPortal DTO.
680 Just breaking the code up into smaller chunks.
682 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
684 2011-11-28 Ben Konrath <ben@bagu.org>
688 This should have been added with the refactor. Oops!
690 * src/main/java/org/glom/web/shared/TypedDataItem.java:
692 2011-11-28 Ben Konrath <ben@bagu.org>
694 Create primary key value from URL string using type from Glom document.
696 See this bug, comments 19 - 25:
698 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
700 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
701 create a TypeDataItem for the primary key here when loading from a
702 URL. Show the same string for the primary key value as was received
703 from the URL string (when loading from a URL).
704 * src/main/java/org/glom/web/server/Utils.java: Update method for
705 creating the Gda Value from the TypeDataItem to properly deal with
706 creating a Gda Value based on the Glom document type for the primary
707 key value string when loading from a URL.
708 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
709 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
710 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
711 Update for changed method name.
713 2011-11-27 Ben Konrath <ben@bagu.org>
715 Rename PrimaryKeyItem to TypedDataItem.
717 The name PrimaryKeyItem suggests what the class should be used for.
718 TypedDataItem is a neutral name that describes the class better.
720 This is a rename-only refactor.
722 * src/main/java/org/glom/web/client/OnlineGlomService.java:
723 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
724 * src/main/java/org/glom/web/client/Utils.java:
725 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
726 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
727 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
728 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
729 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
730 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
731 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
732 * src/main/java/org/glom/web/server/Utils.java:
733 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
734 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
735 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
736 * src/main/java/org/glom/web/shared/NavigationRecord.java:
738 2011-11-25 Ben Konrath <ben@bagu.org>
740 Improve Gda Value conversion from PrimaryKeyItem.
742 The value from the PrimaryKeyItem is only used if its type match the
743 type from the glom document.
745 * src/main/java/org/glom/web/server/Utils.java:
747 2011-11-25 Ben Konrath <ben@bagu.org>
749 Manually check if the java-liblgom .so is visible to the JVM.
751 It seems that Tomcat has problems when a static initializer throws an
752 exception. This check is done before the first method call into
753 java-libglom so that execution doesn't continue if the .so is not
756 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
758 2011-11-25 Ben Konrath <ben@bagu.org>
760 Improve browser configuration error messages.
764 https://bugzilla.gnome.org/show_bug.cgi?id=662792
766 * src/main/java/org/glom/web/client/OnlineGlomService.java:
767 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
768 getConfigurationErrorMessage() method.
769 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
770 Get and display a specific configuration error message when no Glom
772 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
773 Implement getConfigurationErrorMessage() method. Surround configuration
774 code in the init() method with a try/catch block. This allows the
775 errors to be caught while keeping the servlet available to retrieve the
776 configuration error message.
778 2011-11-25 Ben Konrath <ben@bagu.org>
780 Don't use Strings to hold primary key values.
782 The primary key values are now held in a new data object
783 (PrimaryKeyItem) that holds type information and the primary key value
784 using the correct type.
786 * src/main/java/org/glom/web/client/OnlineGlomService.java:
787 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
788 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
789 PrimaryKeyItem instead of String to hold the primary key value.
790 * src/main/java/org/glom/web/client/Utils.java: Remove
791 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
792 PrimaryKeyItem based on the GlomFieldType and the DataItem.
793 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
794 PrimaryKeyItem instead of String to hold the primary key value. Load
795 document selection page when the documentID has not been set correctly.
796 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
797 DetailsPlace -> URL and URL -> DetailsPlace conversion with
799 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
800 Return empty string for URL instead of "null".
801 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
802 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
803 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
804 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
805 PrimaryKeyItem instead of String to hold primary key values.
806 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
807 PrimaryKeyValue to a Gda Value.
808 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
809 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
810 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
811 Replace temporary database access code that uses the PrimaryKeyValue to
812 Gda Value conversion.
813 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
814 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
815 PrimaryKeyItem instead of String.
816 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
817 hold primary key values.
819 2011-11-24 Ben Konrath <ben@bagu.org>
821 Use newly added java-libglom API to create queries.
823 This isn't finished. I still need to stop using Strings for primary key
824 values in the client code.
826 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
827 libglom to use fake connections so that retrieving the query string will
829 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
830 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
831 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
832 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
833 Use the newly added libglom sql methods and classes to create the
834 query. Add temporary hack to convert primary value strings to Gda
837 2011-11-23 Ben Konrath <ben@bagu.org>
839 Don't explicitly set the height of Portals.
841 See comments 6 - 10 of this bug for details:
843 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
845 * src/main/java/org/glom/web/client/ui/details/Portal.java:
847 2011-11-23 Ben Konrath <ben@bagu.org>
849 Use an HTML table instead of CSS for the FlowTable layout.
851 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
852 GWT's FlexTable to implement the FlowTable.
853 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
855 2011-11-18 Ben Konrath <ben@bagu.org>
857 Add boolean example to HTML table mockup.
859 * mockups/details-view-html-tables-text-entries.html:
861 2011-11-17 Ben Konrath <ben@bagu.org>
863 Ensure the pager buttons are always visible for related lists.
865 To accomplish this, I've turned off text wrapping in the list view and
866 related list tables for both the header and data text. The related list
867 table now has a fixed layout so the it doesn't overflow its container.
868 This is required to ensure that the cell text is clipped when it
869 overflows the cell and an ellipsis is added to the right side of the
870 cell when text is clipped.
872 A fixed table layout for the related list table in the details view
873 seems what we want for the details view anyway, so the side-effect is
876 The ellipsis will only be displayed in Firefox >= 7.
880 https://bugzilla.gnome.org/show_bug.cgi?id=662930
882 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
883 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
884 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
886 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
887 Set the 'table-layout: fixed' CSS property to the related list table.
888 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
889 'white-space: nowrap;' CSS property on both the list view and the
892 2011-11-16 Ben Konrath <ben@bagu.org>
894 Rework the fix for empty notebook tab labels.
896 Setting the empty group titles with its name caused problems for the
897 details layout. Instead of using libglom's
898 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
899 to the client when the title is empty. This allows the Notebook to use
900 the name when the title is empty without affecting anything else.
902 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
903 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
905 2011-11-16 Ben Konrath <ben@bagu.org>
907 Set group titles with name when title is empty.
909 This fixes a problem with an empty notebook tab label in the Lesson
910 Planner document. The forth tab in the notebook should be "Internet":
912 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
914 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
915 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
918 2011-11-16 Ben Konrath <ben@bagu.org>
920 Remove whitespace from the configured username properties.
922 This assumes that usernames won't have whitespace at the beginning
923 or end. But I think this is a reasonable assumption.
925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
926 String.trim() to remove the whitespace from the username properties.
928 2011-11-15 Ben Konrath <ben@bagu.org>
930 Add details view mockup with HTML tables and text entries.
932 This is from the attachment on this bug:
934 https://bugzilla.gnome.org/show_bug.cgi?id=663109
936 * mockups/details-view-html-tables-text-entries.html:
938 2011-11-15 Ben Konrath <ben@bagu.org>
940 Add space between the columns of the flow table.
944 https://bugzilla.gnome.org/show_bug.cgi?id=662918
946 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
947 space between columns in the flow table.
949 2011-11-15 Ben Konrath <ben@bagu.org>
951 Add backup files to the .gitignore.
953 * .gitignore: Ignore files that end with ~.
955 2011-11-09 Ben Konrath <ben@bagu.org>
957 Use latest release of gwt-log.
959 Gwt-log releases are now being submitted to the maven central
960 repository so manual installation of the jar is no longer required.
962 * pom.xml: Update version and groupId of gwt-log dependency.
964 2011-10-31 Ben Konrath <ben@bagu.org>
966 Don't use GWT numeric formatting to override the glom currency formatting.
968 Currencies are now displayed like they are in Glom. See this bug:
970 https://bugzilla.gnome.org/show_bug.cgi?id=646216
972 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
974 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
975 currency code to constructor and set it when the cell is rendered.
976 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
977 currency code to the constructor of the NumericCell.
979 2011-10-27 Ben Konrath <ben@bagu.org>
981 Require the latest release of java-libglom (1.17.4).
985 2011-10-26 Ben Konrath <ben@bagu.org>
987 Add style to Notebook that matches current theme.
989 It's not the best style in the world but it's better than the default.
991 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
992 padding at the bottom of the child widgets.
993 * src/main/webapp/style.css: Add style for the Notebook.
995 2011-10-26 Ben Konrath <ben@bagu.org>
997 Move servlet initialization code to overridden init method.
999 This is half of the solution to getting proper error messages
1000 displayed when configuration errors occur. Here's the relevant bug:
1002 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1004 The rest of the solution involves surrounding the init method with a
1005 try/catch block and setting a global variable with the error /
1006 exception. A new async method should be created to retrieve and display
1007 the error message / exception.
1009 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1010 code from constructor to init method adding exceptions as needed.
1012 2011-10-26 Ben Konrath <ben@bagu.org>
1014 Add script to monitor and restart tomcat if required.
1016 * utils/check-and-recover-tomcat.py: New file.
1018 2011-10-26 Ben Konrath <ben@bagu.org>
1020 Display the correct number of data items in the pager.
1024 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1026 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1027 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1028 The implementation is the same for both tables: Keep track of the
1029 number of non-empty rows and fire and RowCountChangeEvent after the data has
1031 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1032 custom Pager class that subclasses SimplePager to handle displaying
1033 the correct number when empty rows have been added.
1035 2011-10-26 Ben Konrath <ben@bagu.org>
1037 Correct error in previous commit.
1039 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1040 eventBus parameter from listView.setCellTable().
1042 2011-10-26 Ben Konrath <ben@bagu.org>
1044 Fix error in TODO comment.
1046 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1048 2011-10-24 Ben Konrath <ben@bagu.org>
1050 Create Notebook widgets to the details view.
1052 This isn't finished just yet - I still need to create a reasonable
1053 style to match the current theme.
1055 * src/main/java/org/glom/web/client/Utils.java: Add method for
1056 calculating the height of a widget. This is used in the Notebook class.
1057 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1058 new constructor method in Group.
1059 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1060 method for creating child widget that can be used by subclasses
1061 like Notebook. New constructor that allows disabling the group
1062 titles - Notebooks don't set a group title for their child groups.
1063 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1064 to make Notebooks using GWT's TabLayoutPanel.
1065 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1066 constructor that allows disabling the group titles.
1067 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1068 LayoutItemNotebook DTO.
1069 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1070 DTO for Notebooks. It's just an empty class for now but we might need
1071 it to transfer some specific information in the future.
1073 2011-10-21 Ben Konrath <ben@bagu.org>
1075 Add navigation buttons to related list tables.
1077 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1078 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1079 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1080 method getSuitableRecordToViewDetails() for getting the table name
1081 and primary key value for related list navigation buttons.
1082 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1083 private cell renderer class to get the navigation information for
1084 related list tables from the server. Extract the navigation
1085 processing code from the details cell navigation and use it for the
1086 related list navigation as well.
1087 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1088 cell renderer class for the details open buttons. This was needed
1089 because the related list navigation buttons and the list view
1090 navigation buttons need to react differently when clicked.
1091 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1092 the onEnterKeyDown() method because it's now overriden in the
1093 subclasses that are specific to the related list tables and the list
1095 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1096 the vertical size a little because the buttons add a bit of vertical
1097 space to table. This is not a perfect solution because the vertical
1098 size of with table fewer than 5 rows will be a little smaller.
1099 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1100 changes in how navigation buttons are handled.
1101 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1102 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1103 database access object.
1104 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1105 to find the portal for a given relationship name from
1106 RelatedListDBAccess. Add method to find a primary key field for a
1108 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1109 Move code to find the portal for a given relationship name to
1111 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1112 New file: database access object for getting the related list
1113 navigation information (the table name and the primary key value).
1114 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1115 DTO for transferring a table name to navigate to and a primary key
1117 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1118 boolean and getter/setter to specifies if the related list should add
1121 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1123 Use the master branch of java-libglom
1125 * pom.xml: Depend on java-libglom 1.19 instead.
1127 This is the master branch. See also the libglom-1-18 branch.
1129 2011-10-11 Ben Konrath <ben@bagu.org>
1131 Enable the open navigation button when the data has been set.
1133 This avoids having active buttons that don't do anything when the data
1136 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1138 2011-10-11 Ben Konrath <ben@bagu.org>
1140 Use IsWidget interface for FlowTableItem.
1142 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1143 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1145 2011-10-11 Ben Konrath <ben@bagu.org>
1147 Remove GWT styling from open button in details view.
1149 There are still some issues with how the details cell is arranged but
1150 this should be made to match Glom 1.20. I'm going to leave fixing this
1151 until I have Glom 1.20 up and running.
1153 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1154 style name on open button.
1155 * src/main/webapp/style.css: Move and edit details-navigation class.
1156 Re-arrange some classes to make them appear in the same order as the
1159 2011-10-07 Ben Konrath <ben@bagu.org>
1161 Update to GWT 2.4.0.
1163 * .gitignore: Ignore new cache directory.
1164 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1165 * pom.xml: Change GWT and maven plugin to 2.4.0.
1166 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1168 * src/main/java/org/glom/web/client/ClientFactory.java:
1169 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1170 * src/main/java/org/glom/web/client/OnlineGlom.java:
1171 Update source for API changes.
1172 * utils/build-onlineglom-war.sh: Remove cache directory before the
1175 2011-10-07 Ben Konrath <ben@bagu.org>
1177 Add navigation buttons in the details view.
1179 This isn't finished but I thought I'd commit what I have as it's a
1180 pretty good start. I still need to:
1182 1. Change the style so that it fits better into the current theme
1183 2. Adjust the details cell to expand as much as possible.
1185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1186 click handlers to navigation buttons in the DetailsCells. Create a
1187 refreshData() method to get just the data from the server without the
1189 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1190 Update the tableSelector and browser title when the table name
1191 changes without using the tableSelector.
1192 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1193 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1194 getDetailsCells() to getCells(). Update variable names.
1195 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1196 method to set click handler on navigation button. Rename a few
1197 variables. Add navigation buttons where needed.
1198 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1199 variables and methods.
1200 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1201 navigation boolean and navigation table as required in the
1202 LayoutItemField DTO.
1203 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1204 variables for navigation along with getter/setter methods.
1206 2011-10-07 Ben Konrath <ben@bagu.org>
1208 Rename Field to DetailsCell.
1210 This is a refactor-only commit. No functionality has been added or
1213 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1214 Update variable and method names.
1215 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1216 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1217 variable and method names.
1218 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1220 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1221 variable and method names.
1223 2011-10-07 Ben Konrath <ben@bagu.org>
1225 Create separate methods for layout and data the details view.
1227 This is a refactor-only commit. No functionality has been added or
1230 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1231 private methods: setData(), createLayout().
1233 2011-10-07 Ben Konrath <ben@bagu.org>
1235 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1237 This is part of a change to get navigation buttons in the details view
1238 but it should have been done this way from the start.
1240 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1241 for method name change in TableSelectionView.
1242 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1243 Create TableChangeEvent and set the browser title using the
1244 TableSelectionView API.
1245 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1246 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1247 Change getSelectedTable() to getSelectedTableName(). Add
1248 getSelectedTableTitle().
1250 2011-10-07 Ben Konrath <ben@bagu.org>
1252 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1254 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1256 2011-10-07 Ben Konrath <ben@bagu.org>
1258 Update TableChangeEvent to use newTableName naming convention.
1260 This makes the class more consistent with GWT naming conventions.
1262 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1263 Update for method name change in TableChangeEvent.
1264 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1265 for method name change in TableChangeEvent.
1266 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1267 newTableName variable and getter method. Make toDebugString()
1270 2011-09-30 Ben Konrath <ben@bagu.org>
1272 Disable the pager in the list tables when the data row count is less than the minimum.
1274 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1275 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1277 2011-09-30 Ben Konrath <ben@bagu.org>
1279 Add empty rows to the end of related list and list view tables.
1281 I also extracted the cell rendering classes from the ListTable because
1282 the code was becoming a little crazy with all the anonymous inner
1283 classes. My plan is to use these cell rendering classes in the details
1284 view as well so this refactor will be needed for that change.
1286 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1287 set the row count in related list tables if the data has more rows
1288 than the minimum number of rows visible.
1289 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1290 row count in list view tables if the data has more rows than the
1291 minimum number of rows visible.
1292 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1293 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1295 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1296 for rendering TYPE_NUMERIC cells. The code was extracted from the
1298 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1299 class for rendering cells with buttons in list views. The code was
1300 extracted from the ListTable class.
1301 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1302 for rendering TYPE_TEXT cells. The code was extracted from the
1304 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1305 Add empty rows to the end of the data if required. Implement
1306 ListTable.getMinNumVisibleRows().
1307 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1308 cell renderer code to public classes. Return null in
1309 Column.getValue() for empty rows. Add new abstract method:
1310 getMinNumVisibleRows(). Move code to set the row count of the list view
1311 table to ListViewImpl.
1312 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1313 empty rows to the end of the data if required. Implement
1314 ListTable.getMinNumVisibleRows().
1317 2011-09-27 Ben Konrath <ben@bagu.org>
1319 Use GWT.log for client-side debugging statements.
1321 These are optimized out when deployed so I should have used this method
1322 in the first place. These statements will eventually be replaced with some sort
1323 of notification in the browser.
1325 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1326 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1327 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1328 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1329 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1331 2011-09-27 Ben Konrath <ben@bagu.org>
1333 Put tableselector on the right, back to list link on right.
1335 The idea is that the table selector is acting like a label for the
1336 currently displayed table so it should be placed below the document title. This
1337 puts the table title in a similar position to where it is in Glom.
1339 * mockups/details-contacts.html:
1340 * mockups/details-projects.html:
1341 * mockups/listview-contacts.html:
1342 * mockups/listview-projects.html:
1343 * mockups/style.css:
1344 Update mockups to match how the interfaces currently look.
1345 * src/main/webapp/style.css: Swap positions of backlink with the table
1346 selector. Add some space on the left side of the table selector to
1347 line things up with the document title.
1349 2011-09-27 Ben Konrath <ben@bagu.org>
1351 Add field colouring to details view.
1353 This change re-works how field colouring works. The colour formatting
1354 information is now set to the client with the layout information instead of
1355 with the data. This eliminates the need to send the same colour strings for
1356 data in list view column when colour information is set.
1358 In order to set an alternate colour for negative numeric values, the
1359 number is now sent to client and formatted with the GWT NumberFormat class.
1361 This change also fixes:
1363 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1365 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1366 internationalization framework which is needed for client side numeric
1368 * src/main/java/org/glom/web/client/Utils.java: New file for some
1369 client static utility methods.
1370 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1371 the DataItem object to the Field class. Use a utility method to
1372 create the foreignKeyValue string.
1373 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1374 alignment and text colours in the constructor. Add setData(DataItem)
1375 method. Remove setText(String) method.
1376 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1377 colour information to GlomTextCell. Create and use GlomNumberCell for
1378 rendering numbers. Use utility method to get the string for the
1379 primary key of the key provider. Re-work how the horizontal alignment
1381 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1382 formatting to layout information. Methods for converting the libglom
1383 formatting information were moved from DBAccess.
1384 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1385 numeric formatting (it's now done on the client side). Don't set text
1386 colours in DataItem. Move libglom formatting conversion methods to
1388 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1389 getters/setters for text colour information.
1390 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1391 for transferring the libglom NumericFormat information to the client.
1392 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1393 and getters/setters for: GlomNumericFormat, background colour and
1394 foreground colour strings.
1396 2011-09-26 Ben Konrath <ben@bagu.org>
1398 Simplify code that iterates through the LayoutGroup.
1400 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1402 2011-09-26 Ben Konrath <ben@bagu.org>
1404 Accept Eclipse formatting for OnlineGlomServiceAsync.
1406 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1408 2011-09-26 Ben Konrath <ben@bagu.org>
1410 Don't use the ListDBAccess classes to get the primary key layout information.
1412 This was causing a bug where the wrong index for the hidden primary key
1413 was being sent to the client.
1415 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1416 primary key while creating the LayoutGroup DTO. Create a
1417 LayoutItemField DTO for hidden primary keys. Don't use the
1418 RelatedListDBAccess because it was only used for getting the primary
1420 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1421 access modifier from public to protected for getPrimaryKeyField() and
1422 getPrimaryKeyLayoutItemField().
1423 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1424 abstract method getExpectedResultSize() because RelatedListDBAccess
1425 doesn't have enough info to implement it.
1426 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1427 Remove @Override for getExpectedResultSize().
1428 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1429 Remove method getExpectedResultSize().
1431 2011-09-23 Ben Konrath <ben@bagu.org>
1433 Log which layout (list or details) the ignored item is from.
1435 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1437 2011-09-23 Ben Konrath <ben@bagu.org>
1439 Remove annotations that turn off code formatting in DataItem.
1441 * src/main/java/org/glom/web/shared/DataItem.java:
1443 2011-09-23 Ben Konrath <ben@bagu.org>
1445 Rename GlomField to DataItem and update associated methods.
1447 This is a rename-only refactor. No functionality has been added or
1450 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1451 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1452 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1453 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1454 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1455 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1456 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1457 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1458 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1459 * src/main/java/org/glom/web/server/database/DBAccess.java:
1460 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1461 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1462 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1463 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1464 * src/main/java/org/glom/web/shared/DataItem.java:
1465 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1466 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1468 2011-09-23 Ben Konrath <ben@bagu.org>
1470 Rename GlomDocument to DocumentInfo and update associated methods.
1472 This is a rename-only refactor. No functionality has been added or
1475 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1476 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1477 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1478 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1479 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1480 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1481 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1483 2011-09-20 Ben Konrath <ben@bagu.org>
1485 Require java-libglom 1.17.3.
1487 This picks up the fix for the seg fault problem with the Scenes table
1488 in the Openismus Film Manager example.
1492 2011-09-20 Ben Konrath <ben@bagu.org>
1494 Change the way sort clause is added for primary key when no sort clause is requested.
1496 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1497 before the sort clause is created. When a sort clause is not requested, the
1498 sort clause is created by finding the primary key in the LayoutFieldVector
1501 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1503 2011-09-20 Ben Konrath <ben@bagu.org>
1505 Log error message if no documents are found in the configured directory.
1507 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1508 Extract the glom file extension string to a private static final class
1509 variable (mostly as syntactic sugar). Accept a minor formatting change.
1510 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1511 the example glom.document.directory configuration property to make it
1512 more clear that it can any directory, not just the home directory.
1514 2011-09-18 Ben Konrath <ben@bagu.org>
1516 Add related lists to details view.
1518 The related list table has support for paging and sorting just like the
1519 table in the list view.
1521 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1522 SQL queries for the related list tables.
1523 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1524 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1525 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1526 Rename getList methods to getListView and add comments. Remove
1527 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1528 it being unused. Add methods: getDetailsLayoutAndData(),
1529 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1530 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1531 Create the layout and set the data for the fields in one async call
1532 instead of two. Create related lists where appropriate.
1533 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1534 for method name changes in OnlineGlomService.
1535 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1536 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1537 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1539 * src/main/java/org/glom/web/client/ui/ListView.java:
1540 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1541 tableName from setCellTable(). Create a ListViewTable instead of
1543 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1544 represent a data field in the details view.
1545 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1546 from addDetailsCell() to Field class. Keep track of the Fields and
1547 Portals in the details view.
1548 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1549 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1550 and add a method to get it. Add method to set the contents of the
1552 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1553 New class for related list tables. This class has the data provider
1554 for the related list table.
1555 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1556 abstract class which is the base class for the ListViewTable and the
1558 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1559 New class for list view tables. This class has the data provider for
1560 the list view table.
1561 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1562 methods for related list tables. Add more information to the
1563 LayoutItemField and LayoutItemPortal DTOs.
1564 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1565 Remove debugging print statement.
1566 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1567 Remove debugging print statements. Add primary key field to SQL count
1569 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1570 Remove unnecessary LayoutFieldVector parameter from
1571 getResultSizeOfSQLQuery() method.
1572 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1573 New class for related list table database access.
1574 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1575 class that is a wrapper DTO for details view layout and data.
1576 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1577 new 'fromField' string to this DTO.
1578 * src/main/webapp/style.css: Remove bottom margin and override top
1581 2011-09-15 Ben Konrath <ben@bagu.org>
1583 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1585 This sets things up to make it easier to add the data retrieval for
1586 related lists (portals). No user noticeable changes were made with
1589 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1590 class has the code to retrieve the layouts and access the
1591 database using the new database helper classes.
1592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1593 Most of the functionality has been removed from this class. This
1594 class now represents the public interface for the client side
1595 code. It also deals with configuring the servlet and cleaning
1596 things up when the servlet is stopped.
1597 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1598 of static methods into this utility class.
1599 * src/main/java/org/glom/web/server/database/DBAccess.java:
1600 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1601 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1602 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1603 These classes have the database retrieval code. The class hierarchy
1604 has been setup to make it easy to reuse code for similar
1607 2011-09-06 Ben Konrath <ben@bagu.org>
1609 Create separate classes for list table code and the data provider.
1611 As part of this refactor, I also split up the code a bit to make it
1614 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1615 table code to two new classes (below).
1616 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1617 with code from ListViewImpl.
1618 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1619 New file with code from ListViewImpl.
1621 2011-09-06 Ben Konrath <ben@bagu.org>
1623 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1625 This fixes the LayoutItemPortal DTO to match the libglom layout object
1628 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1630 2011-09-01 Ben Konrath <ben@bagu.org>
1632 Set title of Portals in the Details View.
1634 * pom.xml: Bump required version of java-libglom to 1.17.1.
1635 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1636 widget creation to its own class. Add comments to constructor.
1637 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1638 The code is mostly from the Group class with the title now set.
1639 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1640 title of Portal. Update some comments. Fix some code formatting.
1642 2011-09-01 Ben Konrath <ben@bagu.org>
1644 Remove TODO comment for the flow table column width.
1646 The flow table column width is working correctly and doesn't need to be
1647 changed. See this mailing list post for more info:
1649 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1651 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1653 2011-08-27 Ben Konrath <ben@bagu.org>
1655 Add document title (database name) to top of the browser page.
1657 I added the document title to the TableSelecitonView but that will
1658 change if / when we add a view that doesn't require table selection.
1660 * mockups/details-contacts.html:
1661 * mockups/details-projects.html:
1662 * mockups/listview-contacts.html:
1663 * mockups/listview-projects.html:
1664 * mockups/style.css: Add document title to mockups to keep things
1666 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1667 sizes to account for the document title.
1668 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1669 Set the document title when it has been retrieved from the server.
1670 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1671 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1672 and implement setDocumentTitle(String) method.
1673 * src/main/webapp/style.css: Add ID for document title style.
1675 2011-08-25 Ben Konrath <ben@bagu.org>
1677 Add NavigationType enum to LayoutItemPortal DTO.
1679 This is the start of adding support for Portals to the Details View.
1681 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1682 LayoutItem_Portal.navigation_type enum from libglom to
1683 LayoutItemPortal.NavigationType enum.
1684 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1685 NavigationType enum, field for storing the NavigationType and getter
1688 2011-08-25 Ben Konrath <ben@bagu.org>
1690 Implement the flow table layout in the Details View.
1692 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1693 FlowTable to Group to account for the renamed class.
1694 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1695 File. This is a container widget that implements the Glom details view
1696 flow table behaviour.
1697 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1698 org/glom/web/client/ui/FlowTable.java.
1699 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1700 so that the size of the subgroups are a closer match to the size of
1701 the Glom subgroups. This makes the flowtable layout match the layout
1702 in Glom for the Music Collection example file.
1704 2011-08-16 Ben Konrath <ben@bagu.org>
1706 Create container element for LayoutItemPortal in Details View.
1708 This will help me develop the layout for the FlowTable.
1710 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1711 fieldPanel variable to detailsCell.
1713 2011-08-15 Ben Konrath <ben@bagu.org>
1715 Set the height of the data element in the Details View.
1717 I changed the InlineLabels (text in a span element) to Labels (text in
1718 a div element) so that I could set the height of the details-data
1719 elements instead of the details-cell parent elements. This allows the
1720 the details-data element to display the correct height if style is
1721 applied that shows the height.
1723 This change has the added benefit of allowing the order of the labels
1724 and data elements to be changed for right-to-left languages.
1726 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1727 InlineLabels to Labels.
1728 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1729 InlineLabels to Labels. Set the height of the data element.
1730 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1731 multiline text height in the Formatting DTO.
1732 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1733 for multiline height along with getter and setter methods.
1734 * src/main/webapp/style.css: Adjust style to account for the change
1735 from span elements to div elements in the details cell.
1737 2011-08-15 Ben Konrath <ben@bagu.org>
1739 Make the List View appearance match the mockups.
1741 It doesn't match exactly but it's much better than it was.
1743 * mockups/listview-contacts.html: Remove unused css classes.
1744 * mockups/listview-projects.html: Remove unused css classes.
1745 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1746 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1747 for mainPanel instead of VerticalPanel (table). Set style name on
1748 CellTable. Set style name on Details column. Right-align Details
1750 * src/main/webapp/style.css: Adjust properties to match the mockups.
1752 2011-08-12 Ben Konrath <ben@bagu.org>
1754 Add better support for subgroups in the details view.
1756 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1757 changed FlowTable constructor.
1758 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1759 support for subgroups and subgroup-titles.
1760 * src/main/webapp/style.css: Add CSS class for subgroups and
1763 2011-08-12 Ben Konrath <ben@bagu.org>
1765 Return the top level LayoutGroup title.
1767 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1769 2011-08-11 Ben Konrath <ben@bagu.org>
1771 Make the TableSelector header match the mockup.
1773 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1774 the layout panel. Properly lineup the table selection header with
1775 the list and details view.
1776 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1777 margin around the details view.
1778 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1779 Rename listBox variable to tableSelector. Set id for the style sheet.
1780 Use a FlowPanel instead of a HorizontalPanel.
1781 * src/main/webapp/style.css: Add properties to make the TableSelector
1782 box match the mockups.
1784 2011-07-13 Ben Konrath <ben@bagu.org>
1786 Update install script for java-libglom version change.
1788 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1791 2011-07-13 Ben Konrath <ben@bagu.org>
1793 Add support sub-group in the details view.
1795 I also removed the code that special-cased the default details view
1798 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1800 I still have to make a proper flowtable.
1802 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1803 Don't special-case default details view layout.
1804 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1805 addLayoutField() as I'm going to use it.
1806 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1807 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1809 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1810 extracted from DetailsViewImpl.GroupPanel. Add support for
1812 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1813 column count when getting the details layout.
1815 2011-07-12 Ben Konrath <ben@bagu.org>
1817 Set browser title with database and table titles.
1819 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1820 Set the browser title when the table changes and when the activity
1822 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1823 title when retrieving document info (the GlomDocument object).
1824 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1825 with getter and setter methods. Remove unused convenience constructor.
1826 Use default code formatting.
1828 2011-07-12 Ben Konrath <ben@bagu.org>
1830 Ignore LayoutItemPortals in the details view.
1832 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1835 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1836 LayoutItemPortal layout objects.
1837 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1838 LayoutItemPortal objects when retrieving the details layout.
1839 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1840 file. This is an empty class and just used to get type information for
1843 2011-07-12 Ben Konrath <ben@bagu.org>
1845 Use java-libglom 1.17.0.
1849 2011-07-11 Ben Konrath <ben@bagu.org>
1851 Remove "Table:" label from table selector.
1853 This matches a recent change in the Glom UI.
1855 * mockups/details-contacts.html:
1856 * mockups/details-projects.html:
1857 * mockups/listview-contacts.html:
1858 * mockups/listview-projects.html: Remove the "Table:" label from the
1860 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1862 2011-07-11 Ben Konrath <ben@bagu.org>
1864 Add main groups to the details view.
1866 This makes things look a little nicer in the details view. The next step
1867 is to implement the flowtable.
1869 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1870 resources from the standard gwt css theme. Standard.css is now
1871 included in OnlineGlom.html so that the online glom css rules have
1872 precedence over the gwt theme.
1873 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1874 the whole LayoutGroup to the DetailsView instead of just the titles.
1875 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1876 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1877 details layout with a helper class (GroupPanel). I might extract this
1878 class when I make the full flowtable.
1879 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1880 string as default so I don't have to worry about NPEs when processing
1882 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1883 note beside OnlineGlom.gwt.xml above).
1884 * src/main/webapp/style.css: Add default font-size to body to override
1885 the font-size set by the standard theme. Don't use h2 tags for
1886 group-title. Create new details-cell class.
1888 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1890 ConfiguredDocument: Set the port number too.
1892 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1893 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1894 Glom document. Presumably this worked sometimes so far because there is a
1895 default port number.
1897 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1899 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1901 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1902 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1903 correct, though we should throw an exception too.
1905 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1907 Fix a addDocuemnt typo.
1909 * src/main/java/org/glom/web/shared/Documents.java
1910 (Documents.addDocuemnt): Rename to addDocument().
1911 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1912 (OnlineGlomServiceImpl.getDocuments): Adapt.
1914 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1916 Slightly improved log output when connection fails.
1918 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1919 (ConfiguredDocument.setUsernameAndPassword):
1920 We don't know for sure if it' the username/password that's wrong, so
1921 rephrase the message.
1922 Also ouput the exception message, though it's generic in this case.
1924 2011-07-08 Ben Konrath <ben@bagu.org>
1928 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
1929 added braces to a one line if statement because the Eclipse formatter
1930 was getting confused.
1932 2011-07-07 Ben Konrath <ben@bagu.org>
1934 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
1936 These should really be two separate tasks but I counldn't get things to
1937 work with GWT 2.2.0 and Eclipse 3.7.
1941 * .settings/org.eclipse.jdt.core.prefs:
1942 * .settings/org.eclipse.jdt.ui.prefs:
1943 * .settings/org.eclipse.ltk.core.refactoring.prefs:
1944 * .settings/org.eclipse.m2e.core.prefs:
1945 Add new config files. Update current files. Remove references to the
1946 webtools plugins as we're not using any of the webtools features.
1947 * .gitignore: Add logs directory which is created when running with
1949 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
1950 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
1951 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
1953 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
1955 2011-07-07 Murray Cumming <murrayc@murrayc.com>
1957 onlineglom.properties: Add explanatory comments.
1959 * src/main/resources/onlineglom.properties: Also change the default user
1960 from ben to someuser, to avoid the risk of people thinking we just
1961 stupidly hard-coded a locale path, when they see that on stderr or in a log.
1963 2011-06-28 Ben Konrath <ben@bagu.org>
1965 Use filename in Log for incorrect passwords.
1967 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1968 getFileName(String) method to get the filename from the URI.
1970 2011-06-28 Ben Konrath <ben@bagu.org>
1972 Add the table name to the URL token for the ListPlace.
1974 This makes things consistent between the DetailsPlace and the
1975 ListPlace. It also allows the the ListPlace to be bookmarked.
1977 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1978 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1979 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1980 Remove getDefaultListLayout(). The default layout is now returned
1981 by the getListLayout() method when the table name is an empty string.
1982 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1983 Add table name field. Change to a new ListPlace when the table
1984 has been changed. Use getListLayout() for getting the default
1986 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1987 Add table name field. Set the correct table name in the list box
1988 when loading from bookmark. This corrects a problem for the
1990 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1991 Move table name to super-class (HasSelectableTable). Move document
1992 and table URL keys to super-class in HasSelectableTable.
1993 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1994 Add table name field. Add Tokenizer class with URL key common to
1995 the subclasses (DetailsPlace and ListPlace).
1996 * src/main/java/org/glom/web/client/place/ListPlace.java:
1997 Add table name. Add code to parse the URL token.
1998 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1999 Update ListPlace construction with empty table name string.
2000 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2001 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2002 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2003 Update ListPlace construction with table name string.
2004 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2005 Change defaultTableName field to tableName to reflect how it's now
2006 used. Update the getter and setter methods.
2008 2011-06-28 Ben Konrath <ben@bagu.org>
2010 Enable the table selector in the DetailsView.
2012 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2013 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2014 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2015 Remove getDefaultDetailsLayout(). The default layout is now returned
2016 by the getDetailsLayout() method when the table name is an empty
2018 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2019 event handler for table change event. Change to using
2020 getDetailsLayout() for the default details layout.
2021 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2023 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2024 when navigating to the details place.
2026 2011-06-27 Ben Konrath <ben@bagu.org>
2028 Use filename based unique document ID in URL and for RPC.
2030 The document ID is the glom document name with spaces (' ') replaced
2031 with pluses ('+') and without the .glom extension.
2033 This change is mostly a string substitution of 'documentTitle' for
2034 'documentID'. The only code change is the addition of a Documents DTO to get the
2035 filename to document title mappings as indicated below.
2037 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2038 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2039 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2040 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2041 Use Documents DTO to create the document links in the document
2043 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2044 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2045 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2046 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2047 * src/main/java/org/glom/web/client/place/ListPlace.java:
2048 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2049 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2050 * src/main/java/org/glom/web/client/ui/ListView.java:
2051 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2052 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2053 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2054 * src/main/java/org/glom/web/server/Log.java:
2055 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2056 getDocumentTitles() to getDocuments() and return the Documents DTO.
2057 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2058 transferring the filename to document title mappings.
2060 2011-06-25 Ben Konrath <ben@bagu.org>
2062 Make the authentication popup work again.
2064 This bug was introduced when I extracted ConfiguredDocument to its own class.
2066 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2067 correct success / fail status in setUsernameAndPassword().
2069 2011-06-25 Ben Konrath <ben@bagu.org>
2071 Use filename as unique key for configuring database usernames and passwords.
2073 This replaces the use of the Glom document title which could change
2074 depending on the locale. Thanks to Murray Cumming for pointing out this
2077 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2078 * src/main/resources/onlineglom.properties:
2080 2011-06-24 Ben Konrath <ben@bagu.org>
2082 Pass primary key value to DetailsView.
2084 This enables the DetailsView to load the correct data.
2086 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2087 primary key value field and set in constructor. Pass primary key
2088 value to getDetailsData().
2089 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2090 variables for document title and primary key value.
2091 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2092 key value to the DetailsPlace.
2094 2011-06-24 Ben Konrath <ben@bagu.org>
2096 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2098 This allows the primary key to be retrieved by the Details button. This
2099 functionality has not been implemented yet but it's in the works.
2101 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2102 the LayoutGroup result to ListView.setCellTable instead of all of its
2103 fields individually.
2104 * src/main/java/org/glom/web/client/ui/ListView.java:
2105 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2106 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2107 get the primary key for the table.
2108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2109 index of the primary key in the LayoutGroup accounting for hidden
2110 primary keys. Rename getJavaNumberFormat() to
2111 convertToJavaNumberFormat() for consistency. Cleanup / add some
2113 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2114 field for primary key index and a field to indicate whether the
2115 primary key is hidden or not.
2117 2011-06-23 Ben Konrath <ben@bagu.org>
2119 Rename getTableData methods to getListData.
2121 This is a rename refactor for consistency with other methods.
2123 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2124 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2125 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2128 2011-06-23 Ben Konrath <ben@bagu.org>
2130 Extract the ConfiguredDocument innerclass into its own class.
2132 This makes the servlet code more object oriented.
2134 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2135 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2137 new ConfiguredDocument class.
2139 2011-06-21 Ben Konrath <ben@bagu.org>
2141 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2143 This makes things more inline with how libglom works and reduces code
2144 duplication. This refactor lays the groundwork for adding the primary key to
2145 the LayoutGroup object.
2147 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2148 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2149 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2150 Change method names to getListLayout and getDefaultListLayout for
2151 consistency. Use LayoutGroup as the DTO for the list layout instead of
2152 ColumnInfo and LayoutListTable.
2153 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2154 new method names along with the LayoutGroup object for transferring the
2156 * src/main/java/org/glom/web/client/ui/ListView.java:
2157 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2158 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2159 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2161 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2162 Replaced with LayoutGroup.
2163 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2164 expectedResultSize and defaultTableName fields which are needed for
2166 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2167 type field which is needed for the list layout but will also be
2168 useful for the details layout as things progress.
2169 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2170 Make class abstract. Remove the unnecessary
2171 getFormattingHorizontalAlignment method. Add setFormatting method.
2173 2011-06-16 Ben Konrath <ben@bagu.org>
2175 Add scripts for building and installing war.
2177 These will help when updating OnlineGlom but they're also good
2178 supplemental documentation of the build and deployment proceeding.
2180 * utils/build-onlineglom-war.sh: New file.
2181 * utils/install-onlineglom-war.sh: New file.
2183 2011-06-16 Ben Konrath <ben@bagu.org>
2185 Create wrapper class to create consistent log messages.
2187 I wrapped methods in the Log class of gwt-log to add the method names
2188 from the servlet and create consistent formatting of the document title
2189 and table names in the log messages.
2191 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2192 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2193 log methods to use methods from wrapped Log class.
2195 2011-06-16 Ben Konrath <ben@bagu.org>
2197 Remove superfluous conditional return.
2199 Thanks to Murray Cumming for pointing this out!
2201 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2203 2011-06-15 Ben Konrath <ben@bagu.org>
2205 Return an ArrayList of LayoutGroups for the Details layout.
2207 This corrects a problem with the details layout as it can have more
2208 than one top level LayoutGroup.
2210 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2211 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2212 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2213 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2214 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2215 with ArrayList of LayoutGroups for the details view layout.
2216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2217 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2218 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2219 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2220 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2221 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2223 2011-06-14 Ben Konrath <ben@bagu.org>
2225 Use cast_dynamic method to determine the libglom LayoutItem type.
2227 This is better than finding the LayoutItem type by using the string
2228 returned from the get_part_type_name() method.
2230 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2232 2011-06-14 Ben Konrath <ben@bagu.org>
2234 Add method names to log entries in the servlet.
2236 This helps when tracking down deployment problems.
2238 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2240 2011-06-14 Ben Konrath <ben@bagu.org>
2242 Add data to the DetailsView using a hard-coded primary key value.
2244 The layout and functionality of the DetailsView is not complete. This
2245 is just a checkpoint so the patch doesn't get too big.
2247 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2248 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2249 Add getDetailsData() servlet method.
2250 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2251 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2252 LayoutFields are added to the DetailsView.
2253 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2254 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2255 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2256 take the string for the title instead of the object.
2257 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2258 Add implementation getDetailsData() along with some private helper
2260 * src/main/webapp/style.css: Add padding to details-data class. Add a
2261 details-label class with the same padding as the details-data class.
2263 2011-06-03 Ben Konrath <ben@bagu.org>
2265 Use presenter.goTo() to change to the DetailsPlace.
2267 This will make things easier when we need to open the DetailsView with
2268 data specific to the row that was clicked.
2270 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2272 2011-06-02 Ben Konrath <ben@bagu.org>
2274 Add CSS file from mockups.
2276 I'm adding this now because it's going to be useful to have when
2277 developing the DetailsView. The TableSelectionView and ListView aren't
2280 * src/main/webapp/OnlineGlom.html:
2281 * src/main/webapp/style.css:
2283 2011-06-02 Ben Konrath <ben@bagu.org>
2285 Use String.isEmpty() to check for empty string.
2287 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2289 2011-06-02 Ben Konrath <ben@bagu.org>
2291 Display main layout group titles in the DetailsView.
2293 This is the start of the DetailsActivity/DetailsView implementation.
2295 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2296 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2297 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2298 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2299 Get the layout information for the details view from the server and set
2300 the main layout group titles.
2301 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2302 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2303 Add addLayoutGroup() and addLayoutField() methods. This are just
2304 temporary methods for creating the the details view that will change
2306 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2307 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2309 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2310 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2311 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2312 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2313 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2314 Data Transfer Objects that mimic the libglom object structure. These are
2315 used for transferring the details layout but could also be used for
2316 transferring the list layout.
2318 2011-05-27 Ben Konrath <ben@bagu.org>
2320 Reset the AuthenticationPopup when clearing the ListView.
2322 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2324 2011-05-27 Ben Konrath <ben@bagu.org>
2326 Fix problem with onlineglom.properties file loading.
2328 The old way worked in Eclipse but not on the server. Loading the
2329 onlineglom.properties file now works in Eclipse and on the server.
2331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2333 2011-05-24 Ben Konrath <ben@bagu.org>
2335 Update gwt-log from 3.1.0 to 3.1.2.
2337 Gwt-log 3.1.0 has been marked as depreciated.
2341 2011-05-24 Ben Konrath <ben@bagu.org>
2343 Add comment to ListActivity.goTo() method.
2345 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2347 2011-05-24 Ben Konrath <ben@bagu.org>
2349 Remove FIXME in convertGdkColorToHtmlColour()
2351 The Gdk::Color value returned by libglom is 16-bits per channel on both
2352 64 and 32-bit platforms.
2354 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2356 2011-05-19 Ben Konrath <ben@bagu.org>
2358 Improve performance of initial ListView load.
2360 I removed a round trip to the server for getting the default table name
2361 and then requesting information about that table. This also removes a potential
2362 problem with the table change handler not being setup in time to receive the
2363 table change event from the ListActivity.
2365 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2366 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2367 getDefaultLayoutListTable() method. Improve comments.
2368 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2369 getDefaultLayoutListTable() method instead of firing a table change
2370 event to get the table to load.
2371 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2372 implementation of getDefaultLayoutListTable() method.
2373 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2376 2011-05-19 Ben Konrath <ben@bagu.org>
2378 Override toDebugString() in TableChangeEvent.
2380 This is useful to have for debugging.
2382 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2384 2011-05-19 Ben Konrath <ben@bagu.org>
2386 Add a "Back to List" link when at the DetailsPlace.
2388 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2389 Populate the CellTable based on the selected table of the ListBox if
2390 it's set otherwise use the default table. This allows the "Back to
2392 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2393 Remove Place from constructors. Add a setPlace() method. Add
2394 goToPlace() method. Set class as presenter for TableSelectionView.
2395 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2396 Use the same TableSelectionActivity when switching between the List and
2398 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2399 Subclass the new HasSelectableTablePlace. This removes some duplicate
2401 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2402 New class to represent Places that display the TableSelectionView.
2403 * src/main/java/org/glom/web/client/place/ListPlace.java:
2404 Subclass the new HasSelectableTablePlace. This removes some duplicate
2406 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2407 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2408 Add Presenter interface. Add setBackLinkVisible() method. Add
2409 setBackLink() method.
2411 2011-05-18 Ben Konrath <ben@bagu.org>
2413 Enable the "Details" buttons.
2415 Right now only an empty details view is displayed.
2417 * src/main/java/org/glom/web/client/ClientFactory.java:
2418 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2419 Add DetailsView to ClientFactory.
2420 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2421 A basic activity for the details view.
2422 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2423 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2425 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2426 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2428 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2429 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2430 unnecessary super() in constructor.
2431 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2432 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2433 really shouldn't create a new TableSelectionActivity for both the ListPlace
2434 and the DetailsPlace so this should be considered a temporary solution.
2435 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2436 New file. Represents a URL for the details view.
2437 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2438 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2439 A basic details view interface and implementation.
2440 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2441 Enable the "Details" buttons.
2443 2011-05-12 Ben Konrath <ben@bagu.org>
2445 Use a LayoutPanel with multiple display areas for main layout.
2447 This is mostly a refactor in that there are no changes from the user
2448 point of view. These changes are required so that we can swap out the list view
2449 with the details view when the user clicks the "Details" button.
2451 * src/main/java/org/glom/web/client/ClientFactory.java:
2452 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2453 OnlineGlomView. Add TableSelectionView, ListView and
2454 AuthenticationPopup.
2455 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2456 for main layout. Add display regions for main activities. Add
2457 activity manager for for main activities.
2458 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2459 file from parts of the deleted OnlineGlomActivity.
2460 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2461 New file from parts of the deleted OnlineGlomActivity.
2462 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2463 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2464 New files for app wide table change event.
2465 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2466 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2467 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2468 Activity mappers for the main activities replace the deleted app-wide
2470 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2471 Fix a spelling error in he comment.
2472 * src/main/java/org/glom/web/client/ui/ListView.java:
2473 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2474 Renamed from LayoutListView and modified for MVP. This still not a
2475 proper dumb view as prescribed by the MVP pattern but it works for now.
2476 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2477 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2478 New widget stripped out of the deleted OnlineGlomView.
2479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2480 Remove hack that is fixed by this patch.
2482 2011-05-06 Ben Konrath <ben@bagu.org>
2484 Rename OnlineGlomPlace to ListPlace.
2486 The only change besides the rename is that url will now display #list
2487 instead of #Document.
2489 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2490 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2491 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2492 * src/main/java/org/glom/web/client/place/ListPlace.java:
2493 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2495 2011-05-06 Ben Konrath <ben@bagu.org>
2497 Use Presenter for app navigation.
2499 This is the proper way to deal with Place (URL) changes with the MVP
2502 * src/main/java/org/glom/web/client/ClientFactory.java:
2503 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2504 PlaceHistoryMapper and PlaceHistoryHandler.
2505 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2506 PlaceHistoryMapper and PlaceHistoryHandler.
2507 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2508 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2509 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2510 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2511 Add Presenter interface and setPresenter methods. Rename addHyperLink
2512 to addDocumentLink taking only the document title as a parameter.
2514 2011-04-14 Ben Konrath <ben@bagu.org>
2516 Prompt for db username/password if they haven't been set.
2518 This is implemented with a popup widget that is contained within the
2519 OnlineGlomView and managed by the OnlineGlomActivity.
2521 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2522 methods for checking and setting the database username and password.
2523 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2524 new methods for checking and setting the database username and
2526 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2527 Display authentication popup if the JDBC connection to the database
2528 has not been authenticated.
2529 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2531 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2532 for dealing with the authentication popup.
2533 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2534 Implement the methods for dealing with the authentication popup.
2535 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2536 try to executed queries if the database connection hasn't been
2537 authenticated. Implement methods for checking and setting the
2538 database username and password.
2540 2011-04-12 Ben Konrath <ben@bagu.org>
2542 Make log messages a little clearer.
2544 Add a dash betweeen the document title and the table name.
2546 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2548 2011-04-12 Ben Konrath <ben@bagu.org>
2550 Protect against NPEs when cleaning up database resources.
2552 While this isn't strictly necessary because the exception is caught,
2553 not protecting against the NPEs makes it harder to find the real error
2556 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2558 2011-04-12 Ben Konrath <ben@bagu.org>
2560 Move configuration of the servlet to the constructor.
2562 The servlet will be initialized even if the database authentication
2563 information is not set or correct. I still need to add the UI for prompting
2564 the user for the authentication information when it's required.
2566 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2567 javadocs for getDocumentTitles() method.
2568 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2569 Set error message when RPC fails.
2570 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2571 glom files directory from the configuration file. Try to set the
2572 database authentication information for the specific document if it's
2573 set and works otherwise try to use the global authentication
2574 information set for the directory.
2575 * src/main/resources/onlineglom.properties: Moved from
2576 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2577 Added detailed comments for the new keys.
2579 2011-04-11 Ben Konrath <ben@bagu.org>
2581 Remove unnecessary @Override in DocumentSelectionViewImpl.
2583 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2585 2011-04-11 Ben Konrath <ben@bagu.org>
2587 Remove center alignment in DocumentSelectionView.
2589 The title element is still centred but the document titles and bottom
2590 sentence are both left-aligned.
2592 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2594 2011-04-11 Ben Konrath <ben@bagu.org>
2596 Change 'Demo' naming convention to 'Document'.
2598 This is just a rename refactor with no functional changes to the code.
2600 * src/main/java/org/glom/web/client/ClientFactory.java:
2601 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2602 * src/main/java/org/glom/web/client/OnlineGlom.java:
2603 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2604 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2605 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2606 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2607 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2608 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2609 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2610 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2611 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2612 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2614 2011-04-08 Ben Konrath <ben@bagu.org>
2616 Remove FIXME from safeLongToInt() method.
2618 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2621 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2623 2011-04-08 Ben Konrath <ben@bagu.org>
2625 Display an error if no glom documents are found in the specified directory.
2627 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2628 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2629 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2630 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2632 2011-04-08 Ben Konrath <ben@bagu.org>
2634 Add copyright header to one more file ... oops.
2636 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2638 2011-04-08 Ben Konrath <ben@bagu.org>
2640 Add copyright header to files without it.
2642 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2643 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2644 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2645 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2646 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2647 * src/main/java/org/glom/web/shared/GlomField.java:
2649 2011-04-08 Ben Konrath <ben@bagu.org>
2651 Add support for accessing multiple glom documents in the servlet.
2653 This completes the demo selection functionality.
2655 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2656 document title to methods.
2657 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2658 document title to methods.
2659 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2660 Set browser window title when the activity starts. Correct name of
2661 document title variable.
2662 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2663 Set browser window title when the activity starts. Set the table
2664 selector change handler after table selector has been set. Clear the
2665 OnlineGlomView when the activity has been stopped.
2666 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2667 document title as the place token. Use "#Document:" instead of
2668 "#OnlineGlomPlace:" in the URL.
2669 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2670 Change heading to "Online Glom"
2671 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2672 document title in RPC methods.
2673 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2674 setDocumentTitle() method. Add clear() method.
2675 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2676 setDocumentTitle() method. Implement clear() method which removes the
2677 change handler on the ListBox, clears the ListBox and clears the
2679 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2680 Implement methods with document title. Keep track for the configured
2681 glom documents and their corresponding JDBC configurations in a hash
2682 table. This information is retrieved using the document title as the
2683 key in the hash table.
2684 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2685 document title field as it's no longer needed.
2687 2011-04-08 Ben Konrath <ben@bagu.org>
2689 Update the Eclipse JDT configuration.
2691 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2692 methods. Automatically add the copyright header to new files.
2694 2011-04-05 Ben Konrath <ben@bagu.org>
2696 Add new page for demo selection.
2698 This patch adds all the components required to view and start an
2699 OnlineGlom demo by clicking on the desired hyperlink. The user is
2700 able to return to the demo selection page with the browser's back
2701 button. I still need to modify the servlet to work with multiple
2702 documents so all demo links will load the file defined in the
2703 OnlineGlom.properties.
2705 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2706 This is only useful during development so we don't need to save it.
2707 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2708 get a reference to the DemoSelectionView.
2709 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2710 method to get a reference to the DemoSelectionView.
2711 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2712 default view to DemoSelectionView.
2713 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2714 to get glom document titles for glom files in a hard-coded directory.
2715 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2716 method to get glom document titles for glom files in a hard-coded
2718 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2719 Presenter for DemoSelectionView.
2720 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2721 for DemoSelectionView.
2722 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2723 Update for DemoSelectionView.
2724 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2725 Basic 'Place' implementation for the DemoSelectionView.
2726 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2727 The interface for the DemoSelectionView.
2728 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2729 The implementation of the DemoSelectionView.
2730 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2731 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2732 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2733 implementation of method to get glom document titles for glom files
2734 in a hard-coded directory.
2735 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2736 on longer being used.
2737 * src/main/webapp/glom.png: Glom logo.
2739 2011-04-05 Ben Konrath <ben@bagu.org>
2741 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2743 This is the forth and final commit of a refactor that will allow
2744 OnlineGlom to be used with multiple documents.
2746 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2747 Move RPC code from OnlineGlomViewImpl to this class.
2748 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2750 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2751 RPC code to the presenter class (the P in MVP).
2753 2011-04-04 Ben Konrath <ben@bagu.org>
2755 Start moving the existing OnlineGlom code to MVP.
2757 This work is based on the GWT MVP framework that is documented here:
2759 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2761 This is the third commit of a refactor that will allow OnlineGlom to
2762 be used with multiple documents.
2764 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2765 Interface for client factory which is used to get instances of various
2766 classes throughout the app.
2767 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2768 Implementation of client factory.
2769 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2770 initialize the MVP framework.
2771 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2772 New file. Activity manager for the main container widget. This is the
2774 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2775 Maps place (URL) to its corresponding activity.
2776 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2777 New file. This is just a place holder for a generated file.
2778 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2779 New file. Represents the URL for the main Online Glom app.
2780 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2781 for changes in LayoutListViewImpl.
2782 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2783 interface for View. Move code to OnlineGlomViewImpl class.
2784 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2785 file. Implementation of OnlineGlomView.
2786 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2787 Place resources. Use ClientFactoryImpl by default.
2789 2011-04-04 Ben Konrath <ben@bagu.org>
2791 Move View classes to their own package.
2793 This is the second commit of a refactor that will allow OnlineGlom to
2794 be used with multiple documents.
2796 * src/main/java/org/glom/web/client/OnlineGlom.java:
2797 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2798 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2800 2011-04-02 Ben Konrath <ben@bagu.org>
2802 Move UI code from the main module to its own class.
2804 This is the first commit of a refactor that will allow OnlineGlom to be
2805 used with multiple documents.
2807 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2808 references to OnlineGlom to OnlineGlomView.
2809 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2810 OnlineGlomView and instantiate it here.
2811 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2812 represents the main OnlineGlomView with one document.
2814 2011-04-01 Ben Konrath <ben@bagu.org>
2816 Fix formatting of gwt.xml and add DTD.
2818 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2820 2011-03-30 Ben Konrath <ben@bagu.org>
2822 Propperly convert gdkColor string to html colour string.
2824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2826 2011-03-28 Ben Konrath <ben@bagu.org>
2828 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2830 This implementation matches
2831 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2832 readable and is not tied to Swig.
2834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2836 2011-03-28 Ben Konrath <ben@bagu.org>
2838 Use read-only checkboxes for boolean field types.
2840 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2841 in the CellTable based on the field type. It currently only
2842 distinguishes between boolean and text columns but I'll need to add
2843 support for more types.
2844 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2845 column type in the ColumnInfo object. Add method to convert between the
2846 glom field type enum in ColumnInfo and the glom field type in libglom.
2847 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2849 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2850 getting and setting booleans.
2852 2011-03-25 Ben Konrath <ben@bagu.org>
2854 Don't get the Date twice from the ResultSet.
2856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2858 2011-03-25 Ben Konrath <ben@bagu.org>
2860 Cleanup code in the servlet.
2862 * TODO: Remove item about row count. Add item about testing row count
2863 query with large number of rows.
2864 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2865 spelling mistakes, change method parameter to be consistent with
2868 2011-03-25 Ben Konrath <ben@bagu.org>
2870 Add server side logging with the gwt-log library.
2872 * .gitignore: Ignore the log file we're now producing.
2873 * TODO: Add a couple TODO item for logging.
2874 * pom.xml: Add gwt-log and log4j as a dependency.
2875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2876 logging of errors, warnings and some important info.
2877 * src/main/resources/log4j.properties: New file to configure log4j.
2879 2011-03-24 Ben Konrath <ben@bagu.org>
2881 Add a disable button for the Details view.
2883 * src/main/java/org/glom/web/client/LayoutListView.java:
2885 2011-03-22 Ben Konrath <ben@bagu.org>
2887 Use a count query to get the number of rows for the list view pager.
2889 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2891 2011-03-22 Ben Konrath <ben@bagu.org>
2893 Add more TODO information about CellTable pager positioning.
2897 2011-03-19 Ben Konrath <ben@bagu.org>
2899 Add TODO item about CellTable pager positioning.
2903 2011-03-18 Ben Konrath <ben@bagu.org>
2905 Remove unneeded GlomFieldColumn class.
2907 This is just a small code cleanup.
2909 * src/main/java/org/glom/web/client/LayoutListView.java:
2911 2011-03-18 Ben Konrath <ben@bagu.org>
2913 Use cursor mode in the query that gets data for the list view.
2915 I still need to fix the potential memory problem when getting the row
2916 count for the list view.
2918 * TODO: Add note about testing memory usage with large data sets. Add
2919 item about fixing row counting with large data sets.
2920 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2921 PostgreSQL JDBC driver into cursor mode when getting data for the
2924 2011-03-15 Ben Konrath <ben@bagu.org>
2926 Remove the GWT Container from the Eclipse build classpath.
2928 The GWT dependencies are set by Maven so this isn't needed.
2932 2011-03-15 Murray Cumming <murrayc@murrayc.com>
2934 Added some earlier mockups to git, but not to the tarball dist.
2936 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
2937 Openismus. These hopefully show how we might structure the HTML so that
2938 it can be styled easily with CSS. However, we probably need to adapt them
2939 for the CSS structure that GWT dictates for common widgets.
2941 2011-03-14 Ben Konrath <ben@bagu.org>
2943 Locate OnlineGlom.properties using the ServletContext.
2945 This is required to be able to locate the file in the deployed servlet.
2947 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2948 Configure the database and glom document in in a helper method so
2949 that the ServletContext can be used to locate OnlineGlom.properties.
2950 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
2951 src/main/webapp. This is the proper location for .properites files.
2953 2011-03-12 Ben Konrath <ben@bagu.org>
2955 Add note to README about why we're compiling down to obfuscated JavaScript.
2959 2011-03-11 Ben Konrath <ben@bagu.org>
2961 Use properties file to configure servlet.
2963 This allows people to change the glom file path, db username and db
2964 password without recompiling the code.
2966 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2967 * src/main/webapp/OnlineGlom.properties:
2969 2011-03-11 Ben Konrath <ben@bagu.org>
2971 Use table fields in layout list view if the layout list is not defined.
2973 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2974 Manually create a LayoutFieldVector for the query builder using the
2975 table fields when a layout list is not defined in the glom file.
2977 2011-03-11 Ben Konrath <ben@bagu.org>
2979 Only show FIXME string for images when there's an image.
2981 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
2982 in this change are some small code cleanups.
2984 2011-03-11 Ben Konrath <ben@bagu.org>
2986 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
2988 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2990 2011-03-11 Ben Konrath <ben@bagu.org>
2992 Correctly set the index of the default table.
2994 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2995 Correctly set the index of the default table. Add commented out example
2998 2011-03-10 Ben Konrath <ben@bagu.org>
3000 Add comment to pom.xml about the previous change.
3002 * pom.xml: Add comment about the deployment issue so that it's obvious
3003 why java-libglom is set to the provided scope.
3005 2011-03-10 Ben Konrath <ben@bagu.org>
3007 Change java-libglom dependency from compile to provided in pom.xml.
3009 Since java-libglom uses jni it can only be loaded once and therefore
3010 must be placed in $CATALINA_HOME/lib and not included in each war.
3011 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
3012 More information about this issue can be found in the Tomcat 6 release
3013 notes in the "JNI Based Applications" section:
3015 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
3017 * README: Remove note about this issue. Deployment info should really
3018 be on the wiki anyway so I'll add it right now.
3019 * pom.xml: Change java-libglom dependency from compile to provided so
3020 that it's copied in to the packaged war.
3022 2011-03-09 Ben Konrath <ben@bagu.org>
3024 Change to using a neutral locale for currency, date and time formatting.
3026 This solves the problem of currency values being represented without a
3027 space between the currency code and the number (e.g. "EUR5.89" is now
3028 represented as "EUR 5.89"). More work is required when we implement
3029 a locale preference setting.
3031 * TODO: Add note about currency formatting issues with different
3033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3034 to using the neutral ROOT locale.
3036 2011-03-09 Ben Konrath <ben@bagu.org>
3038 Add support for currency codes that are not ISO 4217 codes.
3040 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3041 the currency code defined in the glom file when it's not 3 characters
3042 long or when Java doesn't recognize the string as an ISO 4217 code.
3044 2011-03-08 Ben Konrath <ben@bagu.org>
3046 Remove test classes, launch configurations and configuration.
3048 The test stuff was getting in the way when creating the war. To make
3049 the war file you can now do 'mvn clean package'. The packaged war file
3050 will be in the target directory.
3052 * .classpath: Remove unused classpathentry for tests and i18n.
3053 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
3054 property. Don't run test or i18n goals when packaging the war.
3055 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
3060 * OnlineGlomTest-dev.launch:
3061 * OnlineGlomTest-prod.launch:
3062 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
3063 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
3065 2011-03-07 Ben Konrath <ben@bagu.org>
3067 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
3069 These fixes allow me to use 'mvn deploy' to create the war file.
3071 * .classpath: This generated config has been updated by Eclipse. This
3072 change was probably triggered by me updating from Eclipse 3.6.1 to
3074 * .gitignore: Add entry to ignore the directory
3075 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
3076 * .project: The generated config has been updated by Eclipse. This
3077 change was probably triggered by me updating from Eclipse 3.6.1 to
3079 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3080 so that Eclipse doesn't complain
3081 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3082 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3083 'tests' directory to 'client' directory. This is the new
3084 gwt-maven-plugin convension.
3085 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3086 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3088 2011-03-07 Ben Konrath <ben@bagu.org>
3090 Add support for horizontal alignment in the LayoutList columns.
3092 * TODO: Remove item about horizontal alignment. Add item about
3093 improvements to ColumnInfo.
3094 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3095 alignment on the columns. Use ColumnInfo RPC object get the column
3096 title and horizontal alignment.
3097 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3098 LayoutListView creation with ColumnInfo RPC object.
3099 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3100 a ColumnInfo object for every LayoutList columnn. Convert the
3101 FieldFormatting.HorizontalAlignment to the correct
3102 ColumnnInfo.HorizontatlAlignment with the new
3103 getColumnInfoHorizontalAlignment helper method.
3104 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3105 to encapsulate column information like alignment and title. This
3106 could be used to set the colour instead of on a per cell field basis.
3107 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3108 column title storage and retrieval with ColumnInfo.
3110 2011-03-04 Ben Konrath <ben@bagu.org>
3112 Add support for column sorting.
3114 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3115 AsynDataProvider to be an anonymous inner class. Use new
3116 getSortedTableData RPC method when column sort is requested. Set all
3117 columns sortable and add an AsyncHandler to activate sorting in the
3119 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3120 method getSortedTableData(). Cleanup other method signatures.
3121 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3122 new method getSortedTableData(). Cleanup other method signatures.
3123 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3124 Implement getSortedTableData() and getTableData() methods by using a
3125 private helper method with the appropriate parameters filled in. Use
3126 user supplied sort clause when supplied, otherwise fall back to
3127 sorting by the primary key. Move destroy() method to be underneath
3128 constructor for readability. Cleanup comments.
3130 2011-03-03 Ben Konrath <ben@bagu.org>
3132 Add support for colour text and colour backgrounds to the layout list cells.
3134 Only the cell backgrounds are coloured which leaves a gap between the
3135 cells that isn't coloured. I need to figure out a way to set
3136 'style=background-colour:' on the whole column rather than just the
3139 * TODO: Add a note about colouring the background of the whole column.
3140 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3141 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3142 render the coloured text and backgrounds. Use GlomField[] for the row type.
3143 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3145 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3146 GlomField[] for the row type.
3147 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3148 GlomField[] for the row type. Set the text, text colour and background
3149 colour in the GlomField objects as specified in the glom document. Add
3150 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3151 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3152 the glom field text, foreground colour and background colour.
3154 2011-03-02 Ben Konrath <ben@bagu.org>
3156 Don't display hidden tables in the combo box.
3158 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3160 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3161 code to ignore hidden tables using ArrayLists for the table names and
3163 * src/main/java/org/glom/web/shared/GlomDocument.java: Change tableTitles and
3164 tableNames to use ArrayLists instead of String[]. Update getter and setter
3167 2011-03-01 Ben Konrath <ben@bagu.org>
3169 Add support for Date and Time number types.
3171 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3172 Implement formatting for Date and Time values. Change the default glom
3173 file to small business example.
3175 2011-03-01 Ben Konrath <ben@bagu.org>
3177 Add support for formatting glom types as specified in the glom file.
3179 Formatting isn't finished yet - I still need to add support for Date
3182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3183 formatting support for TYPE_TEXT, TYPE_BOOLEAN and TYPE_NUMERIC. Remove
3184 checks for null values in JDBC cleanup code and catch all exceptions
3185 instead of just SQLExceptions.
3186 * src/main/java/org/glom/web/shared/LayoutListTable.java: Fix incorrect
3189 2011-03-01 Ben Konrath <ben@bagu.org>
3191 Use GWT 2.2.0 instead of 2.1.1.
3193 * pom.xml: Change GWT version numbers.
3195 2011-03-01 Ben Konrath <ben@bagu.org>
3197 A few small code cleanups.
3199 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Remove
3201 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3202 unnecessary object creation in constructor.
3203 * src/main/java/org/glom/web/shared/LayoutListTable.java: Remove
3204 unnecessary object creation in constructor.
3206 2011-02-28 Ben Konrath <ben@bagu.org>
3208 Add file for TODO list.
3212 2011-02-18 Ben Konrath <ben@bagu.org>
3214 Enable the CellTable Pager when more than 20 rows need to be viewed.
3216 The Pager will automatically become active when the results are larger
3217 than the CellTable size which is currently set to 20 lines.
3219 * src/main/java/org/glom/web/client/LayoutListView.java: Correct class
3220 name on debug statment in RPC call in LayoutListDataProvider, add
3221 numRows parameter to LayoutListView constructor, propperly set rowCount
3223 * src/main/java/org/glom/web/client/OnlineGlom.java: Correct class
3224 name on debug statment in RPC call, use LayoutListTable object in RPC
3225 calls, pass rowCount to LayoutListView.
3226 * src/main/java/org/glom/web/client/OnlineGlomService.java: Change
3227 getLayoutListHeaders to getLayoutListTable and return LayoutListTable
3229 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Update
3230 interface for changes in OnlineGlomService.
3231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3232 getLayoutListHeaders() to getLayoutListTable() and return
3233 LayoutListTable. Using this object allows me to pass other information
3234 about the LayoutList like the expected number