1 2012-01-12 Murray Cumming <murrayc@murrayc.com>
3 Many files: Use final for the parameters and use the @override attribute.
5 2012-01-22 Ben Konrath <ben@bagu.org>
7 Add anchor links for single line text that starts with http, ftp and www.
11 2012-01-22 Ben Konrath <ben@bagu.org>
13 Add ellipsis to single line text in details view.
17 2012-01-04 Murray Cumming <murrayc@murrayc.com>
19 Remove all javadoc author tags.
21 Because they are awkward and meaningless when many people touch
23 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
25 2012-01-04 Murray Cumming <murrayc@murrayc.com>
27 Revert the COPYING.LESSER to COPYING rename.
29 Apparently both should be there if it is LGPL.
31 2012-01-03 Murray Cumming <murrayc@murrayc.com>
33 *View: Remove unused imports.
35 * src/main/java/org/glom/web/client/ui/DetailsView.java:
36 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
37 * src/main/java/org/glom/web/client/ui/ListView.java:
38 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
39 Remove unused imports, as suggested by Eclipse.
41 2012-01-02 Murray Cumming <murrayc@murrayc.com>
43 Move the *View::Presenter types, and some API into one base View.
45 * src/main/java/org/glom/web/client/ui/DetailsView.java:
46 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
47 * src/main/java/org/glom/web/client/ui/ListView.java:
48 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
49 Presenter, setPresenter() and clear() into a shared base interface,
50 to avoid the unnecessary duplicate Presenter types and to more clearly
51 show how the *Views share the same structure, even if they are not
54 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
55 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
57 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
58 * src/main/java/org/glom/web/client/activity/ListActivity.java:
59 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
61 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
64 Feel free to revert this if there is a good reason for the duplicate
67 2012-01-02 Murray Cumming <murrayc@murrayc.com>
69 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
71 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
72 a class member instead of a local variable in the method.
73 This lets us use it to get the view instances, for use in tests.
74 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
75 beforeOnlineGlom(): Test some more details of the initial view.
76 Again, this is not very useful.
78 To really test gwt-glom we will need to start a local postgresql
79 instance with local data, like the Glom tests in C++.
81 2012-01-02 Murray Cumming <murrayc@murrayc.com>
83 pom.xml: Mention the LGPL license.
85 * pom.xml: Add a licenses section.
86 * COPYING.LESSER: Move this to COPYING, which
87 previously contained the GPL. But gwt-glom is all LGPL.
89 2012-01-02 Murray Cumming <murrayc@murrayc.com>
91 Add project information to README and pom.xml.
93 * README: Add a brief description and mention some mvn
95 * pom.xml: This extra information shows up in mvn site
98 2011-01-02 Murray Cumming <murrayc@murrayc.com>
100 Use the latest java-libglom version.
102 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
104 2012-01-01 Murray Cumming <murrayc@murrayc.com>
106 GwtTestOnlineGlom: Test a little more.
108 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
109 protected rather than private, as suggested by the gwt-test-utils
111 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
112 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
113 Test the initial visibility of the panels.
115 However, this is not a very useful test.
116 And I wonder how we should generally test using this idea for an
117 activity/places app like ours where the real changes happen implicitly
118 based on the history token/URL.
120 2012-01-01 Murray Cumming <murrayc@murrayc.com>
122 Slight modification to *Mapper comments.
124 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
126 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
128 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
130 Remove comments mentioning GIN because they are just copied from
131 the example code and are apparently not helpful:
132 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
133 Also change the mention of a class that is only in the example code.
135 2012-01-01 Murray Cumming <murrayc@murrayc.com>
137 GwtTestOnlineGlom test: Minor changes.
139 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
140 Avoid the long qualified class name and modify the comment
141 because it is now obvious to me that the mocked class is the only
142 custom one created via GWT.create().
144 2012-01-01 Murray Cumming <murrayc@murrayc.com>
146 Tests: Added the beginnings of a test using gwt-test-utils.
148 * pom.xml: Add dependencies on gwt-test-utils and easymock.
149 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
150 which tells gwt-test-utils what class will be tested.
151 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
152 Add a simple (but empty) test case. One class, used by the OnlineGlom
153 class, is mocked so that it can be created. However, I am not sure
154 why only this class needs to be mocked.
156 Note that mockito seems more popular, and clearer, than easymock,
157 but I have not got that working yet. It might be a matter of the
160 This test is run during mvn integration-test.
162 2011-12-31 Murray Cumming <murrayc@murrayc.com>
164 Tests: Use junit4-style syntax instead of junit3-style.
166 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
167 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
168 * src/test/java/org/glom/web/shared/DataItemTest.java:
169 Use the @Test annotation rather than relying on the test*() prefix.
170 Also no longer implement TestCase, to avoid triggering support for
171 the junit3-way, which stops the annotations from working.
172 Change the imports from import junit.framework.* to
173 import org.junit.*, which is apparently the new way.
175 2011-12-31 Murray Cumming <murrayc@murrayc.com>
177 Added a test for ListPlace token parsing and creation.
179 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
180 This is much the same as DetailsPlaceTest.
182 I wonder how we could test the other parts of the *Place API.
184 2011-12-30 Murray Cumming <murrayc@murrayc.com>
186 DetailsPlace test: Also test getToken() and recreation via getPlace().
188 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
189 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
190 recreate it, testing the recreated DetailsPlace for the same parameter
193 2011-12-30 Murray Cumming <murrayc@murrayc.com>
195 Use the surefire-report plugin.
197 * pom.xml: This generates a HTML report about the tests in
198 target/site/surefire-report.html
199 when you do mvn surefire-report:report. It seems to be popular/normal.
201 2011-12-30 Murray Cumming <murrayc@murrayc.com>
203 Added a test for DetailsPlace.
205 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
206 Test the getPlace() token parsing.
208 2011-12-30 Murray Cumming <murrayc@murrayc.com>
210 Added a first unit test.
212 * pom.xml: Add a test goal, and a dependency on junit in that scope.
213 * src/test/java/org/glom/web/shared/DataItemTest.java:
214 This is a silly test but it is just to get things started. Note that
215 maven/junit finds the test because it looks in src/test by default.
217 2011-12-22 Ben Konrath <ben@bagu.org>
219 Change charsetName to "UTF-8" when replacing line breaks.
221 JavaScript requires the charsetName to be "UTF-8". CharsetName values
222 that work in Java (such as "UTF8") will not work when compiled to
225 This fixes a problem with multi-line details view fields that have hard
226 line breaks. The "License Text" field on this page demonstrates the
229 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
231 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
233 2011-12-22 Ben Konrath <ben@bagu.org>
235 Fix another bug with related list navigation.
237 I've tested all the navigation buttons in all of the related lists
238 so things should be good now.
240 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
242 2011-12-22 Ben Konrath <ben@bagu.org>
244 Fix a crasher when refreshing the list view with the default table.
246 This crash will also happen when loading the list view with the default
247 table from a link or bookmark.
249 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
250 to the main document selection page when the document id hasn't been
252 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
253 the main document selection page when the document id hasn't been
255 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
256 values for the details place when the document id hasn't been set.
257 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
258 values for the list place when the document id hasn't been set.
260 2011-12-21 Ben Konrath <ben@bagu.org>
262 Protect against NPE when glom.document.locale is not in config.
264 This patch protects against an NPE when glom.document.locale is not in
265 the config file. This NPE will also happen if glom.document.locale is
268 The patch also updates the error message to display the class name when
269 the getMessage() returns null. This was happening when the NPE was
270 thrown and I had "Configuration Error: null". If an NPE is encountered
271 with this patch, "Configuration Error: NullPointerException " will be
274 This commit closes this bug:
276 https://bugzilla.gnome.org/show_bug.cgi?id=666669
278 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
280 2011-12-20 Murray Cumming <murrayc@murrayc.com>
282 Rename onlineglom.properties to onlineglom.properties.sample.
284 * src/main/resources/onlineglom.properties: Rename to:
285 * src/main/resources/onlineglom.properties.sample:
286 * src/main/resources/README: And add this file explaining that people
287 should rename it back when deploying.
289 2011-12-20 Murray Cumming <murrayc@murrayc.com>
291 Allow choosing the translation in the .properties file.
293 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
294 init(): Read a glom.document.locale value from the configuration file
295 and call Glom's TransatableItem::set_current_locale() method.
296 * src/main/resources/onlineglom.properties: Add a commented-out
297 example of this new setting.
299 It would be better to add &lang=de_DE to the URL, but the current
300 libglom API does not allow us to do this easily. I am working on that.
302 2011-12-19 Murray Cumming <murrayc@murrayc.com>
304 Avoid a crash in parsing of token parameters.
306 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
307 ava: getTokenParams(): Do not crash if a parameter has a key but no
308 value, and ignore parameters with neither.
310 2011-12-17 Murray Cumming <murrayc@murayc.com>
312 History token building/handling: Improve use of token parameters.
314 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
315 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
316 and buildParamsToken(HashMap), for use by derived classes.
317 Make the separator private because it is no longer be needed.
318 * src/main/java/org/glom/web/client/place/DetailsPlace.java
319 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
320 instead of manual string concatenation.
321 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
322 of hardcoded indices and awkward splitting code.
323 * src/main/java/org/glom/web/client/place/ListPlace.java
324 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
325 instead of manual string concatenation.
326 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
327 of hardcoded indices and awkward splitting code.
328 This should fix bug #666420
330 2011-12-16 Murray Cumming <murrayc@murrayc.com>
332 Fix a Navgiation->Navigation typo in the code.
334 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
335 Rename processNavgiation() to processNavigation().
337 2011-12-16 Murray Cumming <murrayc@murrayc.com>
339 Fix a seperator->separator typo in the code.
341 * src/main/java/org/glom/web/client/place/DetailsPlace.java
342 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
343 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
346 2011-12-15 Ben Konrath <ben@bagu.org>
348 Cleanup some comments.
350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
352 2011-12-14 Ben Konrath <ben@bagu.org>
354 Replace \n with <br/> for multiline text in the details view.
356 Vertical scrollbars are added when needed as well.
358 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
360 2011-12-14 Ben Konrath <ben@bagu.org>
362 Specify the font for document selection links.
364 * src/main/webapp/style.css:
366 2011-12-14 Ben Konrath <ben@bagu.org>
368 Fix bouncy CellTable while paging.
370 This doesn't currently work with related list tables in unselected
373 * src/main/java/org/glom/web/client/ui/list/ListTable.java
375 2011-12-14 Ben Konrath <ben@bagu.org>
377 Revamp the appearance of the document selection page.
379 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
380 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
381 * src/main/webapp/style.css:
383 2011-12-13 Ben Konrath <ben@bagu.org>
385 Set navigation button column to the smallest size possible.
387 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
389 2011-12-13 Ben Konrath <ben@bagu.org>
391 Change OpenButton nomenclature to NavigationButton.
393 Using NavigtionButton makes things more generic. Classes, methods and
394 variables have been changed.
396 This is a rename-only refactor.
398 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
399 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
400 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
401 Renamed from OpenButtonCell.
402 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
403 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
404 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
406 2011-12-12 Ben Konrath <ben@bagu.org>
408 Remove unnecessary String argument in RelatedListTable and ListViewTable.
410 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
411 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
412 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
413 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
415 2011-12-12 Ben Konrath <ben@bagu.org>
417 Update variable names and comments.
419 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
420 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
422 2011-12-12 Ben Konrath <ben@bagu.org>
424 Properly initialize numNonEmptyRows variable to zero.
426 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
427 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
429 2011-12-05 Ben Konrath <ben@bagu.org>
431 Add latest mockup with HTML tables.
433 Features of this mockup:
435 -> HTML table for flowtable
436 -> HTML table for flowtable column
437 -> Example of how related lists would look
438 -> Not using text entries for data items
440 The current version of Online Glom doesn't use HTML tables for the
443 This mockup has been sent to the glom-devel mailing list but it's good
444 to have it here as well.
446 * mockups/details-view-html-tables.html:
448 2011-12-05 Ben Konrath <ben@bagu.org>
450 Remove unnecessary getPrimaryKeyField() method.
452 getPrimaryKeyFieldForTable(String) has been renamed to
453 getPrimaryKeyField(String).
455 * src/main/java/org/glom/web/server/database/DBAccess.java:
456 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
457 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
459 2011-12-05 Ben Konrath <ben@bagu.org>
461 Add string representation of TypedDataItem value to conversion error message.
463 * src/main/java/org/glom/web/server/Utils.java: Logging the error
464 message was extracted into its own method to avoid duplication.
466 2011-12-05 Ben Konrath <ben@bagu.org>
468 Add type checking to navigation primary key value creation.
470 Create navigation primary key only if the expected type from the Glom
471 document matches the type returned by the SQL query.
473 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
475 2011-12-05 Ben Konrath <ben@bagu.org>
477 Rename a couple of variables in RelatedListNavigation.
479 This is a rename-only refactor.
481 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
483 2011-12-05 Ben Konrath <ben@bagu.org>
485 Move getListLayoutGroup() into getListViewLayoutGroup().
487 This removes getListLayoutGroup(). It was only being called by
488 getListViewLayoutGroup().
490 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
492 2011-12-05 Ben Konrath <ben@bagu.org>
494 Remove check for LayoutItem_Portal in list table method.
496 This check is no longer necessary because the method isn't being used
497 to create the LayoutItemPortal DTO.
499 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
501 2011-12-05 Ben Konrath <ben@bagu.org>
503 Properly support related list navigation.
505 Navigation from the "Repository Analyzer -> Package Scans ->
506 Dependencies" related table wasn't working because the primary key for
507 related tables wasn't being set properly. This commit fixes the
510 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
511 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
512 doesn't set the primary key properly for related list tables.
513 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
514 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
515 useful for getting the primary key for list view tables and for related
517 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
518 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
519 Move code to set the primary key for the table from the abstract
520 ListDBAccess class to ListViewDBAccess as it's only correct for list
522 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
523 Properly add primary key to related list tables.
525 2011-12-02 Ben Konrath <ben@bagu.org>
527 Properly set the horizontal alignment of fields.
529 This fix is for both the list tables and the details view.
531 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
532 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
533 to set the horizontal alignment of fields.
535 2011-12-02 Ben Konrath <ben@bagu.org>
537 Display currency codes in the details view.
539 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
541 2011-12-02 Ben Konrath <ben@bagu.org>
543 Avoid duplicate JNI call.
545 JNI is not as efficient as pure Java and this is an easy (and small)
548 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
549 Use previously retrieved value for whereClauseToTableName instead of
552 2011-12-02 Ben Konrath <ben@bagu.org>
554 Rename a couple of variables in RelatedListNavigation.
556 This is a rename-only refactor.
558 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
560 2011-12-02 Ben Konrath <ben@bagu.org>
562 Indicate clearly that a mismatched primary key type is a bug.
564 * src/main/java/org/glom/web/server/Utils.java: Change log level from
565 warning to error. Add 'This is a bug.' to message.
567 2011-12-02 Ben Konrath <ben@bagu.org>
569 Update / fix some comments.
571 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
573 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
575 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
576 Fix comments. Add some TODOs.
578 2011-12-02 Ben Konrath <ben@bagu.org>
580 Enable navigation to details view with string primary key from related list.
582 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
583 Create a text primary key value when return type of result is
584 java.sql.Types.VARCHAR.
586 2011-12-02 Ben Konrath <ben@bagu.org>
588 Use checkboxes for booleans in the details view.
590 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
592 2011-12-01 Ben Konrath <ben@bagu.org>
594 Improve performance of related list height calculation.
596 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
597 Put code to calculate the expected height in a static initializer so
598 that that it's only called once.
600 2011-12-01 Ben Konrath <ben@bagu.org>
602 Show related list tables in notebooks (again).
604 Calculate the height of the related list tables so the Notebook can be
605 set the correct height. The height of the related list table is also needed by
606 FlowTable to be able decide how to create the layout.
608 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
609 and set the Portal height based on the height of the related list
610 table and the Portal container.
611 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
612 Add method to calculate the height of the related list tables.
613 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
614 * src/main/webapp/style.css: Add css class for Pager. This is needed to
615 calculate the height of the Pager widget.
617 2011-12-01 Ben Konrath <ben@bagu.org>
619 Use CellTable API for table property instead of setting style on Element.
621 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
623 2011-12-01 Ben Konrath <ben@bagu.org>
625 Make ListViewTable and RelatedListTable a consistent height.
627 The tables are now a consistent height regardless of the contents of
628 the table. A hidden button is added to empty rows to ensure that the
629 height of these rows will match the height of rows with data.
631 A navigation button column is now added to every table. The width of
632 the navigation column is set to 0px when a RelatedListTable shouldn't
633 have navigation buttons. This maintains the a consistent row height in
634 tables that don't show the navigation buttons.
636 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
637 navigation column when not needed.
638 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
639 arguments for navigation button to constructor of ListViewTable.
640 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
641 hidden button for empty data rows.
642 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
643 arguments for navigation button to constructor.
644 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
645 create navigation buttons. Add hideNavigationButtons() method.
646 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
647 arguments for navigation button to constructor.
649 2011-12-01 Ben Konrath <ben@bagu.org>
651 Use 'visibility: hidden' in Utils.getWidgetHeight().
653 This is better choice because hidden elements are invisible, don't
654 respond to events and are not part of the tab order. They will,
655 however, take up space which is required to be able to calculate the
656 height of the widget.
658 * src/main/java/org/glom/web/client/Utils.java:
660 2011-12-01 Ben Konrath <ben@bagu.org>
662 Use Utils.getWidgetHeight() in FlowTable.
664 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
666 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
668 2011-12-01 Ben Konrath <ben@bagu.org>
670 Put the details css class name on the correct table column.
672 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
674 2011-11-30 Ben Konrath <ben@bagu.org>
676 Update for java-libglom API change.
678 The getters and setters on FieldFormatting and NumericFormat were
679 changed to remove the 'M'.
681 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
683 2011-11-29 Ben Konrath <ben@bagu.org>
685 Only allow RelatedListTables in Portals.
687 * src/main/java/org/glom/web/client/ui/details/Portal.java:
689 2011-11-29 Ben Konrath <ben@bagu.org>
691 Only create a contents panel for Portals when title is being set.
693 * src/main/java/org/glom/web/client/ui/details/Portal.java:
695 2011-11-29 Ben Konrath <ben@bagu.org>
697 Set TabLayoutPanel height based on calculated height its widgets.
699 This is a potential fix for this bug:
701 https://bugzilla.gnome.org/show_bug.cgi?id=665133
703 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
705 2011-11-29 Ben Konrath <ben@bagu.org>
707 Align details field labels and data with the Open buttons.
709 * src/main/webapp/style.css:
711 2011-11-29 Ben Konrath <ben@bagu.org>
713 Remove unnecessary <div> in the Notebook widget.
715 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
716 method to get container FlowPanel (<div>).
717 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
718 initWidget() method directly on the TabLayoutPanel widget instead of
719 Group's container widget.
721 2011-11-29 Ben Konrath <ben@bagu.org>
723 Don't add group titles for Portals in Notebooks.
725 This reverts the previous patch and fixes a bug I introduced with
726 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
728 * src/main/java/org/glom/web/client/ui/details/Group.java:
729 * src/main/java/org/glom/web/client/ui/details/Portal.java:
731 2011-11-28 Ben Konrath <ben@bagu.org>
733 Remove unused boolean argument in Portal constructor.
737 * src/main/java/org/glom/web/client/ui/details/Group.java:
738 * src/main/java/org/glom/web/client/ui/details/Portal.java:
740 2011-11-28 Ben Konrath <ben@bagu.org>
742 Remove hack for glom 1.18 style glom files.
744 * src/main/java/org/glom/web/client/ui/details/Group.java:
745 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
746 * src/main/java/org/glom/web/client/ui/details/Portal.java:
748 2011-11-28 Ben Konrath <ben@bagu.org>
750 Use Gda Value version of primary key to log result too large error.
752 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
754 2011-11-28 Ben Konrath <ben@bagu.org>
756 Don't use TypedDataItem.getText() for Unknown types from the URL.
758 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
759 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
760 instead of getText().
761 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
762 String field and getUnknown() method.
764 2011-11-28 Ben Konrath <ben@bagu.org>
766 Log an error message when the java-libglom .so is not present.
768 The error message was being set in the exception but not logged.
770 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
772 2011-11-28 Ben Konrath <ben@bagu.org>
774 Ignore LayoutItem_CalendarPortals.
776 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
777 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
779 2011-11-28 Ben Konrath <ben@bagu.org>
781 Extract method for creating the LayoutItemPortal DTO.
783 Just breaking the code up into smaller chunks.
785 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
787 2011-11-28 Ben Konrath <ben@bagu.org>
791 This should have been added with the refactor. Oops!
793 * src/main/java/org/glom/web/shared/TypedDataItem.java:
795 2011-11-28 Ben Konrath <ben@bagu.org>
797 Create primary key value from URL string using type from Glom document.
799 See this bug, comments 19 - 25:
801 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
803 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
804 create a TypeDataItem for the primary key here when loading from a
805 URL. Show the same string for the primary key value as was received
806 from the URL string (when loading from a URL).
807 * src/main/java/org/glom/web/server/Utils.java: Update method for
808 creating the Gda Value from the TypeDataItem to properly deal with
809 creating a Gda Value based on the Glom document type for the primary
810 key value string when loading from a URL.
811 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
812 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
813 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
814 Update for changed method name.
816 2011-11-27 Ben Konrath <ben@bagu.org>
818 Rename PrimaryKeyItem to TypedDataItem.
820 The name PrimaryKeyItem suggests what the class should be used for.
821 TypedDataItem is a neutral name that describes the class better.
823 This is a rename-only refactor.
825 * src/main/java/org/glom/web/client/OnlineGlomService.java:
826 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
827 * src/main/java/org/glom/web/client/Utils.java:
828 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
829 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
830 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
831 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
832 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
833 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
835 * src/main/java/org/glom/web/server/Utils.java:
836 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
837 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
838 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
839 * src/main/java/org/glom/web/shared/NavigationRecord.java:
841 2011-11-25 Ben Konrath <ben@bagu.org>
843 Improve Gda Value conversion from PrimaryKeyItem.
845 The value from the PrimaryKeyItem is only used if its type match the
846 type from the glom document.
848 * src/main/java/org/glom/web/server/Utils.java:
850 2011-11-25 Ben Konrath <ben@bagu.org>
852 Manually check if the java-liblgom .so is visible to the JVM.
854 It seems that Tomcat has problems when a static initializer throws an
855 exception. This check is done before the first method call into
856 java-libglom so that execution doesn't continue if the .so is not
859 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
861 2011-11-25 Ben Konrath <ben@bagu.org>
863 Improve browser configuration error messages.
867 https://bugzilla.gnome.org/show_bug.cgi?id=662792
869 * src/main/java/org/glom/web/client/OnlineGlomService.java:
870 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
871 getConfigurationErrorMessage() method.
872 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
873 Get and display a specific configuration error message when no Glom
875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
876 Implement getConfigurationErrorMessage() method. Surround configuration
877 code in the init() method with a try/catch block. This allows the
878 errors to be caught while keeping the servlet available to retrieve the
879 configuration error message.
881 2011-11-25 Ben Konrath <ben@bagu.org>
883 Don't use Strings to hold primary key values.
885 The primary key values are now held in a new data object
886 (PrimaryKeyItem) that holds type information and the primary key value
887 using the correct type.
889 * src/main/java/org/glom/web/client/OnlineGlomService.java:
890 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
891 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
892 PrimaryKeyItem instead of String to hold the primary key value.
893 * src/main/java/org/glom/web/client/Utils.java: Remove
894 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
895 PrimaryKeyItem based on the GlomFieldType and the DataItem.
896 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
897 PrimaryKeyItem instead of String to hold the primary key value. Load
898 document selection page when the documentID has not been set correctly.
899 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
900 DetailsPlace -> URL and URL -> DetailsPlace conversion with
902 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
903 Return empty string for URL instead of "null".
904 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
905 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
906 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
907 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
908 PrimaryKeyItem instead of String to hold primary key values.
909 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
910 PrimaryKeyValue to a Gda Value.
911 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
912 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
913 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
914 Replace temporary database access code that uses the PrimaryKeyValue to
915 Gda Value conversion.
916 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
917 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
918 PrimaryKeyItem instead of String.
919 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
920 hold primary key values.
922 2011-11-24 Ben Konrath <ben@bagu.org>
924 Use newly added java-libglom API to create queries.
926 This isn't finished. I still need to stop using Strings for primary key
927 values in the client code.
929 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
930 libglom to use fake connections so that retrieving the query string will
932 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
933 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
934 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
935 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
936 Use the newly added libglom sql methods and classes to create the
937 query. Add temporary hack to convert primary value strings to Gda
940 2011-11-23 Ben Konrath <ben@bagu.org>
942 Don't explicitly set the height of Portals.
944 See comments 6 - 10 of this bug for details:
946 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
948 * src/main/java/org/glom/web/client/ui/details/Portal.java:
950 2011-11-23 Ben Konrath <ben@bagu.org>
952 Use an HTML table instead of CSS for the FlowTable layout.
954 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
955 GWT's FlexTable to implement the FlowTable.
956 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
958 2011-11-18 Ben Konrath <ben@bagu.org>
960 Add boolean example to HTML table mockup.
962 * mockups/details-view-html-tables-text-entries.html:
964 2011-11-17 Ben Konrath <ben@bagu.org>
966 Ensure the pager buttons are always visible for related lists.
968 To accomplish this, I've turned off text wrapping in the list view and
969 related list tables for both the header and data text. The related list
970 table now has a fixed layout so the it doesn't overflow its container.
971 This is required to ensure that the cell text is clipped when it
972 overflows the cell and an ellipsis is added to the right side of the
973 cell when text is clipped.
975 A fixed table layout for the related list table in the details view
976 seems what we want for the details view anyway, so the side-effect is
979 The ellipsis will only be displayed in Firefox >= 7.
983 https://bugzilla.gnome.org/show_bug.cgi?id=662930
985 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
986 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
987 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
989 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
990 Set the 'table-layout: fixed' CSS property to the related list table.
991 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
992 'white-space: nowrap;' CSS property on both the list view and the
995 2011-11-16 Ben Konrath <ben@bagu.org>
997 Rework the fix for empty notebook tab labels.
999 Setting the empty group titles with its name caused problems for the
1000 details layout. Instead of using libglom's
1001 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1002 to the client when the title is empty. This allows the Notebook to use
1003 the name when the title is empty without affecting anything else.
1005 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1006 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1008 2011-11-16 Ben Konrath <ben@bagu.org>
1010 Set group titles with name when title is empty.
1012 This fixes a problem with an empty notebook tab label in the Lesson
1013 Planner document. The forth tab in the notebook should be "Internet":
1015 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1017 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1018 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1021 2011-11-16 Ben Konrath <ben@bagu.org>
1023 Remove whitespace from the configured username properties.
1025 This assumes that usernames won't have whitespace at the beginning
1026 or end. But I think this is a reasonable assumption.
1028 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1029 String.trim() to remove the whitespace from the username properties.
1031 2011-11-15 Ben Konrath <ben@bagu.org>
1033 Add details view mockup with HTML tables and text entries.
1035 This is from the attachment on this bug:
1037 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1039 * mockups/details-view-html-tables-text-entries.html:
1041 2011-11-15 Ben Konrath <ben@bagu.org>
1043 Add space between the columns of the flow table.
1047 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1049 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1050 space between columns in the flow table.
1052 2011-11-15 Ben Konrath <ben@bagu.org>
1054 Add backup files to the .gitignore.
1056 * .gitignore: Ignore files that end with ~.
1058 2011-11-09 Ben Konrath <ben@bagu.org>
1060 Use latest release of gwt-log.
1062 Gwt-log releases are now being submitted to the maven central
1063 repository so manual installation of the jar is no longer required.
1065 * pom.xml: Update version and groupId of gwt-log dependency.
1067 2011-10-31 Ben Konrath <ben@bagu.org>
1069 Don't use GWT numeric formatting to override the glom currency formatting.
1071 Currencies are now displayed like they are in Glom. See this bug:
1073 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1075 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1077 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1078 currency code to constructor and set it when the cell is rendered.
1079 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1080 currency code to the constructor of the NumericCell.
1082 2011-10-27 Ben Konrath <ben@bagu.org>
1084 Require the latest release of java-libglom (1.17.4).
1088 2011-10-26 Ben Konrath <ben@bagu.org>
1090 Add style to Notebook that matches current theme.
1092 It's not the best style in the world but it's better than the default.
1094 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1095 padding at the bottom of the child widgets.
1096 * src/main/webapp/style.css: Add style for the Notebook.
1098 2011-10-26 Ben Konrath <ben@bagu.org>
1100 Move servlet initialization code to overridden init method.
1102 This is half of the solution to getting proper error messages
1103 displayed when configuration errors occur. Here's the relevant bug:
1105 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1107 The rest of the solution involves surrounding the init method with a
1108 try/catch block and setting a global variable with the error /
1109 exception. A new async method should be created to retrieve and display
1110 the error message / exception.
1112 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1113 code from constructor to init method adding exceptions as needed.
1115 2011-10-26 Ben Konrath <ben@bagu.org>
1117 Add script to monitor and restart tomcat if required.
1119 * utils/check-and-recover-tomcat.py: New file.
1121 2011-10-26 Ben Konrath <ben@bagu.org>
1123 Display the correct number of data items in the pager.
1127 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1129 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1130 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1131 The implementation is the same for both tables: Keep track of the
1132 number of non-empty rows and fire and RowCountChangeEvent after the data has
1134 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1135 custom Pager class that subclasses SimplePager to handle displaying
1136 the correct number when empty rows have been added.
1138 2011-10-26 Ben Konrath <ben@bagu.org>
1140 Correct error in previous commit.
1142 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1143 eventBus parameter from listView.setCellTable().
1145 2011-10-26 Ben Konrath <ben@bagu.org>
1147 Fix error in TODO comment.
1149 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1151 2011-10-24 Ben Konrath <ben@bagu.org>
1153 Create Notebook widgets to the details view.
1155 This isn't finished just yet - I still need to create a reasonable
1156 style to match the current theme.
1158 * src/main/java/org/glom/web/client/Utils.java: Add method for
1159 calculating the height of a widget. This is used in the Notebook class.
1160 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1161 new constructor method in Group.
1162 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1163 method for creating child widget that can be used by subclasses
1164 like Notebook. New constructor that allows disabling the group
1165 titles - Notebooks don't set a group title for their child groups.
1166 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1167 to make Notebooks using GWT's TabLayoutPanel.
1168 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1169 constructor that allows disabling the group titles.
1170 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1171 LayoutItemNotebook DTO.
1172 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1173 DTO for Notebooks. It's just an empty class for now but we might need
1174 it to transfer some specific information in the future.
1176 2011-10-21 Ben Konrath <ben@bagu.org>
1178 Add navigation buttons to related list tables.
1180 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1181 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1182 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1183 method getSuitableRecordToViewDetails() for getting the table name
1184 and primary key value for related list navigation buttons.
1185 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1186 private cell renderer class to get the navigation information for
1187 related list tables from the server. Extract the navigation
1188 processing code from the details cell navigation and use it for the
1189 related list navigation as well.
1190 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1191 cell renderer class for the details open buttons. This was needed
1192 because the related list navigation buttons and the list view
1193 navigation buttons need to react differently when clicked.
1194 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1195 the onEnterKeyDown() method because it's now overriden in the
1196 subclasses that are specific to the related list tables and the list
1198 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1199 the vertical size a little because the buttons add a bit of vertical
1200 space to table. This is not a perfect solution because the vertical
1201 size of with table fewer than 5 rows will be a little smaller.
1202 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1203 changes in how navigation buttons are handled.
1204 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1205 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1206 database access object.
1207 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1208 to find the portal for a given relationship name from
1209 RelatedListDBAccess. Add method to find a primary key field for a
1211 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1212 Move code to find the portal for a given relationship name to
1214 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1215 New file: database access object for getting the related list
1216 navigation information (the table name and the primary key value).
1217 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1218 DTO for transferring a table name to navigate to and a primary key
1220 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1221 boolean and getter/setter to specifies if the related list should add
1224 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1226 Use the master branch of java-libglom
1228 * pom.xml: Depend on java-libglom 1.19 instead.
1230 This is the master branch. See also the libglom-1-18 branch.
1232 2011-10-11 Ben Konrath <ben@bagu.org>
1234 Enable the open navigation button when the data has been set.
1236 This avoids having active buttons that don't do anything when the data
1239 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1241 2011-10-11 Ben Konrath <ben@bagu.org>
1243 Use IsWidget interface for FlowTableItem.
1245 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1246 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1248 2011-10-11 Ben Konrath <ben@bagu.org>
1250 Remove GWT styling from open button in details view.
1252 There are still some issues with how the details cell is arranged but
1253 this should be made to match Glom 1.20. I'm going to leave fixing this
1254 until I have Glom 1.20 up and running.
1256 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1257 style name on open button.
1258 * src/main/webapp/style.css: Move and edit details-navigation class.
1259 Re-arrange some classes to make them appear in the same order as the
1262 2011-10-07 Ben Konrath <ben@bagu.org>
1264 Update to GWT 2.4.0.
1266 * .gitignore: Ignore new cache directory.
1267 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1268 * pom.xml: Change GWT and maven plugin to 2.4.0.
1269 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1271 * src/main/java/org/glom/web/client/ClientFactory.java:
1272 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1273 * src/main/java/org/glom/web/client/OnlineGlom.java:
1274 Update source for API changes.
1275 * utils/build-onlineglom-war.sh: Remove cache directory before the
1278 2011-10-07 Ben Konrath <ben@bagu.org>
1280 Add navigation buttons in the details view.
1282 This isn't finished but I thought I'd commit what I have as it's a
1283 pretty good start. I still need to:
1285 1. Change the style so that it fits better into the current theme
1286 2. Adjust the details cell to expand as much as possible.
1288 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1289 click handlers to navigation buttons in the DetailsCells. Create a
1290 refreshData() method to get just the data from the server without the
1292 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1293 Update the tableSelector and browser title when the table name
1294 changes without using the tableSelector.
1295 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1296 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1297 getDetailsCells() to getCells(). Update variable names.
1298 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1299 method to set click handler on navigation button. Rename a few
1300 variables. Add navigation buttons where needed.
1301 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1302 variables and methods.
1303 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1304 navigation boolean and navigation table as required in the
1305 LayoutItemField DTO.
1306 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1307 variables for navigation along with getter/setter methods.
1309 2011-10-07 Ben Konrath <ben@bagu.org>
1311 Rename Field to DetailsCell.
1313 This is a refactor-only commit. No functionality has been added or
1316 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1317 Update variable and method names.
1318 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1319 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1320 variable and method names.
1321 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1323 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1324 variable and method names.
1326 2011-10-07 Ben Konrath <ben@bagu.org>
1328 Create separate methods for layout and data the details view.
1330 This is a refactor-only commit. No functionality has been added or
1333 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1334 private methods: setData(), createLayout().
1336 2011-10-07 Ben Konrath <ben@bagu.org>
1338 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1340 This is part of a change to get navigation buttons in the details view
1341 but it should have been done this way from the start.
1343 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1344 for method name change in TableSelectionView.
1345 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1346 Create TableChangeEvent and set the browser title using the
1347 TableSelectionView API.
1348 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1349 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1350 Change getSelectedTable() to getSelectedTableName(). Add
1351 getSelectedTableTitle().
1353 2011-10-07 Ben Konrath <ben@bagu.org>
1355 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1357 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1359 2011-10-07 Ben Konrath <ben@bagu.org>
1361 Update TableChangeEvent to use newTableName naming convention.
1363 This makes the class more consistent with GWT naming conventions.
1365 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1366 Update for method name change in TableChangeEvent.
1367 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1368 for method name change in TableChangeEvent.
1369 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1370 newTableName variable and getter method. Make toDebugString()
1373 2011-09-30 Ben Konrath <ben@bagu.org>
1375 Disable the pager in the list tables when the data row count is less than the minimum.
1377 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1378 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1380 2011-09-30 Ben Konrath <ben@bagu.org>
1382 Add empty rows to the end of related list and list view tables.
1384 I also extracted the cell rendering classes from the ListTable because
1385 the code was becoming a little crazy with all the anonymous inner
1386 classes. My plan is to use these cell rendering classes in the details
1387 view as well so this refactor will be needed for that change.
1389 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1390 set the row count in related list tables if the data has more rows
1391 than the minimum number of rows visible.
1392 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1393 row count in list view tables if the data has more rows than the
1394 minimum number of rows visible.
1395 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1396 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1398 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1399 for rendering TYPE_NUMERIC cells. The code was extracted from the
1401 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1402 class for rendering cells with buttons in list views. The code was
1403 extracted from the ListTable class.
1404 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1405 for rendering TYPE_TEXT cells. The code was extracted from the
1407 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1408 Add empty rows to the end of the data if required. Implement
1409 ListTable.getMinNumVisibleRows().
1410 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1411 cell renderer code to public classes. Return null in
1412 Column.getValue() for empty rows. Add new abstract method:
1413 getMinNumVisibleRows(). Move code to set the row count of the list view
1414 table to ListViewImpl.
1415 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1416 empty rows to the end of the data if required. Implement
1417 ListTable.getMinNumVisibleRows().
1420 2011-09-27 Ben Konrath <ben@bagu.org>
1422 Use GWT.log for client-side debugging statements.
1424 These are optimized out when deployed so I should have used this method
1425 in the first place. These statements will eventually be replaced with some sort
1426 of notification in the browser.
1428 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1429 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1430 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1431 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1432 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1434 2011-09-27 Ben Konrath <ben@bagu.org>
1436 Put tableselector on the right, back to list link on right.
1438 The idea is that the table selector is acting like a label for the
1439 currently displayed table so it should be placed below the document title. This
1440 puts the table title in a similar position to where it is in Glom.
1442 * mockups/details-contacts.html:
1443 * mockups/details-projects.html:
1444 * mockups/listview-contacts.html:
1445 * mockups/listview-projects.html:
1446 * mockups/style.css:
1447 Update mockups to match how the interfaces currently look.
1448 * src/main/webapp/style.css: Swap positions of backlink with the table
1449 selector. Add some space on the left side of the table selector to
1450 line things up with the document title.
1452 2011-09-27 Ben Konrath <ben@bagu.org>
1454 Add field colouring to details view.
1456 This change re-works how field colouring works. The colour formatting
1457 information is now set to the client with the layout information instead of
1458 with the data. This eliminates the need to send the same colour strings for
1459 data in list view column when colour information is set.
1461 In order to set an alternate colour for negative numeric values, the
1462 number is now sent to client and formatted with the GWT NumberFormat class.
1464 This change also fixes:
1466 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1468 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1469 internationalization framework which is needed for client side numeric
1471 * src/main/java/org/glom/web/client/Utils.java: New file for some
1472 client static utility methods.
1473 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1474 the DataItem object to the Field class. Use a utility method to
1475 create the foreignKeyValue string.
1476 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1477 alignment and text colours in the constructor. Add setData(DataItem)
1478 method. Remove setText(String) method.
1479 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1480 colour information to GlomTextCell. Create and use GlomNumberCell for
1481 rendering numbers. Use utility method to get the string for the
1482 primary key of the key provider. Re-work how the horizontal alignment
1484 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1485 formatting to layout information. Methods for converting the libglom
1486 formatting information were moved from DBAccess.
1487 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1488 numeric formatting (it's now done on the client side). Don't set text
1489 colours in DataItem. Move libglom formatting conversion methods to
1491 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1492 getters/setters for text colour information.
1493 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1494 for transferring the libglom NumericFormat information to the client.
1495 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1496 and getters/setters for: GlomNumericFormat, background colour and
1497 foreground colour strings.
1499 2011-09-26 Ben Konrath <ben@bagu.org>
1501 Simplify code that iterates through the LayoutGroup.
1503 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1505 2011-09-26 Ben Konrath <ben@bagu.org>
1507 Accept Eclipse formatting for OnlineGlomServiceAsync.
1509 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1511 2011-09-26 Ben Konrath <ben@bagu.org>
1513 Don't use the ListDBAccess classes to get the primary key layout information.
1515 This was causing a bug where the wrong index for the hidden primary key
1516 was being sent to the client.
1518 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1519 primary key while creating the LayoutGroup DTO. Create a
1520 LayoutItemField DTO for hidden primary keys. Don't use the
1521 RelatedListDBAccess because it was only used for getting the primary
1523 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1524 access modifier from public to protected for getPrimaryKeyField() and
1525 getPrimaryKeyLayoutItemField().
1526 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1527 abstract method getExpectedResultSize() because RelatedListDBAccess
1528 doesn't have enough info to implement it.
1529 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1530 Remove @Override for getExpectedResultSize().
1531 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1532 Remove method getExpectedResultSize().
1534 2011-09-23 Ben Konrath <ben@bagu.org>
1536 Log which layout (list or details) the ignored item is from.
1538 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1540 2011-09-23 Ben Konrath <ben@bagu.org>
1542 Remove annotations that turn off code formatting in DataItem.
1544 * src/main/java/org/glom/web/shared/DataItem.java:
1546 2011-09-23 Ben Konrath <ben@bagu.org>
1548 Rename GlomField to DataItem and update associated methods.
1550 This is a rename-only refactor. No functionality has been added or
1553 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1554 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1555 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1556 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1557 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1558 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1559 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1560 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1561 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1562 * src/main/java/org/glom/web/server/database/DBAccess.java:
1563 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1564 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1565 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1566 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1567 * src/main/java/org/glom/web/shared/DataItem.java:
1568 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1569 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1571 2011-09-23 Ben Konrath <ben@bagu.org>
1573 Rename GlomDocument to DocumentInfo and update associated methods.
1575 This is a rename-only refactor. No functionality has been added or
1578 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1579 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1580 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1581 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1582 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1583 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1584 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1586 2011-09-20 Ben Konrath <ben@bagu.org>
1588 Require java-libglom 1.17.3.
1590 This picks up the fix for the seg fault problem with the Scenes table
1591 in the Openismus Film Manager example.
1595 2011-09-20 Ben Konrath <ben@bagu.org>
1597 Change the way sort clause is added for primary key when no sort clause is requested.
1599 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1600 before the sort clause is created. When a sort clause is not requested, the
1601 sort clause is created by finding the primary key in the LayoutFieldVector
1604 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1606 2011-09-20 Ben Konrath <ben@bagu.org>
1608 Log error message if no documents are found in the configured directory.
1610 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1611 Extract the glom file extension string to a private static final class
1612 variable (mostly as syntactic sugar). Accept a minor formatting change.
1613 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1614 the example glom.document.directory configuration property to make it
1615 more clear that it can any directory, not just the home directory.
1617 2011-09-18 Ben Konrath <ben@bagu.org>
1619 Add related lists to details view.
1621 The related list table has support for paging and sorting just like the
1622 table in the list view.
1624 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1625 SQL queries for the related list tables.
1626 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1627 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1629 Rename getList methods to getListView and add comments. Remove
1630 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1631 it being unused. Add methods: getDetailsLayoutAndData(),
1632 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1633 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1634 Create the layout and set the data for the fields in one async call
1635 instead of two. Create related lists where appropriate.
1636 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1637 for method name changes in OnlineGlomService.
1638 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1639 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1640 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1642 * src/main/java/org/glom/web/client/ui/ListView.java:
1643 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1644 tableName from setCellTable(). Create a ListViewTable instead of
1646 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1647 represent a data field in the details view.
1648 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1649 from addDetailsCell() to Field class. Keep track of the Fields and
1650 Portals in the details view.
1651 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1652 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1653 and add a method to get it. Add method to set the contents of the
1655 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1656 New class for related list tables. This class has the data provider
1657 for the related list table.
1658 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1659 abstract class which is the base class for the ListViewTable and the
1661 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1662 New class for list view tables. This class has the data provider for
1663 the list view table.
1664 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1665 methods for related list tables. Add more information to the
1666 LayoutItemField and LayoutItemPortal DTOs.
1667 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1668 Remove debugging print statement.
1669 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1670 Remove debugging print statements. Add primary key field to SQL count
1672 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1673 Remove unnecessary LayoutFieldVector parameter from
1674 getResultSizeOfSQLQuery() method.
1675 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1676 New class for related list table database access.
1677 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1678 class that is a wrapper DTO for details view layout and data.
1679 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1680 new 'fromField' string to this DTO.
1681 * src/main/webapp/style.css: Remove bottom margin and override top
1684 2011-09-15 Ben Konrath <ben@bagu.org>
1686 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1688 This sets things up to make it easier to add the data retrieval for
1689 related lists (portals). No user noticeable changes were made with
1692 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1693 class has the code to retrieve the layouts and access the
1694 database using the new database helper classes.
1695 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1696 Most of the functionality has been removed from this class. This
1697 class now represents the public interface for the client side
1698 code. It also deals with configuring the servlet and cleaning
1699 things up when the servlet is stopped.
1700 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1701 of static methods into this utility class.
1702 * src/main/java/org/glom/web/server/database/DBAccess.java:
1703 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1704 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1705 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1706 These classes have the database retrieval code. The class hierarchy
1707 has been setup to make it easy to reuse code for similar
1710 2011-09-06 Ben Konrath <ben@bagu.org>
1712 Create separate classes for list table code and the data provider.
1714 As part of this refactor, I also split up the code a bit to make it
1717 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1718 table code to two new classes (below).
1719 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1720 with code from ListViewImpl.
1721 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1722 New file with code from ListViewImpl.
1724 2011-09-06 Ben Konrath <ben@bagu.org>
1726 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1728 This fixes the LayoutItemPortal DTO to match the libglom layout object
1731 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1733 2011-09-01 Ben Konrath <ben@bagu.org>
1735 Set title of Portals in the Details View.
1737 * pom.xml: Bump required version of java-libglom to 1.17.1.
1738 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1739 widget creation to its own class. Add comments to constructor.
1740 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1741 The code is mostly from the Group class with the title now set.
1742 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1743 title of Portal. Update some comments. Fix some code formatting.
1745 2011-09-01 Ben Konrath <ben@bagu.org>
1747 Remove TODO comment for the flow table column width.
1749 The flow table column width is working correctly and doesn't need to be
1750 changed. See this mailing list post for more info:
1752 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1754 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1756 2011-08-27 Ben Konrath <ben@bagu.org>
1758 Add document title (database name) to top of the browser page.
1760 I added the document title to the TableSelecitonView but that will
1761 change if / when we add a view that doesn't require table selection.
1763 * mockups/details-contacts.html:
1764 * mockups/details-projects.html:
1765 * mockups/listview-contacts.html:
1766 * mockups/listview-projects.html:
1767 * mockups/style.css: Add document title to mockups to keep things
1769 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1770 sizes to account for the document title.
1771 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1772 Set the document title when it has been retrieved from the server.
1773 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1774 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1775 and implement setDocumentTitle(String) method.
1776 * src/main/webapp/style.css: Add ID for document title style.
1778 2011-08-25 Ben Konrath <ben@bagu.org>
1780 Add NavigationType enum to LayoutItemPortal DTO.
1782 This is the start of adding support for Portals to the Details View.
1784 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1785 LayoutItem_Portal.navigation_type enum from libglom to
1786 LayoutItemPortal.NavigationType enum.
1787 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1788 NavigationType enum, field for storing the NavigationType and getter
1791 2011-08-25 Ben Konrath <ben@bagu.org>
1793 Implement the flow table layout in the Details View.
1795 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1796 FlowTable to Group to account for the renamed class.
1797 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1798 File. This is a container widget that implements the Glom details view
1799 flow table behaviour.
1800 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1801 org/glom/web/client/ui/FlowTable.java.
1802 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1803 so that the size of the subgroups are a closer match to the size of
1804 the Glom subgroups. This makes the flowtable layout match the layout
1805 in Glom for the Music Collection example file.
1807 2011-08-16 Ben Konrath <ben@bagu.org>
1809 Create container element for LayoutItemPortal in Details View.
1811 This will help me develop the layout for the FlowTable.
1813 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1814 fieldPanel variable to detailsCell.
1816 2011-08-15 Ben Konrath <ben@bagu.org>
1818 Set the height of the data element in the Details View.
1820 I changed the InlineLabels (text in a span element) to Labels (text in
1821 a div element) so that I could set the height of the details-data
1822 elements instead of the details-cell parent elements. This allows the
1823 the details-data element to display the correct height if style is
1824 applied that shows the height.
1826 This change has the added benefit of allowing the order of the labels
1827 and data elements to be changed for right-to-left languages.
1829 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1830 InlineLabels to Labels.
1831 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1832 InlineLabels to Labels. Set the height of the data element.
1833 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1834 multiline text height in the Formatting DTO.
1835 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1836 for multiline height along with getter and setter methods.
1837 * src/main/webapp/style.css: Adjust style to account for the change
1838 from span elements to div elements in the details cell.
1840 2011-08-15 Ben Konrath <ben@bagu.org>
1842 Make the List View appearance match the mockups.
1844 It doesn't match exactly but it's much better than it was.
1846 * mockups/listview-contacts.html: Remove unused css classes.
1847 * mockups/listview-projects.html: Remove unused css classes.
1848 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1849 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1850 for mainPanel instead of VerticalPanel (table). Set style name on
1851 CellTable. Set style name on Details column. Right-align Details
1853 * src/main/webapp/style.css: Adjust properties to match the mockups.
1855 2011-08-12 Ben Konrath <ben@bagu.org>
1857 Add better support for subgroups in the details view.
1859 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1860 changed FlowTable constructor.
1861 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1862 support for subgroups and subgroup-titles.
1863 * src/main/webapp/style.css: Add CSS class for subgroups and
1866 2011-08-12 Ben Konrath <ben@bagu.org>
1868 Return the top level LayoutGroup title.
1870 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1872 2011-08-11 Ben Konrath <ben@bagu.org>
1874 Make the TableSelector header match the mockup.
1876 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1877 the layout panel. Properly lineup the table selection header with
1878 the list and details view.
1879 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1880 margin around the details view.
1881 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1882 Rename listBox variable to tableSelector. Set id for the style sheet.
1883 Use a FlowPanel instead of a HorizontalPanel.
1884 * src/main/webapp/style.css: Add properties to make the TableSelector
1885 box match the mockups.
1887 2011-07-13 Ben Konrath <ben@bagu.org>
1889 Update install script for java-libglom version change.
1891 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1894 2011-07-13 Ben Konrath <ben@bagu.org>
1896 Add support sub-group in the details view.
1898 I also removed the code that special-cased the default details view
1901 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1903 I still have to make a proper flowtable.
1905 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1906 Don't special-case default details view layout.
1907 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1908 addLayoutField() as I'm going to use it.
1909 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1910 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1912 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1913 extracted from DetailsViewImpl.GroupPanel. Add support for
1915 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1916 column count when getting the details layout.
1918 2011-07-12 Ben Konrath <ben@bagu.org>
1920 Set browser title with database and table titles.
1922 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1923 Set the browser title when the table changes and when the activity
1925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1926 title when retrieving document info (the GlomDocument object).
1927 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1928 with getter and setter methods. Remove unused convenience constructor.
1929 Use default code formatting.
1931 2011-07-12 Ben Konrath <ben@bagu.org>
1933 Ignore LayoutItemPortals in the details view.
1935 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1938 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1939 LayoutItemPortal layout objects.
1940 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1941 LayoutItemPortal objects when retrieving the details layout.
1942 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1943 file. This is an empty class and just used to get type information for
1946 2011-07-12 Ben Konrath <ben@bagu.org>
1948 Use java-libglom 1.17.0.
1952 2011-07-11 Ben Konrath <ben@bagu.org>
1954 Remove "Table:" label from table selector.
1956 This matches a recent change in the Glom UI.
1958 * mockups/details-contacts.html:
1959 * mockups/details-projects.html:
1960 * mockups/listview-contacts.html:
1961 * mockups/listview-projects.html: Remove the "Table:" label from the
1963 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1965 2011-07-11 Ben Konrath <ben@bagu.org>
1967 Add main groups to the details view.
1969 This makes things look a little nicer in the details view. The next step
1970 is to implement the flowtable.
1972 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1973 resources from the standard gwt css theme. Standard.css is now
1974 included in OnlineGlom.html so that the online glom css rules have
1975 precedence over the gwt theme.
1976 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1977 the whole LayoutGroup to the DetailsView instead of just the titles.
1978 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1979 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1980 details layout with a helper class (GroupPanel). I might extract this
1981 class when I make the full flowtable.
1982 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1983 string as default so I don't have to worry about NPEs when processing
1985 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1986 note beside OnlineGlom.gwt.xml above).
1987 * src/main/webapp/style.css: Add default font-size to body to override
1988 the font-size set by the standard theme. Don't use h2 tags for
1989 group-title. Create new details-cell class.
1991 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1993 ConfiguredDocument: Set the port number too.
1995 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1996 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1997 Glom document. Presumably this worked sometimes so far because there is a
1998 default port number.
2000 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2002 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2004 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2005 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2006 correct, though we should throw an exception too.
2008 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2010 Fix a addDocuemnt typo.
2012 * src/main/java/org/glom/web/shared/Documents.java
2013 (Documents.addDocuemnt): Rename to addDocument().
2014 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2015 (OnlineGlomServiceImpl.getDocuments): Adapt.
2017 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2019 Slightly improved log output when connection fails.
2021 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2022 (ConfiguredDocument.setUsernameAndPassword):
2023 We don't know for sure if it' the username/password that's wrong, so
2024 rephrase the message.
2025 Also ouput the exception message, though it's generic in this case.
2027 2011-07-08 Ben Konrath <ben@bagu.org>
2031 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2032 added braces to a one line if statement because the Eclipse formatter
2033 was getting confused.
2035 2011-07-07 Ben Konrath <ben@bagu.org>
2037 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2039 These should really be two separate tasks but I counldn't get things to
2040 work with GWT 2.2.0 and Eclipse 3.7.
2044 * .settings/org.eclipse.jdt.core.prefs:
2045 * .settings/org.eclipse.jdt.ui.prefs:
2046 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2047 * .settings/org.eclipse.m2e.core.prefs:
2048 Add new config files. Update current files. Remove references to the
2049 webtools plugins as we're not using any of the webtools features.
2050 * .gitignore: Add logs directory which is created when running with
2052 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2053 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2054 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2056 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2058 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2060 onlineglom.properties: Add explanatory comments.
2062 * src/main/resources/onlineglom.properties: Also change the default user
2063 from ben to someuser, to avoid the risk of people thinking we just
2064 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2066 2011-06-28 Ben Konrath <ben@bagu.org>
2068 Use filename in Log for incorrect passwords.
2070 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2071 getFileName(String) method to get the filename from the URI.
2073 2011-06-28 Ben Konrath <ben@bagu.org>
2075 Add the table name to the URL token for the ListPlace.
2077 This makes things consistent between the DetailsPlace and the
2078 ListPlace. It also allows the the ListPlace to be bookmarked.
2080 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2081 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2082 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2083 Remove getDefaultListLayout(). The default layout is now returned
2084 by the getListLayout() method when the table name is an empty string.
2085 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2086 Add table name field. Change to a new ListPlace when the table
2087 has been changed. Use getListLayout() for getting the default
2089 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2090 Add table name field. Set the correct table name in the list box
2091 when loading from bookmark. This corrects a problem for the
2093 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2094 Move table name to super-class (HasSelectableTable). Move document
2095 and table URL keys to super-class in HasSelectableTable.
2096 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2097 Add table name field. Add Tokenizer class with URL key common to
2098 the subclasses (DetailsPlace and ListPlace).
2099 * src/main/java/org/glom/web/client/place/ListPlace.java:
2100 Add table name. Add code to parse the URL token.
2101 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2102 Update ListPlace construction with empty table name string.
2103 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2104 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2105 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2106 Update ListPlace construction with table name string.
2107 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2108 Change defaultTableName field to tableName to reflect how it's now
2109 used. Update the getter and setter methods.
2111 2011-06-28 Ben Konrath <ben@bagu.org>
2113 Enable the table selector in the DetailsView.
2115 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2116 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2117 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2118 Remove getDefaultDetailsLayout(). The default layout is now returned
2119 by the getDetailsLayout() method when the table name is an empty
2121 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2122 event handler for table change event. Change to using
2123 getDetailsLayout() for the default details layout.
2124 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2126 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2127 when navigating to the details place.
2129 2011-06-27 Ben Konrath <ben@bagu.org>
2131 Use filename based unique document ID in URL and for RPC.
2133 The document ID is the glom document name with spaces (' ') replaced
2134 with pluses ('+') and without the .glom extension.
2136 This change is mostly a string substitution of 'documentTitle' for
2137 'documentID'. The only code change is the addition of a Documents DTO to get the
2138 filename to document title mappings as indicated below.
2140 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2141 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2142 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2143 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2144 Use Documents DTO to create the document links in the document
2146 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2147 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2148 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2149 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2150 * src/main/java/org/glom/web/client/place/ListPlace.java:
2151 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2152 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2153 * src/main/java/org/glom/web/client/ui/ListView.java:
2154 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2155 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2156 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2157 * src/main/java/org/glom/web/server/Log.java:
2158 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2159 getDocumentTitles() to getDocuments() and return the Documents DTO.
2160 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2161 transferring the filename to document title mappings.
2163 2011-06-25 Ben Konrath <ben@bagu.org>
2165 Make the authentication popup work again.
2167 This bug was introduced when I extracted ConfiguredDocument to its own class.
2169 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2170 correct success / fail status in setUsernameAndPassword().
2172 2011-06-25 Ben Konrath <ben@bagu.org>
2174 Use filename as unique key for configuring database usernames and passwords.
2176 This replaces the use of the Glom document title which could change
2177 depending on the locale. Thanks to Murray Cumming for pointing out this
2180 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2181 * src/main/resources/onlineglom.properties:
2183 2011-06-24 Ben Konrath <ben@bagu.org>
2185 Pass primary key value to DetailsView.
2187 This enables the DetailsView to load the correct data.
2189 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2190 primary key value field and set in constructor. Pass primary key
2191 value to getDetailsData().
2192 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2193 variables for document title and primary key value.
2194 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2195 key value to the DetailsPlace.
2197 2011-06-24 Ben Konrath <ben@bagu.org>
2199 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2201 This allows the primary key to be retrieved by the Details button. This
2202 functionality has not been implemented yet but it's in the works.
2204 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2205 the LayoutGroup result to ListView.setCellTable instead of all of its
2206 fields individually.
2207 * src/main/java/org/glom/web/client/ui/ListView.java:
2208 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2209 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2210 get the primary key for the table.
2211 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2212 index of the primary key in the LayoutGroup accounting for hidden
2213 primary keys. Rename getJavaNumberFormat() to
2214 convertToJavaNumberFormat() for consistency. Cleanup / add some
2216 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2217 field for primary key index and a field to indicate whether the
2218 primary key is hidden or not.
2220 2011-06-23 Ben Konrath <ben@bagu.org>
2222 Rename getTableData methods to getListData.
2224 This is a rename refactor for consistency with other methods.
2226 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2227 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2228 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2229 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2231 2011-06-23 Ben Konrath <ben@bagu.org>
2233 Extract the ConfiguredDocument innerclass into its own class.
2235 This makes the servlet code more object oriented.
2237 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2238 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2239 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2240 new ConfiguredDocument class.
2242 2011-06-21 Ben Konrath <ben@bagu.org>
2244 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2246 This makes things more inline with how libglom works and reduces code
2247 duplication. This refactor lays the groundwork for adding the primary key to
2248 the LayoutGroup object.
2250 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2251 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2252 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2253 Change method names to getListLayout and getDefaultListLayout for
2254 consistency. Use LayoutGroup as the DTO for the list layout instead of
2255 ColumnInfo and LayoutListTable.
2256 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2257 new method names along with the LayoutGroup object for transferring the
2259 * src/main/java/org/glom/web/client/ui/ListView.java:
2260 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2261 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2262 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2264 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2265 Replaced with LayoutGroup.
2266 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2267 expectedResultSize and defaultTableName fields which are needed for
2269 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2270 type field which is needed for the list layout but will also be
2271 useful for the details layout as things progress.
2272 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2273 Make class abstract. Remove the unnecessary
2274 getFormattingHorizontalAlignment method. Add setFormatting method.
2276 2011-06-16 Ben Konrath <ben@bagu.org>
2278 Add scripts for building and installing war.
2280 These will help when updating OnlineGlom but they're also good
2281 supplemental documentation of the build and deployment proceeding.
2283 * utils/build-onlineglom-war.sh: New file.
2284 * utils/install-onlineglom-war.sh: New file.
2286 2011-06-16 Ben Konrath <ben@bagu.org>
2288 Create wrapper class to create consistent log messages.
2290 I wrapped methods in the Log class of gwt-log to add the method names
2291 from the servlet and create consistent formatting of the document title
2292 and table names in the log messages.
2294 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2295 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2296 log methods to use methods from wrapped Log class.
2298 2011-06-16 Ben Konrath <ben@bagu.org>
2300 Remove superfluous conditional return.
2302 Thanks to Murray Cumming for pointing this out!
2304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2306 2011-06-15 Ben Konrath <ben@bagu.org>
2308 Return an ArrayList of LayoutGroups for the Details layout.
2310 This corrects a problem with the details layout as it can have more
2311 than one top level LayoutGroup.
2313 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2314 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2315 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2316 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2317 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2318 with ArrayList of LayoutGroups for the details view layout.
2319 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2320 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2321 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2322 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2323 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2324 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2326 2011-06-14 Ben Konrath <ben@bagu.org>
2328 Use cast_dynamic method to determine the libglom LayoutItem type.
2330 This is better than finding the LayoutItem type by using the string
2331 returned from the get_part_type_name() method.
2333 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2335 2011-06-14 Ben Konrath <ben@bagu.org>
2337 Add method names to log entries in the servlet.
2339 This helps when tracking down deployment problems.
2341 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2343 2011-06-14 Ben Konrath <ben@bagu.org>
2345 Add data to the DetailsView using a hard-coded primary key value.
2347 The layout and functionality of the DetailsView is not complete. This
2348 is just a checkpoint so the patch doesn't get too big.
2350 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2351 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2352 Add getDetailsData() servlet method.
2353 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2354 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2355 LayoutFields are added to the DetailsView.
2356 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2357 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2358 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2359 take the string for the title instead of the object.
2360 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2361 Add implementation getDetailsData() along with some private helper
2363 * src/main/webapp/style.css: Add padding to details-data class. Add a
2364 details-label class with the same padding as the details-data class.
2366 2011-06-03 Ben Konrath <ben@bagu.org>
2368 Use presenter.goTo() to change to the DetailsPlace.
2370 This will make things easier when we need to open the DetailsView with
2371 data specific to the row that was clicked.
2373 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2375 2011-06-02 Ben Konrath <ben@bagu.org>
2377 Add CSS file from mockups.
2379 I'm adding this now because it's going to be useful to have when
2380 developing the DetailsView. The TableSelectionView and ListView aren't
2383 * src/main/webapp/OnlineGlom.html:
2384 * src/main/webapp/style.css:
2386 2011-06-02 Ben Konrath <ben@bagu.org>
2388 Use String.isEmpty() to check for empty string.
2390 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2392 2011-06-02 Ben Konrath <ben@bagu.org>
2394 Display main layout group titles in the DetailsView.
2396 This is the start of the DetailsActivity/DetailsView implementation.
2398 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2399 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2400 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2401 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2402 Get the layout information for the details view from the server and set
2403 the main layout group titles.
2404 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2405 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2406 Add addLayoutGroup() and addLayoutField() methods. This are just
2407 temporary methods for creating the the details view that will change
2409 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2410 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2412 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2413 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2414 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2415 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2416 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2417 Data Transfer Objects that mimic the libglom object structure. These are
2418 used for transferring the details layout but could also be used for
2419 transferring the list layout.
2421 2011-05-27 Ben Konrath <ben@bagu.org>
2423 Reset the AuthenticationPopup when clearing the ListView.
2425 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2427 2011-05-27 Ben Konrath <ben@bagu.org>
2429 Fix problem with onlineglom.properties file loading.
2431 The old way worked in Eclipse but not on the server. Loading the
2432 onlineglom.properties file now works in Eclipse and on the server.
2434 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2436 2011-05-24 Ben Konrath <ben@bagu.org>
2438 Update gwt-log from 3.1.0 to 3.1.2.
2440 Gwt-log 3.1.0 has been marked as depreciated.
2444 2011-05-24 Ben Konrath <ben@bagu.org>
2446 Add comment to ListActivity.goTo() method.
2448 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2450 2011-05-24 Ben Konrath <ben@bagu.org>
2452 Remove FIXME in convertGdkColorToHtmlColour()
2454 The Gdk::Color value returned by libglom is 16-bits per channel on both
2455 64 and 32-bit platforms.
2457 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2459 2011-05-19 Ben Konrath <ben@bagu.org>
2461 Improve performance of initial ListView load.
2463 I removed a round trip to the server for getting the default table name
2464 and then requesting information about that table. This also removes a potential
2465 problem with the table change handler not being setup in time to receive the
2466 table change event from the ListActivity.
2468 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2469 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2470 getDefaultLayoutListTable() method. Improve comments.
2471 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2472 getDefaultLayoutListTable() method instead of firing a table change
2473 event to get the table to load.
2474 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2475 implementation of getDefaultLayoutListTable() method.
2476 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2479 2011-05-19 Ben Konrath <ben@bagu.org>
2481 Override toDebugString() in TableChangeEvent.
2483 This is useful to have for debugging.
2485 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2487 2011-05-19 Ben Konrath <ben@bagu.org>
2489 Add a "Back to List" link when at the DetailsPlace.
2491 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2492 Populate the CellTable based on the selected table of the ListBox if
2493 it's set otherwise use the default table. This allows the "Back to
2495 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2496 Remove Place from constructors. Add a setPlace() method. Add
2497 goToPlace() method. Set class as presenter for TableSelectionView.
2498 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2499 Use the same TableSelectionActivity when switching between the List and
2501 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2502 Subclass the new HasSelectableTablePlace. This removes some duplicate
2504 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2505 New class to represent Places that display the TableSelectionView.
2506 * src/main/java/org/glom/web/client/place/ListPlace.java:
2507 Subclass the new HasSelectableTablePlace. This removes some duplicate
2509 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2510 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2511 Add Presenter interface. Add setBackLinkVisible() method. Add
2512 setBackLink() method.
2514 2011-05-18 Ben Konrath <ben@bagu.org>
2516 Enable the "Details" buttons.
2518 Right now only an empty details view is displayed.
2520 * src/main/java/org/glom/web/client/ClientFactory.java:
2521 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2522 Add DetailsView to ClientFactory.
2523 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2524 A basic activity for the details view.
2525 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2526 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2528 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2529 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2531 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2532 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2533 unnecessary super() in constructor.
2534 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2535 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2536 really shouldn't create a new TableSelectionActivity for both the ListPlace
2537 and the DetailsPlace so this should be considered a temporary solution.
2538 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2539 New file. Represents a URL for the details view.
2540 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2541 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2542 A basic details view interface and implementation.
2543 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2544 Enable the "Details" buttons.
2546 2011-05-12 Ben Konrath <ben@bagu.org>
2548 Use a LayoutPanel with multiple display areas for main layout.
2550 This is mostly a refactor in that there are no changes from the user
2551 point of view. These changes are required so that we can swap out the list view
2552 with the details view when the user clicks the "Details" button.
2554 * src/main/java/org/glom/web/client/ClientFactory.java:
2555 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2556 OnlineGlomView. Add TableSelectionView, ListView and
2557 AuthenticationPopup.
2558 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2559 for main layout. Add display regions for main activities. Add
2560 activity manager for for main activities.
2561 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2562 file from parts of the deleted OnlineGlomActivity.
2563 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2564 New file from parts of the deleted OnlineGlomActivity.
2565 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2566 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2567 New files for app wide table change event.
2568 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2569 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2570 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2571 Activity mappers for the main activities replace the deleted app-wide
2573 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2574 Fix a spelling error in he comment.
2575 * src/main/java/org/glom/web/client/ui/ListView.java:
2576 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2577 Renamed from LayoutListView and modified for MVP. This still not a
2578 proper dumb view as prescribed by the MVP pattern but it works for now.
2579 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2580 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2581 New widget stripped out of the deleted OnlineGlomView.
2582 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2583 Remove hack that is fixed by this patch.
2585 2011-05-06 Ben Konrath <ben@bagu.org>
2587 Rename OnlineGlomPlace to ListPlace.
2589 The only change besides the rename is that url will now display #list
2590 instead of #Document.
2592 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2593 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2594 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2595 * src/main/java/org/glom/web/client/place/ListPlace.java:
2596 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2598 2011-05-06 Ben Konrath <ben@bagu.org>
2600 Use Presenter for app navigation.
2602 This is the proper way to deal with Place (URL) changes with the MVP
2605 * src/main/java/org/glom/web/client/ClientFactory.java:
2606 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2607 PlaceHistoryMapper and PlaceHistoryHandler.
2608 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2609 PlaceHistoryMapper and PlaceHistoryHandler.
2610 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2611 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2612 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2613 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2614 Add Presenter interface and setPresenter methods. Rename addHyperLink
2615 to addDocumentLink taking only the document title as a parameter.
2617 2011-04-14 Ben Konrath <ben@bagu.org>
2619 Prompt for db username/password if they haven't been set.
2621 This is implemented with a popup widget that is contained within the
2622 OnlineGlomView and managed by the OnlineGlomActivity.
2624 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2625 methods for checking and setting the database username and password.
2626 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2627 new methods for checking and setting the database username and
2629 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2630 Display authentication popup if the JDBC connection to the database
2631 has not been authenticated.
2632 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2634 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2635 for dealing with the authentication popup.
2636 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2637 Implement the methods for dealing with the authentication popup.
2638 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2639 try to executed queries if the database connection hasn't been
2640 authenticated. Implement methods for checking and setting the
2641 database username and password.
2643 2011-04-12 Ben Konrath <ben@bagu.org>
2645 Make log messages a little clearer.
2647 Add a dash betweeen the document title and the table name.
2649 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2651 2011-04-12 Ben Konrath <ben@bagu.org>
2653 Protect against NPEs when cleaning up database resources.
2655 While this isn't strictly necessary because the exception is caught,
2656 not protecting against the NPEs makes it harder to find the real error
2659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2661 2011-04-12 Ben Konrath <ben@bagu.org>
2663 Move configuration of the servlet to the constructor.
2665 The servlet will be initialized even if the database authentication
2666 information is not set or correct. I still need to add the UI for prompting
2667 the user for the authentication information when it's required.
2669 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2670 javadocs for getDocumentTitles() method.
2671 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2672 Set error message when RPC fails.
2673 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2674 glom files directory from the configuration file. Try to set the
2675 database authentication information for the specific document if it's
2676 set and works otherwise try to use the global authentication
2677 information set for the directory.
2678 * src/main/resources/onlineglom.properties: Moved from
2679 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2680 Added detailed comments for the new keys.
2682 2011-04-11 Ben Konrath <ben@bagu.org>
2684 Remove unnecessary @Override in DocumentSelectionViewImpl.
2686 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2688 2011-04-11 Ben Konrath <ben@bagu.org>
2690 Remove center alignment in DocumentSelectionView.
2692 The title element is still centred but the document titles and bottom
2693 sentence are both left-aligned.
2695 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2697 2011-04-11 Ben Konrath <ben@bagu.org>
2699 Change 'Demo' naming convention to 'Document'.
2701 This is just a rename refactor with no functional changes to the code.
2703 * src/main/java/org/glom/web/client/ClientFactory.java:
2704 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2705 * src/main/java/org/glom/web/client/OnlineGlom.java:
2706 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2707 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2708 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2709 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2710 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2711 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2712 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2713 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2714 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2715 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2717 2011-04-08 Ben Konrath <ben@bagu.org>
2719 Remove FIXME from safeLongToInt() method.
2721 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2724 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2726 2011-04-08 Ben Konrath <ben@bagu.org>
2728 Display an error if no glom documents are found in the specified directory.
2730 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2731 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2732 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2735 2011-04-08 Ben Konrath <ben@bagu.org>
2737 Add copyright header to one more file ... oops.
2739 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2741 2011-04-08 Ben Konrath <ben@bagu.org>
2743 Add copyright header to files without it.
2745 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2746 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2747 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2748 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2749 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2750 * src/main/java/org/glom/web/shared/GlomField.java:
2752 2011-04-08 Ben Konrath <ben@bagu.org>
2754 Add support for accessing multiple glom documents in the servlet.
2756 This completes the demo selection functionality.
2758 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2759 document title to methods.
2760 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2761 document title to methods.
2762 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2763 Set browser window title when the activity starts. Correct name of
2764 document title variable.
2765 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2766 Set browser window title when the activity starts. Set the table
2767 selector change handler after table selector has been set. Clear the
2768 OnlineGlomView when the activity has been stopped.
2769 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2770 document title as the place token. Use "#Document:" instead of
2771 "#OnlineGlomPlace:" in the URL.
2772 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2773 Change heading to "Online Glom"
2774 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2775 document title in RPC methods.
2776 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2777 setDocumentTitle() method. Add clear() method.
2778 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2779 setDocumentTitle() method. Implement clear() method which removes the
2780 change handler on the ListBox, clears the ListBox and clears the
2782 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2783 Implement methods with document title. Keep track for the configured
2784 glom documents and their corresponding JDBC configurations in a hash
2785 table. This information is retrieved using the document title as the
2786 key in the hash table.
2787 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2788 document title field as it's no longer needed.
2790 2011-04-08 Ben Konrath <ben@bagu.org>
2792 Update the Eclipse JDT configuration.
2794 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2795 methods. Automatically add the copyright header to new files.
2797 2011-04-05 Ben Konrath <ben@bagu.org>
2799 Add new page for demo selection.
2801 This patch adds all the components required to view and start an
2802 OnlineGlom demo by clicking on the desired hyperlink. The user is
2803 able to return to the demo selection page with the browser's back
2804 button. I still need to modify the servlet to work with multiple
2805 documents so all demo links will load the file defined in the
2806 OnlineGlom.properties.
2808 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2809 This is only useful during development so we don't need to save it.
2810 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2811 get a reference to the DemoSelectionView.
2812 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2813 method to get a reference to the DemoSelectionView.
2814 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2815 default view to DemoSelectionView.
2816 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2817 to get glom document titles for glom files in a hard-coded directory.
2818 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2819 method to get glom document titles for glom files in a hard-coded
2821 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2822 Presenter for DemoSelectionView.
2823 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2824 for DemoSelectionView.
2825 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2826 Update for DemoSelectionView.
2827 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2828 Basic 'Place' implementation for the DemoSelectionView.
2829 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2830 The interface for the DemoSelectionView.
2831 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2832 The implementation of the DemoSelectionView.
2833 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2834 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2835 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2836 implementation of method to get glom document titles for glom files
2837 in a hard-coded directory.
2838 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2839 on longer being used.
2840 * src/main/webapp/glom.png: Glom logo.
2842 2011-04-05 Ben Konrath <ben@bagu.org>
2844 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2846 This is the forth and final commit of a refactor that will allow
2847 OnlineGlom to be used with multiple documents.
2849 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2850 Move RPC code from OnlineGlomViewImpl to this class.
2851 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2853 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2854 RPC code to the presenter class (the P in MVP).
2856 2011-04-04 Ben Konrath <ben@bagu.org>
2858 Start moving the existing OnlineGlom code to MVP.
2860 This work is based on the GWT MVP framework that is documented here:
2862 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2864 This is the third commit of a refactor that will allow OnlineGlom to
2865 be used with multiple documents.
2867 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2868 Interface for client factory which is used to get instances of various
2869 classes throughout the app.
2870 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2871 Implementation of client factory.
2872 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2873 initialize the MVP framework.
2874 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2875 New file. Activity manager for the main container widget. This is the
2877 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2878 Maps place (URL) to its corresponding activity.
2879 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2880 New file. This is just a place holder for a generated file.
2881 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2882 New file. Represents the URL for the main Online Glom app.
2883 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2884 for changes in LayoutListViewImpl.
2885 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2886 interface for View. Move code to OnlineGlomViewImpl class.
2887 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2888 file. Implementation of OnlineGlomView.
2889 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2890 Place resources. Use ClientFactoryImpl by default.
2892 2011-04-04 Ben Konrath <ben@bagu.org>
2894 Move View classes to their own package.
2896 This is the second commit of a refactor that will allow OnlineGlom to
2897 be used with multiple documents.
2899 * src/main/java/org/glom/web/client/OnlineGlom.java:
2900 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2901 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2903 2011-04-02 Ben Konrath <ben@bagu.org>
2905 Move UI code from the main module to its own class.
2907 This is the first commit of a refactor that will allow OnlineGlom to be
2908 used with multiple documents.
2910 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2911 references to OnlineGlom to OnlineGlomView.
2912 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2913 OnlineGlomView and instantiate it here.
2914 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2915 represents the main OnlineGlomView with one document.
2917 2011-04-01 Ben Konrath <ben@bagu.org>
2919 Fix formatting of gwt.xml and add DTD.
2921 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2923 2011-03-30 Ben Konrath <ben@bagu.org>
2925 Propperly convert gdkColor string to html colour string.
2927 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2929 2011-03-28 Ben Konrath <ben@bagu.org>
2931 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2933 This implementation matches
2934 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2935 readable and is not tied to Swig.
2937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2939 2011-03-28 Ben Konrath <ben@bagu.org>
2941 Use read-only checkboxes for boolean field types.
2943 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2944 in the CellTable based on the field type. It currently only
2945 distinguishes between boolean and text columns but I'll need to add
2946 support for more types.
2947 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2948 column type in the ColumnInfo object. Add method to convert between the
2949 glom field type enum in ColumnInfo and the glom field type in libglom.
2950 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2952 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2953 getting and setting booleans.
2955 2011-03-25 Ben Konrath <ben@bagu.org>
2957 Don't get the Date twice from the ResultSet.
2959 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2961 2011-03-25 Ben Konrath <ben@bagu.org>
2963 Cleanup code in the servlet.
2965 * TODO: Remove item about row count. Add item about testing row count
2966 query with large number of rows.
2967 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2968 spelling mistakes, change method parameter to be consistent with
2971 2011-03-25 Ben Konrath <ben@bagu.org>
2973 Add server side logging with the gwt-log library.
2975 * .gitignore: Ignore the log file we're now producing.
2976 * TODO: Add a couple TODO item for logging.
2977 * pom.xml: Add gwt-log and log4j as a dependency.
2978 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2979 logging of errors, warnings and some important info.
2980 * src/main/resources/log4j.properties: New file to configure log4j.
2982 2011-03-24 Ben Konrath <ben@bagu.org>
2984 Add a disable button for the Details view.
2986 * src/main/java/org/glom/web/client/LayoutListView.java:
2988 2011-03-22 Ben Konrath <ben@bagu.org>
2990 Use a count query to get the number of rows for the list view pager.
2992 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2994 2011-03-22 Ben Konrath <ben@bagu.org>
2996 Add more TODO information about CellTable pager positioning.
3000 2011-03-19 Ben Konrath <ben@bagu.org>
3002 Add TODO item about CellTable pager positioning.
3006 2011-03-18 Ben Konrath <ben@bagu.org>
3008 Remove unneeded GlomFieldColumn class.
3010 This is just a small code cleanup.
3012 * src/main/java/org/glom/web/client/LayoutListView.java:
3014 2011-03-18 Ben Konrath <ben@bagu.org>
3016 Use cursor mode in the query that gets data for the list view.
3018 I still need to fix the potential memory problem when getting the row
3019 count for the list view.
3021 * TODO: Add note about testing memory usage with large data sets. Add
3022 item about fixing row counting with large data sets.
3023 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
3024 PostgreSQL JDBC driver into cursor mode when getting data for the
3027 2011-03-15 Ben Konrath <ben@bagu.org>
3029 Remove the GWT Container from the Eclipse build classpath.
3031 The GWT dependencies are set by Maven so this isn't needed.
3035 2011-03-15 Murray Cumming <murrayc@murrayc.com>
3037 Added some earlier mockups to git, but not to the tarball dist.
3039 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
3040 Openismus. These hopefully show how we might structure the HTML so that
3041 it can be styled easily with CSS. However, we probably need to adapt them
3042 for the CSS structure that GWT dictates for common widgets.
3044 2011-03-14 Ben Konrath <ben@bagu.org>
3046 Locate OnlineGlom.properties using the ServletContext.
3048 This is required to be able to locate the file in the deployed servlet.
3050 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3051 Configure the database and glom document in in a helper method so
3052 that the ServletContext can be used to locate OnlineGlom.properties.
3053 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
3054 src/main/webapp. This is the proper location for .properites files.
3056 2011-03-12 Ben Konrath <ben@bagu.org>
3058 Add note to README about why we're compiling down to obfuscated JavaScript.
3062 2011-03-11 Ben Konrath <ben@bagu.org>
3064 Use properties file to configure servlet.
3066 This allows people to change the glom file path, db username and db
3067 password without recompiling the code.
3069 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3070 * src/main/webapp/OnlineGlom.properties:
3072 2011-03-11 Ben Konrath <ben@bagu.org>
3074 Use table fields in layout list view if the layout list is not defined.
3076 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3077 Manually create a LayoutFieldVector for the query builder using the
3078 table fields when a layout list is not defined in the glom file.
3080 2011-03-11 Ben Konrath <ben@bagu.org>
3082 Only show FIXME string for images when there's an image.
3084 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
3085 in this change are some small code cleanups.
3087 2011-03-11 Ben Konrath <ben@bagu.org>
3089 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
3091 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3093 2011-03-11 Ben Konrath <ben@bagu.org>
3095 Correctly set the index of the default table.
3097 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3098 Correctly set the index of the default table. Add commented out example
3101 2011-03-10 Ben Konrath <ben@bagu.org>
3103 Add comment to pom.xml about the previous change.
3105 * pom.xml: Add comment about the deployment issue so that it's obvious
3106 why java-libglom is set to the provided scope.
3108 2011-03-10 Ben Konrath <ben@bagu.org>
3110 Change java-libglom dependency from compile to provided in pom.xml.
3112 Since java-libglom uses jni it can only be loaded once and therefore
3113 must be placed in $CATALINA_HOME/lib and not included in each war.
3114 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
3115 More information about this issue can be found in the Tomcat 6 release
3116 notes in the "JNI Based Applications" section:
3118 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
3120 * README: Remove note about this issue. Deployment info should really
3121 be on the wiki anyway so I'll add it right now.
3122 * pom.xml: Change java-libglom dependency from compile to provided so
3123 that it's copied in to the packaged war.
3125 2011-03-09 Ben Konrath <ben@bagu.org>
3127 Change to using a neutral locale for currency, date and time formatting.
3129 This solves the problem of currency values being represented without a
3130 space between the currency code and the number (e.g. "EUR5.89" is now
3131 represented as "EUR 5.89"). More work is required when we implement
3132 a locale preference setting.
3134 * TODO: Add note about currency formatting issues with different
3136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3137 to using the neutral ROOT locale.
3139 2011-03-09 Ben Konrath <ben@bagu.org>
3141 Add support for currency codes that are not ISO 4217 codes.
3143 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3144 the currency code defined in the glom file when it's not 3 characters
3145 long or when Java doesn't recognize the string as an ISO 4217 code.
3147 2011-03-08 Ben Konrath <ben@bagu.org>
3149 Remove test classes, launch configurations and configuration.
3151 The test stuff was getting in the way when creating the war. To make
3152 the war file you can now do 'mvn clean package'. The packaged war file
3153 will be in the target directory.
3155 * .classpath: Remove unused classpathentry for tests and i18n.
3156 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
3157 property. Don't run test or i18n goals when packaging the war.
3158 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
3163 * OnlineGlomTest-dev.launch:
3164 * OnlineGlomTest-prod.launch:
3165 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
3166 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
3168 2011-03-07 Ben Konrath <ben@bagu.org>
3170 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
3172 These fixes allow me to use 'mvn deploy' to create the war file.
3174 * .classpath: This generated config has been updated by Eclipse. This
3175 change was probably triggered by me updating from Eclipse 3.6.1 to
3177 * .gitignore: Add entry to ignore the directory
3178 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
3179 * .project: The generated config has been updated by Eclipse. This
3180 change was probably triggered by me updating from Eclipse 3.6.1 to
3182 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3183 so that Eclipse doesn't complain
3184 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3185 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3186 'tests' directory to 'client' directory. This is the new
3187 gwt-maven-plugin convension.
3188 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3189 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3191 2011-03-07 Ben Konrath <ben@bagu.org>
3193 Add support for horizontal alignment in the LayoutList columns.
3195 * TODO: Remove item about horizontal alignment. Add item about
3196 improvements to ColumnInfo.
3197 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3198 alignment on the columns. Use ColumnInfo RPC object get the column
3199 title and horizontal alignment.
3200 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3201 LayoutListView creation with ColumnInfo RPC object.
3202 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3203 a ColumnInfo object for every LayoutList columnn. Convert the
3204 FieldFormatting.HorizontalAlignment to the correct
3205 ColumnnInfo.HorizontatlAlignment with the new
3206 getColumnInfoHorizontalAlignment helper method.
3207 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3208 to encapsulate column information like alignment and title. This
3209 could be used to set the colour instead of on a per cell field basis.
3210 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3211 column title storage and retrieval with ColumnInfo.
3213 2011-03-04 Ben Konrath <ben@bagu.org>
3215 Add support for column sorting.
3217 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3218 AsynDataProvider to be an anonymous inner class. Use new
3219 getSortedTableData RPC method when column sort is requested. Set all
3220 columns sortable and add an AsyncHandler to activate sorting in the
3222 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3223 method getSortedTableData(). Cleanup other method signatures.
3224 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3225 new method getSortedTableData(). Cleanup other method signatures.
3226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3227 Implement getSortedTableData() and getTableData() methods by using a
3228 private helper method with the appropriate parameters filled in. Use
3229 user supplied sort clause when supplied, otherwise fall back to
3230 sorting by the primary key. Move destroy() method to be underneath
3231 constructor for readability. Cleanup comments.
3233 2011-03-03 Ben Konrath <ben@bagu.org>
3235 Add support for colour text and colour backgrounds to the layout list cells.
3237 Only the cell backgrounds are coloured which leaves a gap between the
3238 cells that isn't coloured. I need to figure out a way to set
3239 'style=background-colour:' on the whole column rather than just&n