1 2012-01-03 Murray Cumming <murrayc@murrayc.com>
3 *View: Remove unused imports.
5 * src/main/java/org/glom/web/client/ui/DetailsView.java:
6 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
7 * src/main/java/org/glom/web/client/ui/ListView.java:
8 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
9 Remove unused imports, as suggested by Eclipse.
11 2012-01-02 Murray Cumming <murrayc@murrayc.com>
13 Move the *View::Presenter types, and some API into one base View.
15 * src/main/java/org/glom/web/client/ui/DetailsView.java:
16 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
17 * src/main/java/org/glom/web/client/ui/ListView.java:
18 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
19 Presenter, setPresenter() and clear() into a shared base interface,
20 to avoid the unnecessary duplicate Presenter types and to more clearly
21 show how the *Views share the same structure, even if they are not
24 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
25 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
27 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
28 * src/main/java/org/glom/web/client/activity/ListActivity.java:
29 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
31 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
34 Feel free to revert this if there is a good reason for the duplicate
37 2012-01-02 Murray Cumming <murrayc@murrayc.com>
39 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
41 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
42 a class member instead of a local variable in the method.
43 This lets us use it to get the view instances, for use in tests.
44 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
45 beforeOnlineGlom(): Test some more details of the initial view.
46 Again, this is not very useful.
48 To really test gwt-glom we will need to start a local postgresql
49 instance with local data, like the Glom tests in C++.
51 2012-01-02 Murray Cumming <murrayc@murrayc.com>
53 pom.xml: Mention the LGPL license.
55 * pom.xml: Add a licenses section.
56 * COPYING.LESSER: Move this to COPYING, which
57 previously contained the GPL. But gwt-glom is all LGPL.
59 2012-01-02 Murray Cumming <murrayc@murrayc.com>
61 Add project information to README and pom.xml.
63 * README: Add a brief description and mention some mvn
65 * pom.xml: This extra information shows up in mvn site
68 2011-01-02 Murray Cumming <murrayc@murrayc.com>
70 Use the latest java-libglom version.
72 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
74 2012-01-01 Murray Cumming <murrayc@murrayc.com>
76 GwtTestOnlineGlom: Test a little more.
78 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
79 protected rather than private, as suggested by the gwt-test-utils
81 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
82 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
83 Test the initial visibility of the panels.
85 However, this is not a very useful test.
86 And I wonder how we should generally test using this idea for an
87 activity/places app like ours where the real changes happen implicitly
88 based on the history token/URL.
90 2012-01-01 Murray Cumming <murrayc@murrayc.com>
92 Slight modification to *Mapper comments.
94 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
96 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
98 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
100 Remove comments mentioning GIN because they are just copied from
101 the example code and are apparently not helpful:
102 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
103 Also change the mention of a class that is only in the example code.
105 2012-01-01 Murray Cumming <murrayc@murrayc.com>
107 GwtTestOnlineGlom test: Minor changes.
109 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
110 Avoid the long qualified class name and modify the comment
111 because it is now obvious to me that the mocked class is the only
112 custom one created via GWT.create().
114 2012-01-01 Murray Cumming <murrayc@murrayc.com>
116 Tests: Added the beginnings of a test using gwt-test-utils.
118 * pom.xml: Add dependencies on gwt-test-utils and easymock.
119 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
120 which tells gwt-test-utils what class will be tested.
121 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
122 Add a simple (but empty) test case. One class, used by the OnlineGlom
123 class, is mocked so that it can be created. However, I am not sure
124 why only this class needs to be mocked.
126 Note that mockito seems more popular, and clearer, than easymock,
127 but I have not got that working yet. It might be a matter of the
130 This test is run during mvn integration-test.
132 2011-12-31 Murray Cumming <murrayc@murrayc.com>
134 Tests: Use junit4-style syntax instead of junit3-style.
136 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
137 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
138 * src/test/java/org/glom/web/shared/DataItemTest.java:
139 Use the @Test annotation rather than relying on the test*() prefix.
140 Also no longer implement TestCase, to avoid triggering support for
141 the junit3-way, which stops the annotations from working.
142 Change the imports from import junit.framework.* to
143 import org.junit.*, which is apparently the new way.
145 2011-12-31 Murray Cumming <murrayc@murrayc.com>
147 Added a test for ListPlace token parsing and creation.
149 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
150 This is much the same as DetailsPlaceTest.
152 I wonder how we could test the other parts of the *Place API.
154 2011-12-30 Murray Cumming <murrayc@murrayc.com>
156 DetailsPlace test: Also test getToken() and recreation via getPlace().
158 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
159 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
160 recreate it, testing the recreated DetailsPlace for the same parameter
163 2011-12-30 Murray Cumming <murrayc@murrayc.com>
165 Use the surefire-report plugin.
167 * pom.xml: This generates a HTML report about the tests in
168 target/site/surefire-report.html
169 when you do mvn surefire-report:report. It seems to be popular/normal.
171 2011-12-30 Murray Cumming <murrayc@murrayc.com>
173 Added a test for DetailsPlace.
175 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
176 Test the getPlace() token parsing.
178 2011-12-30 Murray Cumming <murrayc@murrayc.com>
180 Added a first unit test.
182 * pom.xml: Add a test goal, and a dependency on junit in that scope.
183 * src/test/java/org/glom/web/shared/DataItemTest.java:
184 This is a silly test but it is just to get things started. Note that
185 maven/junit finds the test because it looks in src/test by default.
187 2011-12-22 Ben Konrath <ben@bagu.org>
189 Change charsetName to "UTF-8" when replacing line breaks.
191 JavaScript requires the charsetName to be "UTF-8". CharsetName values
192 that work in Java (such as "UTF8") will not work when compiled to
195 This fixes a problem with multi-line details view fields that have hard
196 line breaks. The "License Text" field on this page demonstrates the
199 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
201 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
203 2011-12-22 Ben Konrath <ben@bagu.org>
205 Fix another bug with related list navigation.
207 I've tested all the navigation buttons in all of the related lists
208 so things should be good now.
210 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
212 2011-12-22 Ben Konrath <ben@bagu.org>
214 Fix a crasher when refreshing the list view with the default table.
216 This crash will also happen when loading the list view with the default
217 table from a link or bookmark.
219 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
220 to the main document selection page when the document id hasn't been
222 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
223 the main document selection page when the document id hasn't been
225 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
226 values for the details place when the document id hasn't been set.
227 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
228 values for the list place when the document id hasn't been set.
230 2011-12-21 Ben Konrath <ben@bagu.org>
232 Protect against NPE when glom.document.locale is not in config.
234 This patch protects against an NPE when glom.document.locale is not in
235 the config file. This NPE will also happen if glom.document.locale is
238 The patch also updates the error message to display the class name when
239 the getMessage() returns null. This was happening when the NPE was
240 thrown and I had "Configuration Error: null". If an NPE is encountered
241 with this patch, "Configuration Error: NullPointerException " will be
244 This commit closes this bug:
246 https://bugzilla.gnome.org/show_bug.cgi?id=666669
248 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
250 2011-12-20 Murray Cumming <murrayc@murrayc.com>
252 Rename onlineglom.properties to onlineglom.properties.sample.
254 * src/main/resources/onlineglom.properties: Rename to:
255 * src/main/resources/onlineglom.properties.sample:
256 * src/main/resources/README: And add this file explaining that people
257 should rename it back when deploying.
259 2011-12-20 Murray Cumming <murrayc@murrayc.com>
261 Allow choosing the translation in the .properties file.
263 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
264 init(): Read a glom.document.locale value from the configuration file
265 and call Glom's TransatableItem::set_current_locale() method.
266 * src/main/resources/onlineglom.properties: Add a commented-out
267 example of this new setting.
269 It would be better to add &lang=de_DE to the URL, but the current
270 libglom API does not allow us to do this easily. I am working on that.
272 2011-12-19 Murray Cumming <murrayc@murrayc.com>
274 Avoid a crash in parsing of token parameters.
276 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
277 ava: getTokenParams(): Do not crash if a parameter has a key but no
278 value, and ignore parameters with neither.
280 2011-12-17 Murray Cumming <murrayc@murayc.com>
282 History token building/handling: Improve use of token parameters.
284 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
285 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
286 and buildParamsToken(HashMap), for use by derived classes.
287 Make the separator private because it is no longer be needed.
288 * src/main/java/org/glom/web/client/place/DetailsPlace.java
289 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
290 instead of manual string concatenation.
291 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
292 of hardcoded indices and awkward splitting code.
293 * src/main/java/org/glom/web/client/place/ListPlace.java
294 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
295 instead of manual string concatenation.
296 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
297 of hardcoded indices and awkward splitting code.
298 This should fix bug #666420
300 2011-12-16 Murray Cumming <murrayc@murrayc.com>
302 Fix a Navgiation->Navigation typo in the code.
304 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
305 Rename processNavgiation() to processNavigation().
307 2011-12-16 Murray Cumming <murrayc@murrayc.com>
309 Fix a seperator->separator typo in the code.
311 * src/main/java/org/glom/web/client/place/DetailsPlace.java
312 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
313 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
316 2011-12-15 Ben Konrath <ben@bagu.org>
318 Cleanup some comments.
320 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
322 2011-12-14 Ben Konrath <ben@bagu.org>
324 Replace \n with <br/> for multiline text in the details view.
326 Vertical scrollbars are added when needed as well.
328 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
330 2011-12-14 Ben Konrath <ben@bagu.org>
332 Specify the font for document selection links.
334 * src/main/webapp/style.css:
336 2011-12-14 Ben Konrath <ben@bagu.org>
338 Fix bouncy CellTable while paging.
340 This doesn't currently work with related list tables in unselected
343 * src/main/java/org/glom/web/client/ui/list/ListTable.java
345 2011-12-14 Ben Konrath <ben@bagu.org>
347 Revamp the appearance of the document selection page.
349 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
350 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
351 * src/main/webapp/style.css:
353 2011-12-13 Ben Konrath <ben@bagu.org>
355 Set navigation button column to the smallest size possible.
357 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
359 2011-12-13 Ben Konrath <ben@bagu.org>
361 Change OpenButton nomenclature to NavigationButton.
363 Using NavigtionButton makes things more generic. Classes, methods and
364 variables have been changed.
366 This is a rename-only refactor.
368 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
369 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
370 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
371 Renamed from OpenButtonCell.
372 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
373 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
374 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
376 2011-12-12 Ben Konrath <ben@bagu.org>
378 Remove unnecessary String argument in RelatedListTable and ListViewTable.
380 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
381 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
382 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
383 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
385 2011-12-12 Ben Konrath <ben@bagu.org>
387 Update variable names and comments.
389 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
390 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
392 2011-12-12 Ben Konrath <ben@bagu.org>
394 Properly initialize numNonEmptyRows variable to zero.
396 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
397 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
399 2011-12-05 Ben Konrath <ben@bagu.org>
401 Add latest mockup with HTML tables.
403 Features of this mockup:
405 -> HTML table for flowtable
406 -> HTML table for flowtable column
407 -> Example of how related lists would look
408 -> Not using text entries for data items
410 The current version of Online Glom doesn't use HTML tables for the
413 This mockup has been sent to the glom-devel mailing list but it's good
414 to have it here as well.
416 * mockups/details-view-html-tables.html:
418 2011-12-05 Ben Konrath <ben@bagu.org>
420 Remove unnecessary getPrimaryKeyField() method.
422 getPrimaryKeyFieldForTable(String) has been renamed to
423 getPrimaryKeyField(String).
425 * src/main/java/org/glom/web/server/database/DBAccess.java:
426 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
427 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
429 2011-12-05 Ben Konrath <ben@bagu.org>
431 Add string representation of TypedDataItem value to conversion error message.
433 * src/main/java/org/glom/web/server/Utils.java: Logging the error
434 message was extracted into its own method to avoid duplication.
436 2011-12-05 Ben Konrath <ben@bagu.org>
438 Add type checking to navigation primary key value creation.
440 Create navigation primary key only if the expected type from the Glom
441 document matches the type returned by the SQL query.
443 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
445 2011-12-05 Ben Konrath <ben@bagu.org>
447 Rename a couple of variables in RelatedListNavigation.
449 This is a rename-only refactor.
451 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
453 2011-12-05 Ben Konrath <ben@bagu.org>
455 Move getListLayoutGroup() into getListViewLayoutGroup().
457 This removes getListLayoutGroup(). It was only being called by
458 getListViewLayoutGroup().
460 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
462 2011-12-05 Ben Konrath <ben@bagu.org>
464 Remove check for LayoutItem_Portal in list table method.
466 This check is no longer necessary because the method isn't being used
467 to create the LayoutItemPortal DTO.
469 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
471 2011-12-05 Ben Konrath <ben@bagu.org>
473 Properly support related list navigation.
475 Navigation from the "Repository Analyzer -> Package Scans ->
476 Dependencies" related table wasn't working because the primary key for
477 related tables wasn't being set properly. This commit fixes the
480 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
481 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
482 doesn't set the primary key properly for related list tables.
483 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
484 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
485 useful for getting the primary key for list view tables and for related
487 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
488 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
489 Move code to set the primary key for the table from the abstract
490 ListDBAccess class to ListViewDBAccess as it's only correct for list
492 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
493 Properly add primary key to related list tables.
495 2011-12-02 Ben Konrath <ben@bagu.org>
497 Properly set the horizontal alignment of fields.
499 This fix is for both the list tables and the details view.
501 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
502 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
503 to set the horizontal alignment of fields.
505 2011-12-02 Ben Konrath <ben@bagu.org>
507 Display currency codes in the details view.
509 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
511 2011-12-02 Ben Konrath <ben@bagu.org>
513 Avoid duplicate JNI call.
515 JNI is not as efficient as pure Java and this is an easy (and small)
518 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
519 Use previously retrieved value for whereClauseToTableName instead of
522 2011-12-02 Ben Konrath <ben@bagu.org>
524 Rename a couple of variables in RelatedListNavigation.
526 This is a rename-only refactor.
528 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
530 2011-12-02 Ben Konrath <ben@bagu.org>
532 Indicate clearly that a mismatched primary key type is a bug.
534 * src/main/java/org/glom/web/server/Utils.java: Change log level from
535 warning to error. Add 'This is a bug.' to message.
537 2011-12-02 Ben Konrath <ben@bagu.org>
539 Update / fix some comments.
541 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
543 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
545 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
546 Fix comments. Add some TODOs.
548 2011-12-02 Ben Konrath <ben@bagu.org>
550 Enable navigation to details view with string primary key from related list.
552 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
553 Create a text primary key value when return type of result is
554 java.sql.Types.VARCHAR.
556 2011-12-02 Ben Konrath <ben@bagu.org>
558 Use checkboxes for booleans in the details view.
560 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
562 2011-12-01 Ben Konrath <ben@bagu.org>
564 Improve performance of related list height calculation.
566 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
567 Put code to calculate the expected height in a static initializer so
568 that that it's only called once.
570 2011-12-01 Ben Konrath <ben@bagu.org>
572 Show related list tables in notebooks (again).
574 Calculate the height of the related list tables so the Notebook can be
575 set the correct height. The height of the related list table is also needed by
576 FlowTable to be able decide how to create the layout.
578 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
579 and set the Portal height based on the height of the related list
580 table and the Portal container.
581 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
582 Add method to calculate the height of the related list tables.
583 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
584 * src/main/webapp/style.css: Add css class for Pager. This is needed to
585 calculate the height of the Pager widget.
587 2011-12-01 Ben Konrath <ben@bagu.org>
589 Use CellTable API for table property instead of setting style on Element.
591 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
593 2011-12-01 Ben Konrath <ben@bagu.org>
595 Make ListViewTable and RelatedListTable a consistent height.
597 The tables are now a consistent height regardless of the contents of
598 the table. A hidden button is added to empty rows to ensure that the
599 height of these rows will match the height of rows with data.
601 A navigation button column is now added to every table. The width of
602 the navigation column is set to 0px when a RelatedListTable shouldn't
603 have navigation buttons. This maintains the a consistent row height in
604 tables that don't show the navigation buttons.
606 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
607 navigation column when not needed.
608 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
609 arguments for navigation button to constructor of ListViewTable.
610 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
611 hidden button for empty data rows.
612 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
613 arguments for navigation button to constructor.
614 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
615 create navigation buttons. Add hideNavigationButtons() method.
616 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
617 arguments for navigation button to constructor.
619 2011-12-01 Ben Konrath <ben@bagu.org>
621 Use 'visibility: hidden' in Utils.getWidgetHeight().
623 This is better choice because hidden elements are invisible, don't
624 respond to events and are not part of the tab order. They will,
625 however, take up space which is required to be able to calculate the
626 height of the widget.
628 * src/main/java/org/glom/web/client/Utils.java:
630 2011-12-01 Ben Konrath <ben@bagu.org>
632 Use Utils.getWidgetHeight() in FlowTable.
634 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
636 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
638 2011-12-01 Ben Konrath <ben@bagu.org>
640 Put the details css class name on the correct table column.
642 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
644 2011-11-30 Ben Konrath <ben@bagu.org>
646 Update for java-libglom API change.
648 The getters and setters on FieldFormatting and NumericFormat were
649 changed to remove the 'M'.
651 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
653 2011-11-29 Ben Konrath <ben@bagu.org>
655 Only allow RelatedListTables in Portals.
657 * src/main/java/org/glom/web/client/ui/details/Portal.java:
659 2011-11-29 Ben Konrath <ben@bagu.org>
661 Only create a contents panel for Portals when title is being set.
663 * src/main/java/org/glom/web/client/ui/details/Portal.java:
665 2011-11-29 Ben Konrath <ben@bagu.org>
667 Set TabLayoutPanel height based on calculated height its widgets.
669 This is a potential fix for this bug:
671 https://bugzilla.gnome.org/show_bug.cgi?id=665133
673 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
675 2011-11-29 Ben Konrath <ben@bagu.org>
677 Align details field labels and data with the Open buttons.
679 * src/main/webapp/style.css:
681 2011-11-29 Ben Konrath <ben@bagu.org>
683 Remove unnecessary <div> in the Notebook widget.
685 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
686 method to get container FlowPanel (<div>).
687 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
688 initWidget() method directly on the TabLayoutPanel widget instead of
689 Group's container widget.
691 2011-11-29 Ben Konrath <ben@bagu.org>
693 Don't add group titles for Portals in Notebooks.
695 This reverts the previous patch and fixes a bug I introduced with
696 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
698 * src/main/java/org/glom/web/client/ui/details/Group.java:
699 * src/main/java/org/glom/web/client/ui/details/Portal.java:
701 2011-11-28 Ben Konrath <ben@bagu.org>
703 Remove unused boolean argument in Portal constructor.
707 * src/main/java/org/glom/web/client/ui/details/Group.java:
708 * src/main/java/org/glom/web/client/ui/details/Portal.java:
710 2011-11-28 Ben Konrath <ben@bagu.org>
712 Remove hack for glom 1.18 style glom files.
714 * src/main/java/org/glom/web/client/ui/details/Group.java:
715 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
716 * src/main/java/org/glom/web/client/ui/details/Portal.java:
718 2011-11-28 Ben Konrath <ben@bagu.org>
720 Use Gda Value version of primary key to log result too large error.
722 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
724 2011-11-28 Ben Konrath <ben@bagu.org>
726 Don't use TypedDataItem.getText() for Unknown types from the URL.
728 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
729 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
730 instead of getText().
731 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
732 String field and getUnknown() method.
734 2011-11-28 Ben Konrath <ben@bagu.org>
736 Log an error message when the java-libglom .so is not present.
738 The error message was being set in the exception but not logged.
740 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
742 2011-11-28 Ben Konrath <ben@bagu.org>
744 Ignore LayoutItem_CalendarPortals.
746 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
747 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
749 2011-11-28 Ben Konrath <ben@bagu.org>
751 Extract method for creating the LayoutItemPortal DTO.
753 Just breaking the code up into smaller chunks.
755 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
757 2011-11-28 Ben Konrath <ben@bagu.org>
761 This should have been added with the refactor. Oops!
763 * src/main/java/org/glom/web/shared/TypedDataItem.java:
765 2011-11-28 Ben Konrath <ben@bagu.org>
767 Create primary key value from URL string using type from Glom document.
769 See this bug, comments 19 - 25:
771 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
773 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
774 create a TypeDataItem for the primary key here when loading from a
775 URL. Show the same string for the primary key value as was received
776 from the URL string (when loading from a URL).
777 * src/main/java/org/glom/web/server/Utils.java: Update method for
778 creating the Gda Value from the TypeDataItem to properly deal with
779 creating a Gda Value based on the Glom document type for the primary
780 key value string when loading from a URL.
781 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
782 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
783 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
784 Update for changed method name.
786 2011-11-27 Ben Konrath <ben@bagu.org>
788 Rename PrimaryKeyItem to TypedDataItem.
790 The name PrimaryKeyItem suggests what the class should be used for.
791 TypedDataItem is a neutral name that describes the class better.
793 This is a rename-only refactor.
795 * src/main/java/org/glom/web/client/OnlineGlomService.java:
796 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
797 * src/main/java/org/glom/web/client/Utils.java:
798 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
799 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
800 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
801 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
802 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
803 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
804 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
805 * src/main/java/org/glom/web/server/Utils.java:
806 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
807 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
808 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
809 * src/main/java/org/glom/web/shared/NavigationRecord.java:
811 2011-11-25 Ben Konrath <ben@bagu.org>
813 Improve Gda Value conversion from PrimaryKeyItem.
815 The value from the PrimaryKeyItem is only used if its type match the
816 type from the glom document.
818 * src/main/java/org/glom/web/server/Utils.java:
820 2011-11-25 Ben Konrath <ben@bagu.org>
822 Manually check if the java-liblgom .so is visible to the JVM.
824 It seems that Tomcat has problems when a static initializer throws an
825 exception. This check is done before the first method call into
826 java-libglom so that execution doesn't continue if the .so is not
829 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
831 2011-11-25 Ben Konrath <ben@bagu.org>
833 Improve browser configuration error messages.
837 https://bugzilla.gnome.org/show_bug.cgi?id=662792
839 * src/main/java/org/glom/web/client/OnlineGlomService.java:
840 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
841 getConfigurationErrorMessage() method.
842 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
843 Get and display a specific configuration error message when no Glom
845 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
846 Implement getConfigurationErrorMessage() method. Surround configuration
847 code in the init() method with a try/catch block. This allows the
848 errors to be caught while keeping the servlet available to retrieve the
849 configuration error message.
851 2011-11-25 Ben Konrath <ben@bagu.org>
853 Don't use Strings to hold primary key values.
855 The primary key values are now held in a new data object
856 (PrimaryKeyItem) that holds type information and the primary key value
857 using the correct type.
859 * src/main/java/org/glom/web/client/OnlineGlomService.java:
860 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
861 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
862 PrimaryKeyItem instead of String to hold the primary key value.
863 * src/main/java/org/glom/web/client/Utils.java: Remove
864 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
865 PrimaryKeyItem based on the GlomFieldType and the DataItem.
866 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
867 PrimaryKeyItem instead of String to hold the primary key value. Load
868 document selection page when the documentID has not been set correctly.
869 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
870 DetailsPlace -> URL and URL -> DetailsPlace conversion with
872 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
873 Return empty string for URL instead of "null".
874 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
875 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
876 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
877 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
878 PrimaryKeyItem instead of String to hold primary key values.
879 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
880 PrimaryKeyValue to a Gda Value.
881 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
882 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
883 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
884 Replace temporary database access code that uses the PrimaryKeyValue to
885 Gda Value conversion.
886 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
887 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
888 PrimaryKeyItem instead of String.
889 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
890 hold primary key values.
892 2011-11-24 Ben Konrath <ben@bagu.org>
894 Use newly added java-libglom API to create queries.
896 This isn't finished. I still need to stop using Strings for primary key
897 values in the client code.
899 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
900 libglom to use fake connections so that retrieving the query string will
902 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
903 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
904 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
905 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
906 Use the newly added libglom sql methods and classes to create the
907 query. Add temporary hack to convert primary value strings to Gda
910 2011-11-23 Ben Konrath <ben@bagu.org>
912 Don't explicitly set the height of Portals.
914 See comments 6 - 10 of this bug for details:
916 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
918 * src/main/java/org/glom/web/client/ui/details/Portal.java:
920 2011-11-23 Ben Konrath <ben@bagu.org>
922 Use an HTML table instead of CSS for the FlowTable layout.
924 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
925 GWT's FlexTable to implement the FlowTable.
926 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
928 2011-11-18 Ben Konrath <ben@bagu.org>
930 Add boolean example to HTML table mockup.
932 * mockups/details-view-html-tables-text-entries.html:
934 2011-11-17 Ben Konrath <ben@bagu.org>
936 Ensure the pager buttons are always visible for related lists.
938 To accomplish this, I've turned off text wrapping in the list view and
939 related list tables for both the header and data text. The related list
940 table now has a fixed layout so the it doesn't overflow its container.
941 This is required to ensure that the cell text is clipped when it
942 overflows the cell and an ellipsis is added to the right side of the
943 cell when text is clipped.
945 A fixed table layout for the related list table in the details view
946 seems what we want for the details view anyway, so the side-effect is
949 The ellipsis will only be displayed in Firefox >= 7.
953 https://bugzilla.gnome.org/show_bug.cgi?id=662930
955 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
956 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
957 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
959 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
960 Set the 'table-layout: fixed' CSS property to the related list table.
961 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
962 'white-space: nowrap;' CSS property on both the list view and the
965 2011-11-16 Ben Konrath <ben@bagu.org>
967 Rework the fix for empty notebook tab labels.
969 Setting the empty group titles with its name caused problems for the
970 details layout. Instead of using libglom's
971 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
972 to the client when the title is empty. This allows the Notebook to use
973 the name when the title is empty without affecting anything else.
975 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
976 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
978 2011-11-16 Ben Konrath <ben@bagu.org>
980 Set group titles with name when title is empty.
982 This fixes a problem with an empty notebook tab label in the Lesson
983 Planner document. The forth tab in the notebook should be "Internet":
985 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
987 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
988 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
991 2011-11-16 Ben Konrath <ben@bagu.org>
993 Remove whitespace from the configured username properties.
995 This assumes that usernames won't have whitespace at the beginning
996 or end. But I think this is a reasonable assumption.
998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
999 String.trim() to remove the whitespace from the username properties.
1001 2011-11-15 Ben Konrath <ben@bagu.org>
1003 Add details view mockup with HTML tables and text entries.
1005 This is from the attachment on this bug:
1007 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1009 * mockups/details-view-html-tables-text-entries.html:
1011 2011-11-15 Ben Konrath <ben@bagu.org>
1013 Add space between the columns of the flow table.
1017 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1019 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1020 space between columns in the flow table.
1022 2011-11-15 Ben Konrath <ben@bagu.org>
1024 Add backup files to the .gitignore.
1026 * .gitignore: Ignore files that end with ~.
1028 2011-11-09 Ben Konrath <ben@bagu.org>
1030 Use latest release of gwt-log.
1032 Gwt-log releases are now being submitted to the maven central
1033 repository so manual installation of the jar is no longer required.
1035 * pom.xml: Update version and groupId of gwt-log dependency.
1037 2011-10-31 Ben Konrath <ben@bagu.org>
1039 Don't use GWT numeric formatting to override the glom currency formatting.
1041 Currencies are now displayed like they are in Glom. See this bug:
1043 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1045 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1047 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1048 currency code to constructor and set it when the cell is rendered.
1049 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1050 currency code to the constructor of the NumericCell.
1052 2011-10-27 Ben Konrath <ben@bagu.org>
1054 Require the latest release of java-libglom (1.17.4).
1058 2011-10-26 Ben Konrath <ben@bagu.org>
1060 Add style to Notebook that matches current theme.
1062 It's not the best style in the world but it's better than the default.
1064 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1065 padding at the bottom of the child widgets.
1066 * src/main/webapp/style.css: Add style for the Notebook.
1068 2011-10-26 Ben Konrath <ben@bagu.org>
1070 Move servlet initialization code to overridden init method.
1072 This is half of the solution to getting proper error messages
1073 displayed when configuration errors occur. Here's the relevant bug:
1075 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1077 The rest of the solution involves surrounding the init method with a
1078 try/catch block and setting a global variable with the error /
1079 exception. A new async method should be created to retrieve and display
1080 the error message / exception.
1082 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1083 code from constructor to init method adding exceptions as needed.
1085 2011-10-26 Ben Konrath <ben@bagu.org>
1087 Add script to monitor and restart tomcat if required.
1089 * utils/check-and-recover-tomcat.py: New file.
1091 2011-10-26 Ben Konrath <ben@bagu.org>
1093 Display the correct number of data items in the pager.
1097 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1099 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1100 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1101 The implementation is the same for both tables: Keep track of the
1102 number of non-empty rows and fire and RowCountChangeEvent after the data has
1104 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1105 custom Pager class that subclasses SimplePager to handle displaying
1106 the correct number when empty rows have been added.
1108 2011-10-26 Ben Konrath <ben@bagu.org>
1110 Correct error in previous commit.
1112 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1113 eventBus parameter from listView.setCellTable().
1115 2011-10-26 Ben Konrath <ben@bagu.org>
1117 Fix error in TODO comment.
1119 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1121 2011-10-24 Ben Konrath <ben@bagu.org>
1123 Create Notebook widgets to the details view.
1125 This isn't finished just yet - I still need to create a reasonable
1126 style to match the current theme.
1128 * src/main/java/org/glom/web/client/Utils.java: Add method for
1129 calculating the height of a widget. This is used in the Notebook class.
1130 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1131 new constructor method in Group.
1132 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1133 method for creating child widget that can be used by subclasses
1134 like Notebook. New constructor that allows disabling the group
1135 titles - Notebooks don't set a group title for their child groups.
1136 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1137 to make Notebooks using GWT's TabLayoutPanel.
1138 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1139 constructor that allows disabling the group titles.
1140 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1141 LayoutItemNotebook DTO.
1142 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1143 DTO for Notebooks. It's just an empty class for now but we might need
1144 it to transfer some specific information in the future.
1146 2011-10-21 Ben Konrath <ben@bagu.org>
1148 Add navigation buttons to related list tables.
1150 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1151 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1152 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1153 method getSuitableRecordToViewDetails() for getting the table name
1154 and primary key value for related list navigation buttons.
1155 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1156 private cell renderer class to get the navigation information for
1157 related list tables from the server. Extract the navigation
1158 processing code from the details cell navigation and use it for the
1159 related list navigation as well.
1160 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1161 cell renderer class for the details open buttons. This was needed
1162 because the related list navigation buttons and the list view
1163 navigation buttons need to react differently when clicked.
1164 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1165 the onEnterKeyDown() method because it's now overriden in the
1166 subclasses that are specific to the related list tables and the list
1168 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1169 the vertical size a little because the buttons add a bit of vertical
1170 space to table. This is not a perfect solution because the vertical
1171 size of with table fewer than 5 rows will be a little smaller.
1172 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1173 changes in how navigation buttons are handled.
1174 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1175 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1176 database access object.
1177 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1178 to find the portal for a given relationship name from
1179 RelatedListDBAccess. Add method to find a primary key field for a
1181 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1182 Move code to find the portal for a given relationship name to
1184 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1185 New file: database access object for getting the related list
1186 navigation information (the table name and the primary key value).
1187 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1188 DTO for transferring a table name to navigate to and a primary key
1190 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1191 boolean and getter/setter to specifies if the related list should add
1194 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1196 Use the master branch of java-libglom
1198 * pom.xml: Depend on java-libglom 1.19 instead.
1200 This is the master branch. See also the libglom-1-18 branch.
1202 2011-10-11 Ben Konrath <ben@bagu.org>
1204 Enable the open navigation button when the data has been set.
1206 This avoids having active buttons that don't do anything when the data
1209 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1211 2011-10-11 Ben Konrath <ben@bagu.org>
1213 Use IsWidget interface for FlowTableItem.
1215 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1216 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1218 2011-10-11 Ben Konrath <ben@bagu.org>
1220 Remove GWT styling from open button in details view.
1222 There are still some issues with how the details cell is arranged but
1223 this should be made to match Glom 1.20. I'm going to leave fixing this
1224 until I have Glom 1.20 up and running.
1226 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1227 style name on open button.
1228 * src/main/webapp/style.css: Move and edit details-navigation class.
1229 Re-arrange some classes to make them appear in the same order as the
1232 2011-10-07 Ben Konrath <ben@bagu.org>
1234 Update to GWT 2.4.0.
1236 * .gitignore: Ignore new cache directory.
1237 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1238 * pom.xml: Change GWT and maven plugin to 2.4.0.
1239 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1241 * src/main/java/org/glom/web/client/ClientFactory.java:
1242 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1243 * src/main/java/org/glom/web/client/OnlineGlom.java:
1244 Update source for API changes.
1245 * utils/build-onlineglom-war.sh: Remove cache directory before the
1248 2011-10-07 Ben Konrath <ben@bagu.org>
1250 Add navigation buttons in the details view.
1252 This isn't finished but I thought I'd commit what I have as it's a
1253 pretty good start. I still need to:
1255 1. Change the style so that it fits better into the current theme
1256 2. Adjust the details cell to expand as much as possible.
1258 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1259 click handlers to navigation buttons in the DetailsCells. Create a
1260 refreshData() method to get just the data from the server without the
1262 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1263 Update the tableSelector and browser title when the table name
1264 changes without using the tableSelector.
1265 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1266 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1267 getDetailsCells() to getCells(). Update variable names.
1268 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1269 method to set click handler on navigation button. Rename a few
1270 variables. Add navigation buttons where needed.
1271 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1272 variables and methods.
1273 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1274 navigation boolean and navigation table as required in the
1275 LayoutItemField DTO.
1276 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1277 variables for navigation along with getter/setter methods.
1279 2011-10-07 Ben Konrath <ben@bagu.org>
1281 Rename Field to DetailsCell.
1283 This is a refactor-only commit. No functionality has been added or
1286 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1287 Update variable and method names.
1288 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1289 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1290 variable and method names.
1291 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1293 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1294 variable and method names.
1296 2011-10-07 Ben Konrath <ben@bagu.org>
1298 Create separate methods for layout and data the details view.
1300 This is a refactor-only commit. No functionality has been added or
1303 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1304 private methods: setData(), createLayout().
1306 2011-10-07 Ben Konrath <ben@bagu.org>
1308 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1310 This is part of a change to get navigation buttons in the details view
1311 but it should have been done this way from the start.
1313 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1314 for method name change in TableSelectionView.
1315 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1316 Create TableChangeEvent and set the browser title using the
1317 TableSelectionView API.
1318 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1319 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1320 Change getSelectedTable() to getSelectedTableName(). Add
1321 getSelectedTableTitle().
1323 2011-10-07 Ben Konrath <ben@bagu.org>
1325 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1327 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1329 2011-10-07 Ben Konrath <ben@bagu.org>
1331 Update TableChangeEvent to use newTableName naming convention.
1333 This makes the class more consistent with GWT naming conventions.
1335 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1336 Update for method name change in TableChangeEvent.
1337 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1338 for method name change in TableChangeEvent.
1339 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1340 newTableName variable and getter method. Make toDebugString()
1343 2011-09-30 Ben Konrath <ben@bagu.org>
1345 Disable the pager in the list tables when the data row count is less than the minimum.
1347 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1348 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1350 2011-09-30 Ben Konrath <ben@bagu.org>
1352 Add empty rows to the end of related list and list view tables.
1354 I also extracted the cell rendering classes from the ListTable because
1355 the code was becoming a little crazy with all the anonymous inner
1356 classes. My plan is to use these cell rendering classes in the details
1357 view as well so this refactor will be needed for that change.
1359 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1360 set the row count in related list tables if the data has more rows
1361 than the minimum number of rows visible.
1362 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1363 row count in list view tables if the data has more rows than the
1364 minimum number of rows visible.
1365 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1366 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1368 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1369 for rendering TYPE_NUMERIC cells. The code was extracted from the
1371 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1372 class for rendering cells with buttons in list views. The code was
1373 extracted from the ListTable class.
1374 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1375 for rendering TYPE_TEXT cells. The code was extracted from the
1377 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1378 Add empty rows to the end of the data if required. Implement
1379 ListTable.getMinNumVisibleRows().
1380 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1381 cell renderer code to public classes. Return null in
1382 Column.getValue() for empty rows. Add new abstract method:
1383 getMinNumVisibleRows(). Move code to set the row count of the list view
1384 table to ListViewImpl.
1385 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1386 empty rows to the end of the data if required. Implement
1387 ListTable.getMinNumVisibleRows().
1390 2011-09-27 Ben Konrath <ben@bagu.org>
1392 Use GWT.log for client-side debugging statements.
1394 These are optimized out when deployed so I should have used this method
1395 in the first place. These statements will eventually be replaced with some sort
1396 of notification in the browser.
1398 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1399 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1400 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1401 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1402 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1404 2011-09-27 Ben Konrath <ben@bagu.org>
1406 Put tableselector on the right, back to list link on right.
1408 The idea is that the table selector is acting like a label for the
1409 currently displayed table so it should be placed below the document title. This
1410 puts the table title in a similar position to where it is in Glom.
1412 * mockups/details-contacts.html:
1413 * mockups/details-projects.html:
1414 * mockups/listview-contacts.html:
1415 * mockups/listview-projects.html:
1416 * mockups/style.css:
1417 Update mockups to match how the interfaces currently look.
1418 * src/main/webapp/style.css: Swap positions of backlink with the table
1419 selector. Add some space on the left side of the table selector to
1420 line things up with the document title.
1422 2011-09-27 Ben Konrath <ben@bagu.org>
1424 Add field colouring to details view.
1426 This change re-works how field colouring works. The colour formatting
1427 information is now set to the client with the layout information instead of
1428 with the data. This eliminates the need to send the same colour strings for
1429 data in list view column when colour information is set.
1431 In order to set an alternate colour for negative numeric values, the
1432 number is now sent to client and formatted with the GWT NumberFormat class.
1434 This change also fixes:
1436 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1438 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1439 internationalization framework which is needed for client side numeric
1441 * src/main/java/org/glom/web/client/Utils.java: New file for some
1442 client static utility methods.
1443 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1444 the DataItem object to the Field class. Use a utility method to
1445 create the foreignKeyValue string.
1446 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1447 alignment and text colours in the constructor. Add setData(DataItem)
1448 method. Remove setText(String) method.
1449 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1450 colour information to GlomTextCell. Create and use GlomNumberCell for
1451 rendering numbers. Use utility method to get the string for the
1452 primary key of the key provider. Re-work how the horizontal alignment
1454 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1455 formatting to layout information. Methods for converting the libglom
1456 formatting information were moved from DBAccess.
1457 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1458 numeric formatting (it's now done on the client side). Don't set text
1459 colours in DataItem. Move libglom formatting conversion methods to
1461 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1462 getters/setters for text colour information.
1463 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1464 for transferring the libglom NumericFormat information to the client.
1465 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1466 and getters/setters for: GlomNumericFormat, background colour and
1467 foreground colour strings.
1469 2011-09-26 Ben Konrath <ben@bagu.org>
1471 Simplify code that iterates through the LayoutGroup.
1473 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1475 2011-09-26 Ben Konrath <ben@bagu.org>
1477 Accept Eclipse formatting for OnlineGlomServiceAsync.
1479 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1481 2011-09-26 Ben Konrath <ben@bagu.org>
1483 Don't use the ListDBAccess classes to get the primary key layout information.
1485 This was causing a bug where the wrong index for the hidden primary key
1486 was being sent to the client.
1488 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1489 primary key while creating the LayoutGroup DTO. Create a
1490 LayoutItemField DTO for hidden primary keys. Don't use the
1491 RelatedListDBAccess because it was only used for getting the primary
1493 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1494 access modifier from public to protected for getPrimaryKeyField() and
1495 getPrimaryKeyLayoutItemField().
1496 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1497 abstract method getExpectedResultSize() because RelatedListDBAccess
1498 doesn't have enough info to implement it.
1499 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1500 Remove @Override for getExpectedResultSize().
1501 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1502 Remove method getExpectedResultSize().
1504 2011-09-23 Ben Konrath <ben@bagu.org>
1506 Log which layout (list or details) the ignored item is from.
1508 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1510 2011-09-23 Ben Konrath <ben@bagu.org>
1512 Remove annotations that turn off code formatting in DataItem.
1514 * src/main/java/org/glom/web/shared/DataItem.java:
1516 2011-09-23 Ben Konrath <ben@bagu.org>
1518 Rename GlomField to DataItem and update associated methods.
1520 This is a rename-only refactor. No functionality has been added or
1523 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1524 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1525 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1526 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1527 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1528 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1529 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1530 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1531 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1532 * src/main/java/org/glom/web/server/database/DBAccess.java:
1533 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1534 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1535 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1536 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1537 * src/main/java/org/glom/web/shared/DataItem.java:
1538 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1539 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1541 2011-09-23 Ben Konrath <ben@bagu.org>
1543 Rename GlomDocument to DocumentInfo and update associated methods.
1545 This is a rename-only refactor. No functionality has been added or
1548 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1549 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1550 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1551 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1552 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1554 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1556 2011-09-20 Ben Konrath <ben@bagu.org>
1558 Require java-libglom 1.17.3.
1560 This picks up the fix for the seg fault problem with the Scenes table
1561 in the Openismus Film Manager example.
1565 2011-09-20 Ben Konrath <ben@bagu.org>
1567 Change the way sort clause is added for primary key when no sort clause is requested.
1569 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1570 before the sort clause is created. When a sort clause is not requested, the
1571 sort clause is created by finding the primary key in the LayoutFieldVector
1574 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1576 2011-09-20 Ben Konrath <ben@bagu.org>
1578 Log error message if no documents are found in the configured directory.
1580 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1581 Extract the glom file extension string to a private static final class
1582 variable (mostly as syntactic sugar). Accept a minor formatting change.
1583 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1584 the example glom.document.directory configuration property to make it
1585 more clear that it can any directory, not just the home directory.
1587 2011-09-18 Ben Konrath <ben@bagu.org>
1589 Add related lists to details view.
1591 The related list table has support for paging and sorting just like the
1592 table in the list view.
1594 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1595 SQL queries for the related list tables.
1596 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1597 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1598 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1599 Rename getList methods to getListView and add comments. Remove
1600 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1601 it being unused. Add methods: getDetailsLayoutAndData(),
1602 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1603 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1604 Create the layout and set the data for the fields in one async call
1605 instead of two. Create related lists where appropriate.
1606 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1607 for method name changes in OnlineGlomService.
1608 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1609 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1610 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1612 * src/main/java/org/glom/web/client/ui/ListView.java:
1613 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1614 tableName from setCellTable(). Create a ListViewTable instead of
1616 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1617 represent a data field in the details view.
1618 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1619 from addDetailsCell() to Field class. Keep track of the Fields and
1620 Portals in the details view.
1621 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1622 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1623 and add a method to get it. Add method to set the contents of the
1625 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1626 New class for related list tables. This class has the data provider
1627 for the related list table.
1628 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1629 abstract class which is the base class for the ListViewTable and the
1631 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1632 New class for list view tables. This class has the data provider for
1633 the list view table.
1634 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1635 methods for related list tables. Add more information to the
1636 LayoutItemField and LayoutItemPortal DTOs.
1637 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1638 Remove debugging print statement.
1639 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1640 Remove debugging print statements. Add primary key field to SQL count
1642 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1643 Remove unnecessary LayoutFieldVector parameter from
1644 getResultSizeOfSQLQuery() method.
1645 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1646 New class for related list table database access.
1647 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1648 class that is a wrapper DTO for details view layout and data.
1649 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1650 new 'fromField' string to this DTO.
1651 * src/main/webapp/style.css: Remove bottom margin and override top
1654 2011-09-15 Ben Konrath <ben@bagu.org>
1656 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1658 This sets things up to make it easier to add the data retrieval for
1659 related lists (portals). No user noticeable changes were made with
1662 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1663 class has the code to retrieve the layouts and access the
1664 database using the new database helper classes.
1665 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1666 Most of the functionality has been removed from this class. This
1667 class now represents the public interface for the client side
1668 code. It also deals with configuring the servlet and cleaning
1669 things up when the servlet is stopped.
1670 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1671 of static methods into this utility class.
1672 * src/main/java/org/glom/web/server/database/DBAccess.java:
1673 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1674 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1675 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1676 These classes have the database retrieval code. The class hierarchy
1677 has been setup to make it easy to reuse code for similar
1680 2011-09-06 Ben Konrath <ben@bagu.org>
1682 Create separate classes for list table code and the data provider.
1684 As part of this refactor, I also split up the code a bit to make it
1687 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1688 table code to two new classes (below).
1689 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1690 with code from ListViewImpl.
1691 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1692 New file with code from ListViewImpl.
1694 2011-09-06 Ben Konrath <ben@bagu.org>
1696 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1698 This fixes the LayoutItemPortal DTO to match the libglom layout object
1701 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1703 2011-09-01 Ben Konrath <ben@bagu.org>
1705 Set title of Portals in the Details View.
1707 * pom.xml: Bump required version of java-libglom to 1.17.1.
1708 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1709 widget creation to its own class. Add comments to constructor.
1710 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1711 The code is mostly from the Group class with the title now set.
1712 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1713 title of Portal. Update some comments. Fix some code formatting.
1715 2011-09-01 Ben Konrath <ben@bagu.org>
1717 Remove TODO comment for the flow table column width.
1719 The flow table column width is working correctly and doesn't need to be
1720 changed. See this mailing list post for more info:
1722 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
1724 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1726 2011-08-27 Ben Konrath <ben@bagu.org>
1728 Add document title (database name) to top of the browser page.
1730 I added the document title to the TableSelecitonView but that will
1731 change if / when we add a view that doesn't require table selection.
1733 * mockups/details-contacts.html:
1734 * mockups/details-projects.html:
1735 * mockups/listview-contacts.html:
1736 * mockups/listview-projects.html:
1737 * mockups/style.css: Add document title to mockups to keep things
1739 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
1740 sizes to account for the document title.
1741 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1742 Set the document title when it has been retrieved from the server.
1743 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1744 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
1745 and implement setDocumentTitle(String) method.
1746 * src/main/webapp/style.css: Add ID for document title style.
1748 2011-08-25 Ben Konrath <ben@bagu.org>
1750 Add NavigationType enum to LayoutItemPortal DTO.
1752 This is the start of adding support for Portals to the Details View.
1754 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
1755 LayoutItem_Portal.navigation_type enum from libglom to
1756 LayoutItemPortal.NavigationType enum.
1757 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1758 NavigationType enum, field for storing the NavigationType and getter
1761 2011-08-25 Ben Konrath <ben@bagu.org>
1763 Implement the flow table layout in the Details View.
1765 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1766 FlowTable to Group to account for the renamed class.
1767 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
1768 File. This is a container widget that implements the Glom details view
1769 flow table behaviour.
1770 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
1771 org/glom/web/client/ui/FlowTable.java.
1772 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
1773 so that the size of the subgroups are a closer match to the size of
1774 the Glom subgroups. This makes the flowtable layout match the layout
1775 in Glom for the Music Collection example file.
1777 2011-08-16 Ben Konrath <ben@bagu.org>
1779 Create container element for LayoutItemPortal in Details View.
1781 This will help me develop the layout for the FlowTable.
1783 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
1784 fieldPanel variable to detailsCell.
1786 2011-08-15 Ben Konrath <ben@bagu.org>
1788 Set the height of the data element in the Details View.
1790 I changed the InlineLabels (text in a span element) to Labels (text in
1791 a div element) so that I could set the height of the details-data
1792 elements instead of the details-cell parent elements. This allows the
1793 the details-data element to display the correct height if style is
1794 applied that shows the height.
1796 This change has the added benefit of allowing the order of the labels
1797 and data elements to be changed for right-to-left languages.
1799 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
1800 InlineLabels to Labels.
1801 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
1802 InlineLabels to Labels. Set the height of the data element.
1803 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
1804 multiline text height in the Formatting DTO.
1805 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
1806 for multiline height along with getter and setter methods.
1807 * src/main/webapp/style.css: Adjust style to account for the change
1808 from span elements to div elements in the details cell.
1810 2011-08-15 Ben Konrath <ben@bagu.org>
1812 Make the List View appearance match the mockups.
1814 It doesn't match exactly but it's much better than it was.
1816 * mockups/listview-contacts.html: Remove unused css classes.
1817 * mockups/listview-projects.html: Remove unused css classes.
1818 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
1819 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
1820 for mainPanel instead of VerticalPanel (table). Set style name on
1821 CellTable. Set style name on Details column. Right-align Details
1823 * src/main/webapp/style.css: Adjust properties to match the mockups.
1825 2011-08-12 Ben Konrath <ben@bagu.org>
1827 Add better support for subgroups in the details view.
1829 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1830 changed FlowTable constructor.
1831 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
1832 support for subgroups and subgroup-titles.
1833 * src/main/webapp/style.css: Add CSS class for subgroups and
1836 2011-08-12 Ben Konrath <ben@bagu.org>
1838 Return the top level LayoutGroup title.
1840 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1842 2011-08-11 Ben Konrath <ben@bagu.org>
1844 Make the TableSelector header match the mockup.
1846 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
1847 the layout panel. Properly lineup the table selection header with
1848 the list and details view.
1849 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
1850 margin around the details view.
1851 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1852 Rename listBox variable to tableSelector. Set id for the style sheet.
1853 Use a FlowPanel instead of a HorizontalPanel.
1854 * src/main/webapp/style.css: Add properties to make the TableSelector
1855 box match the mockups.
1857 2011-07-13 Ben Konrath <ben@bagu.org>
1859 Update install script for java-libglom version change.
1861 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
1864 2011-07-13 Ben Konrath <ben@bagu.org>
1866 Add support sub-group in the details view.
1868 I also removed the code that special-cased the default details view
1871 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
1873 I still have to make a proper flowtable.
1875 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1876 Don't special-case default details view layout.
1877 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
1878 addLayoutField() as I'm going to use it.
1879 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
1880 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
1882 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
1883 extracted from DetailsViewImpl.GroupPanel. Add support for
1885 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1886 column count when getting the details layout.
1888 2011-07-12 Ben Konrath <ben@bagu.org>
1890 Set browser title with database and table titles.
1892 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1893 Set the browser title when the table changes and when the activity
1895 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1896 title when retrieving document info (the GlomDocument object).
1897 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
1898 with getter and setter methods. Remove unused convenience constructor.
1899 Use default code formatting.
1901 2011-07-12 Ben Konrath <ben@bagu.org>
1903 Ignore LayoutItemPortals in the details view.
1905 I added a new DTO for the LayoutItemPortal so that I can ignore it in
1908 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
1909 LayoutItemPortal layout objects.
1910 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
1911 LayoutItemPortal objects when retrieving the details layout.
1912 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
1913 file. This is an empty class and just used to get type information for
1916 2011-07-12 Ben Konrath <ben@bagu.org>
1918 Use java-libglom 1.17.0.
1922 2011-07-11 Ben Konrath <ben@bagu.org>
1924 Remove "Table:" label from table selector.
1926 This matches a recent change in the Glom UI.
1928 * mockups/details-contacts.html:
1929 * mockups/details-projects.html:
1930 * mockups/listview-contacts.html:
1931 * mockups/listview-projects.html: Remove the "Table:" label from the
1933 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1935 2011-07-11 Ben Konrath <ben@bagu.org>
1937 Add main groups to the details view.
1939 This makes things look a little nicer in the details view. The next step
1940 is to implement the flowtable.
1942 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
1943 resources from the standard gwt css theme. Standard.css is now
1944 included in OnlineGlom.html so that the online glom css rules have
1945 precedence over the gwt theme.
1946 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1947 the whole LayoutGroup to the DetailsView instead of just the titles.
1948 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1949 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
1950 details layout with a helper class (GroupPanel). I might extract this
1951 class when I make the full flowtable.
1952 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
1953 string as default so I don't have to worry about NPEs when processing
1955 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
1956 note beside OnlineGlom.gwt.xml above).
1957 * src/main/webapp/style.css: Add default font-size to body to override
1958 the font-size set by the standard theme. Don't use h2 tags for
1959 group-title. Create new details-cell class.
1961 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1963 ConfiguredDocument: Set the port number too.
1965 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1966 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
1967 Glom document. Presumably this worked sometimes so far because there is a
1968 default port number.
1970 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1972 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
1974 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1975 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
1976 correct, though we should throw an exception too.
1978 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1980 Fix a addDocuemnt typo.
1982 * src/main/java/org/glom/web/shared/Documents.java
1983 (Documents.addDocuemnt): Rename to addDocument().
1984 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1985 (OnlineGlomServiceImpl.getDocuments): Adapt.
1987 2011-07-08 Murray Cumming <murrayc@murrayc.com>
1989 Slightly improved log output when connection fails.
1991 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1992 (ConfiguredDocument.setUsernameAndPassword):
1993 We don't know for sure if it' the username/password that's wrong, so
1994 rephrase the message.
1995 Also ouput the exception message, though it's generic in this case.
1997 2011-07-08 Ben Konrath <ben@bagu.org>
2001 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2002 added braces to a one line if statement because the Eclipse formatter
2003 was getting confused.
2005 2011-07-07 Ben Konrath <ben@bagu.org>
2007 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2009 These should really be two separate tasks but I counldn't get things to
2010 work with GWT 2.2.0 and Eclipse 3.7.
2014 * .settings/org.eclipse.jdt.core.prefs:
2015 * .settings/org.eclipse.jdt.ui.prefs:
2016 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2017 * .settings/org.eclipse.m2e.core.prefs:
2018 Add new config files. Update current files. Remove references to the
2019 webtools plugins as we're not using any of the webtools features.
2020 * .gitignore: Add logs directory which is created when running with
2022 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2023 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2024 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2026 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2028 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2030 onlineglom.properties: Add explanatory comments.
2032 * src/main/resources/onlineglom.properties: Also change the default user
2033 from ben to someuser, to avoid the risk of people thinking we just
2034 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2036 2011-06-28 Ben Konrath <ben@bagu.org>
2038 Use filename in Log for incorrect passwords.
2040 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2041 getFileName(String) method to get the filename from the URI.
2043 2011-06-28 Ben Konrath <ben@bagu.org>
2045 Add the table name to the URL token for the ListPlace.
2047 This makes things consistent between the DetailsPlace and the
2048 ListPlace. It also allows the the ListPlace to be bookmarked.
2050 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2051 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2052 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2053 Remove getDefaultListLayout(). The default layout is now returned
2054 by the getListLayout() method when the table name is an empty string.
2055 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2056 Add table name field. Change to a new ListPlace when the table
2057 has been changed. Use getListLayout() for getting the default
2059 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2060 Add table name field. Set the correct table name in the list box
2061 when loading from bookmark. This corrects a problem for the
2063 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2064 Move table name to super-class (HasSelectableTable). Move document
2065 and table URL keys to super-class in HasSelectableTable.
2066 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2067 Add table name field. Add Tokenizer class with URL key common to
2068 the subclasses (DetailsPlace and ListPlace).
2069 * src/main/java/org/glom/web/client/place/ListPlace.java:
2070 Add table name. Add code to parse the URL token.
2071 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2072 Update ListPlace construction with empty table name string.
2073 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2074 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2075 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2076 Update ListPlace construction with table name string.
2077 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2078 Change defaultTableName field to tableName to reflect how it's now
2079 used. Update the getter and setter methods.
2081 2011-06-28 Ben Konrath <ben@bagu.org>
2083 Enable the table selector in the DetailsView.
2085 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2086 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2087 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2088 Remove getDefaultDetailsLayout(). The default layout is now returned
2089 by the getDetailsLayout() method when the table name is an empty
2091 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2092 event handler for table change event. Change to using
2093 getDetailsLayout() for the default details layout.
2094 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2096 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2097 when navigating to the details place.
2099 2011-06-27 Ben Konrath <ben@bagu.org>
2101 Use filename based unique document ID in URL and for RPC.
2103 The document ID is the glom document name with spaces (' ') replaced
2104 with pluses ('+') and without the .glom extension.
2106 This change is mostly a string substitution of 'documentTitle' for
2107 'documentID'. The only code change is the addition of a Documents DTO to get the
2108 filename to document title mappings as indicated below.
2110 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2111 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2112 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2113 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2114 Use Documents DTO to create the document links in the document
2116 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2117 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2118 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2119 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2120 * src/main/java/org/glom/web/client/place/ListPlace.java:
2121 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2122 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2123 * src/main/java/org/glom/web/client/ui/ListView.java:
2124 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2125 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2126 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2127 * src/main/java/org/glom/web/server/Log.java:
2128 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2129 getDocumentTitles() to getDocuments() and return the Documents DTO.
2130 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2131 transferring the filename to document title mappings.
2133 2011-06-25 Ben Konrath <ben@bagu.org>
2135 Make the authentication popup work again.
2137 This bug was introduced when I extracted ConfiguredDocument to its own class.
2139 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2140 correct success / fail status in setUsernameAndPassword().
2142 2011-06-25 Ben Konrath <ben@bagu.org>
2144 Use filename as unique key for configuring database usernames and passwords.
2146 This replaces the use of the Glom document title which could change
2147 depending on the locale. Thanks to Murray Cumming for pointing out this
2150 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2151 * src/main/resources/onlineglom.properties:
2153 2011-06-24 Ben Konrath <ben@bagu.org>
2155 Pass primary key value to DetailsView.
2157 This enables the DetailsView to load the correct data.
2159 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2160 primary key value field and set in constructor. Pass primary key
2161 value to getDetailsData().
2162 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2163 variables for document title and primary key value.
2164 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2165 key value to the DetailsPlace.
2167 2011-06-24 Ben Konrath <ben@bagu.org>
2169 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2171 This allows the primary key to be retrieved by the Details button. This
2172 functionality has not been implemented yet but it's in the works.
2174 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2175 the LayoutGroup result to ListView.setCellTable instead of all of its
2176 fields individually.
2177 * src/main/java/org/glom/web/client/ui/ListView.java:
2178 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2179 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2180 get the primary key for the table.
2181 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2182 index of the primary key in the LayoutGroup accounting for hidden
2183 primary keys. Rename getJavaNumberFormat() to
2184 convertToJavaNumberFormat() for consistency. Cleanup / add some
2186 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2187 field for primary key index and a field to indicate whether the
2188 primary key is hidden or not.
2190 2011-06-23 Ben Konrath <ben@bagu.org>
2192 Rename getTableData methods to getListData.
2194 This is a rename refactor for consistency with other methods.
2196 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2197 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2198 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2199 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2201 2011-06-23 Ben Konrath <ben@bagu.org>
2203 Extract the ConfiguredDocument innerclass into its own class.
2205 This makes the servlet code more object oriented.
2207 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2208 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2209 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2210 new ConfiguredDocument class.
2212 2011-06-21 Ben Konrath <ben@bagu.org>
2214 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2216 This makes things more inline with how libglom works and reduces code
2217 duplication. This refactor lays the groundwork for adding the primary key to
2218 the LayoutGroup object.
2220 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2221 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2222 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2223 Change method names to getListLayout and getDefaultListLayout for
2224 consistency. Use LayoutGroup as the DTO for the list layout instead of
2225 ColumnInfo and LayoutListTable.
2226 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2227 new method names along with the LayoutGroup object for transferring the
2229 * src/main/java/org/glom/web/client/ui/ListView.java:
2230 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2231 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2232 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2234 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2235 Replaced with LayoutGroup.
2236 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2237 expectedResultSize and defaultTableName fields which are needed for
2239 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2240 type field which is needed for the list layout but will also be
2241 useful for the details layout as things progress.
2242 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2243 Make class abstract. Remove the unnecessary
2244 getFormattingHorizontalAlignment method. Add setFormatting method.
2246 2011-06-16 Ben Konrath <ben@bagu.org>
2248 Add scripts for building and installing war.
2250 These will help when updating OnlineGlom but they're also good
2251 supplemental documentation of the build and deployment proceeding.
2253 * utils/build-onlineglom-war.sh: New file.
2254 * utils/install-onlineglom-war.sh: New file.
2256 2011-06-16 Ben Konrath <ben@bagu.org>
2258 Create wrapper class to create consistent log messages.
2260 I wrapped methods in the Log class of gwt-log to add the method names
2261 from the servlet and create consistent formatting of the document title
2262 and table names in the log messages.
2264 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2265 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2266 log methods to use methods from wrapped Log class.
2268 2011-06-16 Ben Konrath <ben@bagu.org>
2270 Remove superfluous conditional return.
2272 Thanks to Murray Cumming for pointing this out!
2274 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2276 2011-06-15 Ben Konrath <ben@bagu.org>
2278 Return an ArrayList of LayoutGroups for the Details layout.
2280 This corrects a problem with the details layout as it can have more
2281 than one top level LayoutGroup.
2283 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2284 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2285 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2286 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2287 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2288 with ArrayList of LayoutGroups for the details view layout.
2289 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2290 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2291 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2292 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2293 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2294 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2296 2011-06-14 Ben Konrath <ben@bagu.org>
2298 Use cast_dynamic method to determine the libglom LayoutItem type.
2300 This is better than finding the LayoutItem type by using the string
2301 returned from the get_part_type_name() method.
2303 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2305 2011-06-14 Ben Konrath <ben@bagu.org>
2307 Add method names to log entries in the servlet.
2309 This helps when tracking down deployment problems.
2311 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2313 2011-06-14 Ben Konrath <ben@bagu.org>
2315 Add data to the DetailsView using a hard-coded primary key value.
2317 The layout and functionality of the DetailsView is not complete. This
2318 is just a checkpoint so the patch doesn't get too big.
2320 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2321 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2322 Add getDetailsData() servlet method.
2323 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2324 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2325 LayoutFields are added to the DetailsView.
2326 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2327 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2328 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2329 take the string for the title instead of the object.
2330 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2331 Add implementation getDetailsData() along with some private helper
2333 * src/main/webapp/style.css: Add padding to details-data class. Add a
2334 details-label class with the same padding as the details-data class.
2336 2011-06-03 Ben Konrath <ben@bagu.org>
2338 Use presenter.goTo() to change to the DetailsPlace.
2340 This will make things easier when we need to open the DetailsView with
2341 data specific to the row that was clicked.
2343 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2345 2011-06-02 Ben Konrath <ben@bagu.org>
2347 Add CSS file from mockups.
2349 I'm adding this now because it's going to be useful to have when
2350 developing the DetailsView. The TableSelectionView and ListView aren't
2353 * src/main/webapp/OnlineGlom.html:
2354 * src/main/webapp/style.css:
2356 2011-06-02 Ben Konrath <ben@bagu.org>
2358 Use String.isEmpty() to check for empty string.
2360 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2362 2011-06-02 Ben Konrath <ben@bagu.org>
2364 Display main layout group titles in the DetailsView.
2366 This is the start of the DetailsActivity/DetailsView implementation.
2368 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2369 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2370 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2371 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2372 Get the layout information for the details view from the server and set
2373 the main layout group titles.
2374 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2375 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2376 Add addLayoutGroup() and addLayoutField() methods. This are just
2377 temporary methods for creating the the details view that will change
2379 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2380 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2382 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2383 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2384 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2385 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2386 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2387 Data Transfer Objects that mimic the libglom object structure. These are
2388 used for transferring the details layout but could also be used for
2389 transferring the list layout.
2391 2011-05-27 Ben Konrath <ben@bagu.org>
2393 Reset the AuthenticationPopup when clearing the ListView.
2395 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2397 2011-05-27 Ben Konrath <ben@bagu.org>
2399 Fix problem with onlineglom.properties file loading.
2401 The old way worked in Eclipse but not on the server. Loading the
2402 onlineglom.properties file now works in Eclipse and on the server.
2404 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2406 2011-05-24 Ben Konrath <ben@bagu.org>
2408 Update gwt-log from 3.1.0 to 3.1.2.
2410 Gwt-log 3.1.0 has been marked as depreciated.
2414 2011-05-24 Ben Konrath <ben@bagu.org>
2416 Add comment to ListActivity.goTo() method.
2418 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2420 2011-05-24 Ben Konrath <ben@bagu.org>
2422 Remove FIXME in convertGdkColorToHtmlColour()
2424 The Gdk::Color value returned by libglom is 16-bits per channel on both
2425 64 and 32-bit platforms.
2427 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2429 2011-05-19 Ben Konrath <ben@bagu.org>
2431 Improve performance of initial ListView load.
2433 I removed a round trip to the server for getting the default table name
2434 and then requesting information about that table. This also removes a potential
2435 problem with the table change handler not being setup in time to receive the
2436 table change event from the ListActivity.
2438 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2439 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2440 getDefaultLayoutListTable() method. Improve comments.
2441 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2442 getDefaultLayoutListTable() method instead of firing a table change
2443 event to get the table to load.
2444 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2445 implementation of getDefaultLayoutListTable() method.
2446 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2449 2011-05-19 Ben Konrath <ben@bagu.org>
2451 Override toDebugString() in TableChangeEvent.
2453 This is useful to have for debugging.
2455 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2457 2011-05-19 Ben Konrath <ben@bagu.org>
2459 Add a "Back to List" link when at the DetailsPlace.
2461 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2462 Populate the CellTable based on the selected table of the ListBox if
2463 it's set otherwise use the default table. This allows the "Back to
2465 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2466 Remove Place from constructors. Add a setPlace() method. Add
2467 goToPlace() method. Set class as presenter for TableSelectionView.
2468 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2469 Use the same TableSelectionActivity when switching between the List and
2471 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2472 Subclass the new HasSelectableTablePlace. This removes some duplicate
2474 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2475 New class to represent Places that display the TableSelectionView.
2476 * src/main/java/org/glom/web/client/place/ListPlace.java:
2477 Subclass the new HasSelectableTablePlace. This removes some duplicate
2479 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2480 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2481 Add Presenter interface. Add setBackLinkVisible() method. Add
2482 setBackLink() method.
2484 2011-05-18 Ben Konrath <ben@bagu.org>
2486 Enable the "Details" buttons.
2488 Right now only an empty details view is displayed.
2490 * src/main/java/org/glom/web/client/ClientFactory.java:
2491 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2492 Add DetailsView to ClientFactory.
2493 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2494 A basic activity for the details view.
2495 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2496 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2498 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2499 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2501 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2502 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2503 unnecessary super() in constructor.
2504 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2505 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2506 really shouldn't create a new TableSelectionActivity for both the ListPlace
2507 and the DetailsPlace so this should be considered a temporary solution.
2508 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2509 New file. Represents a URL for the details view.
2510 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2511 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2512 A basic details view interface and implementation.
2513 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2514 Enable the "Details" buttons.
2516 2011-05-12 Ben Konrath <ben@bagu.org>
2518 Use a LayoutPanel with multiple display areas for main layout.
2520 This is mostly a refactor in that there are no changes from the user
2521 point of view. These changes are required so that we can swap out the list view
2522 with the details view when the user clicks the "Details" button.
2524 * src/main/java/org/glom/web/client/ClientFactory.java:
2525 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2526 OnlineGlomView. Add TableSelectionView, ListView and
2527 AuthenticationPopup.
2528 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2529 for main layout. Add display regions for main activities. Add
2530 activity manager for for main activities.
2531 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2532 file from parts of the deleted OnlineGlomActivity.
2533 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2534 New file from parts of the deleted OnlineGlomActivity.
2535 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2536 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2537 New files for app wide table change event.
2538 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2539 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2540 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2541 Activity mappers for the main activities replace the deleted app-wide
2543 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2544 Fix a spelling error in he comment.
2545 * src/main/java/org/glom/web/client/ui/ListView.java:
2546 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2547 Renamed from LayoutListView and modified for MVP. This still not a
2548 proper dumb view as prescribed by the MVP pattern but it works for now.
2549 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2550 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2551 New widget stripped out of the deleted OnlineGlomView.
2552 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2553 Remove hack that is fixed by this patch.
2555 2011-05-06 Ben Konrath <ben@bagu.org>
2557 Rename OnlineGlomPlace to ListPlace.
2559 The only change besides the rename is that url will now display #list
2560 instead of #Document.
2562 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2563 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2564 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2565 * src/main/java/org/glom/web/client/place/ListPlace.java:
2566 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2568 2011-05-06 Ben Konrath <ben@bagu.org>
2570 Use Presenter for app navigation.
2572 This is the proper way to deal with Place (URL) changes with the MVP
2575 * src/main/java/org/glom/web/client/ClientFactory.java:
2576 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2577 PlaceHistoryMapper and PlaceHistoryHandler.
2578 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2579 PlaceHistoryMapper and PlaceHistoryHandler.
2580 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2581 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2582 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2583 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2584 Add Presenter interface and setPresenter methods. Rename addHyperLink
2585 to addDocumentLink taking only the document title as a parameter.
2587 2011-04-14 Ben Konrath <ben@bagu.org>
2589 Prompt for db username/password if they haven't been set.
2591 This is implemented with a popup widget that is contained within the
2592 OnlineGlomView and managed by the OnlineGlomActivity.
2594 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2595 methods for checking and setting the database username and password.
2596 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2597 new methods for checking and setting the database username and
2599 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2600 Display authentication popup if the JDBC connection to the database
2601 has not been authenticated.
2602 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2604 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2605 for dealing with the authentication popup.
2606 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2607 Implement the methods for dealing with the authentication popup.
2608 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2609 try to executed queries if the database connection hasn't been
2610 authenticated. Implement methods for checking and setting the
2611 database username and password.
2613 2011-04-12 Ben Konrath <ben@bagu.org>
2615 Make log messages a little clearer.
2617 Add a dash betweeen the document title and the table name.
2619 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2621 2011-04-12 Ben Konrath <ben@bagu.org>
2623 Protect against NPEs when cleaning up database resources.
2625 While this isn't strictly necessary because the exception is caught,
2626 not protecting against the NPEs makes it harder to find the real error
2629 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2631 2011-04-12 Ben Konrath <ben@bagu.org>
2633 Move configuration of the servlet to the constructor.
2635 The servlet will be initialized even if the database authentication
2636 information is not set or correct. I still need to add the UI for prompting
2637 the user for the authentication information when it's required.
2639 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2640 javadocs for getDocumentTitles() method.
2641 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2642 Set error message when RPC fails.
2643 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2644 glom files directory from the configuration file. Try to set the
2645 database authentication information for the specific document if it's
2646 set and works otherwise try to use the global authentication
2647 information set for the directory.
2648 * src/main/resources/onlineglom.properties: Moved from
2649 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2650 Added detailed comments for the new keys.
2652 2011-04-11 Ben Konrath <ben@bagu.org>
2654 Remove unnecessary @Override in DocumentSelectionViewImpl.
2656 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2658 2011-04-11 Ben Konrath <ben@bagu.org>
2660 Remove center alignment in DocumentSelectionView.
2662 The title element is still centred but the document titles and bottom
2663 sentence are both left-aligned.
2665 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2667 2011-04-11 Ben Konrath <ben@bagu.org>
2669 Change 'Demo' naming convention to 'Document'.
2671 This is just a rename refactor with no functional changes to the code.
2673 * src/main/java/org/glom/web/client/ClientFactory.java:
2674 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2675 * src/main/java/org/glom/web/client/OnlineGlom.java:
2676 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2677 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2678 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2679 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2680 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2681 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2682 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2683 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2684 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2685 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2687 2011-04-08 Ben Konrath <ben@bagu.org>
2689 Remove FIXME from safeLongToInt() method.
2691 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2694 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2696 2011-04-08 Ben Konrath <ben@bagu.org>
2698 Display an error if no glom documents are found in the specified directory.
2700 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2701 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2702 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2703 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2705 2011-04-08 Ben Konrath <ben@bagu.org>
2707 Add copyright header to one more file ... oops.
2709 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2711 2011-04-08 Ben Konrath <ben@bagu.org>
2713 Add copyright header to files without it.
2715 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2716 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2717 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2718 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2719 * src/main/java/org/glom/web/shared/ColumnInfo.java:
2720 * src/main/java/org/glom/web/shared/GlomField.java:
2722 2011-04-08 Ben Konrath <ben@bagu.org>
2724 Add support for accessing multiple glom documents in the servlet.
2726 This completes the demo selection functionality.
2728 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2729 document title to methods.
2730 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2731 document title to methods.
2732 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2733 Set browser window title when the activity starts. Correct name of
2734 document title variable.
2735 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2736 Set browser window title when the activity starts. Set the table
2737 selector change handler after table selector has been set. Clear the
2738 OnlineGlomView when the activity has been stopped.
2739 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
2740 document title as the place token. Use "#Document:" instead of
2741 "#OnlineGlomPlace:" in the URL.
2742 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2743 Change heading to "Online Glom"
2744 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
2745 document title in RPC methods.
2746 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
2747 setDocumentTitle() method. Add clear() method.
2748 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
2749 setDocumentTitle() method. Implement clear() method which removes the
2750 change handler on the ListBox, clears the ListBox and clears the
2752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2753 Implement methods with document title. Keep track for the configured
2754 glom documents and their corresponding JDBC configurations in a hash
2755 table. This information is retrieved using the document title as the
2756 key in the hash table.
2757 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
2758 document title field as it's no longer needed.
2760 2011-04-08 Ben Konrath <ben@bagu.org>
2762 Update the Eclipse JDT configuration.
2764 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
2765 methods. Automatically add the copyright header to new files.
2767 2011-04-05 Ben Konrath <ben@bagu.org>
2769 Add new page for demo selection.
2771 This patch adds all the components required to view and start an
2772 OnlineGlom demo by clicking on the desired hyperlink. The user is
2773 able to return to the demo selection page with the browser's back
2774 button. I still need to modify the servlet to work with multiple
2775 documents so all demo links will load the file defined in the
2776 OnlineGlom.properties.
2778 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
2779 This is only useful during development so we don't need to save it.
2780 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
2781 get a reference to the DemoSelectionView.
2782 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
2783 method to get a reference to the DemoSelectionView.
2784 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
2785 default view to DemoSelectionView.
2786 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
2787 to get glom document titles for glom files in a hard-coded directory.
2788 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2789 method to get glom document titles for glom files in a hard-coded
2791 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2792 Presenter for DemoSelectionView.
2793 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
2794 for DemoSelectionView.
2795 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2796 Update for DemoSelectionView.
2797 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2798 Basic 'Place' implementation for the DemoSelectionView.
2799 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2800 The interface for the DemoSelectionView.
2801 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2802 The implementation of the DemoSelectionView.
2803 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
2804 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
2805 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2806 implementation of method to get glom document titles for glom files
2807 in a hard-coded directory.
2808 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
2809 on longer being used.
2810 * src/main/webapp/glom.png: Glom logo.
2812 2011-04-05 Ben Konrath <ben@bagu.org>
2814 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
2816 This is the forth and final commit of a refactor that will allow
2817 OnlineGlom to be used with multiple documents.
2819 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2820 Move RPC code from OnlineGlomViewImpl to this class.
2821 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2823 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
2824 RPC code to the presenter class (the P in MVP).
2826 2011-04-04 Ben Konrath <ben@bagu.org>
2828 Start moving the existing OnlineGlom code to MVP.
2830 This work is based on the GWT MVP framework that is documented here:
2832 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
2834 This is the third commit of a refactor that will allow OnlineGlom to
2835 be used with multiple documents.
2837 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
2838 Interface for client factory which is used to get instances of various
2839 classes throughout the app.
2840 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
2841 Implementation of client factory.
2842 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
2843 initialize the MVP framework.
2844 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2845 New file. Activity manager for the main container widget. This is the
2847 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
2848 Maps place (URL) to its corresponding activity.
2849 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2850 New file. This is just a place holder for a generated file.
2851 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
2852 New file. Represents the URL for the main Online Glom app.
2853 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
2854 for changes in LayoutListViewImpl.
2855 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
2856 interface for View. Move code to OnlineGlomViewImpl class.
2857 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
2858 file. Implementation of OnlineGlomView.
2859 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
2860 Place resources. Use ClientFactoryImpl by default.
2862 2011-04-04 Ben Konrath <ben@bagu.org>
2864 Move View classes to their own package.
2866 This is the second commit of a refactor that will allow OnlineGlom to
2867 be used with multiple documents.
2869 * src/main/java/org/glom/web/client/OnlineGlom.java:
2870 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
2871 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
2873 2011-04-02 Ben Konrath <ben@bagu.org>
2875 Move UI code from the main module to its own class.
2877 This is the first commit of a refactor that will allow OnlineGlom to be
2878 used with multiple documents.
2880 * src/main/java/org/glom/web/client/LayoutListView.java: Update
2881 references to OnlineGlom to OnlineGlomView.
2882 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
2883 OnlineGlomView and instantiate it here.
2884 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
2885 represents the main OnlineGlomView with one document.
2887 2011-04-01 Ben Konrath <ben@bagu.org>
2889 Fix formatting of gwt.xml and add DTD.
2891 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
2893 2011-03-30 Ben Konrath <ben@bagu.org>
2895 Propperly convert gdkColor string to html colour string.
2897 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2899 2011-03-28 Ben Konrath <ben@bagu.org>
2901 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
2903 This implementation matches
2904 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
2905 readable and is not tied to Swig.
2907 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2909 2011-03-28 Ben Konrath <ben@bagu.org>
2911 Use read-only checkboxes for boolean field types.
2913 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
2914 in the CellTable based on the field type. It currently only
2915 distinguishes between boolean and text columns but I'll need to add
2916 support for more types.
2917 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2918 column type in the ColumnInfo object. Add method to convert between the
2919 glom field type enum in ColumnInfo and the glom field type in libglom.
2920 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
2922 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
2923 getting and setting booleans.
2925 2011-03-25 Ben Konrath <ben@bagu.org>
2927 Don't get the Date twice from the ResultSet.
2929 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2931 2011-03-25 Ben Konrath <ben@bagu.org>
2933 Cleanup code in the servlet.
2935 * TODO: Remove item about row count. Add item about testing row count
2936 query with large number of rows.
2937 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
2938 spelling mistakes, change method parameter to be consistent with
2941 2011-03-25 Ben Konrath <ben@bagu.org>
2943 Add server side logging with the gwt-log library.
2945 * .gitignore: Ignore the log file we're now producing.
2946 * TODO: Add a couple TODO item for logging.
2947 * pom.xml: Add gwt-log and log4j as a dependency.
2948 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2949 logging of errors, warnings and some important info.
2950 * src/main/resources/log4j.properties: New file to configure log4j.
2952 2011-03-24 Ben Konrath <ben@bagu.org>
2954 Add a disable button for the Details view.
2956 * src/main/java/org/glom/web/client/LayoutListView.java:
2958 2011-03-22 Ben Konrath <ben@bagu.org>
2960 Use a count query to get the number of rows for the list view pager.
2962 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2964 2011-03-22 Ben Konrath <ben@bagu.org>
2966 Add more TODO information about CellTable pager positioning.
2970 2011-03-19 Ben Konrath <ben@bagu.org>
2972 Add TODO item about CellTable pager positioning.
2976 2011-03-18 Ben Konrath <ben@bagu.org>
2978 Remove unneeded GlomFieldColumn class.
2980 This is just a small code cleanup.
2982 * src/main/java/org/glom/web/client/LayoutListView.java:
2984 2011-03-18 Ben Konrath <ben@bagu.org>
2986 Use cursor mode in the query that gets data for the list view.
2988 I still need to fix the potential memory problem when getting the row
2989 count for the list view.
2991 * TODO: Add note about testing memory usage with large data sets. Add
2992 item about fixing row counting with large data sets.
2993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Put the
2994 PostgreSQL JDBC driver into cursor mode when getting data for the
2997 2011-03-15 Ben Konrath <ben@bagu.org>
2999 Remove the GWT Container from the Eclipse build classpath.
3001 The GWT dependencies are set by Maven so this isn't needed.
3005 2011-03-15 Murray Cumming <murrayc@murrayc.com>
3007 Added some earlier mockups to git, but not to the tarball dist.
3009 * mockups/: Added some mockups from 2010-02 by Daniel Borgmann for
3010 Openismus. These hopefully show how we might structure the HTML so that
3011 it can be styled easily with CSS. However, we probably need to adapt them
3012 for the CSS structure that GWT dictates for common widgets.
3014 2011-03-14 Ben Konrath <ben@bagu.org>
3016 Locate OnlineGlom.properties using the ServletContext.
3018 This is required to be able to locate the file in the deployed servlet.
3020 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3021 Configure the database and glom document in in a helper method so
3022 that the ServletContext can be used to locate OnlineGlom.properties.
3023 * src/main/webapp/WEB-INF/OnlineGlom.properties: Moved from
3024 src/main/webapp. This is the proper location for .properites files.
3026 2011-03-12 Ben Konrath <ben@bagu.org>
3028 Add note to README about why we're compiling down to obfuscated JavaScript.
3032 2011-03-11 Ben Konrath <ben@bagu.org>
3034 Use properties file to configure servlet.
3036 This allows people to change the glom file path, db username and db
3037 password without recompiling the code.
3039 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3040 * src/main/webapp/OnlineGlom.properties:
3042 2011-03-11 Ben Konrath <ben@bagu.org>
3044 Use table fields in layout list view if the layout list is not defined.
3046 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3047 Manually create a LayoutFieldVector for the query builder using the
3048 table fields when a layout list is not defined in the glom file.
3050 2011-03-11 Ben Konrath <ben@bagu.org>
3052 Only show FIXME string for images when there's an image.
3054 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also included
3055 in this change are some small code cleanups.
3057 2011-03-11 Ben Konrath <ben@bagu.org>
3059 Set text for fields with TYPE_IMAGE and TYPE_INVALID to avoid NPEs.
3061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3063 2011-03-11 Ben Konrath <ben@bagu.org>
3065 Correctly set the index of the default table.
3067 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3068 Correctly set the index of the default table. Add commented out example
3071 2011-03-10 Ben Konrath <ben@bagu.org>
3073 Add comment to pom.xml about the previous change.
3075 * pom.xml: Add comment about the deployment issue so that it's obvious
3076 why java-libglom is set to the provided scope.
3078 2011-03-10 Ben Konrath <ben@bagu.org>
3080 Change java-libglom dependency from compile to provided in pom.xml.
3082 Since java-libglom uses jni it can only be loaded once and therefore
3083 must be placed in $CATALINA_HOME/lib and not included in each war.
3084 This directory is defined as /usr/share/tomcat6/lib/ on Ubuntu 10.04.
3085 More information about this issue can be found in the Tomcat 6 release
3086 notes in the "JNI Based Applications" section:
3088 http://tomcat.apache.org/tomcat-6.0-doc/RELEASE-NOTES.txt
3090 * README: Remove note about this issue. Deployment info should really
3091 be on the wiki anyway so I'll add it right now.
3092 * pom.xml: Change java-libglom dependency from compile to provided so
3093 that it's copied in to the packaged war.
3095 2011-03-09 Ben Konrath <ben@bagu.org>
3097 Change to using a neutral locale for currency, date and time formatting.
3099 This solves the problem of currency values being represented without a
3100 space between the currency code and the number (e.g. "EUR5.89" is now
3101 represented as "EUR 5.89"). More work is required when we implement
3102 a locale preference setting.
3104 * TODO: Add note about currency formatting issues with different
3106 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3107 to using the neutral ROOT locale.
3109 2011-03-09 Ben Konrath <ben@bagu.org>
3111 Add support for currency codes that are not ISO 4217 codes.
3113 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3114 the currency code defined in the glom file when it's not 3 characters
3115 long or when Java doesn't recognize the string as an ISO 4217 code.
3117 2011-03-08 Ben Konrath <ben@bagu.org>
3119 Remove test classes, launch configurations and configuration.
3121 The test stuff was getting in the way when creating the war. To make
3122 the war file you can now do 'mvn clean package'. The packaged war file
3123 will be in the target directory.
3125 * .classpath: Remove unused classpathentry for tests and i18n.
3126 * pom.xml: Remove junit.jar dependency. Properly use gwt.version
3127 property. Don't run test or i18n goals when packaging the war.
3128 * src/main/webapp/WEB-INF/web.xml: Add xml name space. Correct
3133 * OnlineGlomTest-dev.launch:
3134 * OnlineGlomTest-prod.launch:
3135 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
3136 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml:
3138 2011-03-07 Ben Konrath <ben@bagu.org>
3140 Update gwt-maven plugin to 2.2.0 and fix other configuation problems.
3142 These fixes allow me to use 'mvn deploy' to create the war file.
3144 * .classpath: This generated config has been updated by Eclipse. This
3145 change was probably triggered by me updating from Eclipse 3.6.1 to
3147 * .gitignore: Add entry to ignore the directory
3148 src/main/webapp/WEB-INF/deploy. This directory is generated by Eclipse.
3149 * .project: The generated config has been updated by Eclipse. This
3150 change was probably triggered by me updating from Eclipse 3.6.1 to
3152 * .settings/com.google.appengine.eclipse.core.prefs: Add empty config
3153 so that Eclipse doesn't complain
3154 * pom.xml: Update to gwt-maven-plugin 2.2.0.
3155 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java: Move from
3156 'tests' directory to 'client' directory. This is the new
3157 gwt-maven-plugin convension.
3158 * src/test/resources/org/glom/web/OnlineGlomJUnit.gwt.xml: Correctly
3159 refer to org.glom.web.OnlineGlom gwt module and OnlineGlomServiceImpl.
3161 2011-03-07 Ben Konrath <ben@bagu.org>
3163 Add support for horizontal alignment in the LayoutList columns.
3165 * TODO: Remove item about horizontal alignment. Add item about
3166 improvements to ColumnInfo.
3167 * src/main/java/org/glom/web/client/LayoutListView.java: Set horizontal
3168 alignment on the columns. Use ColumnInfo RPC object get the column
3169 title and horizontal alignment.
3170 * src/main/java/org/glom/web/client/OnlineGlom.java: Update
3171 LayoutListView creation with ColumnInfo RPC object.
3172 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
3173 a ColumnInfo object for every LayoutList columnn. Convert the
3174 FieldFormatting.HorizontalAlignment to the correct
3175 ColumnnInfo.HorizontatlAlignment with the new
3176 getColumnInfoHorizontalAlignment helper method.
3177 * src/main/java/org/glom/web/shared/ColumnInfo.java: New RPC object
3178 to encapsulate column information like alignment and title. This
3179 could be used to set the colour instead of on a per cell field basis.
3180 * src/main/java/org/glom/web/shared/LayoutListTable.java: Replace
3181 column title storage and retrieval with ColumnInfo.
3183 2011-03-04 Ben Konrath <ben@bagu.org>
3185 Add support for column sorting.
3187 * src/main/java/org/glom/web/client/LayoutListView.java: Change
3188 AsynDataProvider to be an anonymous inner class. Use new
3189 getSortedTableData RPC method when column sort is requested. Set all
3190 columns sortable and add an AsyncHandler to activate sorting in the
3192 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add new
3193 method getSortedTableData(). Cleanup other method signatures.
3194 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3195 new method getSortedTableData(). Cleanup other method signatures.
3196 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3197 Implement getSortedTableData() and getTableData() methods by using a
3198 private helper method with the appropriate parameters filled in. Use
3199 user supplied sort clause when supplied, otherwise fall back to
3200 sorting by the primary key. Move destroy() method to be underneath
3201 constructor for readability. Cleanup comments.
3203 2011-03-03 Ben Konrath <ben@bagu.org>
3205 Add support for colour text and colour backgrounds to the layout list cells.
3207 Only the cell backgrounds are coloured which leaves a gap between the
3208 cells that isn't coloured. I need to figure out a way to set
3209 'style=background-colour:' on the whole column rather than just the
3212 * TODO: Add a note about colouring the background of the whole column.
3213 * src/main/java/org/glom/web/client/LayoutListView.java: Add a custom
3214 column type (GlomFieldColumn) and a custom cell type (GlomFieldCell) to
3215 render the coloured text and backgrounds. Use GlomField[] for the row type.
3216 * src/main/java/org/glom/web/client/OnlineGlomService.java: Use GlomField[]
3218 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Use
3219 GlomField[] for the row type.
3220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
3221 GlomField[] for the row type. Set the text, text colour and background
3222 colour in the GlomField objects as specified in the glom document. Add
3223 method to convert from Gdk::Color to HTML colour string. Cleanup comments.
3224 * src/main/java/org/glom/web/shared/GlomField.java: New file to encapulate
3225 the glom field text, foreground colour and background colour.
3227 2011-03-02 Ben Konrath <ben@bagu.org>
3229 Don't display hidden tables in the combo box.
3231 * src/main/java/org/glom/web/client/OnlineGlom.java: Update code to use
3233 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3234 code to ignore hidden tables using ArrayLists for the table names and