1 2012-07-20 Murray Cumming <murrayc@murrayc.com>
3 tests: ConfiguredDocumentTest: Make this pass.
5 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
6 Disable tests that need a database connection.
8 2012-07-20 Murray Cumming <murrayc@murrayc.com>
10 Use Java 1.7 instead of Java 1.6.
12 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
13 to do this twice, at least for Eclipse.
14 This seems OK because it is the current version.
16 2012-07-20 Murray Cumming <murrayc@murrayc.com>
20 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
21 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
22 Avoid using a null Connection.
24 2012-07-20 Murray Cumming <murrayc@murrayc.com>
26 tests: Add a ConfiguredDocument test.
28 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
31 2012-07-20 Murray Cumming <murrayc@murrayc.com>
33 LayoutItemFIeld: getName(): Use the Field if it is set.
35 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
36 getName(): If the full field details have been set, return its name, so that
37 callers do not need to set the name separately.
38 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
39 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
40 so we can count the rows.
42 2012-07-20 Murray Cumming <murrayc@murrayc.com>
44 tests: SelfHoster: Test SqlUtils too.
46 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
47 Retrieve some data and check it too, as in the regular Glom
48 test_selfhosting_new_from_example.cc test.
49 * src/test/java/org/glom/web/server/SelfHoster.java:
50 createConnection(): Make this public.
52 2012-07-20 Murray Cumming <murrayc@murrayc.com>
54 tests: SelfHoster: createConnection(): Do not warn about expected failures.
56 Let the caller say if the connection is expected to fail, to avoid
57 irrelevant error output.
59 2012-07-20 Murray Cumming <murrayc@murrayc.com>
61 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
63 * src/test/java/org/glom/web/server/SelfHoster.java:
64 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
65 due to the inevitable need to retry the connection while the database server
68 2012-07-20 Murray Cumming <murrayc@murray.com>
70 tests: SelfHoster: createConnection(): Set a timeout.
72 * src/test/java/org/glom/web/server/SelfHoster.java:
73 createConnection(): Use setLoginTimeout() because it otherwise seems to take
74 ages to actually return when it fails.
76 2012-07-20 Murray Cumming <murrayc@murrayc.com>
78 tests: SelfHoster: selfHost(): Close the test connection.
80 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
81 When we check that the connection works, close the connection. This seems
82 to not be closed automatically otherwise.
84 2012-07-20 Murray Cumming <murrayc@murrayc.com>
86 Use slf4j-simple to see JDBC errors.
88 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
90 2012-07-19 Murray Cumming <murrayc@murrayc.com>
92 SelfHoster.discoverFirstFreePort(): Close the socket.
94 * src/test/java/org/glom/web/server/SelfHoster.java:
95 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
97 2012-07-19 Murray Cumming <murrayc@murrayc.com>
99 Avoid another code warning in Eclipse Juno.
101 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
102 Do instanceof checks on the FileUtils.listFiles() result and its
105 2012-07-13 Murray Cumming <murrayc@murrayc.com>
107 Avoid some code warnings in Eclipse Juno
109 * src/main/java/org/glom/web/server/libglom/Document.java:
110 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
111 * src/test/java/org/glom/web/server/SelfHoster.java
112 createTextFile(): Make sure that the FileOutputStream is closed.
114 2012-06-22 Murray Cumming <murrayc@murrayc.com>
116 Added OnlineGlomPropertiesTest.
118 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
119 Make sure we never return a null string.
120 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
121 Added tests of the OnlineGlomProperties API, using our sample file.
123 2012-06-20 Murray Cumming <murrayc@murrayc.com>
125 Make OnlineGlomProperties be a normal class.
127 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
128 Move OnlineGlomProperties into its own file to be a regular class:
129 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
130 This makes testing simpler.
132 2012-06-15 Murray Cumming <murrayc@murrayc.com>
134 OnlineGlomServiceImpl.init(): Move some code into a new method.
136 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
137 Create addDocument().
139 2012-06-15 Murray Cumming <murrayc@murrayc.com>
141 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
143 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
144 OnlineGlomProperties.getKey(): Make this more robust by moving the
145 check for *.*.filename to here.
147 2012-06-15 Murray Cumming <murrayc@murrayc.com>
149 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
151 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
152 init(): Move knowledge of the config file format into the
153 OnlineGlomProperties inner class.
155 2012-06-15 Murray Cumming <murrayc@murrayc.com>
157 SelfHostExampleTest: Make sure we cleanup on failure.
159 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
160 the use of cleanup() to a tearDown() JUnit method.
162 2012-06-12 Murray Cumming <murrayc@murrayc.com>
164 ConfiguredDocument: Add a primary key to portals at least once.
166 * src/main/java/org/glom/web/server/ConfiguredDocument.java
167 updatePortalsExtras): Fix a typo so that we add the primary key
168 column at least once.
169 This is a fix for the previous commit:
170 ConfiguredDocument: Do not add a primary key to portals each time.
172 2012-06-08 Murray Cumming <murrayc@murrayc.com>
174 SelfHoster: Avoid some compiler warnings.
176 * src/test/java/org/glom/web/server/SelfHoster.java
177 executeCommandLineAndWait():
178 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
179 the now-unused streams for stdout and stderr from the command Processes.
180 These are not used because readln() hangs while waiting for a new line,
181 where there may be no next line. The commented out code is still there
182 to help us figure out how to do this properly.
184 2012-06-08 Murray Cumming <murrayc@murrayc.com>
186 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
188 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
189 Make this actually test the cloning again, though it is not very useful
190 now that we do not use the part that had a problem with cloning before.
192 2012-06-08 Murray Cumming <murrayc@murrayc.com>
194 SelfHoster: Keep trying pg_ctl after starting postgres.
196 * src/test/java/org/glom/web/server/SelfHoster.java
197 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
198 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
199 regular Glom. This seems mad but it seems to work because the first
200 command would fail if pg_ctl would eventually fail.
202 2012-06-08 Murray Cumming <murrayc@murrayc.com>
204 SelfHoster: Wait until the server is really ready.
206 * src/test/java/org/glom/web/server/SelfHoster.java
207 selfHost(): Attempt the connection after starting the server, retrying
208 a few times if necessary, so that the server is really ready already when
209 we return from this method.
210 The regular Glom code does this too because pg_ctl reports success too soon.
212 2012-06-08 Murray Cumming <murrayc@murrayc.com>
214 ConfiguredDocument: Do not add a primary key to portals each time.
216 * src/main/java/org/glom/web/server/ConfiguredDocument.java
217 updatePortalsExtras(): Only add an extra primary key field if there is
218 none, to avoid adding one each time we retrieve the details layout from the
220 This should fix bug #676986 (Ben Konrath)
222 2012-05-25 Murray Cumming <murrayc@murrayc.com>
224 Document.load(): Support version 7 documents.
226 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
227 database_title attribute if the title attribute is not there.
230 2012-05-24 Ben Konrath <ben@bagu.org>
232 Add configuration for auto-generating mvn:i18n from with Eclipse.
234 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
236 2012-05-24 Murray Cumming <murrayc@murrayc.com>
238 Update translations, adding French.
240 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
241 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
242 Add a French translation, using the translation from Glom.
244 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
245 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
246 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
247 Update these based on the translations from Glom.
249 2012-05-24 Murray Cumming <murrayc@murrayc.com>
251 SelfHoster: Add some debug println messages to help when things fail.
253 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
254 System.out.println() lines.
256 2012-05-23 Murray Cumming <murrayc@murrayc.com>
258 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
260 * src/test/java/org/glom/web/server/SelfHoster.java:
261 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
262 instance) instead of just /usr/bin (as on Fedora). Check the result when
265 2012-05-23 Murray Cumming <murrayc@murrayc.com>
267 Remove LayoutItemPortal.get/setNavigationTable().
269 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
270 Remove get/setNavigationTable(), which is only a cache, because it is not
271 used, and does not need to be used, because that decision should be made on
273 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
274 updatePortalsExtras():
275 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
276 getNavigationRecord():
277 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
280 2012-05-21 Murray Cumming <murrayc@murrayc.com>
282 Initial self-hosting for tests.
284 * pom.xml: Change the scope for log4j, to hopefully make it
285 available to the test code which uses it indirectly via jOOQ.
286 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
287 self-hosting, though we only use it for testing.
289 * src/main/java/org/glom/web/server/libglom/Document.java:
290 example rows: Use a map instead of a list for each row of values,
291 so we know what field they are for, instead of relying on the sequence
292 being correct. This is not very efficient, but it does not really need
294 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
295 testReadTableExampleRows(): Adapted.
297 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
298 that returns an Object, for generic use. Note that Object seems to be
299 the implicit base even of double.
300 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
301 for use in CREATE TABLE SQL queries.
302 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
303 to do self-hosting of PostgreSQL databases via its command-line
304 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
305 backends/postgres_self.cc. This is incomplete - it needs more
306 warnings about failures and it needs to clean up properly when things
308 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
309 test of this new class.
311 2012-05-21 Murray Cumming <murrayc@murrayc.com>
313 Document: loading example data: Handle exceptions.
315 * src/main/java/org/glom/web/server/libglom/Document.java:
316 DateFormat.parse() and Double.valueOf() can throw exceptions, though
317 Eclipse did not warn about that.
319 2012-05-20 Murray Cumming <murrayc@murrayc.com>
321 Document: load(), save(): Handle the example rows.
323 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
325 * src/main/java/org/glom/web/server/libglom/Document.java:
326 load(), save(): Load and save the example rows, though the date, time
327 and image types are not handled properly yet.
328 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
329 Add testReadTableExampleRows() just to check that something is read.
331 2012-05-20 Murray Cumming <murrayc@murrayc.com>
333 Document: Add save().
335 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
336 Added getTranslationsMap() for use while saving.
337 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
338 Adedd getUseDefaultFormatting() for use while saving.
339 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
340 and several private methods that it uses.
342 This will be useful while testing via self-hosting.
343 It is not complete, but should be complete enough for testing.
345 2012-05-17 Murray Cumming <murrayc@murrayc.com>
347 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
349 * src/main/java/org/glom/web/client/OnlineGlomService.java
350 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
351 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
352 Remove getSortedListViewData() and getSortedRelatedListData(), adding
353 the sort column index and ascending bool to the regular method.
354 Instead, a sort column index of -1 now means no sort.
355 This is less explicit, but it's fairly simple, reduces the amount of
356 code, and makes the OnlineGlomService API slightly smaller.
357 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
358 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
360 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
361 getListViewData(), getRelatedListData():
362 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
363 getListViewData(), getRelatedListData():
364 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
366 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
368 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
373 2012-05-16 Murray Cumming <murrayc@murrayc.com>
375 Use translations for top-level groups too.
377 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
378 updateTitlesForLocale(): Use the translation for the group
379 as well as for child items.
383 Just recompiled to fix a problem in the released .tar.gz file.
387 2012-05-15 Murray Cumming <murrayc@murrayc.com>
389 Corrections to navigation to related records.
391 * src/main/java/org/glom/web/client/OnlineGlomService.java:
392 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
393 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
394 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
395 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
396 relationship name, because the relationship name is not necessarily unique
398 TOOD: This is inefficient, because it passes the whole list of
399 child field items back to the server, but it is more correct, and happens
400 to fix a bug with the primary key being lost after a few navigations.
401 There is probably a chance to make this more efficient anyway in some
404 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
405 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
406 * src/main/java/org/glom/web/server/ConfiguredDocument.java
407 * src/main/java/org/glom/web/server/database/DBAccess.java
408 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
409 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
412 2012-05-15 Murray Cumming <murrayc@murrayc.com>
414 Fix the use of translations.
416 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
417 Add updateTitlesForLocale().
418 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
419 Call it to discard unwanted translations and to make getTitle() return
420 the wanted translation wihout the need for the client code to specify a locale.
421 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
422 getTitle(): Fallback to the original title, as libglom does.
424 2012-05-15 Murray Cumming <murrayc@murrayc.com>
426 Document: Correctly report the number of available translation locales.
428 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
429 the available locale IDs list.
430 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
431 testLocales: Test this.
433 2012-05-15 Murray Cumming <murrayc@murrayc.com>
435 SqlUtils: Use camelCase.
437 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
438 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
439 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
440 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
441 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
442 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
444 2012-05-15 Murray Cumming <murrayc@murrayc.com>
446 Use jOOQ's tableByName() and fieldByName.
448 * pom.xml: Use jOOQ 2.3.1 to get the new API.
449 * src/main/java/org/glom/web/server/SqlUtils.java:
450 build_sql_select_step_with_where_clause(), .createField(),
451 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
452 so we can get correct quoting and escaping. Thanks to Lukas Eder for
453 adding this, and other things, to jOOQ.
455 2012-05-15 Murray Cumming <murrayc@murrayc.com>
457 SqlUtils: Remove the Connection parameters.
459 * src/main/java/org/glom/web/server/SqlUtils.java:
460 build_sql_select_with_key(), build_sql_select_with_where_clause(),
461 createSelect(), build_sql_select_step_with_where_clause(),
462 build_sql_count_select_with_where_clause(),
463 build_sql_select_count_rows(): Remove the Connection parameter because
464 jOOQ does not actually need a connectionwhen it is just used to build
466 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
468 * src/main/java/org/glom/web/server/ReportGenerator.java:
470 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
472 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
473 Constructor, getListData(), getResultSizeOfSQLQuery():
474 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
475 getSelectQuery(), getCountQuery():
476 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
477 getSelectQuery(), getCountQuery():
478 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
479 getNavigationRecord(): Adapted.
481 2012-05-14 Murray Cumming <murrayc@murrayc.com>
485 * src/main/java/org/glom/web/server/SqlUtils.java:
486 get_find_where_clause_quick(): Use a comparison of
487 lowercase values, instead of a simple equals. Regular Glom
488 uses the PostgreSQL ILIKE operator but jOOQ does not
489 support that just yet, though it will soon.
491 2012-05-14 Murray Cumming <murrayc@murrayc.com>
493 TableToViewDetails: Use a real serialization ID.
495 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
496 Though this does not fix the serialization problem.
498 2012-05-12 Murray Cumming <murrayc@murrayc.com>
500 Added LayoutItemPortalDeepCloneTest.
502 2012-05-11 Murray Cumming <murrayc@murrayc.com>
504 Make navigation work again.
506 * src/main/java/org/glom/web/server/libglom/Document.java:
507 Add getLayoutItemFieldShouldHaveNavigation().
508 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
509 Replace get/setAddNavigation() with the partly-existing
510 get/setNavigationTableName(), with an empty string being no navigation,
511 because this is simpler. Use the new
512 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
514 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
515 Add updateFieldsExtras() and call setNavigationTableName in it.
516 getDetailsLayoutGroup(),
517 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
518 createLayout(): Adapted.
519 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
520 Constructor: Adapted.
522 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
523 Replace get/setAddNavigation() with get/setNavigation(), returning a
524 TableToViewDetails class with both the table name and UsesRelationship,
525 because both are need. The previous code used java-libglom's output
526 variable (strangely, via sharedptr) to return both, but we cannot really
528 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
529 getNavigationRecord(): Adapt. However, we cannot actually use the cache
530 here because it somehow gets set to null during deepCopy(). I must test this.
531 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
532 testGetSuitableTableToViewDetails(): Adapted.
534 TODO: Find out why deepClone() is not quite working.
536 2012-05-11 Murray Cumming <murrayc@murrayc.com>
538 DBAccess: Simplify the retrievel of full field details.
540 * src/main/java/org/glom/web/server/database/DBAccess.java
541 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
542 because the Document loading should have done this.
544 2012-05-11 Murray Cumming <murrayc@murrayc.com>
546 Document: Correct loading of doubly-related layout fields.
548 * src/main/java/org/glom/web/server/libglom/Document.java:
549 loadUsesRelationship(): Actually set the related relationship, instead
550 of only setting it if it's not found.
552 2012-05-09 Murray Cumming <murrayc@murrayc.com>
554 Replace all appearances of Colour with color.
556 Because US English is dominant.
558 2012-05-09 Murray Cumming <murrayc@murrayc.com>
560 Use colors in HTML format, solving a warning about an unused function.
562 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
563 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
564 Add *asHTMLColor() versions of methods.
565 TODO: However, we should create and cache the results on the server.
566 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
567 * src/main/java/org/glom/web/client/ui/list/ListTable.java
568 * src/main/java/org/glom/web/server/ConfiguredDocument.java
569 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
570 Use the asHTMLcolor() versions.
572 2012-05-09 Murray Cumming <murrayc@murrayc.com>
574 ListViewTable: Constructor: Take the table name as a parameter.
576 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
577 Constructor: Take the tableName, and set the member variable, because
579 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
580 setCellTable(): Pass the table name.
581 This makes navigation to non-default tables work again. I don't know
582 why it worked before in the master branch.
584 2012-05-07 Murray Cumming <murrayc@murrayc.com>
586 ConfiguredDocument: Restore correct addition of hidden primary key items.
588 * src/main/java/org/glom/web/client/ui/list/ListTable.java
589 (ListTable.createCellTable): Uncomment out the check for the hidden
591 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
592 add primary key items for top-level lists and portals, as before,
593 instead of adding them to each group.
594 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
595 Actually implement the extra methods such as setHiddenPrimaryKey() and
596 comment that these are used only for top-level list groups and in portals.
597 This strangeness suggests even more that this should not be squeezed
598 into the LayoutGroup class.
600 2012-05-07 Murray Cumming <murrayc@murrayc.com>
602 Fix Formatting loading.
604 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
605 getFormattingUsed(): Remove the duplicate Formatting member variable
606 in favour of the one from the base class.
607 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
608 Initialize a new Formatting instead of using null by default, so we
609 have some defaults, instead of having to initialize one later just to
610 get the same defaults. This also makes loading of formatting from the
611 document work, because that expected a non-null.
613 2012-05-07 Murray Cumming <murrayc@murrayc.com>
615 RelatedListTable: Make sure that the tableName is set.
617 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
618 Constructor: Take the tableName so it is available later. Otherwise,
619 the server assumes that we mean the default table and cannot find the
621 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
622 setData(): Pass the tableName to the RelatedListTable constructor.
624 2012-05-07 Murray Cumming <murrayc@murrayc.com>
628 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
629 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
630 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
632 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
634 * src/main/java/org/glom/web/server/database/DBAccess.java:
635 convertResultSetToDTO(), getPortal():
636 * src/main/java/org/glom/web/server/database/ListDBAccess.java
638 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
639 Add checks for null objects and out of range access, with log messages to
640 give hints so we can fix these properly.
642 2012-05-07 Murray Cumming <murrayc@murrayc.com>
644 Portals: some corrections.
646 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
648 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
649 constructor: Use getRelationshipNameUsed() instead of getName(), because
650 that is what is meant.
651 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
652 getFromField(): Fix a typo, to get the field name, not the table name.
653 * src/main/java/org/glom/web/server/database/DBAccess.java:
654 getPortal(): Fix a typo that stopped this from working.
656 2012-05-07 Murray Cumming <murrayc@murrayc.com>
658 LayoutItemPortal: Also override getTitleOriginal().
660 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
661 This lets the base getTitle() with no parameters work.
662 TODO: Test this properly.
664 2012-05-06 Murray Cumming <murrayc@murrayc.com>
666 LayoutItemPortal: getTitle*(): Use the relationship title.
668 2012-05-06 Murray Cumming <murrayc@murrayc.com>
670 LayoutItemField: Fix loading of custom titles.
672 * src/main/java/org/glom/web/server/libglom/Document.java
673 loadDataLayoutItemField(): The title, if any, instead of the field
674 title, is stored in a title_custom node. Load it from there.
675 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
677 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
678 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
679 getTitle*() overrides.
680 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
683 2012-05-06 Murray Cumming <murrayc@murrayc.com>
685 LayoutItemField: Fall back to field titles, so some are really shown.
687 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
688 Override getTitleOriginal() and getTitle(), as in java-libglom.
689 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
692 2012-05-06 Murray Cumming <murrayc@murrayc.com>
694 Correct use of setExpectedResultSize().
696 * src/main/java/org/glom/web/server/ConfiguredDocument.java
697 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
698 Use setExpectedResultSize only on top-level groups (for instance, the
699 list layout) or on child portals (in details views).
700 Use the correct table name for portals to avoid SQL errors.
701 Update the expected counts when returning cached layouts.
703 2012-05-06 Murray Cumming <murrayc@murrayc.com>
705 Document: Interpret no group column count as 1.
707 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
708 default, though we now check for this in the UI code anyway.
710 2012-05-06 Murray Cumming <murrayc@murrayc.com>
714 2012-05-06 Murray Cumming <murrayc@murrayc.com>
716 Translatable: Use Hashmap instead of Treemap because GWT supports it.
718 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
719 The use of Treemap lead to this error from async methods, with no
721 "The response could not be deserialized"
723 2012-05-06 Murray Cumming <murrayc@murrayc.com>
725 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
727 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
728 when using the Google -> GWT Compile, or
729 g toolbar button -> GWT Compile Project... feature in Eclipse.
731 2012-05-06 Murray Cumming <murrayc@murrayc.com>
733 ListTable.addColumn(): Protect against a null Formatting.
735 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
736 Create a default Formatting if it is null, because that is the simplest
739 2012-05-06 Murray Cumming <murrayc@murrayc.com>
741 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
743 * src/main/java/org/glom/web/server/ConfiguredDocument.java
744 updateLayoutGroup(): Check that the field is not null.
746 2012-05-06 Murray Cumming <murrayc@murrayc.com>
748 ListViewImpl: Protected against a bad cast error.
750 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
751 onEnterKeyDown(): Do not cast without an instanceof check.
753 2012-05-06 Murray Cumming <murrayc@murrayc.com>
755 ListTable: Protect against an out of range error.
757 * src/main/java/org/glom/web/client/ui/list/ListTable.java
758 createCellTable(): This is unlikely, but can happen while debugging.
760 2012-05-06 Murray Cumming <murrayc@murrayc.com>
762 AsyncMessage onFailure() callbacks: Log the exception message.
764 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
765 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
766 * src/main/java/org/glom/web/client/activity/ListActivity.java:
767 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
768 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
769 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
770 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
771 These are useful clues when something is wrong.
773 2012-05-06 Murray Cumming <murrayc@murrayc.com>
775 ConfiguredDocument: Avoid a null dereference.
777 * src/main/java/org/glom/web/server/ConfiguredDocument.java
778 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
779 details maps are created.
781 2012-05-06 Murray Cumming <murrayc@murrayc.com>
783 Document: Correct the port number parsing.
785 * src/main/java/org/glom/web/server/libglom/Document.java:
786 This lets us actually connect to the database and show the document.
788 2012-05-05 Murray Cumming <murrayc@murrayc.com>
792 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
793 user-interaction, asking us to load a temporary URL in a browser.s
794 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
795 which is apparently necessary for testing the service. See the comment.
796 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
797 Show the exception, if any. This is how I saw the 404 in the HTML in
800 2012-05-05 Murray Cumming <murrayc@murrayc.com>
802 DocumentTest: Move the .glom files into the resources directory.
804 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
805 URI via getResource().
807 2012-05-05 Murray Cumming <murrayc@murrayc.com>
809 Document: Remove the FieldIdentifies inner class.
811 * src/main/java/org/glom/web/server/libglom/Document.java: We only
812 use the Relationship (though the same function in libglom is maybe
813 used in other ways) and so this removes a compiler warning.
815 2012-05-05 Murray Cumming <murrayc@murrayc.com>
817 Document.load() Remove the error code parameter.
819 * src/main/java/org/glom/web/server/libglom/Document.java: load():
820 Remove the parameter. We do not set it yet and it could never have
821 worked as an output parameter (though maybe it did in java-libglom).
822 We could use an exception if we really want the failure reason.
823 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
825 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
826 setUp(), testGetSuitableTableToViewDetails(): Adapt.
828 2012-05-05 Murray Cumming <murrayc@murrayc.com>
830 Make some inner classes static.
832 * src/main/java/org/glom/web/server/ConfiguredDocument.java
833 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
834 * src/main/java/org/glom/web/server/ReportGenerator.java
835 * src/main/java/org/glom/web/server/libglom/Document.java
836 Make all inner classes static that can be static.
838 2012-05-05 Murray Cumming <murrayc@murrayc.com>
840 OnlineGlomServiceImpl: Do not load and check for java-libglom.
842 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
843 init(): We do not use java-libglom any more.
845 2012-05-05 Murray Cumming <murrayc@murrayc.com>
847 Remove mentions of java-libglom.
849 * README: Remove mention of java-libglom, because it no longer needed.
850 * utils/build-onlineglom-war.sh:
851 * utils/check-and-recover-tomcat.py:
852 * utils/install-onlineglom-war.sh: Remove these as they are no longer
853 useful. Building is now far easier, with no need for jhbuild.
855 2012-05-05 Murray Cumming <murrayc@murrayc.com>
857 Fix the build (mvn package)
859 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
860 (LayoutGroup): Make the LayoutItemList inner class static and protected.
861 Otherwise the GWT Java->Javascript compilation fails with just this
862 error, during mvn package or when attempting to view in a browser,
863 in the GWT developer mode in Eclipse.
865 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
866 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
867 [INFO] Compiling module org.glom.web.OnlineGlom
868 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
869 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
870 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
871 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
872 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
873 [INFO] [ERROR] Cannot proceed due to previous errors
875 It has taken me 2 days to find out what was causing that. After reducing
876 the code, the compiler eventually showed me the full error message.
878 2012-05-04 Murray Cumming <murrayc@murrayc.com>
880 ConfiguredDocument: Cache the cloned and stripped layouts.
882 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
883 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
884 layout in a map, so we can retrieve it again without rebuilding it.
886 2012-05-04 Murray Cumming <murrayc@murrayc.com>
888 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
890 2012-05-04 Murray Cumming <murrayc@murrayc.com>
892 libglom classes: Implement some auto-generated emthods.
894 2012-05-04 Murray Cumming <murrayc@murrayc.com>
896 Add GwtTestOnlineGlomService.
898 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
899 However, this (and the other GwtTest*) does not seem to run during
902 2012-05-04 Murray Cumming <murrayc@murrayc.com>
904 Remove use of unsupported features from client code.
906 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
907 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
908 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
909 Use our client version of StringUtils instead of the apache commons one.
911 However, the GWT Javascript compliation still fails.
913 2012-04-25 Murray Cumming <murrayc@murrayc.com>
915 Add a Field class and implement some loading of it in Document.
917 2012-04-25 Murray Cumming <murrayc@murrayc.com>
919 Initial Document loading implementation, instead of libglom.
921 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
922 and Translatable classes, and adapt the rest of the code to use them.
923 However, this is still missing Layout and Field classes and loading.
925 2012-04-24 Murray Cumming <murrayc@murrayc.com>
927 Use of jOOQ: Move Field creation into a utility method.
929 * src/main/java/org/glom/web/server/SqlUtils.java:
930 This lets us improve it more easily.
932 2012-04-24 Murray Cumming <murrayc@murrayc.com>
934 Use of jOOQ: Improve the code to COUNT a sub-select.
936 * src/main/java/org/glom/web/server/SqlUtils.java:
937 Move initial query creation into
938 build_sql_select_step_with_where_clause().
939 build_sql_select_count_rows(): Use the jOOQ API instead of
940 concatentating text, because a jOOQ Select*Step is a TableLike,
941 which is what from() takes.
943 2012-04-23 Murray Cumming <murrayc@murrayc.com>
945 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
947 * pom.xml: Depend on jooq.
948 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
949 methods with jOOQ, based on the C++ implementations in libglom,
950 with some changes to the logic required by jooQ.
951 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
953 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
954 * src/main/java/org/glom/web/server/ReportGenerator.java:
955 * src/main/java/org/glom/web/server/SqlUtils.java:
956 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
957 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
958 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
959 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
960 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
961 Adapt. In particular, the SqlUtils methods now need to take a Connection,
962 because jOOQ needs that, though it seems unnecessary.
964 This is not quite finished. Ideally jOOQ would help us to build
965 table_name.field_name names, quoting and escaping them properly.
966 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
968 2012-04-21 Murray Cumming <murrayc@murrayc.com>
970 Move use of Glom.build_sql*() into a new SqlUtils class.
972 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
973 to wrap Glom.build_sql*(). The parameter types are still Glom one,
974 but this will make it easier to start using something other than
975 libglom or SqlBuilder.
977 2012-04-21 Murray Cumming <murrayc@murrayc.com>
979 Update the project URL.
981 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
983 2012-04-21 Murray Cumming <murrayc@murrayc.com>
985 Main layout: Use a FlowTable instead of absolute positioning.
987 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
988 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
989 child panels/widgets must have an absolute position. But that is annoying, so
990 this adds a FlowTable and puts the child panels in there.
992 2012-04-21 Murray Cumming <murrayc@murrayc.com>
994 GwtTestOnlineGlom: Comment out unused code.
996 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
997 Eclipse has started to say that some code is unused.
999 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1001 Update to the latest versions of dependencies.
1003 * pom.xml: Update version numbers of dependencies to the latest
1005 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1006 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1007 * src/main/java/org/glom/web/server/ReportGenerator.java:
1008 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1009 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1010 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1012 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1013 Modify the imports where necessary.
1015 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1017 Style: Remove overflow:hidden from searchbox
1019 * src/main/webapp/style.css: Because this pushes the Back To Link
1020 label/link on to the next row, which is then hidden due to the
1021 hard-coded (in ems) height.
1023 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1025 Remove some duplicate code.
1027 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1028 getDocumentInfo(): This must have been duplicated during the merge from the
1033 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1035 Reports: Localize the waiting for report message.
1037 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1038 start(): Get the message from the contants.
1039 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1040 Add the string here.
1041 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1042 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1043 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1044 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1045 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1046 Update these files with the English text for newer strings for now.
1048 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1050 Reports: Show a message while waiting for the report.
1052 * src/main/java/org/glom/web/client/ui/ReportView.java
1053 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1054 Add setWaitingText(), to show a message saying that we are
1055 waiting for the report to be ready.
1056 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1057 start(): Call setWaitingText() before calling the async
1060 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1062 ReportGenerator: Specify date and time formats.
1064 * src/main/java/org/glom/web/server/ReportGenerator.java:
1065 createFieldValueElement(): Use the default (and localized)
1066 short formats, though we still need a way to show 4-digit
1067 years without providing the format for every locale.
1068 * src/main/java/org/glom/web/server/database/DBAccess.java:
1069 convertResultSetToDTO(): Use the short formats here too.
1071 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1073 ReportGenerator: Use the correct numeric formatting.
1075 * src/main/java/org/glom/web/server/ReportGenerator.java
1076 createFieldExpression(), createFieldValueElement(): Take the
1077 whole LayoutItem_Field instead of just the field name, so
1078 we have access to the formatting.
1079 createFieldValueElement(): Use JRTextField.setPattern() to
1080 specify the numeric formatting, with the help of a
1081 regular DecimalFormat.
1083 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1085 ReportGenerator: Avoid showing null for group by titles.
1087 * src/main/java/org/glom/web/server/ReportGenerator.java
1088 generateReport(): Use setBlankWhenNull() on the field title
1089 style too, because this is used for values in group by
1092 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1094 ReportGenerator: Add a colon to titles in vertical groups.
1096 * src/main/java/org/glom/web/server/ReportGenerator.java
1097 addFieldToDetailBandVertical(): Pass true for the withColon
1100 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1102 ReportGenerator: Simplify the code by using Position more.
1104 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1106 Reports: Support vertical groups, roughly.
1108 * src/main/java/org/glom/web/server/ReportGenerator.java:
1109 addToReport(): Rename to addGroupToReport() and, if necessary,
1110 call the new addVerticalGroupToReport() method.
1111 createFieldValueElement(): Let the caller specify the Y position
1114 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1116 Reports: Allow a second report to be shown.
1118 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1119 clear(): Do not remove the HTML widget, which broke the whole layout.
1121 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1123 Locales drop-down: Show that we use English by default.
1125 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1126 fillView(): When we use English, just because that is the default, when
1127 no locale is specified, show that in the Locales drop-down instead of
1128 just showing the first item.
1130 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1132 Unselect the Report/Locale/Table combo item when appropriate.
1134 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1135 setPlace(): clear reportName if this is not a ReportPlace.
1136 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1137 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1138 When the provided name is empty, unselect all items, so that none are
1139 indicated. This uses a for loop because I cannot find a single method
1142 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1144 Report: Give the user a way to get back to the list.
1146 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1147 start(), setPlace(): Show the Back To List link on reports, and also
1148 interpret selecting the empty report item as back to list.
1150 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1152 Really show the selected Report name.
1154 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1155 setPlace(): Store the reportName here, if it is that kind of Place.
1156 fillView(): Set the selected Report after filling the list of reports.
1157 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1158 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1159 null Strings, though we need some way to unselect all ListBox items
1162 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1164 ReportGenerator: Try to avoid some problems.
1166 * src/main/java/org/glom/web/server/ReportGenerator.java
1167 addField(): Try to avoid duplicates, and avoid using a null
1170 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1172 Reports: Use quickFind.
1174 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1175 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1177 getReportHTML(): Add a quickFind parameter.
1178 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1179 start(): Pass the quickFind parameter.
1180 * src/main/java/org/glom/web/server/ReportGenerator.java
1181 generateReport(): Take a quickFind parameter.
1183 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1185 ReportPlace: Actually use the report name.
1187 * src/main/java/org/glom/web/client/place/ReportPlace.java
1188 getPlace(): Do not assign the report name to the quickfind.
1190 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1192 Show java.library.path when complaining.
1194 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1195 init(): When telling us to check java.library.path, show the
1198 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1200 ReportGenerator: Do not show nulls.
1202 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1204 ReportGenerator: Make the title font larger.
1206 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1208 ReportGenerator: Put field titles inside groups, if there are groups.
1210 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1212 ReportGenerator: Take the Report itself instead of the name and group.
1214 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1215 Remove getReportLayoutGroup().
1216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1217 getReportHTML(): Pass the report instead
1218 of its name and layout group.
1219 * src/main/java/org/glom/web/server/ReportGenerator.java
1220 generateReport(): Use the report object to use the title
1221 instead of the name.
1223 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1225 ReportGenerator: Remove designBand parameters.
1227 * src/main/java/org/glom/web/server/ReportGenerator.java:
1228 Make designBand a class member instead of passing it to all
1231 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1233 ReportGenerator: Add lines, a bit like in the desktop version.
1235 * src/main/java/org/glom/web/server/ReportGenerator.java
1236 addToReport(): Use JRDesignLine.
1238 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1240 ReportGenerator: Correct the title positions and use some bold style.
1242 * src/main/java/org/glom/web/server/ReportGenerator.java:
1243 Break the code up into reusable functions, correct the placement of
1244 titles, and use normal/bold styles as in the reports in the desktop
1247 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1249 ReportGenerator: Add a header band to show the field titles.
1251 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1252 getReportHTML(): Pass the localeId to the ReportGenerator
1254 * src/main/java/org/glom/web/server/ReportGenerator.java
1255 constructor: Take the localeID so we can get translated field
1257 generateReport(), addToReport(), addFieldToBand(): Add field
1258 titles in a column header band.
1260 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1262 Reports drop-down list: Some improvement.
1264 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1265 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1266 Adedd setSelectedReport(),
1267 setReportList(): Add a blank line so that the user can select the
1269 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1270 start(): Show the current report by calling setSelectedReport().
1271 This does not seem to work yet.
1273 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1275 DetailsActivity, ListActivity: Move some variables into a base class.
1277 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1278 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1279 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1280 the clientFactory, documentID, tableName and authenticationPopup into
1281 a base class, to avoid duplication.
1283 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1285 Translate the Reports label.
1287 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1288 Get the "Reports" label string from the constants.
1289 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1290 perties: Add Reports to the constants.
1292 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1294 Reports: Implement grouping.
1296 * src/main/java/org/glom/web/server/ReportGenerator.java:
1297 Handle LayoutItem_GroupBy items and try to do the right thing
1298 with JRDesignGroup. It seems to work.
1300 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1302 Actually show some data with JasperReports.
1304 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1305 getReportHTML(): Move most code into a ReportGenerator class.
1306 * src/main/java/org/glom/web/server/ReportGenerator.java:
1307 Recurse into sub-groups, adding fields to the JasperDesign's details
1308 band. Note that we must set an arbitrary width and height, or it just
1309 will not show any data.
1311 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1313 Reports Chooser: Show the titles, not the names.
1315 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1316 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1317 and the names as the values.
1318 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1319 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1320 group now that we provide the report name, so it should always
1323 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1325 Depend on jasperreports.
1327 * pom.xml: Add the dependency. My plan is to use this on the
1330 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1332 Implement navigation to report places.
1334 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1335 start(): Do not bother to handle all events here.
1336 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1337 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1338 Added getSelectedReport().
1339 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1340 .java: start(): When handling a change to the reports chooser,
1341 call getSelectedReport() and goTo() its ReportPlace.
1342 * src/main/java/org/glom/web/client/ui/ReportView.java
1343 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1344 Added setReportHTML() which puts the html in a gwt HTML widget.
1345 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1346 getReportHTML(): Return "TODO" just to show that this works.
1348 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1350 Make ReportPlace usable.
1352 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1353 Mention ReportPlace.
1354 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1355 Correct the @prefix annotation.
1357 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1359 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1361 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1362 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1363 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1364 Change getReportLayout() to getReportHMTL() because we will not need to
1365 parse or render the report layout on the client side.
1366 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1367 getReportLayout(): Return the libglom LayoutGroup type because we will
1368 not need to convert to a shared type, because this will not be used on
1370 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1373 Note that there is still no implementation for this.
1376 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1378 Add a (empty) Report Place, View, and Activity.
1380 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1382 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1383 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1384 this into a superclass:
1385 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1386 and also use it as the base of this new ReportPlace:
1387 * src/main/java/org/glom/web/client/place/ReportPlace.java
1389 * src/main/java/org/glom/web/client/ui/ReportView.java
1390 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1391 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1392 Add these, containing mostly boiler-plate for now.
1394 * src/main/java/org/glom/web/client/OnlineGlomService.java
1395 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1396 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1397 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1398 Add API to get the LayoutGroup for the report.
1400 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1402 Add and fill a Reports drop-down list box.
1404 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1406 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1407 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1408 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1409 Added getReports(document, table, localeID), calling
1410 ConfiguredDocument.getReports().
1411 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1412 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1413 Added setReportsList() and a list widget.
1414 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1415 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1420 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1422 Translations: Add Esperanto.
1424 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1425 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1426 properties: Add this translation because someone took the time to make it.
1428 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1430 Adapt to the java-libglom 1.21.7 API.
1432 * src/main/java/org/glom/web/server/ReportGenerator.java:
1433 addToReport(): get_group_secondary_fields() is now
1434 get_secondary_fields().
1437 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1439 Use the latest java-libglom version.
1441 * pom.xml: Use java-libglom 1.21.7.
1443 2012-03-03 Ben Konrath <ben@bagu.org>
1445 Display date and time in details view.
1447 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1449 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1451 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1453 Require the latest java-libglom.
1455 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1457 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1459 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1461 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1462 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1463 an empty quickfind string. I also corrected libglom to create only
1464 empty where clauses for empty quickfind strings, but this avoids the
1467 2012-02-24 Ben Konrath <ben@bagu.org>
1469 Improve the tabs in the Notebook widget.
1473 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1475 Translations: Try to translate the strings.
1477 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1478 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1479 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1480 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1481 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1482 Take the Open translation from GTK+'s .po files.
1483 Take the Details translation from Glom's po files.
1484 I have added the other strings to Glom so we can get translations that way:
1485 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1487 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1489 TableSelectionViewImpl: Put the search label and entry in a div.
1491 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1492 Put the search widgets in a FlowTable so that the CSS can be used to
1493 style them while keeping them together.
1494 * src/main/webapp/style.css: Mention the new div.
1496 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1498 Translate more strings in more locales.
1500 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1501 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1502 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1503 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1504 Translate the "Details" and "Open" string too.
1506 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1507 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1508 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1509 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1510 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1511 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1512 Add these new locales as placeholders though they currently contain English.
1514 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1516 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1518 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1519 Check the ConfiguredDocument* for null before using it.
1521 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1523 Tell Eclipse about the generated java files.
1525 * .classpath: This lets it find OnlineGlomConstants.java.
1526 It would be nice if Eclipse just used the maven build files.
1528 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1530 Prevent a crash when no locale is specified in the URL.
1532 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1533 Avoid returning a null string, obtained from
1534 Window.Location.getParameter(). This caused a crash when it was
1535 later passed to libglom's API.
1536 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1537 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1538 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1539 guard against future null strings.
1541 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1543 Use the ?locale= query param instead of the &lang= token param.
1545 * src/main/java/org/glom/web/client/place/ListPlace.java
1546 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1547 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1548 Remove the lang token key and value.
1550 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1551 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1552 When the user selects a different locale from the chooser, use
1553 Window.Location.assign() to change the URL, which then causes a reload.
1555 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1556 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1557 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1558 * src/main/java/org/glom/web/client/activity/ListActivity.java
1559 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1560 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1561 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1562 * src/main/java/org/glom/web/client/ui/ListView.java:
1563 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1565 Remove localeID member variables and method/constructor parameters, instead
1566 using Utils.getCurrentLocaleID() when we need a localID to pass to
1569 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1571 Internationalize the UI strings.
1573 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1574 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1575 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1576 because it is unused. Messages are apparently strings that can have
1577 parameters, but we do not need that yet, so Contants will be enough for now.
1578 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1579 to say that we support the en and de locales.
1580 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1581 The original English strings.
1582 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1583 Some German translations of the English strings.
1584 The i18n goal then uses the .properties file to generate an
1585 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1586 returns an implementation that returns the translated strings.
1587 The documentation suggests putting these in src/java/*/client/, but it seems
1588 best to put it in src/resources/*/client/.
1589 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1590 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1591 instead of hard-coding them.
1592 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1593 but that does not seem to stop the build, though it confuses Eclipse.
1595 You can see the translated string by adding ?locale=de to the URL, like so:
1596 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1598 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1600 Improve null/empty String checks.
1602 * pom.xml: Add a dependency on commons-lang, to use
1603 org.apache.commons.lang.StringUtils.
1604 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1605 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1606 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1607 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1608 Use StringUtils.isEmpty().
1610 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1611 StringUtils class with a static isEmpty() function because we
1612 cannot use org.apache.commons.lang.StringUtils in client-side
1613 GWT code because it (apparently) cannot be compiled to javascript.
1614 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1615 * src/main/java/org/glom/web/client/activity/ListActivity.java
1616 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1617 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1618 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1619 * src/main/java/org/glom/web/client/place/ListPlace.java
1620 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1621 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1622 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1623 * src/main/java/org/glom/web/client/ui/details/Group.java
1624 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1625 our StringUtils.isEmpty() function.
1627 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1629 Update to the latest java-libglom API.
1631 * pom.xml: Require java-libglom 1.21.4.
1632 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1633 getDocumentInfo(), getListViewLayoutGroup():
1634 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1636 * src/main/java/org/glom/web/server/database/DBAccess.java
1637 getFieldsToShowForSQLQueryAddGroup(),
1638 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1639 with either get_database_title_original() or
1640 get_database_title(localeID).
1642 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1644 ConfiguredDocument: Avoid a null pointer exception.
1646 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1647 Initialize localeID to "" to avoid returning a null String which
1648 causes a crash in java-libglom's swing-generated code.
1650 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1652 Some simple renaming.
1654 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1655 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1656 for localeChooser. This seems more appropriate and is less ambiguous
1657 particularly in the .css file.
1659 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1661 ConfiguredDocument: Rename the localedID private member variable.
1663 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1665 Adapt to the latest java-libglom API from git master.
1667 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1668 libglom now uses only Vector instead of List, which uses add() instead of
1671 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1673 ConfiguredDocument: Rename the localedID private member variable.
1675 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1677 Build a source tarball with mvn assembly:single
1679 * assembly.xml: Add this file.
1680 * pom.xml: Use the maven-assembly-plugin and tell it to use
1681 our assembly.xml file.
1683 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1685 OnlineGlomServiceImpl: Get .glom files recursively.
1687 * pom.xml: Depend on commons-io from org.apache.commons.
1688 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1689 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1690 files recursively, and with the easier filter for the extension.
1691 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1692 simplify that code too.
1694 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1696 README: Mention that you must install java-libglom packages separately.
1698 But then it works, because java-libglom is now in the central maven
1701 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1703 locales drop-down: Show the correct selected locale when the URL changes.
1705 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1706 .java: setPlace(): Move some code into fillView().
1708 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1710 locales drop-down: Do not lose the primary key.
1712 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1713 start(): onLocaleChange(): Pass the current primary key value,
1714 instead of an empty value.
1716 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1718 locales drop-down: Do not lose the drop-down selection.
1720 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1721 .java (TableSelectionActivity.fillView): Set the selected locale
1722 after changing the drop-down items (though we do not really need
1723 to change them just because the locale changes.)
1725 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1727 locales drop-down: Change the tables list when this changes.
1729 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1730 .java: TableSelectionActivity.start(): Move the async table titles
1731 retrieval into a private fillView() method and also call this when
1732 the chosen locale changes.
1733 Note that the document title is not actually translatable yet, but
1734 that is a problem that I should fix soon in libglom.
1736 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1738 Improve the placement of the locales drop-down.
1740 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1741 Put the title and locales drop-down in a div (gwt.FlowTable).
1742 * src/main/webapp/style.css: Add magic css properties to make this work.
1743 Also remove the left margin from the title so that it lines up with the
1746 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1748 locales selector: Show human-readable locale titles.
1750 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1751 getDocumentInfo(): Use java.util.Locale to show a real title of
1752 each locale, in the locale's own language.
1754 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1756 Add a language/locale selector drop-down.
1758 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1759 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1760 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1761 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1762 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1763 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1764 Add a ListBox to show the available locales. Add getLocaleSelector(),
1765 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1766 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1767 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1768 java: Add these classes.
1769 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1770 start(): Fill the locales ListBox. Handle its change event, firing a
1772 setPlace(): Show the selected locale as specified by the URL token.
1773 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1774 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1775 Handle LocaleChangeEvent, going to a new *Place with that locale.
1777 The placement of the ListBox is not pretty, and it currently uses the ID
1778 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1782 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1784 Search box: Show the search text from the URL token.
1786 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1787 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1788 Add setQuickFindText().
1789 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1790 .java: setPlace(): Store the queryText if the place is a ListPlace,
1791 and call TableSelectionView.setQuickFindText().
1793 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1795 Allow use of translations via, for instance, &lang=de in the URL.
1797 * pom.xml: Use the unstable java-libglom 1.21 version.
1799 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1800 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1801 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1802 init(): Instead of calling TranslatableItem.set_current_locale()
1803 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1804 However, this is only for default locales, which are not needed to
1805 change the locale in the URL.
1806 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1807 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1808 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1809 layout for a particular locale.
1810 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1811 Add get/setDefaultLocaleID().
1812 getDocumentInfo(), getListViewData(), getRelatedListData(),
1813 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1814 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1815 localeID parameter, so we can get the layout for a particular locale.
1817 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1818 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1819 * src/main/java/org/glom/web/client/place/ListPlace.java:
1820 Parse and construct a lang parameter too.
1822 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1823 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1824 passed to subsequent methods and constructors.
1825 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1826 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1827 Store the localeID from the *Place and pass it to other constructors
1828 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1830 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1831 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1832 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1833 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1834 * src/main/java/org/glom/web/client/ui/ListView.java:
1835 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1836 Take localeID parameters and pass them to subsequent constructors and
1837 methods, so that the layout is always retrieved for that locale.
1839 This is rather repetitive.
1841 Note that "" means the original (default) locale of the Glom document,
1842 which is usually English.
1844 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1846 Documents: Remove final keyword to fix startup configuration.
1848 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1849 final keywords on the private member variables because that breaks
1850 the startup, apparently (there are warnings) because it stops them
1851 from being serialized. I added these in the previous commit.
1853 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1855 Documents: Add some final keywords.
1857 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1860 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1862 OnlineGlomServiceImpl: Add to overview comments.
1864 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1865 Note that this is where all the document are loaded. They are not
1866 loaded freshly for each page.
1868 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1872 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1873 Add a TextBox for the text of a quick find.
1874 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1876 setBackLink(): Add a String quickFind parameter.
1877 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1878 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1879 to the base interface, because that is how TableSelectionViewImpl is used.
1880 * src/main/webapp/style.css: Add style for the search box and its label.
1882 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1883 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1884 Add these files, based on the existing TableChangeEvent and
1885 TableChangeEventHandlers.
1886 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1887 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1888 a ListPlace() that the user should be taken to.
1889 * src/main/java/org/glom/web/client/activity/ListActivity.java
1890 start(): Handle it here too and adapt the TableChangeEvent handler to
1891 pass the extra "" quickFind parameter to ListPlace.
1892 * src/main/java/org/glom/web/client/place/ListPlace.java:
1893 Constructor: Take an extra String quickFind parameter and store it,
1894 returning it from a new getQuickFind() method.
1895 getToken(): Put the quickFind text in the URL token.
1896 getPlace(): Parse the quickFind text from the URL token.
1897 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1898 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1899 ListPlace constructor.
1900 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1901 .java: start(): Add a Change handler for the TableSelectionView's
1902 TextBox (via its base HasChangeHandlers interface), firing the new
1903 QuickFindChangeEvent.
1904 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1905 pass the extra "" quickFind parameter.
1907 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1908 setCellTable(): Add a String quickFind parameter and pass it to
1909 the ListViewTable() constructor.
1910 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1911 setCellTable() in the base interface, because that is how ListViewImpl
1914 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1915 Add a String quickFind member variable.
1916 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1917 Constructor: Add a String quickFind parameter, storing it in the
1918 base ListTable's member variable.
1919 onRangeChanged(): Pass quickFind to the
1920 OnlineGlomServiceAsync.getSortedListViewData() and
1921 OnlineGlomServiceAsync.getListViewData() methods.
1923 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1924 getListViewData(), getSortedListViewData(): Add a String quickFind
1925 parameter, passing it to ConfiguredDocument.getListViewData().
1926 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1927 Change getListViewData(), getSortedListViewData() in the base interface,
1928 because that is how OnlineGlomServiceImpl is used, via this:
1929 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1930 Change getListViewData(), getSortedListViewData() here too.
1931 This class can apparently be used to asynchronously call methods on
1932 OnlineGlomService, and GWT seems to implement that after recognizing
1933 just the *Async name convention and the extra AsyncCallback parameters.
1935 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1936 getListViewData(): Add a String quickFind parameter, and pass it to
1937 ListViewDBAccess.getData().
1938 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1939 getListData(): Add a String quickFind parameter and pass it to
1941 getSelectQuery(): Add a String quickFind parameter.
1942 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1943 getSelectQuery(): Add a String quickFind parameter and use it with
1944 Glom.get_find_where_clause_quick() to pass a where_clause to
1945 Glom.build_sql_select_with_where_clause(), to actually filter the
1947 getData(): Add a String quickFind parameter, passing it to getListData().
1948 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1949 va: getData(): Pass an empty string to getListData() for the
1950 quickFind parameter.
1952 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1954 ListTable: Minor change.
1956 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1957 createCellTable(): Make this protected instead of public.
1959 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1961 Many files: Use final for the parameters and use the @override attribute.
1963 2012-01-22 Ben Konrath <ben@bagu.org>
1965 Add anchor links for single line text that starts with http, ftp and www.
1969 2012-01-22 Ben Konrath <ben@bagu.org>
1971 Add ellipsis to single line text in details view.
1975 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1977 Remove all javadoc author tags.
1979 Because they are awkward and meaningless when many people touch
1981 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1983 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1985 Revert the COPYING.LESSER to COPYING rename.
1987 Apparently both should be there if it is LGPL.
1989 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1991 *View: Remove unused imports.
1993 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1994 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1995 * src/main/java/org/glom/web/client/ui/ListView.java:
1996 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1997 Remove unused imports, as suggested by Eclipse.
1999 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2001 Move the *View::Presenter types, and some API into one base View.
2003 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2004 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2005 * src/main/java/org/glom/web/client/ui/ListView.java:
2006 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2007 Presenter, setPresenter() and clear() into a shared base interface,
2008 to avoid the unnecessary duplicate Presenter types and to more clearly
2009 show how the *Views share the same structure, even if they are not
2010 used polymorphically.
2012 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2013 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2015 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2016 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2017 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2019 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2022 Feel free to revert this if there is a good reason for the duplicate
2025 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2027 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2029 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2030 a class member instead of a local variable in the method.
2031 This lets us use it to get the view instances, for use in tests.
2032 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2033 beforeOnlineGlom(): Test some more details of the initial view.
2034 Again, this is not very useful.
2036 To really test gwt-glom we will need to start a local postgresql
2037 instance with local data, like the Glom tests in C++.
2039 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2041 pom.xml: Mention the LGPL license.
2043 * pom.xml: Add a licenses section.
2044 * COPYING.LESSER: Move this to COPYING, which
2045 previously contained the GPL. But gwt-glom is all LGPL.
2047 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2049 Add project information to README and pom.xml.
2051 * README: Add a brief description and mention some mvn
2053 * pom.xml: This extra information shows up in mvn site
2056 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2058 Use the latest java-libglom version.
2060 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2062 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2064 GwtTestOnlineGlom: Test a little more.
2066 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2067 protected rather than private, as suggested by the gwt-test-utils
2069 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2070 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2071 Test the initial visibility of the panels.
2073 However, this is not a very useful test.
2074 And I wonder how we should generally test using this idea for an
2075 activity/places app like ours where the real changes happen implicitly
2076 based on the history token/URL.
2078 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2080 Slight modification to *Mapper comments.
2082 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2083 (DataActivityMapper)
2084 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2086 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2088 Remove comments mentioning GIN because they are just copied from
2089 the example code and are apparently not helpful:
2090 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2091 Also change the mention of a class that is only in the example code.
2093 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2095 GwtTestOnlineGlom test: Minor changes.
2097 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2098 Avoid the long qualified class name and modify the comment
2099 because it is now obvious to me that the mocked class is the only
2100 custom one created via GWT.create().
2102 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2104 Tests: Added the beginnings of a test using gwt-test-utils.
2106 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2107 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2108 which tells gwt-test-utils what class will be tested.
2109 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2110 Add a simple (but empty) test case. One class, used by the OnlineGlom
2111 class, is mocked so that it can be created. However, I am not sure
2112 why only this class needs to be mocked.
2114 Note that mockito seems more popular, and clearer, than easymock,
2115 but I have not got that working yet. It might be a matter of the
2118 This test is run during mvn integration-test.
2120 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2122 Tests: Use junit4-style syntax instead of junit3-style.
2124 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2125 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2126 * src/test/java/org/glom/web/shared/DataItemTest.java:
2127 Use the @Test annotation rather than relying on the test*() prefix.
2128 Also no longer implement TestCase, to avoid triggering support for
2129 the junit3-way, which stops the annotations from working.
2130 Change the imports from import junit.framework.* to
2131 import org.junit.*, which is apparently the new way.
2133 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2135 Added a test for ListPlace token parsing and creation.
2137 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2138 This is much the same as DetailsPlaceTest.
2140 I wonder how we could test the other parts of the *Place API.
2142 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2144 DetailsPlace test: Also test getToken() and recreation via getPlace().
2146 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2147 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2148 recreate it, testing the recreated DetailsPlace for the same parameter
2151 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2153 Use the surefire-report plugin.
2155 * pom.xml: This generates a HTML report about the tests in
2156 target/site/surefire-report.html
2157 when you do mvn surefire-report:report. It seems to be popular/normal.
2159 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2161 Added a test for DetailsPlace.
2163 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2164 Test the getPlace() token parsing.
2166 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2168 Added a first unit test.
2170 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2171 * src/test/java/org/glom/web/shared/DataItemTest.java:
2172 This is a silly test but it is just to get things started. Note that
2173 maven/junit finds the test because it looks in src/test by default.
2175 2011-12-22 Ben Konrath <ben@bagu.org>
2177 Change charsetName to "UTF-8" when replacing line breaks.
2179 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2180 that work in Java (such as "UTF8") will not work when compiled to
2183 This fixes a problem with multi-line details view fields that have hard
2184 line breaks. The "License Text" field on this page demonstrates the
2187 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2189 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2191 2011-12-22 Ben Konrath <ben@bagu.org>
2193 Fix another bug with related list navigation.
2195 I've tested all the navigation buttons in all of the related lists
2196 so things should be good now.
2198 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2200 2011-12-22 Ben Konrath <ben@bagu.org>
2202 Fix a crasher when refreshing the list view with the default table.
2204 This crash will also happen when loading the list view with the default
2205 table from a link or bookmark.
2207 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2208 to the main document selection page when the document id hasn't been
2210 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2211 the main document selection page when the document id hasn't been
2213 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2214 values for the details place when the document id hasn't been set.
2215 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2216 values for the list place when the document id hasn't been set.
2218 2011-12-21 Ben Konrath <ben@bagu.org>
2220 Protect against NPE when glom.document.locale is not in config.
2222 This patch protects against an NPE when glom.document.locale is not in
2223 the config file. This NPE will also happen if glom.document.locale is
2226 The patch also updates the error message to display the class name when
2227 the getMessage() returns null. This was happening when the NPE was
2228 thrown and I had "Configuration Error: null". If an NPE is encountered
2229 with this patch, "Configuration Error: NullPointerException " will be
2232 This commit closes this bug:
2234 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2236 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2238 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2240 Rename onlineglom.properties to onlineglom.properties.sample.
2242 * src/main/resources/onlineglom.properties: Rename to:
2243 * src/main/resources/onlineglom.properties.sample:
2244 * src/main/resources/README: And add this file explaining that people
2245 should rename it back when deploying.
2247 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2249 Allow choosing the translation in the .properties file.
2251 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2252 init(): Read a glom.document.locale value from the configuration file
2253 and call Glom's TransatableItem::set_current_locale() method.
2254 * src/main/resources/onlineglom.properties: Add a commented-out
2255 example of this new setting.
2257 It would be better to add &lang=de_DE to the URL, but the current
2258 libglom API does not allow us to do this easily. I am working on that.
2260 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2262 Avoid a crash in parsing of token parameters.
2264 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2265 ava: getTokenParams(): Do not crash if a parameter has a key but no
2266 value, and ignore parameters with neither.
2268 2011-12-17 Murray Cumming <murrayc@murayc.com>
2270 History token building/handling: Improve use of token parameters.
2272 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2273 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2274 and buildParamsToken(HashMap), for use by derived classes.
2275 Make the separator private because it is no longer be needed.
2276 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2277 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2278 instead of manual string concatenation.
2279 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2280 of hardcoded indices and awkward splitting code.
2281 * src/main/java/org/glom/web/client/place/ListPlace.java
2282 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2283 instead of manual string concatenation.
2284 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2285 of hardcoded indices and awkward splitting code.
2286 This should fix bug #666420
2288 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2290 Fix a Navgiation->Navigation typo in the code.
2292 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2293 Rename processNavgiation() to processNavigation().
2295 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2297 Fix a seperator->separator typo in the code.
2299 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2300 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2301 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2304 2011-12-15 Ben Konrath <ben@bagu.org>
2306 Cleanup some comments.
2308 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2310 2011-12-14 Ben Konrath <ben@bagu.org>
2312 Replace \n with <br/> for multiline text in the details view.
2314 Vertical scrollbars are added when needed as well.
2316 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2318 2011-12-14 Ben Konrath <ben@bagu.org>
2320 Specify the font for document selection links.
2322 * src/main/webapp/style.css:
2324 2011-12-14 Ben Konrath <ben@bagu.org>
2326 Fix bouncy CellTable while paging.
2328 This doesn't currently work with related list tables in unselected
2331 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2333 2011-12-14 Ben Konrath <ben@bagu.org>
2335 Revamp the appearance of the document selection page.
2337 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2338 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2339 * src/main/webapp/style.css:
2341 2011-12-13 Ben Konrath <ben@bagu.org>
2343 Set navigation button column to the smallest size possible.
2345 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2347 2011-12-13 Ben Konrath <ben@bagu.org>
2349 Change OpenButton nomenclature to NavigationButton.
2351 Using NavigtionButton makes things more generic. Classes, methods and
2352 variables have been changed.
2354 This is a rename-only refactor.
2356 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2357 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2358 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2359 Renamed from OpenButtonCell.
2360 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2361 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2362 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2364 2011-12-12 Ben Konrath <ben@bagu.org>
2366 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2368 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2369 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2370 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2371 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2373 2011-12-12 Ben Konrath <ben@bagu.org>
2375 Update variable names and comments.
2377 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2378 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2380 2011-12-12 Ben Konrath <ben@bagu.org>
2382 Properly initialize numNonEmptyRows variable to zero.
2384 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2385 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2387 2011-12-05 Ben Konrath <ben@bagu.org>
2389 Add latest mockup with HTML tables.
2391 Features of this mockup:
2393 -> HTML table for flowtable
2394 -> HTML table for flowtable column
2395 -> Example of how related lists would look
2396 -> Not using text entries for data items
2398 The current version of Online Glom doesn't use HTML tables for the
2401 This mockup has been sent to the glom-devel mailing list but it's good
2402 to have it here as well.
2404 * mockups/details-view-html-tables.html:
2406 2011-12-05 Ben Konrath <ben@bagu.org>
2408 Remove unnecessary getPrimaryKeyField() method.
2410 getPrimaryKeyFieldForTable(String) has been renamed to
2411 getPrimaryKeyField(String).
2413 * src/main/java/org/glom/web/server/database/DBAccess.java:
2414 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2415 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2417 2011-12-05 Ben Konrath <ben@bagu.org>
2419 Add string representation of TypedDataItem value to conversion error message.
2421 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2422 message was extracted into its own method to avoid duplication.
2424 2011-12-05 Ben Konrath <ben@bagu.org>
2426 Add type checking to navigation primary key value creation.
2428 Create navigation primary key only if the expected type from the Glom
2429 document matches the type returned by the SQL query.
2431 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2433 2011-12-05 Ben Konrath <ben@bagu.org>
2435 Rename a couple of variables in RelatedListNavigation.
2437 This is a rename-only refactor.
2439 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2441 2011-12-05 Ben Konrath <ben@bagu.org>
2443 Move getListLayoutGroup() into getListViewLayoutGroup().
2445 This removes getListLayoutGroup(). It was only being called by
2446 getListViewLayoutGroup().
2448 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2450 2011-12-05 Ben Konrath <ben@bagu.org>
2452 Remove check for LayoutItem_Portal in list table method.
2454 This check is no longer necessary because the method isn't being used
2455 to create the LayoutItemPortal DTO.
2457 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2459 2011-12-05 Ben Konrath <ben@bagu.org>
2461 Properly support related list navigation.
2463 Navigation from the "Repository Analyzer -> Package Scans ->
2464 Dependencies" related table wasn't working because the primary key for
2465 related tables wasn't being set properly. This commit fixes the
2468 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2469 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2470 doesn't set the primary key properly for related list tables.
2471 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2472 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2473 useful for getting the primary key for list view tables and for related
2475 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2476 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2477 Move code to set the primary key for the table from the abstract
2478 ListDBAccess class to ListViewDBAccess as it's only correct for list
2480 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2481 Properly add primary key to related list tables.
2483 2011-12-02 Ben Konrath <ben@bagu.org>
2485 Properly set the horizontal alignment of fields.
2487 This fix is for both the list tables and the details view.
2489 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2490 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2491 to set the horizontal alignment of fields.
2493 2011-12-02 Ben Konrath <ben@bagu.org>
2495 Display currency codes in the details view.
2497 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2499 2011-12-02 Ben Konrath <ben@bagu.org>
2501 Avoid duplicate JNI call.
2503 JNI is not as efficient as pure Java and this is an easy (and small)
2506 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2507 Use previously retrieved value for whereClauseToTableName instead of
2510 2011-12-02 Ben Konrath <ben@bagu.org>
2512 Rename a couple of variables in RelatedListNavigation.
2514 This is a rename-only refactor.
2516 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2518 2011-12-02 Ben Konrath <ben@bagu.org>
2520 Indicate clearly that a mismatched primary key type is a bug.
2522 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2523 warning to error. Add 'This is a bug.' to message.
2525 2011-12-02 Ben Konrath <ben@bagu.org>
2527 Update / fix some comments.
2529 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2531 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2533 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2534 Fix comments. Add some TODOs.
2536 2011-12-02 Ben Konrath <ben@bagu.org>
2538 Enable navigation to details view with string primary key from related list.
2540 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2541 Create a text primary key value when return type of result is
2542 java.sql.Types.VARCHAR.
2544 2011-12-02 Ben Konrath <ben@bagu.org>
2546 Use checkboxes for booleans in the details view.
2548 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2550 2011-12-01 Ben Konrath <ben@bagu.org>
2552 Improve performance of related list height calculation.
2554 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2555 Put code to calculate the expected height in a static initializer so
2556 that that it's only called once.
2558 2011-12-01 Ben Konrath <ben@bagu.org>
2560 Show related list tables in notebooks (again).
2562 Calculate the height of the related list tables so the Notebook can be
2563 set the correct height. The height of the related list table is also needed by
2564 FlowTable to be able decide how to create the layout.
2566 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2567 and set the Portal height based on the height of the related list
2568 table and the Portal container.
2569 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2570 Add method to calculate the height of the related list tables.
2571 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2572 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2573 calculate the height of the Pager widget.
2575 2011-12-01 Ben Konrath <ben@bagu.org>
2577 Use CellTable API for table property instead of setting style on Element.
2579 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2581 2011-12-01 Ben Konrath <ben@bagu.org>
2583 Make ListViewTable and RelatedListTable a consistent height.
2585 The tables are now a consistent height regardless of the contents of
2586 the table. A hidden button is added to empty rows to ensure that the
2587 height of these rows will match the height of rows with data.
2589 A navigation button column is now added to every table. The width of
2590 the navigation column is set to 0px when a RelatedListTable shouldn't
2591 have navigation buttons. This maintains the a consistent row height in
2592 tables that don't show the navigation buttons.
2594 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2595 navigation column when not needed.
2596 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2597 arguments for navigation button to constructor of ListViewTable.
2598 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2599 hidden button for empty data rows.
2600 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2601 arguments for navigation button to constructor.
2602 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2603 create navigation buttons. Add hideNavigationButtons() method.
2604 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2605 arguments for navigation button to constructor.
2607 2011-12-01 Ben Konrath <ben@bagu.org>
2609 Use 'visibility: hidden' in Utils.getWidgetHeight().
2611 This is better choice because hidden elements are invisible, don't
2612 respond to events and are not part of the tab order. They will,