1 2012-01-18 Murray Cumming <murrayc@murrayc.com>
3 locales drop-down: Do not lose the primary key.
5 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
6 start(): onLocaleChange(): Pass the current primary key value,
7 instead of an empty value.
9 2012-01-18 Murray Cumming <murrayc@murrayc.com>
11 locales drop-down: Do not lose the drop-down selection.
13 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
14 .java (TableSelectionActivity.fillView): Set the selected locale
15 after changing the drop-down items (though we do not really need
16 to change them just because the locale changes.)
18 2012-01-18 Murray Cumming <murrayc@murrayc.com>
20 locales drop-down: Change the tables list when this changes.
22 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
23 .java: TableSelectionActivity.start(): Move the async table titles
24 retrieval into a private fillView() method and also call this when
25 the chosen locale changes.
26 Note that the document title is not actually translatable yet, but
27 that is a problem that I should fix soon in libglom.
29 2012-01-18 Murray Cumming <murrayc@murrayc.com>
31 Improve the placement of the locales drop-down.
33 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
34 Put the title and locales drop-down in a div (gwt.FlowTable).
35 * src/main/webapp/style.css: Add magic css properties to make this work.
36 Also remove the left margin from the title so that it lines up with the
39 2012-01-18 Murray Cumming <murrayc@murrayc.com>
41 locales selector: Show human-readable locale titles.
43 * src/main/java/org/glom/web/server/ConfiguredDocument.java
44 getDocumentInfo(): Use java.util.Locale to show a real title of
45 each locale, in the locale's own language.
47 2012-01-17 Murray Cumming <murrayc@murrayc.com>
49 Add a language/locale selector drop-down.
51 * src/main/java/org/glom/web/shared/DocumentInfo.java:
52 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
53 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
54 getDocumentInfo(): Store the available Locales in the DocumentInfo.
55 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
56 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
57 Add a ListBox to show the available locales. Add getLocaleSelector(),
58 setLocaleList(), getSelectedLocale(), setSelectedLocale().
59 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
60 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
61 java: Add these classes.
62 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
63 start(): Fill the locales ListBox. Handle its change event, firing a
65 setPlace(): Show the selected locale as specified by the URL token.
66 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
67 * src/main/java/org/glom/web/client/activity/ListActivity.java:
68 Handle LocaleChangeEvent, going to a new *Place with that locale.
70 The placement of the ListBox is not pretty, and it currently uses the ID
71 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
75 2012-01-17 Murray Cumming <murrayc@murrayc.com>
77 Search box: Show the search text from the URL token.
79 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
80 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
81 Add setQuickFindText().
82 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
83 .java: setPlace(): Store the queryText if the place is a ListPlace,
84 and call TableSelectionView.setQuickFindText().
86 2012-01-17 Murray Cumming <murrayc@murrayc.com>
88 Allow use of translations via, for instance, &lang=de in the URL.
90 * pom.xml: Use the unstable java-libglom 1.21 version.
92 * src/main/java/org/glom/web/client/OnlineGlomService.java:
93 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
94 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
95 init(): Instead of calling TranslatableItem.set_current_locale()
96 (now removed), call ConfiguredDocument.setDefaultLocaleID().
97 However, this is only for default locales, which are not needed to
98 change the locale in the URL.
99 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
100 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
101 getSortedRelatedListData(): Add a localeID parameter, so we can get the
102 layout for a particular locale.
103 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
104 Add get/setDefaultLocaleID().
105 getDocumentInfo(), getListViewData(), getRelatedListData(),
106 getDetailsLayoutGroup(), getListViewLayoutGroup(),
107 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
108 localeID parameter, so we can get the layout for a particular locale.
110 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
111 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
112 * src/main/java/org/glom/web/client/place/ListPlace.java:
113 Parse and construct a lang parameter too.
115 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
116 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
117 passed to subsequent methods and constructors.
118 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
119 * src/main/java/org/glom/web/client/activity/ListActivity.java:
120 Store the localeID from the *Place and pass it to other constructors
121 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
123 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
124 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
125 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
126 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
127 * src/main/java/org/glom/web/client/ui/ListView.java:
128 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
129 Take localeID parameters and pass them to subsequent constructors and
130 methods, so that the layout is always retrieved for that locale.
132 This is rather repetitive.
134 Note that "" means the original (default) locale of the Glom document,
135 which is usually English.
137 2012-01-17 Murray Cumming <murrayc@murrayc.com>
139 Documents: Remove final keyword to fix startup configuration.
141 * src/main/java/org/glom/web/shared/Documents.java: Remove the
142 final keywords on the private member variables because that breaks
143 the startup, apparently (there are warnings) because it stops them
144 from being serialized. I added these in the previous commit.
146 2012-01-13 Murray Cumming <murrayc@murrayc.com>
148 Documents: Add some final keywords.
150 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
153 2012-01-13 Murray Cumming <murrayc@murrayc.com>
155 OnlineGlomServiceImpl: Add to overview comments.
157 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
158 Note that this is where all the document are loaded. They are not
159 loaded freshly for each page.
161 2012-01-12 Murray Cumming <murrayc@murrayc.com>
165 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
166 Add a TextBox for the text of a quick find.
167 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
169 setBackLink(): Add a String quickFind parameter.
170 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
171 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
172 to the base interface, because that is how TableSelectionViewImpl is used.
173 * src/main/webapp/style.css: Add style for the search box and its label.
175 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
176 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
177 Add these files, based on the existing TableChangeEvent and
178 TableChangeEventHandlers.
179 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
180 start(): Handle QuickFindChangeEvent, passing its quickFind text to
181 a ListPlace() that the user should be taken to.
182 * src/main/java/org/glom/web/client/activity/ListActivity.java
183 start(): Handle it here too and adapt the TableChangeEvent handler to
184 pass the extra "" quickFind parameter to ListPlace.
185 * src/main/java/org/glom/web/client/place/ListPlace.java:
186 Constructor: Take an extra String quickFind parameter and store it,
187 returning it from a new getQuickFind() method.
188 getToken(): Put the quickFind text in the URL token.
189 getPlace(): Parse the quickFind text from the URL token.
190 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
191 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
192 ListPlace constructor.
193 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
194 .java: start(): Add a Change handler for the TableSelectionView's
195 TextBox (via its base HasChangeHandlers interface), firing the new
196 QuickFindChangeEvent.
197 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
198 pass the extra "" quickFind parameter.
200 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
201 setCellTable(): Add a String quickFind parameter and pass it to
202 the ListViewTable() constructor.
203 * src/main/java/org/glom/web/client/ui/ListView.java: Change
204 setCellTable() in the base interface, because that is how ListViewImpl
207 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
208 Add a String quickFind member variable.
209 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
210 Constructor: Add a String quickFind parameter, storing it in the
211 base ListTable's member variable.
212 onRangeChanged(): Pass quickFind to the
213 OnlineGlomServiceAsync.getSortedListViewData() and
214 OnlineGlomServiceAsync.getListViewData() methods.
216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
217 getListViewData(), getSortedListViewData(): Add a String quickFind
218 parameter, passing it to ConfiguredDocument.getListViewData().
219 * src/main/java/org/glom/web/client/OnlineGlomService.java:
220 Change getListViewData(), getSortedListViewData() in the base interface,
221 because that is how OnlineGlomServiceImpl is used, via this:
222 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
223 Change getListViewData(), getSortedListViewData() here too.
224 This class can apparently be used to asynchronously call methods on
225 OnlineGlomService, and GWT seems to implement that after recognizing
226 just the *Async name convention and the extra AsyncCallback parameters.
228 * src/main/java/org/glom/web/server/ConfiguredDocument.java
229 getListViewData(): Add a String quickFind parameter, and pass it to
230 ListViewDBAccess.getData().
231 * src/main/java/org/glom/web/server/database/ListDBAccess.java
232 getListData(): Add a String quickFind parameter and pass it to
234 getSelectQuery(): Add a String quickFind parameter.
235 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
236 getSelectQuery(): Add a String quickFind parameter and use it with
237 Glom.get_find_where_clause_quick() to pass a where_clause to
238 Glom.build_sql_select_with_where_clause(), to actually filter the
240 getData(): Add a String quickFind parameter, passing it to getListData().
241 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
242 va: getData(): Pass an empty string to getListData() for the
245 2012-01-12 Murray Cumming <murrayc@murrayc.com>
247 ListTable: Minor change.
249 * src/main/java/org/glom/web/client/ui/list/ListTable.java
250 createCellTable(): Make this protected instead of public.
252 2012-01-12 Murray Cumming <murrayc@murrayc.com>
254 Many files: Use final for the parameters and use the @override attribute.
256 2012-01-22 Ben Konrath <ben@bagu.org>
258 Add anchor links for single line text that starts with http, ftp and www.
262 2012-01-22 Ben Konrath <ben@bagu.org>
264 Add ellipsis to single line text in details view.
268 2012-01-04 Murray Cumming <murrayc@murrayc.com>
270 Remove all javadoc author tags.
272 Because they are awkward and meaningless when many people touch
274 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
276 2012-01-04 Murray Cumming <murrayc@murrayc.com>
278 Revert the COPYING.LESSER to COPYING rename.
280 Apparently both should be there if it is LGPL.
282 2012-01-03 Murray Cumming <murrayc@murrayc.com>
284 *View: Remove unused imports.
286 * src/main/java/org/glom/web/client/ui/DetailsView.java:
287 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
288 * src/main/java/org/glom/web/client/ui/ListView.java:
289 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
290 Remove unused imports, as suggested by Eclipse.
292 2012-01-02 Murray Cumming <murrayc@murrayc.com>
294 Move the *View::Presenter types, and some API into one base View.
296 * src/main/java/org/glom/web/client/ui/DetailsView.java:
297 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
298 * src/main/java/org/glom/web/client/ui/ListView.java:
299 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
300 Presenter, setPresenter() and clear() into a shared base interface,
301 to avoid the unnecessary duplicate Presenter types and to more clearly
302 show how the *Views share the same structure, even if they are not
303 used polymorphically.
305 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
306 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
308 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
309 * src/main/java/org/glom/web/client/activity/ListActivity.java:
310 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
312 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
315 Feel free to revert this if there is a good reason for the duplicate
318 2012-01-02 Murray Cumming <murrayc@murrayc.com>
320 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
322 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
323 a class member instead of a local variable in the method.
324 This lets us use it to get the view instances, for use in tests.
325 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
326 beforeOnlineGlom(): Test some more details of the initial view.
327 Again, this is not very useful.
329 To really test gwt-glom we will need to start a local postgresql
330 instance with local data, like the Glom tests in C++.
332 2012-01-02 Murray Cumming <murrayc@murrayc.com>
334 pom.xml: Mention the LGPL license.
336 * pom.xml: Add a licenses section.
337 * COPYING.LESSER: Move this to COPYING, which
338 previously contained the GPL. But gwt-glom is all LGPL.
340 2012-01-02 Murray Cumming <murrayc@murrayc.com>
342 Add project information to README and pom.xml.
344 * README: Add a brief description and mention some mvn
346 * pom.xml: This extra information shows up in mvn site
349 2011-01-02 Murray Cumming <murrayc@murrayc.com>
351 Use the latest java-libglom version.
353 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
355 2012-01-01 Murray Cumming <murrayc@murrayc.com>
357 GwtTestOnlineGlom: Test a little more.
359 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
360 protected rather than private, as suggested by the gwt-test-utils
362 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
363 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
364 Test the initial visibility of the panels.
366 However, this is not a very useful test.
367 And I wonder how we should generally test using this idea for an
368 activity/places app like ours where the real changes happen implicitly
369 based on the history token/URL.
371 2012-01-01 Murray Cumming <murrayc@murrayc.com>
373 Slight modification to *Mapper comments.
375 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
377 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
379 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
381 Remove comments mentioning GIN because they are just copied from
382 the example code and are apparently not helpful:
383 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
384 Also change the mention of a class that is only in the example code.
386 2012-01-01 Murray Cumming <murrayc@murrayc.com>
388 GwtTestOnlineGlom test: Minor changes.
390 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
391 Avoid the long qualified class name and modify the comment
392 because it is now obvious to me that the mocked class is the only
393 custom one created via GWT.create().
395 2012-01-01 Murray Cumming <murrayc@murrayc.com>
397 Tests: Added the beginnings of a test using gwt-test-utils.
399 * pom.xml: Add dependencies on gwt-test-utils and easymock.
400 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
401 which tells gwt-test-utils what class will be tested.
402 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
403 Add a simple (but empty) test case. One class, used by the OnlineGlom
404 class, is mocked so that it can be created. However, I am not sure
405 why only this class needs to be mocked.
407 Note that mockito seems more popular, and clearer, than easymock,
408 but I have not got that working yet. It might be a matter of the
411 This test is run during mvn integration-test.
413 2011-12-31 Murray Cumming <murrayc@murrayc.com>
415 Tests: Use junit4-style syntax instead of junit3-style.
417 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
418 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
419 * src/test/java/org/glom/web/shared/DataItemTest.java:
420 Use the @Test annotation rather than relying on the test*() prefix.
421 Also no longer implement TestCase, to avoid triggering support for
422 the junit3-way, which stops the annotations from working.
423 Change the imports from import junit.framework.* to
424 import org.junit.*, which is apparently the new way.
426 2011-12-31 Murray Cumming <murrayc@murrayc.com>
428 Added a test for ListPlace token parsing and creation.
430 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
431 This is much the same as DetailsPlaceTest.
433 I wonder how we could test the other parts of the *Place API.
435 2011-12-30 Murray Cumming <murrayc@murrayc.com>
437 DetailsPlace test: Also test getToken() and recreation via getPlace().
439 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
440 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
441 recreate it, testing the recreated DetailsPlace for the same parameter
444 2011-12-30 Murray Cumming <murrayc@murrayc.com>
446 Use the surefire-report plugin.
448 * pom.xml: This generates a HTML report about the tests in
449 target/site/surefire-report.html
450 when you do mvn surefire-report:report. It seems to be popular/normal.
452 2011-12-30 Murray Cumming <murrayc@murrayc.com>
454 Added a test for DetailsPlace.
456 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
457 Test the getPlace() token parsing.
459 2011-12-30 Murray Cumming <murrayc@murrayc.com>
461 Added a first unit test.
463 * pom.xml: Add a test goal, and a dependency on junit in that scope.
464 * src/test/java/org/glom/web/shared/DataItemTest.java:
465 This is a silly test but it is just to get things started. Note that
466 maven/junit finds the test because it looks in src/test by default.
468 2011-12-22 Ben Konrath <ben@bagu.org>
470 Change charsetName to "UTF-8" when replacing line breaks.
472 JavaScript requires the charsetName to be "UTF-8". CharsetName values
473 that work in Java (such as "UTF8") will not work when compiled to
476 This fixes a problem with multi-line details view fields that have hard
477 line breaks. The "License Text" field on this page demonstrates the
480 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
482 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
484 2011-12-22 Ben Konrath <ben@bagu.org>
486 Fix another bug with related list navigation.
488 I've tested all the navigation buttons in all of the related lists
489 so things should be good now.
491 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
493 2011-12-22 Ben Konrath <ben@bagu.org>
495 Fix a crasher when refreshing the list view with the default table.
497 This crash will also happen when loading the list view with the default
498 table from a link or bookmark.
500 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
501 to the main document selection page when the document id hasn't been
503 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
504 the main document selection page when the document id hasn't been
506 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
507 values for the details place when the document id hasn't been set.
508 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
509 values for the list place when the document id hasn't been set.
511 2011-12-21 Ben Konrath <ben@bagu.org>
513 Protect against NPE when glom.document.locale is not in config.
515 This patch protects against an NPE when glom.document.locale is not in
516 the config file. This NPE will also happen if glom.document.locale is
519 The patch also updates the error message to display the class name when
520 the getMessage() returns null. This was happening when the NPE was
521 thrown and I had "Configuration Error: null". If an NPE is encountered
522 with this patch, "Configuration Error: NullPointerException " will be
525 This commit closes this bug:
527 https://bugzilla.gnome.org/show_bug.cgi?id=666669
529 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
531 2011-12-20 Murray Cumming <murrayc@murrayc.com>
533 Rename onlineglom.properties to onlineglom.properties.sample.
535 * src/main/resources/onlineglom.properties: Rename to:
536 * src/main/resources/onlineglom.properties.sample:
537 * src/main/resources/README: And add this file explaining that people
538 should rename it back when deploying.
540 2011-12-20 Murray Cumming <murrayc@murrayc.com>
542 Allow choosing the translation in the .properties file.
544 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
545 init(): Read a glom.document.locale value from the configuration file
546 and call Glom's TransatableItem::set_current_locale() method.
547 * src/main/resources/onlineglom.properties: Add a commented-out
548 example of this new setting.
550 It would be better to add &lang=de_DE to the URL, but the current
551 libglom API does not allow us to do this easily. I am working on that.
553 2011-12-19 Murray Cumming <murrayc@murrayc.com>
555 Avoid a crash in parsing of token parameters.
557 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
558 ava: getTokenParams(): Do not crash if a parameter has a key but no
559 value, and ignore parameters with neither.
561 2011-12-17 Murray Cumming <murrayc@murayc.com>
563 History token building/handling: Improve use of token parameters.
565 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
566 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
567 and buildParamsToken(HashMap), for use by derived classes.
568 Make the separator private because it is no longer be needed.
569 * src/main/java/org/glom/web/client/place/DetailsPlace.java
570 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
571 instead of manual string concatenation.
572 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
573 of hardcoded indices and awkward splitting code.
574 * src/main/java/org/glom/web/client/place/ListPlace.java
575 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
576 instead of manual string concatenation.
577 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
578 of hardcoded indices and awkward splitting code.
579 This should fix bug #666420
581 2011-12-16 Murray Cumming <murrayc@murrayc.com>
583 Fix a Navgiation->Navigation typo in the code.
585 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
586 Rename processNavgiation() to processNavigation().
588 2011-12-16 Murray Cumming <murrayc@murrayc.com>
590 Fix a seperator->separator typo in the code.
592 * src/main/java/org/glom/web/client/place/DetailsPlace.java
593 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
594 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
597 2011-12-15 Ben Konrath <ben@bagu.org>
599 Cleanup some comments.
601 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
603 2011-12-14 Ben Konrath <ben@bagu.org>
605 Replace \n with <br/> for multiline text in the details view.
607 Vertical scrollbars are added when needed as well.
609 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
611 2011-12-14 Ben Konrath <ben@bagu.org>
613 Specify the font for document selection links.
615 * src/main/webapp/style.css:
617 2011-12-14 Ben Konrath <ben@bagu.org>
619 Fix bouncy CellTable while paging.
621 This doesn't currently work with related list tables in unselected
624 * src/main/java/org/glom/web/client/ui/list/ListTable.java
626 2011-12-14 Ben Konrath <ben@bagu.org>
628 Revamp the appearance of the document selection page.
630 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
631 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
632 * src/main/webapp/style.css:
634 2011-12-13 Ben Konrath <ben@bagu.org>
636 Set navigation button column to the smallest size possible.
638 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
640 2011-12-13 Ben Konrath <ben@bagu.org>
642 Change OpenButton nomenclature to NavigationButton.
644 Using NavigtionButton makes things more generic. Classes, methods and
645 variables have been changed.
647 This is a rename-only refactor.
649 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
650 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
651 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
652 Renamed from OpenButtonCell.
653 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
654 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
655 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
657 2011-12-12 Ben Konrath <ben@bagu.org>
659 Remove unnecessary String argument in RelatedListTable and ListViewTable.
661 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
662 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
663 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
664 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
666 2011-12-12 Ben Konrath <ben@bagu.org>
668 Update variable names and comments.
670 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
671 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
673 2011-12-12 Ben Konrath <ben@bagu.org>
675 Properly initialize numNonEmptyRows variable to zero.
677 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
678 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
680 2011-12-05 Ben Konrath <ben@bagu.org>
682 Add latest mockup with HTML tables.
684 Features of this mockup:
686 -> HTML table for flowtable
687 -> HTML table for flowtable column
688 -> Example of how related lists would look
689 -> Not using text entries for data items
691 The current version of Online Glom doesn't use HTML tables for the
694 This mockup has been sent to the glom-devel mailing list but it's good
695 to have it here as well.
697 * mockups/details-view-html-tables.html:
699 2011-12-05 Ben Konrath <ben@bagu.org>
701 Remove unnecessary getPrimaryKeyField() method.
703 getPrimaryKeyFieldForTable(String) has been renamed to
704 getPrimaryKeyField(String).
706 * src/main/java/org/glom/web/server/database/DBAccess.java:
707 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
708 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
710 2011-12-05 Ben Konrath <ben@bagu.org>
712 Add string representation of TypedDataItem value to conversion error message.
714 * src/main/java/org/glom/web/server/Utils.java: Logging the error
715 message was extracted into its own method to avoid duplication.
717 2011-12-05 Ben Konrath <ben@bagu.org>
719 Add type checking to navigation primary key value creation.
721 Create navigation primary key only if the expected type from the Glom
722 document matches the type returned by the SQL query.
724 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
726 2011-12-05 Ben Konrath <ben@bagu.org>
728 Rename a couple of variables in RelatedListNavigation.
730 This is a rename-only refactor.
732 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
734 2011-12-05 Ben Konrath <ben@bagu.org>
736 Move getListLayoutGroup() into getListViewLayoutGroup().
738 This removes getListLayoutGroup(). It was only being called by
739 getListViewLayoutGroup().
741 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
743 2011-12-05 Ben Konrath <ben@bagu.org>
745 Remove check for LayoutItem_Portal in list table method.
747 This check is no longer necessary because the method isn't being used
748 to create the LayoutItemPortal DTO.
750 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
752 2011-12-05 Ben Konrath <ben@bagu.org>
754 Properly support related list navigation.
756 Navigation from the "Repository Analyzer -> Package Scans ->
757 Dependencies" related table wasn't working because the primary key for
758 related tables wasn't being set properly. This commit fixes the
761 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
762 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
763 doesn't set the primary key properly for related list tables.
764 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
765 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
766 useful for getting the primary key for list view tables and for related
768 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
769 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
770 Move code to set the primary key for the table from the abstract
771 ListDBAccess class to ListViewDBAccess as it's only correct for list
773 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
774 Properly add primary key to related list tables.
776 2011-12-02 Ben Konrath <ben@bagu.org>
778 Properly set the horizontal alignment of fields.
780 This fix is for both the list tables and the details view.
782 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
783 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
784 to set the horizontal alignment of fields.
786 2011-12-02 Ben Konrath <ben@bagu.org>
788 Display currency codes in the details view.
790 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
792 2011-12-02 Ben Konrath <ben@bagu.org>
794 Avoid duplicate JNI call.
796 JNI is not as efficient as pure Java and this is an easy (and small)
799 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
800 Use previously retrieved value for whereClauseToTableName instead of
803 2011-12-02 Ben Konrath <ben@bagu.org>
805 Rename a couple of variables in RelatedListNavigation.
807 This is a rename-only refactor.
809 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
811 2011-12-02 Ben Konrath <ben@bagu.org>
813 Indicate clearly that a mismatched primary key type is a bug.
815 * src/main/java/org/glom/web/server/Utils.java: Change log level from
816 warning to error. Add 'This is a bug.' to message.
818 2011-12-02 Ben Konrath <ben@bagu.org>
820 Update / fix some comments.
822 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
824 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
826 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
827 Fix comments. Add some TODOs.
829 2011-12-02 Ben Konrath <ben@bagu.org>
831 Enable navigation to details view with string primary key from related list.
833 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
834 Create a text primary key value when return type of result is
835 java.sql.Types.VARCHAR.
837 2011-12-02 Ben Konrath <ben@bagu.org>
839 Use checkboxes for booleans in the details view.
841 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
843 2011-12-01 Ben Konrath <ben@bagu.org>
845 Improve performance of related list height calculation.
847 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
848 Put code to calculate the expected height in a static initializer so
849 that that it's only called once.
851 2011-12-01 Ben Konrath <ben@bagu.org>
853 Show related list tables in notebooks (again).
855 Calculate the height of the related list tables so the Notebook can be
856 set the correct height. The height of the related list table is also needed by
857 FlowTable to be able decide how to create the layout.
859 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
860 and set the Portal height based on the height of the related list
861 table and the Portal container.
862 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
863 Add method to calculate the height of the related list tables.
864 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
865 * src/main/webapp/style.css: Add css class for Pager. This is needed to
866 calculate the height of the Pager widget.
868 2011-12-01 Ben Konrath <ben@bagu.org>
870 Use CellTable API for table property instead of setting style on Element.
872 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
874 2011-12-01 Ben Konrath <ben@bagu.org>
876 Make ListViewTable and RelatedListTable a consistent height.
878 The tables are now a consistent height regardless of the contents of
879 the table. A hidden button is added to empty rows to ensure that the
880 height of these rows will match the height of rows with data.
882 A navigation button column is now added to every table. The width of
883 the navigation column is set to 0px when a RelatedListTable shouldn't
884 have navigation buttons. This maintains the a consistent row height in
885 tables that don't show the navigation buttons.
887 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
888 navigation column when not needed.
889 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
890 arguments for navigation button to constructor of ListViewTable.
891 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
892 hidden button for empty data rows.
893 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
894 arguments for navigation button to constructor.
895 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
896 create navigation buttons. Add hideNavigationButtons() method.
897 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
898 arguments for navigation button to constructor.
900 2011-12-01 Ben Konrath <ben@bagu.org>
902 Use 'visibility: hidden' in Utils.getWidgetHeight().
904 This is better choice because hidden elements are invisible, don't
905 respond to events and are not part of the tab order. They will,
906 however, take up space which is required to be able to calculate the
907 height of the widget.
909 * src/main/java/org/glom/web/client/Utils.java:
911 2011-12-01 Ben Konrath <ben@bagu.org>
913 Use Utils.getWidgetHeight() in FlowTable.
915 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
917 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
919 2011-12-01 Ben Konrath <ben@bagu.org>
921 Put the details css class name on the correct table column.
923 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
925 2011-11-30 Ben Konrath <ben@bagu.org>
927 Update for java-libglom API change.
929 The getters and setters on FieldFormatting and NumericFormat were
930 changed to remove the 'M'.
932 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
934 2011-11-29 Ben Konrath <ben@bagu.org>
936 Only allow RelatedListTables in Portals.
938 * src/main/java/org/glom/web/client/ui/details/Portal.java:
940 2011-11-29 Ben Konrath <ben@bagu.org>
942 Only create a contents panel for Portals when title is being set.
944 * src/main/java/org/glom/web/client/ui/details/Portal.java:
946 2011-11-29 Ben Konrath <ben@bagu.org>
948 Set TabLayoutPanel height based on calculated height its widgets.
950 This is a potential fix for this bug:
952 https://bugzilla.gnome.org/show_bug.cgi?id=665133
954 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
956 2011-11-29 Ben Konrath <ben@bagu.org>
958 Align details field labels and data with the Open buttons.
960 * src/main/webapp/style.css:
962 2011-11-29 Ben Konrath <ben@bagu.org>
964 Remove unnecessary <div> in the Notebook widget.
966 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
967 method to get container FlowPanel (<div>).
968 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
969 initWidget() method directly on the TabLayoutPanel widget instead of
970 Group's container widget.
972 2011-11-29 Ben Konrath <ben@bagu.org>
974 Don't add group titles for Portals in Notebooks.
976 This reverts the previous patch and fixes a bug I introduced with
977 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
979 * src/main/java/org/glom/web/client/ui/details/Group.java:
980 * src/main/java/org/glom/web/client/ui/details/Portal.java:
982 2011-11-28 Ben Konrath <ben@bagu.org>
984 Remove unused boolean argument in Portal constructor.
988 * src/main/java/org/glom/web/client/ui/details/Group.java:
989 * src/main/java/org/glom/web/client/ui/details/Portal.java:
991 2011-11-28 Ben Konrath <ben@bagu.org>
993 Remove hack for glom 1.18 style glom files.
995 * src/main/java/org/glom/web/client/ui/details/Group.java:
996 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
997 * src/main/java/org/glom/web/client/ui/details/Portal.java:
999 2011-11-28 Ben Konrath <ben@bagu.org>
1001 Use Gda Value version of primary key to log result too large error.
1003 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1005 2011-11-28 Ben Konrath <ben@bagu.org>
1007 Don't use TypedDataItem.getText() for Unknown types from the URL.
1009 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1010 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1011 instead of getText().
1012 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1013 String field and getUnknown() method.
1015 2011-11-28 Ben Konrath <ben@bagu.org>
1017 Log an error message when the java-libglom .so is not present.
1019 The error message was being set in the exception but not logged.
1021 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1023 2011-11-28 Ben Konrath <ben@bagu.org>
1025 Ignore LayoutItem_CalendarPortals.
1027 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1028 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1030 2011-11-28 Ben Konrath <ben@bagu.org>
1032 Extract method for creating the LayoutItemPortal DTO.
1034 Just breaking the code up into smaller chunks.
1036 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1038 2011-11-28 Ben Konrath <ben@bagu.org>
1042 This should have been added with the refactor. Oops!
1044 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1046 2011-11-28 Ben Konrath <ben@bagu.org>
1048 Create primary key value from URL string using type from Glom document.
1050 See this bug, comments 19 - 25:
1052 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1054 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1055 create a TypeDataItem for the primary key here when loading from a
1056 URL. Show the same string for the primary key value as was received
1057 from the URL string (when loading from a URL).
1058 * src/main/java/org/glom/web/server/Utils.java: Update method for
1059 creating the Gda Value from the TypeDataItem to properly deal with
1060 creating a Gda Value based on the Glom document type for the primary
1061 key value string when loading from a URL.
1062 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1063 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1064 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1065 Update for changed method name.
1067 2011-11-27 Ben Konrath <ben@bagu.org>
1069 Rename PrimaryKeyItem to TypedDataItem.
1071 The name PrimaryKeyItem suggests what the class should be used for.
1072 TypedDataItem is a neutral name that describes the class better.
1074 This is a rename-only refactor.
1076 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1077 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1078 * src/main/java/org/glom/web/client/Utils.java:
1079 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1080 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1081 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1082 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1083 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1084 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1085 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1086 * src/main/java/org/glom/web/server/Utils.java:
1087 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1088 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1089 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1090 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1092 2011-11-25 Ben Konrath <ben@bagu.org>
1094 Improve Gda Value conversion from PrimaryKeyItem.
1096 The value from the PrimaryKeyItem is only used if its type match the
1097 type from the glom document.
1099 * src/main/java/org/glom/web/server/Utils.java:
1101 2011-11-25 Ben Konrath <ben@bagu.org>
1103 Manually check if the java-liblgom .so is visible to the JVM.
1105 It seems that Tomcat has problems when a static initializer throws an
1106 exception. This check is done before the first method call into
1107 java-libglom so that execution doesn't continue if the .so is not
1110 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1112 2011-11-25 Ben Konrath <ben@bagu.org>
1114 Improve browser configuration error messages.
1118 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1120 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1121 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1122 getConfigurationErrorMessage() method.
1123 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1124 Get and display a specific configuration error message when no Glom
1125 documents are found.
1126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1127 Implement getConfigurationErrorMessage() method. Surround configuration
1128 code in the init() method with a try/catch block. This allows the
1129 errors to be caught while keeping the servlet available to retrieve the
1130 configuration error message.
1132 2011-11-25 Ben Konrath <ben@bagu.org>
1134 Don't use Strings to hold primary key values.
1136 The primary key values are now held in a new data object
1137 (PrimaryKeyItem) that holds type information and the primary key value
1138 using the correct type.
1140 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1141 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1143 PrimaryKeyItem instead of String to hold the primary key value.
1144 * src/main/java/org/glom/web/client/Utils.java: Remove
1145 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1146 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1147 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1148 PrimaryKeyItem instead of String to hold the primary key value. Load
1149 document selection page when the documentID has not been set correctly.
1150 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1151 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1153 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1154 Return empty string for URL instead of "null".
1155 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1156 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1157 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1158 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1159 PrimaryKeyItem instead of String to hold primary key values.
1160 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1161 PrimaryKeyValue to a Gda Value.
1162 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1163 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1164 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1165 Replace temporary database access code that uses the PrimaryKeyValue to
1166 Gda Value conversion.
1167 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1168 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1169 PrimaryKeyItem instead of String.
1170 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1171 hold primary key values.
1173 2011-11-24 Ben Konrath <ben@bagu.org>
1175 Use newly added java-libglom API to create queries.
1177 This isn't finished. I still need to stop using Strings for primary key
1178 values in the client code.
1180 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1181 libglom to use fake connections so that retrieving the query string will
1183 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1184 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1185 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1186 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1187 Use the newly added libglom sql methods and classes to create the
1188 query. Add temporary hack to convert primary value strings to Gda
1191 2011-11-23 Ben Konrath <ben@bagu.org>
1193 Don't explicitly set the height of Portals.
1195 See comments 6 - 10 of this bug for details:
1197 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1199 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1201 2011-11-23 Ben Konrath <ben@bagu.org>
1203 Use an HTML table instead of CSS for the FlowTable layout.
1205 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1206 GWT's FlexTable to implement the FlowTable.
1207 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1209 2011-11-18 Ben Konrath <ben@bagu.org>
1211 Add boolean example to HTML table mockup.
1213 * mockups/details-view-html-tables-text-entries.html:
1215 2011-11-17 Ben Konrath <ben@bagu.org>
1217 Ensure the pager buttons are always visible for related lists.
1219 To accomplish this, I've turned off text wrapping in the list view and
1220 related list tables for both the header and data text. The related list
1221 table now has a fixed layout so the it doesn't overflow its container.
1222 This is required to ensure that the cell text is clipped when it
1223 overflows the cell and an ellipsis is added to the right side of the
1224 cell when text is clipped.
1226 A fixed table layout for the related list table in the details view
1227 seems what we want for the details view anyway, so the side-effect is
1230 The ellipsis will only be displayed in Firefox >= 7.
1234 https://bugzilla.gnome.org/show_bug.cgi?id=662930
1236 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
1237 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
1238 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
1240 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1241 Set the 'table-layout: fixed' CSS property to the related list table.
1242 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
1243 'white-space: nowrap;' CSS property on both the list view and the
1244 related list tables.
1246 2011-11-16 Ben Konrath <ben@bagu.org>
1248 Rework the fix for empty notebook tab labels.
1250 Setting the empty group titles with its name caused problems for the
1251 details layout. Instead of using libglom's
1252 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
1253 to the client when the title is empty. This allows the Notebook to use
1254 the name when the title is empty without affecting anything else.
1256 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1257 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1259 2011-11-16 Ben Konrath <ben@bagu.org>
1261 Set group titles with name when title is empty.
1263 This fixes a problem with an empty notebook tab label in the Lesson
1264 Planner document. The forth tab in the notebook should be "Internet":
1266 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
1268 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1269 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
1272 2011-11-16 Ben Konrath <ben@bagu.org>
1274 Remove whitespace from the configured username properties.
1276 This assumes that usernames won't have whitespace at the beginning
1277 or end. But I think this is a reasonable assumption.
1279 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1280 String.trim() to remove the whitespace from the username properties.
1282 2011-11-15 Ben Konrath <ben@bagu.org>
1284 Add details view mockup with HTML tables and text entries.
1286 This is from the attachment on this bug:
1288 https://bugzilla.gnome.org/show_bug.cgi?id=663109
1290 * mockups/details-view-html-tables-text-entries.html:
1292 2011-11-15 Ben Konrath <ben@bagu.org>
1294 Add space between the columns of the flow table.
1298 https://bugzilla.gnome.org/show_bug.cgi?id=662918
1300 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
1301 space between columns in the flow table.
1303 2011-11-15 Ben Konrath <ben@bagu.org>
1305 Add backup files to the .gitignore.
1307 * .gitignore: Ignore files that end with ~.
1309 2011-11-09 Ben Konrath <ben@bagu.org>
1311 Use latest release of gwt-log.
1313 Gwt-log releases are now being submitted to the maven central
1314 repository so manual installation of the jar is no longer required.
1316 * pom.xml: Update version and groupId of gwt-log dependency.
1318 2011-10-31 Ben Konrath <ben@bagu.org>
1320 Don't use GWT numeric formatting to override the glom currency formatting.
1322 Currencies are now displayed like they are in Glom. See this bug:
1324 https://bugzilla.gnome.org/show_bug.cgi?id=646216
1326 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
1328 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
1329 currency code to constructor and set it when the cell is rendered.
1330 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1331 currency code to the constructor of the NumericCell.
1333 2011-10-27 Ben Konrath <ben@bagu.org>
1335 Require the latest release of java-libglom (1.17.4).
1339 2011-10-26 Ben Konrath <ben@bagu.org>
1341 Add style to Notebook that matches current theme.
1343 It's not the best style in the world but it's better than the default.
1345 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
1346 padding at the bottom of the child widgets.
1347 * src/main/webapp/style.css: Add style for the Notebook.
1349 2011-10-26 Ben Konrath <ben@bagu.org>
1351 Move servlet initialization code to overridden init method.
1353 This is half of the solution to getting proper error messages
1354 displayed when configuration errors occur. Here's the relevant bug:
1356 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1358 The rest of the solution involves surrounding the init method with a
1359 try/catch block and setting a global variable with the error /
1360 exception. A new async method should be created to retrieve and display
1361 the error message / exception.
1363 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
1364 code from constructor to init method adding exceptions as needed.
1366 2011-10-26 Ben Konrath <ben@bagu.org>
1368 Add script to monitor and restart tomcat if required.
1370 * utils/check-and-recover-tomcat.py: New file.
1372 2011-10-26 Ben Konrath <ben@bagu.org>
1374 Display the correct number of data items in the pager.
1378 https://bugzilla.gnome.org/show_bug.cgi?id=661441
1380 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1381 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1382 The implementation is the same for both tables: Keep track of the
1383 number of non-empty rows and fire and RowCountChangeEvent after the data has
1385 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
1386 custom Pager class that subclasses SimplePager to handle displaying
1387 the correct number when empty rows have been added.
1389 2011-10-26 Ben Konrath <ben@bagu.org>
1391 Correct error in previous commit.
1393 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
1394 eventBus parameter from listView.setCellTable().
1396 2011-10-26 Ben Konrath <ben@bagu.org>
1398 Fix error in TODO comment.
1400 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1402 2011-10-24 Ben Konrath <ben@bagu.org>
1404 Create Notebook widgets to the details view.
1406 This isn't finished just yet - I still need to create a reasonable
1407 style to match the current theme.
1409 * src/main/java/org/glom/web/client/Utils.java: Add method for
1410 calculating the height of a widget. This is used in the Notebook class.
1411 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
1412 new constructor method in Group.
1413 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
1414 method for creating child widget that can be used by subclasses
1415 like Notebook. New constructor that allows disabling the group
1416 titles - Notebooks don't set a group title for their child groups.
1417 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
1418 to make Notebooks using GWT's TabLayoutPanel.
1419 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
1420 constructor that allows disabling the group titles.
1421 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
1422 LayoutItemNotebook DTO.
1423 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
1424 DTO for Notebooks. It's just an empty class for now but we might need
1425 it to transfer some specific information in the future.
1427 2011-10-21 Ben Konrath <ben@bagu.org>
1429 Add navigation buttons to related list tables.
1431 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1432 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
1434 method getSuitableRecordToViewDetails() for getting the table name
1435 and primary key value for related list navigation buttons.
1436 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1437 private cell renderer class to get the navigation information for
1438 related list tables from the server. Extract the navigation
1439 processing code from the details cell navigation and use it for the
1440 related list navigation as well.
1441 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
1442 cell renderer class for the details open buttons. This was needed
1443 because the related list navigation buttons and the list view
1444 navigation buttons need to react differently when clicked.
1445 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
1446 the onEnterKeyDown() method because it's now overriden in the
1447 subclasses that are specific to the related list tables and the list
1449 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
1450 the vertical size a little because the buttons add a bit of vertical
1451 space to table. This is not a perfect solution because the vertical
1452 size of with table fewer than 5 rows will be a little smaller.
1453 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
1454 changes in how navigation buttons are handled.
1455 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
1456 getSuitableRecordToViewDetails() using the new RelatedListNavigation
1457 database access object.
1458 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
1459 to find the portal for a given relationship name from
1460 RelatedListDBAccess. Add method to find a primary key field for a
1462 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1463 Move code to find the portal for a given relationship name to
1465 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1466 New file: database access object for getting the related list
1467 navigation information (the table name and the primary key value).
1468 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
1469 DTO for transferring a table name to navigate to and a primary key
1471 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1472 boolean and getter/setter to specifies if the related list should add
1475 2011-10-24 Murray Cumming <murrayc@murrayc.com>
1477 Use the master branch of java-libglom
1479 * pom.xml: Depend on java-libglom 1.19 instead.
1481 This is the master branch. See also the libglom-1-18 branch.
1483 2011-10-11 Ben Konrath <ben@bagu.org>
1485 Enable the open navigation button when the data has been set.
1487 This avoids having active buttons that don't do anything when the data
1490 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1492 2011-10-11 Ben Konrath <ben@bagu.org>
1494 Use IsWidget interface for FlowTableItem.
1496 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
1497 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
1499 2011-10-11 Ben Konrath <ben@bagu.org>
1501 Remove GWT styling from open button in details view.
1503 There are still some issues with how the details cell is arranged but
1504 this should be made to match Glom 1.20. I'm going to leave fixing this
1505 until I have Glom 1.20 up and running.
1507 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
1508 style name on open button.
1509 * src/main/webapp/style.css: Move and edit details-navigation class.
1510 Re-arrange some classes to make them appear in the same order as the
1513 2011-10-07 Ben Konrath <ben@bagu.org>
1515 Update to GWT 2.4.0.
1517 * .gitignore: Ignore new cache directory.
1518 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
1519 * pom.xml: Change GWT and maven plugin to 2.4.0.
1520 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
1522 * src/main/java/org/glom/web/client/ClientFactory.java:
1523 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
1524 * src/main/java/org/glom/web/client/OnlineGlom.java:
1525 Update source for API changes.
1526 * utils/build-onlineglom-war.sh: Remove cache directory before the
1529 2011-10-07 Ben Konrath <ben@bagu.org>
1531 Add navigation buttons in the details view.
1533 This isn't finished but I thought I'd commit what I have as it's a
1534 pretty good start. I still need to:
1536 1. Change the style so that it fits better into the current theme
1537 2. Adjust the details cell to expand as much as possible.
1539 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
1540 click handlers to navigation buttons in the DetailsCells. Create a
1541 refreshData() method to get just the data from the server without the
1543 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1544 Update the tableSelector and browser title when the table name
1545 changes without using the tableSelector.
1546 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1547 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1548 getDetailsCells() to getCells(). Update variable names.
1549 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
1550 method to set click handler on navigation button. Rename a few
1551 variables. Add navigation buttons where needed.
1552 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
1553 variables and methods.
1554 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
1555 navigation boolean and navigation table as required in the
1556 LayoutItemField DTO.
1557 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
1558 variables for navigation along with getter/setter methods.
1560 2011-10-07 Ben Konrath <ben@bagu.org>
1562 Rename Field to DetailsCell.
1564 This is a refactor-only commit. No functionality has been added or
1567 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1568 Update variable and method names.
1569 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1570 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
1571 variable and method names.
1572 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1574 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
1575 variable and method names.
1577 2011-10-07 Ben Konrath <ben@bagu.org>
1579 Create separate methods for layout and data the details view.
1581 This is a refactor-only commit. No functionality has been added or
1584 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
1585 private methods: setData(), createLayout().
1587 2011-10-07 Ben Konrath <ben@bagu.org>
1589 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
1591 This is part of a change to get navigation buttons in the details view
1592 but it should have been done this way from the start.
1594 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1595 for method name change in TableSelectionView.
1596 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1597 Create TableChangeEvent and set the browser title using the
1598 TableSelectionView API.
1599 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1600 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1601 Change getSelectedTable() to getSelectedTableName(). Add
1602 getSelectedTableTitle().
1604 2011-10-07 Ben Konrath <ben@bagu.org>
1606 Use primaryKeyValue naming convention in constructor of DetailsPlace.
1608 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1610 2011-10-07 Ben Konrath <ben@bagu.org>
1612 Update TableChangeEvent to use newTableName naming convention.
1614 This makes the class more consistent with GWT naming conventions.
1616 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1617 Update for method name change in TableChangeEvent.
1618 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
1619 for method name change in TableChangeEvent.
1620 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
1621 newTableName variable and getter method. Make toDebugString()
1624 2011-09-30 Ben Konrath <ben@bagu.org>
1626 Disable the pager in the list tables when the data row count is less than the minimum.
1628 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1629 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1631 2011-09-30 Ben Konrath <ben@bagu.org>
1633 Add empty rows to the end of related list and list view tables.
1635 I also extracted the cell rendering classes from the ListTable because
1636 the code was becoming a little crazy with all the anonymous inner
1637 classes. My plan is to use these cell rendering classes in the details
1638 view as well so this refactor will be needed for that change.
1640 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
1641 set the row count in related list tables if the data has more rows
1642 than the minimum number of rows visible.
1643 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
1644 row count in list view tables if the data has more rows than the
1645 minimum number of rows visible.
1646 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
1647 for rendering TYPE_BOOLEAN cells. The code was extracted from the
1649 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
1650 for rendering TYPE_NUMERIC cells. The code was extracted from the
1652 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
1653 class for rendering cells with buttons in list views. The code was
1654 extracted from the ListTable class.
1655 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
1656 for rendering TYPE_TEXT cells. The code was extracted from the
1658 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1659 Add empty rows to the end of the data if required. Implement
1660 ListTable.getMinNumVisibleRows().
1661 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
1662 cell renderer code to public classes. Return null in
1663 Column.getValue() for empty rows. Add new abstract method:
1664 getMinNumVisibleRows(). Move code to set the row count of the list view
1665 table to ListViewImpl.
1666 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
1667 empty rows to the end of the data if required. Implement
1668 ListTable.getMinNumVisibleRows().
1671 2011-09-27 Ben Konrath <ben@bagu.org>
1673 Use GWT.log for client-side debugging statements.
1675 These are optimized out when deployed so I should have used this method
1676 in the first place. These statements will eventually be replaced with some sort
1677 of notification in the browser.
1679 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1680 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1681 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1682 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1683 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1685 2011-09-27 Ben Konrath <ben@bagu.org>
1687 Put tableselector on the right, back to list link on right.
1689 The idea is that the table selector is acting like a label for the
1690 currently displayed table so it should be placed below the document title. This
1691 puts the table title in a similar position to where it is in Glom.
1693 * mockups/details-contacts.html:
1694 * mockups/details-projects.html:
1695 * mockups/listview-contacts.html:
1696 * mockups/listview-projects.html:
1697 * mockups/style.css:
1698 Update mockups to match how the interfaces currently look.
1699 * src/main/webapp/style.css: Swap positions of backlink with the table
1700 selector. Add some space on the left side of the table selector to
1701 line things up with the document title.
1703 2011-09-27 Ben Konrath <ben@bagu.org>
1705 Add field colouring to details view.
1707 This change re-works how field colouring works. The colour formatting
1708 information is now set to the client with the layout information instead of
1709 with the data. This eliminates the need to send the same colour strings for
1710 data in list view column when colour information is set.
1712 In order to set an alternate colour for negative numeric values, the
1713 number is now sent to client and formatted with the GWT NumberFormat class.
1715 This change also fixes:
1717 https://bugzilla.gnome.org/show_bug.cgi?id=659752
1719 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
1720 internationalization framework which is needed for client side numeric
1722 * src/main/java/org/glom/web/client/Utils.java: New file for some
1723 client static utility methods.
1724 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
1725 the DataItem object to the Field class. Use a utility method to
1726 create the foreignKeyValue string.
1727 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
1728 alignment and text colours in the constructor. Add setData(DataItem)
1729 method. Remove setText(String) method.
1730 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
1731 colour information to GlomTextCell. Create and use GlomNumberCell for
1732 rendering numbers. Use utility method to get the string for the
1733 primary key of the key provider. Re-work how the horizontal alignment
1735 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1736 formatting to layout information. Methods for converting the libglom
1737 formatting information were moved from DBAccess.
1738 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
1739 numeric formatting (it's now done on the client side). Don't set text
1740 colours in DataItem. Move libglom formatting conversion methods to
1742 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
1743 getters/setters for text colour information.
1744 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
1745 for transferring the libglom NumericFormat information to the client.
1746 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
1747 and getters/setters for: GlomNumericFormat, background colour and
1748 foreground colour strings.
1750 2011-09-26 Ben Konrath <ben@bagu.org>
1752 Simplify code that iterates through the LayoutGroup.
1754 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1756 2011-09-26 Ben Konrath <ben@bagu.org>
1758 Accept Eclipse formatting for OnlineGlomServiceAsync.
1760 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1762 2011-09-26 Ben Konrath <ben@bagu.org>
1764 Don't use the ListDBAccess classes to get the primary key layout information.
1766 This was causing a bug where the wrong index for the hidden primary key
1767 was being sent to the client.
1769 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
1770 primary key while creating the LayoutGroup DTO. Create a
1771 LayoutItemField DTO for hidden primary keys. Don't use the
1772 RelatedListDBAccess because it was only used for getting the primary
1774 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
1775 access modifier from public to protected for getPrimaryKeyField() and
1776 getPrimaryKeyLayoutItemField().
1777 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
1778 abstract method getExpectedResultSize() because RelatedListDBAccess
1779 doesn't have enough info to implement it.
1780 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1781 Remove @Override for getExpectedResultSize().
1782 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1783 Remove method getExpectedResultSize().
1785 2011-09-23 Ben Konrath <ben@bagu.org>
1787 Log which layout (list or details) the ignored item is from.
1789 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1791 2011-09-23 Ben Konrath <ben@bagu.org>
1793 Remove annotations that turn off code formatting in DataItem.
1795 * src/main/java/org/glom/web/shared/DataItem.java:
1797 2011-09-23 Ben Konrath <ben@bagu.org>
1799 Rename GlomField to DataItem and update associated methods.
1801 This is a rename-only refactor. No functionality has been added or
1804 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1805 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1806 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1807 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1808 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1809 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1810 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1811 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1812 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1813 * src/main/java/org/glom/web/server/database/DBAccess.java:
1814 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1815 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1816 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1817 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1818 * src/main/java/org/glom/web/shared/DataItem.java:
1819 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
1820 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
1822 2011-09-23 Ben Konrath <ben@bagu.org>
1824 Rename GlomDocument to DocumentInfo and update associated methods.
1826 This is a rename-only refactor. No functionality has been added or
1829 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1830 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1831 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1832 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1833 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1834 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1835 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1837 2011-09-20 Ben Konrath <ben@bagu.org>
1839 Require java-libglom 1.17.3.
1841 This picks up the fix for the seg fault problem with the Scenes table
1842 in the Openismus Film Manager example.
1846 2011-09-20 Ben Konrath <ben@bagu.org>
1848 Change the way sort clause is added for primary key when no sort clause is requested.
1850 The primary key is now added to the LayoutFieldVector (fieldsToGet)
1851 before the sort clause is created. When a sort clause is not requested, the
1852 sort clause is created by finding the primary key in the LayoutFieldVector
1855 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1857 2011-09-20 Ben Konrath <ben@bagu.org>
1859 Log error message if no documents are found in the configured directory.
1861 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
1862 Extract the glom file extension string to a private static final class
1863 variable (mostly as syntactic sugar). Accept a minor formatting change.
1864 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
1865 the example glom.document.directory configuration property to make it
1866 more clear that it can any directory, not just the home directory.
1868 2011-09-18 Ben Konrath <ben@bagu.org>
1870 Add related lists to details view.
1872 The related list table has support for paging and sorting just like the
1873 table in the list view.
1875 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
1876 SQL queries for the related list tables.
1877 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1878 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1879 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1880 Rename getList methods to getListView and add comments. Remove
1881 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
1882 it being unused. Add methods: getDetailsLayoutAndData(),
1883 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
1884 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1885 Create the layout and set the data for the fields in one async call
1886 instead of two. Create related lists where appropriate.
1887 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
1888 for method name changes in OnlineGlomService.
1889 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1890 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
1891 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
1893 * src/main/java/org/glom/web/client/ui/ListView.java:
1894 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
1895 tableName from setCellTable(). Create a ListViewTable instead of
1897 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
1898 represent a data field in the details view.
1899 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
1900 from addDetailsCell() to Field class. Keep track of the Fields and
1901 Portals in the details view.
1902 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
1903 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
1904 and add a method to get it. Add method to set the contents of the
1906 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1907 New class for related list tables. This class has the data provider
1908 for the related list table.
1909 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
1910 abstract class which is the base class for the ListViewTable and the
1912 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1913 New class for list view tables. This class has the data provider for
1914 the list view table.
1915 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
1916 methods for related list tables. Add more information to the
1917 LayoutItemField and LayoutItemPortal DTOs.
1918 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1919 Remove debugging print statement.
1920 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1921 Remove debugging print statements. Add primary key field to SQL count
1923 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1924 Remove unnecessary LayoutFieldVector parameter from
1925 getResultSizeOfSQLQuery() method.
1926 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1927 New class for related list table database access.
1928 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
1929 class that is a wrapper DTO for details view layout and data.
1930 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
1931 new 'fromField' string to this DTO.
1932 * src/main/webapp/style.css: Remove bottom margin and override top
1935 2011-09-15 Ben Konrath <ben@bagu.org>
1937 Breakup the OnlineGlomServiceImpl class to make it more manageable.
1939 This sets things up to make it easier to add the data retrieval for
1940 related lists (portals). No user noticeable changes were made with
1943 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
1944 class has the code to retrieve the layouts and access the
1945 database using the new database helper classes.
1946 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1947 Most of the functionality has been removed from this class. This
1948 class now represents the public interface for the client side
1949 code. It also deals with configuring the servlet and cleaning
1950 things up when the servlet is stopped.
1951 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
1952 of static methods into this utility class.
1953 * src/main/java/org/glom/web/server/database/DBAccess.java:
1954 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1955 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1956 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1957 These classes have the database retrieval code. The class hierarchy
1958 has been setup to make it easy to reuse code for similar
1961 2011-09-06 Ben Konrath <ben@bagu.org>
1963 Create separate classes for list table code and the data provider.
1965 As part of this refactor, I also split up the code a bit to make it
1968 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
1969 table code to two new classes (below).
1970 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
1971 with code from ListViewImpl.
1972 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
1973 New file with code from ListViewImpl.
1975 2011-09-06 Ben Konrath <ben@bagu.org>
1977 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
1979 This fixes the LayoutItemPortal DTO to match the libglom layout object
1982 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
1984 2011-09-01 Ben Konrath <ben@bagu.org>
1986 Set title of Portals in the Details View.
1988 * pom.xml: Bump required version of java-libglom to 1.17.1.
1989 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
1990 widget creation to its own class. Add comments to constructor.
1991 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
1992 The code is mostly from the Group class with the title now set.
1993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
1994 title of Portal. Update some comments. Fix some code formatting.
1996 2011-09-01 Ben Konrath <ben@bagu.org>
1998 Remove TODO comment for the flow table column width.
2000 The flow table column width is working correctly and doesn't need to be
2001 changed. See this mailing list post for more info:
2003 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2005 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2007 2011-08-27 Ben Konrath <ben@bagu.org>
2009 Add document title (database name) to top of the browser page.
2011 I added the document title to the TableSelecitonView but that will
2012 change if / when we add a view that doesn't require table selection.
2014 * mockups/details-contacts.html:
2015 * mockups/details-projects.html:
2016 * mockups/listview-contacts.html:
2017 * mockups/listview-projects.html:
2018 * mockups/style.css: Add document title to mockups to keep things
2020 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2021 sizes to account for the document title.
2022 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2023 Set the document title when it has been retrieved from the server.
2024 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2025 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2026 and implement setDocumentTitle(String) method.
2027 * src/main/webapp/style.css: Add ID for document title style.
2029 2011-08-25 Ben Konrath <ben@bagu.org>
2031 Add NavigationType enum to LayoutItemPortal DTO.
2033 This is the start of adding support for Portals to the Details View.
2035 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2036 LayoutItem_Portal.navigation_type enum from libglom to
2037 LayoutItemPortal.NavigationType enum.
2038 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2039 NavigationType enum, field for storing the NavigationType and getter
2042 2011-08-25 Ben Konrath <ben@bagu.org>
2044 Implement the flow table layout in the Details View.
2046 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2047 FlowTable to Group to account for the renamed class.
2048 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2049 File. This is a container widget that implements the Glom details view
2050 flow table behaviour.
2051 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2052 org/glom/web/client/ui/FlowTable.java.
2053 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2054 so that the size of the subgroups are a closer match to the size of
2055 the Glom subgroups. This makes the flowtable layout match the layout
2056 in Glom for the Music Collection example file.
2058 2011-08-16 Ben Konrath <ben@bagu.org>
2060 Create container element for LayoutItemPortal in Details View.
2062 This will help me develop the layout for the FlowTable.
2064 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2065 fieldPanel variable to detailsCell.
2067 2011-08-15 Ben Konrath <ben@bagu.org>
2069 Set the height of the data element in the Details View.
2071 I changed the InlineLabels (text in a span element) to Labels (text in
2072 a div element) so that I could set the height of the details-data
2073 elements instead of the details-cell parent elements. This allows the
2074 the details-data element to display the correct height if style is
2075 applied that shows the height.
2077 This change has the added benefit of allowing the order of the labels
2078 and data elements to be changed for right-to-left languages.
2080 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2081 InlineLabels to Labels.
2082 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2083 InlineLabels to Labels. Set the height of the data element.
2084 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2085 multiline text height in the Formatting DTO.
2086 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2087 for multiline height along with getter and setter methods.
2088 * src/main/webapp/style.css: Adjust style to account for the change
2089 from span elements to div elements in the details cell.
2091 2011-08-15 Ben Konrath <ben@bagu.org>
2093 Make the List View appearance match the mockups.
2095 It doesn't match exactly but it's much better than it was.
2097 * mockups/listview-contacts.html: Remove unused css classes.
2098 * mockups/listview-projects.html: Remove unused css classes.
2099 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2100 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2101 for mainPanel instead of VerticalPanel (table). Set style name on
2102 CellTable. Set style name on Details column. Right-align Details
2104 * src/main/webapp/style.css: Adjust properties to match the mockups.
2106 2011-08-12 Ben Konrath <ben@bagu.org>
2108 Add better support for subgroups in the details view.
2110 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2111 changed FlowTable constructor.
2112 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2113 support for subgroups and subgroup-titles.
2114 * src/main/webapp/style.css: Add CSS class for subgroups and
2117 2011-08-12 Ben Konrath <ben@bagu.org>
2119 Return the top level LayoutGroup title.
2121 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2123 2011-08-11 Ben Konrath <ben@bagu.org>
2125 Make the TableSelector header match the mockup.
2127 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2128 the layout panel. Properly lineup the table selection header with
2129 the list and details view.
2130 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2131 margin around the details view.
2132 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2133 Rename listBox variable to tableSelector. Set id for the style sheet.
2134 Use a FlowPanel instead of a HorizontalPanel.
2135 * src/main/webapp/style.css: Add properties to make the TableSelector
2136 box match the mockups.
2138 2011-07-13 Ben Konrath <ben@bagu.org>
2140 Update install script for java-libglom version change.
2142 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2145 2011-07-13 Ben Konrath <ben@bagu.org>
2147 Add support sub-group in the details view.
2149 I also removed the code that special-cased the default details view
2152 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2154 I still have to make a proper flowtable.
2156 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2157 Don't special-case default details view layout.
2158 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2159 addLayoutField() as I'm going to use it.
2160 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2161 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2163 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2164 extracted from DetailsViewImpl.GroupPanel. Add support for
2166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2167 column count when getting the details layout.
2169 2011-07-12 Ben Konrath <ben@bagu.org>
2171 Set browser title with database and table titles.
2173 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2174 Set the browser title when the table changes and when the activity
2176 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2177 title when retrieving document info (the GlomDocument object).
2178 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2179 with getter and setter methods. Remove unused convenience constructor.
2180 Use default code formatting.
2182 2011-07-12 Ben Konrath <ben@bagu.org>
2184 Ignore LayoutItemPortals in the details view.
2186 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2189 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2190 LayoutItemPortal layout objects.
2191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2192 LayoutItemPortal objects when retrieving the details layout.
2193 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
2194 file. This is an empty class and just used to get type information for
2197 2011-07-12 Ben Konrath <ben@bagu.org>
2199 Use java-libglom 1.17.0.
2203 2011-07-11 Ben Konrath <ben@bagu.org>
2205 Remove "Table:" label from table selector.
2207 This matches a recent change in the Glom UI.
2209 * mockups/details-contacts.html:
2210 * mockups/details-projects.html:
2211 * mockups/listview-contacts.html:
2212 * mockups/listview-projects.html: Remove the "Table:" label from the
2214 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2216 2011-07-11 Ben Konrath <ben@bagu.org>
2218 Add main groups to the details view.
2220 This makes things look a little nicer in the details view. The next step
2221 is to implement the flowtable.
2223 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
2224 resources from the standard gwt css theme. Standard.css is now
2225 included in OnlineGlom.html so that the online glom css rules have
2226 precedence over the gwt theme.
2227 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2228 the whole LayoutGroup to the DetailsView instead of just the titles.
2229 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2230 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
2231 details layout with a helper class (GroupPanel). I might extract this
2232 class when I make the full flowtable.
2233 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
2234 string as default so I don't have to worry about NPEs when processing
2236 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
2237 note beside OnlineGlom.gwt.xml above).
2238 * src/main/webapp/style.css: Add default font-size to body to override
2239 the font-size set by the standard theme. Don't use h2 tags for
2240 group-title. Create new details-cell class.
2242 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2244 ConfiguredDocument: Set the port number too.
2246 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2247 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
2248 Glom document. Presumably this worked sometimes so far because there is a
2249 default port number.
2251 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2253 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
2255 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2256 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
2257 correct, though we should throw an exception too.
2259 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2261 Fix a addDocuemnt typo.
2263 * src/main/java/org/glom/web/shared/Documents.java
2264 (Documents.addDocuemnt): Rename to addDocument().
2265 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2266 (OnlineGlomServiceImpl.getDocuments): Adapt.
2268 2011-07-08 Murray Cumming <murrayc@murrayc.com>
2270 Slightly improved log output when connection fails.
2272 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2273 (ConfiguredDocument.setUsernameAndPassword):
2274 We don't know for sure if it' the username/password that's wrong, so
2275 rephrase the message.
2276 Also ouput the exception message, though it's generic in this case.
2278 2011-07-08 Ben Konrath <ben@bagu.org>
2282 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
2283 added braces to a one line if statement because the Eclipse formatter
2284 was getting confused.
2286 2011-07-07 Ben Konrath <ben@bagu.org>
2288 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
2290 These should really be two separate tasks but I counldn't get things to
2291 work with GWT 2.2.0 and Eclipse 3.7.
2295 * .settings/org.eclipse.jdt.core.prefs:
2296 * .settings/org.eclipse.jdt.ui.prefs:
2297 * .settings/org.eclipse.ltk.core.refactoring.prefs:
2298 * .settings/org.eclipse.m2e.core.prefs:
2299 Add new config files. Update current files. Remove references to the
2300 webtools plugins as we're not using any of the webtools features.
2301 * .gitignore: Add logs directory which is created when running with
2303 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
2304 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
2305 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
2307 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
2309 2011-07-07 Murray Cumming <murrayc@murrayc.com>
2311 onlineglom.properties: Add explanatory comments.
2313 * src/main/resources/onlineglom.properties: Also change the default user
2314 from ben to someuser, to avoid the risk of people thinking we just
2315 stupidly hard-coded a locale path, when they see that on stderr or in a log.
2317 2011-06-28 Ben Konrath <ben@bagu.org>
2319 Use filename in Log for incorrect passwords.
2321 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2322 getFileName(String) method to get the filename from the URI.
2324 2011-06-28 Ben Konrath <ben@bagu.org>
2326 Add the table name to the URL token for the ListPlace.
2328 This makes things consistent between the DetailsPlace and the
2329 ListPlace. It also allows the the ListPlace to be bookmarked.
2331 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2332 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2333 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2334 Remove getDefaultListLayout(). The default layout is now returned
2335 by the getListLayout() method when the table name is an empty string.
2336 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2337 Add table name field. Change to a new ListPlace when the table
2338 has been changed. Use getListLayout() for getting the default
2340 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2341 Add table name field. Set the correct table name in the list box
2342 when loading from bookmark. This corrects a problem for the
2344 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2345 Move table name to super-class (HasSelectableTable). Move document
2346 and table URL keys to super-class in HasSelectableTable.
2347 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2348 Add table name field. Add Tokenizer class with URL key common to
2349 the subclasses (DetailsPlace and ListPlace).
2350 * src/main/java/org/glom/web/client/place/ListPlace.java:
2351 Add table name. Add code to parse the URL token.
2352 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2353 Update ListPlace construction with empty table name string.
2354 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2355 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2356 Change setTableSelectedIndex(int) to setSelectedTableName(String).
2357 Update ListPlace construction with table name string.
2358 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2359 Change defaultTableName field to tableName to reflect how it's now
2360 used. Update the getter and setter methods.
2362 2011-06-28 Ben Konrath <ben@bagu.org>
2364 Enable the table selector in the DetailsView.
2366 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2367 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2368 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2369 Remove getDefaultDetailsLayout(). The default layout is now returned
2370 by the getDetailsLayout() method when the table name is an empty
2372 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2373 event handler for table change event. Change to using
2374 getDetailsLayout() for the default details layout.
2375 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
2377 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
2378 when navigating to the details place.
2380 2011-06-27 Ben Konrath <ben@bagu.org>
2382 Use filename based unique document ID in URL and for RPC.
2384 The document ID is the glom document name with spaces (' ') replaced
2385 with pluses ('+') and without the .glom extension.
2387 This change is mostly a string substitution of 'documentTitle' for
2388 'documentID'. The only code change is the addition of a Documents DTO to get the
2389 filename to document title mappings as indicated below.
2391 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2392 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2393 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2394 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2395 Use Documents DTO to create the document links in the document
2397 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2398 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2399 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2400 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2401 * src/main/java/org/glom/web/client/place/ListPlace.java:
2402 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2403 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2404 * src/main/java/org/glom/web/client/ui/ListView.java:
2405 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2406 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2407 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2408 * src/main/java/org/glom/web/server/Log.java:
2409 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2410 getDocumentTitles() to getDocuments() and return the Documents DTO.
2411 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
2412 transferring the filename to document title mappings.
2414 2011-06-25 Ben Konrath <ben@bagu.org>
2416 Make the authentication popup work again.
2418 This bug was introduced when I extracted ConfiguredDocument to its own class.
2420 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
2421 correct success / fail status in setUsernameAndPassword().
2423 2011-06-25 Ben Konrath <ben@bagu.org>
2425 Use filename as unique key for configuring database usernames and passwords.
2427 This replaces the use of the Glom document title which could change
2428 depending on the locale. Thanks to Murray Cumming for pointing out this
2431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2432 * src/main/resources/onlineglom.properties:
2434 2011-06-24 Ben Konrath <ben@bagu.org>
2436 Pass primary key value to DetailsView.
2438 This enables the DetailsView to load the correct data.
2440 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2441 primary key value field and set in constructor. Pass primary key
2442 value to getDetailsData().
2443 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL
2444 variables for document title and primary key value.
2445 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Pass primary
2446 key value to the DetailsPlace.
2448 2011-06-24 Ben Konrath <ben@bagu.org>
2450 Add primary key index to LayoutGroup DTO and add ProvidesKey to CellTable.
2452 This allows the primary key to be retrieved by the Details button. This
2453 functionality has not been implemented yet but it's in the works.
2455 * src/main/java/org/glom/web/client/activity/ListActivity.java: Pass
2456 the LayoutGroup result to ListView.setCellTable instead of all of its
2457 fields individually.
2458 * src/main/java/org/glom/web/client/ui/ListView.java:
2459 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use
2460 LayoutGroup as parameter for setCellTable. Add ProvidesKey to CellTable
2461 get the primary key for the table.
2462 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2463 index of the primary key in the LayoutGroup accounting for hidden
2464 primary keys. Rename getJavaNumberFormat() to
2465 convertToJavaNumberFormat() for consistency. Cleanup / add some
2467 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add a
2468 field for primary key index and a field to indicate whether the
2469 primary key is hidden or not.
2471 2011-06-23 Ben Konrath <ben@bagu.org>
2473 Rename getTableData methods to getListData.
2475 This is a rename refactor for consistency with other methods.
2477 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2478 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2479 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2480 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2482 2011-06-23 Ben Konrath <ben@bagu.org>
2484 Extract the ConfiguredDocument innerclass into its own class.
2486 This makes the servlet code more object oriented.
2488 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Extracted
2489 from private ConfiguredDocument class in OnlineGlomServiceImpl.
2490 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use the
2491 new ConfiguredDocument class.
2493 2011-06-21 Ben Konrath <ben@bagu.org>
2495 Use the LayoutGroup group for the list layout instead of ColumnInfo and LayoutListTable.
2497 This makes things more inline with how libglom works and reduces code
2498 duplication. This refactor lays the groundwork for adding the primary key to
2499 the LayoutGroup object.
2501 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2502 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2504 Change method names to getListLayout and getDefaultListLayout for
2505 consistency. Use LayoutGroup as the DTO for the list layout instead of
2506 ColumnInfo and LayoutListTable.
2507 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use the
2508 new method names along with the LayoutGroup object for transferring the
2510 * src/main/java/org/glom/web/client/ui/ListView.java:
2511 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2512 Use ArrayList<LayoutItem> instead of ColumnInfo[] in setCellTable().
2513 * src/main/java/org/glom/web/shared/ColumnInfo.java: Deleted. Replaced
2515 * src/main/java/org/glom/web/shared/LayoutListTable.java: Deleted.
2516 Replaced with LayoutGroup.
2517 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java: Add
2518 expectedResultSize and defaultTableName fields which are needed for
2520 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2521 type field which is needed for the list layout but will also be
2522 useful for the details layout as things progress.
2523 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2524 Make class abstract. Remove the unnecessary
2525 getFormattingHorizontalAlignment method. Add setFormatting method.
2527 2011-06-16 Ben Konrath <ben@bagu.org>
2529 Add scripts for building and installing war.
2531 These will help when updating OnlineGlom but they're also good
2532 supplemental documentation of the build and deployment proceeding.
2534 * utils/build-onlineglom-war.sh: New file.
2535 * utils/install-onlineglom-war.sh: New file.
2537 2011-06-16 Ben Konrath <ben@bagu.org>
2539 Create wrapper class to create consistent log messages.
2541 I wrapped methods in the Log class of gwt-log to add the method names
2542 from the servlet and create consistent formatting of the document title
2543 and table names in the log messages.
2545 * src/main/java/org/glom/web/server/Log.java: New file with wrapped methods.
2546 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert all
2547 log methods to use methods from wrapped Log class.
2549 2011-06-16 Ben Konrath <ben@bagu.org>
2551 Remove superfluous conditional return.
2553 Thanks to Murray Cumming for pointing this out!
2555 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2557 2011-06-15 Ben Konrath <ben@bagu.org>
2559 Return an ArrayList of LayoutGroups for the Details layout.
2561 This corrects a problem with the details layout as it can have more
2562 than one top level LayoutGroup.
2564 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2565 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Change
2566 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return
2567 an ArrayList<LayoutGroup> in the get*DetailsLayout methods.
2568 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Deal
2569 with ArrayList of LayoutGroups for the details view layout.
2570 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
2571 method name from get*DetailsLayoutGroup to get*DetailsLayout. Return an
2572 ArrayList<LayoutGroup> in the get*DetailsLayout methods. Inline
2573 getTableFieldsToShowForSequence() into getFieldsToShowForSQLQuery() to simplify
2574 the code a bit. Rename getTableFieldsToShowForSequenceAddGroup() to
2575 getFieldsToShowForSQLQueryAddGroup() to try to keep things more consistent.
2577 2011-06-14 Ben Konrath <ben@bagu.org>
2579 Use cast_dynamic method to determine the libglom LayoutItem type.
2581 This is better than finding the LayoutItem type by using the string
2582 returned from the get_part_type_name() method.
2584 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2586 2011-06-14 Ben Konrath <ben@bagu.org>
2588 Add method names to log entries in the servlet.
2590 This helps when tracking down deployment problems.
2592 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2594 2011-06-14 Ben Konrath <ben@bagu.org>
2596 Add data to the DetailsView using a hard-coded primary key value.
2598 The layout and functionality of the DetailsView is not complete. This
2599 is just a checkpoint so the patch doesn't get too big.
2601 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2602 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2603 Add getDetailsData() servlet method.
2604 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2605 Add RPC to getDetailsData(). Change the way the LayoutGroups and
2606 LayoutFields are added to the DetailsView.
2607 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2608 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2609 Add setData() method. Change addLayoutGroup() and addLayoutField() to
2610 take the string for the title instead of the object.
2611 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2612 Add implementation getDetailsData() along with some private helper
2614 * src/main/webapp/style.css: Add padding to details-data class. Add a
2615 details-label class with the same padding as the details-data class.
2617 2011-06-03 Ben Konrath <ben@bagu.org>
2619 Use presenter.goTo() to change to the DetailsPlace.
2621 This will make things easier when we need to open the DetailsView with
2622 data specific to the row that was clicked.
2624 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2626 2011-06-02 Ben Konrath <ben@bagu.org>
2628 Add CSS file from mockups.
2630 I'm adding this now because it's going to be useful to have when
2631 developing the DetailsView. The TableSelectionView and ListView aren't
2634 * src/main/webapp/OnlineGlom.html:
2635 * src/main/webapp/style.css:
2637 2011-06-02 Ben Konrath <ben@bagu.org>
2639 Use String.isEmpty() to check for empty string.
2641 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2643 2011-06-02 Ben Konrath <ben@bagu.org>
2645 Display main layout group titles in the DetailsView.
2647 This is the start of the DetailsActivity/DetailsView implementation.
2649 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2650 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2651 Add getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup() methods.
2652 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2653 Get the layout information for the details view from the server and set
2654 the main layout group titles.
2655 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2656 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2657 Add addLayoutGroup() and addLayoutField() methods. This are just
2658 temporary methods for creating the the details view that will change
2660 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2661 Implement getDetailsLayoutGroup() and getDefaultDetailsLayoutGroup()
2663 * src/main/java/org/glom/web/shared/layout/Formatting.java:
2664 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2665 * src/main/java/org/glom/web/shared/layout/LayoutItem.java:
2666 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java:
2667 * src/main/java/org/glom/web/shared/layout/LayoutItemWithFormatting.java:
2668 Data Transfer Objects that mimic the libglom object structure. These are
2669 used for transferring the details layout but could also be used for
2670 transferring the list layout.
2672 2011-05-27 Ben Konrath <ben@bagu.org>
2674 Reset the AuthenticationPopup when clearing the ListView.
2676 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2678 2011-05-27 Ben Konrath <ben@bagu.org>
2680 Fix problem with onlineglom.properties file loading.
2682 The old way worked in Eclipse but not on the server. Loading the
2683 onlineglom.properties file now works in Eclipse and on the server.
2685 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2687 2011-05-24 Ben Konrath <ben@bagu.org>
2689 Update gwt-log from 3.1.0 to 3.1.2.
2691 Gwt-log 3.1.0 has been marked as depreciated.
2695 2011-05-24 Ben Konrath <ben@bagu.org>
2697 Add comment to ListActivity.goTo() method.
2699 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2701 2011-05-24 Ben Konrath <ben@bagu.org>
2703 Remove FIXME in convertGdkColorToHtmlColour()
2705 The Gdk::Color value returned by libglom is 16-bits per channel on both
2706 64 and 32-bit platforms.
2708 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2710 2011-05-19 Ben Konrath <ben@bagu.org>
2712 Improve performance of initial ListView load.
2714 I removed a round trip to the server for getting the default table name
2715 and then requesting information about that table. This also removes a potential
2716 problem with the table change handler not being setup in time to receive the
2717 table change event from the ListActivity.
2719 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2720 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2721 getDefaultLayoutListTable() method. Improve comments.
2722 * src/main/java/org/glom/web/client/activity/ListActivity.java: Use
2723 getDefaultLayoutListTable() method instead of firing a table change
2724 event to get the table to load.
2725 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
2726 implementation of getDefaultLayoutListTable() method.
2727 * src/main/java/org/glom/web/shared/LayoutListTable.java: Add field for
2730 2011-05-19 Ben Konrath <ben@bagu.org>
2732 Override toDebugString() in TableChangeEvent.
2734 This is useful to have for debugging.
2736 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2738 2011-05-19 Ben Konrath <ben@bagu.org>
2740 Add a "Back to List" link when at the DetailsPlace.
2742 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2743 Populate the CellTable based on the selected table of the ListBox if
2744 it's set otherwise use the default table. This allows the "Back to
2746 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2747 Remove Place from constructors. Add a setPlace() method. Add
2748 goToPlace() method. Set class as presenter for TableSelectionView.
2749 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2750 Use the same TableSelectionActivity when switching between the List and
2752 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2753 Subclass the new HasSelectableTablePlace. This removes some duplicate
2755 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2756 New class to represent Places that display the TableSelectionView.
2757 * src/main/java/org/glom/web/client/place/ListPlace.java:
2758 Subclass the new HasSelectableTablePlace. This removes some duplicate
2760 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2761 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2762 Add Presenter interface. Add setBackLinkVisible() method. Add
2763 setBackLink() method.
2765 2011-05-18 Ben Konrath <ben@bagu.org>
2767 Enable the "Details" buttons.
2769 Right now only an empty details view is displayed.
2771 * src/main/java/org/glom/web/client/ClientFactory.java:
2772 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2773 Add DetailsView to ClientFactory.
2774 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2775 A basic activity for the details view.
2776 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2777 Add a new constructor that takes a DetailsPlace. Rename shutdown() to
2779 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2780 Add DetailsPlace.Tokenizer to the list of tokens that are generated by
2782 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2783 Create a new DetailsActivity when a DetailsPlace is requested. Remove
2784 unnecessary super() in constructor.
2785 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2786 Create a new TableSelectionActivity when a DetailsPlace is requested. We
2787 really shouldn't create a new TableSelectionActivity for both the ListPlace
2788 and the DetailsPlace so this should be considered a temporary solution.
2789 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2790 New file. Represents a URL for the details view.
2791 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2792 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2793 A basic details view interface and implementation.
2794 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2795 Enable the "Details" buttons.
2797 2011-05-12 Ben Konrath <ben@bagu.org>
2799 Use a LayoutPanel with multiple display areas for main layout.
2801 This is mostly a refactor in that there are no changes from the user
2802 point of view. These changes are required so that we can swap out the list view
2803 with the details view when the user clicks the "Details" button.
2805 * src/main/java/org/glom/web/client/ClientFactory.java:
2806 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2807 OnlineGlomView. Add TableSelectionView, ListView and
2808 AuthenticationPopup.
2809 * src/main/java/org/glom/web/client/OnlineGlom.java: Use LayoutPanel
2810 for main layout. Add display regions for main activities. Add
2811 activity manager for for main activities.
2812 * src/main/java/org/glom/web/client/activity/ListActivity.java: New
2813 file from parts of the deleted OnlineGlomActivity.
2814 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2815 New file from parts of the deleted OnlineGlomActivity.
2816 * src/main/java/org/glom/web/client/event/TableChangeEvent.java:
2817 * src/main/java/org/glom/web/client/event/TableChangeEventHandler.java:
2818 New files for app wide table change event.
2819 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java:
2820 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMapper.java:
2821 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMapper.java:
2822 Activity mappers for the main activities replace the deleted app-wide
2824 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java:
2825 Fix a spelling error in he comment.
2826 * src/main/java/org/glom/web/client/ui/ListView.java:
2827 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2828 Renamed from LayoutListView and modified for MVP. This still not a
2829 proper dumb view as prescribed by the MVP pattern but it works for now.
2830 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2831 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2832 New widget stripped out of the deleted OnlineGlomView.
2833 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2834 Remove hack that is fixed by this patch.
2836 2011-05-06 Ben Konrath <ben@bagu.org>
2838 Rename OnlineGlomPlace to ListPlace.
2840 The only change besides the rename is that url will now display #list
2841 instead of #Document.
2843 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2844 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2845 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2846 * src/main/java/org/glom/web/client/place/ListPlace.java:
2847 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2849 2011-05-06 Ben Konrath <ben@bagu.org>
2851 Use Presenter for app navigation.
2853 This is the proper way to deal with Place (URL) changes with the MVP
2856 * src/main/java/org/glom/web/client/ClientFactory.java:
2857 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Remove
2858 PlaceHistoryMapper and PlaceHistoryHandler.
2859 * src/main/java/org/glom/web/client/OnlineGlom.java: Re-add
2860 PlaceHistoryMapper and PlaceHistoryHandler.
2861 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2862 Don't use getHistoryMapper().getToken(place) to create the hyperlinks.
2863 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2864 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2865 Add Presenter interface and setPresenter methods. Rename addHyperLink
2866 to addDocumentLink taking only the document title as a parameter.
2868 2011-04-14 Ben Konrath <ben@bagu.org>
2870 Prompt for db username/password if they haven't been set.
2872 This is implemented with a popup widget that is contained within the
2873 OnlineGlomView and managed by the OnlineGlomActivity.
2875 * src/main/java/org/glom/web/client/OnlineGlomService.java: Two new
2876 methods for checking and setting the database username and password.
2877 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Two
2878 new methods for checking and setting the database username and
2880 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
2881 Display authentication popup if the JDBC connection to the database
2882 has not been authenticated.
2883 * src/main/java/org/glom/web/client/ui/AuthenticationPopup.java: New
2885 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
2886 for dealing with the authentication popup.
2887 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java:
2888 Implement the methods for dealing with the authentication popup.
2889 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Don't
2890 try to executed queries if the database connection hasn't been
2891 authenticated. Implement methods for checking and setting the
2892 database username and password.
2894 2011-04-12 Ben Konrath <ben@bagu.org>
2896 Make log messages a little clearer.
2898 Add a dash betweeen the document title and the table name.
2900 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2902 2011-04-12 Ben Konrath <ben@bagu.org>
2904 Protect against NPEs when cleaning up database resources.
2906 While this isn't strictly necessary because the exception is caught,
2907 not protecting against the NPEs makes it harder to find the real error
2910 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2912 2011-04-12 Ben Konrath <ben@bagu.org>
2914 Move configuration of the servlet to the constructor.
2916 The servlet will be initialized even if the database authentication
2917 information is not set or correct. I still need to add the UI for prompting
2918 the user for the authentication information when it's required.
2920 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
2921 javadocs for getDocumentTitles() method.
2922 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2923 Set error message when RPC fails.
2924 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Get the
2925 glom files directory from the configuration file. Try to set the
2926 database authentication information for the specific document if it's
2927 set and works otherwise try to use the global authentication
2928 information set for the directory.
2929 * src/main/resources/onlineglom.properties: Moved from
2930 src/main/webapp/WEB-INF/OnlineGlom.properties. Updated with new keys.
2931 Added detailed comments for the new keys.
2933 2011-04-11 Ben Konrath <ben@bagu.org>
2935 Remove unnecessary @Override in DocumentSelectionViewImpl.
2937 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2939 2011-04-11 Ben Konrath <ben@bagu.org>
2941 Remove center alignment in DocumentSelectionView.
2943 The title element is still centred but the document titles and bottom
2944 sentence are both left-aligned.
2946 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2948 2011-04-11 Ben Konrath <ben@bagu.org>
2950 Change 'Demo' naming convention to 'Document'.
2952 This is just a rename refactor with no functional changes to the code.
2954 * src/main/java/org/glom/web/client/ClientFactory.java:
2955 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2956 * src/main/java/org/glom/web/client/OnlineGlom.java:
2957 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2958 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2959 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2960 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java:
2961 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
2962 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2963 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2964 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2965 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2966 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2968 2011-04-08 Ben Konrath <ben@bagu.org>
2970 Remove FIXME from safeLongToInt() method.
2972 Libglom uses longs on 32-bit and 64-bit platforms so it's ok to use
2975 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2977 2011-04-08 Ben Konrath <ben@bagu.org>
2979 Display an error if no glom documents are found in the specified directory.
2981 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2982 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2983 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
2984 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2986 2011-04-08 Ben Konrath <ben@bagu.org>
2988 Add copyright header to one more file ... oops.
2990 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2992 2011-04-08 Ben Konrath <ben@bagu.org>
2994 Add copyright header to files without it.
2996 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
2997 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
2998 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
2999 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3000 * src/main/java/org/glom/web/shared/ColumnInfo.java:
3001 * src/main/java/org/glom/web/shared/GlomField.java:
3003 2011-04-08 Ben Konrath <ben@bagu.org>
3005 Add support for accessing multiple glom documents in the servlet.
3007 This completes the demo selection functionality.
3009 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add
3010 document title to methods.
3011 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3012 document title to methods.
3013 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3014 Set browser window title when the activity starts. Correct name of
3015 document title variable.
3016 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3017 Set browser window title when the activity starts. Set the table
3018 selector change handler after table selector has been set. Clear the
3019 OnlineGlomView when the activity has been stopped.
3020 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java: Use the
3021 document title as the place token. Use "#Document:" instead of
3022 "#OnlineGlomPlace:" in the URL.
3023 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3024 Change heading to "Online Glom"
3025 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Use
3026 document title in RPC methods.
3027 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Remove
3028 setDocumentTitle() method. Add clear() method.
3029 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Remove
3030 setDocumentTitle() method. Implement clear() method which removes the
3031 change handler on the ListBox, clears the ListBox and clears the
3033 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3034 Implement methods with document title. Keep track for the configured
3035 glom documents and their corresponding JDBC configurations in a hash
3036 table. This information is retrieved using the document title as the
3037 key in the hash table.
3038 * src/main/java/org/glom/web/shared/GlomDocument.java: Remove
3039 document title field as it's no longer needed.
3041 2011-04-08 Ben Konrath <ben@bagu.org>
3043 Update the Eclipse JDT configuration.
3045 * .settings/org.eclipse.jdt.ui.prefs: Automatically add comments to new
3046 methods. Automatically add the copyright header to new files.
3048 2011-04-05 Ben Konrath <ben@bagu.org>
3050 Add new page for demo selection.
3052 This patch adds all the components required to view and start an
3053 OnlineGlom demo by clicking on the desired hyperlink. The user is
3054 able to return to the demo selection page with the browser's back
3055 button. I still need to modify the servlet to work with multiple
3056 documents so all demo links will load the file defined in the
3057 OnlineGlom.properties.
3059 * .gitignore: Add .gwt which holds the error log for the GWT UiBuidler.
3060 This is only useful during development so we don't need to save it.
3061 * src/main/java/org/glom/web/client/ClientFactory.java: Add method to
3062 get a reference to the DemoSelectionView.
3063 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: Implement
3064 method to get a reference to the DemoSelectionView.
3065 * src/main/java/org/glom/web/client/OnlineGlom.java: Change the
3066 default view to DemoSelectionView.
3067 * src/main/java/org/glom/web/client/OnlineGlomService.java: Add method
3068 to get glom document titles for glom files in a hard-coded directory.
3069 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
3070 method to get glom document titles for glom files in a hard-coded
3072 * src/main/java/org/glom/web/client/activity/DemoSelectionActivity.java:
3073 Presenter for DemoSelectionView.
3074 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: Update
3075 for DemoSelectionView.
3076 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3077 Update for DemoSelectionView.
3078 * src/main/java/org/glom/web/client/place/DemoSelectionPlace.java:
3079 Basic 'Place' implementation for the DemoSelectionView.
3080 * src/main/java/org/glom/web/client/ui/DemoSelectionView.java:
3081 The interface for the DemoSelectionView.
3082 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.java:
3083 The implementation of the DemoSelectionView.
3084 * src/main/java/org/glom/web/client/ui/DemoSelectionViewImpl.ui.xml:
3085 The GWT UiBuilder xml file used in DemoSelectionViewImpl.
3086 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add
3087 implementation of method to get glom document titles for glom files
3088 in a hard-coded directory.
3089 * src/main/webapp/OnlineGlom.html: Remove link to CSS file as it's
3090 on longer being used.
3091 * src/main/webapp/glom.png: Glom logo.
3093 2011-04-05 Ben Konrath <ben@bagu.org>
3095 Move RPC code from OnlineGlomViewImpl to OnlineGlomActivity.
3097 This is the forth and final commit of a refactor that will allow
3098 OnlineGlom to be used with multiple documents.
3100 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3101 Move RPC code from OnlineGlomViewImpl to this class.
3102 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Add methods
3104 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: Move
3105 RPC code to the presenter class (the P in MVP).
3107 2011-04-04 Ben Konrath <ben@bagu.org>
3109 Start moving the existing OnlineGlom code to MVP.
3111 This work is based on the GWT MVP framework that is documented here:
3113 https://code.google.com/webtoolkit/doc/2.2/DevGuideMvpActivitiesAndPlaces.html
3115 This is the third commit of a refactor that will allow OnlineGlom to
3116 be used with multiple documents.
3118 * src/main/java/org/glom/web/client/ClientFactory.java: New file.
3119 Interface for client factory which is used to get instances of various
3120 classes throughout the app.
3121 * src/main/java/org/glom/web/client/ClientFactoryImpl.java: New file.
3122 Implementation of client factory.
3123 * src/main/java/org/glom/web/client/OnlineGlom.java: Add code to
3124 initialize the MVP framework.
3125 * src/main/java/org/glom/web/client/activity/OnlineGlomActivity.java:
3126 New file. Activity manager for the main container widget. This is the
3128 * src/main/java/org/glom/web/client/mvp/AppActivityMapper.java: New file.
3129 Maps place (URL) to its corresponding activity.
3130 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
3131 New file. This is just a place holder for a generated file.
3132 * src/main/java/org/glom/web/client/place/OnlineGlomPlace.java:
3133 New file. Represents the URL for the main Online Glom app.
3134 * src/main/java/org/glom/web/client/ui/LayoutListView.java: Update
3135 for changes in LayoutListViewImpl.
3136 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java: Create
3137 interface for View. Move code to OnlineGlomViewImpl class.
3138 * src/main/java/org/glom/web/client/ui/OnlineGlomViewImpl.java: New
3139 file. Implementation of OnlineGlomView.
3140 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml: Add Activity and
3141 Place resources. Use ClientFactoryImpl by default.
3143 2011-04-04 Ben Konrath <ben@bagu.org>
3145 Move View classes to their own package.
3147 This is the second commit of a refactor that will allow OnlineGlom to
3148 be used with multiple documents.
3150 * src/main/java/org/glom/web/client/OnlineGlom.java:
3151 * src/main/java/org/glom/web/client/ui/LayoutListView.java:
3152 * src/main/java/org/glom/web/client/ui/OnlineGlomView.java:
3154 2011-04-02 Ben Konrath <ben@bagu.org>
3156 Move UI code from the main module to its own class.
3158 This is the first commit of a refactor that will allow OnlineGlom to be
3159 used with multiple documents.
3161 * src/main/java/org/glom/web/client/LayoutListView.java: Update
3162 references to OnlineGlom to OnlineGlomView.
3163 * src/main/java/org/glom/web/client/OnlineGlom.java: Move code to
3164 OnlineGlomView and instantiate it here.
3165 * src/main/java/org/glom/web/client/OnlineGlomView.java: New class that
3166 represents the main OnlineGlomView with one document.
3168 2011-04-01 Ben Konrath <ben@bagu.org>
3170 Fix formatting of gwt.xml and add DTD.
3172 * src/main/resources/org/glom/web/OnlineGlom.gwt.xml:
3174 2011-03-30 Ben Konrath <ben@bagu.org>
3176 Propperly convert gdkColor string to html colour string.
3178 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3180 2011-03-28 Ben Konrath <ben@bagu.org>
3182 Change implementation of OnlineGlomServiceImpl.getColumnInfoHorizontalAlignment().
3184 This implementation matches
3185 OnlineGlomServiceImpl.getColumnInfoGlomFieldType(), should perform better, is more
3186 readable and is not tied to Swig.
3188 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3190 2011-03-28 Ben Konrath <ben@bagu.org>
3192 Use read-only checkboxes for boolean field types.
3194 * src/main/java/org/glom/web/client/LayoutListView.java: Create columns
3195 in the CellTable based on the field type. It currently only
3196 distinguishes between boolean and text columns but I'll need to add
3197 support for more types.
3198 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
3199 column type in the ColumnInfo object. Add method to convert between the
3200 glom field type enum in ColumnInfo and the glom field type in libglom.
3201 * src/main/java/org/glom/web/shared/ColumnInfo.java: Add support for
3203 * src/main/java/org/glom/web/shared/GlomField.java: Add support for
3204 getting and setting booleans.
3206 2011-03-25 Ben Konrath <ben@bagu.org>
3208 Don't get the Date twice from the ResultSet.
3210 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3212 2011-03-25 Ben Konrath <ben@bagu.org>
3214 Cleanup code in the servlet.
3216 * TODO: Remove item about row count. Add item about testing row count
3217 query with large number of rows.
3218 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Fix
3219 spelling mistakes, change method parameter to be consistent with
3222 2011-03-25 Ben Konrath <ben@bagu.org>
3224 Add server side logging with the gwt-log library.
3226 * .gitignore: Ignore the log file we're now producing.
3227 * TODO: Add a couple TODO item for logging.
3228 * pom.xml: Add gwt-log and log4j as a dependency.