1 2012-06-15 Murray Cumming <murrayc@murrayc.com>
3 OnlineGlomServiceImpl.init(): Move some code into a new method.
5 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
8 2012-06-15 Murray Cumming <murrayc@murrayc.com>
10 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
12 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
13 OnlineGlomProperties.getKey(): Make this more robust by moving the
14 check for *.*.filename to here.
16 2012-06-15 Murray Cumming <murrayc@murrayc.com>
18 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
20 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
21 init(): Move knowledge of the config file format into the
22 OnlineGlomProperties inner class.
24 2012-06-15 Murray Cumming <murrayc@murrayc.com>
26 SelfHostExampleTest: Make sure we cleanup on failure.
28 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
29 the use of cleanup() to a tearDown() JUnit method.
31 2012-06-12 Murray Cumming <murrayc@murrayc.com>
33 ConfiguredDocument: Add a primary key to portals at least once.
35 * src/main/java/org/glom/web/server/ConfiguredDocument.java
36 updatePortalsExtras): Fix a typo so that we add the primary key
38 This is a fix for the previous commit:
39 ConfiguredDocument: Do not add a primary key to portals each time.
41 2012-06-08 Murray Cumming <murrayc@murrayc.com>
43 SelfHoster: Avoid some compiler warnings.
45 * src/test/java/org/glom/web/server/SelfHoster.java
46 executeCommandLineAndWait():
47 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
48 the now-unused streams for stdout and stderr from the command Processes.
49 These are not used because readln() hangs while waiting for a new line,
50 where there may be no next line. The commented out code is still there
51 to help us figure out how to do this properly.
53 2012-06-08 Murray Cumming <murrayc@murrayc.com>
55 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
57 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
58 Make this actually test the cloning again, though it is not very useful
59 now that we do not use the part that had a problem with cloning before.
61 2012-06-08 Murray Cumming <murrayc@murrayc.com>
63 SelfHoster: Keep trying pg_ctl after starting postgres.
65 * src/test/java/org/glom/web/server/SelfHoster.java
66 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
67 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
68 regular Glom. This seems mad but it seems to work because the first
69 command would fail if pg_ctl would eventually fail.
71 2012-06-08 Murray Cumming <murrayc@murrayc.com>
73 SelfHoster: Wait until the server is really ready.
75 * src/test/java/org/glom/web/server/SelfHoster.java
76 selfHost(): Attempt the connection after starting the server, retrying
77 a few times if necessary, so that the server is really ready already when
78 we return from this method.
79 The regular Glom code does this too because pg_ctl reports success too soon.
81 2012-06-08 Murray Cumming <murrayc@murrayc.com>
83 ConfiguredDocument: Do not add a primary key to portals each time.
85 * src/main/java/org/glom/web/server/ConfiguredDocument.java
86 updatePortalsExtras(): Only add an extra primary key field if there is
87 none, to avoid adding one each time we retrieve the details layout from the
89 This should fix bug #676986 (Ben Konrath)
91 2012-05-25 Murray Cumming <murrayc@murrayc.com>
93 Document.load(): Support version 7 documents.
95 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
96 database_title attribute if the title attribute is not there.
99 2012-05-24 Ben Konrath <ben@bagu.org>
101 Add configuration for auto-generating mvn:i18n from with Eclipse.
103 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
105 2012-05-24 Murray Cumming <murrayc@murrayc.com>
107 Update translations, adding French.
109 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
110 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
111 Add a French translation, using the translation from Glom.
113 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
114 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
115 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
116 Update these based on the translations from Glom.
118 2012-05-24 Murray Cumming <murrayc@murrayc.com>
120 SelfHoster: Add some debug println messages to help when things fail.
122 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
123 System.out.println() lines.
125 2012-05-23 Murray Cumming <murrayc@murrayc.com>
127 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
129 * src/test/java/org/glom/web/server/SelfHoster.java:
130 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
131 instance) instead of just /usr/bin (as on Fedora). Check the result when
134 2012-05-23 Murray Cumming <murrayc@murrayc.com>
136 Remove LayoutItemPortal.get/setNavigationTable().
138 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
139 Remove get/setNavigationTable(), which is only a cache, because it is not
140 used, and does not need to be used, because that decision should be made on
142 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
143 updatePortalsExtras():
144 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
145 getNavigationRecord():
146 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
149 2012-05-21 Murray Cumming <murrayc@murrayc.com>
151 Initial self-hosting for tests.
153 * pom.xml: Change the scope for log4j, to hopefully make it
154 available to the test code which uses it indirectly via jOOQ.
155 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
156 self-hosting, though we only use it for testing.
158 * src/main/java/org/glom/web/server/libglom/Document.java:
159 example rows: Use a map instead of a list for each row of values,
160 so we know what field they are for, instead of relying on the sequence
161 being correct. This is not very efficient, but it does not really need
163 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
164 testReadTableExampleRows(): Adapted.
166 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
167 that returns an Object, for generic use. Note that Object seems to be
168 the implicit base even of double.
169 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
170 for use in CREATE TABLE SQL queries.
171 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
172 to do self-hosting of PostgreSQL databases via its command-line
173 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
174 backends/postgres_self.cc. This is incomplete - it needs more
175 warnings about failures and it needs to clean up properly when things
177 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
178 test of this new class.
180 2012-05-21 Murray Cumming <murrayc@murrayc.com>
182 Document: loading example data: Handle exceptions.
184 * src/main/java/org/glom/web/server/libglom/Document.java:
185 DateFormat.parse() and Double.valueOf() can throw exceptions, though
186 Eclipse did not warn about that.
188 2012-05-20 Murray Cumming <murrayc@murrayc.com>
190 Document: load(), save(): Handle the example rows.
192 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
194 * src/main/java/org/glom/web/server/libglom/Document.java:
195 load(), save(): Load and save the example rows, though the date, time
196 and image types are not handled properly yet.
197 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
198 Add testReadTableExampleRows() just to check that something is read.
200 2012-05-20 Murray Cumming <murrayc@murrayc.com>
202 Document: Add save().
204 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
205 Added getTranslationsMap() for use while saving.
206 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
207 Adedd getUseDefaultFormatting() for use while saving.
208 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
209 and several private methods that it uses.
211 This will be useful while testing via self-hosting.
212 It is not complete, but should be complete enough for testing.
214 2012-05-17 Murray Cumming <murrayc@murrayc.com>
216 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
218 * src/main/java/org/glom/web/client/OnlineGlomService.java
219 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
220 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
221 Remove getSortedListViewData() and getSortedRelatedListData(), adding
222 the sort column index and ascending bool to the regular method.
223 Instead, a sort column index of -1 now means no sort.
224 This is less explicit, but it's fairly simple, reduces the amount of
225 code, and makes the OnlineGlomService API slightly smaller.
226 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
227 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
229 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
230 getListViewData(), getRelatedListData():
231 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
232 getListViewData(), getRelatedListData():
233 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
235 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
237 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
242 2012-05-16 Murray Cumming <murrayc@murrayc.com>
244 Use translations for top-level groups too.
246 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
247 updateTitlesForLocale(): Use the translation for the group
248 as well as for child items.
252 Just recompiled to fix a problem in the released .tar.gz file.
256 2012-05-15 Murray Cumming <murrayc@murrayc.com>
258 Corrections to navigation to related records.
260 * src/main/java/org/glom/web/client/OnlineGlomService.java:
261 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
262 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
263 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
264 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
265 relationship name, because the relationship name is not necessarily unique
267 TOOD: This is inefficient, because it passes the whole list of
268 child field items back to the server, but it is more correct, and happens
269 to fix a bug with the primary key being lost after a few navigations.
270 There is probably a chance to make this more efficient anyway in some
273 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
274 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
275 * src/main/java/org/glom/web/server/ConfiguredDocument.java
276 * src/main/java/org/glom/web/server/database/DBAccess.java
277 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
278 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
281 2012-05-15 Murray Cumming <murrayc@murrayc.com>
283 Fix the use of translations.
285 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
286 Add updateTitlesForLocale().
287 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
288 Call it to discard unwanted translations and to make getTitle() return
289 the wanted translation wihout the need for the client code to specify a locale.
290 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
291 getTitle(): Fallback to the original title, as libglom does.
293 2012-05-15 Murray Cumming <murrayc@murrayc.com>
295 Document: Correctly report the number of available translation locales.
297 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
298 the available locale IDs list.
299 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
300 testLocales: Test this.
302 2012-05-15 Murray Cumming <murrayc@murrayc.com>
304 SqlUtils: Use camelCase.
306 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
307 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
308 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
309 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
310 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
311 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
313 2012-05-15 Murray Cumming <murrayc@murrayc.com>
315 Use jOOQ's tableByName() and fieldByName.
317 * pom.xml: Use jOOQ 2.3.1 to get the new API.
318 * src/main/java/org/glom/web/server/SqlUtils.java:
319 build_sql_select_step_with_where_clause(), .createField(),
320 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
321 so we can get correct quoting and escaping. Thanks to Lukas Eder for
322 adding this, and other things, to jOOQ.
324 2012-05-15 Murray Cumming <murrayc@murrayc.com>
326 SqlUtils: Remove the Connection parameters.
328 * src/main/java/org/glom/web/server/SqlUtils.java:
329 build_sql_select_with_key(), build_sql_select_with_where_clause(),
330 createSelect(), build_sql_select_step_with_where_clause(),
331 build_sql_count_select_with_where_clause(),
332 build_sql_select_count_rows(): Remove the Connection parameter because
333 jOOQ does not actually need a connectionwhen it is just used to build
335 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
337 * src/main/java/org/glom/web/server/ReportGenerator.java:
339 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
341 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
342 Constructor, getListData(), getResultSizeOfSQLQuery():
343 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
344 getSelectQuery(), getCountQuery():
345 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
346 getSelectQuery(), getCountQuery():
347 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
348 getNavigationRecord(): Adapted.
350 2012-05-14 Murray Cumming <murrayc@murrayc.com>
354 * src/main/java/org/glom/web/server/SqlUtils.java:
355 get_find_where_clause_quick(): Use a comparison of
356 lowercase values, instead of a simple equals. Regular Glom
357 uses the PostgreSQL ILIKE operator but jOOQ does not
358 support that just yet, though it will soon.
360 2012-05-14 Murray Cumming <murrayc@murrayc.com>
362 TableToViewDetails: Use a real serialization ID.
364 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
365 Though this does not fix the serialization problem.
367 2012-05-12 Murray Cumming <murrayc@murrayc.com>
369 Added LayoutItemPortalDeepCloneTest.
371 2012-05-11 Murray Cumming <murrayc@murrayc.com>
373 Make navigation work again.
375 * src/main/java/org/glom/web/server/libglom/Document.java:
376 Add getLayoutItemFieldShouldHaveNavigation().
377 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
378 Replace get/setAddNavigation() with the partly-existing
379 get/setNavigationTableName(), with an empty string being no navigation,
380 because this is simpler. Use the new
381 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
383 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
384 Add updateFieldsExtras() and call setNavigationTableName in it.
385 getDetailsLayoutGroup(),
386 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
387 createLayout(): Adapted.
388 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
389 Constructor: Adapted.
391 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
392 Replace get/setAddNavigation() with get/setNavigation(), returning a
393 TableToViewDetails class with both the table name and UsesRelationship,
394 because both are need. The previous code used java-libglom's output
395 variable (strangely, via sharedptr) to return both, but we cannot really
397 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
398 getNavigationRecord(): Adapt. However, we cannot actually use the cache
399 here because it somehow gets set to null during deepCopy(). I must test this.
400 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
401 testGetSuitableTableToViewDetails(): Adapted.
403 TODO: Find out why deepClone() is not quite working.
405 2012-05-11 Murray Cumming <murrayc@murrayc.com>
407 DBAccess: Simplify the retrievel of full field details.
409 * src/main/java/org/glom/web/server/database/DBAccess.java
410 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
411 because the Document loading should have done this.
413 2012-05-11 Murray Cumming <murrayc@murrayc.com>
415 Document: Correct loading of doubly-related layout fields.
417 * src/main/java/org/glom/web/server/libglom/Document.java:
418 loadUsesRelationship(): Actually set the related relationship, instead
419 of only setting it if it's not found.
421 2012-05-09 Murray Cumming <murrayc@murrayc.com>
423 Replace all appearances of Colour with color.
425 Because US English is dominant.
427 2012-05-09 Murray Cumming <murrayc@murrayc.com>
429 Use colors in HTML format, solving a warning about an unused function.
431 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
432 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
433 Add *asHTMLColor() versions of methods.
434 TODO: However, we should create and cache the results on the server.
435 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
436 * src/main/java/org/glom/web/client/ui/list/ListTable.java
437 * src/main/java/org/glom/web/server/ConfiguredDocument.java
438 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
439 Use the asHTMLcolor() versions.
441 2012-05-09 Murray Cumming <murrayc@murrayc.com>
443 ListViewTable: Constructor: Take the table name as a parameter.
445 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
446 Constructor: Take the tableName, and set the member variable, because
448 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
449 setCellTable(): Pass the table name.
450 This makes navigation to non-default tables work again. I don't know
451 why it worked before in the master branch.
453 2012-05-07 Murray Cumming <murrayc@murrayc.com>
455 ConfiguredDocument: Restore correct addition of hidden primary key items.
457 * src/main/java/org/glom/web/client/ui/list/ListTable.java
458 (ListTable.createCellTable): Uncomment out the check for the hidden
460 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
461 add primary key items for top-level lists and portals, as before,
462 instead of adding them to each group.
463 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
464 Actually implement the extra methods such as setHiddenPrimaryKey() and
465 comment that these are used only for top-level list groups and in portals.
466 This strangeness suggests even more that this should not be squeezed
467 into the LayoutGroup class.
469 2012-05-07 Murray Cumming <murrayc@murrayc.com>
471 Fix Formatting loading.
473 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
474 getFormattingUsed(): Remove the duplicate Formatting member variable
475 in favour of the one from the base class.
476 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
477 Initialize a new Formatting instead of using null by default, so we
478 have some defaults, instead of having to initialize one later just to
479 get the same defaults. This also makes loading of formatting from the
480 document work, because that expected a non-null.
482 2012-05-07 Murray Cumming <murrayc@murrayc.com>
484 RelatedListTable: Make sure that the tableName is set.
486 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
487 Constructor: Take the tableName so it is available later. Otherwise,
488 the server assumes that we mean the default table and cannot find the
490 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
491 setData(): Pass the tableName to the RelatedListTable constructor.
493 2012-05-07 Murray Cumming <murrayc@murrayc.com>
497 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
498 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
499 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
501 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
503 * src/main/java/org/glom/web/server/database/DBAccess.java:
504 convertResultSetToDTO(), getPortal():
505 * src/main/java/org/glom/web/server/database/ListDBAccess.java
507 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
508 Add checks for null objects and out of range access, with log messages to
509 give hints so we can fix these properly.
511 2012-05-07 Murray Cumming <murrayc@murrayc.com>
513 Portals: some corrections.
515 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
517 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
518 constructor: Use getRelationshipNameUsed() instead of getName(), because
519 that is what is meant.
520 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
521 getFromField(): Fix a typo, to get the field name, not the table name.
522 * src/main/java/org/glom/web/server/database/DBAccess.java:
523 getPortal(): Fix a typo that stopped this from working.
525 2012-05-07 Murray Cumming <murrayc@murrayc.com>
527 LayoutItemPortal: Also override getTitleOriginal().
529 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
530 This lets the base getTitle() with no parameters work.
531 TODO: Test this properly.
533 2012-05-06 Murray Cumming <murrayc@murrayc.com>
535 LayoutItemPortal: getTitle*(): Use the relationship title.
537 2012-05-06 Murray Cumming <murrayc@murrayc.com>
539 LayoutItemField: Fix loading of custom titles.
541 * src/main/java/org/glom/web/server/libglom/Document.java
542 loadDataLayoutItemField(): The title, if any, instead of the field
543 title, is stored in a title_custom node. Load it from there.
544 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
546 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
547 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
548 getTitle*() overrides.
549 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
552 2012-05-06 Murray Cumming <murrayc@murrayc.com>
554 LayoutItemField: Fall back to field titles, so some are really shown.
556 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
557 Override getTitleOriginal() and getTitle(), as in java-libglom.
558 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
561 2012-05-06 Murray Cumming <murrayc@murrayc.com>
563 Correct use of setExpectedResultSize().
565 * src/main/java/org/glom/web/server/ConfiguredDocument.java
566 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
567 Use setExpectedResultSize only on top-level groups (for instance, the
568 list layout) or on child portals (in details views).
569 Use the correct table name for portals to avoid SQL errors.
570 Update the expected counts when returning cached layouts.
572 2012-05-06 Murray Cumming <murrayc@murrayc.com>
574 Document: Interpret no group column count as 1.
576 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
577 default, though we now check for this in the UI code anyway.
579 2012-05-06 Murray Cumming <murrayc@murrayc.com>
583 2012-05-06 Murray Cumming <murrayc@murrayc.com>
585 Translatable: Use Hashmap instead of Treemap because GWT supports it.
587 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
588 The use of Treemap lead to this error from async methods, with no
590 "The response could not be deserialized"
592 2012-05-06 Murray Cumming <murrayc@murrayc.com>
594 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
596 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
597 when using the Google -> GWT Compile, or
598 g toolbar button -> GWT Compile Project... feature in Eclipse.
600 2012-05-06 Murray Cumming <murrayc@murrayc.com>
602 ListTable.addColumn(): Protect against a null Formatting.
604 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
605 Create a default Formatting if it is null, because that is the simplest
608 2012-05-06 Murray Cumming <murrayc@murrayc.com>
610 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
612 * src/main/java/org/glom/web/server/ConfiguredDocument.java
613 updateLayoutGroup(): Check that the field is not null.
615 2012-05-06 Murray Cumming <murrayc@murrayc.com>
617 ListViewImpl: Protected against a bad cast error.
619 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
620 onEnterKeyDown(): Do not cast without an instanceof check.
622 2012-05-06 Murray Cumming <murrayc@murrayc.com>
624 ListTable: Protect against an out of range error.
626 * src/main/java/org/glom/web/client/ui/list/ListTable.java
627 createCellTable(): This is unlikely, but can happen while debugging.
629 2012-05-06 Murray Cumming <murrayc@murrayc.com>
631 AsyncMessage onFailure() callbacks: Log the exception message.
633 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
634 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
635 * src/main/java/org/glom/web/client/activity/ListActivity.java:
636 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
637 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
638 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
639 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
640 These are useful clues when something is wrong.
642 2012-05-06 Murray Cumming <murrayc@murrayc.com>
644 ConfiguredDocument: Avoid a null dereference.
646 * src/main/java/org/glom/web/server/ConfiguredDocument.java
647 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
648 details maps are created.
650 2012-05-06 Murray Cumming <murrayc@murrayc.com>
652 Document: Correct the port number parsing.
654 * src/main/java/org/glom/web/server/libglom/Document.java:
655 This lets us actually connect to the database and show the document.
657 2012-05-05 Murray Cumming <murrayc@murrayc.com>
661 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
662 user-interaction, asking us to load a temporary URL in a browser.s
663 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
664 which is apparently necessary for testing the service. See the comment.
665 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
666 Show the exception, if any. This is how I saw the 404 in the HTML in
669 2012-05-05 Murray Cumming <murrayc@murrayc.com>
671 DocumentTest: Move the .glom files into the resources directory.
673 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
674 URI via getResource().
676 2012-05-05 Murray Cumming <murrayc@murrayc.com>
678 Document: Remove the FieldIdentifies inner class.
680 * src/main/java/org/glom/web/server/libglom/Document.java: We only
681 use the Relationship (though the same function in libglom is maybe
682 used in other ways) and so this removes a compiler warning.
684 2012-05-05 Murray Cumming <murrayc@murrayc.com>
686 Document.load() Remove the error code parameter.
688 * src/main/java/org/glom/web/server/libglom/Document.java: load():
689 Remove the parameter. We do not set it yet and it could never have
690 worked as an output parameter (though maybe it did in java-libglom).
691 We could use an exception if we really want the failure reason.
692 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
694 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
695 setUp(), testGetSuitableTableToViewDetails(): Adapt.
697 2012-05-05 Murray Cumming <murrayc@murrayc.com>
699 Make some inner classes static.
701 * src/main/java/org/glom/web/server/ConfiguredDocument.java
702 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
703 * src/main/java/org/glom/web/server/ReportGenerator.java
704 * src/main/java/org/glom/web/server/libglom/Document.java
705 Make all inner classes static that can be static.
707 2012-05-05 Murray Cumming <murrayc@murrayc.com>
709 OnlineGlomServiceImpl: Do not load and check for java-libglom.
711 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
712 init(): We do not use java-libglom any more.
714 2012-05-05 Murray Cumming <murrayc@murrayc.com>
716 Remove mentions of java-libglom.
718 * README: Remove mention of java-libglom, because it no longer needed.
719 * utils/build-onlineglom-war.sh:
720 * utils/check-and-recover-tomcat.py:
721 * utils/install-onlineglom-war.sh: Remove these as they are no longer
722 useful. Building is now far easier, with no need for jhbuild.
724 2012-05-05 Murray Cumming <murrayc@murrayc.com>
726 Fix the build (mvn package)
728 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
729 (LayoutGroup): Make the LayoutItemList inner class static and protected.
730 Otherwise the GWT Java->Javascript compilation fails with just this
731 error, during mvn package or when attempting to view in a browser,
732 in the GWT developer mode in Eclipse.
734 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
735 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
736 [INFO] Compiling module org.glom.web.OnlineGlom
737 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
738 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
739 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
740 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
741 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
742 [INFO] [ERROR] Cannot proceed due to previous errors
744 It has taken me 2 days to find out what was causing that. After reducing
745 the code, the compiler eventually showed me the full error message.
747 2012-05-04 Murray Cumming <murrayc@murrayc.com>
749 ConfiguredDocument: Cache the cloned and stripped layouts.
751 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
752 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
753 layout in a map, so we can retrieve it again without rebuilding it.
755 2012-05-04 Murray Cumming <murrayc@murrayc.com>
757 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
759 2012-05-04 Murray Cumming <murrayc@murrayc.com>
761 libglom classes: Implement some auto-generated emthods.
763 2012-05-04 Murray Cumming <murrayc@murrayc.com>
765 Add GwtTestOnlineGlomService.
767 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
768 However, this (and the other GwtTest*) does not seem to run during
771 2012-05-04 Murray Cumming <murrayc@murrayc.com>
773 Remove use of unsupported features from client code.
775 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
776 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
777 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
778 Use our client version of StringUtils instead of the apache commons one.
780 However, the GWT Javascript compliation still fails.
782 2012-04-25 Murray Cumming <murrayc@murrayc.com>
784 Add a Field class and implement some loading of it in Document.
786 2012-04-25 Murray Cumming <murrayc@murrayc.com>
788 Initial Document loading implementation, instead of libglom.
790 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
791 and Translatable classes, and adapt the rest of the code to use them.
792 However, this is still missing Layout and Field classes and loading.
794 2012-04-24 Murray Cumming <murrayc@murrayc.com>
796 Use of jOOQ: Move Field creation into a utility method.
798 * src/main/java/org/glom/web/server/SqlUtils.java:
799 This lets us improve it more easily.
801 2012-04-24 Murray Cumming <murrayc@murrayc.com>
803 Use of jOOQ: Improve the code to COUNT a sub-select.
805 * src/main/java/org/glom/web/server/SqlUtils.java:
806 Move initial query creation into
807 build_sql_select_step_with_where_clause().
808 build_sql_select_count_rows(): Use the jOOQ API instead of
809 concatentating text, because a jOOQ Select*Step is a TableLike,
810 which is what from() takes.
812 2012-04-23 Murray Cumming <murrayc@murrayc.com>
814 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
816 * pom.xml: Depend on jooq.
817 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
818 methods with jOOQ, based on the C++ implementations in libglom,
819 with some changes to the logic required by jooQ.
820 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
822 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
823 * src/main/java/org/glom/web/server/ReportGenerator.java:
824 * src/main/java/org/glom/web/server/SqlUtils.java:
825 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
826 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
827 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
828 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
829 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
830 Adapt. In particular, the SqlUtils methods now need to take a Connection,
831 because jOOQ needs that, though it seems unnecessary.
833 This is not quite finished. Ideally jOOQ would help us to build
834 table_name.field_name names, quoting and escaping them properly.
835 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
837 2012-04-21 Murray Cumming <murrayc@murrayc.com>
839 Move use of Glom.build_sql*() into a new SqlUtils class.
841 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
842 to wrap Glom.build_sql*(). The parameter types are still Glom one,
843 but this will make it easier to start using something other than
844 libglom or SqlBuilder.
846 2012-04-21 Murray Cumming <murrayc@murrayc.com>
848 Update the project URL.
850 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
852 2012-04-21 Murray Cumming <murrayc@murrayc.com>
854 Main layout: Use a FlowTable instead of absolute positioning.
856 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
857 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
858 child panels/widgets must have an absolute position. But that is annoying, so
859 this adds a FlowTable and puts the child panels in there.
861 2012-04-21 Murray Cumming <murrayc@murrayc.com>
863 GwtTestOnlineGlom: Comment out unused code.
865 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
866 Eclipse has started to say that some code is unused.
868 2012-04-21 Murray Cumming <murrayc@murrayc.com>
870 Update to the latest versions of dependencies.
872 * pom.xml: Update version numbers of dependencies to the latest
874 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
875 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
876 * src/main/java/org/glom/web/server/ReportGenerator.java:
877 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
878 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
879 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
881 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
882 Modify the imports where necessary.
884 2012-04-17 Murray Cumming <murrayc@murrayc.com>
886 Style: Remove overflow:hidden from searchbox
888 * src/main/webapp/style.css: Because this pushes the Back To Link
889 label/link on to the next row, which is then hidden due to the
890 hard-coded (in ems) height.
892 2012-04-20 Murray Cumming <murrayc@murrayc.com>
894 Remove some duplicate code.
896 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
897 getDocumentInfo(): This must have been duplicated during the merge from the
902 2012-04-19 Murray Cumming <murrayc@murrayc.com>
904 Reports: Localize the waiting for report message.
906 * src/main/java/org/glom/web/client/activity/ReportActivity.java
907 start(): Get the message from the contants.
908 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
910 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
911 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
912 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
913 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
914 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
915 Update these files with the English text for newer strings for now.
917 2012-04-19 Murray Cumming <murrayc@murrayc.com>
919 Reports: Show a message while waiting for the report.
921 * src/main/java/org/glom/web/client/ui/ReportView.java
922 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
923 Add setWaitingText(), to show a message saying that we are
924 waiting for the report to be ready.
925 * src/main/java/org/glom/web/client/activity/ReportActivity.java
926 start(): Call setWaitingText() before calling the async
929 2012-04-19 Murray Cumming <murrayc@murrayc.com>
931 ReportGenerator: Specify date and time formats.
933 * src/main/java/org/glom/web/server/ReportGenerator.java:
934 createFieldValueElement(): Use the default (and localized)
935 short formats, though we still need a way to show 4-digit
936 years without providing the format for every locale.
937 * src/main/java/org/glom/web/server/database/DBAccess.java:
938 convertResultSetToDTO(): Use the short formats here too.
940 2012-04-18 Murray Cumming <murrayc@murrayc.com>
942 ReportGenerator: Use the correct numeric formatting.
944 * src/main/java/org/glom/web/server/ReportGenerator.java
945 createFieldExpression(), createFieldValueElement(): Take the
946 whole LayoutItem_Field instead of just the field name, so
947 we have access to the formatting.
948 createFieldValueElement(): Use JRTextField.setPattern() to
949 specify the numeric formatting, with the help of a
950 regular DecimalFormat.
952 2012-04-18 Murray Cumming <murrayc@murrayc.com>
954 ReportGenerator: Avoid showing null for group by titles.
956 * src/main/java/org/glom/web/server/ReportGenerator.java
957 generateReport(): Use setBlankWhenNull() on the field title
958 style too, because this is used for values in group by
961 2012-04-18 Murray Cumming <murrayc@murrayc.com>
963 ReportGenerator: Add a colon to titles in vertical groups.
965 * src/main/java/org/glom/web/server/ReportGenerator.java
966 addFieldToDetailBandVertical(): Pass true for the withColon
969 2012-04-18 Murray Cumming <murrayc@murrayc.com>
971 ReportGenerator: Simplify the code by using Position more.
973 2012-04-18 Murray Cumming <murrayc@murrayc.com>
975 Reports: Support vertical groups, roughly.
977 * src/main/java/org/glom/web/server/ReportGenerator.java:
978 addToReport(): Rename to addGroupToReport() and, if necessary,
979 call the new addVerticalGroupToReport() method.
980 createFieldValueElement(): Let the caller specify the Y position
983 2012-04-17 Murray Cumming <murrayc@murrayc.com>
985 Reports: Allow a second report to be shown.
987 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
988 clear(): Do not remove the HTML widget, which broke the whole layout.
990 2012-04-17 Murray Cumming <murrayc@murrayc.com>
992 Locales drop-down: Show that we use English by default.
994 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
995 fillView(): When we use English, just because that is the default, when
996 no locale is specified, show that in the Locales drop-down instead of
997 just showing the first item.
999 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1001 Unselect the Report/Locale/Table combo item when appropriate.
1003 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1004 setPlace(): clear reportName if this is not a ReportPlace.
1005 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1006 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1007 When the provided name is empty, unselect all items, so that none are
1008 indicated. This uses a for loop because I cannot find a single method
1011 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1013 Report: Give the user a way to get back to the list.
1015 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1016 start(), setPlace(): Show the Back To List link on reports, and also
1017 interpret selecting the empty report item as back to list.
1019 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1021 Really show the selected Report name.
1023 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1024 setPlace(): Store the reportName here, if it is that kind of Place.
1025 fillView(): Set the selected Report after filling the list of reports.
1026 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1027 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1028 null Strings, though we need some way to unselect all ListBox items
1031 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1033 ReportGenerator: Try to avoid some problems.
1035 * src/main/java/org/glom/web/server/ReportGenerator.java
1036 addField(): Try to avoid duplicates, and avoid using a null
1039 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1041 Reports: Use quickFind.
1043 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1044 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1045 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1046 getReportHTML(): Add a quickFind parameter.
1047 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1048 start(): Pass the quickFind parameter.
1049 * src/main/java/org/glom/web/server/ReportGenerator.java
1050 generateReport(): Take a quickFind parameter.
1052 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1054 ReportPlace: Actually use the report name.
1056 * src/main/java/org/glom/web/client/place/ReportPlace.java
1057 getPlace(): Do not assign the report name to the quickfind.
1059 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1061 Show java.library.path when complaining.
1063 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1064 init(): When telling us to check java.library.path, show the
1067 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1069 ReportGenerator: Do not show nulls.
1071 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1073 ReportGenerator: Make the title font larger.
1075 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1077 ReportGenerator: Put field titles inside groups, if there are groups.
1079 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1081 ReportGenerator: Take the Report itself instead of the name and group.
1083 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1084 Remove getReportLayoutGroup().
1085 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1086 getReportHTML(): Pass the report instead
1087 of its name and layout group.
1088 * src/main/java/org/glom/web/server/ReportGenerator.java
1089 generateReport(): Use the report object to use the title
1090 instead of the name.
1092 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1094 ReportGenerator: Remove designBand parameters.
1096 * src/main/java/org/glom/web/server/ReportGenerator.java:
1097 Make designBand a class member instead of passing it to all
1100 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1102 ReportGenerator: Add lines, a bit like in the desktop version.
1104 * src/main/java/org/glom/web/server/ReportGenerator.java
1105 addToReport(): Use JRDesignLine.
1107 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1109 ReportGenerator: Correct the title positions and use some bold style.
1111 * src/main/java/org/glom/web/server/ReportGenerator.java:
1112 Break the code up into reusable functions, correct the placement of
1113 titles, and use normal/bold styles as in the reports in the desktop
1116 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1118 ReportGenerator: Add a header band to show the field titles.
1120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1121 getReportHTML(): Pass the localeId to the ReportGenerator
1123 * src/main/java/org/glom/web/server/ReportGenerator.java
1124 constructor: Take the localeID so we can get translated field
1126 generateReport(), addToReport(), addFieldToBand(): Add field
1127 titles in a column header band.
1129 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1131 Reports drop-down list: Some improvement.
1133 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1134 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1135 Adedd setSelectedReport(),
1136 setReportList(): Add a blank line so that the user can select the
1138 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1139 start(): Show the current report by calling setSelectedReport().
1140 This does not seem to work yet.
1142 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1144 DetailsActivity, ListActivity: Move some variables into a base class.
1146 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1147 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1148 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1149 the clientFactory, documentID, tableName and authenticationPopup into
1150 a base class, to avoid duplication.
1152 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1154 Translate the Reports label.
1156 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1157 Get the "Reports" label string from the constants.
1158 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1159 perties: Add Reports to the constants.
1161 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1163 Reports: Implement grouping.
1165 * src/main/java/org/glom/web/server/ReportGenerator.java:
1166 Handle LayoutItem_GroupBy items and try to do the right thing
1167 with JRDesignGroup. It seems to work.
1169 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1171 Actually show some data with JasperReports.
1173 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1174 getReportHTML(): Move most code into a ReportGenerator class.
1175 * src/main/java/org/glom/web/server/ReportGenerator.java:
1176 Recurse into sub-groups, adding fields to the JasperDesign's details
1177 band. Note that we must set an arbitrary width and height, or it just
1178 will not show any data.
1180 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1182 Reports Chooser: Show the titles, not the names.
1184 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1185 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1186 and the names as the values.
1187 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1188 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1189 group now that we provide the report name, so it should always
1192 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1194 Depend on jasperreports.
1196 * pom.xml: Add the dependency. My plan is to use this on the
1199 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1201 Implement navigation to report places.
1203 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1204 start(): Do not bother to handle all events here.
1205 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1206 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1207 Added getSelectedReport().
1208 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1209 .java: start(): When handling a change to the reports chooser,
1210 call getSelectedReport() and goTo() its ReportPlace.
1211 * src/main/java/org/glom/web/client/ui/ReportView.java
1212 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1213 Added setReportHTML() which puts the html in a gwt HTML widget.
1214 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1215 getReportHTML(): Return "TODO" just to show that this works.
1217 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1219 Make ReportPlace usable.
1221 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1222 Mention ReportPlace.
1223 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1224 Correct the @prefix annotation.
1226 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1228 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1230 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1231 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1232 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1233 Change getReportLayout() to getReportHMTL() because we will not need to
1234 parse or render the report layout on the client side.
1235 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1236 getReportLayout(): Return the libglom LayoutGroup type because we will
1237 not need to convert to a shared type, because this will not be used on
1239 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1242 Note that there is still no implementation for this.
1245 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1247 Add a (empty) Report Place, View, and Activity.
1249 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1251 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1252 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1253 this into a superclass:
1254 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1255 and also use it as the base of this new ReportPlace:
1256 * src/main/java/org/glom/web/client/place/ReportPlace.java
1258 * src/main/java/org/glom/web/client/ui/ReportView.java
1259 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1260 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1261 Add these, containing mostly boiler-plate for now.
1263 * src/main/java/org/glom/web/client/OnlineGlomService.java
1264 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1265 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1266 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1267 Add API to get the LayoutGroup for the report.
1269 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1271 Add and fill a Reports drop-down list box.
1273 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1275 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1276 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1277 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1278 Added getReports(document, table, localeID), calling
1279 ConfiguredDocument.getReports().
1280 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1281 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1282 Added setReportsList() and a list widget.
1283 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1284 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1289 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1291 Translations: Add Esperanto.
1293 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1294 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1295 properties: Add this translation because someone took the time to make it.
1297 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1299 Adapt to the java-libglom 1.21.7 API.
1301 * src/main/java/org/glom/web/server/ReportGenerator.java:
1302 addToReport(): get_group_secondary_fields() is now
1303 get_secondary_fields().
1306 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1308 Use the latest java-libglom version.
1310 * pom.xml: Use java-libglom 1.21.7.
1312 2012-03-03 Ben Konrath <ben@bagu.org>
1314 Display date and time in details view.
1316 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1318 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1320 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1322 Require the latest java-libglom.
1324 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1326 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1328 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1330 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1331 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1332 an empty quickfind string. I also corrected libglom to create only
1333 empty where clauses for empty quickfind strings, but this avoids the
1336 2012-02-24 Ben Konrath <ben@bagu.org>
1338 Improve the tabs in the Notebook widget.
1342 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1344 Translations: Try to translate the strings.
1346 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1347 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1348 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1349 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1350 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1351 Take the Open translation from GTK+'s .po files.
1352 Take the Details translation from Glom's po files.
1353 I have added the other strings to Glom so we can get translations that way:
1354 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1356 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1358 TableSelectionViewImpl: Put the search label and entry in a div.
1360 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1361 Put the search widgets in a FlowTable so that the CSS can be used to
1362 style them while keeping them together.
1363 * src/main/webapp/style.css: Mention the new div.
1365 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1367 Translate more strings in more locales.
1369 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1370 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1371 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1372 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1373 Translate the "Details" and "Open" string too.
1375 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1376 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1377 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1378 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1379 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1380 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1381 Add these new locales as placeholders though they currently contain English.
1383 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1385 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1387 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1388 Check the ConfiguredDocument* for null before using it.
1390 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1392 Tell Eclipse about the generated java files.
1394 * .classpath: This lets it find OnlineGlomConstants.java.
1395 It would be nice if Eclipse just used the maven build files.
1397 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1399 Prevent a crash when no locale is specified in the URL.
1401 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1402 Avoid returning a null string, obtained from
1403 Window.Location.getParameter(). This caused a crash when it was
1404 later passed to libglom's API.
1405 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1406 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1407 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1408 guard against future null strings.
1410 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1412 Use the ?locale= query param instead of the &lang= token param.
1414 * src/main/java/org/glom/web/client/place/ListPlace.java
1415 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1416 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1417 Remove the lang token key and value.
1419 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1420 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1421 When the user selects a different locale from the chooser, use
1422 Window.Location.assign() to change the URL, which then causes a reload.
1424 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1425 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1426 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1427 * src/main/java/org/glom/web/client/activity/ListActivity.java
1428 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1429 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1430 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1431 * src/main/java/org/glom/web/client/ui/ListView.java:
1432 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1434 Remove localeID member variables and method/constructor parameters, instead
1435 using Utils.getCurrentLocaleID() when we need a localID to pass to
1438 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1440 Internationalize the UI strings.
1442 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1443 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1444 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1445 because it is unused. Messages are apparently strings that can have
1446 parameters, but we do not need that yet, so Contants will be enough for now.
1447 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1448 to say that we support the en and de locales.
1449 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1450 The original English strings.
1451 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1452 Some German translations of the English strings.
1453 The i18n goal then uses the .properties file to generate an
1454 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1455 returns an implementation that returns the translated strings.
1456 The documentation suggests putting these in src/java/*/client/, but it seems
1457 best to put it in src/resources/*/client/.
1458 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1459 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1460 instead of hard-coding them.
1461 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1462 but that does not seem to stop the build, though it confuses Eclipse.
1464 You can see the translated string by adding ?locale=de to the URL, like so:
1465 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1467 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1469 Improve null/empty String checks.
1471 * pom.xml: Add a dependency on commons-lang, to use
1472 org.apache.commons.lang.StringUtils.
1473 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1474 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1475 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1476 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1477 Use StringUtils.isEmpty().
1479 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1480 StringUtils class with a static isEmpty() function because we
1481 cannot use org.apache.commons.lang.StringUtils in client-side
1482 GWT code because it (apparently) cannot be compiled to javascript.
1483 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1484 * src/main/java/org/glom/web/client/activity/ListActivity.java
1485 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1486 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1487 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1488 * src/main/java/org/glom/web/client/place/ListPlace.java
1489 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1490 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1491 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1492 * src/main/java/org/glom/web/client/ui/details/Group.java
1493 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1494 our StringUtils.isEmpty() function.
1496 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1498 Update to the latest java-libglom API.
1500 * pom.xml: Require java-libglom 1.21.4.
1501 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1502 getDocumentInfo(), getListViewLayoutGroup():
1503 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1505 * src/main/java/org/glom/web/server/database/DBAccess.java
1506 getFieldsToShowForSQLQueryAddGroup(),
1507 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1508 with either get_database_title_original() or
1509 get_database_title(localeID).
1511 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1513 ConfiguredDocument: Avoid a null pointer exception.
1515 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1516 Initialize localeID to "" to avoid returning a null String which
1517 causes a crash in java-libglom's swing-generated code.
1519 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1521 Some simple renaming.
1523 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1524 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1525 for localeChooser. This seems more appropriate and is less ambiguous
1526 particularly in the .css file.
1528 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1530 ConfiguredDocument: Rename the localedID private member variable.
1532 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1534 Adapt to the latest java-libglom API from git master.
1536 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1537 libglom now uses only Vector instead of List, which uses add() instead of
1540 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1542 ConfiguredDocument: Rename the localedID private member variable.
1544 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1546 Build a source tarball with mvn assembly:single
1548 * assembly.xml: Add this file.
1549 * pom.xml: Use the maven-assembly-plugin and tell it to use
1550 our assembly.xml file.
1552 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1554 OnlineGlomServiceImpl: Get .glom files recursively.
1556 * pom.xml: Depend on commons-io from org.apache.commons.
1557 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1558 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1559 files recursively, and with the easier filter for the extension.
1560 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1561 simplify that code too.
1563 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1565 README: Mention that you must install java-libglom packages separately.
1567 But then it works, because java-libglom is now in the central maven
1570 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1572 locales drop-down: Show the correct selected locale when the URL changes.
1574 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1575 .java: setPlace(): Move some code into fillView().
1577 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1579 locales drop-down: Do not lose the primary key.
1581 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1582 start(): onLocaleChange(): Pass the current primary key value,
1583 instead of an empty value.
1585 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1587 locales drop-down: Do not lose the drop-down selection.
1589 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1590 .java (TableSelectionActivity.fillView): Set the selected locale
1591 after changing the drop-down items (though we do not really need
1592 to change them just because the locale changes.)
1594 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1596 locales drop-down: Change the tables list when this changes.
1598 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1599 .java: TableSelectionActivity.start(): Move the async table titles
1600 retrieval into a private fillView() method and also call this when
1601 the chosen locale changes.
1602 Note that the document title is not actually translatable yet, but
1603 that is a problem that I should fix soon in libglom.
1605 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1607 Improve the placement of the locales drop-down.
1609 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1610 Put the title and locales drop-down in a div (gwt.FlowTable).
1611 * src/main/webapp/style.css: Add magic css properties to make this work.
1612 Also remove the left margin from the title so that it lines up with the
1615 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1617 locales selector: Show human-readable locale titles.
1619 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1620 getDocumentInfo(): Use java.util.Locale to show a real title of
1621 each locale, in the locale's own language.
1623 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1625 Add a language/locale selector drop-down.
1627 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1628 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1629 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1630 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1631 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1632 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1633 Add a ListBox to show the available locales. Add getLocaleSelector(),
1634 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1635 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1636 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1637 java: Add these classes.
1638 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1639 start(): Fill the locales ListBox. Handle its change event, firing a
1641 setPlace(): Show the selected locale as specified by the URL token.
1642 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1643 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1644 Handle LocaleChangeEvent, going to a new *Place with that locale.
1646 The placement of the ListBox is not pretty, and it currently uses the ID
1647 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1651 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1653 Search box: Show the search text from the URL token.
1655 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1656 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1657 Add setQuickFindText().
1658 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1659 .java: setPlace(): Store the queryText if the place is a ListPlace,
1660 and call TableSelectionView.setQuickFindText().
1662 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1664 Allow use of translations via, for instance, &lang=de in the URL.
1666 * pom.xml: Use the unstable java-libglom 1.21 version.
1668 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1669 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1670 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1671 init(): Instead of calling TranslatableItem.set_current_locale()
1672 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1673 However, this is only for default locales, which are not needed to
1674 change the locale in the URL.
1675 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1676 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1677 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1678 layout for a particular locale.
1679 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1680 Add get/setDefaultLocaleID().
1681 getDocumentInfo(), getListViewData(), getRelatedListData(),
1682 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1683 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1684 localeID parameter, so we can get the layout for a particular locale.
1686 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1687 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1688 * src/main/java/org/glom/web/client/place/ListPlace.java:
1689 Parse and construct a lang parameter too.
1691 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1692 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1693 passed to subsequent methods and constructors.
1694 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1695 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1696 Store the localeID from the *Place and pass it to other constructors
1697 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1699 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1700 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1701 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1702 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1703 * src/main/java/org/glom/web/client/ui/ListView.java:
1704 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1705 Take localeID parameters and pass them to subsequent constructors and
1706 methods, so that the layout is always retrieved for that locale.
1708 This is rather repetitive.
1710 Note that "" means the original (default) locale of the Glom document,
1711 which is usually English.
1713 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1715 Documents: Remove final keyword to fix startup configuration.
1717 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1718 final keywords on the private member variables because that breaks
1719 the startup, apparently (there are warnings) because it stops them
1720 from being serialized. I added these in the previous commit.
1722 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1724 Documents: Add some final keywords.
1726 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1729 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1731 OnlineGlomServiceImpl: Add to overview comments.
1733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1734 Note that this is where all the document are loaded. They are not
1735 loaded freshly for each page.
1737 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1741 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1742 Add a TextBox for the text of a quick find.
1743 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1745 setBackLink(): Add a String quickFind parameter.
1746 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1747 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1748 to the base interface, because that is how TableSelectionViewImpl is used.
1749 * src/main/webapp/style.css: Add style for the search box and its label.
1751 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1752 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1753 Add these files, based on the existing TableChangeEvent and
1754 TableChangeEventHandlers.
1755 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1756 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1757 a ListPlace() that the user should be taken to.
1758 * src/main/java/org/glom/web/client/activity/ListActivity.java
1759 start(): Handle it here too and adapt the TableChangeEvent handler to
1760 pass the extra "" quickFind parameter to ListPlace.
1761 * src/main/java/org/glom/web/client/place/ListPlace.java:
1762 Constructor: Take an extra String quickFind parameter and store it,
1763 returning it from a new getQuickFind() method.
1764 getToken(): Put the quickFind text in the URL token.
1765 getPlace(): Parse the quickFind text from the URL token.
1766 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1767 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1768 ListPlace constructor.
1769 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1770 .java: start(): Add a Change handler for the TableSelectionView's
1771 TextBox (via its base HasChangeHandlers interface), firing the new
1772 QuickFindChangeEvent.
1773 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1774 pass the extra "" quickFind parameter.
1776 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1777 setCellTable(): Add a String quickFind parameter and pass it to
1778 the ListViewTable() constructor.
1779 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1780 setCellTable() in the base interface, because that is how ListViewImpl
1783 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1784 Add a String quickFind member variable.
1785 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1786 Constructor: Add a String quickFind parameter, storing it in the
1787 base ListTable's member variable.
1788 onRangeChanged(): Pass quickFind to the
1789 OnlineGlomServiceAsync.getSortedListViewData() and
1790 OnlineGlomServiceAsync.getListViewData() methods.
1792 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1793 getListViewData(), getSortedListViewData(): Add a String quickFind
1794 parameter, passing it to ConfiguredDocument.getListViewData().
1795 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1796 Change getListViewData(), getSortedListViewData() in the base interface,
1797 because that is how OnlineGlomServiceImpl is used, via this:
1798 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1799 Change getListViewData(), getSortedListViewData() here too.
1800 This class can apparently be used to asynchronously call methods on
1801 OnlineGlomService, and GWT seems to implement that after recognizing
1802 just the *Async name convention and the extra AsyncCallback parameters.
1804 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1805 getListViewData(): Add a String quickFind parameter, and pass it to
1806 ListViewDBAccess.getData().
1807 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1808 getListData(): Add a String quickFind parameter and pass it to
1810 getSelectQuery(): Add a String quickFind parameter.
1811 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1812 getSelectQuery(): Add a String quickFind parameter and use it with
1813 Glom.get_find_where_clause_quick() to pass a where_clause to
1814 Glom.build_sql_select_with_where_clause(), to actually filter the
1816 getData(): Add a String quickFind parameter, passing it to getListData().
1817 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1818 va: getData(): Pass an empty string to getListData() for the
1819 quickFind parameter.
1821 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1823 ListTable: Minor change.
1825 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1826 createCellTable(): Make this protected instead of public.
1828 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1830 Many files: Use final for the parameters and use the @override attribute.
1832 2012-01-22 Ben Konrath <ben@bagu.org>
1834 Add anchor links for single line text that starts with http, ftp and www.
1838 2012-01-22 Ben Konrath <ben@bagu.org>
1840 Add ellipsis to single line text in details view.
1844 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1846 Remove all javadoc author tags.
1848 Because they are awkward and meaningless when many people touch
1850 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1852 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1854 Revert the COPYING.LESSER to COPYING rename.
1856 Apparently both should be there if it is LGPL.
1858 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1860 *View: Remove unused imports.
1862 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1863 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1864 * src/main/java/org/glom/web/client/ui/ListView.java:
1865 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1866 Remove unused imports, as suggested by Eclipse.
1868 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1870 Move the *View::Presenter types, and some API into one base View.
1872 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1873 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1874 * src/main/java/org/glom/web/client/ui/ListView.java:
1875 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1876 Presenter, setPresenter() and clear() into a shared base interface,
1877 to avoid the unnecessary duplicate Presenter types and to more clearly
1878 show how the *Views share the same structure, even if they are not
1879 used polymorphically.
1881 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1882 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1884 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1885 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1886 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1888 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1891 Feel free to revert this if there is a good reason for the duplicate
1894 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1896 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1898 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1899 a class member instead of a local variable in the method.
1900 This lets us use it to get the view instances, for use in tests.
1901 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1902 beforeOnlineGlom(): Test some more details of the initial view.
1903 Again, this is not very useful.
1905 To really test gwt-glom we will need to start a local postgresql
1906 instance with local data, like the Glom tests in C++.
1908 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1910 pom.xml: Mention the LGPL license.
1912 * pom.xml: Add a licenses section.
1913 * COPYING.LESSER: Move this to COPYING, which
1914 previously contained the GPL. But gwt-glom is all LGPL.
1916 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1918 Add project information to README and pom.xml.
1920 * README: Add a brief description and mention some mvn
1922 * pom.xml: This extra information shows up in mvn site
1925 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1927 Use the latest java-libglom version.
1929 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1931 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1933 GwtTestOnlineGlom: Test a little more.
1935 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1936 protected rather than private, as suggested by the gwt-test-utils
1938 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1939 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1940 Test the initial visibility of the panels.
1942 However, this is not a very useful test.
1943 And I wonder how we should generally test using this idea for an
1944 activity/places app like ours where the real changes happen implicitly
1945 based on the history token/URL.
1947 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1949 Slight modification to *Mapper comments.
1951 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1952 (DataActivityMapper)
1953 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1955 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1957 Remove comments mentioning GIN because they are just copied from
1958 the example code and are apparently not helpful:
1959 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1960 Also change the mention of a class that is only in the example code.
1962 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1964 GwtTestOnlineGlom test: Minor changes.
1966 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1967 Avoid the long qualified class name and modify the comment
1968 because it is now obvious to me that the mocked class is the only
1969 custom one created via GWT.create().
1971 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1973 Tests: Added the beginnings of a test using gwt-test-utils.
1975 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1976 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1977 which tells gwt-test-utils what class will be tested.
1978 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1979 Add a simple (but empty) test case. One class, used by the OnlineGlom
1980 class, is mocked so that it can be created. However, I am not sure
1981 why only this class needs to be mocked.
1983 Note that mockito seems more popular, and clearer, than easymock,
1984 but I have not got that working yet. It might be a matter of the
1987 This test is run during mvn integration-test.
1989 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1991 Tests: Use junit4-style syntax instead of junit3-style.
1993 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1994 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1995 * src/test/java/org/glom/web/shared/DataItemTest.java:
1996 Use the @Test annotation rather than relying on the test*() prefix.
1997 Also no longer implement TestCase, to avoid triggering support for
1998 the junit3-way, which stops the annotations from working.
1999 Change the imports from import junit.framework.* to
2000 import org.junit.*, which is apparently the new way.
2002 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2004 Added a test for ListPlace token parsing and creation.
2006 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2007 This is much the same as DetailsPlaceTest.
2009 I wonder how we could test the other parts of the *Place API.
2011 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2013 DetailsPlace test: Also test getToken() and recreation via getPlace().
2015 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2016 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2017 recreate it, testing the recreated DetailsPlace for the same parameter
2020 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2022 Use the surefire-report plugin.
2024 * pom.xml: This generates a HTML report about the tests in
2025 target/site/surefire-report.html
2026 when you do mvn surefire-report:report. It seems to be popular/normal.
2028 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2030 Added a test for DetailsPlace.
2032 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2033 Test the getPlace() token parsing.
2035 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2037 Added a first unit test.
2039 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2040 * src/test/java/org/glom/web/shared/DataItemTest.java:
2041 This is a silly test but it is just to get things started. Note that
2042 maven/junit finds the test because it looks in src/test by default.
2044 2011-12-22 Ben Konrath <ben@bagu.org>
2046 Change charsetName to "UTF-8" when replacing line breaks.
2048 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2049 that work in Java (such as "UTF8") will not work when compiled to
2052 This fixes a problem with multi-line details view fields that have hard
2053 line breaks. The "License Text" field on this page demonstrates the
2056 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2058 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2060 2011-12-22 Ben Konrath <ben@bagu.org>
2062 Fix another bug with related list navigation.
2064 I've tested all the navigation buttons in all of the related lists
2065 so things should be good now.
2067 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2069 2011-12-22 Ben Konrath <ben@bagu.org>
2071 Fix a crasher when refreshing the list view with the default table.
2073 This crash will also happen when loading the list view with the default
2074 table from a link or bookmark.
2076 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2077 to the main document selection page when the document id hasn't been
2079 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2080 the main document selection page when the document id hasn't been
2082 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2083 values for the details place when the document id hasn't been set.
2084 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2085 values for the list place when the document id hasn't been set.
2087 2011-12-21 Ben Konrath <ben@bagu.org>
2089 Protect against NPE when glom.document.locale is not in config.
2091 This patch protects against an NPE when glom.document.locale is not in
2092 the config file. This NPE will also happen if glom.document.locale is
2095 The patch also updates the error message to display the class name when
2096 the getMessage() returns null. This was happening when the NPE was
2097 thrown and I had "Configuration Error: null". If an NPE is encountered
2098 with this patch, "Configuration Error: NullPointerException " will be
2101 This commit closes this bug:
2103 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2105 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2107 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2109 Rename onlineglom.properties to onlineglom.properties.sample.
2111 * src/main/resources/onlineglom.properties: Rename to:
2112 * src/main/resources/onlineglom.properties.sample:
2113 * src/main/resources/README: And add this file explaining that people
2114 should rename it back when deploying.
2116 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2118 Allow choosing the translation in the .properties file.
2120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2121 init(): Read a glom.document.locale value from the configuration file
2122 and call Glom's TransatableItem::set_current_locale() method.
2123 * src/main/resources/onlineglom.properties: Add a commented-out
2124 example of this new setting.
2126 It would be better to add &lang=de_DE to the URL, but the current
2127 libglom API does not allow us to do this easily. I am working on that.
2129 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2131 Avoid a crash in parsing of token parameters.
2133 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2134 ava: getTokenParams(): Do not crash if a parameter has a key but no
2135 value, and ignore parameters with neither.
2137 2011-12-17 Murray Cumming <murrayc@murayc.com>
2139 History token building/handling: Improve use of token parameters.
2141 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2142 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2143 and buildParamsToken(HashMap), for use by derived classes.
2144 Make the separator private because it is no longer be needed.
2145 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2146 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2147 instead of manual string concatenation.
2148 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2149 of hardcoded indices and awkward splitting code.
2150 * src/main/java/org/glom/web/client/place/ListPlace.java
2151 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2152 instead of manual string concatenation.
2153 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2154 of hardcoded indices and awkward splitting code.
2155 This should fix bug #666420
2157 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2159 Fix a Navgiation->Navigation typo in the code.
2161 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2162 Rename processNavgiation() to processNavigation().
2164 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2166 Fix a seperator->separator typo in the code.
2168 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2169 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2170 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2173 2011-12-15 Ben Konrath <ben@bagu.org>
2175 Cleanup some comments.
2177 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2179 2011-12-14 Ben Konrath <ben@bagu.org>
2181 Replace \n with <br/> for multiline text in the details view.
2183 Vertical scrollbars are added when needed as well.
2185 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2187 2011-12-14 Ben Konrath <ben@bagu.org>
2189 Specify the font for document selection links.
2191 * src/main/webapp/style.css:
2193 2011-12-14 Ben Konrath <ben@bagu.org>
2195 Fix bouncy CellTable while paging.
2197 This doesn't currently work with related list tables in unselected
2200 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2202 2011-12-14 Ben Konrath <ben@bagu.org>
2204 Revamp the appearance of the document selection page.
2206 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2207 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2208 * src/main/webapp/style.css:
2210 2011-12-13 Ben Konrath <ben@bagu.org>
2212 Set navigation button column to the smallest size possible.
2214 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2216 2011-12-13 Ben Konrath <ben@bagu.org>
2218 Change OpenButton nomenclature to NavigationButton.
2220 Using NavigtionButton makes things more generic. Classes, methods and
2221 variables have been changed.
2223 This is a rename-only refactor.
2225 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2226 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2227 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2228 Renamed from OpenButtonCell.
2229 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2230 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2231 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2233 2011-12-12 Ben Konrath <ben@bagu.org>
2235 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2237 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2238 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2239 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2240 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2242 2011-12-12 Ben Konrath <ben@bagu.org>
2244 Update variable names and comments.
2246 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2247 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2249 2011-12-12 Ben Konrath <ben@bagu.org>
2251 Properly initialize numNonEmptyRows variable to zero.
2253 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2254 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2256 2011-12-05 Ben Konrath <ben@bagu.org>
2258 Add latest mockup with HTML tables.
2260 Features of this mockup:
2262 -> HTML table for flowtable
2263 -> HTML table for flowtable column
2264 -> Example of how related lists would look
2265 -> Not using text entries for data items
2267 The current version of Online Glom doesn't use HTML tables for the
2270 This mockup has been sent to the glom-devel mailing list but it's good
2271 to have it here as well.
2273 * mockups/details-view-html-tables.html:
2275 2011-12-05 Ben Konrath <ben@bagu.org>
2277 Remove unnecessary getPrimaryKeyField() method.
2279 getPrimaryKeyFieldForTable(String) has been renamed to
2280 getPrimaryKeyField(String).
2282 * src/main/java/org/glom/web/server/database/DBAccess.java:
2283 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2284 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2286 2011-12-05 Ben Konrath <ben@bagu.org>
2288 Add string representation of TypedDataItem value to conversion error message.
2290 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2291 message was extracted into its own method to avoid duplication.
2293 2011-12-05 Ben Konrath <ben@bagu.org>
2295 Add type checking to navigation primary key value creation.
2297 Create navigation primary key only if the expected type from the Glom
2298 document matches the type returned by the SQL query.
2300 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2302 2011-12-05 Ben Konrath <ben@bagu.org>
2304 Rename a couple of variables in RelatedListNavigation.
2306 This is a rename-only refactor.
2308 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2310 2011-12-05 Ben Konrath <ben@bagu.org>
2312 Move getListLayoutGroup() into getListViewLayoutGroup().
2314 This removes getListLayoutGroup(). It was only being called by
2315 getListViewLayoutGroup().
2317 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2319 2011-12-05 Ben Konrath <ben@bagu.org>
2321 Remove check for LayoutItem_Portal in list table method.
2323 This check is no longer necessary because the method isn't being used
2324 to create the LayoutItemPortal DTO.
2326 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2328 2011-12-05 Ben Konrath <ben@bagu.org>
2330 Properly support related list navigation.
2332 Navigation from the "Repository Analyzer -> Package Scans ->
2333 Dependencies" related table wasn't working because the primary key for
2334 related tables wasn't being set properly. This commit fixes the
2337 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2338 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2339 doesn't set the primary key properly for related list tables.
2340 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2341 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2342 useful for getting the primary key for list view tables and for related
2344 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2345 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2346 Move code to set the primary key for the table from the abstract
2347 ListDBAccess class to ListViewDBAccess as it's only correct for list
2349 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2350 Properly add primary key to related list tables.
2352 2011-12-02 Ben Konrath <ben@bagu.org>
2354 Properly set the horizontal alignment of fields.
2356 This fix is for both the list tables and the details view.
2358 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2359 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2360 to set the horizontal alignment of fields.
2362 2011-12-02 Ben Konrath <ben@bagu.org>
2364 Display currency codes in the details view.
2366 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2368 2011-12-02 Ben Konrath <ben@bagu.org>
2370 Avoid duplicate JNI call.
2372 JNI is not as efficient as pure Java and this is an easy (and small)
2375 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2376 Use previously retrieved value for whereClauseToTableName instead of
2379 2011-12-02 Ben Konrath <ben@bagu.org>
2381 Rename a couple of variables in RelatedListNavigation.
2383 This is a rename-only refactor.
2385 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2387 2011-12-02 Ben Konrath <ben@bagu.org>
2389 Indicate clearly that a mismatched primary key type is a bug.
2391 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2392 warning to error. Add 'This is a bug.' to message.
2394 2011-12-02 Ben Konrath <ben@bagu.org>
2396 Update / fix some comments.
2398 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2400 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2402 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2403 Fix comments. Add some TODOs.
2405 2011-12-02 Ben Konrath <ben@bagu.org>
2407 Enable navigation to details view with string primary key from related list.
2409 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2410 Create a text primary key value when return type of result is
2411 java.sql.Types.VARCHAR.
2413 2011-12-02 Ben Konrath <ben@bagu.org>
2415 Use checkboxes for booleans in the details view.
2417 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2419 2011-12-01 Ben Konrath <ben@bagu.org>
2421 Improve performance of related list height calculation.
2423 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2424 Put code to calculate the expected height in a static initializer so
2425 that that it's only called once.
2427 2011-12-01 Ben Konrath <ben@bagu.org>
2429 Show related list tables in notebooks (again).
2431 Calculate the height of the related list tables so the Notebook can be
2432 set the correct height. The height of the related list table is also needed by
2433 FlowTable to be able decide how to create the layout.
2435 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2436 and set the Portal height based on the height of the related list
2437 table and the Portal container.
2438 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2439 Add method to calculate the height of the related list tables.
2440 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2441 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2442 calculate the height of the Pager widget.
2444 2011-12-01 Ben Konrath <ben@bagu.org>
2446 Use CellTable API for table property instead of setting style on Element.
2448 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2450 2011-12-01 Ben Konrath <ben@bagu.org>
2452 Make ListViewTable and RelatedListTable a consistent height.
2454 The tables are now a consistent height regardless of the contents of
2455 the table. A hidden button is added to empty rows to ensure that the
2456 height of these rows will match the height of rows with data.
2458 A navigation button column is now added to every table. The width of
2459 the navigation column is set to 0px when a RelatedListTable shouldn't
2460 have navigation buttons. This maintains the a consistent row height in
2461 tables that don't show the navigation buttons.
2463 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2464 navigation column when not needed.
2465 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2466 arguments for navigation button to constructor of ListViewTable.
2467 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2468 hidden button for empty data rows.
2469 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2470 arguments for navigation button to constructor.
2471 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2472 create navigation buttons. Add hideNavigationButtons() method.
2473 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2474 arguments for navigation button to constructor.
2476 2011-12-01 Ben Konrath <ben@bagu.org>
2478 Use 'visibility: hidden' in Utils.getWidgetHeight().
2480 This is better choice because hidden elements are invisible, don't
2481 respond to events and are not part of the tab order. They will,
2482 however, take up space which is required to be able to calculate the
2483 height of the widget.
2485 * src/main/java/org/glom/web/client/Utils.java:
2487 2011-12-01 Ben Konrath <ben@bagu.org>
2489 Use Utils.getWidgetHeight() in FlowTable.
2491 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2493 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2495 2011-12-01 Ben Konrath <ben@bagu.org>
2497 Put the details css class name on the correct table column.
2499 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2501 2011-11-30 Ben Konrath <ben@bagu.org>
2503 Update for java-libglom API change.
2505 The getters and setters on FieldFormatting and NumericFormat were
2506 changed to remove the 'M'.
2508 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2510 2011-11-29 Ben Konrath <ben@bagu.org>
2512 Only allow RelatedListTables in Portals.
2514 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2516 2011-11-29 Ben Konrath <ben@bagu.org>
2518 Only create a contents panel for Portals when title is being set.
2520 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2522 2011-11-29 Ben Konrath <ben@bagu.org>
2524 Set TabLayoutPanel height based on calculated height its widgets.
2526 This is a potential fix for this bug:
2528 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2530 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2532 2011-11-29 Ben Konrath <ben@bagu.org>
2534 Align details field labels and data with the Open buttons.
2536 * src/main/webapp/style.css:
2538 2011-11-29 Ben Konrath <ben@bagu.org>
2540 Remove unnecessary <div> in the Notebook widget.
2542 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2543 method to get container FlowPanel (<div>).
2544 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2545 initWidget() method directly on the TabLayoutPanel widget instead of
2546 Group's container widget.
2548 2011-11-29 Ben Konrath <ben@bagu.org>
2550 Don't add group titles for Portals in Notebooks.
2552 This reverts the previous patch and fixes a bug I introduced with
2553 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2555 * src/main/java/org/glom/web/client/ui/details/Group.java:
2556 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2558 2011-11-28 Ben Konrath <ben@bagu.org>
2560 Remove unused boolean argument in Portal constructor.
2562 Just a code cleanup.
2564 * src/main/java/org/glom/web/client/ui/details/Group.java:
2565 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2567 2011-11-28 Ben Konrath <ben@bagu.org>
2569 Remove hack for glom 1.18 style glom files.
2571 * src/main/java/org/glom/web/client/ui/details/Group.java:
2572 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2573 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2575 2011-11-28 Ben Konrath <ben@bagu.org>
2577 Use Gda Value version of primary key to log result too large error.
2579 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2581 2011-11-28 Ben Konrath <ben@bagu.org>
2583 Don't use TypedDataItem.getText() for Unknown types from the URL.
2585 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2586 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2587 instead of getText().
2588 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2589 String field and getUnknown() method.
2591 2011-11-28 Ben Konrath <ben@bagu.org>
2593 Log an error message when the java-libglom .so is not present.
2595 The error message was being set in the exception but not logged.
2597 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2599 2011-11-28 Ben Konrath <ben@bagu.org>
2601 Ignore LayoutItem_CalendarPortals.
2603 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2604 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2606 2011-11-28 Ben Konrath <ben@bagu.org>
2608 Extract method for creating the LayoutItemPortal DTO.
2610 Just breaking the code up into smaller chunks.
2612 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2614 2011-11-28 Ben Konrath <ben@bagu.org>
2618 This should have been added with the refactor. Oops!
2620 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2622 2011-11-28 Ben Konrath <ben@bagu.org>
2624 Create primary key value from URL string using type from Glom document.
2626 See this bug, comments 19 - 25:
2628 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2630 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2631 create a TypeDataItem for the primary key here when loading from a
2632 URL. Show the same string for the primary key value as was received
2633 from the URL string (when loading from a URL).
2634 * src/main/java/org/glom/web/server/Utils.java: Update method for
2635 creating the Gda Value from the TypeDataItem to properly deal with
2636 creating a Gda Value based on the Glom document type for the primary
2637 key value string when loading from a URL.
2638 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2639 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2640 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2641 Update for changed method name.
2643 2011-11-27 Ben Konrath <ben@bagu.org>
2645 Rename PrimaryKeyItem to TypedDataItem.
2647 The name PrimaryKeyItem suggests what the class should be used for.
2648 TypedDataItem is a neutral name that describes the class better.
2650 This is a rename-only refactor.
2652 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2653 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2654 * src/main/java/org/glom/web/client/Utils.java:
2655 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2656 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2657 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2658 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2659 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2660 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2661 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2662 * src/main/java/org/glom/web/server/Utils.java:
2663 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2664 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2665 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2666 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2668 2011-11-25 Ben Konrath <ben@bagu.org>
2670 Improve Gda Value conversion from PrimaryKeyItem.
2672 The value from the PrimaryKeyItem is only used if its type match the
2673 type from the glom document.
2675 * src/main/java/org/glom/web/server/Utils.java:
2677 2011-11-25 Ben Konrath <ben@bagu.org>
2679 Manually check if the java-liblgom .so is visible to the JVM.
2681 It seems that Tomcat has problems when a static initializer throws an
2682 exception. This check is done before the first method call into
2683 java-libglom so that execution doesn't continue if the .so is not
2686 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2688 2011-11-25 Ben Konrath <ben@bagu.org>
2690 Improve browser configuration error messages.
2694 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2696 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2697 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2698 getConfigurationErrorMessage() method.
2699 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2700 Get and display a specific configuration error message when no Glom
2701 documents are found.
2702 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2703 Implement getConfigurationErrorMessage() method. Surround configuration
2704 code in the init() method with a try/catch block. This allows the
2705 errors to be caught while keeping the servlet available to retrieve the
2706 configuration error message.
2708 2011-11-25 Ben Konrath <ben@bagu.org>
2710 Don't use Strings to hold primary key values.
2712 The primary key values are now held in a new data object
2713 (PrimaryKeyItem) that holds type information and the primary key value
2714 using the correct type.
2716 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2717 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2718 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2719 PrimaryKeyItem instead of String to hold the primary key value.
2720 * src/main/java/org/glom/web/client/Utils.java: Remove
2721 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2722 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2723 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2724 PrimaryKeyItem instead of String to hold the primary key value. Load
2725 document selection page when the documentID has not been set correctly.
2726 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2727 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2729 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2730 Return empty string for URL instead of "null".
2731 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2732 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2733 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2734 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2735 PrimaryKeyItem instead of String to hold primary key values.
2736 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2737 PrimaryKeyValue to a Gda Value.
2738 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2739 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2740 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2741 Replace temporary database access code that uses the PrimaryKeyValue to
2742 Gda Value conversion.
2743 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2744 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2745 PrimaryKeyItem instead of String.
2746 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2747 hold primary key values.
2749 2011-11-24 Ben Konrath <ben@bagu.org>
2751 Use newly added java-libglom API to create queries.
2753 This isn't finished. I still need to stop using Strings for primary key
2754 values in the client code.
2756 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2757 libglom to use fake connections so that retrieving the query string will
2759 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2760 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2761 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2762 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2763 Use the newly added libglom sql methods and classes to create the
2764 query. Add temporary hack to convert primary value strings to Gda
2767 2011-11-23 Ben Konrath <ben@bagu.org>
2769 Don't explicitly set the height of Portals.
2771 See comments 6 - 10 of this bug for details:
2773 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2775 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2777 2011-11-23 Ben Konrath <ben@bagu.org>
2779 Use an HTML table instead of CSS for the FlowTable layout.
2781 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2782 GWT's FlexTable to implement the FlowTable.
2783 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2785 2011-11-18 Ben Konrath <ben@bagu.org>
2787 Add boolean example to HTML table mockup.
2789 * mockups/details-view-html-tables-text-entries.html:
2791 2011-11-17 Ben Konrath <ben@bagu.org>
2793 Ensure the pager buttons are always visible for related lists.
2795 To accomplish this, I've turned off text wrapping in the list view and
2796 related list tables for both the header and data text. The related list
2797 table now has a fixed layout so the it doesn't overflow its container.
2798 This is required to ensure that the cell text is clipped when it
2799 overflows the cell and an ellipsis is added to the right side of the
2800 cell when text is clipped.
2802 A fixed table layout for the related list table in the details view
2803 seems what we want for the details view anyway, so the side-effect is
2806 The ellipsis will only be displayed in Firefox >= 7.
2810 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2812 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2813 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2814 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2816 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2817 Set the 'table-layout: fixed' CSS property to the related list table.
2818 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2819 'white-space: nowrap;' CSS property on both the list view and the
2820 related list tables.
2822 2011-11-16 Ben Konrath <ben@bagu.org>
2824 Rework the fix for empty notebook tab labels.
2826 Setting the empty group titles with its name caused problems for the
2827 details layout. Instead of using libglom's
2828 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2829 to the client when the title is empty. This allows the Notebook to use
2830 the name when the title is empty without affecting anything else.
2832 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2833 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2835 2011-11-16 Ben Konrath <ben@bagu.org>
2837 Set group titles with name when title is empty.
2839 This fixes a problem with an empty notebook tab label in the Lesson
2840 Planner document. The forth tab in the notebook should be "Internet":
2842 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2844 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2845 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2848 2011-11-16 Ben Konrath <ben@bagu.org>
2850 Remove whitespace from the configured username properties.
2852 This assumes that usernames won't have whitespace at the beginning
2853 or end. But I think this is a reasonable assumption.
2855 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2856 String.trim() to remove the whitespace from the username properties.
2858 2011-11-15 Ben Konrath <ben@bagu.org>
2860 Add details view mockup with HTML tables and text entries.
2862 This is from the attachment on this bug:
2864 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2866 * mockups/details-view-html-tables-text-entries.html:
2868 2011-11-15 Ben Konrath <ben@bagu.org>
2870 Add space between the columns of the flow table.
2874 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2876 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2877 space between columns in the flow table.
2879 2011-11-15 Ben Konrath <ben@bagu.org>
2881 Add backup files to the .gitignore.
2883 * .gitignore: Ignore files that end with ~.
2885 2011-11-09 Ben Konrath <ben@bagu.org>
2887 Use latest release of gwt-log.
2889 Gwt-log releases are now being submitted to the maven central
2890 repository so manual installation of the jar is no longer required.
2892 * pom.xml: Update version and groupId of gwt-log dependency.
2894 2011-10-31 Ben Konrath <ben@bagu.org>
2896 Don't use GWT numeric formatting to override the glom currency formatting.
2898 Currencies are now displayed like they are in Glom. See this bug:
2900 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2902 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2904 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2905 currency code to constructor and set it when the cell is rendered.
2906 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2907 currency code to the constructor of the NumericCell.
2909 2011-10-27 Ben Konrath <ben@bagu.org>
2911 Require the latest release of java-libglom (1.17.4).
2915 2011-10-26 Ben Konrath <ben@bagu.org>
2917 Add style to Notebook that matches current theme.
2919 It's not the best style in the world but it's better than the default.
2921 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2922 padding at the bottom of the child widgets.
2923 * src/main/webapp/style.css: Add style for the Notebook.
2925 2011-10-26 Ben Konrath <ben@bagu.org>
2927 Move servlet initialization code to overridden init method.
2929 This is half of the solution to getting proper error messages
2930 displayed when configuration errors occur. Here's the relevant bug:
2932 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2934 The rest of the solution involves surrounding the init method with a
2935 try/catch block and setting a global variable with the error /
2936 exception. A new async method should be created to retrieve and display
2937 the error message / exception.
2939 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2940 code from constructor to init method adding exceptions as needed.
2942 2011-10-26 Ben Konrath <ben@bagu.org>
2944 Add script to monitor and restart tomcat if required.
2946 * utils/check-and-recover-tomcat.py: New file.
2948 2011-10-26 Ben Konrath <ben@bagu.org>
2950 Display the correct number of data items in the pager.
2954 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2956 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2957 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2958 The implementation is the same for both tables: Keep track of the
2959 number of non-empty rows and fire and RowCountChangeEvent after the data has
2961 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2962 custom Pager class that subclasses SimplePager to handle displaying
2963 the correct number when empty rows have been added.
2965 2011-10-26 Ben Konrath <ben@bagu.org>
2967 Correct error in previous commit.
2969 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2970 eventBus parameter from listView.setCellTable().
2972 2011-10-26 Ben Konrath <ben@bagu.org>
2974 Fix error in TODO comment.
2976 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2978 2011-10-24 Ben Konrath <ben@bagu.org>
2980 Create Notebook widgets to the details view.
2982 This isn't finished just yet - I still need to create a reasonable
2983 style to match the current theme.
2985 * src/main/java/org/glom/web/client/Utils.java: Add method for
2986 calculating the height of a widget. This is used in the Notebook class.
2987 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2988 new constructor method in Group.
2989 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2990 method for creating child widget that can be used by subclasses
2991 like Notebook. New constructor that allows disabling the group
2992 titles - Notebooks don't set a group title for their child groups.
2993 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2994 to make Notebooks using GWT's TabLayoutPanel.
2995 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2996 constructor that allows disabling the group titles.
2997 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2998 LayoutItemNotebook DTO.
2999 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
3000 DTO for Notebooks. It's just an empty class for now but we might need
3001 it to transfer some specific information in the future.
3003 2011-10-21 Ben Konrath <ben@bagu.org>
3005 Add navigation buttons to related list tables.
3007 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3008 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3009 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
3010 method getSuitableRecordToViewDetails() for getting the table name
3011 and primary key value for related list navigation buttons.
3012 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3013 private cell renderer class to get the navigation information for
3014 related list tables from the server. Extract the navigation
3015 processing code from the details cell navigation and use it for the
3016 related list navigation as well.
3017 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
3018 cell renderer class for the details open buttons. This was needed
3019 because the related list navigation buttons and the list view
3020 navigation buttons need to react differently when clicked.
3021 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
3022 the onEnterKeyDown() method because it's now overriden in the
3023 subclasses that are specific to the related list tables and the list
3025 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
3026 the vertical size a little because the buttons add a bit of vertical
3027 space to table. This is not a perfect solution because the vertical
3028 size of with table fewer than 5 rows will be a little smaller.
3029 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
3030 changes in how navigation buttons are handled.
3031 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
3032 getSuitableRecordToViewDetails() using the new RelatedListNavigation
3033 database access object.
3034 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
3035 to find the portal for a given relationship name from
3036 RelatedListDBAccess. Add method to find a primary key field for a
3038 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
3039 Move code to find the portal for a given relationship name to
3041 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
3042 New file: database access object for getting the related list
3043 navigation information (the table name and the primary key value).
3044 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
3045 DTO for transferring a table name to navigate to and a primary key
3047 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
3048 boolean and getter/setter to specifies if the related list should add
3051 2011-10-24 Murray Cumming <murrayc@murrayc.com>
3053 Use the master branch of java-libglom
3055 * pom.xml: Depend on java-libglom 1.19 instead.
3057 This is the master branch. See also the libglom-1-18 branch.
3059 2011-10-11 Ben Konrath <ben@bagu.org>
3061 Enable the open navigation button when the data has been set.
3063 This avoids having active buttons that don't do anything when the data
3066 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3068 2011-10-11 Ben Konrath <ben@bagu.org>
3070 Use IsWidget interface for FlowTableItem.
3072 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
3073 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
3075 2011-10-11 Ben Konrath <ben@bagu.org>
3077 Remove GWT styling from open button in details view.
3079 There are still some issues with how the details cell is arranged but
3080 this should be made to match Glom 1.20. I'm going to leave fixing this
3081 until I have Glom 1.20 up and running.
3083 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
3084 style name on open button.
3085 * src/main/webapp/style.css: Move and edit details-navigation class.
3086 Re-arrange some classes to make them appear in the same order as the
3089 2011-10-07 Ben Konrath <ben@bagu.org>
3091 Update to GWT 2.4.0.
3093 * .gitignore: Ignore new cache directory.
3094 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
3095 * pom.xml: Change GWT and maven plugin to 2.4.0.
3096 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
3098 * src/main/java/org/glom/web/client/ClientFactory.java:
3099 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
3100 * src/main/java/org/glom/web/client/OnlineGlom.java:
3101 Update source for API changes.
3102 * utils/build-onlineglom-war.sh: Remove cache directory before the
3105 2011-10-07 Ben Konrath <ben@bagu.org>
3107 Add navigation buttons in the details view.
3109 This isn't finished but I thought I'd commit what I have as it's a
3110 pretty good start. I still need to:
3112 1. Change the style so that it fits better into the current theme
3113 2. Adjust the details cell to expand as much as possible.
3115 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3116 click handlers to navigation buttons in the DetailsCells. Create a
3117 refreshData() method to get just the data from the server without the
3119 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3120 Update the tableSelector and browser title when the table name
3121 changes without using the tableSelector.
3122 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3123 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
3124 getDetailsCells() to getCells(). Update variable names.
3125 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
3126 method to set click handler on navigation button. Rename a few
3127 variables. Add navigation buttons where needed.
3128 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
3129 variables and methods.
3130 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
3131 navigation boolean and navigation table as required in the
3132 LayoutItemField DTO.
3133 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
3134 variables for navigation along with getter/setter methods.
3136 2011-10-07 Ben Konrath <ben@bagu.org>
3138 Rename Field to DetailsCell.
3140 This is a refactor-only commit. No functionality has been added or
3143 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3144 Update variable and method names.
3145 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3146 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
3147 variable and method names.
3148 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
3150 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
3151 variable and method names.
3153 2011-10-07 Ben Konrath <ben@bagu.org>
3155 Create separate methods for layout and data the details view.
3157 This is a refactor-only commit. No functionality has been added or
3160 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
3161 private methods: setData(), createLayout().
3163 2011-10-07 Ben Konrath <ben@bagu.org>
3165 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
3167 This is part of a change to get navigation buttons in the details view
3168 but it should have been done this way from the start.
3170 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3171 for method name change in TableSelectionView.
3172 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3173 Create TableChangeEvent and set the browser title using the
3174 TableSelectionView API.
3175 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3176 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3177 Change getSelectedTable() to getSelectedTableName(). Add
3178 getSelectedTableTitle().
3180 2011-10-07 Ben Konrath <ben@bagu.org>
3182 Use primaryKeyValue naming convention in constructor of DetailsPlace.
3184 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3186 2011-10-07 Ben Konrath <ben@bagu.org>
3188 Update TableChangeEvent to use newTableName naming convention.
3190 This makes the class more consistent with GWT naming conventions.
3192 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3193 Update for method name change in TableChangeEvent.
3194 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
3195 for method name change in TableChangeEvent.
3196 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
3197 newTableName variable and getter method. Make toDebugString()
3200 2011-09-30 Ben Konrath <ben@bagu.org>
3202 Disable the pager in the list tables when the data row count is less than the minimum.
3204 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3205 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3207 2011-09-30 Ben Konrath <ben@bagu.org>
3209 Add empty rows to the end of related list and list view tables.
3211 I also extracted the cell rendering classes from the ListTable because
3212 the code was becoming a little crazy with all the anonymous inner
3213 classes. My plan is to use these cell rendering classes in the details
3214 view as well so this refactor will be needed for that change.
3216 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
3217 set the row count in related list tables if the data has more rows
3218 than the minimum number of rows visible.
3219 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
3220 row count in list view tables if the data has more rows than the
3221 minimum number of rows visible.
3222 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
3223 for rendering TYPE_BOOLEAN cells. The code was extracted from the
3225 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
3226 for rendering TYPE_NUMERIC cells. The code was extracted from the
3228 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
3229 class for rendering cells with buttons in list views. The code was
3230 extracted from the ListTable class.
3231 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
3232 for rendering TYPE_TEXT cells. The code was extracted from the
3234 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3235 Add empty rows to the end of the data if required. Implement
3236 ListTable.getMinNumVisibleRows().
3237 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
3238 cell renderer code to public classes. Return null in
3239 Column.getValue() for empty rows. Add new abstract method:
3240 getMinNumVisibleRows(). Move code to set the row count of the list view
3241 table to ListViewImpl.
3242 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
3243 empty rows to the end of the data if required. Implement
3244 ListTable.getMinNumVisibleRows().
3247 2011-09-27 Ben Konrath <ben@bagu.org>
3249 Use GWT.log for client-side debugging statements.
3251 These are optimized out when deployed so I should have used this method
3252 in the first place. These statements will eventually be replaced with some sort
3253 of notification in the browser.
3255 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3256 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3257 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3258 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
3259 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
3261 2011-09-27 Ben Konrath <ben@bagu.org>
3263 Put tableselector on the right, back to list link on right.
3265 The idea is that the table selector is acting like a label for the
3266 currently displayed table so it should be placed below the document title. This
3267 puts the table title in a similar position to where it is in Glom.