1 2012-11-08 Murray Cumming <murrayc@murrayc.com>
3 Added an Indonesian translation.
5 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
6 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
7 This is from the new translation in Glom.
9 2012-07-22 Murray Cumming <murrayc@murrayc.com>
13 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
14 * src/main/java/org/glom/web/client/OnlineGlomService.java:
15 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
16 to gwtGlom, which is more appropriate.
17 This servlet name does not seem to be visible to the client side anyway.
19 2012-07-22 Murray Cumming <murrayc@murrayc.com>
21 Tests: Make the imports of assert*() consistent.
23 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
24 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
25 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
26 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
27 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
28 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
29 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
30 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
31 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
32 * src/test/java/org/glom/web/shared/DataItemTest.java:
34 import static org.junit.Assert.*;
35 which seems fairly common.
39 2012-07-21 Murray Cumming <murrayc@murrayc.com>
41 tests: Move a test that needs a database connection.
43 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
44 Move testGetListViewLayoutGroup() to
45 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
46 because it needs a database connection.
48 2012-07-21 Murray Cumming <murrayc@murrayc.com>
50 tests: Use @BeforeClass on tearDown().
52 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
53 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
54 This avoids leaking a postgres process in SelfHostExampleTest.
56 2012-07-21 Murray Cumming <murrayc@murrayc.com>
58 tests: Test translations more.
60 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
61 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
62 Test titles in the non-default locale.
64 2012-07-21 Murray Cumming <murrayc@murrayc.com>
66 tests: Add SelfHostConfiguredDocumentTest
68 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
69 username and password, for use by ConfiguredDocument.
70 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
71 This tests some of the ConfiguredDocument API that requires a database connection.
73 2012-07-21 Murray Cumming <murrayc@murrayc.com>
75 Document: Load title translations and test them.
77 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
78 of titles. I am surprised that we do not do this yet.
79 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
80 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
81 Test translations more.
83 2012-07-20 Murray Cumming <murrayc@murrayc.com>
87 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
88 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
89 Set the timeout here too.
91 2012-07-20 Murray Cumming <murrayc@murrayc.com>
93 tests: ConfiguredDocumentTest: Make this pass.
95 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
96 Disable tests that need a database connection.
98 2012-07-20 Murray Cumming <murrayc@murrayc.com>
100 Use Java 1.7 instead of Java 1.6.
102 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
103 to do this twice, at least for Eclipse.
104 This seems OK because it is the current version.
106 2012-07-20 Murray Cumming <murrayc@murrayc.com>
110 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
111 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
112 Avoid using a null Connection.
114 2012-07-20 Murray Cumming <murrayc@murrayc.com>
116 tests: Add a ConfiguredDocument test.
118 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
121 2012-07-20 Murray Cumming <murrayc@murrayc.com>
123 LayoutItemFIeld: getName(): Use the Field if it is set.
125 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
126 getName(): If the full field details have been set, return its name, so that
127 callers do not need to set the name separately.
128 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
129 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
130 so we can count the rows.
132 2012-07-20 Murray Cumming <murrayc@murrayc.com>
134 tests: SelfHoster: Test SqlUtils too.
136 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
137 Retrieve some data and check it too, as in the regular Glom
138 test_selfhosting_new_from_example.cc test.
139 * src/test/java/org/glom/web/server/SelfHoster.java:
140 createConnection(): Make this public.
142 2012-07-20 Murray Cumming <murrayc@murrayc.com>
144 tests: SelfHoster: createConnection(): Do not warn about expected failures.
146 Let the caller say if the connection is expected to fail, to avoid
147 irrelevant error output.
149 2012-07-20 Murray Cumming <murrayc@murrayc.com>
151 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
153 * src/test/java/org/glom/web/server/SelfHoster.java:
154 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
155 due to the inevitable need to retry the connection while the database server
158 2012-07-20 Murray Cumming <murrayc@murray.com>
160 tests: SelfHoster: createConnection(): Set a timeout.
162 * src/test/java/org/glom/web/server/SelfHoster.java:
163 createConnection(): Use setLoginTimeout() because it otherwise seems to take
164 ages to actually return when it fails.
166 2012-07-20 Murray Cumming <murrayc@murrayc.com>
168 tests: SelfHoster: selfHost(): Close the test connection.
170 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
171 When we check that the connection works, close the connection. This seems
172 to not be closed automatically otherwise.
174 2012-07-20 Murray Cumming <murrayc@murrayc.com>
176 Use slf4j-simple to see JDBC errors.
178 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
180 2012-07-19 Murray Cumming <murrayc@murrayc.com>
182 SelfHoster.discoverFirstFreePort(): Close the socket.
184 * src/test/java/org/glom/web/server/SelfHoster.java:
185 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
187 2012-07-19 Murray Cumming <murrayc@murrayc.com>
189 Avoid another code warning in Eclipse Juno.
191 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
192 Do instanceof checks on the FileUtils.listFiles() result and its
195 2012-07-13 Murray Cumming <murrayc@murrayc.com>
197 Avoid some code warnings in Eclipse Juno
199 * src/main/java/org/glom/web/server/libglom/Document.java:
200 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
201 * src/test/java/org/glom/web/server/SelfHoster.java
202 createTextFile(): Make sure that the FileOutputStream is closed.
204 2012-06-22 Murray Cumming <murrayc@murrayc.com>
206 Added OnlineGlomPropertiesTest.
208 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
209 Make sure we never return a null string.
210 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
211 Added tests of the OnlineGlomProperties API, using our sample file.
213 2012-06-20 Murray Cumming <murrayc@murrayc.com>
215 Make OnlineGlomProperties be a normal class.
217 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
218 Move OnlineGlomProperties into its own file to be a regular class:
219 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
220 This makes testing simpler.
222 2012-06-15 Murray Cumming <murrayc@murrayc.com>
224 OnlineGlomServiceImpl.init(): Move some code into a new method.
226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
227 Create addDocument().
229 2012-06-15 Murray Cumming <murrayc@murrayc.com>
231 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
233 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
234 OnlineGlomProperties.getKey(): Make this more robust by moving the
235 check for *.*.filename to here.
237 2012-06-15 Murray Cumming <murrayc@murrayc.com>
239 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
241 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
242 init(): Move knowledge of the config file format into the
243 OnlineGlomProperties inner class.
245 2012-06-15 Murray Cumming <murrayc@murrayc.com>
247 SelfHostExampleTest: Make sure we cleanup on failure.
249 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
250 the use of cleanup() to a tearDown() JUnit method.
254 2012-06-12 Murray Cumming <murrayc@murrayc.com>
256 ConfiguredDocument: Add a primary key to portals at least once.
258 * src/main/java/org/glom/web/server/ConfiguredDocument.java
259 updatePortalsExtras): Fix a typo so that we add the primary key
260 column at least once.
261 This is a fix for the previous commit:
262 ConfiguredDocument: Do not add a primary key to portals each time.
264 2012-06-08 Murray Cumming <murrayc@murrayc.com>
266 SelfHoster: Avoid some compiler warnings.
268 * src/test/java/org/glom/web/server/SelfHoster.java
269 executeCommandLineAndWait():
270 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
271 the now-unused streams for stdout and stderr from the command Processes.
272 These are not used because readln() hangs while waiting for a new line,
273 where there may be no next line. The commented out code is still there
274 to help us figure out how to do this properly.
276 2012-06-08 Murray Cumming <murrayc@murrayc.com>
278 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
280 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
281 Make this actually test the cloning again, though it is not very useful
282 now that we do not use the part that had a problem with cloning before.
284 2012-06-08 Murray Cumming <murrayc@murrayc.com>
286 SelfHoster: Keep trying pg_ctl after starting postgres.
288 * src/test/java/org/glom/web/server/SelfHoster.java
289 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
290 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
291 regular Glom. This seems mad but it seems to work because the first
292 command would fail if pg_ctl would eventually fail.
294 2012-06-08 Murray Cumming <murrayc@murrayc.com>
296 SelfHoster: Wait until the server is really ready.
298 * src/test/java/org/glom/web/server/SelfHoster.java
299 selfHost(): Attempt the connection after starting the server, retrying
300 a few times if necessary, so that the server is really ready already when
301 we return from this method.
302 The regular Glom code does this too because pg_ctl reports success too soon.
304 2012-06-08 Murray Cumming <murrayc@murrayc.com>
306 ConfiguredDocument: Do not add a primary key to portals each time.
308 * src/main/java/org/glom/web/server/ConfiguredDocument.java
309 updatePortalsExtras(): Only add an extra primary key field if there is
310 none, to avoid adding one each time we retrieve the details layout from the
312 This should fix bug #676986 (Ben Konrath)
314 2012-05-25 Murray Cumming <murrayc@murrayc.com>
316 Document.load(): Support version 7 documents.
318 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
319 database_title attribute if the title attribute is not there.
322 2012-05-24 Ben Konrath <ben@bagu.org>
324 Add configuration for auto-generating mvn:i18n from with Eclipse.
326 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
328 2012-05-24 Murray Cumming <murrayc@murrayc.com>
330 Update translations, adding French.
332 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
333 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
334 Add a French translation, using the translation from Glom.
336 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
337 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
338 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
339 Update these based on the translations from Glom.
341 2012-05-24 Murray Cumming <murrayc@murrayc.com>
343 SelfHoster: Add some debug println messages to help when things fail.
345 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
346 System.out.println() lines.
348 2012-05-23 Murray Cumming <murrayc@murrayc.com>
350 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
352 * src/test/java/org/glom/web/server/SelfHoster.java:
353 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
354 instance) instead of just /usr/bin (as on Fedora). Check the result when
357 2012-05-23 Murray Cumming <murrayc@murrayc.com>
359 Remove LayoutItemPortal.get/setNavigationTable().
361 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
362 Remove get/setNavigationTable(), which is only a cache, because it is not
363 used, and does not need to be used, because that decision should be made on
365 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
366 updatePortalsExtras():
367 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
368 getNavigationRecord():
369 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
372 2012-05-21 Murray Cumming <murrayc@murrayc.com>
374 Initial self-hosting for tests.
376 * pom.xml: Change the scope for log4j, to hopefully make it
377 available to the test code which uses it indirectly via jOOQ.
378 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
379 self-hosting, though we only use it for testing.
381 * src/main/java/org/glom/web/server/libglom/Document.java:
382 example rows: Use a map instead of a list for each row of values,
383 so we know what field they are for, instead of relying on the sequence
384 being correct. This is not very efficient, but it does not really need
386 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
387 testReadTableExampleRows(): Adapted.
389 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
390 that returns an Object, for generic use. Note that Object seems to be
391 the implicit base even of double.
392 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
393 for use in CREATE TABLE SQL queries.
394 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
395 to do self-hosting of PostgreSQL databases via its command-line
396 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
397 backends/postgres_self.cc. This is incomplete - it needs more
398 warnings about failures and it needs to clean up properly when things
400 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
401 test of this new class.
403 2012-05-21 Murray Cumming <murrayc@murrayc.com>
405 Document: loading example data: Handle exceptions.
407 * src/main/java/org/glom/web/server/libglom/Document.java:
408 DateFormat.parse() and Double.valueOf() can throw exceptions, though
409 Eclipse did not warn about that.
411 2012-05-20 Murray Cumming <murrayc@murrayc.com>
413 Document: load(), save(): Handle the example rows.
415 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
417 * src/main/java/org/glom/web/server/libglom/Document.java:
418 load(), save(): Load and save the example rows, though the date, time
419 and image types are not handled properly yet.
420 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
421 Add testReadTableExampleRows() just to check that something is read.
423 2012-05-20 Murray Cumming <murrayc@murrayc.com>
425 Document: Add save().
427 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
428 Added getTranslationsMap() for use while saving.
429 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
430 Adedd getUseDefaultFormatting() for use while saving.
431 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
432 and several private methods that it uses.
434 This will be useful while testing via self-hosting.
435 It is not complete, but should be complete enough for testing.
437 2012-05-17 Murray Cumming <murrayc@murrayc.com>
439 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
441 * src/main/java/org/glom/web/client/OnlineGlomService.java
442 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
443 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
444 Remove getSortedListViewData() and getSortedRelatedListData(), adding
445 the sort column index and ascending bool to the regular method.
446 Instead, a sort column index of -1 now means no sort.
447 This is less explicit, but it's fairly simple, reduces the amount of
448 code, and makes the OnlineGlomService API slightly smaller.
449 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
450 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
452 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
453 getListViewData(), getRelatedListData():
454 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
455 getListViewData(), getRelatedListData():
456 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
458 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
460 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
465 2012-05-16 Murray Cumming <murrayc@murrayc.com>
467 Use translations for top-level groups too.
469 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
470 updateTitlesForLocale(): Use the translation for the group
471 as well as for child items.
475 Just recompiled to fix a problem in the released .tar.gz file.
479 2012-05-15 Murray Cumming <murrayc@murrayc.com>
481 Corrections to navigation to related records.
483 * src/main/java/org/glom/web/client/OnlineGlomService.java:
484 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
485 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
486 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
487 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
488 relationship name, because the relationship name is not necessarily unique
490 TOOD: This is inefficient, because it passes the whole list of
491 child field items back to the server, but it is more correct, and happens
492 to fix a bug with the primary key being lost after a few navigations.
493 There is probably a chance to make this more efficient anyway in some
496 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
497 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
498 * src/main/java/org/glom/web/server/ConfiguredDocument.java
499 * src/main/java/org/glom/web/server/database/DBAccess.java
500 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
501 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
504 2012-05-15 Murray Cumming <murrayc@murrayc.com>
506 Fix the use of translations.
508 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
509 Add updateTitlesForLocale().
510 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
511 Call it to discard unwanted translations and to make getTitle() return
512 the wanted translation wihout the need for the client code to specify a locale.
513 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
514 getTitle(): Fallback to the original title, as libglom does.
516 2012-05-15 Murray Cumming <murrayc@murrayc.com>
518 Document: Correctly report the number of available translation locales.
520 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
521 the available locale IDs list.
522 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
523 testLocales: Test this.
525 2012-05-15 Murray Cumming <murrayc@murrayc.com>
527 SqlUtils: Use camelCase.
529 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
530 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
531 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
532 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
533 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
534 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
536 2012-05-15 Murray Cumming <murrayc@murrayc.com>
538 Use jOOQ's tableByName() and fieldByName.
540 * pom.xml: Use jOOQ 2.3.1 to get the new API.
541 * src/main/java/org/glom/web/server/SqlUtils.java:
542 build_sql_select_step_with_where_clause(), .createField(),
543 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
544 so we can get correct quoting and escaping. Thanks to Lukas Eder for
545 adding this, and other things, to jOOQ.
547 2012-05-15 Murray Cumming <murrayc@murrayc.com>
549 SqlUtils: Remove the Connection parameters.
551 * src/main/java/org/glom/web/server/SqlUtils.java:
552 build_sql_select_with_key(), build_sql_select_with_where_clause(),
553 createSelect(), build_sql_select_step_with_where_clause(),
554 build_sql_count_select_with_where_clause(),
555 build_sql_select_count_rows(): Remove the Connection parameter because
556 jOOQ does not actually need a connectionwhen it is just used to build
558 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
560 * src/main/java/org/glom/web/server/ReportGenerator.java:
562 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
564 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
565 Constructor, getListData(), getResultSizeOfSQLQuery():
566 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
567 getSelectQuery(), getCountQuery():
568 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
569 getSelectQuery(), getCountQuery():
570 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
571 getNavigationRecord(): Adapted.
573 2012-05-14 Murray Cumming <murrayc@murrayc.com>
577 * src/main/java/org/glom/web/server/SqlUtils.java:
578 get_find_where_clause_quick(): Use a comparison of
579 lowercase values, instead of a simple equals. Regular Glom
580 uses the PostgreSQL ILIKE operator but jOOQ does not
581 support that just yet, though it will soon.
583 2012-05-14 Murray Cumming <murrayc@murrayc.com>
585 TableToViewDetails: Use a real serialization ID.
587 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
588 Though this does not fix the serialization problem.
590 2012-05-12 Murray Cumming <murrayc@murrayc.com>
592 Added LayoutItemPortalDeepCloneTest.
594 2012-05-11 Murray Cumming <murrayc@murrayc.com>
596 Make navigation work again.
598 * src/main/java/org/glom/web/server/libglom/Document.java:
599 Add getLayoutItemFieldShouldHaveNavigation().
600 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
601 Replace get/setAddNavigation() with the partly-existing
602 get/setNavigationTableName(), with an empty string being no navigation,
603 because this is simpler. Use the new
604 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
606 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
607 Add updateFieldsExtras() and call setNavigationTableName in it.
608 getDetailsLayoutGroup(),
609 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
610 createLayout(): Adapted.
611 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
612 Constructor: Adapted.
614 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
615 Replace get/setAddNavigation() with get/setNavigation(), returning a
616 TableToViewDetails class with both the table name and UsesRelationship,
617 because both are need. The previous code used java-libglom's output
618 variable (strangely, via sharedptr) to return both, but we cannot really
620 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
621 getNavigationRecord(): Adapt. However, we cannot actually use the cache
622 here because it somehow gets set to null during deepCopy(). I must test this.
623 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
624 testGetSuitableTableToViewDetails(): Adapted.
626 TODO: Find out why deepClone() is not quite working.
628 2012-05-11 Murray Cumming <murrayc@murrayc.com>
630 DBAccess: Simplify the retrievel of full field details.
632 * src/main/java/org/glom/web/server/database/DBAccess.java
633 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
634 because the Document loading should have done this.
636 2012-05-11 Murray Cumming <murrayc@murrayc.com>
638 Document: Correct loading of doubly-related layout fields.
640 * src/main/java/org/glom/web/server/libglom/Document.java:
641 loadUsesRelationship(): Actually set the related relationship, instead
642 of only setting it if it's not found.
644 2012-05-09 Murray Cumming <murrayc@murrayc.com>
646 Replace all appearances of Colour with color.
648 Because US English is dominant.
650 2012-05-09 Murray Cumming <murrayc@murrayc.com>
652 Use colors in HTML format, solving a warning about an unused function.
654 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
655 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
656 Add *asHTMLColor() versions of methods.
657 TODO: However, we should create and cache the results on the server.
658 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
659 * src/main/java/org/glom/web/client/ui/list/ListTable.java
660 * src/main/java/org/glom/web/server/ConfiguredDocument.java
661 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
662 Use the asHTMLcolor() versions.
664 2012-05-09 Murray Cumming <murrayc@murrayc.com>
666 ListViewTable: Constructor: Take the table name as a parameter.
668 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
669 Constructor: Take the tableName, and set the member variable, because
671 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
672 setCellTable(): Pass the table name.
673 This makes navigation to non-default tables work again. I don't know
674 why it worked before in the master branch.
676 2012-05-07 Murray Cumming <murrayc@murrayc.com>
678 ConfiguredDocument: Restore correct addition of hidden primary key items.
680 * src/main/java/org/glom/web/client/ui/list/ListTable.java
681 (ListTable.createCellTable): Uncomment out the check for the hidden
683 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
684 add primary key items for top-level lists and portals, as before,
685 instead of adding them to each group.
686 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
687 Actually implement the extra methods such as setHiddenPrimaryKey() and
688 comment that these are used only for top-level list groups and in portals.
689 This strangeness suggests even more that this should not be squeezed
690 into the LayoutGroup class.
692 2012-05-07 Murray Cumming <murrayc@murrayc.com>
694 Fix Formatting loading.
696 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
697 getFormattingUsed(): Remove the duplicate Formatting member variable
698 in favour of the one from the base class.
699 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
700 Initialize a new Formatting instead of using null by default, so we
701 have some defaults, instead of having to initialize one later just to
702 get the same defaults. This also makes loading of formatting from the
703 document work, because that expected a non-null.
705 2012-05-07 Murray Cumming <murrayc@murrayc.com>
707 RelatedListTable: Make sure that the tableName is set.
709 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
710 Constructor: Take the tableName so it is available later. Otherwise,
711 the server assumes that we mean the default table and cannot find the
713 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
714 setData(): Pass the tableName to the RelatedListTable constructor.
716 2012-05-07 Murray Cumming <murrayc@murrayc.com>
720 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
721 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
722 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
724 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
726 * src/main/java/org/glom/web/server/database/DBAccess.java:
727 convertResultSetToDTO(), getPortal():
728 * src/main/java/org/glom/web/server/database/ListDBAccess.java
730 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
731 Add checks for null objects and out of range access, with log messages to
732 give hints so we can fix these properly.
734 2012-05-07 Murray Cumming <murrayc@murrayc.com>
736 Portals: some corrections.
738 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
740 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
741 constructor: Use getRelationshipNameUsed() instead of getName(), because
742 that is what is meant.
743 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
744 getFromField(): Fix a typo, to get the field name, not the table name.
745 * src/main/java/org/glom/web/server/database/DBAccess.java:
746 getPortal(): Fix a typo that stopped this from working.
748 2012-05-07 Murray Cumming <murrayc@murrayc.com>
750 LayoutItemPortal: Also override getTitleOriginal().
752 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
753 This lets the base getTitle() with no parameters work.
754 TODO: Test this properly.
756 2012-05-06 Murray Cumming <murrayc@murrayc.com>
758 LayoutItemPortal: getTitle*(): Use the relationship title.
760 2012-05-06 Murray Cumming <murrayc@murrayc.com>
762 LayoutItemField: Fix loading of custom titles.
764 * src/main/java/org/glom/web/server/libglom/Document.java
765 loadDataLayoutItemField(): The title, if any, instead of the field
766 title, is stored in a title_custom node. Load it from there.
767 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
769 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
770 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
771 getTitle*() overrides.
772 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
775 2012-05-06 Murray Cumming <murrayc@murrayc.com>
777 LayoutItemField: Fall back to field titles, so some are really shown.
779 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
780 Override getTitleOriginal() and getTitle(), as in java-libglom.
781 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
784 2012-05-06 Murray Cumming <murrayc@murrayc.com>
786 Correct use of setExpectedResultSize().
788 * src/main/java/org/glom/web/server/ConfiguredDocument.java
789 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
790 Use setExpectedResultSize only on top-level groups (for instance, the
791 list layout) or on child portals (in details views).
792 Use the correct table name for portals to avoid SQL errors.
793 Update the expected counts when returning cached layouts.
795 2012-05-06 Murray Cumming <murrayc@murrayc.com>
797 Document: Interpret no group column count as 1.
799 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
800 default, though we now check for this in the UI code anyway.
802 2012-05-06 Murray Cumming <murrayc@murrayc.com>
806 2012-05-06 Murray Cumming <murrayc@murrayc.com>
808 Translatable: Use Hashmap instead of Treemap because GWT supports it.
810 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
811 The use of Treemap lead to this error from async methods, with no
813 "The response could not be deserialized"
815 2012-05-06 Murray Cumming <murrayc@murrayc.com>
817 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
819 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
820 when using the Google -> GWT Compile, or
821 g toolbar button -> GWT Compile Project... feature in Eclipse.
823 2012-05-06 Murray Cumming <murrayc@murrayc.com>
825 ListTable.addColumn(): Protect against a null Formatting.
827 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
828 Create a default Formatting if it is null, because that is the simplest
831 2012-05-06 Murray Cumming <murrayc@murrayc.com>
833 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
835 * src/main/java/org/glom/web/server/ConfiguredDocument.java
836 updateLayoutGroup(): Check that the field is not null.
838 2012-05-06 Murray Cumming <murrayc@murrayc.com>
840 ListViewImpl: Protected against a bad cast error.
842 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
843 onEnterKeyDown(): Do not cast without an instanceof check.
845 2012-05-06 Murray Cumming <murrayc@murrayc.com>
847 ListTable: Protect against an out of range error.
849 * src/main/java/org/glom/web/client/ui/list/ListTable.java
850 createCellTable(): This is unlikely, but can happen while debugging.
852 2012-05-06 Murray Cumming <murrayc@murrayc.com>
854 AsyncMessage onFailure() callbacks: Log the exception message.
856 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
857 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
858 * src/main/java/org/glom/web/client/activity/ListActivity.java:
859 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
860 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
861 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
862 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
863 These are useful clues when something is wrong.
865 2012-05-06 Murray Cumming <murrayc@murrayc.com>
867 ConfiguredDocument: Avoid a null dereference.
869 * src/main/java/org/glom/web/server/ConfiguredDocument.java
870 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
871 details maps are created.
873 2012-05-06 Murray Cumming <murrayc@murrayc.com>
875 Document: Correct the port number parsing.
877 * src/main/java/org/glom/web/server/libglom/Document.java:
878 This lets us actually connect to the database and show the document.
880 2012-05-05 Murray Cumming <murrayc@murrayc.com>
884 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
885 user-interaction, asking us to load a temporary URL in a browser.s
886 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
887 which is apparently necessary for testing the service. See the comment.
888 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
889 Show the exception, if any. This is how I saw the 404 in the HTML in
892 2012-05-05 Murray Cumming <murrayc@murrayc.com>
894 DocumentTest: Move the .glom files into the resources directory.
896 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
897 URI via getResource().
899 2012-05-05 Murray Cumming <murrayc@murrayc.com>
901 Document: Remove the FieldIdentifies inner class.
903 * src/main/java/org/glom/web/server/libglom/Document.java: We only
904 use the Relationship (though the same function in libglom is maybe
905 used in other ways) and so this removes a compiler warning.
907 2012-05-05 Murray Cumming <murrayc@murrayc.com>
909 Document.load() Remove the error code parameter.
911 * src/main/java/org/glom/web/server/libglom/Document.java: load():
912 Remove the parameter. We do not set it yet and it could never have
913 worked as an output parameter (though maybe it did in java-libglom).
914 We could use an exception if we really want the failure reason.
915 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
917 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
918 setUp(), testGetSuitableTableToViewDetails(): Adapt.
920 2012-05-05 Murray Cumming <murrayc@murrayc.com>
922 Make some inner classes static.
924 * src/main/java/org/glom/web/server/ConfiguredDocument.java
925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
926 * src/main/java/org/glom/web/server/ReportGenerator.java
927 * src/main/java/org/glom/web/server/libglom/Document.java
928 Make all inner classes static that can be static.
930 2012-05-05 Murray Cumming <murrayc@murrayc.com>
932 OnlineGlomServiceImpl: Do not load and check for java-libglom.
934 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
935 init(): We do not use java-libglom any more.
937 2012-05-05 Murray Cumming <murrayc@murrayc.com>
939 Remove mentions of java-libglom.
941 * README: Remove mention of java-libglom, because it no longer needed.
942 * utils/build-onlineglom-war.sh:
943 * utils/check-and-recover-tomcat.py:
944 * utils/install-onlineglom-war.sh: Remove these as they are no longer
945 useful. Building is now far easier, with no need for jhbuild.
947 2012-05-05 Murray Cumming <murrayc@murrayc.com>
949 Fix the build (mvn package)
951 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
952 (LayoutGroup): Make the LayoutItemList inner class static and protected.
953 Otherwise the GWT Java->Javascript compilation fails with just this
954 error, during mvn package or when attempting to view in a browser,
955 in the GWT developer mode in Eclipse.
957 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
958 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
959 [INFO] Compiling module org.glom.web.OnlineGlom
960 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
961 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
962 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
963 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
964 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
965 [INFO] [ERROR] Cannot proceed due to previous errors
967 It has taken me 2 days to find out what was causing that. After reducing
968 the code, the compiler eventually showed me the full error message.
970 2012-05-04 Murray Cumming <murrayc@murrayc.com>
972 ConfiguredDocument: Cache the cloned and stripped layouts.
974 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
975 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
976 layout in a map, so we can retrieve it again without rebuilding it.
978 2012-05-04 Murray Cumming <murrayc@murrayc.com>
980 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
982 2012-05-04 Murray Cumming <murrayc@murrayc.com>
984 libglom classes: Implement some auto-generated emthods.
986 2012-05-04 Murray Cumming <murrayc@murrayc.com>
988 Add GwtTestOnlineGlomService.
990 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
991 However, this (and the other GwtTest*) does not seem to run during
994 2012-05-04 Murray Cumming <murrayc@murrayc.com>
996 Remove use of unsupported features from client code.
998 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
999 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1000 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1001 Use our client version of StringUtils instead of the apache commons one.
1003 However, the GWT Javascript compliation still fails.
1005 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1007 Add a Field class and implement some loading of it in Document.
1009 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1011 Initial Document loading implementation, instead of libglom.
1013 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1014 and Translatable classes, and adapt the rest of the code to use them.
1015 However, this is still missing Layout and Field classes and loading.
1017 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1019 Use of jOOQ: Move Field creation into a utility method.
1021 * src/main/java/org/glom/web/server/SqlUtils.java:
1022 This lets us improve it more easily.
1024 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1026 Use of jOOQ: Improve the code to COUNT a sub-select.
1028 * src/main/java/org/glom/web/server/SqlUtils.java:
1029 Move initial query creation into
1030 build_sql_select_step_with_where_clause().
1031 build_sql_select_count_rows(): Use the jOOQ API instead of
1032 concatentating text, because a jOOQ Select*Step is a TableLike,
1033 which is what from() takes.
1035 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1037 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1039 * pom.xml: Depend on jooq.
1040 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1041 methods with jOOQ, based on the C++ implementations in libglom,
1042 with some changes to the logic required by jooQ.
1043 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1045 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1046 * src/main/java/org/glom/web/server/ReportGenerator.java:
1047 * src/main/java/org/glom/web/server/SqlUtils.java:
1048 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1049 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1050 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1051 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1052 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1053 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1054 because jOOQ needs that, though it seems unnecessary.
1056 This is not quite finished. Ideally jOOQ would help us to build
1057 table_name.field_name names, quoting and escaping them properly.
1058 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1060 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1062 Move use of Glom.build_sql*() into a new SqlUtils class.
1064 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1065 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1066 but this will make it easier to start using something other than
1067 libglom or SqlBuilder.
1069 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1071 Update the project URL.
1073 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1075 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1077 Main layout: Use a FlowTable instead of absolute positioning.
1079 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1080 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1081 child panels/widgets must have an absolute position. But that is annoying, so
1082 this adds a FlowTable and puts the child panels in there.
1084 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1086 GwtTestOnlineGlom: Comment out unused code.
1088 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1089 Eclipse has started to say that some code is unused.
1091 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1093 Update to the latest versions of dependencies.
1095 * pom.xml: Update version numbers of dependencies to the latest
1097 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1098 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1099 * src/main/java/org/glom/web/server/ReportGenerator.java:
1100 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1101 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1102 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1104 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1105 Modify the imports where necessary.
1107 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1109 Style: Remove overflow:hidden from searchbox
1111 * src/main/webapp/style.css: Because this pushes the Back To Link
1112 label/link on to the next row, which is then hidden due to the
1113 hard-coded (in ems) height.
1115 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1117 Remove some duplicate code.
1119 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1120 getDocumentInfo(): This must have been duplicated during the merge from the
1125 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1127 Reports: Localize the waiting for report message.
1129 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1130 start(): Get the message from the contants.
1131 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1132 Add the string here.
1133 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1134 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1135 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1136 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1137 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1138 Update these files with the English text for newer strings for now.
1140 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1142 Reports: Show a message while waiting for the report.
1144 * src/main/java/org/glom/web/client/ui/ReportView.java
1145 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1146 Add setWaitingText(), to show a message saying that we are
1147 waiting for the report to be ready.
1148 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1149 start(): Call setWaitingText() before calling the async
1152 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1154 ReportGenerator: Specify date and time formats.
1156 * src/main/java/org/glom/web/server/ReportGenerator.java:
1157 createFieldValueElement(): Use the default (and localized)
1158 short formats, though we still need a way to show 4-digit
1159 years without providing the format for every locale.
1160 * src/main/java/org/glom/web/server/database/DBAccess.java:
1161 convertResultSetToDTO(): Use the short formats here too.
1163 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1165 ReportGenerator: Use the correct numeric formatting.
1167 * src/main/java/org/glom/web/server/ReportGenerator.java
1168 createFieldExpression(), createFieldValueElement(): Take the
1169 whole LayoutItem_Field instead of just the field name, so
1170 we have access to the formatting.
1171 createFieldValueElement(): Use JRTextField.setPattern() to
1172 specify the numeric formatting, with the help of a
1173 regular DecimalFormat.
1175 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1177 ReportGenerator: Avoid showing null for group by titles.
1179 * src/main/java/org/glom/web/server/ReportGenerator.java
1180 generateReport(): Use setBlankWhenNull() on the field title
1181 style too, because this is used for values in group by
1184 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1186 ReportGenerator: Add a colon to titles in vertical groups.
1188 * src/main/java/org/glom/web/server/ReportGenerator.java
1189 addFieldToDetailBandVertical(): Pass true for the withColon
1192 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1194 ReportGenerator: Simplify the code by using Position more.
1196 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1198 Reports: Support vertical groups, roughly.
1200 * src/main/java/org/glom/web/server/ReportGenerator.java:
1201 addToReport(): Rename to addGroupToReport() and, if necessary,
1202 call the new addVerticalGroupToReport() method.
1203 createFieldValueElement(): Let the caller specify the Y position
1206 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1208 Reports: Allow a second report to be shown.
1210 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1211 clear(): Do not remove the HTML widget, which broke the whole layout.
1213 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1215 Locales drop-down: Show that we use English by default.
1217 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1218 fillView(): When we use English, just because that is the default, when
1219 no locale is specified, show that in the Locales drop-down instead of
1220 just showing the first item.
1222 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1224 Unselect the Report/Locale/Table combo item when appropriate.
1226 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1227 setPlace(): clear reportName if this is not a ReportPlace.
1228 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1229 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1230 When the provided name is empty, unselect all items, so that none are
1231 indicated. This uses a for loop because I cannot find a single method
1234 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1236 Report: Give the user a way to get back to the list.
1238 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1239 start(), setPlace(): Show the Back To List link on reports, and also
1240 interpret selecting the empty report item as back to list.
1242 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1244 Really show the selected Report name.
1246 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1247 setPlace(): Store the reportName here, if it is that kind of Place.
1248 fillView(): Set the selected Report after filling the list of reports.
1249 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1250 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1251 null Strings, though we need some way to unselect all ListBox items
1254 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1256 ReportGenerator: Try to avoid some problems.
1258 * src/main/java/org/glom/web/server/ReportGenerator.java
1259 addField(): Try to avoid duplicates, and avoid using a null
1262 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1264 Reports: Use quickFind.
1266 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1267 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1268 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1269 getReportHTML(): Add a quickFind parameter.
1270 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1271 start(): Pass the quickFind parameter.
1272 * src/main/java/org/glom/web/server/ReportGenerator.java
1273 generateReport(): Take a quickFind parameter.
1275 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1277 ReportPlace: Actually use the report name.
1279 * src/main/java/org/glom/web/client/place/ReportPlace.java
1280 getPlace(): Do not assign the report name to the quickfind.
1282 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1284 Show java.library.path when complaining.
1286 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1287 init(): When telling us to check java.library.path, show the
1290 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1292 ReportGenerator: Do not show nulls.
1294 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1296 ReportGenerator: Make the title font larger.
1298 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1300 ReportGenerator: Put field titles inside groups, if there are groups.
1302 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1304 ReportGenerator: Take the Report itself instead of the name and group.
1306 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1307 Remove getReportLayoutGroup().
1308 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1309 getReportHTML(): Pass the report instead
1310 of its name and layout group.
1311 * src/main/java/org/glom/web/server/ReportGenerator.java
1312 generateReport(): Use the report object to use the title
1313 instead of the name.
1315 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1317 ReportGenerator: Remove designBand parameters.
1319 * src/main/java/org/glom/web/server/ReportGenerator.java:
1320 Make designBand a class member instead of passing it to all
1323 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1325 ReportGenerator: Add lines, a bit like in the desktop version.
1327 * src/main/java/org/glom/web/server/ReportGenerator.java
1328 addToReport(): Use JRDesignLine.
1330 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1332 ReportGenerator: Correct the title positions and use some bold style.
1334 * src/main/java/org/glom/web/server/ReportGenerator.java:
1335 Break the code up into reusable functions, correct the placement of
1336 titles, and use normal/bold styles as in the reports in the desktop
1339 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1341 ReportGenerator: Add a header band to show the field titles.
1343 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1344 getReportHTML(): Pass the localeId to the ReportGenerator
1346 * src/main/java/org/glom/web/server/ReportGenerator.java
1347 constructor: Take the localeID so we can get translated field
1349 generateReport(), addToReport(), addFieldToBand(): Add field
1350 titles in a column header band.
1352 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1354 Reports drop-down list: Some improvement.
1356 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1357 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1358 Adedd setSelectedReport(),
1359 setReportList(): Add a blank line so that the user can select the
1361 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1362 start(): Show the current report by calling setSelectedReport().
1363 This does not seem to work yet.
1365 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1367 DetailsActivity, ListActivity: Move some variables into a base class.
1369 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1370 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1371 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1372 the clientFactory, documentID, tableName and authenticationPopup into
1373 a base class, to avoid duplication.
1375 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1377 Translate the Reports label.
1379 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1380 Get the "Reports" label string from the constants.
1381 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1382 perties: Add Reports to the constants.
1384 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1386 Reports: Implement grouping.
1388 * src/main/java/org/glom/web/server/ReportGenerator.java:
1389 Handle LayoutItem_GroupBy items and try to do the right thing
1390 with JRDesignGroup. It seems to work.
1392 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1394 Actually show some data with JasperReports.
1396 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1397 getReportHTML(): Move most code into a ReportGenerator class.
1398 * src/main/java/org/glom/web/server/ReportGenerator.java:
1399 Recurse into sub-groups, adding fields to the JasperDesign's details
1400 band. Note that we must set an arbitrary width and height, or it just
1401 will not show any data.
1403 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1405 Reports Chooser: Show the titles, not the names.
1407 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1408 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1409 and the names as the values.
1410 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1411 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1412 group now that we provide the report name, so it should always
1415 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1417 Depend on jasperreports.
1419 * pom.xml: Add the dependency. My plan is to use this on the
1422 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1424 Implement navigation to report places.
1426 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1427 start(): Do not bother to handle all events here.
1428 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1429 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1430 Added getSelectedReport().
1431 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1432 .java: start(): When handling a change to the reports chooser,
1433 call getSelectedReport() and goTo() its ReportPlace.
1434 * src/main/java/org/glom/web/client/ui/ReportView.java
1435 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1436 Added setReportHTML() which puts the html in a gwt HTML widget.
1437 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1438 getReportHTML(): Return "TODO" just to show that this works.
1440 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1442 Make ReportPlace usable.
1444 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1445 Mention ReportPlace.
1446 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1447 Correct the @prefix annotation.
1449 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1451 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1453 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1454 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1455 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1456 Change getReportLayout() to getReportHMTL() because we will not need to
1457 parse or render the report layout on the client side.
1458 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1459 getReportLayout(): Return the libglom LayoutGroup type because we will
1460 not need to convert to a shared type, because this will not be used on
1462 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1465 Note that there is still no implementation for this.
1468 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1470 Add a (empty) Report Place, View, and Activity.
1472 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1474 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1475 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1476 this into a superclass:
1477 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1478 and also use it as the base of this new ReportPlace:
1479 * src/main/java/org/glom/web/client/place/ReportPlace.java
1481 * src/main/java/org/glom/web/client/ui/ReportView.java
1482 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1483 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1484 Add these, containing mostly boiler-plate for now.
1486 * src/main/java/org/glom/web/client/OnlineGlomService.java
1487 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1488 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1489 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1490 Add API to get the LayoutGroup for the report.
1492 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1494 Add and fill a Reports drop-down list box.
1496 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1498 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1499 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1500 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1501 Added getReports(document, table, localeID), calling
1502 ConfiguredDocument.getReports().
1503 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1504 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1505 Added setReportsList() and a list widget.
1506 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1507 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1512 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1514 Translations: Add Esperanto.
1516 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1517 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1518 properties: Add this translation because someone took the time to make it.
1520 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1522 Adapt to the java-libglom 1.21.7 API.
1524 * src/main/java/org/glom/web/server/ReportGenerator.java:
1525 addToReport(): get_group_secondary_fields() is now
1526 get_secondary_fields().
1529 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1531 Use the latest java-libglom version.
1533 * pom.xml: Use java-libglom 1.21.7.
1535 2012-03-03 Ben Konrath <ben@bagu.org>
1537 Display date and time in details view.
1539 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1541 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1543 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1545 Require the latest java-libglom.
1547 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1549 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1551 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1553 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1554 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1555 an empty quickfind string. I also corrected libglom to create only
1556 empty where clauses for empty quickfind strings, but this avoids the
1559 2012-02-24 Ben Konrath <ben@bagu.org>
1561 Improve the tabs in the Notebook widget.
1565 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1567 Translations: Try to translate the strings.
1569 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1570 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1571 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1572 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1573 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1574 Take the Open translation from GTK+'s .po files.
1575 Take the Details translation from Glom's po files.
1576 I have added the other strings to Glom so we can get translations that way:
1577 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1579 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1581 TableSelectionViewImpl: Put the search label and entry in a div.
1583 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1584 Put the search widgets in a FlowTable so that the CSS can be used to
1585 style them while keeping them together.
1586 * src/main/webapp/style.css: Mention the new div.
1588 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1590 Translate more strings in more locales.
1592 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1593 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1594 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1595 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1596 Translate the "Details" and "Open" string too.
1598 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1599 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1600 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1601 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1602 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1603 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1604 Add these new locales as placeholders though they currently contain English.
1606 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1608 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1610 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1611 Check the ConfiguredDocument* for null before using it.
1613 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1615 Tell Eclipse about the generated java files.
1617 * .classpath: This lets it find OnlineGlomConstants.java.
1618 It would be nice if Eclipse just used the maven build files.
1620 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1622 Prevent a crash when no locale is specified in the URL.
1624 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1625 Avoid returning a null string, obtained from
1626 Window.Location.getParameter(). This caused a crash when it was
1627 later passed to libglom's API.
1628 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1629 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1630 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1631 guard against future null strings.
1633 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1635 Use the ?locale= query param instead of the &lang= token param.
1637 * src/main/java/org/glom/web/client/place/ListPlace.java
1638 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1639 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1640 Remove the lang token key and value.
1642 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1643 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1644 When the user selects a different locale from the chooser, use
1645 Window.Location.assign() to change the URL, which then causes a reload.
1647 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1648 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1649 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1650 * src/main/java/org/glom/web/client/activity/ListActivity.java
1651 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1652 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1653 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1654 * src/main/java/org/glom/web/client/ui/ListView.java:
1655 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1657 Remove localeID member variables and method/constructor parameters, instead
1658 using Utils.getCurrentLocaleID() when we need a localID to pass to
1661 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1663 Internationalize the UI strings.
1665 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1666 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1667 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1668 because it is unused. Messages are apparently strings that can have
1669 parameters, but we do not need that yet, so Contants will be enough for now.
1670 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1671 to say that we support the en and de locales.
1672 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1673 The original English strings.
1674 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1675 Some German translations of the English strings.
1676 The i18n goal then uses the .properties file to generate an
1677 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1678 returns an implementation that returns the translated strings.
1679 The documentation suggests putting these in src/java/*/client/, but it seems
1680 best to put it in src/resources/*/client/.
1681 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1682 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1683 instead of hard-coding them.
1684 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1685 but that does not seem to stop the build, though it confuses Eclipse.
1687 You can see the translated string by adding ?locale=de to the URL, like so:
1688 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1690 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1692 Improve null/empty String checks.
1694 * pom.xml: Add a dependency on commons-lang, to use
1695 org.apache.commons.lang.StringUtils.
1696 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1697 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1698 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1699 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1700 Use StringUtils.isEmpty().
1702 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1703 StringUtils class with a static isEmpty() function because we
1704 cannot use org.apache.commons.lang.StringUtils in client-side
1705 GWT code because it (apparently) cannot be compiled to javascript.
1706 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1707 * src/main/java/org/glom/web/client/activity/ListActivity.java
1708 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1709 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1710 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1711 * src/main/java/org/glom/web/client/place/ListPlace.java
1712 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1713 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1714 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1715 * src/main/java/org/glom/web/client/ui/details/Group.java
1716 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1717 our StringUtils.isEmpty() function.
1719 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1721 Update to the latest java-libglom API.
1723 * pom.xml: Require java-libglom 1.21.4.
1724 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1725 getDocumentInfo(), getListViewLayoutGroup():
1726 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1728 * src/main/java/org/glom/web/server/database/DBAccess.java
1729 getFieldsToShowForSQLQueryAddGroup(),
1730 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1731 with either get_database_title_original() or
1732 get_database_title(localeID).
1734 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1736 ConfiguredDocument: Avoid a null pointer exception.
1738 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1739 Initialize localeID to "" to avoid returning a null String which
1740 causes a crash in java-libglom's swing-generated code.
1742 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1744 Some simple renaming.
1746 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1747 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1748 for localeChooser. This seems more appropriate and is less ambiguous
1749 particularly in the .css file.
1751 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1753 ConfiguredDocument: Rename the localedID private member variable.
1755 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1757 Adapt to the latest java-libglom API from git master.
1759 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1760 libglom now uses only Vector instead of List, which uses add() instead of
1763 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1765 ConfiguredDocument: Rename the localedID private member variable.
1767 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1769 Build a source tarball with mvn assembly:single
1771 * assembly.xml: Add this file.
1772 * pom.xml: Use the maven-assembly-plugin and tell it to use
1773 our assembly.xml file.
1775 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1777 OnlineGlomServiceImpl: Get .glom files recursively.
1779 * pom.xml: Depend on commons-io from org.apache.commons.
1780 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1781 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1782 files recursively, and with the easier filter for the extension.
1783 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1784 simplify that code too.
1786 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1788 README: Mention that you must install java-libglom packages separately.
1790 But then it works, because java-libglom is now in the central maven
1793 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1795 locales drop-down: Show the correct selected locale when the URL changes.
1797 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1798 .java: setPlace(): Move some code into fillView().
1800 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1802 locales drop-down: Do not lose the primary key.
1804 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1805 start(): onLocaleChange(): Pass the current primary key value,
1806 instead of an empty value.
1808 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1810 locales drop-down: Do not lose the drop-down selection.
1812 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1813 .java (TableSelectionActivity.fillView): Set the selected locale
1814 after changing the drop-down items (though we do not really need
1815 to change them just because the locale changes.)
1817 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1819 locales drop-down: Change the tables list when this changes.
1821 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1822 .java: TableSelectionActivity.start(): Move the async table titles
1823 retrieval into a private fillView() method and also call this when
1824 the chosen locale changes.
1825 Note that the document title is not actually translatable yet, but
1826 that is a problem that I should fix soon in libglom.
1828 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1830 Improve the placement of the locales drop-down.
1832 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1833 Put the title and locales drop-down in a div (gwt.FlowTable).
1834 * src/main/webapp/style.css: Add magic css properties to make this work.
1835 Also remove the left margin from the title so that it lines up with the
1838 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1840 locales selector: Show human-readable locale titles.
1842 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1843 getDocumentInfo(): Use java.util.Locale to show a real title of
1844 each locale, in the locale's own language.
1846 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1848 Add a language/locale selector drop-down.
1850 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1851 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1852 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1853 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1854 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1855 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1856 Add a ListBox to show the available locales. Add getLocaleSelector(),
1857 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1858 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1859 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1860 java: Add these classes.
1861 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1862 start(): Fill the locales ListBox. Handle its change event, firing a
1864 setPlace(): Show the selected locale as specified by the URL token.
1865 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1866 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1867 Handle LocaleChangeEvent, going to a new *Place with that locale.
1869 The placement of the ListBox is not pretty, and it currently uses the ID
1870 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1874 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1876 Search box: Show the search text from the URL token.
1878 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1879 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1880 Add setQuickFindText().
1881 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1882 .java: setPlace(): Store the queryText if the place is a ListPlace,
1883 and call TableSelectionView.setQuickFindText().
1885 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1887 Allow use of translations via, for instance, &lang=de in the URL.
1889 * pom.xml: Use the unstable java-libglom 1.21 version.
1891 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1892 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1893 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1894 init(): Instead of calling TranslatableItem.set_current_locale()
1895 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1896 However, this is only for default locales, which are not needed to
1897 change the locale in the URL.
1898 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1899 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1900 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1901 layout for a particular locale.
1902 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1903 Add get/setDefaultLocaleID().
1904 getDocumentInfo(), getListViewData(), getRelatedListData(),
1905 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1906 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1907 localeID parameter, so we can get the layout for a particular locale.
1909 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1910 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1911 * src/main/java/org/glom/web/client/place/ListPlace.java:
1912 Parse and construct a lang parameter too.
1914 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1915 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1916 passed to subsequent methods and constructors.
1917 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1918 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1919 Store the localeID from the *Place and pass it to other constructors
1920 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1922 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1923 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1924 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1925 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1926 * src/main/java/org/glom/web/client/ui/ListView.java:
1927 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1928 Take localeID parameters and pass them to subsequent constructors and
1929 methods, so that the layout is always retrieved for that locale.
1931 This is rather repetitive.
1933 Note that "" means the original (default) locale of the Glom document,
1934 which is usually English.
1936 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1938 Documents: Remove final keyword to fix startup configuration.
1940 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1941 final keywords on the private member variables because that breaks
1942 the startup, apparently (there are warnings) because it stops them
1943 from being serialized. I added these in the previous commit.
1945 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1947 Documents: Add some final keywords.
1949 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1952 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1954 OnlineGlomServiceImpl: Add to overview comments.
1956 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1957 Note that this is where all the document are loaded. They are not
1958 loaded freshly for each page.
1960 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1964 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1965 Add a TextBox for the text of a quick find.
1966 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1968 setBackLink(): Add a String quickFind parameter.
1969 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1970 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1971 to the base interface, because that is how TableSelectionViewImpl is used.
1972 * src/main/webapp/style.css: Add style for the search box and its label.
1974 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1975 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1976 Add these files, based on the existing TableChangeEvent and
1977 TableChangeEventHandlers.
1978 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1979 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1980 a ListPlace() that the user should be taken to.
1981 * src/main/java/org/glom/web/client/activity/ListActivity.java
1982 start(): Handle it here too and adapt the TableChangeEvent handler to
1983 pass the extra "" quickFind parameter to ListPlace.
1984 * src/main/java/org/glom/web/client/place/ListPlace.java:
1985 Constructor: Take an extra String quickFind parameter and store it,
1986 returning it from a new getQuickFind() method.
1987 getToken(): Put the quickFind text in the URL token.
1988 getPlace(): Parse the quickFind text from the URL token.
1989 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1990 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1991 ListPlace constructor.
1992 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1993 .java: start(): Add a Change handler for the TableSelectionView's
1994 TextBox (via its base HasChangeHandlers interface), firing the new
1995 QuickFindChangeEvent.
1996 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1997 pass the extra "" quickFind parameter.
1999 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2000 setCellTable(): Add a String quickFind parameter and pass it to
2001 the ListViewTable() constructor.
2002 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2003 setCellTable() in the base interface, because that is how ListViewImpl
2006 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2007 Add a String quickFind member variable.
2008 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2009 Constructor: Add a String quickFind parameter, storing it in the
2010 base ListTable's member variable.
2011 onRangeChanged(): Pass quickFind to the
2012 OnlineGlomServiceAsync.getSortedListViewData() and
2013 OnlineGlomServiceAsync.getListViewData() methods.
2015 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2016 getListViewData(), getSortedListViewData(): Add a String quickFind
2017 parameter, passing it to ConfiguredDocument.getListViewData().
2018 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2019 Change getListViewData(), getSortedListViewData() in the base interface,
2020 because that is how OnlineGlomServiceImpl is used, via this:
2021 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2022 Change getListViewData(), getSortedListViewData() here too.
2023 This class can apparently be used to asynchronously call methods on
2024 OnlineGlomService, and GWT seems to implement that after recognizing
2025 just the *Async name convention and the extra AsyncCallback parameters.
2027 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2028 getListViewData(): Add a String quickFind parameter, and pass it to
2029 ListViewDBAccess.getData().
2030 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2031 getListData(): Add a String quickFind parameter and pass it to
2033 getSelectQuery(): Add a String quickFind parameter.
2034 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2035 getSelectQuery(): Add a String quickFind parameter and use it with
2036 Glom.get_find_where_clause_quick() to pass a where_clause to
2037 Glom.build_sql_select_with_where_clause(), to actually filter the
2039 getData(): Add a String quickFind parameter, passing it to getListData().
2040 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2041 va: getData(): Pass an empty string to getListData() for the
2042 quickFind parameter.
2044 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2046 ListTable: Minor change.
2048 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2049 createCellTable(): Make this protected instead of public.
2051 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2053 Many files: Use final for the parameters and use the @override attribute.
2055 2012-01-22 Ben Konrath <ben@bagu.org>
2057 Add anchor links for single line text that starts with http, ftp and www.
2061 2012-01-22 Ben Konrath <ben@bagu.org>
2063 Add ellipsis to single line text in details view.
2067 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2069 Remove all javadoc author tags.
2071 Because they are awkward and meaningless when many people touch
2073 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2075 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2077 Revert the COPYING.LESSER to COPYING rename.
2079 Apparently both should be there if it is LGPL.
2081 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2083 *View: Remove unused imports.
2085 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2086 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2087 * src/main/java/org/glom/web/client/ui/ListView.java:
2088 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2089 Remove unused imports, as suggested by Eclipse.
2091 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2093 Move the *View::Presenter types, and some API into one base View.
2095 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2096 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2097 * src/main/java/org/glom/web/client/ui/ListView.java:
2098 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2099 Presenter, setPresenter() and clear() into a shared base interface,
2100 to avoid the unnecessary duplicate Presenter types and to more clearly
2101 show how the *Views share the same structure, even if they are not
2102 used polymorphically.
2104 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2105 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2107 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2108 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2109 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2111 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2114 Feel free to revert this if there is a good reason for the duplicate
2117 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2119 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2121 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2122 a class member instead of a local variable in the method.
2123 This lets us use it to get the view instances, for use in tests.
2124 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2125 beforeOnlineGlom(): Test some more details of the initial view.
2126 Again, this is not very useful.
2128 To really test gwt-glom we will need to start a local postgresql
2129 instance with local data, like the Glom tests in C++.
2131 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2133 pom.xml: Mention the LGPL license.
2135 * pom.xml: Add a licenses section.
2136 * COPYING.LESSER: Move this to COPYING, which
2137 previously contained the GPL. But gwt-glom is all LGPL.
2139 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2141 Add project information to README and pom.xml.
2143 * README: Add a brief description and mention some mvn
2145 * pom.xml: This extra information shows up in mvn site
2148 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2150 Use the latest java-libglom version.
2152 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2154 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2156 GwtTestOnlineGlom: Test a little more.
2158 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2159 protected rather than private, as suggested by the gwt-test-utils
2161 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2162 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2163 Test the initial visibility of the panels.
2165 However, this is not a very useful test.
2166 And I wonder how we should generally test using this idea for an
2167 activity/places app like ours where the real changes happen implicitly
2168 based on the history token/URL.
2170 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2172 Slight modification to *Mapper comments.
2174 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2175 (DataActivityMapper)
2176 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2178 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2180 Remove comments mentioning GIN because they are just copied from
2181 the example code and are apparently not helpful:
2182 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2183 Also change the mention of a class that is only in the example code.
2185 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2187 GwtTestOnlineGlom test: Minor changes.
2189 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2190 Avoid the long qualified class name and modify the comment
2191 because it is now obvious to me that the mocked class is the only
2192 custom one created via GWT.create().
2194 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2196 Tests: Added the beginnings of a test using gwt-test-utils.
2198 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2199 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2200 which tells gwt-test-utils what class will be tested.
2201 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2202 Add a simple (but empty) test case. One class, used by the OnlineGlom
2203 class, is mocked so that it can be created. However, I am not sure
2204 why only this class needs to be mocked.
2206 Note that mockito seems more popular, and clearer, than easymock,
2207 but I have not got that working yet. It might be a matter of the
2210 This test is run during mvn integration-test.
2212 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2214 Tests: Use junit4-style syntax instead of junit3-style.
2216 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2217 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2218 * src/test/java/org/glom/web/shared/DataItemTest.java:
2219 Use the @Test annotation rather than relying on the test*() prefix.
2220 Also no longer implement TestCase, to avoid triggering support for
2221 the junit3-way, which stops the annotations from working.
2222 Change the imports from import junit.framework.* to
2223 import org.junit.*, which is apparently the new way.
2225 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2227 Added a test for ListPlace token parsing and creation.
2229 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2230 This is much the same as DetailsPlaceTest.
2232 I wonder how we could test the other parts of the *Place API.
2234 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2236 DetailsPlace test: Also test getToken() and recreation via getPlace().
2238 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2239 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2240 recreate it, testing the recreated DetailsPlace for the same parameter
2243 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2245 Use the surefire-report plugin.
2247 * pom.xml: This generates a HTML report about the tests in
2248 target/site/surefire-report.html
2249 when you do mvn surefire-report:report. It seems to be popular/normal.
2251 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2253 Added a test for DetailsPlace.
2255 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2256 Test the getPlace() token parsing.
2258 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2260 Added a first unit test.
2262 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2263 * src/test/java/org/glom/web/shared/DataItemTest.java:
2264 This is a silly test but it is just to get things started. Note that
2265 maven/junit finds the test because it looks in src/test by default.
2267 2011-12-22 Ben Konrath <ben@bagu.org>
2269 Change charsetName to "UTF-8" when replacing line breaks.
2271 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2272 that work in Java (such as "UTF8") will not work when compiled to
2275 This fixes a problem with multi-line details view fields that have hard
2276 line breaks. The "License Text" field on this page demonstrates the
2279 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2281 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2283 2011-12-22 Ben Konrath <ben@bagu.org>
2285 Fix another bug with related list navigation.
2287 I've tested all the navigation buttons in all of the related lists
2288 so things should be good now.
2290 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2292 2011-12-22 Ben Konrath <ben@bagu.org>
2294 Fix a crasher when refreshing the list view with the default table.
2296 This crash will also happen when loading the list view with the default
2297 table from a link or bookmark.
2299 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2300 to the main document selection page when the document id hasn't been
2302 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2303 the main document selection page when the document id hasn't been
2305 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2306 values for the details place when the document id hasn't been set.
2307 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2308 values for the list place when the document id hasn't been set.
2310 2011-12-21 Ben Konrath <ben@bagu.org>
2312 Protect against NPE when glom.document.locale is not in config.
2314 This patch protects against an NPE when glom.document.locale is not in
2315 the config file. This NPE will also happen if glom.document.locale is
2318 The patch also updates the error message to display the class name when
2319 the getMessage() returns null. This was happening when the NPE was
2320 thrown and I had "Configuration Error: null". If an NPE is encountered
2321 with this patch, "Configuration Error: NullPointerException " will be
2324 This commit closes this bug:
2326 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2328 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2330 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2332 Rename onlineglom.properties to onlineglom.properties.sample.
2334 * src/main/resources/onlineglom.properties: Rename to:
2335 * src/main/resources/onlineglom.properties.sample:
2336 * src/main/resources/README: And add this file explaining that people
2337 should rename it back when deploying.
2339 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2341 Allow choosing the translation in the .properties file.
2343 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2344 init(): Read a glom.document.locale value from the configuration file
2345 and call Glom's TransatableItem::set_current_locale() method.
2346 * src/main/resources/onlineglom.properties: Add a commented-out
2347 example of this new setting.
2349 It would be better to add &lang=de_DE to the URL, but the current
2350 libglom API does not allow us to do this easily. I am working on that.
2352 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2354 Avoid a crash in parsing of token parameters.
2356 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2357 ava: getTokenParams(): Do not crash if a parameter has a key but no
2358 value, and ignore parameters with neither.
2360 2011-12-17 Murray Cumming <murrayc@murayc.com>
2362 History token building/handling: Improve use of token parameters.
2364 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2365 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2366 and buildParamsToken(HashMap), for use by derived classes.
2367 Make the separator private because it is no longer be needed.
2368 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2369 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2370 instead of manual string concatenation.
2371 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2372 of hardcoded indices and awkward splitting code.
2373 * src/main/java/org/glom/web/client/place/ListPlace.java
2374 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2375 instead of manual string concatenation.
2376 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2377 of hardcoded indices and awkward splitting code.
2378 This should fix bug #666420
2380 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2382 Fix a Navgiation->Navigation typo in the code.
2384 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2385 Rename processNavgiation() to processNavigation().
2387 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2389 Fix a seperator->separator typo in the code.
2391 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2392 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2393 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2396 2011-12-15 Ben Konrath <ben@bagu.org>
2398 Cleanup some comments.
2400 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2402 2011-12-14 Ben Konrath <ben@bagu.org>
2404 Replace \n with <br/> for multiline text in the details view.
2406 Vertical scrollbars are added when needed as well.
2408 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2410 2011-12-14 Ben Konrath <ben@bagu.org>
2412 Specify the font for document selection links.
2414 * src/main/webapp/style.css:
2416 2011-12-14 Ben Konrath <ben@bagu.org>
2418 Fix bouncy CellTable while paging.
2420 This doesn't currently work with related list tables in unselected
2423 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2425 2011-12-14 Ben Konrath <ben@bagu.org>
2427 Revamp the appearance of the document selection page.
2429 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2430 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2431 * src/main/webapp/style.css:
2433 2011-12-13 Ben Konrath <ben@bagu.org>
2435 Set navigation button column to the smallest size possible.
2437 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2439 2011-12-13 Ben Konrath <ben@bagu.org>
2441 Change OpenButton nomenclature to NavigationButton.
2443 Using NavigtionButton makes things more generic. Classes, methods and
2444 variables have been changed.
2446 This is a rename-only refactor.
2448 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2449 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2450 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2451 Renamed from OpenButtonCell.
2452 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2453 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2454 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2456 2011-12-12 Ben Konrath <ben@bagu.org>
2458 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2460 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2461 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2462 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2463 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2465 2011-12-12 Ben Konrath <ben@bagu.org>
2467 Update variable names and comments.
2469 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2470 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2472 2011-12-12 Ben Konrath <ben@bagu.org>
2474 Properly initialize numNonEmptyRows variable to zero.
2476 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2477 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2479 2011-12-05 Ben Konrath <ben@bagu.org>
2481 Add latest mockup with HTML tables.
2483 Features of this mockup:
2485 -> HTML table for flowtable
2486 -> HTML table for flowtable column
2487 -> Example of how related lists would look
2488 -> Not using text entries for data items
2490 The current version of Online Glom doesn't use HTML tables for the
2493 This mockup has been sent to the glom-devel mailing list but it's good
2494 to have it here as well.
2496 * mockups/details-view-html-tables.html:
2498 2011-12-05 Ben Konrath <ben@bagu.org>
2500 Remove unnecessary getPrimaryKeyField() method.
2502 getPrimaryKeyFieldForTable(String) has been renamed to
2503 getPrimaryKeyField(String).
2505 * src/main/java/org/glom/web/server/database/DBAccess.java:
2506 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2507 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2509 2011-12-05 Ben Konrath <ben@bagu.org>
2511 Add string representation of TypedDataItem value to conversion error message.
2513 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2514 message was extracted into its own method to avoid duplication.
2516 2011-12-05 Ben Konrath <ben@bagu.org>
2518 Add type checking to navigation primary key value creation.
2520 Create navigation primary key only if the expected type from the Glom
2521 document matches the type returned by the SQL query.
2523 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2525 2011-12-05 Ben Konrath <ben@bagu.org>
2527 Rename a couple of variables in RelatedListNavigation.
2529 This is a rename-only refactor.
2531 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2533 2011-12-05 Ben Konrath <ben@bagu.org>
2535 Move getListLayoutGroup() into getListViewLayoutGroup().
2537 This removes getListLayoutGroup(). It was only being called by
2538 getListViewLayoutGroup().
2540 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2542 2011-12-05 Ben Konrath <ben@bagu.org>
2544 Remove check for LayoutItem_Portal in list table method.
2546 This check is no longer necessary because the method isn't being used
2547 to create the LayoutItemPortal DTO.
2549 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2551 2011-12-05 Ben Konrath <ben@bagu.org>
2553 Properly support related list navigation.
2555 Navigation from the "Repository Analyzer -> Package Scans ->
2556 Dependencies" related table wasn't working because the primary key for
2557 related tables wasn't being set properly. This commit fixes the
2560 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2561 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2562 doesn't set the primary key properly for related list tables.
2563 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2564 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2565 useful for getting the primary key for list view tables and for related
2567 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2568 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2569 Move code to set the primary key for the table from the abstract
2570 ListDBAccess class to ListViewDBAccess as it's only correct for list
2572 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2573 Properly add primary key to related list tables.
2575 2011-12-02 Ben Konrath <ben@bagu.org>
2577 Properly set the horizontal alignment of fields.
2579 This fix is for both the list tables and the details view.
2581 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2582 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2583 to set the horizontal alignment of fields.
2585 2011-12-02 Ben Konrath <ben@bagu.org>
2587 Display currency codes in the details view.
2589 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2591 2011-12-02 Ben Konrath <ben@bagu.org>
2593 Avoid duplicate JNI call.
2595 JNI is not as efficient as pure Java and this is an easy (and small)
2598 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2599 Use previously retrieved value for whereClauseToTableName instead of
2602 2011-12-02 Ben Konrath <ben@bagu.org>
2604 Rename a couple of variables in RelatedListNavigation.
2606 This is a rename-only refactor.
2608 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2610 2011-12-02 Ben Konrath <ben@bagu.org>
2612 Indicate clearly that a mismatched primary key type is a bug.
2614 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2615 warning to error. Add 'This is a bug.' to message.
2617 2011-12-02 Ben Konrath <ben@bagu.org>
2619 Update / fix some comments.
2621 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2623 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2625 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2626 Fix comments. Add some TODOs.
2628 2011-12-02 Ben Konrath <ben@bagu.org>
2630 Enable navigation to details view with string primary key from related list.
2632 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2633 Create a text primary key value when return type of result is
2634 java.sql.Types.VARCHAR.
2636 2011-12-02 Ben Konrath <ben@bagu.org>
2638 Use checkboxes for booleans in the details view.
2640 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2642 2011-12-01 Ben Konrath <ben@bagu.org>
2644 Improve performance of related list height calculation.
2646 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2647 Put code to calculate the expected height in a static initializer so
2648 that that it's only called once.
2650 2011-12-01 Ben Konrath <ben@bagu.org>
2652 Show related list tables in notebooks (again).
2654 Calculate the height of the related list tables so the Notebook can be
2655 set the correct height. The height of the related list table is also needed by
2656 FlowTable to be able decide how to create the layout.
2658 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2659 and set the Portal height based on the height of the related list
2660 table and the Portal container.
2661 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2662 Add method to calculate the height of the related list tables.
2663 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2664 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2665 calculate the height of the Pager widget.
2667 2011-12-01 Ben Konrath <ben@bagu.org>
2669 Use CellTable API for table property instead of setting style on Element.
2671 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2673 2011-12-01 Ben Konrath <ben@bagu.org>
2675 Make ListViewTable and RelatedListTable a consistent height.
2677 The tables are now a consistent height regardless of the contents of
2678 the table. A hidden button is added to empty rows to ensure that the
2679 height of these rows will match the height of rows with data.
2681 A navigation button column is now added to every table. The width of
2682 the navigation column is set to 0px when a RelatedListTable shouldn't
2683 have navigation buttons. This maintains the a consistent row height in
2684 tables that don't show the navigation buttons.
2686 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2687 navigation column when not needed.
2688 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2689 arguments for navigation button to constructor of ListViewTable.
2690 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2691 hidden button for empty data rows.
2692 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2693 arguments for navigation button to constructor.
2694 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2695 create navigation buttons. Add hideNavigationButtons() method.
2696 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2697 arguments for navigation button to constructor.
2699 2011-12-01 Ben Konrath <ben@bagu.org>
2701 Use 'visibility: hidden' in Utils.getWidgetHeight().
2703 This is better choice because hidden elements are invisible, don't
2704 respond to events and are not part of the tab order. They will,