1 2012-05-04 Murray Cumming <murrayc@murrayc.com>
3 Remove use of unsupported features from client code.
5 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
6 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
7 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
8 Use our client version of StringUtils instead of the apache commons one.
10 However, the GWT Javascript compliation still fails.
12 2012-04-25 Murray Cumming <murrayc@murrayc.com>
14 Add a Field class and implement some loading of it in Document.
16 2012-04-25 Murray Cumming <murrayc@murrayc.com>
18 Initial Document loading implementation, instead of libglom.
20 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
21 and Translatable classes, and adapt the rest of the code to use them.
22 However, this is still missing Layout and Field classes and loading.
24 2012-04-24 Murray Cumming <murrayc@murrayc.com>
26 Use of jOOQ: Move Field creation into a utility method.
28 * src/main/java/org/glom/web/server/SqlUtils.java:
29 This lets us improve it more easily.
31 2012-04-24 Murray Cumming <murrayc@murrayc.com>
33 Use of jOOQ: Improve the code to COUNT a sub-select.
35 * src/main/java/org/glom/web/server/SqlUtils.java:
36 Move initial query creation into
37 build_sql_select_step_with_where_clause().
38 build_sql_select_count_rows(): Use the jOOQ API instead of
39 concatentating text, because a jOOQ Select*Step is a TableLike,
40 which is what from() takes.
42 2012-04-23 Murray Cumming <murrayc@murrayc.com>
44 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
46 * pom.xml: Depend on jooq.
47 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
48 methods with jOOQ, based on the C++ implementations in libglom,
49 with some changes to the logic required by jooQ.
50 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
52 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
53 * src/main/java/org/glom/web/server/ReportGenerator.java:
54 * src/main/java/org/glom/web/server/SqlUtils.java:
55 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
56 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
57 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
58 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
59 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
60 Adapt. In particular, the SqlUtils methods now need to take a Connection,
61 because jOOQ needs that, though it seems unnecessary.
63 This is not quite finished. Ideally jOOQ would help us to build
64 table_name.field_name names, quoting and escaping them properly.
65 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
67 2012-04-21 Murray Cumming <murrayc@murrayc.com>
69 Move use of Glom.build_sql*() into a new SqlUtils class.
71 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
72 to wrap Glom.build_sql*(). The parameter types are still Glom one,
73 but this will make it easier to start using something other than
74 libglom or SqlBuilder.
76 2012-04-21 Murray Cumming <murrayc@murrayc.com>
78 Update the project URL.
80 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
82 2012-04-21 Murray Cumming <murrayc@murrayc.com>
84 Main layout: Use a FlowTable instead of absolute positioning.
86 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
87 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
88 child panels/widgets must have an absolute position. But that is annoying, so
89 this adds a FlowTable and puts the child panels in there.
91 2012-04-21 Murray Cumming <murrayc@murrayc.com>
93 GwtTestOnlineGlom: Comment out unused code.
95 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
96 Eclipse has started to say that some code is unused.
98 2012-04-21 Murray Cumming <murrayc@murrayc.com>
100 Update to the latest versions of dependencies.
102 * pom.xml: Update version numbers of dependencies to the latest
104 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
105 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
106 * src/main/java/org/glom/web/server/ReportGenerator.java:
107 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
108 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
109 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
111 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
112 Modify the imports where necessary.
114 2012-04-17 Murray Cumming <murrayc@murrayc.com>
116 Style: Remove overflow:hidden from searchbox
118 * src/main/webapp/style.css: Because this pushes the Back To Link
119 label/link on to the next row, which is then hidden due to the
120 hard-coded (in ems) height.
122 2012-04-20 Murray Cumming <murrayc@murrayc.com>
124 Remove some duplicate code.
126 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
127 getDocumentInfo(): This must have been duplicated during the merge from the
132 2012-04-19 Murray Cumming <murrayc@murrayc.com>
134 Reports: Localize the waiting for report message.
136 * src/main/java/org/glom/web/client/activity/ReportActivity.java
137 start(): Get the message from the contants.
138 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
140 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
141 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
142 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
143 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
144 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
145 Update these files with the English text for newer strings for now.
147 2012-04-19 Murray Cumming <murrayc@murrayc.com>
149 Reports: Show a message while waiting for the report.
151 * src/main/java/org/glom/web/client/ui/ReportView.java
152 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
153 Add setWaitingText(), to show a message saying that we are
154 waiting for the report to be ready.
155 * src/main/java/org/glom/web/client/activity/ReportActivity.java
156 start(): Call setWaitingText() before calling the async
159 2012-04-19 Murray Cumming <murrayc@murrayc.com>
161 ReportGenerator: Specify date and time formats.
163 * src/main/java/org/glom/web/server/ReportGenerator.java:
164 createFieldValueElement(): Use the default (and localized)
165 short formats, though we still need a way to show 4-digit
166 years without providing the format for every locale.
167 * src/main/java/org/glom/web/server/database/DBAccess.java:
168 convertResultSetToDTO(): Use the short formats here too.
170 2012-04-18 Murray Cumming <murrayc@murrayc.com>
172 ReportGenerator: Use the correct numeric formatting.
174 * src/main/java/org/glom/web/server/ReportGenerator.java
175 createFieldExpression(), createFieldValueElement(): Take the
176 whole LayoutItem_Field instead of just the field name, so
177 we have access to the formatting.
178 createFieldValueElement(): Use JRTextField.setPattern() to
179 specify the numeric formatting, with the help of a
180 regular DecimalFormat.
182 2012-04-18 Murray Cumming <murrayc@murrayc.com>
184 ReportGenerator: Avoid showing null for group by titles.
186 * src/main/java/org/glom/web/server/ReportGenerator.java
187 generateReport(): Use setBlankWhenNull() on the field title
188 style too, because this is used for values in group by
191 2012-04-18 Murray Cumming <murrayc@murrayc.com>
193 ReportGenerator: Add a colon to titles in vertical groups.
195 * src/main/java/org/glom/web/server/ReportGenerator.java
196 addFieldToDetailBandVertical(): Pass true for the withColon
199 2012-04-18 Murray Cumming <murrayc@murrayc.com>
201 ReportGenerator: Simplify the code by using Position more.
203 2012-04-18 Murray Cumming <murrayc@murrayc.com>
205 Reports: Support vertical groups, roughly.
207 * src/main/java/org/glom/web/server/ReportGenerator.java:
208 addToReport(): Rename to addGroupToReport() and, if necessary,
209 call the new addVerticalGroupToReport() method.
210 createFieldValueElement(): Let the caller specify the Y position
213 2012-04-17 Murray Cumming <murrayc@murrayc.com>
215 Reports: Allow a second report to be shown.
217 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
218 clear(): Do not remove the HTML widget, which broke the whole layout.
220 2012-04-17 Murray Cumming <murrayc@murrayc.com>
222 Locales drop-down: Show that we use English by default.
224 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
225 fillView(): When we use English, just because that is the default, when
226 no locale is specified, show that in the Locales drop-down instead of
227 just showing the first item.
229 2012-04-17 Murray Cumming <murrayc@murrayc.com>
231 Unselect the Report/Locale/Table combo item when appropriate.
233 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
234 setPlace(): clear reportName if this is not a ReportPlace.
235 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
236 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
237 When the provided name is empty, unselect all items, so that none are
238 indicated. This uses a for loop because I cannot find a single method
241 2012-04-17 Murray Cumming <murrayc@murrayc.com>
243 Report: Give the user a way to get back to the list.
245 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
246 start(), setPlace(): Show the Back To List link on reports, and also
247 interpret selecting the empty report item as back to list.
249 2012-04-13 Murray Cumming <murrayc@murrayc.com>
251 Really show the selected Report name.
253 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
254 setPlace(): Store the reportName here, if it is that kind of Place.
255 fillView(): Set the selected Report after filling the list of reports.
256 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
257 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
258 null Strings, though we need some way to unselect all ListBox items
261 2012-04-13 Murray Cumming <murrayc@murrayc.com>
263 ReportGenerator: Try to avoid some problems.
265 * src/main/java/org/glom/web/server/ReportGenerator.java
266 addField(): Try to avoid duplicates, and avoid using a null
269 2012-04-13 Murray Cumming <murrayc@murrayc.com>
271 Reports: Use quickFind.
273 * src/main/java/org/glom/web/client/OnlineGlomService.java;
274 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
275 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
276 getReportHTML(): Add a quickFind parameter.
277 * src/main/java/org/glom/web/client/activity/ReportActivity.java
278 start(): Pass the quickFind parameter.
279 * src/main/java/org/glom/web/server/ReportGenerator.java
280 generateReport(): Take a quickFind parameter.
282 2012-04-13 Murray Cumming <murrayc@murrayc.com>
284 ReportPlace: Actually use the report name.
286 * src/main/java/org/glom/web/client/place/ReportPlace.java
287 getPlace(): Do not assign the report name to the quickfind.
289 2012-04-13 Murray Cumming <murrayc@murrayc.com>
291 Show java.library.path when complaining.
293 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
294 init(): When telling us to check java.library.path, show the
297 2012-03-06 Murray Cumming <murrayc@murrayc.com>
299 ReportGenerator: Do not show nulls.
301 2012-03-06 Murray Cumming <murrayc@murrayc.com>
303 ReportGenerator: Make the title font larger.
305 2012-03-06 Murray Cumming <murrayc@murrayc.com>
307 ReportGenerator: Put field titles inside groups, if there are groups.
309 2012-03-06 Murray Cumming <murrayc@murrayc.com>
311 ReportGenerator: Take the Report itself instead of the name and group.
313 * src/main/java/org/glom/web/server/ConfiguredDocument.java
314 Remove getReportLayoutGroup().
315 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
316 getReportHTML(): Pass the report instead
317 of its name and layout group.
318 * src/main/java/org/glom/web/server/ReportGenerator.java
319 generateReport(): Use the report object to use the title
322 2012-03-06 Murray Cumming <murrayc@murrayc.com>
324 ReportGenerator: Remove designBand parameters.
326 * src/main/java/org/glom/web/server/ReportGenerator.java:
327 Make designBand a class member instead of passing it to all
330 2012-03-06 Murray Cumming <murrayc@murrayc.com>
332 ReportGenerator: Add lines, a bit like in the desktop version.
334 * src/main/java/org/glom/web/server/ReportGenerator.java
335 addToReport(): Use JRDesignLine.
337 2012-03-06 Murray Cumming <murrayc@murrayc.com>
339 ReportGenerator: Correct the title positions and use some bold style.
341 * src/main/java/org/glom/web/server/ReportGenerator.java:
342 Break the code up into reusable functions, correct the placement of
343 titles, and use normal/bold styles as in the reports in the desktop
346 2012-03-06 Murray Cumming <murrayc@murrayc.com>
348 ReportGenerator: Add a header band to show the field titles.
350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
351 getReportHTML(): Pass the localeId to the ReportGenerator
353 * src/main/java/org/glom/web/server/ReportGenerator.java
354 constructor: Take the localeID so we can get translated field
356 generateReport(), addToReport(), addFieldToBand(): Add field
357 titles in a column header band.
359 2012-03-05 Murray Cumming <murrayc@murrayc.com>
361 Reports drop-down list: Some improvement.
363 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
364 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
365 Adedd setSelectedReport(),
366 setReportList(): Add a blank line so that the user can select the
368 * src/main/java/org/glom/web/client/activity/ReportActivity.java
369 start(): Show the current report by calling setSelectedReport().
370 This does not seem to work yet.
372 2012-03-05 Murray Cumming <murrayc@murrayc.com>
374 DetailsActivity, ListActivity: Move some variables into a base class.
376 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
377 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
378 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
379 the clientFactory, documentID, tableName and authenticationPopup into
380 a base class, to avoid duplication.
382 2012-03-05 Murray Cumming <murrayc@murrayc.com>
384 Translate the Reports label.
386 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
387 Get the "Reports" label string from the constants.
388 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
389 perties: Add Reports to the constants.
391 2012-03-05 Murray Cumming <murrayc@murrayc.com>
393 Reports: Implement grouping.
395 * src/main/java/org/glom/web/server/ReportGenerator.java:
396 Handle LayoutItem_GroupBy items and try to do the right thing
397 with JRDesignGroup. It seems to work.
399 2012-03-04 Murray Cumming <murrayc@murrayc.com>
401 Actually show some data with JasperReports.
403 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
404 getReportHTML(): Move most code into a ReportGenerator class.
405 * src/main/java/org/glom/web/server/ReportGenerator.java:
406 Recurse into sub-groups, adding fields to the JasperDesign's details
407 band. Note that we must set an arbitrary width and height, or it just
408 will not show any data.
410 2012-03-04 Murray Cumming <murrayc@murrayc.com>
412 Reports Chooser: Show the titles, not the names.
414 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
415 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
416 and the names as the values.
417 * src/main/java/org/glom/web/server/ConfiguredDocument.java
418 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
419 group now that we provide the report name, so it should always
422 2012-02-15 Murray Cumming <murrayc@murrayc.com>
424 Depend on jasperreports.
426 * pom.xml: Add the dependency. My plan is to use this on the
429 2012-01-31 Murray Cumming <murrayc@murrayc.com>
431 Implement navigation to report places.
433 * src/main/java/org/glom/web/client/activity/ReportActivity.java
434 start(): Do not bother to handle all events here.
435 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
436 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
437 Added getSelectedReport().
438 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
439 .java: start(): When handling a change to the reports chooser,
440 call getSelectedReport() and goTo() its ReportPlace.
441 * src/main/java/org/glom/web/client/ui/ReportView.java
442 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
443 Added setReportHTML() which puts the html in a gwt HTML widget.
444 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
445 getReportHTML(): Return "TODO" just to show that this works.
447 2012-01-31 Murray Cumming <murrayc@murrayc.com>
449 Make ReportPlace usable.
451 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
453 * src/main/java/org/glom/web/client/place/ReportPlace.java:
454 Correct the @prefix annotation.
456 2012-01-31 Murray Cumming <murrayc@murrayc.com>
458 OnlineGlomService: Return report HTML rather than the LayoutGroup.
460 * src/main/java/org/glom/web/client/OnlineGlomService.java:
461 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
462 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
463 Change getReportLayout() to getReportHMTL() because we will not need to
464 parse or render the report layout on the client side.
465 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
466 getReportLayout(): Return the libglom LayoutGroup type because we will
467 not need to convert to a shared type, because this will not be used on
469 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
472 Note that there is still no implementation for this.
475 2012-01-27 Murray Cumming <murrayc@murrayc.com>
477 Add a (empty) Report Place, View, and Activity.
479 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
481 * src/main/java/org/glom/web/client/place/HasTablePlace.java
482 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
483 this into a superclass:
484 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
485 and also use it as the base of this new ReportPlace:
486 * src/main/java/org/glom/web/client/place/ReportPlace.java
488 * src/main/java/org/glom/web/client/ui/ReportView.java
489 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
490 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
491 Add these, containing mostly boiler-plate for now.
493 * src/main/java/org/glom/web/client/OnlineGlomService.java
494 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
495 * src/main/java/org/glom/web/server/ConfiguredDocument.java
496 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
497 Add API to get the LayoutGroup for the report.
499 2012-01-23 Murray Cumming <murrayc@murrayc.com>
501 Add and fill a Reports drop-down list box.
503 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
505 * src/main/java/org/glom/web/client/OnlineGlomService.java:
506 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
507 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
508 Added getReports(document, table, localeID), calling
509 ConfiguredDocument.getReports().
510 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
511 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
512 Added setReportsList() and a list widget.
513 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
514 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
519 2012-04-12 Murray Cumming <murrayc@murrayc.com>
521 Translations: Add Esperanto.
523 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
524 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
525 properties: Add this translation because someone took the time to make it.
527 2012-03-15 Murray Cumming <murrayc@murrayc.com>
529 Adapt to the java-libglom 1.21.7 API.
531 * src/main/java/org/glom/web/server/ReportGenerator.java:
532 addToReport(): get_group_secondary_fields() is now
533 get_secondary_fields().
536 2012-03-15 Murray Cumming <murrayc@murrayc.com>
538 Use the latest java-libglom version.
540 * pom.xml: Use java-libglom 1.21.7.
542 2012-03-03 Ben Konrath <ben@bagu.org>
544 Display date and time in details view.
546 https://bugzilla.gnome.org/show_bug.cgi?id=671257
548 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
550 2012-03-05 Murray Cumming <murrayc@murrayc.com>
552 Require the latest java-libglom.
554 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
556 2012-03-04 Murray Cumming <murrayc@murrayc.com>
558 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
560 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
561 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
562 an empty quickfind string. I also corrected libglom to create only
563 empty where clauses for empty quickfind strings, but this avoids the
566 2012-02-24 Ben Konrath <ben@bagu.org>
568 Improve the tabs in the Notebook widget.
572 2012-01-30 Murray Cumming <murrayc@murrayc.com>
574 Translations: Try to translate the strings.
576 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
577 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
578 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
579 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
580 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
581 Take the Open translation from GTK+'s .po files.
582 Take the Details translation from Glom's po files.
583 I have added the other strings to Glom so we can get translations that way:
584 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
586 2012-01-27 Murray Cumming <murrayc@murrayc.com>
588 TableSelectionViewImpl: Put the search label and entry in a div.
590 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
591 Put the search widgets in a FlowTable so that the CSS can be used to
592 style them while keeping them together.
593 * src/main/webapp/style.css: Mention the new div.
595 2012-01-27 Murray Cumming <murrayc@murrayc.com>
597 Translate more strings in more locales.
599 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
600 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
601 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
602 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
603 Translate the "Details" and "Open" string too.
605 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
606 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
607 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
608 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
609 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
610 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
611 Add these new locales as placeholders though they currently contain English.
613 2012-01-27 Murray Cumming <murrayc@murrayc.com>
615 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
617 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
618 Check the ConfiguredDocument* for null before using it.
620 2012-01-26 Murray Cumming <murrayc@murrayc.com>
622 Tell Eclipse about the generated java files.
624 * .classpath: This lets it find OnlineGlomConstants.java.
625 It would be nice if Eclipse just used the maven build files.
627 2012-01-26 Murray Cumming <murrayc@murrayc.com>
629 Prevent a crash when no locale is specified in the URL.
631 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
632 Avoid returning a null string, obtained from
633 Window.Location.getParameter(). This caused a crash when it was
634 later passed to libglom's API.
635 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
636 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
637 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
638 guard against future null strings.
640 2012-01-26 Murray Cumming <murrayc@murrayc.com>
642 Use the ?locale= query param instead of the &lang= token param.
644 * src/main/java/org/glom/web/client/place/ListPlace.java
645 * src/main/java/org/glom/web/client/place/DetailsPlace.java
646 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
647 Remove the lang token key and value.
649 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
650 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
651 When the user selects a different locale from the chooser, use
652 Window.Location.assign() to change the URL, which then causes a reload.
654 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
655 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
656 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
657 * src/main/java/org/glom/web/client/activity/ListActivity.java
658 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
659 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
660 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
661 * src/main/java/org/glom/web/client/ui/ListView.java:
662 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
664 Remove localeID member variables and method/constructor parameters, instead
665 using Utils.getCurrentLocaleID() when we need a localID to pass to
668 2012-01-26 Murray Cumming <murrayc@murrayc.com>
670 Internationalize the UI strings.
672 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
673 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
674 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
675 because it is unused. Messages are apparently strings that can have
676 parameters, but we do not need that yet, so Contants will be enough for now.
677 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
678 to say that we support the en and de locales.
679 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
680 The original English strings.
681 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
682 Some German translations of the English strings.
683 The i18n goal then uses the .properties file to generate an
684 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
685 returns an implementation that returns the translated strings.
686 The documentation suggests putting these in src/java/*/client/, but it seems
687 best to put it in src/resources/*/client/.
688 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
689 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
690 instead of hard-coding them.
691 Note that we cannot import OnlineGlomConstants because it does not exist yet,
692 but that does not seem to stop the build, though it confuses Eclipse.
694 You can see the translated string by adding ?locale=de to the URL, like so:
695 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
697 2012-01-24 Murray Cumming <murrayc@murrayc.com>
699 Improve null/empty String checks.
701 * pom.xml: Add a dependency on commons-lang, to use
702 org.apache.commons.lang.StringUtils.
703 * src/main/java/org/glom/web/server/ConfiguredDocument.java
704 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
705 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
706 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
707 Use StringUtils.isEmpty().
709 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
710 StringUtils class with a static isEmpty() function because we
711 cannot use org.apache.commons.lang.StringUtils in client-side
712 GWT code because it (apparently) cannot be compiled to javascript.
713 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
714 * src/main/java/org/glom/web/client/activity/ListActivity.java
715 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
716 * src/main/java/org/glom/web/client/place/DetailsPlace.java
717 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
718 * src/main/java/org/glom/web/client/place/ListPlace.java
719 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
720 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
721 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
722 * src/main/java/org/glom/web/client/ui/details/Group.java
723 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
724 our StringUtils.isEmpty() function.
726 2012-01-24 Murray Cumming <murrayc@murrayc.com>
728 Update to the latest java-libglom API.
730 * pom.xml: Require java-libglom 1.21.4.
731 * src/main/java/org/glom/web/server/ConfiguredDocument.java
732 getDocumentInfo(), getListViewLayoutGroup():
733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
735 * src/main/java/org/glom/web/server/database/DBAccess.java
736 getFieldsToShowForSQLQueryAddGroup(),
737 getPrimaryKeyLayoutItemField(): Replace get_database_title()
738 with either get_database_title_original() or
739 get_database_title(localeID).
741 2012-01-24 Murray Cumming <murrayc@murrayc.com>
743 ConfiguredDocument: Avoid a null pointer exception.
745 * src/main/java/org/glom/web/server/ConfiguredDocument.java
746 Initialize localeID to "" to avoid returning a null String which
747 causes a crash in java-libglom's swing-generated code.
749 2012-01-23 Murray Cumming <murrayc@murrayc.com>
751 Some simple renaming.
753 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
754 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
755 for localeChooser. This seems more appropriate and is less ambiguous
756 particularly in the .css file.
758 2012-01-23 Murray Cumming <murrayc@murrayc.com>
760 ConfiguredDocument: Rename the localedID private member variable.
762 2012-01-23 Murray Cumming <murrayc@murrayc.com>
764 Adapt to the latest java-libglom API from git master.
766 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
767 libglom now uses only Vector instead of List, which uses add() instead of
770 2012-01-22 Murray Cumming <murrayc@murrayc.com>
772 ConfiguredDocument: Rename the localedID private member variable.
774 2012-01-20 Murray Cumming <murrayc@murrayc.com>
776 Build a source tarball with mvn assembly:single
778 * assembly.xml: Add this file.
779 * pom.xml: Use the maven-assembly-plugin and tell it to use
780 our assembly.xml file.
782 2012-01-19 Murray Cumming <murrayc@murrayc.com>
784 OnlineGlomServiceImpl: Get .glom files recursively.
786 * pom.xml: Depend on commons-io from org.apache.commons.
787 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
788 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
789 files recursively, and with the easier filter for the extension.
790 Use org.apache.commons.io.FilenameUtils.removeExtension() to
791 simplify that code too.
793 2012-01-19 Murray Cumming <murrayc@murrayc.com>
795 README: Mention that you must install java-libglom packages separately.
797 But then it works, because java-libglom is now in the central maven
800 2012-01-18 Murray Cumming <murrayc@murrayc.com>
802 locales drop-down: Show the correct selected locale when the URL changes.
804 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
805 .java: setPlace(): Move some code into fillView().
807 2012-01-18 Murray Cumming <murrayc@murrayc.com>
809 locales drop-down: Do not lose the primary key.
811 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
812 start(): onLocaleChange(): Pass the current primary key value,
813 instead of an empty value.
815 2012-01-18 Murray Cumming <murrayc@murrayc.com>
817 locales drop-down: Do not lose the drop-down selection.
819 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
820 .java (TableSelectionActivity.fillView): Set the selected locale
821 after changing the drop-down items (though we do not really need
822 to change them just because the locale changes.)
824 2012-01-18 Murray Cumming <murrayc@murrayc.com>
826 locales drop-down: Change the tables list when this changes.
828 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
829 .java: TableSelectionActivity.start(): Move the async table titles
830 retrieval into a private fillView() method and also call this when
831 the chosen locale changes.
832 Note that the document title is not actually translatable yet, but
833 that is a problem that I should fix soon in libglom.
835 2012-01-18 Murray Cumming <murrayc@murrayc.com>
837 Improve the placement of the locales drop-down.
839 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
840 Put the title and locales drop-down in a div (gwt.FlowTable).
841 * src/main/webapp/style.css: Add magic css properties to make this work.
842 Also remove the left margin from the title so that it lines up with the
845 2012-01-18 Murray Cumming <murrayc@murrayc.com>
847 locales selector: Show human-readable locale titles.
849 * src/main/java/org/glom/web/server/ConfiguredDocument.java
850 getDocumentInfo(): Use java.util.Locale to show a real title of
851 each locale, in the locale's own language.
853 2012-01-17 Murray Cumming <murrayc@murrayc.com>
855 Add a language/locale selector drop-down.
857 * src/main/java/org/glom/web/shared/DocumentInfo.java:
858 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
859 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
860 getDocumentInfo(): Store the available Locales in the DocumentInfo.
861 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
862 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
863 Add a ListBox to show the available locales. Add getLocaleSelector(),
864 setLocaleList(), getSelectedLocale(), setSelectedLocale().
865 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
866 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
867 java: Add these classes.
868 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
869 start(): Fill the locales ListBox. Handle its change event, firing a
871 setPlace(): Show the selected locale as specified by the URL token.
872 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
873 * src/main/java/org/glom/web/client/activity/ListActivity.java:
874 Handle LocaleChangeEvent, going to a new *Place with that locale.
876 The placement of the ListBox is not pretty, and it currently uses the ID
877 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
881 2012-01-17 Murray Cumming <murrayc@murrayc.com>
883 Search box: Show the search text from the URL token.
885 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
886 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
887 Add setQuickFindText().
888 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
889 .java: setPlace(): Store the queryText if the place is a ListPlace,
890 and call TableSelectionView.setQuickFindText().
892 2012-01-17 Murray Cumming <murrayc@murrayc.com>
894 Allow use of translations via, for instance, &lang=de in the URL.
896 * pom.xml: Use the unstable java-libglom 1.21 version.
898 * src/main/java/org/glom/web/client/OnlineGlomService.java:
899 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
900 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
901 init(): Instead of calling TranslatableItem.set_current_locale()
902 (now removed), call ConfiguredDocument.setDefaultLocaleID().
903 However, this is only for default locales, which are not needed to
904 change the locale in the URL.
905 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
906 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
907 getSortedRelatedListData(): Add a localeID parameter, so we can get the
908 layout for a particular locale.
909 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
910 Add get/setDefaultLocaleID().
911 getDocumentInfo(), getListViewData(), getRelatedListData(),
912 getDetailsLayoutGroup(), getListViewLayoutGroup(),
913 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
914 localeID parameter, so we can get the layout for a particular locale.
916 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
917 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
918 * src/main/java/org/glom/web/client/place/ListPlace.java:
919 Parse and construct a lang parameter too.
921 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
922 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
923 passed to subsequent methods and constructors.
924 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
925 * src/main/java/org/glom/web/client/activity/ListActivity.java:
926 Store the localeID from the *Place and pass it to other constructors
927 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
929 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
930 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
931 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
932 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
933 * src/main/java/org/glom/web/client/ui/ListView.java:
934 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
935 Take localeID parameters and pass them to subsequent constructors and
936 methods, so that the layout is always retrieved for that locale.
938 This is rather repetitive.
940 Note that "" means the original (default) locale of the Glom document,
941 which is usually English.
943 2012-01-17 Murray Cumming <murrayc@murrayc.com>
945 Documents: Remove final keyword to fix startup configuration.
947 * src/main/java/org/glom/web/shared/Documents.java: Remove the
948 final keywords on the private member variables because that breaks
949 the startup, apparently (there are warnings) because it stops them
950 from being serialized. I added these in the previous commit.
952 2012-01-13 Murray Cumming <murrayc@murrayc.com>
954 Documents: Add some final keywords.
956 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
959 2012-01-13 Murray Cumming <murrayc@murrayc.com>
961 OnlineGlomServiceImpl: Add to overview comments.
963 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
964 Note that this is where all the document are loaded. They are not
965 loaded freshly for each page.
967 2012-01-12 Murray Cumming <murrayc@murrayc.com>
971 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
972 Add a TextBox for the text of a quick find.
973 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
975 setBackLink(): Add a String quickFind parameter.
976 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
977 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
978 to the base interface, because that is how TableSelectionViewImpl is used.
979 * src/main/webapp/style.css: Add style for the search box and its label.
981 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
982 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
983 Add these files, based on the existing TableChangeEvent and
984 TableChangeEventHandlers.
985 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
986 start(): Handle QuickFindChangeEvent, passing its quickFind text to
987 a ListPlace() that the user should be taken to.
988 * src/main/java/org/glom/web/client/activity/ListActivity.java
989 start(): Handle it here too and adapt the TableChangeEvent handler to
990 pass the extra "" quickFind parameter to ListPlace.
991 * src/main/java/org/glom/web/client/place/ListPlace.java:
992 Constructor: Take an extra String quickFind parameter and store it,
993 returning it from a new getQuickFind() method.
994 getToken(): Put the quickFind text in the URL token.
995 getPlace(): Parse the quickFind text from the URL token.
996 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
997 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
998 ListPlace constructor.
999 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1000 .java: start(): Add a Change handler for the TableSelectionView's
1001 TextBox (via its base HasChangeHandlers interface), firing the new
1002 QuickFindChangeEvent.
1003 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1004 pass the extra "" quickFind parameter.
1006 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1007 setCellTable(): Add a String quickFind parameter and pass it to
1008 the ListViewTable() constructor.
1009 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1010 setCellTable() in the base interface, because that is how ListViewImpl
1013 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1014 Add a String quickFind member variable.
1015 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1016 Constructor: Add a String quickFind parameter, storing it in the
1017 base ListTable's member variable.
1018 onRangeChanged(): Pass quickFind to the
1019 OnlineGlomServiceAsync.getSortedListViewData() and
1020 OnlineGlomServiceAsync.getListViewData() methods.
1022 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1023 getListViewData(), getSortedListViewData(): Add a String quickFind
1024 parameter, passing it to ConfiguredDocument.getListViewData().
1025 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1026 Change getListViewData(), getSortedListViewData() in the base interface,
1027 because that is how OnlineGlomServiceImpl is used, via this:
1028 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1029 Change getListViewData(), getSortedListViewData() here too.
1030 This class can apparently be used to asynchronously call methods on
1031 OnlineGlomService, and GWT seems to implement that after recognizing
1032 just the *Async name convention and the extra AsyncCallback parameters.
1034 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1035 getListViewData(): Add a String quickFind parameter, and pass it to
1036 ListViewDBAccess.getData().
1037 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1038 getListData(): Add a String quickFind parameter and pass it to
1040 getSelectQuery(): Add a String quickFind parameter.
1041 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1042 getSelectQuery(): Add a String quickFind parameter and use it with
1043 Glom.get_find_where_clause_quick() to pass a where_clause to
1044 Glom.build_sql_select_with_where_clause(), to actually filter the
1046 getData(): Add a String quickFind parameter, passing it to getListData().
1047 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1048 va: getData(): Pass an empty string to getListData() for the
1049 quickFind parameter.
1051 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1053 ListTable: Minor change.
1055 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1056 createCellTable(): Make this protected instead of public.
1058 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1060 Many files: Use final for the parameters and use the @override attribute.
1062 2012-01-22 Ben Konrath <ben@bagu.org>
1064 Add anchor links for single line text that starts with http, ftp and www.
1068 2012-01-22 Ben Konrath <ben@bagu.org>
1070 Add ellipsis to single line text in details view.
1074 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1076 Remove all javadoc author tags.
1078 Because they are awkward and meaningless when many people touch
1080 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1082 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1084 Revert the COPYING.LESSER to COPYING rename.
1086 Apparently both should be there if it is LGPL.
1088 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1090 *View: Remove unused imports.
1092 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1093 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1094 * src/main/java/org/glom/web/client/ui/ListView.java:
1095 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1096 Remove unused imports, as suggested by Eclipse.
1098 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1100 Move the *View::Presenter types, and some API into one base View.
1102 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1103 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1104 * src/main/java/org/glom/web/client/ui/ListView.java:
1105 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1106 Presenter, setPresenter() and clear() into a shared base interface,
1107 to avoid the unnecessary duplicate Presenter types and to more clearly
1108 show how the *Views share the same structure, even if they are not
1109 used polymorphically.
1111 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1112 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1114 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1115 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1116 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1118 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1121 Feel free to revert this if there is a good reason for the duplicate
1124 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1126 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1128 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1129 a class member instead of a local variable in the method.
1130 This lets us use it to get the view instances, for use in tests.
1131 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1132 beforeOnlineGlom(): Test some more details of the initial view.
1133 Again, this is not very useful.
1135 To really test gwt-glom we will need to start a local postgresql
1136 instance with local data, like the Glom tests in C++.
1138 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1140 pom.xml: Mention the LGPL license.
1142 * pom.xml: Add a licenses section.
1143 * COPYING.LESSER: Move this to COPYING, which
1144 previously contained the GPL. But gwt-glom is all LGPL.
1146 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1148 Add project information to README and pom.xml.
1150 * README: Add a brief description and mention some mvn
1152 * pom.xml: This extra information shows up in mvn site
1155 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1157 Use the latest java-libglom version.
1159 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1161 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1163 GwtTestOnlineGlom: Test a little more.
1165 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1166 protected rather than private, as suggested by the gwt-test-utils
1168 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1169 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1170 Test the initial visibility of the panels.
1172 However, this is not a very useful test.
1173 And I wonder how we should generally test using this idea for an
1174 activity/places app like ours where the real changes happen implicitly
1175 based on the history token/URL.
1177 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1179 Slight modification to *Mapper comments.
1181 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1182 (DataActivityMapper)
1183 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1185 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1187 Remove comments mentioning GIN because they are just copied from
1188 the example code and are apparently not helpful:
1189 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1190 Also change the mention of a class that is only in the example code.
1192 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1194 GwtTestOnlineGlom test: Minor changes.
1196 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1197 Avoid the long qualified class name and modify the comment
1198 because it is now obvious to me that the mocked class is the only
1199 custom one created via GWT.create().
1201 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1203 Tests: Added the beginnings of a test using gwt-test-utils.
1205 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1206 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1207 which tells gwt-test-utils what class will be tested.
1208 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1209 Add a simple (but empty) test case. One class, used by the OnlineGlom
1210 class, is mocked so that it can be created. However, I am not sure
1211 why only this class needs to be mocked.
1213 Note that mockito seems more popular, and clearer, than easymock,
1214 but I have not got that working yet. It might be a matter of the
1217 This test is run during mvn integration-test.
1219 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1221 Tests: Use junit4-style syntax instead of junit3-style.
1223 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1224 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1225 * src/test/java/org/glom/web/shared/DataItemTest.java:
1226 Use the @Test annotation rather than relying on the test*() prefix.
1227 Also no longer implement TestCase, to avoid triggering support for
1228 the junit3-way, which stops the annotations from working.
1229 Change the imports from import junit.framework.* to
1230 import org.junit.*, which is apparently the new way.
1232 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1234 Added a test for ListPlace token parsing and creation.
1236 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1237 This is much the same as DetailsPlaceTest.
1239 I wonder how we could test the other parts of the *Place API.
1241 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1243 DetailsPlace test: Also test getToken() and recreation via getPlace().
1245 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1246 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1247 recreate it, testing the recreated DetailsPlace for the same parameter
1250 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1252 Use the surefire-report plugin.
1254 * pom.xml: This generates a HTML report about the tests in
1255 target/site/surefire-report.html
1256 when you do mvn surefire-report:report. It seems to be popular/normal.
1258 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1260 Added a test for DetailsPlace.
1262 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1263 Test the getPlace() token parsing.
1265 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1267 Added a first unit test.
1269 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1270 * src/test/java/org/glom/web/shared/DataItemTest.java:
1271 This is a silly test but it is just to get things started. Note that
1272 maven/junit finds the test because it looks in src/test by default.
1274 2011-12-22 Ben Konrath <ben@bagu.org>
1276 Change charsetName to "UTF-8" when replacing line breaks.
1278 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1279 that work in Java (such as "UTF8") will not work when compiled to
1282 This fixes a problem with multi-line details view fields that have hard
1283 line breaks. The "License Text" field on this page demonstrates the
1286 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1288 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1290 2011-12-22 Ben Konrath <ben@bagu.org>
1292 Fix another bug with related list navigation.
1294 I've tested all the navigation buttons in all of the related lists
1295 so things should be good now.
1297 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1299 2011-12-22 Ben Konrath <ben@bagu.org>
1301 Fix a crasher when refreshing the list view with the default table.
1303 This crash will also happen when loading the list view with the default
1304 table from a link or bookmark.
1306 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1307 to the main document selection page when the document id hasn't been
1309 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1310 the main document selection page when the document id hasn't been
1312 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1313 values for the details place when the document id hasn't been set.
1314 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1315 values for the list place when the document id hasn't been set.
1317 2011-12-21 Ben Konrath <ben@bagu.org>
1319 Protect against NPE when glom.document.locale is not in config.
1321 This patch protects against an NPE when glom.document.locale is not in
1322 the config file. This NPE will also happen if glom.document.locale is
1325 The patch also updates the error message to display the class name when
1326 the getMessage() returns null. This was happening when the NPE was
1327 thrown and I had "Configuration Error: null". If an NPE is encountered
1328 with this patch, "Configuration Error: NullPointerException " will be
1331 This commit closes this bug:
1333 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1335 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1337 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1339 Rename onlineglom.properties to onlineglom.properties.sample.
1341 * src/main/resources/onlineglom.properties: Rename to:
1342 * src/main/resources/onlineglom.properties.sample:
1343 * src/main/resources/README: And add this file explaining that people
1344 should rename it back when deploying.
1346 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1348 Allow choosing the translation in the .properties file.
1350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1351 init(): Read a glom.document.locale value from the configuration file
1352 and call Glom's TransatableItem::set_current_locale() method.
1353 * src/main/resources/onlineglom.properties: Add a commented-out
1354 example of this new setting.
1356 It would be better to add &lang=de_DE to the URL, but the current
1357 libglom API does not allow us to do this easily. I am working on that.
1359 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1361 Avoid a crash in parsing of token parameters.
1363 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1364 ava: getTokenParams(): Do not crash if a parameter has a key but no
1365 value, and ignore parameters with neither.
1367 2011-12-17 Murray Cumming <murrayc@murayc.com>
1369 History token building/handling: Improve use of token parameters.
1371 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1372 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1373 and buildParamsToken(HashMap), for use by derived classes.
1374 Make the separator private because it is no longer be needed.
1375 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1376 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1377 instead of manual string concatenation.
1378 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1379 of hardcoded indices and awkward splitting code.
1380 * src/main/java/org/glom/web/client/place/ListPlace.java
1381 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1382 instead of manual string concatenation.
1383 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1384 of hardcoded indices and awkward splitting code.
1385 This should fix bug #666420
1387 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1389 Fix a Navgiation->Navigation typo in the code.
1391 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1392 Rename processNavgiation() to processNavigation().
1394 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1396 Fix a seperator->separator typo in the code.
1398 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1399 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1400 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1403 2011-12-15 Ben Konrath <ben@bagu.org>
1405 Cleanup some comments.
1407 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1409 2011-12-14 Ben Konrath <ben@bagu.org>
1411 Replace \n with <br/> for multiline text in the details view.
1413 Vertical scrollbars are added when needed as well.
1415 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1417 2011-12-14 Ben Konrath <ben@bagu.org>
1419 Specify the font for document selection links.
1421 * src/main/webapp/style.css:
1423 2011-12-14 Ben Konrath <ben@bagu.org>
1425 Fix bouncy CellTable while paging.
1427 This doesn't currently work with related list tables in unselected
1430 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1432 2011-12-14 Ben Konrath <ben@bagu.org>
1434 Revamp the appearance of the document selection page.
1436 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1437 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1438 * src/main/webapp/style.css:
1440 2011-12-13 Ben Konrath <ben@bagu.org>
1442 Set navigation button column to the smallest size possible.
1444 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1446 2011-12-13 Ben Konrath <ben@bagu.org>
1448 Change OpenButton nomenclature to NavigationButton.
1450 Using NavigtionButton makes things more generic. Classes, methods and
1451 variables have been changed.
1453 This is a rename-only refactor.
1455 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1456 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1457 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1458 Renamed from OpenButtonCell.
1459 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1460 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1461 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1463 2011-12-12 Ben Konrath <ben@bagu.org>
1465 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1467 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1468 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1469 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1470 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1472 2011-12-12 Ben Konrath <ben@bagu.org>
1474 Update variable names and comments.
1476 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1477 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1479 2011-12-12 Ben Konrath <ben@bagu.org>
1481 Properly initialize numNonEmptyRows variable to zero.
1483 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1484 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1486 2011-12-05 Ben Konrath <ben@bagu.org>
1488 Add latest mockup with HTML tables.
1490 Features of this mockup:
1492 -> HTML table for flowtable
1493 -> HTML table for flowtable column
1494 -> Example of how related lists would look
1495 -> Not using text entries for data items
1497 The current version of Online Glom doesn't use HTML tables for the
1500 This mockup has been sent to the glom-devel mailing list but it's good
1501 to have it here as well.
1503 * mockups/details-view-html-tables.html:
1505 2011-12-05 Ben Konrath <ben@bagu.org>
1507 Remove unnecessary getPrimaryKeyField() method.
1509 getPrimaryKeyFieldForTable(String) has been renamed to
1510 getPrimaryKeyField(String).
1512 * src/main/java/org/glom/web/server/database/DBAccess.java:
1513 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1514 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1516 2011-12-05 Ben Konrath <ben@bagu.org>
1518 Add string representation of TypedDataItem value to conversion error message.
1520 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1521 message was extracted into its own method to avoid duplication.
1523 2011-12-05 Ben Konrath <ben@bagu.org>
1525 Add type checking to navigation primary key value creation.
1527 Create navigation primary key only if the expected type from the Glom
1528 document matches the type returned by the SQL query.
1530 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1532 2011-12-05 Ben Konrath <ben@bagu.org>
1534 Rename a couple of variables in RelatedListNavigation.
1536 This is a rename-only refactor.
1538 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1540 2011-12-05 Ben Konrath <ben@bagu.org>
1542 Move getListLayoutGroup() into getListViewLayoutGroup().
1544 This removes getListLayoutGroup(). It was only being called by
1545 getListViewLayoutGroup().
1547 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1549 2011-12-05 Ben Konrath <ben@bagu.org>
1551 Remove check for LayoutItem_Portal in list table method.
1553 This check is no longer necessary because the method isn't being used
1554 to create the LayoutItemPortal DTO.
1556 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1558 2011-12-05 Ben Konrath <ben@bagu.org>
1560 Properly support related list navigation.
1562 Navigation from the "Repository Analyzer -> Package Scans ->
1563 Dependencies" related table wasn't working because the primary key for
1564 related tables wasn't being set properly. This commit fixes the
1567 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1568 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1569 doesn't set the primary key properly for related list tables.
1570 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1571 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1572 useful for getting the primary key for list view tables and for related
1574 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1575 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1576 Move code to set the primary key for the table from the abstract
1577 ListDBAccess class to ListViewDBAccess as it's only correct for list
1579 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1580 Properly add primary key to related list tables.
1582 2011-12-02 Ben Konrath <ben@bagu.org>
1584 Properly set the horizontal alignment of fields.
1586 This fix is for both the list tables and the details view.
1588 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1589 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1590 to set the horizontal alignment of fields.
1592 2011-12-02 Ben Konrath <ben@bagu.org>
1594 Display currency codes in the details view.
1596 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1598 2011-12-02 Ben Konrath <ben@bagu.org>
1600 Avoid duplicate JNI call.
1602 JNI is not as efficient as pure Java and this is an easy (and small)
1605 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1606 Use previously retrieved value for whereClauseToTableName instead of
1609 2011-12-02 Ben Konrath <ben@bagu.org>
1611 Rename a couple of variables in RelatedListNavigation.
1613 This is a rename-only refactor.
1615 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1617 2011-12-02 Ben Konrath <ben@bagu.org>
1619 Indicate clearly that a mismatched primary key type is a bug.
1621 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1622 warning to error. Add 'This is a bug.' to message.
1624 2011-12-02 Ben Konrath <ben@bagu.org>
1626 Update / fix some comments.
1628 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1630 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1632 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1633 Fix comments. Add some TODOs.
1635 2011-12-02 Ben Konrath <ben@bagu.org>
1637 Enable navigation to details view with string primary key from related list.
1639 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1640 Create a text primary key value when return type of result is
1641 java.sql.Types.VARCHAR.
1643 2011-12-02 Ben Konrath <ben@bagu.org>
1645 Use checkboxes for booleans in the details view.
1647 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1649 2011-12-01 Ben Konrath <ben@bagu.org>
1651 Improve performance of related list height calculation.
1653 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1654 Put code to calculate the expected height in a static initializer so
1655 that that it's only called once.
1657 2011-12-01 Ben Konrath <ben@bagu.org>
1659 Show related list tables in notebooks (again).
1661 Calculate the height of the related list tables so the Notebook can be
1662 set the correct height. The height of the related list table is also needed by
1663 FlowTable to be able decide how to create the layout.
1665 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1666 and set the Portal height based on the height of the related list
1667 table and the Portal container.
1668 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1669 Add method to calculate the height of the related list tables.
1670 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1671 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1672 calculate the height of the Pager widget.
1674 2011-12-01 Ben Konrath <ben@bagu.org>
1676 Use CellTable API for table property instead of setting style on Element.
1678 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1680 2011-12-01 Ben Konrath <ben@bagu.org>
1682 Make ListViewTable and RelatedListTable a consistent height.
1684 The tables are now a consistent height regardless of the contents of
1685 the table. A hidden button is added to empty rows to ensure that the
1686 height of these rows will match the height of rows with data.
1688 A navigation button column is now added to every table. The width of
1689 the navigation column is set to 0px when a RelatedListTable shouldn't
1690 have navigation buttons. This maintains the a consistent row height in
1691 tables that don't show the navigation buttons.
1693 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1694 navigation column when not needed.
1695 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1696 arguments for navigation button to constructor of ListViewTable.
1697 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1698 hidden button for empty data rows.
1699 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1700 arguments for navigation button to constructor.
1701 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1702 create navigation buttons. Add hideNavigationButtons() method.
1703 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1704 arguments for navigation button to constructor.
1706 2011-12-01 Ben Konrath <ben@bagu.org>
1708 Use 'visibility: hidden' in Utils.getWidgetHeight().
1710 This is better choice because hidden elements are invisible, don't
1711 respond to events and are not part of the tab order. They will,
1712 however, take up space which is required to be able to calculate the
1713 height of the widget.
1715 * src/main/java/org/glom/web/client/Utils.java:
1717 2011-12-01 Ben Konrath <ben@bagu.org>
1719 Use Utils.getWidgetHeight() in FlowTable.
1721 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1723 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1725 2011-12-01 Ben Konrath <ben@bagu.org>
1727 Put the details css class name on the correct table column.
1729 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1731 2011-11-30 Ben Konrath <ben@bagu.org>
1733 Update for java-libglom API change.
1735 The getters and setters on FieldFormatting and NumericFormat were
1736 changed to remove the 'M'.
1738 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1740 2011-11-29 Ben Konrath <ben@bagu.org>
1742 Only allow RelatedListTables in Portals.
1744 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1746 2011-11-29 Ben Konrath <ben@bagu.org>
1748 Only create a contents panel for Portals when title is being set.
1750 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1752 2011-11-29 Ben Konrath <ben@bagu.org>
1754 Set TabLayoutPanel height based on calculated height its widgets.
1756 This is a potential fix for this bug:
1758 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1760 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1762 2011-11-29 Ben Konrath <ben@bagu.org>
1764 Align details field labels and data with the Open buttons.
1766 * src/main/webapp/style.css:
1768 2011-11-29 Ben Konrath <ben@bagu.org>
1770 Remove unnecessary <div> in the Notebook widget.
1772 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1773 method to get container FlowPanel (<div>).
1774 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1775 initWidget() method directly on the TabLayoutPanel widget instead of
1776 Group's container widget.
1778 2011-11-29 Ben Konrath <ben@bagu.org>
1780 Don't add group titles for Portals in Notebooks.
1782 This reverts the previous patch and fixes a bug I introduced with
1783 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1785 * src/main/java/org/glom/web/client/ui/details/Group.java:
1786 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1788 2011-11-28 Ben Konrath <ben@bagu.org>
1790 Remove unused boolean argument in Portal constructor.
1792 Just a code cleanup.
1794 * src/main/java/org/glom/web/client/ui/details/Group.java:
1795 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1797 2011-11-28 Ben Konrath <ben@bagu.org>
1799 Remove hack for glom 1.18 style glom files.
1801 * src/main/java/org/glom/web/client/ui/details/Group.java:
1802 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1803 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1805 2011-11-28 Ben Konrath <ben@bagu.org>
1807 Use Gda Value version of primary key to log result too large error.
1809 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1811 2011-11-28 Ben Konrath <ben@bagu.org>
1813 Don't use TypedDataItem.getText() for Unknown types from the URL.
1815 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1816 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1817 instead of getText().
1818 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1819 String field and getUnknown() method.
1821 2011-11-28 Ben Konrath <ben@bagu.org>
1823 Log an error message when the java-libglom .so is not present.
1825 The error message was being set in the exception but not logged.
1827 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1829 2011-11-28 Ben Konrath <ben@bagu.org>
1831 Ignore LayoutItem_CalendarPortals.
1833 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1834 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1836 2011-11-28 Ben Konrath <ben@bagu.org>
1838 Extract method for creating the LayoutItemPortal DTO.
1840 Just breaking the code up into smaller chunks.
1842 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1844 2011-11-28 Ben Konrath <ben@bagu.org>
1848 This should have been added with the refactor. Oops!
1850 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1852 2011-11-28 Ben Konrath <ben@bagu.org>
1854 Create primary key value from URL string using type from Glom document.
1856 See this bug, comments 19 - 25:
1858 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1860 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1861 create a TypeDataItem for the primary key here when loading from a
1862 URL. Show the same string for the primary key value as was received
1863 from the URL string (when loading from a URL).
1864 * src/main/java/org/glom/web/server/Utils.java: Update method for
1865 creating the Gda Value from the TypeDataItem to properly deal with
1866 creating a Gda Value based on the Glom document type for the primary
1867 key value string when loading from a URL.
1868 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1869 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1870 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1871 Update for changed method name.
1873 2011-11-27 Ben Konrath <ben@bagu.org>
1875 Rename PrimaryKeyItem to TypedDataItem.
1877 The name PrimaryKeyItem suggests what the class should be used for.
1878 TypedDataItem is a neutral name that describes the class better.
1880 This is a rename-only refactor.
1882 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1883 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1884 * src/main/java/org/glom/web/client/Utils.java:
1885 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1886 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1887 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1888 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1889 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1890 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1891 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1892 * src/main/java/org/glom/web/server/Utils.java:
1893 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1894 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1895 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1896 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1898 2011-11-25 Ben Konrath <ben@bagu.org>
1900 Improve Gda Value conversion from PrimaryKeyItem.
1902 The value from the PrimaryKeyItem is only used if its type match the
1903 type from the glom document.
1905 * src/main/java/org/glom/web/server/Utils.java:
1907 2011-11-25 Ben Konrath <ben@bagu.org>
1909 Manually check if the java-liblgom .so is visible to the JVM.
1911 It seems that Tomcat has problems when a static initializer throws an
1912 exception. This check is done before the first method call into
1913 java-libglom so that execution doesn't continue if the .so is not
1916 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1918 2011-11-25 Ben Konrath <ben@bagu.org>
1920 Improve browser configuration error messages.
1924 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1926 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1927 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1928 getConfigurationErrorMessage() method.
1929 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1930 Get and display a specific configuration error message when no Glom
1931 documents are found.
1932 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1933 Implement getConfigurationErrorMessage() method. Surround configuration
1934 code in the init() method with a try/catch block. This allows the
1935 errors to be caught while keeping the servlet available to retrieve the
1936 configuration error message.
1938 2011-11-25 Ben Konrath <ben@bagu.org>
1940 Don't use Strings to hold primary key values.
1942 The primary key values are now held in a new data object
1943 (PrimaryKeyItem) that holds type information and the primary key value
1944 using the correct type.
1946 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1947 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1948 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1949 PrimaryKeyItem instead of String to hold the primary key value.
1950 * src/main/java/org/glom/web/client/Utils.java: Remove
1951 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1952 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1953 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1954 PrimaryKeyItem instead of String to hold the primary key value. Load
1955 document selection page when the documentID has not been set correctly.
1956 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1957 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1959 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1960 Return empty string for URL instead of "null".
1961 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1962 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1963 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1964 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1965 PrimaryKeyItem instead of String to hold primary key values.
1966 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1967 PrimaryKeyValue to a Gda Value.
1968 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1969 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1970 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1971 Replace temporary database access code that uses the PrimaryKeyValue to
1972 Gda Value conversion.
1973 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1974 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1975 PrimaryKeyItem instead of String.
1976 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1977 hold primary key values.
1979 2011-11-24 Ben Konrath <ben@bagu.org>
1981 Use newly added java-libglom API to create queries.
1983 This isn't finished. I still need to stop using Strings for primary key
1984 values in the client code.
1986 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1987 libglom to use fake connections so that retrieving the query string will
1989 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1990 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1991 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1992 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1993 Use the newly added libglom sql methods and classes to create the
1994 query. Add temporary hack to convert primary value strings to Gda
1997 2011-11-23 Ben Konrath <ben@bagu.org>
1999 Don't explicitly set the height of Portals.
2001 See comments 6 - 10 of this bug for details:
2003 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2005 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2007 2011-11-23 Ben Konrath <ben@bagu.org>
2009 Use an HTML table instead of CSS for the FlowTable layout.
2011 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2012 GWT's FlexTable to implement the FlowTable.
2013 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2015 2011-11-18 Ben Konrath <ben@bagu.org>
2017 Add boolean example to HTML table mockup.
2019 * mockups/details-view-html-tables-text-entries.html:
2021 2011-11-17 Ben Konrath <ben@bagu.org>
2023 Ensure the pager buttons are always visible for related lists.
2025 To accomplish this, I've turned off text wrapping in the list view and
2026 related list tables for both the header and data text. The related list
2027 table now has a fixed layout so the it doesn't overflow its container.
2028 This is required to ensure that the cell text is clipped when it
2029 overflows the cell and an ellipsis is added to the right side of the
2030 cell when text is clipped.
2032 A fixed table layout for the related list table in the details view
2033 seems what we want for the details view anyway, so the side-effect is
2036 The ellipsis will only be displayed in Firefox >= 7.
2040 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2042 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2043 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2044 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2046 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2047 Set the 'table-layout: fixed' CSS property to the related list table.
2048 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2049 'white-space: nowrap;' CSS property on both the list view and the
2050 related list tables.
2052 2011-11-16 Ben Konrath <ben@bagu.org>
2054 Rework the fix for empty notebook tab labels.
2056 Setting the empty group titles with its name caused problems for the
2057 details layout. Instead of using libglom's
2058 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2059 to the client when the title is empty. This allows the Notebook to use
2060 the name when the title is empty without affecting anything else.
2062 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2063 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2065 2011-11-16 Ben Konrath <ben@bagu.org>
2067 Set group titles with name when title is empty.
2069 This fixes a problem with an empty notebook tab label in the Lesson
2070 Planner document. The forth tab in the notebook should be "Internet":
2072 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2074 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2075 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2078 2011-11-16 Ben Konrath <ben@bagu.org>
2080 Remove whitespace from the configured username properties.
2082 This assumes that usernames won't have whitespace at the beginning
2083 or end. But I think this is a reasonable assumption.
2085 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2086 String.trim() to remove the whitespace from the username properties.
2088 2011-11-15 Ben Konrath <ben@bagu.org>
2090 Add details view mockup with HTML tables and text entries.
2092 This is from the attachment on this bug:
2094 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2096 * mockups/details-view-html-tables-text-entries.html:
2098 2011-11-15 Ben Konrath <ben@bagu.org>
2100 Add space between the columns of the flow table.
2104 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2106 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2107 space between columns in the flow table.
2109 2011-11-15 Ben Konrath <ben@bagu.org>
2111 Add backup files to the .gitignore.
2113 * .gitignore: Ignore files that end with ~.
2115 2011-11-09 Ben Konrath <ben@bagu.org>
2117 Use latest release of gwt-log.
2119 Gwt-log releases are now being submitted to the maven central
2120 repository so manual installation of the jar is no longer required.
2122 * pom.xml: Update version and groupId of gwt-log dependency.
2124 2011-10-31 Ben Konrath <ben@bagu.org>
2126 Don't use GWT numeric formatting to override the glom currency formatting.
2128 Currencies are now displayed like they are in Glom. See this bug:
2130 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2132 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2134 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2135 currency code to constructor and set it when the cell is rendered.
2136 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2137 currency code to the constructor of the NumericCell.
2139 2011-10-27 Ben Konrath <ben@bagu.org>
2141 Require the latest release of java-libglom (1.17.4).
2145 2011-10-26 Ben Konrath <ben@bagu.org>
2147 Add style to Notebook that matches current theme.
2149 It's not the best style in the world but it's better than the default.
2151 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2152 padding at the bottom of the child widgets.
2153 * src/main/webapp/style.css: Add style for the Notebook.
2155 2011-10-26 Ben Konrath <ben@bagu.org>
2157 Move servlet initialization code to overridden init method.
2159 This is half of the solution to getting proper error messages
2160 displayed when configuration errors occur. Here's the relevant bug:
2162 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2164 The rest of the solution involves surrounding the init method with a
2165 try/catch block and setting a global variable with the error /
2166 exception. A new async method should be created to retrieve and display
2167 the error message / exception.
2169 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2170 code from constructor to init method adding exceptions as needed.
2172 2011-10-26 Ben Konrath <ben@bagu.org>
2174 Add script to monitor and restart tomcat if required.
2176 * utils/check-and-recover-tomcat.py: New file.
2178 2011-10-26 Ben Konrath <ben@bagu.org>
2180 Display the correct number of data items in the pager.
2184 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2186 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2187 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2188 The implementation is the same for both tables: Keep track of the
2189 number of non-empty rows and fire and RowCountChangeEvent after the data has
2191 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2192 custom Pager class that subclasses SimplePager to handle displaying
2193 the correct number when empty rows have been added.
2195 2011-10-26 Ben Konrath <ben@bagu.org>
2197 Correct error in previous commit.
2199 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2200 eventBus parameter from listView.setCellTable().
2202 2011-10-26 Ben Konrath <ben@bagu.org>
2204 Fix error in TODO comment.
2206 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2208 2011-10-24 Ben Konrath <ben@bagu.org>
2210 Create Notebook widgets to the details view.
2212 This isn't finished just yet - I still need to create a reasonable
2213 style to match the current theme.
2215 * src/main/java/org/glom/web/client/Utils.java: Add method for
2216 calculating the height of a widget. This is used in the Notebook class.
2217 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2218 new constructor method in Group.
2219 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2220 method for creating child widget that can be used by subclasses
2221 like Notebook. New constructor that allows disabling the group
2222 titles - Notebooks don't set a group title for their child groups.
2223 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2224 to make Notebooks using GWT's TabLayoutPanel.
2225 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2226 constructor that allows disabling the group titles.
2227 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2228 LayoutItemNotebook DTO.
2229 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2230 DTO for Notebooks. It's just an empty class for now but we might need
2231 it to transfer some specific information in the future.
2233 2011-10-21 Ben Konrath <ben@bagu.org>
2235 Add navigation buttons to related list tables.
2237 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2238 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2239 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2240 method getSuitableRecordToViewDetails() for getting the table name
2241 and primary key value for related list navigation buttons.
2242 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2243 private cell renderer class to get the navigation information for
2244 related list tables from the server. Extract the navigation
2245 processing code from the details cell navigation and use it for the
2246 related list navigation as well.
2247 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2248 cell renderer class for the details open buttons. This was needed
2249 because the related list navigation buttons and the list view
2250 navigation buttons need to react differently when clicked.
2251 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2252 the onEnterKeyDown() method because it's now overriden in the
2253 subclasses that are specific to the related list tables and the list
2255 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2256 the vertical size a little because the buttons add a bit of vertical
2257 space to table. This is not a perfect solution because the vertical
2258 size of with table fewer than 5 rows will be a little smaller.
2259 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2260 changes in how navigation buttons are handled.
2261 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2262 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2263 database access object.
2264 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2265 to find the portal for a given relationship name from
2266 RelatedListDBAccess. Add method to find a primary key field for a
2268 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2269 Move code to find the portal for a given relationship name to
2271 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2272 New file: database access object for getting the related list
2273 navigation information (the table name and the primary key value).
2274 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2275 DTO for transferring a table name to navigate to and a primary key
2277 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2278 boolean and getter/setter to specifies if the related list should add
2281 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2283 Use the master branch of java-libglom
2285 * pom.xml: Depend on java-libglom 1.19 instead.
2287 This is the master branch. See also the libglom-1-18 branch.
2289 2011-10-11 Ben Konrath <ben@bagu.org>
2291 Enable the open navigation button when the data has been set.
2293 This avoids having active buttons that don't do anything when the data
2296 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2298 2011-10-11 Ben Konrath <ben@bagu.org>
2300 Use IsWidget interface for FlowTableItem.
2302 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2303 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2305 2011-10-11 Ben Konrath <ben@bagu.org>
2307 Remove GWT styling from open button in details view.
2309 There are still some issues with how the details cell is arranged but
2310 this should be made to match Glom 1.20. I'm going to leave fixing this
2311 until I have Glom 1.20 up and running.
2313 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2314 style name on open button.
2315 * src/main/webapp/style.css: Move and edit details-navigation class.
2316 Re-arrange some classes to make them appear in the same order as the
2319 2011-10-07 Ben Konrath <ben@bagu.org>
2321 Update to GWT 2.4.0.
2323 * .gitignore: Ignore new cache directory.
2324 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2325 * pom.xml: Change GWT and maven plugin to 2.4.0.
2326 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2328 * src/main/java/org/glom/web/client/ClientFactory.java:
2329 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2330 * src/main/java/org/glom/web/client/OnlineGlom.java:
2331 Update source for API changes.
2332 * utils/build-onlineglom-war.sh: Remove cache directory before the
2335 2011-10-07 Ben Konrath <ben@bagu.org>
2337 Add navigation buttons in the details view.
2339 This isn't finished but I thought I'd commit what I have as it's a
2340 pretty good start. I still need to:
2342 1. Change the style so that it fits better into the current theme
2343 2. Adjust the details cell to expand as much as possible.
2345 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2346 click handlers to navigation buttons in the DetailsCells. Create a
2347 refreshData() method to get just the data from the server without the
2349 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2350 Update the tableSelector and browser title when the table name
2351 changes without using the tableSelector.
2352 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2353 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2354 getDetailsCells() to getCells(). Update variable names.
2355 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2356 method to set click handler on navigation button. Rename a few
2357 variables. Add navigation buttons where needed.
2358 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2359 variables and methods.
2360 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2361 navigation boolean and navigation table as required in the
2362 LayoutItemField DTO.
2363 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2364 variables for navigation along with getter/setter methods.
2366 2011-10-07 Ben Konrath <ben@bagu.org>
2368 Rename Field to DetailsCell.
2370 This is a refactor-only commit. No functionality has been added or
2373 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2374 Update variable and method names.
2375 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2376 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2377 variable and method names.
2378 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2380 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2381 variable and method names.
2383 2011-10-07 Ben Konrath <ben@bagu.org>
2385 Create separate methods for layout and data the details view.
2387 This is a refactor-only commit. No functionality has been added or
2390 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2391 private methods: setData(), createLayout().
2393 2011-10-07 Ben Konrath <ben@bagu.org>
2395 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2397 This is part of a change to get navigation buttons in the details view
2398 but it should have been done this way from the start.
2400 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2401 for method name change in TableSelectionView.
2402 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2403 Create TableChangeEvent and set the browser title using the
2404 TableSelectionView API.
2405 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2406 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2407 Change getSelectedTable() to getSelectedTableName(). Add
2408 getSelectedTableTitle().
2410 2011-10-07 Ben Konrath <ben@bagu.org>
2412 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2414 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2416 2011-10-07 Ben Konrath <ben@bagu.org>
2418 Update TableChangeEvent to use newTableName naming convention.
2420 This makes the class more consistent with GWT naming conventions.
2422 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2423 Update for method name change in TableChangeEvent.
2424 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2425 for method name change in TableChangeEvent.
2426 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2427 newTableName variable and getter method. Make toDebugString()
2430 2011-09-30 Ben Konrath <ben@bagu.org>
2432 Disable the pager in the list tables when the data row count is less than the minimum.
2434 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2435 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2437 2011-09-30 Ben Konrath <ben@bagu.org>
2439 Add empty rows to the end of related list and list view tables.
2441 I also extracted the cell rendering classes from the ListTable because
2442 the code was becoming a little crazy with all the anonymous inner
2443 classes. My plan is to use these cell rendering classes in the details
2444 view as well so this refactor will be needed for that change.
2446 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2447 set the row count in related list tables if the data has more rows
2448 than the minimum number of rows visible.
2449 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2450 row count in list view tables if the data has more rows than the
2451 minimum number of rows visible.
2452 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2453 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2455 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2456 for rendering TYPE_NUMERIC cells. The code was extracted from the
2458 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2459 class for rendering cells with buttons in list views. The code was
2460 extracted from the ListTable class.
2461 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2462 for rendering TYPE_TEXT cells. The code was extracted from the
2464 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2465 Add empty rows to the end of the data if required. Implement
2466 ListTable.getMinNumVisibleRows().
2467 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2468 cell renderer code to public classes. Return null in
2469 Column.getValue() for empty rows. Add new abstract method:
2470 getMinNumVisibleRows(). Move code to set the row count of the list view
2471 table to ListViewImpl.
2472 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2473 empty rows to the end of the data if required. Implement
2474 ListTable.getMinNumVisibleRows().
2477 2011-09-27 Ben Konrath <ben@bagu.org>
2479 Use GWT.log for client-side debugging statements.
2481 These are optimized out when deployed so I should have used this method
2482 in the first place. These statements will eventually be replaced with some sort
2483 of notification in the browser.
2485 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2486 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2487 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2488 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2489 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2491 2011-09-27 Ben Konrath <ben@bagu.org>
2493 Put tableselector on the right, back to list link on right.
2495 The idea is that the table selector is acting like a label for the
2496 currently displayed table so it should be placed below the document title. This
2497 puts the table title in a similar position to where it is in Glom.
2499 * mockups/details-contacts.html:
2500 * mockups/details-projects.html:
2501 * mockups/listview-contacts.html:
2502 * mockups/listview-projects.html:
2503 * mockups/style.css:
2504 Update mockups to match how the interfaces currently look.
2505 * src/main/webapp/style.css: Swap positions of backlink with the table
2506 selector. Add some space on the left side of the table selector to
2507 line things up with the document title.
2509 2011-09-27 Ben Konrath <ben@bagu.org>
2511 Add field colouring to details view.
2513 This change re-works how field colouring works. The colour formatting
2514 information is now set to the client with the layout information instead of
2515 with the data. This eliminates the need to send the same colour strings for
2516 data in list view column when colour information is set.
2518 In order to set an alternate colour for negative numeric values, the
2519 number is now sent to client and formatted with the GWT NumberFormat class.
2521 This change also fixes:
2523 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2525 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2526 internationalization framework which is needed for client side numeric
2528 * src/main/java/org/glom/web/client/Utils.java: New file for some
2529 client static utility methods.
2530 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2531 the DataItem object to the Field class. Use a utility method to
2532 create the foreignKeyValue string.
2533 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2534 alignment and text colours in the constructor. Add setData(DataItem)
2535 method. Remove setText(String) method.
2536 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2537 colour information to GlomTextCell. Create and use GlomNumberCell for
2538 rendering numbers. Use utility method to get the string for the
2539 primary key of the key provider. Re-work how the horizontal alignment
2541 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2542 formatting to layout information. Methods for converting the libglom
2543 formatting information were moved from DBAccess.
2544 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2545 numeric formatting (it's now done on the client side). Don't set text
2546 colours in DataItem. Move libglom formatting conversion methods to
2548 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2549 getters/setters for text colour information.
2550 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2551 for transferring the libglom NumericFormat information to the client.
2552 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2553 and getters/setters for: GlomNumericFormat, background colour and
2554 foreground colour strings.
2556 2011-09-26 Ben Konrath <ben@bagu.org>
2558 Simplify code that iterates through the LayoutGroup.
2560 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2562 2011-09-26 Ben Konrath <ben@bagu.org>
2564 Accept Eclipse formatting for OnlineGlomServiceAsync.
2566 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2568 2011-09-26 Ben Konrath <ben@bagu.org>
2570 Don't use the ListDBAccess classes to get the primary key layout information.
2572 This was causing a bug where the wrong index for the hidden primary key
2573 was being sent to the client.
2575 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2576 primary key while creating the LayoutGroup DTO. Create a
2577 LayoutItemField DTO for hidden primary keys. Don't use the
2578 RelatedListDBAccess because it was only used for getting the primary
2580 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2581 access modifier from public to protected for getPrimaryKeyField() and
2582 getPrimaryKeyLayoutItemField().
2583 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2584 abstract method getExpectedResultSize() because RelatedListDBAccess
2585 doesn't have enough info to implement it.
2586 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2587 Remove @Override for getExpectedResultSize().
2588 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2589 Remove method getExpectedResultSize().
2591 2011-09-23 Ben Konrath <ben@bagu.org>
2593 Log which layout (list or details) the ignored item is from.
2595 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2597 2011-09-23 Ben Konrath <ben@bagu.org>
2599 Remove annotations that turn off code formatting in DataItem.
2601 * src/main/java/org/glom/web/shared/DataItem.java:
2603 2011-09-23 Ben Konrath <ben@bagu.org>
2605 Rename GlomField to DataItem and update associated methods.
2607 This is a rename-only refactor. No functionality has been added or
2610 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2611 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2612 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2613 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2614 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2615 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2616 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2617 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2618 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2619 * src/main/java/org/glom/web/server/database/DBAccess.java:
2620 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2621 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2622 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2623 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2624 * src/main/java/org/glom/web/shared/DataItem.java:
2625 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2626 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2628 2011-09-23 Ben Konrath <ben@bagu.org>
2630 Rename GlomDocument to DocumentInfo and update associated methods.
2632 This is a rename-only refactor. No functionality has been added or
2635 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2636 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2637 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2638 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2639 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2640 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2641 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2643 2011-09-20 Ben Konrath <ben@bagu.org>
2645 Require java-libglom 1.17.3.
2647 This picks up the fix for the seg fault problem with the Scenes table
2648 in the Openismus Film Manager example.
2652 2011-09-20 Ben Konrath <ben@bagu.org>
2654 Change the way sort clause is added for primary key when no sort clause is requested.
2656 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2657 before the sort clause is created. When a sort clause is not requested, the
2658 sort clause is created by finding the primary key in the LayoutFieldVector
2661 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2663 2011-09-20 Ben Konrath <ben@bagu.org>
2665 Log error message if no documents are found in the configured directory.
2667 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2668 Extract the glom file extension string to a private static final class
2669 variable (mostly as syntactic sugar). Accept a minor formatting change.
2670 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2671 the example glom.document.directory configuration property to make it
2672 more clear that it can any directory, not just the home directory.
2674 2011-09-18 Ben Konrath <ben@bagu.org>
2676 Add related lists to details view.
2678 The related list table has support for paging and sorting just like the
2679 table in the list view.
2681 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2682 SQL queries for the related list tables.
2683 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2684 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2685 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2686 Rename getList methods to getListView and add comments. Remove
2687 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2688 it being unused. Add methods: getDetailsLayoutAndData(),
2689 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2690 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2691 Create the layout and set the data for the fields in one async call
2692 instead of two. Create related lists where appropriate.
2693 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2694 for method name changes in OnlineGlomService.
2695 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2696 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2697 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2699 * src/main/java/org/glom/web/client/ui/ListView.java:
2700 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2701 tableName from setCellTable(). Create a ListViewTable instead of
2703 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2704 represent a data field in the details view.
2705 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2706 from addDetailsCell() to Field class. Keep track of the Fields and
2707 Portals in the details view.
2708 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2709 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2710 and add a method to get it. Add method to set the contents of the
2712 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2713 New class for related list tables. This class has the data provider
2714 for the related list table.
2715 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2716 abstract class which is the base class for the ListViewTable and the
2718 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2719 New class for list view tables. This class has the data provider for
2720 the list view table.
2721 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2722 methods for related list tables. Add more information to the
2723 LayoutItemField and LayoutItemPortal DTOs.
2724 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2725 Remove debugging print statement.
2726 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2727 Remove debugging print statements. Add primary key field to SQL count
2729 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2730 Remove unnecessary LayoutFieldVector parameter from
2731 getResultSizeOfSQLQuery() method.
2732 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2733 New class for related list table database access.
2734 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2735 class that is a wrapper DTO for details view layout and data.
2736 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2737 new 'fromField' string to this DTO.
2738 * src/main/webapp/style.css: Remove bottom margin and override top
2741 2011-09-15 Ben Konrath <ben@bagu.org>
2743 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2745 This sets things up to make it easier to add the data retrieval for
2746 related lists (portals). No user noticeable changes were made with
2749 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2750 class has the code to retrieve the layouts and access the
2751 database using the new database helper classes.
2752 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2753 Most of the functionality has been removed from this class. This
2754 class now represents the public interface for the client side
2755 code. It also deals with configuring the servlet and cleaning
2756 things up when the servlet is stopped.
2757 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2758 of static methods into this utility class.
2759 * src/main/java/org/glom/web/server/database/DBAccess.java:
2760 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2761 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2762 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2763 These classes have the database retrieval code. The class hierarchy
2764 has been setup to make it easy to reuse code for similar
2767 2011-09-06 Ben Konrath <ben@bagu.org>
2769 Create separate classes for list table code and the data provider.
2771 As part of this refactor, I also split up the code a bit to make it
2774 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2775 table code to two new classes (below).
2776 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2777 with code from ListViewImpl.
2778 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2779 New file with code from ListViewImpl.
2781 2011-09-06 Ben Konrath <ben@bagu.org>
2783 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2785 This fixes the LayoutItemPortal DTO to match the libglom layout object
2788 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2790 2011-09-01 Ben Konrath <ben@bagu.org>
2792 Set title of Portals in the Details View.
2794 * pom.xml: Bump required version of java-libglom to 1.17.1.
2795 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2796 widget creation to its own class. Add comments to constructor.
2797 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2798 The code is mostly from the Group class with the title now set.
2799 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2800 title of Portal. Update some comments. Fix some code formatting.
2802 2011-09-01 Ben Konrath <ben@bagu.org>
2804 Remove TODO comment for the flow table column width.
2806 The flow table column width is working correctly and doesn't need to be
2807 changed. See this mailing list post for more info:
2809 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2811 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2813 2011-08-27 Ben Konrath <ben@bagu.org>
2815 Add document title (database name) to top of the browser page.
2817 I added the document title to the TableSelecitonView but that will
2818 change if / when we add a view that doesn't require table selection.
2820 * mockups/details-contacts.html:
2821 * mockups/details-projects.html:
2822 * mockups/listview-contacts.html:
2823 * mockups/listview-projects.html:
2824 * mockups/style.css: Add document title to mockups to keep things
2826 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2827 sizes to account for the document title.
2828 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2829 Set the document title when it has been retrieved from the server.
2830 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2831 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2832 and implement setDocumentTitle(String) method.
2833 * src/main/webapp/style.css: Add ID for document title style.
2835 2011-08-25 Ben Konrath <ben@bagu.org>
2837 Add NavigationType enum to LayoutItemPortal DTO.
2839 This is the start of adding support for Portals to the Details View.
2841 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2842 LayoutItem_Portal.navigation_type enum from libglom to
2843 LayoutItemPortal.NavigationType enum.
2844 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2845 NavigationType enum, field for storing the NavigationType and getter
2848 2011-08-25 Ben Konrath <ben@bagu.org>
2850 Implement the flow table layout in the Details View.
2852 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2853 FlowTable to Group to account for the renamed class.
2854 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2855 File. This is a container widget that implements the Glom details view
2856 flow table behaviour.
2857 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2858 org/glom/web/client/ui/FlowTable.java.
2859 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2860 so that the size of the subgroups are a closer match to the size of
2861 the Glom subgroups. This makes the flowtable layout match the layout
2862 in Glom for the Music Collection example file.
2864 2011-08-16 Ben Konrath <ben@bagu.org>
2866 Create container element for LayoutItemPortal in Details View.
2868 This will help me develop the layout for the FlowTable.
2870 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2871 fieldPanel variable to detailsCell.
2873 2011-08-15 Ben Konrath <ben@bagu.org>
2875 Set the height of the data element in the Details View.
2877 I changed the InlineLabels (text in a span element) to Labels (text in
2878 a div element) so that I could set the height of the details-data
2879 elements instead of the details-cell parent elements. This allows the
2880 the details-data element to display the correct height if style is
2881 applied that shows the height.
2883 This change has the added benefit of allowing the order of the labels
2884 and data elements to be changed for right-to-left languages.
2886 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2887 InlineLabels to Labels.
2888 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2889 InlineLabels to Labels. Set the height of the data element.
2890 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2891 multiline text height in the Formatting DTO.
2892 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2893 for multiline height along with getter and setter methods.
2894 * src/main/webapp/style.css: Adjust style to account for the change
2895 from span elements to div elements in the details cell.
2897 2011-08-15 Ben Konrath <ben@bagu.org>
2899 Make the List View appearance match the mockups.
2901 It doesn't match exactly but it's much better than it was.
2903 * mockups/listview-contacts.html: Remove unused css classes.
2904 * mockups/listview-projects.html: Remove unused css classes.
2905 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Display 15
2906 rows instead of 20. Rename vPanel to mainPanel. Use FlowPanel (div)
2907 for mainPanel instead of VerticalPanel (table). Set style name on
2908 CellTable. Set style name on Details column. Right-align Details
2910 * src/main/webapp/style.css: Adjust properties to match the mockups.
2912 2011-08-12 Ben Konrath <ben@bagu.org>
2914 Add better support for subgroups in the details view.
2916 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2917 changed FlowTable constructor.
2918 * src/main/java/org/glom/web/client/ui/FlowTable.java: Add better
2919 support for subgroups and subgroup-titles.
2920 * src/main/webapp/style.css: Add CSS class for subgroups and
2923 2011-08-12 Ben Konrath <ben@bagu.org>
2925 Return the top level LayoutGroup title.
2927 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2929 2011-08-11 Ben Konrath <ben@bagu.org>
2931 Make the TableSelector header match the mockup.
2933 * src/main/java/org/glom/web/client/OnlineGlom.java: Add a margin to
2934 the layout panel. Properly lineup the table selection header with
2935 the list and details view.
2936 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Remove the
2937 margin around the details view.
2938 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2939 Rename listBox variable to tableSelector. Set id for the style sheet.
2940 Use a FlowPanel instead of a HorizontalPanel.
2941 * src/main/webapp/style.css: Add properties to make the TableSelector
2942 box match the mockups.
2944 2011-07-13 Ben Konrath <ben@bagu.org>
2946 Update install script for java-libglom version change.
2948 * utils/install-onlineglom-war.sh: Also exit if 'make check' in
2951 2011-07-13 Ben Konrath <ben@bagu.org>
2953 Add support sub-group in the details view.
2955 I also removed the code that special-cased the default details view
2958 http://mail.gnome.org/archives/glom-devel-list/2011-July/msg00005.html
2960 I still have to make a proper flowtable.
2962 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2963 Don't special-case default details view layout.
2964 * src/main/java/org/glom/web/client/ui/DetailsView.java: Remove
2965 addLayoutField() as I'm going to use it.
2966 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Extract
2967 GroupPanel to FlowTable class. Remove unimplemented addLayoutField()
2969 * src/main/java/org/glom/web/client/ui/FlowTable.java: New class
2970 extracted from DetailsViewImpl.GroupPanel. Add support for
2972 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2973 column count when getting the details layout.
2975 2011-07-12 Ben Konrath <ben@bagu.org>
2977 Set browser title with database and table titles.
2979 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2980 Set the browser title when the table changes and when the activity
2982 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2983 title when retrieving document info (the GlomDocument object).
2984 * src/main/java/org/glom/web/shared/GlomDocument.java: Add title field
2985 with getter and setter methods. Remove unused convenience constructor.
2986 Use default code formatting.
2988 2011-07-12 Ben Konrath <ben@bagu.org>
2990 Ignore LayoutItemPortals in the details view.
2992 I added a new DTO for the LayoutItemPortal so that I can ignore it in
2995 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Ignore
2996 LayoutItemPortal layout objects.
2997 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Create
2998 LayoutItemPortal objects when retrieving the details layout.
2999 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: New
3000 file. This is an empty class and just used to get type information for
3003 2011-07-12 Ben Konrath <ben@bagu.org>
3005 Use java-libglom 1.17.0.
3009 2011-07-11 Ben Konrath <ben@bagu.org>
3011 Remove "Table:" label from table selector.
3013 This matches a recent change in the Glom UI.
3015 * mockups/details-contacts.html:
3016 * mockups/details-projects.html:
3017 * mockups/listview-contacts.html:
3018 * mockups/listview-projects.html: Remove the "Table:" label from the
3020 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3022 2011-07-11 Ben Konrath <ben@bagu.org>
3024 Add main groups to the details view.
3026 This makes things look a little nicer in the details view. The next step
3027 is to implement the flowtable.
3029 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Inherit only the
3030 resources from the standard gwt css theme. Standard.css is now
3031 included in OnlineGlom.html so that the online glom css rules have
3032 precedence over the gwt theme.
3033 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
3034 the whole LayoutGroup to the DetailsView instead of just the titles.
3035 * src/main/java/org/glom/web/client/ui/DetailsView.java:
3036 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Create the
3037 details layout with a helper class (GroupPanel). I might extract this
3038 class when I make the full flowtable.
3039 * src/main/java/org/glom/web/shared/layout/LayoutItem.java: Add empty
3040 string as default so I don't have to worry about NPEs when processing
3042 * src/main/webapp/OnlineGlom.html: Add the gwt standard css file (see
3043 note beside OnlineGlom.gwt.xml above).
3044 * src/main/webapp/style.css: Add default font-size to body to override
3045 the font-size set by the standard theme. Don't use h2 tags for
3046 group-title. Create new details-cell class.
3048 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3050 ConfiguredDocument: Set the port number too.
3052 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3053 (ConfiguredDocument.ConfiguredDocument): Get the port number from the
3054 Glom document. Presumably this worked sometimes so far because there is a
3055 default port number.
3057 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3059 ConfiguredDocument: Warn that sqlite and self-hosting are not supported.
3061 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3062 (ConfiguredDocument.ConfiguredDocument): Check that the hosting mode is
3063 correct, though we should throw an exception too.
3065 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3067 Fix a addDocuemnt typo.
3069 * src/main/java/org/glom/web/shared/Documents.java
3070 (Documents.addDocuemnt): Rename to addDocument().
3071 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
3072 (OnlineGlomServiceImpl.getDocuments): Adapt.
3074 2011-07-08 Murray Cumming <murrayc@murrayc.com>
3076 Slightly improved log output when connection fails.
3078 * src/main/java/org/glom/web/server/ConfiguredDocument.java
3079 (ConfiguredDocument.setUsernameAndPassword):
3080 We don't know for sure if it' the username/password that's wrong, so
3081 rephrase the message.
3082 Also ouput the exception message, though it's generic in this case.
3084 2011-07-08 Ben Konrath <ben@bagu.org>
3088 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also
3089 added braces to a one line if statement because the Eclipse formatter
3090 was getting confused.
3092 2011-07-07 Ben Konrath <ben@bagu.org>
3094 Update project config files for Eclipse 3.7 and use GWT 2.3.0.
3096 These should really be two separate tasks but I counldn't get things to
3097 work with GWT 2.2.0 and Eclipse 3.7.
3101 * .settings/org.eclipse.jdt.core.prefs:
3102 * .settings/org.eclipse.jdt.ui.prefs:
3103 * .settings/org.eclipse.ltk.core.refactoring.prefs:
3104 * .settings/org.eclipse.m2e.core.prefs:
3105 Add new config files. Update current files. Remove references to the
3106 webtools plugins as we're not using any of the webtools features.
3107 * .gitignore: Add logs directory which is created when running with
3109 * pom.xml: Update to GWT 2.3.0. Eclipse configuration was automatically added.
3110 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Moved from
3111 src/main/resources/org/glom/web/OnlineGlom.gwt.xml as per this known
3113 http://mojo.codehaus.org/gwt-maven-plugin/eclipse/google_plugin.html#Limitations
3115 2011-07-07 Murray Cumming <murrayc@murrayc.com>
3117 onlineglom.properties: Add explanatory comments.
3119 * src/main/resources/onlineglom.properties: Also change the default user
3120 from ben to someuser, to avoid the risk of people thinking we just
3121 stupidly hard-coded a locale path, when they see that on stderr or in a log.
3123 2011-06-28 Ben Konrath <ben@bagu.org>
3125 Use filename in Log for incorrect passwords.
3127 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
3128 getFileName(String) method to get the filename from the URI.
3130 2011-06-28 Ben Konrath <ben@bagu.org>
3132 Add the table name to the URL token for the ListPlace.
3134 This makes things consistent between the DetailsPlace and the
3135 ListPlace. It also allows the the ListPlace to be bookmarked.
3137 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3138 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3139 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3140 Remove getDefaultListLayout(). The default layout is now returned
3141 by the getListLayout() method when the table name is an empty string.
3142 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3143 Add table name field. Change to a new ListPlace when the table
3144 has been changed. Use getListLayout() for getting the default
3146 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3147 Add table name field. Set the correct table name in the list box
3148 when loading from bookmark. This corrects a problem for the
3150 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3151 Move table name to super-class (HasSelectableTable). Move document
3152 and table URL keys to super-class in HasSelectableTable.
3153 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3154 Add table name field. Add Tokenizer class with URL key common to
3155 the subclasses (DetailsPlace and ListPlace).
3156 * src/main/java/org/glom/web/client/place/ListPlace.java:
3157 Add table name. Add code to parse the URL token.
3158 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3159 Update ListPlace construction with empty table name string.
3160 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3161 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3162 Change setTableSelectedIndex(int) to setSelectedTableName(String).
3163 Update ListPlace construction with table name string.
3164 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
3165 Change defaultTableName field to tableName to reflect how it's now
3166 used. Update the getter and setter methods.
3168 2011-06-28 Ben Konrath <ben@bagu.org>
3170 Enable the table selector in the DetailsView.
3172 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3173 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3174 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3175 Remove getDefaultDetailsLayout(). The default layout is now returned
3176 by the getDetailsLayout() method when the table name is an empty
3178 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3179 event handler for table change event. Change to using
3180 getDetailsLayout() for the default details layout.
3181 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add table
3183 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Use table
3184 when navigating to the details place.
3186 2011-06-27 Ben Konrath <ben@bagu.org>
3188 Use filename based unique document ID in URL and for RPC.
3190 The document ID is the glom document name with spaces (' ') replaced
3191 with pluses ('+') and without the .glom extension.
3193 This change is mostly a string substitution of 'documentTitle' for
3194 'documentID'. The only code change is the addition of a Documents DTO to get the
3195 filename to document title mappings as indicated below.
3197 * src/main/java/org/glom/web/client/OnlineGlomService.java:
3198 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
3199 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
3200 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
3201 Use Documents DTO to create the document links in the document
3203 * src/main/java/org/glom/web/client/activity/ListActivity.java:
3204 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
3205 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
3206 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
3207 * src/main/java/org/glom/web/client/place/ListPlace.java:
3208 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
3209 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
3210 * src/main/java/org/glom/web/client/ui/ListView.java:
3211 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
3212 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
3213 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
3214 * src/main/java/org/glom/web/server/Log.java:
3215 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Change
3216 getDocumentTitles() to getDocuments() and return the Documents DTO.
3217 * src/main/java/org/glom/web/shared/Documents.java: New DTO for
3218 transferring the filename to document title mappings.
3220 2011-06-25 Ben Konrath <ben@bagu.org>
3222 Make the authentication popup work again.
3224 This bug was introduced when I extracted ConfiguredDocument to its own class.
3226 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Return the
3227 correct success / fail status in setUsernameAndPassword().
3229 2011-06-25 Ben Konrath <ben@bagu.org>
3231 Use filename as unique key for configuring database usernames and passwords.
3233 This replaces the use of the Glom document title which could change
3234 depending on the locale. Thanks to Murray Cumming for pointing out this
3237 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
3238 * src/main/resources/onlineglom.properties:
3240 2011-06-24 Ben Konrath <ben@bagu.org>
3242 Pass primary key value to DetailsView.
3244 This enables the DetailsView to load the correct data.
3246 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
3247 primary key value field and set in constructor. Pass primary key
3248 value to getDetailsData().
3249 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Add URL