3 2012-05-16 Murray Cumming <murrayc@murrayc.com>
5 Use translations for top-level groups too.
7 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
8 updateTitlesForLocale(): Use the translation for the group
9 as well as for child items.
13 Just recompiled to fix a problem in the released .tar.gz file.
17 2012-05-15 Murray Cumming <murrayc@murrayc.com>
19 Corrections to navigation to related records.
21 * src/main/java/org/glom/web/client/OnlineGlomService.java:
22 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
23 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
24 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
25 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
26 relationship name, because the relationship name is not necessarily unique
28 TOOD: This is inefficient, because it passes the whole list of
29 child field items back to the server, but it is more correct, and happens
30 to fix a bug with the primary key being lost after a few navigations.
31 There is probably a chance to make this more efficient anyway in some
34 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
35 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
36 * src/main/java/org/glom/web/server/ConfiguredDocument.java
37 * src/main/java/org/glom/web/server/database/DBAccess.java
38 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
39 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
42 2012-05-15 Murray Cumming <murrayc@murrayc.com>
44 Fix the use of translations.
46 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
47 Add updateTitlesForLocale().
48 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
49 Call it to discard unwanted translations and to make getTitle() return
50 the wanted translation wihout the need for the client code to specify a locale.
51 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
52 getTitle(): Fallback to the original title, as libglom does.
54 2012-05-15 Murray Cumming <murrayc@murrayc.com>
56 Document: Correctly report the number of available translation locales.
58 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
59 the available locale IDs list.
60 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
61 testLocales: Test this.
63 2012-05-15 Murray Cumming <murrayc@murrayc.com>
65 SqlUtils: Use camelCase.
67 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
68 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
69 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
70 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
71 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
72 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
74 2012-05-15 Murray Cumming <murrayc@murrayc.com>
76 Use jOOQ's tableByName() and fieldByName.
78 * pom.xml: Use jOOQ 2.3.1 to get the new API.
79 * src/main/java/org/glom/web/server/SqlUtils.java:
80 build_sql_select_step_with_where_clause(), .createField(),
81 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
82 so we can get correct quoting and escaping. Thanks to Lukas Eder for
83 adding this, and other things, to jOOQ.
85 2012-05-15 Murray Cumming <murrayc@murrayc.com>
87 SqlUtils: Remove the Connection parameters.
89 * src/main/java/org/glom/web/server/SqlUtils.java:
90 build_sql_select_with_key(), build_sql_select_with_where_clause(),
91 createSelect(), build_sql_select_step_with_where_clause(),
92 build_sql_count_select_with_where_clause(),
93 build_sql_select_count_rows(): Remove the Connection parameter because
94 jOOQ does not actually need a connectionwhen it is just used to build
96 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
98 * src/main/java/org/glom/web/server/ReportGenerator.java:
100 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
102 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
103 Constructor, getListData(), getResultSizeOfSQLQuery():
104 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
105 getSelectQuery(), getCountQuery():
106 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
107 getSelectQuery(), getCountQuery():
108 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
109 getNavigationRecord(): Adapted.
111 2012-05-14 Murray Cumming <murrayc@murrayc.com>
115 * src/main/java/org/glom/web/server/SqlUtils.java:
116 get_find_where_clause_quick(): Use a comparison of
117 lowercase values, instead of a simple equals. Regular Glom
118 uses the PostgreSQL ILIKE operator but jOOQ does not
119 support that just yet, though it will soon.
121 2012-05-14 Murray Cumming <murrayc@murrayc.com>
123 TableToViewDetails: Use a real serialization ID.
125 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
126 Though this does not fix the serialization problem.
128 2012-05-12 Murray Cumming <murrayc@murrayc.com>
130 Added LayoutItemPortalDeepCloneTest.
132 2012-05-11 Murray Cumming <murrayc@murrayc.com>
134 Make navigation work again.
136 * src/main/java/org/glom/web/server/libglom/Document.java:
137 Add getLayoutItemFieldShouldHaveNavigation().
138 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
139 Replace get/setAddNavigation() with the partly-existing
140 get/setNavigationTableName(), with an empty string being no navigation,
141 because this is simpler. Use the new
142 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
144 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
145 Add updateFieldsExtras() and call setNavigationTableName in it.
146 getDetailsLayoutGroup(),
147 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
148 createLayout(): Adapted.
149 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
150 Constructor: Adapted.
152 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
153 Replace get/setAddNavigation() with get/setNavigation(), returning a
154 TableToViewDetails class with both the table name and UsesRelationship,
155 because both are need. The previous code used java-libglom's output
156 variable (strangely, via sharedptr) to return both, but we cannot really
158 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
159 getNavigationRecord(): Adapt. However, we cannot actually use the cache
160 here because it somehow gets set to null during deepCopy(). I must test this.
161 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
162 testGetSuitableTableToViewDetails(): Adapted.
164 TODO: Find out why deepClone() is not quite working.
166 2012-05-11 Murray Cumming <murrayc@murrayc.com>
168 DBAccess: Simplify the retrievel of full field details.
170 * src/main/java/org/glom/web/server/database/DBAccess.java
171 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
172 because the Document loading should have done this.
174 2012-05-11 Murray Cumming <murrayc@murrayc.com>
176 Document: Correct loading of doubly-related layout fields.
178 * src/main/java/org/glom/web/server/libglom/Document.java:
179 loadUsesRelationship(): Actually set the related relationship, instead
180 of only setting it if it's not found.
182 2012-05-09 Murray Cumming <murrayc@murrayc.com>
184 Replace all appearances of Colour with color.
186 Because US English is dominant.
188 2012-05-09 Murray Cumming <murrayc@murrayc.com>
190 Use colors in HTML format, solving a warning about an unused function.
192 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
193 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
194 Add *asHTMLColor() versions of methods.
195 TODO: However, we should create and cache the results on the server.
196 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
197 * src/main/java/org/glom/web/client/ui/list/ListTable.java
198 * src/main/java/org/glom/web/server/ConfiguredDocument.java
199 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
200 Use the asHTMLcolor() versions.
202 2012-05-09 Murray Cumming <murrayc@murrayc.com>
204 ListViewTable: Constructor: Take the table name as a parameter.
206 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
207 Constructor: Take the tableName, and set the member variable, because
209 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
210 setCellTable(): Pass the table name.
211 This makes navigation to non-default tables work again. I don't know
212 why it worked before in the master branch.
214 2012-05-07 Murray Cumming <murrayc@murrayc.com>
216 ConfiguredDocument: Restore correct addition of hidden primary key items.
218 * src/main/java/org/glom/web/client/ui/list/ListTable.java
219 (ListTable.createCellTable): Uncomment out the check for the hidden
221 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
222 add primary key items for top-level lists and portals, as before,
223 instead of adding them to each group.
224 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
225 Actually implement the extra methods such as setHiddenPrimaryKey() and
226 comment that these are used only for top-level list groups and in portals.
227 This strangeness suggests even more that this should not be squeezed
228 into the LayoutGroup class.
230 2012-05-07 Murray Cumming <murrayc@murrayc.com>
232 Fix Formatting loading.
234 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
235 getFormattingUsed(): Remove the duplicate Formatting member variable
236 in favour of the one from the base class.
237 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
238 Initialize a new Formatting instead of using null by default, so we
239 have some defaults, instead of having to initialize one later just to
240 get the same defaults. This also makes loading of formatting from the
241 document work, because that expected a non-null.
243 2012-05-07 Murray Cumming <murrayc@murrayc.com>
245 RelatedListTable: Make sure that the tableName is set.
247 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
248 Constructor: Take the tableName so it is available later. Otherwise,
249 the server assumes that we mean the default table and cannot find the
251 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
252 setData(): Pass the tableName to the RelatedListTable constructor.
254 2012-05-07 Murray Cumming <murrayc@murrayc.com>
258 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
259 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
260 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
262 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
264 * src/main/java/org/glom/web/server/database/DBAccess.java:
265 convertResultSetToDTO(), getPortal():
266 * src/main/java/org/glom/web/server/database/ListDBAccess.java
268 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
269 Add checks for null objects and out of range access, with log messages to
270 give hints so we can fix these properly.
272 2012-05-07 Murray Cumming <murrayc@murrayc.com>
274 Portals: some corrections.
276 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
278 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
279 constructor: Use getRelationshipNameUsed() instead of getName(), because
280 that is what is meant.
281 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
282 getFromField(): Fix a typo, to get the field name, not the table name.
283 * src/main/java/org/glom/web/server/database/DBAccess.java:
284 getPortal(): Fix a typo that stopped this from working.
286 2012-05-07 Murray Cumming <murrayc@murrayc.com>
288 LayoutItemPortal: Also override getTitleOriginal().
290 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
291 This lets the base getTitle() with no parameters work.
292 TODO: Test this properly.
294 2012-05-06 Murray Cumming <murrayc@murrayc.com>
296 LayoutItemPortal: getTitle*(): Use the relationship title.
298 2012-05-06 Murray Cumming <murrayc@murrayc.com>
300 LayoutItemField: Fix loading of custom titles.
302 * src/main/java/org/glom/web/server/libglom/Document.java
303 loadDataLayoutItemField(): The title, if any, instead of the field
304 title, is stored in a title_custom node. Load it from there.
305 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
307 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
308 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
309 getTitle*() overrides.
310 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
313 2012-05-06 Murray Cumming <murrayc@murrayc.com>
315 LayoutItemField: Fall back to field titles, so some are really shown.
317 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
318 Override getTitleOriginal() and getTitle(), as in java-libglom.
319 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
322 2012-05-06 Murray Cumming <murrayc@murrayc.com>
324 Correct use of setExpectedResultSize().
326 * src/main/java/org/glom/web/server/ConfiguredDocument.java
327 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
328 Use setExpectedResultSize only on top-level groups (for instance, the
329 list layout) or on child portals (in details views).
330 Use the correct table name for portals to avoid SQL errors.
331 Update the expected counts when returning cached layouts.
333 2012-05-06 Murray Cumming <murrayc@murrayc.com>
335 Document: Interpret no group column count as 1.
337 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
338 default, though we now check for this in the UI code anyway.
340 2012-05-06 Murray Cumming <murrayc@murrayc.com>
344 2012-05-06 Murray Cumming <murrayc@murrayc.com>
346 Translatable: Use Hashmap instead of Treemap because GWT supports it.
348 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
349 The use of Treemap lead to this error from async methods, with no
351 "The response could not be deserialized"
353 2012-05-06 Murray Cumming <murrayc@murrayc.com>
355 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
357 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
358 when using the Google -> GWT Compile, or
359 g toolbar button -> GWT Compile Project... feature in Eclipse.
361 2012-05-06 Murray Cumming <murrayc@murrayc.com>
363 ListTable.addColumn(): Protect against a null Formatting.
365 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
366 Create a default Formatting if it is null, because that is the simplest
369 2012-05-06 Murray Cumming <murrayc@murrayc.com>
371 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
373 * src/main/java/org/glom/web/server/ConfiguredDocument.java
374 updateLayoutGroup(): Check that the field is not null.
376 2012-05-06 Murray Cumming <murrayc@murrayc.com>
378 ListViewImpl: Protected against a bad cast error.
380 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
381 onEnterKeyDown(): Do not cast without an instanceof check.
383 2012-05-06 Murray Cumming <murrayc@murrayc.com>
385 ListTable: Protect against an out of range error.
387 * src/main/java/org/glom/web/client/ui/list/ListTable.java
388 createCellTable(): This is unlikely, but can happen while debugging.
390 2012-05-06 Murray Cumming <murrayc@murrayc.com>
392 AsyncMessage onFailure() callbacks: Log the exception message.
394 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
395 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
396 * src/main/java/org/glom/web/client/activity/ListActivity.java:
397 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
398 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
399 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
400 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
401 These are useful clues when something is wrong.
403 2012-05-06 Murray Cumming <murrayc@murrayc.com>
405 ConfiguredDocument: Avoid a null dereference.
407 * src/main/java/org/glom/web/server/ConfiguredDocument.java
408 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
409 details maps are created.
411 2012-05-06 Murray Cumming <murrayc@murrayc.com>
413 Document: Correct the port number parsing.
415 * src/main/java/org/glom/web/server/libglom/Document.java:
416 This lets us actually connect to the database and show the document.
418 2012-05-05 Murray Cumming <murrayc@murrayc.com>
422 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
423 user-interaction, asking us to load a temporary URL in a browser.s
424 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
425 which is apparently necessary for testing the service. See the comment.
426 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
427 Show the exception, if any. This is how I saw the 404 in the HTML in
430 2012-05-05 Murray Cumming <murrayc@murrayc.com>
432 DocumentTest: Move the .glom files into the resources directory.
434 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
435 URI via getResource().
437 2012-05-05 Murray Cumming <murrayc@murrayc.com>
439 Document: Remove the FieldIdentifies inner class.
441 * src/main/java/org/glom/web/server/libglom/Document.java: We only
442 use the Relationship (though the same function in libglom is maybe
443 used in other ways) and so this removes a compiler warning.
445 2012-05-05 Murray Cumming <murrayc@murrayc.com>
447 Document.load() Remove the error code parameter.
449 * src/main/java/org/glom/web/server/libglom/Document.java: load():
450 Remove the parameter. We do not set it yet and it could never have
451 worked as an output parameter (though maybe it did in java-libglom).
452 We could use an exception if we really want the failure reason.
453 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
455 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
456 setUp(), testGetSuitableTableToViewDetails(): Adapt.
458 2012-05-05 Murray Cumming <murrayc@murrayc.com>
460 Make some inner classes static.
462 * src/main/java/org/glom/web/server/ConfiguredDocument.java
463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
464 * src/main/java/org/glom/web/server/ReportGenerator.java
465 * src/main/java/org/glom/web/server/libglom/Document.java
466 Make all inner classes static that can be static.
468 2012-05-05 Murray Cumming <murrayc@murrayc.com>
470 OnlineGlomServiceImpl: Do not load and check for java-libglom.
472 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
473 init(): We do not use java-libglom any more.
475 2012-05-05 Murray Cumming <murrayc@murrayc.com>
477 Remove mentions of java-libglom.
479 * README: Remove mention of java-libglom, because it no longer needed.
480 * utils/build-onlineglom-war.sh:
481 * utils/check-and-recover-tomcat.py:
482 * utils/install-onlineglom-war.sh: Remove these as they are no longer
483 useful. Building is now far easier, with no need for jhbuild.
485 2012-05-05 Murray Cumming <murrayc@murrayc.com>
487 Fix the build (mvn package)
489 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
490 (LayoutGroup): Make the LayoutItemList inner class static and protected.
491 Otherwise the GWT Java->Javascript compilation fails with just this
492 error, during mvn package or when attempting to view in a browser,
493 in the GWT developer mode in Eclipse.
495 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
496 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
497 [INFO] Compiling module org.glom.web.OnlineGlom
498 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
499 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
500 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
501 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
502 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
503 [INFO] [ERROR] Cannot proceed due to previous errors
505 It has taken me 2 days to find out what was causing that. After reducing
506 the code, the compiler eventually showed me the full error message.
508 2012-05-04 Murray Cumming <murrayc@murrayc.com>
510 ConfiguredDocument: Cache the cloned and stripped layouts.
512 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
513 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
514 layout in a map, so we can retrieve it again without rebuilding it.
516 2012-05-04 Murray Cumming <murrayc@murrayc.com>
518 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
520 2012-05-04 Murray Cumming <murrayc@murrayc.com>
522 libglom classes: Implement some auto-generated emthods.
524 2012-05-04 Murray Cumming <murrayc@murrayc.com>
526 Add GwtTestOnlineGlomService.
528 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
529 However, this (and the other GwtTest*) does not seem to run during
532 2012-05-04 Murray Cumming <murrayc@murrayc.com>
534 Remove use of unsupported features from client code.
536 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
537 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
538 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
539 Use our client version of StringUtils instead of the apache commons one.
541 However, the GWT Javascript compliation still fails.
543 2012-04-25 Murray Cumming <murrayc@murrayc.com>
545 Add a Field class and implement some loading of it in Document.
547 2012-04-25 Murray Cumming <murrayc@murrayc.com>
549 Initial Document loading implementation, instead of libglom.
551 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
552 and Translatable classes, and adapt the rest of the code to use them.
553 However, this is still missing Layout and Field classes and loading.
555 2012-04-24 Murray Cumming <murrayc@murrayc.com>
557 Use of jOOQ: Move Field creation into a utility method.
559 * src/main/java/org/glom/web/server/SqlUtils.java:
560 This lets us improve it more easily.
562 2012-04-24 Murray Cumming <murrayc@murrayc.com>
564 Use of jOOQ: Improve the code to COUNT a sub-select.
566 * src/main/java/org/glom/web/server/SqlUtils.java:
567 Move initial query creation into
568 build_sql_select_step_with_where_clause().
569 build_sql_select_count_rows(): Use the jOOQ API instead of
570 concatentating text, because a jOOQ Select*Step is a TableLike,
571 which is what from() takes.
573 2012-04-23 Murray Cumming <murrayc@murrayc.com>
575 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
577 * pom.xml: Depend on jooq.
578 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
579 methods with jOOQ, based on the C++ implementations in libglom,
580 with some changes to the logic required by jooQ.
581 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
583 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
584 * src/main/java/org/glom/web/server/ReportGenerator.java:
585 * src/main/java/org/glom/web/server/SqlUtils.java:
586 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
587 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
588 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
589 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
590 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
591 Adapt. In particular, the SqlUtils methods now need to take a Connection,
592 because jOOQ needs that, though it seems unnecessary.
594 This is not quite finished. Ideally jOOQ would help us to build
595 table_name.field_name names, quoting and escaping them properly.
596 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
598 2012-04-21 Murray Cumming <murrayc@murrayc.com>
600 Move use of Glom.build_sql*() into a new SqlUtils class.
602 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
603 to wrap Glom.build_sql*(). The parameter types are still Glom one,
604 but this will make it easier to start using something other than
605 libglom or SqlBuilder.
607 2012-04-21 Murray Cumming <murrayc@murrayc.com>
609 Update the project URL.
611 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
613 2012-04-21 Murray Cumming <murrayc@murrayc.com>
615 Main layout: Use a FlowTable instead of absolute positioning.
617 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
618 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
619 child panels/widgets must have an absolute position. But that is annoying, so
620 this adds a FlowTable and puts the child panels in there.
622 2012-04-21 Murray Cumming <murrayc@murrayc.com>
624 GwtTestOnlineGlom: Comment out unused code.
626 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
627 Eclipse has started to say that some code is unused.
629 2012-04-21 Murray Cumming <murrayc@murrayc.com>
631 Update to the latest versions of dependencies.
633 * pom.xml: Update version numbers of dependencies to the latest
635 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
636 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
637 * src/main/java/org/glom/web/server/ReportGenerator.java:
638 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
639 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
640 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
642 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
643 Modify the imports where necessary.
645 2012-04-17 Murray Cumming <murrayc@murrayc.com>
647 Style: Remove overflow:hidden from searchbox
649 * src/main/webapp/style.css: Because this pushes the Back To Link
650 label/link on to the next row, which is then hidden due to the
651 hard-coded (in ems) height.
653 2012-04-20 Murray Cumming <murrayc@murrayc.com>
655 Remove some duplicate code.
657 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
658 getDocumentInfo(): This must have been duplicated during the merge from the
663 2012-04-19 Murray Cumming <murrayc@murrayc.com>
665 Reports: Localize the waiting for report message.
667 * src/main/java/org/glom/web/client/activity/ReportActivity.java
668 start(): Get the message from the contants.
669 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
671 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
672 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
673 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
674 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
675 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
676 Update these files with the English text for newer strings for now.
678 2012-04-19 Murray Cumming <murrayc@murrayc.com>
680 Reports: Show a message while waiting for the report.
682 * src/main/java/org/glom/web/client/ui/ReportView.java
683 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
684 Add setWaitingText(), to show a message saying that we are
685 waiting for the report to be ready.
686 * src/main/java/org/glom/web/client/activity/ReportActivity.java
687 start(): Call setWaitingText() before calling the async
690 2012-04-19 Murray Cumming <murrayc@murrayc.com>
692 ReportGenerator: Specify date and time formats.
694 * src/main/java/org/glom/web/server/ReportGenerator.java:
695 createFieldValueElement(): Use the default (and localized)
696 short formats, though we still need a way to show 4-digit
697 years without providing the format for every locale.
698 * src/main/java/org/glom/web/server/database/DBAccess.java:
699 convertResultSetToDTO(): Use the short formats here too.
701 2012-04-18 Murray Cumming <murrayc@murrayc.com>
703 ReportGenerator: Use the correct numeric formatting.
705 * src/main/java/org/glom/web/server/ReportGenerator.java
706 createFieldExpression(), createFieldValueElement(): Take the
707 whole LayoutItem_Field instead of just the field name, so
708 we have access to the formatting.
709 createFieldValueElement(): Use JRTextField.setPattern() to
710 specify the numeric formatting, with the help of a
711 regular DecimalFormat.
713 2012-04-18 Murray Cumming <murrayc@murrayc.com>
715 ReportGenerator: Avoid showing null for group by titles.
717 * src/main/java/org/glom/web/server/ReportGenerator.java
718 generateReport(): Use setBlankWhenNull() on the field title
719 style too, because this is used for values in group by
722 2012-04-18 Murray Cumming <murrayc@murrayc.com>
724 ReportGenerator: Add a colon to titles in vertical groups.
726 * src/main/java/org/glom/web/server/ReportGenerator.java
727 addFieldToDetailBandVertical(): Pass true for the withColon
730 2012-04-18 Murray Cumming <murrayc@murrayc.com>
732 ReportGenerator: Simplify the code by using Position more.
734 2012-04-18 Murray Cumming <murrayc@murrayc.com>
736 Reports: Support vertical groups, roughly.
738 * src/main/java/org/glom/web/server/ReportGenerator.java:
739 addToReport(): Rename to addGroupToReport() and, if necessary,
740 call the new addVerticalGroupToReport() method.
741 createFieldValueElement(): Let the caller specify the Y position
744 2012-04-17 Murray Cumming <murrayc@murrayc.com>
746 Reports: Allow a second report to be shown.
748 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
749 clear(): Do not remove the HTML widget, which broke the whole layout.
751 2012-04-17 Murray Cumming <murrayc@murrayc.com>
753 Locales drop-down: Show that we use English by default.
755 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
756 fillView(): When we use English, just because that is the default, when
757 no locale is specified, show that in the Locales drop-down instead of
758 just showing the first item.
760 2012-04-17 Murray Cumming <murrayc@murrayc.com>
762 Unselect the Report/Locale/Table combo item when appropriate.
764 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
765 setPlace(): clear reportName if this is not a ReportPlace.
766 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
767 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
768 When the provided name is empty, unselect all items, so that none are
769 indicated. This uses a for loop because I cannot find a single method
772 2012-04-17 Murray Cumming <murrayc@murrayc.com>
774 Report: Give the user a way to get back to the list.
776 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
777 start(), setPlace(): Show the Back To List link on reports, and also
778 interpret selecting the empty report item as back to list.
780 2012-04-13 Murray Cumming <murrayc@murrayc.com>
782 Really show the selected Report name.
784 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
785 setPlace(): Store the reportName here, if it is that kind of Place.
786 fillView(): Set the selected Report after filling the list of reports.
787 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
788 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
789 null Strings, though we need some way to unselect all ListBox items
792 2012-04-13 Murray Cumming <murrayc@murrayc.com>
794 ReportGenerator: Try to avoid some problems.
796 * src/main/java/org/glom/web/server/ReportGenerator.java
797 addField(): Try to avoid duplicates, and avoid using a null
800 2012-04-13 Murray Cumming <murrayc@murrayc.com>
802 Reports: Use quickFind.
804 * src/main/java/org/glom/web/client/OnlineGlomService.java;
805 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
806 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
807 getReportHTML(): Add a quickFind parameter.
808 * src/main/java/org/glom/web/client/activity/ReportActivity.java
809 start(): Pass the quickFind parameter.
810 * src/main/java/org/glom/web/server/ReportGenerator.java
811 generateReport(): Take a quickFind parameter.
813 2012-04-13 Murray Cumming <murrayc@murrayc.com>
815 ReportPlace: Actually use the report name.
817 * src/main/java/org/glom/web/client/place/ReportPlace.java
818 getPlace(): Do not assign the report name to the quickfind.
820 2012-04-13 Murray Cumming <murrayc@murrayc.com>
822 Show java.library.path when complaining.
824 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
825 init(): When telling us to check java.library.path, show the
828 2012-03-06 Murray Cumming <murrayc@murrayc.com>
830 ReportGenerator: Do not show nulls.
832 2012-03-06 Murray Cumming <murrayc@murrayc.com>
834 ReportGenerator: Make the title font larger.
836 2012-03-06 Murray Cumming <murrayc@murrayc.com>
838 ReportGenerator: Put field titles inside groups, if there are groups.
840 2012-03-06 Murray Cumming <murrayc@murrayc.com>
842 ReportGenerator: Take the Report itself instead of the name and group.
844 * src/main/java/org/glom/web/server/ConfiguredDocument.java
845 Remove getReportLayoutGroup().
846 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
847 getReportHTML(): Pass the report instead
848 of its name and layout group.
849 * src/main/java/org/glom/web/server/ReportGenerator.java
850 generateReport(): Use the report object to use the title
853 2012-03-06 Murray Cumming <murrayc@murrayc.com>
855 ReportGenerator: Remove designBand parameters.
857 * src/main/java/org/glom/web/server/ReportGenerator.java:
858 Make designBand a class member instead of passing it to all
861 2012-03-06 Murray Cumming <murrayc@murrayc.com>
863 ReportGenerator: Add lines, a bit like in the desktop version.
865 * src/main/java/org/glom/web/server/ReportGenerator.java
866 addToReport(): Use JRDesignLine.
868 2012-03-06 Murray Cumming <murrayc@murrayc.com>
870 ReportGenerator: Correct the title positions and use some bold style.
872 * src/main/java/org/glom/web/server/ReportGenerator.java:
873 Break the code up into reusable functions, correct the placement of
874 titles, and use normal/bold styles as in the reports in the desktop
877 2012-03-06 Murray Cumming <murrayc@murrayc.com>
879 ReportGenerator: Add a header band to show the field titles.
881 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
882 getReportHTML(): Pass the localeId to the ReportGenerator
884 * src/main/java/org/glom/web/server/ReportGenerator.java
885 constructor: Take the localeID so we can get translated field
887 generateReport(), addToReport(), addFieldToBand(): Add field
888 titles in a column header band.
890 2012-03-05 Murray Cumming <murrayc@murrayc.com>
892 Reports drop-down list: Some improvement.
894 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
895 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
896 Adedd setSelectedReport(),
897 setReportList(): Add a blank line so that the user can select the
899 * src/main/java/org/glom/web/client/activity/ReportActivity.java
900 start(): Show the current report by calling setSelectedReport().
901 This does not seem to work yet.
903 2012-03-05 Murray Cumming <murrayc@murrayc.com>
905 DetailsActivity, ListActivity: Move some variables into a base class.
907 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
908 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
909 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
910 the clientFactory, documentID, tableName and authenticationPopup into
911 a base class, to avoid duplication.
913 2012-03-05 Murray Cumming <murrayc@murrayc.com>
915 Translate the Reports label.
917 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
918 Get the "Reports" label string from the constants.
919 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
920 perties: Add Reports to the constants.
922 2012-03-05 Murray Cumming <murrayc@murrayc.com>
924 Reports: Implement grouping.
926 * src/main/java/org/glom/web/server/ReportGenerator.java:
927 Handle LayoutItem_GroupBy items and try to do the right thing
928 with JRDesignGroup. It seems to work.
930 2012-03-04 Murray Cumming <murrayc@murrayc.com>
932 Actually show some data with JasperReports.
934 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
935 getReportHTML(): Move most code into a ReportGenerator class.
936 * src/main/java/org/glom/web/server/ReportGenerator.java:
937 Recurse into sub-groups, adding fields to the JasperDesign's details
938 band. Note that we must set an arbitrary width and height, or it just
939 will not show any data.
941 2012-03-04 Murray Cumming <murrayc@murrayc.com>
943 Reports Chooser: Show the titles, not the names.
945 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
946 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
947 and the names as the values.
948 * src/main/java/org/glom/web/server/ConfiguredDocument.java
949 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
950 group now that we provide the report name, so it should always
953 2012-02-15 Murray Cumming <murrayc@murrayc.com>
955 Depend on jasperreports.
957 * pom.xml: Add the dependency. My plan is to use this on the
960 2012-01-31 Murray Cumming <murrayc@murrayc.com>
962 Implement navigation to report places.
964 * src/main/java/org/glom/web/client/activity/ReportActivity.java
965 start(): Do not bother to handle all events here.
966 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
967 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
968 Added getSelectedReport().
969 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
970 .java: start(): When handling a change to the reports chooser,
971 call getSelectedReport() and goTo() its ReportPlace.
972 * src/main/java/org/glom/web/client/ui/ReportView.java
973 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
974 Added setReportHTML() which puts the html in a gwt HTML widget.
975 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
976 getReportHTML(): Return "TODO" just to show that this works.
978 2012-01-31 Murray Cumming <murrayc@murrayc.com>
980 Make ReportPlace usable.
982 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
984 * src/main/java/org/glom/web/client/place/ReportPlace.java:
985 Correct the @prefix annotation.
987 2012-01-31 Murray Cumming <murrayc@murrayc.com>
989 OnlineGlomService: Return report HTML rather than the LayoutGroup.
991 * src/main/java/org/glom/web/client/OnlineGlomService.java:
992 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
993 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
994 Change getReportLayout() to getReportHMTL() because we will not need to
995 parse or render the report layout on the client side.
996 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
997 getReportLayout(): Return the libglom LayoutGroup type because we will
998 not need to convert to a shared type, because this will not be used on
1000 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1003 Note that there is still no implementation for this.
1006 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1008 Add a (empty) Report Place, View, and Activity.
1010 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1012 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1013 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1014 this into a superclass:
1015 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1016 and also use it as the base of this new ReportPlace:
1017 * src/main/java/org/glom/web/client/place/ReportPlace.java
1019 * src/main/java/org/glom/web/client/ui/ReportView.java
1020 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1021 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1022 Add these, containing mostly boiler-plate for now.
1024 * src/main/java/org/glom/web/client/OnlineGlomService.java
1025 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1026 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1027 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1028 Add API to get the LayoutGroup for the report.
1030 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1032 Add and fill a Reports drop-down list box.
1034 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1036 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1037 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1038 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1039 Added getReports(document, table, localeID), calling
1040 ConfiguredDocument.getReports().
1041 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1042 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1043 Added setReportsList() and a list widget.
1044 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1045 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1050 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1052 Translations: Add Esperanto.
1054 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1055 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1056 properties: Add this translation because someone took the time to make it.
1058 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1060 Adapt to the java-libglom 1.21.7 API.
1062 * src/main/java/org/glom/web/server/ReportGenerator.java:
1063 addToReport(): get_group_secondary_fields() is now
1064 get_secondary_fields().
1067 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1069 Use the latest java-libglom version.
1071 * pom.xml: Use java-libglom 1.21.7.
1073 2012-03-03 Ben Konrath <ben@bagu.org>
1075 Display date and time in details view.
1077 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1079 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1081 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1083 Require the latest java-libglom.
1085 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1087 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1089 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1091 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1092 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1093 an empty quickfind string. I also corrected libglom to create only
1094 empty where clauses for empty quickfind strings, but this avoids the
1097 2012-02-24 Ben Konrath <ben@bagu.org>
1099 Improve the tabs in the Notebook widget.
1103 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1105 Translations: Try to translate the strings.
1107 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1108 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1109 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1110 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1111 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1112 Take the Open translation from GTK+'s .po files.
1113 Take the Details translation from Glom's po files.
1114 I have added the other strings to Glom so we can get translations that way:
1115 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1117 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1119 TableSelectionViewImpl: Put the search label and entry in a div.
1121 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1122 Put the search widgets in a FlowTable so that the CSS can be used to
1123 style them while keeping them together.
1124 * src/main/webapp/style.css: Mention the new div.
1126 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1128 Translate more strings in more locales.
1130 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1131 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1132 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1133 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1134 Translate the "Details" and "Open" string too.
1136 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1137 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1138 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1139 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1140 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1141 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1142 Add these new locales as placeholders though they currently contain English.
1144 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1146 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1148 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1149 Check the ConfiguredDocument* for null before using it.
1151 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1153 Tell Eclipse about the generated java files.
1155 * .classpath: This lets it find OnlineGlomConstants.java.
1156 It would be nice if Eclipse just used the maven build files.
1158 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1160 Prevent a crash when no locale is specified in the URL.
1162 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1163 Avoid returning a null string, obtained from
1164 Window.Location.getParameter(). This caused a crash when it was
1165 later passed to libglom's API.
1166 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1167 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1168 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1169 guard against future null strings.
1171 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1173 Use the ?locale= query param instead of the &lang= token param.
1175 * src/main/java/org/glom/web/client/place/ListPlace.java
1176 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1177 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1178 Remove the lang token key and value.
1180 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1181 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1182 When the user selects a different locale from the chooser, use
1183 Window.Location.assign() to change the URL, which then causes a reload.
1185 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1186 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1187 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1188 * src/main/java/org/glom/web/client/activity/ListActivity.java
1189 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1190 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1191 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1192 * src/main/java/org/glom/web/client/ui/ListView.java:
1193 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1195 Remove localeID member variables and method/constructor parameters, instead
1196 using Utils.getCurrentLocaleID() when we need a localID to pass to
1199 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1201 Internationalize the UI strings.
1203 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1204 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1205 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1206 because it is unused. Messages are apparently strings that can have
1207 parameters, but we do not need that yet, so Contants will be enough for now.
1208 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1209 to say that we support the en and de locales.
1210 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1211 The original English strings.
1212 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1213 Some German translations of the English strings.
1214 The i18n goal then uses the .properties file to generate an
1215 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1216 returns an implementation that returns the translated strings.
1217 The documentation suggests putting these in src/java/*/client/, but it seems
1218 best to put it in src/resources/*/client/.
1219 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1220 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1221 instead of hard-coding them.
1222 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1223 but that does not seem to stop the build, though it confuses Eclipse.
1225 You can see the translated string by adding ?locale=de to the URL, like so:
1226 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1228 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1230 Improve null/empty String checks.
1232 * pom.xml: Add a dependency on commons-lang, to use
1233 org.apache.commons.lang.StringUtils.
1234 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1235 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1236 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1237 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1238 Use StringUtils.isEmpty().
1240 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1241 StringUtils class with a static isEmpty() function because we
1242 cannot use org.apache.commons.lang.StringUtils in client-side
1243 GWT code because it (apparently) cannot be compiled to javascript.
1244 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1245 * src/main/java/org/glom/web/client/activity/ListActivity.java
1246 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1247 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1248 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1249 * src/main/java/org/glom/web/client/place/ListPlace.java
1250 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1251 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1252 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1253 * src/main/java/org/glom/web/client/ui/details/Group.java
1254 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1255 our StringUtils.isEmpty() function.
1257 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1259 Update to the latest java-libglom API.
1261 * pom.xml: Require java-libglom 1.21.4.
1262 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1263 getDocumentInfo(), getListViewLayoutGroup():
1264 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1266 * src/main/java/org/glom/web/server/database/DBAccess.java
1267 getFieldsToShowForSQLQueryAddGroup(),
1268 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1269 with either get_database_title_original() or
1270 get_database_title(localeID).
1272 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1274 ConfiguredDocument: Avoid a null pointer exception.
1276 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1277 Initialize localeID to "" to avoid returning a null String which
1278 causes a crash in java-libglom's swing-generated code.
1280 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1282 Some simple renaming.
1284 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1285 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1286 for localeChooser. This seems more appropriate and is less ambiguous
1287 particularly in the .css file.
1289 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1291 ConfiguredDocument: Rename the localedID private member variable.
1293 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1295 Adapt to the latest java-libglom API from git master.
1297 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1298 libglom now uses only Vector instead of List, which uses add() instead of
1301 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1303 ConfiguredDocument: Rename the localedID private member variable.
1305 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1307 Build a source tarball with mvn assembly:single
1309 * assembly.xml: Add this file.
1310 * pom.xml: Use the maven-assembly-plugin and tell it to use
1311 our assembly.xml file.
1313 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1315 OnlineGlomServiceImpl: Get .glom files recursively.
1317 * pom.xml: Depend on commons-io from org.apache.commons.
1318 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1319 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1320 files recursively, and with the easier filter for the extension.
1321 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1322 simplify that code too.
1324 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1326 README: Mention that you must install java-libglom packages separately.
1328 But then it works, because java-libglom is now in the central maven
1331 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1333 locales drop-down: Show the correct selected locale when the URL changes.
1335 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1336 .java: setPlace(): Move some code into fillView().
1338 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1340 locales drop-down: Do not lose the primary key.
1342 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1343 start(): onLocaleChange(): Pass the current primary key value,
1344 instead of an empty value.
1346 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1348 locales drop-down: Do not lose the drop-down selection.
1350 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1351 .java (TableSelectionActivity.fillView): Set the selected locale
1352 after changing the drop-down items (though we do not really need
1353 to change them just because the locale changes.)
1355 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1357 locales drop-down: Change the tables list when this changes.
1359 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1360 .java: TableSelectionActivity.start(): Move the async table titles
1361 retrieval into a private fillView() method and also call this when
1362 the chosen locale changes.
1363 Note that the document title is not actually translatable yet, but
1364 that is a problem that I should fix soon in libglom.
1366 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1368 Improve the placement of the locales drop-down.
1370 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1371 Put the title and locales drop-down in a div (gwt.FlowTable).
1372 * src/main/webapp/style.css: Add magic css properties to make this work.
1373 Also remove the left margin from the title so that it lines up with the
1376 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1378 locales selector: Show human-readable locale titles.
1380 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1381 getDocumentInfo(): Use java.util.Locale to show a real title of
1382 each locale, in the locale's own language.
1384 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1386 Add a language/locale selector drop-down.
1388 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1389 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1390 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1391 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1392 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1393 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1394 Add a ListBox to show the available locales. Add getLocaleSelector(),
1395 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1396 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1397 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1398 java: Add these classes.
1399 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1400 start(): Fill the locales ListBox. Handle its change event, firing a
1402 setPlace(): Show the selected locale as specified by the URL token.
1403 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1404 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1405 Handle LocaleChangeEvent, going to a new *Place with that locale.
1407 The placement of the ListBox is not pretty, and it currently uses the ID
1408 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1412 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1414 Search box: Show the search text from the URL token.
1416 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1417 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1418 Add setQuickFindText().
1419 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1420 .java: setPlace(): Store the queryText if the place is a ListPlace,
1421 and call TableSelectionView.setQuickFindText().
1423 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1425 Allow use of translations via, for instance, &lang=de in the URL.
1427 * pom.xml: Use the unstable java-libglom 1.21 version.
1429 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1430 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1431 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1432 init(): Instead of calling TranslatableItem.set_current_locale()
1433 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1434 However, this is only for default locales, which are not needed to
1435 change the locale in the URL.
1436 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1437 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1438 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1439 layout for a particular locale.
1440 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1441 Add get/setDefaultLocaleID().
1442 getDocumentInfo(), getListViewData(), getRelatedListData(),
1443 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1444 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1445 localeID parameter, so we can get the layout for a particular locale.
1447 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1448 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1449 * src/main/java/org/glom/web/client/place/ListPlace.java:
1450 Parse and construct a lang parameter too.
1452 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1453 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1454 passed to subsequent methods and constructors.
1455 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1456 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1457 Store the localeID from the *Place and pass it to other constructors
1458 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1460 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1461 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1462 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1463 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1464 * src/main/java/org/glom/web/client/ui/ListView.java:
1465 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1466 Take localeID parameters and pass them to subsequent constructors and
1467 methods, so that the layout is always retrieved for that locale.
1469 This is rather repetitive.
1471 Note that "" means the original (default) locale of the Glom document,
1472 which is usually English.
1474 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1476 Documents: Remove final keyword to fix startup configuration.
1478 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1479 final keywords on the private member variables because that breaks
1480 the startup, apparently (there are warnings) because it stops them
1481 from being serialized. I added these in the previous commit.
1483 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1485 Documents: Add some final keywords.
1487 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1490 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1492 OnlineGlomServiceImpl: Add to overview comments.
1494 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1495 Note that this is where all the document are loaded. They are not
1496 loaded freshly for each page.
1498 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1502 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1503 Add a TextBox for the text of a quick find.
1504 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1506 setBackLink(): Add a String quickFind parameter.
1507 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1508 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1509 to the base interface, because that is how TableSelectionViewImpl is used.
1510 * src/main/webapp/style.css: Add style for the search box and its label.
1512 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1513 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1514 Add these files, based on the existing TableChangeEvent and
1515 TableChangeEventHandlers.
1516 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1517 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1518 a ListPlace() that the user should be taken to.
1519 * src/main/java/org/glom/web/client/activity/ListActivity.java
1520 start(): Handle it here too and adapt the TableChangeEvent handler to
1521 pass the extra "" quickFind parameter to ListPlace.
1522 * src/main/java/org/glom/web/client/place/ListPlace.java:
1523 Constructor: Take an extra String quickFind parameter and store it,
1524 returning it from a new getQuickFind() method.
1525 getToken(): Put the quickFind text in the URL token.
1526 getPlace(): Parse the quickFind text from the URL token.
1527 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1528 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1529 ListPlace constructor.
1530 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1531 .java: start(): Add a Change handler for the TableSelectionView's
1532 TextBox (via its base HasChangeHandlers interface), firing the new
1533 QuickFindChangeEvent.
1534 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1535 pass the extra "" quickFind parameter.
1537 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1538 setCellTable(): Add a String quickFind parameter and pass it to
1539 the ListViewTable() constructor.
1540 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1541 setCellTable() in the base interface, because that is how ListViewImpl
1544 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1545 Add a String quickFind member variable.
1546 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1547 Constructor: Add a String quickFind parameter, storing it in the
1548 base ListTable's member variable.
1549 onRangeChanged(): Pass quickFind to the
1550 OnlineGlomServiceAsync.getSortedListViewData() and
1551 OnlineGlomServiceAsync.getListViewData() methods.
1553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1554 getListViewData(), getSortedListViewData(): Add a String quickFind
1555 parameter, passing it to ConfiguredDocument.getListViewData().
1556 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1557 Change getListViewData(), getSortedListViewData() in the base interface,
1558 because that is how OnlineGlomServiceImpl is used, via this:
1559 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1560 Change getListViewData(), getSortedListViewData() here too.
1561 This class can apparently be used to asynchronously call methods on
1562 OnlineGlomService, and GWT seems to implement that after recognizing
1563 just the *Async name convention and the extra AsyncCallback parameters.
1565 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1566 getListViewData(): Add a String quickFind parameter, and pass it to
1567 ListViewDBAccess.getData().
1568 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1569 getListData(): Add a String quickFind parameter and pass it to
1571 getSelectQuery(): Add a String quickFind parameter.
1572 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1573 getSelectQuery(): Add a String quickFind parameter and use it with
1574 Glom.get_find_where_clause_quick() to pass a where_clause to
1575 Glom.build_sql_select_with_where_clause(), to actually filter the
1577 getData(): Add a String quickFind parameter, passing it to getListData().
1578 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1579 va: getData(): Pass an empty string to getListData() for the
1580 quickFind parameter.
1582 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1584 ListTable: Minor change.
1586 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1587 createCellTable(): Make this protected instead of public.
1589 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1591 Many files: Use final for the parameters and use the @override attribute.
1593 2012-01-22 Ben Konrath <ben@bagu.org>
1595 Add anchor links for single line text that starts with http, ftp and www.
1599 2012-01-22 Ben Konrath <ben@bagu.org>
1601 Add ellipsis to single line text in details view.
1605 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1607 Remove all javadoc author tags.
1609 Because they are awkward and meaningless when many people touch
1611 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1613 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1615 Revert the COPYING.LESSER to COPYING rename.
1617 Apparently both should be there if it is LGPL.
1619 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1621 *View: Remove unused imports.
1623 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1624 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1625 * src/main/java/org/glom/web/client/ui/ListView.java:
1626 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1627 Remove unused imports, as suggested by Eclipse.
1629 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1631 Move the *View::Presenter types, and some API into one base View.
1633 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1634 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1635 * src/main/java/org/glom/web/client/ui/ListView.java:
1636 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1637 Presenter, setPresenter() and clear() into a shared base interface,
1638 to avoid the unnecessary duplicate Presenter types and to more clearly
1639 show how the *Views share the same structure, even if they are not
1640 used polymorphically.
1642 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1643 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1645 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1646 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1647 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1649 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1652 Feel free to revert this if there is a good reason for the duplicate
1655 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1657 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1659 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1660 a class member instead of a local variable in the method.
1661 This lets us use it to get the view instances, for use in tests.
1662 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1663 beforeOnlineGlom(): Test some more details of the initial view.
1664 Again, this is not very useful.
1666 To really test gwt-glom we will need to start a local postgresql
1667 instance with local data, like the Glom tests in C++.
1669 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1671 pom.xml: Mention the LGPL license.
1673 * pom.xml: Add a licenses section.
1674 * COPYING.LESSER: Move this to COPYING, which
1675 previously contained the GPL. But gwt-glom is all LGPL.
1677 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1679 Add project information to README and pom.xml.
1681 * README: Add a brief description and mention some mvn
1683 * pom.xml: This extra information shows up in mvn site
1686 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1688 Use the latest java-libglom version.
1690 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1692 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1694 GwtTestOnlineGlom: Test a little more.
1696 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1697 protected rather than private, as suggested by the gwt-test-utils
1699 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1700 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1701 Test the initial visibility of the panels.
1703 However, this is not a very useful test.
1704 And I wonder how we should generally test using this idea for an
1705 activity/places app like ours where the real changes happen implicitly
1706 based on the history token/URL.
1708 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1710 Slight modification to *Mapper comments.
1712 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1713 (DataActivityMapper)
1714 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1716 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1718 Remove comments mentioning GIN because they are just copied from
1719 the example code and are apparently not helpful:
1720 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1721 Also change the mention of a class that is only in the example code.
1723 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1725 GwtTestOnlineGlom test: Minor changes.
1727 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1728 Avoid the long qualified class name and modify the comment
1729 because it is now obvious to me that the mocked class is the only
1730 custom one created via GWT.create().
1732 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1734 Tests: Added the beginnings of a test using gwt-test-utils.
1736 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1737 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1738 which tells gwt-test-utils what class will be tested.
1739 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1740 Add a simple (but empty) test case. One class, used by the OnlineGlom
1741 class, is mocked so that it can be created. However, I am not sure
1742 why only this class needs to be mocked.
1744 Note that mockito seems more popular, and clearer, than easymock,
1745 but I have not got that working yet. It might be a matter of the
1748 This test is run during mvn integration-test.
1750 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1752 Tests: Use junit4-style syntax instead of junit3-style.
1754 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1755 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1756 * src/test/java/org/glom/web/shared/DataItemTest.java:
1757 Use the @Test annotation rather than relying on the test*() prefix.
1758 Also no longer implement TestCase, to avoid triggering support for
1759 the junit3-way, which stops the annotations from working.
1760 Change the imports from import junit.framework.* to
1761 import org.junit.*, which is apparently the new way.
1763 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1765 Added a test for ListPlace token parsing and creation.
1767 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1768 This is much the same as DetailsPlaceTest.
1770 I wonder how we could test the other parts of the *Place API.
1772 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1774 DetailsPlace test: Also test getToken() and recreation via getPlace().
1776 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1777 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1778 recreate it, testing the recreated DetailsPlace for the same parameter
1781 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1783 Use the surefire-report plugin.
1785 * pom.xml: This generates a HTML report about the tests in
1786 target/site/surefire-report.html
1787 when you do mvn surefire-report:report. It seems to be popular/normal.
1789 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1791 Added a test for DetailsPlace.
1793 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1794 Test the getPlace() token parsing.
1796 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1798 Added a first unit test.
1800 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1801 * src/test/java/org/glom/web/shared/DataItemTest.java:
1802 This is a silly test but it is just to get things started. Note that
1803 maven/junit finds the test because it looks in src/test by default.
1805 2011-12-22 Ben Konrath <ben@bagu.org>
1807 Change charsetName to "UTF-8" when replacing line breaks.
1809 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1810 that work in Java (such as "UTF8") will not work when compiled to
1813 This fixes a problem with multi-line details view fields that have hard
1814 line breaks. The "License Text" field on this page demonstrates the
1817 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1819 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1821 2011-12-22 Ben Konrath <ben@bagu.org>
1823 Fix another bug with related list navigation.
1825 I've tested all the navigation buttons in all of the related lists
1826 so things should be good now.
1828 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1830 2011-12-22 Ben Konrath <ben@bagu.org>
1832 Fix a crasher when refreshing the list view with the default table.
1834 This crash will also happen when loading the list view with the default
1835 table from a link or bookmark.
1837 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1838 to the main document selection page when the document id hasn't been
1840 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1841 the main document selection page when the document id hasn't been
1843 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1844 values for the details place when the document id hasn't been set.
1845 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1846 values for the list place when the document id hasn't been set.
1848 2011-12-21 Ben Konrath <ben@bagu.org>
1850 Protect against NPE when glom.document.locale is not in config.
1852 This patch protects against an NPE when glom.document.locale is not in
1853 the config file. This NPE will also happen if glom.document.locale is
1856 The patch also updates the error message to display the class name when
1857 the getMessage() returns null. This was happening when the NPE was
1858 thrown and I had "Configuration Error: null". If an NPE is encountered
1859 with this patch, "Configuration Error: NullPointerException " will be
1862 This commit closes this bug:
1864 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1866 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1868 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1870 Rename onlineglom.properties to onlineglom.properties.sample.
1872 * src/main/resources/onlineglom.properties: Rename to:
1873 * src/main/resources/onlineglom.properties.sample:
1874 * src/main/resources/README: And add this file explaining that people
1875 should rename it back when deploying.
1877 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1879 Allow choosing the translation in the .properties file.
1881 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1882 init(): Read a glom.document.locale value from the configuration file
1883 and call Glom's TransatableItem::set_current_locale() method.
1884 * src/main/resources/onlineglom.properties: Add a commented-out
1885 example of this new setting.
1887 It would be better to add &lang=de_DE to the URL, but the current
1888 libglom API does not allow us to do this easily. I am working on that.
1890 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1892 Avoid a crash in parsing of token parameters.
1894 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1895 ava: getTokenParams(): Do not crash if a parameter has a key but no
1896 value, and ignore parameters with neither.
1898 2011-12-17 Murray Cumming <murrayc@murayc.com>
1900 History token building/handling: Improve use of token parameters.
1902 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1903 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1904 and buildParamsToken(HashMap), for use by derived classes.
1905 Make the separator private because it is no longer be needed.
1906 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1907 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1908 instead of manual string concatenation.
1909 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1910 of hardcoded indices and awkward splitting code.
1911 * src/main/java/org/glom/web/client/place/ListPlace.java
1912 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1913 instead of manual string concatenation.
1914 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1915 of hardcoded indices and awkward splitting code.
1916 This should fix bug #666420
1918 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1920 Fix a Navgiation->Navigation typo in the code.
1922 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1923 Rename processNavgiation() to processNavigation().
1925 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1927 Fix a seperator->separator typo in the code.
1929 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1930 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1931 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1934 2011-12-15 Ben Konrath <ben@bagu.org>
1936 Cleanup some comments.
1938 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1940 2011-12-14 Ben Konrath <ben@bagu.org>
1942 Replace \n with <br/> for multiline text in the details view.
1944 Vertical scrollbars are added when needed as well.
1946 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1948 2011-12-14 Ben Konrath <ben@bagu.org>
1950 Specify the font for document selection links.
1952 * src/main/webapp/style.css:
1954 2011-12-14 Ben Konrath <ben@bagu.org>
1956 Fix bouncy CellTable while paging.
1958 This doesn't currently work with related list tables in unselected
1961 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1963 2011-12-14 Ben Konrath <ben@bagu.org>
1965 Revamp the appearance of the document selection page.
1967 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1968 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1969 * src/main/webapp/style.css:
1971 2011-12-13 Ben Konrath <ben@bagu.org>
1973 Set navigation button column to the smallest size possible.
1975 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1977 2011-12-13 Ben Konrath <ben@bagu.org>
1979 Change OpenButton nomenclature to NavigationButton.
1981 Using NavigtionButton makes things more generic. Classes, methods and
1982 variables have been changed.
1984 This is a rename-only refactor.
1986 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1987 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1988 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1989 Renamed from OpenButtonCell.
1990 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1991 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1992 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1994 2011-12-12 Ben Konrath <ben@bagu.org>
1996 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1998 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1999 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2000 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2001 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2003 2011-12-12 Ben Konrath <ben@bagu.org>
2005 Update variable names and comments.
2007 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2008 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2010 2011-12-12 Ben Konrath <ben@bagu.org>
2012 Properly initialize numNonEmptyRows variable to zero.
2014 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2015 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2017 2011-12-05 Ben Konrath <ben@bagu.org>
2019 Add latest mockup with HTML tables.
2021 Features of this mockup:
2023 -> HTML table for flowtable
2024 -> HTML table for flowtable column
2025 -> Example of how related lists would look
2026 -> Not using text entries for data items
2028 The current version of Online Glom doesn't use HTML tables for the
2031 This mockup has been sent to the glom-devel mailing list but it's good
2032 to have it here as well.
2034 * mockups/details-view-html-tables.html:
2036 2011-12-05 Ben Konrath <ben@bagu.org>
2038 Remove unnecessary getPrimaryKeyField() method.
2040 getPrimaryKeyFieldForTable(String) has been renamed to
2041 getPrimaryKeyField(String).
2043 * src/main/java/org/glom/web/server/database/DBAccess.java:
2044 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2045 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2047 2011-12-05 Ben Konrath <ben@bagu.org>
2049 Add string representation of TypedDataItem value to conversion error message.
2051 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2052 message was extracted into its own method to avoid duplication.
2054 2011-12-05 Ben Konrath <ben@bagu.org>
2056 Add type checking to navigation primary key value creation.
2058 Create navigation primary key only if the expected type from the Glom
2059 document matches the type returned by the SQL query.
2061 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2063 2011-12-05 Ben Konrath <ben@bagu.org>
2065 Rename a couple of variables in RelatedListNavigation.
2067 This is a rename-only refactor.
2069 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2071 2011-12-05 Ben Konrath <ben@bagu.org>
2073 Move getListLayoutGroup() into getListViewLayoutGroup().
2075 This removes getListLayoutGroup(). It was only being called by
2076 getListViewLayoutGroup().
2078 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2080 2011-12-05 Ben Konrath <ben@bagu.org>
2082 Remove check for LayoutItem_Portal in list table method.
2084 This check is no longer necessary because the method isn't being used
2085 to create the LayoutItemPortal DTO.
2087 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2089 2011-12-05 Ben Konrath <ben@bagu.org>
2091 Properly support related list navigation.
2093 Navigation from the "Repository Analyzer -> Package Scans ->
2094 Dependencies" related table wasn't working because the primary key for
2095 related tables wasn't being set properly. This commit fixes the
2098 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2099 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2100 doesn't set the primary key properly for related list tables.
2101 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2102 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2103 useful for getting the primary key for list view tables and for related
2105 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2106 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2107 Move code to set the primary key for the table from the abstract
2108 ListDBAccess class to ListViewDBAccess as it's only correct for list
2110 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2111 Properly add primary key to related list tables.
2113 2011-12-02 Ben Konrath <ben@bagu.org>
2115 Properly set the horizontal alignment of fields.
2117 This fix is for both the list tables and the details view.
2119 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2120 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2121 to set the horizontal alignment of fields.
2123 2011-12-02 Ben Konrath <ben@bagu.org>
2125 Display currency codes in the details view.
2127 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2129 2011-12-02 Ben Konrath <ben@bagu.org>
2131 Avoid duplicate JNI call.
2133 JNI is not as efficient as pure Java and this is an easy (and small)
2136 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2137 Use previously retrieved value for whereClauseToTableName instead of
2140 2011-12-02 Ben Konrath <ben@bagu.org>
2142 Rename a couple of variables in RelatedListNavigation.
2144 This is a rename-only refactor.
2146 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2148 2011-12-02 Ben Konrath <ben@bagu.org>
2150 Indicate clearly that a mismatched primary key type is a bug.
2152 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2153 warning to error. Add 'This is a bug.' to message.
2155 2011-12-02 Ben Konrath <ben@bagu.org>
2157 Update / fix some comments.
2159 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2161 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2163 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2164 Fix comments. Add some TODOs.
2166 2011-12-02 Ben Konrath <ben@bagu.org>
2168 Enable navigation to details view with string primary key from related list.
2170 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2171 Create a text primary key value when return type of result is
2172 java.sql.Types.VARCHAR.
2174 2011-12-02 Ben Konrath <ben@bagu.org>
2176 Use checkboxes for booleans in the details view.
2178 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2180 2011-12-01 Ben Konrath <ben@bagu.org>
2182 Improve performance of related list height calculation.
2184 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2185 Put code to calculate the expected height in a static initializer so
2186 that that it's only called once.
2188 2011-12-01 Ben Konrath <ben@bagu.org>
2190 Show related list tables in notebooks (again).
2192 Calculate the height of the related list tables so the Notebook can be
2193 set the correct height. The height of the related list table is also needed by
2194 FlowTable to be able decide how to create the layout.
2196 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2197 and set the Portal height based on the height of the related list
2198 table and the Portal container.
2199 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2200 Add method to calculate the height of the related list tables.
2201 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2202 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2203 calculate the height of the Pager widget.
2205 2011-12-01 Ben Konrath <ben@bagu.org>
2207 Use CellTable API for table property instead of setting style on Element.
2209 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2211 2011-12-01 Ben Konrath <ben@bagu.org>
2213 Make ListViewTable and RelatedListTable a consistent height.
2215 The tables are now a consistent height regardless of the contents of
2216 the table. A hidden button is added to empty rows to ensure that the
2217 height of these rows will match the height of rows with data.
2219 A navigation button column is now added to every table. The width of
2220 the navigation column is set to 0px when a RelatedListTable shouldn't
2221 have navigation buttons. This maintains the a consistent row height in
2222 tables that don't show the navigation buttons.
2224 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2225 navigation column when not needed.
2226 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2227 arguments for navigation button to constructor of ListViewTable.
2228 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2229 hidden button for empty data rows.
2230 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2231 arguments for navigation button to constructor.
2232 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2233 create navigation buttons. Add hideNavigationButtons() method.
2234 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2235 arguments for navigation button to constructor.
2237 2011-12-01 Ben Konrath <ben@bagu.org>
2239 Use 'visibility: hidden' in Utils.getWidgetHeight().
2241 This is better choice because hidden elements are invisible, don't
2242 respond to events and are not part of the tab order. They will,
2243 however, take up space which is required to be able to calculate the
2244 height of the widget.
2246 * src/main/java/org/glom/web/client/Utils.java:
2248 2011-12-01 Ben Konrath <ben@bagu.org>
2250 Use Utils.getWidgetHeight() in FlowTable.
2252 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2254 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2256 2011-12-01 Ben Konrath <ben@bagu.org>
2258 Put the details css class name on the correct table column.
2260 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2262 2011-11-30 Ben Konrath <ben@bagu.org>
2264 Update for java-libglom API change.
2266 The getters and setters on FieldFormatting and NumericFormat were
2267 changed to remove the 'M'.
2269 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2271 2011-11-29 Ben Konrath <ben@bagu.org>
2273 Only allow RelatedListTables in Portals.
2275 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2277 2011-11-29 Ben Konrath <ben@bagu.org>
2279 Only create a contents panel for Portals when title is being set.
2281 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2283 2011-11-29 Ben Konrath <ben@bagu.org>
2285 Set TabLayoutPanel height based on calculated height its widgets.
2287 This is a potential fix for this bug:
2289 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2291 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2293 2011-11-29 Ben Konrath <ben@bagu.org>
2295 Align details field labels and data with the Open buttons.
2297 * src/main/webapp/style.css:
2299 2011-11-29 Ben Konrath <ben@bagu.org>
2301 Remove unnecessary <div> in the Notebook widget.
2303 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2304 method to get container FlowPanel (<div>).
2305 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2306 initWidget() method directly on the TabLayoutPanel widget instead of
2307 Group's container widget.
2309 2011-11-29 Ben Konrath <ben@bagu.org>
2311 Don't add group titles for Portals in Notebooks.
2313 This reverts the previous patch and fixes a bug I introduced with
2314 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2316 * src/main/java/org/glom/web/client/ui/details/Group.java:
2317 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2319 2011-11-28 Ben Konrath <ben@bagu.org>
2321 Remove unused boolean argument in Portal constructor.
2323 Just a code cleanup.
2325 * src/main/java/org/glom/web/client/ui/details/Group.java:
2326 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2328 2011-11-28 Ben Konrath <ben@bagu.org>
2330 Remove hack for glom 1.18 style glom files.
2332 * src/main/java/org/glom/web/client/ui/details/Group.java:
2333 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2334 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2336 2011-11-28 Ben Konrath <ben@bagu.org>
2338 Use Gda Value version of primary key to log result too large error.
2340 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2342 2011-11-28 Ben Konrath <ben@bagu.org>
2344 Don't use TypedDataItem.getText() for Unknown types from the URL.
2346 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2347 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2348 instead of getText().
2349 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2350 String field and getUnknown() method.
2352 2011-11-28 Ben Konrath <ben@bagu.org>
2354 Log an error message when the java-libglom .so is not present.
2356 The error message was being set in the exception but not logged.
2358 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2360 2011-11-28 Ben Konrath <ben@bagu.org>
2362 Ignore LayoutItem_CalendarPortals.
2364 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2365 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2367 2011-11-28 Ben Konrath <ben@bagu.org>
2369 Extract method for creating the LayoutItemPortal DTO.
2371 Just breaking the code up into smaller chunks.
2373 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2375 2011-11-28 Ben Konrath <ben@bagu.org>
2379 This should have been added with the refactor. Oops!
2381 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2383 2011-11-28 Ben Konrath <ben@bagu.org>
2385 Create primary key value from URL string using type from Glom document.
2387 See this bug, comments 19 - 25:
2389 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2391 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2392 create a TypeDataItem for the primary key here when loading from a
2393 URL. Show the same string for the primary key value as was received
2394 from the URL string (when loading from a URL).
2395 * src/main/java/org/glom/web/server/Utils.java: Update method for
2396 creating the Gda Value from the TypeDataItem to properly deal with
2397 creating a Gda Value based on the Glom document type for the primary
2398 key value string when loading from a URL.
2399 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2400 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2401 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2402 Update for changed method name.
2404 2011-11-27 Ben Konrath <ben@bagu.org>
2406 Rename PrimaryKeyItem to TypedDataItem.
2408 The name PrimaryKeyItem suggests what the class should be used for.
2409 TypedDataItem is a neutral name that describes the class better.
2411 This is a rename-only refactor.
2413 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2414 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2415 * src/main/java/org/glom/web/client/Utils.java:
2416 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2417 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2418 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2419 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2420 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2421 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2422 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2423 * src/main/java/org/glom/web/server/Utils.java:
2424 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2425 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2426 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2427 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2429 2011-11-25 Ben Konrath <ben@bagu.org>
2431 Improve Gda Value conversion from PrimaryKeyItem.
2433 The value from the PrimaryKeyItem is only used if its type match the
2434 type from the glom document.
2436 * src/main/java/org/glom/web/server/Utils.java:
2438 2011-11-25 Ben Konrath <ben@bagu.org>
2440 Manually check if the java-liblgom .so is visible to the JVM.
2442 It seems that Tomcat has problems when a static initializer throws an
2443 exception. This check is done before the first method call into
2444 java-libglom so that execution doesn't continue if the .so is not
2447 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2449 2011-11-25 Ben Konrath <ben@bagu.org>
2451 Improve browser configuration error messages.
2455 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2457 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2458 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2459 getConfigurationErrorMessage() method.
2460 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2461 Get and display a specific configuration error message when no Glom
2462 documents are found.
2463 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2464 Implement getConfigurationErrorMessage() method. Surround configuration
2465 code in the init() method with a try/catch block. This allows the
2466 errors to be caught while keeping the servlet available to retrieve the
2467 configuration error message.
2469 2011-11-25 Ben Konrath <ben@bagu.org>
2471 Don't use Strings to hold primary key values.
2473 The primary key values are now held in a new data object
2474 (PrimaryKeyItem) that holds type information and the primary key value
2475 using the correct type.
2477 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2478 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2479 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2480 PrimaryKeyItem instead of String to hold the primary key value.
2481 * src/main/java/org/glom/web/client/Utils.java: Remove
2482 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2483 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2484 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2485 PrimaryKeyItem instead of String to hold the primary key value. Load
2486 document selection page when the documentID has not been set correctly.
2487 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2488 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2490 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2491 Return empty string for URL instead of "null".
2492 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2493 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2494 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2495 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2496 PrimaryKeyItem instead of String to hold primary key values.
2497 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2498 PrimaryKeyValue to a Gda Value.
2499 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2500 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2501 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2502 Replace temporary database access code that uses the PrimaryKeyValue to
2503 Gda Value conversion.
2504 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2505 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2506 PrimaryKeyItem instead of String.
2507 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2508 hold primary key values.
2510 2011-11-24 Ben Konrath <ben@bagu.org>
2512 Use newly added java-libglom API to create queries.
2514 This isn't finished. I still need to stop using Strings for primary key
2515 values in the client code.
2517 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2518 libglom to use fake connections so that retrieving the query string will
2520 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2521 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2522 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2523 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2524 Use the newly added libglom sql methods and classes to create the
2525 query. Add temporary hack to convert primary value strings to Gda
2528 2011-11-23 Ben Konrath <ben@bagu.org>
2530 Don't explicitly set the height of Portals.
2532 See comments 6 - 10 of this bug for details:
2534 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2536 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2538 2011-11-23 Ben Konrath <ben@bagu.org>
2540 Use an HTML table instead of CSS for the FlowTable layout.
2542 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2543 GWT's FlexTable to implement the FlowTable.
2544 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2546 2011-11-18 Ben Konrath <ben@bagu.org>
2548 Add boolean example to HTML table mockup.
2550 * mockups/details-view-html-tables-text-entries.html:
2552 2011-11-17 Ben Konrath <ben@bagu.org>
2554 Ensure the pager buttons are always visible for related lists.
2556 To accomplish this, I've turned off text wrapping in the list view and
2557 related list tables for both the header and data text. The related list
2558 table now has a fixed layout so the it doesn't overflow its container.
2559 This is required to ensure that the cell text is clipped when it
2560 overflows the cell and an ellipsis is added to the right side of the
2561 cell when text is clipped.
2563 A fixed table layout for the related list table in the details view
2564 seems what we want for the details view anyway, so the side-effect is
2567 The ellipsis will only be displayed in Firefox >= 7.
2571 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2573 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2574 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2575 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2577 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2578 Set the 'table-layout: fixed' CSS property to the related list table.
2579 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2580 'white-space: nowrap;' CSS property on both the list view and the
2581 related list tables.
2583 2011-11-16 Ben Konrath <ben@bagu.org>
2585 Rework the fix for empty notebook tab labels.
2587 Setting the empty group titles with its name caused problems for the
2588 details layout. Instead of using libglom's
2589 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2590 to the client when the title is empty. This allows the Notebook to use
2591 the name when the title is empty without affecting anything else.
2593 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2594 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2596 2011-11-16 Ben Konrath <ben@bagu.org>
2598 Set group titles with name when title is empty.
2600 This fixes a problem with an empty notebook tab label in the Lesson
2601 Planner document. The forth tab in the notebook should be "Internet":
2603 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2605 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2606 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2609 2011-11-16 Ben Konrath <ben@bagu.org>
2611 Remove whitespace from the configured username properties.
2613 This assumes that usernames won't have whitespace at the beginning
2614 or end. But I think this is a reasonable assumption.
2616 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2617 String.trim() to remove the whitespace from the username properties.
2619 2011-11-15 Ben Konrath <ben@bagu.org>
2621 Add details view mockup with HTML tables and text entries.
2623 This is from the attachment on this bug:
2625 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2627 * mockups/details-view-html-tables-text-entries.html:
2629 2011-11-15 Ben Konrath <ben@bagu.org>
2631 Add space between the columns of the flow table.
2635 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2637 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2638 space between columns in the flow table.
2640 2011-11-15 Ben Konrath <ben@bagu.org>
2642 Add backup files to the .gitignore.
2644 * .gitignore: Ignore files that end with ~.
2646 2011-11-09 Ben Konrath <ben@bagu.org>
2648 Use latest release of gwt-log.
2650 Gwt-log releases are now being submitted to the maven central
2651 repository so manual installation of the jar is no longer required.
2653 * pom.xml: Update version and groupId of gwt-log dependency.
2655 2011-10-31 Ben Konrath <ben@bagu.org>
2657 Don't use GWT numeric formatting to override the glom currency formatting.
2659 Currencies are now displayed like they are in Glom. See this bug:
2661 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2663 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2665 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2666 currency code to constructor and set it when the cell is rendered.
2667 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2668 currency code to the constructor of the NumericCell.
2670 2011-10-27 Ben Konrath <ben@bagu.org>
2672 Require the latest release of java-libglom (1.17.4).
2676 2011-10-26 Ben Konrath <ben@bagu.org>
2678 Add style to Notebook that matches current theme.
2680 It's not the best style in the world but it's better than the default.
2682 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2683 padding at the bottom of the child widgets.
2684 * src/main/webapp/style.css: Add style for the Notebook.
2686 2011-10-26 Ben Konrath <ben@bagu.org>
2688 Move servlet initialization code to overridden init method.
2690 This is half of the solution to getting proper error messages
2691 displayed when configuration errors occur. Here's the relevant bug:
2693 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2695 The rest of the solution involves surrounding the init method with a
2696 try/catch block and setting a global variable with the error /
2697 exception. A new async method should be created to retrieve and display
2698 the error message / exception.
2700 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2701 code from constructor to init method adding exceptions as needed.
2703 2011-10-26 Ben Konrath <ben@bagu.org>
2705 Add script to monitor and restart tomcat if required.
2707 * utils/check-and-recover-tomcat.py: New file.
2709 2011-10-26 Ben Konrath <ben@bagu.org>
2711 Display the correct number of data items in the pager.
2715 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2717 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2718 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2719 The implementation is the same for both tables: Keep track of the
2720 number of non-empty rows and fire and RowCountChangeEvent after the data has
2722 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2723 custom Pager class that subclasses SimplePager to handle displaying
2724 the correct number when empty rows have been added.
2726 2011-10-26 Ben Konrath <ben@bagu.org>
2728 Correct error in previous commit.
2730 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2731 eventBus parameter from listView.setCellTable().
2733 2011-10-26 Ben Konrath <ben@bagu.org>
2735 Fix error in TODO comment.
2737 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2739 2011-10-24 Ben Konrath <ben@bagu.org>
2741 Create Notebook widgets to the details view.
2743 This isn't finished just yet - I still need to create a reasonable
2744 style to match the current theme.
2746 * src/main/java/org/glom/web/client/Utils.java: Add method for
2747 calculating the height of a widget. This is used in the Notebook class.
2748 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2749 new constructor method in Group.
2750 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2751 method for creating child widget that can be used by subclasses
2752 like Notebook. New constructor that allows disabling the group
2753 titles - Notebooks don't set a group title for their child groups.
2754 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2755 to make Notebooks using GWT's TabLayoutPanel.
2756 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2757 constructor that allows disabling the group titles.
2758 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2759 LayoutItemNotebook DTO.
2760 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2761 DTO for Notebooks. It's just an empty class for now but we might need
2762 it to transfer some specific information in the future.
2764 2011-10-21 Ben Konrath <ben@bagu.org>
2766 Add navigation buttons to related list tables.
2768 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2769 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2770 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2771 method getSuitableRecordToViewDetails() for getting the table name
2772 and primary key value for related list navigation buttons.
2773 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2774 private cell renderer class to get the navigation information for
2775 related list tables from the server. Extract the navigation
2776 processing code from the details cell navigation and use it for the
2777 related list navigation as well.
2778 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2779 cell renderer class for the details open buttons. This was needed
2780 because the related list navigation buttons and the list view
2781 navigation buttons need to react differently when clicked.
2782 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2783 the onEnterKeyDown() method because it's now overriden in the
2784 subclasses that are specific to the related list tables and the list
2786 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2787 the vertical size a little because the buttons add a bit of vertical
2788 space to table. This is not a perfect solution because the vertical
2789 size of with table fewer than 5 rows will be a little smaller.
2790 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2791 changes in how navigation buttons are handled.
2792 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2793 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2794 database access object.
2795 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2796 to find the portal for a given relationship name from
2797 RelatedListDBAccess. Add method to find a primary key field for a
2799 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2800 Move code to find the portal for a given relationship name to
2802 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2803 New file: database access object for getting the related list
2804 navigation information (the table name and the primary key value).
2805 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2806 DTO for transferring a table name to navigate to and a primary key
2808 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2809 boolean and getter/setter to specifies if the related list should add
2812 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2814 Use the master branch of java-libglom
2816 * pom.xml: Depend on java-libglom 1.19 instead.
2818 This is the master branch. See also the libglom-1-18 branch.
2820 2011-10-11 Ben Konrath <ben@bagu.org>
2822 Enable the open navigation button when the data has been set.
2824 This avoids having active buttons that don't do anything when the data
2827 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2829 2011-10-11 Ben Konrath <ben@bagu.org>
2831 Use IsWidget interface for FlowTableItem.
2833 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2834 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2836 2011-10-11 Ben Konrath <ben@bagu.org>
2838 Remove GWT styling from open button in details view.
2840 There are still some issues with how the details cell is arranged but
2841 this should be made to match Glom 1.20. I'm going to leave fixing this
2842 until I have Glom 1.20 up and running.
2844 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2845 style name on open button.
2846 * src/main/webapp/style.css: Move and edit details-navigation class.
2847 Re-arrange some classes to make them appear in the same order as the
2850 2011-10-07 Ben Konrath <ben@bagu.org>
2852 Update to GWT 2.4.0.
2854 * .gitignore: Ignore new cache directory.
2855 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2856 * pom.xml: Change GWT and maven plugin to 2.4.0.
2857 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2859 * src/main/java/org/glom/web/client/ClientFactory.java:
2860 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2861 * src/main/java/org/glom/web/client/OnlineGlom.java:
2862 Update source for API changes.
2863 * utils/build-onlineglom-war.sh: Remove cache directory before the
2866 2011-10-07 Ben Konrath <ben@bagu.org>
2868 Add navigation buttons in the details view.
2870 This isn't finished but I thought I'd commit what I have as it's a
2871 pretty good start. I still need to:
2873 1. Change the style so that it fits better into the current theme
2874 2. Adjust the details cell to expand as much as possible.
2876 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2877 click handlers to navigation buttons in the DetailsCells. Create a
2878 refreshData() method to get just the data from the server without the
2880 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2881 Update the tableSelector and browser title when the table name
2882 changes without using the tableSelector.
2883 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2884 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2885 getDetailsCells() to getCells(). Update variable names.
2886 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add