1 2012-05-23 Murray Cumming <murrayc@murrayc.com>
3 Remove LayoutItemPortal.get/setNavigationTable().
5 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
6 Remove get/setNavigationTable(), which is only a cache, because it is not
7 used, and does not need to be used, because that decision should be made on
9 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
10 updatePortalsExtras():
11 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
12 getNavigationRecord():
13 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
16 2012-05-21 Murray Cumming <murrayc@murrayc.com>
18 Initial self-hosting for tests.
20 * pom.xml: Change the scope for log4j, to hopefully make it
21 available to the test code which uses it indirectly via jOOQ.
22 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
23 self-hosting, though we only use it for testing.
25 * src/main/java/org/glom/web/server/libglom/Document.java:
26 example rows: Use a map instead of a list for each row of values,
27 so we know what field they are for, instead of relying on the sequence
28 being correct. This is not very efficient, but it does not really need
30 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
31 testReadTableExampleRows(): Adapted.
33 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
34 that returns an Object, for generic use. Note that Object seems to be
35 the implicit base even of double.
36 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
37 for use in CREATE TABLE SQL queries.
38 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
39 to do self-hosting of PostgreSQL databases via its command-line
40 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
41 backends/postgres_self.cc. This is incomplete - it needs more
42 warnings about failures and it needs to clean up properly when things
44 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
45 test of this new class.
47 2012-05-21 Murray Cumming <murrayc@murrayc.com>
49 Document: loading example data: Handle exceptions.
51 * src/main/java/org/glom/web/server/libglom/Document.java:
52 DateFormat.parse() and Double.valueOf() can throw exceptions, though
53 Eclipse did not warn about that.
55 2012-05-20 Murray Cumming <murrayc@murrayc.com>
57 Document: load(), save(): Handle the example rows.
59 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
61 * src/main/java/org/glom/web/server/libglom/Document.java:
62 load(), save(): Load and save the example rows, though the date, time
63 and image types are not handled properly yet.
64 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
65 Add testReadTableExampleRows() just to check that something is read.
67 2012-05-20 Murray Cumming <murrayc@murrayc.com>
71 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
72 Added getTranslationsMap() for use while saving.
73 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
74 Adedd getUseDefaultFormatting() for use while saving.
75 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
76 and several private methods that it uses.
78 This will be useful while testing via self-hosting.
79 It is not complete, but should be complete enough for testing.
81 2012-05-17 Murray Cumming <murrayc@murrayc.com>
83 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
85 * src/main/java/org/glom/web/client/OnlineGlomService.java
86 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
87 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
88 Remove getSortedListViewData() and getSortedRelatedListData(), adding
89 the sort column index and ascending bool to the regular method.
90 Instead, a sort column index of -1 now means no sort.
91 This is less explicit, but it's fairly simple, reduces the amount of
92 code, and makes the OnlineGlomService API slightly smaller.
93 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
94 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
96 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
97 getListViewData(), getRelatedListData():
98 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
99 getListViewData(), getRelatedListData():
100 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
102 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
104 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
109 2012-05-16 Murray Cumming <murrayc@murrayc.com>
111 Use translations for top-level groups too.
113 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
114 updateTitlesForLocale(): Use the translation for the group
115 as well as for child items.
119 Just recompiled to fix a problem in the released .tar.gz file.
123 2012-05-15 Murray Cumming <murrayc@murrayc.com>
125 Corrections to navigation to related records.
127 * src/main/java/org/glom/web/client/OnlineGlomService.java:
128 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
129 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
130 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
131 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
132 relationship name, because the relationship name is not necessarily unique
134 TOOD: This is inefficient, because it passes the whole list of
135 child field items back to the server, but it is more correct, and happens
136 to fix a bug with the primary key being lost after a few navigations.
137 There is probably a chance to make this more efficient anyway in some
140 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
141 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
142 * src/main/java/org/glom/web/server/ConfiguredDocument.java
143 * src/main/java/org/glom/web/server/database/DBAccess.java
144 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
145 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
148 2012-05-15 Murray Cumming <murrayc@murrayc.com>
150 Fix the use of translations.
152 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
153 Add updateTitlesForLocale().
154 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
155 Call it to discard unwanted translations and to make getTitle() return
156 the wanted translation wihout the need for the client code to specify a locale.
157 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
158 getTitle(): Fallback to the original title, as libglom does.
160 2012-05-15 Murray Cumming <murrayc@murrayc.com>
162 Document: Correctly report the number of available translation locales.
164 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
165 the available locale IDs list.
166 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
167 testLocales: Test this.
169 2012-05-15 Murray Cumming <murrayc@murrayc.com>
171 SqlUtils: Use camelCase.
173 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
174 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
175 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
176 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
177 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
178 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
180 2012-05-15 Murray Cumming <murrayc@murrayc.com>
182 Use jOOQ's tableByName() and fieldByName.
184 * pom.xml: Use jOOQ 2.3.1 to get the new API.
185 * src/main/java/org/glom/web/server/SqlUtils.java:
186 build_sql_select_step_with_where_clause(), .createField(),
187 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
188 so we can get correct quoting and escaping. Thanks to Lukas Eder for
189 adding this, and other things, to jOOQ.
191 2012-05-15 Murray Cumming <murrayc@murrayc.com>
193 SqlUtils: Remove the Connection parameters.
195 * src/main/java/org/glom/web/server/SqlUtils.java:
196 build_sql_select_with_key(), build_sql_select_with_where_clause(),
197 createSelect(), build_sql_select_step_with_where_clause(),
198 build_sql_count_select_with_where_clause(),
199 build_sql_select_count_rows(): Remove the Connection parameter because
200 jOOQ does not actually need a connectionwhen it is just used to build
202 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
204 * src/main/java/org/glom/web/server/ReportGenerator.java:
206 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
208 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
209 Constructor, getListData(), getResultSizeOfSQLQuery():
210 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
211 getSelectQuery(), getCountQuery():
212 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
213 getSelectQuery(), getCountQuery():
214 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
215 getNavigationRecord(): Adapted.
217 2012-05-14 Murray Cumming <murrayc@murrayc.com>
221 * src/main/java/org/glom/web/server/SqlUtils.java:
222 get_find_where_clause_quick(): Use a comparison of
223 lowercase values, instead of a simple equals. Regular Glom
224 uses the PostgreSQL ILIKE operator but jOOQ does not
225 support that just yet, though it will soon.
227 2012-05-14 Murray Cumming <murrayc@murrayc.com>
229 TableToViewDetails: Use a real serialization ID.
231 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
232 Though this does not fix the serialization problem.
234 2012-05-12 Murray Cumming <murrayc@murrayc.com>
236 Added LayoutItemPortalDeepCloneTest.
238 2012-05-11 Murray Cumming <murrayc@murrayc.com>
240 Make navigation work again.
242 * src/main/java/org/glom/web/server/libglom/Document.java:
243 Add getLayoutItemFieldShouldHaveNavigation().
244 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
245 Replace get/setAddNavigation() with the partly-existing
246 get/setNavigationTableName(), with an empty string being no navigation,
247 because this is simpler. Use the new
248 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
250 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
251 Add updateFieldsExtras() and call setNavigationTableName in it.
252 getDetailsLayoutGroup(),
253 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
254 createLayout(): Adapted.
255 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
256 Constructor: Adapted.
258 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
259 Replace get/setAddNavigation() with get/setNavigation(), returning a
260 TableToViewDetails class with both the table name and UsesRelationship,
261 because both are need. The previous code used java-libglom's output
262 variable (strangely, via sharedptr) to return both, but we cannot really
264 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
265 getNavigationRecord(): Adapt. However, we cannot actually use the cache
266 here because it somehow gets set to null during deepCopy(). I must test this.
267 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
268 testGetSuitableTableToViewDetails(): Adapted.
270 TODO: Find out why deepClone() is not quite working.
272 2012-05-11 Murray Cumming <murrayc@murrayc.com>
274 DBAccess: Simplify the retrievel of full field details.
276 * src/main/java/org/glom/web/server/database/DBAccess.java
277 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
278 because the Document loading should have done this.
280 2012-05-11 Murray Cumming <murrayc@murrayc.com>
282 Document: Correct loading of doubly-related layout fields.
284 * src/main/java/org/glom/web/server/libglom/Document.java:
285 loadUsesRelationship(): Actually set the related relationship, instead
286 of only setting it if it's not found.
288 2012-05-09 Murray Cumming <murrayc@murrayc.com>
290 Replace all appearances of Colour with color.
292 Because US English is dominant.
294 2012-05-09 Murray Cumming <murrayc@murrayc.com>
296 Use colors in HTML format, solving a warning about an unused function.
298 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
299 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
300 Add *asHTMLColor() versions of methods.
301 TODO: However, we should create and cache the results on the server.
302 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
303 * src/main/java/org/glom/web/client/ui/list/ListTable.java
304 * src/main/java/org/glom/web/server/ConfiguredDocument.java
305 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
306 Use the asHTMLcolor() versions.
308 2012-05-09 Murray Cumming <murrayc@murrayc.com>
310 ListViewTable: Constructor: Take the table name as a parameter.
312 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
313 Constructor: Take the tableName, and set the member variable, because
315 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
316 setCellTable(): Pass the table name.
317 This makes navigation to non-default tables work again. I don't know
318 why it worked before in the master branch.
320 2012-05-07 Murray Cumming <murrayc@murrayc.com>
322 ConfiguredDocument: Restore correct addition of hidden primary key items.
324 * src/main/java/org/glom/web/client/ui/list/ListTable.java
325 (ListTable.createCellTable): Uncomment out the check for the hidden
327 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
328 add primary key items for top-level lists and portals, as before,
329 instead of adding them to each group.
330 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
331 Actually implement the extra methods such as setHiddenPrimaryKey() and
332 comment that these are used only for top-level list groups and in portals.
333 This strangeness suggests even more that this should not be squeezed
334 into the LayoutGroup class.
336 2012-05-07 Murray Cumming <murrayc@murrayc.com>
338 Fix Formatting loading.
340 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
341 getFormattingUsed(): Remove the duplicate Formatting member variable
342 in favour of the one from the base class.
343 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
344 Initialize a new Formatting instead of using null by default, so we
345 have some defaults, instead of having to initialize one later just to
346 get the same defaults. This also makes loading of formatting from the
347 document work, because that expected a non-null.
349 2012-05-07 Murray Cumming <murrayc@murrayc.com>
351 RelatedListTable: Make sure that the tableName is set.
353 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
354 Constructor: Take the tableName so it is available later. Otherwise,
355 the server assumes that we mean the default table and cannot find the
357 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
358 setData(): Pass the tableName to the RelatedListTable constructor.
360 2012-05-07 Murray Cumming <murrayc@murrayc.com>
364 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
365 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
366 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
368 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
370 * src/main/java/org/glom/web/server/database/DBAccess.java:
371 convertResultSetToDTO(), getPortal():
372 * src/main/java/org/glom/web/server/database/ListDBAccess.java
374 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
375 Add checks for null objects and out of range access, with log messages to
376 give hints so we can fix these properly.
378 2012-05-07 Murray Cumming <murrayc@murrayc.com>
380 Portals: some corrections.
382 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
384 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
385 constructor: Use getRelationshipNameUsed() instead of getName(), because
386 that is what is meant.
387 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
388 getFromField(): Fix a typo, to get the field name, not the table name.
389 * src/main/java/org/glom/web/server/database/DBAccess.java:
390 getPortal(): Fix a typo that stopped this from working.
392 2012-05-07 Murray Cumming <murrayc@murrayc.com>
394 LayoutItemPortal: Also override getTitleOriginal().
396 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
397 This lets the base getTitle() with no parameters work.
398 TODO: Test this properly.
400 2012-05-06 Murray Cumming <murrayc@murrayc.com>
402 LayoutItemPortal: getTitle*(): Use the relationship title.
404 2012-05-06 Murray Cumming <murrayc@murrayc.com>
406 LayoutItemField: Fix loading of custom titles.
408 * src/main/java/org/glom/web/server/libglom/Document.java
409 loadDataLayoutItemField(): The title, if any, instead of the field
410 title, is stored in a title_custom node. Load it from there.
411 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
413 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
414 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
415 getTitle*() overrides.
416 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
419 2012-05-06 Murray Cumming <murrayc@murrayc.com>
421 LayoutItemField: Fall back to field titles, so some are really shown.
423 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
424 Override getTitleOriginal() and getTitle(), as in java-libglom.
425 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
428 2012-05-06 Murray Cumming <murrayc@murrayc.com>
430 Correct use of setExpectedResultSize().
432 * src/main/java/org/glom/web/server/ConfiguredDocument.java
433 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
434 Use setExpectedResultSize only on top-level groups (for instance, the
435 list layout) or on child portals (in details views).
436 Use the correct table name for portals to avoid SQL errors.
437 Update the expected counts when returning cached layouts.
439 2012-05-06 Murray Cumming <murrayc@murrayc.com>
441 Document: Interpret no group column count as 1.
443 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
444 default, though we now check for this in the UI code anyway.
446 2012-05-06 Murray Cumming <murrayc@murrayc.com>
450 2012-05-06 Murray Cumming <murrayc@murrayc.com>
452 Translatable: Use Hashmap instead of Treemap because GWT supports it.
454 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
455 The use of Treemap lead to this error from async methods, with no
457 "The response could not be deserialized"
459 2012-05-06 Murray Cumming <murrayc@murrayc.com>
461 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
463 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
464 when using the Google -> GWT Compile, or
465 g toolbar button -> GWT Compile Project... feature in Eclipse.
467 2012-05-06 Murray Cumming <murrayc@murrayc.com>
469 ListTable.addColumn(): Protect against a null Formatting.
471 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
472 Create a default Formatting if it is null, because that is the simplest
475 2012-05-06 Murray Cumming <murrayc@murrayc.com>
477 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
479 * src/main/java/org/glom/web/server/ConfiguredDocument.java
480 updateLayoutGroup(): Check that the field is not null.
482 2012-05-06 Murray Cumming <murrayc@murrayc.com>
484 ListViewImpl: Protected against a bad cast error.
486 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
487 onEnterKeyDown(): Do not cast without an instanceof check.
489 2012-05-06 Murray Cumming <murrayc@murrayc.com>
491 ListTable: Protect against an out of range error.
493 * src/main/java/org/glom/web/client/ui/list/ListTable.java
494 createCellTable(): This is unlikely, but can happen while debugging.
496 2012-05-06 Murray Cumming <murrayc@murrayc.com>
498 AsyncMessage onFailure() callbacks: Log the exception message.
500 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
501 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
502 * src/main/java/org/glom/web/client/activity/ListActivity.java:
503 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
504 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
505 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
506 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
507 These are useful clues when something is wrong.
509 2012-05-06 Murray Cumming <murrayc@murrayc.com>
511 ConfiguredDocument: Avoid a null dereference.
513 * src/main/java/org/glom/web/server/ConfiguredDocument.java
514 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
515 details maps are created.
517 2012-05-06 Murray Cumming <murrayc@murrayc.com>
519 Document: Correct the port number parsing.
521 * src/main/java/org/glom/web/server/libglom/Document.java:
522 This lets us actually connect to the database and show the document.
524 2012-05-05 Murray Cumming <murrayc@murrayc.com>
528 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
529 user-interaction, asking us to load a temporary URL in a browser.s
530 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
531 which is apparently necessary for testing the service. See the comment.
532 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
533 Show the exception, if any. This is how I saw the 404 in the HTML in
536 2012-05-05 Murray Cumming <murrayc@murrayc.com>
538 DocumentTest: Move the .glom files into the resources directory.
540 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
541 URI via getResource().
543 2012-05-05 Murray Cumming <murrayc@murrayc.com>
545 Document: Remove the FieldIdentifies inner class.
547 * src/main/java/org/glom/web/server/libglom/Document.java: We only
548 use the Relationship (though the same function in libglom is maybe
549 used in other ways) and so this removes a compiler warning.
551 2012-05-05 Murray Cumming <murrayc@murrayc.com>
553 Document.load() Remove the error code parameter.
555 * src/main/java/org/glom/web/server/libglom/Document.java: load():
556 Remove the parameter. We do not set it yet and it could never have
557 worked as an output parameter (though maybe it did in java-libglom).
558 We could use an exception if we really want the failure reason.
559 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
561 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
562 setUp(), testGetSuitableTableToViewDetails(): Adapt.
564 2012-05-05 Murray Cumming <murrayc@murrayc.com>
566 Make some inner classes static.
568 * src/main/java/org/glom/web/server/ConfiguredDocument.java
569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
570 * src/main/java/org/glom/web/server/ReportGenerator.java
571 * src/main/java/org/glom/web/server/libglom/Document.java
572 Make all inner classes static that can be static.
574 2012-05-05 Murray Cumming <murrayc@murrayc.com>
576 OnlineGlomServiceImpl: Do not load and check for java-libglom.
578 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
579 init(): We do not use java-libglom any more.
581 2012-05-05 Murray Cumming <murrayc@murrayc.com>
583 Remove mentions of java-libglom.
585 * README: Remove mention of java-libglom, because it no longer needed.
586 * utils/build-onlineglom-war.sh:
587 * utils/check-and-recover-tomcat.py:
588 * utils/install-onlineglom-war.sh: Remove these as they are no longer
589 useful. Building is now far easier, with no need for jhbuild.
591 2012-05-05 Murray Cumming <murrayc@murrayc.com>
593 Fix the build (mvn package)
595 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
596 (LayoutGroup): Make the LayoutItemList inner class static and protected.
597 Otherwise the GWT Java->Javascript compilation fails with just this
598 error, during mvn package or when attempting to view in a browser,
599 in the GWT developer mode in Eclipse.
601 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
602 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
603 [INFO] Compiling module org.glom.web.OnlineGlom
604 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
605 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
606 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
607 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
608 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
609 [INFO] [ERROR] Cannot proceed due to previous errors
611 It has taken me 2 days to find out what was causing that. After reducing
612 the code, the compiler eventually showed me the full error message.
614 2012-05-04 Murray Cumming <murrayc@murrayc.com>
616 ConfiguredDocument: Cache the cloned and stripped layouts.
618 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
619 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
620 layout in a map, so we can retrieve it again without rebuilding it.
622 2012-05-04 Murray Cumming <murrayc@murrayc.com>
624 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
626 2012-05-04 Murray Cumming <murrayc@murrayc.com>
628 libglom classes: Implement some auto-generated emthods.
630 2012-05-04 Murray Cumming <murrayc@murrayc.com>
632 Add GwtTestOnlineGlomService.
634 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
635 However, this (and the other GwtTest*) does not seem to run during
638 2012-05-04 Murray Cumming <murrayc@murrayc.com>
640 Remove use of unsupported features from client code.
642 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
643 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
644 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
645 Use our client version of StringUtils instead of the apache commons one.
647 However, the GWT Javascript compliation still fails.
649 2012-04-25 Murray Cumming <murrayc@murrayc.com>
651 Add a Field class and implement some loading of it in Document.
653 2012-04-25 Murray Cumming <murrayc@murrayc.com>
655 Initial Document loading implementation, instead of libglom.
657 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
658 and Translatable classes, and adapt the rest of the code to use them.
659 However, this is still missing Layout and Field classes and loading.
661 2012-04-24 Murray Cumming <murrayc@murrayc.com>
663 Use of jOOQ: Move Field creation into a utility method.
665 * src/main/java/org/glom/web/server/SqlUtils.java:
666 This lets us improve it more easily.
668 2012-04-24 Murray Cumming <murrayc@murrayc.com>
670 Use of jOOQ: Improve the code to COUNT a sub-select.
672 * src/main/java/org/glom/web/server/SqlUtils.java:
673 Move initial query creation into
674 build_sql_select_step_with_where_clause().
675 build_sql_select_count_rows(): Use the jOOQ API instead of
676 concatentating text, because a jOOQ Select*Step is a TableLike,
677 which is what from() takes.
679 2012-04-23 Murray Cumming <murrayc@murrayc.com>
681 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
683 * pom.xml: Depend on jooq.
684 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
685 methods with jOOQ, based on the C++ implementations in libglom,
686 with some changes to the logic required by jooQ.
687 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
689 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
690 * src/main/java/org/glom/web/server/ReportGenerator.java:
691 * src/main/java/org/glom/web/server/SqlUtils.java:
692 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
693 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
694 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
695 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
696 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
697 Adapt. In particular, the SqlUtils methods now need to take a Connection,
698 because jOOQ needs that, though it seems unnecessary.
700 This is not quite finished. Ideally jOOQ would help us to build
701 table_name.field_name names, quoting and escaping them properly.
702 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
704 2012-04-21 Murray Cumming <murrayc@murrayc.com>
706 Move use of Glom.build_sql*() into a new SqlUtils class.
708 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
709 to wrap Glom.build_sql*(). The parameter types are still Glom one,
710 but this will make it easier to start using something other than
711 libglom or SqlBuilder.
713 2012-04-21 Murray Cumming <murrayc@murrayc.com>
715 Update the project URL.
717 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
719 2012-04-21 Murray Cumming <murrayc@murrayc.com>
721 Main layout: Use a FlowTable instead of absolute positioning.
723 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
724 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
725 child panels/widgets must have an absolute position. But that is annoying, so
726 this adds a FlowTable and puts the child panels in there.
728 2012-04-21 Murray Cumming <murrayc@murrayc.com>
730 GwtTestOnlineGlom: Comment out unused code.
732 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
733 Eclipse has started to say that some code is unused.
735 2012-04-21 Murray Cumming <murrayc@murrayc.com>
737 Update to the latest versions of dependencies.
739 * pom.xml: Update version numbers of dependencies to the latest
741 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
742 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
743 * src/main/java/org/glom/web/server/ReportGenerator.java:
744 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
745 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
746 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
748 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
749 Modify the imports where necessary.
751 2012-04-17 Murray Cumming <murrayc@murrayc.com>
753 Style: Remove overflow:hidden from searchbox
755 * src/main/webapp/style.css: Because this pushes the Back To Link
756 label/link on to the next row, which is then hidden due to the
757 hard-coded (in ems) height.
759 2012-04-20 Murray Cumming <murrayc@murrayc.com>
761 Remove some duplicate code.
763 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
764 getDocumentInfo(): This must have been duplicated during the merge from the
769 2012-04-19 Murray Cumming <murrayc@murrayc.com>
771 Reports: Localize the waiting for report message.
773 * src/main/java/org/glom/web/client/activity/ReportActivity.java
774 start(): Get the message from the contants.
775 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
777 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
778 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
779 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
780 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
781 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
782 Update these files with the English text for newer strings for now.
784 2012-04-19 Murray Cumming <murrayc@murrayc.com>
786 Reports: Show a message while waiting for the report.
788 * src/main/java/org/glom/web/client/ui/ReportView.java
789 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
790 Add setWaitingText(), to show a message saying that we are
791 waiting for the report to be ready.
792 * src/main/java/org/glom/web/client/activity/ReportActivity.java
793 start(): Call setWaitingText() before calling the async
796 2012-04-19 Murray Cumming <murrayc@murrayc.com>
798 ReportGenerator: Specify date and time formats.
800 * src/main/java/org/glom/web/server/ReportGenerator.java:
801 createFieldValueElement(): Use the default (and localized)
802 short formats, though we still need a way to show 4-digit
803 years without providing the format for every locale.
804 * src/main/java/org/glom/web/server/database/DBAccess.java:
805 convertResultSetToDTO(): Use the short formats here too.
807 2012-04-18 Murray Cumming <murrayc@murrayc.com>
809 ReportGenerator: Use the correct numeric formatting.
811 * src/main/java/org/glom/web/server/ReportGenerator.java
812 createFieldExpression(), createFieldValueElement(): Take the
813 whole LayoutItem_Field instead of just the field name, so
814 we have access to the formatting.
815 createFieldValueElement(): Use JRTextField.setPattern() to
816 specify the numeric formatting, with the help of a
817 regular DecimalFormat.
819 2012-04-18 Murray Cumming <murrayc@murrayc.com>
821 ReportGenerator: Avoid showing null for group by titles.
823 * src/main/java/org/glom/web/server/ReportGenerator.java
824 generateReport(): Use setBlankWhenNull() on the field title
825 style too, because this is used for values in group by
828 2012-04-18 Murray Cumming <murrayc@murrayc.com>
830 ReportGenerator: Add a colon to titles in vertical groups.
832 * src/main/java/org/glom/web/server/ReportGenerator.java
833 addFieldToDetailBandVertical(): Pass true for the withColon
836 2012-04-18 Murray Cumming <murrayc@murrayc.com>
838 ReportGenerator: Simplify the code by using Position more.
840 2012-04-18 Murray Cumming <murrayc@murrayc.com>
842 Reports: Support vertical groups, roughly.
844 * src/main/java/org/glom/web/server/ReportGenerator.java:
845 addToReport(): Rename to addGroupToReport() and, if necessary,
846 call the new addVerticalGroupToReport() method.
847 createFieldValueElement(): Let the caller specify the Y position
850 2012-04-17 Murray Cumming <murrayc@murrayc.com>
852 Reports: Allow a second report to be shown.
854 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
855 clear(): Do not remove the HTML widget, which broke the whole layout.
857 2012-04-17 Murray Cumming <murrayc@murrayc.com>
859 Locales drop-down: Show that we use English by default.
861 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
862 fillView(): When we use English, just because that is the default, when
863 no locale is specified, show that in the Locales drop-down instead of
864 just showing the first item.
866 2012-04-17 Murray Cumming <murrayc@murrayc.com>
868 Unselect the Report/Locale/Table combo item when appropriate.
870 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
871 setPlace(): clear reportName if this is not a ReportPlace.
872 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
873 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
874 When the provided name is empty, unselect all items, so that none are
875 indicated. This uses a for loop because I cannot find a single method
878 2012-04-17 Murray Cumming <murrayc@murrayc.com>
880 Report: Give the user a way to get back to the list.
882 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
883 start(), setPlace(): Show the Back To List link on reports, and also
884 interpret selecting the empty report item as back to list.
886 2012-04-13 Murray Cumming <murrayc@murrayc.com>
888 Really show the selected Report name.
890 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
891 setPlace(): Store the reportName here, if it is that kind of Place.
892 fillView(): Set the selected Report after filling the list of reports.
893 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
894 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
895 null Strings, though we need some way to unselect all ListBox items
898 2012-04-13 Murray Cumming <murrayc@murrayc.com>
900 ReportGenerator: Try to avoid some problems.
902 * src/main/java/org/glom/web/server/ReportGenerator.java
903 addField(): Try to avoid duplicates, and avoid using a null
906 2012-04-13 Murray Cumming <murrayc@murrayc.com>
908 Reports: Use quickFind.
910 * src/main/java/org/glom/web/client/OnlineGlomService.java;
911 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
912 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
913 getReportHTML(): Add a quickFind parameter.
914 * src/main/java/org/glom/web/client/activity/ReportActivity.java
915 start(): Pass the quickFind parameter.
916 * src/main/java/org/glom/web/server/ReportGenerator.java
917 generateReport(): Take a quickFind parameter.
919 2012-04-13 Murray Cumming <murrayc@murrayc.com>
921 ReportPlace: Actually use the report name.
923 * src/main/java/org/glom/web/client/place/ReportPlace.java
924 getPlace(): Do not assign the report name to the quickfind.
926 2012-04-13 Murray Cumming <murrayc@murrayc.com>
928 Show java.library.path when complaining.
930 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
931 init(): When telling us to check java.library.path, show the
934 2012-03-06 Murray Cumming <murrayc@murrayc.com>
936 ReportGenerator: Do not show nulls.
938 2012-03-06 Murray Cumming <murrayc@murrayc.com>
940 ReportGenerator: Make the title font larger.
942 2012-03-06 Murray Cumming <murrayc@murrayc.com>
944 ReportGenerator: Put field titles inside groups, if there are groups.
946 2012-03-06 Murray Cumming <murrayc@murrayc.com>
948 ReportGenerator: Take the Report itself instead of the name and group.
950 * src/main/java/org/glom/web/server/ConfiguredDocument.java
951 Remove getReportLayoutGroup().
952 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
953 getReportHTML(): Pass the report instead
954 of its name and layout group.
955 * src/main/java/org/glom/web/server/ReportGenerator.java
956 generateReport(): Use the report object to use the title
959 2012-03-06 Murray Cumming <murrayc@murrayc.com>
961 ReportGenerator: Remove designBand parameters.
963 * src/main/java/org/glom/web/server/ReportGenerator.java:
964 Make designBand a class member instead of passing it to all
967 2012-03-06 Murray Cumming <murrayc@murrayc.com>
969 ReportGenerator: Add lines, a bit like in the desktop version.
971 * src/main/java/org/glom/web/server/ReportGenerator.java
972 addToReport(): Use JRDesignLine.
974 2012-03-06 Murray Cumming <murrayc@murrayc.com>
976 ReportGenerator: Correct the title positions and use some bold style.
978 * src/main/java/org/glom/web/server/ReportGenerator.java:
979 Break the code up into reusable functions, correct the placement of
980 titles, and use normal/bold styles as in the reports in the desktop
983 2012-03-06 Murray Cumming <murrayc@murrayc.com>
985 ReportGenerator: Add a header band to show the field titles.
987 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
988 getReportHTML(): Pass the localeId to the ReportGenerator
990 * src/main/java/org/glom/web/server/ReportGenerator.java
991 constructor: Take the localeID so we can get translated field
993 generateReport(), addToReport(), addFieldToBand(): Add field
994 titles in a column header band.
996 2012-03-05 Murray Cumming <murrayc@murrayc.com>
998 Reports drop-down list: Some improvement.
1000 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1001 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1002 Adedd setSelectedReport(),
1003 setReportList(): Add a blank line so that the user can select the
1005 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1006 start(): Show the current report by calling setSelectedReport().
1007 This does not seem to work yet.
1009 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1011 DetailsActivity, ListActivity: Move some variables into a base class.
1013 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1014 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1015 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1016 the clientFactory, documentID, tableName and authenticationPopup into
1017 a base class, to avoid duplication.
1019 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1021 Translate the Reports label.
1023 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1024 Get the "Reports" label string from the constants.
1025 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1026 perties: Add Reports to the constants.
1028 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1030 Reports: Implement grouping.
1032 * src/main/java/org/glom/web/server/ReportGenerator.java:
1033 Handle LayoutItem_GroupBy items and try to do the right thing
1034 with JRDesignGroup. It seems to work.
1036 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1038 Actually show some data with JasperReports.
1040 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1041 getReportHTML(): Move most code into a ReportGenerator class.
1042 * src/main/java/org/glom/web/server/ReportGenerator.java:
1043 Recurse into sub-groups, adding fields to the JasperDesign's details
1044 band. Note that we must set an arbitrary width and height, or it just
1045 will not show any data.
1047 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1049 Reports Chooser: Show the titles, not the names.
1051 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1052 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1053 and the names as the values.
1054 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1055 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1056 group now that we provide the report name, so it should always
1059 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1061 Depend on jasperreports.
1063 * pom.xml: Add the dependency. My plan is to use this on the
1066 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1068 Implement navigation to report places.
1070 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1071 start(): Do not bother to handle all events here.
1072 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1073 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1074 Added getSelectedReport().
1075 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1076 .java: start(): When handling a change to the reports chooser,
1077 call getSelectedReport() and goTo() its ReportPlace.
1078 * src/main/java/org/glom/web/client/ui/ReportView.java
1079 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1080 Added setReportHTML() which puts the html in a gwt HTML widget.
1081 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1082 getReportHTML(): Return "TODO" just to show that this works.
1084 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1086 Make ReportPlace usable.
1088 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1089 Mention ReportPlace.
1090 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1091 Correct the @prefix annotation.
1093 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1095 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1097 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1098 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1099 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1100 Change getReportLayout() to getReportHMTL() because we will not need to
1101 parse or render the report layout on the client side.
1102 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1103 getReportLayout(): Return the libglom LayoutGroup type because we will
1104 not need to convert to a shared type, because this will not be used on
1106 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1109 Note that there is still no implementation for this.
1112 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1114 Add a (empty) Report Place, View, and Activity.
1116 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1118 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1119 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1120 this into a superclass:
1121 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1122 and also use it as the base of this new ReportPlace:
1123 * src/main/java/org/glom/web/client/place/ReportPlace.java
1125 * src/main/java/org/glom/web/client/ui/ReportView.java
1126 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1127 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1128 Add these, containing mostly boiler-plate for now.
1130 * src/main/java/org/glom/web/client/OnlineGlomService.java
1131 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1132 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1133 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1134 Add API to get the LayoutGroup for the report.
1136 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1138 Add and fill a Reports drop-down list box.
1140 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1142 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1143 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1144 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1145 Added getReports(document, table, localeID), calling
1146 ConfiguredDocument.getReports().
1147 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1148 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1149 Added setReportsList() and a list widget.
1150 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1151 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1156 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1158 Translations: Add Esperanto.
1160 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1161 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1162 properties: Add this translation because someone took the time to make it.
1164 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1166 Adapt to the java-libglom 1.21.7 API.
1168 * src/main/java/org/glom/web/server/ReportGenerator.java:
1169 addToReport(): get_group_secondary_fields() is now
1170 get_secondary_fields().
1173 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1175 Use the latest java-libglom version.
1177 * pom.xml: Use java-libglom 1.21.7.
1179 2012-03-03 Ben Konrath <ben@bagu.org>
1181 Display date and time in details view.
1183 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1185 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1187 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1189 Require the latest java-libglom.
1191 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1193 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1195 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1197 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1198 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1199 an empty quickfind string. I also corrected libglom to create only
1200 empty where clauses for empty quickfind strings, but this avoids the
1203 2012-02-24 Ben Konrath <ben@bagu.org>
1205 Improve the tabs in the Notebook widget.
1209 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1211 Translations: Try to translate the strings.
1213 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1214 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1215 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1216 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1217 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1218 Take the Open translation from GTK+'s .po files.
1219 Take the Details translation from Glom's po files.
1220 I have added the other strings to Glom so we can get translations that way:
1221 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1223 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1225 TableSelectionViewImpl: Put the search label and entry in a div.
1227 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1228 Put the search widgets in a FlowTable so that the CSS can be used to
1229 style them while keeping them together.
1230 * src/main/webapp/style.css: Mention the new div.
1232 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1234 Translate more strings in more locales.
1236 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1237 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1238 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1239 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1240 Translate the "Details" and "Open" string too.
1242 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1243 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1244 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1245 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1246 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1247 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1248 Add these new locales as placeholders though they currently contain English.
1250 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1252 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1254 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1255 Check the ConfiguredDocument* for null before using it.
1257 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1259 Tell Eclipse about the generated java files.
1261 * .classpath: This lets it find OnlineGlomConstants.java.
1262 It would be nice if Eclipse just used the maven build files.
1264 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1266 Prevent a crash when no locale is specified in the URL.
1268 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1269 Avoid returning a null string, obtained from
1270 Window.Location.getParameter(). This caused a crash when it was
1271 later passed to libglom's API.
1272 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1273 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1274 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1275 guard against future null strings.
1277 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1279 Use the ?locale= query param instead of the &lang= token param.
1281 * src/main/java/org/glom/web/client/place/ListPlace.java
1282 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1283 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1284 Remove the lang token key and value.
1286 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1287 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1288 When the user selects a different locale from the chooser, use
1289 Window.Location.assign() to change the URL, which then causes a reload.
1291 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1292 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1293 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1294 * src/main/java/org/glom/web/client/activity/ListActivity.java
1295 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1296 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1297 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1298 * src/main/java/org/glom/web/client/ui/ListView.java:
1299 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1301 Remove localeID member variables and method/constructor parameters, instead
1302 using Utils.getCurrentLocaleID() when we need a localID to pass to
1305 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1307 Internationalize the UI strings.
1309 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1310 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1311 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1312 because it is unused. Messages are apparently strings that can have
1313 parameters, but we do not need that yet, so Contants will be enough for now.
1314 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1315 to say that we support the en and de locales.
1316 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1317 The original English strings.
1318 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1319 Some German translations of the English strings.
1320 The i18n goal then uses the .properties file to generate an
1321 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1322 returns an implementation that returns the translated strings.
1323 The documentation suggests putting these in src/java/*/client/, but it seems
1324 best to put it in src/resources/*/client/.
1325 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1326 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1327 instead of hard-coding them.
1328 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1329 but that does not seem to stop the build, though it confuses Eclipse.
1331 You can see the translated string by adding ?locale=de to the URL, like so:
1332 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1334 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1336 Improve null/empty String checks.
1338 * pom.xml: Add a dependency on commons-lang, to use
1339 org.apache.commons.lang.StringUtils.
1340 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1341 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1342 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1343 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1344 Use StringUtils.isEmpty().
1346 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1347 StringUtils class with a static isEmpty() function because we
1348 cannot use org.apache.commons.lang.StringUtils in client-side
1349 GWT code because it (apparently) cannot be compiled to javascript.
1350 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1351 * src/main/java/org/glom/web/client/activity/ListActivity.java
1352 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1353 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1354 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1355 * src/main/java/org/glom/web/client/place/ListPlace.java
1356 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1357 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1358 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1359 * src/main/java/org/glom/web/client/ui/details/Group.java
1360 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1361 our StringUtils.isEmpty() function.
1363 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1365 Update to the latest java-libglom API.
1367 * pom.xml: Require java-libglom 1.21.4.
1368 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1369 getDocumentInfo(), getListViewLayoutGroup():
1370 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1372 * src/main/java/org/glom/web/server/database/DBAccess.java
1373 getFieldsToShowForSQLQueryAddGroup(),
1374 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1375 with either get_database_title_original() or
1376 get_database_title(localeID).
1378 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1380 ConfiguredDocument: Avoid a null pointer exception.
1382 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1383 Initialize localeID to "" to avoid returning a null String which
1384 causes a crash in java-libglom's swing-generated code.
1386 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1388 Some simple renaming.
1390 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1391 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1392 for localeChooser. This seems more appropriate and is less ambiguous
1393 particularly in the .css file.
1395 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1397 ConfiguredDocument: Rename the localedID private member variable.
1399 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1401 Adapt to the latest java-libglom API from git master.
1403 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1404 libglom now uses only Vector instead of List, which uses add() instead of
1407 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1409 ConfiguredDocument: Rename the localedID private member variable.
1411 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1413 Build a source tarball with mvn assembly:single
1415 * assembly.xml: Add this file.
1416 * pom.xml: Use the maven-assembly-plugin and tell it to use
1417 our assembly.xml file.
1419 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1421 OnlineGlomServiceImpl: Get .glom files recursively.
1423 * pom.xml: Depend on commons-io from org.apache.commons.
1424 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1425 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1426 files recursively, and with the easier filter for the extension.
1427 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1428 simplify that code too.
1430 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1432 README: Mention that you must install java-libglom packages separately.
1434 But then it works, because java-libglom is now in the central maven
1437 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1439 locales drop-down: Show the correct selected locale when the URL changes.
1441 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1442 .java: setPlace(): Move some code into fillView().
1444 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1446 locales drop-down: Do not lose the primary key.
1448 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1449 start(): onLocaleChange(): Pass the current primary key value,
1450 instead of an empty value.
1452 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1454 locales drop-down: Do not lose the drop-down selection.
1456 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1457 .java (TableSelectionActivity.fillView): Set the selected locale
1458 after changing the drop-down items (though we do not really need
1459 to change them just because the locale changes.)
1461 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1463 locales drop-down: Change the tables list when this changes.
1465 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1466 .java: TableSelectionActivity.start(): Move the async table titles
1467 retrieval into a private fillView() method and also call this when
1468 the chosen locale changes.
1469 Note that the document title is not actually translatable yet, but
1470 that is a problem that I should fix soon in libglom.
1472 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1474 Improve the placement of the locales drop-down.
1476 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1477 Put the title and locales drop-down in a div (gwt.FlowTable).
1478 * src/main/webapp/style.css: Add magic css properties to make this work.
1479 Also remove the left margin from the title so that it lines up with the
1482 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1484 locales selector: Show human-readable locale titles.
1486 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1487 getDocumentInfo(): Use java.util.Locale to show a real title of
1488 each locale, in the locale's own language.
1490 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1492 Add a language/locale selector drop-down.
1494 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1495 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1496 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1497 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1498 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1499 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1500 Add a ListBox to show the available locales. Add getLocaleSelector(),
1501 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1502 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1503 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1504 java: Add these classes.
1505 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1506 start(): Fill the locales ListBox. Handle its change event, firing a
1508 setPlace(): Show the selected locale as specified by the URL token.
1509 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1510 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1511 Handle LocaleChangeEvent, going to a new *Place with that locale.
1513 The placement of the ListBox is not pretty, and it currently uses the ID
1514 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1518 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1520 Search box: Show the search text from the URL token.
1522 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1523 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1524 Add setQuickFindText().
1525 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1526 .java: setPlace(): Store the queryText if the place is a ListPlace,
1527 and call TableSelectionView.setQuickFindText().
1529 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1531 Allow use of translations via, for instance, &lang=de in the URL.
1533 * pom.xml: Use the unstable java-libglom 1.21 version.
1535 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1536 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1538 init(): Instead of calling TranslatableItem.set_current_locale()
1539 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1540 However, this is only for default locales, which are not needed to
1541 change the locale in the URL.
1542 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1543 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1544 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1545 layout for a particular locale.
1546 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1547 Add get/setDefaultLocaleID().
1548 getDocumentInfo(), getListViewData(), getRelatedListData(),
1549 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1550 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1551 localeID parameter, so we can get the layout for a particular locale.
1553 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1554 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1555 * src/main/java/org/glom/web/client/place/ListPlace.java:
1556 Parse and construct a lang parameter too.
1558 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1559 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1560 passed to subsequent methods and constructors.
1561 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1562 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1563 Store the localeID from the *Place and pass it to other constructors
1564 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1566 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1567 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1568 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1569 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1570 * src/main/java/org/glom/web/client/ui/ListView.java:
1571 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1572 Take localeID parameters and pass them to subsequent constructors and
1573 methods, so that the layout is always retrieved for that locale.
1575 This is rather repetitive.
1577 Note that "" means the original (default) locale of the Glom document,
1578 which is usually English.
1580 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1582 Documents: Remove final keyword to fix startup configuration.
1584 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1585 final keywords on the private member variables because that breaks
1586 the startup, apparently (there are warnings) because it stops them
1587 from being serialized. I added these in the previous commit.
1589 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1591 Documents: Add some final keywords.
1593 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1596 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1598 OnlineGlomServiceImpl: Add to overview comments.
1600 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1601 Note that this is where all the document are loaded. They are not
1602 loaded freshly for each page.
1604 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1608 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1609 Add a TextBox for the text of a quick find.
1610 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1612 setBackLink(): Add a String quickFind parameter.
1613 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1614 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1615 to the base interface, because that is how TableSelectionViewImpl is used.
1616 * src/main/webapp/style.css: Add style for the search box and its label.
1618 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1619 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1620 Add these files, based on the existing TableChangeEvent and
1621 TableChangeEventHandlers.
1622 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1623 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1624 a ListPlace() that the user should be taken to.
1625 * src/main/java/org/glom/web/client/activity/ListActivity.java
1626 start(): Handle it here too and adapt the TableChangeEvent handler to
1627 pass the extra "" quickFind parameter to ListPlace.
1628 * src/main/java/org/glom/web/client/place/ListPlace.java:
1629 Constructor: Take an extra String quickFind parameter and store it,
1630 returning it from a new getQuickFind() method.
1631 getToken(): Put the quickFind text in the URL token.
1632 getPlace(): Parse the quickFind text from the URL token.
1633 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1634 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1635 ListPlace constructor.
1636 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1637 .java: start(): Add a Change handler for the TableSelectionView's
1638 TextBox (via its base HasChangeHandlers interface), firing the new
1639 QuickFindChangeEvent.
1640 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1641 pass the extra "" quickFind parameter.
1643 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1644 setCellTable(): Add a String quickFind parameter and pass it to
1645 the ListViewTable() constructor.
1646 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1647 setCellTable() in the base interface, because that is how ListViewImpl
1650 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1651 Add a String quickFind member variable.
1652 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1653 Constructor: Add a String quickFind parameter, storing it in the
1654 base ListTable's member variable.
1655 onRangeChanged(): Pass quickFind to the
1656 OnlineGlomServiceAsync.getSortedListViewData() and
1657 OnlineGlomServiceAsync.getListViewData() methods.
1659 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1660 getListViewData(), getSortedListViewData(): Add a String quickFind
1661 parameter, passing it to ConfiguredDocument.getListViewData().
1662 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1663 Change getListViewData(), getSortedListViewData() in the base interface,
1664 because that is how OnlineGlomServiceImpl is used, via this:
1665 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1666 Change getListViewData(), getSortedListViewData() here too.
1667 This class can apparently be used to asynchronously call methods on
1668 OnlineGlomService, and GWT seems to implement that after recognizing
1669 just the *Async name convention and the extra AsyncCallback parameters.
1671 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1672 getListViewData(): Add a String quickFind parameter, and pass it to
1673 ListViewDBAccess.getData().
1674 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1675 getListData(): Add a String quickFind parameter and pass it to
1677 getSelectQuery(): Add a String quickFind parameter.
1678 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1679 getSelectQuery(): Add a String quickFind parameter and use it with
1680 Glom.get_find_where_clause_quick() to pass a where_clause to
1681 Glom.build_sql_select_with_where_clause(), to actually filter the
1683 getData(): Add a String quickFind parameter, passing it to getListData().
1684 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1685 va: getData(): Pass an empty string to getListData() for the
1686 quickFind parameter.
1688 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1690 ListTable: Minor change.
1692 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1693 createCellTable(): Make this protected instead of public.
1695 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1697 Many files: Use final for the parameters and use the @override attribute.
1699 2012-01-22 Ben Konrath <ben@bagu.org>
1701 Add anchor links for single line text that starts with http, ftp and www.
1705 2012-01-22 Ben Konrath <ben@bagu.org>
1707 Add ellipsis to single line text in details view.
1711 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1713 Remove all javadoc author tags.
1715 Because they are awkward and meaningless when many people touch
1717 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1719 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1721 Revert the COPYING.LESSER to COPYING rename.
1723 Apparently both should be there if it is LGPL.
1725 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1727 *View: Remove unused imports.
1729 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1730 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1731 * src/main/java/org/glom/web/client/ui/ListView.java:
1732 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1733 Remove unused imports, as suggested by Eclipse.
1735 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1737 Move the *View::Presenter types, and some API into one base View.
1739 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1740 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1741 * src/main/java/org/glom/web/client/ui/ListView.java:
1742 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1743 Presenter, setPresenter() and clear() into a shared base interface,
1744 to avoid the unnecessary duplicate Presenter types and to more clearly
1745 show how the *Views share the same structure, even if they are not
1746 used polymorphically.
1748 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1749 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1751 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1752 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1753 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1755 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1758 Feel free to revert this if there is a good reason for the duplicate
1761 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1763 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1765 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1766 a class member instead of a local variable in the method.
1767 This lets us use it to get the view instances, for use in tests.
1768 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1769 beforeOnlineGlom(): Test some more details of the initial view.
1770 Again, this is not very useful.
1772 To really test gwt-glom we will need to start a local postgresql
1773 instance with local data, like the Glom tests in C++.
1775 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1777 pom.xml: Mention the LGPL license.
1779 * pom.xml: Add a licenses section.
1780 * COPYING.LESSER: Move this to COPYING, which
1781 previously contained the GPL. But gwt-glom is all LGPL.
1783 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1785 Add project information to README and pom.xml.
1787 * README: Add a brief description and mention some mvn
1789 * pom.xml: This extra information shows up in mvn site
1792 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1794 Use the latest java-libglom version.
1796 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1798 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1800 GwtTestOnlineGlom: Test a little more.
1802 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1803 protected rather than private, as suggested by the gwt-test-utils
1805 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1806 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1807 Test the initial visibility of the panels.
1809 However, this is not a very useful test.
1810 And I wonder how we should generally test using this idea for an
1811 activity/places app like ours where the real changes happen implicitly
1812 based on the history token/URL.
1814 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1816 Slight modification to *Mapper comments.
1818 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1819 (DataActivityMapper)
1820 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1822 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1824 Remove comments mentioning GIN because they are just copied from
1825 the example code and are apparently not helpful:
1826 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1827 Also change the mention of a class that is only in the example code.
1829 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1831 GwtTestOnlineGlom test: Minor changes.
1833 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1834 Avoid the long qualified class name and modify the comment
1835 because it is now obvious to me that the mocked class is the only
1836 custom one created via GWT.create().
1838 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1840 Tests: Added the beginnings of a test using gwt-test-utils.
1842 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1843 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1844 which tells gwt-test-utils what class will be tested.
1845 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1846 Add a simple (but empty) test case. One class, used by the OnlineGlom
1847 class, is mocked so that it can be created. However, I am not sure
1848 why only this class needs to be mocked.
1850 Note that mockito seems more popular, and clearer, than easymock,
1851 but I have not got that working yet. It might be a matter of the
1854 This test is run during mvn integration-test.
1856 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1858 Tests: Use junit4-style syntax instead of junit3-style.
1860 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1861 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1862 * src/test/java/org/glom/web/shared/DataItemTest.java:
1863 Use the @Test annotation rather than relying on the test*() prefix.
1864 Also no longer implement TestCase, to avoid triggering support for
1865 the junit3-way, which stops the annotations from working.
1866 Change the imports from import junit.framework.* to
1867 import org.junit.*, which is apparently the new way.
1869 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1871 Added a test for ListPlace token parsing and creation.
1873 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1874 This is much the same as DetailsPlaceTest.
1876 I wonder how we could test the other parts of the *Place API.
1878 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1880 DetailsPlace test: Also test getToken() and recreation via getPlace().
1882 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1883 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1884 recreate it, testing the recreated DetailsPlace for the same parameter
1887 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1889 Use the surefire-report plugin.
1891 * pom.xml: This generates a HTML report about the tests in
1892 target/site/surefire-report.html
1893 when you do mvn surefire-report:report. It seems to be popular/normal.
1895 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1897 Added a test for DetailsPlace.
1899 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1900 Test the getPlace() token parsing.
1902 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1904 Added a first unit test.
1906 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1907 * src/test/java/org/glom/web/shared/DataItemTest.java:
1908 This is a silly test but it is just to get things started. Note that
1909 maven/junit finds the test because it looks in src/test by default.
1911 2011-12-22 Ben Konrath <ben@bagu.org>
1913 Change charsetName to "UTF-8" when replacing line breaks.
1915 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1916 that work in Java (such as "UTF8") will not work when compiled to
1919 This fixes a problem with multi-line details view fields that have hard
1920 line breaks. The "License Text" field on this page demonstrates the
1923 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1925 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1927 2011-12-22 Ben Konrath <ben@bagu.org>
1929 Fix another bug with related list navigation.
1931 I've tested all the navigation buttons in all of the related lists
1932 so things should be good now.
1934 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1936 2011-12-22 Ben Konrath <ben@bagu.org>
1938 Fix a crasher when refreshing the list view with the default table.
1940 This crash will also happen when loading the list view with the default
1941 table from a link or bookmark.
1943 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1944 to the main document selection page when the document id hasn't been
1946 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1947 the main document selection page when the document id hasn't been
1949 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1950 values for the details place when the document id hasn't been set.
1951 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1952 values for the list place when the document id hasn't been set.
1954 2011-12-21 Ben Konrath <ben@bagu.org>
1956 Protect against NPE when glom.document.locale is not in config.
1958 This patch protects against an NPE when glom.document.locale is not in
1959 the config file. This NPE will also happen if glom.document.locale is
1962 The patch also updates the error message to display the class name when
1963 the getMessage() returns null. This was happening when the NPE was
1964 thrown and I had "Configuration Error: null". If an NPE is encountered
1965 with this patch, "Configuration Error: NullPointerException " will be
1968 This commit closes this bug:
1970 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1972 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1974 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1976 Rename onlineglom.properties to onlineglom.properties.sample.
1978 * src/main/resources/onlineglom.properties: Rename to:
1979 * src/main/resources/onlineglom.properties.sample:
1980 * src/main/resources/README: And add this file explaining that people
1981 should rename it back when deploying.
1983 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1985 Allow choosing the translation in the .properties file.
1987 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1988 init(): Read a glom.document.locale value from the configuration file
1989 and call Glom's TransatableItem::set_current_locale() method.
1990 * src/main/resources/onlineglom.properties: Add a commented-out
1991 example of this new setting.
1993 It would be better to add &lang=de_DE to the URL, but the current
1994 libglom API does not allow us to do this easily. I am working on that.
1996 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1998 Avoid a crash in parsing of token parameters.
2000 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2001 ava: getTokenParams(): Do not crash if a parameter has a key but no
2002 value, and ignore parameters with neither.
2004 2011-12-17 Murray Cumming <murrayc@murayc.com>
2006 History token building/handling: Improve use of token parameters.
2008 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2009 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2010 and buildParamsToken(HashMap), for use by derived classes.
2011 Make the separator private because it is no longer be needed.
2012 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2013 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2014 instead of manual string concatenation.
2015 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2016 of hardcoded indices and awkward splitting code.
2017 * src/main/java/org/glom/web/client/place/ListPlace.java
2018 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2019 instead of manual string concatenation.
2020 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2021 of hardcoded indices and awkward splitting code.
2022 This should fix bug #666420
2024 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2026 Fix a Navgiation->Navigation typo in the code.
2028 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2029 Rename processNavgiation() to processNavigation().
2031 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2033 Fix a seperator->separator typo in the code.
2035 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2036 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2037 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2040 2011-12-15 Ben Konrath <ben@bagu.org>
2042 Cleanup some comments.
2044 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2046 2011-12-14 Ben Konrath <ben@bagu.org>
2048 Replace \n with <br/> for multiline text in the details view.
2050 Vertical scrollbars are added when needed as well.
2052 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2054 2011-12-14 Ben Konrath <ben@bagu.org>
2056 Specify the font for document selection links.
2058 * src/main/webapp/style.css:
2060 2011-12-14 Ben Konrath <ben@bagu.org>
2062 Fix bouncy CellTable while paging.
2064 This doesn't currently work with related list tables in unselected
2067 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2069 2011-12-14 Ben Konrath <ben@bagu.org>
2071 Revamp the appearance of the document selection page.
2073 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2074 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2075 * src/main/webapp/style.css:
2077 2011-12-13 Ben Konrath <ben@bagu.org>
2079 Set navigation button column to the smallest size possible.
2081 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2083 2011-12-13 Ben Konrath <ben@bagu.org>
2085 Change OpenButton nomenclature to NavigationButton.
2087 Using NavigtionButton makes things more generic. Classes, methods and
2088 variables have been changed.
2090 This is a rename-only refactor.
2092 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2093 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2094 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2095 Renamed from OpenButtonCell.
2096 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2097 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2098 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2100 2011-12-12 Ben Konrath <ben@bagu.org>
2102 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2104 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2105 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2106 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2107 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2109 2011-12-12 Ben Konrath <ben@bagu.org>
2111 Update variable names and comments.
2113 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2114 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2116 2011-12-12 Ben Konrath <ben@bagu.org>
2118 Properly initialize numNonEmptyRows variable to zero.
2120 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2121 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2123 2011-12-05 Ben Konrath <ben@bagu.org>
2125 Add latest mockup with HTML tables.
2127 Features of this mockup:
2129 -> HTML table for flowtable
2130 -> HTML table for flowtable column
2131 -> Example of how related lists would look
2132 -> Not using text entries for data items
2134 The current version of Online Glom doesn't use HTML tables for the
2137 This mockup has been sent to the glom-devel mailing list but it's good
2138 to have it here as well.
2140 * mockups/details-view-html-tables.html:
2142 2011-12-05 Ben Konrath <ben@bagu.org>
2144 Remove unnecessary getPrimaryKeyField() method.
2146 getPrimaryKeyFieldForTable(String) has been renamed to
2147 getPrimaryKeyField(String).
2149 * src/main/java/org/glom/web/server/database/DBAccess.java:
2150 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2151 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2153 2011-12-05 Ben Konrath <ben@bagu.org>
2155 Add string representation of TypedDataItem value to conversion error message.
2157 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2158 message was extracted into its own method to avoid duplication.
2160 2011-12-05 Ben Konrath <ben@bagu.org>
2162 Add type checking to navigation primary key value creation.
2164 Create navigation primary key only if the expected type from the Glom
2165 document matches the type returned by the SQL query.
2167 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2169 2011-12-05 Ben Konrath <ben@bagu.org>
2171 Rename a couple of variables in RelatedListNavigation.
2173 This is a rename-only refactor.
2175 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2177 2011-12-05 Ben Konrath <ben@bagu.org>
2179 Move getListLayoutGroup() into getListViewLayoutGroup().
2181 This removes getListLayoutGroup(). It was only being called by
2182 getListViewLayoutGroup().
2184 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2186 2011-12-05 Ben Konrath <ben@bagu.org>
2188 Remove check for LayoutItem_Portal in list table method.
2190 This check is no longer necessary because the method isn't being used
2191 to create the LayoutItemPortal DTO.
2193 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2195 2011-12-05 Ben Konrath <ben@bagu.org>
2197 Properly support related list navigation.
2199 Navigation from the "Repository Analyzer -> Package Scans ->
2200 Dependencies" related table wasn't working because the primary key for
2201 related tables wasn't being set properly. This commit fixes the
2204 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2205 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2206 doesn't set the primary key properly for related list tables.
2207 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2208 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2209 useful for getting the primary key for list view tables and for related
2211 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2212 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2213 Move code to set the primary key for the table from the abstract
2214 ListDBAccess class to ListViewDBAccess as it's only correct for list
2216 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2217 Properly add primary key to related list tables.
2219 2011-12-02 Ben Konrath <ben@bagu.org>
2221 Properly set the horizontal alignment of fields.
2223 This fix is for both the list tables and the details view.
2225 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2226 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2227 to set the horizontal alignment of fields.
2229 2011-12-02 Ben Konrath <ben@bagu.org>
2231 Display currency codes in the details view.
2233 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2235 2011-12-02 Ben Konrath <ben@bagu.org>
2237 Avoid duplicate JNI call.
2239 JNI is not as efficient as pure Java and this is an easy (and small)
2242 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2243 Use previously retrieved value for whereClauseToTableName instead of
2246 2011-12-02 Ben Konrath <ben@bagu.org>
2248 Rename a couple of variables in RelatedListNavigation.
2250 This is a rename-only refactor.
2252 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2254 2011-12-02 Ben Konrath <ben@bagu.org>
2256 Indicate clearly that a mismatched primary key type is a bug.
2258 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2259 warning to error. Add 'This is a bug.' to message.
2261 2011-12-02 Ben Konrath <ben@bagu.org>
2263 Update / fix some comments.
2265 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2267 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2269 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2270 Fix comments. Add some TODOs.
2272 2011-12-02 Ben Konrath <ben@bagu.org>
2274 Enable navigation to details view with string primary key from related list.
2276 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2277 Create a text primary key value when return type of result is
2278 java.sql.Types.VARCHAR.
2280 2011-12-02 Ben Konrath <ben@bagu.org>
2282 Use checkboxes for booleans in the details view.
2284 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2286 2011-12-01 Ben Konrath <ben@bagu.org>
2288 Improve performance of related list height calculation.
2290 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2291 Put code to calculate the expected height in a static initializer so
2292 that that it's only called once.
2294 2011-12-01 Ben Konrath <ben@bagu.org>
2296 Show related list tables in notebooks (again).
2298 Calculate the height of the related list tables so the Notebook can be
2299 set the correct height. The height of the related list table is also needed by
2300 FlowTable to be able decide how to create the layout.
2302 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2303 and set the Portal height based on the height of the related list
2304 table and the Portal container.
2305 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2306 Add method to calculate the height of the related list tables.
2307 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2308 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2309 calculate the height of the Pager widget.
2311 2011-12-01 Ben Konrath <ben@bagu.org>
2313 Use CellTable API for table property instead of setting style on Element.
2315 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2317 2011-12-01 Ben Konrath <ben@bagu.org>
2319 Make ListViewTable and RelatedListTable a consistent height.
2321 The tables are now a consistent height regardless of the contents of
2322 the table. A hidden button is added to empty rows to ensure that the
2323 height of these rows will match the height of rows with data.
2325 A navigation button column is now added to every table. The width of
2326 the navigation column is set to 0px when a RelatedListTable shouldn't
2327 have navigation buttons. This maintains the a consistent row height in
2328 tables that don't show the navigation buttons.
2330 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2331 navigation column when not needed.
2332 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2333 arguments for navigation button to constructor of ListViewTable.
2334 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2335 hidden button for empty data rows.
2336 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2337 arguments for navigation button to constructor.
2338 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2339 create navigation buttons. Add hideNavigationButtons() method.
2340 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2341 arguments for navigation button to constructor.
2343 2011-12-01 Ben Konrath <ben@bagu.org>
2345 Use 'visibility: hidden' in Utils.getWidgetHeight().
2347 This is better choice because hidden elements are invisible, don't
2348 respond to events and are not part of the tab order. They will,
2349 however, take up space which is required to be able to calculate the
2350 height of the widget.
2352 * src/main/java/org/glom/web/client/Utils.java:
2354 2011-12-01 Ben Konrath <ben@bagu.org>
2356 Use Utils.getWidgetHeight() in FlowTable.
2358 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2360 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2362 2011-12-01 Ben Konrath <ben@bagu.org>
2364 Put the details css class name on the correct table column.
2366 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2368 2011-11-30 Ben Konrath <ben@bagu.org>
2370 Update for java-libglom API change.
2372 The getters and setters on FieldFormatting and NumericFormat were
2373 changed to remove the 'M'.
2375 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2377 2011-11-29 Ben Konrath <ben@bagu.org>
2379 Only allow RelatedListTables in Portals.
2381 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2383 2011-11-29 Ben Konrath <ben@bagu.org>
2385 Only create a contents panel for Portals when title is being set.
2387 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2389 2011-11-29 Ben Konrath <ben@bagu.org>
2391 Set TabLayoutPanel height based on calculated height its widgets.
2393 This is a potential fix for this bug:
2395 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2397 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2399 2011-11-29 Ben Konrath <ben@bagu.org>
2401 Align details field labels and data with the Open buttons.
2403 * src/main/webapp/style.css:
2405 2011-11-29 Ben Konrath <ben@bagu.org>
2407 Remove unnecessary <div> in the Notebook widget.
2409 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2410 method to get container FlowPanel (<div>).
2411 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2412 initWidget() method directly on the TabLayoutPanel widget instead of
2413 Group's container widget.
2415 2011-11-29 Ben Konrath <ben@bagu.org>
2417 Don't add group titles for Portals in Notebooks.
2419 This reverts the previous patch and fixes a bug I introduced with
2420 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2422 * src/main/java/org/glom/web/client/ui/details/Group.java:
2423 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2425 2011-11-28 Ben Konrath <ben@bagu.org>
2427 Remove unused boolean argument in Portal constructor.
2429 Just a code cleanup.
2431 * src/main/java/org/glom/web/client/ui/details/Group.java:
2432 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2434 2011-11-28 Ben Konrath <ben@bagu.org>
2436 Remove hack for glom 1.18 style glom files.
2438 * src/main/java/org/glom/web/client/ui/details/Group.java:
2439 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2440 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2442 2011-11-28 Ben Konrath <ben@bagu.org>
2444 Use Gda Value version of primary key to log result too large error.
2446 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2448 2011-11-28 Ben Konrath <ben@bagu.org>
2450 Don't use TypedDataItem.getText() for Unknown types from the URL.
2452 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2453 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2454 instead of getText().
2455 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2456 String field and getUnknown() method.
2458 2011-11-28 Ben Konrath <ben@bagu.org>
2460 Log an error message when the java-libglom .so is not present.
2462 The error message was being set in the exception but not logged.
2464 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2466 2011-11-28 Ben Konrath <ben@bagu.org>
2468 Ignore LayoutItem_CalendarPortals.
2470 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2471 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2473 2011-11-28 Ben Konrath <ben@bagu.org>
2475 Extract method for creating the LayoutItemPortal DTO.
2477 Just breaking the code up into smaller chunks.
2479 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2481 2011-11-28 Ben Konrath <ben@bagu.org>
2485 This should have been added with the refactor. Oops!
2487 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2489 2011-11-28 Ben Konrath <ben@bagu.org>
2491 Create primary key value from URL string using type from Glom document.
2493 See this bug, comments 19 - 25:
2495 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2497 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2498 create a TypeDataItem for the primary key here when loading from a
2499 URL. Show the same string for the primary key value as was received
2500 from the URL string (when loading from a URL).
2501 * src/main/java/org/glom/web/server/Utils.java: Update method for
2502 creating the Gda Value from the TypeDataItem to properly deal with
2503 creating a Gda Value based on the Glom document type for the primary
2504 key value string when loading from a URL.
2505 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2506 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2507 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2508 Update for changed method name.
2510 2011-11-27 Ben Konrath <ben@bagu.org>
2512 Rename PrimaryKeyItem to TypedDataItem.
2514 The name PrimaryKeyItem suggests what the class should be used for.
2515 TypedDataItem is a neutral name that describes the class better.
2517 This is a rename-only refactor.
2519 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2520 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2521 * src/main/java/org/glom/web/client/Utils.java:
2522 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2523 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2524 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2525 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2526 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2527 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2528 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2529 * src/main/java/org/glom/web/server/Utils.java:
2530 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2531 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2532 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2533 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2535 2011-11-25 Ben Konrath <ben@bagu.org>
2537 Improve Gda Value conversion from PrimaryKeyItem.
2539 The value from the PrimaryKeyItem is only used if its type match the
2540 type from the glom document.
2542 * src/main/java/org/glom/web/server/Utils.java:
2544 2011-11-25 Ben Konrath <ben@bagu.org>
2546 Manually check if the java-liblgom .so is visible to the JVM.
2548 It seems that Tomcat has problems when a static initializer throws an
2549 exception. This check is done before the first method call into
2550 java-libglom so that execution doesn't continue if the .so is not
2553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2555 2011-11-25 Ben Konrath <ben@bagu.org>
2557 Improve browser configuration error messages.
2561 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2563 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2564 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2565 getConfigurationErrorMessage() method.
2566 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2567 Get and display a specific configuration error message when no Glom
2568 documents are found.
2569 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2570 Implement getConfigurationErrorMessage() method. Surround configuration
2571 code in the init() method with a try/catch block. This allows the
2572 errors to be caught while keeping the servlet available to retrieve the
2573 configuration error message.
2575 2011-11-25 Ben Konrath <ben@bagu.org>
2577 Don't use Strings to hold primary key values.
2579 The primary key values are now held in a new data object
2580 (PrimaryKeyItem) that holds type information and the primary key value
2581 using the correct type.
2583 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2584 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2585 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2586 PrimaryKeyItem instead of String to hold the primary key value.
2587 * src/main/java/org/glom/web/client/Utils.java: Remove
2588 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2589 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2590 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2591 PrimaryKeyItem instead of String to hold the primary key value. Load
2592 document selection page when the documentID has not been set correctly.
2593 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2594 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2596 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2597 Return empty string for URL instead of "null".
2598 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2599 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2600 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2601 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2602 PrimaryKeyItem instead of String to hold primary key values.
2603 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2604 PrimaryKeyValue to a Gda Value.
2605 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2606 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2607 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2608 Replace temporary database access code that uses the PrimaryKeyValue to
2609 Gda Value conversion.
2610 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2611 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2612 PrimaryKeyItem instead of String.
2613 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2614 hold primary key values.
2616 2011-11-24 Ben Konrath <ben@bagu.org>
2618 Use newly added java-libglom API to create queries.
2620 This isn't finished. I still need to stop using Strings for primary key
2621 values in the client code.
2623 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2624 libglom to use fake connections so that retrieving the query string will
2626 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2627 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2628 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2629 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2630 Use the newly added libglom sql methods and classes to create the
2631 query. Add temporary hack to convert primary value strings to Gda
2634 2011-11-23 Ben Konrath <ben@bagu.org>
2636 Don't explicitly set the height of Portals.
2638 See comments 6 - 10 of this bug for details:
2640 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2642 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2644 2011-11-23 Ben Konrath <ben@bagu.org>
2646 Use an HTML table instead of CSS for the FlowTable layout.
2648 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2649 GWT's FlexTable to implement the FlowTable.
2650 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2652 2011-11-18 Ben Konrath <ben@bagu.org>
2654 Add boolean example to HTML table mockup.
2656 * mockups/details-view-html-tables-text-entries.html:
2658 2011-11-17 Ben Konrath <ben@bagu.org>
2660 Ensure the pager buttons are always visible for related lists.
2662 To accomplish this, I've turned off text wrapping in the list view and
2663 related list tables for both the header and data text. The related list
2664 table now has a fixed layout so the it doesn't overflow its container.
2665 This is required to ensure that the cell text is clipped when it
2666 overflows the cell and an ellipsis is added to the right side of the
2667 cell when text is clipped.
2669 A fixed table layout for the related list table in the details view
2670 seems what we want for the details view anyway, so the side-effect is
2673 The ellipsis will only be displayed in Firefox >= 7.
2677 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2679 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2680 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2681 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2683 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2684 Set the 'table-layout: fixed' CSS property to the related list table.
2685 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2686 'white-space: nowrap;' CSS property on both the list view and the
2687 related list tables.
2689 2011-11-16 Ben Konrath <ben@bagu.org>
2691 Rework the fix for empty notebook tab labels.
2693 Setting the empty group titles with its name caused problems for the
2694 details layout. Instead of using libglom's
2695 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2696 to the client when the title is empty. This allows the Notebook to use
2697 the name when the title is empty without affecting anything else.
2699 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2700 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2702 2011-11-16 Ben Konrath <ben@bagu.org>
2704 Set group titles with name when title is empty.
2706 This fixes a problem with an empty notebook tab label in the Lesson
2707 Planner document. The forth tab in the notebook should be "Internet":
2709 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2711 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2712 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2715 2011-11-16 Ben Konrath <ben@bagu.org>
2717 Remove whitespace from the configured username properties.
2719 This assumes that usernames won't have whitespace at the beginning
2720 or end. But I think this is a reasonable assumption.
2722 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2723 String.trim() to remove the whitespace from the username properties.
2725 2011-11-15 Ben Konrath <ben@bagu.org>
2727 Add details view mockup with HTML tables and text entries.
2729 This is from the attachment on this bug:
2731 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2733 * mockups/details-view-html-tables-text-entries.html:
2735 2011-11-15 Ben Konrath <ben@bagu.org>
2737 Add space between the columns of the flow table.
2741 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2743 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2744 space between columns in the flow table.
2746 2011-11-15 Ben Konrath <ben@bagu.org>
2748 Add backup files to the .gitignore.
2750 * .gitignore: Ignore files that end with ~.
2752 2011-11-09 Ben Konrath <ben@bagu.org>
2754 Use latest release of gwt-log.
2756 Gwt-log releases are now being submitted to the maven central
2757 repository so manual installation of the jar is no longer required.
2759 * pom.xml: Update version and groupId of gwt-log dependency.
2761 2011-10-31 Ben Konrath <ben@bagu.org>
2763 Don't use GWT numeric formatting to override the glom currency formatting.
2765 Currencies are now displayed like they are in Glom. See this bug:
2767 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2769 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2771 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2772 currency code to constructor and set it when the cell is rendered.
2773 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2774 currency code to the constructor of the NumericCell.
2776 2011-10-27 Ben Konrath <ben@bagu.org>
2778 Require the latest release of java-libglom (1.17.4).
2782 2011-10-26 Ben Konrath <ben@bagu.org>
2784 Add style to Notebook that matches current theme.
2786 It's not the best style in the world but it's better than the default.
2788 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2789 padding at the bottom of the child widgets.
2790 * src/main/webapp/style.css: Add style for the Notebook.
2792 2011-10-26 Ben Konrath <ben@bagu.org>
2794 Move servlet initialization code to overridden init method.
2796 This is half of the solution to getting proper error messages
2797 displayed when configuration errors occur. Here's the relevant bug:
2799 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2801 The rest of the solution involves surrounding the init method with a
2802 try/catch block and setting a global variable with the error /
2803 exception. A new async method should be created to retrieve and display
2804 the error message / exception.
2806 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2807 code from constructor to init method adding exceptions as needed.
2809 2011-10-26 Ben Konrath <ben@bagu.org>
2811 Add script to monitor and restart tomcat if required.
2813 * utils/check-and-recover-tomcat.py: New file.
2815 2011-10-26 Ben Konrath <ben@bagu.org>
2817 Display the correct number of data items in the pager.
2821 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2823 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2824 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2825 The implementation is the same for both tables: Keep track of the
2826 number of non-empty rows and fire and RowCountChangeEvent after the data has
2828 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2829 custom Pager class that subclasses SimplePager to handle displaying
2830 the correct number when empty rows have been added.
2832 2011-10-26 Ben Konrath <ben@bagu.org>
2834 Correct error in previous commit.
2836 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2837 eventBus parameter from listView.setCellTable().
2839 2011-10-26 Ben Konrath <ben@bagu.org>
2841 Fix error in TODO comment.
2843 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2845 2011-10-24 Ben Konrath <ben@bagu.org>
2847 Create Notebook widgets to the details view.
2849 This isn't finished just yet - I still need to create a reasonable
2850 style to match the current theme.
2852 * src/main/java/org/glom/web/client/Utils.java: Add method for
2853 calculating the height of a widget. This is used in the Notebook class.
2854 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2855 new constructor method in Group.
2856 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2857 method for creating child widget that can be used by subclasses
2858 like Notebook. New constructor that allows disabling the group
2859 titles - Notebooks don't set a group title for their child groups.
2860 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2861 to make Notebooks using GWT's TabLayoutPanel.
2862 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2863 constructor that allows disabling the group titles.
2864 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2865 LayoutItemNotebook DTO.
2866 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2867 DTO for Notebooks. It's just an empty class for now but we might need
2868 it to transfer some specific information in the future.
2870 2011-10-21 Ben Konrath <ben@bagu.org>
2872 Add navigation buttons to related list tables.
2874 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2875 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2876 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2877 method getSuitableRecordToViewDetails() for getting the table name
2878 and primary key value for related list navigation buttons.
2879 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2880 private cell renderer class to get the navigation information for
2881 related list tables from the server. Extract the navigation
2882 processing code from the details cell navigation and use it for the
2883 related list navigation as well.
2884 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2885 cell renderer class for the details open buttons. This was needed
2886 because the related list navigation buttons and the list view