1 2012-04-24 Murray Cumming <murrayc@murrayc.com>
3 Use of jOOQ: Move Field creation into a utility method.
5 * src/main/java/org/glom/web/server/SqlUtils.java:
6 This lets us improve it more easily.
8 2012-04-24 Murray Cumming <murrayc@murrayc.com>
10 Use of jOOQ: Improve the code to COUNT a sub-select.
12 * src/main/java/org/glom/web/server/SqlUtils.java:
13 Move initial query creation into
14 build_sql_select_step_with_where_clause().
15 build_sql_select_count_rows(): Use the jOOQ API instead of
16 concatentating text, because a jOOQ Select*Step is a TableLike,
17 which is what from() takes.
19 2012-04-23 Murray Cumming <murrayc@murrayc.com>
21 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
23 * pom.xml: Depend on jooq.
24 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
25 methods with jOOQ, based on the C++ implementations in libglom,
26 with some changes to the logic required by jooQ.
27 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
29 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
30 * src/main/java/org/glom/web/server/ReportGenerator.java:
31 * src/main/java/org/glom/web/server/SqlUtils.java:
32 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
33 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
34 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
35 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
36 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
37 Adapt. In particular, the SqlUtils methods now need to take a Connection,
38 because jOOQ needs that, though it seems unnecessary.
40 This is not quite finished. Ideally jOOQ would help us to build
41 table_name.field_name names, quoting and escaping them properly.
42 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
44 2012-04-21 Murray Cumming <murrayc@murrayc.com>
46 Move use of Glom.build_sql*() into a new SqlUtils class.
48 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
49 to wrap Glom.build_sql*(). The parameter types are still Glom one,
50 but this will make it easier to start using something other than
51 libglom or SqlBuilder.
53 2012-04-21 Murray Cumming <murrayc@murrayc.com>
55 Update the project URL.
57 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
59 2012-04-21 Murray Cumming <murrayc@murrayc.com>
61 Main layout: Use a FlowTable instead of absolute positioning.
63 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
64 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
65 child panels/widgets must have an absolute position. But that is annoying, so
66 this adds a FlowTable and puts the child panels in there.
68 2012-04-21 Murray Cumming <murrayc@murrayc.com>
70 GwtTestOnlineGlom: Comment out unused code.
72 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
73 Eclipse has started to say that some code is unused.
75 2012-04-21 Murray Cumming <murrayc@murrayc.com>
77 Update to the latest versions of dependencies.
79 * pom.xml: Update version numbers of dependencies to the latest
81 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
82 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
83 * src/main/java/org/glom/web/server/ReportGenerator.java:
84 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
85 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
86 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
88 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
89 Modify the imports where necessary.
91 2012-04-17 Murray Cumming <murrayc@murrayc.com>
93 Style: Remove overflow:hidden from searchbox
95 * src/main/webapp/style.css: Because this pushes the Back To Link
96 label/link on to the next row, which is then hidden due to the
97 hard-coded (in ems) height.
99 2012-04-20 Murray Cumming <murrayc@murrayc.com>
101 Remove some duplicate code.
103 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
104 getDocumentInfo(): This must have been duplicated during the merge from the
109 2012-04-19 Murray Cumming <murrayc@murrayc.com>
111 Reports: Localize the waiting for report message.
113 * src/main/java/org/glom/web/client/activity/ReportActivity.java
114 start(): Get the message from the contants.
115 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
117 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
118 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
119 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
120 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
121 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
122 Update these files with the English text for newer strings for now.
124 2012-04-19 Murray Cumming <murrayc@murrayc.com>
126 Reports: Show a message while waiting for the report.
128 * src/main/java/org/glom/web/client/ui/ReportView.java
129 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
130 Add setWaitingText(), to show a message saying that we are
131 waiting for the report to be ready.
132 * src/main/java/org/glom/web/client/activity/ReportActivity.java
133 start(): Call setWaitingText() before calling the async
136 2012-04-19 Murray Cumming <murrayc@murrayc.com>
138 ReportGenerator: Specify date and time formats.
140 * src/main/java/org/glom/web/server/ReportGenerator.java:
141 createFieldValueElement(): Use the default (and localized)
142 short formats, though we still need a way to show 4-digit
143 years without providing the format for every locale.
144 * src/main/java/org/glom/web/server/database/DBAccess.java:
145 convertResultSetToDTO(): Use the short formats here too.
147 2012-04-18 Murray Cumming <murrayc@murrayc.com>
149 ReportGenerator: Use the correct numeric formatting.
151 * src/main/java/org/glom/web/server/ReportGenerator.java
152 createFieldExpression(), createFieldValueElement(): Take the
153 whole LayoutItem_Field instead of just the field name, so
154 we have access to the formatting.
155 createFieldValueElement(): Use JRTextField.setPattern() to
156 specify the numeric formatting, with the help of a
157 regular DecimalFormat.
159 2012-04-18 Murray Cumming <murrayc@murrayc.com>
161 ReportGenerator: Avoid showing null for group by titles.
163 * src/main/java/org/glom/web/server/ReportGenerator.java
164 generateReport(): Use setBlankWhenNull() on the field title
165 style too, because this is used for values in group by
168 2012-04-18 Murray Cumming <murrayc@murrayc.com>
170 ReportGenerator: Add a colon to titles in vertical groups.
172 * src/main/java/org/glom/web/server/ReportGenerator.java
173 addFieldToDetailBandVertical(): Pass true for the withColon
176 2012-04-18 Murray Cumming <murrayc@murrayc.com>
178 ReportGenerator: Simplify the code by using Position more.
180 2012-04-18 Murray Cumming <murrayc@murrayc.com>
182 Reports: Support vertical groups, roughly.
184 * src/main/java/org/glom/web/server/ReportGenerator.java:
185 addToReport(): Rename to addGroupToReport() and, if necessary,
186 call the new addVerticalGroupToReport() method.
187 createFieldValueElement(): Let the caller specify the Y position
190 2012-04-17 Murray Cumming <murrayc@murrayc.com>
192 Reports: Allow a second report to be shown.
194 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
195 clear(): Do not remove the HTML widget, which broke the whole layout.
197 2012-04-17 Murray Cumming <murrayc@murrayc.com>
199 Locales drop-down: Show that we use English by default.
201 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
202 fillView(): When we use English, just because that is the default, when
203 no locale is specified, show that in the Locales drop-down instead of
204 just showing the first item.
206 2012-04-17 Murray Cumming <murrayc@murrayc.com>
208 Unselect the Report/Locale/Table combo item when appropriate.
210 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
211 setPlace(): clear reportName if this is not a ReportPlace.
212 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
213 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
214 When the provided name is empty, unselect all items, so that none are
215 indicated. This uses a for loop because I cannot find a single method
218 2012-04-17 Murray Cumming <murrayc@murrayc.com>
220 Report: Give the user a way to get back to the list.
222 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
223 start(), setPlace(): Show the Back To List link on reports, and also
224 interpret selecting the empty report item as back to list.
226 2012-04-13 Murray Cumming <murrayc@murrayc.com>
228 Really show the selected Report name.
230 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
231 setPlace(): Store the reportName here, if it is that kind of Place.
232 fillView(): Set the selected Report after filling the list of reports.
233 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
234 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
235 null Strings, though we need some way to unselect all ListBox items
238 2012-04-13 Murray Cumming <murrayc@murrayc.com>
240 ReportGenerator: Try to avoid some problems.
242 * src/main/java/org/glom/web/server/ReportGenerator.java
243 addField(): Try to avoid duplicates, and avoid using a null
246 2012-04-13 Murray Cumming <murrayc@murrayc.com>
248 Reports: Use quickFind.
250 * src/main/java/org/glom/web/client/OnlineGlomService.java;
251 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
252 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
253 getReportHTML(): Add a quickFind parameter.
254 * src/main/java/org/glom/web/client/activity/ReportActivity.java
255 start(): Pass the quickFind parameter.
256 * src/main/java/org/glom/web/server/ReportGenerator.java
257 generateReport(): Take a quickFind parameter.
259 2012-04-13 Murray Cumming <murrayc@murrayc.com>
261 ReportPlace: Actually use the report name.
263 * src/main/java/org/glom/web/client/place/ReportPlace.java
264 getPlace(): Do not assign the report name to the quickfind.
266 2012-04-13 Murray Cumming <murrayc@murrayc.com>
268 Show java.library.path when complaining.
270 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
271 init(): When telling us to check java.library.path, show the
274 2012-03-06 Murray Cumming <murrayc@murrayc.com>
276 ReportGenerator: Do not show nulls.
278 2012-03-06 Murray Cumming <murrayc@murrayc.com>
280 ReportGenerator: Make the title font larger.
282 2012-03-06 Murray Cumming <murrayc@murrayc.com>
284 ReportGenerator: Put field titles inside groups, if there are groups.
286 2012-03-06 Murray Cumming <murrayc@murrayc.com>
288 ReportGenerator: Take the Report itself instead of the name and group.
290 * src/main/java/org/glom/web/server/ConfiguredDocument.java
291 Remove getReportLayoutGroup().
292 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
293 getReportHTML(): Pass the report instead
294 of its name and layout group.
295 * src/main/java/org/glom/web/server/ReportGenerator.java
296 generateReport(): Use the report object to use the title
299 2012-03-06 Murray Cumming <murrayc@murrayc.com>
301 ReportGenerator: Remove designBand parameters.
303 * src/main/java/org/glom/web/server/ReportGenerator.java:
304 Make designBand a class member instead of passing it to all
307 2012-03-06 Murray Cumming <murrayc@murrayc.com>
309 ReportGenerator: Add lines, a bit like in the desktop version.
311 * src/main/java/org/glom/web/server/ReportGenerator.java
312 addToReport(): Use JRDesignLine.
314 2012-03-06 Murray Cumming <murrayc@murrayc.com>
316 ReportGenerator: Correct the title positions and use some bold style.
318 * src/main/java/org/glom/web/server/ReportGenerator.java:
319 Break the code up into reusable functions, correct the placement of
320 titles, and use normal/bold styles as in the reports in the desktop
323 2012-03-06 Murray Cumming <murrayc@murrayc.com>
325 ReportGenerator: Add a header band to show the field titles.
327 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
328 getReportHTML(): Pass the localeId to the ReportGenerator
330 * src/main/java/org/glom/web/server/ReportGenerator.java
331 constructor: Take the localeID so we can get translated field
333 generateReport(), addToReport(), addFieldToBand(): Add field
334 titles in a column header band.
336 2012-03-05 Murray Cumming <murrayc@murrayc.com>
338 Reports drop-down list: Some improvement.
340 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
341 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
342 Adedd setSelectedReport(),
343 setReportList(): Add a blank line so that the user can select the
345 * src/main/java/org/glom/web/client/activity/ReportActivity.java
346 start(): Show the current report by calling setSelectedReport().
347 This does not seem to work yet.
349 2012-03-05 Murray Cumming <murrayc@murrayc.com>
351 DetailsActivity, ListActivity: Move some variables into a base class.
353 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
354 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
355 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
356 the clientFactory, documentID, tableName and authenticationPopup into
357 a base class, to avoid duplication.
359 2012-03-05 Murray Cumming <murrayc@murrayc.com>
361 Translate the Reports label.
363 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
364 Get the "Reports" label string from the constants.
365 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
366 perties: Add Reports to the constants.
368 2012-03-05 Murray Cumming <murrayc@murrayc.com>
370 Reports: Implement grouping.
372 * src/main/java/org/glom/web/server/ReportGenerator.java:
373 Handle LayoutItem_GroupBy items and try to do the right thing
374 with JRDesignGroup. It seems to work.
376 2012-03-04 Murray Cumming <murrayc@murrayc.com>
378 Actually show some data with JasperReports.
380 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
381 getReportHTML(): Move most code into a ReportGenerator class.
382 * src/main/java/org/glom/web/server/ReportGenerator.java:
383 Recurse into sub-groups, adding fields to the JasperDesign's details
384 band. Note that we must set an arbitrary width and height, or it just
385 will not show any data.
387 2012-03-04 Murray Cumming <murrayc@murrayc.com>
389 Reports Chooser: Show the titles, not the names.
391 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
392 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
393 and the names as the values.
394 * src/main/java/org/glom/web/server/ConfiguredDocument.java
395 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
396 group now that we provide the report name, so it should always
399 2012-02-15 Murray Cumming <murrayc@murrayc.com>
401 Depend on jasperreports.
403 * pom.xml: Add the dependency. My plan is to use this on the
406 2012-01-31 Murray Cumming <murrayc@murrayc.com>
408 Implement navigation to report places.
410 * src/main/java/org/glom/web/client/activity/ReportActivity.java
411 start(): Do not bother to handle all events here.
412 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
413 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
414 Added getSelectedReport().
415 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
416 .java: start(): When handling a change to the reports chooser,
417 call getSelectedReport() and goTo() its ReportPlace.
418 * src/main/java/org/glom/web/client/ui/ReportView.java
419 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
420 Added setReportHTML() which puts the html in a gwt HTML widget.
421 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
422 getReportHTML(): Return "TODO" just to show that this works.
424 2012-01-31 Murray Cumming <murrayc@murrayc.com>
426 Make ReportPlace usable.
428 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
430 * src/main/java/org/glom/web/client/place/ReportPlace.java:
431 Correct the @prefix annotation.
433 2012-01-31 Murray Cumming <murrayc@murrayc.com>
435 OnlineGlomService: Return report HTML rather than the LayoutGroup.
437 * src/main/java/org/glom/web/client/OnlineGlomService.java:
438 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
439 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
440 Change getReportLayout() to getReportHMTL() because we will not need to
441 parse or render the report layout on the client side.
442 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
443 getReportLayout(): Return the libglom LayoutGroup type because we will
444 not need to convert to a shared type, because this will not be used on
446 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
449 Note that there is still no implementation for this.
452 2012-01-27 Murray Cumming <murrayc@murrayc.com>
454 Add a (empty) Report Place, View, and Activity.
456 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
458 * src/main/java/org/glom/web/client/place/HasTablePlace.java
459 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
460 this into a superclass:
461 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
462 and also use it as the base of this new ReportPlace:
463 * src/main/java/org/glom/web/client/place/ReportPlace.java
465 * src/main/java/org/glom/web/client/ui/ReportView.java
466 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
467 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
468 Add these, containing mostly boiler-plate for now.
470 * src/main/java/org/glom/web/client/OnlineGlomService.java
471 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
472 * src/main/java/org/glom/web/server/ConfiguredDocument.java
473 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
474 Add API to get the LayoutGroup for the report.
476 2012-01-23 Murray Cumming <murrayc@murrayc.com>
478 Add and fill a Reports drop-down list box.
480 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
482 * src/main/java/org/glom/web/client/OnlineGlomService.java:
483 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
484 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
485 Added getReports(document, table, localeID), calling
486 ConfiguredDocument.getReports().
487 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
488 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
489 Added setReportsList() and a list widget.
490 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
491 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
496 2012-04-12 Murray Cumming <murrayc@murrayc.com>
498 Translations: Add Esperanto.
500 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
501 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
502 properties: Add this translation because someone took the time to make it.
504 2012-03-15 Murray Cumming <murrayc@murrayc.com>
506 Adapt to the java-libglom 1.21.7 API.
508 * src/main/java/org/glom/web/server/ReportGenerator.java:
509 addToReport(): get_group_secondary_fields() is now
510 get_secondary_fields().
513 2012-03-15 Murray Cumming <murrayc@murrayc.com>
515 Use the latest java-libglom version.
517 * pom.xml: Use java-libglom 1.21.7.
519 2012-03-03 Ben Konrath <ben@bagu.org>
521 Display date and time in details view.
523 https://bugzilla.gnome.org/show_bug.cgi?id=671257
525 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
527 2012-03-05 Murray Cumming <murrayc@murrayc.com>
529 Require the latest java-libglom.
531 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
533 2012-03-04 Murray Cumming <murrayc@murrayc.com>
535 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
537 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
538 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
539 an empty quickfind string. I also corrected libglom to create only
540 empty where clauses for empty quickfind strings, but this avoids the
543 2012-02-24 Ben Konrath <ben@bagu.org>
545 Improve the tabs in the Notebook widget.
549 2012-01-30 Murray Cumming <murrayc@murrayc.com>
551 Translations: Try to translate the strings.
553 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
554 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
555 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
556 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
557 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
558 Take the Open translation from GTK+'s .po files.
559 Take the Details translation from Glom's po files.
560 I have added the other strings to Glom so we can get translations that way:
561 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
563 2012-01-27 Murray Cumming <murrayc@murrayc.com>
565 TableSelectionViewImpl: Put the search label and entry in a div.
567 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
568 Put the search widgets in a FlowTable so that the CSS can be used to
569 style them while keeping them together.
570 * src/main/webapp/style.css: Mention the new div.
572 2012-01-27 Murray Cumming <murrayc@murrayc.com>
574 Translate more strings in more locales.
576 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
577 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
578 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
579 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
580 Translate the "Details" and "Open" string too.
582 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
583 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
584 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
585 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
586 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
587 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
588 Add these new locales as placeholders though they currently contain English.
590 2012-01-27 Murray Cumming <murrayc@murrayc.com>
592 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
594 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
595 Check the ConfiguredDocument* for null before using it.
597 2012-01-26 Murray Cumming <murrayc@murrayc.com>
599 Tell Eclipse about the generated java files.
601 * .classpath: This lets it find OnlineGlomConstants.java.
602 It would be nice if Eclipse just used the maven build files.
604 2012-01-26 Murray Cumming <murrayc@murrayc.com>
606 Prevent a crash when no locale is specified in the URL.
608 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
609 Avoid returning a null string, obtained from
610 Window.Location.getParameter(). This caused a crash when it was
611 later passed to libglom's API.
612 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
613 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
614 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
615 guard against future null strings.
617 2012-01-26 Murray Cumming <murrayc@murrayc.com>
619 Use the ?locale= query param instead of the &lang= token param.
621 * src/main/java/org/glom/web/client/place/ListPlace.java
622 * src/main/java/org/glom/web/client/place/DetailsPlace.java
623 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
624 Remove the lang token key and value.
626 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
627 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
628 When the user selects a different locale from the chooser, use
629 Window.Location.assign() to change the URL, which then causes a reload.
631 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
632 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
633 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
634 * src/main/java/org/glom/web/client/activity/ListActivity.java
635 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
636 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
637 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
638 * src/main/java/org/glom/web/client/ui/ListView.java:
639 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
641 Remove localeID member variables and method/constructor parameters, instead
642 using Utils.getCurrentLocaleID() when we need a localID to pass to
645 2012-01-26 Murray Cumming <murrayc@murrayc.com>
647 Internationalize the UI strings.
649 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
650 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
651 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
652 because it is unused. Messages are apparently strings that can have
653 parameters, but we do not need that yet, so Contants will be enough for now.
654 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
655 to say that we support the en and de locales.
656 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
657 The original English strings.
658 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
659 Some German translations of the English strings.
660 The i18n goal then uses the .properties file to generate an
661 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
662 returns an implementation that returns the translated strings.
663 The documentation suggests putting these in src/java/*/client/, but it seems
664 best to put it in src/resources/*/client/.
665 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
666 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
667 instead of hard-coding them.
668 Note that we cannot import OnlineGlomConstants because it does not exist yet,
669 but that does not seem to stop the build, though it confuses Eclipse.
671 You can see the translated string by adding ?locale=de to the URL, like so:
672 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
674 2012-01-24 Murray Cumming <murrayc@murrayc.com>
676 Improve null/empty String checks.
678 * pom.xml: Add a dependency on commons-lang, to use
679 org.apache.commons.lang.StringUtils.
680 * src/main/java/org/glom/web/server/ConfiguredDocument.java
681 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
682 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
683 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
684 Use StringUtils.isEmpty().
686 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
687 StringUtils class with a static isEmpty() function because we
688 cannot use org.apache.commons.lang.StringUtils in client-side
689 GWT code because it (apparently) cannot be compiled to javascript.
690 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
691 * src/main/java/org/glom/web/client/activity/ListActivity.java
692 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
693 * src/main/java/org/glom/web/client/place/DetailsPlace.java
694 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
695 * src/main/java/org/glom/web/client/place/ListPlace.java
696 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
697 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
698 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
699 * src/main/java/org/glom/web/client/ui/details/Group.java
700 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
701 our StringUtils.isEmpty() function.
703 2012-01-24 Murray Cumming <murrayc@murrayc.com>
705 Update to the latest java-libglom API.
707 * pom.xml: Require java-libglom 1.21.4.
708 * src/main/java/org/glom/web/server/ConfiguredDocument.java
709 getDocumentInfo(), getListViewLayoutGroup():
710 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
712 * src/main/java/org/glom/web/server/database/DBAccess.java
713 getFieldsToShowForSQLQueryAddGroup(),
714 getPrimaryKeyLayoutItemField(): Replace get_database_title()
715 with either get_database_title_original() or
716 get_database_title(localeID).
718 2012-01-24 Murray Cumming <murrayc@murrayc.com>
720 ConfiguredDocument: Avoid a null pointer exception.
722 * src/main/java/org/glom/web/server/ConfiguredDocument.java
723 Initialize localeID to "" to avoid returning a null String which
724 causes a crash in java-libglom's swing-generated code.
726 2012-01-23 Murray Cumming <murrayc@murrayc.com>
728 Some simple renaming.
730 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
731 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
732 for localeChooser. This seems more appropriate and is less ambiguous
733 particularly in the .css file.
735 2012-01-23 Murray Cumming <murrayc@murrayc.com>
737 ConfiguredDocument: Rename the localedID private member variable.
739 2012-01-23 Murray Cumming <murrayc@murrayc.com>
741 Adapt to the latest java-libglom API from git master.
743 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
744 libglom now uses only Vector instead of List, which uses add() instead of
747 2012-01-22 Murray Cumming <murrayc@murrayc.com>
749 ConfiguredDocument: Rename the localedID private member variable.
751 2012-01-20 Murray Cumming <murrayc@murrayc.com>
753 Build a source tarball with mvn assembly:single
755 * assembly.xml: Add this file.
756 * pom.xml: Use the maven-assembly-plugin and tell it to use
757 our assembly.xml file.
759 2012-01-19 Murray Cumming <murrayc@murrayc.com>
761 OnlineGlomServiceImpl: Get .glom files recursively.
763 * pom.xml: Depend on commons-io from org.apache.commons.
764 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
765 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
766 files recursively, and with the easier filter for the extension.
767 Use org.apache.commons.io.FilenameUtils.removeExtension() to
768 simplify that code too.
770 2012-01-19 Murray Cumming <murrayc@murrayc.com>
772 README: Mention that you must install java-libglom packages separately.
774 But then it works, because java-libglom is now in the central maven
777 2012-01-18 Murray Cumming <murrayc@murrayc.com>
779 locales drop-down: Show the correct selected locale when the URL changes.
781 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
782 .java: setPlace(): Move some code into fillView().
784 2012-01-18 Murray Cumming <murrayc@murrayc.com>
786 locales drop-down: Do not lose the primary key.
788 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
789 start(): onLocaleChange(): Pass the current primary key value,
790 instead of an empty value.
792 2012-01-18 Murray Cumming <murrayc@murrayc.com>
794 locales drop-down: Do not lose the drop-down selection.
796 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
797 .java (TableSelectionActivity.fillView): Set the selected locale
798 after changing the drop-down items (though we do not really need
799 to change them just because the locale changes.)
801 2012-01-18 Murray Cumming <murrayc@murrayc.com>
803 locales drop-down: Change the tables list when this changes.
805 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
806 .java: TableSelectionActivity.start(): Move the async table titles
807 retrieval into a private fillView() method and also call this when
808 the chosen locale changes.
809 Note that the document title is not actually translatable yet, but
810 that is a problem that I should fix soon in libglom.
812 2012-01-18 Murray Cumming <murrayc@murrayc.com>
814 Improve the placement of the locales drop-down.
816 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
817 Put the title and locales drop-down in a div (gwt.FlowTable).
818 * src/main/webapp/style.css: Add magic css properties to make this work.
819 Also remove the left margin from the title so that it lines up with the
822 2012-01-18 Murray Cumming <murrayc@murrayc.com>
824 locales selector: Show human-readable locale titles.
826 * src/main/java/org/glom/web/server/ConfiguredDocument.java
827 getDocumentInfo(): Use java.util.Locale to show a real title of
828 each locale, in the locale's own language.
830 2012-01-17 Murray Cumming <murrayc@murrayc.com>
832 Add a language/locale selector drop-down.
834 * src/main/java/org/glom/web/shared/DocumentInfo.java:
835 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
836 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
837 getDocumentInfo(): Store the available Locales in the DocumentInfo.
838 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
839 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
840 Add a ListBox to show the available locales. Add getLocaleSelector(),
841 setLocaleList(), getSelectedLocale(), setSelectedLocale().
842 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
843 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
844 java: Add these classes.
845 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
846 start(): Fill the locales ListBox. Handle its change event, firing a
848 setPlace(): Show the selected locale as specified by the URL token.
849 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
850 * src/main/java/org/glom/web/client/activity/ListActivity.java:
851 Handle LocaleChangeEvent, going to a new *Place with that locale.
853 The placement of the ListBox is not pretty, and it currently uses the ID
854 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
858 2012-01-17 Murray Cumming <murrayc@murrayc.com>
860 Search box: Show the search text from the URL token.
862 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
863 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
864 Add setQuickFindText().
865 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
866 .java: setPlace(): Store the queryText if the place is a ListPlace,
867 and call TableSelectionView.setQuickFindText().
869 2012-01-17 Murray Cumming <murrayc@murrayc.com>
871 Allow use of translations via, for instance, &lang=de in the URL.
873 * pom.xml: Use the unstable java-libglom 1.21 version.
875 * src/main/java/org/glom/web/client/OnlineGlomService.java:
876 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
877 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
878 init(): Instead of calling TranslatableItem.set_current_locale()
879 (now removed), call ConfiguredDocument.setDefaultLocaleID().
880 However, this is only for default locales, which are not needed to
881 change the locale in the URL.
882 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
883 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
884 getSortedRelatedListData(): Add a localeID parameter, so we can get the
885 layout for a particular locale.
886 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
887 Add get/setDefaultLocaleID().
888 getDocumentInfo(), getListViewData(), getRelatedListData(),
889 getDetailsLayoutGroup(), getListViewLayoutGroup(),
890 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
891 localeID parameter, so we can get the layout for a particular locale.
893 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
894 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
895 * src/main/java/org/glom/web/client/place/ListPlace.java:
896 Parse and construct a lang parameter too.
898 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
899 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
900 passed to subsequent methods and constructors.
901 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
902 * src/main/java/org/glom/web/client/activity/ListActivity.java:
903 Store the localeID from the *Place and pass it to other constructors
904 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
906 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
907 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
908 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
909 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
910 * src/main/java/org/glom/web/client/ui/ListView.java:
911 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
912 Take localeID parameters and pass them to subsequent constructors and
913 methods, so that the layout is always retrieved for that locale.
915 This is rather repetitive.
917 Note that "" means the original (default) locale of the Glom document,
918 which is usually English.
920 2012-01-17 Murray Cumming <murrayc@murrayc.com>
922 Documents: Remove final keyword to fix startup configuration.
924 * src/main/java/org/glom/web/shared/Documents.java: Remove the
925 final keywords on the private member variables because that breaks
926 the startup, apparently (there are warnings) because it stops them
927 from being serialized. I added these in the previous commit.
929 2012-01-13 Murray Cumming <murrayc@murrayc.com>
931 Documents: Add some final keywords.
933 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
936 2012-01-13 Murray Cumming <murrayc@murrayc.com>
938 OnlineGlomServiceImpl: Add to overview comments.
940 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
941 Note that this is where all the document are loaded. They are not
942 loaded freshly for each page.
944 2012-01-12 Murray Cumming <murrayc@murrayc.com>
948 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
949 Add a TextBox for the text of a quick find.
950 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
952 setBackLink(): Add a String quickFind parameter.
953 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
954 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
955 to the base interface, because that is how TableSelectionViewImpl is used.
956 * src/main/webapp/style.css: Add style for the search box and its label.
958 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
959 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
960 Add these files, based on the existing TableChangeEvent and
961 TableChangeEventHandlers.
962 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
963 start(): Handle QuickFindChangeEvent, passing its quickFind text to
964 a ListPlace() that the user should be taken to.
965 * src/main/java/org/glom/web/client/activity/ListActivity.java
966 start(): Handle it here too and adapt the TableChangeEvent handler to
967 pass the extra "" quickFind parameter to ListPlace.
968 * src/main/java/org/glom/web/client/place/ListPlace.java:
969 Constructor: Take an extra String quickFind parameter and store it,
970 returning it from a new getQuickFind() method.
971 getToken(): Put the quickFind text in the URL token.
972 getPlace(): Parse the quickFind text from the URL token.
973 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
974 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
975 ListPlace constructor.
976 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
977 .java: start(): Add a Change handler for the TableSelectionView's
978 TextBox (via its base HasChangeHandlers interface), firing the new
979 QuickFindChangeEvent.
980 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
981 pass the extra "" quickFind parameter.
983 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
984 setCellTable(): Add a String quickFind parameter and pass it to
985 the ListViewTable() constructor.
986 * src/main/java/org/glom/web/client/ui/ListView.java: Change
987 setCellTable() in the base interface, because that is how ListViewImpl
990 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
991 Add a String quickFind member variable.
992 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
993 Constructor: Add a String quickFind parameter, storing it in the
994 base ListTable's member variable.
995 onRangeChanged(): Pass quickFind to the
996 OnlineGlomServiceAsync.getSortedListViewData() and
997 OnlineGlomServiceAsync.getListViewData() methods.
999 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1000 getListViewData(), getSortedListViewData(): Add a String quickFind
1001 parameter, passing it to ConfiguredDocument.getListViewData().
1002 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1003 Change getListViewData(), getSortedListViewData() in the base interface,
1004 because that is how OnlineGlomServiceImpl is used, via this:
1005 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1006 Change getListViewData(), getSortedListViewData() here too.
1007 This class can apparently be used to asynchronously call methods on
1008 OnlineGlomService, and GWT seems to implement that after recognizing
1009 just the *Async name convention and the extra AsyncCallback parameters.
1011 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1012 getListViewData(): Add a String quickFind parameter, and pass it to
1013 ListViewDBAccess.getData().
1014 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1015 getListData(): Add a String quickFind parameter and pass it to
1017 getSelectQuery(): Add a String quickFind parameter.
1018 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1019 getSelectQuery(): Add a String quickFind parameter and use it with
1020 Glom.get_find_where_clause_quick() to pass a where_clause to
1021 Glom.build_sql_select_with_where_clause(), to actually filter the
1023 getData(): Add a String quickFind parameter, passing it to getListData().
1024 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1025 va: getData(): Pass an empty string to getListData() for the
1026 quickFind parameter.
1028 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1030 ListTable: Minor change.
1032 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1033 createCellTable(): Make this protected instead of public.
1035 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1037 Many files: Use final for the parameters and use the @override attribute.
1039 2012-01-22 Ben Konrath <ben@bagu.org>
1041 Add anchor links for single line text that starts with http, ftp and www.
1045 2012-01-22 Ben Konrath <ben@bagu.org>
1047 Add ellipsis to single line text in details view.
1051 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1053 Remove all javadoc author tags.
1055 Because they are awkward and meaningless when many people touch
1057 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1059 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1061 Revert the COPYING.LESSER to COPYING rename.
1063 Apparently both should be there if it is LGPL.
1065 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1067 *View: Remove unused imports.
1069 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1070 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1071 * src/main/java/org/glom/web/client/ui/ListView.java:
1072 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1073 Remove unused imports, as suggested by Eclipse.
1075 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1077 Move the *View::Presenter types, and some API into one base View.
1079 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1080 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1081 * src/main/java/org/glom/web/client/ui/ListView.java:
1082 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1083 Presenter, setPresenter() and clear() into a shared base interface,
1084 to avoid the unnecessary duplicate Presenter types and to more clearly
1085 show how the *Views share the same structure, even if they are not
1086 used polymorphically.
1088 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1089 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1091 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1092 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1093 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1095 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1098 Feel free to revert this if there is a good reason for the duplicate
1101 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1103 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1105 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1106 a class member instead of a local variable in the method.
1107 This lets us use it to get the view instances, for use in tests.
1108 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1109 beforeOnlineGlom(): Test some more details of the initial view.
1110 Again, this is not very useful.
1112 To really test gwt-glom we will need to start a local postgresql
1113 instance with local data, like the Glom tests in C++.
1115 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1117 pom.xml: Mention the LGPL license.
1119 * pom.xml: Add a licenses section.
1120 * COPYING.LESSER: Move this to COPYING, which
1121 previously contained the GPL. But gwt-glom is all LGPL.
1123 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1125 Add project information to README and pom.xml.
1127 * README: Add a brief description and mention some mvn
1129 * pom.xml: This extra information shows up in mvn site
1132 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1134 Use the latest java-libglom version.
1136 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1138 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1140 GwtTestOnlineGlom: Test a little more.
1142 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1143 protected rather than private, as suggested by the gwt-test-utils
1145 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1146 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1147 Test the initial visibility of the panels.
1149 However, this is not a very useful test.
1150 And I wonder how we should generally test using this idea for an
1151 activity/places app like ours where the real changes happen implicitly
1152 based on the history token/URL.
1154 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1156 Slight modification to *Mapper comments.
1158 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1159 (DataActivityMapper)
1160 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1162 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1164 Remove comments mentioning GIN because they are just copied from
1165 the example code and are apparently not helpful:
1166 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1167 Also change the mention of a class that is only in the example code.
1169 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1171 GwtTestOnlineGlom test: Minor changes.
1173 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1174 Avoid the long qualified class name and modify the comment
1175 because it is now obvious to me that the mocked class is the only
1176 custom one created via GWT.create().
1178 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1180 Tests: Added the beginnings of a test using gwt-test-utils.
1182 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1183 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1184 which tells gwt-test-utils what class will be tested.
1185 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1186 Add a simple (but empty) test case. One class, used by the OnlineGlom
1187 class, is mocked so that it can be created. However, I am not sure
1188 why only this class needs to be mocked.
1190 Note that mockito seems more popular, and clearer, than easymock,
1191 but I have not got that working yet. It might be a matter of the
1194 This test is run during mvn integration-test.
1196 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1198 Tests: Use junit4-style syntax instead of junit3-style.
1200 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1201 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1202 * src/test/java/org/glom/web/shared/DataItemTest.java:
1203 Use the @Test annotation rather than relying on the test*() prefix.
1204 Also no longer implement TestCase, to avoid triggering support for
1205 the junit3-way, which stops the annotations from working.
1206 Change the imports from import junit.framework.* to
1207 import org.junit.*, which is apparently the new way.
1209 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1211 Added a test for ListPlace token parsing and creation.
1213 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1214 This is much the same as DetailsPlaceTest.
1216 I wonder how we could test the other parts of the *Place API.
1218 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1220 DetailsPlace test: Also test getToken() and recreation via getPlace().
1222 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1223 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1224 recreate it, testing the recreated DetailsPlace for the same parameter
1227 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1229 Use the surefire-report plugin.
1231 * pom.xml: This generates a HTML report about the tests in
1232 target/site/surefire-report.html
1233 when you do mvn surefire-report:report. It seems to be popular/normal.
1235 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1237 Added a test for DetailsPlace.
1239 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1240 Test the getPlace() token parsing.
1242 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1244 Added a first unit test.
1246 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1247 * src/test/java/org/glom/web/shared/DataItemTest.java:
1248 This is a silly test but it is just to get things started. Note that
1249 maven/junit finds the test because it looks in src/test by default.
1251 2011-12-22 Ben Konrath <ben@bagu.org>
1253 Change charsetName to "UTF-8" when replacing line breaks.
1255 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1256 that work in Java (such as "UTF8") will not work when compiled to
1259 This fixes a problem with multi-line details view fields that have hard
1260 line breaks. The "License Text" field on this page demonstrates the
1263 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1265 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1267 2011-12-22 Ben Konrath <ben@bagu.org>
1269 Fix another bug with related list navigation.
1271 I've tested all the navigation buttons in all of the related lists
1272 so things should be good now.
1274 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1276 2011-12-22 Ben Konrath <ben@bagu.org>
1278 Fix a crasher when refreshing the list view with the default table.
1280 This crash will also happen when loading the list view with the default
1281 table from a link or bookmark.
1283 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1284 to the main document selection page when the document id hasn't been
1286 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1287 the main document selection page when the document id hasn't been
1289 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1290 values for the details place when the document id hasn't been set.
1291 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1292 values for the list place when the document id hasn't been set.
1294 2011-12-21 Ben Konrath <ben@bagu.org>
1296 Protect against NPE when glom.document.locale is not in config.
1298 This patch protects against an NPE when glom.document.locale is not in
1299 the config file. This NPE will also happen if glom.document.locale is
1302 The patch also updates the error message to display the class name when
1303 the getMessage() returns null. This was happening when the NPE was
1304 thrown and I had "Configuration Error: null". If an NPE is encountered
1305 with this patch, "Configuration Error: NullPointerException " will be
1308 This commit closes this bug:
1310 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1312 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1314 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1316 Rename onlineglom.properties to onlineglom.properties.sample.
1318 * src/main/resources/onlineglom.properties: Rename to:
1319 * src/main/resources/onlineglom.properties.sample:
1320 * src/main/resources/README: And add this file explaining that people
1321 should rename it back when deploying.
1323 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1325 Allow choosing the translation in the .properties file.
1327 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1328 init(): Read a glom.document.locale value from the configuration file
1329 and call Glom's TransatableItem::set_current_locale() method.
1330 * src/main/resources/onlineglom.properties: Add a commented-out
1331 example of this new setting.
1333 It would be better to add &lang=de_DE to the URL, but the current
1334 libglom API does not allow us to do this easily. I am working on that.
1336 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1338 Avoid a crash in parsing of token parameters.
1340 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1341 ava: getTokenParams(): Do not crash if a parameter has a key but no
1342 value, and ignore parameters with neither.
1344 2011-12-17 Murray Cumming <murrayc@murayc.com>
1346 History token building/handling: Improve use of token parameters.
1348 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1349 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1350 and buildParamsToken(HashMap), for use by derived classes.
1351 Make the separator private because it is no longer be needed.
1352 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1353 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1354 instead of manual string concatenation.
1355 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1356 of hardcoded indices and awkward splitting code.
1357 * src/main/java/org/glom/web/client/place/ListPlace.java
1358 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1359 instead of manual string concatenation.
1360 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1361 of hardcoded indices and awkward splitting code.
1362 This should fix bug #666420
1364 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1366 Fix a Navgiation->Navigation typo in the code.
1368 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1369 Rename processNavgiation() to processNavigation().
1371 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1373 Fix a seperator->separator typo in the code.
1375 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1376 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1377 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1380 2011-12-15 Ben Konrath <ben@bagu.org>
1382 Cleanup some comments.
1384 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1386 2011-12-14 Ben Konrath <ben@bagu.org>
1388 Replace \n with <br/> for multiline text in the details view.
1390 Vertical scrollbars are added when needed as well.
1392 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1394 2011-12-14 Ben Konrath <ben@bagu.org>
1396 Specify the font for document selection links.
1398 * src/main/webapp/style.css:
1400 2011-12-14 Ben Konrath <ben@bagu.org>
1402 Fix bouncy CellTable while paging.
1404 This doesn't currently work with related list tables in unselected
1407 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1409 2011-12-14 Ben Konrath <ben@bagu.org>
1411 Revamp the appearance of the document selection page.
1413 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1414 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1415 * src/main/webapp/style.css:
1417 2011-12-13 Ben Konrath <ben@bagu.org>
1419 Set navigation button column to the smallest size possible.
1421 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1423 2011-12-13 Ben Konrath <ben@bagu.org>
1425 Change OpenButton nomenclature to NavigationButton.
1427 Using NavigtionButton makes things more generic. Classes, methods and
1428 variables have been changed.
1430 This is a rename-only refactor.
1432 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1433 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1434 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1435 Renamed from OpenButtonCell.
1436 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1437 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1438 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1440 2011-12-12 Ben Konrath <ben@bagu.org>
1442 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1444 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1445 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1446 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1447 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1449 2011-12-12 Ben Konrath <ben@bagu.org>
1451 Update variable names and comments.
1453 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1454 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1456 2011-12-12 Ben Konrath <ben@bagu.org>
1458 Properly initialize numNonEmptyRows variable to zero.
1460 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1461 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1463 2011-12-05 Ben Konrath <ben@bagu.org>
1465 Add latest mockup with HTML tables.
1467 Features of this mockup:
1469 -> HTML table for flowtable
1470 -> HTML table for flowtable column
1471 -> Example of how related lists would look
1472 -> Not using text entries for data items
1474 The current version of Online Glom doesn't use HTML tables for the
1477 This mockup has been sent to the glom-devel mailing list but it's good
1478 to have it here as well.
1480 * mockups/details-view-html-tables.html:
1482 2011-12-05 Ben Konrath <ben@bagu.org>
1484 Remove unnecessary getPrimaryKeyField() method.
1486 getPrimaryKeyFieldForTable(String) has been renamed to
1487 getPrimaryKeyField(String).
1489 * src/main/java/org/glom/web/server/database/DBAccess.java:
1490 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1491 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1493 2011-12-05 Ben Konrath <ben@bagu.org>
1495 Add string representation of TypedDataItem value to conversion error message.
1497 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1498 message was extracted into its own method to avoid duplication.
1500 2011-12-05 Ben Konrath <ben@bagu.org>
1502 Add type checking to navigation primary key value creation.
1504 Create navigation primary key only if the expected type from the Glom
1505 document matches the type returned by the SQL query.
1507 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1509 2011-12-05 Ben Konrath <ben@bagu.org>
1511 Rename a couple of variables in RelatedListNavigation.
1513 This is a rename-only refactor.
1515 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1517 2011-12-05 Ben Konrath <ben@bagu.org>
1519 Move getListLayoutGroup() into getListViewLayoutGroup().
1521 This removes getListLayoutGroup(). It was only being called by
1522 getListViewLayoutGroup().
1524 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1526 2011-12-05 Ben Konrath <ben@bagu.org>
1528 Remove check for LayoutItem_Portal in list table method.
1530 This check is no longer necessary because the method isn't being used
1531 to create the LayoutItemPortal DTO.
1533 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1535 2011-12-05 Ben Konrath <ben@bagu.org>
1537 Properly support related list navigation.
1539 Navigation from the "Repository Analyzer -> Package Scans ->
1540 Dependencies" related table wasn't working because the primary key for
1541 related tables wasn't being set properly. This commit fixes the
1544 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1545 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1546 doesn't set the primary key properly for related list tables.
1547 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1548 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1549 useful for getting the primary key for list view tables and for related
1551 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1552 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1553 Move code to set the primary key for the table from the abstract
1554 ListDBAccess class to ListViewDBAccess as it's only correct for list
1556 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1557 Properly add primary key to related list tables.
1559 2011-12-02 Ben Konrath <ben@bagu.org>
1561 Properly set the horizontal alignment of fields.
1563 This fix is for both the list tables and the details view.
1565 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1566 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1567 to set the horizontal alignment of fields.
1569 2011-12-02 Ben Konrath <ben@bagu.org>
1571 Display currency codes in the details view.
1573 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1575 2011-12-02 Ben Konrath <ben@bagu.org>
1577 Avoid duplicate JNI call.
1579 JNI is not as efficient as pure Java and this is an easy (and small)
1582 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1583 Use previously retrieved value for whereClauseToTableName instead of
1586 2011-12-02 Ben Konrath <ben@bagu.org>
1588 Rename a couple of variables in RelatedListNavigation.
1590 This is a rename-only refactor.
1592 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1594 2011-12-02 Ben Konrath <ben@bagu.org>
1596 Indicate clearly that a mismatched primary key type is a bug.
1598 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1599 warning to error. Add 'This is a bug.' to message.
1601 2011-12-02 Ben Konrath <ben@bagu.org>
1603 Update / fix some comments.
1605 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1607 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1609 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1610 Fix comments. Add some TODOs.
1612 2011-12-02 Ben Konrath <ben@bagu.org>
1614 Enable navigation to details view with string primary key from related list.
1616 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1617 Create a text primary key value when return type of result is
1618 java.sql.Types.VARCHAR.
1620 2011-12-02 Ben Konrath <ben@bagu.org>
1622 Use checkboxes for booleans in the details view.
1624 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1626 2011-12-01 Ben Konrath <ben@bagu.org>
1628 Improve performance of related list height calculation.
1630 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1631 Put code to calculate the expected height in a static initializer so
1632 that that it's only called once.
1634 2011-12-01 Ben Konrath <ben@bagu.org>
1636 Show related list tables in notebooks (again).
1638 Calculate the height of the related list tables so the Notebook can be
1639 set the correct height. The height of the related list table is also needed by
1640 FlowTable to be able decide how to create the layout.
1642 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1643 and set the Portal height based on the height of the related list
1644 table and the Portal container.
1645 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1646 Add method to calculate the height of the related list tables.
1647 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1648 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1649 calculate the height of the Pager widget.
1651 2011-12-01 Ben Konrath <ben@bagu.org>
1653 Use CellTable API for table property instead of setting style on Element.
1655 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1657 2011-12-01 Ben Konrath <ben@bagu.org>
1659 Make ListViewTable and RelatedListTable a consistent height.
1661 The tables are now a consistent height regardless of the contents of
1662 the table. A hidden button is added to empty rows to ensure that the
1663 height of these rows will match the height of rows with data.
1665 A navigation button column is now added to every table. The width of
1666 the navigation column is set to 0px when a RelatedListTable shouldn't
1667 have navigation buttons. This maintains the a consistent row height in
1668 tables that don't show the navigation buttons.
1670 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1671 navigation column when not needed.
1672 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1673 arguments for navigation button to constructor of ListViewTable.
1674 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1675 hidden button for empty data rows.
1676 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1677 arguments for navigation button to constructor.
1678 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1679 create navigation buttons. Add hideNavigationButtons() method.
1680 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1681 arguments for navigation button to constructor.
1683 2011-12-01 Ben Konrath <ben@bagu.org>
1685 Use 'visibility: hidden' in Utils.getWidgetHeight().
1687 This is better choice because hidden elements are invisible, don't
1688 respond to events and are not part of the tab order. They will,
1689 however, take up space which is required to be able to calculate the
1690 height of the widget.
1692 * src/main/java/org/glom/web/client/Utils.java:
1694 2011-12-01 Ben Konrath <ben@bagu.org>
1696 Use Utils.getWidgetHeight() in FlowTable.
1698 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1700 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1702 2011-12-01 Ben Konrath <ben@bagu.org>
1704 Put the details css class name on the correct table column.
1706 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1708 2011-11-30 Ben Konrath <ben@bagu.org>
1710 Update for java-libglom API change.
1712 The getters and setters on FieldFormatting and NumericFormat were
1713 changed to remove the 'M'.
1715 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1717 2011-11-29 Ben Konrath <ben@bagu.org>
1719 Only allow RelatedListTables in Portals.
1721 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1723 2011-11-29 Ben Konrath <ben@bagu.org>
1725 Only create a contents panel for Portals when title is being set.
1727 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1729 2011-11-29 Ben Konrath <ben@bagu.org>
1731 Set TabLayoutPanel height based on calculated height its widgets.
1733 This is a potential fix for this bug:
1735 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1737 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1739 2011-11-29 Ben Konrath <ben@bagu.org>
1741 Align details field labels and data with the Open buttons.
1743 * src/main/webapp/style.css:
1745 2011-11-29 Ben Konrath <ben@bagu.org>
1747 Remove unnecessary <div> in the Notebook widget.
1749 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1750 method to get container FlowPanel (<div>).
1751 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1752 initWidget() method directly on the TabLayoutPanel widget instead of
1753 Group's container widget.
1755 2011-11-29 Ben Konrath <ben@bagu.org>
1757 Don't add group titles for Portals in Notebooks.
1759 This reverts the previous patch and fixes a bug I introduced with
1760 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1762 * src/main/java/org/glom/web/client/ui/details/Group.java:
1763 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1765 2011-11-28 Ben Konrath <ben@bagu.org>
1767 Remove unused boolean argument in Portal constructor.
1769 Just a code cleanup.
1771 * src/main/java/org/glom/web/client/ui/details/Group.java:
1772 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1774 2011-11-28 Ben Konrath <ben@bagu.org>
1776 Remove hack for glom 1.18 style glom files.
1778 * src/main/java/org/glom/web/client/ui/details/Group.java:
1779 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1780 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1782 2011-11-28 Ben Konrath <ben@bagu.org>
1784 Use Gda Value version of primary key to log result too large error.
1786 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1788 2011-11-28 Ben Konrath <ben@bagu.org>
1790 Don't use TypedDataItem.getText() for Unknown types from the URL.
1792 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1793 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1794 instead of getText().
1795 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1796 String field and getUnknown() method.
1798 2011-11-28 Ben Konrath <ben@bagu.org>
1800 Log an error message when the java-libglom .so is not present.
1802 The error message was being set in the exception but not logged.
1804 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1806 2011-11-28 Ben Konrath <ben@bagu.org>
1808 Ignore LayoutItem_CalendarPortals.
1810 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1811 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1813 2011-11-28 Ben Konrath <ben@bagu.org>
1815 Extract method for creating the LayoutItemPortal DTO.
1817 Just breaking the code up into smaller chunks.
1819 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1821 2011-11-28 Ben Konrath <ben@bagu.org>
1825 This should have been added with the refactor. Oops!
1827 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1829 2011-11-28 Ben Konrath <ben@bagu.org>
1831 Create primary key value from URL string using type from Glom document.
1833 See this bug, comments 19 - 25:
1835 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1837 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1838 create a TypeDataItem for the primary key here when loading from a
1839 URL. Show the same string for the primary key value as was received
1840 from the URL string (when loading from a URL).
1841 * src/main/java/org/glom/web/server/Utils.java: Update method for
1842 creating the Gda Value from the TypeDataItem to properly deal with
1843 creating a Gda Value based on the Glom document type for the primary
1844 key value string when loading from a URL.
1845 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1846 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1847 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1848 Update for changed method name.
1850 2011-11-27 Ben Konrath <ben@bagu.org>
1852 Rename PrimaryKeyItem to TypedDataItem.
1854 The name PrimaryKeyItem suggests what the class should be used for.
1855 TypedDataItem is a neutral name that describes the class better.
1857 This is a rename-only refactor.
1859 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1860 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1861 * src/main/java/org/glom/web/client/Utils.java:
1862 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1863 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1864 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1865 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1866 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1867 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1868 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1869 * src/main/java/org/glom/web/server/Utils.java:
1870 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1871 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1872 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1873 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1875 2011-11-25 Ben Konrath <ben@bagu.org>
1877 Improve Gda Value conversion from PrimaryKeyItem.
1879 The value from the PrimaryKeyItem is only used if its type match the
1880 type from the glom document.
1882 * src/main/java/org/glom/web/server/Utils.java:
1884 2011-11-25 Ben Konrath <ben@bagu.org>
1886 Manually check if the java-liblgom .so is visible to the JVM.
1888 It seems that Tomcat has problems when a static initializer throws an
1889 exception. This check is done before the first method call into
1890 java-libglom so that execution doesn't continue if the .so is not
1893 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1895 2011-11-25 Ben Konrath <ben@bagu.org>
1897 Improve browser configuration error messages.
1901 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1903 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1904 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1905 getConfigurationErrorMessage() method.
1906 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1907 Get and display a specific configuration error message when no Glom
1908 documents are found.
1909 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1910 Implement getConfigurationErrorMessage() method. Surround configuration
1911 code in the init() method with a try/catch block. This allows the
1912 errors to be caught while keeping the servlet available to retrieve the
1913 configuration error message.
1915 2011-11-25 Ben Konrath <ben@bagu.org>
1917 Don't use Strings to hold primary key values.
1919 The primary key values are now held in a new data object
1920 (PrimaryKeyItem) that holds type information and the primary key value
1921 using the correct type.
1923 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1924 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1925 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
1926 PrimaryKeyItem instead of String to hold the primary key value.
1927 * src/main/java/org/glom/web/client/Utils.java: Remove
1928 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
1929 PrimaryKeyItem based on the GlomFieldType and the DataItem.
1930 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
1931 PrimaryKeyItem instead of String to hold the primary key value. Load
1932 document selection page when the documentID has not been set correctly.
1933 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
1934 DetailsPlace -> URL and URL -> DetailsPlace conversion with
1936 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
1937 Return empty string for URL instead of "null".
1938 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1939 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1940 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1941 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1942 PrimaryKeyItem instead of String to hold primary key values.
1943 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
1944 PrimaryKeyValue to a Gda Value.
1945 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1946 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1947 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1948 Replace temporary database access code that uses the PrimaryKeyValue to
1949 Gda Value conversion.
1950 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
1951 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
1952 PrimaryKeyItem instead of String.
1953 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
1954 hold primary key values.
1956 2011-11-24 Ben Konrath <ben@bagu.org>
1958 Use newly added java-libglom API to create queries.
1960 This isn't finished. I still need to stop using Strings for primary key
1961 values in the client code.
1963 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
1964 libglom to use fake connections so that retrieving the query string will
1966 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1967 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1968 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1969 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1970 Use the newly added libglom sql methods and classes to create the
1971 query. Add temporary hack to convert primary value strings to Gda
1974 2011-11-23 Ben Konrath <ben@bagu.org>
1976 Don't explicitly set the height of Portals.
1978 See comments 6 - 10 of this bug for details:
1980 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
1982 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1984 2011-11-23 Ben Konrath <ben@bagu.org>
1986 Use an HTML table instead of CSS for the FlowTable layout.
1988 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
1989 GWT's FlexTable to implement the FlowTable.
1990 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
1992 2011-11-18 Ben Konrath <ben@bagu.org>
1994 Add boolean example to HTML table mockup.
1996 * mockups/details-view-html-tables-text-entries.html:
1998 2011-11-17 Ben Konrath <ben@bagu.org>
2000 Ensure the pager buttons are always visible for related lists.
2002 To accomplish this, I've turned off text wrapping in the list view and
2003 related list tables for both the header and data text. The related list
2004 table now has a fixed layout so the it doesn't overflow its container.
2005 This is required to ensure that the cell text is clipped when it
2006 overflows the cell and an ellipsis is added to the right side of the
2007 cell when text is clipped.
2009 A fixed table layout for the related list table in the details view
2010 seems what we want for the details view anyway, so the side-effect is
2013 The ellipsis will only be displayed in Firefox >= 7.
2017 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2019 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2020 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2021 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2023 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2024 Set the 'table-layout: fixed' CSS property to the related list table.
2025 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2026 'white-space: nowrap;' CSS property on both the list view and the
2027 related list tables.
2029 2011-11-16 Ben Konrath <ben@bagu.org>
2031 Rework the fix for empty notebook tab labels.
2033 Setting the empty group titles with its name caused problems for the
2034 details layout. Instead of using libglom's
2035 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2036 to the client when the title is empty. This allows the Notebook to use
2037 the name when the title is empty without affecting anything else.
2039 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2040 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2042 2011-11-16 Ben Konrath <ben@bagu.org>
2044 Set group titles with name when title is empty.
2046 This fixes a problem with an empty notebook tab label in the Lesson
2047 Planner document. The forth tab in the notebook should be "Internet":
2049 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2051 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2052 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2055 2011-11-16 Ben Konrath <ben@bagu.org>
2057 Remove whitespace from the configured username properties.
2059 This assumes that usernames won't have whitespace at the beginning
2060 or end. But I think this is a reasonable assumption.
2062 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2063 String.trim() to remove the whitespace from the username properties.
2065 2011-11-15 Ben Konrath <ben@bagu.org>
2067 Add details view mockup with HTML tables and text entries.
2069 This is from the attachment on this bug:
2071 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2073 * mockups/details-view-html-tables-text-entries.html:
2075 2011-11-15 Ben Konrath <ben@bagu.org>
2077 Add space between the columns of the flow table.
2081 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2083 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2084 space between columns in the flow table.
2086 2011-11-15 Ben Konrath <ben@bagu.org>
2088 Add backup files to the .gitignore.
2090 * .gitignore: Ignore files that end with ~.
2092 2011-11-09 Ben Konrath <ben@bagu.org>
2094 Use latest release of gwt-log.
2096 Gwt-log releases are now being submitted to the maven central
2097 repository so manual installation of the jar is no longer required.
2099 * pom.xml: Update version and groupId of gwt-log dependency.
2101 2011-10-31 Ben Konrath <ben@bagu.org>
2103 Don't use GWT numeric formatting to override the glom currency formatting.
2105 Currencies are now displayed like they are in Glom. See this bug:
2107 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2109 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2111 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2112 currency code to constructor and set it when the cell is rendered.
2113 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2114 currency code to the constructor of the NumericCell.
2116 2011-10-27 Ben Konrath <ben@bagu.org>
2118 Require the latest release of java-libglom (1.17.4).
2122 2011-10-26 Ben Konrath <ben@bagu.org>
2124 Add style to Notebook that matches current theme.
2126 It's not the best style in the world but it's better than the default.
2128 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2129 padding at the bottom of the child widgets.
2130 * src/main/webapp/style.css: Add style for the Notebook.
2132 2011-10-26 Ben Konrath <ben@bagu.org>
2134 Move servlet initialization code to overridden init method.
2136 This is half of the solution to getting proper error messages
2137 displayed when configuration errors occur. Here's the relevant bug:
2139 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2141 The rest of the solution involves surrounding the init method with a
2142 try/catch block and setting a global variable with the error /
2143 exception. A new async method should be created to retrieve and display
2144 the error message / exception.
2146 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2147 code from constructor to init method adding exceptions as needed.
2149 2011-10-26 Ben Konrath <ben@bagu.org>
2151 Add script to monitor and restart tomcat if required.
2153 * utils/check-and-recover-tomcat.py: New file.
2155 2011-10-26 Ben Konrath <ben@bagu.org>
2157 Display the correct number of data items in the pager.
2161 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2163 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2164 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2165 The implementation is the same for both tables: Keep track of the
2166 number of non-empty rows and fire and RowCountChangeEvent after the data has
2168 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2169 custom Pager class that subclasses SimplePager to handle displaying
2170 the correct number when empty rows have been added.
2172 2011-10-26 Ben Konrath <ben@bagu.org>
2174 Correct error in previous commit.
2176 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2177 eventBus parameter from listView.setCellTable().
2179 2011-10-26 Ben Konrath <ben@bagu.org>
2181 Fix error in TODO comment.
2183 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2185 2011-10-24 Ben Konrath <ben@bagu.org>
2187 Create Notebook widgets to the details view.
2189 This isn't finished just yet - I still need to create a reasonable
2190 style to match the current theme.
2192 * src/main/java/org/glom/web/client/Utils.java: Add method for
2193 calculating the height of a widget. This is used in the Notebook class.
2194 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2195 new constructor method in Group.
2196 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2197 method for creating child widget that can be used by subclasses
2198 like Notebook. New constructor that allows disabling the group
2199 titles - Notebooks don't set a group title for their child groups.
2200 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2201 to make Notebooks using GWT's TabLayoutPanel.
2202 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2203 constructor that allows disabling the group titles.
2204 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2205 LayoutItemNotebook DTO.
2206 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2207 DTO for Notebooks. It's just an empty class for now but we might need
2208 it to transfer some specific information in the future.
2210 2011-10-21 Ben Konrath <ben@bagu.org>
2212 Add navigation buttons to related list tables.
2214 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2215 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2216 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2217 method getSuitableRecordToViewDetails() for getting the table name
2218 and primary key value for related list navigation buttons.
2219 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2220 private cell renderer class to get the navigation information for
2221 related list tables from the server. Extract the navigation
2222 processing code from the details cell navigation and use it for the
2223 related list navigation as well.
2224 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2225 cell renderer class for the details open buttons. This was needed
2226 because the related list navigation buttons and the list view
2227 navigation buttons need to react differently when clicked.
2228 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2229 the onEnterKeyDown() method because it's now overriden in the
2230 subclasses that are specific to the related list tables and the list
2232 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2233 the vertical size a little because the buttons add a bit of vertical
2234 space to table. This is not a perfect solution because the vertical
2235 size of with table fewer than 5 rows will be a little smaller.
2236 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2237 changes in how navigation buttons are handled.
2238 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2239 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2240 database access object.
2241 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2242 to find the portal for a given relationship name from
2243 RelatedListDBAccess. Add method to find a primary key field for a
2245 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2246 Move code to find the portal for a given relationship name to
2248 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2249 New file: database access object for getting the related list
2250 navigation information (the table name and the primary key value).
2251 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2252 DTO for transferring a table name to navigate to and a primary key
2254 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2255 boolean and getter/setter to specifies if the related list should add
2258 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2260 Use the master branch of java-libglom
2262 * pom.xml: Depend on java-libglom 1.19 instead.
2264 This is the master branch. See also the libglom-1-18 branch.
2266 2011-10-11 Ben Konrath <ben@bagu.org>
2268 Enable the open navigation button when the data has been set.
2270 This avoids having active buttons that don't do anything when the data
2273 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2275 2011-10-11 Ben Konrath <ben@bagu.org>
2277 Use IsWidget interface for FlowTableItem.
2279 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2280 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2282 2011-10-11 Ben Konrath <ben@bagu.org>
2284 Remove GWT styling from open button in details view.
2286 There are still some issues with how the details cell is arranged but
2287 this should be made to match Glom 1.20. I'm going to leave fixing this
2288 until I have Glom 1.20 up and running.
2290 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2291 style name on open button.
2292 * src/main/webapp/style.css: Move and edit details-navigation class.
2293 Re-arrange some classes to make them appear in the same order as the
2296 2011-10-07 Ben Konrath <ben@bagu.org>
2298 Update to GWT 2.4.0.
2300 * .gitignore: Ignore new cache directory.
2301 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2302 * pom.xml: Change GWT and maven plugin to 2.4.0.
2303 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2305 * src/main/java/org/glom/web/client/ClientFactory.java:
2306 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2307 * src/main/java/org/glom/web/client/OnlineGlom.java:
2308 Update source for API changes.
2309 * utils/build-onlineglom-war.sh: Remove cache directory before the
2312 2011-10-07 Ben Konrath <ben@bagu.org>
2314 Add navigation buttons in the details view.
2316 This isn't finished but I thought I'd commit what I have as it's a
2317 pretty good start. I still need to:
2319 1. Change the style so that it fits better into the current theme
2320 2. Adjust the details cell to expand as much as possible.
2322 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2323 click handlers to navigation buttons in the DetailsCells. Create a
2324 refreshData() method to get just the data from the server without the
2326 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2327 Update the tableSelector and browser title when the table name
2328 changes without using the tableSelector.
2329 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2330 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2331 getDetailsCells() to getCells(). Update variable names.
2332 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2333 method to set click handler on navigation button. Rename a few
2334 variables. Add navigation buttons where needed.
2335 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2336 variables and methods.
2337 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2338 navigation boolean and navigation table as required in the
2339 LayoutItemField DTO.
2340 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2341 variables for navigation along with getter/setter methods.
2343 2011-10-07 Ben Konrath <ben@bagu.org>
2345 Rename Field to DetailsCell.
2347 This is a refactor-only commit. No functionality has been added or
2350 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2351 Update variable and method names.
2352 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2353 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2354 variable and method names.
2355 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2357 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2358 variable and method names.
2360 2011-10-07 Ben Konrath <ben@bagu.org>
2362 Create separate methods for layout and data the details view.
2364 This is a refactor-only commit. No functionality has been added or
2367 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2368 private methods: setData(), createLayout().
2370 2011-10-07 Ben Konrath <ben@bagu.org>
2372 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2374 This is part of a change to get navigation buttons in the details view
2375 but it should have been done this way from the start.
2377 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2378 for method name change in TableSelectionView.
2379 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2380 Create TableChangeEvent and set the browser title using the
2381 TableSelectionView API.
2382 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2383 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2384 Change getSelectedTable() to getSelectedTableName(). Add
2385 getSelectedTableTitle().
2387 2011-10-07 Ben Konrath <ben@bagu.org>
2389 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2391 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2393 2011-10-07 Ben Konrath <ben@bagu.org>
2395 Update TableChangeEvent to use newTableName naming convention.
2397 This makes the class more consistent with GWT naming conventions.
2399 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2400 Update for method name change in TableChangeEvent.
2401 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2402 for method name change in TableChangeEvent.
2403 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2404 newTableName variable and getter method. Make toDebugString()
2407 2011-09-30 Ben Konrath <ben@bagu.org>
2409 Disable the pager in the list tables when the data row count is less than the minimum.
2411 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2412 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2414 2011-09-30 Ben Konrath <ben@bagu.org>
2416 Add empty rows to the end of related list and list view tables.
2418 I also extracted the cell rendering classes from the ListTable because
2419 the code was becoming a little crazy with all the anonymous inner
2420 classes. My plan is to use these cell rendering classes in the details
2421 view as well so this refactor will be needed for that change.
2423 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2424 set the row count in related list tables if the data has more rows
2425 than the minimum number of rows visible.
2426 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2427 row count in list view tables if the data has more rows than the
2428 minimum number of rows visible.
2429 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2430 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2432 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2433 for rendering TYPE_NUMERIC cells. The code was extracted from the
2435 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2436 class for rendering cells with buttons in list views. The code was
2437 extracted from the ListTable class.
2438 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2439 for rendering TYPE_TEXT cells. The code was extracted from the
2441 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2442 Add empty rows to the end of the data if required. Implement
2443 ListTable.getMinNumVisibleRows().
2444 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2445 cell renderer code to public classes. Return null in
2446 Column.getValue() for empty rows. Add new abstract method:
2447 getMinNumVisibleRows(). Move code to set the row count of the list view
2448 table to ListViewImpl.
2449 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2450 empty rows to the end of the data if required. Implement
2451 ListTable.getMinNumVisibleRows().
2454 2011-09-27 Ben Konrath <ben@bagu.org>
2456 Use GWT.log for client-side debugging statements.
2458 These are optimized out when deployed so I should have used this method
2459 in the first place. These statements will eventually be replaced with some sort
2460 of notification in the browser.
2462 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2463 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2464 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2465 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2466 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2468 2011-09-27 Ben Konrath <ben@bagu.org>
2470 Put tableselector on the right, back to list link on right.
2472 The idea is that the table selector is acting like a label for the
2473 currently displayed table so it should be placed below the document title. This
2474 puts the table title in a similar position to where it is in Glom.
2476 * mockups/details-contacts.html:
2477 * mockups/details-projects.html:
2478 * mockups/listview-contacts.html:
2479 * mockups/listview-projects.html:
2480 * mockups/style.css:
2481 Update mockups to match how the interfaces currently look.
2482 * src/main/webapp/style.css: Swap positions of backlink with the table
2483 selector. Add some space on the left side of the table selector to
2484 line things up with the document title.
2486 2011-09-27 Ben Konrath <ben@bagu.org>
2488 Add field colouring to details view.
2490 This change re-works how field colouring works. The colour formatting
2491 information is now set to the client with the layout information instead of
2492 with the data. This eliminates the need to send the same colour strings for
2493 data in list view column when colour information is set.
2495 In order to set an alternate colour for negative numeric values, the
2496 number is now sent to client and formatted with the GWT NumberFormat class.
2498 This change also fixes:
2500 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2502 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2503 internationalization framework which is needed for client side numeric
2505 * src/main/java/org/glom/web/client/Utils.java: New file for some
2506 client static utility methods.
2507 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2508 the DataItem object to the Field class. Use a utility method to
2509 create the foreignKeyValue string.
2510 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2511 alignment and text colours in the constructor. Add setData(DataItem)
2512 method. Remove setText(String) method.
2513 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2514 colour information to GlomTextCell. Create and use GlomNumberCell for
2515 rendering numbers. Use utility method to get the string for the
2516 primary key of the key provider. Re-work how the horizontal alignment
2518 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2519 formatting to layout information. Methods for converting the libglom
2520 formatting information were moved from DBAccess.
2521 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2522 numeric formatting (it's now done on the client side). Don't set text
2523 colours in DataItem. Move libglom formatting conversion methods to
2525 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2526 getters/setters for text colour information.
2527 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2528 for transferring the libglom NumericFormat information to the client.
2529 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2530 and getters/setters for: GlomNumericFormat, background colour and
2531 foreground colour strings.
2533 2011-09-26 Ben Konrath <ben@bagu.org>
2535 Simplify code that iterates through the LayoutGroup.
2537 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2539 2011-09-26 Ben Konrath <ben@bagu.org>
2541 Accept Eclipse formatting for OnlineGlomServiceAsync.
2543 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2545 2011-09-26 Ben Konrath <ben@bagu.org>
2547 Don't use the ListDBAccess classes to get the primary key layout information.
2549 This was causing a bug where the wrong index for the hidden primary key
2550 was being sent to the client.
2552 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2553 primary key while creating the LayoutGroup DTO. Create a
2554 LayoutItemField DTO for hidden primary keys. Don't use the
2555 RelatedListDBAccess because it was only used for getting the primary
2557 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2558 access modifier from public to protected for getPrimaryKeyField() and
2559 getPrimaryKeyLayoutItemField().
2560 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2561 abstract method getExpectedResultSize() because RelatedListDBAccess
2562 doesn't have enough info to implement it.
2563 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2564 Remove @Override for getExpectedResultSize().
2565 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2566 Remove method getExpectedResultSize().
2568 2011-09-23 Ben Konrath <ben@bagu.org>
2570 Log which layout (list or details) the ignored item is from.
2572 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2574 2011-09-23 Ben Konrath <ben@bagu.org>
2576 Remove annotations that turn off code formatting in DataItem.
2578 * src/main/java/org/glom/web/shared/DataItem.java:
2580 2011-09-23 Ben Konrath <ben@bagu.org>
2582 Rename GlomField to DataItem and update associated methods.
2584 This is a rename-only refactor. No functionality has been added or
2587 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2588 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2589 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2590 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2591 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2592 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2593 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2594 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2595 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2596 * src/main/java/org/glom/web/server/database/DBAccess.java:
2597 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2598 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2599 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2600 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2601 * src/main/java/org/glom/web/shared/DataItem.java:
2602 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2603 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2605 2011-09-23 Ben Konrath <ben@bagu.org>
2607 Rename GlomDocument to DocumentInfo and update associated methods.
2609 This is a rename-only refactor. No functionality has been added or
2612 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2613 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2614 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2615 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2616 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2617 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2618 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2620 2011-09-20 Ben Konrath <ben@bagu.org>
2622 Require java-libglom 1.17.3.
2624 This picks up the fix for the seg fault problem with the Scenes table
2625 in the Openismus Film Manager example.
2629 2011-09-20 Ben Konrath <ben@bagu.org>
2631 Change the way sort clause is added for primary key when no sort clause is requested.
2633 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2634 before the sort clause is created. When a sort clause is not requested, the
2635 sort clause is created by finding the primary key in the LayoutFieldVector
2638 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2640 2011-09-20 Ben Konrath <ben@bagu.org>
2642 Log error message if no documents are found in the configured directory.
2644 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2645 Extract the glom file extension string to a private static final class
2646 variable (mostly as syntactic sugar). Accept a minor formatting change.
2647 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2648 the example glom.document.directory configuration property to make it
2649 more clear that it can any directory, not just the home directory.
2651 2011-09-18 Ben Konrath <ben@bagu.org>
2653 Add related lists to details view.
2655 The related list table has support for paging and sorting just like the
2656 table in the list view.
2658 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2659 SQL queries for the related list tables.
2660 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2661 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2662 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2663 Rename getList methods to getListView and add comments. Remove
2664 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2665 it being unused. Add methods: getDetailsLayoutAndData(),
2666 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2667 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2668 Create the layout and set the data for the fields in one async call
2669 instead of two. Create related lists where appropriate.
2670 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2671 for method name changes in OnlineGlomService.
2672 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2673 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2674 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2676 * src/main/java/org/glom/web/client/ui/ListView.java:
2677 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2678 tableName from setCellTable(). Create a ListViewTable instead of
2680 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2681 represent a data field in the details view.
2682 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2683 from addDetailsCell() to Field class. Keep track of the Fields and
2684 Portals in the details view.
2685 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2686 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2687 and add a method to get it. Add method to set the contents of the
2689 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2690 New class for related list tables. This class has the data provider
2691 for the related list table.
2692 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2693 abstract class which is the base class for the ListViewTable and the
2695 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2696 New class for list view tables. This class has the data provider for
2697 the list view table.
2698 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2699 methods for related list tables. Add more information to the
2700 LayoutItemField and LayoutItemPortal DTOs.
2701 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2702 Remove debugging print statement.
2703 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2704 Remove debugging print statements. Add primary key field to SQL count
2706 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2707 Remove unnecessary LayoutFieldVector parameter from
2708 getResultSizeOfSQLQuery() method.
2709 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2710 New class for related list table database access.
2711 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2712 class that is a wrapper DTO for details view layout and data.
2713 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2714 new 'fromField' string to this DTO.
2715 * src/main/webapp/style.css: Remove bottom margin and override top
2718 2011-09-15 Ben Konrath <ben@bagu.org>
2720 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2722 This sets things up to make it easier to add the data retrieval for
2723 related lists (portals). No user noticeable changes were made with
2726 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2727 class has the code to retrieve the layouts and access the
2728 database using the new database helper classes.
2729 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2730 Most of the functionality has been removed from this class. This
2731 class now represents the public interface for the client side
2732 code. It also deals with configuring the servlet and cleaning
2733 things up when the servlet is stopped.
2734 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2735 of static methods into this utility class.
2736 * src/main/java/org/glom/web/server/database/DBAccess.java:
2737 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2738 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2739 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2740 These classes have the database retrieval code. The class hierarchy
2741 has been setup to make it easy to reuse code for similar
2744 2011-09-06 Ben Konrath <ben@bagu.org>
2746 Create separate classes for list table code and the data provider.
2748 As part of this refactor, I also split up the code a bit to make it
2751 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2752 table code to two new classes (below).
2753 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2754 with code from ListViewImpl.
2755 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2756 New file with code from ListViewImpl.
2758 2011-09-06 Ben Konrath <ben@bagu.org>
2760 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2762 This fixes the LayoutItemPortal DTO to match the libglom layout object
2765 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2767 2011-09-01 Ben Konrath <ben@bagu.org>
2769 Set title of Portals in the Details View.
2771 * pom.xml: Bump required version of java-libglom to 1.17.1.
2772 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2773 widget creation to its own class. Add comments to constructor.
2774 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2775 The code is mostly from the Group class with the title now set.
2776 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2777 title of Portal. Update some comments. Fix some code formatting.
2779 2011-09-01 Ben Konrath <ben@bagu.org>
2781 Remove TODO comment for the flow table column width.
2783 The flow table column width is working correctly and doesn't need to be
2784 changed. See this mailing list post for more info:
2786 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2788 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2790 2011-08-27 Ben Konrath <ben@bagu.org>
2792 Add document title (database name) to top of the browser page.
2794 I added the document title to the TableSelecitonView but that will
2795 change if / when we add a view that doesn't require table selection.
2797 * mockups/details-contacts.html:
2798 * mockups/details-projects.html:
2799 * mockups/listview-contacts.html:
2800 * mockups/listview-projects.html:
2801 * mockups/style.css: Add document title to mockups to keep things
2803 * src/main/java/org/glom/web/client/OnlineGlom.java: Adjust LayoutPanel
2804 sizes to account for the document title.
2805 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2806 Set the document title when it has been retrieved from the server.
2807 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2808 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java: Add
2809 and implement setDocumentTitle(String) method.
2810 * src/main/webapp/style.css: Add ID for document title style.
2812 2011-08-25 Ben Konrath <ben@bagu.org>
2814 Add NavigationType enum to LayoutItemPortal DTO.
2816 This is the start of adding support for Portals to the Details View.
2818 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Convert
2819 LayoutItem_Portal.navigation_type enum from libglom to
2820 LayoutItemPortal.NavigationType enum.
2821 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2822 NavigationType enum, field for storing the NavigationType and getter
2825 2011-08-25 Ben Konrath <ben@bagu.org>
2827 Implement the flow table layout in the Details View.
2829 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2830 FlowTable to Group to account for the renamed class.
2831 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: New
2832 File. This is a container widget that implements the Glom details view
2833 flow table behaviour.
2834 * src/main/java/org/glom/web/client/ui/details/Group.java: Moved from
2835 org/glom/web/client/ui/FlowTable.java.
2836 * src/main/webapp/style.css: Adjust bottom margin of the subgroup-title
2837 so that the size of the subgroups are a closer match to the size of
2838 the Glom subgroups. This makes the flowtable layout match the layout
2839 in Glom for the Music Collection example file.
2841 2011-08-16 Ben Konrath <ben@bagu.org>
2843 Create container element for LayoutItemPortal in Details View.
2845 This will help me develop the layout for the FlowTable.
2847 * src/main/java/org/glom/web/client/ui/FlowTable.java: Also rename
2848 fieldPanel variable to detailsCell.
2850 2011-08-15 Ben Konrath <ben@bagu.org>
2852 Set the height of the data element in the Details View.
2854 I changed the InlineLabels (text in a span element) to Labels (text in
2855 a div element) so that I could set the height of the details-data
2856 elements instead of the details-cell parent elements. This allows the
2857 the details-data element to display the correct height if style is
2858 applied that shows the height.
2860 This change has the added benefit of allowing the order of the labels
2861 and data elements to be changed for right-to-left languages.
2863 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Change
2864 InlineLabels to Labels.
2865 * src/main/java/org/glom/web/client/ui/FlowTable.java: Change
2866 InlineLabels to Labels. Set the height of the data element.
2867 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set the
2868 multiline text height in the Formatting DTO.
2869 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add field
2870 for multiline height&nb