Allow primary keys to be any type, and test it.
[online-glom:gwt-glom.git] / ChangeLog
1 2012-11-30  Murray Cumming  <murrayc@murrayc.com>
2
3         Allow primary keys to be any type, and test it.
4
5         * src/main/java/org/glom/web/shared/TypedDataItem.java:
6         Add overrides for the other set*() methods, to set the type.
7         Added getValue() which returns a generic Object.
8         * src/main/java/org/glom/web/server/SqlUtils.java:
9         buildSimpleWhereExpression(): Use TypedDataItem.getValue() instead of 
10         getNumber().
11         * src/test/java/org/glom/web/server/SelfHostExampleNonNumericPrimaryKeysTest.java:
12         Added this test, which is much like SelfHostExampleTest, but which uses this
13         test file, take from Glom:
14         * src/test/resources/org/glom/web/server/test_example_music_collection_text_pk_fields.glom:
15         which has all the primary keys changes to text instead of numbers.
16
17         However, parts of the UI code still assume that primary keys are numbers.
18
19 2012-11-28  Murray Cumming  <murrayc@murrayc.com>
20
21         SelfHostExampleTest: Move some checks into a utility function.
22
23         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
24         Move the data checks into a new file:
25         * src/test/java/org/glom/web/server/SelfHostTestUtils.java:
26         SelfHostTestUtils.java: so we can use it in some other 
27         tests, with different documents.
28
29 2012-11-28  Murray Cumming  <murrayc@murrayc.com>
30
31         SelfHosting test: Also try using a relationship.
32
33         * src/main/java/org/glom/web/server/database/DBAccess.java:
34         convertResultSetToDTO(): Move some code into a public 
35         method as:
36         * src/main/java/org/glom/web/server/SqlUtils.java:
37         fillDataItemFromResultSet(): This takes a DataItem and 
38         sets it from a value from a datbase recordset.
39         * src/main/java/org/glom/web/server/libglom/Document.java:
40         Make getDocument() public, so we can use it in a test.
41         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
42         Add testExampleMusiccollectionDataRelated() and call it from 
43         testExampleMusiccollectionData(), to do a basic test of using
44         a relationship.
45
46 2012-11-22  Murray Cumming  <murrayc@murrayc.com>
47
48         Build: Specify the source encoding.
49
50         * pom.xml: Set project.build.sourceEncoding
51         This should fix this build problem on some systems:
52         [ERROR] /var/lib/jenkins/workspace/OnlineGlom/src/test/java/org/glom/web/server/libglom/DocumentTest.java:[139,72] error: unmappable character for encoding ASCII
53
54 1.23.1:
55
56 2012-11-20  Murray Cumming  <murrayc@murrayc.com>
57
58         Update the jasperreports version.
59
60         * pom.xml: This was shown by
61         mvn versions:display-dependency-updates
62
63 2012-11-20  Murray Cumming  <murrayc@murrayc.com>
64
65         Eclipse: Reorder the Java Build Path to fix the build in Eclipse.
66
67         * .classpath: This prevents an error saying that getTextContent()
68         is undefined.
69         See http://mergetag.com/the-method-gettextcontent-is-undefined-for-the-type-node/
70
71 2012-11-20  Murray Cumming  <murrayc@murrayc.com>
72
73         Explicitly declare some dependencies (and scopes) that we use.
74
75         * pom.xml: The dependency report showed what we use.
76
77 2012-11-20  Murray Cumming  <murrayc@murrayc.com>
78
79         Update the gwt-test-utils version.
80
81         * pom.xml: gwt-test-utils 0.43 uses GWT 2.5.0, not GWT 2.4.0.
82         Using both in the same project was causing gwt-log to fail in GWTBrige,
83         with this error:
84         testOutOfBounds(org.glom.web.server.libglom.DocumentLayoutPathTest):
85         (class: com/google/gwt/core/client/GWT, method: setBridge signature: (Lcom/google/gwt/core/client/GWTBridge;)V) Incompatible argument to function
86
87 2012-11-19  Murray Cumming  <murrayc@murrayc.com>
88
89         DocumentTest: testLocales(): Update for the latest example version.
90
91         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
92         The .glom file, updated in the previous commit, now has more translations.
93
94 2012-11-19  Murray Cumming  <murrayc@murrayc.com>
95
96         Update the .glom files used for tests.
97
98         * src/test/resources/org/glom/web/server/example_film_manager.glom:
99         * src/test/resources/org/glom/web/server/example_music_collection.glom:
100         * src/test/resources/org/glom/web/server/libglom/example_film_manager.glom:
101         * src/test/resources/org/glom/web/server/libglom/example_music_collection.glom:
102         Copy them from git master of Glom.
103
104 2012-11-18  Murray Cumming  <murrayc@murrayc.com>
105
106         Update versions of dependencies.
107
108         * pom.xml: Increase some version numbers based on the output of
109         , using mvn versions:display-dependency-updates.
110         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
111         Use the annotation instead of getModuleName().
112         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
113         Do not use deprecated assert() classes/methods.
114
115 2012-11-18  Murray Cumming  <murrayc@murrayc.com>
116
117         Document: Correct an import to use the correct Log API.
118
119         * src/main/java/org/glom/web/server/libglom/Document.java:
120         Use our Utils.Log API rather than the jfree one that Eclipse
121         must have suggested at some time.
122
123 2012-11-15  Murray Cumming  <murrayc@murrayc.com>
124
125         Details: Get static image data from our images services.
126
127         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
128         Add constructors for LayoutItemText and LayoutItemImage and
129         deal with their common type instead of just LayoutItemField.
130         setData():
131         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
132         Adapted.
133         * src/main/java/org/glom/web/client/ui/details/Group.java:
134         createChildWidget(): Use the other DetailsCell constructors for
135         these layout items, and do not add them to the list of
136         cells with data from the database.
137         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
138         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
139         Remove the image data when cloning the layout and storing it in the
140         cache. Clients will instead get it via the URL, from
141         our images service.
142         * src/main/java/org/glom/web/server/OnlineGlomImages.java:
143         doGet(): Depending on the URI parameters, optionally get 
144         image data from a layout_item_image in the document,
145         via its layout path.
146         * src/main/java/org/glom/web/server/database/DBAccess.java:
147         convertResultSetToDTO(): Move some URIBuilder code to:
148         * src/main/java/org/glom/web/server/Utils.java:
149         Add buildImageDataUrl() taking the primary key, etc, to
150         get data from the database.
151
152 2012-11-15  Murray Cumming  <murrayc@murrayc.com>
153
154         Document: Static image items: Store an image URL, using the layout path. 
155
156         * src/main/java/org/glom/web/server/Utils.java: Add buildImageDataUrl().
157         * src/main/java/org/glom/web/server/libglom/Document.java:
158         Add a constructor that takes the documentID, for use in the 
159         LayoutItemImage URL.
160         loadLayoutNode(): Pass a Path object to the helper methods, so we 
161         can use it to create a URL for LayoutItemImage items.
162         This seems as good a way as any to specify a layout item in the document.
163         * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
164         Pass the documentID to the constructor, for use in the LayoutItemImage
165         URL.
166
167 2012-11-15  Murray Cumming  <murrayc@murrayc.com>
168
169         Document: Add getLayoutItemByPath().
170
171         * src/main/java/org/glom/web/server/Utils.java:
172         Add buildLayoutPath() and parseLayoutPath().
173         * src/test/java/org/glom/web/server/LayoutPathTest.java: Test that these 
174         utility methods work.
175         * src/main/java/org/glom/web/server/libglom/Document.java:
176         Add Add getLayoutItemByPath().
177         * src/test/java/org/glom/web/server/libglom/DocumentLayoutPathTest.java: Test 
178         that it works.
179
180         This will be useful in subsequent commits.
181
182 2012-11-15  Murray Cumming  <murrayc@murrayc.com>
183
184         Document: Use a better base64 decoder to read static image data.
185
186         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
187         getNodeTextChildAsValue(): Use the apache commons base64 decoder
188         instead of the gwt one, because it correctly decodes the strings
189         from g_base64_encode(). It is probably more correct.
190         The newlines might be confusing the gwt decoder.
191
192 2012-11-14  Murray Cumming  <murrayc@murrayc.com>
193
194         Document: Do not use == to compare strings. Use equals().
195
196         * src/main/java/org/glom/web/server/libglom/Document.java:
197         == only checks that they are the same object, so it can 
198         seem to fail.
199
200 2012-11-14  Murray Cumming  <murrayc@murrayc.com>
201
202         Document: Add and use public constants for layout names.
203
204         * src/main/java/org/glom/web/server/libglom/Document.java:
205         Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
206         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
207         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
208         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
209         * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use 
210         them here instead of hard-coded the strings repeatedly.
211
212 2012-11-13  Murray Cumming  <murrayc@murrayc.com>
213
214         Document: Load static text and image items too.
215
216         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
217         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
218         New LayoutItem classes to represent these layout items.
219         * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The 
220         main text of a LayoutItemText.
221         * src/main/java/org/glom/web/server/libglom/Document.java:
222         load_after_layout_group(): Handle the node types and instantiate the 
223         new classes.
224         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
225         Add testLayoutItemText() to check that the text is loaded properly.
226
227 2012-11-13  Murray Cumming  <murrayc@murrayc.com>
228
229         Do not use client.GWT for shared code.
230
231         * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
232         Import shared.GWT instead of client.GWT, which seems to be appropriate.
233
234 2012-11-12  Murray Cumming  <murrayc@murrayc.com>
235
236         Use image data when recreating databases for testing.
237
238         * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
239         for use locally (not acrosss the network) when recreating databases
240         for testing.
241         getValue(): Use it here instead of getImageDataUrl(), noting that 
242         this method is only for use when recreating databases.
243         * src/main/java/org/glom/web/server/libglom/Document.java:
244         getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
245
246 2012-11-09  Murray Cumming  <murrayc@murrayc.com>
247
248         OnlineGlomImages: Detect the mime-type (content type).
249
250         * src/main/java/org/glom/web/server/OnlineGlomImages.java:
251         doGet(): Instead of hard-coding image/png.
252
253 2012-11-09  Murray Cumming  <murrayc@murrayc.com>
254
255         Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
256
257         * .classpath:
258         * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
259         Java Compiler and Java Build path settings in the UI.
260
261 2012-11-09  Murray Cumming  <murrayc@murrayc.com>
262
263         Use the latest (now stable) version of GWT.
264
265         * pom.xml: And the latest version of the gwt-maven-plugin.
266
267 2012-11-08  Murray Cumming  <murrayc@murrayc.com>
268
269         Added an Indonesian translation.
270
271         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
272         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
273         This is from the new translation in Glom.
274
275 2012-07-23  Murray Cumming  <murrayc@murrayc.com>
276
277         Details: Show images.
278
279         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
280         Move some code into
281         * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
282         so it can be used in:
283         * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
284         for serving image data.
285         * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
286
287         * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
288         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
289         setData(): For image field types, add a GWT Image widget, 
290         with the URL that was set in the DataItem.
291
292         * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
293         * src/main/java/org/glom/web/server/database/DBAccess.java:
294         convertResultSetToDTO(): Set the URL for image data, so the client browser
295         can retrieve the image from our new servlet. This uses UriBuilder.
296         Move getPrimaryKeyField to:
297         * src/main/java/org/glom/web/server/libglom/Document.java:
298         Added getTablePrimaryKeyField().
299
300         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
301         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
302         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
303         Adapted.
304
305 2012-07-22  Murray Cumming  <murrayc@murrayc.com>
306
307         Rename the servlet.
308
309         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
310         * src/main/java/org/glom/web/client/OnlineGlomService.java:
311         * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
312         to gwtGlom, which is more appropriate.
313         This servlet name does not seem to be visible to the client side anyway.
314
315 2012-07-22  Murray Cumming  <murrayc@murrayc.com>
316
317         Tests: Make the imports of assert*() consistent.
318
319         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
320         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
321         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
322         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
323         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
324         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
325         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
326         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
327         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
328         * src/test/java/org/glom/web/shared/DataItemTest.java:
329         Just do
330         import static org.junit.Assert.*;
331         which seems fairly common.
332
333 1.21.10 (unstable):
334
335 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
336
337         tests: Move a test that needs a database connection.
338
339         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
340         Move testGetListViewLayoutGroup() to
341         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
342         because it needs a database connection.
343
344 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
345
346         tests: Use @BeforeClass on tearDown().
347
348         * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
349         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
350         This avoids leaking a postgres process in SelfHostExampleTest.
351
352 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
353
354         tests: Test translations more.
355
356         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
357         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
358         Test titles in the non-default locale.
359
360 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
361
362         tests: Add SelfHostConfiguredDocumentTest
363  
364         * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the 
365         username and password, for use by ConfiguredDocument.
366         * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java: 
367         This tests some of the ConfiguredDocument API that requires a database connection.
368
369 2012-07-21  Murray Cumming  <murrayc@murrayc.com>
370
371         Document: Load title translations and test them.
372
373         * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
374         of titles. I am surprised that we do not do this yet.
375         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
376         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
377         Test translations more.
378
379 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
380
381         Set JDBC timeouts.
382
383         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
384         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
385         Set the timeout here too.
386
387 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
388
389         tests: ConfiguredDocumentTest: Make this pass.
390
391         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
392         Disable tests that need a database connection.
393
394 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
395
396         Use Java 1.7 instead of Java 1.6.
397
398         * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
399         to do this twice, at least for Eclipse.
400         This seems OK because it is the current version.
401
402 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
403
404         Some error checking.
405
406         * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
407         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
408         Avoid using a null Connection.
409
410 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
411
412         tests: Add a ConfiguredDocument test.
413
414         * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
415         Add this test.
416
417 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
418
419         LayoutItemFIeld: getName(): Use the Field if it is set.
420
421         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
422         getName(): If the full field details have been set, return its name, so that
423         callers do not need to set the name separately.
424         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
425         testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
426         so we can count the rows.
427
428 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
429
430         tests: SelfHoster: Test SqlUtils too.
431
432         * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
433         Retrieve some data and check it too, as in the regular Glom
434         test_selfhosting_new_from_example.cc test.
435         * src/test/java/org/glom/web/server/SelfHoster.java:
436         createConnection(): Make this public.
437
438 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
439
440         tests: SelfHoster: createConnection(): Do not warn about expected failures.
441         
442         Let the caller say if the connection is expected to fail, to avoid 
443         irrelevant error output.
444
445 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
446
447         tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
448         
449         * src/test/java/org/glom/web/server/SelfHoster.java:
450         createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
451         due to the inevitable need to retry the connection while the database server
452         starts.
453
454 2012-07-20  Murray Cumming  <murrayc@murray.com>
455
456         tests: SelfHoster: createConnection(): Set a timeout.
457
458         * src/test/java/org/glom/web/server/SelfHoster.java:
459         createConnection(): Use setLoginTimeout() because it otherwise seems to take
460         ages to actually return when it fails.
461
462 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
463
464         tests: SelfHoster: selfHost(): Close the test connection.
465
466         * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
467         When we check that the connection works, close the connection. This seems
468         to not be closed automatically otherwise.
469
470 2012-07-20  Murray Cumming  <murrayc@murrayc.com>
471
472         Use slf4j-simple to see JDBC errors.
473
474         * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
475
476 2012-07-19  Murray Cumming  <murrayc@murrayc.com>
477
478         SelfHoster.discoverFirstFreePort(): Close the socket.
479
480         * src/test/java/org/glom/web/server/SelfHoster.java:
481         discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
482
483 2012-07-19  Murray Cumming  <murrayc@murrayc.com>
484
485         Avoid another code warning in Eclipse Juno.
486
487         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
488         Do instanceof checks on the FileUtils.listFiles() result and its 
489         items.
490
491 2012-07-13  Murray Cumming  <murrayc@murrayc.com>
492
493         Avoid some code warnings in Eclipse Juno
494
495         * src/main/java/org/glom/web/server/libglom/Document.java:
496         getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
497         * src/test/java/org/glom/web/server/SelfHoster.java
498         createTextFile(): Make sure that the FileOutputStream is closed.
499
500 2012-06-22  Murray Cumming  <murrayc@murrayc.com>
501
502         Added OnlineGlomPropertiesTest.
503
504         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
505         Make sure we never return a null string.
506         * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
507         Added tests of the OnlineGlomProperties API, using our sample file.
508
509 2012-06-20  Murray Cumming  <murrayc@murrayc.com>
510
511         Make OnlineGlomProperties be a normal class.
512
513         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
514         Move OnlineGlomProperties into its own file to be a regular class:
515         * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
516         This makes testing simpler.
517
518 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
519
520         OnlineGlomServiceImpl.init(): Move some code into a new method.
521
522         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
523         Create addDocument().
524
525 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
526
527         OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
528
529         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
530         OnlineGlomProperties.getKey(): Make this more robust by moving the
531         check for *.*.filename to here.
532
533 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
534
535         OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
536
537         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
538         init(): Move knowledge of the config file format into the 
539         OnlineGlomProperties inner class.
540
541 2012-06-15  Murray Cumming  <murrayc@murrayc.com>
542
543         SelfHostExampleTest: Make sure we cleanup on failure.
544
545         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
546         the use of cleanup() to a tearDown() JUnit method.
547
548 1.21.9.3:
549
550 2012-06-12  Murray Cumming  <murrayc@murrayc.com>
551
552         ConfiguredDocument: Add a primary key to portals at least once.
553
554         * src/main/java/org/glom/web/server/ConfiguredDocument.java
555         updatePortalsExtras): Fix a typo so that we add the primary key
556         column at least once.
557         This is a fix for the previous commit:
558         ConfiguredDocument: Do not add a primary key to portals each time.
559
560 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
561
562         SelfHoster: Avoid some compiler warnings.
563
564         * src/test/java/org/glom/web/server/SelfHoster.java
565         executeCommandLineAndWait():
566         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
567         the now-unused streams for stdout and stderr from the command Processes.
568         These are not used because readln() hangs while waiting for a new line,
569         where there may be no next line. The commented out code is still there
570         to help us figure out how to do this properly.
571
572 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
573
574         LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
575
576         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
577         Make this actually test the cloning again, though it is not very useful
578         now that we do not use the part that had a problem with cloning before.
579
580 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
581
582         SelfHoster: Keep trying pg_ctl after starting postgres.
583
584         * src/test/java/org/glom/web/server/SelfHoster.java
585         executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
586         Try pg_ctl repeatedly (for ever) until it succeeds, as we do in 
587         regular Glom. This seems mad but it seems to work because the first
588         command would fail if pg_ctl would eventually fail.
589
590 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
591
592         SelfHoster: Wait until the server is really ready.
593
594         * src/test/java/org/glom/web/server/SelfHoster.java
595         selfHost(): Attempt the connection after starting the server, retrying 
596         a few times if necessary, so that the server is really ready already when
597         we return from this method.
598         The regular Glom code does this too because pg_ctl reports success too soon.
599
600 2012-06-08  Murray Cumming  <murrayc@murrayc.com>
601
602         ConfiguredDocument: Do not add a primary key to portals each time.
603
604         * src/main/java/org/glom/web/server/ConfiguredDocument.java
605         updatePortalsExtras(): Only add an extra primary key field if there is 
606         none, to avoid adding one each time we retrieve the details layout from the
607         layouts cache.
608         This should fix bug #676986 (Ben Konrath) 
609
610 2012-05-25  Murray Cumming  <murrayc@murrayc.com>
611
612         Document.load(): Support version 7 documents. 
613
614         * src/main/java/org/glom/web/server/libglom/Document.java: Load the 
615         database_title attribute if the title attribute is not there.
616         Bug #676737
617
618 2012-05-24  Ben Konrath  <ben@bagu.org>
619
620         Add configuration for auto-generating mvn:i18n from with Eclipse.
621
622         * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
623
624 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
625
626         Update translations, adding French.
627
628         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
629         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
630         Add a French translation, using the translation from Glom.
631
632         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
633         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
634         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
635         Update these based on the translations from Glom.
636
637 2012-05-24  Murray Cumming  <murrayc@murrayc.com>
638
639         SelfHoster: Add some debug println messages to help when things fail.
640
641         * src/test/java/org/glom/web/server/SelfHoster.java: Add several
642         System.out.println() lines.
643
644 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
645
646         Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
647
648         * src/test/java/org/glom/web/server/SelfHoster.java:
649         getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for 
650         instance) instead of just /usr/bin (as on Fedora). Check the result when 
651         using this method.
652
653 2012-05-23  Murray Cumming  <murrayc@murrayc.com>
654
655         Remove LayoutItemPortal.get/setNavigationTable().
656         
657         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
658         Remove get/setNavigationTable(), which is only a cache, because it is not
659         used, and does not need to be used, because that decision should be made on
660         the server.
661         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
662         updatePortalsExtras():
663         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
664         getNavigationRecord():
665         * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
666         Adapted.
667
668 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
669
670         Initial self-hosting for tests.
671
672         * pom.xml: Change the scope for log4j, to hopefully make it 
673         available to the test code which uses it indirectly via jOOQ.
674         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
675         self-hosting, though we only use it for testing.
676
677         * src/main/java/org/glom/web/server/libglom/Document.java:
678         example rows: Use a map instead of a list for each row of values,
679         so we know what field they are for, instead of relying on the sequence
680         being correct. This is not very efficient, but it does not really need 
681         to be.
682         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
683         testReadTableExampleRows(): Adapted.
684
685         * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
686         that returns an Object, for generic use. Note that Object seems to be 
687         the implicit base even of double.
688         * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
689         for use in CREATE TABLE SQL queries.
690         * src/test/java/org/glom/web/server/SelfHoster.java: Add this class 
691         to do self-hosting of PostgreSQL databases via its command-line 
692         utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
693         backends/postgres_self.cc. This is incomplete - it needs more 
694         warnings about failures and it needs to clean up properly when things
695         fail.
696         * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple 
697         test of this new class.
698
699 2012-05-21  Murray Cumming  <murrayc@murrayc.com>
700
701         Document: loading example data: Handle exceptions.
702
703         * src/main/java/org/glom/web/server/libglom/Document.java:
704         DateFormat.parse() and Double.valueOf() can throw exceptions, though
705         Eclipse did not warn about that.
706
707 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
708
709         Document: load(), save(): Handle the example rows.
710
711         * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate() 
712         and get/setImage().
713         * src/main/java/org/glom/web/server/libglom/Document.java:
714         load(), save(): Load and save the example rows, though the date, time
715         and image types are not handled properly yet.
716         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
717         Add testReadTableExampleRows() just to check that something is read.
718
719 2012-05-20  Murray Cumming  <murrayc@murrayc.com>
720
721         Document: Add save().
722
723         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
724         Added getTranslationsMap() for use while saving.
725         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
726         Adedd getUseDefaultFormatting() for use while saving.
727         * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
728         and several private methods that it uses.
729
730         This will be useful while testing via self-hosting.
731         It is not complete, but should be complete enough for testing.
732
733 2012-05-17  Murray Cumming  <murrayc@murrayc.com>
734
735         OnlineGlomService: Simplify the getList/RelatedViewData() methods.
736
737         * src/main/java/org/glom/web/client/OnlineGlomService.java
738         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
739         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
740         Remove getSortedListViewData() and getSortedRelatedListData(), adding
741         the sort column index and ascending bool to the regular method.
742         Instead, a sort column index of -1 now means no sort.
743         This is less explicit, but it's fairly simple, reduces the amount of 
744         code, and makes the OnlineGlomService API slightly smaller.
745         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
746         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
747         getDataProvider():
748         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
749         getListViewData(), getRelatedListData():
750         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
751         getListViewData(), getRelatedListData():
752         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
753         getListData():
754         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
755         getData():
756         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
757         getData(): Adapted.
758
759 1.21.9.2:
760
761 2012-05-16  Murray Cumming  <murrayc@murrayc.com>
762
763         Use translations for top-level groups too.
764
765         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
766         updateTitlesForLocale(): Use the translation for the group 
767         as well as for child items.
768
769 1.21.9.1:
770
771 Just recompiled to fix a problem in the released .tar.gz file.
772
773 1.21.9:
774
775 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
776
777         Corrections to navigation to related records.
778         
779         * src/main/java/org/glom/web/client/OnlineGlomService.java:
780         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
781         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
782         getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
783         getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a 
784         relationship name, because the relationship name is not necessarily unique 
785         on the layout.
786         TOOD: This is inefficient, because it passes the whole list of 
787         child field items back to the server, but it is more correct, and happens
788         to fix a bug with the primary key being lost after a few navigations.
789         There is probably a chance to make this more efficient anyway in some 
790         more basic way.
791         
792         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
793         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
794         * src/main/java/org/glom/web/server/ConfiguredDocument.java
795         * src/main/java/org/glom/web/server/database/DBAccess.java
796         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
797         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
798         Adapted.
799
800 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
801
802         Fix the use of translations.
803
804         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
805         Add updateTitlesForLocale().
806         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
807         Call it to discard unwanted translations and to make getTitle() return
808         the wanted translation wihout the need for the client code to specify a locale.
809         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
810         getTitle(): Fallback to the original title, as libglom does.
811
812 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
813
814         Document: Correctly report the number of available translation locales.
815
816         * src/main/java/org/glom/web/server/libglom/Document.java: Fill
817         the available locale IDs list.
818         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
819         testLocales: Test this.
820
821 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
822
823         SqlUtils: Use camelCase.
824
825         * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
826         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
827         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
828         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
829         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
830         * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
831
832 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
833
834         Use jOOQ's tableByName() and fieldByName.
835
836         * pom.xml: Use jOOQ 2.3.1 to get the new API.
837         * src/main/java/org/glom/web/server/SqlUtils.java:
838         build_sql_select_step_with_where_clause(), .createField(),
839         builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
840         so we can get correct quoting and escaping. Thanks to Lukas Eder for 
841         adding this, and other things, to jOOQ.
842
843 2012-05-15  Murray Cumming  <murrayc@murrayc.com>
844
845         SqlUtils: Remove the Connection parameters.
846
847         * src/main/java/org/glom/web/server/SqlUtils.java:
848         build_sql_select_with_key(), build_sql_select_with_where_clause(),
849         createSelect(), build_sql_select_step_with_where_clause(),
850         build_sql_count_select_with_where_clause(),
851         build_sql_select_count_rows(): Remove the Connection parameter because
852         jOOQ does not actually need a connectionwhen it is just used to build 
853         a SQL string:
854         https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
855
856         * src/main/java/org/glom/web/server/ReportGenerator.java:
857         generateReport():
858         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
859         getData():
860         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
861         Constructor, getListData(), getResultSizeOfSQLQuery():
862         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
863         getSelectQuery(), getCountQuery():
864         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
865         getSelectQuery(), getCountQuery():
866         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
867         getNavigationRecord(): Adapted.
868
869 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
870
871         Fix quick find.
872
873         * src/main/java/org/glom/web/server/SqlUtils.java:
874         get_find_where_clause_quick(): Use a comparison of 
875         lowercase values, instead of a simple equals. Regular Glom
876         uses the PostgreSQL ILIKE operator but jOOQ does not 
877         support that just yet, though it will soon.
878
879 2012-05-14  Murray Cumming  <murrayc@murrayc.com>
880
881         TableToViewDetails: Use a real serialization ID.
882
883         * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
884         Though this does not fix the serialization problem.
885
886 2012-05-12  Murray Cumming  <murrayc@murrayc.com>
887
888         Added LayoutItemPortalDeepCloneTest.
889
890 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
891
892         Make navigation work again.
893
894         * src/main/java/org/glom/web/server/libglom/Document.java:
895         Add getLayoutItemFieldShouldHaveNavigation().
896         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
897         Replace get/setAddNavigation() with the partly-existing 
898         get/setNavigationTableName(), with an empty string being no navigation,
899         because this is simpler. Use the new 
900         Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
901         
902         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
903         Add updateFieldsExtras() and call setNavigationTableName in it.
904         getDetailsLayoutGroup(), 
905         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
906         createLayout(): Adapted.
907         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
908         Constructor: Adapted.
909
910         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
911         Replace get/setAddNavigation() with get/setNavigation(), returning a
912         TableToViewDetails class with both the table name and UsesRelationship,
913         because both are need. The previous code used java-libglom's output 
914         variable (strangely, via sharedptr) to return both, but we cannot really
915         do that in Java.
916         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
917         getNavigationRecord(): Adapt. However, we cannot actually use the cache
918         here because it somehow gets set to null during deepCopy(). I must test this.
919         * src/test/java/org/glom/web/server/libglom/DocumentTest.java
920         testGetSuitableTableToViewDetails(): Adapted.
921         
922         TODO: Find out why deepClone() is not quite working.
923         
924 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
925
926         DBAccess: Simplify the retrievel of full field details.
927
928         * src/main/java/org/glom/web/server/database/DBAccess.java
929         getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
930         because the Document loading should have done this.
931
932 2012-05-11  Murray Cumming  <murrayc@murrayc.com>
933
934         Document: Correct loading of doubly-related layout fields.
935
936         * src/main/java/org/glom/web/server/libglom/Document.java:
937         loadUsesRelationship(): Actually set the related relationship, instead
938         of only setting it if it's not found.
939
940 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
941
942         Replace all appearances of Colour with color.
943
944         Because US English is dominant.
945
946 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
947
948         Use colors in HTML format, solving a warning about an unused function.
949
950         * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
951         * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
952         Add *asHTMLColor() versions of methods.
953         TODO: However, we should create and cache the results on the server.
954         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
955         * src/main/java/org/glom/web/client/ui/list/ListTable.java
956         * src/main/java/org/glom/web/server/ConfiguredDocument.java
957         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
958         Use the asHTMLcolor() versions.
959
960 2012-05-09  Murray Cumming  <murrayc@murrayc.com>
961
962         ListViewTable: Constructor: Take the table name as a parameter.
963
964         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
965         Constructor: Take the tableName, and set the member variable, because
966         we use it here.
967         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
968         setCellTable(): Pass the table name.
969         This makes navigation to non-default tables work again. I don't know 
970         why it worked before in the master branch.
971
972 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
973
974         ConfiguredDocument: Restore correct addition of hidden primary key items.
975
976         * src/main/java/org/glom/web/client/ui/list/ListTable.java
977         (ListTable.createCellTable): Uncomment out the check for the hidden
978         primary key.
979         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
980         add primary key items for top-level lists and portals, as before, 
981         instead of adding them to each group.
982         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
983         Actually implement the extra methods such as setHiddenPrimaryKey() and
984         comment that these are used only for top-level list groups and in portals.
985         This strangeness suggests even more that this should not be squeezed
986         into the LayoutGroup class.
987
988 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
989
990         Fix Formatting loading.
991
992         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
993         getFormattingUsed(): Remove the duplicate Formatting member variable
994         in favour of the one from the base class.
995         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
996         Initialize a new Formatting instead of using null by default, so we 
997         have some defaults, instead of having to initialize one later just to 
998         get the same defaults. This also makes loading of formatting from the
999         document work, because that expected a non-null.
1000
1001 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
1002
1003         RelatedListTable: Make sure that the tableName is set.
1004
1005         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1006         Constructor: Take the tableName so it is available later. Otherwise, 
1007         the server assumes that we mean the default table and cannot find the
1008         relationship in it.
1009         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1010         setData(): Pass the tableName to the RelatedListTable constructor.
1011
1012 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
1013
1014         Add some checks.
1015
1016         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1017         RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
1018         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1019         getDataProvider():
1020         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1021         addColumn():
1022         * src/main/java/org/glom/web/server/database/DBAccess.java:
1023         convertResultSetToDTO(), getPortal():
1024         * src/main/java/org/glom/web/server/database/ListDBAccess.java
1025         getListData():
1026         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1027         Add checks for null objects and out of range access, with log messages to
1028         give hints so we can fix these properly.
1029
1030 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
1031
1032         Portals: some corrections.
1033
1034         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1035         setData():
1036         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1037         constructor: Use getRelationshipNameUsed() instead of getName(), because
1038         that is what is meant.
1039         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1040         getFromField(): Fix a typo, to get the field name, not the table name.
1041         * src/main/java/org/glom/web/server/database/DBAccess.java:
1042         getPortal(): Fix a typo that stopped this from working.
1043
1044 2012-05-07  Murray Cumming  <murrayc@murrayc.com>
1045
1046         LayoutItemPortal: Also override getTitleOriginal().
1047
1048         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
1049         This lets the base getTitle() with no parameters work.
1050         TODO: Test this properly.
1051
1052 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1053
1054         LayoutItemPortal: getTitle*(): Use the relationship title.
1055
1056 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1057
1058         LayoutItemField: Fix loading of custom titles.
1059
1060         * src/main/java/org/glom/web/server/libglom/Document.java
1061         loadDataLayoutItemField(): The title, if any, instead of the field 
1062         title, is stored in a title_custom node. Load it from there.
1063         * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
1064         class.
1065         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
1066         Add getCustomTitle() and use it, instead of super.getTitle*(), in the
1067         getTitle*() overrides.
1068         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1069         Adapt.
1070
1071 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1072
1073         LayoutItemField: Fall back to field titles, so some are really shown.
1074
1075         * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
1076         Override getTitleOriginal() and getTitle(), as in java-libglom.
1077         * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
1078         Test this behaviour.
1079
1080 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1081
1082         Correct use of setExpectedResultSize().
1083
1084         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1085         getValidListViewLayoutGroup(), getDetailsLayoutGroup():
1086         Use setExpectedResultSize only on top-level groups (for instance, the
1087         list layout) or on child portals (in details views).
1088         Use the correct table name for portals to avoid SQL errors.
1089         Update the expected counts when returning cached layouts.
1090
1091 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1092
1093         Document: Interpret no group column count as 1.
1094
1095         * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
1096         default, though we now check for this in the UI code anyway.
1097
1098 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1099
1100         More null checks.
1101
1102 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1103
1104         Translatable: Use Hashmap instead of Treemap because GWT supports it.
1105
1106         * src/main/java/org/glom/web/shared/libglom/Translatable.java:
1107         The use of Treemap lead to this error from async methods, with no 
1108         further clue:
1109         "The response could not be deserialized"
1110
1111 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1112
1113         OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
1114
1115         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary 
1116         when using the Google -> GWT Compile, or 
1117         g toolbar button -> GWT Compile Project... feature in Eclipse.
1118
1119 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1120
1121         ListTable.addColumn(): Protect against a null Formatting.
1122
1123         * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
1124         Create a default Formatting if it is null, because that is the simplest
1125         way to do this.
1126
1127 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1128
1129         ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
1130
1131         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1132         updateLayoutGroup(): Check that the field is not null.
1133
1134 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1135
1136         ListViewImpl: Protected against a bad cast error.
1137
1138         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1139         onEnterKeyDown(): Do not cast without an instanceof check.
1140
1141 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1142
1143         ListTable: Protect against an out of range error.
1144
1145         * src/main/java/org/glom/web/client/ui/list/ListTable.java
1146         createCellTable(): This is unlikely, but can happen while debugging.
1147
1148 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1149
1150         AsyncMessage onFailure() callbacks: Log the exception message.
1151
1152         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1153         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1154         * src/main/java/org/glom/web/client/activity/ListActivity.java:
1155         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1156         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1157         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1158         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1159         These are useful clues when something is wrong.
1160
1161 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1162
1163         ConfiguredDocument: Avoid a null dereference.
1164
1165         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1166         TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and 
1167         details maps are created.
1168
1169 2012-05-06  Murray Cumming  <murrayc@murrayc.com>
1170
1171         Document: Correct the port number parsing.
1172
1173         * src/main/java/org/glom/web/server/libglom/Document.java:
1174         This lets us actually connect to the database and show the document.
1175
1176 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1177
1178         Fix mvn gwt:test
1179
1180         * pom.xml: Use htmlunit mode for gwt:test, because the default demands
1181         user-interaction, asking us to load a temporary URL in a browser.s
1182         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
1183         which is apparently necessary for testing the service. See the comment.
1184         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java: 
1185         Show the exception, if any. This is how I saw the 404 in the HTML in 
1186         the exception.
1187
1188 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1189
1190         DocumentTest: Move the .glom files into the resources directory.
1191
1192         * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1193         URI via getResource().
1194
1195 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1196
1197         Document: Remove the FieldIdentifies inner class.
1198
1199         * src/main/java/org/glom/web/server/libglom/Document.java: We only
1200         use the Relationship (though the same function in libglom is maybe
1201         used in other ways) and so this removes a compiler warning.
1202
1203 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1204
1205         Document.load() Remove the error code parameter.
1206
1207         * src/main/java/org/glom/web/server/libglom/Document.java: load():
1208         Remove the parameter. We do not set it yet and it could never have
1209         worked as an output parameter (though maybe it did in java-libglom).
1210         We could use an exception if we really want the failure reason.
1211         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1212         init():
1213         * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1214         setUp(), testGetSuitableTableToViewDetails(): Adapt.
1215
1216 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1217
1218         Make some inner classes static.
1219
1220         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1221         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1222         * src/main/java/org/glom/web/server/ReportGenerator.java
1223         * src/main/java/org/glom/web/server/libglom/Document.java
1224         Make all inner classes static that can be static.
1225
1226 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1227
1228         OnlineGlomServiceImpl: Do not load and check for java-libglom.
1229
1230         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1231         init(): We do not use java-libglom any more.
1232
1233 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1234
1235         Remove mentions of java-libglom.
1236
1237         * README: Remove mention of java-libglom, because it no longer needed.
1238         * utils/build-onlineglom-war.sh:
1239         * utils/check-and-recover-tomcat.py:
1240         * utils/install-onlineglom-war.sh: Remove these as they are no longer
1241         useful. Building is now far easier, with no need for jhbuild.
1242
1243 2012-05-05  Murray Cumming  <murrayc@murrayc.com>
1244
1245         Fix the build (mvn package)
1246
1247         * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1248         (LayoutGroup): Make the LayoutItemList inner class static and protected.
1249         Otherwise the GWT Java->Javascript compilation fails with just this
1250         error, during mvn package or when attempting to view in a browser, 
1251         in the GWT developer mode in Eclipse.
1252
1253         [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1254         [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1255         [INFO] Compiling module org.glom.web.OnlineGlom
1256         [INFO]    [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1257         [INFO]       [ERROR] Line 46:  Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1258         [INFO]    Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1259         [INFO]       [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1260         [INFO]          [WARN] org.glom.web.client.OnlineGlomService_Proxy
1261         [INFO]    [ERROR] Cannot proceed due to previous errors
1262
1263         It has taken me 2 days to find out what was causing that. After reducing
1264         the code, the compiler eventually showed me the full error message.
1265
1266 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1267
1268         ConfiguredDocument: Cache the cloned and stripped layouts.
1269
1270         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1271         getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1272         layout in a map, so we can retrieve it again without rebuilding it.
1273
1274 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1275
1276         UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1277
1278 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1279
1280         libglom classes: Implement some auto-generated emthods.
1281
1282 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1283
1284         Add GwtTestOnlineGlomService.
1285
1286         * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1287         However, this (and the other GwtTest*) does not seem to run during 
1288         mvn test. 
1289
1290 2012-05-04  Murray Cumming  <murrayc@murrayc.com>
1291
1292         Remove use of unsupported features from client code.
1293
1294         * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1295         * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1296         * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1297         Use our client version of StringUtils instead of the apache commons one.
1298         
1299         However, the GWT Javascript compliation still fails.
1300
1301 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
1302
1303         Add a Field class and implement some loading of it in Document.
1304
1305 2012-04-25  Murray Cumming  <murrayc@murrayc.com>
1306
1307         Initial Document loading implementation, instead of libglom.
1308
1309         * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1310         and Translatable classes, and adapt the rest of the code to use them.
1311         However, this is still missing Layout and Field classes and loading.
1312
1313 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
1314
1315         Use of jOOQ: Move Field creation into a utility method.
1316
1317         * src/main/java/org/glom/web/server/SqlUtils.java:
1318         This lets us improve it more easily.
1319
1320 2012-04-24  Murray Cumming  <murrayc@murrayc.com>
1321
1322         Use of jOOQ: Improve the code to COUNT a sub-select.
1323
1324         * src/main/java/org/glom/web/server/SqlUtils.java:
1325         Move initial query creation into 
1326         build_sql_select_step_with_where_clause().
1327         build_sql_select_count_rows(): Use the jOOQ API instead of
1328         concatentating text, because a jOOQ Select*Step is a TableLike,
1329         which is what from() takes.
1330
1331 2012-04-23  Murray Cumming  <murrayc@murrayc.com>
1332
1333         Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1334
1335         * pom.xml: Depend on jooq.
1336         * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1337         methods with jOOQ, based on the C++ implementations in libglom,
1338         with some changes to the logic required by jooQ.
1339         Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1340         where clause.
1341         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1342         * src/main/java/org/glom/web/server/ReportGenerator.java:
1343         * src/main/java/org/glom/web/server/SqlUtils.java:
1344         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1345         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1346         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1347         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1348         * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1349         Adapt. In particular, the SqlUtils methods now need to take a Connection,
1350         because jOOQ needs that, though it seems unnecessary.
1351
1352         This is not quite finished. Ideally jOOQ would help us to build 
1353         table_name.field_name names, quoting and escaping them properly.
1354         See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1355
1356 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1357
1358         Move use of Glom.build_sql*() into a new SqlUtils class.
1359
1360         * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1361         to wrap Glom.build_sql*(). The parameter types are still Glom one,
1362         but this will make it easier to start using something other than 
1363         libglom or SqlBuilder.
1364
1365 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1366
1367         Update the project URL.
1368
1369         * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1370
1371 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1372
1373         Main layout: Use a FlowTable instead of absolute positioning.
1374
1375         * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1376         The RootLayoutPanel is a (extends) AbsolutePanel, so each of its 
1377         child panels/widgets must have an absolute position. But that is annoying, so
1378         this adds a FlowTable and puts the child panels in there.
1379
1380 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1381
1382         GwtTestOnlineGlom: Comment out unused code.
1383
1384         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1385         Eclipse has started to say that some code is unused.
1386
1387 2012-04-21  Murray Cumming  <murrayc@murrayc.com>
1388
1389         Update to the latest versions of dependencies.
1390
1391         * pom.xml: Update version numbers of dependencies to the latest
1392         versions.
1393         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1394         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1395         * src/main/java/org/glom/web/server/ReportGenerator.java:
1396         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1397         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1398         * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1399         java:
1400         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1401         Modify the imports where necessary.
1402
1403 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1404
1405         Style: Remove overflow:hidden from searchbox
1406
1407         * src/main/webapp/style.css: Because this pushes the Back To Link
1408         label/link on to the next row, which is then hidden due to the 
1409         hard-coded (in ems) height.
1410
1411 2012-04-20  Murray Cumming  <murrayc@murrayc.com>
1412
1413         Remove some duplicate code.
1414
1415         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1416         getDocumentInfo(): This must have been duplicated during the merge from the
1417         reports branch.
1418
1419 1.21.8.1:
1420
1421 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1422
1423         Reports: Localize the waiting for report message.
1424
1425         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1426         start(): Get the message from the contants.
1427         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1428         Add the string here.
1429         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1430         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1431         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1432         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1433         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1434         Update these files with the English text for newer strings for now.
1435
1436 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1437
1438         Reports: Show a message while waiting for the report.
1439
1440         * src/main/java/org/glom/web/client/ui/ReportView.java
1441         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1442         Add setWaitingText(), to show a message saying that we are 
1443         waiting for the report to be ready.
1444         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1445         start(): Call setWaitingText() before calling the async
1446         report generation.
1447
1448 2012-04-19  Murray Cumming  <murrayc@murrayc.com>
1449
1450         ReportGenerator: Specify date and time formats.
1451
1452         * src/main/java/org/glom/web/server/ReportGenerator.java:
1453         createFieldValueElement(): Use the default (and localized)
1454         short formats, though we still need a way to show 4-digit
1455         years without providing the format for every locale.
1456         * src/main/java/org/glom/web/server/database/DBAccess.java:
1457         convertResultSetToDTO(): Use the short formats here too.
1458
1459 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1460
1461         ReportGenerator: Use the correct numeric formatting.
1462
1463         * src/main/java/org/glom/web/server/ReportGenerator.java
1464         createFieldExpression(), createFieldValueElement(): Take the
1465         whole LayoutItem_Field instead of just the field name, so
1466         we have access to the formatting.
1467         createFieldValueElement(): Use JRTextField.setPattern() to
1468         specify the numeric formatting, with the help of a 
1469         regular DecimalFormat.
1470
1471 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1472
1473         ReportGenerator: Avoid showing null for group by titles.
1474
1475         * src/main/java/org/glom/web/server/ReportGenerator.java
1476         generateReport(): Use setBlankWhenNull() on the field title
1477         style too, because this is used for values in group by
1478         sections.
1479
1480 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1481
1482         ReportGenerator: Add a colon to titles in vertical groups.
1483
1484         * src/main/java/org/glom/web/server/ReportGenerator.java
1485         addFieldToDetailBandVertical(): Pass true for the withColon
1486         parameter.
1487
1488 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1489
1490         ReportGenerator: Simplify the code by using Position more.
1491
1492 2012-04-18  Murray Cumming  <murrayc@murrayc.com>
1493
1494         Reports: Support vertical groups, roughly.
1495
1496         * src/main/java/org/glom/web/server/ReportGenerator.java:
1497         addToReport(): Rename to addGroupToReport() and, if necessary,
1498         call the new addVerticalGroupToReport() method.
1499         createFieldValueElement(): Let the caller specify the Y position
1500         too.
1501
1502 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1503
1504         Reports: Allow a second report to be shown.
1505
1506         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1507         clear(): Do not remove the HTML widget, which broke the whole layout.
1508
1509 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1510
1511         Locales drop-down: Show that we use English by default.
1512
1513         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1514         fillView(): When we use English, just because that is the default, when
1515         no locale is specified, show that in the Locales drop-down instead of 
1516         just showing the first item.
1517
1518 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1519
1520         Unselect the Report/Locale/Table combo item when appropriate.
1521
1522         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1523         setPlace(): clear reportName if this is not a ReportPlace.
1524         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1525         setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1526         When the provided name is empty, unselect all items, so that none are
1527         indicated. This uses a for loop because I cannot find a single method
1528         to do this.
1529
1530 2012-04-17  Murray Cumming  <murrayc@murrayc.com>
1531
1532         Report: Give the user a way to get back to the list.
1533
1534         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1535         start(), setPlace(): Show the Back To List link on reports, and also 
1536         interpret selecting the empty report item as back to list.
1537
1538 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1539
1540         Really show the selected Report name.
1541
1542         * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1543         setPlace(): Store the reportName here, if it is that kind of Place.
1544         fillView(): Set the selected Report after filling the list of reports.
1545         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1546         setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1547         null Strings, though we need some way to unselect all ListBox items
1548         in that case.
1549
1550 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1551
1552         ReportGenerator: Try to avoid some problems.
1553
1554         * src/main/java/org/glom/web/server/ReportGenerator.java
1555         addField(): Try to avoid duplicates, and avoid using a null
1556         class type.
1557
1558 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1559
1560         Reports: Use quickFind.
1561
1562         * src/main/java/org/glom/web/client/OnlineGlomService.java;
1563         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1564         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1565         getReportHTML(): Add a quickFind parameter.
1566         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1567         start(): Pass the quickFind parameter.
1568         * src/main/java/org/glom/web/server/ReportGenerator.java
1569         generateReport(): Take a quickFind parameter.
1570
1571 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1572
1573         ReportPlace: Actually use the report name.
1574
1575         * src/main/java/org/glom/web/client/place/ReportPlace.java
1576         getPlace(): Do not assign the report name to the quickfind.
1577
1578 2012-04-13  Murray Cumming  <murrayc@murrayc.com>
1579
1580         Show java.library.path when complaining.
1581
1582         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1583         init(): When telling us to check java.library.path, show the
1584         current value.
1585
1586 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1587
1588         ReportGenerator: Do not show nulls.
1589
1590 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1591
1592         ReportGenerator: Make the title font larger.
1593
1594 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1595
1596         ReportGenerator: Put field titles inside groups, if there are groups.
1597
1598 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1599
1600         ReportGenerator: Take the Report itself instead of the name and group.
1601
1602         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1603         Remove getReportLayoutGroup().
1604         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1605         getReportHTML(): Pass the report instead
1606         of its name and layout group.
1607         * src/main/java/org/glom/web/server/ReportGenerator.java
1608         generateReport(): Use the report object to use the title 
1609         instead of the name.
1610
1611 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1612
1613         ReportGenerator: Remove designBand parameters.
1614
1615         * src/main/java/org/glom/web/server/ReportGenerator.java:
1616         Make designBand a class member instead of passing it to all
1617         methods.
1618
1619 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1620
1621         ReportGenerator: Add lines, a bit like in the desktop version.
1622
1623         * src/main/java/org/glom/web/server/ReportGenerator.java
1624         addToReport(): Use JRDesignLine.
1625
1626 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1627
1628         ReportGenerator: Correct the title positions and use some bold style.
1629
1630         * src/main/java/org/glom/web/server/ReportGenerator.java:
1631         Break the code up into reusable functions, correct the placement of 
1632         titles, and use normal/bold styles as in the reports in the desktop 
1633         version.
1634
1635 2012-03-06  Murray Cumming  <murrayc@murrayc.com>
1636
1637         ReportGenerator: Add a header band to show the field titles.
1638
1639         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1640         getReportHTML(): Pass the localeId to the ReportGenerator 
1641         constructor.
1642         * src/main/java/org/glom/web/server/ReportGenerator.java
1643         constructor: Take the localeID so we can get translated field
1644         titles.
1645         generateReport(), addToReport(), addFieldToBand(): Add field 
1646         titles in a column header band.
1647
1648 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1649
1650         Reports drop-down list: Some improvement.
1651
1652         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1653         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1654         Adedd setSelectedReport(),
1655         setReportList(): Add a blank line so that the user can select the 
1656         first one.
1657         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1658         start(): Show the current report by calling setSelectedReport().
1659         This does not seem to work yet.
1660
1661 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1662
1663         DetailsActivity, ListActivity: Move some variables into a base class.
1664
1665         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1666         * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1667         * src/main/java/org/glom/web/client/activity/ListActivity.java: Move 
1668         the clientFactory, documentID, tableName and authenticationPopup into
1669         a base class, to avoid duplication.
1670
1671 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1672
1673         Translate the Reports label.
1674
1675         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1676         Get the "Reports" label string from the constants.
1677         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1678         perties: Add Reports to the constants.
1679
1680 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1681
1682         Reports: Implement grouping.
1683
1684         * src/main/java/org/glom/web/server/ReportGenerator.java:
1685         Handle LayoutItem_GroupBy items and try to do the right thing
1686         with JRDesignGroup. It seems to work.
1687
1688 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1689
1690         Actually show some data with JasperReports.
1691
1692         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: 
1693         getReportHTML(): Move most code into a ReportGenerator class.
1694         * src/main/java/org/glom/web/server/ReportGenerator.java:
1695         Recurse into sub-groups, adding fields to the JasperDesign's details
1696         band. Note that we must set an arbitrary width and height, or it just
1697         will not show any data.
1698
1699 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1700
1701         Reports Chooser: Show the titles, not the names.
1702
1703         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1704         (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1705         and the names as the values.
1706         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1707         (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1708         group now that we provide the report name, so it should always 
1709         succeed.
1710
1711 2012-02-15  Murray Cumming  <murrayc@murrayc.com>
1712
1713         Depend on jasperreports.
1714
1715         * pom.xml: Add the dependency. My plan is to use this on the 
1716         server side.
1717
1718 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1719
1720         Implement navigation to report places.
1721
1722         * src/main/java/org/glom/web/client/activity/ReportActivity.java
1723         start(): Do not bother to handle all events here.
1724         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1725         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1726         Added getSelectedReport().
1727         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1728         .java: start(): When handling a change to the reports chooser,
1729         call getSelectedReport() and goTo() its ReportPlace.
1730         * src/main/java/org/glom/web/client/ui/ReportView.java
1731         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1732         Added setReportHTML() which puts the html in a gwt HTML widget.
1733         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1734         getReportHTML(): Return "TODO" just to show that this works.
1735
1736 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1737
1738         Make ReportPlace usable.
1739
1740         * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1741         Mention ReportPlace.
1742         * src/main/java/org/glom/web/client/place/ReportPlace.java:
1743         Correct the @prefix annotation.
1744
1745 2012-01-31  Murray Cumming  <murrayc@murrayc.com>
1746
1747         OnlineGlomService: Return report HTML rather than the LayoutGroup.
1748
1749         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1750         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1751         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1752         Change getReportLayout() to getReportHMTL() because we will not need to 
1753         parse or render the report layout on the client side.
1754         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1755         getReportLayout(): Return the libglom LayoutGroup type because we will
1756         not need to convert to a shared type, because this will not be used on
1757         the client side.
1758         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1759         Adapted.
1760
1761         Note that there is still no implementation for this.
1762
1763
1764 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1765
1766         Add a (empty) Report Place, View, and Activity.
1767
1768         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1769         Rename to:
1770         * src/main/java/org/glom/web/client/place/HasTablePlace.java
1771         * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1772         this into a superclass:
1773         * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1774         and also use it as the base of this new ReportPlace:
1775         * src/main/java/org/glom/web/client/place/ReportPlace.java
1776
1777         * src/main/java/org/glom/web/client/ui/ReportView.java
1778         * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1779         * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1780         Add these, containing mostly boiler-plate for now.
1781
1782         * src/main/java/org/glom/web/client/OnlineGlomService.java
1783         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1784         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1785         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1786         Add API to get the LayoutGroup for the report.
1787
1788 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
1789
1790         Add and fill a Reports drop-down list box.
1791
1792         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1793         Aded getReports():
1794         * src/main/java/org/glom/web/client/OnlineGlomService.java:
1795         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1796         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1797         Added getReports(document, table, localeID), calling 
1798         ConfiguredDocument.getReports().
1799         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1800         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1801         Added setReportsList() and a list widget.
1802         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1803         .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1804
1805
1806 1.21.8:
1807
1808 2012-04-12  Murray Cumming  <murrayc@murrayc.com>
1809
1810         Translations: Add Esperanto.
1811
1812         * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1813         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1814         properties: Add this translation because someone took the time to make it.
1815
1816 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1817
1818         Adapt to the java-libglom 1.21.7 API. 
1819
1820         * src/main/java/org/glom/web/server/ReportGenerator.java:
1821         addToReport(): get_group_secondary_fields() is now
1822         get_secondary_fields().
1823
1824
1825 2012-03-15  Murray Cumming  <murrayc@murrayc.com>
1826
1827         Use the latest java-libglom version.
1828
1829         * pom.xml: Use java-libglom 1.21.7.
1830
1831 2012-03-03  Ben Konrath  <ben@bagu.org>
1832
1833         Display date and time in details view.
1834
1835         https://bugzilla.gnome.org/show_bug.cgi?id=671257
1836
1837         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1838
1839 2012-03-05  Murray Cumming  <murrayc@murrayc.com>
1840
1841         Require the latest java-libglom.
1842
1843         * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1844
1845 2012-03-04  Murray Cumming  <murrayc@murrayc.com>
1846
1847         ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1848
1849         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1850         ListViewDBAccess.getSelectQuery(): Do not create a where clause for 
1851         an empty quickfind string. I also corrected libglom to create only 
1852         empty where clauses for empty quickfind strings, but this avoids the
1853         need for that fix.
1854
1855 2012-02-24  Ben Konrath  <ben@bagu.org>
1856
1857         Improve the tabs in the Notebook widget.
1858
1859         Bug #670728
1860
1861 2012-01-30  Murray Cumming  <murrayc@murrayc.com>
1862
1863         Translations: Try to translate the strings.
1864
1865         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1866         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1867         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1868         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1869         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1870         Take the Open translation from GTK+'s .po files.
1871         Take the Details translation from Glom's po files.
1872         I have added the other strings to Glom so we can get translations that way:
1873         http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1874
1875 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1876
1877         TableSelectionViewImpl: Put the search label and entry in a div.
1878
1879         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1880         Put the search widgets in a FlowTable so that the CSS can be used to
1881         style them while keeping them together.
1882         * src/main/webapp/style.css: Mention the new div.
1883
1884 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1885
1886         Translate more strings in more locales.
1887
1888         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1889         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1890         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1891         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1892         Translate the "Details" and "Open" string too.
1893
1894         * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1895         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1896         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1897         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1898         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1899         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1900         Add these new locales as placeholders though they currently contain English.
1901
1902 2012-01-27  Murray Cumming  <murrayc@murrayc.com>
1903
1904         OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1905
1906         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1907         Check the ConfiguredDocument* for null before using it.
1908
1909 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1910
1911         Tell Eclipse about the generated java files.
1912
1913         * .classpath: This lets it find OnlineGlomConstants.java.
1914         It would be nice if Eclipse just used the maven build files.
1915
1916 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1917
1918         Prevent a crash when no locale is specified in the URL.
1919
1920         * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1921         Avoid returning a null string, obtained from 
1922         Window.Location.getParameter(). This caused a crash when it was
1923         later passed to libglom's API.
1924         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1925         init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1926         getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1927         guard against future null strings.
1928
1929 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1930
1931         Use the ?locale= query param instead of the &lang= token param. 
1932
1933         * src/main/java/org/glom/web/client/place/ListPlace.java
1934         * src/main/java/org/glom/web/client/place/DetailsPlace.java
1935         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1936         Remove the lang token key and value.
1937         
1938         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1939         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1940         When the user selects a different locale from the chooser, use 
1941         Window.Location.assign() to change the URL, which then causes a reload.
1942         
1943         * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1944         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1945         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1946         * src/main/java/org/glom/web/client/activity/ListActivity.java
1947         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1948         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1949         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1950         * src/main/java/org/glom/web/client/ui/ListView.java:
1951         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1952
1953         Remove localeID member variables and method/constructor parameters, instead
1954         using Utils.getCurrentLocaleID() when we need a localID to pass to 
1955         OnlineGlomService.
1956
1957 2012-01-26  Murray Cumming  <murrayc@murrayc.com>
1958
1959         Internationalize the UI strings.
1960
1961         * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a 
1962         <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1963         * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1964         because it is unused. Messages are apparently strings that can have 
1965         parameters, but we do not need that yet, so Contants will be enough for now.
1966         * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1967         to say that we support the en and de locales.
1968         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1969         The original English strings.
1970         * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1971         Some German translations of the English strings.
1972         The i18n goal then uses the .properties file to generate an 
1973         OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1974         returns an implementation that returns the translated strings.
1975         The documentation suggests putting these in src/java/*/client/, but it seems
1976         best to put it in src/resources/*/client/.
1977         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1978         Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1979         instead of hard-coding them.
1980         Note that we cannot import OnlineGlomConstants because it does not exist yet,
1981         but that does not seem to stop the build, though it confuses Eclipse.
1982         
1983         You can see the translated string by adding ?locale=de to the URL, like so:
1984         http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1985
1986 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
1987
1988         Improve null/empty String checks. 
1989
1990         * pom.xml: Add a dependency on commons-lang, to use
1991         org.apache.commons.lang.StringUtils.
1992         * src/main/java/org/glom/web/server/ConfiguredDocument.java
1993         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1994         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1995         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1996         Use StringUtils.isEmpty().
1997
1998         * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1999         StringUtils class with a static isEmpty() function because we 
2000         cannot use org.apache.commons.lang.StringUtils in client-side
2001         GWT code because it (apparently) cannot be compiled to javascript.
2002         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2003         * src/main/java/org/glom/web/client/activity/ListActivity.java
2004         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
2005         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2006         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2007         * src/main/java/org/glom/web/client/place/ListPlace.java
2008         * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
2009         * src/main/java/org/glom/web/client/ui/cell/TextCell.java
2010         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
2011         * src/main/java/org/glom/web/client/ui/details/Group.java
2012         * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use 
2013         our StringUtils.isEmpty() function.
2014
2015 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
2016
2017         Update to the latest java-libglom API.
2018
2019         * pom.xml: Require java-libglom 1.21.4.
2020         * src/main/java/org/glom/web/server/ConfiguredDocument.java
2021         getDocumentInfo(), getListViewLayoutGroup():
2022         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2023         getDocuments():
2024         * src/main/java/org/glom/web/server/database/DBAccess.java
2025         getFieldsToShowForSQLQueryAddGroup(),
2026         getPrimaryKeyLayoutItemField(): Replace get_database_title()
2027         with either get_database_title_original() or 
2028         get_database_title(localeID).
2029
2030 2012-01-24  Murray Cumming  <murrayc@murrayc.com>
2031
2032         ConfiguredDocument: Avoid a null pointer exception.
2033
2034         * src/main/java/org/glom/web/server/ConfiguredDocument.java
2035         Initialize localeID to "" to avoid returning a null String which 
2036         causes a crash in java-libglom's swing-generated code.
2037
2038 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
2039
2040         Some simple renaming.
2041
2042         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2043         * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
2044         for localeChooser. This seems more appropriate and is less ambiguous 
2045         particularly in the .css file.
2046
2047 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
2048
2049         ConfiguredDocument: Rename the localedID private member variable.
2050
2051 2012-01-23  Murray Cumming  <murrayc@murrayc.com>
2052
2053         Adapt to the latest java-libglom API from git master.
2054
2055         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2056         libglom now uses only Vector instead of List, which uses add() instead of
2057         addLast(). 
2058
2059 2012-01-22  Murray Cumming  <murrayc@murrayc.com>
2060
2061         ConfiguredDocument: Rename the localedID private member variable.
2062
2063 2012-01-20  Murray Cumming  <murrayc@murrayc.com>
2064
2065         Build a source tarball with mvn assembly:single
2066
2067         * assembly.xml: Add this file.
2068         * pom.xml: Use the maven-assembly-plugin and tell it to use 
2069         our assembly.xml file.
2070
2071 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
2072
2073         OnlineGlomServiceImpl: Get .glom files recursively.
2074
2075         * pom.xml: Depend on commons-io from org.apache.commons.
2076         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2077         init(): Use org.apache.commons.io.FileUtils.listFiles() to get the 
2078         files recursively, and with the easier filter for the extension.
2079         Use org.apache.commons.io.FilenameUtils.removeExtension() to 
2080         simplify that code too.
2081
2082 2012-01-19  Murray Cumming  <murrayc@murrayc.com>
2083
2084         README: Mention that you must install java-libglom packages separately.
2085
2086         But then it works, because java-libglom is now in the central maven 
2087         repository.
2088
2089 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2090
2091         locales drop-down: Show the correct selected locale when the URL changes.
2092
2093         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2094         .java: setPlace(): Move some code into fillView().
2095
2096 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2097
2098         locales drop-down: Do not lose the primary key.
2099
2100         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2101         start(): onLocaleChange(): Pass the current primary key value, 
2102         instead of an empty value.
2103
2104 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2105
2106         locales drop-down: Do not lose the drop-down selection.
2107
2108         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2109         .java (TableSelectionActivity.fillView): Set the selected locale
2110         after changing the drop-down items (though we do not really need
2111         to change them just because the locale changes.)
2112
2113 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2114
2115         locales drop-down: Change the tables list when this changes.
2116
2117         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2118         .java: TableSelectionActivity.start(): Move the async table titles
2119         retrieval into a private fillView() method and also call this when 
2120         the chosen locale changes.
2121         Note that the document title is not actually translatable yet, but
2122         that is a problem that I should fix soon in libglom.
2123
2124 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2125
2126         Improve the placement of the locales drop-down.
2127
2128         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2129         Put the title and locales drop-down in a div (gwt.FlowTable).
2130         * src/main/webapp/style.css: Add magic css properties to make this work.
2131         Also remove the left margin from the title so that it lines up with the 
2132         headerbox below it.
2133
2134 2012-01-18  Murray Cumming  <murrayc@murrayc.com>
2135
2136         locales selector: Show human-readable locale titles.
2137
2138         * src/main/java/org/glom/web/server/ConfiguredDocument.java
2139         getDocumentInfo(): Use java.util.Locale to show a real title of 
2140         each locale, in the locale's own language.
2141
2142 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
2143
2144         Add a language/locale selector drop-down.
2145
2146         * src/main/java/org/glom/web/shared/DocumentInfo.java:
2147         Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
2148         * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
2149         getDocumentInfo(): Store the available Locales in the DocumentInfo.
2150         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2151         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2152         Add a ListBox to show the available locales. Add getLocaleSelector(),
2153         setLocaleList(), getSelectedLocale(), setSelectedLocale().
2154         * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
2155         * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
2156         java: Add these classes.
2157         * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2158         start(): Fill the locales ListBox. Handle its change event, firing a 
2159         LocaleChangeEvent.
2160         setPlace(): Show the selected locale as specified by the URL token.
2161         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2162         * src/main/java/org/glom/web/client/activity/ListActivity.java:
2163         Handle LocaleChangeEvent, going to a new *Place with that locale.
2164
2165         The placement of the ListBox is not pretty, and it currently uses the ID
2166         as a title, instead of "English", "Deutsch", "Espanola", etc, but it 
2167         is a start.
2168
2169
2170 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
2171
2172         Search box: Show the search text from the URL token.
2173
2174         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2175         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2176         Add setQuickFindText().
2177         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2178         .java: setPlace(): Store the queryText if the place is a ListPlace, 
2179         and call TableSelectionView.setQuickFindText().
2180
2181 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
2182
2183         Allow use of translations via, for instance, &lang=de in the URL.
2184
2185         * pom.xml: Use the unstable java-libglom 1.21 version.
2186
2187         * src/main/java/org/glom/web/client/OnlineGlomService.java:
2188         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
2189         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2190         init(): Instead of calling TranslatableItem.set_current_locale() 
2191         (now removed), call ConfiguredDocument.setDefaultLocaleID().
2192         However, this is only for default locales, which are not needed to 
2193         change the locale in the URL.
2194         getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2195         getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2196         getSortedRelatedListData(): Add a localeID parameter, so we can get the 
2197         layout for a particular locale.
2198         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2199         Add get/setDefaultLocaleID().
2200         getDocumentInfo(), getListViewData(), getRelatedListData(),
2201         getDetailsLayoutGroup(), getListViewLayoutGroup(),
2202         createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a 
2203         localeID parameter, so we can get the layout for a particular locale.
2204
2205         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2206         * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2207         * src/main/java/org/glom/web/client/place/ListPlace.java:
2208         Parse and construct a lang parameter too.
2209
2210         * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2211         start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2212         passed to subsequent methods and constructors.
2213         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2214         * src/main/java/org/glom/web/client/activity/ListActivity.java:
2215         Store the localeID from the *Place and pass it to other constructors
2216         and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2217
2218         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2219         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2220         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2221         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2222         * src/main/java/org/glom/web/client/ui/ListView.java:
2223         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2224         Take localeID parameters and pass them to subsequent constructors and 
2225         methods, so that the layout is always retrieved for that locale.
2226
2227         This is rather repetitive.
2228
2229         Note that "" means the original (default) locale of the Glom document,
2230         which is usually English.       
2231
2232 2012-01-17  Murray Cumming  <murrayc@murrayc.com>
2233
2234         Documents: Remove final keyword to fix startup configuration.
2235
2236         * src/main/java/org/glom/web/shared/Documents.java: Remove the
2237         final keywords on the private member variables because that breaks
2238         the startup, apparently (there are warnings) because it stops them
2239         from being serialized. I added these in the previous commit.
2240
2241 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
2242
2243         Documents: Add some final keywords.
2244
2245         * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2246         this.
2247
2248 2012-01-13  Murray Cumming  <murrayc@murrayc.com>
2249
2250         OnlineGlomServiceImpl: Add to overview comments.
2251
2252         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2253         Note that this is where all the document are loaded. They are not 
2254         loaded freshly for each page.
2255
2256 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
2257
2258         Add a search box.
2259
2260         * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2261         Add a TextBox for the text of a quick find.
2262         Add getQuickFindBox(), to get the widget, and getQuickFindText() to 
2263         get the text.
2264         setBackLink(): Add a String quickFind parameter.
2265         * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2266         (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2267         to the base interface, because that is how TableSelectionViewImpl is used.
2268         * src/main/webapp/style.css: Add style for the search box and its label.
2269
2270         * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2271         * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2272         Add these files, based on the existing TableChangeEvent and 
2273         TableChangeEventHandlers.
2274         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2275         start(): Handle QuickFindChangeEvent, passing its quickFind text to
2276         a ListPlace() that the user should be taken to.
2277         * src/main/java/org/glom/web/client/activity/ListActivity.java
2278         start(): Handle it here too and adapt the TableChangeEvent handler to 
2279         pass the extra "" quickFind parameter to ListPlace.
2280         * src/main/java/org/glom/web/client/place/ListPlace.java: 
2281         Constructor: Take an extra String quickFind parameter and store it, 
2282         returning it from a new  getQuickFind() method.
2283         getToken(): Put the quickFind text in the URL token.
2284         getPlace(): Parse the quickFind text from the URL token.
2285         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2286         va: addDocumentLink(): Pass an extra "" quickFind parameter to the 
2287         ListPlace constructor.
2288         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2289         .java: start(): Add a Change handler for the TableSelectionView's
2290         TextBox (via its base HasChangeHandlers interface), firing the new 
2291         QuickFindChangeEvent.
2292         setPlace(): Adapt the call to TableSelectionView.setbackLink(), to 
2293         pass the extra "" quickFind parameter.
2294
2295         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2296         setCellTable(): Add a String quickFind parameter and pass it to 
2297         the ListViewTable() constructor.
2298         * src/main/java/org/glom/web/client/ui/ListView.java: Change 
2299         setCellTable() in the base interface, because that is how ListViewImpl
2300         is used.
2301
2302         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2303         Add a String quickFind member variable.
2304         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2305         Constructor: Add a String quickFind parameter, storing it in the
2306         base ListTable's member variable.
2307         onRangeChanged(): Pass quickFind to the 
2308         OnlineGlomServiceAsync.getSortedListViewData() and 
2309         OnlineGlomServiceAsync.getListViewData() methods.
2310
2311         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2312         getListViewData(), getSortedListViewData(): Add a String quickFind 
2313         parameter, passing it to ConfiguredDocument.getListViewData().
2314         * src/main/java/org/glom/web/client/OnlineGlomService.java:
2315         Change getListViewData(), getSortedListViewData() in the base interface,
2316         because that is how OnlineGlomServiceImpl is used, via this:
2317         * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2318         Change getListViewData(), getSortedListViewData() here too.
2319         This class can apparently be used to asynchronously call methods on 
2320         OnlineGlomService, and GWT seems to implement that after recognizing 
2321         just the *Async name convention and the extra AsyncCallback parameters.
2322
2323         * src/main/java/org/glom/web/server/ConfiguredDocument.java
2324         getListViewData(): Add a String quickFind parameter, and pass it to 
2325         ListViewDBAccess.getData().
2326         * src/main/java/org/glom/web/server/database/ListDBAccess.java
2327         getListData(): Add a String quickFind parameter and pass it to 
2328         getSelectQuery().
2329         getSelectQuery(): Add a String quickFind parameter.
2330         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2331         getSelectQuery(): Add a String quickFind parameter and use it with 
2332         Glom.get_find_where_clause_quick() to pass a where_clause to 
2333         Glom.build_sql_select_with_where_clause(), to actually filter the 
2334         list view results.
2335         getData(): Add a String quickFind parameter, passing it to getListData().
2336         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2337         va: getData(): Pass an empty string to getListData() for the 
2338         quickFind parameter.
2339
2340 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
2341
2342         ListTable: Minor change.
2343
2344         * src/main/java/org/glom/web/client/ui/list/ListTable.java
2345         createCellTable(): Make this protected instead of public.
2346
2347 2012-01-12  Murray Cumming  <murrayc@murrayc.com>
2348
2349         Many files: Use final for the parameters and use the @override attribute.
2350
2351 2012-01-22  Ben Konrath <ben@bagu.org>
2352
2353         Add anchor links for single line text that starts with http, ftp and www.
2354
2355         Bug #667269
2356
2357 2012-01-22  Ben Konrath <ben@bagu.org>
2358
2359         Add ellipsis to single line text in details view.
2360
2361         Bug #667269
2362
2363 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
2364
2365         Remove all javadoc author tags.
2366
2367         Because they are awkward and meaningless when many people touch
2368         many files.
2369         See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2370  
2371 2012-01-04  Murray Cumming  <murrayc@murrayc.com>
2372
2373         Revert the COPYING.LESSER to COPYING rename.
2374
2375         Apparently both should be there if it is LGPL.
2376
2377 2012-01-03  Murray Cumming  <murrayc@murrayc.com>
2378
2379         *View: Remove unused imports.
2380
2381         * src/main/java/org/glom/web/client/ui/DetailsView.java:
2382         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2383         * src/main/java/org/glom/web/client/ui/ListView.java:
2384         * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2385         Remove unused imports, as suggested by Eclipse.
2386
2387 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2388
2389         Move the *View::Presenter types, and some API into one base View.
2390
2391         * src/main/java/org/glom/web/client/ui/DetailsView.java:
2392         * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2393         * src/main/java/org/glom/web/client/ui/ListView.java:
2394         * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2395         Presenter, setPresenter() and clear() into a shared base interface,
2396         to avoid the unnecessary duplicate Presenter types and to more clearly
2397         show how the *Views share the same structure, even if they are not 
2398         used polymorphically.
2399
2400         * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2401         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2402         va:
2403         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2404         * src/main/java/org/glom/web/client/activity/ListActivity.java:
2405         * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2406         ity.java:
2407         * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2408         .java: Adapt.
2409
2410         Feel free to revert this if there is a good reason for the duplicate
2411         types.
2412
2413 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2414
2415         OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2416
2417         * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2418         a class member instead of a local variable in the method.
2419         This lets us use it to get the view instances, for use in tests.
2420         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2421         beforeOnlineGlom(): Test some more details of the initial view.
2422         Again, this is not very useful.
2423
2424         To really test gwt-glom we will need to start a local postgresql 
2425         instance with local data, like the Glom tests in C++.
2426
2427 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2428
2429         pom.xml: Mention the LGPL license.
2430
2431         * pom.xml: Add a licenses section.
2432         * COPYING.LESSER: Move this to COPYING, which
2433         previously contained the GPL. But gwt-glom is all LGPL.
2434
2435 2012-01-02  Murray Cumming  <murrayc@murrayc.com>
2436
2437         Add project information to README and pom.xml.
2438
2439         * README: Add a brief description and mention some mvn
2440         commands.
2441         * pom.xml: This extra information shows up in mvn site
2442         generated pages.
2443
2444 2011-01-02  Murray Cumming  <murrayc@murrayc.com>
2445
2446         Use the latest java-libglom version.
2447
2448         * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2449
2450 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2451
2452         GwtTestOnlineGlom: Test a little more.
2453
2454         * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2455         protected rather than private, as suggested by the gwt-test-utils
2456         maintianer here:
2457         http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2458         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2459         Test the initial visibility of the panels.
2460
2461         However, this is not a very useful test.
2462         And I wonder how we should generally test using this idea for an
2463         activity/places app like ours where the real changes happen implicitly
2464         based on the history token/URL.
2465
2466 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2467
2468         Slight modification to *Mapper comments.
2469
2470         * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2471         (DataActivityMapper)
2472         * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2473         pper.java
2474         * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2475         r.java
2476         Remove comments mentioning GIN because they are just copied from 
2477         the example code and are apparently not helpful:
2478         http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2479         Also change the mention of a class that is only in the example code.
2480
2481 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2482
2483         GwtTestOnlineGlom test: Minor changes.
2484
2485         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2486         Avoid the long qualified class name and modify the comment 
2487         because it is now obvious to me that the mocked class is the only
2488         custom one created via GWT.create().
2489
2490 2012-01-01  Murray Cumming  <murrayc@murrayc.com>
2491
2492         Tests: Added the beginnings of a test using gwt-test-utils.
2493
2494         * pom.xml: Add dependencies on gwt-test-utils and easymock.
2495         * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2496         which tells gwt-test-utils what class will be tested.
2497         * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2498         Add a simple (but empty) test case. One class, used by the OnlineGlom
2499         class, is mocked so that it can be created. However, I am not sure 
2500         why only this class needs to be mocked.
2501
2502         Note that mockito seems more popular, and clearer, than easymock,
2503         but I have not got that working yet. It might be a matter of the 
2504         mockito version.
2505
2506         This test is run during mvn integration-test.
2507
2508 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2509
2510         Tests: Use junit4-style syntax instead of junit3-style.
2511
2512         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2513         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2514         * src/test/java/org/glom/web/shared/DataItemTest.java:
2515         Use the @Test annotation rather than relying on the test*() prefix.
2516         Also no longer implement TestCase, to avoid triggering support for 
2517         the junit3-way, which stops the annotations from working.
2518         Change the imports from import junit.framework.* to 
2519         import org.junit.*, which is apparently the new way.
2520
2521 2011-12-31  Murray Cumming  <murrayc@murrayc.com>
2522
2523         Added a test for ListPlace token parsing and creation.
2524
2525         * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2526         This is much the same as DetailsPlaceTest.
2527
2528         I wonder how we could test the other parts of the *Place API.
2529
2530 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2531
2532         DetailsPlace test: Also test getToken() and recreation via getPlace().
2533
2534         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2535         testGetPlaceParameters(): Get the tokens from the DetailsPlace and 
2536         recreate it, testing the recreated DetailsPlace for the same parameter
2537         values.
2538
2539 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2540
2541         Use the surefire-report plugin.
2542
2543         * pom.xml: This generates a HTML report about the tests in 
2544         target/site/surefire-report.html
2545         when you do mvn surefire-report:report. It seems to be popular/normal.
2546
2547 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2548
2549         Added a test for DetailsPlace.
2550
2551         * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2552         Test the getPlace() token parsing.
2553
2554 2011-12-30  Murray Cumming  <murrayc@murrayc.com>
2555
2556         Added a first unit test.
2557
2558         * pom.xml: Add a test goal, and a dependency on junit in that scope.
2559         * src/test/java/org/glom/web/shared/DataItemTest.java:
2560         This is a silly test but it is just to get things started. Note that
2561         maven/junit finds the test because it looks in src/test by default.
2562
2563 2011-12-22  Ben Konrath  <ben@bagu.org>
2564
2565         Change charsetName to "UTF-8" when replacing line breaks.
2566
2567         JavaScript requires the charsetName to be "UTF-8". CharsetName values
2568         that work in Java (such as "UTF8") will not work when compiled to
2569         JavaScript.
2570
2571         This fixes a problem with multi-line details view fields that have hard
2572         line breaks. The "License Text" field on this page demonstrates the
2573         problem:
2574
2575         http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2576
2577         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2578
2579 2011-12-22  Ben Konrath  <ben@bagu.org>
2580
2581         Fix another bug with related list navigation.
2582
2583         I've tested all the navigation buttons in all of the related lists
2584         so things should be good now.
2585
2586         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2587
2588 2011-12-22  Ben Konrath  <ben@bagu.org>
2589
2590         Fix a crasher when refreshing the list view with the default table.
2591
2592         This crash will also happen when loading the list view with the default
2593         table from a link or bookmark.
2594
2595         * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2596         to the main document selection page when the document id hasn't been
2597         set.
2598         * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2599         the main document selection page when the document id hasn't been
2600         set.
2601         * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2602         values for the details place when the document id hasn't been set.
2603         * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2604         values for the list place when the document id hasn't been set.
2605
2606 2011-12-21  Ben Konrath  <ben@bagu.org>
2607
2608         Protect against NPE when glom.document.locale is not in config.
2609
2610         This patch protects against an NPE when glom.document.locale is not in
2611         the config file. This NPE will also happen if glom.document.locale is
2612         commented out.
2613
2614         The patch also updates the error message to display the class name when
2615         the getMessage() returns null. This was happening when the NPE was
2616         thrown and I had "Configuration Error: null". If an NPE is encountered
2617         with this patch, "Configuration Error: NullPointerException " will be
2618         displayed.
2619
2620         This commit closes this bug:
2621
2622         https://bugzilla.gnome.org/show_bug.cgi?id=666669
2623
2624         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2625
2626 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2627
2628         Rename onlineglom.properties to onlineglom.properties.sample.
2629
2630         * src/main/resources/onlineglom.properties: Rename to:
2631         * src/main/resources/onlineglom.properties.sample:
2632         * src/main/resources/README: And add this file explaining that people
2633         should rename it back when deploying.
2634
2635 2011-12-20  Murray Cumming  <murrayc@murrayc.com>
2636
2637         Allow choosing the translation in the .properties file.
2638
2639         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2640         init(): Read a glom.document.locale value from the configuration file 
2641         and call Glom's TransatableItem::set_current_locale() method.
2642         * src/main/resources/onlineglom.properties: Add a commented-out 
2643         example of this new setting.
2644
2645         It would be better to add &lang=de_DE to the URL, but the current 
2646         libglom API does not allow us to do this easily. I am working on that.
2647
2648 2011-12-19  Murray Cumming  <murrayc@murrayc.com>
2649
2650         Avoid a crash in parsing of token parameters.
2651
2652         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2653         ava: getTokenParams(): Do not crash if a parameter has a key but no 
2654         value, and ignore parameters with neither.
2655
2656 2011-12-17  Murray Cumming  <murrayc@murayc.com>
2657
2658         History token building/handling: Improve use of token parameters.
2659
2660         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java 
2661         (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2662         and buildParamsToken(HashMap), for use by derived classes.
2663         Make the separator private because it is no longer be needed.
2664         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2665         (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2666         instead of manual string concatenation.
2667         (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2668         of hardcoded indices and awkward splitting code.
2669         * src/main/java/org/glom/web/client/place/ListPlace.java
2670         (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2671         instead of manual string concatenation.
2672         (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead 
2673         of hardcoded indices and awkward splitting code.
2674         This should fix bug #666420
2675
2676 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2677
2678         Fix a Navgiation->Navigation typo in the code.
2679
2680         * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2681         Rename processNavgiation() to processNavigation().
2682
2683 2011-12-16  Murray Cumming  <murrayc@murrayc.com>
2684
2685         Fix a seperator->separator typo in the code.
2686
2687         * src/main/java/org/glom/web/client/place/DetailsPlace.java
2688         * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2689         * src/main/java/org/glom/web/client/place/ListPlace.java: Just a 
2690         misspelling.
2691
2692 2011-12-15  Ben Konrath <ben@bagu.org>
2693
2694         Cleanup some comments.
2695
2696         * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2697
2698 2011-12-14  Ben Konrath <ben@bagu.org>
2699
2700         Replace \n with <br/> for multiline text in the details view.
2701
2702         Vertical scrollbars are added when needed as well.
2703
2704         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2705
2706 2011-12-14  Ben Konrath <ben@bagu.org>
2707
2708         Specify the font for document selection links.
2709
2710         * src/main/webapp/style.css:
2711
2712 2011-12-14  Ben Konrath <ben@bagu.org>
2713
2714         Fix bouncy CellTable while paging.
2715
2716         This doesn't currently work with related list tables in unselected
2717         Notebook tabs.
2718
2719         * src/main/java/org/glom/web/client/ui/list/ListTable.java
2720
2721 2011-12-14  Ben Konrath <ben@bagu.org>
2722
2723         Revamp the appearance of the document selection page.
2724
2725         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2726         * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2727         * src/main/webapp/style.css:
2728
2729 2011-12-13  Ben Konrath <ben@bagu.org>
2730
2731         Set navigation button column to the smallest size possible.
2732
2733         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2734
2735 2011-12-13  Ben Konrath <ben@bagu.org>
2736
2737         Change OpenButton nomenclature to NavigationButton.
2738
2739         Using NavigtionButton makes things more generic. Classes, methods and
2740         variables have been changed.
2741
2742         This is a rename-only refactor.
2743
2744         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2745         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2746         * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2747         Renamed from OpenButtonCell.
2748         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2749         * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2750         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2751
2752 2011-12-12  Ben Konrath <ben@bagu.org>
2753
2754         Remove unnecessary String argument in RelatedListTable and ListViewTable.
2755
2756         * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2757         * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2758         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2759         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2760
2761 2011-12-12  Ben Konrath <ben@bagu.org>
2762
2763         Update variable names and comments.
2764
2765         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2766         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2767
2768 2011-12-12  Ben Konrath <ben@bagu.org>
2769
2770         Properly initialize numNonEmptyRows variable to zero.
2771
2772         * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2773         * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2774
2775 2011-12-05  Ben Konrath  <ben@bagu.org>
2776
2777         Add latest mockup with HTML tables.
2778
2779         Features of this mockup:
2780
2781         -> HTML table for flowtable
2782         -> HTML table for flowtable column
2783         -> Example of how related lists would look
2784         -> Not using text entries for data items
2785
2786         The current version of Online Glom doesn't use HTML tables for the
2787         flowtable columns.
2788
2789         This mockup has been sent to the glom-devel mailing list but it's good
2790         to have it here as well.
2791
2792         * mockups/details-view-html-tables.html:
2793
2794 2011-12-05  Ben Konrath  <ben@bagu.org>
2795
2796         Remove unnecessary getPrimaryKeyField() method.
2797
2798         getPrimaryKeyFieldForTable(String) has been renamed to
2799         getPrimaryKeyField(String).
2800
2801         * src/main/java/org/glom/web/server/database/DBAccess.java:
2802         * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2803         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2804
2805 2011-12-05  Ben Konrath  <ben@bagu.org>
2806
2807         Add string representation of TypedDataItem value to conversion error message.
2808
2809         * src/main/java/org/glom/web/server/Utils.java: Logging the error
2810         message was extracted into its own method to avoid duplication.
2811
2812 2011-12-05  Ben Konrath  <ben@bagu.org>
2813
2814         Add type checking to navigation primary key value creation.
2815
2816         Create navigation primary key only if the expected type from the Glom
2817         document matches the type returned by the SQL query.
2818
2819         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2820
2821 2011-12-05  Ben Konrath  <ben@bagu.org>
2822
2823         Rename a couple of variables in RelatedListNavigation.
2824
2825         This is a rename-only refactor.
2826
2827         * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2828
2829 2011-12-05  Ben Konrath  <ben@bagu.org>
2830
2831         Move getListLayoutGroup() into getListViewLayoutGroup().
2832
2833         This removes getListLayoutGroup(). It was only being called by
2834         getListViewLayoutGroup().
2835
2836         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2837
2838 2011-12-05  Ben Konrath  <ben@bagu.org>
2839
2840         Remove check for LayoutItem_Portal in list table method.
2841
2842         This check is no longer necessary because the method isn't being used
2843         to create the LayoutItemPortal DTO.
2844
2845         * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2846
2847 2011-12-05  Ben Konrath  <ben@bagu.org>
2848
2849         Properly support related list navigation.
2850
2851         Navigation from the "Repository Analyzer -> Package Scans ->
2852         Dependencies" related table wasn't working because the primary key for
2853         related tables wasn't being set properly. This commit fixes the
2854         problem.
2855
2856         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2857         getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2858         doesn't set the primary key properly for related list tables.
2859         * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2860         name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2861         useful for getting the primary key for list view tables and for related
2862         list tables.
2863         * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2864         * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2865         Move code to set the primary key for the table from the abstract
2866         ListDBAccess class to ListViewDBAccess as it's only correct for list
2867         view tables.
2868         * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2869         Properly add primary key to related list tables.
2870
2871 2011-12-02  Ben Konrath  <ben@bagu.org>
2872
2873         Properly set the horizontal alignment of fields.
2874
2875         This fix is for both the list tables and the details view.
2876
2877         * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2878         LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2879         to set the horizontal alignment of fields.
2880
2881 2011-12-02  Ben Konrath  <ben@bagu.org>
2882
2883         Display currency codes in the details view.
2884
2885         * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2886