1 2012-05-23 Murray Cumming <murrayc@murrayc.com>
3 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
5 * src/test/java/org/glom/web/server/SelfHoster.java:
6 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
7 instance) instead of just /usr/bin (as on Fedora). Check the result when
10 2012-05-23 Murray Cumming <murrayc@murrayc.com>
12 Remove LayoutItemPortal.get/setNavigationTable().
14 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
15 Remove get/setNavigationTable(), which is only a cache, because it is not
16 used, and does not need to be used, because that decision should be made on
18 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
19 updatePortalsExtras():
20 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
21 getNavigationRecord():
22 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
25 2012-05-21 Murray Cumming <murrayc@murrayc.com>
27 Initial self-hosting for tests.
29 * pom.xml: Change the scope for log4j, to hopefully make it
30 available to the test code which uses it indirectly via jOOQ.
31 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
32 self-hosting, though we only use it for testing.
34 * src/main/java/org/glom/web/server/libglom/Document.java:
35 example rows: Use a map instead of a list for each row of values,
36 so we know what field they are for, instead of relying on the sequence
37 being correct. This is not very efficient, but it does not really need
39 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
40 testReadTableExampleRows(): Adapted.
42 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
43 that returns an Object, for generic use. Note that Object seems to be
44 the implicit base even of double.
45 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
46 for use in CREATE TABLE SQL queries.
47 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
48 to do self-hosting of PostgreSQL databases via its command-line
49 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
50 backends/postgres_self.cc. This is incomplete - it needs more
51 warnings about failures and it needs to clean up properly when things
53 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
54 test of this new class.
56 2012-05-21 Murray Cumming <murrayc@murrayc.com>
58 Document: loading example data: Handle exceptions.
60 * src/main/java/org/glom/web/server/libglom/Document.java:
61 DateFormat.parse() and Double.valueOf() can throw exceptions, though
62 Eclipse did not warn about that.
64 2012-05-20 Murray Cumming <murrayc@murrayc.com>
66 Document: load(), save(): Handle the example rows.
68 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
70 * src/main/java/org/glom/web/server/libglom/Document.java:
71 load(), save(): Load and save the example rows, though the date, time
72 and image types are not handled properly yet.
73 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
74 Add testReadTableExampleRows() just to check that something is read.
76 2012-05-20 Murray Cumming <murrayc@murrayc.com>
80 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
81 Added getTranslationsMap() for use while saving.
82 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
83 Adedd getUseDefaultFormatting() for use while saving.
84 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
85 and several private methods that it uses.
87 This will be useful while testing via self-hosting.
88 It is not complete, but should be complete enough for testing.
90 2012-05-17 Murray Cumming <murrayc@murrayc.com>
92 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
94 * src/main/java/org/glom/web/client/OnlineGlomService.java
95 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
96 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
97 Remove getSortedListViewData() and getSortedRelatedListData(), adding
98 the sort column index and ascending bool to the regular method.
99 Instead, a sort column index of -1 now means no sort.
100 This is less explicit, but it's fairly simple, reduces the amount of
101 code, and makes the OnlineGlomService API slightly smaller.
102 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
103 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
105 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
106 getListViewData(), getRelatedListData():
107 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
108 getListViewData(), getRelatedListData():
109 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
111 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
113 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
118 2012-05-16 Murray Cumming <murrayc@murrayc.com>
120 Use translations for top-level groups too.
122 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
123 updateTitlesForLocale(): Use the translation for the group
124 as well as for child items.
128 Just recompiled to fix a problem in the released .tar.gz file.
132 2012-05-15 Murray Cumming <murrayc@murrayc.com>
134 Corrections to navigation to related records.
136 * src/main/java/org/glom/web/client/OnlineGlomService.java:
137 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
138 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
139 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
140 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
141 relationship name, because the relationship name is not necessarily unique
143 TOOD: This is inefficient, because it passes the whole list of
144 child field items back to the server, but it is more correct, and happens
145 to fix a bug with the primary key being lost after a few navigations.
146 There is probably a chance to make this more efficient anyway in some
149 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
150 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
151 * src/main/java/org/glom/web/server/ConfiguredDocument.java
152 * src/main/java/org/glom/web/server/database/DBAccess.java
153 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
154 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
157 2012-05-15 Murray Cumming <murrayc@murrayc.com>
159 Fix the use of translations.
161 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
162 Add updateTitlesForLocale().
163 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
164 Call it to discard unwanted translations and to make getTitle() return
165 the wanted translation wihout the need for the client code to specify a locale.
166 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
167 getTitle(): Fallback to the original title, as libglom does.
169 2012-05-15 Murray Cumming <murrayc@murrayc.com>
171 Document: Correctly report the number of available translation locales.
173 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
174 the available locale IDs list.
175 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
176 testLocales: Test this.
178 2012-05-15 Murray Cumming <murrayc@murrayc.com>
180 SqlUtils: Use camelCase.
182 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
183 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
184 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
185 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
186 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
187 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
189 2012-05-15 Murray Cumming <murrayc@murrayc.com>
191 Use jOOQ's tableByName() and fieldByName.
193 * pom.xml: Use jOOQ 2.3.1 to get the new API.
194 * src/main/java/org/glom/web/server/SqlUtils.java:
195 build_sql_select_step_with_where_clause(), .createField(),
196 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
197 so we can get correct quoting and escaping. Thanks to Lukas Eder for
198 adding this, and other things, to jOOQ.
200 2012-05-15 Murray Cumming <murrayc@murrayc.com>
202 SqlUtils: Remove the Connection parameters.
204 * src/main/java/org/glom/web/server/SqlUtils.java:
205 build_sql_select_with_key(), build_sql_select_with_where_clause(),
206 createSelect(), build_sql_select_step_with_where_clause(),
207 build_sql_count_select_with_where_clause(),
208 build_sql_select_count_rows(): Remove the Connection parameter because
209 jOOQ does not actually need a connectionwhen it is just used to build
211 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
213 * src/main/java/org/glom/web/server/ReportGenerator.java:
215 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
217 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
218 Constructor, getListData(), getResultSizeOfSQLQuery():
219 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
220 getSelectQuery(), getCountQuery():
221 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
222 getSelectQuery(), getCountQuery():
223 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
224 getNavigationRecord(): Adapted.
226 2012-05-14 Murray Cumming <murrayc@murrayc.com>
230 * src/main/java/org/glom/web/server/SqlUtils.java:
231 get_find_where_clause_quick(): Use a comparison of
232 lowercase values, instead of a simple equals. Regular Glom
233 uses the PostgreSQL ILIKE operator but jOOQ does not
234 support that just yet, though it will soon.
236 2012-05-14 Murray Cumming <murrayc@murrayc.com>
238 TableToViewDetails: Use a real serialization ID.
240 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
241 Though this does not fix the serialization problem.
243 2012-05-12 Murray Cumming <murrayc@murrayc.com>
245 Added LayoutItemPortalDeepCloneTest.
247 2012-05-11 Murray Cumming <murrayc@murrayc.com>
249 Make navigation work again.
251 * src/main/java/org/glom/web/server/libglom/Document.java:
252 Add getLayoutItemFieldShouldHaveNavigation().
253 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
254 Replace get/setAddNavigation() with the partly-existing
255 get/setNavigationTableName(), with an empty string being no navigation,
256 because this is simpler. Use the new
257 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
259 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
260 Add updateFieldsExtras() and call setNavigationTableName in it.
261 getDetailsLayoutGroup(),
262 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
263 createLayout(): Adapted.
264 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
265 Constructor: Adapted.
267 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
268 Replace get/setAddNavigation() with get/setNavigation(), returning a
269 TableToViewDetails class with both the table name and UsesRelationship,
270 because both are need. The previous code used java-libglom's output
271 variable (strangely, via sharedptr) to return both, but we cannot really
273 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
274 getNavigationRecord(): Adapt. However, we cannot actually use the cache
275 here because it somehow gets set to null during deepCopy(). I must test this.
276 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
277 testGetSuitableTableToViewDetails(): Adapted.
279 TODO: Find out why deepClone() is not quite working.
281 2012-05-11 Murray Cumming <murrayc@murrayc.com>
283 DBAccess: Simplify the retrievel of full field details.
285 * src/main/java/org/glom/web/server/database/DBAccess.java
286 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
287 because the Document loading should have done this.
289 2012-05-11 Murray Cumming <murrayc@murrayc.com>
291 Document: Correct loading of doubly-related layout fields.
293 * src/main/java/org/glom/web/server/libglom/Document.java:
294 loadUsesRelationship(): Actually set the related relationship, instead
295 of only setting it if it's not found.
297 2012-05-09 Murray Cumming <murrayc@murrayc.com>
299 Replace all appearances of Colour with color.
301 Because US English is dominant.
303 2012-05-09 Murray Cumming <murrayc@murrayc.com>
305 Use colors in HTML format, solving a warning about an unused function.
307 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
308 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
309 Add *asHTMLColor() versions of methods.
310 TODO: However, we should create and cache the results on the server.
311 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
312 * src/main/java/org/glom/web/client/ui/list/ListTable.java
313 * src/main/java/org/glom/web/server/ConfiguredDocument.java
314 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
315 Use the asHTMLcolor() versions.
317 2012-05-09 Murray Cumming <murrayc@murrayc.com>
319 ListViewTable: Constructor: Take the table name as a parameter.
321 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
322 Constructor: Take the tableName, and set the member variable, because
324 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
325 setCellTable(): Pass the table name.
326 This makes navigation to non-default tables work again. I don't know
327 why it worked before in the master branch.
329 2012-05-07 Murray Cumming <murrayc@murrayc.com>
331 ConfiguredDocument: Restore correct addition of hidden primary key items.
333 * src/main/java/org/glom/web/client/ui/list/ListTable.java
334 (ListTable.createCellTable): Uncomment out the check for the hidden
336 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
337 add primary key items for top-level lists and portals, as before,
338 instead of adding them to each group.
339 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
340 Actually implement the extra methods such as setHiddenPrimaryKey() and
341 comment that these are used only for top-level list groups and in portals.
342 This strangeness suggests even more that this should not be squeezed
343 into the LayoutGroup class.
345 2012-05-07 Murray Cumming <murrayc@murrayc.com>
347 Fix Formatting loading.
349 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
350 getFormattingUsed(): Remove the duplicate Formatting member variable
351 in favour of the one from the base class.
352 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
353 Initialize a new Formatting instead of using null by default, so we
354 have some defaults, instead of having to initialize one later just to
355 get the same defaults. This also makes loading of formatting from the
356 document work, because that expected a non-null.
358 2012-05-07 Murray Cumming <murrayc@murrayc.com>
360 RelatedListTable: Make sure that the tableName is set.
362 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
363 Constructor: Take the tableName so it is available later. Otherwise,
364 the server assumes that we mean the default table and cannot find the
366 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
367 setData(): Pass the tableName to the RelatedListTable constructor.
369 2012-05-07 Murray Cumming <murrayc@murrayc.com>
373 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
374 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
375 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
377 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
379 * src/main/java/org/glom/web/server/database/DBAccess.java:
380 convertResultSetToDTO(), getPortal():
381 * src/main/java/org/glom/web/server/database/ListDBAccess.java
383 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
384 Add checks for null objects and out of range access, with log messages to
385 give hints so we can fix these properly.
387 2012-05-07 Murray Cumming <murrayc@murrayc.com>
389 Portals: some corrections.
391 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
393 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
394 constructor: Use getRelationshipNameUsed() instead of getName(), because
395 that is what is meant.
396 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
397 getFromField(): Fix a typo, to get the field name, not the table name.
398 * src/main/java/org/glom/web/server/database/DBAccess.java:
399 getPortal(): Fix a typo that stopped this from working.
401 2012-05-07 Murray Cumming <murrayc@murrayc.com>
403 LayoutItemPortal: Also override getTitleOriginal().
405 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
406 This lets the base getTitle() with no parameters work.
407 TODO: Test this properly.
409 2012-05-06 Murray Cumming <murrayc@murrayc.com>
411 LayoutItemPortal: getTitle*(): Use the relationship title.
413 2012-05-06 Murray Cumming <murrayc@murrayc.com>
415 LayoutItemField: Fix loading of custom titles.
417 * src/main/java/org/glom/web/server/libglom/Document.java
418 loadDataLayoutItemField(): The title, if any, instead of the field
419 title, is stored in a title_custom node. Load it from there.
420 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
422 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
423 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
424 getTitle*() overrides.
425 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
428 2012-05-06 Murray Cumming <murrayc@murrayc.com>
430 LayoutItemField: Fall back to field titles, so some are really shown.
432 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
433 Override getTitleOriginal() and getTitle(), as in java-libglom.
434 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
437 2012-05-06 Murray Cumming <murrayc@murrayc.com>
439 Correct use of setExpectedResultSize().
441 * src/main/java/org/glom/web/server/ConfiguredDocument.java
442 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
443 Use setExpectedResultSize only on top-level groups (for instance, the
444 list layout) or on child portals (in details views).
445 Use the correct table name for portals to avoid SQL errors.
446 Update the expected counts when returning cached layouts.
448 2012-05-06 Murray Cumming <murrayc@murrayc.com>
450 Document: Interpret no group column count as 1.
452 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
453 default, though we now check for this in the UI code anyway.
455 2012-05-06 Murray Cumming <murrayc@murrayc.com>
459 2012-05-06 Murray Cumming <murrayc@murrayc.com>
461 Translatable: Use Hashmap instead of Treemap because GWT supports it.
463 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
464 The use of Treemap lead to this error from async methods, with no
466 "The response could not be deserialized"
468 2012-05-06 Murray Cumming <murrayc@murrayc.com>
470 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
472 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
473 when using the Google -> GWT Compile, or
474 g toolbar button -> GWT Compile Project... feature in Eclipse.
476 2012-05-06 Murray Cumming <murrayc@murrayc.com>
478 ListTable.addColumn(): Protect against a null Formatting.
480 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
481 Create a default Formatting if it is null, because that is the simplest
484 2012-05-06 Murray Cumming <murrayc@murrayc.com>
486 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
488 * src/main/java/org/glom/web/server/ConfiguredDocument.java
489 updateLayoutGroup(): Check that the field is not null.
491 2012-05-06 Murray Cumming <murrayc@murrayc.com>
493 ListViewImpl: Protected against a bad cast error.
495 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
496 onEnterKeyDown(): Do not cast without an instanceof check.
498 2012-05-06 Murray Cumming <murrayc@murrayc.com>
500 ListTable: Protect against an out of range error.
502 * src/main/java/org/glom/web/client/ui/list/ListTable.java
503 createCellTable(): This is unlikely, but can happen while debugging.
505 2012-05-06 Murray Cumming <murrayc@murrayc.com>
507 AsyncMessage onFailure() callbacks: Log the exception message.
509 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
510 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
511 * src/main/java/org/glom/web/client/activity/ListActivity.java:
512 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
513 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
514 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
515 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
516 These are useful clues when something is wrong.
518 2012-05-06 Murray Cumming <murrayc@murrayc.com>
520 ConfiguredDocument: Avoid a null dereference.
522 * src/main/java/org/glom/web/server/ConfiguredDocument.java
523 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
524 details maps are created.
526 2012-05-06 Murray Cumming <murrayc@murrayc.com>
528 Document: Correct the port number parsing.
530 * src/main/java/org/glom/web/server/libglom/Document.java:
531 This lets us actually connect to the database and show the document.
533 2012-05-05 Murray Cumming <murrayc@murrayc.com>
537 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
538 user-interaction, asking us to load a temporary URL in a browser.s
539 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
540 which is apparently necessary for testing the service. See the comment.
541 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
542 Show the exception, if any. This is how I saw the 404 in the HTML in
545 2012-05-05 Murray Cumming <murrayc@murrayc.com>
547 DocumentTest: Move the .glom files into the resources directory.
549 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
550 URI via getResource().
552 2012-05-05 Murray Cumming <murrayc@murrayc.com>
554 Document: Remove the FieldIdentifies inner class.
556 * src/main/java/org/glom/web/server/libglom/Document.java: We only
557 use the Relationship (though the same function in libglom is maybe
558 used in other ways) and so this removes a compiler warning.
560 2012-05-05 Murray Cumming <murrayc@murrayc.com>
562 Document.load() Remove the error code parameter.
564 * src/main/java/org/glom/web/server/libglom/Document.java: load():
565 Remove the parameter. We do not set it yet and it could never have
566 worked as an output parameter (though maybe it did in java-libglom).
567 We could use an exception if we really want the failure reason.
568 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
570 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
571 setUp(), testGetSuitableTableToViewDetails(): Adapt.
573 2012-05-05 Murray Cumming <murrayc@murrayc.com>
575 Make some inner classes static.
577 * src/main/java/org/glom/web/server/ConfiguredDocument.java
578 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
579 * src/main/java/org/glom/web/server/ReportGenerator.java
580 * src/main/java/org/glom/web/server/libglom/Document.java
581 Make all inner classes static that can be static.
583 2012-05-05 Murray Cumming <murrayc@murrayc.com>
585 OnlineGlomServiceImpl: Do not load and check for java-libglom.
587 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
588 init(): We do not use java-libglom any more.
590 2012-05-05 Murray Cumming <murrayc@murrayc.com>
592 Remove mentions of java-libglom.
594 * README: Remove mention of java-libglom, because it no longer needed.
595 * utils/build-onlineglom-war.sh:
596 * utils/check-and-recover-tomcat.py:
597 * utils/install-onlineglom-war.sh: Remove these as they are no longer
598 useful. Building is now far easier, with no need for jhbuild.
600 2012-05-05 Murray Cumming <murrayc@murrayc.com>
602 Fix the build (mvn package)
604 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
605 (LayoutGroup): Make the LayoutItemList inner class static and protected.
606 Otherwise the GWT Java->Javascript compilation fails with just this
607 error, during mvn package or when attempting to view in a browser,
608 in the GWT developer mode in Eclipse.
610 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
611 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
612 [INFO] Compiling module org.glom.web.OnlineGlom
613 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
614 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
615 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
616 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
617 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
618 [INFO] [ERROR] Cannot proceed due to previous errors
620 It has taken me 2 days to find out what was causing that. After reducing
621 the code, the compiler eventually showed me the full error message.
623 2012-05-04 Murray Cumming <murrayc@murrayc.com>
625 ConfiguredDocument: Cache the cloned and stripped layouts.
627 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
628 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
629 layout in a map, so we can retrieve it again without rebuilding it.
631 2012-05-04 Murray Cumming <murrayc@murrayc.com>
633 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
635 2012-05-04 Murray Cumming <murrayc@murrayc.com>
637 libglom classes: Implement some auto-generated emthods.
639 2012-05-04 Murray Cumming <murrayc@murrayc.com>
641 Add GwtTestOnlineGlomService.
643 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
644 However, this (and the other GwtTest*) does not seem to run during
647 2012-05-04 Murray Cumming <murrayc@murrayc.com>
649 Remove use of unsupported features from client code.
651 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
652 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
653 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
654 Use our client version of StringUtils instead of the apache commons one.
656 However, the GWT Javascript compliation still fails.
658 2012-04-25 Murray Cumming <murrayc@murrayc.com>
660 Add a Field class and implement some loading of it in Document.
662 2012-04-25 Murray Cumming <murrayc@murrayc.com>
664 Initial Document loading implementation, instead of libglom.
666 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
667 and Translatable classes, and adapt the rest of the code to use them.
668 However, this is still missing Layout and Field classes and loading.
670 2012-04-24 Murray Cumming <murrayc@murrayc.com>
672 Use of jOOQ: Move Field creation into a utility method.
674 * src/main/java/org/glom/web/server/SqlUtils.java:
675 This lets us improve it more easily.
677 2012-04-24 Murray Cumming <murrayc@murrayc.com>
679 Use of jOOQ: Improve the code to COUNT a sub-select.
681 * src/main/java/org/glom/web/server/SqlUtils.java:
682 Move initial query creation into
683 build_sql_select_step_with_where_clause().
684 build_sql_select_count_rows(): Use the jOOQ API instead of
685 concatentating text, because a jOOQ Select*Step is a TableLike,
686 which is what from() takes.
688 2012-04-23 Murray Cumming <murrayc@murrayc.com>
690 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
692 * pom.xml: Depend on jooq.
693 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
694 methods with jOOQ, based on the C++ implementations in libglom,
695 with some changes to the logic required by jooQ.
696 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
698 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
699 * src/main/java/org/glom/web/server/ReportGenerator.java:
700 * src/main/java/org/glom/web/server/SqlUtils.java:
701 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
702 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
703 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
704 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
705 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
706 Adapt. In particular, the SqlUtils methods now need to take a Connection,
707 because jOOQ needs that, though it seems unnecessary.
709 This is not quite finished. Ideally jOOQ would help us to build
710 table_name.field_name names, quoting and escaping them properly.
711 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
713 2012-04-21 Murray Cumming <murrayc@murrayc.com>
715 Move use of Glom.build_sql*() into a new SqlUtils class.
717 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
718 to wrap Glom.build_sql*(). The parameter types are still Glom one,
719 but this will make it easier to start using something other than
720 libglom or SqlBuilder.
722 2012-04-21 Murray Cumming <murrayc@murrayc.com>
724 Update the project URL.
726 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
728 2012-04-21 Murray Cumming <murrayc@murrayc.com>
730 Main layout: Use a FlowTable instead of absolute positioning.
732 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
733 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
734 child panels/widgets must have an absolute position. But that is annoying, so
735 this adds a FlowTable and puts the child panels in there.
737 2012-04-21 Murray Cumming <murrayc@murrayc.com>
739 GwtTestOnlineGlom: Comment out unused code.
741 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
742 Eclipse has started to say that some code is unused.
744 2012-04-21 Murray Cumming <murrayc@murrayc.com>
746 Update to the latest versions of dependencies.
748 * pom.xml: Update version numbers of dependencies to the latest
750 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
751 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
752 * src/main/java/org/glom/web/server/ReportGenerator.java:
753 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
754 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
755 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
757 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
758 Modify the imports where necessary.
760 2012-04-17 Murray Cumming <murrayc@murrayc.com>
762 Style: Remove overflow:hidden from searchbox
764 * src/main/webapp/style.css: Because this pushes the Back To Link
765 label/link on to the next row, which is then hidden due to the
766 hard-coded (in ems) height.
768 2012-04-20 Murray Cumming <murrayc@murrayc.com>
770 Remove some duplicate code.
772 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
773 getDocumentInfo(): This must have been duplicated during the merge from the
778 2012-04-19 Murray Cumming <murrayc@murrayc.com>
780 Reports: Localize the waiting for report message.
782 * src/main/java/org/glom/web/client/activity/ReportActivity.java
783 start(): Get the message from the contants.
784 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
786 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
787 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
788 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
789 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
790 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
791 Update these files with the English text for newer strings for now.
793 2012-04-19 Murray Cumming <murrayc@murrayc.com>
795 Reports: Show a message while waiting for the report.
797 * src/main/java/org/glom/web/client/ui/ReportView.java
798 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
799 Add setWaitingText(), to show a message saying that we are
800 waiting for the report to be ready.
801 * src/main/java/org/glom/web/client/activity/ReportActivity.java
802 start(): Call setWaitingText() before calling the async
805 2012-04-19 Murray Cumming <murrayc@murrayc.com>
807 ReportGenerator: Specify date and time formats.
809 * src/main/java/org/glom/web/server/ReportGenerator.java:
810 createFieldValueElement(): Use the default (and localized)
811 short formats, though we still need a way to show 4-digit
812 years without providing the format for every locale.
813 * src/main/java/org/glom/web/server/database/DBAccess.java:
814 convertResultSetToDTO(): Use the short formats here too.
816 2012-04-18 Murray Cumming <murrayc@murrayc.com>
818 ReportGenerator: Use the correct numeric formatting.
820 * src/main/java/org/glom/web/server/ReportGenerator.java
821 createFieldExpression(), createFieldValueElement(): Take the
822 whole LayoutItem_Field instead of just the field name, so
823 we have access to the formatting.
824 createFieldValueElement(): Use JRTextField.setPattern() to
825 specify the numeric formatting, with the help of a
826 regular DecimalFormat.
828 2012-04-18 Murray Cumming <murrayc@murrayc.com>
830 ReportGenerator: Avoid showing null for group by titles.
832 * src/main/java/org/glom/web/server/ReportGenerator.java
833 generateReport(): Use setBlankWhenNull() on the field title
834 style too, because this is used for values in group by
837 2012-04-18 Murray Cumming <murrayc@murrayc.com>
839 ReportGenerator: Add a colon to titles in vertical groups.
841 * src/main/java/org/glom/web/server/ReportGenerator.java
842 addFieldToDetailBandVertical(): Pass true for the withColon
845 2012-04-18 Murray Cumming <murrayc@murrayc.com>
847 ReportGenerator: Simplify the code by using Position more.
849 2012-04-18 Murray Cumming <murrayc@murrayc.com>
851 Reports: Support vertical groups, roughly.
853 * src/main/java/org/glom/web/server/ReportGenerator.java:
854 addToReport(): Rename to addGroupToReport() and, if necessary,
855 call the new addVerticalGroupToReport() method.
856 createFieldValueElement(): Let the caller specify the Y position
859 2012-04-17 Murray Cumming <murrayc@murrayc.com>
861 Reports: Allow a second report to be shown.
863 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
864 clear(): Do not remove the HTML widget, which broke the whole layout.
866 2012-04-17 Murray Cumming <murrayc@murrayc.com>
868 Locales drop-down: Show that we use English by default.
870 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
871 fillView(): When we use English, just because that is the default, when
872 no locale is specified, show that in the Locales drop-down instead of
873 just showing the first item.
875 2012-04-17 Murray Cumming <murrayc@murrayc.com>
877 Unselect the Report/Locale/Table combo item when appropriate.
879 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
880 setPlace(): clear reportName if this is not a ReportPlace.
881 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
882 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
883 When the provided name is empty, unselect all items, so that none are
884 indicated. This uses a for loop because I cannot find a single method
887 2012-04-17 Murray Cumming <murrayc@murrayc.com>
889 Report: Give the user a way to get back to the list.
891 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
892 start(), setPlace(): Show the Back To List link on reports, and also
893 interpret selecting the empty report item as back to list.
895 2012-04-13 Murray Cumming <murrayc@murrayc.com>
897 Really show the selected Report name.
899 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
900 setPlace(): Store the reportName here, if it is that kind of Place.
901 fillView(): Set the selected Report after filling the list of reports.
902 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
903 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
904 null Strings, though we need some way to unselect all ListBox items
907 2012-04-13 Murray Cumming <murrayc@murrayc.com>
909 ReportGenerator: Try to avoid some problems.
911 * src/main/java/org/glom/web/server/ReportGenerator.java
912 addField(): Try to avoid duplicates, and avoid using a null
915 2012-04-13 Murray Cumming <murrayc@murrayc.com>
917 Reports: Use quickFind.
919 * src/main/java/org/glom/web/client/OnlineGlomService.java;
920 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
921 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
922 getReportHTML(): Add a quickFind parameter.
923 * src/main/java/org/glom/web/client/activity/ReportActivity.java
924 start(): Pass the quickFind parameter.
925 * src/main/java/org/glom/web/server/ReportGenerator.java
926 generateReport(): Take a quickFind parameter.
928 2012-04-13 Murray Cumming <murrayc@murrayc.com>
930 ReportPlace: Actually use the report name.
932 * src/main/java/org/glom/web/client/place/ReportPlace.java
933 getPlace(): Do not assign the report name to the quickfind.
935 2012-04-13 Murray Cumming <murrayc@murrayc.com>
937 Show java.library.path when complaining.
939 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
940 init(): When telling us to check java.library.path, show the
943 2012-03-06 Murray Cumming <murrayc@murrayc.com>
945 ReportGenerator: Do not show nulls.
947 2012-03-06 Murray Cumming <murrayc@murrayc.com>
949 ReportGenerator: Make the title font larger.
951 2012-03-06 Murray Cumming <murrayc@murrayc.com>
953 ReportGenerator: Put field titles inside groups, if there are groups.
955 2012-03-06 Murray Cumming <murrayc@murrayc.com>
957 ReportGenerator: Take the Report itself instead of the name and group.
959 * src/main/java/org/glom/web/server/ConfiguredDocument.java
960 Remove getReportLayoutGroup().
961 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
962 getReportHTML(): Pass the report instead
963 of its name and layout group.
964 * src/main/java/org/glom/web/server/ReportGenerator.java
965 generateReport(): Use the report object to use the title
968 2012-03-06 Murray Cumming <murrayc@murrayc.com>
970 ReportGenerator: Remove designBand parameters.
972 * src/main/java/org/glom/web/server/ReportGenerator.java:
973 Make designBand a class member instead of passing it to all
976 2012-03-06 Murray Cumming <murrayc@murrayc.com>
978 ReportGenerator: Add lines, a bit like in the desktop version.
980 * src/main/java/org/glom/web/server/ReportGenerator.java
981 addToReport(): Use JRDesignLine.
983 2012-03-06 Murray Cumming <murrayc@murrayc.com>
985 ReportGenerator: Correct the title positions and use some bold style.
987 * src/main/java/org/glom/web/server/ReportGenerator.java:
988 Break the code up into reusable functions, correct the placement of
989 titles, and use normal/bold styles as in the reports in the desktop
992 2012-03-06 Murray Cumming <murrayc@murrayc.com>
994 ReportGenerator: Add a header band to show the field titles.
996 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
997 getReportHTML(): Pass the localeId to the ReportGenerator
999 * src/main/java/org/glom/web/server/ReportGenerator.java
1000 constructor: Take the localeID so we can get translated field
1002 generateReport(), addToReport(), addFieldToBand(): Add field
1003 titles in a column header band.
1005 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1007 Reports drop-down list: Some improvement.
1009 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1010 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1011 Adedd setSelectedReport(),
1012 setReportList(): Add a blank line so that the user can select the
1014 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1015 start(): Show the current report by calling setSelectedReport().
1016 This does not seem to work yet.
1018 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1020 DetailsActivity, ListActivity: Move some variables into a base class.
1022 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1023 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1024 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1025 the clientFactory, documentID, tableName and authenticationPopup into
1026 a base class, to avoid duplication.
1028 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1030 Translate the Reports label.
1032 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1033 Get the "Reports" label string from the constants.
1034 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1035 perties: Add Reports to the constants.
1037 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1039 Reports: Implement grouping.
1041 * src/main/java/org/glom/web/server/ReportGenerator.java:
1042 Handle LayoutItem_GroupBy items and try to do the right thing
1043 with JRDesignGroup. It seems to work.
1045 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1047 Actually show some data with JasperReports.
1049 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1050 getReportHTML(): Move most code into a ReportGenerator class.
1051 * src/main/java/org/glom/web/server/ReportGenerator.java:
1052 Recurse into sub-groups, adding fields to the JasperDesign's details
1053 band. Note that we must set an arbitrary width and height, or it just
1054 will not show any data.
1056 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1058 Reports Chooser: Show the titles, not the names.
1060 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1061 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1062 and the names as the values.
1063 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1064 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1065 group now that we provide the report name, so it should always
1068 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1070 Depend on jasperreports.
1072 * pom.xml: Add the dependency. My plan is to use this on the
1075 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1077 Implement navigation to report places.
1079 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1080 start(): Do not bother to handle all events here.
1081 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1082 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1083 Added getSelectedReport().
1084 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1085 .java: start(): When handling a change to the reports chooser,
1086 call getSelectedReport() and goTo() its ReportPlace.
1087 * src/main/java/org/glom/web/client/ui/ReportView.java
1088 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1089 Added setReportHTML() which puts the html in a gwt HTML widget.
1090 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1091 getReportHTML(): Return "TODO" just to show that this works.
1093 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1095 Make ReportPlace usable.
1097 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1098 Mention ReportPlace.
1099 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1100 Correct the @prefix annotation.
1102 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1104 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1106 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1107 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1108 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1109 Change getReportLayout() to getReportHMTL() because we will not need to
1110 parse or render the report layout on the client side.
1111 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1112 getReportLayout(): Return the libglom LayoutGroup type because we will
1113 not need to convert to a shared type, because this will not be used on
1115 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1118 Note that there is still no implementation for this.
1121 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1123 Add a (empty) Report Place, View, and Activity.
1125 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1127 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1128 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1129 this into a superclass:
1130 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1131 and also use it as the base of this new ReportPlace:
1132 * src/main/java/org/glom/web/client/place/ReportPlace.java
1134 * src/main/java/org/glom/web/client/ui/ReportView.java
1135 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1136 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1137 Add these, containing mostly boiler-plate for now.
1139 * src/main/java/org/glom/web/client/OnlineGlomService.java
1140 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1141 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1143 Add API to get the LayoutGroup for the report.
1145 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1147 Add and fill a Reports drop-down list box.
1149 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1151 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1152 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1153 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1154 Added getReports(document, table, localeID), calling
1155 ConfiguredDocument.getReports().
1156 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1157 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1158 Added setReportsList() and a list widget.
1159 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1160 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1165 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1167 Translations: Add Esperanto.
1169 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1170 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1171 properties: Add this translation because someone took the time to make it.
1173 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1175 Adapt to the java-libglom 1.21.7 API.
1177 * src/main/java/org/glom/web/server/ReportGenerator.java:
1178 addToReport(): get_group_secondary_fields() is now
1179 get_secondary_fields().
1182 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1184 Use the latest java-libglom version.
1186 * pom.xml: Use java-libglom 1.21.7.
1188 2012-03-03 Ben Konrath <ben@bagu.org>
1190 Display date and time in details view.
1192 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1194 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1196 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1198 Require the latest java-libglom.
1200 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1202 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1204 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1206 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1207 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1208 an empty quickfind string. I also corrected libglom to create only
1209 empty where clauses for empty quickfind strings, but this avoids the
1212 2012-02-24 Ben Konrath <ben@bagu.org>
1214 Improve the tabs in the Notebook widget.
1218 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1220 Translations: Try to translate the strings.
1222 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1223 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1224 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1225 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1226 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1227 Take the Open translation from GTK+'s .po files.
1228 Take the Details translation from Glom's po files.
1229 I have added the other strings to Glom so we can get translations that way:
1230 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1232 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1234 TableSelectionViewImpl: Put the search label and entry in a div.
1236 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1237 Put the search widgets in a FlowTable so that the CSS can be used to
1238 style them while keeping them together.
1239 * src/main/webapp/style.css: Mention the new div.
1241 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1243 Translate more strings in more locales.
1245 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1246 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1247 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1248 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1249 Translate the "Details" and "Open" string too.
1251 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1252 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1253 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1254 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1255 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1256 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1257 Add these new locales as placeholders though they currently contain English.
1259 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1261 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1263 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1264 Check the ConfiguredDocument* for null before using it.
1266 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1268 Tell Eclipse about the generated java files.
1270 * .classpath: This lets it find OnlineGlomConstants.java.
1271 It would be nice if Eclipse just used the maven build files.
1273 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1275 Prevent a crash when no locale is specified in the URL.
1277 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1278 Avoid returning a null string, obtained from
1279 Window.Location.getParameter(). This caused a crash when it was
1280 later passed to libglom's API.
1281 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1282 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1283 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1284 guard against future null strings.
1286 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1288 Use the ?locale= query param instead of the &lang= token param.
1290 * src/main/java/org/glom/web/client/place/ListPlace.java
1291 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1292 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1293 Remove the lang token key and value.
1295 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1296 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1297 When the user selects a different locale from the chooser, use
1298 Window.Location.assign() to change the URL, which then causes a reload.
1300 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1301 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1302 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1303 * src/main/java/org/glom/web/client/activity/ListActivity.java
1304 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1305 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1306 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1307 * src/main/java/org/glom/web/client/ui/ListView.java:
1308 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1310 Remove localeID member variables and method/constructor parameters, instead
1311 using Utils.getCurrentLocaleID() when we need a localID to pass to
1314 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1316 Internationalize the UI strings.
1318 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1319 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1320 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1321 because it is unused. Messages are apparently strings that can have
1322 parameters, but we do not need that yet, so Contants will be enough for now.
1323 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1324 to say that we support the en and de locales.
1325 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1326 The original English strings.
1327 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1328 Some German translations of the English strings.
1329 The i18n goal then uses the .properties file to generate an
1330 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1331 returns an implementation that returns the translated strings.
1332 The documentation suggests putting these in src/java/*/client/, but it seems
1333 best to put it in src/resources/*/client/.
1334 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1335 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1336 instead of hard-coding them.
1337 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1338 but that does not seem to stop the build, though it confuses Eclipse.
1340 You can see the translated string by adding ?locale=de to the URL, like so:
1341 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1343 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1345 Improve null/empty String checks.
1347 * pom.xml: Add a dependency on commons-lang, to use
1348 org.apache.commons.lang.StringUtils.
1349 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1351 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1352 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1353 Use StringUtils.isEmpty().
1355 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1356 StringUtils class with a static isEmpty() function because we
1357 cannot use org.apache.commons.lang.StringUtils in client-side
1358 GWT code because it (apparently) cannot be compiled to javascript.
1359 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1360 * src/main/java/org/glom/web/client/activity/ListActivity.java
1361 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1362 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1363 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1364 * src/main/java/org/glom/web/client/place/ListPlace.java
1365 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1366 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1367 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1368 * src/main/java/org/glom/web/client/ui/details/Group.java
1369 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1370 our StringUtils.isEmpty() function.
1372 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1374 Update to the latest java-libglom API.
1376 * pom.xml: Require java-libglom 1.21.4.
1377 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1378 getDocumentInfo(), getListViewLayoutGroup():
1379 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1381 * src/main/java/org/glom/web/server/database/DBAccess.java
1382 getFieldsToShowForSQLQueryAddGroup(),
1383 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1384 with either get_database_title_original() or
1385 get_database_title(localeID).
1387 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1389 ConfiguredDocument: Avoid a null pointer exception.
1391 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1392 Initialize localeID to "" to avoid returning a null String which
1393 causes a crash in java-libglom's swing-generated code.
1395 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1397 Some simple renaming.
1399 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1400 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1401 for localeChooser. This seems more appropriate and is less ambiguous
1402 particularly in the .css file.
1404 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1406 ConfiguredDocument: Rename the localedID private member variable.
1408 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1410 Adapt to the latest java-libglom API from git master.
1412 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1413 libglom now uses only Vector instead of List, which uses add() instead of
1416 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1418 ConfiguredDocument: Rename the localedID private member variable.
1420 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1422 Build a source tarball with mvn assembly:single
1424 * assembly.xml: Add this file.
1425 * pom.xml: Use the maven-assembly-plugin and tell it to use
1426 our assembly.xml file.
1428 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1430 OnlineGlomServiceImpl: Get .glom files recursively.
1432 * pom.xml: Depend on commons-io from org.apache.commons.
1433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1434 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1435 files recursively, and with the easier filter for the extension.
1436 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1437 simplify that code too.
1439 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1441 README: Mention that you must install java-libglom packages separately.
1443 But then it works, because java-libglom is now in the central maven
1446 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1448 locales drop-down: Show the correct selected locale when the URL changes.
1450 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1451 .java: setPlace(): Move some code into fillView().
1453 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1455 locales drop-down: Do not lose the primary key.
1457 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1458 start(): onLocaleChange(): Pass the current primary key value,
1459 instead of an empty value.
1461 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1463 locales drop-down: Do not lose the drop-down selection.
1465 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1466 .java (TableSelectionActivity.fillView): Set the selected locale
1467 after changing the drop-down items (though we do not really need
1468 to change them just because the locale changes.)
1470 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1472 locales drop-down: Change the tables list when this changes.
1474 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1475 .java: TableSelectionActivity.start(): Move the async table titles
1476 retrieval into a private fillView() method and also call this when
1477 the chosen locale changes.
1478 Note that the document title is not actually translatable yet, but
1479 that is a problem that I should fix soon in libglom.
1481 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1483 Improve the placement of the locales drop-down.
1485 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1486 Put the title and locales drop-down in a div (gwt.FlowTable).
1487 * src/main/webapp/style.css: Add magic css properties to make this work.
1488 Also remove the left margin from the title so that it lines up with the
1491 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1493 locales selector: Show human-readable locale titles.
1495 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1496 getDocumentInfo(): Use java.util.Locale to show a real title of
1497 each locale, in the locale's own language.
1499 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1501 Add a language/locale selector drop-down.
1503 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1504 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1505 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1506 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1507 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1508 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1509 Add a ListBox to show the available locales. Add getLocaleSelector(),
1510 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1511 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1512 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1513 java: Add these classes.
1514 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1515 start(): Fill the locales ListBox. Handle its change event, firing a
1517 setPlace(): Show the selected locale as specified by the URL token.
1518 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1519 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1520 Handle LocaleChangeEvent, going to a new *Place with that locale.
1522 The placement of the ListBox is not pretty, and it currently uses the ID
1523 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1527 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1529 Search box: Show the search text from the URL token.
1531 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1532 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1533 Add setQuickFindText().
1534 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1535 .java: setPlace(): Store the queryText if the place is a ListPlace,
1536 and call TableSelectionView.setQuickFindText().
1538 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1540 Allow use of translations via, for instance, &lang=de in the URL.
1542 * pom.xml: Use the unstable java-libglom 1.21 version.
1544 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1545 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1546 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1547 init(): Instead of calling TranslatableItem.set_current_locale()
1548 (now removed), call ConfiguredDocument.setDefaultLocaleID().
1549 However, this is only for default locales, which are not needed to
1550 change the locale in the URL.
1551 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
1552 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
1553 getSortedRelatedListData(): Add a localeID parameter, so we can get the
1554 layout for a particular locale.
1555 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1556 Add get/setDefaultLocaleID().
1557 getDocumentInfo(), getListViewData(), getRelatedListData(),
1558 getDetailsLayoutGroup(), getListViewLayoutGroup(),
1559 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
1560 localeID parameter, so we can get the layout for a particular locale.
1562 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1563 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1564 * src/main/java/org/glom/web/client/place/ListPlace.java:
1565 Parse and construct a lang parameter too.
1567 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1568 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
1569 passed to subsequent methods and constructors.
1570 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1571 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1572 Store the localeID from the *Place and pass it to other constructors
1573 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
1575 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1576 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1577 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1578 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1579 * src/main/java/org/glom/web/client/ui/ListView.java:
1580 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1581 Take localeID parameters and pass them to subsequent constructors and
1582 methods, so that the layout is always retrieved for that locale.
1584 This is rather repetitive.
1586 Note that "" means the original (default) locale of the Glom document,
1587 which is usually English.
1589 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1591 Documents: Remove final keyword to fix startup configuration.
1593 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1594 final keywords on the private member variables because that breaks
1595 the startup, apparently (there are warnings) because it stops them
1596 from being serialized. I added these in the previous commit.
1598 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1600 Documents: Add some final keywords.
1602 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1605 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1607 OnlineGlomServiceImpl: Add to overview comments.
1609 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1610 Note that this is where all the document are loaded. They are not
1611 loaded freshly for each page.
1613 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1617 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1618 Add a TextBox for the text of a quick find.
1619 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1621 setBackLink(): Add a String quickFind parameter.
1622 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1623 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1624 to the base interface, because that is how TableSelectionViewImpl is used.
1625 * src/main/webapp/style.css: Add style for the search box and its label.
1627 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1628 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1629 Add these files, based on the existing TableChangeEvent and
1630 TableChangeEventHandlers.
1631 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1632 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1633 a ListPlace() that the user should be taken to.
1634 * src/main/java/org/glom/web/client/activity/ListActivity.java
1635 start(): Handle it here too and adapt the TableChangeEvent handler to
1636 pass the extra "" quickFind parameter to ListPlace.
1637 * src/main/java/org/glom/web/client/place/ListPlace.java:
1638 Constructor: Take an extra String quickFind parameter and store it,
1639 returning it from a new getQuickFind() method.
1640 getToken(): Put the quickFind text in the URL token.
1641 getPlace(): Parse the quickFind text from the URL token.
1642 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1643 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1644 ListPlace constructor.
1645 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1646 .java: start(): Add a Change handler for the TableSelectionView's
1647 TextBox (via its base HasChangeHandlers interface), firing the new
1648 QuickFindChangeEvent.
1649 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1650 pass the extra "" quickFind parameter.
1652 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1653 setCellTable(): Add a String quickFind parameter and pass it to
1654 the ListViewTable() constructor.
1655 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1656 setCellTable() in the base interface, because that is how ListViewImpl
1659 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1660 Add a String quickFind member variable.
1661 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1662 Constructor: Add a String quickFind parameter, storing it in the
1663 base ListTable's member variable.
1664 onRangeChanged(): Pass quickFind to the
1665 OnlineGlomServiceAsync.getSortedListViewData() and
1666 OnlineGlomServiceAsync.getListViewData() methods.
1668 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1669 getListViewData(), getSortedListViewData(): Add a String quickFind
1670 parameter, passing it to ConfiguredDocument.getListViewData().
1671 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1672 Change getListViewData(), getSortedListViewData() in the base interface,
1673 because that is how OnlineGlomServiceImpl is used, via this:
1674 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1675 Change getListViewData(), getSortedListViewData() here too.
1676 This class can apparently be used to asynchronously call methods on
1677 OnlineGlomService, and GWT seems to implement that after recognizing
1678 just the *Async name convention and the extra AsyncCallback parameters.
1680 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1681 getListViewData(): Add a String quickFind parameter, and pass it to
1682 ListViewDBAccess.getData().
1683 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1684 getListData(): Add a String quickFind parameter and pass it to
1686 getSelectQuery(): Add a String quickFind parameter.
1687 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1688 getSelectQuery(): Add a String quickFind parameter and use it with
1689 Glom.get_find_where_clause_quick() to pass a where_clause to
1690 Glom.build_sql_select_with_where_clause(), to actually filter the
1692 getData(): Add a String quickFind parameter, passing it to getListData().
1693 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1694 va: getData(): Pass an empty string to getListData() for the
1695 quickFind parameter.
1697 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1699 ListTable: Minor change.
1701 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1702 createCellTable(): Make this protected instead of public.
1704 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1706 Many files: Use final for the parameters and use the @override attribute.
1708 2012-01-22 Ben Konrath <ben@bagu.org>
1710 Add anchor links for single line text that starts with http, ftp and www.
1714 2012-01-22 Ben Konrath <ben@bagu.org>
1716 Add ellipsis to single line text in details view.
1720 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1722 Remove all javadoc author tags.
1724 Because they are awkward and meaningless when many people touch
1726 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1728 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1730 Revert the COPYING.LESSER to COPYING rename.
1732 Apparently both should be there if it is LGPL.
1734 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1736 *View: Remove unused imports.
1738 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1739 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1740 * src/main/java/org/glom/web/client/ui/ListView.java:
1741 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1742 Remove unused imports, as suggested by Eclipse.
1744 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1746 Move the *View::Presenter types, and some API into one base View.
1748 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1749 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1750 * src/main/java/org/glom/web/client/ui/ListView.java:
1751 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1752 Presenter, setPresenter() and clear() into a shared base interface,
1753 to avoid the unnecessary duplicate Presenter types and to more clearly
1754 show how the *Views share the same structure, even if they are not
1755 used polymorphically.
1757 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1758 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1760 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1761 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1762 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1764 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1767 Feel free to revert this if there is a good reason for the duplicate
1770 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1772 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1774 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1775 a class member instead of a local variable in the method.
1776 This lets us use it to get the view instances, for use in tests.
1777 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1778 beforeOnlineGlom(): Test some more details of the initial view.
1779 Again, this is not very useful.
1781 To really test gwt-glom we will need to start a local postgresql
1782 instance with local data, like the Glom tests in C++.
1784 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1786 pom.xml: Mention the LGPL license.
1788 * pom.xml: Add a licenses section.
1789 * COPYING.LESSER: Move this to COPYING, which
1790 previously contained the GPL. But gwt-glom is all LGPL.
1792 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1794 Add project information to README and pom.xml.
1796 * README: Add a brief description and mention some mvn
1798 * pom.xml: This extra information shows up in mvn site
1801 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1803 Use the latest java-libglom version.
1805 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1807 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1809 GwtTestOnlineGlom: Test a little more.
1811 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1812 protected rather than private, as suggested by the gwt-test-utils
1814 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1815 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1816 Test the initial visibility of the panels.
1818 However, this is not a very useful test.
1819 And I wonder how we should generally test using this idea for an
1820 activity/places app like ours where the real changes happen implicitly
1821 based on the history token/URL.
1823 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1825 Slight modification to *Mapper comments.
1827 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1828 (DataActivityMapper)
1829 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1831 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1833 Remove comments mentioning GIN because they are just copied from
1834 the example code and are apparently not helpful:
1835 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1836 Also change the mention of a class that is only in the example code.
1838 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1840 GwtTestOnlineGlom test: Minor changes.
1842 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1843 Avoid the long qualified class name and modify the comment
1844 because it is now obvious to me that the mocked class is the only
1845 custom one created via GWT.create().
1847 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1849 Tests: Added the beginnings of a test using gwt-test-utils.
1851 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1852 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1853 which tells gwt-test-utils what class will be tested.
1854 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1855 Add a simple (but empty) test case. One class, used by the OnlineGlom
1856 class, is mocked so that it can be created. However, I am not sure
1857 why only this class needs to be mocked.
1859 Note that mockito seems more popular, and clearer, than easymock,
1860 but I have not got that working yet. It might be a matter of the
1863 This test is run during mvn integration-test.
1865 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1867 Tests: Use junit4-style syntax instead of junit3-style.
1869 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1870 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1871 * src/test/java/org/glom/web/shared/DataItemTest.java:
1872 Use the @Test annotation rather than relying on the test*() prefix.
1873 Also no longer implement TestCase, to avoid triggering support for
1874 the junit3-way, which stops the annotations from working.
1875 Change the imports from import junit.framework.* to
1876 import org.junit.*, which is apparently the new way.
1878 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1880 Added a test for ListPlace token parsing and creation.
1882 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1883 This is much the same as DetailsPlaceTest.
1885 I wonder how we could test the other parts of the *Place API.
1887 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1889 DetailsPlace test: Also test getToken() and recreation via getPlace().
1891 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1892 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1893 recreate it, testing the recreated DetailsPlace for the same parameter
1896 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1898 Use the surefire-report plugin.
1900 * pom.xml: This generates a HTML report about the tests in
1901 target/site/surefire-report.html
1902 when you do mvn surefire-report:report. It seems to be popular/normal.
1904 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1906 Added a test for DetailsPlace.
1908 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1909 Test the getPlace() token parsing.
1911 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1913 Added a first unit test.
1915 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1916 * src/test/java/org/glom/web/shared/DataItemTest.java:
1917 This is a silly test but it is just to get things started. Note that
1918 maven/junit finds the test because it looks in src/test by default.
1920 2011-12-22 Ben Konrath <ben@bagu.org>
1922 Change charsetName to "UTF-8" when replacing line breaks.
1924 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1925 that work in Java (such as "UTF8") will not work when compiled to
1928 This fixes a problem with multi-line details view fields that have hard
1929 line breaks. The "License Text" field on this page demonstrates the
1932 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1934 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1936 2011-12-22 Ben Konrath <ben@bagu.org>
1938 Fix another bug with related list navigation.
1940 I've tested all the navigation buttons in all of the related lists
1941 so things should be good now.
1943 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1945 2011-12-22 Ben Konrath <ben@bagu.org>
1947 Fix a crasher when refreshing the list view with the default table.
1949 This crash will also happen when loading the list view with the default
1950 table from a link or bookmark.
1952 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1953 to the main document selection page when the document id hasn't been
1955 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1956 the main document selection page when the document id hasn't been
1958 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1959 values for the details place when the document id hasn't been set.
1960 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1961 values for the list place when the document id hasn't been set.
1963 2011-12-21 Ben Konrath <ben@bagu.org>
1965 Protect against NPE when glom.document.locale is not in config.
1967 This patch protects against an NPE when glom.document.locale is not in
1968 the config file. This NPE will also happen if glom.document.locale is
1971 The patch also updates the error message to display the class name when
1972 the getMessage() returns null. This was happening when the NPE was
1973 thrown and I had "Configuration Error: null". If an NPE is encountered
1974 with this patch, "Configuration Error: NullPointerException " will be
1977 This commit closes this bug:
1979 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1981 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1983 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1985 Rename onlineglom.properties to onlineglom.properties.sample.
1987 * src/main/resources/onlineglom.properties: Rename to:
1988 * src/main/resources/onlineglom.properties.sample:
1989 * src/main/resources/README: And add this file explaining that people
1990 should rename it back when deploying.
1992 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1994 Allow choosing the translation in the .properties file.
1996 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1997 init(): Read a glom.document.locale value from the configuration file
1998 and call Glom's TransatableItem::set_current_locale() method.
1999 * src/main/resources/onlineglom.properties: Add a commented-out
2000 example of this new setting.
2002 It would be better to add &lang=de_DE to the URL, but the current
2003 libglom API does not allow us to do this easily. I am working on that.
2005 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2007 Avoid a crash in parsing of token parameters.
2009 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2010 ava: getTokenParams(): Do not crash if a parameter has a key but no
2011 value, and ignore parameters with neither.
2013 2011-12-17 Murray Cumming <murrayc@murayc.com>
2015 History token building/handling: Improve use of token parameters.
2017 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2018 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2019 and buildParamsToken(HashMap), for use by derived classes.
2020 Make the separator private because it is no longer be needed.
2021 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2022 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2023 instead of manual string concatenation.
2024 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2025 of hardcoded indices and awkward splitting code.
2026 * src/main/java/org/glom/web/client/place/ListPlace.java
2027 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2028 instead of manual string concatenation.
2029 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2030 of hardcoded indices and awkward splitting code.
2031 This should fix bug #666420
2033 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2035 Fix a Navgiation->Navigation typo in the code.
2037 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2038 Rename processNavgiation() to processNavigation().
2040 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2042 Fix a seperator->separator typo in the code.
2044 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2045 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2046 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2049 2011-12-15 Ben Konrath <ben@bagu.org>
2051 Cleanup some comments.
2053 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2055 2011-12-14 Ben Konrath <ben@bagu.org>
2057 Replace \n with <br/> for multiline text in the details view.
2059 Vertical scrollbars are added when needed as well.
2061 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2063 2011-12-14 Ben Konrath <ben@bagu.org>
2065 Specify the font for document selection links.
2067 * src/main/webapp/style.css:
2069 2011-12-14 Ben Konrath <ben@bagu.org>
2071 Fix bouncy CellTable while paging.
2073 This doesn't currently work with related list tables in unselected
2076 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2078 2011-12-14 Ben Konrath <ben@bagu.org>
2080 Revamp the appearance of the document selection page.
2082 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2083 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2084 * src/main/webapp/style.css:
2086 2011-12-13 Ben Konrath <ben@bagu.org>
2088 Set navigation button column to the smallest size possible.
2090 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2092 2011-12-13 Ben Konrath <ben@bagu.org>
2094 Change OpenButton nomenclature to NavigationButton.
2096 Using NavigtionButton makes things more generic. Classes, methods and
2097 variables have been changed.
2099 This is a rename-only refactor.
2101 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2102 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2103 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2104 Renamed from OpenButtonCell.
2105 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2106 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2107 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2109 2011-12-12 Ben Konrath <ben@bagu.org>
2111 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2113 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2114 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2115 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2116 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2118 2011-12-12 Ben Konrath <ben@bagu.org>
2120 Update variable names and comments.
2122 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2123 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2125 2011-12-12 Ben Konrath <ben@bagu.org>
2127 Properly initialize numNonEmptyRows variable to zero.
2129 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2130 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2132 2011-12-05 Ben Konrath <ben@bagu.org>
2134 Add latest mockup with HTML tables.
2136 Features of this mockup:
2138 -> HTML table for flowtable
2139 -> HTML table for flowtable column
2140 -> Example of how related lists would look
2141 -> Not using text entries for data items
2143 The current version of Online Glom doesn't use HTML tables for the
2146 This mockup has been sent to the glom-devel mailing list but it's good
2147 to have it here as well.
2149 * mockups/details-view-html-tables.html:
2151 2011-12-05 Ben Konrath <ben@bagu.org>
2153 Remove unnecessary getPrimaryKeyField() method.
2155 getPrimaryKeyFieldForTable(String) has been renamed to
2156 getPrimaryKeyField(String).
2158 * src/main/java/org/glom/web/server/database/DBAccess.java:
2159 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2160 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2162 2011-12-05 Ben Konrath <ben@bagu.org>
2164 Add string representation of TypedDataItem value to conversion error message.
2166 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2167 message was extracted into its own method to avoid duplication.
2169 2011-12-05 Ben Konrath <ben@bagu.org>
2171 Add type checking to navigation primary key value creation.
2173 Create navigation primary key only if the expected type from the Glom
2174 document matches the type returned by the SQL query.
2176 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2178 2011-12-05 Ben Konrath <ben@bagu.org>
2180 Rename a couple of variables in RelatedListNavigation.
2182 This is a rename-only refactor.
2184 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2186 2011-12-05 Ben Konrath <ben@bagu.org>
2188 Move getListLayoutGroup() into getListViewLayoutGroup().
2190 This removes getListLayoutGroup(). It was only being called by
2191 getListViewLayoutGroup().
2193 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2195 2011-12-05 Ben Konrath <ben@bagu.org>
2197 Remove check for LayoutItem_Portal in list table method.
2199 This check is no longer necessary because the method isn't being used
2200 to create the LayoutItemPortal DTO.
2202 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2204 2011-12-05 Ben Konrath <ben@bagu.org>
2206 Properly support related list navigation.
2208 Navigation from the "Repository Analyzer -> Package Scans ->
2209 Dependencies" related table wasn't working because the primary key for
2210 related tables wasn't being set properly. This commit fixes the
2213 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2214 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2215 doesn't set the primary key properly for related list tables.
2216 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2217 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2218 useful for getting the primary key for list view tables and for related
2220 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2221 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2222 Move code to set the primary key for the table from the abstract
2223 ListDBAccess class to ListViewDBAccess as it's only correct for list
2225 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2226 Properly add primary key to related list tables.
2228 2011-12-02 Ben Konrath <ben@bagu.org>
2230 Properly set the horizontal alignment of fields.
2232 This fix is for both the list tables and the details view.
2234 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2235 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2236 to set the horizontal alignment of fields.
2238 2011-12-02 Ben Konrath <ben@bagu.org>
2240 Display currency codes in the details view.
2242 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2244 2011-12-02 Ben Konrath <ben@bagu.org>
2246 Avoid duplicate JNI call.
2248 JNI is not as efficient as pure Java and this is an easy (and small)
2251 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2252 Use previously retrieved value for whereClauseToTableName instead of
2255 2011-12-02 Ben Konrath <ben@bagu.org>
2257 Rename a couple of variables in RelatedListNavigation.
2259 This is a rename-only refactor.
2261 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2263 2011-12-02 Ben Konrath <ben@bagu.org>
2265 Indicate clearly that a mismatched primary key type is a bug.
2267 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2268 warning to error. Add 'This is a bug.' to message.
2270 2011-12-02 Ben Konrath <ben@bagu.org>
2272 Update / fix some comments.
2274 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2276 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2278 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2279 Fix comments. Add some TODOs.
2281 2011-12-02 Ben Konrath <ben@bagu.org>
2283 Enable navigation to details view with string primary key from related list.
2285 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2286 Create a text primary key value when return type of result is
2287 java.sql.Types.VARCHAR.
2289 2011-12-02 Ben Konrath <ben@bagu.org>
2291 Use checkboxes for booleans in the details view.
2293 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2295 2011-12-01 Ben Konrath <ben@bagu.org>
2297 Improve performance of related list height calculation.
2299 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2300 Put code to calculate the expected height in a static initializer so
2301 that that it's only called once.
2303 2011-12-01 Ben Konrath <ben@bagu.org>
2305 Show related list tables in notebooks (again).
2307 Calculate the height of the related list tables so the Notebook can be
2308 set the correct height. The height of the related list table is also needed by
2309 FlowTable to be able decide how to create the layout.
2311 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2312 and set the Portal height based on the height of the related list
2313 table and the Portal container.
2314 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2315 Add method to calculate the height of the related list tables.
2316 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2317 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2318 calculate the height of the Pager widget.
2320 2011-12-01 Ben Konrath <ben@bagu.org>
2322 Use CellTable API for table property instead of setting style on Element.
2324 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2326 2011-12-01 Ben Konrath <ben@bagu.org>
2328 Make ListViewTable and RelatedListTable a consistent height.
2330 The tables are now a consistent height regardless of the contents of
2331 the table. A hidden button is added to empty rows to ensure that the
2332 height of these rows will match the height of rows with data.
2334 A navigation button column is now added to every table. The width of
2335 the navigation column is set to 0px when a RelatedListTable shouldn't
2336 have navigation buttons. This maintains the a consistent row height in
2337 tables that don't show the navigation buttons.
2339 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2340 navigation column when not needed.
2341 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2342 arguments for navigation button to constructor of ListViewTable.
2343 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2344 hidden button for empty data rows.
2345 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2346 arguments for navigation button to constructor.
2347 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2348 create navigation buttons. Add hideNavigationButtons() method.
2349 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2350 arguments for navigation button to constructor.
2352 2011-12-01 Ben Konrath <ben@bagu.org>
2354 Use 'visibility: hidden' in Utils.getWidgetHeight().
2356 This is better choice because hidden elements are invisible, don't
2357 respond to events and are not part of the tab order. They will,
2358 however, take up space which is required to be able to calculate the
2359 height of the widget.
2361 * src/main/java/org/glom/web/client/Utils.java:
2363 2011-12-01 Ben Konrath <ben@bagu.org>
2365 Use Utils.getWidgetHeight() in FlowTable.
2367 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
2369 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2371 2011-12-01 Ben Konrath <ben@bagu.org>
2373 Put the details css class name on the correct table column.
2375 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2377 2011-11-30 Ben Konrath <ben@bagu.org>
2379 Update for java-libglom API change.
2381 The getters and setters on FieldFormatting and NumericFormat were
2382 changed to remove the 'M'.
2384 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2386 2011-11-29 Ben Konrath <ben@bagu.org>
2388 Only allow RelatedListTables in Portals.
2390 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2392 2011-11-29 Ben Konrath <ben@bagu.org>
2394 Only create a contents panel for Portals when title is being set.
2396 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2398 2011-11-29 Ben Konrath <ben@bagu.org>
2400 Set TabLayoutPanel height based on calculated height its widgets.
2402 This is a potential fix for this bug:
2404 https://bugzilla.gnome.org/show_bug.cgi?id=665133
2406 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2408 2011-11-29 Ben Konrath <ben@bagu.org>
2410 Align details field labels and data with the Open buttons.
2412 * src/main/webapp/style.css:
2414 2011-11-29 Ben Konrath <ben@bagu.org>
2416 Remove unnecessary <div> in the Notebook widget.
2418 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
2419 method to get container FlowPanel (<div>).
2420 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
2421 initWidget() method directly on the TabLayoutPanel widget instead of
2422 Group's container widget.
2424 2011-11-29 Ben Konrath <ben@bagu.org>
2426 Don't add group titles for Portals in Notebooks.
2428 This reverts the previous patch and fixes a bug I introduced with
2429 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
2431 * src/main/java/org/glom/web/client/ui/details/Group.java:
2432 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2434 2011-11-28 Ben Konrath <ben@bagu.org>
2436 Remove unused boolean argument in Portal constructor.
2438 Just a code cleanup.
2440 * src/main/java/org/glom/web/client/ui/details/Group.java:
2441 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2443 2011-11-28 Ben Konrath <ben@bagu.org>
2445 Remove hack for glom 1.18 style glom files.
2447 * src/main/java/org/glom/web/client/ui/details/Group.java:
2448 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2449 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2451 2011-11-28 Ben Konrath <ben@bagu.org>
2453 Use Gda Value version of primary key to log result too large error.
2455 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2457 2011-11-28 Ben Konrath <ben@bagu.org>
2459 Don't use TypedDataItem.getText() for Unknown types from the URL.
2461 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2462 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
2463 instead of getText().
2464 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
2465 String field and getUnknown() method.
2467 2011-11-28 Ben Konrath <ben@bagu.org>
2469 Log an error message when the java-libglom .so is not present.
2471 The error message was being set in the exception but not logged.
2473 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2475 2011-11-28 Ben Konrath <ben@bagu.org>
2477 Ignore LayoutItem_CalendarPortals.
2479 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
2480 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
2482 2011-11-28 Ben Konrath <ben@bagu.org>
2484 Extract method for creating the LayoutItemPortal DTO.
2486 Just breaking the code up into smaller chunks.
2488 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2490 2011-11-28 Ben Konrath <ben@bagu.org>
2494 This should have been added with the refactor. Oops!
2496 * src/main/java/org/glom/web/shared/TypedDataItem.java:
2498 2011-11-28 Ben Konrath <ben@bagu.org>
2500 Create primary key value from URL string using type from Glom document.
2502 See this bug, comments 19 - 25:
2504 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
2506 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
2507 create a TypeDataItem for the primary key here when loading from a
2508 URL. Show the same string for the primary key value as was received
2509 from the URL string (when loading from a URL).
2510 * src/main/java/org/glom/web/server/Utils.java: Update method for
2511 creating the Gda Value from the TypeDataItem to properly deal with
2512 creating a Gda Value based on the Glom document type for the primary
2513 key value string when loading from a URL.
2514 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2515 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2516 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2517 Update for changed method name.
2519 2011-11-27 Ben Konrath <ben@bagu.org>
2521 Rename PrimaryKeyItem to TypedDataItem.
2523 The name PrimaryKeyItem suggests what the class should be used for.
2524 TypedDataItem is a neutral name that describes the class better.
2526 This is a rename-only refactor.
2528 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2529 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2530 * src/main/java/org/glom/web/client/Utils.java:
2531 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2532 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2533 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2534 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2535 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2536 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2537 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2538 * src/main/java/org/glom/web/server/Utils.java:
2539 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2540 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2541 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2542 * src/main/java/org/glom/web/shared/NavigationRecord.java:
2544 2011-11-25 Ben Konrath <ben@bagu.org>
2546 Improve Gda Value conversion from PrimaryKeyItem.
2548 The value from the PrimaryKeyItem is only used if its type match the
2549 type from the glom document.
2551 * src/main/java/org/glom/web/server/Utils.java:
2553 2011-11-25 Ben Konrath <ben@bagu.org>
2555 Manually check if the java-liblgom .so is visible to the JVM.
2557 It seems that Tomcat has problems when a static initializer throws an
2558 exception. This check is done before the first method call into
2559 java-libglom so that execution doesn't continue if the .so is not
2562 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2564 2011-11-25 Ben Konrath <ben@bagu.org>
2566 Improve browser configuration error messages.
2570 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2572 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2573 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
2574 getConfigurationErrorMessage() method.
2575 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2576 Get and display a specific configuration error message when no Glom
2577 documents are found.
2578 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2579 Implement getConfigurationErrorMessage() method. Surround configuration
2580 code in the init() method with a try/catch block. This allows the
2581 errors to be caught while keeping the servlet available to retrieve the
2582 configuration error message.
2584 2011-11-25 Ben Konrath <ben@bagu.org>
2586 Don't use Strings to hold primary key values.
2588 The primary key values are now held in a new data object
2589 (PrimaryKeyItem) that holds type information and the primary key value
2590 using the correct type.
2592 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2593 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2594 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2595 PrimaryKeyItem instead of String to hold the primary key value.
2596 * src/main/java/org/glom/web/client/Utils.java: Remove
2597 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2598 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2599 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2600 PrimaryKeyItem instead of String to hold the primary key value. Load
2601 document selection page when the documentID has not been set correctly.
2602 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2603 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2605 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2606 Return empty string for URL instead of "null".
2607 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2608 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2609 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2610 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2611 PrimaryKeyItem instead of String to hold primary key values.
2612 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2613 PrimaryKeyValue to a Gda Value.
2614 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2615 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2616 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2617 Replace temporary database access code that uses the PrimaryKeyValue to
2618 Gda Value conversion.
2619 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2620 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2621 PrimaryKeyItem instead of String.
2622 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2623 hold primary key values.
2625 2011-11-24 Ben Konrath <ben@bagu.org>
2627 Use newly added java-libglom API to create queries.
2629 This isn't finished. I still need to stop using Strings for primary key
2630 values in the client code.
2632 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2633 libglom to use fake connections so that retrieving the query string will
2635 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2636 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2637 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2638 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2639 Use the newly added libglom sql methods and classes to create the
2640 query. Add temporary hack to convert primary value strings to Gda
2643 2011-11-23 Ben Konrath <ben@bagu.org>
2645 Don't explicitly set the height of Portals.
2647 See comments 6 - 10 of this bug for details:
2649 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2651 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2653 2011-11-23 Ben Konrath <ben@bagu.org>
2655 Use an HTML table instead of CSS for the FlowTable layout.
2657 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2658 GWT's FlexTable to implement the FlowTable.
2659 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2661 2011-11-18 Ben Konrath <ben@bagu.org>
2663 Add boolean example to HTML table mockup.
2665 * mockups/details-view-html-tables-text-entries.html:
2667 2011-11-17 Ben Konrath <ben@bagu.org>
2669 Ensure the pager buttons are always visible for related lists.
2671 To accomplish this, I've turned off text wrapping in the list view and
2672 related list tables for both the header and data text. The related list
2673 table now has a fixed layout so the it doesn't overflow its container.
2674 This is required to ensure that the cell text is clipped when it
2675 overflows the cell and an ellipsis is added to the right side of the
2676 cell when text is clipped.
2678 A fixed table layout for the related list table in the details view
2679 seems what we want for the details view anyway, so the side-effect is
2682 The ellipsis will only be displayed in Firefox >= 7.
2686 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2688 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2689 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2690 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2692 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2693 Set the 'table-layout: fixed' CSS property to the related list table.
2694 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2695 'white-space: nowrap;' CSS property on both the list view and the
2696 related list tables.
2698 2011-11-16 Ben Konrath <ben@bagu.org>
2700 Rework the fix for empty notebook tab labels.
2702 Setting the empty group titles with its name caused problems for the
2703 details layout. Instead of using libglom's
2704 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2705 to the client when the title is empty. This allows the Notebook to use
2706 the name when the title is empty without affecting anything else.
2708 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2709 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2711 2011-11-16 Ben Konrath <ben@bagu.org>
2713 Set group titles with name when title is empty.
2715 This fixes a problem with an empty notebook tab label in the Lesson
2716 Planner document. The forth tab in the notebook should be "Internet":
2718 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2720 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2721 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2724 2011-11-16 Ben Konrath <ben@bagu.org>
2726 Remove whitespace from the configured username properties.
2728 This assumes that usernames won't have whitespace at the beginning
2729 or end. But I think this is a reasonable assumption.
2731 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2732 String.trim() to remove the whitespace from the username properties.
2734 2011-11-15 Ben Konrath <ben@bagu.org>
2736 Add details view mockup with HTML tables and text entries.
2738 This is from the attachment on this bug:
2740 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2742 * mockups/details-view-html-tables-text-entries.html:
2744 2011-11-15 Ben Konrath <ben@bagu.org>
2746 Add space between the columns of the flow table.
2750 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2752 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2753 space between columns in the flow table.
2755 2011-11-15 Ben Konrath <ben@bagu.org>
2757 Add backup files to the .gitignore.
2759 * .gitignore: Ignore files that end with ~.
2761 2011-11-09 Ben Konrath <ben@bagu.org>
2763 Use latest release of gwt-log.
2765 Gwt-log releases are now being submitted to the maven central
2766 repository so manual installation of the jar is no longer required.
2768 * pom.xml: Update version and groupId of gwt-log dependency.
2770 2011-10-31 Ben Konrath <ben@bagu.org>
2772 Don't use GWT numeric formatting to override the glom currency formatting.
2774 Currencies are now displayed like they are in Glom. See this bug:
2776 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2778 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2780 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2781 currency code to constructor and set it when the cell is rendered.
2782 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2783 currency code to the constructor of the NumericCell.
2785 2011-10-27 Ben Konrath <ben@bagu.org>
2787 Require the latest release of java-libglom (1.17.4).
2791 2011-10-26 Ben Konrath <ben@bagu.org>
2793 Add style to Notebook that matches current theme.
2795 It's not the best style in the world but it's better than the default.
2797 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2798 padding at the bottom of the child widgets.
2799 * src/main/webapp/style.css: Add style for the Notebook.
2801 2011-10-26 Ben Konrath <ben@bagu.org>
2803 Move servlet initialization code to overridden init method.
2805 This is half of the solution to getting proper error messages
2806 displayed when configuration errors occur. Here's the relevant bug:
2808 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2810 The rest of the solution involves surrounding the init method with a
2811 try/catch block and setting a global variable with the error /
2812 exception. A new async method should be created to retrieve and display
2813 the error message / exception.
2815 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2816 code from constructor to init method adding exceptions as needed.
2818 2011-10-26 Ben Konrath <ben@bagu.org>
2820 Add script to monitor and restart tomcat if required.
2822 * utils/check-and-recover-tomcat.py: New file.
2824 2011-10-26 Ben Konrath <ben@bagu.org>
2826 Display the correct number of data items in the pager.
2830 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2832 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2833 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2834 The implementation is the same for both tables: Keep track of the
2835 number of non-empty rows and fire and RowCountChangeEvent after the data has
2837 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2838 custom Pager class that subclasses SimplePager to handle displaying
2839 the correct number when empty rows have been added.
2841 2011-10-26 Ben Konrath <ben@bagu.org>
2843 Correct error in previous commit.
2845 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2846 eventBus parameter from listView.setCellTable().
2848 2011-10-26 Ben Konrath <ben@bagu.org>
2850 Fix error in TODO comment.
2852 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2854 2011-10-24 Ben Konrath <ben@bagu.org>
2856 Create Notebook widgets to the details view.
2858 This isn't finished just yet - I still need to create a reasonable
2859 style to match the current theme.
2861 * src/main/java/org/glom/web/client/Utils.java: Add method for
2862 calculating the height of a widget. This is used in the Notebook class.
2863 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2864 new constructor method in Group.
2865 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2866 method for creating child widget that can be used by subclasses
2867 like Notebook. New constructor that allows disabling the group
2868 titles - Notebooks don't set a group title for their child groups.
2869 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2870 to make Notebooks using GWT's TabLayoutPanel.
2871 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2872 constructor that allows disabling the group titles.
2873 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2874 LayoutItemNotebook DTO.
2875 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2876 DTO for Notebooks. It's just an empty class for now but we might need
2877 it to transfer some specific information in the future.
2879 2011-10-21 Ben Konrath <ben@bagu.org>
2881 Add navigation buttons to related list tables.
2883 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2884 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2885 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2886 method getSuitableRecordToViewDetails() for getting the table name
2887 and primary key value for related list navigation buttons.