1 2012-05-05 Murray Cumming <murrayc@murrayc.com>
3 Remove mentions of java-libglom.
5 * README: Remove mention of java-libglom, because it no longer needed.
6 * utils/build-onlineglom-war.sh:
7 * utils/check-and-recover-tomcat.py:
8 * utils/install-onlineglom-war.sh: Remove these as they are no longer
9 useful. Building is now far easier, with no need for jhbuild.
11 2012-05-05 Murray Cumming <murrayc@murrayc.com>
13 Fix the build (mvn package)
15 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
16 (LayoutGroup): Make the LayoutItemList inner class static and protected.
17 Otherwise the GWT Java->Javascript compilation fails with just this
18 error, during mvn package or when attempting to view in a browser,
19 in the GWT developer mode in Eclipse.
21 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
22 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
23 [INFO] Compiling module org.glom.web.OnlineGlom
24 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
25 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
26 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
27 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
28 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
29 [INFO] [ERROR] Cannot proceed due to previous errors
31 It has taken me 2 days to find out what was causing that. After reducing
32 the code, the compiler eventually showed me the full error message.
34 2012-05-04 Murray Cumming <murrayc@murrayc.com>
36 ConfiguredDocument: Cache the cloned and stripped layouts.
38 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
39 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
40 layout in a map, so we can retrieve it again without rebuilding it.
42 2012-05-04 Murray Cumming <murrayc@murrayc.com>
44 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
46 2012-05-04 Murray Cumming <murrayc@murrayc.com>
48 libglom classes: Implement some auto-generated emthods.
50 2012-05-04 Murray Cumming <murrayc@murrayc.com>
52 Add GwtTestOnlineGlomService.
54 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
55 However, this (and the other GwtTest*) does not seem to run during
58 2012-05-04 Murray Cumming <murrayc@murrayc.com>
60 Remove use of unsupported features from client code.
62 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
63 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
64 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
65 Use our client version of StringUtils instead of the apache commons one.
67 However, the GWT Javascript compliation still fails.
69 2012-04-25 Murray Cumming <murrayc@murrayc.com>
71 Add a Field class and implement some loading of it in Document.
73 2012-04-25 Murray Cumming <murrayc@murrayc.com>
75 Initial Document loading implementation, instead of libglom.
77 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
78 and Translatable classes, and adapt the rest of the code to use them.
79 However, this is still missing Layout and Field classes and loading.
81 2012-04-24 Murray Cumming <murrayc@murrayc.com>
83 Use of jOOQ: Move Field creation into a utility method.
85 * src/main/java/org/glom/web/server/SqlUtils.java:
86 This lets us improve it more easily.
88 2012-04-24 Murray Cumming <murrayc@murrayc.com>
90 Use of jOOQ: Improve the code to COUNT a sub-select.
92 * src/main/java/org/glom/web/server/SqlUtils.java:
93 Move initial query creation into
94 build_sql_select_step_with_where_clause().
95 build_sql_select_count_rows(): Use the jOOQ API instead of
96 concatentating text, because a jOOQ Select*Step is a TableLike,
97 which is what from() takes.
99 2012-04-23 Murray Cumming <murrayc@murrayc.com>
101 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
103 * pom.xml: Depend on jooq.
104 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
105 methods with jOOQ, based on the C++ implementations in libglom,
106 with some changes to the logic required by jooQ.
107 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
109 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
110 * src/main/java/org/glom/web/server/ReportGenerator.java:
111 * src/main/java/org/glom/web/server/SqlUtils.java:
112 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
113 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
114 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
115 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
116 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
117 Adapt. In particular, the SqlUtils methods now need to take a Connection,
118 because jOOQ needs that, though it seems unnecessary.
120 This is not quite finished. Ideally jOOQ would help us to build
121 table_name.field_name names, quoting and escaping them properly.
122 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
124 2012-04-21 Murray Cumming <murrayc@murrayc.com>
126 Move use of Glom.build_sql*() into a new SqlUtils class.
128 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
129 to wrap Glom.build_sql*(). The parameter types are still Glom one,
130 but this will make it easier to start using something other than
131 libglom or SqlBuilder.
133 2012-04-21 Murray Cumming <murrayc@murrayc.com>
135 Update the project URL.
137 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
139 2012-04-21 Murray Cumming <murrayc@murrayc.com>
141 Main layout: Use a FlowTable instead of absolute positioning.
143 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
144 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
145 child panels/widgets must have an absolute position. But that is annoying, so
146 this adds a FlowTable and puts the child panels in there.
148 2012-04-21 Murray Cumming <murrayc@murrayc.com>
150 GwtTestOnlineGlom: Comment out unused code.
152 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
153 Eclipse has started to say that some code is unused.
155 2012-04-21 Murray Cumming <murrayc@murrayc.com>
157 Update to the latest versions of dependencies.
159 * pom.xml: Update version numbers of dependencies to the latest
161 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
162 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
163 * src/main/java/org/glom/web/server/ReportGenerator.java:
164 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
165 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
166 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
168 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
169 Modify the imports where necessary.
171 2012-04-17 Murray Cumming <murrayc@murrayc.com>
173 Style: Remove overflow:hidden from searchbox
175 * src/main/webapp/style.css: Because this pushes the Back To Link
176 label/link on to the next row, which is then hidden due to the
177 hard-coded (in ems) height.
179 2012-04-20 Murray Cumming <murrayc@murrayc.com>
181 Remove some duplicate code.
183 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
184 getDocumentInfo(): This must have been duplicated during the merge from the
189 2012-04-19 Murray Cumming <murrayc@murrayc.com>
191 Reports: Localize the waiting for report message.
193 * src/main/java/org/glom/web/client/activity/ReportActivity.java
194 start(): Get the message from the contants.
195 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
197 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
198 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
199 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
200 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
201 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
202 Update these files with the English text for newer strings for now.
204 2012-04-19 Murray Cumming <murrayc@murrayc.com>
206 Reports: Show a message while waiting for the report.
208 * src/main/java/org/glom/web/client/ui/ReportView.java
209 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
210 Add setWaitingText(), to show a message saying that we are
211 waiting for the report to be ready.
212 * src/main/java/org/glom/web/client/activity/ReportActivity.java
213 start(): Call setWaitingText() before calling the async
216 2012-04-19 Murray Cumming <murrayc@murrayc.com>
218 ReportGenerator: Specify date and time formats.
220 * src/main/java/org/glom/web/server/ReportGenerator.java:
221 createFieldValueElement(): Use the default (and localized)
222 short formats, though we still need a way to show 4-digit
223 years without providing the format for every locale.
224 * src/main/java/org/glom/web/server/database/DBAccess.java:
225 convertResultSetToDTO(): Use the short formats here too.
227 2012-04-18 Murray Cumming <murrayc@murrayc.com>
229 ReportGenerator: Use the correct numeric formatting.
231 * src/main/java/org/glom/web/server/ReportGenerator.java
232 createFieldExpression(), createFieldValueElement(): Take the
233 whole LayoutItem_Field instead of just the field name, so
234 we have access to the formatting.
235 createFieldValueElement(): Use JRTextField.setPattern() to
236 specify the numeric formatting, with the help of a
237 regular DecimalFormat.
239 2012-04-18 Murray Cumming <murrayc@murrayc.com>
241 ReportGenerator: Avoid showing null for group by titles.
243 * src/main/java/org/glom/web/server/ReportGenerator.java
244 generateReport(): Use setBlankWhenNull() on the field title
245 style too, because this is used for values in group by
248 2012-04-18 Murray Cumming <murrayc@murrayc.com>
250 ReportGenerator: Add a colon to titles in vertical groups.
252 * src/main/java/org/glom/web/server/ReportGenerator.java
253 addFieldToDetailBandVertical(): Pass true for the withColon
256 2012-04-18 Murray Cumming <murrayc@murrayc.com>
258 ReportGenerator: Simplify the code by using Position more.
260 2012-04-18 Murray Cumming <murrayc@murrayc.com>
262 Reports: Support vertical groups, roughly.
264 * src/main/java/org/glom/web/server/ReportGenerator.java:
265 addToReport(): Rename to addGroupToReport() and, if necessary,
266 call the new addVerticalGroupToReport() method.
267 createFieldValueElement(): Let the caller specify the Y position
270 2012-04-17 Murray Cumming <murrayc@murrayc.com>
272 Reports: Allow a second report to be shown.
274 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
275 clear(): Do not remove the HTML widget, which broke the whole layout.
277 2012-04-17 Murray Cumming <murrayc@murrayc.com>
279 Locales drop-down: Show that we use English by default.
281 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
282 fillView(): When we use English, just because that is the default, when
283 no locale is specified, show that in the Locales drop-down instead of
284 just showing the first item.
286 2012-04-17 Murray Cumming <murrayc@murrayc.com>
288 Unselect the Report/Locale/Table combo item when appropriate.
290 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
291 setPlace(): clear reportName if this is not a ReportPlace.
292 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
293 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
294 When the provided name is empty, unselect all items, so that none are
295 indicated. This uses a for loop because I cannot find a single method
298 2012-04-17 Murray Cumming <murrayc@murrayc.com>
300 Report: Give the user a way to get back to the list.
302 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
303 start(), setPlace(): Show the Back To List link on reports, and also
304 interpret selecting the empty report item as back to list.
306 2012-04-13 Murray Cumming <murrayc@murrayc.com>
308 Really show the selected Report name.
310 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
311 setPlace(): Store the reportName here, if it is that kind of Place.
312 fillView(): Set the selected Report after filling the list of reports.
313 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
314 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
315 null Strings, though we need some way to unselect all ListBox items
318 2012-04-13 Murray Cumming <murrayc@murrayc.com>
320 ReportGenerator: Try to avoid some problems.
322 * src/main/java/org/glom/web/server/ReportGenerator.java
323 addField(): Try to avoid duplicates, and avoid using a null
326 2012-04-13 Murray Cumming <murrayc@murrayc.com>
328 Reports: Use quickFind.
330 * src/main/java/org/glom/web/client/OnlineGlomService.java;
331 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
332 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
333 getReportHTML(): Add a quickFind parameter.
334 * src/main/java/org/glom/web/client/activity/ReportActivity.java
335 start(): Pass the quickFind parameter.
336 * src/main/java/org/glom/web/server/ReportGenerator.java
337 generateReport(): Take a quickFind parameter.
339 2012-04-13 Murray Cumming <murrayc@murrayc.com>
341 ReportPlace: Actually use the report name.
343 * src/main/java/org/glom/web/client/place/ReportPlace.java
344 getPlace(): Do not assign the report name to the quickfind.
346 2012-04-13 Murray Cumming <murrayc@murrayc.com>
348 Show java.library.path when complaining.
350 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
351 init(): When telling us to check java.library.path, show the
354 2012-03-06 Murray Cumming <murrayc@murrayc.com>
356 ReportGenerator: Do not show nulls.
358 2012-03-06 Murray Cumming <murrayc@murrayc.com>
360 ReportGenerator: Make the title font larger.
362 2012-03-06 Murray Cumming <murrayc@murrayc.com>
364 ReportGenerator: Put field titles inside groups, if there are groups.
366 2012-03-06 Murray Cumming <murrayc@murrayc.com>
368 ReportGenerator: Take the Report itself instead of the name and group.
370 * src/main/java/org/glom/web/server/ConfiguredDocument.java
371 Remove getReportLayoutGroup().
372 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
373 getReportHTML(): Pass the report instead
374 of its name and layout group.
375 * src/main/java/org/glom/web/server/ReportGenerator.java
376 generateReport(): Use the report object to use the title
379 2012-03-06 Murray Cumming <murrayc@murrayc.com>
381 ReportGenerator: Remove designBand parameters.
383 * src/main/java/org/glom/web/server/ReportGenerator.java:
384 Make designBand a class member instead of passing it to all
387 2012-03-06 Murray Cumming <murrayc@murrayc.com>
389 ReportGenerator: Add lines, a bit like in the desktop version.
391 * src/main/java/org/glom/web/server/ReportGenerator.java
392 addToReport(): Use JRDesignLine.
394 2012-03-06 Murray Cumming <murrayc@murrayc.com>
396 ReportGenerator: Correct the title positions and use some bold style.
398 * src/main/java/org/glom/web/server/ReportGenerator.java:
399 Break the code up into reusable functions, correct the placement of
400 titles, and use normal/bold styles as in the reports in the desktop
403 2012-03-06 Murray Cumming <murrayc@murrayc.com>
405 ReportGenerator: Add a header band to show the field titles.
407 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
408 getReportHTML(): Pass the localeId to the ReportGenerator
410 * src/main/java/org/glom/web/server/ReportGenerator.java
411 constructor: Take the localeID so we can get translated field
413 generateReport(), addToReport(), addFieldToBand(): Add field
414 titles in a column header band.
416 2012-03-05 Murray Cumming <murrayc@murrayc.com>
418 Reports drop-down list: Some improvement.
420 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
421 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
422 Adedd setSelectedReport(),
423 setReportList(): Add a blank line so that the user can select the
425 * src/main/java/org/glom/web/client/activity/ReportActivity.java
426 start(): Show the current report by calling setSelectedReport().
427 This does not seem to work yet.
429 2012-03-05 Murray Cumming <murrayc@murrayc.com>
431 DetailsActivity, ListActivity: Move some variables into a base class.
433 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
434 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
435 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
436 the clientFactory, documentID, tableName and authenticationPopup into
437 a base class, to avoid duplication.
439 2012-03-05 Murray Cumming <murrayc@murrayc.com>
441 Translate the Reports label.
443 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
444 Get the "Reports" label string from the constants.
445 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
446 perties: Add Reports to the constants.
448 2012-03-05 Murray Cumming <murrayc@murrayc.com>
450 Reports: Implement grouping.
452 * src/main/java/org/glom/web/server/ReportGenerator.java:
453 Handle LayoutItem_GroupBy items and try to do the right thing
454 with JRDesignGroup. It seems to work.
456 2012-03-04 Murray Cumming <murrayc@murrayc.com>
458 Actually show some data with JasperReports.
460 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
461 getReportHTML(): Move most code into a ReportGenerator class.
462 * src/main/java/org/glom/web/server/ReportGenerator.java:
463 Recurse into sub-groups, adding fields to the JasperDesign's details
464 band. Note that we must set an arbitrary width and height, or it just
465 will not show any data.
467 2012-03-04 Murray Cumming <murrayc@murrayc.com>
469 Reports Chooser: Show the titles, not the names.
471 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
472 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
473 and the names as the values.
474 * src/main/java/org/glom/web/server/ConfiguredDocument.java
475 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
476 group now that we provide the report name, so it should always
479 2012-02-15 Murray Cumming <murrayc@murrayc.com>
481 Depend on jasperreports.
483 * pom.xml: Add the dependency. My plan is to use this on the
486 2012-01-31 Murray Cumming <murrayc@murrayc.com>
488 Implement navigation to report places.
490 * src/main/java/org/glom/web/client/activity/ReportActivity.java
491 start(): Do not bother to handle all events here.
492 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
493 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
494 Added getSelectedReport().
495 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
496 .java: start(): When handling a change to the reports chooser,
497 call getSelectedReport() and goTo() its ReportPlace.
498 * src/main/java/org/glom/web/client/ui/ReportView.java
499 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
500 Added setReportHTML() which puts the html in a gwt HTML widget.
501 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
502 getReportHTML(): Return "TODO" just to show that this works.
504 2012-01-31 Murray Cumming <murrayc@murrayc.com>
506 Make ReportPlace usable.
508 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
510 * src/main/java/org/glom/web/client/place/ReportPlace.java:
511 Correct the @prefix annotation.
513 2012-01-31 Murray Cumming <murrayc@murrayc.com>
515 OnlineGlomService: Return report HTML rather than the LayoutGroup.
517 * src/main/java/org/glom/web/client/OnlineGlomService.java:
518 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
519 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
520 Change getReportLayout() to getReportHMTL() because we will not need to
521 parse or render the report layout on the client side.
522 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
523 getReportLayout(): Return the libglom LayoutGroup type because we will
524 not need to convert to a shared type, because this will not be used on
526 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
529 Note that there is still no implementation for this.
532 2012-01-27 Murray Cumming <murrayc@murrayc.com>
534 Add a (empty) Report Place, View, and Activity.
536 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
538 * src/main/java/org/glom/web/client/place/HasTablePlace.java
539 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
540 this into a superclass:
541 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
542 and also use it as the base of this new ReportPlace:
543 * src/main/java/org/glom/web/client/place/ReportPlace.java
545 * src/main/java/org/glom/web/client/ui/ReportView.java
546 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
547 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
548 Add these, containing mostly boiler-plate for now.
550 * src/main/java/org/glom/web/client/OnlineGlomService.java
551 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
552 * src/main/java/org/glom/web/server/ConfiguredDocument.java
553 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
554 Add API to get the LayoutGroup for the report.
556 2012-01-23 Murray Cumming <murrayc@murrayc.com>
558 Add and fill a Reports drop-down list box.
560 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
562 * src/main/java/org/glom/web/client/OnlineGlomService.java:
563 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
564 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
565 Added getReports(document, table, localeID), calling
566 ConfiguredDocument.getReports().
567 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
568 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
569 Added setReportsList() and a list widget.
570 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
571 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
576 2012-04-12 Murray Cumming <murrayc@murrayc.com>
578 Translations: Add Esperanto.
580 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
581 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
582 properties: Add this translation because someone took the time to make it.
584 2012-03-15 Murray Cumming <murrayc@murrayc.com>
586 Adapt to the java-libglom 1.21.7 API.
588 * src/main/java/org/glom/web/server/ReportGenerator.java:
589 addToReport(): get_group_secondary_fields() is now
590 get_secondary_fields().
593 2012-03-15 Murray Cumming <murrayc@murrayc.com>
595 Use the latest java-libglom version.
597 * pom.xml: Use java-libglom 1.21.7.
599 2012-03-03 Ben Konrath <ben@bagu.org>
601 Display date and time in details view.
603 https://bugzilla.gnome.org/show_bug.cgi?id=671257
605 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
607 2012-03-05 Murray Cumming <murrayc@murrayc.com>
609 Require the latest java-libglom.
611 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
613 2012-03-04 Murray Cumming <murrayc@murrayc.com>
615 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
617 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
618 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
619 an empty quickfind string. I also corrected libglom to create only
620 empty where clauses for empty quickfind strings, but this avoids the
623 2012-02-24 Ben Konrath <ben@bagu.org>
625 Improve the tabs in the Notebook widget.
629 2012-01-30 Murray Cumming <murrayc@murrayc.com>
631 Translations: Try to translate the strings.
633 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
634 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
635 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
636 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
637 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
638 Take the Open translation from GTK+'s .po files.
639 Take the Details translation from Glom's po files.
640 I have added the other strings to Glom so we can get translations that way:
641 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
643 2012-01-27 Murray Cumming <murrayc@murrayc.com>
645 TableSelectionViewImpl: Put the search label and entry in a div.
647 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
648 Put the search widgets in a FlowTable so that the CSS can be used to
649 style them while keeping them together.
650 * src/main/webapp/style.css: Mention the new div.
652 2012-01-27 Murray Cumming <murrayc@murrayc.com>
654 Translate more strings in more locales.
656 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
657 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
658 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
659 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
660 Translate the "Details" and "Open" string too.
662 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
663 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
664 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
665 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
666 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
667 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
668 Add these new locales as placeholders though they currently contain English.
670 2012-01-27 Murray Cumming <murrayc@murrayc.com>
672 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
674 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
675 Check the ConfiguredDocument* for null before using it.
677 2012-01-26 Murray Cumming <murrayc@murrayc.com>
679 Tell Eclipse about the generated java files.
681 * .classpath: This lets it find OnlineGlomConstants.java.
682 It would be nice if Eclipse just used the maven build files.
684 2012-01-26 Murray Cumming <murrayc@murrayc.com>
686 Prevent a crash when no locale is specified in the URL.
688 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
689 Avoid returning a null string, obtained from
690 Window.Location.getParameter(). This caused a crash when it was
691 later passed to libglom's API.
692 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
693 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
694 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
695 guard against future null strings.
697 2012-01-26 Murray Cumming <murrayc@murrayc.com>
699 Use the ?locale= query param instead of the &lang= token param.
701 * src/main/java/org/glom/web/client/place/ListPlace.java
702 * src/main/java/org/glom/web/client/place/DetailsPlace.java
703 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
704 Remove the lang token key and value.
706 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
707 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
708 When the user selects a different locale from the chooser, use
709 Window.Location.assign() to change the URL, which then causes a reload.
711 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
712 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
713 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
714 * src/main/java/org/glom/web/client/activity/ListActivity.java
715 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
716 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
717 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
718 * src/main/java/org/glom/web/client/ui/ListView.java:
719 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
721 Remove localeID member variables and method/constructor parameters, instead
722 using Utils.getCurrentLocaleID() when we need a localID to pass to
725 2012-01-26 Murray Cumming <murrayc@murrayc.com>
727 Internationalize the UI strings.
729 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
730 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
731 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
732 because it is unused. Messages are apparently strings that can have
733 parameters, but we do not need that yet, so Contants will be enough for now.
734 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
735 to say that we support the en and de locales.
736 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
737 The original English strings.
738 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
739 Some German translations of the English strings.
740 The i18n goal then uses the .properties file to generate an
741 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
742 returns an implementation that returns the translated strings.
743 The documentation suggests putting these in src/java/*/client/, but it seems
744 best to put it in src/resources/*/client/.
745 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
746 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
747 instead of hard-coding them.
748 Note that we cannot import OnlineGlomConstants because it does not exist yet,
749 but that does not seem to stop the build, though it confuses Eclipse.
751 You can see the translated string by adding ?locale=de to the URL, like so:
752 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
754 2012-01-24 Murray Cumming <murrayc@murrayc.com>
756 Improve null/empty String checks.
758 * pom.xml: Add a dependency on commons-lang, to use
759 org.apache.commons.lang.StringUtils.
760 * src/main/java/org/glom/web/server/ConfiguredDocument.java
761 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
762 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
763 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
764 Use StringUtils.isEmpty().
766 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
767 StringUtils class with a static isEmpty() function because we
768 cannot use org.apache.commons.lang.StringUtils in client-side
769 GWT code because it (apparently) cannot be compiled to javascript.
770 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
771 * src/main/java/org/glom/web/client/activity/ListActivity.java
772 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
773 * src/main/java/org/glom/web/client/place/DetailsPlace.java
774 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
775 * src/main/java/org/glom/web/client/place/ListPlace.java
776 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
777 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
778 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
779 * src/main/java/org/glom/web/client/ui/details/Group.java
780 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
781 our StringUtils.isEmpty() function.
783 2012-01-24 Murray Cumming <murrayc@murrayc.com>
785 Update to the latest java-libglom API.
787 * pom.xml: Require java-libglom 1.21.4.
788 * src/main/java/org/glom/web/server/ConfiguredDocument.java
789 getDocumentInfo(), getListViewLayoutGroup():
790 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
792 * src/main/java/org/glom/web/server/database/DBAccess.java
793 getFieldsToShowForSQLQueryAddGroup(),
794 getPrimaryKeyLayoutItemField(): Replace get_database_title()
795 with either get_database_title_original() or
796 get_database_title(localeID).
798 2012-01-24 Murray Cumming <murrayc@murrayc.com>
800 ConfiguredDocument: Avoid a null pointer exception.
802 * src/main/java/org/glom/web/server/ConfiguredDocument.java
803 Initialize localeID to "" to avoid returning a null String which
804 causes a crash in java-libglom's swing-generated code.
806 2012-01-23 Murray Cumming <murrayc@murrayc.com>
808 Some simple renaming.
810 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
811 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
812 for localeChooser. This seems more appropriate and is less ambiguous
813 particularly in the .css file.
815 2012-01-23 Murray Cumming <murrayc@murrayc.com>
817 ConfiguredDocument: Rename the localedID private member variable.
819 2012-01-23 Murray Cumming <murrayc@murrayc.com>
821 Adapt to the latest java-libglom API from git master.
823 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
824 libglom now uses only Vector instead of List, which uses add() instead of
827 2012-01-22 Murray Cumming <murrayc@murrayc.com>
829 ConfiguredDocument: Rename the localedID private member variable.
831 2012-01-20 Murray Cumming <murrayc@murrayc.com>
833 Build a source tarball with mvn assembly:single
835 * assembly.xml: Add this file.
836 * pom.xml: Use the maven-assembly-plugin and tell it to use
837 our assembly.xml file.
839 2012-01-19 Murray Cumming <murrayc@murrayc.com>
841 OnlineGlomServiceImpl: Get .glom files recursively.
843 * pom.xml: Depend on commons-io from org.apache.commons.
844 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
845 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
846 files recursively, and with the easier filter for the extension.
847 Use org.apache.commons.io.FilenameUtils.removeExtension() to
848 simplify that code too.
850 2012-01-19 Murray Cumming <murrayc@murrayc.com>
852 README: Mention that you must install java-libglom packages separately.
854 But then it works, because java-libglom is now in the central maven
857 2012-01-18 Murray Cumming <murrayc@murrayc.com>
859 locales drop-down: Show the correct selected locale when the URL changes.
861 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
862 .java: setPlace(): Move some code into fillView().
864 2012-01-18 Murray Cumming <murrayc@murrayc.com>
866 locales drop-down: Do not lose the primary key.
868 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
869 start(): onLocaleChange(): Pass the current primary key value,
870 instead of an empty value.
872 2012-01-18 Murray Cumming <murrayc@murrayc.com>
874 locales drop-down: Do not lose the drop-down selection.
876 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
877 .java (TableSelectionActivity.fillView): Set the selected locale
878 after changing the drop-down items (though we do not really need
879 to change them just because the locale changes.)
881 2012-01-18 Murray Cumming <murrayc@murrayc.com>
883 locales drop-down: Change the tables list when this changes.
885 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
886 .java: TableSelectionActivity.start(): Move the async table titles
887 retrieval into a private fillView() method and also call this when
888 the chosen locale changes.
889 Note that the document title is not actually translatable yet, but
890 that is a problem that I should fix soon in libglom.
892 2012-01-18 Murray Cumming <murrayc@murrayc.com>
894 Improve the placement of the locales drop-down.
896 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
897 Put the title and locales drop-down in a div (gwt.FlowTable).
898 * src/main/webapp/style.css: Add magic css properties to make this work.
899 Also remove the left margin from the title so that it lines up with the
902 2012-01-18 Murray Cumming <murrayc@murrayc.com>
904 locales selector: Show human-readable locale titles.
906 * src/main/java/org/glom/web/server/ConfiguredDocument.java
907 getDocumentInfo(): Use java.util.Locale to show a real title of
908 each locale, in the locale's own language.
910 2012-01-17 Murray Cumming <murrayc@murrayc.com>
912 Add a language/locale selector drop-down.
914 * src/main/java/org/glom/web/shared/DocumentInfo.java:
915 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
916 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
917 getDocumentInfo(): Store the available Locales in the DocumentInfo.
918 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
919 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
920 Add a ListBox to show the available locales. Add getLocaleSelector(),
921 setLocaleList(), getSelectedLocale(), setSelectedLocale().
922 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
923 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
924 java: Add these classes.
925 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
926 start(): Fill the locales ListBox. Handle its change event, firing a
928 setPlace(): Show the selected locale as specified by the URL token.
929 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
930 * src/main/java/org/glom/web/client/activity/ListActivity.java:
931 Handle LocaleChangeEvent, going to a new *Place with that locale.
933 The placement of the ListBox is not pretty, and it currently uses the ID
934 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
938 2012-01-17 Murray Cumming <murrayc@murrayc.com>
940 Search box: Show the search text from the URL token.
942 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
943 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
944 Add setQuickFindText().
945 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
946 .java: setPlace(): Store the queryText if the place is a ListPlace,
947 and call TableSelectionView.setQuickFindText().
949 2012-01-17 Murray Cumming <murrayc@murrayc.com>
951 Allow use of translations via, for instance, &lang=de in the URL.
953 * pom.xml: Use the unstable java-libglom 1.21 version.
955 * src/main/java/org/glom/web/client/OnlineGlomService.java:
956 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
957 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
958 init(): Instead of calling TranslatableItem.set_current_locale()
959 (now removed), call ConfiguredDocument.setDefaultLocaleID().
960 However, this is only for default locales, which are not needed to
961 change the locale in the URL.
962 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
963 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
964 getSortedRelatedListData(): Add a localeID parameter, so we can get the
965 layout for a particular locale.
966 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
967 Add get/setDefaultLocaleID().
968 getDocumentInfo(), getListViewData(), getRelatedListData(),
969 getDetailsLayoutGroup(), getListViewLayoutGroup(),
970 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
971 localeID parameter, so we can get the layout for a particular locale.
973 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
974 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
975 * src/main/java/org/glom/web/client/place/ListPlace.java:
976 Parse and construct a lang parameter too.
978 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
979 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
980 passed to subsequent methods and constructors.
981 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
982 * src/main/java/org/glom/web/client/activity/ListActivity.java:
983 Store the localeID from the *Place and pass it to other constructors
984 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
986 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
987 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
988 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
989 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
990 * src/main/java/org/glom/web/client/ui/ListView.java:
991 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
992 Take localeID parameters and pass them to subsequent constructors and
993 methods, so that the layout is always retrieved for that locale.
995 This is rather repetitive.
997 Note that "" means the original (default) locale of the Glom document,
998 which is usually English.
1000 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1002 Documents: Remove final keyword to fix startup configuration.
1004 * src/main/java/org/glom/web/shared/Documents.java: Remove the
1005 final keywords on the private member variables because that breaks
1006 the startup, apparently (there are warnings) because it stops them
1007 from being serialized. I added these in the previous commit.
1009 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1011 Documents: Add some final keywords.
1013 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
1016 2012-01-13 Murray Cumming <murrayc@murrayc.com>
1018 OnlineGlomServiceImpl: Add to overview comments.
1020 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1021 Note that this is where all the document are loaded. They are not
1022 loaded freshly for each page.
1024 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1028 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1029 Add a TextBox for the text of a quick find.
1030 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
1032 setBackLink(): Add a String quickFind parameter.
1033 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1034 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
1035 to the base interface, because that is how TableSelectionViewImpl is used.
1036 * src/main/webapp/style.css: Add style for the search box and its label.
1038 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
1039 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
1040 Add these files, based on the existing TableChangeEvent and
1041 TableChangeEventHandlers.
1042 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1043 start(): Handle QuickFindChangeEvent, passing its quickFind text to
1044 a ListPlace() that the user should be taken to.
1045 * src/main/java/org/glom/web/client/activity/ListActivity.java
1046 start(): Handle it here too and adapt the TableChangeEvent handler to
1047 pass the extra "" quickFind parameter to ListPlace.
1048 * src/main/java/org/glom/web/client/place/ListPlace.java:
1049 Constructor: Take an extra String quickFind parameter and store it,
1050 returning it from a new getQuickFind() method.
1051 getToken(): Put the quickFind text in the URL token.
1052 getPlace(): Parse the quickFind text from the URL token.
1053 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1054 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
1055 ListPlace constructor.
1056 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1057 .java: start(): Add a Change handler for the TableSelectionView's
1058 TextBox (via its base HasChangeHandlers interface), firing the new
1059 QuickFindChangeEvent.
1060 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
1061 pass the extra "" quickFind parameter.
1063 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1064 setCellTable(): Add a String quickFind parameter and pass it to
1065 the ListViewTable() constructor.
1066 * src/main/java/org/glom/web/client/ui/ListView.java: Change
1067 setCellTable() in the base interface, because that is how ListViewImpl
1070 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1071 Add a String quickFind member variable.
1072 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1073 Constructor: Add a String quickFind parameter, storing it in the
1074 base ListTable's member variable.
1075 onRangeChanged(): Pass quickFind to the
1076 OnlineGlomServiceAsync.getSortedListViewData() and
1077 OnlineGlomServiceAsync.getListViewData() methods.
1079 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1080 getListViewData(), getSortedListViewData(): Add a String quickFind
1081 parameter, passing it to ConfiguredDocument.getListViewData().
1082 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1083 Change getListViewData(), getSortedListViewData() in the base interface,
1084 because that is how OnlineGlomServiceImpl is used, via this:
1085 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1086 Change getListViewData(), getSortedListViewData() here too.
1087 This class can apparently be used to asynchronously call methods on
1088 OnlineGlomService, and GWT seems to implement that after recognizing
1089 just the *Async name convention and the extra AsyncCallback parameters.
1091 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1092 getListViewData(): Add a String quickFind parameter, and pass it to
1093 ListViewDBAccess.getData().
1094 * src/main/java/org/glom/web/server/database/ListDBAccess.java
1095 getListData(): Add a String quickFind parameter and pass it to
1097 getSelectQuery(): Add a String quickFind parameter.
1098 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1099 getSelectQuery(): Add a String quickFind parameter and use it with
1100 Glom.get_find_where_clause_quick() to pass a where_clause to
1101 Glom.build_sql_select_with_where_clause(), to actually filter the
1103 getData(): Add a String quickFind parameter, passing it to getListData().
1104 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
1105 va: getData(): Pass an empty string to getListData() for the
1106 quickFind parameter.
1108 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1110 ListTable: Minor change.
1112 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1113 createCellTable(): Make this protected instead of public.
1115 2012-01-12 Murray Cumming <murrayc@murrayc.com>
1117 Many files: Use final for the parameters and use the @override attribute.
1119 2012-01-22 Ben Konrath <ben@bagu.org>
1121 Add anchor links for single line text that starts with http, ftp and www.
1125 2012-01-22 Ben Konrath <ben@bagu.org>
1127 Add ellipsis to single line text in details view.
1131 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1133 Remove all javadoc author tags.
1135 Because they are awkward and meaningless when many people touch
1137 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
1139 2012-01-04 Murray Cumming <murrayc@murrayc.com>
1141 Revert the COPYING.LESSER to COPYING rename.
1143 Apparently both should be there if it is LGPL.
1145 2012-01-03 Murray Cumming <murrayc@murrayc.com>
1147 *View: Remove unused imports.
1149 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1150 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1151 * src/main/java/org/glom/web/client/ui/ListView.java:
1152 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1153 Remove unused imports, as suggested by Eclipse.
1155 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1157 Move the *View::Presenter types, and some API into one base View.
1159 * src/main/java/org/glom/web/client/ui/DetailsView.java:
1160 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
1161 * src/main/java/org/glom/web/client/ui/ListView.java:
1162 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
1163 Presenter, setPresenter() and clear() into a shared base interface,
1164 to avoid the unnecessary duplicate Presenter types and to more clearly
1165 show how the *Views share the same structure, even if they are not
1166 used polymorphically.
1168 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
1169 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
1171 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1172 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1173 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
1175 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1178 Feel free to revert this if there is a good reason for the duplicate
1181 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1183 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
1185 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
1186 a class member instead of a local variable in the method.
1187 This lets us use it to get the view instances, for use in tests.
1188 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1189 beforeOnlineGlom(): Test some more details of the initial view.
1190 Again, this is not very useful.
1192 To really test gwt-glom we will need to start a local postgresql
1193 instance with local data, like the Glom tests in C++.
1195 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1197 pom.xml: Mention the LGPL license.
1199 * pom.xml: Add a licenses section.
1200 * COPYING.LESSER: Move this to COPYING, which
1201 previously contained the GPL. But gwt-glom is all LGPL.
1203 2012-01-02 Murray Cumming <murrayc@murrayc.com>
1205 Add project information to README and pom.xml.
1207 * README: Add a brief description and mention some mvn
1209 * pom.xml: This extra information shows up in mvn site
1212 2011-01-02 Murray Cumming <murrayc@murrayc.com>
1214 Use the latest java-libglom version.
1216 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
1218 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1220 GwtTestOnlineGlom: Test a little more.
1222 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
1223 protected rather than private, as suggested by the gwt-test-utils
1225 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
1226 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
1227 Test the initial visibility of the panels.
1229 However, this is not a very useful test.
1230 And I wonder how we should generally test using this idea for an
1231 activity/places app like ours where the real changes happen implicitly
1232 based on the history token/URL.
1234 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1236 Slight modification to *Mapper comments.
1238 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
1239 (DataActivityMapper)
1240 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
1242 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
1244 Remove comments mentioning GIN because they are just copied from
1245 the example code and are apparently not helpful:
1246 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
1247 Also change the mention of a class that is only in the example code.
1249 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1251 GwtTestOnlineGlom test: Minor changes.
1253 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1254 Avoid the long qualified class name and modify the comment
1255 because it is now obvious to me that the mocked class is the only
1256 custom one created via GWT.create().
1258 2012-01-01 Murray Cumming <murrayc@murrayc.com>
1260 Tests: Added the beginnings of a test using gwt-test-utils.
1262 * pom.xml: Add dependencies on gwt-test-utils and easymock.
1263 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
1264 which tells gwt-test-utils what class will be tested.
1265 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1266 Add a simple (but empty) test case. One class, used by the OnlineGlom
1267 class, is mocked so that it can be created. However, I am not sure
1268 why only this class needs to be mocked.
1270 Note that mockito seems more popular, and clearer, than easymock,
1271 but I have not got that working yet. It might be a matter of the
1274 This test is run during mvn integration-test.
1276 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1278 Tests: Use junit4-style syntax instead of junit3-style.
1280 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1281 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1282 * src/test/java/org/glom/web/shared/DataItemTest.java:
1283 Use the @Test annotation rather than relying on the test*() prefix.
1284 Also no longer implement TestCase, to avoid triggering support for
1285 the junit3-way, which stops the annotations from working.
1286 Change the imports from import junit.framework.* to
1287 import org.junit.*, which is apparently the new way.
1289 2011-12-31 Murray Cumming <murrayc@murrayc.com>
1291 Added a test for ListPlace token parsing and creation.
1293 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
1294 This is much the same as DetailsPlaceTest.
1296 I wonder how we could test the other parts of the *Place API.
1298 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1300 DetailsPlace test: Also test getToken() and recreation via getPlace().
1302 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1303 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
1304 recreate it, testing the recreated DetailsPlace for the same parameter
1307 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1309 Use the surefire-report plugin.
1311 * pom.xml: This generates a HTML report about the tests in
1312 target/site/surefire-report.html
1313 when you do mvn surefire-report:report. It seems to be popular/normal.
1315 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1317 Added a test for DetailsPlace.
1319 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
1320 Test the getPlace() token parsing.
1322 2011-12-30 Murray Cumming <murrayc@murrayc.com>
1324 Added a first unit test.
1326 * pom.xml: Add a test goal, and a dependency on junit in that scope.
1327 * src/test/java/org/glom/web/shared/DataItemTest.java:
1328 This is a silly test but it is just to get things started. Note that
1329 maven/junit finds the test because it looks in src/test by default.
1331 2011-12-22 Ben Konrath <ben@bagu.org>
1333 Change charsetName to "UTF-8" when replacing line breaks.
1335 JavaScript requires the charsetName to be "UTF-8". CharsetName values
1336 that work in Java (such as "UTF8") will not work when compiled to
1339 This fixes a problem with multi-line details view fields that have hard
1340 line breaks. The "License Text" field on this page demonstrates the
1343 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
1345 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1347 2011-12-22 Ben Konrath <ben@bagu.org>
1349 Fix another bug with related list navigation.
1351 I've tested all the navigation buttons in all of the related lists
1352 so things should be good now.
1354 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1356 2011-12-22 Ben Konrath <ben@bagu.org>
1358 Fix a crasher when refreshing the list view with the default table.
1360 This crash will also happen when loading the list view with the default
1361 table from a link or bookmark.
1363 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
1364 to the main document selection page when the document id hasn't been
1366 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
1367 the main document selection page when the document id hasn't been
1369 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
1370 values for the details place when the document id hasn't been set.
1371 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
1372 values for the list place when the document id hasn't been set.
1374 2011-12-21 Ben Konrath <ben@bagu.org>
1376 Protect against NPE when glom.document.locale is not in config.
1378 This patch protects against an NPE when glom.document.locale is not in
1379 the config file. This NPE will also happen if glom.document.locale is
1382 The patch also updates the error message to display the class name when
1383 the getMessage() returns null. This was happening when the NPE was
1384 thrown and I had "Configuration Error: null". If an NPE is encountered
1385 with this patch, "Configuration Error: NullPointerException " will be
1388 This commit closes this bug:
1390 https://bugzilla.gnome.org/show_bug.cgi?id=666669
1392 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1394 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1396 Rename onlineglom.properties to onlineglom.properties.sample.
1398 * src/main/resources/onlineglom.properties: Rename to:
1399 * src/main/resources/onlineglom.properties.sample:
1400 * src/main/resources/README: And add this file explaining that people
1401 should rename it back when deploying.
1403 2011-12-20 Murray Cumming <murrayc@murrayc.com>
1405 Allow choosing the translation in the .properties file.
1407 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1408 init(): Read a glom.document.locale value from the configuration file
1409 and call Glom's TransatableItem::set_current_locale() method.
1410 * src/main/resources/onlineglom.properties: Add a commented-out
1411 example of this new setting.
1413 It would be better to add &lang=de_DE to the URL, but the current
1414 libglom API does not allow us to do this easily. I am working on that.
1416 2011-12-19 Murray Cumming <murrayc@murrayc.com>
1418 Avoid a crash in parsing of token parameters.
1420 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
1421 ava: getTokenParams(): Do not crash if a parameter has a key but no
1422 value, and ignore parameters with neither.
1424 2011-12-17 Murray Cumming <murrayc@murayc.com>
1426 History token building/handling: Improve use of token parameters.
1428 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1429 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
1430 and buildParamsToken(HashMap), for use by derived classes.
1431 Make the separator private because it is no longer be needed.
1432 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1433 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
1434 instead of manual string concatenation.
1435 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
1436 of hardcoded indices and awkward splitting code.
1437 * src/main/java/org/glom/web/client/place/ListPlace.java
1438 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
1439 instead of manual string concatenation.
1440 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
1441 of hardcoded indices and awkward splitting code.
1442 This should fix bug #666420
1444 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1446 Fix a Navgiation->Navigation typo in the code.
1448 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1449 Rename processNavgiation() to processNavigation().
1451 2011-12-16 Murray Cumming <murrayc@murrayc.com>
1453 Fix a seperator->separator typo in the code.
1455 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1456 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1457 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
1460 2011-12-15 Ben Konrath <ben@bagu.org>
1462 Cleanup some comments.
1464 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1466 2011-12-14 Ben Konrath <ben@bagu.org>
1468 Replace \n with <br/> for multiline text in the details view.
1470 Vertical scrollbars are added when needed as well.
1472 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1474 2011-12-14 Ben Konrath <ben@bagu.org>
1476 Specify the font for document selection links.
1478 * src/main/webapp/style.css:
1480 2011-12-14 Ben Konrath <ben@bagu.org>
1482 Fix bouncy CellTable while paging.
1484 This doesn't currently work with related list tables in unselected
1487 * src/main/java/org/glom/web/client/ui/list/ListTable.java
1489 2011-12-14 Ben Konrath <ben@bagu.org>
1491 Revamp the appearance of the document selection page.
1493 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1494 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
1495 * src/main/webapp/style.css:
1497 2011-12-13 Ben Konrath <ben@bagu.org>
1499 Set navigation button column to the smallest size possible.
1501 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1503 2011-12-13 Ben Konrath <ben@bagu.org>
1505 Change OpenButton nomenclature to NavigationButton.
1507 Using NavigtionButton makes things more generic. Classes, methods and
1508 variables have been changed.
1510 This is a rename-only refactor.
1512 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1513 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1514 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
1515 Renamed from OpenButtonCell.
1516 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1517 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1518 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1520 2011-12-12 Ben Konrath <ben@bagu.org>
1522 Remove unnecessary String argument in RelatedListTable and ListViewTable.
1524 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1525 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1526 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1527 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1529 2011-12-12 Ben Konrath <ben@bagu.org>
1531 Update variable names and comments.
1533 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1534 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1536 2011-12-12 Ben Konrath <ben@bagu.org>
1538 Properly initialize numNonEmptyRows variable to zero.
1540 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1541 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1543 2011-12-05 Ben Konrath <ben@bagu.org>
1545 Add latest mockup with HTML tables.
1547 Features of this mockup:
1549 -> HTML table for flowtable
1550 -> HTML table for flowtable column
1551 -> Example of how related lists would look
1552 -> Not using text entries for data items
1554 The current version of Online Glom doesn't use HTML tables for the
1557 This mockup has been sent to the glom-devel mailing list but it's good
1558 to have it here as well.
1560 * mockups/details-view-html-tables.html:
1562 2011-12-05 Ben Konrath <ben@bagu.org>
1564 Remove unnecessary getPrimaryKeyField() method.
1566 getPrimaryKeyFieldForTable(String) has been renamed to
1567 getPrimaryKeyField(String).
1569 * src/main/java/org/glom/web/server/database/DBAccess.java:
1570 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1571 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1573 2011-12-05 Ben Konrath <ben@bagu.org>
1575 Add string representation of TypedDataItem value to conversion error message.
1577 * src/main/java/org/glom/web/server/Utils.java: Logging the error
1578 message was extracted into its own method to avoid duplication.
1580 2011-12-05 Ben Konrath <ben@bagu.org>
1582 Add type checking to navigation primary key value creation.
1584 Create navigation primary key only if the expected type from the Glom
1585 document matches the type returned by the SQL query.
1587 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1589 2011-12-05 Ben Konrath <ben@bagu.org>
1591 Rename a couple of variables in RelatedListNavigation.
1593 This is a rename-only refactor.
1595 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1597 2011-12-05 Ben Konrath <ben@bagu.org>
1599 Move getListLayoutGroup() into getListViewLayoutGroup().
1601 This removes getListLayoutGroup(). It was only being called by
1602 getListViewLayoutGroup().
1604 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1606 2011-12-05 Ben Konrath <ben@bagu.org>
1608 Remove check for LayoutItem_Portal in list table method.
1610 This check is no longer necessary because the method isn't being used
1611 to create the LayoutItemPortal DTO.
1613 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1615 2011-12-05 Ben Konrath <ben@bagu.org>
1617 Properly support related list navigation.
1619 Navigation from the "Repository Analyzer -> Package Scans ->
1620 Dependencies" related table wasn't working because the primary key for
1621 related tables wasn't being set properly. This commit fixes the
1624 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
1625 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
1626 doesn't set the primary key properly for related list tables.
1627 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
1628 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
1629 useful for getting the primary key for list view tables and for related
1631 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1632 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1633 Move code to set the primary key for the table from the abstract
1634 ListDBAccess class to ListViewDBAccess as it's only correct for list
1636 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1637 Properly add primary key to related list tables.
1639 2011-12-02 Ben Konrath <ben@bagu.org>
1641 Properly set the horizontal alignment of fields.
1643 This fix is for both the list tables and the details view.
1645 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
1646 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
1647 to set the horizontal alignment of fields.
1649 2011-12-02 Ben Konrath <ben@bagu.org>
1651 Display currency codes in the details view.
1653 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1655 2011-12-02 Ben Konrath <ben@bagu.org>
1657 Avoid duplicate JNI call.
1659 JNI is not as efficient as pure Java and this is an easy (and small)
1662 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1663 Use previously retrieved value for whereClauseToTableName instead of
1666 2011-12-02 Ben Konrath <ben@bagu.org>
1668 Rename a couple of variables in RelatedListNavigation.
1670 This is a rename-only refactor.
1672 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1674 2011-12-02 Ben Konrath <ben@bagu.org>
1676 Indicate clearly that a mismatched primary key type is a bug.
1678 * src/main/java/org/glom/web/server/Utils.java: Change log level from
1679 warning to error. Add 'This is a bug.' to message.
1681 2011-12-02 Ben Konrath <ben@bagu.org>
1683 Update / fix some comments.
1685 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
1687 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
1689 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1690 Fix comments. Add some TODOs.
1692 2011-12-02 Ben Konrath <ben@bagu.org>
1694 Enable navigation to details view with string primary key from related list.
1696 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1697 Create a text primary key value when return type of result is
1698 java.sql.Types.VARCHAR.
1700 2011-12-02 Ben Konrath <ben@bagu.org>
1702 Use checkboxes for booleans in the details view.
1704 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1706 2011-12-01 Ben Konrath <ben@bagu.org>
1708 Improve performance of related list height calculation.
1710 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1711 Put code to calculate the expected height in a static initializer so
1712 that that it's only called once.
1714 2011-12-01 Ben Konrath <ben@bagu.org>
1716 Show related list tables in notebooks (again).
1718 Calculate the height of the related list tables so the Notebook can be
1719 set the correct height. The height of the related list table is also needed by
1720 FlowTable to be able decide how to create the layout.
1722 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
1723 and set the Portal height based on the height of the related list
1724 table and the Portal container.
1725 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1726 Add method to calculate the height of the related list tables.
1727 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1728 * src/main/webapp/style.css: Add css class for Pager. This is needed to
1729 calculate the height of the Pager widget.
1731 2011-12-01 Ben Konrath <ben@bagu.org>
1733 Use CellTable API for table property instead of setting style on Element.
1735 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1737 2011-12-01 Ben Konrath <ben@bagu.org>
1739 Make ListViewTable and RelatedListTable a consistent height.
1741 The tables are now a consistent height regardless of the contents of
1742 the table. A hidden button is added to empty rows to ensure that the
1743 height of these rows will match the height of rows with data.
1745 A navigation button column is now added to every table. The width of
1746 the navigation column is set to 0px when a RelatedListTable shouldn't
1747 have navigation buttons. This maintains the a consistent row height in
1748 tables that don't show the navigation buttons.
1750 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
1751 navigation column when not needed.
1752 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
1753 arguments for navigation button to constructor of ListViewTable.
1754 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
1755 hidden button for empty data rows.
1756 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
1757 arguments for navigation button to constructor.
1758 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
1759 create navigation buttons. Add hideNavigationButtons() method.
1760 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
1761 arguments for navigation button to constructor.
1763 2011-12-01 Ben Konrath <ben@bagu.org>
1765 Use 'visibility: hidden' in Utils.getWidgetHeight().
1767 This is better choice because hidden elements are invisible, don't
1768 respond to events and are not part of the tab order. They will,
1769 however, take up space which is required to be able to calculate the
1770 height of the widget.
1772 * src/main/java/org/glom/web/client/Utils.java:
1774 2011-12-01 Ben Konrath <ben@bagu.org>
1776 Use Utils.getWidgetHeight() in FlowTable.
1778 * src/main/java/org/glom/web/client/Utils.java: Remove TODO item about
1780 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
1782 2011-12-01 Ben Konrath <ben@bagu.org>
1784 Put the details css class name on the correct table column.
1786 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1788 2011-11-30 Ben Konrath <ben@bagu.org>
1790 Update for java-libglom API change.
1792 The getters and setters on FieldFormatting and NumericFormat were
1793 changed to remove the 'M'.
1795 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1797 2011-11-29 Ben Konrath <ben@bagu.org>
1799 Only allow RelatedListTables in Portals.
1801 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1803 2011-11-29 Ben Konrath <ben@bagu.org>
1805 Only create a contents panel for Portals when title is being set.
1807 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1809 2011-11-29 Ben Konrath <ben@bagu.org>
1811 Set TabLayoutPanel height based on calculated height its widgets.
1813 This is a potential fix for this bug:
1815 https://bugzilla.gnome.org/show_bug.cgi?id=665133
1817 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1819 2011-11-29 Ben Konrath <ben@bagu.org>
1821 Align details field labels and data with the Open buttons.
1823 * src/main/webapp/style.css:
1825 2011-11-29 Ben Konrath <ben@bagu.org>
1827 Remove unnecessary <div> in the Notebook widget.
1829 * src/main/java/org/glom/web/client/ui/details/Group.java: Remove
1830 method to get container FlowPanel (<div>).
1831 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Run the
1832 initWidget() method directly on the TabLayoutPanel widget instead of
1833 Group's container widget.
1835 2011-11-29 Ben Konrath <ben@bagu.org>
1837 Don't add group titles for Portals in Notebooks.
1839 This reverts the previous patch and fixes a bug I introduced with
1840 commit b1753fd27bd2c4ea189c4c353e0ece92dcc66c2c .
1842 * src/main/java/org/glom/web/client/ui/details/Group.java:
1843 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1845 2011-11-28 Ben Konrath <ben@bagu.org>
1847 Remove unused boolean argument in Portal constructor.
1849 Just a code cleanup.
1851 * src/main/java/org/glom/web/client/ui/details/Group.java:
1852 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1854 2011-11-28 Ben Konrath <ben@bagu.org>
1856 Remove hack for glom 1.18 style glom files.
1858 * src/main/java/org/glom/web/client/ui/details/Group.java:
1859 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
1860 * src/main/java/org/glom/web/client/ui/details/Portal.java:
1862 2011-11-28 Ben Konrath <ben@bagu.org>
1864 Use Gda Value version of primary key to log result too large error.
1866 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1868 2011-11-28 Ben Konrath <ben@bagu.org>
1870 Don't use TypedDataItem.getText() for Unknown types from the URL.
1872 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1873 * src/main/java/org/glom/web/server/Utils.java: Use getUnknown()
1874 instead of getText().
1875 * src/main/java/org/glom/web/shared/TypedDataItem.java: Add unknown
1876 String field and getUnknown() method.
1878 2011-11-28 Ben Konrath <ben@bagu.org>
1880 Log an error message when the java-libglom .so is not present.
1882 The error message was being set in the exception but not logged.
1884 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1886 2011-11-28 Ben Konrath <ben@bagu.org>
1888 Ignore LayoutItem_CalendarPortals.
1890 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't
1891 create the LayoutItemPortal DTO for LayoutItem_CanendarPortals.
1893 2011-11-28 Ben Konrath <ben@bagu.org>
1895 Extract method for creating the LayoutItemPortal DTO.
1897 Just breaking the code up into smaller chunks.
1899 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1901 2011-11-28 Ben Konrath <ben@bagu.org>
1905 This should have been added with the refactor. Oops!
1907 * src/main/java/org/glom/web/shared/TypedDataItem.java:
1909 2011-11-28 Ben Konrath <ben@bagu.org>
1911 Create primary key value from URL string using type from Glom document.
1913 See this bug, comments 19 - 25:
1915 https://bugzilla.gnome.org/show_bug.cgi?id=662376#c19
1917 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Don't
1918 create a TypeDataItem for the primary key here when loading from a
1919 URL. Show the same string for the primary key value as was received
1920 from the URL string (when loading from a URL).
1921 * src/main/java/org/glom/web/server/Utils.java: Update method for
1922 creating the Gda Value from the TypeDataItem to properly deal with
1923 creating a Gda Value based on the Glom document type for the primary
1924 key value string when loading from a URL.
1925 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1926 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1927 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1928 Update for changed method name.
1930 2011-11-27 Ben Konrath <ben@bagu.org>
1932 Rename PrimaryKeyItem to TypedDataItem.
1934 The name PrimaryKeyItem suggests what the class should be used for.
1935 TypedDataItem is a neutral name that describes the class better.
1937 This is a rename-only refactor.
1939 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1940 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1941 * src/main/java/org/glom/web/client/Utils.java:
1942 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1943 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
1944 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1945 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1946 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
1947 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1948 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1949 * src/main/java/org/glom/web/server/Utils.java:
1950 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1951 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1952 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1953 * src/main/java/org/glom/web/shared/NavigationRecord.java:
1955 2011-11-25 Ben Konrath <ben@bagu.org>
1957 Improve Gda Value conversion from PrimaryKeyItem.
1959 The value from the PrimaryKeyItem is only used if its type match the
1960 type from the glom document.
1962 * src/main/java/org/glom/web/server/Utils.java:
1964 2011-11-25 Ben Konrath <ben@bagu.org>
1966 Manually check if the java-liblgom .so is visible to the JVM.
1968 It seems that Tomcat has problems when a static initializer throws an
1969 exception. This check is done before the first method call into
1970 java-libglom so that execution doesn't continue if the .so is not
1973 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1975 2011-11-25 Ben Konrath <ben@bagu.org>
1977 Improve browser configuration error messages.
1981 https://bugzilla.gnome.org/show_bug.cgi?id=662792
1983 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1984 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java: Add
1985 getConfigurationErrorMessage() method.
1986 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
1987 Get and display a specific configuration error message when no Glom
1988 documents are found.
1989 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1990 Implement getConfigurationErrorMessage() method. Surround configuration
1991 code in the init() method with a try/catch block. This allows the
1992 errors to be caught while keeping the servlet available to retrieve the
1993 configuration error message.
1995 2011-11-25 Ben Konrath <ben@bagu.org>
1997 Don't use Strings to hold primary key values.
1999 The primary key values are now held in a new data object
2000 (PrimaryKeyItem) that holds type information and the primary key value
2001 using the correct type.
2003 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2004 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2005 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2006 PrimaryKeyItem instead of String to hold the primary key value.
2007 * src/main/java/org/glom/web/client/Utils.java: Remove
2008 getKeyValueStringForQuery(). Add getPrimaryKeyItem() which creates a
2009 PrimaryKeyItem based on the GlomFieldType and the DataItem.
2010 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Use
2011 PrimaryKeyItem instead of String to hold the primary key value. Load
2012 document selection page when the documentID has not been set correctly.
2013 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Re-work
2014 DetailsPlace -> URL and URL -> DetailsPlace conversion with
2016 * src/main/java/org/glom/web/client/place/DocumentSelectionPlace.java:
2017 Return empty string for URL instead of "null".
2018 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2019 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2020 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2021 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2022 PrimaryKeyItem instead of String to hold primary key values.
2023 * src/main/java/org/glom/web/server/Utils.java: New method to convert a
2024 PrimaryKeyValue to a Gda Value.
2025 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2026 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2027 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2028 Replace temporary database access code that uses the PrimaryKeyValue to
2029 Gda Value conversion.
2030 * src/main/java/org/glom/web/shared/DataItem.java: Add comment.
2031 * src/main/java/org/glom/web/shared/NavigationRecord.java: Use
2032 PrimaryKeyItem instead of String.
2033 * src/main/java/org/glom/web/shared/PrimaryKeyItem.java: New class to
2034 hold primary key values.
2036 2011-11-24 Ben Konrath <ben@bagu.org>
2038 Use newly added java-libglom API to create queries.
2040 This isn't finished. I still need to stop using Strings for primary key
2041 values in the client code.
2043 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Tell
2044 libglom to use fake connections so that retrieving the query string will
2046 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2047 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2048 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2049 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2050 Use the newly added libglom sql methods and classes to create the
2051 query. Add temporary hack to convert primary value strings to Gda
2054 2011-11-23 Ben Konrath <ben@bagu.org>
2056 Don't explicitly set the height of Portals.
2058 See comments 6 - 10 of this bug for details:
2060 https://bugzilla.gnome.org/show_bug.cgi?id=662930#c6
2062 * src/main/java/org/glom/web/client/ui/details/Portal.java:
2064 2011-11-23 Ben Konrath <ben@bagu.org>
2066 Use an HTML table instead of CSS for the FlowTable layout.
2068 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Use
2069 GWT's FlexTable to implement the FlowTable.
2070 * src/main/webapp/style.css: Adjust CSS for the change to FlexTable.
2072 2011-11-18 Ben Konrath <ben@bagu.org>
2074 Add boolean example to HTML table mockup.
2076 * mockups/details-view-html-tables-text-entries.html:
2078 2011-11-17 Ben Konrath <ben@bagu.org>
2080 Ensure the pager buttons are always visible for related lists.
2082 To accomplish this, I've turned off text wrapping in the list view and
2083 related list tables for both the header and data text. The related list
2084 table now has a fixed layout so the it doesn't overflow its container.
2085 This is required to ensure that the cell text is clipped when it
2086 overflows the cell and an ellipsis is added to the right side of the
2087 cell when text is clipped.
2089 A fixed table layout for the related list table in the details view
2090 seems what we want for the details view anyway, so the side-effect is
2093 The ellipsis will only be displayed in Firefox >= 7.
2097 https://bugzilla.gnome.org/show_bug.cgi?id=662930
2099 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java:
2100 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: Add
2101 'overflow: hidden; text-overflow: ellipsis;' CSS properties to the table
2103 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2104 Set the 'table-layout: fixed' CSS property to the related list table.
2105 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Set the
2106 'white-space: nowrap;' CSS property on both the list view and the
2107 related list tables.
2109 2011-11-16 Ben Konrath <ben@bagu.org>
2111 Rework the fix for empty notebook tab labels.
2113 Setting the empty group titles with its name caused problems for the
2114 details layout. Instead of using libglom's
2115 LayoutItem.get_title_or_name(), the LayoutItem name is explicitly sent
2116 to the client when the title is empty. This allows the Notebook to use
2117 the name when the title is empty without affecting anything else.
2119 * src/main/java/org/glom/web/client/ui/details/Notebook.java:
2120 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2122 2011-11-16 Ben Konrath <ben@bagu.org>
2124 Set group titles with name when title is empty.
2126 This fixes a problem with an empty notebook tab label in the Lesson
2127 Planner document. The forth tab in the notebook should be "Internet":
2129 http://bagu.org:8080/OnlineGlom/#details:document=lesson-planner&table=teachers&value=0
2131 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2132 libglom's LayoutItem.get_title_or_name() to fill in the LayoutGroup
2135 2011-11-16 Ben Konrath <ben@bagu.org>
2137 Remove whitespace from the configured username properties.
2139 This assumes that usernames won't have whitespace at the beginning
2140 or end. But I think this is a reasonable assumption.
2142 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Use
2143 String.trim() to remove the whitespace from the username properties.
2145 2011-11-15 Ben Konrath <ben@bagu.org>
2147 Add details view mockup with HTML tables and text entries.
2149 This is from the attachment on this bug:
2151 https://bugzilla.gnome.org/show_bug.cgi?id=663109
2153 * mockups/details-view-html-tables-text-entries.html:
2155 2011-11-15 Ben Konrath <ben@bagu.org>
2157 Add space between the columns of the flow table.
2161 https://bugzilla.gnome.org/show_bug.cgi?id=662918
2163 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Add a 1%
2164 space between columns in the flow table.
2166 2011-11-15 Ben Konrath <ben@bagu.org>
2168 Add backup files to the .gitignore.
2170 * .gitignore: Ignore files that end with ~.
2172 2011-11-09 Ben Konrath <ben@bagu.org>
2174 Use latest release of gwt-log.
2176 Gwt-log releases are now being submitted to the maven central
2177 repository so manual installation of the jar is no longer required.
2179 * pom.xml: Update version and groupId of gwt-log dependency.
2181 2011-10-31 Ben Konrath <ben@bagu.org>
2183 Don't use GWT numeric formatting to override the glom currency formatting.
2185 Currencies are now displayed like they are in Glom. See this bug:
2187 https://bugzilla.gnome.org/show_bug.cgi?id=646216
2189 * src/main/java/org/glom/web/client/Utils.java: Remove GWT currency
2191 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: Add
2192 currency code to constructor and set it when the cell is rendered.
2193 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2194 currency code to the constructor of the NumericCell.
2196 2011-10-27 Ben Konrath <ben@bagu.org>
2198 Require the latest release of java-libglom (1.17.4).
2202 2011-10-26 Ben Konrath <ben@bagu.org>
2204 Add style to Notebook that matches current theme.
2206 It's not the best style in the world but it's better than the default.
2208 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Add some
2209 padding at the bottom of the child widgets.
2210 * src/main/webapp/style.css: Add style for the Notebook.
2212 2011-10-26 Ben Konrath <ben@bagu.org>
2214 Move servlet initialization code to overridden init method.
2216 This is half of the solution to getting proper error messages
2217 displayed when configuration errors occur. Here's the relevant bug:
2219 https://bugzilla.gnome.org/show_bug.cgi?id=662792
2221 The rest of the solution involves surrounding the init method with a
2222 try/catch block and setting a global variable with the error /
2223 exception. A new async method should be created to retrieve and display
2224 the error message / exception.
2226 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Move
2227 code from constructor to init method adding exceptions as needed.
2229 2011-10-26 Ben Konrath <ben@bagu.org>
2231 Add script to monitor and restart tomcat if required.
2233 * utils/check-and-recover-tomcat.py: New file.
2235 2011-10-26 Ben Konrath <ben@bagu.org>
2237 Display the correct number of data items in the pager.
2241 https://bugzilla.gnome.org/show_bug.cgi?id=661441
2243 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2244 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2245 The implementation is the same for both tables: Keep track of the
2246 number of non-empty rows and fire and RowCountChangeEvent after the data has
2248 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add a
2249 custom Pager class that subclasses SimplePager to handle displaying
2250 the correct number when empty rows have been added.
2252 2011-10-26 Ben Konrath <ben@bagu.org>
2254 Correct error in previous commit.
2256 * src/main/java/org/glom/web/client/activity/ListActivity.java: Remove
2257 eventBus parameter from listView.setCellTable().
2259 2011-10-26 Ben Konrath <ben@bagu.org>
2261 Fix error in TODO comment.
2263 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2265 2011-10-24 Ben Konrath <ben@bagu.org>
2267 Create Notebook widgets to the details view.
2269 This isn't finished just yet - I still need to create a reasonable
2270 style to match the current theme.
2272 * src/main/java/org/glom/web/client/Utils.java: Add method for
2273 calculating the height of a widget. This is used in the Notebook class.
2274 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update for
2275 new constructor method in Group.
2276 * src/main/java/org/glom/web/client/ui/details/Group.java: Add new
2277 method for creating child widget that can be used by subclasses
2278 like Notebook. New constructor that allows disabling the group
2279 titles - Notebooks don't set a group title for their child groups.
2280 * src/main/java/org/glom/web/client/ui/details/Notebook.java: New class
2281 to make Notebooks using GWT's TabLayoutPanel.
2282 * src/main/java/org/glom/web/client/ui/details/Portal.java: New
2283 constructor that allows disabling the group titles.
2284 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Create the
2285 LayoutItemNotebook DTO.
2286 * src/main/java/org/glom/web/shared/layout/LayoutItemNotebook.java: New
2287 DTO for Notebooks. It's just an empty class for now but we might need
2288 it to transfer some specific information in the future.
2290 2011-10-21 Ben Konrath <ben@bagu.org>
2292 Add navigation buttons to related list tables.
2294 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2295 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2296 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Add new
2297 method getSuitableRecordToViewDetails() for getting the table name
2298 and primary key value for related list navigation buttons.
2299 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2300 private cell renderer class to get the navigation information for
2301 related list tables from the server. Extract the navigation
2302 processing code from the details cell navigation and use it for the
2303 related list navigation as well.
2304 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Add private
2305 cell renderer class for the details open buttons. This was needed
2306 because the related list navigation buttons and the list view
2307 navigation buttons need to react differently when clicked.
2308 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Remove
2309 the onEnterKeyDown() method because it's now overriden in the
2310 subclasses that are specific to the related list tables and the list
2312 * src/main/java/org/glom/web/client/ui/details/Portal.java: Increase
2313 the vertical size a little because the buttons add a bit of vertical
2314 space to table. This is not a perfect solution because the vertical
2315 size of with table fewer than 5 rows will be a little smaller.
2316 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Update for
2317 changes in how navigation buttons are handled.
2318 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Implement
2319 getSuitableRecordToViewDetails() using the new RelatedListNavigation
2320 database access object.
2321 * src/main/java/org/glom/web/server/database/DBAccess.java: Move code
2322 to find the portal for a given relationship name from
2323 RelatedListDBAccess. Add method to find a primary key field for a
2325 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2326 Move code to find the portal for a given relationship name to
2328 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2329 New file: database access object for getting the related list
2330 navigation information (the table name and the primary key value).
2331 * src/main/java/org/glom/web/shared/NavigationRecord.java: New file:
2332 DTO for transferring a table name to navigate to and a primary key
2334 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2335 boolean and getter/setter to specifies if the related list should add
2338 2011-10-24 Murray Cumming <murrayc@murrayc.com>
2340 Use the master branch of java-libglom
2342 * pom.xml: Depend on java-libglom 1.19 instead.
2344 This is the master branch. See also the libglom-1-18 branch.
2346 2011-10-11 Ben Konrath <ben@bagu.org>
2348 Enable the open navigation button when the data has been set.
2350 This avoids having active buttons that don't do anything when the data
2353 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2355 2011-10-11 Ben Konrath <ben@bagu.org>
2357 Use IsWidget interface for FlowTableItem.
2359 * src/main/java/org/glom/web/client/ui/details/FlowTable.java: Change
2360 FlowTableItem.getWidget() to asWidget() from the IsWidget interface.
2362 2011-10-11 Ben Konrath <ben@bagu.org>
2364 Remove GWT styling from open button in details view.
2366 There are still some issues with how the details cell is arranged but
2367 this should be made to match Glom 1.20. I'm going to leave fixing this
2368 until I have Glom 1.20 up and running.
2370 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Set
2371 style name on open button.
2372 * src/main/webapp/style.css: Move and edit details-navigation class.
2373 Re-arrange some classes to make them appear in the same order as the
2376 2011-10-07 Ben Konrath <ben@bagu.org>
2378 Update to GWT 2.4.0.
2380 * .gitignore: Ignore new cache directory.
2381 * .settings/com.google.gwt.eclipse.core.prefs: Update Eclipse settting.
2382 * pom.xml: Change GWT and maven plugin to 2.4.0.
2383 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Update doctype for
2385 * src/main/java/org/glom/web/client/ClientFactory.java:
2386 * src/main/java/org/glom/web/client/ClientFactoryImpl.java:
2387 * src/main/java/org/glom/web/client/OnlineGlom.java:
2388 Update source for API changes.
2389 * utils/build-onlineglom-war.sh: Remove cache directory before the
2392 2011-10-07 Ben Konrath <ben@bagu.org>
2394 Add navigation buttons in the details view.
2396 This isn't finished but I thought I'd commit what I have as it's a
2397 pretty good start. I still need to:
2399 1. Change the style so that it fits better into the current theme
2400 2. Adjust the details cell to expand as much as possible.
2402 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Add
2403 click handlers to navigation buttons in the DetailsCells. Create a
2404 refreshData() method to get just the data from the server without the
2406 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2407 Update the tableSelector and browser title when the table name
2408 changes without using the tableSelector.
2409 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2410 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2411 getDetailsCells() to getCells(). Update variable names.
2412 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Add
2413 method to set click handler on navigation button. Rename a few
2414 variables. Add navigation buttons where needed.
2415 * src/main/java/org/glom/web/client/ui/details/Group.java: Rename a few
2416 variables and methods.
2417 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Set the
2418 navigation boolean and navigation table as required in the
2419 LayoutItemField DTO.
2420 * src/main/java/org/glom/web/shared/layout/LayoutItemField.java: Add
2421 variables for navigation along with getter/setter methods.
2423 2011-10-07 Ben Konrath <ben@bagu.org>
2425 Rename Field to DetailsCell.
2427 This is a refactor-only commit. No functionality has been added or
2430 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2431 Update variable and method names.
2432 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2433 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Update
2434 variable and method names.
2435 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2437 * src/main/java/org/glom/web/client/ui/details/Group.java: Update
2438 variable and method names.
2440 2011-10-07 Ben Konrath <ben@bagu.org>
2442 Create separate methods for layout and data the details view.
2444 This is a refactor-only commit. No functionality has been added or
2447 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: New
2448 private methods: setData(), createLayout().
2450 2011-10-07 Ben Konrath <ben@bagu.org>
2452 Don't use TableSelectorImpl implementation details in TableSelectorActivity.
2454 This is part of a change to get navigation buttons in the details view
2455 but it should have been done this way from the start.
2457 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2458 for method name change in TableSelectionView.
2459 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2460 Create TableChangeEvent and set the browser title using the
2461 TableSelectionView API.
2462 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2463 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2464 Change getSelectedTable() to getSelectedTableName(). Add
2465 getSelectedTableTitle().
2467 2011-10-07 Ben Konrath <ben@bagu.org>
2469 Use primaryKeyValue naming convention in constructor of DetailsPlace.
2471 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2473 2011-10-07 Ben Konrath <ben@bagu.org>
2475 Update TableChangeEvent to use newTableName naming convention.
2477 This makes the class more consistent with GWT naming conventions.
2479 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2480 Update for method name change in TableChangeEvent.
2481 * src/main/java/org/glom/web/client/activity/ListActivity.java: Update
2482 for method name change in TableChangeEvent.
2483 * src/main/java/org/glom/web/client/event/TableChangeEvent.java: Update
2484 newTableName variable and getter method. Make toDebugString()
2487 2011-09-30 Ben Konrath <ben@bagu.org>
2489 Disable the pager in the list tables when the data row count is less than the minimum.
2491 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2492 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2494 2011-09-30 Ben Konrath <ben@bagu.org>
2496 Add empty rows to the end of related list and list view tables.
2498 I also extracted the cell rendering classes from the ListTable because
2499 the code was becoming a little crazy with all the anonymous inner
2500 classes. My plan is to use these cell rendering classes in the details
2501 view as well so this refactor will be needed for that change.
2503 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Only
2504 set the row count in related list tables if the data has more rows
2505 than the minimum number of rows visible.
2506 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Only set the
2507 row count in list view tables if the data has more rows than the
2508 minimum number of rows visible.
2509 * src/main/java/org/glom/web/client/ui/cell/BooleanCell.java: New class
2510 for rendering TYPE_BOOLEAN cells. The code was extracted from the
2512 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java: New class
2513 for rendering TYPE_NUMERIC cells. The code was extracted from the
2515 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: New
2516 class for rendering cells with buttons in list views. The code was
2517 extracted from the ListTable class.
2518 * src/main/java/org/glom/web/client/ui/cell/TextCell.java: New class
2519 for rendering TYPE_TEXT cells. The code was extracted from the
2521 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2522 Add empty rows to the end of the data if required. Implement
2523 ListTable.getMinNumVisibleRows().
2524 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Extract
2525 cell renderer code to public classes. Return null in
2526 Column.getValue() for empty rows. Add new abstract method:
2527 getMinNumVisibleRows(). Move code to set the row count of the list view
2528 table to ListViewImpl.
2529 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add
2530 empty rows to the end of the data if required. Implement
2531 ListTable.getMinNumVisibleRows().
2534 2011-09-27 Ben Konrath <ben@bagu.org>
2536 Use GWT.log for client-side debugging statements.
2538 These are optimized out when deployed so I should have used this method
2539 in the first place. These statements will eventually be replaced with some sort
2540 of notification in the browser.
2542 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2543 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2544 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2545 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2546 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2548 2011-09-27 Ben Konrath <ben@bagu.org>
2550 Put tableselector on the right, back to list link on right.
2552 The idea is that the table selector is acting like a label for the
2553 currently displayed table so it should be placed below the document title. This
2554 puts the table title in a similar position to where it is in Glom.
2556 * mockups/details-contacts.html:
2557 * mockups/details-projects.html:
2558 * mockups/listview-contacts.html:
2559 * mockups/listview-projects.html:
2560 * mockups/style.css:
2561 Update mockups to match how the interfaces currently look.
2562 * src/main/webapp/style.css: Swap positions of backlink with the table
2563 selector. Add some space on the left side of the table selector to
2564 line things up with the document title.
2566 2011-09-27 Ben Konrath <ben@bagu.org>
2568 Add field colouring to details view.
2570 This change re-works how field colouring works. The colour formatting
2571 information is now set to the client with the layout information instead of
2572 with the data. This eliminates the need to send the same colour strings for
2573 data in list view column when colour information is set.
2575 In order to set an alternate colour for negative numeric values, the
2576 number is now sent to client and formatted with the GWT NumberFormat class.
2578 This change also fixes:
2580 https://bugzilla.gnome.org/show_bug.cgi?id=659752
2582 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add the GWT
2583 internationalization framework which is needed for client side numeric
2585 * src/main/java/org/glom/web/client/Utils.java: New file for some
2586 client static utility methods.
2587 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Pass
2588 the DataItem object to the Field class. Use a utility method to
2589 create the foreignKeyValue string.
2590 * src/main/java/org/glom/web/client/ui/details/Field.java: Set
2591 alignment and text colours in the constructor. Add setData(DataItem)
2592 method. Remove setText(String) method.
2593 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Add the
2594 colour information to GlomTextCell. Create and use GlomNumberCell for
2595 rendering numbers. Use utility method to get the string for the
2596 primary key of the key provider. Re-work how the horizontal alignment
2598 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2599 formatting to layout information. Methods for converting the libglom
2600 formatting information were moved from DBAccess.
2601 * src/main/java/org/glom/web/server/database/DBAccess.java: Remove
2602 numeric formatting (it's now done on the client side). Don't set text
2603 colours in DataItem. Move libglom formatting conversion methods to
2605 * src/main/java/org/glom/web/shared/DataItem.java: Remove fields and
2606 getters/setters for text colour information.
2607 * src/main/java/org/glom/web/shared/GlomNumericFormat.java: New file
2608 for transferring the libglom NumericFormat information to the client.
2609 * src/main/java/org/glom/web/shared/layout/Formatting.java: Add fields
2610 and getters/setters for: GlomNumericFormat, background colour and
2611 foreground colour strings.
2613 2011-09-26 Ben Konrath <ben@bagu.org>
2615 Simplify code that iterates through the LayoutGroup.
2617 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2619 2011-09-26 Ben Konrath <ben@bagu.org>
2621 Accept Eclipse formatting for OnlineGlomServiceAsync.
2623 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2625 2011-09-26 Ben Konrath <ben@bagu.org>
2627 Don't use the ListDBAccess classes to get the primary key layout information.
2629 This was causing a bug where the wrong index for the hidden primary key
2630 was being sent to the client.
2632 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Find the
2633 primary key while creating the LayoutGroup DTO. Create a
2634 LayoutItemField DTO for hidden primary keys. Don't use the
2635 RelatedListDBAccess because it was only used for getting the primary
2637 * src/main/java/org/glom/web/server/database/DBAccess.java: Change the
2638 access modifier from public to protected for getPrimaryKeyField() and
2639 getPrimaryKeyLayoutItemField().
2640 * src/main/java/org/glom/web/server/database/ListDBAccess.java: Remove
2641 abstract method getExpectedResultSize() because RelatedListDBAccess
2642 doesn't have enough info to implement it.
2643 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2644 Remove @Override for getExpectedResultSize().
2645 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2646 Remove method getExpectedResultSize().
2648 2011-09-23 Ben Konrath <ben@bagu.org>
2650 Log which layout (list or details) the ignored item is from.
2652 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2654 2011-09-23 Ben Konrath <ben@bagu.org>
2656 Remove annotations that turn off code formatting in DataItem.
2658 * src/main/java/org/glom/web/shared/DataItem.java:
2660 2011-09-23 Ben Konrath <ben@bagu.org>
2662 Rename GlomField to DataItem and update associated methods.
2664 This is a rename-only refactor. No functionality has been added or
2667 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2668 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2669 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2670 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2671 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2672 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2673 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2674 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2675 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2676 * src/main/java/org/glom/web/server/database/DBAccess.java:
2677 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2678 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2679 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2680 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2681 * src/main/java/org/glom/web/shared/DataItem.java:
2682 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java:
2683 * src/main/java/org/glom/web/shared/layout/LayoutGroup.java:
2685 2011-09-23 Ben Konrath <ben@bagu.org>
2687 Rename GlomDocument to DocumentInfo and update associated methods.
2689 This is a rename-only refactor. No functionality has been added or
2692 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2693 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2694 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2695 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
2696 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2697 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2698 * src/main/java/org/glom/web/shared/DocumentInfo.java:
2700 2011-09-20 Ben Konrath <ben@bagu.org>
2702 Require java-libglom 1.17.3.
2704 This picks up the fix for the seg fault problem with the Scenes table
2705 in the Openismus Film Manager example.
2709 2011-09-20 Ben Konrath <ben@bagu.org>
2711 Change the way sort clause is added for primary key when no sort clause is requested.
2713 The primary key is now added to the LayoutFieldVector (fieldsToGet)
2714 before the sort clause is created. When a sort clause is not requested, the
2715 sort clause is created by finding the primary key in the LayoutFieldVector
2718 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2720 2011-09-20 Ben Konrath <ben@bagu.org>
2722 Log error message if no documents are found in the configured directory.
2724 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Also:
2725 Extract the glom file extension string to a private static final class
2726 variable (mostly as syntactic sugar). Accept a minor formatting change.
2727 * src/main/resources/onlineglom.properties: Add '/glomfile' to end of
2728 the example glom.document.directory configuration property to make it
2729 more clear that it can any directory, not just the home directory.
2731 2011-09-18 Ben Konrath <ben@bagu.org>
2733 Add related lists to details view.
2735 The related list table has support for paging and sorting just like the
2736 table in the list view.
2738 * pom.xml: Require java-libglom 1.17.2 for the new methods to build the
2739 SQL queries for the related list tables.
2740 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2741 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2742 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2743 Rename getList methods to getListView and add comments. Remove
2744 getDetailsLayout() as it's not used anymore. Add note to getDetailsData() about
2745 it being unused. Add methods: getDetailsLayoutAndData(),
2746 getSortedRelatedListData(), getRelatedListData(), getRelatedListRowCount()
2747 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2748 Create the layout and set the data for the fields in one async call
2749 instead of two. Create related lists where appropriate.
2750 * src/main/java/org/glom/web/client/activity/ListActivity.java: Changes
2751 for method name changes in OnlineGlomService.
2752 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2753 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java: Rename
2754 addLayoutGroup() to addGroup(). Add methods to get the DTOs for the
2756 * src/main/java/org/glom/web/client/ui/ListView.java:
2757 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Remove
2758 tableName from setCellTable(). Create a ListViewTable instead of
2760 * src/main/java/org/glom/web/client/ui/details/Field.java: New class to
2761 represent a data field in the details view.
2762 * src/main/java/org/glom/web/client/ui/details/Group.java: Move to code
2763 from addDetailsCell() to Field class. Keep track of the Fields and
2764 Portals in the details view.
2765 * src/main/java/org/glom/web/client/ui/details/Portal.java: Make portal
2766 a little bigger to match Glom. Keep track of the LayoutItemPortal DTO
2767 and add a method to get it. Add method to set the contents of the
2769 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2770 New class for related list tables. This class has the data provider
2771 for the related list table.
2772 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Change to
2773 abstract class which is the base class for the ListViewTable and the
2775 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2776 New class for list view tables. This class has the data provider for
2777 the list view table.
2778 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Add
2779 methods for related list tables. Add more information to the
2780 LayoutItemField and LayoutItemPortal DTOs.
2781 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2782 Remove debugging print statement.
2783 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2784 Remove debugging print statements. Add primary key field to SQL count
2786 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2787 Remove unnecessary LayoutFieldVector parameter from
2788 getResultSizeOfSQLQuery() method.
2789 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2790 New class for related list table database access.
2791 * src/main/java/org/glom/web/shared/DetailsLayoutAndData.java: New
2792 class that is a wrapper DTO for details view layout and data.
2793 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java: Add
2794 new 'fromField' string to this DTO.
2795 * src/main/webapp/style.css: Remove bottom margin and override top
2798 2011-09-15 Ben Konrath <ben@bagu.org>
2800 Breakup the OnlineGlomServiceImpl class to make it more manageable.
2802 This sets things up to make it easier to add the data retrieval for
2803 related lists (portals). No user noticeable changes were made with
2806 * src/main/java/org/glom/web/server/ConfiguredDocument.java: This
2807 class has the code to retrieve the layouts and access the
2808 database using the new database helper classes.
2809 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2810 Most of the functionality has been removed from this class. This
2811 class now represents the public interface for the client side
2812 code. It also deals with configuring the servlet and cleaning
2813 things up when the servlet is stopped.
2814 * src/main/java/org/glom/web/server/Utils.java: Extract a couple
2815 of static methods into this utility class.
2816 * src/main/java/org/glom/web/server/database/DBAccess.java:
2817 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2818 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2819 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2820 These classes have the database retrieval code. The class hierarchy
2821 has been setup to make it easy to reuse code for similar
2824 2011-09-06 Ben Konrath <ben@bagu.org>
2826 Create separate classes for list table code and the data provider.
2828 As part of this refactor, I also split up the code a bit to make it
2831 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move list
2832 table code to two new classes (below).
2833 * src/main/java/org/glom/web/client/ui/list/ListTable.java: New file
2834 with code from ListViewImpl.
2835 * src/main/java/org/glom/web/client/ui/list/ListTableDataProvider.java:
2836 New file with code from ListViewImpl.
2838 2011-09-06 Ben Konrath <ben@bagu.org>
2840 Change the LayoutItemPortal DTO to extend LayoutGroup instead of LayoutItem.
2842 This fixes the LayoutItemPortal DTO to match the libglom layout object
2845 * src/main/java/org/glom/web/shared/layout/LayoutItemPortal.java:
2847 2011-09-01 Ben Konrath <ben@bagu.org>
2849 Set title of Portals in the Details View.
2851 * pom.xml: Bump required version of java-libglom to 1.17.1.
2852 * src/main/java/org/glom/web/client/ui/details/Group.java: Move Portal
2853 widget creation to its own class. Add comments to constructor.
2854 * src/main/java/org/glom/web/client/ui/details/Portal.java: New file.
2855 The code is mostly from the Group class with the title now set.
2856 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: Set
2857 title of Portal. Update some comments. Fix some code formatting.
2859 2011-09-01 Ben Konrath <ben@bagu.org>
2861 Remove TODO comment for the flow table column width.
2863 The flow table column width is working correctly and doesn't need to be
2864 changed. See this mailing list post for more info:
2866 https://mail.gnome.org/archives/glom-devel-list/2011-August/msg00017.html
2868 * src/main/java/org/glom/web/client/ui/details/FlowTable.java:
2870 2011-08-27 Ben Konrath <ben@bagu.org>