1 2012-11-14 Murray Cumming <murrayc@murrayc.com>
3 Document: Do not use == to compare strings. Use equals().
5 * src/main/java/org/glom/web/server/libglom/Document.java:
6 == only checks that they are the same object, so it can
9 2012-11-14 Murray Cumming <murrayc@murrayc.com>
11 Document: Add and use public constants for layout names.
13 * src/main/java/org/glom/web/server/libglom/Document.java:
14 Make LAYOUT_NAME_DETAILS and LAYOUT_NAME_LIST public.
15 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
16 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
17 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
18 * src/test/java/org/glom/web/server/libglom/DocumentTest.java: Use
19 them here instead of hard-coded the strings repeatedly.
21 2012-11-13 Murray Cumming <murrayc@murrayc.com>
23 Document: Load static text and image items too.
25 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemImage.java:
26 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemText.java:
27 New LayoutItem classes to represent these layout items.
28 * src/main/java/org/glom/web/shared/libglom/layout/StaticText.java: The
29 main text of a LayoutItemText.
30 * src/main/java/org/glom/web/server/libglom/Document.java:
31 load_after_layout_group(): Handle the node types and instantiate the
33 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
34 Add testLayoutItemText() to check that the text is loaded properly.
36 2012-11-13 Murray Cumming <murrayc@murrayc.com>
38 Do not use client.GWT for shared code.
40 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
41 Import shared.GWT instead of client.GWT, which seems to be appropriate.
43 2012-11-12 Murray Cumming <murrayc@murrayc.com>
45 Use image data when recreating databases for testing.
47 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setImageData(),
48 for use locally (not acrosss the network) when recreating databases
50 getValue(): Use it here instead of getImageDataUrl(), noting that
51 this method is only for use when recreating databases.
52 * src/main/java/org/glom/web/server/libglom/Document.java:
53 getNodeTextChildAsValue(): Use it instead of setImageDataUrl().
55 2012-11-09 Murray Cumming <murrayc@murrayc.com>
57 OnlineGlomImages: Detect the mime-type (content type).
59 * src/main/java/org/glom/web/server/OnlineGlomImages.java:
60 doGet(): Instead of hard-coding image/png.
62 2012-11-09 Murray Cumming <murrayc@murrayc.com>
64 Eclipse project files: Use JDK 1.7 instead of JDK 1.6.
67 * .settings/org.eclipse.jdt.core.prefs: By changing the Eclipse
68 Java Compiler and Java Build path settings in the UI.
70 2012-11-09 Murray Cumming <murrayc@murrayc.com>
72 Use the latest (now stable) version of GWT.
74 * pom.xml: And the latest version of the gwt-maven-plugin.
76 2012-11-08 Murray Cumming <murrayc@murrayc.com>
78 Added an Indonesian translation.
80 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
81 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_id.properties:
82 This is from the new translation in Glom.
84 2012-07-23 Murray Cumming <murrayc@murrayc.com>
88 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
90 * src/main/java/org/glom/web/server/ConfiguredDocumentSet.java:
92 * src/main/java/org/glom/web/server/OnlineGlomImages.java: A new servlet just
93 for serving image data.
94 * src/main/webapp/WEB-INF/web.xml: Mention the new servlet.
96 * src/main/java/org/glom/web/shared/DataItem.java: Added get/setImageDataUrl().
97 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
98 setData(): For image field types, add a GWT Image widget,
99 with the URL that was set in the DataItem.
101 * pom.xml: Depend on org.apache.httpcomponents for UriBuilder.
102 * src/main/java/org/glom/web/server/database/DBAccess.java:
103 convertResultSetToDTO(): Set the URL for image data, so the client browser
104 can retrieve the image from our new servlet. This uses UriBuilder.
105 Move getPrimaryKeyField to:
106 * src/main/java/org/glom/web/server/libglom/Document.java:
107 Added getTablePrimaryKeyField().
109 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
110 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
111 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
114 2012-07-22 Murray Cumming <murrayc@murrayc.com>
118 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
119 * src/main/java/org/glom/web/client/OnlineGlomService.java:
120 * src/main/webapp/WEB-INF/web.xml: Change the servlet-name from libGlom
121 to gwtGlom, which is more appropriate.
122 This servlet name does not seem to be visible to the client side anyway.
124 2012-07-22 Murray Cumming <murrayc@murrayc.com>
126 Tests: Make the imports of assert*() consistent.
128 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
129 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
130 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
131 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
132 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
133 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
134 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
135 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
136 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
137 * src/test/java/org/glom/web/shared/DataItemTest.java:
139 import static org.junit.Assert.*;
140 which seems fairly common.
144 2012-07-21 Murray Cumming <murrayc@murrayc.com>
146 tests: Move a test that needs a database connection.
148 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
149 Move testGetListViewLayoutGroup() to
150 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
151 because it needs a database connection.
153 2012-07-21 Murray Cumming <murrayc@murrayc.com>
155 tests: Use @BeforeClass on tearDown().
157 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
158 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
159 This avoids leaking a postgres process in SelfHostExampleTest.
161 2012-07-21 Murray Cumming <murrayc@murrayc.com>
163 tests: Test translations more.
165 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
166 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
167 Test titles in the non-default locale.
169 2012-07-21 Murray Cumming <murrayc@murrayc.com>
171 tests: Add SelfHostConfiguredDocumentTest
173 * src/test/java/org/glom/web/server/SelfHoster.java: Add getters for the
174 username and password, for use by ConfiguredDocument.
175 * src/test/java/org/glom/web/server/SelfHostConfiguredDocumentTest.java:
176 This tests some of the ConfiguredDocument API that requires a database connection.
178 2012-07-21 Murray Cumming <murrayc@murrayc.com>
180 Document: Load title translations and test them.
182 * src/main/java/org/glom/web/server/libglom/Document.java: Load the translations
183 of titles. I am surprised that we do not do this yet.
184 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
185 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
186 Test translations more.
188 2012-07-20 Murray Cumming <murrayc@murrayc.com>
192 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
193 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
194 Set the timeout here too.
196 2012-07-20 Murray Cumming <murrayc@murrayc.com>
198 tests: ConfiguredDocumentTest: Make this pass.
200 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
201 Disable tests that need a database connection.
203 2012-07-20 Murray Cumming <murrayc@murrayc.com>
205 Use Java 1.7 instead of Java 1.6.
207 * pom.xml: Specify the 1.7 JDK, though I don't like how we seem to need
208 to do this twice, at least for Eclipse.
209 This seems OK because it is the current version.
211 2012-07-20 Murray Cumming <murrayc@murrayc.com>
215 * src/main/java/org/glom/web/server/Log.java: Avoid using null strings.
216 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
217 Avoid using a null Connection.
219 2012-07-20 Murray Cumming <murrayc@murrayc.com>
221 tests: Add a ConfiguredDocument test.
223 * src/test/java/org/glom/web/server/ConfiguredDocumentTest.java:
226 2012-07-20 Murray Cumming <murrayc@murrayc.com>
228 LayoutItemFIeld: getName(): Use the Field if it is set.
230 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
231 getName(): If the full field details have been set, return its name, so that
232 callers do not need to set the name separately.
233 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
234 testExampleMusiccollectionData): Do not use a TYPE_FORWARD_ONLY statement,
235 so we can count the rows.
237 2012-07-20 Murray Cumming <murrayc@murrayc.com>
239 tests: SelfHoster: Test SqlUtils too.
241 * src/test/java/org/glom/web/server/SelfHostExampleTest.java:
242 Retrieve some data and check it too, as in the regular Glom
243 test_selfhosting_new_from_example.cc test.
244 * src/test/java/org/glom/web/server/SelfHoster.java:
245 createConnection(): Make this public.
247 2012-07-20 Murray Cumming <murrayc@murrayc.com>
249 tests: SelfHoster: createConnection(): Do not warn about expected failures.
251 Let the caller say if the connection is expected to fail, to avoid
252 irrelevant error output.
254 2012-07-20 Murray Cumming <murrayc@murrayc.com>
256 tests: SelfHoster: createAndSelfHostNewEmpty(): Sleep after starting server.
258 * src/test/java/org/glom/web/server/SelfHoster.java:
259 createAndSelfHostNewEmpty(): Sleep initially, to avoid distracting errors
260 due to the inevitable need to retry the connection while the database server
263 2012-07-20 Murray Cumming <murrayc@murray.com>
265 tests: SelfHoster: createConnection(): Set a timeout.
267 * src/test/java/org/glom/web/server/SelfHoster.java:
268 createConnection(): Use setLoginTimeout() because it otherwise seems to take
269 ages to actually return when it fails.
271 2012-07-20 Murray Cumming <murrayc@murrayc.com>
273 tests: SelfHoster: selfHost(): Close the test connection.
275 * src/test/java/org/glom/web/server/SelfHoster.java: selfHost():
276 When we check that the connection works, close the connection. This seems
277 to not be closed automatically otherwise.
279 2012-07-20 Murray Cumming <murrayc@murrayc.com>
281 Use slf4j-simple to see JDBC errors.
283 * pom.xml: Depend on slf4j-simple so we can see errors from JDBC.
285 2012-07-19 Murray Cumming <murrayc@murrayc.com>
287 SelfHoster.discoverFirstFreePort(): Close the socket.
289 * src/test/java/org/glom/web/server/SelfHoster.java:
290 discoverFirstFreePort(): Close the socket. Eclipse Juno warns about this.
292 2012-07-19 Murray Cumming <murrayc@murrayc.com>
294 Avoid another code warning in Eclipse Juno.
296 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
297 Do instanceof checks on the FileUtils.listFiles() result and its
300 2012-07-13 Murray Cumming <murrayc@murrayc.com>
302 Avoid some code warnings in Eclipse Juno
304 * src/main/java/org/glom/web/server/libglom/Document.java:
305 getNodeTextChildAsValue(), setNodeTextChildAsValue(): Handle the invalid type.
306 * src/test/java/org/glom/web/server/SelfHoster.java
307 createTextFile(): Make sure that the FileOutputStream is closed.
309 2012-06-22 Murray Cumming <murrayc@murrayc.com>
311 Added OnlineGlomPropertiesTest.
313 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
314 Make sure we never return a null string.
315 * src/test/java/org/glom/web/server/OnlineGlomPropertiesTest.java:
316 Added tests of the OnlineGlomProperties API, using our sample file.
318 2012-06-20 Murray Cumming <murrayc@murrayc.com>
320 Make OnlineGlomProperties be a normal class.
322 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
323 Move OnlineGlomProperties into its own file to be a regular class:
324 * src/main/java/org/glom/web/server/OnlineGlomProperties.java:
325 This makes testing simpler.
327 2012-06-15 Murray Cumming <murrayc@murrayc.com>
329 OnlineGlomServiceImpl.init(): Move some code into a new method.
331 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
332 Create addDocument().
334 2012-06-15 Murray Cumming <murrayc@murrayc.com>
336 OnlineGlomServiceImpl.OnlineGlomProperties: Improve getKey().
338 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
339 OnlineGlomProperties.getKey(): Make this more robust by moving the
340 check for *.*.filename to here.
342 2012-06-15 Murray Cumming <murrayc@murrayc.com>
344 OnlineGlomServiceImpl: Improve the OnlineGlomProperties class.
346 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
347 init(): Move knowledge of the config file format into the
348 OnlineGlomProperties inner class.
350 2012-06-15 Murray Cumming <murrayc@murrayc.com>
352 SelfHostExampleTest: Make sure we cleanup on failure.
354 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: Move
355 the use of cleanup() to a tearDown() JUnit method.
359 2012-06-12 Murray Cumming <murrayc@murrayc.com>
361 ConfiguredDocument: Add a primary key to portals at least once.
363 * src/main/java/org/glom/web/server/ConfiguredDocument.java
364 updatePortalsExtras): Fix a typo so that we add the primary key
365 column at least once.
366 This is a fix for the previous commit:
367 ConfiguredDocument: Do not add a primary key to portals each time.
369 2012-06-08 Murray Cumming <murrayc@murrayc.com>
371 SelfHoster: Avoid some compiler warnings.
373 * src/test/java/org/glom/web/server/SelfHoster.java
374 executeCommandLineAndWait():
375 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess(): Comment out
376 the now-unused streams for stdout and stderr from the command Processes.
377 These are not used because readln() hangs while waiting for a new line,
378 where there may be no next line. The commented out code is still there
379 to help us figure out how to do this properly.
381 2012-06-08 Murray Cumming <murrayc@murrayc.com>
383 LayoutItemPortalDeepCloneTest: Test something to avoid warnings.
385 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
386 Make this actually test the cloning again, though it is not very useful
387 now that we do not use the part that had a problem with cloning before.
389 2012-06-08 Murray Cumming <murrayc@murrayc.com>
391 SelfHoster: Keep trying pg_ctl after starting postgres.
393 * src/test/java/org/glom/web/server/SelfHoster.java
394 executeCommandLineAndWaitUntilSecondCommandReturnsSuccess():
395 Try pg_ctl repeatedly (for ever) until it succeeds, as we do in
396 regular Glom. This seems mad but it seems to work because the first
397 command would fail if pg_ctl would eventually fail.
399 2012-06-08 Murray Cumming <murrayc@murrayc.com>
401 SelfHoster: Wait until the server is really ready.
403 * src/test/java/org/glom/web/server/SelfHoster.java
404 selfHost(): Attempt the connection after starting the server, retrying
405 a few times if necessary, so that the server is really ready already when
406 we return from this method.
407 The regular Glom code does this too because pg_ctl reports success too soon.
409 2012-06-08 Murray Cumming <murrayc@murrayc.com>
411 ConfiguredDocument: Do not add a primary key to portals each time.
413 * src/main/java/org/glom/web/server/ConfiguredDocument.java
414 updatePortalsExtras(): Only add an extra primary key field if there is
415 none, to avoid adding one each time we retrieve the details layout from the
417 This should fix bug #676986 (Ben Konrath)
419 2012-05-25 Murray Cumming <murrayc@murrayc.com>
421 Document.load(): Support version 7 documents.
423 * src/main/java/org/glom/web/server/libglom/Document.java: Load the
424 database_title attribute if the title attribute is not there.
427 2012-05-24 Ben Konrath <ben@bagu.org>
429 Add configuration for auto-generating mvn:i18n from with Eclipse.
431 * pom.xml: Add PluginExecution configuration for gwt-maven-plugin.
433 2012-05-24 Murray Cumming <murrayc@murrayc.com>
435 Update translations, adding French.
437 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
438 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_fr.properties:
439 Add a French translation, using the translation from Glom.
441 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
442 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
443 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
444 Update these based on the translations from Glom.
446 2012-05-24 Murray Cumming <murrayc@murrayc.com>
448 SelfHoster: Add some debug println messages to help when things fail.
450 * src/test/java/org/glom/web/server/SelfHoster.java: Add several
451 System.out.println() lines.
453 2012-05-23 Murray Cumming <murrayc@murrayc.com>
455 Tests: SelfHoster: Check other paths for PostgreSQL command-line tools.
457 * src/test/java/org/glom/web/server/SelfHoster.java:
458 getPathToPostgresExecutable(): Try some common paths (as on Ubuntu, for
459 instance) instead of just /usr/bin (as on Fedora). Check the result when
462 2012-05-23 Murray Cumming <murrayc@murrayc.com>
464 Remove LayoutItemPortal.get/setNavigationTable().
466 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
467 Remove get/setNavigationTable(), which is only a cache, because it is not
468 used, and does not need to be used, because that decision should be made on
470 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
471 updatePortalsExtras():
472 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
473 getNavigationRecord():
474 * src/test/java/org/glom/web/server/libglom/LayoutItemPortalDeepCloneTest.java:
477 2012-05-21 Murray Cumming <murrayc@murrayc.com>
479 Initial self-hosting for tests.
481 * pom.xml: Change the scope for log4j, to hopefully make it
482 available to the test code which uses it indirectly via jOOQ.
483 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Allow
484 self-hosting, though we only use it for testing.
486 * src/main/java/org/glom/web/server/libglom/Document.java:
487 example rows: Use a map instead of a list for each row of values,
488 so we know what field they are for, instead of relying on the sequence
489 being correct. This is not very efficient, but it does not really need
491 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
492 testReadTableExampleRows(): Adapted.
494 * src/main/java/org/glom/web/shared/DataItem.java: Added getValue()
495 that returns an Object, for generic use. Note that Object seems to be
496 the implicit base even of double.
497 * src/main/java/org/glom/web/shared/libglom/Field.java: Add getSqlType(),
498 for use in CREATE TABLE SQL queries.
499 * src/test/java/org/glom/web/server/SelfHoster.java: Add this class
500 to do self-hosting of PostgreSQL databases via its command-line
501 utilities, based on Glom's C++ code in test_selfhosting_utils.cc and
502 backends/postgres_self.cc. This is incomplete - it needs more
503 warnings about failures and it needs to clean up properly when things
505 * src/test/java/org/glom/web/server/SelfHostExampleTest.java: A simple
506 test of this new class.
508 2012-05-21 Murray Cumming <murrayc@murrayc.com>
510 Document: loading example data: Handle exceptions.
512 * src/main/java/org/glom/web/server/libglom/Document.java:
513 DateFormat.parse() and Double.valueOf() can throw exceptions, though
514 Eclipse did not warn about that.
516 2012-05-20 Murray Cumming <murrayc@murrayc.com>
518 Document: load(), save(): Handle the example rows.
520 * src/main/java/org/glom/web/shared/DataItem.java: Add get/setDate()
522 * src/main/java/org/glom/web/server/libglom/Document.java:
523 load(), save(): Load and save the example rows, though the date, time
524 and image types are not handled properly yet.
525 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
526 Add testReadTableExampleRows() just to check that something is read.
528 2012-05-20 Murray Cumming <murrayc@murrayc.com>
530 Document: Add save().
532 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
533 Added getTranslationsMap() for use while saving.
534 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
535 Adedd getUseDefaultFormatting() for use while saving.
536 * src/main/java/org/glom/web/server/libglom/Document.java: Added save()
537 and several private methods that it uses.
539 This will be useful while testing via self-hosting.
540 It is not complete, but should be complete enough for testing.
542 2012-05-17 Murray Cumming <murrayc@murrayc.com>
544 OnlineGlomService: Simplify the getList/RelatedViewData() methods.
546 * src/main/java/org/glom/web/client/OnlineGlomService.java
547 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
548 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
549 Remove getSortedListViewData() and getSortedRelatedListData(), adding
550 the sort column index and ascending bool to the regular method.
551 Instead, a sort column index of -1 now means no sort.
552 This is less explicit, but it's fairly simple, reduces the amount of
553 code, and makes the OnlineGlomService API slightly smaller.
554 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
555 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
557 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
558 getListViewData(), getRelatedListData():
559 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
560 getListViewData(), getRelatedListData():
561 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
563 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
565 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
570 2012-05-16 Murray Cumming <murrayc@murrayc.com>
572 Use translations for top-level groups too.
574 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
575 updateTitlesForLocale(): Use the translation for the group
576 as well as for child items.
580 Just recompiled to fix a problem in the released .tar.gz file.
584 2012-05-15 Murray Cumming <murrayc@murrayc.com>
586 Corrections to navigation to related records.
588 * src/main/java/org/glom/web/client/OnlineGlomService.java:
589 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
590 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
591 getRelatedListData(), getSortedRelatedListData)(), getRelatedListRowCount(),
592 getSuitableRecordToViewDetails(): Take a LayoutItemPortal instead of a
593 relationship name, because the relationship name is not necessarily unique
595 TOOD: This is inefficient, because it passes the whole list of
596 child field items back to the server, but it is more correct, and happens
597 to fix a bug with the primary key being lost after a few navigations.
598 There is probably a chance to make this more efficient anyway in some
601 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
602 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.jav
603 * src/main/java/org/glom/web/server/ConfiguredDocument.java
604 * src/main/java/org/glom/web/server/database/DBAccess.java
605 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
606 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
609 2012-05-15 Murray Cumming <murrayc@murrayc.com>
611 Fix the use of translations.
613 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
614 Add updateTitlesForLocale().
615 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
616 Call it to discard unwanted translations and to make getTitle() return
617 the wanted translation wihout the need for the client code to specify a locale.
618 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
619 getTitle(): Fallback to the original title, as libglom does.
621 2012-05-15 Murray Cumming <murrayc@murrayc.com>
623 Document: Correctly report the number of available translation locales.
625 * src/main/java/org/glom/web/server/libglom/Document.java: Fill
626 the available locale IDs list.
627 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
628 testLocales: Test this.
630 2012-05-15 Murray Cumming <murrayc@murrayc.com>
632 SqlUtils: Use camelCase.
634 * src/main/java/org/glom/web/server/SqlUtils.java: Use camelCase.
635 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
636 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
637 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
638 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
639 * src/main/java/org/glom/web/server/ReportGenerator.java: Adapt.
641 2012-05-15 Murray Cumming <murrayc@murrayc.com>
643 Use jOOQ's tableByName() and fieldByName.
645 * pom.xml: Use jOOQ 2.3.1 to get the new API.
646 * src/main/java/org/glom/web/server/SqlUtils.java:
647 build_sql_select_step_with_where_clause(), .createField(),
648 builder_add_join(): Use Factory.tableByName() and Factory.fieldByName()
649 so we can get correct quoting and escaping. Thanks to Lukas Eder for
650 adding this, and other things, to jOOQ.
652 2012-05-15 Murray Cumming <murrayc@murrayc.com>
654 SqlUtils: Remove the Connection parameters.
656 * src/main/java/org/glom/web/server/SqlUtils.java:
657 build_sql_select_with_key(), build_sql_select_with_where_clause(),
658 createSelect(), build_sql_select_step_with_where_clause(),
659 build_sql_count_select_with_where_clause(),
660 build_sql_select_count_rows(): Remove the Connection parameter because
661 jOOQ does not actually need a connectionwhen it is just used to build
663 https://groups.google.com/forum/#!topic/jooq-user/tIwobFOR2iM
665 * src/main/java/org/glom/web/server/ReportGenerator.java:
667 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
669 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
670 Constructor, getListData(), getResultSizeOfSQLQuery():
671 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
672 getSelectQuery(), getCountQuery():
673 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
674 getSelectQuery(), getCountQuery():
675 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
676 getNavigationRecord(): Adapted.
678 2012-05-14 Murray Cumming <murrayc@murrayc.com>
682 * src/main/java/org/glom/web/server/SqlUtils.java:
683 get_find_where_clause_quick(): Use a comparison of
684 lowercase values, instead of a simple equals. Regular Glom
685 uses the PostgreSQL ILIKE operator but jOOQ does not
686 support that just yet, though it will soon.
688 2012-05-14 Murray Cumming <murrayc@murrayc.com>
690 TableToViewDetails: Use a real serialization ID.
692 * src/main/java/org/glom/web/shared/libglom/layout/TableToViewDetails.java:
693 Though this does not fix the serialization problem.
695 2012-05-12 Murray Cumming <murrayc@murrayc.com>
697 Added LayoutItemPortalDeepCloneTest.
699 2012-05-11 Murray Cumming <murrayc@murrayc.com>
701 Make navigation work again.
703 * src/main/java/org/glom/web/server/libglom/Document.java:
704 Add getLayoutItemFieldShouldHaveNavigation().
705 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
706 Replace get/setAddNavigation() with the partly-existing
707 get/setNavigationTableName(), with an empty string being no navigation,
708 because this is simpler. Use the new
709 Document.getLayoutItemFieldShouldHaveNavigation() method to set this.
711 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
712 Add updateFieldsExtras() and call setNavigationTableName in it.
713 getDetailsLayoutGroup(),
714 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
715 createLayout(): Adapted.
716 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
717 Constructor: Adapted.
719 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
720 Replace get/setAddNavigation() with get/setNavigation(), returning a
721 TableToViewDetails class with both the table name and UsesRelationship,
722 because both are need. The previous code used java-libglom's output
723 variable (strangely, via sharedptr) to return both, but we cannot really
725 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
726 getNavigationRecord(): Adapt. However, we cannot actually use the cache
727 here because it somehow gets set to null during deepCopy(). I must test this.
728 * src/test/java/org/glom/web/server/libglom/DocumentTest.java
729 testGetSuitableTableToViewDetails(): Adapted.
731 TODO: Find out why deepClone() is not quite working.
733 2012-05-11 Murray Cumming <murrayc@murrayc.com>
735 DBAccess: Simplify the retrievel of full field details.
737 * src/main/java/org/glom/web/server/database/DBAccess.java
738 getFieldsToShowForSQLQueryAddGroup(). This might be unnecessary anyway,
739 because the Document loading should have done this.
741 2012-05-11 Murray Cumming <murrayc@murrayc.com>
743 Document: Correct loading of doubly-related layout fields.
745 * src/main/java/org/glom/web/server/libglom/Document.java:
746 loadUsesRelationship(): Actually set the related relationship, instead
747 of only setting it if it's not found.
749 2012-05-09 Murray Cumming <murrayc@murrayc.com>
751 Replace all appearances of Colour with color.
753 Because US English is dominant.
755 2012-05-09 Murray Cumming <murrayc@murrayc.com>
757 Use colors in HTML format, solving a warning about an unused function.
759 * src/main/java/org/glom/web/shared/libglom/NumericFormat.java
760 * src/main/java/org/glom/web/shared/libglom/layout/Formatting.java:
761 Add *asHTMLColor() versions of methods.
762 TODO: However, we should create and cache the results on the server.
763 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
764 * src/main/java/org/glom/web/client/ui/list/ListTable.java
765 * src/main/java/org/glom/web/server/ConfiguredDocument.java
766 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
767 Use the asHTMLcolor() versions.
769 2012-05-09 Murray Cumming <murrayc@murrayc.com>
771 ListViewTable: Constructor: Take the table name as a parameter.
773 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
774 Constructor: Take the tableName, and set the member variable, because
776 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
777 setCellTable(): Pass the table name.
778 This makes navigation to non-default tables work again. I don't know
779 why it worked before in the master branch.
781 2012-05-07 Murray Cumming <murrayc@murrayc.com>
783 ConfiguredDocument: Restore correct addition of hidden primary key items.
785 * src/main/java/org/glom/web/client/ui/list/ListTable.java
786 (ListTable.createCellTable): Uncomment out the check for the hidden
788 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Only
789 add primary key items for top-level lists and portals, as before,
790 instead of adding them to each group.
791 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java:
792 Actually implement the extra methods such as setHiddenPrimaryKey() and
793 comment that these are used only for top-level list groups and in portals.
794 This strangeness suggests even more that this should not be squeezed
795 into the LayoutGroup class.
797 2012-05-07 Murray Cumming <murrayc@murrayc.com>
799 Fix Formatting loading.
801 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
802 getFormattingUsed(): Remove the duplicate Formatting member variable
803 in favour of the one from the base class.
804 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemWithFormatting.java:
805 Initialize a new Formatting instead of using null by default, so we
806 have some defaults, instead of having to initialize one later just to
807 get the same defaults. This also makes loading of formatting from the
808 document work, because that expected a non-null.
810 2012-05-07 Murray Cumming <murrayc@murrayc.com>
812 RelatedListTable: Make sure that the tableName is set.
814 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
815 Constructor: Take the tableName so it is available later. Otherwise,
816 the server assumes that we mean the default table and cannot find the
818 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
819 setData(): Pass the tableName to the RelatedListTable constructor.
821 2012-05-07 Murray Cumming <murrayc@murrayc.com>
825 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
826 RelatedListNavigationButtonCell.onEnterKeyDown(), setData():
827 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
829 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
831 * src/main/java/org/glom/web/server/database/DBAccess.java:
832 convertResultSetToDTO(), getPortal():
833 * src/main/java/org/glom/web/server/database/ListDBAccess.java
835 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
836 Add checks for null objects and out of range access, with log messages to
837 give hints so we can fix these properly.
839 2012-05-07 Murray Cumming <murrayc@murrayc.com>
841 Portals: some corrections.
843 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
845 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
846 constructor: Use getRelationshipNameUsed() instead of getName(), because
847 that is what is meant.
848 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
849 getFromField(): Fix a typo, to get the field name, not the table name.
850 * src/main/java/org/glom/web/server/database/DBAccess.java:
851 getPortal(): Fix a typo that stopped this from working.
853 2012-05-07 Murray Cumming <murrayc@murrayc.com>
855 LayoutItemPortal: Also override getTitleOriginal().
857 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemPortal.java:
858 This lets the base getTitle() with no parameters work.
859 TODO: Test this properly.
861 2012-05-06 Murray Cumming <murrayc@murrayc.com>
863 LayoutItemPortal: getTitle*(): Use the relationship title.
865 2012-05-06 Murray Cumming <murrayc@murrayc.com>
867 LayoutItemField: Fix loading of custom titles.
869 * src/main/java/org/glom/web/server/libglom/Document.java
870 loadDataLayoutItemField(): The title, if any, instead of the field
871 title, is stored in a title_custom node. Load it from there.
872 * src/main/java/org/glom/web/shared/libglom/CustomTitle.java: Add this
874 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField:
875 Add getCustomTitle() and use it, instead of super.getTitle*(), in the
876 getTitle*() overrides.
877 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
880 2012-05-06 Murray Cumming <murrayc@murrayc.com>
882 LayoutItemField: Fall back to field titles, so some are really shown.
884 * src/main/java/org/glom/web/shared/libglom/layout/LayoutItemField.java:
885 Override getTitleOriginal() and getTitle(), as in java-libglom.
886 * src/test/java/org/glom/web/server/libglom/LayoutItemFieldTest.java:
889 2012-05-06 Murray Cumming <murrayc@murrayc.com>
891 Correct use of setExpectedResultSize().
893 * src/main/java/org/glom/web/server/ConfiguredDocument.java
894 getValidListViewLayoutGroup(), getDetailsLayoutGroup():
895 Use setExpectedResultSize only on top-level groups (for instance, the
896 list layout) or on child portals (in details views).
897 Use the correct table name for portals to avoid SQL errors.
898 Update the expected counts when returning cached layouts.
900 2012-05-06 Murray Cumming <murrayc@murrayc.com>
902 Document: Interpret no group column count as 1.
904 * src/main/java/org/glom/web/server/libglom/Document.java: Use a sane
905 default, though we now check for this in the UI code anyway.
907 2012-05-06 Murray Cumming <murrayc@murrayc.com>
911 2012-05-06 Murray Cumming <murrayc@murrayc.com>
913 Translatable: Use Hashmap instead of Treemap because GWT supports it.
915 * src/main/java/org/glom/web/shared/libglom/Translatable.java:
916 The use of Treemap lead to this error from async methods, with no
918 "The response could not be deserialized"
920 2012-05-06 Murray Cumming <murrayc@murrayc.com>
922 OnlineGlom.gwt.xml: Add exludes to fix explicit gwt compilation in Eclipse.
924 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: This is necessary
925 when using the Google -> GWT Compile, or
926 g toolbar button -> GWT Compile Project... feature in Eclipse.
928 2012-05-06 Murray Cumming <murrayc@murrayc.com>
930 ListTable.addColumn(): Protect against a null Formatting.
932 * src/main/java/org/glom/web/client/ui/list/ListTable.java: addColumn():
933 Create a default Formatting if it is null, because that is the simplest
936 2012-05-06 Murray Cumming <murrayc@murrayc.com>
938 ConfiguredDocument.updateLayoutGroup(): Protect against a null dereference.
940 * src/main/java/org/glom/web/server/ConfiguredDocument.java
941 updateLayoutGroup(): Check that the field is not null.
943 2012-05-06 Murray Cumming <murrayc@murrayc.com>
945 ListViewImpl: Protected against a bad cast error.
947 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
948 onEnterKeyDown(): Do not cast without an instanceof check.
950 2012-05-06 Murray Cumming <murrayc@murrayc.com>
952 ListTable: Protect against an out of range error.
954 * src/main/java/org/glom/web/client/ui/list/ListTable.java
955 createCellTable(): This is unlikely, but can happen while debugging.
957 2012-05-06 Murray Cumming <murrayc@murrayc.com>
959 AsyncMessage onFailure() callbacks: Log the exception message.
961 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
962 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
963 * src/main/java/org/glom/web/client/activity/ListActivity.java:
964 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
965 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
966 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
967 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
968 These are useful clues when something is wrong.
970 2012-05-06 Murray Cumming <murrayc@murrayc.com>
972 ConfiguredDocument: Avoid a null dereference.
974 * src/main/java/org/glom/web/server/ConfiguredDocument.java
975 TableLayoutsForLocale.getMapWithAdd(): Make sure that the list and
976 details maps are created.
978 2012-05-06 Murray Cumming <murrayc@murrayc.com>
980 Document: Correct the port number parsing.
982 * src/main/java/org/glom/web/server/libglom/Document.java:
983 This lets us actually connect to the database and show the document.
985 2012-05-05 Murray Cumming <murrayc@murrayc.com>
989 * pom.xml: Use htmlunit mode for gwt:test, because the default demands
990 user-interaction, asking us to load a temporary URL in a browser.s
991 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add a servlet node,
992 which is apparently necessary for testing the service. See the comment.
993 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
994 Show the exception, if any. This is how I saw the 404 in the HTML in
997 2012-05-05 Murray Cumming <murrayc@murrayc.com>
999 DocumentTest: Move the .glom files into the resources directory.
1001 * src/test/java/org/glom/web/server/libglom/DocumentTest: And get the
1002 URI via getResource().
1004 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1006 Document: Remove the FieldIdentifies inner class.
1008 * src/main/java/org/glom/web/server/libglom/Document.java: We only
1009 use the Relationship (though the same function in libglom is maybe
1010 used in other ways) and so this removes a compiler warning.
1012 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1014 Document.load() Remove the error code parameter.
1016 * src/main/java/org/glom/web/server/libglom/Document.java: load():
1017 Remove the parameter. We do not set it yet and it could never have
1018 worked as an output parameter (though maybe it did in java-libglom).
1019 We could use an exception if we really want the failure reason.
1020 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1022 * src/test/java/org/glom/web/server/libglom/DocumentTest.java:
1023 setUp(), testGetSuitableTableToViewDetails(): Adapt.
1025 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1027 Make some inner classes static.
1029 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1030 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1031 * src/main/java/org/glom/web/server/ReportGenerator.java
1032 * src/main/java/org/glom/web/server/libglom/Document.java
1033 Make all inner classes static that can be static.
1035 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1037 OnlineGlomServiceImpl: Do not load and check for java-libglom.
1039 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1040 init(): We do not use java-libglom any more.
1042 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1044 Remove mentions of java-libglom.
1046 * README: Remove mention of java-libglom, because it no longer needed.
1047 * utils/build-onlineglom-war.sh:
1048 * utils/check-and-recover-tomcat.py:
1049 * utils/install-onlineglom-war.sh: Remove these as they are no longer
1050 useful. Building is now far easier, with no need for jhbuild.
1052 2012-05-05 Murray Cumming <murrayc@murrayc.com>
1054 Fix the build (mvn package)
1056 * src/main/java/org/glom/web/shared/libglom/layout/LayoutGroup.java
1057 (LayoutGroup): Make the LayoutItemList inner class static and protected.
1058 Otherwise the GWT Java->Javascript compilation fails with just this
1059 error, during mvn package or when attempting to view in a browser,
1060 in the GWT developer mode in Eclipse.
1062 [INFO] --- gwt-maven-plugin:2.4.0:compile (default) @ gwt-glom ---
1063 [INFO] auto discovered modules [org.glom.web.OnlineGlom]
1064 [INFO] Compiling module org.glom.web.OnlineGlom
1065 [INFO] [ERROR] Errors in 'file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java'
1066 [INFO] [ERROR] Line 46: Failed to resolve 'org.glom.web.client.OnlineGlomService' via deferred binding
1067 [INFO] Scanning for additional dependencies: file:/home/murrayc/checkouts/gnome/gwt-glom/src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1068 [INFO] [WARN] For the following type(s), generated source was never committed (did you forget to call commit()?)
1069 [INFO] [WARN] org.glom.web.client.OnlineGlomService_Proxy
1070 [INFO] [ERROR] Cannot proceed due to previous errors
1072 It has taken me 2 days to find out what was causing that. After reducing
1073 the code, the compiler eventually showed me the full error message.
1075 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1077 ConfiguredDocument: Cache the cloned and stripped layouts.
1079 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1080 getValidListViewLayoutGroup(), .getDetailsLayoutGroup(): Store the cloned
1081 layout in a map, so we can retrieve it again without rebuilding it.
1083 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1085 UsesRelationshipImpl: Complete the relationshipEquals() implementation.
1087 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1089 libglom classes: Implement some auto-generated emthods.
1091 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1093 Add GwtTestOnlineGlomService.
1095 * src/test/java/org/glom/web/client/GwtTestOnlineGlomService.java:
1096 However, this (and the other GwtTest*) does not seem to run during
1099 2012-05-04 Murray Cumming <murrayc@murrayc.com>
1101 Remove use of unsupported features from client code.
1103 * src/main/java/org/glom/web/client/StringUtils.java: Add equals().
1104 * src/main/java/org/glom/web/shared/libglom/layout/UsesRelationshipImpl.java:
1105 * src/main/java/org/glom/web/shared/libglom/layout/reportparts/LayoutItemGroupBy.java:
1106 Use our client version of StringUtils instead of the apache commons one.
1108 However, the GWT Javascript compliation still fails.
1110 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1112 Add a Field class and implement some loading of it in Document.
1114 2012-04-25 Murray Cumming <murrayc@murrayc.com>
1116 Initial Document loading implementation, instead of libglom.
1118 * src/test/java/org/glom/web/shared/libglom/: Add Document, Report,
1119 and Translatable classes, and adapt the rest of the code to use them.
1120 However, this is still missing Layout and Field classes and loading.
1122 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1124 Use of jOOQ: Move Field creation into a utility method.
1126 * src/main/java/org/glom/web/server/SqlUtils.java:
1127 This lets us improve it more easily.
1129 2012-04-24 Murray Cumming <murrayc@murrayc.com>
1131 Use of jOOQ: Improve the code to COUNT a sub-select.
1133 * src/main/java/org/glom/web/server/SqlUtils.java:
1134 Move initial query creation into
1135 build_sql_select_step_with_where_clause().
1136 build_sql_select_count_rows(): Use the jOOQ API instead of
1137 concatentating text, because a jOOQ Select*Step is a TableLike,
1138 which is what from() takes.
1140 2012-04-23 Murray Cumming <murrayc@murrayc.com>
1142 Use jOOQ instead of Glom.build_sql*(), to avoid native calls.
1144 * pom.xml: Depend on jooq.
1145 * src/main/java/org/glom/web/server/SqlUtils.java: Reimplement the
1146 methods with jOOQ, based on the C++ implementations in libglom,
1147 with some changes to the logic required by jooQ.
1148 Take a jOOQ Condition rather than a Glom.SqlExpr (GdaSqlExpr) for the
1150 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1151 * src/main/java/org/glom/web/server/ReportGenerator.java:
1152 * src/main/java/org/glom/web/server/SqlUtils.java:
1153 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
1154 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1155 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1156 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1157 * src/main/java/org/glom/web/server/database/RelatedListNavigation:
1158 Adapt. In particular, the SqlUtils methods now need to take a Connection,
1159 because jOOQ needs that, though it seems unnecessary.
1161 This is not quite finished. Ideally jOOQ would help us to build
1162 table_name.field_name names, quoting and escaping them properly.
1163 See http://stackoverflow.com/questions/10264001/instantiating-a-jooq-field-by-name
1165 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1167 Move use of Glom.build_sql*() into a new SqlUtils class.
1169 * src/main/java/org/glom/web/server/SqlUtils.java: Add static methods
1170 to wrap Glom.build_sql*(). The parameter types are still Glom one,
1171 but this will make it easier to start using something other than
1172 libglom or SqlBuilder.
1174 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1176 Update the project URL.
1178 * pom.xml: Use an OnlineGlom-specific URL for the project URL.
1180 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1182 Main layout: Use a FlowTable instead of absolute positioning.
1184 * src/main/java/org/glom/web/client/OnlineGlom.java: onModuleLoad():
1185 The RootLayoutPanel is a (extends) AbsolutePanel, so each of its
1186 child panels/widgets must have an absolute position. But that is annoying, so
1187 this adds a FlowTable and puts the child panels in there.
1189 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1191 GwtTestOnlineGlom: Comment out unused code.
1193 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1194 Eclipse has started to say that some code is unused.
1196 2012-04-21 Murray Cumming <murrayc@murrayc.com>
1198 Update to the latest versions of dependencies.
1200 * pom.xml: Update version numbers of dependencies to the latest
1202 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1203 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1204 * src/main/java/org/glom/web/server/ReportGenerator.java:
1205 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
1206 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
1207 * src/main/java/org/glom/web/server/database/RelatedListNavigation.
1209 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
1210 Modify the imports where necessary.
1212 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1214 Style: Remove overflow:hidden from searchbox
1216 * src/main/webapp/style.css: Because this pushes the Back To Link
1217 label/link on to the next row, which is then hidden due to the
1218 hard-coded (in ems) height.
1220 2012-04-20 Murray Cumming <murrayc@murrayc.com>
1222 Remove some duplicate code.
1224 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1225 getDocumentInfo(): This must have been duplicated during the merge from the
1230 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1232 Reports: Localize the waiting for report message.
1234 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1235 start(): Get the message from the contants.
1236 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1237 Add the string here.
1238 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1239 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1240 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1241 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1242 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1243 Update these files with the English text for newer strings for now.
1245 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1247 Reports: Show a message while waiting for the report.
1249 * src/main/java/org/glom/web/client/ui/ReportView.java
1250 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1251 Add setWaitingText(), to show a message saying that we are
1252 waiting for the report to be ready.
1253 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1254 start(): Call setWaitingText() before calling the async
1257 2012-04-19 Murray Cumming <murrayc@murrayc.com>
1259 ReportGenerator: Specify date and time formats.
1261 * src/main/java/org/glom/web/server/ReportGenerator.java:
1262 createFieldValueElement(): Use the default (and localized)
1263 short formats, though we still need a way to show 4-digit
1264 years without providing the format for every locale.
1265 * src/main/java/org/glom/web/server/database/DBAccess.java:
1266 convertResultSetToDTO(): Use the short formats here too.
1268 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1270 ReportGenerator: Use the correct numeric formatting.
1272 * src/main/java/org/glom/web/server/ReportGenerator.java
1273 createFieldExpression(), createFieldValueElement(): Take the
1274 whole LayoutItem_Field instead of just the field name, so
1275 we have access to the formatting.
1276 createFieldValueElement(): Use JRTextField.setPattern() to
1277 specify the numeric formatting, with the help of a
1278 regular DecimalFormat.
1280 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1282 ReportGenerator: Avoid showing null for group by titles.
1284 * src/main/java/org/glom/web/server/ReportGenerator.java
1285 generateReport(): Use setBlankWhenNull() on the field title
1286 style too, because this is used for values in group by
1289 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1291 ReportGenerator: Add a colon to titles in vertical groups.
1293 * src/main/java/org/glom/web/server/ReportGenerator.java
1294 addFieldToDetailBandVertical(): Pass true for the withColon
1297 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1299 ReportGenerator: Simplify the code by using Position more.
1301 2012-04-18 Murray Cumming <murrayc@murrayc.com>
1303 Reports: Support vertical groups, roughly.
1305 * src/main/java/org/glom/web/server/ReportGenerator.java:
1306 addToReport(): Rename to addGroupToReport() and, if necessary,
1307 call the new addVerticalGroupToReport() method.
1308 createFieldValueElement(): Let the caller specify the Y position
1311 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1313 Reports: Allow a second report to be shown.
1315 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1316 clear(): Do not remove the HTML widget, which broke the whole layout.
1318 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1320 Locales drop-down: Show that we use English by default.
1322 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1323 fillView(): When we use English, just because that is the default, when
1324 no locale is specified, show that in the Locales drop-down instead of
1325 just showing the first item.
1327 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1329 Unselect the Report/Locale/Table combo item when appropriate.
1331 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1332 setPlace(): clear reportName if this is not a ReportPlace.
1333 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1334 setSelectedTableName(), setSelectedLocale(), setSelectedReport():
1335 When the provided name is empty, unselect all items, so that none are
1336 indicated. This uses a for loop because I cannot find a single method
1339 2012-04-17 Murray Cumming <murrayc@murrayc.com>
1341 Report: Give the user a way to get back to the list.
1343 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1344 start(), setPlace(): Show the Back To List link on reports, and also
1345 interpret selecting the empty report item as back to list.
1347 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1349 Really show the selected Report name.
1351 * src/main/java/org/glom/web/client/activity/TableSelectionActivity:
1352 setPlace(): Store the reportName here, if it is that kind of Place.
1353 fillView(): Set the selected Report after filling the list of reports.
1354 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1355 setSelectedLocale(), setSelectedReport(): Avoid possible uses of
1356 null Strings, though we need some way to unselect all ListBox items
1359 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1361 ReportGenerator: Try to avoid some problems.
1363 * src/main/java/org/glom/web/server/ReportGenerator.java
1364 addField(): Try to avoid duplicates, and avoid using a null
1367 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1369 Reports: Use quickFind.
1371 * src/main/java/org/glom/web/client/OnlineGlomService.java;
1372 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1373 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1374 getReportHTML(): Add a quickFind parameter.
1375 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1376 start(): Pass the quickFind parameter.
1377 * src/main/java/org/glom/web/server/ReportGenerator.java
1378 generateReport(): Take a quickFind parameter.
1380 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1382 ReportPlace: Actually use the report name.
1384 * src/main/java/org/glom/web/client/place/ReportPlace.java
1385 getPlace(): Do not assign the report name to the quickfind.
1387 2012-04-13 Murray Cumming <murrayc@murrayc.com>
1389 Show java.library.path when complaining.
1391 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1392 init(): When telling us to check java.library.path, show the
1395 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1397 ReportGenerator: Do not show nulls.
1399 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1401 ReportGenerator: Make the title font larger.
1403 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1405 ReportGenerator: Put field titles inside groups, if there are groups.
1407 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1409 ReportGenerator: Take the Report itself instead of the name and group.
1411 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1412 Remove getReportLayoutGroup().
1413 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1414 getReportHTML(): Pass the report instead
1415 of its name and layout group.
1416 * src/main/java/org/glom/web/server/ReportGenerator.java
1417 generateReport(): Use the report object to use the title
1418 instead of the name.
1420 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1422 ReportGenerator: Remove designBand parameters.
1424 * src/main/java/org/glom/web/server/ReportGenerator.java:
1425 Make designBand a class member instead of passing it to all
1428 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1430 ReportGenerator: Add lines, a bit like in the desktop version.
1432 * src/main/java/org/glom/web/server/ReportGenerator.java
1433 addToReport(): Use JRDesignLine.
1435 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1437 ReportGenerator: Correct the title positions and use some bold style.
1439 * src/main/java/org/glom/web/server/ReportGenerator.java:
1440 Break the code up into reusable functions, correct the placement of
1441 titles, and use normal/bold styles as in the reports in the desktop
1444 2012-03-06 Murray Cumming <murrayc@murrayc.com>
1446 ReportGenerator: Add a header band to show the field titles.
1448 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1449 getReportHTML(): Pass the localeId to the ReportGenerator
1451 * src/main/java/org/glom/web/server/ReportGenerator.java
1452 constructor: Take the localeID so we can get translated field
1454 generateReport(), addToReport(), addFieldToBand(): Add field
1455 titles in a column header band.
1457 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1459 Reports drop-down list: Some improvement.
1461 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1462 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1463 Adedd setSelectedReport(),
1464 setReportList(): Add a blank line so that the user can select the
1466 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1467 start(): Show the current report by calling setSelectedReport().
1468 This does not seem to work yet.
1470 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1472 DetailsActivity, ListActivity: Move some variables into a base class.
1474 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1475 * src/main/java/org/glom/web/client/activity/HasTableActivity.java:
1476 * src/main/java/org/glom/web/client/activity/ListActivity.java: Move
1477 the clientFactory, documentID, tableName and authenticationPopup into
1478 a base class, to avoid duplication.
1480 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1482 Translate the Reports label.
1484 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1485 Get the "Reports" label string from the constants.
1486 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.pro
1487 perties: Add Reports to the constants.
1489 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1491 Reports: Implement grouping.
1493 * src/main/java/org/glom/web/server/ReportGenerator.java:
1494 Handle LayoutItem_GroupBy items and try to do the right thing
1495 with JRDesignGroup. It seems to work.
1497 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1499 Actually show some data with JasperReports.
1501 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1502 getReportHTML(): Move most code into a ReportGenerator class.
1503 * src/main/java/org/glom/web/server/ReportGenerator.java:
1504 Recurse into sub-groups, adding fields to the JasperDesign's details
1505 band. Note that we must set an arbitrary width and height, or it just
1506 will not show any data.
1508 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1510 Reports Chooser: Show the titles, not the names.
1512 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1513 (TableSelectionViewImpl.setReportList): Show the titles in the UI,
1514 and the names as the values.
1515 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1516 (ConfiguredDocument.getReportLayoutGroup): Do not return a default
1517 group now that we provide the report name, so it should always
1520 2012-02-15 Murray Cumming <murrayc@murrayc.com>
1522 Depend on jasperreports.
1524 * pom.xml: Add the dependency. My plan is to use this on the
1527 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1529 Implement navigation to report places.
1531 * src/main/java/org/glom/web/client/activity/ReportActivity.java
1532 start(): Do not bother to handle all events here.
1533 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1534 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1535 Added getSelectedReport().
1536 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1537 .java: start(): When handling a change to the reports chooser,
1538 call getSelectedReport() and goTo() its ReportPlace.
1539 * src/main/java/org/glom/web/client/ui/ReportView.java
1540 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java:
1541 Added setReportHTML() which puts the html in a gwt HTML widget.
1542 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1543 getReportHTML(): Return "TODO" just to show that this works.
1545 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1547 Make ReportPlace usable.
1549 * src/main/java/org/glom/web/client/mvp/AppPlaceHistoryMapper.java:
1550 Mention ReportPlace.
1551 * src/main/java/org/glom/web/client/place/ReportPlace.java:
1552 Correct the @prefix annotation.
1554 2012-01-31 Murray Cumming <murrayc@murrayc.com>
1556 OnlineGlomService: Return report HTML rather than the LayoutGroup.
1558 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1559 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1560 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1561 Change getReportLayout() to getReportHMTL() because we will not need to
1562 parse or render the report layout on the client side.
1563 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1564 getReportLayout(): Return the libglom LayoutGroup type because we will
1565 not need to convert to a shared type, because this will not be used on
1567 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1570 Note that there is still no implementation for this.
1573 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1575 Add a (empty) Report Place, View, and Activity.
1577 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
1579 * src/main/java/org/glom/web/client/place/HasTablePlace.java
1580 * src/main/java/org/glom/web/client/place/ListPlace.java: Move some of
1581 this into a superclass:
1582 * src/main/java/org/glom/web/client/place/HasRecordsPlace.java
1583 and also use it as the base of this new ReportPlace:
1584 * src/main/java/org/glom/web/client/place/ReportPlace.java
1586 * src/main/java/org/glom/web/client/ui/ReportView.java
1587 * src/main/java/org/glom/web/client/ui/ReportViewImpl.java
1588 * src/main/java/org/glom/web/client/activity/ReportActivity.java:
1589 Add these, containing mostly boiler-plate for now.
1591 * src/main/java/org/glom/web/client/OnlineGlomService.java
1592 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1593 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1594 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1595 Add API to get the LayoutGroup for the report.
1597 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1599 Add and fill a Reports drop-down list box.
1601 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
1603 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1604 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
1605 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1606 Added getReports(document, table, localeID), calling
1607 ConfiguredDocument.getReports().
1608 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1609 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1610 Added setReportsList() and a list widget.
1611 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1612 .java (TableSelectionActivity.fillView(): Fill the view's reports list.
1617 2012-04-12 Murray Cumming <murrayc@murrayc.com>
1619 Translations: Add Esperanto.
1621 * src/main/java/org/glom/web/OnlineGlom.gwt.xml
1622 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_eo.
1623 properties: Add this translation because someone took the time to make it.
1625 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1627 Adapt to the java-libglom 1.21.7 API.
1629 * src/main/java/org/glom/web/server/ReportGenerator.java:
1630 addToReport(): get_group_secondary_fields() is now
1631 get_secondary_fields().
1634 2012-03-15 Murray Cumming <murrayc@murrayc.com>
1636 Use the latest java-libglom version.
1638 * pom.xml: Use java-libglom 1.21.7.
1640 2012-03-03 Ben Konrath <ben@bagu.org>
1642 Display date and time in details view.
1644 https://bugzilla.gnome.org/show_bug.cgi?id=671257
1646 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1648 2012-03-05 Murray Cumming <murrayc@murrayc.com>
1650 Require the latest java-libglom.
1652 * pom.xml: java-libglom 1.21.5 has LayoutItem_GroupBy.
1654 2012-03-04 Murray Cumming <murrayc@murrayc.com>
1656 ListViewDbAccess.getSelectQuery(): Avoid using empty quickfind strings.
1658 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
1659 ListViewDBAccess.getSelectQuery(): Do not create a where clause for
1660 an empty quickfind string. I also corrected libglom to create only
1661 empty where clauses for empty quickfind strings, but this avoids the
1664 2012-02-24 Ben Konrath <ben@bagu.org>
1666 Improve the tabs in the Notebook widget.
1670 2012-01-30 Murray Cumming <murrayc@murrayc.com>
1672 Translations: Try to translate the strings.
1674 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1675 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1676 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1677 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1678 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1679 Take the Open translation from GTK+'s .po files.
1680 Take the Details translation from Glom's po files.
1681 I have added the other strings to Glom so we can get translations that way:
1682 http://git.gnome.org/browse/glom/commit/?id=c3cefe607428a84bdf8de1b04e8bef6f70b04564
1684 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1686 TableSelectionViewImpl: Put the search label and entry in a div.
1688 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1689 Put the search widgets in a FlowTable so that the CSS can be used to
1690 style them while keeping them together.
1691 * src/main/webapp/style.css: Mention the new div.
1693 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1695 Translate more strings in more locales.
1697 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1698 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
1699 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
1700 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
1701 Translate the "Details" and "Open" string too.
1703 * src/main/java/org/glom/web/OnlineGlom.gwt.xml:
1704 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1705 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_cs.properties:
1706 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_es.properties:
1707 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_sl.properties:
1708 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_zh_CN.properties:
1709 Add these new locales as placeholders though they currently contain English.
1711 2012-01-27 Murray Cumming <murrayc@murrayc.com>
1713 OnlineGlomServiceImpl: Avoid (unlikely) null object dereferences.
1715 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java: get*():
1716 Check the ConfiguredDocument* for null before using it.
1718 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1720 Tell Eclipse about the generated java files.
1722 * .classpath: This lets it find OnlineGlomConstants.java.
1723 It would be nice if Eclipse just used the maven build files.
1725 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1727 Prevent a crash when no locale is specified in the URL.
1729 * src/main/java/org/glom/web/client/Utils.java: getCurrentLocaleID():
1730 Avoid returning a null string, obtained from
1731 Window.Location.getParameter(). This caused a crash when it was
1732 later passed to libglom's API.
1733 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1734 init(), getDocumentInfo(), getListViewLayout(), getDocuments(),
1735 getDetailsLayoutAndData(): Use StringUtils.defaultString() to
1736 guard against future null strings.
1738 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1740 Use the ?locale= query param instead of the &lang= token param.
1742 * src/main/java/org/glom/web/client/place/ListPlace.java
1743 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1744 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1745 Remove the lang token key and value.
1747 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
1748 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1749 When the user selects a different locale from the chooser, use
1750 Window.Location.assign() to change the URL, which then causes a reload.
1752 * src/main/java/org/glom/web/client/Utils.java: Added getCurrentLocaleID().
1753 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1754 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java
1755 * src/main/java/org/glom/web/client/activity/ListActivity.java
1756 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1757 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
1758 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
1759 * src/main/java/org/glom/web/client/ui/ListView.java:
1760 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
1762 Remove localeID member variables and method/constructor parameters, instead
1763 using Utils.getCurrentLocaleID() when we need a localID to pass to
1766 2012-01-26 Murray Cumming <murrayc@murrayc.com>
1768 Internationalize the UI strings.
1770 * pom.xml: gwt-maven-plugin: Add the i18n goal and specify a
1771 <i18nConstantsBundle>, removing the unused <i18nMessagesBundle>.
1772 * src/main/resources/org/glom/web/client/Messages.properties: Remove this
1773 because it is unused. Messages are apparently strings that can have
1774 parameters, but we do not need that yet, so Contants will be enough for now.
1775 * src/main/java/org/glom/web/OnlineGlom.gwt.xml: Add extend-property lines
1776 to say that we support the en and de locales.
1777 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants.properties:
1778 The original English strings.
1779 * src/main/resources/org/glom/web/client/ui/OnlineGlomConstants_de.properties:
1780 Some German translations of the English strings.
1781 The i18n goal then uses the .properties file to generate an
1782 OnlineGlomConstants.java file in target/ and somehow GWT.create() magically
1783 returns an implementation that returns the translated strings.
1784 The documentation suggests putting these in src/java/*/client/, but it seems
1785 best to put it in src/resources/*/client/.
1786 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1787 Instantiate OnlineGlomConstants via GWT.create() and use it to get the strings
1788 instead of hard-coding them.
1789 Note that we cannot import OnlineGlomConstants because it does not exist yet,
1790 but that does not seem to stop the build, though it confuses Eclipse.
1792 You can see the translated string by adding ?locale=de to the URL, like so:
1793 http://127.0.0.1:8888/OnlineGlom.html?gwt.codesvr=127.0.0.1:9997?locale=de#list:document=film_manager
1795 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1797 Improve null/empty String checks.
1799 * pom.xml: Add a dependency on commons-lang, to use
1800 org.apache.commons.lang.StringUtils.
1801 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1802 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1803 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java
1804 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
1805 Use StringUtils.isEmpty().
1807 * src/main/java/org/glom/web/client/StringUtils.java: Add a tiny
1808 StringUtils class with a static isEmpty() function because we
1809 cannot use org.apache.commons.lang.StringUtils in client-side
1810 GWT code because it (apparently) cannot be compiled to javascript.
1811 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1812 * src/main/java/org/glom/web/client/activity/ListActivity.java
1813 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java
1814 * src/main/java/org/glom/web/client/place/DetailsPlace.java
1815 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
1816 * src/main/java/org/glom/web/client/place/ListPlace.java
1817 * src/main/java/org/glom/web/client/ui/cell/NumericCell.java
1818 * src/main/java/org/glom/web/client/ui/cell/TextCell.java
1819 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java
1820 * src/main/java/org/glom/web/client/ui/details/Group.java
1821 * src/main/java/org/glom/web/client/ui/details/Notebook.java: Use
1822 our StringUtils.isEmpty() function.
1824 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1826 Update to the latest java-libglom API.
1828 * pom.xml: Require java-libglom 1.21.4.
1829 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1830 getDocumentInfo(), getListViewLayoutGroup():
1831 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1833 * src/main/java/org/glom/web/server/database/DBAccess.java
1834 getFieldsToShowForSQLQueryAddGroup(),
1835 getPrimaryKeyLayoutItemField(): Replace get_database_title()
1836 with either get_database_title_original() or
1837 get_database_title(localeID).
1839 2012-01-24 Murray Cumming <murrayc@murrayc.com>
1841 ConfiguredDocument: Avoid a null pointer exception.
1843 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1844 Initialize localeID to "" to avoid returning a null String which
1845 causes a crash in java-libglom's swing-generated code.
1847 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1849 Some simple renaming.
1851 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1852 * src/main/webapp/style.css: Rename, tableChooser to tablesChooser. Likewise
1853 for localeChooser. This seems more appropriate and is less ambiguous
1854 particularly in the .css file.
1856 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1858 ConfiguredDocument: Rename the localedID private member variable.
1860 2012-01-23 Murray Cumming <murrayc@murrayc.com>
1862 Adapt to the latest java-libglom API from git master.
1864 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
1865 libglom now uses only Vector instead of List, which uses add() instead of
1868 2012-01-22 Murray Cumming <murrayc@murrayc.com>
1870 ConfiguredDocument: Rename the localedID private member variable.
1872 2012-01-20 Murray Cumming <murrayc@murrayc.com>
1874 Build a source tarball with mvn assembly:single
1876 * assembly.xml: Add this file.
1877 * pom.xml: Use the maven-assembly-plugin and tell it to use
1878 our assembly.xml file.
1880 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1882 OnlineGlomServiceImpl: Get .glom files recursively.
1884 * pom.xml: Depend on commons-io from org.apache.commons.
1885 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
1886 init(): Use org.apache.commons.io.FileUtils.listFiles() to get the
1887 files recursively, and with the easier filter for the extension.
1888 Use org.apache.commons.io.FilenameUtils.removeExtension() to
1889 simplify that code too.
1891 2012-01-19 Murray Cumming <murrayc@murrayc.com>
1893 README: Mention that you must install java-libglom packages separately.
1895 But then it works, because java-libglom is now in the central maven
1898 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1900 locales drop-down: Show the correct selected locale when the URL changes.
1902 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1903 .java: setPlace(): Move some code into fillView().
1905 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1907 locales drop-down: Do not lose the primary key.
1909 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
1910 start(): onLocaleChange(): Pass the current primary key value,
1911 instead of an empty value.
1913 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1915 locales drop-down: Do not lose the drop-down selection.
1917 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1918 .java (TableSelectionActivity.fillView): Set the selected locale
1919 after changing the drop-down items (though we do not really need
1920 to change them just because the locale changes.)
1922 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1924 locales drop-down: Change the tables list when this changes.
1926 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1927 .java: TableSelectionActivity.start(): Move the async table titles
1928 retrieval into a private fillView() method and also call this when
1929 the chosen locale changes.
1930 Note that the document title is not actually translatable yet, but
1931 that is a problem that I should fix soon in libglom.
1933 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1935 Improve the placement of the locales drop-down.
1937 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
1938 Put the title and locales drop-down in a div (gwt.FlowTable).
1939 * src/main/webapp/style.css: Add magic css properties to make this work.
1940 Also remove the left margin from the title so that it lines up with the
1943 2012-01-18 Murray Cumming <murrayc@murrayc.com>
1945 locales selector: Show human-readable locale titles.
1947 * src/main/java/org/glom/web/server/ConfiguredDocument.java
1948 getDocumentInfo(): Use java.util.Locale to show a real title of
1949 each locale, in the locale's own language.
1951 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1953 Add a language/locale selector drop-down.
1955 * src/main/java/org/glom/web/shared/DocumentInfo.java:
1956 Add getLocaleIDs(), setLocaleIDs(), getLocaleTitles(), setLocaleTitles().
1957 * /src/main/java/org/glom/web/server/ConfiguredDocument.java:
1958 getDocumentInfo(): Store the available Locales in the DocumentInfo.
1959 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1960 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1961 Add a ListBox to show the available locales. Add getLocaleSelector(),
1962 setLocaleList(), getSelectedLocale(), setSelectedLocale().
1963 * src/main/java/org/glom/web/client/event/LocaleChangeEvent.java
1964 * src/main/java/org/glom/web/client/event/LocaleChangeEventHandler.
1965 java: Add these classes.
1966 * src/main/java/org/glom/web/client/activity/TableSelectionActivity.java:
1967 start(): Fill the locales ListBox. Handle its change event, firing a
1969 setPlace(): Show the selected locale as specified by the URL token.
1970 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
1971 * src/main/java/org/glom/web/client/activity/ListActivity.java:
1972 Handle LocaleChangeEvent, going to a new *Place with that locale.
1974 The placement of the ListBox is not pretty, and it currently uses the ID
1975 as a title, instead of "English", "Deutsch", "Espanola", etc, but it
1979 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1981 Search box: Show the search text from the URL token.
1983 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
1984 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
1985 Add setQuickFindText().
1986 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
1987 .java: setPlace(): Store the queryText if the place is a ListPlace,
1988 and call TableSelectionView.setQuickFindText().
1990 2012-01-17 Murray Cumming <murrayc@murrayc.com>
1992 Allow use of translations via, for instance, &lang=de in the URL.
1994 * pom.xml: Use the unstable java-libglom 1.21 version.
1996 * src/main/java/org/glom/web/client/OnlineGlomService.java:
1997 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java
1998 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
1999 init(): Instead of calling TranslatableItem.set_current_locale()
2000 (now removed), call ConfiguredDocument.setDefaultLocaleID().
2001 However, this is only for default locales, which are not needed to
2002 change the locale in the URL.
2003 getDocumentInfo(), getListViewLayout(), getSortedListViewData(),
2004 getDetailsData(), getDetailsLayoutAndData(), getRelatedListData(),
2005 getSortedRelatedListData(): Add a localeID parameter, so we can get the
2006 layout for a particular locale.
2007 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2008 Add get/setDefaultLocaleID().
2009 getDocumentInfo(), getListViewData(), getRelatedListData(),
2010 getDetailsLayoutGroup(), getListViewLayoutGroup(),
2011 createLayoutItemPortalDTO(), convertToGWTGlomLayoutItemField(): Add a
2012 localeID parameter, so we can get the layout for a particular locale.
2014 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java:
2015 * src/main/java/org/glom/web/client/place/DetailsPlace.java:
2016 * src/main/java/org/glom/web/client/place/ListPlace.java:
2017 Parse and construct a lang parameter too.
2019 * src/main/java/org/glom/web/client/activity/DocumentSelectionActivity.java:
2020 start(): Pass the defaultLocaleID to addDocumentLink(). It is then
2021 passed to subsequent methods and constructors.
2022 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2023 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2024 Store the localeID from the *Place and pass it to other constructors
2025 and methods, such as OnlineGlomServiceAsync.getDetailsLayoutAndData().
2027 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2028 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2029 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2030 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java
2031 * src/main/java/org/glom/web/client/ui/ListView.java:
2032 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2033 Take localeID parameters and pass them to subsequent constructors and
2034 methods, so that the layout is always retrieved for that locale.
2036 This is rather repetitive.
2038 Note that "" means the original (default) locale of the Glom document,
2039 which is usually English.
2041 2012-01-17 Murray Cumming <murrayc@murrayc.com>
2043 Documents: Remove final keyword to fix startup configuration.
2045 * src/main/java/org/glom/web/shared/Documents.java: Remove the
2046 final keywords on the private member variables because that breaks
2047 the startup, apparently (there are warnings) because it stops them
2048 from being serialized. I added these in the previous commit.
2050 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2052 Documents: Add some final keywords.
2054 * src/main/java/org/glom/web/shared/Documents.java: Eclipse suggested
2057 2012-01-13 Murray Cumming <murrayc@murrayc.com>
2059 OnlineGlomServiceImpl: Add to overview comments.
2061 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2062 Note that this is where all the document are loaded. They are not
2063 loaded freshly for each page.
2065 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2069 * src/main/java/org/glom/web/client/ui/TableSelectionViewImpl.java:
2070 Add a TextBox for the text of a quick find.
2071 Add getQuickFindBox(), to get the widget, and getQuickFindText() to
2073 setBackLink(): Add a String quickFind parameter.
2074 * src/main/java/org/glom/web/client/ui/TableSelectionView.java
2075 (TableSelectionView): Add getQuickFindBox() and getQuickFindText()
2076 to the base interface, because that is how TableSelectionViewImpl is used.
2077 * src/main/webapp/style.css: Add style for the search box and its label.
2079 * src/main/java/org/glom/web/client/event/QuickFindChangeEvent.java:
2080 * src/main/java/org/glom/web/client/event/QuickFindChangeEventHandler.java:
2081 Add these files, based on the existing TableChangeEvent and
2082 TableChangeEventHandlers.
2083 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2084 start(): Handle QuickFindChangeEvent, passing its quickFind text to
2085 a ListPlace() that the user should be taken to.
2086 * src/main/java/org/glom/web/client/activity/ListActivity.java
2087 start(): Handle it here too and adapt the TableChangeEvent handler to
2088 pass the extra "" quickFind parameter to ListPlace.
2089 * src/main/java/org/glom/web/client/place/ListPlace.java:
2090 Constructor: Take an extra String quickFind parameter and store it,
2091 returning it from a new getQuickFind() method.
2092 getToken(): Put the quickFind text in the URL token.
2093 getPlace(): Parse the quickFind text from the URL token.
2094 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2095 va: addDocumentLink(): Pass an extra "" quickFind parameter to the
2096 ListPlace constructor.
2097 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2098 .java: start(): Add a Change handler for the TableSelectionView's
2099 TextBox (via its base HasChangeHandlers interface), firing the new
2100 QuickFindChangeEvent.
2101 setPlace(): Adapt the call to TableSelectionView.setbackLink(), to
2102 pass the extra "" quickFind parameter.
2104 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2105 setCellTable(): Add a String quickFind parameter and pass it to
2106 the ListViewTable() constructor.
2107 * src/main/java/org/glom/web/client/ui/ListView.java: Change
2108 setCellTable() in the base interface, because that is how ListViewImpl
2111 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2112 Add a String quickFind member variable.
2113 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2114 Constructor: Add a String quickFind parameter, storing it in the
2115 base ListTable's member variable.
2116 onRangeChanged(): Pass quickFind to the
2117 OnlineGlomServiceAsync.getSortedListViewData() and
2118 OnlineGlomServiceAsync.getListViewData() methods.
2120 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2121 getListViewData(), getSortedListViewData(): Add a String quickFind
2122 parameter, passing it to ConfiguredDocument.getListViewData().
2123 * src/main/java/org/glom/web/client/OnlineGlomService.java:
2124 Change getListViewData(), getSortedListViewData() in the base interface,
2125 because that is how OnlineGlomServiceImpl is used, via this:
2126 * src/main/java/org/glom/web/client/OnlineGlomServiceAsync.java:
2127 Change getListViewData(), getSortedListViewData() here too.
2128 This class can apparently be used to asynchronously call methods on
2129 OnlineGlomService, and GWT seems to implement that after recognizing
2130 just the *Async name convention and the extra AsyncCallback parameters.
2132 * src/main/java/org/glom/web/server/ConfiguredDocument.java
2133 getListViewData(): Add a String quickFind parameter, and pass it to
2134 ListViewDBAccess.getData().
2135 * src/main/java/org/glom/web/server/database/ListDBAccess.java
2136 getListData(): Add a String quickFind parameter and pass it to
2138 getSelectQuery(): Add a String quickFind parameter.
2139 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java
2140 getSelectQuery(): Add a String quickFind parameter and use it with
2141 Glom.get_find_where_clause_quick() to pass a where_clause to
2142 Glom.build_sql_select_with_where_clause(), to actually filter the
2144 getData(): Add a String quickFind parameter, passing it to getListData().
2145 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.ja
2146 va: getData(): Pass an empty string to getListData() for the
2147 quickFind parameter.
2149 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2151 ListTable: Minor change.
2153 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2154 createCellTable(): Make this protected instead of public.
2156 2012-01-12 Murray Cumming <murrayc@murrayc.com>
2158 Many files: Use final for the parameters and use the @override attribute.
2160 2012-01-22 Ben Konrath <ben@bagu.org>
2162 Add anchor links for single line text that starts with http, ftp and www.
2166 2012-01-22 Ben Konrath <ben@bagu.org>
2168 Add ellipsis to single line text in details view.
2172 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2174 Remove all javadoc author tags.
2176 Because they are awkward and meaningless when many people touch
2178 See https://gitorious.org/online-glom/gwt-glom/commit/7628b732cb90cbc6d5635420a75568504e8b3655#comment_81164
2180 2012-01-04 Murray Cumming <murrayc@murrayc.com>
2182 Revert the COPYING.LESSER to COPYING rename.
2184 Apparently both should be there if it is LGPL.
2186 2012-01-03 Murray Cumming <murrayc@murrayc.com>
2188 *View: Remove unused imports.
2190 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2191 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java
2192 * src/main/java/org/glom/web/client/ui/ListView.java:
2193 * src/main/java/org/glom/web/client/ui/TableSelectionView.java:
2194 Remove unused imports, as suggested by Eclipse.
2196 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2198 Move the *View::Presenter types, and some API into one base View.
2200 * src/main/java/org/glom/web/client/ui/DetailsView.java:
2201 * src/main/java/org/glom/web/client/ui/DocumentSelectionView.java:
2202 * src/main/java/org/glom/web/client/ui/ListView.java:
2203 * src/main/java/org/glom/web/client/ui/TableSelectionView.java: Move
2204 Presenter, setPresenter() and clear() into a shared base interface,
2205 to avoid the unnecessary duplicate Presenter types and to more clearly
2206 show how the *Views share the same structure, even if they are not
2207 used polymorphically.
2209 * src/main/java/org/glom/web/client/ui/DetailsViewImpl.java:
2210 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ja
2212 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2213 * src/main/java/org/glom/web/client/activity/ListActivity.java:
2214 * src/main/java/org/glom/web/client/activity/DocumentSelectionActiv
2216 * src/main/java/org/glom/web/client/activity/TableSelectionActivity
2219 Feel free to revert this if there is a good reason for the duplicate
2222 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2224 OnlineGlom: Make clientFactory a (protected) member, and test it a bit.
2226 * src/main/java/org/glom/web/client/OnlineGlom.java: Make clientFactory
2227 a class member instead of a local variable in the method.
2228 This lets us use it to get the view instances, for use in tests.
2229 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2230 beforeOnlineGlom(): Test some more details of the initial view.
2231 Again, this is not very useful.
2233 To really test gwt-glom we will need to start a local postgresql
2234 instance with local data, like the Glom tests in C++.
2236 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2238 pom.xml: Mention the LGPL license.
2240 * pom.xml: Add a licenses section.
2241 * COPYING.LESSER: Move this to COPYING, which
2242 previously contained the GPL. But gwt-glom is all LGPL.
2244 2012-01-02 Murray Cumming <murrayc@murrayc.com>
2246 Add project information to README and pom.xml.
2248 * README: Add a brief description and mention some mvn
2250 * pom.xml: This extra information shows up in mvn site
2253 2011-01-02 Murray Cumming <murrayc@murrayc.com>
2255 Use the latest java-libglom version.
2257 * pom.xml: Use java-libglom 1.19.2 instead of 1.19.1.
2259 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2261 GwtTestOnlineGlom: Test a little more.
2263 * src/main/java/org/glom/web/client/OnlineGlom.java: Make the panels
2264 protected rather than private, as suggested by the gwt-test-utils
2266 http://stackoverflow.com/questions/7931724/gwt-testcase-simulating-clicking-a-button-on-my-page
2267 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java
2268 Test the initial visibility of the panels.
2270 However, this is not a very useful test.
2271 And I wonder how we should generally test using this idea for an
2272 activity/places app like ours where the real changes happen implicitly
2273 based on the history token/URL.
2275 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2277 Slight modification to *Mapper comments.
2279 * src/main/java/org/glom/web/client/mvp/DataActivityMapper.java
2280 (DataActivityMapper)
2281 * src/main/java/org/glom/web/client/mvp/DocumentSelectionActivityMa
2283 * src/main/java/org/glom/web/client/mvp/TableSelectionActivityMappe
2285 Remove comments mentioning GIN because they are just copied from
2286 the example code and are apparently not helpful:
2287 http://groups.google.com/group/google-web-toolkit/msg/82f0098b20669a73
2288 Also change the mention of a class that is only in the example code.
2290 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2292 GwtTestOnlineGlom test: Minor changes.
2294 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2295 Avoid the long qualified class name and modify the comment
2296 because it is now obvious to me that the mocked class is the only
2297 custom one created via GWT.create().
2299 2012-01-01 Murray Cumming <murrayc@murrayc.com>
2301 Tests: Added the beginnings of a test using gwt-test-utils.
2303 * pom.xml: Add dependencies on gwt-test-utils and easymock.
2304 * src/test/resources/META-INF/gwt-test-utils.properties: Add this file
2305 which tells gwt-test-utils what class will be tested.
2306 * src/test/java/org/glom/web/client/GwtTestOnlineGlom.java:
2307 Add a simple (but empty) test case. One class, used by the OnlineGlom
2308 class, is mocked so that it can be created. However, I am not sure
2309 why only this class needs to be mocked.
2311 Note that mockito seems more popular, and clearer, than easymock,
2312 but I have not got that working yet. It might be a matter of the
2315 This test is run during mvn integration-test.
2317 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2319 Tests: Use junit4-style syntax instead of junit3-style.
2321 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2322 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2323 * src/test/java/org/glom/web/shared/DataItemTest.java:
2324 Use the @Test annotation rather than relying on the test*() prefix.
2325 Also no longer implement TestCase, to avoid triggering support for
2326 the junit3-way, which stops the annotations from working.
2327 Change the imports from import junit.framework.* to
2328 import org.junit.*, which is apparently the new way.
2330 2011-12-31 Murray Cumming <murrayc@murrayc.com>
2332 Added a test for ListPlace token parsing and creation.
2334 * src/test/java/org/glom/web/client/place/ListPlaceTest.java:
2335 This is much the same as DetailsPlaceTest.
2337 I wonder how we could test the other parts of the *Place API.
2339 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2341 DetailsPlace test: Also test getToken() and recreation via getPlace().
2343 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2344 testGetPlaceParameters(): Get the tokens from the DetailsPlace and
2345 recreate it, testing the recreated DetailsPlace for the same parameter
2348 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2350 Use the surefire-report plugin.
2352 * pom.xml: This generates a HTML report about the tests in
2353 target/site/surefire-report.html
2354 when you do mvn surefire-report:report. It seems to be popular/normal.
2356 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2358 Added a test for DetailsPlace.
2360 * src/test/java/org/glom/web/client/place/DetailsPlaceTest.java:
2361 Test the getPlace() token parsing.
2363 2011-12-30 Murray Cumming <murrayc@murrayc.com>
2365 Added a first unit test.
2367 * pom.xml: Add a test goal, and a dependency on junit in that scope.
2368 * src/test/java/org/glom/web/shared/DataItemTest.java:
2369 This is a silly test but it is just to get things started. Note that
2370 maven/junit finds the test because it looks in src/test by default.
2372 2011-12-22 Ben Konrath <ben@bagu.org>
2374 Change charsetName to "UTF-8" when replacing line breaks.
2376 JavaScript requires the charsetName to be "UTF-8". CharsetName values
2377 that work in Java (such as "UTF8") will not work when compiled to
2380 This fixes a problem with multi-line details view fields that have hard
2381 line breaks. The "License Text" field on this page demonstrates the
2384 http://onlineglom.openismus.com/OnlineGlom/#details:document=debian_repository_analyzer&table=licenses&value=197
2386 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2388 2011-12-22 Ben Konrath <ben@bagu.org>
2390 Fix another bug with related list navigation.
2392 I've tested all the navigation buttons in all of the related lists
2393 so things should be good now.
2395 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2397 2011-12-22 Ben Konrath <ben@bagu.org>
2399 Fix a crasher when refreshing the list view with the default table.
2401 This crash will also happen when loading the list view with the default
2402 table from a link or bookmark.
2404 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Go
2405 to the main document selection page when the document id hasn't been
2407 * src/main/java/org/glom/web/client/activity/ListActivity.java: Go to
2408 the main document selection page when the document id hasn't been
2410 * src/main/java/org/glom/web/client/place/DetailsPlace.java: Use empty
2411 values for the details place when the document id hasn't been set.
2412 * src/main/java/org/glom/web/client/place/ListPlace.java: Use empty
2413 values for the list place when the document id hasn't been set.
2415 2011-12-21 Ben Konrath <ben@bagu.org>
2417 Protect against NPE when glom.document.locale is not in config.
2419 This patch protects against an NPE when glom.document.locale is not in
2420 the config file. This NPE will also happen if glom.document.locale is
2423 The patch also updates the error message to display the class name when
2424 the getMessage() returns null. This was happening when the NPE was
2425 thrown and I had "Configuration Error: null". If an NPE is encountered
2426 with this patch, "Configuration Error: NullPointerException " will be
2429 This commit closes this bug:
2431 https://bugzilla.gnome.org/show_bug.cgi?id=666669
2433 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2435 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2437 Rename onlineglom.properties to onlineglom.properties.sample.
2439 * src/main/resources/onlineglom.properties: Rename to:
2440 * src/main/resources/onlineglom.properties.sample:
2441 * src/main/resources/README: And add this file explaining that people
2442 should rename it back when deploying.
2444 2011-12-20 Murray Cumming <murrayc@murrayc.com>
2446 Allow choosing the translation in the .properties file.
2448 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java
2449 init(): Read a glom.document.locale value from the configuration file
2450 and call Glom's TransatableItem::set_current_locale() method.
2451 * src/main/resources/onlineglom.properties: Add a commented-out
2452 example of this new setting.
2454 It would be better to add &lang=de_DE to the URL, but the current
2455 libglom API does not allow us to do this easily. I am working on that.
2457 2011-12-19 Murray Cumming <murrayc@murrayc.com>
2459 Avoid a crash in parsing of token parameters.
2461 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.j
2462 ava: getTokenParams(): Do not crash if a parameter has a key but no
2463 value, and ignore parameters with neither.
2465 2011-12-17 Murray Cumming <murrayc@murayc.com>
2467 History token building/handling: Improve use of token parameters.
2469 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2470 (HasSelectableTablePlace.Tokenizer): Add getTokenParams(String)
2471 and buildParamsToken(HashMap), for use by derived classes.
2472 Make the separator private because it is no longer be needed.
2473 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2474 (DetailsPlace.Tokenizer.getToken): Use buildParamsToken()
2475 instead of manual string concatenation.
2476 (DetailsPlace.Tokenizer.getPlace): Use getTokenParams() instead
2477 of hardcoded indices and awkward splitting code.
2478 * src/main/java/org/glom/web/client/place/ListPlace.java
2479 (ListPlace.Tokenizer.getToken): Use buildParamsToken()
2480 instead of manual string concatenation.
2481 (ListPlace.Tokenizer.getPlace): Use getTokenParams() instead
2482 of hardcoded indices and awkward splitting code.
2483 This should fix bug #666420
2485 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2487 Fix a Navgiation->Navigation typo in the code.
2489 * src/main/java/org/glom/web/client/activity/DetailsActivity.java
2490 Rename processNavgiation() to processNavigation().
2492 2011-12-16 Murray Cumming <murrayc@murrayc.com>
2494 Fix a seperator->separator typo in the code.
2496 * src/main/java/org/glom/web/client/place/DetailsPlace.java
2497 * src/main/java/org/glom/web/client/place/HasSelectableTablePlace.java
2498 * src/main/java/org/glom/web/client/place/ListPlace.java: Just a
2501 2011-12-15 Ben Konrath <ben@bagu.org>
2503 Cleanup some comments.
2505 * src/main/java/org/glom/web/server/OnlineGlomServiceImpl.java:
2507 2011-12-14 Ben Konrath <ben@bagu.org>
2509 Replace \n with <br/> for multiline text in the details view.
2511 Vertical scrollbars are added when needed as well.
2513 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2515 2011-12-14 Ben Konrath <ben@bagu.org>
2517 Specify the font for document selection links.
2519 * src/main/webapp/style.css:
2521 2011-12-14 Ben Konrath <ben@bagu.org>
2523 Fix bouncy CellTable while paging.
2525 This doesn't currently work with related list tables in unselected
2528 * src/main/java/org/glom/web/client/ui/list/ListTable.java
2530 2011-12-14 Ben Konrath <ben@bagu.org>
2532 Revamp the appearance of the document selection page.
2534 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.java:
2535 * src/main/java/org/glom/web/client/ui/DocumentSelectionViewImpl.ui.xml:
2536 * src/main/webapp/style.css:
2538 2011-12-13 Ben Konrath <ben@bagu.org>
2540 Set navigation button column to the smallest size possible.
2542 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2544 2011-12-13 Ben Konrath <ben@bagu.org>
2546 Change OpenButton nomenclature to NavigationButton.
2548 Using NavigtionButton makes things more generic. Classes, methods and
2549 variables have been changed.
2551 This is a rename-only refactor.
2553 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2554 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2555 * src/main/java/org/glom/web/client/ui/cell/NavigationButtonCell.java:
2556 Renamed from OpenButtonCell.
2557 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2558 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2559 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2561 2011-12-12 Ben Konrath <ben@bagu.org>
2563 Remove unnecessary String argument in RelatedListTable and ListViewTable.
2565 * src/main/java/org/glom/web/client/activity/DetailsActivity.java:
2566 * src/main/java/org/glom/web/client/ui/ListViewImpl.java:
2567 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2568 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2570 2011-12-12 Ben Konrath <ben@bagu.org>
2572 Update variable names and comments.
2574 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2575 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2577 2011-12-12 Ben Konrath <ben@bagu.org>
2579 Properly initialize numNonEmptyRows variable to zero.
2581 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2582 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java:
2584 2011-12-05 Ben Konrath <ben@bagu.org>
2586 Add latest mockup with HTML tables.
2588 Features of this mockup:
2590 -> HTML table for flowtable
2591 -> HTML table for flowtable column
2592 -> Example of how related lists would look
2593 -> Not using text entries for data items
2595 The current version of Online Glom doesn't use HTML tables for the
2598 This mockup has been sent to the glom-devel mailing list but it's good
2599 to have it here as well.
2601 * mockups/details-view-html-tables.html:
2603 2011-12-05 Ben Konrath <ben@bagu.org>
2605 Remove unnecessary getPrimaryKeyField() method.
2607 getPrimaryKeyFieldForTable(String) has been renamed to
2608 getPrimaryKeyField(String).
2610 * src/main/java/org/glom/web/server/database/DBAccess.java:
2611 * src/main/java/org/glom/web/server/database/DetailsDBAccess.java:
2612 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2614 2011-12-05 Ben Konrath <ben@bagu.org>
2616 Add string representation of TypedDataItem value to conversion error message.
2618 * src/main/java/org/glom/web/server/Utils.java: Logging the error
2619 message was extracted into its own method to avoid duplication.
2621 2011-12-05 Ben Konrath <ben@bagu.org>
2623 Add type checking to navigation primary key value creation.
2625 Create navigation primary key only if the expected type from the Glom
2626 document matches the type returned by the SQL query.
2628 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2630 2011-12-05 Ben Konrath <ben@bagu.org>
2632 Rename a couple of variables in RelatedListNavigation.
2634 This is a rename-only refactor.
2636 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2638 2011-12-05 Ben Konrath <ben@bagu.org>
2640 Move getListLayoutGroup() into getListViewLayoutGroup().
2642 This removes getListLayoutGroup(). It was only being called by
2643 getListViewLayoutGroup().
2645 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2647 2011-12-05 Ben Konrath <ben@bagu.org>
2649 Remove check for LayoutItem_Portal in list table method.
2651 This check is no longer necessary because the method isn't being used
2652 to create the LayoutItemPortal DTO.
2654 * src/main/java/org/glom/web/server/ConfiguredDocument.java:
2656 2011-12-05 Ben Konrath <ben@bagu.org>
2658 Properly support related list navigation.
2660 Navigation from the "Repository Analyzer -> Package Scans ->
2661 Dependencies" related table wasn't working because the primary key for
2662 related tables wasn't being set properly. This commit fixes the
2665 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Don't use
2666 getListLayoutGroup() to create the LayoutItemPortal DTO. This method
2667 doesn't set the primary key properly for related list tables.
2668 * src/main/java/org/glom/web/server/database/DBAccess.java: Add table
2669 name parameter to getPrimaryKeyLayoutItemField(). This makes the method
2670 useful for getting the primary key for list view tables and for related
2672 * src/main/java/org/glom/web/server/database/ListDBAccess.java:
2673 * src/main/java/org/glom/web/server/database/ListViewDBAccess.java:
2674 Move code to set the primary key for the table from the abstract
2675 ListDBAccess class to ListViewDBAccess as it's only correct for list
2677 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2678 Properly add primary key to related list tables.
2680 2011-12-02 Ben Konrath <ben@bagu.org>
2682 Properly set the horizontal alignment of fields.
2684 This fix is for both the list tables and the details view.
2686 * src/main/java/org/glom/web/server/ConfiguredDocument.java: Use
2687 LayoutItem_WithFormatting.get_formatting_used_horizontal_alignment(boolean)
2688 to set the horizontal alignment of fields.
2690 2011-12-02 Ben Konrath <ben@bagu.org>
2692 Display currency codes in the details view.
2694 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2696 2011-12-02 Ben Konrath <ben@bagu.org>
2698 Avoid duplicate JNI call.
2700 JNI is not as efficient as pure Java and this is an easy (and small)
2703 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2704 Use previously retrieved value for whereClauseToTableName instead of
2707 2011-12-02 Ben Konrath <ben@bagu.org>
2709 Rename a couple of variables in RelatedListNavigation.
2711 This is a rename-only refactor.
2713 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2715 2011-12-02 Ben Konrath <ben@bagu.org>
2717 Indicate clearly that a mismatched primary key type is a bug.
2719 * src/main/java/org/glom/web/server/Utils.java: Change log level from
2720 warning to error. Add 'This is a bug.' to message.
2722 2011-12-02 Ben Konrath <ben@bagu.org>
2724 Update / fix some comments.
2726 * src/main/java/org/glom/web/client/OnlineGlomService.java: Remove old
2728 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java: Fix
2730 * src/main/java/org/glom/web/server/database/RelatedListDBAccess.java:
2731 Fix comments. Add some TODOs.
2733 2011-12-02 Ben Konrath <ben@bagu.org>
2735 Enable navigation to details view with string primary key from related list.
2737 * src/main/java/org/glom/web/server/database/RelatedListNavigation.java:
2738 Create a text primary key value when return type of result is
2739 java.sql.Types.VARCHAR.
2741 2011-12-02 Ben Konrath <ben@bagu.org>
2743 Use checkboxes for booleans in the details view.
2745 * src/main/java/org/glom/web/client/ui/details/DetailsCell.java:
2747 2011-12-01 Ben Konrath <ben@bagu.org>
2749 Improve performance of related list height calculation.
2751 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2752 Put code to calculate the expected height in a static initializer so
2753 that that it's only called once.
2755 2011-12-01 Ben Konrath <ben@bagu.org>
2757 Show related list tables in notebooks (again).
2759 Calculate the height of the related list tables so the Notebook can be
2760 set the correct height. The height of the related list table is also needed by
2761 FlowTable to be able decide how to create the layout.
2763 * src/main/java/org/glom/web/client/ui/details/Portal.java: Calculate
2764 and set the Portal height based on the height of the related list
2765 table and the Portal container.
2766 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2767 Add method to calculate the height of the related list tables.
2768 * src/main/java/org/glom/web/client/ui/list/ListTable.java:
2769 * src/main/webapp/style.css: Add css class for Pager. This is needed to
2770 calculate the height of the Pager widget.
2772 2011-12-01 Ben Konrath <ben@bagu.org>
2774 Use CellTable API for table property instead of setting style on Element.
2776 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java:
2778 2011-12-01 Ben Konrath <ben@bagu.org>
2780 Make ListViewTable and RelatedListTable a consistent height.
2782 The tables are now a consistent height regardless of the contents of
2783 the table. A hidden button is added to empty rows to ensure that the
2784 height of these rows will match the height of rows with data.
2786 A navigation button column is now added to every table. The width of
2787 the navigation column is set to 0px when a RelatedListTable shouldn't
2788 have navigation buttons. This maintains the a consistent row height in
2789 tables that don't show the navigation buttons.
2791 * src/main/java/org/glom/web/client/activity/DetailsActivity.java: Hide
2792 navigation column when not needed.
2793 * src/main/java/org/glom/web/client/ui/ListViewImpl.java: Move method
2794 arguments for navigation button to constructor of ListViewTable.
2795 * src/main/java/org/glom/web/client/ui/cell/OpenButtonCell.java: Render
2796 hidden button for empty data rows.
2797 * src/main/java/org/glom/web/client/ui/details/RelatedListTable.java: Add method
2798 arguments for navigation button to constructor.
2799 * src/main/java/org/glom/web/client/ui/list/ListTable.java: Always
2800 create navigation buttons. Add hideNavigationButtons() method.
2801 * src/main/java/org/glom/web/client/ui/list/ListViewTable.java: Add method
2802 arguments for navigation button to constructor.
2804 2011-12-01 Ben Konrath <ben@bagu.org>
2806 Use 'visibility: hidden' in Utils.getWidgetHeight().
2808 This is better choice because hidden elements are invisible, don't
2809 respond to events and are not part of the tab order. They will,